Change in vdsm[master]: spec: Drop el6 support
automat...@ovirt.org has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Drop el6 support
..
Patch Set 5:
(6 comments)
https://gerrit.ovirt.org/#/c/40419/5/vdsm.spec.in
File vdsm.spec.in:
Line 786
Line 787
Line 788
Line 789
Line 790
I guess we don't need this vdsm-reg.init as well
Line 934
Line 935
Line 936
Line 937
Line 938
don't we need this exit 0 ?
Line 971
Line 972
Line 973
Line 974
Line 975
all this section should be removed in different patch
Line 1012
Line 1013
Line 1014
Line 1015
Line 1016
same
Line 1031
Line 1032
Line 1033
Line 1034
Line 1035
same
Line 53: %if ! 0%{?rhel} || ! 0%{fedora_koji_build}
Line 54: %global with_vhostmd 1
Line 55: %endif
Line 56:
Line 57: %global with_chown_hack 1
you can always enable it now and remove the global
Line 58:
Line 59: %global _udevrulesdir /usr/lib/udev/rules.d/
Line 60: %global _udevexecdir /usr/lib/udev/
Line 61:
--
To view, visit https://gerrit.ovirt.org/40419
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
Allon Mureinik has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
automat...@ovirt.org has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
automat...@ovirt.org has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
Allon Mureinik has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/40419/3//COMMIT_MSG Commit Message: Line 8: Line 9: Since we no longer need to package for el6, we can significantly reduce Line 10: the size of our spec file. This patch removes all the conditionals Line 11: dealing with el6, and drops all of the code dealing with sysvinit Line 12: as systemd is now available in both el7 and the supported fedoras. This patch also removes upstart scripts. That should either be documented here or done in a different patch (or not at all if it's a mistake ;-)) Line 13: Line 14: Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Line 9: Since we no longer need to package for el6, we can significantly reduce Line 10: the size of our spec file. This patch removes all the conditionals Line 11: dealing with el6, and drops all of the code dealing with sysvinit Line 12: as systemd is now available in both el7 and the supported fedoras. Line 13: Are you missing "Bug-Url: https://bugzilla.redhat.com/1206231"; ? Line 14: Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
Dima Kuznetsov has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40419/3/vdsm.spec.in File vdsm.spec.in: Line 836: # fallback to vdsmd reconfigure api - This change may be removed Line 837: # when vdsm won't support any downgrade\upgrade to versions that Line 838: # don't include vdsm-tool configure api (vdsm <= 3.3) Line 839: if [ -f "/usr/lib/systemd/systemd-vdsmd" ]; then Line 840: "/usr/lib/systemd/systemd-vdsmd" reconfigure >/dev/null 2>&1 || : > not sure about spec file syntax, is it hard to define variables? Shouldn't be, will change Line 841: fi Line 842: fi Line 843: fi Line 844: -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
Ido Barkan has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40419/3/vdsm.spec.in File vdsm.spec.in: Line 836: # fallback to vdsmd reconfigure api - This change may be removed Line 837: # when vdsm won't support any downgrade\upgrade to versions that Line 838: # don't include vdsm-tool configure api (vdsm <= 3.3) Line 839: if [ -f "/usr/lib/systemd/systemd-vdsmd" ]; then Line 840: "/usr/lib/systemd/systemd-vdsmd" reconfigure >/dev/null 2>&1 || : not sure about spec file syntax, is it hard to define variables? Line 841: fi Line 842: fi Line 843: fi Line 844: -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/107/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1653/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1435/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/881/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/890/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18422/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/881/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1653/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/890/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18422/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
automat...@ovirt.org has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1435/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 3: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/107/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/878/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/104/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/887/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1432/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1641/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18410/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 2: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1641/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 2: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18410/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 2: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/104/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/877/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/103/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/886/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1638/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1431/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18407/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 2: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/878/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 2: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1432/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 2: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/887/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
automat...@ovirt.org has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 1: Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/103/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
Dima Kuznetsov has uploaded a new change for review.
Change subject: spec: Drop el6 support
..
spec: Drop el6 support
Since we no longer need to package for el6, we can significantly reduce
the size of our spec file. This patch removes all the conditionals
dealing with el6, and drops all of the code dealing with sysvinit
as systemd is now available in both el7 and the supported fedoras.
Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560
Signed-off-by: Dima Kuznetsov
---
D init/sysvinit/Makefile.am
D init/sysvinit/respawn
D init/sysvinit/supervdsmd.init.in
D init/sysvinit/vdsmd.init.in
D init/upstart/Makefile.am
D init/upstart/supervdsmd.upstart.in
D init/upstart/vdsm-tmpfiles.upstart.in
D init/upstart/vdsmd.upstart.in
M vdsm.spec.in
9 files changed, 4 insertions(+), 862 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/40419/1
diff --git a/init/sysvinit/Makefile.am b/init/sysvinit/Makefile.am
deleted file mode 100644
index 7beba50..000
--- a/init/sysvinit/Makefile.am
+++ /dev/null
@@ -1,44 +0,0 @@
-#
-# Copyright 2008-2012 Red Hat, Inc.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-#
-# Refer to the README and COPYING files for full details of the license
-#
-
-include $(top_srcdir)/build-aux/Makefile.subs
-
-nodist_noinst_DATA = \
- supervdsmd.init \
- vdsmd.init \
- $(NULL)
-
-dist_vdsm_SCRIPTS = \
- respawn \
- $(NULL)
-
-CLEANFILES = \
- config.log \
- $(nodist_noinst_DATA) \
- $(NULL)
-
-EXTRA_DIST = \
- supervdsmd.init.in \
- vdsmd.init.in \
- $(NULL)
-
-all-local: \
- $(nodist_noinst_DATA) \
- $(NULL)
diff --git a/init/sysvinit/respawn b/init/sysvinit/respawn
deleted file mode 100755
index d13effc..000
--- a/init/sysvinit/respawn
+++ /dev/null
@@ -1,101 +0,0 @@
-#!/bin/bash -e
-
-# Copyright 2010 Red Hat, Inc. and/or its affiliates.
-# Released under GPL v2
-#
-# Author: Dan Kenigsberg
-#
-# Please contact me if something similar, but more standard, is available.
-
-MINLIFETIME=2
-MAX_THRASH_INTERVAL=30
-POST_FAIL_INTERVAL=900
-
-usage() {
-echo usage:
-echo "$0 [options] [args]"
-echo " --masterpid pidfile"
-echo " --slavepid pidfile"
-echo " --daemon"
-echo " --minlifetime seconds"
-echo " --thrash seconds"
-echo
-echo "make run, and respawn it on exit"
-exit 1
-}
-
-while [ "$1" != "${1##-}" ];
-do
- case "$1" in
---minlifetime)
-MINLIFETIME="$2"
-shift 2
-;;
---thrash)
-MAX_THRASH_INTERVAL="$2"
-shift 2
-;;
---masterpid)
-masterpidfile="$2"
-shift 2
-;;
---slavepid)
-slavepidfile="$2"
-shift 2
-;;
---daemon)
-daemonize=1
-shift
- ;;
---)
-shift
-break
-;;
-*) usage
-;;
- esac
-done
-
-if [ -z "$*" ];
-then
-usage
-fi
-
-loop() {
-local d0 d1
-local thrash_start
-
-# must use BASHPID since $$ is not updated by &
-[ ! -z "$masterpidfile" ] && echo $BASHPID > "$masterpidfile"
-d0=`date +%s`
-while true
-do
-"$@" &
-[ ! -z "$slavepidfile" ] && echo $! > "$slavepidfile"
-wait $! || :
-d1=`date +%s`
-if [ $[d1-d0] -lt "$MINLIFETIME" ];
-then
-if [[ -n "$thrash_start" ]] && \
- [[ $[d1-thrash_start] -gt "$MAX_THRASH_INTERVAL" ]]; then
-logger -t respawn -- "slave '$*' died too quickly for more
than $MAX_THRASH_INTERVAL seconds, master sleeping for $POST_FAIL_INTERVAL
seconds"
-thrash_start=
-sleep "$POST_FAIL_INTERVAL"
-else
-logger -t respawn -- "slave '$*' died too quickly, respawning
slave"
-[[ -z "$thrash_start" ]] && thrash_start=$d1
-fi
-else
-logger -t respawn -- "slave '$*' died, respawning slave"
-thrash_start=
-fi
-d0=$d1
-done
-}
-
-if [ -z "$daemonize" ];
-then
-loop "$@"
-else
-loop "$@" >/dev/null 2>/dev/null &
-fi
diff --git a/init/sysvinit/supervdsmd.init.in b/init/sysvinit/supervdsmd.init.in
deleted file mode 100755
index f3369c2..000
---
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 1: Build Started (2/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/886/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 1: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18407/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 1: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/877/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 1: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1431/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 1: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1638/ -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Drop el6 support
automat...@ovirt.org has posted comments on this change. Change subject: spec: Drop el6 support .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52bf73f539d9036fbc3468b4faf8a8d6556c9560 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
