Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-07 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 3: Code-Review+2

raise

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 4:

* #1321325::Update tracker: OK
* Set MODIFIED::bug 1321325#1321325OK

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-07 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: stomp: make sure to handle eagain
..


stomp: make sure to handle eagain

Checking asyncore documentation I noticed that we do not process recv
properly. I found that:

Note that recv() may raise socket.error with EAGAIN or EWOULDBLOCK

betterAsyncore code was based on asyncore.dispatcher so the issue was
duplicated. We need to make sure to handle errors properly. We base our
errnos on asynchat which include: EAGAIN, EALREADY, EINPROGRESS,
EWOULDBLOCK.


Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Signed-off-by: pkliczewski 
Bug-Url: https://bugzilla.redhat.com/1321325
Related-To: https://bugs.python.org/issue16133
Reviewed-on: https://gerrit.ovirt.org/56997
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-06 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-05 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 3: Verified+1

Verified by running local build

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-05 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 3:

* #1321325::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1321325::OK, public bug
* Check Product::#1321325::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-05 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/56997/2//COMMIT_MSG
Commit Message:

Line 11: 
Line 12: Note that recv() may raise socket.error with EAGAIN or EWOULDBLOCK
Line 13: 
Line 14: betterAsyncore code was based on asyncore.dispatcher so the issue was
Line 15: duplicated. We need to make sure to handle this error propely.
> Please mention we handle now the same errors handled by asynchat.
Done
Line 16: 
Line 17: 
Line 18: Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Line 19: Signed-off-by: pkliczewski 


https://gerrit.ovirt.org/#/c/56997/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 116
Line 117
Line 118
Line 119
Line 120
> In another patch we need to copy this constant into our code, we don't want
Agreed


-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/56997/2//COMMIT_MSG
Commit Message:

Line 11: 
Line 12: Note that recv() may raise socket.error with EAGAIN or EWOULDBLOCK
Line 13: 
Line 14: betterAsyncore code was based on asyncore.dispatcher so the issue was
Line 15: duplicated. We need to make sure to handle this error propely.
Please mention we handle now the same errors handled by asynchat.
Line 16: 
Line 17: 
Line 18: Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Line 19: Signed-off-by: pkliczewski 


https://gerrit.ovirt.org/#/c/56997/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 116
Line 117
Line 118
Line 119
Line 120
In another patch we need to copy this constant into our code, we don't want to 
depend on private stuff from other modules.


-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-04 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 2: Verified+1

Verification steps the same as in patch set #1

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 2:

* #1321325::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1321325::OK, public bug
* Check Product::#1321325::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-04 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/56997/1/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 94: return ''
Line 95: else:
Line 96: return data
Line 97: except socket.error as why:
Line 98: # winsock sometimes raises ENOTCONN
> you can update the doc above and say when EAGAIN is expected in few words..
Done
Line 99: if why.args[0] in (EWOULDBLOCK, EAGAIN):
Line 100: return None
Line 101: elif why.args[0] in asyncore._DISCONNECTED:
Line 102: self.handle_close()


Line 95: else:
Line 96: return data
Line 97: except socket.error as why:
Line 98: # winsock sometimes raises ENOTCONN
Line 99: if why.args[0] in (EWOULDBLOCK, EAGAIN):
> EWOULDBLOCK and EAGAIN are have the same value:
Done
Line 100: return None
Line 101: elif why.args[0] in asyncore._DISCONNECTED:
Line 102: self.handle_close()
Line 103: return ''


-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-04 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56997/1/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 95: else:
Line 96: return data
Line 97: except socket.error as why:
Line 98: # winsock sometimes raises ENOTCONN
Line 99: if why.args[0] in (EWOULDBLOCK, EAGAIN):
EWOULDBLOCK and EAGAIN are have the same value:

 >>> import errno
 >>> errno.EWOULDBLOCK
 11
 >>> errno.EAGAIN
 11

This patch may be more correct but I don't think it make any difference on 
Linux.

If you want to do this define a constant in the module for these errors, see 
asynchat._BLOCKING_IO_ERRORS.
Line 100: return None
Line 101: elif why.args[0] in asyncore._DISCONNECTED:
Line 102: self.handle_close()
Line 103: return ''


-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-04 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56997/1/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 94: return ''
Line 95: else:
Line 96: return data
Line 97: except socket.error as why:
Line 98: # winsock sometimes raises ENOTCONN
you can update the doc above and say when EAGAIN is expected in few words..
Line 99: if why.args[0] in (EWOULDBLOCK, EAGAIN):
Line 100: return None
Line 101: elif why.args[0] in asyncore._DISCONNECTED:
Line 102: self.handle_close()


-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-04 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 1: Verified+1

Verified by installing new host and seeing no communication issues.

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-04 Thread piotr . kliczewski 
Piotr Kliczewski has uploaded a new change for review.

Change subject: stomp: make sure to handle eagain
..

stomp: make sure to handle eagain

Checking asyncore documentation I noticed that we do not process recv
properly. I found that:

Note that recv() may raise socket.error with EAGAIN or EWOULDBLOCK

betterAsyncore code was based on asyncore.dispatcher so the issue was
duplicated. We need to make sure to handle this error propely.


Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Signed-off-by: pkliczewski 
Bug-Url: https://bugzilla.redhat.com/1321325
Related-To: https://bugs.python.org/issue16133
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/56997/1

diff --git a/lib/yajsonrpc/betterAsyncore.py b/lib/yajsonrpc/betterAsyncore.py
index 8ef9431..ae70824 100644
--- a/lib/yajsonrpc/betterAsyncore.py
+++ b/lib/yajsonrpc/betterAsyncore.py
@@ -20,7 +20,7 @@
 import asyncore
 import logging
 import socket
-from errno import EWOULDBLOCK
+from errno import EWOULDBLOCK, EAGAIN
 
 from vdsm.sslcompat import sslutils
 from vdsm.infra.eventfd import EventFD
@@ -96,7 +96,7 @@
 return data
 except socket.error as why:
 # winsock sometimes raises ENOTCONN
-if why.args[0] == EWOULDBLOCK:
+if why.args[0] in (EWOULDBLOCK, EAGAIN):
 return None
 elif why.args[0] in asyncore._DISCONNECTED:
 self.handle_close()


-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

2016-05-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 1:

* #1321325::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1321325::OK, public bug
* Check Product::#1321325::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches