Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-22 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


storage: Remove legacy get[Iso|Floppy]List

The legacy getIsoList and getFloppyList verbs are only used in DCs of
compatibility version 3.3 (or older), while newer DCs use the
getFileStats verb. Since these old DC levels are no longer supported
by VDSM, these verbs can safely be removed.

Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/54900
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M client/vdsClient.py
M lib/api/vdsmapi-schema.json
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/rpc/bindingxmlrpc.py
M lib/vdsm/storage/exception.py
M vdsm/API.py
M vdsm/storage/hsm.py
7 files changed, 2 insertions(+), 132 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-22 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-20 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-20 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 5: Verified+1

And now with the typo actually fixed.

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-20 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-20 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 3: Verified+1

Fixed typo in comment as noticed in Nir's review

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-20 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/54900/3/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 533: message = "Storage pool not connected"
Line 534: 
Line 535: 
Line 536: # Code 314 was used for GetIsoListError, removed in 4.18
Line 537: # Code 315 was used for GetFloppyListError, removed in 4.19
4.19?
Line 538: 
Line 539: 
Line 540: class StoragePoolAlreadyExists(StorageException):
Line 541: code = 316


-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-20 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/54900/3/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 533: message = "Storage pool not connected"
Line 534: 
Line 535: 
Line 536: # Code 314 was used for GetIsoListError, removed in 4.18
Line 537: # Code 315 was used for GetFloppyListError, removed in 4.19
> 4.19?
Typo, will fix.
Line 538: 
Line 539: 
Line 540: class StoragePoolAlreadyExists(StorageException):
Line 541: code = 316


-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-20 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread amureini 
Allon Mureinik has uploaded a new change for review.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..

storage: Remove legacy get[Iso|Floppy]List

The legacy getIsoList and getFloppyList verbs are only used in DCs of
compatibility version 3.3 or older, while newer DCs use the
getFileStats verb. Since these old DC levels are no longer supported
by VDSM, these verbs can safely be removed.

Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Signed-off-by: Allon Mureinik 
---
M client/vdsClient.py
M lib/api/vdsmapi-schema.json
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/rpc/bindingxmlrpc.py
M lib/vdsm/storage/exception.py
M vdsm/API.py
M vdsm/storage/hsm.py
7 files changed, 0 insertions(+), 134 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/54900/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index d86b7138..4e182c6 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1220,26 +1220,6 @@
 
 return 0, ''
 
-def getIsoList(self, args):
-spUUID = args[0]
-isos = self.s.getIsoList(spUUID)
-if isos['status']['code']:
-return isos['status']['code'], isos['status']['message']
-
-print('-- ISO list with proper permissions only ---')
-for entry in isos['isolist']:
-print(entry)
-return 0, ''
-
-def getFloppyList(self, args):
-spUUID = args[0]
-floppies = self.s.getFloppyList(spUUID)
-if floppies['status']['code']:
-return floppies['status']['code'], floppies['status']['message']
-for entry in floppies['isolist']:
-print(entry)
-return 0, ''
-
 def getImagesList(self, args):
 sdUUID = args[0]
 images = self.s.getImagesList(sdUUID)
@@ -2563,14 +2543,6 @@
  (' [pattern][caseSensitive]',
   'Returns files statistics from ISO domain'
   )),
-'getIsoList': (serv.getIsoList,
-   ('',
-'Returns list of all .iso images in ISO domain'
-)),
-'getFloppyList': (serv.getFloppyList,
-  ('',
-   'Returns list of all .vfd images in ISO domain'
-   )),
 'getImagesList': (serv.getImagesList,
   ('',
'Get list of all images of specific domain'
diff --git a/lib/api/vdsmapi-schema.json b/lib/api/vdsmapi-schema.json
index da58cc3..84f8832 100644
--- a/lib/api/vdsmapi-schema.json
+++ b/lib/api/vdsmapi-schema.json
@@ -6127,22 +6127,6 @@
  'returns': ['UUID']}
 
 ##
-# @StoragePool.getFloppyList:
-#
-# Get a list of all floppy disk images associated with a Storage Pool.
-#
-# @storagepoolID:  The UUID of the Storage Pool
-#
-# Returns:
-# A list of floppy disk file names
-#
-# Since: 4.10.0
-##
-{'command': {'class': 'StoragePool', 'name': 'getFloppyList'},
- 'data': {'storagepoolID': 'UUID'},
- 'returns': ['str']}
-
-##
 # @StoragePool.getDomainsContainingImage:
 #
 # Get a list of Data Storage Domains that contain an Image.
@@ -6159,25 +6143,6 @@
 {'command': {'class': 'StoragePool', 'name': 'getDomainsContainingImage'},
  'data': {'storagepoolID': 'UUID', 'imageID': 'UUID'},
  'returns': ['UUID']}
-
-##
-# @StoragePool.getIsoList:
-#
-# Get a list of all ISO images associated with a Storage Pool.
-#
-# @storagepoolID:  The UUID of the Storage Pool
-#
-# @filenameExtension:  #optional Specify an alternate file extension (the
-#  default extension used is 'iso')
-#
-# Returns:
-# A list of available files
-#
-# Since: 4.10.0
-##
-{'command': {'class': 'StoragePool', 'name': 'getIsoList'},
- 'data': {'storagepoolID': 'UUID', '*filenameExtension': 'str'},
- 'returns': ['str']}
 
 ##
 # @StoragePool.getSpmStatus:
diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 67d259f..d1880d1 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -447,9 +447,7 @@
 'StoragePool_getBackedUpVmsInfo': {'ret': 'vmlist'},
 'StoragePool_getBackedUpVmsList': {'ret': 'vmlist'},
 'StoragePool_getDomainsContainingImage': {'ret': 'domainslist'},
-'StoragePool_getFloppyList': {'ret': 'isolist'},
 'StoragePool_getInfo': {'ret': StoragePool_getInfo_Ret},
-'StoragePool_getIsoList': {'ret': 'isolist'},
 'StoragePool_getSpmStatus': {'ret': 'spm_st'},
 'StoragePool_spmStart': {'ret': 'uuid'},
 'StoragePool_upgrade': {'ret': 'upgradeStatus'},
diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py
index 10eca62..2d80a2d 100644
--- a/lib/vdsm/rpc/bindingxmlrpc.py
+++ b/lib/vdsm/rpc/bindingxmlrpc.py
@@ -815,17 +815,9 @@
 pool = API.StoragePool(spUUID)
 return pool.getBackedUpVmsList(sdUUID)
 
-def poolGetFloppyList(self, spUUID, options=None):
-

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54900/2/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 532: code = 313
Line 533: message = "Storage pool not connected"
Line 534: 
Line 535: # Code 314 no longer used
Line 536: # Code 315 no longer used
> This is not very useful. How about:
Also pep8 is not happy because it likes 2 empty lines between classes and 
comments (does not make sense but we cannot fight with pep8 gods).

20:47:29 ./lib/vdsm/storage/exception.py:538:1: E302 expected 2 blank lines, 
found 1
Line 537: 
Line 538: class StoragePoolAlreadyExists(StorageException):
Line 539: code = 316
Line 540: message = "Error creating a storage pool - pool already exists"


-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54900/2/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 532: code = 313
Line 533: message = "Storage pool not connected"
Line 534: 
Line 535: # Code 314 no longer used
Line 536: # Code 315 no longer used
This is not very useful. How about:

# Code 314 was used for GetIsoListError, removed in 4.18
Line 537: 
Line 538: class StoragePoolAlreadyExists(StorageException):
Line 539: code = 316
Line 540: message = "Error creating a storage pool - pool already exists"


-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 2: Verified+1

Added comment in the code as per Nir's review

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54900/1/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 539
Line 540
Line 541
Line 542
Line 543
> I can't see any comment there. Could you refer me to a more accurate locati
Like the comments here:
https://gerrit.ovirt.org/#/c/48871/20/lib/vdsm/exception.py


-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54900/1/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 539
Line 540
Line 541
Line 542
Line 543
> When removing exception, please leave a command about the removed exception
I can't see any comment there. Could you refer me to a more accurate location 
please?


-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 1:

(1 comment)

Simone, please check that you are not using one of the removed apis.

https://gerrit.ovirt.org/#/c/54900/1/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 539
Line 540
Line 541
Line 542
Line 543
When removing exception, please leave a command about the removed exceptions, 
see lib/vdsm/exception.py.


-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread mlipchuk 
Maor Lipchuk has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches