Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-21 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..


Patch Set 11: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4780/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5580/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/833/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5663/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-21 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..


Patch Set 11: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-21 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..


Patch Set 11: Verified+1

Thanks Petr for you patch!

-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-20 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..


Patch Set 10: Code-Review-1

(2 comments)

few nits remain.


File tests/functional/firewall.py
Line 46: '--add-interface=' + interface])
Line 47: _execCmdChecker([_FIREWALLD_BINARY.cmd, '--zone=work',
Line 48: '--add-service=dhcp'])
Line 49: except FirewallError as e:
Line 50: raise SkipTest('Failed to allow dhcp traffic in firewall 
because of' +
'+' has remained here. please add space after of.
Line 51:'%s' % e)
Line 52: 
Line 53: 
Line 54: def stopAllowingDhcp(interface):


Line 62: '--remove-service=dhcp'])
Line 63: _execCmdChecker([_FIREWALLD_BINARY.cmd, '--zone=work',
Line 64: '--remove-interface=' + interface])
Line 65: except FirewallError as e:
Line 66: raise SkipTest('Failed to remove created rules from firewall 
because'
please add a space after 'because'
Line 67:'of %s' % e)
Line 68: 
Line 69: 
Line 70: def _serviceRunning(name):


-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-19 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..


Patch Set 10: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4712/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5512/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/820/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5591/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-18 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..


Patch Set 8: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4684/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5484/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/814/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5563/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-18 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..


Patch Set 8: Code-Review-1

(1 comment)


File tests/functional/networkTests.py
Line 1581: {NETWORK_NAME: {'remove': True}},
Line 1582: {BONDING_NAME: {'remove': True}},
Line 1583: {'connectivityCheck': False})
Line 1584: 
Line 1585: @permutations([[True], [False]])
we should not forget the @cleanupNet decorator.

And if you are changing this file, how about dropping the bridged permutation? 
we should limit the number of tests due to their accumulating time.
Line 1586: @RequireVethMod
Line 1587: @ValidateRunningAsRoot
Line 1588: def testSetupNetworksAddDelDhcp(self, bridged):
Line 1589: with vethIf() as (left, right):


-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-18 Thread pbenas 
Petr Benas has posted comments on this change.

Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..


Patch Set 8:

(1 comment)


File tests/functional/networkTests.py
Line 1581: {NETWORK_NAME: {'remove': True}},
Line 1582: {BONDING_NAME: {'remove': True}},
Line 1583: {'connectivityCheck': False})
Line 1584: 
Line 1585: @permutations([[True], [False]])
I had @cleanupNet here, but It seems I had removed it unintionaly while 
rebasing while resolving confilicts in this file.
Line 1586: @RequireVethMod
Line 1587: @ValidateRunningAsRoot
Line 1588: def testSetupNetworksAddDelDhcp(self, bridged):
Line 1589: with vethIf() as (left, right):


-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-18 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..


Patch Set 9:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4694/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5494/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/816/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5573/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp

2013-11-16 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..


Patch Set 7: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4664/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5464/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_network_functional_tests/808/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5543/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/21113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Benas pbe...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches