Change in vdsm[master]: tests: making sure that after events changes all tests passes
Nir Soffer has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39031/5/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: Line 58 Line 59 Line 60 Line 61 Line 62 > whenever we run tests we should close any resources that we use. We should But we do close - in line 61 and 62. This is the same code used by xmlrpc server. If the ssl socket does not close the underlying socket, it should be solved in the ssl socket code, not here. We should not depend on dispatcher here - and same for the application, we do not call dispatcher.close() in the application. -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Piotr Kliczewski has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/39031/5/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: Line 58 Line 59 Line 60 Line 61 Line 62 > We don't use close, since we want to shutdown the socket properly. whenever we run tests we should close any resources that we use. We should not rely on stop of interpreter. Line 61: client_socket.setblocking(1) Line 62: client_socket.sendall(response) Line 63: except: Line 64: # ignore errors Line 65: pass > This is very bad, making it impossible to debug error in this code. Will remove it so we could see the errors. Line 66: Line 67: t = threading.Thread(target=run) Line 68: t.daemon = True Line 69: t.start() Line 69: t.start() Line 70: Line 71: def close(self): Line 72: if self.dispatcher is not None: Line 73: self.dispatcher.close() > How are we going to fix broken tests or code without these tracebacks?! tracebacks are there because we do not clean properly after running the test. Line 74: Line 75: Line 76: class Echo(Detector): Line 77: """ A detector echoing sent line """ Line 221: s = socket.socket() Line 222: try: Line 223: s.settimeout(self.TIMEOUT) Line 224: if use_ssl: Line 225: s = self.SSLCTX.wrapSocket(s) > I think that the reason I did not use SSLCTX it when I added these test is Let's use both. Line 226: s.connect(self.acceptor_address) Line 227: yield s Line 228: finally: Line 229: s.close() -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Nir Soffer has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39031/5/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: Line 221: s = socket.socket() Line 222: try: Line 223: s.settimeout(self.TIMEOUT) Line 224: if use_ssl: Line 225: s = self.SSLCTX.wrapSocket(s) > Done I think that the reason I did not use SSLCTX it when I added these test is I was trying to simulate real connections, where client and server are *not* sharing the same ssl context. So this change is not needed. Line 226: s.connect(self.acceptor_address) Line 227: yield s Line 228: finally: Line 229: s.close() -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Nir Soffer has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/39031/5/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: Line 58 Line 59 Line 60 Line 61 Line 62 > socket is closed in close method so we do not need to do it many times. We don't use close, since we want to shutdown the socket properly. Both the xmlrpc and jsonrpc servers do not use the dispatcher, and do not call dispatcher.close() - why should these tests do this? Line 61: client_socket.setblocking(1) Line 62: client_socket.sendall(response) Line 63: except: Line 64: # ignore errors Line 65: pass This is very bad, making it impossible to debug error in this code. If the client socket was closed, I want to see errors here in the test log. Line 66: Line 67: t = threading.Thread(target=run) Line 68: t.daemon = True Line 69: t.start() Line 69: t.start() Line 70: Line 71: def close(self): Line 72: if self.dispatcher is not None: Line 73: self.dispatcher.close() > My aim here is to get rid of stack traces when the tests are done. If any o How are we going to fix broken tests or code without these tracebacks?! Line 74: Line 75: Line 76: class Echo(Detector): Line 77: """ A detector echoing sent line """ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Piotr Kliczewski has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: (5 comments) https://gerrit.ovirt.org/#/c/39031/5/tests/protocoldetectorTests.py File tests/protocoldetectorTests.py: Line 69: t.start() Line 70: Line 71: def close(self): Line 72: if self.dispatcher is not None: Line 73: self.dispatcher.close() > Why do we care about closing dispatcher? we just removed it from event loop My aim here is to get rid of stack traces when the tests are done. If any of the tests fails there is bunch of stack traces printed to the console. If all are OK we do not see them. Line 74: Line 75: Line 76: class Echo(Detector): Line 77: """ A detector echoing sent line """ Line 111: def tearDown(self): Line 112: if self.acceptor: Line 113: self.acceptor.stop() Line 114: for detector in self.detectors: Line 115: detector.close() > Why do we care about closing detectors? As above. Line 116: Line 117: # Testing Line 118: Line 119: def test_reject_ssl_accept_error(self): https://gerrit.ovirt.org/#/c/39031/5/tests/scheduleTests.py File tests/scheduleTests.py: Line 93 Line 94 Line 95 Line 96 Line 97 > This tests were never broken - I wonder why commit 1db6e0419d6af marking th I have seen it many times that on slower machines this test always failed. Line 98: def test_cancel_call_many(self, clock): Line 99: self.create_scheduler(clock) Line 100: # we do not care for this test Line 101: # on slower machines tasks can be run Line 102: delay = 10 > Why delay of 0.3 is too small? 10 seconds delay seems way too much. Looks l Response is on previous version tab Line 103: tasks = [] Line 104: for i in range(self.MAX_TASKS): Line 105: task = Task(clock) Line 106: call = self.scheduler.schedule(delay, task) Line 126: def test_stop_scheduler_many(self, clock): Line 127: self.create_scheduler(clock) Line 128: # we do not care for this test Line 129: # on slower machines tasks can be run Line 130: delay = 10 > Same Response is on previous version tab Line 131: tasks = [] Line 132: for i in range(self.MAX_TASKS): Line 133: task = Task(clock) Line 134: call = self.scheduler.schedule(delay, task) -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Piotr Kliczewski has posted comments on this change.
Change subject: tests: making sure that after events changes all tests passes
..
Patch Set 5:
(4 comments)
https://gerrit.ovirt.org/#/c/39031/5//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-03-23 10:00:39 +0100
Line 4: Commit: pkliczewski
Line 5: CommitDate: 2015-04-03 09:47:56 +0200
Line 6:
Line 7: tests: making sure that after events changes all tests passes
> How event changes effect protocol detector and scheduler?!
I noticed the failure when working on events so at least wanted to fix them.
Will update the message to make it more meaningful.
Line 8:
Line 9: Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80
https://gerrit.ovirt.org/#/c/39031/5/tests/protocoldetectorTests.py
File tests/protocoldetectorTests.py:
Line 58
Line 59
Line 60
Line 61
Line 62
> Whats wrong with shutting down and closing the socket?
socket is closed in close method so we do not need to do it many times.
Line 221: s = socket.socket()
Line 222: try:
Line 223: s.settimeout(self.TIMEOUT)
Line 224: if use_ssl:
Line 225: s = self.SSLCTX.wrapSocket(s)
> This change makes sense, please separate it to another patch.
Done
Line 226: s.connect(self.acceptor_address)
Line 227: yield s
Line 228: finally:
Line 229: s.close()
https://gerrit.ovirt.org/#/c/39031/5/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:
Line 216:
Line 217: def stop(self):
Line 218: self.log.debug("Stopping Acceptor")
Line 219: self._reactor.stop()
Line 220: self._acceptor.close()
> This makes sense, please separate to another patch.
Done
Line 221:
Line 222:
Line 223: class _CannotDetectProtocol(Exception):
Line 224: pass
--
To view, visit https://gerrit.ovirt.org/39031
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Nir Soffer has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39031/5/tests/scheduleTests.py File tests/scheduleTests.py: Line 93 Line 94 Line 95 Line 96 Line 97 This tests were never broken - I wonder why commit 1db6e0419d6af marking them as broken was merged without consulting the author of this code. -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Nir Soffer has posted comments on this change.
Change subject: tests: making sure that after events changes all tests passes
..
Patch Set 5: Code-Review-1
(8 comments)
https://gerrit.ovirt.org/#/c/39031/5//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-03-23 10:00:39 +0100
Line 4: Commit: pkliczewski
Line 5: CommitDate: 2015-04-03 09:47:56 +0200
Line 6:
Line 7: tests: making sure that after events changes all tests passes
How event changes effect protocol detector and scheduler?!
Line 8:
Line 9: Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80
https://gerrit.ovirt.org/#/c/39031/5/tests/protocoldetectorTests.py
File tests/protocoldetectorTests.py:
Line 58
Line 59
Line 60
Line 61
Line 62
Whats wrong with shutting down and closing the socket?
Line 69: t.start()
Line 70:
Line 71: def close(self):
Line 72: if self.dispatcher is not None:
Line 73: self.dispatcher.close()
Why do we care about closing dispatcher? we just removed it from event loop,
and we are shutting down and closing the client_socket as we should.
Line 74:
Line 75:
Line 76: class Echo(Detector):
Line 77: """ A detector echoing sent line """
Line 111: def tearDown(self):
Line 112: if self.acceptor:
Line 113: self.acceptor.stop()
Line 114: for detector in self.detectors:
Line 115: detector.close()
Why do we care about closing detectors?
Line 116:
Line 117: # Testing
Line 118:
Line 119: def test_reject_ssl_accept_error(self):
Line 221: s = socket.socket()
Line 222: try:
Line 223: s.settimeout(self.TIMEOUT)
Line 224: if use_ssl:
Line 225: s = self.SSLCTX.wrapSocket(s)
This change makes sense, please separate it to another patch.
Line 226: s.connect(self.acceptor_address)
Line 227: yield s
Line 228: finally:
Line 229: s.close()
https://gerrit.ovirt.org/#/c/39031/5/tests/scheduleTests.py
File tests/scheduleTests.py:
Line 98: def test_cancel_call_many(self, clock):
Line 99: self.create_scheduler(clock)
Line 100: # we do not care for this test
Line 101: # on slower machines tasks can be run
Line 102: delay = 10
Why delay of 0.3 is too small? 10 seconds delay seems way too much. Looks like
you are not fixing the root cause here, but hiding its effects.
Line 103: tasks = []
Line 104: for i in range(self.MAX_TASKS):
Line 105: task = Task(clock)
Line 106: call = self.scheduler.schedule(delay, task)
Line 126: def test_stop_scheduler_many(self, clock):
Line 127: self.create_scheduler(clock)
Line 128: # we do not care for this test
Line 129: # on slower machines tasks can be run
Line 130: delay = 10
Same
Line 131: tasks = []
Line 132: for i in range(self.MAX_TASKS):
Line 133: task = Task(clock)
Line 134: call = self.scheduler.schedule(delay, task)
https://gerrit.ovirt.org/#/c/39031/5/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:
Line 216:
Line 217: def stop(self):
Line 218: self.log.debug("Stopping Acceptor")
Line 219: self._reactor.stop()
Line 220: self._acceptor.close()
This makes sense, please separate to another patch.
Line 221:
Line 222:
Line 223: class _CannotDetectProtocol(Exception):
Line 224: pass
--
To view, visit https://gerrit.ovirt.org/39031
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17455/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17629/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Piotr Kliczewski has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: Verified+1 Verified by running local build on f20. -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
automat...@ovirt.org has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17629/ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17455/ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Piotr Kliczewski has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 4: Verified+1 Verified locally and by jenkins (schema validation failed the build). No issues with tests spotted. -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17078/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17252/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 4: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17252/ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 4: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17078/ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
automat...@ovirt.org has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17075/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17249/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 3: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17249/ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17075/ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
automat...@ovirt.org has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17046/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17220/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17220/ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17046/ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
automat...@ovirt.org has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17006/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17180/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17180/ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17006/ -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Piotr Kliczewski has uploaded a new change for review. Change subject: tests: making sure that after events changes all tests passes .. tests: making sure that after events changes all tests passes Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Signed-off-by: pkliczewski --- M tests/protocoldetectorTests.py M tests/scheduleTests.py 2 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/39031/1 diff --git a/tests/protocoldetectorTests.py b/tests/protocoldetectorTests.py index 8ef1582..4350e8d 100644 --- a/tests/protocoldetectorTests.py +++ b/tests/protocoldetectorTests.py @@ -58,8 +58,9 @@ client_socket.setblocking(1) client_socket.sendall(response) finally: -client_socket.shutdown(socket.SHUT_RDWR) -client_socket.close() +if client_socket is not None: +client_socket.shutdown(socket.SHUT_RDWR) +client_socket.close() t = threading.Thread(target=run) t.daemon = True diff --git a/tests/scheduleTests.py b/tests/scheduleTests.py index 4a5e52f..2774dda 100644 --- a/tests/scheduleTests.py +++ b/tests/scheduleTests.py @@ -24,7 +24,7 @@ from vdsm import schedule from vdsm import utils from testlib import VdsmTestCase -from testValidation import slowtest, brokentest +from testValidation import slowtest from testlib import permutations, expandPermutations @@ -94,7 +94,6 @@ task.wait(delay + self.GRACETIME) self.assertEquals(task.call_time, None) -@brokentest @permutations(PERMUTATIONS) def test_cancel_call_many(self, clock): self.create_scheduler(clock) @@ -121,7 +120,6 @@ task.wait(delay + self.GRACETIME) self.assertEquals(task.call_time, None) -@brokentest @permutations(PERMUTATIONS) def test_stop_scheduler_many(self, clock): self.create_scheduler(clock) -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
automat...@ovirt.org has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
