Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/543/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/920/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/957/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/539/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/955/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/552/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/97/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/97/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/29/ : 0 -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: Build Started (9/9) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/29/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/955/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/97/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/552/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/97/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/539/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/853/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/862/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1407/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/92/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18217/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1447/ : 0 -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/920/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/543/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/853/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/957/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1407/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/862/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/92/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. tool: Remove leftover libvirtd.log rotating logic. Vdsm libvirt logging definitions were recently dropped in favor of libvirt defaults[1]. It is now up to libvirt to manage logging, rotating included. libvirt.logrotate is a file installed by libvirt's rpm and then modified by vdsm-tool. we need to stop modifying it, and drop modifications when libvirtd.conf updates to include [1] - When we have a version bump. [1] http://gerrit.ovirt.org/#/q/I251c2534d3284aa95bffa56143c449d5de887008,n,z Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149757 Signed-off-by: Mooli Tayer Signed-off-by: Yaniv Bronhaim Reviewed-on: https://gerrit.ovirt.org/33925 Reviewed-by: Dan Kenigsberg --- M debian/vdsm.install M lib/vdsm/tool/Makefile.am M lib/vdsm/tool/configurators/libvirt.py D lib/vdsm/tool/libvirtd.logrotate M tests/Makefile.am M tests/toolTests.py D tests/toolTests_libvirt_logrotate.conf M vdsm.spec.in M vdsm/Makefile.am D vdsm/vdsm-libvirt-logrotate 10 files changed, 0 insertions(+), 102 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
automat...@ovirt.org has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 5: * Update tracker::#1149757::OK * Check TR::#1149757::ERROR, 3.6.0 should not match .* -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
Dan Kenigsberg has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
Yaniv Bronhaim has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (2/6) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1447/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: -Verified Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18217/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/853/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1398/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/83/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18192/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1422/ : 0 -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (6/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/853/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (5/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/844/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (4/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/83/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (3/6) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1398/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: -Verified Build Started (1/6) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18192/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (2/6) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1422/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
mooli tayer has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/33925/3/vdsm.spec.in File vdsm.spec.in: Line 1074 Line 1075 Line 1076 Line 1077 Line 1078 > mistake? Don't think so. I think only bvirtd.logrotate would go to that lib, and build would fail with it. -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1337/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17800/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/780/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1325/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/8/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17629/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (4/7) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17629/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (5/7) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1325/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
automat...@ovirt.org has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: * Update tracker::#1149757::OK * Check Bug-Url::OK * Check Public Bug::#1149757::OK, public bug * Check Product::#1149757::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (3/7) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/780/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (2/7) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc22_created/8/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (6/7) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/771/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (1/7) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17800/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 4: Build Started (7/7) -> http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1337/ -- To view, visit https://gerrit.ovirt.org/33925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
automat...@ovirt.org has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 3: * Update tracker::#1149757::OK * Check Bug-Url::OK * Check Public Bug::#1149757::OK, public bug * Check Product::#1149757::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/33925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: Remove leftover libvirtd.log rotating logic.
..
Patch Set 3: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/33925/3/debian/vdsm.prerm
File debian/vdsm.prerm:
Line 36
Line 37
Line 38
Line 39
Line 40
do we need all this section in debian?? we moved it to the configurator...
please remove it all in seperate patch. the sasl set should stay until having
it as well as configurator
http://gerrit.ovirt.org/#/c/33925/3/vdsm.spec.in
File vdsm.spec.in:
Line 1074
Line 1075
Line 1076
Line 1077
Line 1078
mistake?
Line 1363: %{_datadir}/%{vdsm_name}/tests/run_tests.sh
Line 1364: %{_datadir}/%{vdsm_name}/tests/tc_filter_show.out
Line 1365: %{_datadir}/%{vdsm_name}/tests/toolTests_empty.conf
Line 1366: %{_datadir}/%{vdsm_name}/tests/toolTests_lconf_ssl.conf
Line 1367: %{_datadir}/%{vdsm_name}/tests/toolTests_libvirt_logrotate.conf
this should be removed as well I guess.. and all the related tests
Line 1368: %{_datadir}/%{vdsm_name}/tests/toolTests_libvirtd.conf
Line 1369: %{_datadir}/%{vdsm_name}/tests/toolTests_qemu_sanlock.conf
Line 1370: %{_datadir}/%{vdsm_name}/tests/toolTests_qemu_ssl.conf
Line 1371: %{_datadir}/%{vdsm_name}/tests/toolTests_vdsm_no_ssl.conf
--
To view, visit http://gerrit.ovirt.org/33925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15277/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15108/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14320/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/884/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/343/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/901/ : FAILURE -- To view, visit http://gerrit.ovirt.org/33925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
mooli tayer has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 2: I am considering what to do upon upgrade. -- To view, visit http://gerrit.ovirt.org/33925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
mooli tayer has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 2: Tested on fe20, ps libvirt-daemon installs a log rotate for a non existent file: $ sudo rpm -qf /etc/logrotate.d/libvirtd libvirt-daemon-1.1.3.8-1.fc20.x86_64 but it is has "missingok" -- To view, visit http://gerrit.ovirt.org/33925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/227/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/232/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13635/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14592/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/792/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14424/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/775/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
mooli tayer has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33925/1/lib/vdsm/tool/Makefile.am File lib/vdsm/tool/Makefile.am: Line 20 Line 21 Line 22 Line 23 Line 24 > you sure we don't need toolfilesdir? anyway this unrelated.. it was added in [1] and only needed for libvirtd.logrotate. did find other occurrences. [1] http://gerrit.ovirt.org/#/c/27298/31/lib/vdsm/tool/Makefile.am,cm http://gerrit.ovirt.org/#/c/33925/1/vdsm.spec.in File vdsm.spec.in: Line 1014 Line 1015 Line 1016 Line 1017 Line 1018 > why is that related? There was one thing in this directory: libvirtd.logrotate -- To view, visit http://gerrit.ovirt.org/33925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
Yaniv Bronhaim has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33925/1/lib/vdsm/tool/Makefile.am File lib/vdsm/tool/Makefile.am: Line 20 Line 21 Line 22 Line 23 Line 24 you sure we don't need toolfilesdir? anyway this unrelated.. http://gerrit.ovirt.org/#/c/33925/1/vdsm.spec.in File vdsm.spec.in: Line 1014 Line 1015 Line 1016 Line 1017 Line 1018 why is that related? -- To view, visit http://gerrit.ovirt.org/33925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: tool: Remove leftover libvirtd.log rotating logic. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12839/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11891/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/458/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/441/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12682/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tool: Remove leftover libvirtd.log rotating logic.
mooli tayer has uploaded a new change for review.
Change subject: tool: Remove leftover libvirtd.log rotating logic.
..
tool: Remove leftover libvirtd.log rotating logic.
Vdsm libvirt logging definitions were recently dropped in
favor of libvirt defaults[1]. It is now up to libvirt to
manage logging, rotating included.
[1] http://gerrit.ovirt.org/#/q/I251c2534d3284aa95bffa56143c449d5de887008,n,z
Change-Id: I08e005c2fdd874941abd5dea7d30b3955cadde20
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149757
Signed-off-by: Mooli Tayer
---
M debian/vdsm.prerm
M lib/vdsm/tool/Makefile.am
M lib/vdsm/tool/configurators/libvirt.py
D lib/vdsm/tool/libvirtd.logrotate
M tests/Makefile.am
M tests/toolTests.py
D tests/toolTests_libvirt_logrotate.conf
M vdsm.spec.in
M vdsm/Makefile.am
D vdsm/vdsm-libvirt-logrotate
10 files changed, 0 insertions(+), 103 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/33925/1
diff --git a/debian/vdsm.prerm b/debian/vdsm.prerm
index 596c5be..dfc54a6 100644
--- a/debian/vdsm.prerm
+++ b/debian/vdsm.prerm
@@ -31,12 +31,9 @@
/etc/default/libvirt-bin \
/etc/libvirt/libvirtd.conf \
/etc/libvirt/qemu.conf \
- /etc/logrotate.d/libvirtd \
/etc/sysctl.conf \
/etc/default/sanlock
-# Restoring backuped logrotate.d/libvirtd
-sed -i -e 's/# VDSM backup//' /etc/logrotate.d/libvirtd
vdsm-tool sebool-unconfig || :
saslpasswd2 -p -a libvirt -d vdsm@ovirt
;;
diff --git a/lib/vdsm/tool/Makefile.am b/lib/vdsm/tool/Makefile.am
index a181617..94059ce 100644
--- a/lib/vdsm/tool/Makefile.am
+++ b/lib/vdsm/tool/Makefile.am
@@ -21,12 +21,6 @@
include $(top_srcdir)/build-aux/Makefile.subs
-toolfilesdir=$(pkgdatadir)/tool
-
-dist_toolfiles_DATA= \
-libvirtd.logrotate \
-$(NULL)
-
EXTRA_DIST = \
load_needed_modules.py.in \
validate_ovirt_certs.py.in \
diff --git a/lib/vdsm/tool/configurators/libvirt.py
b/lib/vdsm/tool/configurators/libvirt.py
index 5d15de2..63e5ff6 100644
--- a/lib/vdsm/tool/configurators/libvirt.py
+++ b/lib/vdsm/tool/configurators/libvirt.py
@@ -257,17 +257,6 @@
for key, val in configuration.items():
conff.addEntry(key, val)
-def _prefixAndPrepend(self, content, vdsmConfiguration):
-"""
-Prefix each line with a comment and prepend a section
-from file path defined by 'content["prependFile"]'
-"""
-with self._openConfig(content['path']) as conf:
-conf.prefixLines()
-
-with open(self._getFile(content['prependFile'])) as src_conf:
-conf.prependSection(src_conf.read())
-
def _removeFile(self, content, vdsmConfiguration):
"""
delete a file if it exists.
@@ -280,15 +269,6 @@
except OSError as e:
if e.errno != errno.ENOENT:
raise
-
-def _unprefixAndRemoveSection(self, path):
-"""
-undo changes done by _prefixAndPrepend.
-"""
-if os.path.exists(path):
-with self._openConfig(path) as conff:
-conff.removeConf()
-conff.unprefixLines()
def _removeSection(self, path):
"""
@@ -475,29 +455,6 @@
}
]
},
-
-'LRCONF': {
-'path': os.path.join(
-constants.SYSCONF_PATH,
-'logrotate.d/libvirtd',
-),
-'configure': _prefixAndPrepend,
-'prependFile': 'LRCONF_EXAMPLE',
-'removeConf': _unprefixAndRemoveSection,
-'persisted': True,
-},
-
-'LRCONF_EXAMPLE': {
-'path': os.path.join(
-constants.P_VDSM,
-'tool',
-'libvirtd.logrotate',
-),
-'configure': lambda x, y, z: True,
-'removeConf': lambda x, y: True,
-'persisted': False,
-},
-
'QNETWORK': {
'path': os.path.join(
diff --git a/lib/vdsm/tool/libvirtd.logrotate b/lib/vdsm/tool/libvirtd.logrotate
deleted file mode 100644
index 8d9dfd8..000
--- a/lib/vdsm/tool/libvirtd.logrotate
+++ /dev/null
@@ -1,10 +0,0 @@
-/var/log/libvirt/libvirtd.log {
-rotate 100
-missingok
-copytruncate
-size 15M
-compress
-compresscmd /usr/bin/xz
-uncompresscmd /usr/bin/unxz
-compressext .xz
-}
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 449d7b1..39299fb 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -128,7 +128,6 @@
tc_filter_show.out \
toolTests_empty.conf \
toolTests_lconf_ssl.conf \
- toolTests_libvirt_logrotate.conf \
toolTests_libvirtd.conf \
toolTests_qemu_sanlock.conf \
toolTests_qemu_ssl.conf \
diff --git a/tests/toolTests.py b/
