Change in vdsm[master]: v2v: additional info for disk and network
automat...@ovirt.org has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
automat...@ovirt.org has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
automat...@ovirt.org has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
automat...@ovirt.org has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/628/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/227/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4611/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/604/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/231/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/629/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/231/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/217/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/624/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6450/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: additional info for disk and network
..
v2v: additional info for disk and network
disk now return type ('disk', 'cdrom' etc)
network now return type ('e1000', 'rtl' etc)
Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Signed-off-by: Shahar Havivi shah...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/37655
Tested-by: Shahar Havivi shav...@redhat.com
Reviewed-by: Francesco Romani from...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/v2v.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Verified
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15565/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14763/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15734/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/541/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Shahar Havivi has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/37655/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 132: params['disks'] = []
Line 133: disks = root.findall('.//disk[@type=file]')
Line 134: for disk in disks:
Line 135: d = {}
Line 136: if disk.get('device') is not None:
let's just use
Done
Line 137: d['type'] = disk.get('device')
Line 138: target = disk.find('./target/[@dev]')
Line 139: if target is not None:
Line 140: d['dev'] = target.get('dev')
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Shahar Havivi has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Francesco Romani has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 3: Code-Review+1 thanks for the updates! -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Francesco Romani has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 2: Code-Review-1
(1 comment)
'd' and 'i' are too terse names. It is not only matter of taste, using such
short names makes looking for identifiers unneededly harder
(I can make an exception for loop variables, but that's my pet peeve as C coder)
But that's stuff for later patches, if any. One minor comment inside, shoulde
be quick and easy to fix. Other than that, looks good.
http://gerrit.ovirt.org/#/c/37655/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 132: params['disks'] = []
Line 133: disks = root.findall('.//disk[@type=file]')
Line 134: for disk in disks:
Line 135: d = {}
Line 136: if disk.get('device') is not None:
let's just use
device = disk.get('device')
if device is not None:
d['type'] = device
to be consistent with the surrounding code (and equally correct)
Line 137: d['type'] = disk.get('device')
Line 138: target = disk.find('./target/[@dev]')
Line 139: if target is not None:
Line 140: d['dev'] = target.get('dev')
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: additional info for disk and network
..
v2v: additional info for disk and network
disk now return type ('disk', 'cdrom' etc)
network now return type ('e1000', 'rtl' etc)
Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Signed-off-by: Shahar Havivi shah...@redhat.com
---
M vdsm/v2v.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/37655/1
diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index 46596c9..26d2490 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -133,6 +133,7 @@
disks = root.findall('.//disk[@type=file]')
for disk in disks:
d = {}
+d['type'] = disk.get('device')
target = disk.find('./target/[@dev]')
if target is not None:
d['dev'] = target.get('dev')
@@ -158,4 +159,7 @@
target = iface.find('./target/[@dev]')
if target is not None:
i['dev'] = target.get('dev')
+model = iface.find('./model/[@type]')
+if model is not None:
+i['model'] = model.get('type')
params['networks'].append(i)
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Shahar Havivi has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14718/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15690/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/496/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37655/1/vdsm/v2v.py
File vdsm/v2v.py:
Line 132: params['disks'] = []
Line 133: disks = root.findall('.//disk[@type=file]')
Line 134: for disk in disks:
Line 135: d = {}
Line 136: d['type'] = disk.get('device')
Can 'device' ever be missing? We do NOT want to report None values over xmlrpc
Line 137: target = disk.find('./target/[@dev]')
Line 138: if target is not None:
Line 139: d['dev'] = target.get('dev')
Line 140: source = disk.find('./source/[@file]')
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Shahar Havivi has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37655/1/vdsm/v2v.py
File vdsm/v2v.py:
Line 132: params['disks'] = []
Line 133: disks = root.findall('.//disk[@type=file]')
Line 134: for disk in disks:
Line 135: d = {}
Line 136: d['type'] = disk.get('device')
Can 'device' ever be missing? We do NOT want to report None values over xml
No,
But I will add a check
Line 137: target = disk.find('./target/[@dev]')
Line 138: if target is not None:
Line 139: d['dev'] = target.get('dev')
Line 140: source = disk.find('./source/[@file]')
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Shahar Havivi has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15524/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14721/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15693/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/499/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
