Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/14237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Guglielmi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Vinzenz Feenstra 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/14237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Guglielmi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11: Code-Review-1

not needed anymore due to built-in hostdev support

-- 
To view, visit https://gerrit.ovirt.org/14237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Guglielmi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Itamar Heim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[iheim]

Itamar Heim has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11:

ping

-- 
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[iheim]

Itamar Heim has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11:

ping

-- 
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11:

David, I'm not sure I understand your question (and sorry for not having 
noticed it for so long). If you suggest to fix the issue that I pointed in too 
different patches, by all means please do so! First fix it in the current code, 
and then add your improvements (my preference), or the other way around.

-- 
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/14237/11/vdsm_hooks/hostusb/before_vm_start.py
File vdsm_hooks/hostusb/before_vm_start.py:

Line 133: sys.stderr.write('hostusb: bad input, 
expected '
Line 134:  '000 format for bus and 
device '
Line 135:  'id, input: %s:%s\n' %
Line 136:  (fbusid, fphydevid))
Line 137: sys.exit(2)
the orginal code already had it, but this patch makes it worse by adding more 
exit(2). The code should raise an exception on error, that should be handled 
once  in the except block.

I would be grateful if the code is transformed to current standard of hook 
writing, with a main() function and a test() function. See recently accepted 
http://gerrit.ovirt.org/#/c/22178/11/vdsm_hooks/spiceoptions/before_vm_start.py
Line 138: 
Line 139: elif not usefilter:
Line 140: vendorid, productid = usb.split(':')
Line 141: 


-- 
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[iheim]

Itamar Heim has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11:

ping

-- 
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[iheim]

Itamar Heim has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11:

ping?

-- 
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11:

(2 comments)


File vdsm_hooks/hostusb/after_vm_destroy.py
Line 67: usefilter = False
Line 68: 
Line 69: for usb in os.environ['hostusb'].split(''):
Line 70: 
Line 71: if usb.find('@') != -1:
I have a preference for

'@' in usb
Line 72: usbvp, filter = usb.split('@')
Line 73: vendorid, productid = usbvp.split(':')
Line 74: fbusid, fphydevid = filter.split(':')
Line 75: usefilter = True



File vdsm_hooks/hostusb/before_vm_start.py
Line 121: devices = domxml.getElementsByTagName('devices')[0]
Line 122: 
Line 123: for usb in os.environ['hostusb'].split(''):
Line 124: 
Line 125: if usb.find('@') != -1:
same here imo better '@' in usb
Line 126: usbvp, filter = usb.split('@')
Line 127: vendorid, productid = usbvp.split(':')
Line 128: fbusid, fphydevid = filter.split(':')
Line 129: usefilter = True


-- 
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[iheim]

Itamar Heim has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11:

ping?

-- 
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 11:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2720/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1908/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2794/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 6: Fails; I would prefer that you didn't submit this

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2697/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1885/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2771/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 7: Fails; I would prefer that you didn't submit this

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2698/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1886/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2772/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 8: Fails; I would prefer that you didn't submit this

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2699/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1887/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2773/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 9: Fails; I would prefer that you didn't submit this

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2700/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1888/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2774/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 10:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2701/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1889/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2775/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[asegurap]

Antoni Segura Puimedon has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 5: Looks good to me, but someone else must approve

Thanks a lot David for the patch to add support for multiple devices. The 
current hook suffers from concurrency issues when two VM use the hook since the 
ownership log is not locked and it is global per all the usb devices controlled 
by the hook.

It should be improved in a later patch following the approach that the sr-iov 
hook has to handle multiple devices. For the moment, I feel that we can 
probably take this in as a step towards a better hostusb hook.

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[asegurap]

Antoni Segura Puimedon has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 5:

One thing I would want to submit also for consideration for a further patch, 
now that this patch will pass through all the devices with the same vendor and 
product id to a host is:

Do we want to potentially redefine the custom property so the hook can be 
called with optional info specifying only a subset (by bus and dev addr)?

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2064/ (1/2)

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2067/ (1/2)

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2125/ (2/2)

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 4: Fails; I would prefer that you didn't submit this

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2067/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2125/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2126/ (2/2)

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2068/ (1/2)

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm_hooks/hostusb: Allow multiple usb devices with same ven...

[Gerrit Code Review]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor 
and product id
..


Patch Set 5:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2068/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2126/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Guglielmi david.guglie...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches