Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-08-25 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 7:

* Update tracker::#1226911::OK
* Check Bug-Url::OK
* Check Public Bug::#1226911::OK, public bug
* Check Product::#1226911::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-08-25 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/42570/7/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 60:event)
Line 61: # Try to forcibly remove this FD from EPOLL
Line 62: # To really stop receiving events
Line 63: try:
Line 64: self._epoll.unregister(fileno)
I don't think we understand the issue yet.

Please add logs for each "successful" branches ("else" and ENOENT) so we can at 
least have a bit more information if the linked bug ever reproduces.
Line 65: except IOError as e:
Line 66: # Ignore ENOENT
Line 67: if e.errno != errno.ENOENT:
Line 68: raise


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-09-02 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 8:

* Update tracker::#1226911::OK
* Check Bug-Url::OK
* Check Public Bug::#1226911::OK, public bug
* Check Product::#1226911::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-10-16 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 9:

* Update tracker::#1226911::OK
* Check Bug-Url::OK
* Check Public Bug::#1226911::OK, public bug
* Check Product::#1226911::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-11-30 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 9:

(5 comments)

https://gerrit.ovirt.org/#/c/42570/9/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 58: else:
Line 59: self.log.debug("Received %.08X. On fd removed by 
epoll.",
Line 60:event)
Line 61: # Try to forcibly remove this FD from EPOLL
Line 62: # To really stop receiving events
Why forcibly? this looks like normal usage of epoll, where is the "force"?
Line 63: try:
Line 64: self._epoll.unregister(fileno)
Line 65: except IOError as e:
Line 66: # Ignore ENOENT


Line 60:event)
Line 61: # Try to forcibly remove this FD from EPOLL
Line 62: # To really stop receiving events
Line 63: try:
Line 64: self._epoll.unregister(fileno)
Why do this only if fileno is not in self._channels?
Line 65: except IOError as e:
Line 66: # Ignore ENOENT
Line 67: if e.errno != errno.ENOENT:
Line 68: raise


Line 62: # To really stop receiving events
Line 63: try:
Line 64: self._epoll.unregister(fileno)
Line 65: except IOError as e:
Line 66: # Ignore ENOENT
The comment is not needed, the code explains it self.

What can be useful is why do we need to ignore ENOENT - I guess because the 
race with another thread calling stop(), right?
Line 67: if e.errno != errno.ENOENT:
Line 68: raise
Line 69: else:
Line 70: self.log.debug('Forcibly unregistering stray 
fd %d '


Line 67: if e.errno != errno.ENOENT:
Line 68: raise
Line 69: else:
Line 70: self.log.debug('Forcibly unregistering stray 
fd %d '
Line 71:'from epoll FAILED', fileno)
This should be a log.error, and more important, we want to log e - it contains 
an error code and error message which may help to understand the issue.
Line 72: else:
Line 73: self.log.debug('Forcibly unregistering stray fd %d 
from '
Line 74:'epoll SUCCEEDED', fileno)
Line 75: elif (event & select.EPOLLIN):


Line 70: self.log.debug('Forcibly unregistering stray 
fd %d '
Line 71:'from epoll FAILED', fileno)
Line 72: else:
Line 73: self.log.debug('Forcibly unregistering stray fd %d 
from '
Line 74:'epoll SUCCEEDED', fileno)
Why stray? this is just another fd monitored by epoll.
Line 75: elif (event & select.EPOLLIN):
Line 76: obj = self._channels.get(fileno, None)
Line 77: if obj:
Line 78: obj['timeout_seen'] = False


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-12-10 Thread vfeenstr 
Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 9:

(5 comments)

https://gerrit.ovirt.org/#/c/42570/9/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 58: else:
Line 59: self.log.debug("Received %.08X. On fd removed by 
epoll.",
Line 60:event)
Line 61: # Try to forcibly remove this FD from EPOLL
Line 62: # To really stop receiving events
> Why forcibly? this looks like normal usage of epoll, where is the "force"?
the force might be the wrong wording - Explicit might be more appropriate
Line 63: try:
Line 64: self._epoll.unregister(fileno)
Line 65: except IOError as e:
Line 66: # Ignore ENOENT


Line 60:event)
Line 61: # Try to forcibly remove this FD from EPOLL
Line 62: # To really stop receiving events
Line 63: try:
Line 64: self._epoll.unregister(fileno)
> Why do this only if fileno is not in self._channels?
Because closing a fd, according to the epoll manage causes it automatically to 
be unregistered.

So I only care about this if we don't listen to events
Line 65: except IOError as e:
Line 66: # Ignore ENOENT
Line 67: if e.errno != errno.ENOENT:
Line 68: raise


Line 62: # To really stop receiving events
Line 63: try:
Line 64: self._epoll.unregister(fileno)
Line 65: except IOError as e:
Line 66: # Ignore ENOENT
> The comment is not needed, the code explains it self.
No, no race - Not if it is not in self._channels

self._channels only contains tracked fds - And that list is maintained by the 
same thread that checks this. So no, it's not caused by that. In theory there 
might be some other issue, ENOENT should not be happening if we're getting the 
event, however if it does happen we really shouldn't care about that error
Line 67: if e.errno != errno.ENOENT:
Line 68: raise
Line 69: else:
Line 70: self.log.debug('Forcibly unregistering stray 
fd %d '


Line 67: if e.errno != errno.ENOENT:
Line 68: raise
Line 69: else:
Line 70: self.log.debug('Forcibly unregistering stray 
fd %d '
Line 71:'from epoll FAILED', fileno)
> This should be a log.error, and more important, we want to log e - it conta
I don't see a point in having ENOENT logged with a higher info level. ENOENT 
just says that the unregister failed because epoll doesn't know about the fd we 
passed
Line 72: else:
Line 73: self.log.debug('Forcibly unregistering stray fd %d 
from '
Line 74:'epoll SUCCEEDED', fileno)
Line 75: elif (event & select.EPOLLIN):


Line 70: self.log.debug('Forcibly unregistering stray 
fd %d '
Line 71:'from epoll FAILED', fileno)
Line 72: else:
Line 73: self.log.debug('Forcibly unregistering stray fd %d 
from '
Line 74:'epoll SUCCEEDED', fileno)
> Why stray? this is just another fd monitored by epoll.
Well but it shouldn't - We don't know about it in _channels, that means epoll 
also shouldn't care about it
Line 75: elif (event & select.EPOLLIN):
Line 76: obj = self._channels.get(fileno, None)
Line 77: if obj:
Line 78: obj['timeout_seen'] = False


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-06-19 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 1:

* Update tracker::#1226911::OK
* Check Bug-Url::OK
* Check Public Bug::#1226911::OK, public bug
* Check Product::#1226911::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-06-19 Thread vfeenstr 
Vinzenz Feenstra has uploaded a new change for review.

Change subject: virt: Forcibly unregister fds with errors from epoll
..

virt: Forcibly unregister fds with errors from epoll

To ensure that we do not get spammed with errors, we're now again
proactively trying to unregister events from epoll

Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Bug-Url: https://bugzilla.redhat.com/1226911
Signed-off-by: Vinzenz Feenstra 
---
M vdsm/virt/vmchannels.py
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/42570/1

diff --git a/vdsm/virt/vmchannels.py b/vdsm/virt/vmchannels.py
index 9939546..ade79ca 100644
--- a/vdsm/virt/vmchannels.py
+++ b/vdsm/virt/vmchannels.py
@@ -69,6 +69,12 @@
 self._untrackedErrors += 1
 self.log.debug("Received %.08X. On fd removed by epoll.",
event)
+# Try to forcibly remove this FD from EPOLL
+# To really stop receiving events
+try:
+self._epoll.unregister(fileno)
+except IOError:
+pass
 elif (event & select.EPOLLIN):
 obj = self._channels.get(fileno, None)
 if obj:


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-06-23 Thread michal . skrivanek 
Michal Skrivanek has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-06-23 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 2:

* Update tracker::#1226911::OK
* Check Bug-Url::OK
* Check Public Bug::#1226911::OK, public bug
* Check Product::#1226911::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-06-23 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 3:

* Update tracker::#1226911::OK
* Check Bug-Url::OK
* Check Public Bug::#1226911::OK, public bug
* Check Product::#1226911::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-06-24 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 3: Code-Review-1

(1 comment)

-1 for visibility because of a question inside

https://gerrit.ovirt.org/#/c/42570/3/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 59:event)
Line 60: # Try to forcibly remove this FD from EPOLL
Line 61: # To really stop receiving events
Line 62: try:
Line 63: self._epoll.unregister(fileno)
question: how about doing this in unregister()? Any drawback?
Line 64: except IOError:
Line 65: pass
Line 66: elif (event & select.EPOLLIN):
Line 67: obj = self._channels.get(fileno, None)


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-06-26 Thread vfeenstr 
Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/42570/3/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 59:event)
Line 60: # Try to forcibly remove this FD from EPOLL
Line 61: # To really stop receiving events
Line 62: try:
Line 63: self._epoll.unregister(fileno)
> question: how about doing this in unregister()? Any drawback?
the point is that we are not tracking this filedescripter anymore, and by 
definition epoll should actually drop it when there was an error, however as 
can be seen in the linked bug (commit message) that there are loads and loads 
of errors happening. This is an attempt to be a safety mechanism to try to stop 
those errors.
Line 64: except IOError:
Line 65: pass
Line 66: elif (event & select.EPOLLIN):
Line 67: obj = self._channels.get(fileno, None)


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-06-29 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 3: Code-Review+1

changing score after answer from Vinzenz

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-01 Thread vfeenstr 
Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-01 Thread vfeenstr 
Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 3:

Tested on el7 with guest agent installed, migrated shutdown etc no other side 
effects.

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-01 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 4:

* Update tracker::#1226911::OK
* Check Bug-Url::OK
* Check Public Bug::#1226911::OK, public bug
* Check Product::#1226911::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-01 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/42570/4/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 60: # Try to forcibly remove this FD from EPOLL
Line 61: # To really stop receiving events
Line 62: try:
Line 63: self._epoll.unregister(fileno)
Line 64: except IOError:
unregister() only adds fileno to _del_channels. It cannot possibly raise an 
IOError (and if it does, I want to know).

But more importantly - I simply don't see how this "forcible" attempt to remove 
an FD that is already missing from _channles would help anybody.
Line 65: pass
Line 66: elif (event & select.EPOLLIN):
Line 67: obj = self._channels.get(fileno, None)
Line 68: if obj:


Line 172: """ Wait for an epoll event and handle channels' timeout. """
Line 173: events = NoIntrPoll(self._epoll.poll, 1)
Line 174: for (fileno, event) in events:
Line 175: self._handle_event(fileno, event)
Line 176: else:
unrelated, but I find this "else" confusing, as the "for" loop does not have 
any "break". do you recall why do we have this "else"?
Line 177: self._update_channels()
Line 178: if (self._timeout is not None) and (self._timeout > 0):
Line 179: self._handle_timeouts()
Line 180: self._handle_unconnected()


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-01 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/42570/4/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 60: # Try to forcibly remove this FD from EPOLL
Line 61: # To really stop receiving events
Line 62: try:
Line 63: self._epoll.unregister(fileno)
Line 64: except IOError:
> unregister() only adds fileno to _del_channels. It cannot possibly raise an
g, I mixed up between epoll.unregister and self.unregister. sorry.
Line 65: pass
Line 66: elif (event & select.EPOLLIN):
Line 67: obj = self._channels.get(fileno, None)
Line 68: if obj:


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-01 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/42570/4//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-07-01 06:36:22 -0400
Line 6: 
Line 7: virt: Forcibly unregister fds with errors from epoll
Line 8: 
Line 9: To ensure that we do not get spammed with errors, we're now again
please point to https://gerrit.ovirt.org/#/c/15393 which dropped unregister, 
and please state clearly that we do NOT understand how come we still get events 
from unknown FDs.
Line 10: proactively trying to unregister events from epoll
Line 11: 
Line 12: Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Line 13: Bug-Url: https://bugzilla.redhat.com/1226911


https://gerrit.ovirt.org/#/c/42570/4/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 60: # Try to forcibly remove this FD from EPOLL
Line 61: # To really stop receiving events
Line 62: try:
Line 63: self._epoll.unregister(fileno)
Line 64: except IOError:
> g, I mixed up between epoll.unregister and self.unregister. sorry.
We should swallow only ENOENT errors (already unregistered) but log others, 
right?
Line 65: pass
Line 66: elif (event & select.EPOLLIN):
Line 67: obj = self._channels.get(fileno, None)
Line 68: if obj:


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-01 Thread vfeenstr 
Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/42570/4/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 60: # Try to forcibly remove this FD from EPOLL
Line 61: # To really stop receiving events
Line 62: try:
Line 63: self._epoll.unregister(fileno)
Line 64: except IOError:
> We should swallow only ENOENT errors (already unregistered) but log others,
Actually, this should not happen, since we just got that event, and this is the 
same thread which is controlling it.
But yes, will do
Line 65: pass
Line 66: elif (event & select.EPOLLIN):
Line 67: obj = self._channels.get(fileno, None)
Line 68: if obj:


Line 172: """ Wait for an epoll event and handle channels' timeout. """
Line 173: events = NoIntrPoll(self._epoll.poll, 1)
Line 174: for (fileno, event) in events:
Line 175: self._handle_event(fileno, event)
Line 176: else:
> unrelated, but I find this "else" confusing, as the "for" loop does not hav
it only handes these things when there are no events. Else is triggered, when 
events is empty
Line 177: self._update_channels()
Line 178: if (self._timeout is not None) and (self._timeout > 0):
Line 179: self._handle_timeouts()
Line 180: self._handle_unconnected()


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-01 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/42570/4/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 60: # Try to forcibly remove this FD from EPOLL
Line 61: # To really stop receiving events
Line 62: try:
Line 63: self._epoll.unregister(fileno)
Line 64: except IOError:
> Actually, this should not happen, since we just got that event, and this is
another thread may close the fd since the event was fired.

but if that has happened, the FD might have also been re-used and and 
re-registered to this epoll, and this unregister call might kill an unrelated 
fd.

I don't like this at all.
Line 65: pass
Line 66: elif (event & select.EPOLLIN):
Line 67: obj = self._channels.get(fileno, None)
Line 68: if obj:


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-01 Thread vfeenstr 
Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/42570/4/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 60: # Try to forcibly remove this FD from EPOLL
Line 61: # To really stop receiving events
Line 62: try:
Line 63: self._epoll.unregister(fileno)
Line 64: except IOError:
> another thread may close the fd since the event was fired.
It can be closed, the event gets fired, yes. BUT then the event would actually 
end up in the 'reconnect' portion not in the untracked portion.

If that FD then gets reused, it would first end up in the add list and by this 
thread and moved to the _channels once there have been no events.

This code has been stable for a long time now. The only problem we have right 
now is that we seem to get events we do not want. So we're unregistering it 
here because it's not in self._channels
Line 65: pass
Line 66: elif (event & select.EPOLLIN):
Line 67: obj = self._channels.get(fileno, None)
Line 68: if obj:


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-12 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 5:

* Update tracker::#1226911::OK
* Check Bug-Url::OK
* Check Public Bug::#1226911::OK, public bug
* Check Product::#1226911::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-13 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 6:

* Update tracker::#1226911::OK
* Check Bug-Url::OK
* Check Public Bug::#1226911::OK, public bug
* Check Product::#1226911::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 
ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-13 Thread vfeenstr 
Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-13 Thread vfeenstr 
Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 6:

All still working - No side effects noticed.
Tested on EL7 Host
 
Tested scenarios:
- Migrations from/to
- Start/Stop VM
- Suspend/Resume VM
- Sending commands to the agent
- Receiving data from the agent 
No regressions noticed

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

2015-07-13 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Gal Hammer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches