Change in vdsm[master]: virt: sampling: extract disk latency calculation
Dan Kenigsberg has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 7: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/29952/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 570: try: Line 571: if (sInfo and vmDrive.name in sInfo and Line 572:eInfo and vmDrive.name in eInfo): Line 573: dStats = _calcDiskLatency(vmDrive, sInfo, eInfo) Line 574: except (KeyError, TypeError): I do not see KeyError on the original code. Why is it required now? Beyond that - now you test sInfo; should we keep TypeError? If we do need these, they should wrap only the _calcDiskLatency call, as the condition itself can never raise them. Line 575: self._log.exception(Disk %s latency not available, Line 576: vmDrive.name) Line 577: Line 578: stats[vmDrive.name].update(dStats) -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Dan Kenigsberg has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: sampling: extract disk latency calculation .. virt: sampling: extract disk latency calculation This is a preparation patch for the merge of sampleDisk and sampleDiskLatency Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/29952 Reviewed-by: Martin Polednik mpoled...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 27 insertions(+), 38 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Martin Polednik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4064/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/50/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/77/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/272/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5904/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/74/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/70/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Francesco Romani has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 7: rebased. -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12846/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11897/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1754/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12688/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Francesco Romani has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 7: Verified+1 verified by running one VM on one patched VDSM and checked using vdsClient that the disk latency stats are present in the output of the getAllVmStats. -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12780/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1737/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12623/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Martin Polednik has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Martin Polednik has posted comments on this change.
Change subject: virt: sampling: extract disk latency calculation
..
Patch Set 4: Code-Review-1
(2 comments)
-1 for visibility, not critical to me
http://gerrit.ovirt.org/#/c/29952/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 570: try:
Line 571: if (sInfo and vmDrive.name in sInfo and
Line 572:eInfo and vmDrive.name in eInfo):
Line 573: dStats = self._calcDiskLatency(vmDrive, sInfo,
eInfo)
Line 574: except (KeyError, TypeError):
Have you thought of adding AttributeError, NameError and removing if block
above?
Line 575: self._log.exception(Disk %s latency not available,
Line 576: vmDrive.name)
Line 577:
Line 578: stats[vmDrive.name].update(dStats)
Line 596: sData['flush_operations'])
Line 597: else (eData['flush_total_times'] -
Line 598: sData['flush_total_times']) /
Line 599: (eData['flush_operations'] -
Line 600: sData['flush_operations']))
I'd consider iterating over some composed data structure in order to reduce the
amount of copy-pastiness in this code
latency = {}
for type in ('rd', 'wr', 'flush'):
(0 if not eData[type + '_operations']
latency[type]
Line 601: return {'readLatency': str(readLatency),
Line 602: 'writeLatency': str(writeLatency),
Line 603: 'flushLatency': str(flushLatency)}
Line 604:
--
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Nir Soffer has posted comments on this change.
Change subject: virt: sampling: extract disk latency calculation
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/29952/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 570: try:
Line 571: if (sInfo and vmDrive.name in sInfo and
Line 572:eInfo and vmDrive.name in eInfo):
Line 573: dStats = self._calcDiskLatency(vmDrive, sInfo,
eInfo)
Line 574: except (KeyError, TypeError):
Have you thought of adding AttributeError, NameError and removing if block
The if block is required, we don't want to log exceptions when vmDrive.name is
not in sInfo or eInfo.
Why do we need to handle AttributeError or NameError?
Line 575: self._log.exception(Disk %s latency not available,
Line 576: vmDrive.name)
Line 577:
Line 578: stats[vmDrive.name].update(dStats)
Line 596: sData['flush_operations'])
Line 597: else (eData['flush_total_times'] -
Line 598: sData['flush_total_times']) /
Line 599: (eData['flush_operations'] -
Line 600: sData['flush_operations']))
I'd consider iterating over some composed data structure in order to reduce
The repeating code here is the code to calculate the latency, which is the same
for all types. So lets have a function that repeat this code once:
Something like:
def compute_latency(ltype, edata, sdata):
ops = ltype + '_operations'
operations = edata[ops] - sdata[ops]
if not operations
return 0
times = ltype + '_total_times'
elasped_time = edata[times] - sdata[times]
return elapsed_time / operations
I'm using edata and sdata because I don't know what they mean, please use more
descriptive names.
The client code looks like:
readLatency = compute_latency(rd, edata, sdata)
Line 601: return {'readLatency': str(readLatency),
Line 602: 'writeLatency': str(writeLatency),
Line 603: 'flushLatency': str(flushLatency)}
Line 604:
--
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: extract disk latency calculation
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29952/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 596: sData['flush_operations'])
Line 597: else (eData['flush_total_times'] -
Line 598: sData['flush_total_times']) /
Line 599: (eData['flush_operations'] -
Line 600: sData['flush_operations']))
The repeating code here is the code to calculate the latency, which is the
neat, will do.
Line 601: return {'readLatency': str(readLatency),
Line 602: 'writeLatency': str(writeLatency),
Line 603: 'flushLatency': str(flushLatency)}
Line 604:
--
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Martin Polednik has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29952/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 570: try: Line 571: if (sInfo and vmDrive.name in sInfo and Line 572:eInfo and vmDrive.name in eInfo): Line 573: dStats = self._calcDiskLatency(vmDrive, sInfo, eInfo) Line 574: except (KeyError, TypeError): The if block is required, we don't want to log exceptions when vmDrive.name These were meant if the if could be dropped, wasn't aware of the logging issue so ignore Line 575: self._log.exception(Disk %s latency not available, Line 576: vmDrive.name) Line 577: Line 578: stats[vmDrive.name].update(dStats) -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11792/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12738/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1713/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12581/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11756/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12700/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1705/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12545/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: extract disk latency calculation
..
Patch Set 3: Verified+1
Verified with 29951 by letting a VM boot by CD on a patched VDSM:
disks = {'vda': {'readLatency': '25910', 'apparentsize': '1073741824',
'writeLatency': '0', 'imageID': '524f0170-68fe-4acf-94c9-923cb510e1d1',
'flushLatency': '0', 'readRate': '8.52', 'truesize': '1073741824', 'writeRate':
'0.00'}
, 'hdc': {'readLatency': '11395', 'apparentsize': '0', 'writeLatency': '0',
'flushLatency': '0', 'readRate': '589226.28', 'truesize': '0', 'writeRate':
'0.00'}}
--
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Francesco Romani has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 3: rebased. -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1425/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10758/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11700/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11543/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Francesco Romani has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 2: Verified+1 verified with 29951 and 29953 using both the new and old flow. Stats shows correctly on vdsClient. -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10224/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11009/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1266/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11166/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
Francesco Romani has uploaded a new change for review.
Change subject: virt: sampling: extract disk latency calculation
..
virt: sampling: extract disk latency calculation
This is a preparation patch for the merge
of sampleDisk and sampleDiskLatency
Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 21 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/29952/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4a3f629..1082d1c 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -538,7 +538,22 @@
def _getDiskLatency(self, stats):
sInfo, eInfo, sampleInterval = self.sampleDiskLatency.getStats()
-def _avgLatencyCalc(sData, eData):
+for vmDrive in self._vm.getDiskDevices():
+if sInfo is not None:
+dLatency = self._calcDiskLatency(vmDrive, sInfo, eInfo,
+ sampleInterval)
+else:
+# will be None if sampled during recovery
+dLatency = {'readLatency': '0',
+'writeLatency': '0',
+'flushLatency': '0'}
+
+stats[dName].update(dLatency)
+
+def _calcDiskLatency(self, vmDrive, sInfo, eInfo, sampleInterval):
+try:
+sData = sInfo[vmDrive.name]
+eData = eInfo[vmDrive.name]
readLatency = (0 if not (eData['rd_operations'] -
sData['rd_operations'])
else (eData['rd_total_times'] -
@@ -561,21 +576,11 @@
'readLatency': str(readLatency),
'writeLatency': str(writeLatency),
'flushLatency': str(flushLatency)}
-
-for vmDrive in self._vm.getDiskDevices():
-dName = vmDrive.name
-dLatency = {'readLatency': '0',
-'writeLatency': '0',
-'flushLatency': '0'}
-
-if sInfo is not None:
-# will be None if sampled during recovery
-try:
-dLatency = _avgLatencyCalc(sInfo[dName], eInfo[dName])
-except (KeyError, TypeError):
-self._log.exception(Disk %s latency not available, dName)
-
-stats[dName].update(dLatency)
+except (KeyError, TypeError):
+self._log.exception(Disk %s latency not available, vmDrive.name)
+return {'readLatency': '0',
+'writeLatency': '0',
+'flushLatency': '0'}
def _getVmJobs(self, stats):
sInfo, eInfo, sampleInterval = self.sampleVmJobs.getStats()
--
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: extract disk latency calculation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10166/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10951/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1241/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11109/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
