Change in vdsm[master]: virt: support per-vm stats age
Dan Kenigsberg has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 35: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: Build Started (8/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/70/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: Build Started (4/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/512/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: Build Started (2/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/516/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: support per-vm stats age .. virt: support per-vm stats age It is possible that a VM goes rougue right at the startup, even before that any commmand is sent to it. To cover this case, VDSM marks a VM as unresponsive if stats are unavailable for too long, including the startup. This patch provides support in StatsCache to provide the same behaviour when switching to the new bulk stats sampling. Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38066 Reviewed-by: Martin Polednik mpoled...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/samplingTests.py M vdsm/virt/sampling.py 2 files changed, 113 insertions(+), 43 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: Build Started (3/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/893/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: Build Started (5/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/928/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: Build Started (7/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/70/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: Build Started (6/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/525/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: Build Successful http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/516/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/893/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/930/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/512/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/928/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/525/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/70/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/70/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/2/ : 0 -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
automat...@ovirt.org has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: Build Started (1/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/930/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 36: Build Started (9/9) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/2/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 35: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18151/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Francesco Romani has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 35: Verified+1 version 35 includes minor fixes, most notably the rename from 'values_interval' to 'interval'. Tests run OK - V+1 again. -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 35: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17979/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 35: Build Started (3/3) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1208/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
automat...@ovirt.org has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 35: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Martin Polednik has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 35: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Francesco Romani has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 31: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
automat...@ovirt.org has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 32: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 32: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17903/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 32: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18073/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17903/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Francesco Romani has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 32: Verified+1 verified positive flows using tests and run a patched VDSM. -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 32: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18073/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Martin Polednik has posted comments on this change.
Change subject: virt: support per-vm stats age
..
Patch Set 32: Code-Review-1
(4 comments)
I wouldn't say anything is critical here, but some explanation about the
pre/post sampling (in code or commit msg) would be nice for readers.
https://gerrit.ovirt.org/#/c/38066/32/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 424: Provide facilities to retrieve per-vm samples,
Line 425: and the glue code to deal with disappearing per-vm samples.
Line 426:
Line 427:
Line 428: EMPTY = StatsSample(None, None, None, None) # 'null' sample
Should be in the same namespace as StatsSample imho.
Line 429:
Line 430: _log = logging.getLogger(sampling.StatsCache)
Line 431:
Line 432: def __init__(self, clock=utils.monotonic_time):
Line 435: self._last_sample_time = 0
Line 436: self._vm_last_timestamp = defaultdict(int)
Line 437: self._lock = threading.Lock()
Line 438:
Line 439: def clock(self):
Making it a @property would be nicer from pythonic standpoint.
Line 440:
Line 441: Provide timestamp compatible with what put() expects
Line 442:
Line 443: return self._clock()
Line 492: returned by unblocked stuck calls, to avoid overwrite fresh
data
Line 493: with stale one.
Line 494:
Line 495: with self._lock:
Line 496: if monotonic_ts = self._last_sample_time:
Not exactly related to this patchset, but still something very close: is =
relation better idea than plain here?
Line 497: self._samples.append(bulk_stats)
Line 498: self._last_sample_time = monotonic_ts
Line 499:
Line 500: self._update_ts(bulk_stats, monotonic_ts)
Line 496: if monotonic_ts = self._last_sample_time:
Line 497: self._samples.append(bulk_stats)
Line 498: self._last_sample_time = monotonic_ts
Line 499:
Line 500: self._update_ts(bulk_stats, monotonic_ts)
Not sure which semantics did you target and I think it should be noted
somewhere:
Is it correct that the time of the last sample is calculated AFTER constructing
the last sample? It could also be calculated BEFORE the sample is made where
above comment would make sense.
Line 501: else:
Line 502: self._log.warning('dropped stale old sample')
Line 503:
Line 504: def _update_ts(self, bulk_stats, monotonic_ts):
--
To view, visit https://gerrit.ovirt.org/38066
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Martin Polednik has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 33: Code-Review+1 (1 comment) Very little stylistic issue with comments vs docstrings but still way better. +1ing the code itself because I have very little experience with our sampling code and cannot comment further on the functionality https://gerrit.ovirt.org/#/c/38066/33/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 479: # So, under the assumption that at stable state stats collection has Line 480: # a time cost negligible with respect the collection interval, we need Line 481: # to take the sample timestamp BEFORE to start the possibly-blocking call. Line 482: # If we take the timestamp after the call, we have no means to distinguish Line 483: # between a well behaving call and an unblocked stuck call. I'd say move to class docstring Line 484: Line 485: def clock(self): Line 486: Line 487: Provide timestamp compatible with what put() expects -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Francesco Romani has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 33: (1 comment) https://gerrit.ovirt.org/#/c/38066/33/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 479: # So, under the assumption that at stable state stats collection has Line 480: # a time cost negligible with respect the collection interval, we need Line 481: # to take the sample timestamp BEFORE to start the possibly-blocking call. Line 482: # If we take the timestamp after the call, we have no means to distinguish Line 483: # between a well behaving call and an unblocked stuck call. I'd say move to class docstring good idea. Line 484: Line 485: def clock(self): Line 486: Line 487: Provide timestamp compatible with what put() expects -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 33: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18112/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17940/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 33: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18112/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
automat...@ovirt.org has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 33: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 34: Build Started (1/3) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17957/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 34: Build Started (2/3) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18129/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Dan Kenigsberg has posted comments on this change.
Change subject: virt: support per-vm stats age
..
Patch Set 34: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/38066/34/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 402:
Line 403:
Line 404: StatsSample = namedtuple('StatsSample',
Line 405: ['first_value', 'last_value',
Line 406: 'values_interval', 'stats_age'])
naming: interval seems crystal clear. values_interval is longer and adds
nothing much imho.
Line 407:
Line 408:
Line 409: EMPTY_SAMPLE = StatsSample(None, None, None, None)
Line 410:
--
To view, visit https://gerrit.ovirt.org/38066
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed
Gerrit-PatchSet: 34
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Francesco Romani has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 34: Verified+1 (re)verified using tests -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
automat...@ovirt.org has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 34: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Francesco Romani has posted comments on this change.
Change subject: virt: support per-vm stats age
..
Patch Set 34:
(1 comment)
https://gerrit.ovirt.org/#/c/38066/34/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 402:
Line 403:
Line 404: StatsSample = namedtuple('StatsSample',
Line 405: ['first_value', 'last_value',
Line 406: 'values_interval', 'stats_age'])
naming: interval seems crystal clear. values_interval is longer and add
good point, will change.
Line 407:
Line 408:
Line 409: EMPTY_SAMPLE = StatsSample(None, None, None, None)
Line 410:
--
To view, visit https://gerrit.ovirt.org/38066
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed
Gerrit-PatchSet: 34
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Martin Polednik has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 34: Code-Review+1 +1.1 if interval name change gets in -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 33: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17940/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Francesco Romani has posted comments on this change.
Change subject: virt: support per-vm stats age
..
Patch Set 32:
(9 comments)
https://gerrit.ovirt.org/#/c/38066/32/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 362: return None
Line 363: _, last_sample = self._samples[-1]
Line 364: return last_sample
Line 365:
Line 366: def values(self):
not needed anymore, will remove
Line 367:
Line 368: Return the raw collected values.
Line 369:
Line 370: if len(self._samples) 2:
Line 424: Provide facilities to retrieve per-vm samples,
Line 425: and the glue code to deal with disappearing per-vm samples.
Line 426:
Line 427:
Line 428: EMPTY = StatsSample(None, None, None, None) # 'null' sample
Should be in the same namespace as StatsSample imho.
will move
Line 429:
Line 430: _log = logging.getLogger(sampling.StatsCache)
Line 431:
Line 432: def __init__(self, clock=utils.monotonic_time):
Line 435: self._last_sample_time = 0
Line 436: self._vm_last_timestamp = defaultdict(int)
Line 437: self._lock = threading.Lock()
Line 438:
Line 439: def clock(self):
Making it a @property would be nicer from pythonic standpoint.
probably yes, will play with it
Line 440:
Line 441: Provide timestamp compatible with what put() expects
Line 442:
Line 443: return self._clock()
Line 448:
Line 449: with self._lock:
Line 450: try:
Line 451: del self._vm_last_timestamp[vmid]
Line 452: except KeyError:
do not swallow KeyError here
Line 453: pass
Line 454:
Line 455: def register(self, vmid):
Line 456:
Line 451: del self._vm_last_timestamp[vmid]
Line 452: except KeyError:
Line 453: pass
Line 454:
Line 455: def register(self, vmid):
unneeded since we use defaultdict
Line 456:
Line 457: Warm up the cache for `vmid'
Line 458:
Line 459: with self._lock:
Line 464: Return the available StatSample for the given VM.
Line 465:
Line 466: with self._lock:
Line 467: (first_batch, first_batch_timestamp,
Line 468: last_batch, last_batch_timestamp) =
self._samples.values()
we can use stats() method
Line 469:
Line 470: if first_batch is None:
Line 471: return self.EMPTY
Line 472:
Line 475:
Line 476: if first_sample is None or last_sample is None:
Line 477: return self.EMPTY
Line 478:
Line 479: elapsed_time = last_batch_timestamp -
first_batch_timestamp
it is 'interval' actually, and no gain in calculating it here
Line 480: stats_age = self._clock() - self._vm_last_timestamp[vmid]
Line 481:
Line 482: return StatsSample(first_sample, last_sample,
Line 483:elapsed_time, stats_age)
Line 492: returned by unblocked stuck calls, to avoid overwrite fresh
data
Line 493: with stale one.
Line 494:
Line 495: with self._lock:
Line 496: if monotonic_ts = self._last_sample_time:
Not exactly related to this patchset, but still something very close: is =
it's just me being paranoid. I don't have a clear case to use '=' instead of
''
Line 497: self._samples.append(bulk_stats)
Line 498: self._last_sample_time = monotonic_ts
Line 499:
Line 500: self._update_ts(bulk_stats, monotonic_ts)
Line 496: if monotonic_ts = self._last_sample_time:
Line 497: self._samples.append(bulk_stats)
Line 498: self._last_sample_time = monotonic_ts
Line 499:
Line 500: self._update_ts(bulk_stats, monotonic_ts)
Not sure which semantics did you target and I think it should be noted some
Not sure I understood your remark, but here the problem I'm addressing is a
stuck call that eventually unblocks.
When it unblocks, it will try to add a sample to this StatsCache, but that
sample can be stale, because another worker can have took over, and succesfully
collected a new sample.
So, under the assumption that at stable state stats collection has a time cost
negligible with respect the collection interval, I need to take the sample time
BEFORE to start the possibly-blocking call. If I take the time after, I have no
means to distinguish between a well behaving call and an unblocked stuck call.
If that is what you meant, I can add a comment/docstring explaining the API
weirdness.
Line 501: else:
Line 502: self._log.warning('dropped stale old sample')
Line 503:
Line 504: def _update_ts(self, bulk_stats, monotonic_ts):
--
To view, visit https://gerrit.ovirt.org/38066
To unsubscribe, visit
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 31: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18045/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17874/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 31: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18045/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 31: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17874/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
automat...@ovirt.org has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 31: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
Dan Kenigsberg has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 30: (1 comment) https://gerrit.ovirt.org/#/c/38066/30//COMMIT_MSG Commit Message: Line 7: virt: support per-vm stats age Line 8: Line 9: For quite obscure historical reasons, VDSM marks Line 10: a VM as unresponsive if stats are unavailable for too long. Line 11: Assume that a VM was started, but it is tickled a qemu bug and never answer back. It must be marked as non-responsive, right? Can you give an example of the unintentionally-changed behavior of Vdsm? I'll probably need a face-to-face explanation of the issue. Line 12: The benefit of this behaviour is questionable, but it was Line 13: broken as side effect of the transition of new periodic, Line 14: bulk sampling. Line 15: -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 30: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17980/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17810/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
automat...@ovirt.org has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 30: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 30: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17810/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 30: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17980/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
automat...@ovirt.org has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 29: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 29: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17765/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: support per-vm stats age
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: support per-vm stats age .. Patch Set 29: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17936/ -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
