Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Francesco Romani has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Verified+1 Verification: - with default settings, VM is paused - with propagateErrors forced to ON, VM continues to run, the VM console is filled with kernel logs and the error line is seen in the VDSM logs. -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Dan Kenigsberg has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Dan Kenigsberg has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 6: Verified+1 Code-Review+2 Simple rebase, copying scores. -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: consider 'action' when handling I/O errors .. vm: consider 'action' when handling I/O errors When VDSM receives an I/O error event from libvirt, it does not consider the value of the 'action' callback field, and thus considers the guest CPU stopped. This is true in the default configuration, which translates to the disk write error policy 'stop', but not necessarily true if the said policy is 'enospace'. In this case the reported state of the CPU goes out of sync. Since the error policy may be changed through an hook, the safest thing to do is actually check the 'action' value as reported by libvirt in the IOError callback. This patch adds this check, and additional logging in the case the guest CPU is reported running after I/O errors. Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Bug-Url: https://bugzilla.redhat.com/1064630 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25157 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/clientIF.py M vdsm/vm.py 2 files changed, 17 insertions(+), 9 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6795/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7585/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7695/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7405/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6612/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7514/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
David Gibson has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Code-Review+1 Looks good to me now. -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Nir Soffer has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Dan Kenigsberg has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25157/3/vdsm/vm.py
File vdsm/vm.py:
Line 4578: self._guestCpuRunning = False
Line 4579: if err.upper() == 'ENOSPC':
Line 4580: if not self.extendDrivesIfNeeded():
Line 4581: self.log.info(No VM drives were extended)
Line 4582: elif action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_REPORT:
it seems that with this, the guest cpu is not really stopped. This means that a
rename of the callback function is due. How about _onIOError?
Line 4583: self.log.info('I/O error %s device %s reported to guest
OS',
Line 4584: err, blockDevAlias)
Line 4585: else:
Line 4586: # we do not support and do not expect other values
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Francesco Romani has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/3/vdsm/vm.py
File vdsm/vm.py:
Line 4578: self._guestCpuRunning = False
Line 4579: if err.upper() == 'ENOSPC':
Line 4580: if not self.extendDrivesIfNeeded():
Line 4581: self.log.info(No VM drives were extended)
Line 4582: elif action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_REPORT:
it seems that with this, the guest cpu is not really stopped. This means th
Agreed. Moreover, the docstring at the beginning of the function already
suggest when this callback should be triggered. Better to rename in a different
patch or to on this one?
Line 4583: self.log.info('I/O error %s device %s reported to guest
OS',
Line 4584: err, blockDevAlias)
Line 4585: else:
Line 4586: # we do not support and do not expect other values
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Francesco Romani has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 4: Patch set 4: renamed the callback as per Dan's suggestion. Not sure if it is best to rename in this patch, but I'll split the change if is needed (or just more convenient) -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7394/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6601/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7503/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
David Gibson has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 4: Code-Review-1 The else clause looks as though it could give a really misleading error if qemu/libvirt ever added an action type other than the current stop/report/ignore. Better to just print unexpected error action: value or something, maybe? -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Michal Skrivanek has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 4: Code-Review+1 It's an error in log, IMO it looks good -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Nir Soffer has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 4:
(2 comments)
Looks ok except the error for unexpected action, which should be a warning.
http://gerrit.ovirt.org/#/c/25157/4/vdsm/vm.py
File vdsm/vm.py:
Line 4568:
Line 4569: Called back by IO_ERROR_REASON event
Line 4570:
Line 4571: :param err: one of eperm, eio, enospc or eother
Line 4572: Note the different API from that of Vm._onAbnormalStop
Note for later patch - the note about the different API looks outdated. Isn't
this Vm._onAbnormalStop?
Line 4573:
Line 4574: if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
Line 4575: self.log.info('abnormal vm stop device %s error %s',
Line 4576: blockDevAlias, err)
Line 4584: err, blockDevAlias)
Line 4585: else:
Line 4586: # we do not support and do not expect other values
Line 4587: self.log.error('I/O error %s device %s action %i
ignored',
Line 4588:err, blockDevAlias, action)
This should be a warning, this is not an error condition.
Line 4589:
Line 4590: def _acpiShutdown(self):
Line 4591:
self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
Line 4592:
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Gibson dgib...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Francesco Romani has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/25157/4/vdsm/vm.py
File vdsm/vm.py:
Line 4568:
Line 4569: Called back by IO_ERROR_REASON event
Line 4570:
Line 4571: :param err: one of eperm, eio, enospc or eother
Line 4572: Note the different API from that of Vm._onAbnormalStop
Note for later patch - the note about the different API looks outdated. Isn
Agreed. Will fix in a later (cleanup) patch
Line 4573:
Line 4574: if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
Line 4575: self.log.info('abnormal vm stop device %s error %s',
Line 4576: blockDevAlias, err)
Line 4584: err, blockDevAlias)
Line 4585: else:
Line 4586: # we do not support and do not expect other values
Line 4587: self.log.error('I/O error %s device %s action %i
ignored',
Line 4588:err, blockDevAlias, action)
This should be a warning, this is not an error condition.
I will fix, taking in account the remarks from Dave and Michal
Line 4589:
Line 4590: def _acpiShutdown(self):
Line 4591:
self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
Line 4592:
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: David Gibson dgib...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Francesco Romani has uploaded a new change for review.
Change subject: vm: consider 'action' when handling I/O errors
..
vm: consider 'action' when handling I/O errors
When VDSM receives an I/O error event from libvirt,
it does not consider the value of the 'action' callback
field, and thus considers the guest CPU stopped.
This is true in the default configuration, which translates
to the disk write error policy 'stop', but not necessarily
true if the said policy is 'enospace'.
In this case the reported state of the CPU goes out of sync.
Since the error policy may be changed through an hook,
the safest thing to do is actually check the 'action'
value as reported by libvirt in the IOError callback.
This patch adds this check, and additional logging in
the case the guest CPU is reported running after I/O
errors.
Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Bug-Url: https://bugzilla.redhat.com/1064630
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/clientIF.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/25157/1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index f8fe499..0169e81 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -550,7 +550,12 @@
v._rtcUpdate(utcoffset)
elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON:
srcPath, devAlias, action, reason = args[:-1]
-v._onAbnormalStop(devAlias, reason)
+if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
+v._onAbnormalStop(devAlias, reason)
+else:
+self.log.warn('I/O error event on %s (%s) reason %s'
+ ' ignored due to action %i',
+ srcPath, devAlias, reason, action)
elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS:
phase, localAddr, remoteAddr, authScheme, subject = args[:-1]
v.log.debug('graphics event phase '
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7327/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6543/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7445/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 552: srcPath, devAlias, action, reason = args[:-1]
Line 553: if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
Line 554: v._onAbnormalStop(devAlias, reason)
Line 555: else:
Line 556: self.log.warn('I/O error event on %s (%s) reason
%s'
since the only other supported action is report(to the guest), wouldn't it
make more sense to just say so in the log…and only on any other action code log
a warning or error?
Line 557: ' ignored due to action %i',
Line 558: srcPath, devAlias, reason, action)
Line 559: elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS:
Line 560: phase, localAddr, remoteAddr, authScheme, subject =
args[:-1]
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 552: srcPath, devAlias, action, reason = args[:-1]
Line 553: if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
Line 554: v._onAbnormalStop(devAlias, reason)
Line 555: else:
Line 556: self.log.warn('I/O error event on %s (%s) reason
%s'
since the only other supported action is report(to the guest), wouldn't i
or not log anything in case one of these two actions...since there's
self.log.info('abnormal vm stop device… right at the beginning of
_onAbnormalStop ()
Line 557: ' ignored due to action %i',
Line 558: srcPath, devAlias, reason, action)
Line 559: elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS:
Line 560: phase, localAddr, remoteAddr, authScheme, subject =
args[:-1]
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Francesco Romani has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 552: srcPath, devAlias, action, reason = args[:-1]
Line 553: if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
Line 554: v._onAbnormalStop(devAlias, reason)
Line 555: else:
Line 556: self.log.warn('I/O error event on %s (%s) reason
%s'
or not log anything in case one of these two actions...since there's self.
Right, I'll improve logging.
Will also push the check on the 'action' field inside _onAbnormalStop.
Line 557: ' ignored due to action %i',
Line 558: srcPath, devAlias, reason, action)
Line 559: elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS:
Line 560: phase, localAddr, remoteAddr, authScheme, subject =
args[:-1]
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7334/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6550/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7452/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25157/2/vdsm/vm.py
File vdsm/vm.py:
Line 4582: elif action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_REPORT:
Line 4583: self.log.info('I/O error %s device %s reported to guest
OS',
Line 4584: err, blockDevAlias)
Line 4585: else:
Line 4586: self.log.info('I/O error %s device %s action %i ignored',
just a nit, this should probably be an error since the current libvirt list of
events have only pause and report.
As you prefer.
Line 4587: err, blockDevAlias, action)
Line 4588:
Line 4589: def _acpiShutdown(self):
Line 4590:
self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
Francesco Romani has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/2/vdsm/vm.py
File vdsm/vm.py:
Line 4582: elif action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_REPORT:
Line 4583: self.log.info('I/O error %s device %s reported to guest
OS',
Line 4584: err, blockDevAlias)
Line 4585: else:
Line 4586: self.log.info('I/O error %s device %s action %i ignored',
just a nit, this should probably be an error since the current libvirt list
I think you are right. Will change.
Line 4587: err, blockDevAlias, action)
Line 4588:
Line 4589: def _acpiShutdown(self):
Line 4590:
self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: consider 'action' when handling I/O errors
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7337/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6553/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7455/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
