Change in vdsm[master]: vm: prevent faulty volume extensions
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: prevent faulty volume extensions .. vm: prevent faulty volume extensions Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443 Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Signed-off-by: Federico Simoncelli Signed-off-by: Yeela Kaplan Reviewed-on: http://gerrit.ovirt.org/21150 Reviewed-by: Sergey Gotliv Reviewed-by: Ayal Baron Reviewed-by: Allon Mureinik --- M vdsm/vm.py 1 file changed, 33 insertions(+), 2 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Federico Simoncelli: Verified Sergey Gotliv: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: -Code-Review (1 comment) File vdsm/vm.py Line 2291: Line 2292: # Since the check based on nextPhysSize is extremly risky (it Line 2293: # may result in the VM being paused) we can't use the regular Line 2294: # getNextVolumeSize call as it relies on a cached value of the Line 2295: # drive apparentsize. Using getNextVolumeSize() for extend attempts is fine, as it is retries until apparentsize is either updated or ignored. Here the situation is much riskier since if we stop a VM needlessly it's pretty much dead. Line 2296: nextPhysSize = physical + drive.VOLWM_CHUNK_MB * constants.MEGAB Line 2297: Line 2298: # NOTE: the intent of this check is to prevent faulty images to Line 2299: # trick qemu in requesting extremely large extensions (BZ#998443). -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: Code-Review-1 Don't merge yet. -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Dan Kenigsberg has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: (1 comment) File vdsm/vm.py Line 2291: Line 2292: # Since the check based on nextPhysSize is extremly risky (it Line 2293: # may result in the VM being paused) we can't use the regular Line 2294: # getNextVolumeSize call as it relies on a cached value of the Line 2295: # drive apparentsize. I do not understand this comment.. If getNextVolumeSize() is not to be trusted (why?) it should be fixed. It has only single other user. It would be very confusing to see nextPhysSize logged here, followed by a different newSize sent to spm. Line 2296: nextPhysSize = physical + drive.VOLWM_CHUNK_MB * constants.MEGAB Line 2297: Line 2298: # NOTE: the intent of this check is to prevent faulty images to Line 2299: # trick qemu in requesting extremely large extensions (BZ#998443). -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Allon Mureinik has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Sergey Gotliv has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: I am fine with that! -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: @Sergey, I didn't update the commit message because all the info are included as comments in the code. -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: Verified+1 Verified: regular highWrite, onAbnormalStop (enospc), end of file (reaching the full allocation for the qcow2 file) and the faulty extend using the stap script proposed in bz998443. -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Sergey Gotliv has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: Federico, I know that you verified it. Please, mark it as verified. -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Ayal Baron has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: Code-Review+2 yikes! -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Sergey Gotliv has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4572/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5372/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5451/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4558/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5358/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5437/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Sergey Gotliv has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 1:
(3 comments)
Commit message has to be more descriptive.
Commit Message
Line 4: Commit: Federico Simoncelli
Line 5: CommitDate: 2013-11-11 12:15:52 -0500
Line 6:
Line 7: vm: prevent faulty volume extensions
Line 8:
You have to explain more.
Line 9: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
Line 10: Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7
Line 11: Signed-off-by: Federico Simoncelli
Line 12: Signed-off-by: Sergey Gotliv
Line 8:
Line 9: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
Line 10: Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7
Line 11: Signed-off-by: Federico Simoncelli
Line 12: Signed-off-by: Sergey Gotliv
Thanks, but all credit is yours!
File vdsm/vm.py
Line 2294: # getNextVolumeSize call as it relies on a cached value
of the
Line 2295: # drive apparentsize.
Line 2296: nextPhysSize = physical + (
Line 2297: config.getint('irs', 'volume_utilization_chunk_mb') *
Line 2298: constants.MEGAB
We have a constant in the class Drive:
VOLWM_CHUNK_MB = config.getint('irs', 'volume_utilization_chunk_mb')
Line 2299: )
Line 2300:
Line 2301: # NOTE: the intent of this check is to prevent faulty
images to
Line 2302: # trick qemu in requesting extremely large extensions
(BZ#998443).
--
To view, visit http://gerrit.ovirt.org/21150
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Sergey Gotliv
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4539/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5339/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5418/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change. Change subject: vm: prevent faulty volume extensions .. Patch Set 1: (1 comment) Commit Message Line 9: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443 Line 10: Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Line 11: Signed-off-by: Federico Simoncelli Line 12: Signed-off-by: Sergey Gotliv Line 13: Signed-off-by: Federico Simoncelli I'll remove one of my two entries. -- To view, visit http://gerrit.ovirt.org/21150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: prevent faulty volume extensions
Hello Sergey Gotliv,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21150
to review the following change.
Change subject: vm: prevent faulty volume extensions
..
vm: prevent faulty volume extensions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7
Signed-off-by: Federico Simoncelli
Signed-off-by: Sergey Gotliv
Signed-off-by: Federico Simoncelli
---
M vdsm/vm.py
1 file changed, 36 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/21150/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index b39e5b9..75da883 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -2288,6 +2288,39 @@
continue
capacity, alloc, physical = self._dom.blockInfo(drive.path, 0)
+
+# Since the check based on nextPhysSize is extremly risky (it
+# may result in the VM being paused) we can't use the regular
+# getNextVolumeSize call as it relies on a cached value of the
+# drive apparentsize.
+nextPhysSize = physical + (
+config.getint('irs', 'volume_utilization_chunk_mb') *
+constants.MEGAB
+)
+
+# NOTE: the intent of this check is to prevent faulty images to
+# trick qemu in requesting extremely large extensions (BZ#998443).
+# Probably the definitive check would be comparing the allocated
+# space with capacity + format_overhead. Anyway given that:
+#
+# - format_overhead is tricky to be computed (it depends on few
+# assumptions that may change in the future e.g. cluster size)
+# - currently we allow only to extend by one chunk at time
+#
+# the current check compares alloc with the next volume size.
+# It should be noted that alloc cannot be directly compared with
+# the volume physical size as it includes also the clusters not
+# written yet (pending).
+if alloc > nextPhysSize:
+self.log.error(
+"Improbable extension request for volume %s on domain "
+"%s, pausing the VM to avoid corruptions (capacity: %s, "
+"allocated: %s, physical: %s, next physical size: %s)",
+drive.volumeID, drive.domainID, capacity, alloc,
+physical, nextPhysSize)
+self.pause(pauseCode='EOTHER')
+return False
+
if physical - alloc < drive.watermarkLimit:
extend.append((drive, capacity, alloc, physical))
@@ -2438,12 +2471,13 @@
if not guestCpuLocked:
self._guestCpuLock.release()
-def pause(self, afterState='Paused', guestCpuLocked=False):
+def pause(self, afterState='Paused', guestCpuLocked=False,
+ pauseCode='NOERR'):
if not guestCpuLocked:
self._acquireCpuLockWithTimeout()
try:
with self._confLock:
-self.conf['pauseCode'] = 'NOERR'
+self.conf['pauseCode'] = pauseCode
self._underlyingPause()
if hasattr(self, 'updateGuestCpuRunning'):
self.updateGuestCpuRunning()
--
To view, visit http://gerrit.ovirt.org/21150
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7e85c50f375ed7ed0297330b8cd83e38e0986c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
Gerrit-Reviewer: Sergey Gotliv
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
