Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/556/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/933/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/970/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/552/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/968/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/565/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/110/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/110/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/42/ : 0 -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: Build Started (9/9) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/42/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/110/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/110/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/565/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/968/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/933/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/552/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/556/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/970/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
Dan Kenigsberg has submitted this change and it was merged. Change subject: vmdevices: factor out default disk interfaces to storage .. vmdevices: factor out default disk interfaces to storage One step in an ongoing effort to isolate device functionality. Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/40127 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M vdsm/virt/vm.py M vdsm/virt/vmdevices/storage.py 2 files changed, 14 insertions(+), 9 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
automat...@ovirt.org has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
Dan Kenigsberg has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
Francesco Romani has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 4: Code-Review+1 was good enough already, now's even better. Thanks! -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18285/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1515/ : 0 -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18284/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1514/ : 0 -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 4: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1515/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 3: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1514/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 4: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18285/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18284/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
Martin Polednik has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 4: Verified+1 Addresed fromani's nit -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
automat...@ovirt.org has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
automat...@ovirt.org has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
Francesco Romani has posted comments on this change.
Change subject: vmdevices: factor out default disk interfaces to storage
..
Patch Set 2: Code-Review+1
(1 comment)
only a minor style nit inside
https://gerrit.ovirt.org/#/c/40127/2/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 29: from .core import Base
Line 30:
Line 31: DEFAULT_INTERFACE_FOR_ARCH = {caps.Architecture.X86_64: 'ide',
Line 32: caps.Architecture.PPC64: 'scsi',
Line 33: caps.Architecture.PPC64LE: 'scsi'}
slightly better:
DEFAULT_INTERFACE_FOR_ARCH = {
caps.Architecture.X86_64: 'ide',
caps.Architecture.PPC64: 'scsi',
caps.Architecture.PPC64LE: 'scsi'
}
easier to add/remove new key/values pairs.
But not that important.
Line 34:
Line 35:
Line 36: class DRIVE_SHARED_TYPE:
Line 37: NONE = "none"
--
To view, visit https://gerrit.ovirt.org/40127
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
Dan Kenigsberg has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
Martin Polednik has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 2: Verified+1 Verified mostly manually by testing each of 3 occurences for unchanged behavior. -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18037/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1266/ : 0 -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 2: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1266/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
automat...@ovirt.org has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18037/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
Vinzenz Feenstra has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
Francesco Romani has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 1: I agree to move this away from vm.py. It may be debatable if this belongs here or in another module. I'm inclined to believe this is the best place. -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18162/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17990/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1219/ : 0 -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
Martin Polednik has uploaded a new change for review.
Change subject: vmdevices: factor out default disk interfaces to storage
..
vmdevices: factor out default disk interfaces to storage
One step in an ongoing effort to isolate device functionality.
Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b
Signed-off-by: Martin Polednik
---
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 12 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/40127/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 331cfcd..8dabd9b 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -662,12 +662,6 @@
def _makeChannelPath(self, deviceName):
return constants.P_LIBVIRT_VMCHANNELS + self.id + '.' + deviceName
-def _getDefaultDiskInterface(self):
-DEFAULT_DISK_INTERFACES = {caps.Architecture.X86_64: 'ide',
- caps.Architecture.PPC64: 'scsi',
- caps.Architecture.PPC64LE: 'scsi'}
-return DEFAULT_DISK_INTERFACES[self.arch]
-
def __init__(self, cif, params, recover=False):
"""
Initialize a new VM instance.
@@ -824,7 +818,7 @@
removables = [{
'type': hwclass.DISK,
'device': 'cdrom',
-'iface': self._getDefaultDiskInterface(),
+'iface': vmdevices.storage.DEFAULT_INTERFACE_FOR_ARCH[self.arch],
'path': self.conf.get('cdrom', ''),
'index': 2,
'truesize': 0}]
@@ -1035,7 +1029,9 @@
# FIXME: For BC we have now two identical keys: iface = if
# Till the day that conf will not returned as a status anymore.
drv['iface'] = drv.get('iface') or \
-drv.get('if', self._getDefaultDiskInterface())
+drv.get(
+'if',
+vmdevices.storage.DEFAULT_INTERFACE_FOR_ARCH[self.arch])
return confDrives
@@ -4409,7 +4405,8 @@
knownDev = True
# Add unknown disk device to vm's conf
if not knownDev:
-archIface = self._getDefaultDiskInterface()
+archIface = vmdevices.storage.\
+DEFAULT_INTERFACE_FOR_ARCH[self.arch]
iface = archIface if address['type'] == 'drive' else 'pci'
diskDev = {'type': hwclass.DISK, 'device': devType,
'iface': iface, 'path': devPath, 'name': name,
diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py
index 82642d3..19531d8 100644
--- a/vdsm/virt/vmdevices/storage.py
+++ b/vdsm/virt/vmdevices/storage.py
@@ -18,6 +18,8 @@
# Refer to the README and COPYING files for full details of the license
#
+import caps
+
from vdsm.config import config
from vdsm import constants
from vdsm import utils
@@ -26,6 +28,10 @@
from .core import Base
+DEFAULT_INTERFACE_FOR_ARCH = {caps.Architecture.X86_64: 'ide',
+ caps.Architecture.PPC64: 'scsi',
+ caps.Architecture.PPC64LE: 'scsi'}
+
class DRIVE_SHARED_TYPE:
NONE = "none"
--
To view, visit https://gerrit.ovirt.org/40127
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 1: Build Started (3/3) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1219/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 1: Build Started (1/3) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17990/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 1: Build Started (2/3) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18162/ -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: factor out default disk interfaces to storage
automat...@ovirt.org has posted comments on this change. Change subject: vmdevices: factor out default disk interfaces to storage .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a478202224284cb7ba5c5ec28ab0d75a2b0e4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
