Change in vdsm[master]: volume: Fix exception re-rasing
Yeela Kaplan has posted comments on this change. Change subject: volume: Fix exception re-rasing .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
Dan Kenigsberg has posted comments on this change. Change subject: volume: Fix exception re-rasing .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
Dan Kenigsberg has submitted this change and it was merged. Change subject: volume: Fix exception re-rasing .. volume: Fix exception re-rasing When re-raising and excepition, the correct way is: raise And not: raise e The later form create a new useless traceback, strating at the point were the exception was re-raised: Traceback (most recent call last): File raise.py, line 14, in module raise e Exception: testing Instead of the original traceback, showing the original call stack: Traceback (most recent call last): File raise.py, line 11, in module a() File raise.py, line 2, in a b() File raise.py, line 5, in b c() File raise.py, line 8, in c raise Exception(testing) Exception: testing Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33556 Reviewed-by: Yeela Kaplan ykap...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/volume.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Yeela Kaplan: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: Fix exception re-rasing .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/253/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5886/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4046/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/56/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/52/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/58/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/32/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: Fix exception re-rasing .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11747/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12691/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12536/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
Nir Soffer has uploaded a new change for review. Change subject: volume: Fix exception re-rasing .. volume: Fix exception re-rasing When re-raising and excepition, the correct way is: raise And not: raise e The later form create a new useless traceback, strating at the point were the exception was re-raised: Traceback (most recent call last): File raise.py, line 14, in module raise e Exception: testing Instead of the original traceback, showing the original call stack: Traceback (most recent call last): File raise.py, line 11, in module a() File raise.py, line 2, in a b() File raise.py, line 5, in b c() File raise.py, line 8, in c raise Exception(testing) Exception: testing Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Signed-off-by: Nir Soffer nsof...@redhat.com --- M vdsm/storage/volume.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/33556/1 diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py index 13bd256..0f9b335 100644 --- a/vdsm/storage/volume.py +++ b/vdsm/storage/volume.py @@ -437,7 +437,7 @@ cls.log.error(Failed to create volume: %s, volume already exists, volPath) vars.task.popRecovery() -raise e +raise # When the volume format is raw what the guest sees is the apparent # size of the file/device therefore if the requested size doesn't # match the apparent size (eg: physical extent granularity in LVM) -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
Nir Soffer has posted comments on this change. Change subject: volume: Fix exception re-rasing .. Patch Set 1: Verified+1 Verified by eye. -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
