Change in vdsm[ovirt-3.3]: domainMonitor: Log unhandled exceptions in domain monitor th...
Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: Log unhandled exceptions in domain monitor th...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread .. domainMonitor: Log unhandled exceptions in domain monitor thread DomainMonitorThread does not handle exceptions in the thread main function, making it harder to modify the code or understanding unexpected failures in the field. The patch log unhandled exceptions so it will never die silently. Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Bug-Url: https://bugzilla.redhat.com/1040166 Relates-To: https://bugzilla.redhat.com/1034741 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21487 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22214 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/storage/domainMonitor.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: Log unhandled exceptions in domain monitor th...
Yaniv Bronhaim has posted comments on this change. Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: Log unhandled exceptions in domain monitor th...
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread .. Patch Set 2: Verified+1 Rebase on dependent patch, add bug url and verify. -- To view, visit http://gerrit.ovirt.org/22214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: Log unhandled exceptions in domain monitor th...
Hello Federico Simoncelli, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22214 to review the following change. Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread .. domainMonitor: Log unhandled exceptions in domain monitor thread DomainMonitorThread does not handle exceptions in the thread main function, making it harder to modify the code or understanding unexpected failures in the field. The patch log unhandled exceptions so it will never die silently. Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Relates-To: https://bugzilla.redhat.com/1034741 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21487 Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/domainMonitor.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/22214/1 diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py index ac01e8b..09952b8 100644 --- a/vdsm/storage/domainMonitor.py +++ b/vdsm/storage/domainMonitor.py @@ -24,6 +24,7 @@ import logging import misc +from vdsm import utils from vdsm.config import config from sdc import sdCache @@ -152,6 +153,7 @@ def getStatus(self): return self.status.copy() +@utils.traceback(on=log.name) def _monitorLoop(self): self.log.debug(Starting domain monitor for %s, self.sdUUID) -- To view, visit http://gerrit.ovirt.org/22214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: Log unhandled exceptions in domain monitor th...
Yaniv Bronhaim has posted comments on this change. Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread .. Patch Set 1: (1 comment) Commit Message Line 12: Line 13: The patch log unhandled exceptions so it will never die silently. Line 14: Line 15: Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Line 16: Relates-To: https://bugzilla.redhat.com/1034741 didn't you mention something about ovirt bug for it? Line 17: Signed-off-by: Nir Soffer nsof...@redhat.com Line 18: Reviewed-on: http://gerrit.ovirt.org/21487 -- To view, visit http://gerrit.ovirt.org/22214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
