Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-14 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 2:

* #1337882::Update tracker: OK
* Set MODIFIED::bug 1337882#1337882FAILED, illegal change from ON_QA

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-14 Thread fromani 
Francesco Romani has submitted this change and it was merged.

Change subject: Configure mom to ignore missing balloon device
..


Configure mom to ignore missing balloon device

In the past MOM was only responsible for ballooning. But now it also
manages some CPU and storage QoS settings. When there is no ballooning
device on the VM, MOM completely ignores that VM and therefore does not
set QoS attributes for CPU and storage.

Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1337882
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/57796
Reviewed-by: Roman Mohr 
Reviewed-by: Roy Golan 
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
(cherry picked from commit 77e45363ffbafe3e4edae313adb49b1dfc7a8bfe)
Reviewed-on: https://gerrit.ovirt.org/59058
Reviewed-on: https://gerrit.ovirt.org/60524
---
M vdsm.spec.in
M vdsm/mom.conf.in
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Martin Sivák: Verified
  Roman Mohr: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-12 Thread msivak 
Martin Sivák has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1:

mom-0.5.4 is present in rhevm-3.6-rhel-7 and I was told we only support RHEL 7 
hosts in 3.6. mom-0.5.5 is also tagged for 3.6, but candidate only atm.

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1:

Do we have MOM 0.5.4 packages in the 3.6 channels? Do we need to support RHEL6 
(asking, not sure)?

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-11 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-11 Thread rmohr 
Roman Mohr has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-11 Thread msivak 
Martin Sivák has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-11 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1:

* #1337882::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1337882::OK, public bug
* Check Product::#1337882::OK, Correct classification oVirt
* Check TM::#1337882::OK, correct target milestone ovirt-3.6.8
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

2016-07-11 Thread msivak 
Hello Roman Mohr, Dan Kenigsberg, Francesco Romani, Roy Golan,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/60524

to review the following change.

Change subject: Configure mom to ignore missing balloon device
..

Configure mom to ignore missing balloon device

In the past MOM was only responsible for ballooning. But now it also
manages some CPU and storage QoS settings. When there is no ballooning
device on the VM, MOM completely ignores that VM and therefore does not
set QoS attributes for CPU and storage.

Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1337882
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/57796
Reviewed-by: Roman Mohr 
Reviewed-by: Roy Golan 
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
(cherry picked from commit 77e45363ffbafe3e4edae313adb49b1dfc7a8bfe)
Reviewed-on: https://gerrit.ovirt.org/59058
---
M vdsm.spec.in
M vdsm/mom.conf.in
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/60524/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 58ad541..142e2e1 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -84,7 +84,7 @@
 BuildRequires: libselinux-python
 BuildRequires: libvirt-python
 BuildRequires: m2crypto
-BuildRequires: mom >= 0.5.3
+BuildRequires: mom >= 0.5.4
 BuildRequires: openssl
 BuildRequires: policycoreutils-python
 BuildRequires: psmisc
diff --git a/vdsm/mom.conf.in b/vdsm/mom.conf.in
index fbcb56a..0388162 100644
--- a/vdsm/mom.conf.in
+++ b/vdsm/mom.conf.in
@@ -81,4 +81,4 @@
 
 [guest]
 # A comma-separated list of Collector plugins to use for Guest data collection.
-collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloon, GuestCpuTune, 
GuestIoTune
+collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloonOptional, 
GuestCpuTune, GuestIoTune


-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org