RE: patch to if_perl.xs
The terser version looks OK to me. --Suresh --~--~-~--~~~---~--~~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: patch to if_perl.xs
Suresh Govindachar wrote: > *** if_perl.xsFri Sep 14 09:31:10 2007 > --- if_perl_patched.xsFri Sep 14 09:47:38 2007 > *** [...] How about making it a bit simpler: *** ../vim-7.1.108/src/if_perl.xs Thu Sep 13 15:19:32 2007 --- src/if_perl.xs Fri Sep 14 21:23:38 2007 *** *** 48,60 * The changes include addition of two symbols (Perl_sv_2iv_flags, * Perl_newXS_flags) not present in earlier releases. * ! * Jan Dubois suggested the following guarding scheme: */ ! #if (ACTIVEPERL_VERSION >= 822) ! # define PERL589_OR_LATER ! #endif ! #if (PERL_REVISION == 5) && (PERL_VERSION == 8) && (PERL_SUBVERSION >= 9) ! # define PERL589_OR_LATER #endif #if (PERL_REVISION == 5) && (PERL_VERSION >= 9) # define PERL589_OR_LATER --- 48,62 * The changes include addition of two symbols (Perl_sv_2iv_flags, * Perl_newXS_flags) not present in earlier releases. * ! * Jan Dubois suggested the following guarding scheme. ! * ! * Active State defined ACTIVEPERL_VERSION as a string in versions before ! * 5.8.8; and so the comparison to 822 below needs to be guarded. */ ! #if (PERL_REVISION == 5) && (PERL_VERSION == 8) && (PERL_SUBVERSION >= 8) ! # if (ACTIVEPERL_VERSION >= 822) || (PERL_SUBVERSION >= 9) ! # define PERL589_OR_LATER ! # endif #endif #if (PERL_REVISION == 5) && (PERL_VERSION >= 9) # define PERL589_OR_LATER -- ARTHUR: You fight with the strength of many men, Sir knight. I am Arthur, King of the Britons. [pause] I seek the finest and the bravest knights in the land to join me in my Court of Camelot. [pause] You have proved yourself worthy; will you join me? [pause] You make me sad. So be it. Come, Patsy. BLACK KNIGHT: None shall pass. The Quest for the Holy Grail (Monty Python) /// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\download, build and distribute -- http://www.A-A-P.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// --~--~-~--~~~---~--~~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: vimgrep/j messes up folds
A.Politz wrote: > Have 2 files, both with foldmarkers. > A viminfo file, with a mark of > file2. > > $ cat .vimrc > > set nocp > set fdm=marker > "This is a suggested (simplified) autocmd from vimrc_example > autocmd BufReadPost * normal g`" > > $ vim -U NONE --noplugin file1 > :vimgrep /foo/j file2 > > Now file1 has the folds set as if it were file2. I see the problem. I'll make a patch. -- ARTHUR:I command you as King of the Britons to stand aside! BLACK KNIGHT: I move for no man. The Quest for the Holy Grail (Monty Python) /// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\download, build and distribute -- http://www.A-A-P.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// --~--~-~--~~~---~--~~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
patch 7.1.108
Patch 7.1.108 (after 7.1.100)
Problem:Win32: Compilation problems in Cscope code. (Jeff Lanzarotta)
Solution: Use (long) instead of (intptr_t) when it's not defined.
Files: src/if_cscope.c
*** ../vim-7.1.107/src/if_cscope.c Thu Sep 6 17:38:06 2007
--- src/if_cscope.c Wed Sep 12 20:32:17 2007
***
*** 726,731
--- 726,740
HANDLEstdin_rd, stdout_rd;
HANDLEstdout_wr, stdin_wr;
BOOL created;
+ # ifdef __BORLANDC__
+ # define OPEN_OH_ARGTYPE long
+ # else
+ # if (_MSC_VER >= 1300)
+ # define OPEN_OH_ARGTYPE intptr_t
+ # else
+ # define OPEN_OH_ARGTYPE long
+ # endif
+ # endif
#endif
#if defined(UNIX)
***
*** 909,918
CloseHandle(pi.hThread);
/* TODO - tidy up after failure to create files on pipe handles. */
! if (((fd = _open_osfhandle((intptr_t)stdin_wr, _O_TEXT|_O_APPEND)) < 0)
|| ((csinfo[i].to_fp = _fdopen(fd, "w")) == NULL))
PERROR(_("cs_create_connection: fdopen for to_fp failed"));
! if (((fd = _open_osfhandle((intptr_t)stdout_rd, _O_TEXT|_O_RDONLY)) < 0)
|| ((csinfo[i].fr_fp = _fdopen(fd, "r")) == NULL))
PERROR(_("cs_create_connection: fdopen for fr_fp failed"));
--- 918,929
CloseHandle(pi.hThread);
/* TODO - tidy up after failure to create files on pipe handles. */
! if (((fd = _open_osfhandle((OPEN_OH_ARGTYPE)stdin_wr,
! _O_TEXT|_O_APPEND)) < 0)
|| ((csinfo[i].to_fp = _fdopen(fd, "w")) == NULL))
PERROR(_("cs_create_connection: fdopen for to_fp failed"));
! if (((fd = _open_osfhandle((OPEN_OH_ARGTYPE)stdout_rd,
! _O_TEXT|_O_RDONLY)) < 0)
|| ((csinfo[i].fr_fp = _fdopen(fd, "r")) == NULL))
PERROR(_("cs_create_connection: fdopen for fr_fp failed"));
*** ../vim-7.1.107/src/version.cThu Sep 13 22:40:47 2007
--- src/version.c Fri Sep 14 19:55:12 2007
***
*** 668,669
--- 668,671
{ /* Add new patch number below this line */
+ /**/
+ 108,
/**/
--
Q: How many hardware engineers does it take to change a lightbulb?
A: None. We'll fix it in software.
/// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\download, build and distribute -- http://www.A-A-P.org///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--~--~-~--~~~---~--~~
You received this message from the "vim_dev" maillist.
For more information, visit http://www.vim.org/maillist.php
-~--~~~~--~~--~--~---
RE: Error when compiling with Perl interface and Borland C++ 5.5.1
Patrick Texier > > I can add a test for vim compilation > in [perl\lib\core\BuildInfo.h] file. Don't modify perl files; I sent a patch for vim's if_perl.xs -- try that, and let us know if it works. Thanks, --Suresh --~--~-~--~~~---~--~~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Error when compiling with Perl interface and Borland C++ 5.5.1
On Fri, 14 Sep 2007 07:57:56 -0700, Suresh Govindachar wrote in <[EMAIL PROTECTED]>: > > I had removed this bloc, test result must be negative. > > "had" or "have"? If you had removed some code and then ran into issues, ... After errors. > Please let me know what your perl\lib\core\BuildInfo.h defines > defines ACTIVEPERL_VERSION to be. > > I suspect the problem is that your perl\lib\core\BuildInfo.h > defines ACTIVEPERL_VERSION as a string: > >#define ACTIVEPERL_VERSION "Built " __DATE__ " " __TIME__ Thanks Suresh, it is the exact line, I have for ActivePerl version: #define PRODUCT_BUILD_NUMBER"811" #define PERLFILEVERSION "5,8,6,811\0" #define PERLRC_VERSION 5,8,6,811 #define ACTIVEPERL_VERSION "Built " __DATE__ " " __TIME__ #define ACTIVEPERL_LOCAL_PATCHES_ENTRY "ActivePerl Build " PRODUCT_BUILD_NUMBER ACTIVEPERL_CHANGELIST I can add a test for vim compilation in this file. -- Patrick Texier --~--~-~--~~~---~--~~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
patch to if_perl.xs
*** if_perl.xs Fri Sep 14 09:31:10 2007 --- if_perl_patched.xs Fri Sep 14 09:47:38 2007 *** *** 50,63 * * Jan Dubois suggested the following guarding scheme: */ ! #if (ACTIVEPERL_VERSION >= 822) ! # define PERL589_OR_LATER #endif #if (PERL_REVISION == 5) && (PERL_VERSION == 8) && (PERL_SUBVERSION >= 9) ! # define PERL589_OR_LATER #endif #if (PERL_REVISION == 5) && (PERL_VERSION >= 9) ! # define PERL589_OR_LATER #endif #ifndef pTHX --- 50,72 * * Jan Dubois suggested the following guarding scheme: */ ! /* ! * Active State defined ACTIVEPERL_VERSION as a string in older ! * versions; and so the comparison to 822 below needs to be guarded. ! * Googling shows ACTIVEPERL_VERSION as a number in 5.8.7 build 813; ! * and we are only concerned with later buids of 5.8.8 -- so ! * the following guard should do the job. ! */ ! #if (PERL_REVISION == 5) && (PERL_VERSION == 8) && (PERL_SUBVERSION >= 8) ! # if (ACTIVEPERL_VERSION >= 822) ! #define PERL589_OR_LATER ! # endif #endif #if (PERL_REVISION == 5) && (PERL_VERSION == 8) && (PERL_SUBVERSION >= 9) ! # define PERL589_OR_LATER #endif #if (PERL_REVISION == 5) && (PERL_VERSION >= 9) ! # define PERL589_OR_LATER #endif #ifndef pTHX --~--~-~--~~~---~--~~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Handling Unicode codepoints outside the BMP
> (the last screenshot shows that the "new" character is drawn twice: > once at its original position, and once one to the right). The file I > used for testing is attached. FWIW, it's in utf8. --~--~-~--~~~---~--~~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Handling Unicode codepoints outside the BMP
Hi, > I just tested the X11 and Gtk1 in my Debian box. X11 front-end failed > to compile. Gtk1 front-end compiled OK, but doesn't work properly. I'm > afraid I'll not be able to make these two "so old" front-ends work > properly. > > Could you just send out the first patch for screen.c first? Then all > the other front-ends, including GTK2, GNOME2, Windows, will work fine. I tested the screen.c-only patch on ubuntu (terminal and gui), os x (terminal and gui) and windows (gui only), with the default os settings. Encoding was set to utf8, and everything was compiled with --enable-multibyte. By default, neither ubuntu nor windows seem to have unicode fonts installed. Results look good on osx, okayish for gtk and windows gui (both have some redraw problems, but nothing serious. And this problems also occur with some BMP characters that are already supported at the moment). gtk terminal (well -- ubuntu terminal :-P) however doesn't display characters >= 0x1 at all. `cat` doesn't display them either, so this might not be critical. Screenshots are here: http://amnoid.de/tmp/osxgui.png http://amnoid.de/tmp/osxterm.png http://amnoid.de/tmp/gtkgui.png http://amnoid.de/tmp/gtkterm.png http://amnoid.de/tmp/windraw.png http://amnoid.de/tmp/winredraw.png (the last screenshot shows that the "new" character is drawn twice: once at its original position, and once one to the right). The file I used for testing is attached. I'd vote for using this patch and working on the display problems after that (except for the windows case, these display problems already exist with the current version, as the first line in all screenshots shows). Nico --~--~-~--~~~---~--~~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~--- asdfsdfâasdf asdfAasdf asdfãasdfsdf asdfãasdf asdfＡsdf ð´ asdf
RE: Error when compiling with Perl interface and Borland C++ 5.5.1
Patrick Texier wrote: > Hello, > > I'm compiling Vim CVS 7.1.107 (Huge version) using Borland C++ 5.5.1 on > Windows 98. My Active Perl version is 5.8.6 build 811. > > I have the following messages (and some others warnings): > > = Output === > C:\vim71\src>make -f Make_bc5.mak > MAKE Version 5.2 Copyright (c) 1987, 2000 Borland Compiling WIN32 gvim.exe , with: GUI OLE MBYTE IME(dynamic) GETTEXT ICONV CSCOPE NETBEANS PERL cpu=-3 Align=-a4 > > c:\Borland\bcc55\BIN\Bcc32 +WIN32\oleobj\bcc.cfg -c -oWIN32\oleobj\if_perl.obj -pc if_perl.c Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland > if_perl.c: > Error E2313 if_perl.xs 53: Constant expression required Error E2293 if_perl.xs 53: ) expected > *** 2 errors in Compile *** > ** error 1 ** deleting WIN32\oleobj\if_perl.obj === > > line 53 is: > #if (ACTIVEPERL_VERSION >= 822) > > I had removed this bloc, test result must be negative. "had" or "have"? If you had removed some code and then ran into issues, ... Please let me know what your perl\lib\core\BuildInfo.h defines defines ACTIVEPERL_VERSION to be. I suspect the problem is that your perl\lib\core\BuildInfo.h defines ACTIVEPERL_VERSION as a string: #define ACTIVEPERL_VERSION "Built " __DATE__ " " __TIME__ --Suresh --~--~-~--~~~---~--~~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Error when compiling with Perl interface and Borland C++ 5.5.1
Hello, I'm compiling Vim CVS 7.1.107 (Huge version) using Borland C++ 5.5.1 on Windows 98. My Active Perl version is 5.8.6 build 811. I have the following messages (and some others warnings): = Output === C:\vim71\src>make -f Make_bc5.mak MAKE Version 5.2 Copyright (c) 1987, 2000 Borland Compiling WIN32 gvim.exe , with: GUI OLE MBYTE IME(dynamic) GETTEXT ICONV CSCOPE NETBEANS PERL cpu=-3 Align=-a4 c:\Borland\bcc55\BIN\Bcc32 +WIN32\oleobj\bcc.cfg -c -oWIN32\oleobj\if_perl.obj -pc if_perl.c Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland if_perl.c: Error E2313 if_perl.xs 53: Constant expression required Error E2293 if_perl.xs 53: ) expected *** 2 errors in Compile *** ** error 1 ** deleting WIN32\oleobj\if_perl.obj === line 53 is: #if (ACTIVEPERL_VERSION >= 822) I had removed this bloc, test result must be negative. -- Patrick Texier --~--~-~--~~~---~--~~ You received this message from the "vim_dev" maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
