Re: 8.0.1438: Test Failure

[Elimar Riesebieter]

* Bram Moolenaar  [2018-01-29 16:24 +0100]:

> 
> Elimar Riesebieter wrote:
> 
> > This is 8.0.1438
> > 
> > From test_alot.vim:
> > Found errors in Test_filetype_detection():
> > function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: 
> > with file name: /.config/git/config: Expected 'gitconfig' but got ''
> > function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: 
> > with file name: /.config/upstart/file.conf: Expected 'upstart' but got ''
> > function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: 
> > with file name: /.config/upstart/file.override: Expected 'upstart' but got 
> > ''
> > TEST FAILURE
> 
> Does the test somehow pick up something from your local configuration?
> The test passes for me and also on both the CI platforms.

There was /.config. Don't know why...

Removed it and all went fine ;-)

Sorry for the noise
Elimar
-- 
.~.
/V\   L   I   N   U   X
   /( )\ >Phear the Penguin<
   ^^-^^

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: cscope: vim hangs when a tag is not found

[Bram Moolenaar]

Safouane Baroudi wrote:

> When a tag is not found, cscope return the string "Unable to search
> database." but the cs_cnt_matches() does not handle this case.
> 
> cs_cnt_matches():
>   When cscope does not find a tag, it returns "Unable to search
>   database", and thus:
> if (strstr((const char *)stok, "cscope:") == NULL)
>   continue;
>   becomes:
> if (strstr((const char *)stok, "cscope:") == NULL)
>   break;
>   and return nlines which must be initialized at zero.
>   Continuing does not make sens, and result in a buffer underflow on my
>   machine when the loop calls fgets for the second time.
> 
> cscope version: 15.8b
> vim version: v8.0.1437 (cloned from git)
> uname -r: 4.9.65
> 
> below is attached my git patch.
> 
> This is my first public patch ever in any project so I am new to this
> kind of thing and I am a total newbie, I am waiting for your remarks.

The comments indicate that Cscope sometimes adds lines before the line
with the count.  With your change this would cause the count not to be
found.

How about specifically checking for the "Unable to search database"
message and break out of the loop then?  Could this message be
translated?

-- 
ARTHUR: This new learning amazes me, Sir Bedevere.  Explain again how sheep's
bladders may be employed to prevent earthquakes.
 "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: 8.0.1438: Test Failure

[Bram Moolenaar]

Elimar Riesebieter wrote:

> This is 8.0.1438
> 
> From test_alot.vim:
> Found errors in Test_filetype_detection():
> function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: with 
> file name: /.config/git/config: Expected 'gitconfig' but got ''
> function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: with 
> file name: /.config/upstart/file.conf: Expected 'upstart' but got ''
> function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: with 
> file name: /.config/upstart/file.override: Expected 'upstart' but got ''
> TEST FAILURE

Does the test somehow pick up something from your local configuration?
The test passes for me and also on both the CI platforms.

-- 
hundred-and-one symptoms of being an internet addict:
10E. You start counting in hex.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: 8.0.1438: Test Failure

[Bram Moolenaar]

Elimar Riesebieter wrote:

> This is 8.0.1438
> 
> From test_alot.vim:
> Found errors in Test_filetype_detection():
> function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: with 
> file name: /.config/git/config: Expected 'gitconfig' but got ''
> function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: with 
> file name: /.config/upstart/file.conf: Expected 'upstart' but got ''
> function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: with 
> file name: /.config/upstart/file.override: Expected 'upstart' but got ''
> TEST FAILURE

Does the test somehow pick up something from your local configuration?
The test passes for me and also on both the CI platforms.

-- 
hundred-and-one symptoms of being an internet addict:
10E. You start counting in hex.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: 8.0.1438: Test Failure

[Elimar Riesebieter]

* Elimar Riesebieter  [2018-01-29 12:56 +0100]:

[...] > 
> > So, could you tell us more about your OS and environments?
[...] 

To reproduce: cd to source dir.

$ CXX=/usr/bin/clang++-5.0 CC=/usr/bin/clang-5.0 ./configure 
--with-features=huge  --enable-gui=athena
$ make
$ cd src/testdir
$ make 

The binaries of clang maybe have to be adjusted to your
environment. Anyway the failure occurs with gcc 7.3 as well.

> Elimar
> -- 
>   The path to source is always uphill!
> -unknown-
> 
> -- 
> -- 
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
> 
> --- 
> You received this message because you are subscribed to the Google Groups 
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
> 

-- 
  Alles, was viel bedacht wird, wird bedenklich!;-)
 Friedrich Nietzsche

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: 8.0.1438: Test Failure

[Elimar Riesebieter]

* Kazunobu Kuriyama  [2018-01-29 20:37 +0900]:

> 2018-01-29 19:35 GMT+09:00 Elimar Riesebieter :
> 
> > This is 8.0.1438
> >
> > From test_alot.vim:
> > Found errors in Test_filetype_detection():
> > function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9:
> > with file name: /.config/git/config: Expected 'gitconfig' but got ''
> > function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9:
> > with file name: /.config/upstart/file.conf: Expected 'upstart' but got ''
> > function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9:
> > with file name: /.config/upstart/file.override: Expected 'upstart' but
> > got ''
> > TEST FAILURE
> >
> >
> > Elimar
> >
> 
> As you can see with
> 
> https://travis-ci.org/vim/vim/builds/334601526 and
> https://ci.appveyor.com/project/chrisbra/vim/build/4822
> 
> those CI tests gave all green to the patch in question.
> 
> The tests were done on Linux, macOS and Windows.
> 
> So, could you tell us more about your OS and environments?

OS => Debian sid
Kernel: 4.15.0
Compiler: clang-5.0

Feature list extracted from the successful binary:
Variant:on with X11-Athena GUI.  Features included (+) or not (-):
+acl   +farsi +mouse_sgr -tag_any_white
+arabic+file_in_path  -mouse_sysmouse+tcl
+autocmd   +find_in_path  +mouse_urxvt   +termguicolors
+autoservername+float +mouse_xterm   +terminal
+balloon_eval  +folding   +multi_byte+terminfo
+balloon_eval_term -footer+multi_lang+termresponse
+browse+fork()-mzscheme  +textobjects
++builtin_terms+gettext   +netbeans_intg +timers
+byte_offset   -hangul_input  +num64 +title
+channel   +iconv +packages  +toolbar
+cindent   +insert_expand +path_extra+user_commands
+clientserver  +job   +perl  +vertsplit
+clipboard +jumplist  +persistent_undo   +virtualedit
+cmdline_compl +keymap+postscript+visual
+cmdline_hist  +lambda+printer   +visualextra
+cmdline_info  +langmap   +profile   +viminfo
+comments  +libcall   -python+vreplace
+conceal   +linebreak +python3   +wildignore
+cryptv+lispindent+quickfix  +wildmenu
+cscope+listcmds  +reltime   +windows
+cursorbind+localmap  +rightleft +writebackup
+cursorshape   +lua   +ruby  +X11
+dialog_con_gui+menu  +scrollbind+xfontset
+diff  +mksession +signs +xim
+digraphs  +modify_fname  +smartindent   +xpm
-dnd   +mouse +startuptime   +xsmp_interact
-ebcdic+mouseshape+statusline+xterm_clipboard
+emacs_tags+mouse_dec -sun_workshop  -xterm_save
+eval  +mouse_gpm +syntax
+ex_extra  -mouse_jsbterm +tag_binary
+extra_search  +mouse_netterm +tag_old_static

The bug is reproducible.

Elimar
-- 
  The path to source is always uphill!
-unknown-

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: 8.0.1438: Test Failure

[Kazunobu Kuriyama]

2018-01-29 19:35 GMT+09:00 Elimar Riesebieter :

> This is 8.0.1438
>
> From test_alot.vim:
> Found errors in Test_filetype_detection():
> function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9:
> with file name: /.config/git/config: Expected 'gitconfig' but got ''
> function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9:
> with file name: /.config/upstart/file.conf: Expected 'upstart' but got ''
> function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9:
> with file name: /.config/upstart/file.override: Expected 'upstart' but
> got ''
> TEST FAILURE
>
>
> Elimar
>

As you can see with

https://travis-ci.org/vim/vim/builds/334601526 and
https://ci.appveyor.com/project/chrisbra/vim/build/4822

those CI tests gave all green to the patch in question.

The tests were done on Linux, macOS and Windows.

So, could you tell us more about your OS and environments?

Also, as the patch doesn't touch anything other than pike, it is unlikely
for it to cause the failures above.  Could you make sure that they happen
only with it, but not with patches prior to it?

Kazunobu

--
>   From The Collaborative International Dictionary of English v.0.48
> [gcide]:
>   .
>   arsehole \arse"hole`\ ([aum]rs"h[=o]l`), n.
>  1. execretory opening at the end of the alimentary canal.
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

8.0.1438: Test Failure

[Elimar Riesebieter]

This is 8.0.1438

>From test_alot.vim:
Found errors in Test_filetype_detection():
function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: with 
file name: /.config/git/config: Expected 'gitconfig' but got ''
function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: with 
file name: /.config/upstart/file.conf: Expected 'upstart' but got ''
function RunTheTest[38]..Test_filetype_detection[2]..CheckItems line 9: with 
file name: /.config/upstart/file.override: Expected 'upstart' but got ''
TEST FAILURE


Elimar
-- 
  From The Collaborative International Dictionary of English v.0.48 [gcide]:
  .
  arsehole \arse"hole`\ ([aum]rs"h[=o]l`), n.
 1. execretory opening at the end of the alimentary canal.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Patch 8.0.1438

[Bram Moolenaar]

Patch 8.0.1438
Problem:Filetype detection test not updated for change.
Solution:   Update the test.
Files:  src/testdir/test_filetype.vim


*** ../vim-8.0.1437/src/testdir/test_filetype.vim   2017-10-26 
21:59:54.004362215 +0200
--- src/testdir/test_filetype.vim   2018-01-28 14:01:25.899589455 +0100
***
*** 323,329 
  \ 'pf': ['pf.conf'],
  \ 'pfmain': ['main.cf'],
  \ 'php': ['file.php', 'file.php9', 'file.phtml', 'file.ctp'],
! \ 'pike': ['file.pike', 'file.lpc', 'file.ulpc', 'file.pmod'],
  \ 'pilrc': ['file.rcp'],
  \ 'pine': ['.pinerc', 'pinerc', '.pinercex', 'pinercex'],
  \ 'pinfo': ['/etc/pinforc', '/.pinforc'],
--- 323,331 
  \ 'pf': ['pf.conf'],
  \ 'pfmain': ['main.cf'],
  \ 'php': ['file.php', 'file.php9', 'file.phtml', 'file.ctp'],
! \ 'lpc': ['file.lpc', 'file.ulpc'],
! \ 'pike': ['file.pike', 'file.pmod'],
! \ 'cmod': ['file.cmod'],
  \ 'pilrc': ['file.rcp'],
  \ 'pine': ['.pinerc', 'pinerc', '.pinercex', 'pinercex'],
  \ 'pinfo': ['/etc/pinforc', '/.pinforc'],
*** ../vim-8.0.1437/src/version.c   2018-01-28 22:48:50.046864267 +0100
--- src/version.c   2018-01-29 09:17:24.006763682 +0100
***
*** 773,774 
--- 773,776 
  {   /* Add new patch number below this line */
+ /**/
+ 1438,
  /**/

-- 
hundred-and-one symptoms of being an internet addict:
270. You are subscribed to a mailing list for every piece of software
 you use.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.