Re: Found errors in Test_xterm_mouse_middle_click()

2019-04-28 Fir de Conversatie Christian Brabandt


On So, 28 Apr 2019, Dominique Pellé wrote:
> I suppose that Test_xterm_mouse_middle_click() should be skipped
> if 'clipboard' feature is not available, since it uses register @*.
> 
> Please check that the attached patch.

Alternatively, you might simply source shared.vim and use the 
WorkingClipboard() function. 

Just a suggestion.

Best,
Christian
-- 
Alles in der Welt ist merkwürdig und wunderbar für ein paar
wohlgeöffnete Augen.
-- José Ortega y Gasset

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Found errors in Test_xterm_mouse_middle_click()

2019-04-28 Fir de Conversatie Elimar Riesebieter
* Dominique Pellé  [2019-04-28 08:20 +0200]:

> Elimar Riesebieter  wrote:
> 
> > From test_termcodes.vim:
> > Found errors in Test_xterm_mouse_middle_click():
> > Caught exception in Test_xterm_mouse_middle_click(): Vim(let):E354: Invalid 
> > register name: '*' @ function 
> > RunTheTest[40]..Test_xterm_mouse_middle_click, line 6
> > TEST FAILURE
> >
> > Elimar
> 
> Can you send the output of command  ":version" ?

It will show "+clipboard" as that machine has a running X and the
gtk3 gui version installed. Anyway the build was initialised within
a remote tmux session, though.

> I suppose that Test_xterm_mouse_middle_click() should be skipped
> if 'clipboard' feature is not available, since it uses register @*.
> 
> Please check that the attached patch.

That patch seems to fix the issue.

Thanks for cooperation
Elimar
-- 
  Never make anything simple and efficient when a way
  can be found to make it complex and wonderful ;-)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Found errors in Test_xterm_mouse_middle_click()

2019-04-28 Fir de Conversatie Dominique Pellé
Elimar Riesebieter  wrote:

> From test_termcodes.vim:
> Found errors in Test_xterm_mouse_middle_click():
> Caught exception in Test_xterm_mouse_middle_click(): Vim(let):E354: Invalid 
> register name: '*' @ function RunTheTest[40]..Test_xterm_mouse_middle_click, 
> line 6
> TEST FAILURE
>
> Elimar

Can you send the output of command  ":version" ?

I suppose that Test_xterm_mouse_middle_click() should be skipped
if 'clipboard' feature is not available, since it uses register @*.

Please check that the attached patch.

Regards
Dominique

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
diff --git a/src/testdir/test_termcodes.vim b/src/testdir/test_termcodes.vim
index af10e1d5c..489c35e1c 100644
--- a/src/testdir/test_termcodes.vim
+++ b/src/testdir/test_termcodes.vim
@@ -77,6 +77,9 @@ func Test_xterm_mouse_left_click()
 endfunc
 
 func Test_xterm_mouse_middle_click()
+  if !has('clipboard')
+return
+  endif
   new
   let save_mouse = 
   let save_term = 


Found errors in Test_xterm_mouse_middle_click()

2019-04-27 Fir de Conversatie Elimar Riesebieter
>From test_termcodes.vim:
Found errors in Test_xterm_mouse_middle_click():
Caught exception in Test_xterm_mouse_middle_click(): Vim(let):E354: Invalid 
register name: '*' @ function RunTheTest[40]..Test_xterm_mouse_middle_click, 
line 6
TEST FAILURE

Elimar
-- 
  You cannot propel yourself forward by
  patting yourself on the back.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.