Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linus/master v5.7 next-20200529] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-doorbell-mapping/20200531-070834 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: m68k-randconfig-r011-20200601 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>, old ones prefixed by <<): drivers/vhost/vdpa.c: In function 'vhost_vdpa_fault': >> drivers/vhost/vdpa.c:754:22: error: implicit declaration of function >> 'pgprot_noncached' [-Werror=implicit-function-declaration] 754 | vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); | ^~~~ >> drivers/vhost/vdpa.c:754:22: error: incompatible types when assigning to >> type 'pgprot_t' {aka 'struct '} from type 'int' cc1: some warnings being treated as errors vim +/pgprot_noncached +754 drivers/vhost/vdpa.c 742 743 static vm_fault_t vhost_vdpa_fault(struct vm_fault *vmf) 744 { 745 struct vhost_vdpa *v = vmf->vma->vm_file->private_data; 746 struct vdpa_device *vdpa = v->vdpa; 747 const struct vdpa_config_ops *ops = vdpa->config; 748 struct vdpa_notification_area notify; 749 struct vm_area_struct *vma = vmf->vma; 750 u16 index = vma->vm_pgoff; 751 752 notify = ops->get_vq_notification(vdpa, index); 753 > 754 vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); 755 if (remap_pfn_range(vma, vmf->address & PAGE_MASK, 756 notify.addr >> PAGE_SHIFT, PAGE_SIZE, 757 vma->vm_page_prot)) 758 return VM_FAULT_SIGBUS; 759 760 return VM_FAULT_NOPAGE; 761 } 762 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[RFC PATCH] vdpa: vhost_vdpa_poll_stop() can be static
Signed-off-by: kbuild test robot --- vdpa.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index d3a2acafedecd4..5037ce7f48cd42 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -287,12 +287,12 @@ static long vhost_vdpa_get_vring_num(struct vhost_vdpa *v, u16 __user *argp) return 0; } -void vhost_vdpa_poll_stop(struct vhost_virtqueue *vq) +static void vhost_vdpa_poll_stop(struct vhost_virtqueue *vq) { vhost_poll_stop(&vq->poll); } -int vhost_vdpa_poll_start(struct vhost_virtqueue *vq) +static int vhost_vdpa_poll_start(struct vhost_virtqueue *vq) { struct vhost_poll *poll = &vq->poll; struct file *file = vq->kick; @@ -747,7 +747,7 @@ static int vhost_vdpa_poll_worker(wait_queue_entry_t *wait, unsigned int mode, return 0; } -void vhost_vdpa_poll_init(struct vhost_dev *dev) +static void vhost_vdpa_poll_init(struct vhost_dev *dev) { struct vhost_virtqueue *vq; struct vhost_poll *poll; ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] vdpa: bypass waking up vhost_woker for vdpa vq kick
Hi Zhu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on vhost/linux-next] [also build test WARNING on v5.7-rc7 next-20200526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Zhu-Lingshan/vdpa-bypass-waking-up-vhost_woker-for-vdpa-vq-kick/20200526-133819 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All warnings (new ones prefixed by >>, old ones prefixed by <<): >> drivers/vhost/vdpa.c:290:6: warning: no previous prototype for >> 'vhost_vdpa_poll_stop' [-Wmissing-prototypes] 290 | void vhost_vdpa_poll_stop(struct vhost_virtqueue *vq) | ^~~~ >> drivers/vhost/vdpa.c:295:5: warning: no previous prototype for >> 'vhost_vdpa_poll_start' [-Wmissing-prototypes] 295 | int vhost_vdpa_poll_start(struct vhost_virtqueue *vq) | ^ >> drivers/vhost/vdpa.c:750:6: warning: no previous prototype for >> 'vhost_vdpa_poll_init' [-Wmissing-prototypes] 750 | void vhost_vdpa_poll_init(struct vhost_dev *dev) | ^~~~ vim +/vhost_vdpa_poll_stop +290 drivers/vhost/vdpa.c 276 277 static long vhost_vdpa_get_vring_num(struct vhost_vdpa *v, u16 __user *argp) 278 { 279 struct vdpa_device *vdpa = v->vdpa; 280 const struct vdpa_config_ops *ops = vdpa->config; 281 u16 num; 282 283 num = ops->get_vq_num_max(vdpa); 284 285 if (copy_to_user(argp, &num, sizeof(num))) 286 return -EFAULT; 287 288 return 0; 289 } > 290 void vhost_vdpa_poll_stop(struct vhost_virtqueue *vq) 291 { 292 vhost_poll_stop(&vq->poll); 293 } 294 > 295 int vhost_vdpa_poll_start(struct vhost_virtqueue *vq) 296 { 297 struct vhost_poll *poll = &vq->poll; 298 struct file *file = vq->kick; 299 __poll_t mask; 300 301 302 if (poll->wqh) 303 return 0; 304 305 mask = vfs_poll(file, &poll->table); 306 if (mask) 307 vq->handle_kick(&vq->poll.work); 308 if (mask & EPOLLERR) { 309 vhost_poll_stop(poll); 310 return -EINVAL; 311 } 312 313 return 0; 314 } 315 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 6/6] rpmsg: add a device ID to also bind to the ADSP device
Hi Guennadi, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20200515] [cannot apply to vhost/linux-next linus/master v5.7-rc5 v5.7-rc4 v5.7-rc3 v5.7-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Guennadi-Liakhovetski/Add-a-vhost-RPMsg-API/20200516-181559 base:bdecf38f228bcca73b31ada98b5b7ba1215eb9c9 config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>, old ones prefixed by <<): >> drivers/rpmsg/virtio_rpmsg_bus.c:952:4: error: 'VIRTIO_ID_ADSP' undeclared >> here (not in a function); did you mean 'VIRTIO_ID_FS'? { VIRTIO_ID_ADSP, VIRTIO_DEV_ANY_ID }, ^~ VIRTIO_ID_FS vim +952 drivers/rpmsg/virtio_rpmsg_bus.c 949 950 static struct virtio_device_id id_table[] = { 951 { VIRTIO_ID_RPMSG, VIRTIO_DEV_ANY_ID }, > 952 { VIRTIO_ID_ADSP, VIRTIO_DEV_ANY_ID }, 953 { 0 }, 954 }; 955 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug config: x86_64-randconfig-b002-20200505 (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0 # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': >> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function >> 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration] vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); ^~~ vzalloc >> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from >> integer without a cast [-Wint-conversion] vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); ^ >> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function >> 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] kfree(vm); ^ vfree cc1: some warnings being treated as errors vim +1375 drivers/virtio/virtio_mem.c 1369 1370 static int virtio_mem_probe(struct virtio_device *vdev) 1371 { 1372 struct virtio_mem *vm; 1373 int rc = -EINVAL; 1374 > 1375 vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); 1376 if (!vm) 1377 return -ENOMEM; 1378 1379 init_waitqueue_head(&vm->host_resp); 1380 vm->vdev = vdev; 1381 INIT_WORK(&vm->wq, virtio_mem_run_wq); 1382 mutex_init(&vm->hotplug_mutex); 1383 INIT_LIST_HEAD(&vm->next); 1384 spin_lock_init(&vm->removal_lock); 1385 hrtimer_init(&vm->retry_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); 1386 vm->retry_timer.function = virtio_mem_timer_expired; 1387 1388 /* register the virtqueue */ 1389 rc = virtio_mem_init_vq(vm); 1390 if (rc) 1391 goto out_free_vm; 1392 1393 /* initialize the device by querying the config */ 1394 rc = virtio_mem_init(vm); 1395 if (rc) 1396 goto out_del_vq; 1397 1398 /* register callbacks */ 1399 vm->memory_notifier.notifier_call = virtio_mem_memory_notifier_cb; 1400 rc = register_memory_notifier(&vm->memory_notifier); 1401 if (rc) 1402 goto out_del_vq; 1403 rc = register_virtio_mem_device(vm); 1404 if (rc) 1405 goto out_unreg_mem; 1406 1407 virtio_device_ready(vdev); 1408 1409 /* trigger a config update to start processing the requested_size */ 1410 atomic_set(&vm->config_changed, 1); 1411 queue_work(system_freezable_wq, &vm->wq); 1412 1413 return 0; 1414 out_unreg_mem: 1415 unregister_memory_notifier(&vm->memory_notifier); 1416 out_del_vq: 1417 vdev->config->del_vqs(vdev); 1418 out_free_vm: > 1419 kfree(vm); 1420 vdev->priv = NULL; 1421 1422 return rc; 1423 } 1424 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 3/5] swiotlb: Add alloc and free APIs
Hi Srivatsa, Thank you for the patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on xen-tip/linux-next linus/master v5.7-rc3 next-20200429] [cannot apply to swiotlb/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Srivatsa-Vaddagiri/virtio-on-Type-1-hypervisor/20200429-032334 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: i386-randconfig-b002-20200429 (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/i915/i915_scatterlist.h:12:0, from drivers/gpu/drm/i915/i915_scatterlist.c:7: include/linux/swiotlb.h: In function 'swiotlb_alloc': >> include/linux/swiotlb.h:231:9: error: 'DMA_MAPPING_ERROR' undeclared (first >> use in this function); did you mean 'APM_NO_ERROR'? return DMA_MAPPING_ERROR; ^ APM_NO_ERROR include/linux/swiotlb.h:231:9: note: each undeclared identifier is reported only once for each function it appears in vim +231 include/linux/swiotlb.h 226 227 static inline phys_addr_t swiotlb_alloc(struct swiotlb_pool *pool, 228 size_t alloc_size, unsigned long tbl_dma_addr, 229 unsigned long mask) 230 { > 231 return DMA_MAPPING_ERROR; 232 } 233 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 5/5] virtio: Add bounce DMA ops
Hi Srivatsa, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on vhost/linux-next] [also build test WARNING on xen-tip/linux-next linus/master v5.7-rc3 next-20200428] [cannot apply to swiotlb/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Srivatsa-Vaddagiri/virtio-on-Type-1-hypervisor/20200429-032334 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next reproduce: # apt-get install sparse # sparse version: v0.6.1-191-gc51a0382-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/virtio/virtio_bounce.c:22:21: sparse: sparse: symbol 'virtio_pool' >> was not declared. Should it be static? >> drivers/virtio/virtio_bounce.c:79:8: sparse: sparse: symbol >> 'virtio_max_mapping_size' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[RFC PATCH] virtio: virtio_pool can be static
Signed-off-by: kbuild test robot --- virtio_bounce.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_bounce.c b/drivers/virtio/virtio_bounce.c index 3de8e0eb71e48..5a68d48667c42 100644 --- a/drivers/virtio/virtio_bounce.c +++ b/drivers/virtio/virtio_bounce.c @@ -19,7 +19,7 @@ static phys_addr_t bounce_buf_paddr; static void *bounce_buf_vaddr; static size_t bounce_buf_size; -struct swiotlb_pool *virtio_pool; +static struct swiotlb_pool *virtio_pool; #define VIRTIO_MAX_BOUNCE_SIZE (16*4096) @@ -76,7 +76,7 @@ static void virtio_unmap_page(struct device *dev, dma_addr_t dev_addr, size, dir, attrs); } -size_t virtio_max_mapping_size(struct device *dev) +static size_t virtio_max_mapping_size(struct device *dev) { return VIRTIO_MAX_BOUNCE_SIZE; } ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 1/5] swiotlb: Introduce concept of swiotlb_pool
Hi Srivatsa, Thank you for the patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on xen-tip/linux-next linus/master v5.7-rc3 next-20200428] [cannot apply to swiotlb/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Srivatsa-Vaddagiri/virtio-on-Type-1-hypervisor/20200429-032334 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: x86_64-defconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/iommu/intel-iommu.c: In function 'bounce_map_single': >> drivers/iommu/intel-iommu.c:3990:24: error: 'io_tlb_start' undeclared (first >> use in this function); did you mean 'swiotlb_start'? __phys_to_dma(dev, io_tlb_start), ^~~~ swiotlb_start drivers/iommu/intel-iommu.c:3990:24: note: each undeclared identifier is reported only once for each function it appears in vim +3990 drivers/iommu/intel-iommu.c cfb94a372f2d4e Lu Baolu 2019-09-06 3941 cfb94a372f2d4e Lu Baolu 2019-09-06 3942 static dma_addr_t cfb94a372f2d4e Lu Baolu 2019-09-06 3943 bounce_map_single(struct device *dev, phys_addr_t paddr, size_t size, cfb94a372f2d4e Lu Baolu 2019-09-06 3944 enum dma_data_direction dir, unsigned long attrs, cfb94a372f2d4e Lu Baolu 2019-09-06 3945 u64 dma_mask) cfb94a372f2d4e Lu Baolu 2019-09-06 3946 { cfb94a372f2d4e Lu Baolu 2019-09-06 3947size_t aligned_size = ALIGN(size, VTD_PAGE_SIZE); cfb94a372f2d4e Lu Baolu 2019-09-06 3948struct dmar_domain *domain; cfb94a372f2d4e Lu Baolu 2019-09-06 3949struct intel_iommu *iommu; cfb94a372f2d4e Lu Baolu 2019-09-06 3950unsigned long iova_pfn; cfb94a372f2d4e Lu Baolu 2019-09-06 3951unsigned long nrpages; cfb94a372f2d4e Lu Baolu 2019-09-06 3952phys_addr_t tlb_addr; cfb94a372f2d4e Lu Baolu 2019-09-06 3953int prot = 0; cfb94a372f2d4e Lu Baolu 2019-09-06 3954int ret; cfb94a372f2d4e Lu Baolu 2019-09-06 3955 a11bfde9c77df1 Joerg Roedel 2020-02-17 3956if (unlikely(attach_deferred(dev))) a11bfde9c77df1 Joerg Roedel 2020-02-17 3957do_deferred_attach(dev); a11bfde9c77df1 Joerg Roedel 2020-02-17 3958 96d170f3b1a607 Joerg Roedel 2020-02-17 3959domain = find_domain(dev); a11bfde9c77df1 Joerg Roedel 2020-02-17 3960 cfb94a372f2d4e Lu Baolu 2019-09-06 3961if (WARN_ON(dir == DMA_NONE || !domain)) cfb94a372f2d4e Lu Baolu 2019-09-06 3962return DMA_MAPPING_ERROR; cfb94a372f2d4e Lu Baolu 2019-09-06 3963 cfb94a372f2d4e Lu Baolu 2019-09-06 3964iommu = domain_get_iommu(domain); cfb94a372f2d4e Lu Baolu 2019-09-06 3965if (WARN_ON(!iommu)) cfb94a372f2d4e Lu Baolu 2019-09-06 3966return DMA_MAPPING_ERROR; cfb94a372f2d4e Lu Baolu 2019-09-06 3967 cfb94a372f2d4e Lu Baolu 2019-09-06 3968nrpages = aligned_nrpages(0, size); cfb94a372f2d4e Lu Baolu 2019-09-06 3969iova_pfn = intel_alloc_iova(dev, domain, cfb94a372f2d4e Lu Baolu 2019-09-06 3970 dma_to_mm_pfn(nrpages), dma_mask); cfb94a372f2d4e Lu Baolu 2019-09-06 3971if (!iova_pfn) cfb94a372f2d4e Lu Baolu 2019-09-06 3972return DMA_MAPPING_ERROR; cfb94a372f2d4e Lu Baolu 2019-09-06 3973 cfb94a372f2d4e Lu Baolu 2019-09-06 3974/* cfb94a372f2d4e Lu Baolu 2019-09-06 3975 * Check if DMAR supports zero-length reads on write only cfb94a372f2d4e Lu Baolu 2019-09-06 3976 * mappings.. cfb94a372f2d4e Lu Baolu 2019-09-06 3977 */ cfb94a372f2d4e Lu Baolu 2019-09-06 3978if (dir == DMA_TO_DEVICE || dir == DMA_BIDIRECTIONAL || cfb94a372f2d4e Lu Baolu 2019-09-06 3979 !cap_zlr(iommu->cap)) cfb94a372f2d4e Lu Baolu 2019-09-06 3980prot |= DMA_PTE_READ; cfb94a372f2d4e Lu Baolu 2019-09-06 3981if (dir == DMA_FROM_DEVICE || dir == DMA_BIDIRECTIONAL) cfb94a372f2d4e Lu Baolu 2019-09-06 3982prot |= DMA_PTE_WRITE; cfb94a372f2d4e Lu Baolu 2019-09-06 3983 cfb94a372f2d4e Lu Baolu 2019-09-06 3984/* cfb94a372f2d4e Lu Baolu 2019-09-06 3985 * If both the physical buffer start address and size are cfb94a372f2d4e Lu Baolu 2019-09-06 3986 * page aligned, we don't need to use a bounce page. cfb94a372f2d4e Lu
Re: [PATCH 5/5] virtio: Add bounce DMA ops
Hi Srivatsa, Thank you for the patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on xen-tip/linux-next linus/master v5.7-rc3 next-20200428] [cannot apply to swiotlb/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Srivatsa-Vaddagiri/virtio-on-Type-1-hypervisor/20200429-032334 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: s390-randconfig-a001-20200428 (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/virtio/virtio_bounce.c: In function 'virtio_bounce_setup': >> drivers/virtio/virtio_bounce.c:144:7: error: implicit declaration of >> function 'of_get_flat_dt_prop' [-Werror=implicit-function-declaration] 144 | if (!of_get_flat_dt_prop(node, "no-map", NULL)) | ^~~ cc1: some warnings being treated as errors vim +/of_get_flat_dt_prop +144 drivers/virtio/virtio_bounce.c 139 140 static int __init virtio_bounce_setup(struct reserved_mem *rmem) 141 { 142 unsigned long node = rmem->fdt_node; 143 > 144 if (!of_get_flat_dt_prop(node, "no-map", NULL)) 145 return -EINVAL; 146 147 return virtio_register_bounce_buffer(rmem->base, rmem->size); 148 } 149 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 5/5] virtio: Add bounce DMA ops
Hi Srivatsa, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on vhost/linux-next] [also build test WARNING on xen-tip/linux-next linus/master v5.7-rc3 next-20200428] [cannot apply to swiotlb/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Srivatsa-Vaddagiri/virtio-on-Type-1-hypervisor/20200429-032334 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: sh-randconfig-a001-20200428 (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All warnings (new ones prefixed by >>): In file included from drivers/virtio/virtio_bounce.c:13: include/linux/swiotlb.h: In function 'swiotlb_alloc': include/linux/swiotlb.h:234:9: error: 'DMA_MAPPING_ERROR' undeclared (first use in this function) 234 | return DMA_MAPPING_ERROR; | ^ include/linux/swiotlb.h:234:9: note: each undeclared identifier is reported only once for each function it appears in >> include/linux/swiotlb.h:235:1: warning: control reaches end of non-void >> function [-Wreturn-type] 235 | } | ^ vim +235 include/linux/swiotlb.h 9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 229 9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 230 static inline phys_addr_t swiotlb_alloc(struct swiotlb_pool *pool, 9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 231 size_t alloc_size, unsigned long tbl_dma_addr, 9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 232 unsigned long mask) 9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 233 { 9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 234 return DMA_MAPPING_ERROR; 9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 @235 } 9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 236 :: The code at line 235 was first introduced by commit :: 9ab4c39d9f929840cb884e589f6112770dbc2f63 swiotlb: Add alloc and free APIs :: TO: Srivatsa Vaddagiri :: CC: 0day robot --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:vhost 27/32] ./usr/include/linux/virtio_ring.h:126:2: error: unknown type name 'vring_used_elem_t'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 90dc7026cdc9a9cbdc815cf1d8d29aa7b776ebf1 commit: ce4e61f610058ff9311f21d7584746fcfde9577e [27/32] virtio: force spec specified alignment on types config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: git checkout ce4e61f610058ff9311f21d7584746fcfde9577e # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from :32:0: ./usr/include/linux/virtio_ring.h:91:31: error: expected declaration specifiers or '...' before numeric constant #define VRING_USED_ALIGN_SIZE 4 ^ ./usr/include/linux/virtio_ring.h:120:42: note: in expansion of macro 'VRING_USED_ALIGN_SIZE' typedef struct vring_used_elem __aligned(VRING_USED_ALIGN_SIZE) ^ >> ./usr/include/linux/virtio_ring.h:126:2: error: unknown type name >> 'vring_used_elem_t' vring_used_elem_t ring[]; ^ ./usr/include/linux/virtio_ring.h:92:31: error: expected declaration specifiers or '...' before numeric constant #define VRING_DESC_ALIGN_SIZE 16 ^ ./usr/include/linux/virtio_ring.h:143:37: note: in expansion of macro 'VRING_DESC_ALIGN_SIZE' typedef struct vring_desc __aligned(VRING_DESC_ALIGN_SIZE) vring_desc_t; ^ ./usr/include/linux/virtio_ring.h:90:32: error: expected declaration specifiers or '...' before numeric constant #define VRING_AVAIL_ALIGN_SIZE 2 ^ ./usr/include/linux/virtio_ring.h:144:38: note: in expansion of macro 'VRING_AVAIL_ALIGN_SIZE' typedef struct vring_avail __aligned(VRING_AVAIL_ALIGN_SIZE) vring_avail_t; ^~ ./usr/include/linux/virtio_ring.h:91:31: error: expected declaration specifiers or '...' before numeric constant #define VRING_USED_ALIGN_SIZE 4 ^ ./usr/include/linux/virtio_ring.h:145:37: note: in expansion of macro 'VRING_USED_ALIGN_SIZE' typedef struct vring_used __aligned(VRING_USED_ALIGN_SIZE) vring_used_t; ^ ./usr/include/linux/virtio_ring.h:150:2: error: unknown type name 'vring_desc_t' vring_desc_t *desc; ^~~~ ./usr/include/linux/virtio_ring.h:152:2: error: unknown type name 'vring_avail_t' vring_avail_t *avail; ^ ./usr/include/linux/virtio_ring.h:154:2: error: unknown type name 'vring_used_t' vring_used_t *used; ^~~~ ./usr/include/linux/virtio_ring.h: In function 'vring_init': ./usr/include/linux/virtio_ring.h:193:12: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types] vr->avail = (struct vring_avail *)((char *)p + num * sizeof(struct vring_desc)); ^ ./usr/include/linux/virtio_ring.h:194:44: error: request for member 'ring' in something not a structure or union vr->used = (void *)(((uintptr_t)&vr->avail->ring[num] + sizeof(__virtio16) ^~ --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] vhost: do not enable VHOST_MENU by default
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on next-20200414] [cannot apply to powerpc/next s390/features v5.7-rc1] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vhost-do-not-enable-VHOST_MENU-by-default/20200414-110807 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: ia64-randconfig-a001-20200415 (attached as .config) compiler: ia64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.3.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): drivers/vhost/vhost.c: In function 'vhost_vring_ioctl': >> drivers/vhost/vhost.c:1577:33: error: implicit declaration of function >> 'eventfd_fget'; did you mean 'eventfd_signal'? >> [-Werror=implicit-function-declaration] 1577 | eventfp = f.fd == -1 ? NULL : eventfd_fget(f.fd); | ^~~~ | eventfd_signal >> drivers/vhost/vhost.c:1577:31: warning: pointer/integer type mismatch in >> conditional expression 1577 | eventfp = f.fd == -1 ? NULL : eventfd_fget(f.fd); | ^ cc1: some warnings being treated as errors vim +1577 drivers/vhost/vhost.c feebcaeac79ad8 Jason Wang 2019-05-24 1493 feebcaeac79ad8 Jason Wang 2019-05-24 1494 static long vhost_vring_set_num_addr(struct vhost_dev *d, feebcaeac79ad8 Jason Wang 2019-05-24 1495 struct vhost_virtqueue *vq, feebcaeac79ad8 Jason Wang 2019-05-24 1496 unsigned int ioctl, feebcaeac79ad8 Jason Wang 2019-05-24 1497 void __user *argp) feebcaeac79ad8 Jason Wang 2019-05-24 1498 { feebcaeac79ad8 Jason Wang 2019-05-24 1499 long r; feebcaeac79ad8 Jason Wang 2019-05-24 1500 feebcaeac79ad8 Jason Wang 2019-05-24 1501 mutex_lock(&vq->mutex); feebcaeac79ad8 Jason Wang 2019-05-24 1502 feebcaeac79ad8 Jason Wang 2019-05-24 1503 switch (ioctl) { feebcaeac79ad8 Jason Wang 2019-05-24 1504 case VHOST_SET_VRING_NUM: feebcaeac79ad8 Jason Wang 2019-05-24 1505 r = vhost_vring_set_num(d, vq, argp); feebcaeac79ad8 Jason Wang 2019-05-24 1506 break; feebcaeac79ad8 Jason Wang 2019-05-24 1507 case VHOST_SET_VRING_ADDR: feebcaeac79ad8 Jason Wang 2019-05-24 1508 r = vhost_vring_set_addr(d, vq, argp); feebcaeac79ad8 Jason Wang 2019-05-24 1509 break; feebcaeac79ad8 Jason Wang 2019-05-24 1510 default: feebcaeac79ad8 Jason Wang 2019-05-24 1511 BUG(); feebcaeac79ad8 Jason Wang 2019-05-24 1512 } feebcaeac79ad8 Jason Wang 2019-05-24 1513 feebcaeac79ad8 Jason Wang 2019-05-24 1514 mutex_unlock(&vq->mutex); feebcaeac79ad8 Jason Wang 2019-05-24 1515 feebcaeac79ad8 Jason Wang 2019-05-24 1516 return r; feebcaeac79ad8 Jason Wang 2019-05-24 1517 } 26b36604523f4a Sonny Rao 2018-03-14 1518 long vhost_vring_ioctl(struct vhost_dev *d, unsigned int ioctl, void __user *argp) 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1519 { cecb46f194460d Al Viro2012-08-27 1520 struct file *eventfp, *filep = NULL; cecb46f194460d Al Viro2012-08-27 1521 bool pollstart = false, pollstop = false; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1522 struct eventfd_ctx *ctx = NULL; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1523 u32 __user *idxp = argp; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1524 struct vhost_virtqueue *vq; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1525 struct vhost_vring_state s; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1526 struct vhost_vring_file f; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1527 u32 idx; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1528 long r; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1529 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1530 r = get_user(idx, idxp); 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1531 if (r < 0) 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1532
[vhost:vhost 54/54] drivers/virtio/Kconfig:49: syntax error
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: e282a85dc20e6d5da055e65c48aae15cc14897c7 commit: e282a85dc20e6d5da055e65c48aae15cc14897c7 [54/54] vdpa: make vhost, virtio depend on menu config: s390-randconfig-a001-20200412 compiler: s390-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout e282a85dc20e6d5da055e65c48aae15cc14897c7 GCC_VERSION=9.3.0 make.cross ARCH=s390 randconfig GCC_VERSION=9.3.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/virtio/Kconfig:49: syntax error >> drivers/virtio/Kconfig:48: unknown statement "depend" >> drivers/virtio/Kconfig:49: invalid statement drivers/virtio/Kconfig:50: invalid statement >> drivers/virtio/Kconfig:51: unknown statement "This" drivers/virtio/Kconfig:52:warning: ignoring unsupported character '.' drivers/virtio/Kconfig:52:warning: ignoring unsupported character ',' >> drivers/virtio/Kconfig:52: unknown statement "device" >> drivers/virtio/Kconfig:53: unknown statement "an" >> drivers/virtio/Kconfig:54: unknown statement "physical" drivers/virtio/Kconfig:55:warning: ignoring unsupported character '.' >> drivers/virtio/Kconfig:55: unknown statement "offloaded" drivers/virtio/Kconfig:57:warning: ignoring unsupported character ',' drivers/virtio/Kconfig:57:warning: ignoring unsupported character '.' >> drivers/virtio/Kconfig:57: unknown statement "If" make[2]: *** [scripts/kconfig/Makefile:75: oldconfig] Error 1 make[1]: *** [Makefile:568: oldconfig] Error 2 make: *** [Makefile:180: sub-make] Error 2 4 real 1 user 0 sys 35.45% cpumake oldconfig -- >> drivers/virtio/Kconfig:49: syntax error >> drivers/virtio/Kconfig:48: unknown statement "depend" >> drivers/virtio/Kconfig:49: invalid statement drivers/virtio/Kconfig:50: invalid statement >> drivers/virtio/Kconfig:51: unknown statement "This" drivers/virtio/Kconfig:52:warning: ignoring unsupported character '.' drivers/virtio/Kconfig:52:warning: ignoring unsupported character ',' >> drivers/virtio/Kconfig:52: unknown statement "device" >> drivers/virtio/Kconfig:53: unknown statement "an" >> drivers/virtio/Kconfig:54: unknown statement "physical" drivers/virtio/Kconfig:55:warning: ignoring unsupported character '.' >> drivers/virtio/Kconfig:55: unknown statement "offloaded" drivers/virtio/Kconfig:57:warning: ignoring unsupported character ',' drivers/virtio/Kconfig:57:warning: ignoring unsupported character '.' >> drivers/virtio/Kconfig:57: unknown statement "If" make[2]: *** [scripts/kconfig/Makefile:75: olddefconfig] Error 1 make[1]: *** [Makefile:568: olddefconfig] Error 2 make: *** [Makefile:180: sub-make] Error 2 5 real 1 user 0 sys 28.87% cpumake olddefconfig vim +49 drivers/virtio/Kconfig e72542191cbba4 Ohad Ben-Cohen 2011-07-05 14 3343660d8c62c6 Anthony Liguori2007-11-12 15 config VIRTIO_PCI d72c5a8c8c57cb Kees Cook 2012-10-02 16tristate "PCI driver for virtio devices" d72c5a8c8c57cb Kees Cook 2012-10-02 17depends on PCI 3343660d8c62c6 Anthony Liguori2007-11-12 18select VIRTIO 3343660d8c62c6 Anthony Liguori2007-11-12 19---help--- b2a6d51ddf7b23 Michael S. Tsirkin 2015-01-15 20 This driver provides support for virtio based paravirtual device 3343660d8c62c6 Anthony Liguori2007-11-12 21 drivers over PCI. This requires that your VMM has appropriate PCI 3343660d8c62c6 Anthony Liguori2007-11-12 22 virtio backends. Most QEMU based VMMs should support these devices 3343660d8c62c6 Anthony Liguori2007-11-12 23 (like KVM or Xen). 3343660d8c62c6 Anthony Liguori2007-11-12 24 3343660d8c62c6 Anthony Liguori2007-11-12 25 If unsure, say M. 3343660d8c62c6 Anthony Liguori2007-11-12 26 46506da5f365ef Michael S. Tsirkin 2015-01-15 27 config VIRTIO_PCI_LEGACY 46506da5f365ef Michael S. Tsirkin 2015-01-15 28bool "Support for legacy virtio draft 0.9.X and older devices" 46506da5f365ef Michael S. Tsirkin 2015-01-15 29default y 46506da5f365ef Michael S. Tsirkin 2015-01-15 30depends on VIRTIO_PCI 46506da5f365ef Michael S. Tsirkin 2015-01-15 31---help--- 46506da5f365ef Michael S. Tsirkin 2015-01-15 32Virtio PCI Card 0.9.X Draft (circa 2014) and older device support. 465
[vhost:vhost 54/54] drivers/virtio/Kconfig:49: syntax error
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: e282a85dc20e6d5da055e65c48aae15cc14897c7 commit: e282a85dc20e6d5da055e65c48aae15cc14897c7 [54/54] vdpa: make vhost, virtio depend on menu config: powerpc-defconfig compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 4e86e5eedc684453fe0af6eca2ebdbff33db012c) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout e282a85dc20e6d5da055e65c48aae15cc14897c7 COMPILER=clang make.cross ARCH=powerpc defconfig COMPILER=clang make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/virtio/Kconfig:49: syntax error >> drivers/virtio/Kconfig:48: unknown statement "depend" >> drivers/virtio/Kconfig:49: invalid statement drivers/virtio/Kconfig:50: invalid statement >> drivers/virtio/Kconfig:51: unknown statement "This" drivers/virtio/Kconfig:52:warning: ignoring unsupported character '.' drivers/virtio/Kconfig:52:warning: ignoring unsupported character ',' >> drivers/virtio/Kconfig:52: unknown statement "device" >> drivers/virtio/Kconfig:53: unknown statement "an" >> drivers/virtio/Kconfig:54: unknown statement "physical" drivers/virtio/Kconfig:55:warning: ignoring unsupported character '.' >> drivers/virtio/Kconfig:55: unknown statement "offloaded" drivers/virtio/Kconfig:57:warning: ignoring unsupported character ',' drivers/virtio/Kconfig:57:warning: ignoring unsupported character '.' >> drivers/virtio/Kconfig:57: unknown statement "If" make[2]: *** [scripts/kconfig/Makefile:85: defconfig] Error 1 make[1]: *** [Makefile:568: defconfig] Error 2 make: *** [Makefile:180: sub-make] Error 2 4 real 1 user 1 sys 59.31% cpumake defconfig -- >> drivers/virtio/Kconfig:49: syntax error >> drivers/virtio/Kconfig:48: unknown statement "depend" >> drivers/virtio/Kconfig:49: invalid statement drivers/virtio/Kconfig:50: invalid statement >> drivers/virtio/Kconfig:51: unknown statement "This" drivers/virtio/Kconfig:52:warning: ignoring unsupported character '.' drivers/virtio/Kconfig:52:warning: ignoring unsupported character ',' >> drivers/virtio/Kconfig:52: unknown statement "device" >> drivers/virtio/Kconfig:53: unknown statement "an" >> drivers/virtio/Kconfig:54: unknown statement "physical" drivers/virtio/Kconfig:55:warning: ignoring unsupported character '.' >> drivers/virtio/Kconfig:55: unknown statement "offloaded" drivers/virtio/Kconfig:57:warning: ignoring unsupported character ',' drivers/virtio/Kconfig:57:warning: ignoring unsupported character '.' >> drivers/virtio/Kconfig:57: unknown statement "If" make[2]: *** [scripts/kconfig/Makefile:75: oldconfig] Error 1 make[1]: *** [Makefile:568: oldconfig] Error 2 make: *** [Makefile:180: sub-make] Error 2 4 real 1 user 1 sys 66.71% cpumake oldconfig -- >> drivers/virtio/Kconfig:49: syntax error >> drivers/virtio/Kconfig:48: unknown statement "depend" >> drivers/virtio/Kconfig:49: invalid statement drivers/virtio/Kconfig:50: invalid statement >> drivers/virtio/Kconfig:51: unknown statement "This" drivers/virtio/Kconfig:52:warning: ignoring unsupported character '.' drivers/virtio/Kconfig:52:warning: ignoring unsupported character ',' >> drivers/virtio/Kconfig:52: unknown statement "device" >> drivers/virtio/Kconfig:53: unknown statement "an" >> drivers/virtio/Kconfig:54: unknown statement "physical" drivers/virtio/Kconfig:55:warning: ignoring unsupported character '.' >> drivers/virtio/Kconfig:55: unknown statement "offloaded" drivers/virtio/Kconfig:57:warning: ignoring unsupported character ',' drivers/virtio/Kconfig:57:warning: ignoring unsupported character '.' >> drivers/virtio/Kconfig:57: unknown statement "If" make[2]: *** [scripts/kconfig/Makefile:75: olddefconfig] Error 1 make[1]: *** [Makefile:568: olddefconfig] Error 2 make: *** [Makefile:180: sub-make] Error 2 4 real 1 user 1 sys 66.26% cpumake olddefconfig vim +49 drivers/virtio/Kconfig e72542191cbba4 Ohad Ben-Cohen 2011-07-05 14 3343660d8c62c6 Anthony Liguori2007-11-12 15 config VIRTIO_PCI d72c5a8c8c57cb Kees Cook 2012-10-02 16tristate "PCI driver for virtio devices" d72c5a8c8c57cb Kees Cook
[vhost:vhost 32/44] drivers/remoteproc/remoteproc_sysfs.c:55:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 4e6ebec0de18aaea5f5f814b25bfcae3751c6369 commit: 013a472de94693ba05696d59e7df3224c20a22e6 [32/44] virtio: stop using legacy struct vring in kernel config: x86_64-randconfig-s1-20200407 (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: git checkout 013a472de94693ba05696d59e7df3224c20a22e6 # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): drivers/remoteproc/remoteproc_sysfs.c: In function 'firmware_store': >> drivers/remoteproc/remoteproc_sysfs.c:55:2: error: implicit declaration of >> function 'kfree'; did you mean 'vfree'? >> [-Werror=implicit-function-declaration] kfree(rproc->firmware); ^ vfree cc1: some warnings being treated as errors -- drivers/char/hw_random/virtio-rng.c: In function 'probe_common': >> drivers/char/hw_random/virtio-rng.c:92:7: error: implicit declaration of >> function 'kzalloc'; did you mean 'vzalloc'? >> [-Werror=implicit-function-declaration] vi = kzalloc(sizeof(struct virtrng_info), GFP_KERNEL); ^~~ vzalloc >> drivers/char/hw_random/virtio-rng.c:92:5: warning: assignment makes pointer >> from integer without a cast [-Wint-conversion] vi = kzalloc(sizeof(struct virtrng_info), GFP_KERNEL); ^ >> drivers/char/hw_random/virtio-rng.c:125:2: error: implicit declaration of >> function 'kfree'; did you mean 'vfree'? >> [-Werror=implicit-function-declaration] kfree(vi); ^ vfree cc1: some warnings being treated as errors vim +55 drivers/remoteproc/remoteproc_sysfs.c 2aefbef0414981 Matt Redfearn 2016-10-19 20 2aefbef0414981 Matt Redfearn 2016-10-19 21 /* Change firmware name via sysfs */ 2aefbef0414981 Matt Redfearn 2016-10-19 22 static ssize_t firmware_store(struct device *dev, 2aefbef0414981 Matt Redfearn 2016-10-19 23 struct device_attribute *attr, 2aefbef0414981 Matt Redfearn 2016-10-19 24 const char *buf, size_t count) 2aefbef0414981 Matt Redfearn 2016-10-19 25 { 2aefbef0414981 Matt Redfearn 2016-10-19 26 struct rproc *rproc = to_rproc(dev); 2aefbef0414981 Matt Redfearn 2016-10-19 27 char *p; 2aefbef0414981 Matt Redfearn 2016-10-19 28 int err, len = count; 2aefbef0414981 Matt Redfearn 2016-10-19 29 2aefbef0414981 Matt Redfearn 2016-10-19 30 err = mutex_lock_interruptible(&rproc->lock); 2aefbef0414981 Matt Redfearn 2016-10-19 31 if (err) { 2aefbef0414981 Matt Redfearn 2016-10-19 32 dev_err(dev, "can't lock rproc %s: %d\n", rproc->name, err); 2aefbef0414981 Matt Redfearn 2016-10-19 33 return -EINVAL; 2aefbef0414981 Matt Redfearn 2016-10-19 34 } 2aefbef0414981 Matt Redfearn 2016-10-19 35 2aefbef0414981 Matt Redfearn 2016-10-19 36 if (rproc->state != RPROC_OFFLINE) { 2aefbef0414981 Matt Redfearn 2016-10-19 37 dev_err(dev, "can't change firmware while running\n"); 2aefbef0414981 Matt Redfearn 2016-10-19 38 err = -EBUSY; 2aefbef0414981 Matt Redfearn 2016-10-19 39 goto out; 2aefbef0414981 Matt Redfearn 2016-10-19 40 } 2aefbef0414981 Matt Redfearn 2016-10-19 41 2aefbef0414981 Matt Redfearn 2016-10-19 42 len = strcspn(buf, "\n"); faeadbb6409475 Suman Anna2018-09-14 43 if (!len) { faeadbb6409475 Suman Anna2018-09-14 44 dev_err(dev, "can't provide a NULL firmware\n"); faeadbb6409475 Suman Anna2018-09-14 45 err = -EINVAL; faeadbb6409475 Suman Anna2018-09-14 46 goto out; faeadbb6409475 Suman Anna2018-09-14 47 } 2aefbef0414981 Matt Redfearn 2016-10-19 48 2aefbef0414981 Matt Redfearn 2016-10-19 49 p = kstrndup(buf, len, GFP_KERNEL); 2aefbef0414981 Matt Redfearn 2016-10-19 50 if (!p) { 2aefbef0414981 Matt Redfearn 2016-10-19 51 err = -ENOMEM; 2aefbef0414981 Matt Redfearn 2016-10-19 52 goto out; 2aefbef0414981 Matt Redfearn 2016-10-19 53 } 2aefbef0414981 Matt Redfearn 2016-10-19 54 2aefbef0414981 Matt Redfearn 2016-10-19 @55 kfree(rproc->firmware); 2aefbef0414981 Matt Redfearn 2016-10-19 56 rproc->firmware = p; 2aefbef0414981 Matt Redfearn 2016-10-19 57 out: 2aefbef0414981 Matt Redfearn 2016-10-19 58 mutex_unlock(&rproc->lock); 2aefbef0414981 Matt Redfearn 2016-10-19 59 2aefbef0414981 Matt Redfearn 2016-10-19 60 return err ? err : count; 2aefbef0414981 Matt Redfearn 2016-10-19 61 } 2aefbef0414981 Matt Redfearn 2016-10-19 62 static DEVICE_ATTR_RW(fi
[vhost:vhost 32/44] drivers/gpu/drm/virtio/virtgpu_ioctl.c:113:7: error: implicit declaration of function 'copy_from_user'; did you mean 'sg_copy_from_buffer'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 4e6ebec0de18aaea5f5f814b25bfcae3751c6369 commit: 013a472de94693ba05696d59e7df3224c20a22e6 [32/44] virtio: stop using legacy struct vring in kernel config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 013a472de94693ba05696d59e7df3224c20a22e6 # save the attached .config to linux build tree GCC_VERSION=9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/virtio/virtgpu_ioctl.c: In function 'virtio_gpu_execbuffer_ioctl': >> drivers/gpu/drm/virtio/virtgpu_ioctl.c:113:7: error: implicit declaration of >> function 'copy_from_user'; did you mean 'sg_copy_from_buffer'? >> [-Werror=implicit-function-declaration] 113 | if (copy_from_user(bo_handles, user_bo_handles, | ^~ | sg_copy_from_buffer drivers/gpu/drm/virtio/virtgpu_ioctl.c: In function 'virtio_gpu_getparam_ioctl': >> drivers/gpu/drm/virtio/virtgpu_ioctl.c:196:6: error: implicit declaration of >> function 'copy_to_user' [-Werror=implicit-function-declaration] 196 | if (copy_to_user(u64_to_user_ptr(param->value), &value, sizeof(int))) | ^~~~ cc1: some warnings being treated as errors vim +113 drivers/gpu/drm/virtio/virtgpu_ioctl.c 62fb7a5e10962a Gerd Hoffmann 2014-10-28 46 5c32c3dd8501b0 Gustavo Padovan 2016-08-31 47 /* 5c32c3dd8501b0 Gustavo Padovan 2016-08-31 48 * Usage of execbuffer: 5c32c3dd8501b0 Gustavo Padovan 2016-08-31 49 * Relocations need to take into account the full VIRTIO_GPUDrawable size. 5c32c3dd8501b0 Gustavo Padovan 2016-08-31 50 * However, the command as passed from user space must *not* contain the initial 5c32c3dd8501b0 Gustavo Padovan 2016-08-31 51 * VIRTIO_GPUReleaseInfo struct (first XXX bytes) 5c32c3dd8501b0 Gustavo Padovan 2016-08-31 52 */ 5c32c3dd8501b0 Gustavo Padovan 2016-08-31 53 static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data, 62fb7a5e10962a Gerd Hoffmann 2014-10-28 54 struct drm_file *drm_file) 62fb7a5e10962a Gerd Hoffmann 2014-10-28 55 { 5c32c3dd8501b0 Gustavo Padovan 2016-08-31 56 struct drm_virtgpu_execbuffer *exbuf = data; 62fb7a5e10962a Gerd Hoffmann 2014-10-28 57 struct virtio_gpu_device *vgdev = dev->dev_private; 62fb7a5e10962a Gerd Hoffmann 2014-10-28 58 struct virtio_gpu_fpriv *vfpriv = drm_file->driver_priv; 2cd7b6f08bc4cf Robert Foss 2018-11-12 59 struct virtio_gpu_fence *out_fence; 62fb7a5e10962a Gerd Hoffmann 2014-10-28 60 int ret; 62fb7a5e10962a Gerd Hoffmann 2014-10-28 61 uint32_t *bo_handles = NULL; 62fb7a5e10962a Gerd Hoffmann 2014-10-28 62 void __user *user_bo_handles = NULL; da758d51968a88 Gerd Hoffmann 2019-08-29 63 struct virtio_gpu_object_array *buflist = NULL; 2cd7b6f08bc4cf Robert Foss 2018-11-12 64 struct sync_file *sync_file; 2cd7b6f08bc4cf Robert Foss 2018-11-12 65 int in_fence_fd = exbuf->fence_fd; 2cd7b6f08bc4cf Robert Foss 2018-11-12 66 int out_fence_fd = -1; 62fb7a5e10962a Gerd Hoffmann 2014-10-28 67 void *buf; 62fb7a5e10962a Gerd Hoffmann 2014-10-28 68 62fb7a5e10962a Gerd Hoffmann 2014-10-28 69 if (vgdev->has_virgl_3d == false) 62fb7a5e10962a Gerd Hoffmann 2014-10-28 70 return -ENOSYS; 62fb7a5e10962a Gerd Hoffmann 2014-10-28 71 a56f9c868ccf56 Robert Foss 2018-11-12 72 if ((exbuf->flags & ~VIRTGPU_EXECBUF_FLAGS)) a56f9c868ccf56 Robert Foss 2018-11-12 73 return -EINVAL; a56f9c868ccf56 Robert Foss 2018-11-12 74 a56f9c868ccf56 Robert Foss 2018-11-12 75 exbuf->fence_fd = -1; a56f9c868ccf56 Robert Foss 2018-11-12 76 2cd7b6f08bc4cf Robert Foss 2018-11-12 77 if (exbuf->flags & VIRTGPU_EXECBUF_FENCE_FD_IN) { 2cd7b6f08bc4cf Robert Foss 2018-11-12 78 struct dma_fence *in_fence; 2cd7b6f08bc4cf Robert Foss 2018-11-12 79 2cd7b6f08bc4cf Robert Foss 2018-11-12 80 in_fence = sync_file_get_fence(in_fence_fd); 2cd7b6f08bc4cf Robert Foss 2018-11-12 81 2cd7b6f08bc4cf Robert Foss 2018-11-12 82 if (!in_fence) 2cd7b6f08bc4cf Robert Foss 2018-11-12 83 return -EINVAL; 2cd7b6f08bc4cf Robert Foss 2018-11-12 84 2cd7b6f08bc4cf Robert Foss 2018-11-12 85
Re: [PATCH v3 1/2] virtio: stop using legacy struct vring in kernel
Hi "Michael, I love your patch! Yet something to improve: [auto build test ERROR on next-20200406] [also build test ERROR on v5.6] [cannot apply to vhost/linux-next linus/master linux/master v5.6 v5.6-rc7 v5.6-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Michael-S-Tsirkin/virtio-alignment-issues/20200407-025651 base:b2e2a818a01717ba15c74fd355f76822b81a95f6 config: nds32-defconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.3.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from include/linux/virtio.h:12, from include/linux/virtio_config.h:7, from include/uapi/linux/virtio_net.h:30, from include/linux/virtio_net.h:6, from net//packet/af_packet.c:82: >> include/linux/vringh.h:42:15: error: field 'vring' has incomplete type 42 | struct vring vring; | ^ vim +/vring +42 include/linux/vringh.h f87d0fbb579818 Rusty Russell 2013-03-20 20 f87d0fbb579818 Rusty Russell 2013-03-20 21 /* virtio_ring with information needed for host access. */ f87d0fbb579818 Rusty Russell 2013-03-20 22 struct vringh { b9f7ac8c72894c Michael S. Tsirkin 2014-12-12 23/* Everything is little endian */ b9f7ac8c72894c Michael S. Tsirkin 2014-12-12 24bool little_endian; b9f7ac8c72894c Michael S. Tsirkin 2014-12-12 25 f87d0fbb579818 Rusty Russell 2013-03-20 26/* Guest publishes used event idx (note: we always do). */ f87d0fbb579818 Rusty Russell 2013-03-20 27bool event_indices; f87d0fbb579818 Rusty Russell 2013-03-20 28 f87d0fbb579818 Rusty Russell 2013-03-20 29/* Can we get away with weak barriers? */ f87d0fbb579818 Rusty Russell 2013-03-20 30bool weak_barriers; f87d0fbb579818 Rusty Russell 2013-03-20 31 f87d0fbb579818 Rusty Russell 2013-03-20 32/* Last available index we saw (ie. where we're up to). */ f87d0fbb579818 Rusty Russell 2013-03-20 33u16 last_avail_idx; f87d0fbb579818 Rusty Russell 2013-03-20 34 f87d0fbb579818 Rusty Russell 2013-03-20 35/* Last index we used. */ f87d0fbb579818 Rusty Russell 2013-03-20 36u16 last_used_idx; f87d0fbb579818 Rusty Russell 2013-03-20 37 f87d0fbb579818 Rusty Russell 2013-03-20 38/* How many descriptors we've completed since last need_notify(). */ f87d0fbb579818 Rusty Russell 2013-03-20 39u32 completed; f87d0fbb579818 Rusty Russell 2013-03-20 40 f87d0fbb579818 Rusty Russell 2013-03-20 41/* The vring (note: it may contain user pointers!) */ f87d0fbb579818 Rusty Russell 2013-03-20 @42struct vring vring; 3beee86a4b9374 Sjur BrĂŠndeland2013-03-20 43 9ad9c49cfe970b Jason Wang 2020-03-26 44/* IOTLB for this vring */ 9ad9c49cfe970b Jason Wang 2020-03-26 45struct vhost_iotlb *iotlb; 9ad9c49cfe970b Jason Wang 2020-03-26 46 3beee86a4b9374 Sjur BrĂŠndeland2013-03-20 47/* The function to call to notify the guest about added buffers */ 3beee86a4b9374 Sjur BrĂŠndeland2013-03-20 48void (*notify)(struct vringh *); 3beee86a4b9374 Sjur BrĂŠndeland2013-03-20 49 }; 3beee86a4b9374 Sjur BrĂŠndeland2013-03-20 50 :: The code at line 42 was first introduced by commit :: f87d0fbb579818fed3eeb0923cc253163ab93039 vringh: host-side implementation of virtio rings. :: TO: Rusty Russell :: CC: Rusty Russell --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:vhost 22/22] drivers/vdpa/vdpa_sim/vdpa_sim.c:94:8: error: implicit declaration of function 'vringh_init_iotlb'; did you mean 'vringh_init_kern'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 076cb4adba3e2d7d3c25b72a1390b24ebfc58161 commit: 076cb4adba3e2d7d3c25b72a1390b24ebfc58161 [22/22] virtio/test: fix up after IOTLB changes config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 076cb4adba3e2d7d3c25b72a1390b24ebfc58161 # save the attached .config to linux build tree GCC_VERSION=9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_queue_ready': >> drivers/vdpa/vdpa_sim/vdpa_sim.c:94:8: error: implicit declaration of >> function 'vringh_init_iotlb'; did you mean 'vringh_init_kern'? >> [-Werror=implicit-function-declaration] 94 | ret = vringh_init_iotlb(&vq->vring, vdpasim_features, |^ |vringh_init_kern drivers/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_work': >> drivers/vdpa/vdpa_sim/vdpa_sim.c:149:9: error: implicit declaration of >> function 'vringh_getdesc_iotlb'; did you mean 'vringh_getdesc_kern'? >> [-Werror=implicit-function-declaration] 149 | err = vringh_getdesc_iotlb(&txq->vring, &txq->iov, NULL, | ^~~~ | vringh_getdesc_kern >> drivers/vdpa/vdpa_sim/vdpa_sim.c:157:4: error: implicit declaration of >> function 'vringh_complete_iotlb'; did you mean 'vringh_complete_kern'? >> [-Werror=implicit-function-declaration] 157 |vringh_complete_iotlb(&txq->vring, txq->head, 0); |^ |vringh_complete_kern >> drivers/vdpa/vdpa_sim/vdpa_sim.c:162:11: error: implicit declaration of >> function 'vringh_iov_pull_iotlb'; did you mean 'vringh_iov_pull_kern'? >> [-Werror=implicit-function-declaration] 162 |read = vringh_iov_pull_iotlb(&txq->vring, &txq->iov, | ^ | vringh_iov_pull_kern >> drivers/vdpa/vdpa_sim/vdpa_sim.c:168:12: error: implicit declaration of >> function 'vringh_iov_push_iotlb'; did you mean 'vringh_iov_push_kern'? >> [-Werror=implicit-function-declaration] 168 |write = vringh_iov_push_iotlb(&rxq->vring, &rxq->iov, |^ |vringh_iov_push_kern drivers/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_create': >> drivers/vdpa/vdpa_sim/vdpa_sim.c:339:2: error: implicit declaration of >> function 'vringh_set_iotlb' [-Werror=implicit-function-declaration] 339 | vringh_set_iotlb(&vdpasim->vqs[0].vring, vdpasim->iommu); | ^~~~ cc1: some warnings being treated as errors vim +94 drivers/vdpa/vdpa_sim/vdpa_sim.c a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 88 a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 89 static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx) a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 90 { a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 91 struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx]; a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 92 int ret; a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 93 a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 @94 ret = vringh_init_iotlb(&vq->vring, vdpasim_features, a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 95 VDPASIM_QUEUE_MAX, false, a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 96 (struct vring_desc *)(uintptr_t)vq->desc_addr, a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 97 (struct vring_avail *) a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 98 (uintptr_t)vq->driver_addr, a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 99 (struct vring_used *) a35630af6f3198 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c Jason Wang 2020-03-26 100 (uintptr_t)vq->device_addr); a35630af6f3198 drivers/virtio/vdpa/vdpa
[vhost:vhost 22/22] vdpa_sim.c:undefined reference to `vringh_iov_push_iotlb'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 38dd2ba72ece18ec8398c8ddd13cfb02870b0309 commit: 38dd2ba72ece18ec8398c8ddd13cfb02870b0309 [22/22] virtio/test: fix up after IOTLB changes config: m68k-allyesconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 38dd2ba72ece18ec8398c8ddd13cfb02870b0309 # save the attached .config to linux build tree GCC_VERSION=9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): m68k-linux-ld: drivers/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_work': >> vdpa_sim.c:(.text+0x458): undefined reference to `vringh_iov_push_iotlb' >> m68k-linux-ld: vdpa_sim.c:(.text+0x4c0): undefined reference to >> `vringh_iov_pull_iotlb' >> m68k-linux-ld: vdpa_sim.c:(.text+0x504): undefined reference to >> `vringh_complete_iotlb' >> m68k-linux-ld: vdpa_sim.c:(.text+0x478): undefined reference to >> `vringh_getdesc_iotlb' m68k-linux-ld: vdpa_sim.c:(.text+0x496): undefined reference to `vringh_getdesc_iotlb' m68k-linux-ld: vdpa_sim.c:(.text+0x4b0): undefined reference to `vringh_complete_iotlb' m68k-linux-ld: drivers/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_set_status': vdpa_sim.c:(.text+0x764): undefined reference to `vringh_init_iotlb' m68k-linux-ld: drivers/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_set_vq_ready': vdpa_sim.c:(.text+0x844): undefined reference to `vringh_init_iotlb' m68k-linux-ld: drivers/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_dev_init': vdpa_sim.c:(.init.text+0xe4): undefined reference to `vringh_set_iotlb' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:vhost 22/22] riscv64-linux-ld: vdpa_sim.c:undefined reference to `vringh_getdesc_iotlb'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 38dd2ba72ece18ec8398c8ddd13cfb02870b0309 commit: 38dd2ba72ece18ec8398c8ddd13cfb02870b0309 [22/22] virtio/test: fix up after IOTLB changes config: riscv-allyesconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 38dd2ba72ece18ec8398c8ddd13cfb02870b0309 # save the attached .config to linux build tree GCC_VERSION=9.3.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): riscv64-linux-ld: drivers/vdpa/vdpa_sim/vdpa_sim.o: in function `.L42': vdpa_sim.c:(.text+0x682): undefined reference to `vringh_getdesc_iotlb' >> riscv64-linux-ld: vdpa_sim.c:(.text+0x69a): undefined reference to >> `vringh_getdesc_iotlb' >> riscv64-linux-ld: vdpa_sim.c:(.text+0x6b8): undefined reference to >> `vringh_complete_iotlb' riscv64-linux-ld: drivers/vdpa/vdpa_sim/vdpa_sim.o: in function `.L36': >> vdpa_sim.c:(.text+0x6d6): undefined reference to `vringh_iov_pull_iotlb' >> riscv64-linux-ld: vdpa_sim.c:(.text+0x6f4): undefined reference to >> `vringh_iov_push_iotlb' riscv64-linux-ld: drivers/vdpa/vdpa_sim/vdpa_sim.o: in function `.L38': >> vdpa_sim.c:(.text+0x718): undefined reference to `vringh_complete_iotlb' riscv64-linux-ld: vdpa_sim.c:(.text+0x736): undefined reference to `vringh_complete_iotlb' riscv64-linux-ld: drivers/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_set_status': vdpa_sim.c:(.text+0xad2): undefined reference to `vringh_init_iotlb' >> riscv64-linux-ld: vdpa_sim.c:(.text+0xb4e): undefined reference to >> `vringh_init_iotlb' riscv64-linux-ld: drivers/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_set_vq_ready': vdpa_sim.c:(.text+0xc6e): undefined reference to `vringh_init_iotlb' riscv64-linux-ld: drivers/vdpa/vdpa_sim/vdpa_sim.o: in function `.L0 ': vdpa_sim.c:(.init.text+0x1a4): undefined reference to `vringh_set_iotlb' >> riscv64-linux-ld: vdpa_sim.c:(.init.text+0x1be): undefined reference to >> `vringh_set_iotlb' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:linux-next 8/13] include/linux/vringh.h:18:10: fatal error: linux/vhost_iotlb.h: No such file or directory
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: f44a63f9ebf66a450c101084a35a3ef158ead209 commit: c43908b0b9a900bd51f861f4c57b83cfd932f4d2 [8/13] vringh: IOTLB support config: arm-em_x270_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout c43908b0b9a900bd51f861f4c57b83cfd932f4d2 # save the attached .config to linux build tree GCC_VERSION=9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from include/linux/virtio.h:12, from include/linux/virtio_config.h:7, from include/uapi/linux/virtio_net.h:30, from include/linux/virtio_net.h:6, from net//packet/af_packet.c:82: >> include/linux/vringh.h:18:10: fatal error: linux/vhost_iotlb.h: No such file >> or directory 18 | #include | ^ compilation terminated. vim +18 include/linux/vringh.h > 18 #include 19 #include 20 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH V7 7/8] vdpasim: vDPA device simulator
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linux/master linus/master v5.6-rc7 next-20200324] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200324-142634 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: m68k-allyesconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_set_map': vdpa_sim.c:(.text+0x61a): undefined reference to `vhost_iotlb_reset' >> m68k-linux-ld: vdpa_sim.c:(.text+0x64a): undefined reference to >> `vhost_iotlb_itree_next' m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_unmap_page': vdpa_sim.c:(.text+0x22c): undefined reference to `vhost_iotlb_del_range' m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_dma_unmap': vdpa_sim.c:(.text+0x278): undefined reference to `vhost_iotlb_del_range' m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_dma_map': vdpa_sim.c:(.text+0x2cc): undefined reference to `vhost_iotlb_add_range' m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_map_page': vdpa_sim.c:(.text+0x392): undefined reference to `vhost_iotlb_add_range' m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_free_coherent': vdpa_sim.c:(.text+0x3e2): undefined reference to `vhost_iotlb_del_range' m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_free': vdpa_sim.c:(.text+0x5fa): undefined reference to `vhost_iotlb_free' m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_set_map': >> vdpa_sim.c:(.text+0x634): undefined reference to `vhost_iotlb_itree_first' >> m68k-linux-ld: vdpa_sim.c:(.text+0x644): undefined reference to >> `vhost_iotlb_add_range' m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_set_status': vdpa_sim.c:(.text+0x7b8): undefined reference to `vhost_iotlb_reset' m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_alloc_coherent': vdpa_sim.c:(.text+0x8c2): undefined reference to `vhost_iotlb_add_range' m68k-linux-ld: drivers/virtio/vdpa/vdpa_sim/vdpa_sim.o: in function `vdpasim_dev_init': vdpa_sim.c:(.init.text+0x86): undefined reference to `vhost_iotlb_alloc' m68k-linux-ld: drivers/vhost/vringh.o: in function `iotlb_translate.isra.0': vringh.c:(.text+0x172): undefined reference to `vhost_iotlb_itree_first' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH V7 3/8] vringh: IOTLB support
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linux/master linus/master v5.6-rc7 next-20200324] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200324-142634 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: alpha-randconfig-a001-20200324 (attached as .config) compiler: alpha-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=alpha If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): alpha-linux-ld: drivers/vhost/vringh.o: in function `iotlb_translate': drivers/vhost/vringh.c:1079: undefined reference to `vhost_iotlb_itree_first' >> alpha-linux-ld: drivers/vhost/vringh.c:1079: undefined reference to >> `vhost_iotlb_itree_first' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH V6 3/8] vringh: IOTLB support
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linux/master linus/master v5.6-rc6 next-20200317] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200318-191435 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: nds32-randconfig-a001-20200318 (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): nds32le-linux-ld: arch/nds32/kernel/ex-entry.o: in function `common_exception_handler': (.text+0xfe): undefined reference to `__trace_hardirqs_off' (.text+0xfe): relocation truncated to fit: R_NDS32_25_PCREL_RELA against undefined symbol `__trace_hardirqs_off' nds32le-linux-ld: arch/nds32/kernel/ex-exit.o: in function `no_work_pending': (.text+0xce): undefined reference to `__trace_hardirqs_off' nds32le-linux-ld: (.text+0xd2): undefined reference to `__trace_hardirqs_off' nds32le-linux-ld: (.text+0xd6): undefined reference to `__trace_hardirqs_on' nds32le-linux-ld: (.text+0xda): undefined reference to `__trace_hardirqs_on' nds32le-linux-ld: drivers/vhost/vringh.o: in function `iotlb_translate.isra.0': >> vringh.c:(.text+0xa68): undefined reference to `vhost_iotlb_itree_first' >> nds32le-linux-ld: vringh.c:(.text+0xa6c): undefined reference to >> `vhost_iotlb_itree_first' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH V6 3/8] vringh: IOTLB support
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linux/master linus/master v5.6-rc6 next-20200317] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200318-191435 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: h8300-randconfig-a001-20200318 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=h8300 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): h8300-linux-ld: drivers/vhost/vringh.o: in function `iotlb_translate': >> drivers/vhost/vringh.c:1079: undefined reference to `vhost_iotlb_itree_first' vim +1079 drivers/vhost/vringh.c 1061 1062 static int iotlb_translate(const struct vringh *vrh, 1063 u64 addr, u64 len, struct bio_vec iov[], 1064 int iov_size, u32 perm) 1065 { 1066 struct vhost_iotlb_map *map; 1067 struct vhost_iotlb *iotlb = vrh->iotlb; 1068 int ret = 0; 1069 u64 s = 0; 1070 1071 while (len > s) { 1072 u64 size, pa, pfn; 1073 1074 if (unlikely(ret >= iov_size)) { 1075 ret = -ENOBUFS; 1076 break; 1077 } 1078 > 1079 map = vhost_iotlb_itree_first(iotlb, addr, 1080addr + len - 1); 1081 if (!map || map->start > addr) { 1082 ret = -EINVAL; 1083 break; 1084 } else if (!(map->perm & perm)) { 1085 ret = -EPERM; 1086 break; 1087 } 1088 1089 size = map->size - addr + map->start; 1090 pa = map->addr + addr - map->start; 1091 pfn = pa >> PAGE_SHIFT; 1092 iov[ret].bv_page = pfn_to_page(pfn); 1093 iov[ret].bv_len = min(len - s, size); 1094 iov[ret].bv_offset = pa & (PAGE_SIZE - 1); 1095 s += size; 1096 addr += size; 1097 ++ret; 1098 } 1099 1100 return ret; 1101 } 1102 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH V6 8/8] virtio: Intel IFC VF driver for VDPA
Hi Jason, Thank you for the patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linux/master linus/master v5.6-rc6 next-20200317] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200318-191435 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=sh If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/virtio/vdpa/ifcvf/ifcvf_main.c: In function 'ifcvf_probe': drivers/virtio/vdpa/ifcvf/ifcvf_main.c:409:30: error: implicit declaration of function 'pci_iomap_range'; did you mean 'pci_unmap_page'? [-Werror=implicit-function-declaration] 409 | vf->mem_resource[i].addr = pci_iomap_range(pdev, i, 0, | ^~~ | pci_unmap_page drivers/virtio/vdpa/ifcvf/ifcvf_main.c:409:28: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 409 | vf->mem_resource[i].addr = pci_iomap_range(pdev, i, 0, |^ drivers/virtio/vdpa/ifcvf/ifcvf_main.c:443:2: error: implicit declaration of function 'pci_free_irq_vectors'; did you mean 'pci_alloc_irq_vectors'? [-Werror=implicit-function-declaration] 443 | pci_free_irq_vectors(pdev); | ^~~~ | pci_alloc_irq_vectors drivers/virtio/vdpa/ifcvf/ifcvf_main.c: In function 'ifcvf_remove': >> drivers/virtio/vdpa/ifcvf/ifcvf_main.c:463:4: error: implicit declaration of >> function 'pci_iounmap'; did you mean 'pcim_iounmap'? >> [-Werror=implicit-function-declaration] 463 |pci_iounmap(pdev, vf->mem_resource[i].addr); |^~~ |pcim_iounmap drivers/virtio/vdpa/ifcvf/ifcvf_main.c: At top level: drivers/virtio/vdpa/ifcvf/ifcvf_main.c:491:1: warning: data definition has no type or storage class 491 | module_pci_driver(ifcvf_driver); | ^ drivers/virtio/vdpa/ifcvf/ifcvf_main.c:491:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int] drivers/virtio/vdpa/ifcvf/ifcvf_main.c:491:1: warning: parameter names (without types) in function declaration drivers/virtio/vdpa/ifcvf/ifcvf_main.c:484:26: warning: 'ifcvf_driver' defined but not used [-Wunused-variable] 484 | static struct pci_driver ifcvf_driver = { | ^~~~ cc1: some warnings being treated as errors vim +463 drivers/virtio/vdpa/ifcvf/ifcvf_main.c 452 453 static void ifcvf_remove(struct pci_dev *pdev) 454 { 455 struct ifcvf_adapter *adapter = pci_get_drvdata(pdev); 456 struct ifcvf_hw *vf; 457 int i; 458 459 ifcvf_vdpa_detach(adapter); 460 vf = &adapter->vf; 461 for (i = 0; i < IFCVF_PCI_MAX_RESOURCE; i++) { 462 if (vf->mem_resource[i].addr) { > 463 pci_iounmap(pdev, vf->mem_resource[i].addr); 464 vf->mem_resource[i].addr = NULL; 465 } 466 } 467 468 ifcvf_destroy_adapter(adapter); 469 pci_free_irq_vectors(pdev); 470 pci_release_regions(pdev); 471 pci_disable_device(pdev); 472 kfree(adapter); 473 } 474 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH V6 8/8] virtio: Intel IFC VF driver for VDPA
Hi Jason, Thank you for the patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linux/master linus/master v5.6-rc6 next-20200317] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200318-191435 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: c6x-allyesconfig (attached as .config) compiler: c6x-elf-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=c6x If you fix the issue, kindly add following tag Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): drivers/virtio/vdpa/ifcvf/ifcvf_main.c: In function 'ifcvf_probe': >> drivers/virtio/vdpa/ifcvf/ifcvf_main.c:409:30: error: implicit declaration >> of function 'pci_iomap_range'; did you mean 'pci_unmap_page'? >> [-Werror=implicit-function-declaration] 409 | vf->mem_resource[i].addr = pci_iomap_range(pdev, i, 0, | ^~~ | pci_unmap_page >> drivers/virtio/vdpa/ifcvf/ifcvf_main.c:409:28: warning: assignment to 'void >> *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 409 | vf->mem_resource[i].addr = pci_iomap_range(pdev, i, 0, |^ >> drivers/virtio/vdpa/ifcvf/ifcvf_main.c:443:2: error: implicit declaration of >> function 'pci_free_irq_vectors'; did you mean 'pci_alloc_irq_vectors'? >> [-Werror=implicit-function-declaration] 443 | pci_free_irq_vectors(pdev); | ^~~~ | pci_alloc_irq_vectors drivers/virtio/vdpa/ifcvf/ifcvf_main.c: At top level: >> drivers/virtio/vdpa/ifcvf/ifcvf_main.c:491:1: warning: data definition has >> no type or storage class 491 | module_pci_driver(ifcvf_driver); | ^ >> drivers/virtio/vdpa/ifcvf/ifcvf_main.c:491:1: error: type defaults to 'int' >> in declaration of 'module_pci_driver' [-Werror=implicit-int] >> drivers/virtio/vdpa/ifcvf/ifcvf_main.c:491:1: warning: parameter names >> (without types) in function declaration drivers/virtio/vdpa/ifcvf/ifcvf_main.c:484:26: warning: 'ifcvf_driver' defined but not used [-Wunused-variable] 484 | static struct pci_driver ifcvf_driver = { | ^~~~ cc1: some warnings being treated as errors -- drivers/virtio/vdpa/ifcvf/ifcvf_base.c: In function 'ifcvf_init_hw': >> drivers/virtio/vdpa/ifcvf/ifcvf_base.c:110:8: warning: 'pos' is used >> uninitialized in this function [-Wuninitialized] 110 | while (pos) { |^ vim +409 drivers/virtio/vdpa/ifcvf/ifcvf_main.c 365 366 static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id) 367 { 368 struct device *dev = &pdev->dev; 369 struct ifcvf_adapter *adapter; 370 struct ifcvf_hw *vf; 371 int ret, i; 372 373 adapter = kzalloc(sizeof(struct ifcvf_adapter), GFP_KERNEL); 374 if (adapter == NULL) { 375 ret = -ENOMEM; 376 goto fail; 377 } 378 379 adapter->dev = dev; 380 pci_set_drvdata(pdev, adapter); 381 ret = pci_enable_device(pdev); 382 if (ret) { 383 IFCVF_ERR(adapter->dev, "Failed to enable device\n"); 384 goto free_adapter; 385 } 386 387 ret = pci_request_regions(pdev, IFCVF_DRIVER_NAME); 388 if (ret) { 389 IFCVF_ERR(adapter->dev, "Failed to request MMIO region\n"); 390 goto disable_device; 391 } 392 393 pci_set_master(pdev); 394 ret = ifcvf_init_msix(adapter); 395 if (ret) { 396 IFCVF_ERR(adapter->dev, "Failed to initialize MSI-X\n"); 397 goto free_msix; 398 } 399 400 vf = &adapter->vf; 401 for (i = 0; i < IFCVF_PCI_MAX_RESOURCE; i++) { 402 vf->mem_resource[i].phys_addr = pci_resource_start(pdev, i); 403 vf->mem_resource[i].len = pci_res
Re: [PATCH 19/22] drm/virtgpu: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: i386-randconfig-h002-20200307 (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/virtio/virtgpu_display.c: In function 'vgdev_output_init': >> drivers/gpu/drm/virtio/virtgpu_display.c:276:2: error: implicit declaration >> of function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL); ^~~ drm_encoder_init Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:fls Cyclomatic Complexity 1 include/linux/log2.h:__ilog2_u32 Cyclomatic Complexity 1 include/linux/err.h:ERR_PTR Cyclomatic Complexity 1 include/linux/err.h:PTR_ERR Cyclomatic Complexity 3 include/linux/slab.h:kmalloc_type Cyclomatic Complexity 28 include/linux/slab.h:kmalloc_index Cyclomatic Complexity 1 include/linux/slab.h:kmalloc_large Cyclomatic Complexity 4 include/linux/slab.h:kmalloc Cyclomatic Complexity 1 include/linux/slab.h:kzalloc Cyclomatic Complexity 1 include/drm/drm_modeset_helper_vtables.h:drm_crtc_helper_add Cyclomatic Complexity 1 include/drm/drm_modeset_helper_vtables.h:drm_encoder_helper_add Cyclomatic Complexity 1 include/drm/drm_modeset_helper_vtables.h:drm_connector_helper_add Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_crtc_atomic_enable Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_crtc_atomic_check Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_crtc_atomic_flush Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_enc_mode_set Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_enc_enable Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_enc_disable Cyclomatic Complexity 2 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_conn_detect Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:vgdev_atomic_commit_tail Cyclomatic Complexity 67 include/asm-generic/getorder.h:get_order Cyclomatic Complexity 1 include/linux/err.h:IS_ERR Cyclomatic Complexity 2 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_framebuffer_init Cyclomatic Complexity 5 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_user_framebuffer_create Cyclomatic Complexity 5 drivers/gpu/drm/virtio/virtgpu_display.c:vgdev_output_init Cyclomatic Complexity 8 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_conn_mode_valid Cyclomatic Complexity 4 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_conn_get_modes Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_conn_destroy Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_crtc_atomic_disable Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_crtc_mode_set_nofb Cyclomatic Complexity 2 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_modeset_init Cyclomatic Complexity 2 drivers/gpu/drm/virtio/virtgpu_display.c:virtio_gpu_modeset_fini Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:_GLOBAL__sub_I_00100_0_virtio_gpu_modeset_init Cyclomatic Complexity 1 drivers/gpu/drm/virtio/virtgpu_display.c:_GLOBAL__sub_D_00100_1_virtio_gpu_modeset_init cc1: some warnings being treated as errors vim +276 drivers/gpu/drm/virtio/virtgpu_display.c 243 244 static int vgdev_output_init(struct virtio_gpu_device *vgdev, int index) 245 { 246 struct drm_device *dev = vgdev->ddev; 247 struct virtio_gpu_output *output = vgdev->outputs + index; 248 struct drm_connector *connector = &output->conn; 249 struct drm_encoder *encoder = &output->enc; 250 struct drm_crtc *crtc = &output->crtc; 251 struct drm_plane *primary, *cursor; 252 253 output->index = index; 254 if (index == 0) { 255
Re: [PATCH 07/22] drm/i2c/tda998x: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: x86_64-randconfig-h002-20200307 (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/i2c/tda998x_drv.c: In function 'tda998x_encoder_init': >> drivers/gpu/drm/i2c/tda998x_drv.c:2018:8: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(drm, &priv->encoder, ^~~ drm_encoder_init cc1: some warnings being treated as errors vim +2018 drivers/gpu/drm/i2c/tda998x_drv.c 2000 2001 static int tda998x_encoder_init(struct device *dev, struct drm_device *drm) 2002 { 2003 struct tda998x_priv *priv = dev_get_drvdata(dev); 2004 u32 crtcs = 0; 2005 int ret; 2006 2007 if (dev->of_node) 2008 crtcs = drm_of_find_possible_crtcs(drm, dev->of_node); 2009 2010 /* If no CRTCs were found, fall back to our old behaviour */ 2011 if (crtcs == 0) { 2012 dev_warn(dev, "Falling back to first CRTC\n"); 2013 crtcs = 1 << 0; 2014 } 2015 2016 priv->encoder.possible_crtcs = crtcs; 2017 > 2018 ret = drm_simple_encoder_init(drm, &priv->encoder, 2019DRM_MODE_ENCODER_TMDS); 2020 if (ret) 2021 goto err_encoder; 2022 2023 ret = drm_bridge_attach(&priv->encoder, &priv->bridge, NULL, 0); 2024 if (ret) 2025 goto err_bridge; 2026 2027 return 0; 2028 2029 err_bridge: 2030 drm_encoder_cleanup(&priv->encoder); 2031 err_encoder: 2032 return ret; 2033 } 2034 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 20/22] drm/vkms: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: i386-randconfig-h001-20200307 (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu//drm/vkms/vkms_output.c: In function 'vkms_output_init': >> drivers/gpu//drm/vkms/vkms_output.c:70:8: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL); ^~~ drm_encoder_init cc1: some warnings being treated as errors vim +70 drivers/gpu//drm/vkms/vkms_output.c 34 35 int vkms_output_init(struct vkms_device *vkmsdev, int index) 36 { 37 struct vkms_output *output = &vkmsdev->output; 38 struct drm_device *dev = &vkmsdev->drm; 39 struct drm_connector *connector = &output->connector; 40 struct drm_encoder *encoder = &output->encoder; 41 struct drm_crtc *crtc = &output->crtc; 42 struct drm_plane *primary, *cursor = NULL; 43 int ret; 44 45 primary = vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_PRIMARY, index); 46 if (IS_ERR(primary)) 47 return PTR_ERR(primary); 48 49 if (enable_cursor) { 50 cursor = vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_CURSOR, index); 51 if (IS_ERR(cursor)) { 52 ret = PTR_ERR(cursor); 53 goto err_cursor; 54 } 55 } 56 57 ret = vkms_crtc_init(dev, crtc, primary, cursor); 58 if (ret) 59 goto err_crtc; 60 61 ret = drm_connector_init(dev, connector, &vkms_connector_funcs, 62 DRM_MODE_CONNECTOR_VIRTUAL); 63 if (ret) { 64 DRM_ERROR("Failed to init connector\n"); 65 goto err_connector; 66 } 67 68 drm_connector_helper_add(connector, &vkms_conn_helper_funcs); 69 > 70 ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 21/22] drm/writeback: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu/drm/drm_writeback.c:191:8: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(dev, &wb_connector->encoder, ^ drivers/gpu/drm/drm_writeback.c:191:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +191 drivers/gpu/drm/drm_writeback.c 149 150 /** 151 * drm_writeback_connector_init - Initialize a writeback connector and its properties 152 * @dev: DRM device 153 * @wb_connector: Writeback connector to initialize 154 * @con_funcs: Connector funcs vtable 155 * @enc_helper_funcs: Encoder helper funcs vtable to be used by the internal encoder 156 * @formats: Array of supported pixel formats for the writeback engine 157 * @n_formats: Length of the formats array 158 * 159 * This function creates the writeback-connector-specific properties if they 160 * have not been already created, initializes the connector as 161 * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the property 162 * values. It will also create an internal encoder associated with the 163 * drm_writeback_connector and set it to use the @enc_helper_funcs vtable for 164 * the encoder helper. 165 * 166 * Drivers should always use this function instead of drm_connector_init() to 167 * set up writeback connectors. 168 * 169 * Returns: 0 on success, or a negative error code 170 */ 171 int drm_writeback_connector_init(struct drm_device *dev, 172 struct drm_writeback_connector *wb_connector, 173 const struct drm_connector_funcs *con_funcs, 174 const struct drm_encoder_helper_funcs *enc_helper_funcs, 175 const u32 *formats, int n_formats) 176 { 177 struct drm_property_blob *blob; 178 struct drm_connector *connector = &wb_connector->base; 179 struct drm_mode_config *config = &dev->mode_config; 180 int ret = create_writeback_properties(dev); 181 182 if (ret != 0) 183 return ret; 184 185 blob = drm_property_create_blob(dev, n_formats * sizeof(*formats), 186 formats); 187 if (IS_ERR(blob)) 188 return PTR_ERR(blob); 189 190 drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); > 191 ret = drm_simple_encoder_init(dev, &wb_connector->encoder, 192DRM_MODE_ENCODER_VIRTUAL); 193 if (ret) 194 goto fail; 195 196 connector->interlace_allowed = 0; 197 198 ret = drm_connector_init(dev, connector, con_funcs, 199 DRM_MODE_CONNECTOR_WRITEBACK); 200 if (ret) 201 goto connector_fail; 202 203 ret = drm_connector_attach_encoder(connector, 204 &wb_connector->encoder); 205 if (ret) 206 goto attach_fail; 207 208 INIT_LIST_HEAD(&wb_connector->job_queue); 209 spin_lock_init(&wb_connector->job_lock); 210 211 wb_connector->fence_context = dma_fence_context_alloc(1); 212 spin_lock_init(&wb_connector->fence_lock); 213 snprintf(wb_connector->timeline_name, 214 sizeof(wb_connector->timeline_name), 215
Re: [PATCH 18/22] drm/vc4: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu//drm/vc4/vc4_dpi.c:309:2: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, dpi->encoder, DRM_MODE_ENCODER_DPI); ^ drivers/gpu//drm/vc4/vc4_dpi.c:309:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu//drm/vc4/vc4_dsi.c:1610:2: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, dsi->encoder, DRM_MODE_ENCODER_DSI); ^ drivers/gpu//drm/vc4/vc4_dsi.c:1610:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu//drm/vc4/vc4_hdmi.c:1389:2: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, hdmi->encoder, DRM_MODE_ENCODER_TMDS); ^ drivers/gpu//drm/vc4/vc4_hdmi.c:1389:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu//drm/vc4/vc4_vec.c:566:2: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, vec->encoder, DRM_MODE_ENCODER_TVDAC); ^ drivers/gpu//drm/vc4/vc4_vec.c:566:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +309 drivers/gpu//drm/vc4/vc4_dpi.c 254 255 static int vc4_dpi_bind(struct device *dev, struct device *master, void *data) 256 { 257 struct platform_device *pdev = to_platform_device(dev); 258 struct drm_device *drm = dev_get_drvdata(master); 259 struct vc4_dev *vc4 = to_vc4_dev(drm); 260 struct vc4_dpi *dpi; 261 struct vc4_dpi_encoder *vc4_dpi_encoder; 262 int ret; 263 264 dpi = devm_kzalloc(dev, sizeof(*dpi), GFP_KERNEL); 265 if (!dpi) 266 return -ENOMEM; 267 268 vc4_dpi_encoder = devm_kzalloc(dev, sizeof(*vc4_dpi_encoder), 269 GFP_KERNEL); 270 if (!vc4_dpi_encoder) 271 return -ENOMEM; 272 vc4_dpi_encoder->base.type = VC4_ENCODER_TYPE_DPI; 273 vc4_dpi_encoder->dpi = dpi; 274 dpi->encoder = &vc4_dpi_encoder->base.base; 275 276 dpi->pdev = pdev; 277 dpi->regs = vc4_ioremap_regs(pdev, 0); 278 if (IS_ERR(dpi->regs)) 279 return PTR_ERR(dpi->regs); 280 dpi->regset.base = dpi->regs; 281 dpi->regset.regs = dpi_regs; 282 dpi->regset.nregs = ARRAY_SIZE(dpi_regs); 283 284 if (DPI_READ(DPI_ID) != DPI_ID_VALUE) { 285 dev_err(dev, "Port returned 0x%08x for ID instead of 0x%08x\n", 286 DPI_READ(DPI_ID), DPI_ID_VALUE); 287 return -ENODEV; 288 } 289 290 dpi->core_clock = devm_clk_get(dev, "core"); 291 if (IS_ERR(dpi->core_clock)) { 292 ret = PTR_ERR(dp
Re: [PATCH 15/22] drm/tegra: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu/drm/tegra/rgb.c:281:2: error: implicit declaration of function >> 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, &output->encoder, DRM_MODE_ENCODER_LVDS); ^ drivers/gpu/drm/tegra/rgb.c:281:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/tegra/hdmi.c:1445:2: error: implicit declaration of function >> 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, &hdmi->output.encoder, ^ drivers/gpu/drm/tegra/hdmi.c:1445:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/tegra/dsi.c:1058:3: error: implicit declaration of function >> 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, &dsi->output.encoder, ^ drivers/gpu/drm/tegra/dsi.c:1058:3: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/tegra/sor.c:3102:2: error: implicit declaration of function >> 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, &sor->output.encoder, encoder); ^ drivers/gpu/drm/tegra/sor.c:3102:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +281 drivers/gpu/drm/tegra/rgb.c 266 267 int tegra_dc_rgb_init(struct drm_device *drm, struct tegra_dc *dc) 268 { 269 struct tegra_output *output = dc->rgb; 270 int err; 271 272 if (!dc->rgb) 273 return -ENODEV; 274 275 drm_connector_init(drm, &output->connector, &tegra_rgb_connector_funcs, 276 DRM_MODE_CONNECTOR_LVDS); 277 drm_connector_helper_add(&output->connector, 278 &tegra_rgb_connector_helper_funcs); 279 output->connector.dpms = DRM_MODE_DPMS_OFF; 280 > 281 drm_simple_encoder_init(drm, &output->encoder, > DRM_MODE_ENCODER_LVDS); 282 drm_encoder_helper_add(&output->encoder, 283 &tegra_rgb_encoder_helper_funcs); 284 285 drm_connector_attach_encoder(&output->connector, 286&output->encoder); 287 drm_connector_register(&output->connector); 288 289 err = tegra_output_init(drm, output); 290 if (err < 0) { 291 dev_err(output->dev, "failed to initialize output: %d\n", err); 292 return err; 293 } 294 295 /* 296 * Other outputs can be attached to either display controller. The RGB 297 * outputs are an exception and work only with their parent display 298 * controller. 299 */ 300 output->encoder.possible_crtcs = drm_crtc_mask(&dc->base); 301 302 return 0; 303 } 304 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 14/22] drm/sun4i: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu/drm/sun4i/sun4i_lvds.c:121:8: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm, &lvds->encoder, ^ drivers/gpu/drm/sun4i/sun4i_lvds.c:121:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/sun4i/sun4i_rgb.c:213:8: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm, &rgb->encoder, ^ drivers/gpu/drm/sun4i/sun4i_rgb.c:213:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c:611:8: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm, &hdmi->encoder, ^ drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c:611:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:220:2: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS); ^ drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:220:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/sun4i/sun4i_tv.c:587:8: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm, &tv->encoder, ^ drivers/gpu/drm/sun4i/sun4i_tv.c:587:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:1062:8: error: implicit declaration >> of function 'drm_simple_encoder_init' >> [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm, &dsi->encoder, ^ drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:1062:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +121 drivers/gpu/drm/sun4i/sun4i_lvds.c 99 100 int sun4i_lvds_init(struct drm_device *drm, struct sun4i_tcon *tcon) 101 { 102 struct drm_encoder *encoder; 103 struct drm_bridge *bridge; 104 struct sun4i_lvds *lvds; 105 int ret; 106 107 lvds = devm_kzalloc(drm->dev, sizeof(*lvds), GFP_KERNEL); 108 if (!lvds) 109 return -ENOMEM; 110 encoder = &lvds->encoder; 111 112 ret = drm_of_find_panel_or_bridge(tcon->dev->of_node, 1, 0, 113&lvds->panel, &bridge); 114 if (ret) { 115 dev_info(drm->dev, "No p
Re: [PATCH 12/22] drm/rockchip: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:309:8: error: implicit >> declaration of function 'drm_simple_encoder_init' >> [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm_dev, encoder, ^ drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:309:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/rockchip/cdn-dp-core.c:1030:8: error: implicit declaration >> of function 'drm_simple_encoder_init' >> [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm_dev, encoder, ^ drivers/gpu/drm/rockchip/cdn-dp-core.c:1030:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c:546:2: error: implicit >> declaration of function 'drm_simple_encoder_init' >> [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS); ^ drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c:546:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:802:8: error: implicit >> declaration of function 'drm_simple_encoder_init' >> [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI); ^ drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:802:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/rockchip/inno_hdmi.c:617:2: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS); ^ drivers/gpu/drm/rockchip/inno_hdmi.c:617:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +309 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c 297 298 static int rockchip_dp_drm_create_encoder(struct rockchip_dp_device *dp) 299 { 300 struct drm_encoder *encoder = &dp->encoder; 301 struct drm_device *drm_dev = dp->drm_dev; 302 struct device *dev = dp->dev; 303 int ret; 304 305 encoder->possible_crtcs = drm_of_find_possible_crtcs(drm_dev, 306 dev->of_node); 307 DRM_DEBUG_KMS("possible_crtcs = 0x%x\n", encoder->possible_crtcs); 308 > 309 ret = drm_simple_encoder_init(drm_dev, encoder, 310DRM_MODE_ENCODER_TMDS); 311 if (ret) { 312 DRM_ERROR("failed to initialize encoder with drm\n"); 313 return ret; 314 } 315 316 drm_encoder_helper_add(encoder, &rockchip_dp_encoder_helper_funcs); 317 318 return 0; 319 } 320 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 11/22] drm/rcar-du: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu//drm/rcar-du/rcar_du_encoder.c:107:8: error: implicit >> declaration of function 'drm_simple_encoder_init' >> [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(rcdu->ddev, encoder, ^ drivers/gpu//drm/rcar-du/rcar_du_encoder.c:107:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +107 drivers/gpu//drm/rcar-du/rcar_du_encoder.c 46 47 int rcar_du_encoder_init(struct rcar_du_device *rcdu, 48 enum rcar_du_output output, 49 struct device_node *enc_node) 50 { 51 struct rcar_du_encoder *renc; 52 struct drm_encoder *encoder; 53 struct drm_bridge *bridge; 54 int ret; 55 56 renc = devm_kzalloc(rcdu->dev, sizeof(*renc), GFP_KERNEL); 57 if (renc == NULL) 58 return -ENOMEM; 59 60 rcdu->encoders[output] = renc; 61 renc->output = output; 62 encoder = rcar_encoder_to_drm_encoder(renc); 63 64 dev_dbg(rcdu->dev, "initializing encoder %pOF for output %u\n", 65 enc_node, output); 66 67 /* 68 * Locate the DRM bridge from the DT node. For the DPAD outputs, if the 69 * DT node has a single port, assume that it describes a panel and 70 * create a panel bridge. 71 */ 72 if ((output == RCAR_DU_OUTPUT_DPAD0 || 73 output == RCAR_DU_OUTPUT_DPAD1) && 74 rcar_du_encoder_count_ports(enc_node) == 1) { 75 struct drm_panel *panel = of_drm_find_panel(enc_node); 76 77 if (IS_ERR(panel)) { 78 ret = PTR_ERR(panel); 79 goto done; 80 } 81 82 bridge = devm_drm_panel_bridge_add_typed(rcdu->dev, panel, 83 DRM_MODE_CONNECTOR_DPI); 84 if (IS_ERR(bridge)) { 85 ret = PTR_ERR(bridge); 86 goto done; 87 } 88 } else { 89 bridge = of_drm_find_bridge(enc_node); 90 if (!bridge) { 91 ret = -EPROBE_DEFER; 92 goto done; 93 } 94 } 95 96 /* 97 * On Gen3 skip the LVDS1 output if the LVDS1 encoder is used as a 98 * companion for LVDS0 in dual-link mode. 99 */ 100 if (rcdu->info->gen >= 3 && output == RCAR_DU_OUTPUT_LVDS1) { 101 if (rcar_lvds_dual_link(bridge)) { 102 ret = -ENOLINK; 103 goto done; 104 } 105 } 106 > 107 ret = drm_simple_encoder_init(rcdu->ddev, encoder, --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 07/22] drm/i2c/tda998x: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu/drm/i2c/tda998x_drv.c:2018:8: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm, &priv->encoder, ^ drivers/gpu/drm/i2c/tda998x_drv.c:2018:8: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +2018 drivers/gpu/drm/i2c/tda998x_drv.c 2000 2001 static int tda998x_encoder_init(struct device *dev, struct drm_device *drm) 2002 { 2003 struct tda998x_priv *priv = dev_get_drvdata(dev); 2004 u32 crtcs = 0; 2005 int ret; 2006 2007 if (dev->of_node) 2008 crtcs = drm_of_find_possible_crtcs(drm, dev->of_node); 2009 2010 /* If no CRTCs were found, fall back to our old behaviour */ 2011 if (crtcs == 0) { 2012 dev_warn(dev, "Falling back to first CRTC\n"); 2013 crtcs = 1 << 0; 2014 } 2015 2016 priv->encoder.possible_crtcs = crtcs; 2017 > 2018 ret = drm_simple_encoder_init(drm, &priv->encoder, 2019DRM_MODE_ENCODER_TMDS); 2020 if (ret) 2021 goto err_encoder; 2022 2023 ret = drm_bridge_attach(&priv->encoder, &priv->bridge, NULL, 0); 2024 if (ret) 2025 goto err_bridge; 2026 2027 return 0; 2028 2029 err_bridge: 2030 drm_encoder_cleanup(&priv->encoder); 2031 err_encoder: 2032 return ret; 2033 } 2034 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 06/22] drm/hisilicon/kirin: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu//drm/hisilicon/kirin/dw_drm_dsi.c:713:8: error: implicit >> declaration of function 'drm_simple_encoder_init' >> [-Werror,-Wimplicit-function-declaration] ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI); ^ drivers/gpu//drm/hisilicon/kirin/dw_drm_dsi.c:713:8: note: did you mean 'drm_i2c_encoder_init'? include/drm/drm_encoder_slave.h:104:5: note: 'drm_i2c_encoder_init' declared here int drm_i2c_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +713 drivers/gpu//drm/hisilicon/kirin/dw_drm_dsi.c 699 700 static int dw_drm_encoder_init(struct device *dev, 701 struct drm_device *drm_dev, 702 struct drm_encoder *encoder) 703 { 704 int ret; 705 u32 crtc_mask = drm_of_find_possible_crtcs(drm_dev, dev->of_node); 706 707 if (!crtc_mask) { 708 DRM_ERROR("failed to find crtc mask\n"); 709 return -EINVAL; 710 } 711 712 encoder->possible_crtcs = crtc_mask; > 713 ret = drm_simple_encoder_init(drm_dev, encoder, > DRM_MODE_ENCODER_DSI); 714 if (ret) { 715 DRM_ERROR("failed to init dsi encoder\n"); 716 return ret; 717 } 718 719 drm_encoder_helper_add(encoder, &dw_encoder_helper_funcs); 720 721 return 0; 722 } 723 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 03/22] drm/exynos: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu/drm/exynos/exynos_drm_dsi.c:1705:2: error: implicit declaration >> of function 'drm_simple_encoder_init' >> [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); ^ drivers/gpu/drm/exynos/exynos_drm_dsi.c:1705:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/exynos/exynos_hdmi.c:1851:2: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); ^ drivers/gpu/drm/exynos/exynos_hdmi.c:1851:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +1705 drivers/gpu/drm/exynos/exynos_drm_dsi.c 1695 1696 static int exynos_dsi_bind(struct device *dev, struct device *master, 1697 void *data) 1698 { 1699 struct drm_encoder *encoder = dev_get_drvdata(dev); 1700 struct exynos_dsi *dsi = encoder_to_dsi(encoder); 1701 struct drm_device *drm_dev = data; 1702 struct drm_bridge *in_bridge; 1703 int ret; 1704 > 1705 drm_simple_encoder_init(drm_dev, encoder, > DRM_MODE_ENCODER_TMDS); 1706 1707 drm_encoder_helper_add(encoder, &exynos_dsi_encoder_helper_funcs); 1708 1709 ret = exynos_drm_set_possible_crtcs(encoder, EXYNOS_DISPLAY_TYPE_LCD); 1710 if (ret < 0) 1711 return ret; 1712 1713 if (dsi->in_bridge_node) { 1714 in_bridge = of_drm_find_bridge(dsi->in_bridge_node); 1715 if (in_bridge) 1716 drm_bridge_attach(encoder, in_bridge, NULL, 0); 1717 } 1718 1719 return mipi_dsi_host_register(&dsi->dsi_host); 1720 } 1721 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 21/22] drm/writeback: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: mips-randconfig-a001-20200306 (attached as .config) compiler: mipsel-linux-gcc (GCC) 5.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=5.5.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/drm_writeback.c: In function 'drm_writeback_connector_init': >> drivers/gpu/drm/drm_writeback.c:191:8: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(dev, &wb_connector->encoder, ^ cc1: some warnings being treated as errors vim +/drm_simple_encoder_init +191 drivers/gpu/drm/drm_writeback.c 149 150 /** 151 * drm_writeback_connector_init - Initialize a writeback connector and its properties 152 * @dev: DRM device 153 * @wb_connector: Writeback connector to initialize 154 * @con_funcs: Connector funcs vtable 155 * @enc_helper_funcs: Encoder helper funcs vtable to be used by the internal encoder 156 * @formats: Array of supported pixel formats for the writeback engine 157 * @n_formats: Length of the formats array 158 * 159 * This function creates the writeback-connector-specific properties if they 160 * have not been already created, initializes the connector as 161 * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the property 162 * values. It will also create an internal encoder associated with the 163 * drm_writeback_connector and set it to use the @enc_helper_funcs vtable for 164 * the encoder helper. 165 * 166 * Drivers should always use this function instead of drm_connector_init() to 167 * set up writeback connectors. 168 * 169 * Returns: 0 on success, or a negative error code 170 */ 171 int drm_writeback_connector_init(struct drm_device *dev, 172 struct drm_writeback_connector *wb_connector, 173 const struct drm_connector_funcs *con_funcs, 174 const struct drm_encoder_helper_funcs *enc_helper_funcs, 175 const u32 *formats, int n_formats) 176 { 177 struct drm_property_blob *blob; 178 struct drm_connector *connector = &wb_connector->base; 179 struct drm_mode_config *config = &dev->mode_config; 180 int ret = create_writeback_properties(dev); 181 182 if (ret != 0) 183 return ret; 184 185 blob = drm_property_create_blob(dev, n_formats * sizeof(*formats), 186 formats); 187 if (IS_ERR(blob)) 188 return PTR_ERR(blob); 189 190 drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); > 191 ret = drm_simple_encoder_init(dev, &wb_connector->encoder, 192DRM_MODE_ENCODER_VIRTUAL); 193 if (ret) 194 goto fail; 195 196 connector->interlace_allowed = 0; 197 198 ret = drm_connector_init(dev, connector, con_funcs, 199 DRM_MODE_CONNECTOR_WRITEBACK); 200 if (ret) 201 goto connector_fail; 202 203 ret = drm_connector_attach_encoder(connector, 204 &wb_connector->encoder); 205 if (ret) 206 goto attach_fail; 207 208 INIT_LIST_HEAD(&wb_connector->job_queue); 209 spin_lock_init(&wb_connector->job_lock); 210 211 wb_connector->fence_context = dma_fence_context_alloc(1); 212 spin_lock_init(&wb_connector->fence_lock); 213 snprintf(wb_connector->timeline_name, 214 sizeof(wb_connector->timeline_name), 215
Re: [PATCH 03/22] drm/exynos: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/exynos/exynos_drm_dpi.c: In function 'exynos_dpi_bind': >> drivers/gpu/drm/exynos/exynos_drm_dpi.c:201:2: error: implicit declaration >> of function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_TMDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/exynos/exynos_dp.c: In function 'exynos_dp_bind': >> drivers/gpu/drm/exynos/exynos_dp.c:174:2: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors vim +201 drivers/gpu/drm/exynos/exynos_drm_dpi.c 196 197 int exynos_dpi_bind(struct drm_device *dev, struct drm_encoder *encoder) 198 { 199 int ret; 200 > 201 drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_TMDS); 202 203 drm_encoder_helper_add(encoder, &exynos_dpi_encoder_helper_funcs); 204 205 ret = exynos_drm_set_possible_crtcs(encoder, EXYNOS_DISPLAY_TYPE_LCD); 206 if (ret < 0) 207 return ret; 208 209 ret = exynos_dpi_create_connector(encoder); 210 if (ret) { 211 DRM_DEV_ERROR(encoder_to_dpi(encoder)->dev, 212"failed to create connector ret = %d\n", ret); 213 drm_encoder_cleanup(encoder); 214 return ret; 215 } 216 217 return 0; 218 } 219 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 21/22] drm/writeback: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: x86_64-defconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/drm_writeback.c: In function 'drm_writeback_connector_init': >> drivers/gpu/drm/drm_writeback.c:191:8: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(dev, &wb_connector->encoder, ^~~ drm_encoder_init cc1: some warnings being treated as errors vim +191 drivers/gpu/drm/drm_writeback.c 149 150 /** 151 * drm_writeback_connector_init - Initialize a writeback connector and its properties 152 * @dev: DRM device 153 * @wb_connector: Writeback connector to initialize 154 * @con_funcs: Connector funcs vtable 155 * @enc_helper_funcs: Encoder helper funcs vtable to be used by the internal encoder 156 * @formats: Array of supported pixel formats for the writeback engine 157 * @n_formats: Length of the formats array 158 * 159 * This function creates the writeback-connector-specific properties if they 160 * have not been already created, initializes the connector as 161 * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the property 162 * values. It will also create an internal encoder associated with the 163 * drm_writeback_connector and set it to use the @enc_helper_funcs vtable for 164 * the encoder helper. 165 * 166 * Drivers should always use this function instead of drm_connector_init() to 167 * set up writeback connectors. 168 * 169 * Returns: 0 on success, or a negative error code 170 */ 171 int drm_writeback_connector_init(struct drm_device *dev, 172 struct drm_writeback_connector *wb_connector, 173 const struct drm_connector_funcs *con_funcs, 174 const struct drm_encoder_helper_funcs *enc_helper_funcs, 175 const u32 *formats, int n_formats) 176 { 177 struct drm_property_blob *blob; 178 struct drm_connector *connector = &wb_connector->base; 179 struct drm_mode_config *config = &dev->mode_config; 180 int ret = create_writeback_properties(dev); 181 182 if (ret != 0) 183 return ret; 184 185 blob = drm_property_create_blob(dev, n_formats * sizeof(*formats), 186 formats); 187 if (IS_ERR(blob)) 188 return PTR_ERR(blob); 189 190 drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); > 191 ret = drm_simple_encoder_init(dev, &wb_connector->encoder, 192DRM_MODE_ENCODER_VIRTUAL); 193 if (ret) 194 goto fail; 195 196 connector->interlace_allowed = 0; 197 198 ret = drm_connector_init(dev, connector, con_funcs, 199 DRM_MODE_CONNECTOR_WRITEBACK); 200 if (ret) 201 goto connector_fail; 202 203 ret = drm_connector_attach_encoder(connector, 204 &wb_connector->encoder); 205 if (ret) 206 goto attach_fail; 207 208 INIT_LIST_HEAD(&wb_connector->job_queue); 209 spin_lock_init(&wb_connector->job_lock); 210 211 wb_connector->fence_context = dma_fence_context_alloc(1); 212 spin_lock_init(&wb_connector->fence_lock); 213 snprintf(wb_connector->timeline_name, 214 sizeof(wb_connector->timeline_name), 215 "CONNECTOR:%d-%s", connector->base.id, connector->name); 216
Re: [PATCH 05/22] drm/gma500: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/gma500/psb_intel_lvds.c: In function 'psb_intel_lvds_init': >> drivers/gpu/drm/gma500/psb_intel_lvds.c:676:2: error: implicit declaration >> of function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_LVDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/gma500/cdv_intel_crt.c: In function 'cdv_intel_crt_init': >> drivers/gpu/drm/gma500/cdv_intel_crt.c:267:2: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_DAC); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/gma500/cdv_intel_hdmi.c: In function 'cdv_hdmi_init': >> drivers/gpu/drm/gma500/cdv_intel_hdmi.c:315:2: error: implicit declaration >> of function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_TMDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/gma500/cdv_intel_dp.c: In function 'cdv_intel_dp_init': >> drivers/gpu/drm/gma500/cdv_intel_dp.c:2010:2: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_TMDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/gma500/cdv_intel_lvds.c: In function 'cdv_intel_lvds_init': >> drivers/gpu/drm/gma500/cdv_intel_lvds.c:611:2: error: implicit declaration >> of function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_LVDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/gma500/oaktrail_lvds.c: In function 'oaktrail_lvds_init': >> drivers/gpu/drm/gma500/oaktrail_lvds.c:316:2: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_LVDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/gma500/oaktrail_hdmi.c: In function 'oaktrail_hdmi_init': >> drivers/gpu/drm/gma500/oaktrail_hdmi.c:646:2: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_TMDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/gma500/mdfld_dsi_dpi.c: In function 'mdfld_dsi_dpi_init': >> drivers/gpu/drm/gma500/mdfld_dsi_dpi.c:998:2: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_LVDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors vim +676 drivers/gpu/drm/gma500/psb_intel_lvds.c 625 626 /** 627
Re: [PATCH 02/22] drm/atmel-hlcdc: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm-at91_dt_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu//drm/atmel-hlcdc/atmel_hlcdc_output.c: In function 'atmel_hlcdc_attach_endpoint': >> drivers/gpu//drm/atmel-hlcdc/atmel_hlcdc_output.c:98:8: error: implicit >> declaration of function 'drm_simple_encoder_init'; did you mean >> 'drm_encoder_init'? [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(dev, &output->encoder, ^~~ drm_encoder_init cc1: some warnings being treated as errors vim +98 drivers/gpu//drm/atmel-hlcdc/atmel_hlcdc_output.c 65 66 static int atmel_hlcdc_attach_endpoint(struct drm_device *dev, int endpoint) 67 { 68 struct atmel_hlcdc_rgb_output *output; 69 struct device_node *ep; 70 struct drm_panel *panel; 71 struct drm_bridge *bridge; 72 int ret; 73 74 ep = of_graph_get_endpoint_by_regs(dev->dev->of_node, 0, endpoint); 75 if (!ep) 76 return -ENODEV; 77 78 ret = drm_of_find_panel_or_bridge(dev->dev->of_node, 0, endpoint, 79&panel, &bridge); 80 if (ret) { 81 of_node_put(ep); 82 return ret; 83 } 84 85 output = devm_kzalloc(dev->dev, sizeof(*output), GFP_KERNEL); 86 if (!output) { 87 of_node_put(ep); 88 return -ENOMEM; 89 } 90 91 output->bus_fmt = atmel_hlcdc_of_bus_fmt(ep); 92 of_node_put(ep); 93 if (output->bus_fmt < 0) { 94 dev_err(dev->dev, "endpoint %d: invalid bus width\n", endpoint); 95 return -EINVAL; 96 } 97 > 98 ret = drm_simple_encoder_init(dev, &output->encoder, 99DRM_MODE_ENCODER_NONE); 100 if (ret) 101 return ret; 102 103 output->encoder.possible_crtcs = 0x1; 104 105 if (panel) { 106 bridge = drm_panel_bridge_add_typed(panel, 107 DRM_MODE_CONNECTOR_Unknown); 108 if (IS_ERR(bridge)) 109 return PTR_ERR(bridge); 110 } 111 112 if (bridge) { 113 ret = drm_bridge_attach(&output->encoder, bridge, NULL, 0); 114 if (!ret) 115 return 0; 116 117 if (panel) 118 drm_panel_bridge_remove(bridge); 119 } 120 121 drm_encoder_cleanup(&output->encoder); 122 123 return ret; 124 } 125 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 20/22] drm/vkms: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: mips-randconfig-a001-20200306 (attached as .config) compiler: mipsel-linux-gcc (GCC) 5.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=5.5.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/vkms/vkms_output.c: In function 'vkms_output_init': >> drivers/gpu/drm/vkms/vkms_output.c:70:8: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL); ^ cc1: some warnings being treated as errors vim +/drm_simple_encoder_init +70 drivers/gpu/drm/vkms/vkms_output.c 34 35 int vkms_output_init(struct vkms_device *vkmsdev, int index) 36 { 37 struct vkms_output *output = &vkmsdev->output; 38 struct drm_device *dev = &vkmsdev->drm; 39 struct drm_connector *connector = &output->connector; 40 struct drm_encoder *encoder = &output->encoder; 41 struct drm_crtc *crtc = &output->crtc; 42 struct drm_plane *primary, *cursor = NULL; 43 int ret; 44 45 primary = vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_PRIMARY, index); 46 if (IS_ERR(primary)) 47 return PTR_ERR(primary); 48 49 if (enable_cursor) { 50 cursor = vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_CURSOR, index); 51 if (IS_ERR(cursor)) { 52 ret = PTR_ERR(cursor); 53 goto err_cursor; 54 } 55 } 56 57 ret = vkms_crtc_init(dev, crtc, primary, cursor); 58 if (ret) 59 goto err_crtc; 60 61 ret = drm_connector_init(dev, connector, &vkms_connector_funcs, 62 DRM_MODE_CONNECTOR_VIRTUAL); 63 if (ret) { 64 DRM_ERROR("Failed to init connector\n"); 65 goto err_connector; 66 } 67 68 drm_connector_helper_add(connector, &vkms_conn_helper_funcs); 69 > 70 ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 04/22] drm/fsl-dcu: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm-multi_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c: In function 'fsl_dcu_drm_encoder_create': >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c:33:8: error: implicit declaration >> of function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(fsl_dev->drm, encoder, ^~~ drm_encoder_init cc1: some warnings being treated as errors vim +33 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c 20 21 int fsl_dcu_drm_encoder_create(struct fsl_dcu_drm_device *fsl_dev, 22 struct drm_crtc *crtc) 23 { 24 struct drm_encoder *encoder = &fsl_dev->encoder; 25 int ret; 26 27 encoder->possible_crtcs = 1; 28 29 /* Use bypass mode for parallel RGB/LVDS encoder */ 30 if (fsl_dev->tcon) 31 fsl_tcon_bypass_enable(fsl_dev->tcon); 32 > 33 ret = drm_simple_encoder_init(fsl_dev->drm, encoder, 34DRM_MODE_ENCODER_LVDS); 35 if (ret < 0) 36 return ret; 37 38 return 0; 39 } 40 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 12/22] drm/rockchip: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2 v5.6-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: sparc-allyesconfig (attached as .config) compiler: sparc64-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=sparc If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/rockchip/analogix_dp-rockchip.c: In function 'rockchip_dp_drm_create_encoder': >> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c:309:8: error: implicit >> declaration of function 'drm_simple_encoder_init'; did you mean >> 'drm_encoder_init'? [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(drm_dev, encoder, ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/rockchip/cdn-dp-core.c: In function 'cdn_dp_bind': >> drivers/gpu/drm/rockchip/cdn-dp-core.c:1030:8: error: implicit declaration >> of function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(drm_dev, encoder, ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c: In function 'dw_hdmi_rockchip_bind': >> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c:546:2: error: implicit >> declaration of function 'drm_simple_encoder_init'; did you mean >> 'drm_encoder_init'? [-Werror=implicit-function-declaration] drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c: In function 'rockchip_dsi_drm_create_encoder': >> drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:802:8: error: implicit >> declaration of function 'drm_simple_encoder_init'; did you mean >> 'drm_encoder_init'? [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/rockchip/inno_hdmi.c: In function 'inno_hdmi_register': >> drivers/gpu/drm/rockchip/inno_hdmi.c:617:2: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_bind': >> drivers/gpu/drm/rockchip/rockchip_lvds.c:607:8: error: implicit declaration >> of function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_LVDS); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/rockchip/rockchip_rgb.c: In function 'rockchip_rgb_init': >> drivers/gpu/drm/rockchip/rockchip_rgb.c:125:8: error: implicit declaration >> of function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_NONE); ^~~ drm_encoder_init cc1: some warnings being treated as errors -- drivers/gpu/drm/rockchip/rk3066_hdmi.c: In function 'rk3066_hdmi_register': >> drivers/gpu/drm/rockchip/rk3066_hdmi.c:557:2: error: implicit declaration of >> function 'drm_simple_encoder_init'; did you mean 'drm_encoder_init'? >> [-Werror=imp
Re: [PATCH 01/22] drm/arc: Use simple encoder
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base:47466dcf84ee66a973ea7d2fca7e582fe9328932 config: mips-randconfig-a001-20200306 (attached as .config) compiler: mipsel-linux-gcc (GCC) 5.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=5.5.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/arc/arcpgu_hdmi.c: In function 'arcpgu_drm_hdmi_init': >> drivers/gpu/drm/arc/arcpgu_hdmi.c:34:8: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS); ^ cc1: some warnings being treated as errors -- drivers/gpu/drm/arc/arcpgu_sim.c: In function 'arcpgu_drm_sim_init': >> drivers/gpu/drm/arc/arcpgu_sim.c:68:8: error: implicit declaration of >> function 'drm_simple_encoder_init' [-Werror=implicit-function-declaration] ret = drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_VIRTUAL); ^ cc1: some warnings being treated as errors vim +/drm_simple_encoder_init +34 drivers/gpu/drm/arc/arcpgu_hdmi.c 15 16 int arcpgu_drm_hdmi_init(struct drm_device *drm, struct device_node *np) 17 { 18 struct drm_encoder *encoder; 19 struct drm_bridge *bridge; 20 21 int ret = 0; 22 23 encoder = devm_kzalloc(drm->dev, sizeof(*encoder), GFP_KERNEL); 24 if (encoder == NULL) 25 return -ENOMEM; 26 27 /* Locate drm bridge from the hdmi encoder DT node */ 28 bridge = of_drm_find_bridge(np); 29 if (!bridge) 30 return -EPROBE_DEFER; 31 32 encoder->possible_crtcs = 1; 33 encoder->possible_clones = 0; > 34 ret = drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v1 02/11] virtio-mem: Paravirtualized memory hotplug
Hi David, I love your patch! Yet something to improve: [auto build test ERROR on pm/linux-next] [also build test ERROR on linus/master v5.6-rc4 next-20200302] [cannot apply to linux/master mmotm/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/David-Hildenbrand/virtio-mem-paravirtualized-memory/20200303-020852 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: x86_64-randconfig-s1-20200303 (attached as .config) compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from :1:0: >> ./usr/include/linux/virtio_mem.h:185:2: error: unknown type name 'uint32_t' uint32_t block_size; ^ >> ./usr/include/linux/virtio_mem.h:187:2: error: unknown type name 'uint16_t' uint16_t node_id; ^ ./usr/include/linux/virtio_mem.h:188:2: error: unknown type name 'uint16_t' uint16_t padding; ^ >> ./usr/include/linux/virtio_mem.h:190:2: error: unknown type name 'uint64_t' uint64_t addr; ^ ./usr/include/linux/virtio_mem.h:192:2: error: unknown type name 'uint64_t' uint64_t region_size; ^ ./usr/include/linux/virtio_mem.h:198:2: error: unknown type name 'uint64_t' uint64_t usable_region_size; ^ ./usr/include/linux/virtio_mem.h:203:2: error: unknown type name 'uint64_t' uint64_t plugged_size; ^ ./usr/include/linux/virtio_mem.h:205:2: error: unknown type name 'uint64_t' uint64_t requested_size; ^ --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v2 3/3] iommu/virtio: Enable x86 support
Hi Jean-Philippe, I love your patch! Perhaps something to improve: [auto build test WARNING on iommu/next] [cannot apply to pci/next linus/master v5.6-rc3 next-20200228] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jean-Philippe-Brucker/virtio-iommu-on-x86-and-non-devicetree-platforms/20200229-085019 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next reproduce: # apt-get install sparse # sparse version: v0.6.1-173-ge0787745-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/iommu/virtio-iommu.c:1024:9: sparse: sparse: incompatible types in >> comparison expression (different base types): >> drivers/iommu/virtio-iommu.c:1024:9: sparse:restricted __le64 * >> drivers/iommu/virtio-iommu.c:1024:9: sparse:unsigned long long * drivers/iommu/virtio-iommu.c:1036:9: sparse: sparse: incompatible types in comparison expression (different base types): drivers/iommu/virtio-iommu.c:1036:9: sparse:restricted __le64 * drivers/iommu/virtio-iommu.c:1036:9: sparse:unsigned long long * drivers/iommu/virtio-iommu.c:1040:9: sparse: sparse: incompatible types in comparison expression (different base types): drivers/iommu/virtio-iommu.c:1040:9: sparse:restricted __le64 * drivers/iommu/virtio-iommu.c:1040:9: sparse:unsigned long long * drivers/iommu/virtio-iommu.c:1044:9: sparse: sparse: incompatible types in comparison expression (different base types): >> drivers/iommu/virtio-iommu.c:1044:9: sparse:restricted __le32 * >> drivers/iommu/virtio-iommu.c:1044:9: sparse:unsigned int * drivers/iommu/virtio-iommu.c:1048:9: sparse: sparse: incompatible types in comparison expression (different base types): drivers/iommu/virtio-iommu.c:1048:9: sparse:restricted __le32 * drivers/iommu/virtio-iommu.c:1048:9: sparse:unsigned int * drivers/iommu/virtio-iommu.c:1052:9: sparse: sparse: incompatible types in comparison expression (different base types): drivers/iommu/virtio-iommu.c:1052:9: sparse:restricted __le32 * drivers/iommu/virtio-iommu.c:1052:9: sparse:unsigned int * vim +1024 drivers/iommu/virtio-iommu.c edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 996 edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 997 static int viommu_probe(struct virtio_device *vdev) edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 998 { edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 999 struct device *parent_dev = vdev->dev.parent; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1000 struct viommu_dev *viommu = NULL; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1001 struct device *dev = &vdev->dev; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1002 u64 input_start = 0; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1003 u64 input_end = -1UL; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1004 int ret; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1005 edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1006 if (!virtio_has_feature(vdev, VIRTIO_F_VERSION_1) || edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1007 !virtio_has_feature(vdev, VIRTIO_IOMMU_F_MAP_UNMAP)) edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1008 return -ENODEV; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1009 edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1010 viommu = devm_kzalloc(dev, sizeof(*viommu), GFP_KERNEL); edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1011 if (!viommu) edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1012 return -ENOMEM; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1013 edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1014 spin_lock_init(&viommu->request_lock); edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1015 ida_init(&viommu->domain_ids); edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1016 viommu->dev = dev; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1017 viommu->vdev = vdev; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1018 INIT_LIST_HEAD(&viommu->requests); edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1019 edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1020 ret = viommu_init_vqs(viommu); edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1021 if (ret) edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1022 return ret; edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1023 edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 @1024 virtio_cread(vdev,
Re: [PATCH 02/14] drm/msm/mdp5: Remove direct access of dev->iommu_fwspec
Hi Joerg, I love your patch! Yet something to improve: [auto build test ERROR on pm/linux-next] [also build test ERROR on tegra/for-next linux/master linus/master v5.6-rc3 next-20200228] [cannot apply to iommu/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-Move-iommu_fwspec-out-of-struct-device/20200229-075740 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: arm-imx_v6_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c: In function 'mdp5_kms_init': >> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:728:8: error: implicit declaration >> of function 'dev_iommu_fwspec_get'; did you mean 'iommu_fwspec_free'? >> [-Werror=implicit-function-declaration] if (!dev_iommu_fwspec_get(iommu_dev)) ^~~~ iommu_fwspec_free cc1: some warnings being treated as errors vim +728 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c 677 678 struct msm_kms *mdp5_kms_init(struct drm_device *dev) 679 { 680 struct msm_drm_private *priv = dev->dev_private; 681 struct platform_device *pdev; 682 struct mdp5_kms *mdp5_kms; 683 struct mdp5_cfg *config; 684 struct msm_kms *kms; 685 struct msm_gem_address_space *aspace; 686 int irq, i, ret; 687 struct device *iommu_dev; 688 689 /* priv->kms would have been populated by the MDP5 driver */ 690 kms = priv->kms; 691 if (!kms) 692 return NULL; 693 694 mdp5_kms = to_mdp5_kms(to_mdp_kms(kms)); 695 696 mdp_kms_init(&mdp5_kms->base, &kms_funcs); 697 698 pdev = mdp5_kms->pdev; 699 700 irq = irq_of_parse_and_map(pdev->dev.of_node, 0); 701 if (irq < 0) { 702 ret = irq; 703 DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret); 704 goto fail; 705 } 706 707 kms->irq = irq; 708 709 config = mdp5_cfg_get_config(mdp5_kms->cfg); 710 711 /* make sure things are off before attaching iommu (bootloader could 712 * have left things on, in which case we'll start getting faults if 713 * we don't disable): 714 */ 715 pm_runtime_get_sync(&pdev->dev); 716 for (i = 0; i < MDP5_INTF_NUM_MAX; i++) { 717 if (mdp5_cfg_intf_is_virtual(config->hw->intf.connect[i]) || 718 !config->hw->intf.base[i]) 719 continue; 720 mdp5_write(mdp5_kms, REG_MDP5_INTF_TIMING_ENGINE_EN(i), 0); 721 722 mdp5_write(mdp5_kms, REG_MDP5_INTF_FRAME_LINE_COUNT_EN(i), 0x3); 723 } 724 mdelay(16); 725 726 if (config->platform.iommu) { 727 iommu_dev = &pdev->dev; > 728 if (!dev_iommu_fwspec_get(iommu_dev)) 729 iommu_dev = iommu_dev->parent; 730 731 aspace = msm_gem_address_space_create(iommu_dev, 732 config->platform.iommu, "mdp5"); 733 if (IS_ERR(aspace)) { 734 ret = PTR_ERR(aspace); 735 goto fail; 736 } 737 738 kms->aspace = aspace; 739 740 ret = aspace->mmu->funcs->attach(aspace->mmu); 741 if (ret) { 742 DRM_DEV_ERROR(&pdev->dev, "failed to attach iommu: %d\n", 743 ret); 744 goto fail; 745 } 746 } else { 747 DRM_DEV_INFO(&pdev->dev, 748 "no iommu, fallback to phys contig buffers for scanout\n"); 749 aspace = NULL; 750 } 751 752 pm_runtime_put_s
Re: [PATCH V5 5/5] vdpasim: vDPA device simulator
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.6-rc3] [cannot apply to vhost/linux-next next-20200226] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200226-173606 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f5ae2ea6347a308cfe91f53b53682ce635497d0d config: um-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=um If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_create': >> drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:335:2: error: implicit declaration >> of function 'set_dma_ops'; did you mean 'set_groups'? >> [-Werror=implicit-function-declaration] set_dma_ops(dev, &vdpasim_dma_ops); ^~~ set_groups Cyclomatic Complexity 5 include/linux/compiler.h:__write_once_size Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:fls64 Cyclomatic Complexity 1 include/linux/log2.h:__ilog2_u64 Cyclomatic Complexity 1 include/linux/list.h:INIT_LIST_HEAD Cyclomatic Complexity 1 arch/um/include/shared/mem.h:to_phys Cyclomatic Complexity 1 arch/um/include/shared/mem.h:to_virt Cyclomatic Complexity 1 include/linux/spinlock.h:spinlock_check Cyclomatic Complexity 1 include/linux/spinlock.h:spin_lock Cyclomatic Complexity 1 include/linux/spinlock.h:spin_unlock Cyclomatic Complexity 1 include/linux/err.h:ERR_PTR Cyclomatic Complexity 1 include/linux/err.h:PTR_ERR Cyclomatic Complexity 1 include/linux/slab.h:kmalloc_type Cyclomatic Complexity 28 include/linux/slab.h:kmalloc_index Cyclomatic Complexity 1 include/linux/slab.h:kmalloc_large Cyclomatic Complexity 4 include/linux/slab.h:kmalloc Cyclomatic Complexity 1 include/linux/slab.h:kzalloc Cyclomatic Complexity 1 include/asm-generic/io.h:virt_to_phys Cyclomatic Complexity 1 include/asm-generic/io.h:phys_to_virt Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:dev_to_sim Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpa_to_sim Cyclomatic Complexity 4 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:dir_to_perm Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_set_vq_address Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_set_vq_num Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_set_vq_cb Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_get_vq_ready Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_set_vq_state Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_get_vq_state Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_get_vq_align Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_get_features Cyclomatic Complexity 2 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_set_features Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_set_config_cb Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_get_vq_num_max Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_get_device_id Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_get_vendor_id Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_get_status Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_set_config Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_get_generation Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_dev_exit Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_dma_map Cyclomatic Complexity 3 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_map_page Cyclomatic Complexity 3 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_set_map Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_queue_ready Cyclomatic Complexity 2 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_set_vq_ready Cyclomatic Complexity 1 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_vq_reset Cyclomatic Complexity 2 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_reset Cyclomatic Complexity 2 drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c:vdpasim_set_status Cyclomatic Complexity 1 include/linux/workqueue.h:queue_work Cyclomatic Complexity 1 include/linux/workqueue.h:sc
Re: [PATCH v2] virtio: Work around frames incorrectly marked as gso
Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on vhost/linux-next] [also build test WARNING on linus/master ipvs/master v5.6-rc3 next-20200224] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/anton-ivanov-cambridgegreys-com/virtio-Work-around-frames-incorrectly-marked-as-gso/20200224-190342 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: nds32-defconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=nds32 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): In file included from net/packet/af_packet.c:82: include/linux/virtio_net.h: In function 'virtio_net_hdr_from_skb': >> include/linux/virtio_net.h:103:2: warning: ISO C90 forbids mixed >> declarations and code [-Wdeclaration-after-statement] 103 | struct skb_shared_info *sinfo = skb_shinfo(skb); | ^~ vim +103 include/linux/virtio_net.h fd2a0437dc33b6 Mike Rapoport2016-06-08 94 fd2a0437dc33b6 Mike Rapoport2016-06-08 95 static inline int virtio_net_hdr_from_skb(const struct sk_buff *skb, fd2a0437dc33b6 Mike Rapoport2016-06-08 96 struct virtio_net_hdr *hdr, 6391a4481ba079 Jason Wang 2017-01-20 97 bool little_endian, fd3a8862584490 Willem de Bruijn 2018-06-06 98 bool has_data_valid, fd3a8862584490 Willem de Bruijn 2018-06-06 99 int vlan_hlen) fd2a0437dc33b6 Mike Rapoport2016-06-08 100 { 9403cd7cbb08aa Jarno Rajahalme 2016-11-18 101 memset(hdr, 0, sizeof(*hdr)); /* no info leak */ fd2a0437dc33b6 Mike Rapoport2016-06-08 102 fd2a0437dc33b6 Mike Rapoport2016-06-08 @103 struct skb_shared_info *sinfo = skb_shinfo(skb); 3d2c1fd2739938 Anton Ivanov 2020-02-24 104 if (skb_is_gso(skb) && sinfo->gso_type) { fd2a0437dc33b6 Mike Rapoport2016-06-08 105 fd2a0437dc33b6 Mike Rapoport2016-06-08 106 /* This is a hint as to how much should be linear. */ fd2a0437dc33b6 Mike Rapoport2016-06-08 107 hdr->hdr_len = __cpu_to_virtio16(little_endian, fd2a0437dc33b6 Mike Rapoport2016-06-08 108 skb_headlen(skb)); fd2a0437dc33b6 Mike Rapoport2016-06-08 109 hdr->gso_size = __cpu_to_virtio16(little_endian, fd2a0437dc33b6 Mike Rapoport2016-06-08 110 sinfo->gso_size); fd2a0437dc33b6 Mike Rapoport2016-06-08 111 if (sinfo->gso_type & SKB_GSO_TCPV4) fd2a0437dc33b6 Mike Rapoport2016-06-08 112 hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV4; fd2a0437dc33b6 Mike Rapoport2016-06-08 113 else if (sinfo->gso_type & SKB_GSO_TCPV6) fd2a0437dc33b6 Mike Rapoport2016-06-08 114 hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6; fd2a0437dc33b6 Mike Rapoport2016-06-08 115 else fd2a0437dc33b6 Mike Rapoport2016-06-08 116 return -EINVAL; fd2a0437dc33b6 Mike Rapoport2016-06-08 117 if (sinfo->gso_type & SKB_GSO_TCP_ECN) fd2a0437dc33b6 Mike Rapoport2016-06-08 118 hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; fd2a0437dc33b6 Mike Rapoport2016-06-08 119 } else fd2a0437dc33b6 Mike Rapoport2016-06-08 120 hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; fd2a0437dc33b6 Mike Rapoport2016-06-08 121 fd2a0437dc33b6 Mike Rapoport2016-06-08 122 if (skb->ip_summed == CHECKSUM_PARTIAL) { fd2a0437dc33b6 Mike Rapoport2016-06-08 123 hdr->flags = VIRTIO_NET_HDR_F_NEEDS_CSUM; fd2a0437dc33b6 Mike Rapoport2016-06-08 124 hdr->csum_start = __cpu_to_virtio16(little_endian, fd3a8862584490 Willem de Bruijn 2018-06-06 125 skb_checksum_start_offset(skb) + vlan_hlen); fd2a0437dc33b6 Mike Rapoport2016-06-08 126 hdr->csum_offset = __cpu_to_virtio16(little_endian, fd2a0437dc33b6 Mike Rapoport2016-06-08 127 skb->csum_offset); 6391a4481ba079 Jason Wang 2017-01-20 128
Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()
Hi Thomas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.6-rc1 next-20200210] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Provide-a-simple-encoder/20200210-153139 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9 reproduce: make htmldocs If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'getprocattr' not described in 'security_list_options' include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'setprocattr' not described in 'security_list_options' include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'locked_down' not described in 'security_list_options' include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_open' not described in 'security_list_options' include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_alloc' not described in 'security_list_options' include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_free' not described in 'security_list_options' include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_read' not described in 'security_list_options' include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_write' not described in 'security_list_options' drivers/usb/typec/bus.c:1: warning: 'typec_altmode_register_driver' not found drivers/usb/typec/bus.c:1: warning: 'typec_altmode_unregister_driver' not found drivers/usb/typec/class.c:1: warning: 'typec_altmode_unregister_notifier' not found drivers/usb/typec/class.c:1: warning: 'typec_altmode_register_notifier' not found include/linux/regulator/machine.h:196: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints' include/linux/regulator/driver.h:223: warning: Function parameter or member 'resume' not described in 'regulator_ops' include/linux/skbuff.h:890: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'list' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'ip_defrag_offset' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'skb_mstamp_ns' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member '__cloned_offset' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'head_frag' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member '__pkt_type_offset' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'encapsulation' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'encap_hdr_csum' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'csum_valid' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member '__pkt_vlan_present_offset' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'vlan_present' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'csum_complete_sw' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'csum_level' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'inner_protocol_type' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'remcsum_offload' not described in 'sk_buff' include/linux/skbuff.h:890: warning: Function parameter or member 'sender_cpu' not described in 'sk_buff' include/linux/skbuff.h:890: war
Re: [PATCH 5/6] drm/qxl: Use simple encoder
Hi Thomas, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.6-rc1 next-20200210] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Provide-a-simple-encoder/20200210-153139 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9 config: x86_64-randconfig-f002-20200210 (attached as .config) compiler: gcc-7 (Debian 7.5.0-3) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/gpu/drm/qxl/qxl_display.c: In function 'qdev_output_init': >> drivers/gpu/drm/qxl/qxl_display.c:1103:31: error: incompatible type for >> argument 2 of 'drm_simple_encoder_init' drm_simple_encoder_init(dev, qxl_output->enc, DRM_MODE_ENCODER_VIRTUAL, ^~ In file included from include/drm/drm_modeset_helper_vtables.h:33:0, from include/drm/drm_atomic_helper.h:32, from drivers/gpu/drm/qxl/qxl_display.c:30: include/drm/drm_encoder.h:194:5: note: expected 'struct drm_encoder *' but argument is of type 'struct drm_encoder' int drm_simple_encoder_init(struct drm_device *dev, ^~~ vim +/drm_simple_encoder_init +1103 drivers/gpu/drm/qxl/qxl_display.c 1084 1085 static int qdev_output_init(struct drm_device *dev, int num_output) 1086 { 1087 struct qxl_device *qdev = dev->dev_private; 1088 struct qxl_output *qxl_output; 1089 struct drm_connector *connector; 1090 struct drm_encoder *encoder; 1091 1092 qxl_output = kzalloc(sizeof(struct qxl_output), GFP_KERNEL); 1093 if (!qxl_output) 1094 return -ENOMEM; 1095 1096 qxl_output->index = num_output; 1097 1098 connector = &qxl_output->base; 1099 encoder = &qxl_output->enc; 1100 drm_connector_init(dev, &qxl_output->base, 1101 &qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL); 1102 > 1103 drm_simple_encoder_init(dev, qxl_output->enc, > DRM_MODE_ENCODER_VIRTUAL, 1104 NULL); 1105 1106 /* we get HPD via client monitors config */ 1107 connector->polled = DRM_CONNECTOR_POLL_HPD; 1108 encoder->possible_crtcs = 1 << num_output; 1109 drm_connector_attach_encoder(&qxl_output->base, 1110&qxl_output->enc); drm_connector_helper_add(connector, &qxl_connector_helper_funcs); 1112 1113 drm_object_attach_property(&connector->base, 1114 qdev->hotplug_mode_update_property, 0); 1115 drm_object_attach_property(&connector->base, 1116 dev->mode_config.suggested_x_property, 0); 1117 drm_object_attach_property(&connector->base, 1118 dev->mode_config.suggested_y_property, 0); 1119 return 0; 1120 } 1121 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 5/5] vdpasim: vDPA device simulator
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linux/master linus/master v5.5-rc6 next-20200117] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200117-170243 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): drivers/virtio/vdpa/vdpa_sim.c: In function 'vdpasim_queue_ready': >> drivers/virtio/vdpa/vdpa_sim.c:101:19: warning: cast to pointer from integer >> of different size [-Wint-to-pointer-cast] false, (struct vring_desc *)vq->desc_addr, ^ drivers/virtio/vdpa/vdpa_sim.c:102:5: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] (struct vring_avail *)vq->driver_addr, ^ drivers/virtio/vdpa/vdpa_sim.c:103:5: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] (struct vring_used *)vq->device_addr); ^ -- >> ERROR: "vhost_iotlb_free" [drivers/virtio//vdpa/vdpa_sim.ko] undefined! >> ERROR: "vhost_iotlb_alloc" [drivers/virtio//vdpa/vdpa_sim.ko] undefined! >> ERROR: "vhost_iotlb_itree_next" [drivers/virtio//vdpa/vdpa_sim.ko] undefined! >> ERROR: "vhost_iotlb_itree_first" [drivers/virtio//vdpa/vdpa_sim.ko] >> undefined! >> ERROR: "vhost_iotlb_reset" [drivers/virtio//vdpa/vdpa_sim.ko] undefined! >> ERROR: "vhost_iotlb_add_range" [drivers/virtio//vdpa/vdpa_sim.ko] undefined! >> ERROR: "vhost_iotlb_del_range" [drivers/virtio//vdpa/vdpa_sim.ko] undefined! --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 1/5] vhost: factor out IOTLB
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linux/master linus/master v5.5-rc6 next-20200117] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200117-170243 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: i386-randconfig-d002-20200117 (attached as .config) compiler: gcc-7 (Debian 7.5.0-3) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): ld: drivers/vhost/vhost.o: in function `iotlb_alloc': >> drivers/vhost/vhost.c:582: undefined reference to `vhost_iotlb_alloc' >> ld: drivers/vhost/vhost.c:582: undefined reference to `vhost_iotlb_alloc' ld: drivers/vhost/vhost.o: in function `vhost_init_device_iotlb': >> drivers/vhost/vhost.c:1667: undefined reference to `vhost_iotlb_free' ld: drivers/vhost/vhost.o: in function `iotlb_access_ok': >> drivers/vhost/vhost.c:1271: undefined reference to `vhost_iotlb_itree_first' ld: drivers/vhost/vhost.o: in function `translate_desc': drivers/vhost/vhost.c:1981: undefined reference to `vhost_iotlb_itree_first' ld: drivers/vhost/vhost.o: in function `vhost_dev_cleanup': drivers/vhost/vhost.c:658: undefined reference to `vhost_iotlb_free' >> ld: drivers/vhost/vhost.c:660: undefined reference to `vhost_iotlb_free' ld: drivers/vhost/vhost.o: in function `vhost_process_iotlb_msg': >> drivers/vhost/vhost.c:1070: undefined reference to `vhost_iotlb_del_range' >> ld: drivers/vhost/vhost.c:1056: undefined reference to >> `vhost_iotlb_add_range' ld: drivers/vhost/vhost.o: in function `iotlb_alloc': >> drivers/vhost/vhost.c:582: undefined reference to `vhost_iotlb_alloc' ld: drivers/vhost/vhost.o: in function `vhost_set_memory': >> drivers/vhost/vhost.c:1380: undefined reference to `vhost_iotlb_add_range' ld: drivers/vhost/vhost.c:1407: undefined reference to `vhost_iotlb_free' ld: drivers/vhost/vhost.c:1403: undefined reference to `vhost_iotlb_free' vim +582 drivers/vhost/vhost.c 579 580 static struct vhost_iotlb *iotlb_alloc(void) 581 { > 582 return vhost_iotlb_alloc(max_iotlb_entries, 583 VHOST_IOTLB_FLAG_RETIRE); 584 } 585 586 struct vhost_iotlb *vhost_dev_reset_owner_prepare(void) 587 { 588 return iotlb_alloc(); 589 } 590 EXPORT_SYMBOL_GPL(vhost_dev_reset_owner_prepare); 591 592 /* Caller should have device mutex */ 593 void vhost_dev_reset_owner(struct vhost_dev *dev, struct vhost_iotlb *umem) 594 { 595 int i; 596 597 vhost_dev_cleanup(dev); 598 599 dev->umem = umem; 600 /* We don't need VQ locks below since vhost_dev_cleanup makes sure 601 * VQs aren't running. 602 */ 603 for (i = 0; i < dev->nvqs; ++i) 604 dev->vqs[i]->umem = umem; 605 } 606 EXPORT_SYMBOL_GPL(vhost_dev_reset_owner); 607 608 void vhost_dev_stop(struct vhost_dev *dev) 609 { 610 int i; 611 612 for (i = 0; i < dev->nvqs; ++i) { 613 if (dev->vqs[i]->kick && dev->vqs[i]->handle_kick) { 614 vhost_poll_stop(&dev->vqs[i]->poll); 615 vhost_poll_flush(&dev->vqs[i]->poll); 616 } 617 } 618 } 619 EXPORT_SYMBOL_GPL(vhost_dev_stop); 620 621 static void vhost_clear_msg(struct vhost_dev *dev) 622 { 623 struct vhost_msg_node *node, *n; 624 625 spin_lock(&dev->iotlb_lock); 626 627 list_for_each_entry_safe(node, n, &dev->read_list, node) { 628 list_del(&node->node); 629 kfree(node); 630 } 631 632 list_for_each_entry_safe(node, n, &dev->pending_list, node) { 633 list_del(&node->node); 634 kfree(node); 635 } 636 637 spin_unlock(&dev->iotlb_lock); 638 } 639 640 void vhost_dev_cleanup(struct vhost_dev *dev) 641 { 642 int i; 643 644 for (i = 0; i < dev->nvqs; ++i) { 645 if (dev->vqs[i]->error_ct
Re: [PATCH 1/5] vhost: factor out IOTLB
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linux/master linus/master v5.5-rc6 next-20200117] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200117-170243 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: i386-randconfig-g003-20200117 (attached as .config) compiler: gcc-7 (Debian 7.5.0-3) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): ld: drivers/vhost/vhost.o: in function `vhost_dev_reset_owner_prepare': >> (.text+0x18b): undefined reference to `vhost_iotlb_alloc' ld: drivers/vhost/vhost.o: in function `vhost_init_device_iotlb': (.text+0x204): undefined reference to `vhost_iotlb_alloc' >> ld: (.text+0x26c): undefined reference to `vhost_iotlb_free' ld: drivers/vhost/vhost.o: in function `iotlb_access_ok': >> vhost.c:(.text+0x60e): undefined reference to `vhost_iotlb_itree_first' ld: drivers/vhost/vhost.o: in function `translate_desc': vhost.c:(.text+0x85f): undefined reference to `vhost_iotlb_itree_first' ld: drivers/vhost/vhost.o: in function `vhost_dev_cleanup': >> (.text+0xd4a): undefined reference to `vhost_iotlb_free' ld: (.text+0xd59): undefined reference to `vhost_iotlb_free' ld: drivers/vhost/vhost.o: in function `vhost_chr_write_iter': >> (.text+0x1c3b): undefined reference to `vhost_iotlb_del_range' >> ld: (.text+0x1d78): undefined reference to `vhost_iotlb_add_range' ld: drivers/vhost/vhost.o: in function `vhost_dev_ioctl': (.text+0x3d6d): undefined reference to `vhost_iotlb_alloc' ld: (.text+0x3dd5): undefined reference to `vhost_iotlb_add_range' ld: (.text+0x3de4): undefined reference to `vhost_iotlb_free' ld: (.text+0x3e7e): undefined reference to `vhost_iotlb_free' --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 2/5] vringh: IOTLB support
Hi Jason, I love your patch! Perhaps something to improve: [auto build test WARNING on vhost/linux-next] [also build test WARNING on linux/master linus/master v5.5-rc6 next-20200117] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200117-170243 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: sh-randconfig-a001-20200117 (attached as .config) compiler: sh4-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=sh If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): drivers/vhost/vringh.c: In function 'copy_from_iotlb': >> drivers/vhost/vringh.c:1110:29: warning: cast from pointer to integer of >> different size [-Wpointer-to-int-cast] ret = iotlb_translate(vrh, (u64)src, len, iov, 16, VHOST_MAP_RO); ^ drivers/vhost/vringh.c: In function 'copy_to_iotlb': drivers/vhost/vringh.c:1128:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ret = iotlb_translate(vrh, (u64)dst, len, iov, 16, VHOST_MAP_WO); ^ drivers/vhost/vringh.c: In function 'getu16_iotlb': drivers/vhost/vringh.c:1145:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ret = iotlb_translate(vrh, (u64)p, sizeof(*p), ^ drivers/vhost/vringh.c: In function 'putu16_iotlb': drivers/vhost/vringh.c:1166:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ret = iotlb_translate(vrh, (u64)p, sizeof(*p), ^ vim +1110 drivers/vhost/vringh.c 1102 1103 static inline int copy_from_iotlb(const struct vringh *vrh, void *dst, 1104void *src, size_t len) 1105 { 1106 struct iov_iter iter; 1107 struct bio_vec iov[16]; 1108 int ret; 1109 > 1110 ret = iotlb_translate(vrh, (u64)src, len, iov, 16, > VHOST_MAP_RO); if (ret < 0) 1112 return ret; 1113 1114 iov_iter_bvec(&iter, READ, iov, ret, len); 1115 1116 ret = copy_from_iter(dst, len, &iter); 1117 1118 return ret; 1119 } 1120 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 2/5] vringh: IOTLB support
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on linux/master linus/master v5.5-rc6 next-20200117] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-support/20200117-170243 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: nios2-randconfig-a001-20200117 (attached as .config) compiler: nios2-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=nios2 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/vhost/vringh.o: In function `iotlb_translate': >> drivers/vhost/vringh.c:1079: undefined reference to `vhost_iotlb_itree_first' drivers/vhost/vringh.c:1079:(.text+0x45c): relocation truncated to fit: R_NIOS2_CALL26 against `vhost_iotlb_itree_first' vim +1079 drivers/vhost/vringh.c 1061 1062 static int iotlb_translate(const struct vringh *vrh, 1063 u64 addr, u64 len, struct bio_vec iov[], 1064 int iov_size, u32 perm) 1065 { 1066 struct vhost_iotlb_map *map; 1067 struct vhost_iotlb *iotlb = vrh->iotlb; 1068 int ret = 0; 1069 u64 s = 0; 1070 1071 while (len > s) { 1072 u64 size, pa, pfn; 1073 1074 if (unlikely(ret >= iov_size)) { 1075 ret = -ENOBUFS; 1076 break; 1077 } 1078 > 1079 map = vhost_iotlb_itree_first(iotlb, addr, 1080addr + len - 1); 1081 if (!map || map->start > addr) { 1082 ret = -EINVAL; 1083 break; 1084 } else if (!(map->perm & perm)) { 1085 ret = -EPERM; 1086 break; 1087 } 1088 1089 size = map->size - addr + map->start; 1090 pa = map->addr + addr - map->start; 1091 pfn = pa >> PAGE_SHIFT; 1092 iov[ret].bv_page = pfn_to_page(pfn); 1093 iov[ret].bv_len = min(len - s, size); 1094 iov[ret].bv_offset = pa & (PAGE_SIZE - 1); 1095 s += size; 1096 addr += size; 1097 ++ret; 1098 } 1099 1100 return ret; 1101 } 1102 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v2 5/6] KVM: arm64: Add interface to support VCPU preempted check
Hi Zengruan, Thank you for the patch! Yet something to improve: [auto build test ERROR on kvmarm/next] [also build test ERROR on kvm/linux-next linus/master v5.5-rc3 next-20191220] [cannot apply to arm64/for-next/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Zengruan-Ye/KVM-arm64-VCPU-preempted-check-support/20191227-000637 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next config: arm64-alldefconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from include/linux/spinlock.h:89:0, from include/linux/radix-tree.h:16, from include/linux/idr.h:15, from include/linux/kernfs.h:13, from include/linux/sysfs.h:16, from include/linux/kobject.h:20, from include/linux/of.h:17, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from include/acpi/apei.h:9, from include/acpi/ghes.h:5, from include/linux/arm_sdei.h:8, from arch/arm64/kernel/asm-offsets.c:10: arch/arm64/include/asm/spinlock.h: In function 'vcpu_is_preempted': >> arch/arm64/include/asm/spinlock.h:18:9: error: implicit declaration of >> function 'pv_vcpu_is_preempted'; did you mean 'vcpu_is_preempted'? >> [-Werror=implicit-function-declaration] return pv_vcpu_is_preempted(cpu); ^~~~ vcpu_is_preempted cc1: some warnings being treated as errors make[2]: *** [arch/arm64/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [sub-make] Error 2 27 real 5 user 7 sys 48.63% cpu make prepare vim +18 arch/arm64/include/asm/spinlock.h 14 15 #define vcpu_is_preempted vcpu_is_preempted 16 static inline bool vcpu_is_preempted(long cpu) 17 { > 18 return pv_vcpu_is_preempted(cpu); 19 } 20 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 6/8] iommu: allow the dma-iommu api to use bounce buffers
Hi Tom, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rockchip/for-next] [cannot apply to iommu/next tegra/for-next vfio/next linus/master v5.5-rc3 next-20191219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Tom-Murphy/Convert-the-intel-iommu-driver-to-the-dma-iommu-api/20191224-171249 base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next config: x86_64-defconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-3) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): drivers//iommu/dma-iommu.c: In function '__iommu_dma_map': >> drivers//iommu/dma-iommu.c:568:3: warning: ISO C90 forbids mixed >> declarations and code [-Wdeclaration-after-statement] void *padding_start = phys_to_virt(phys); ^~~~ vim +568 drivers//iommu/dma-iommu.c 537 538 static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys, 539 size_t org_size, dma_addr_t dma_mask, bool coherent, 540 enum dma_data_direction dir, unsigned long attrs) 541 { 542 int prot = dma_info_to_prot(dir, coherent, attrs); 543 struct iommu_domain *domain = iommu_get_dma_domain(dev); 544 struct iommu_dma_cookie *cookie = domain->iova_cookie; 545 struct iova_domain *iovad = &cookie->iovad; 546 size_t iova_off = iova_offset(iovad, phys); 547 size_t aligned_size = iova_align(iovad, org_size + iova_off); 548 dma_addr_t iova; 549 550 if (unlikely(iommu_dma_deferred_attach(dev, domain))) 551 return DMA_MAPPING_ERROR; 552 553 #ifdef CONFIG_SWIOTLB 554 /* 555 * If both the physical buffer start address and size are 556 * page aligned, we don't need to use a bounce page. 557 */ 558 if (iommu_needs_bounce_buffer(dev) 559 && !iova_offset(iovad, phys | org_size)) { 560 phys = swiotlb_tbl_map_single(dev, 561 __phys_to_dma(dev, io_tlb_start), 562 phys, org_size, aligned_size, dir, attrs); 563 564 if (phys == DMA_MAPPING_ERROR) 565 return DMA_MAPPING_ERROR; 566 567 /* Cleanup the padding area. */ > 568 void *padding_start = phys_to_virt(phys); 569 size_t padding_size = aligned_size; 570 571 if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) && 572 (dir == DMA_TO_DEVICE || 573 dir == DMA_BIDIRECTIONAL)) { 574 padding_start += org_size; 575 padding_size -= org_size; 576 } 577 578 memset(padding_start, 0, padding_size); 579 } 580 #endif 581 582 iova = iommu_dma_alloc_iova(domain, aligned_size, dma_mask, dev); 583 if (!iova) 584 return DMA_MAPPING_ERROR; 585 586 if (iommu_map_atomic(domain, iova, phys - iova_off, aligned_size, 587 prot)) { 588 589 if (unlikely(is_swiotlb_buffer(phys))) 590 swiotlb_tbl_unmap_single(dev, phys, aligned_size, 591 aligned_size, dir, attrs); 592 iommu_dma_free_iova(cookie, iova, aligned_size, NULL); 593 return DMA_MAPPING_ERROR; 594 } 595 return iova + iova_off; 596 } 597 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:linux-next 12/12] drivers/vhost/vhost.c:1968:25: sparse: sparse: incompatible types in comparison expression (different type sizes):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: b072ae74df177c3ad7704c5fbe66e3f10aad9d4e commit: b072ae74df177c3ad7704c5fbe66e3f10aad9d4e [12/12] vhost: use vhost_desc instead of vhost_log reproduce: # apt-get install sparse # sparse version: v0.6.1-101-g82dee2e-dirty git checkout b072ae74df177c3ad7704c5fbe66e3f10aad9d4e make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) drivers/vhost/vhost.c:763:17: sparse: sparse: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:763:17: sparse:expected void [noderef] * drivers/vhost/vhost.c:763:17: sparse:got void * drivers/vhost/vhost.c:763:17: sparse: sparse: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:763:17: sparse:expected void [noderef] * drivers/vhost/vhost.c:763:17: sparse:got void * drivers/vhost/vhost.c:763:17: sparse: sparse: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:763:17: sparse:expected void [noderef] * drivers/vhost/vhost.c:763:17: sparse:got void * >> drivers/vhost/vhost.c:1968:25: sparse: sparse: incompatible types in >> comparison expression (different type sizes): >> drivers/vhost/vhost.c:1968:25: sparse:unsigned int * >> drivers/vhost/vhost.c:1968:25: sparse:unsigned long long * drivers/vhost/vhost.c:947:16: sparse: sparse: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:947:16: sparse:expected void *addr drivers/vhost/vhost.c:947:16: sparse:got restricted __virtio16 [noderef] * drivers/vhost/vhost.c:763:17: sparse: sparse: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:763:17: sparse:expected void [noderef] * drivers/vhost/vhost.c:763:17: sparse:got void * drivers/vhost/vhost.c:910:42: sparse: sparse: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:910:42: sparse:expected void [noderef] *addr drivers/vhost/vhost.c:910:42: sparse:got void *addr drivers/vhost/vhost.c:932:16: sparse: sparse: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:932:16: sparse:expected void *addr drivers/vhost/vhost.c:932:16: sparse:got restricted __virtio16 [noderef] [usertype] * drivers/vhost/vhost.c:763:17: sparse: sparse: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:763:17: sparse:expected void [noderef] * drivers/vhost/vhost.c:763:17: sparse:got void * drivers/vhost/vhost.c:910:42: sparse: sparse: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:910:42: sparse:expected void [noderef] *addr drivers/vhost/vhost.c:910:42: sparse:got void *addr drivers/vhost/vhost.c:1024:16: sparse: sparse: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:1024:16: sparse:expected void *addr drivers/vhost/vhost.c:1024:16: sparse:got restricted __virtio16 [noderef] * drivers/vhost/vhost.c:763:17: sparse: sparse: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:763:17: sparse:expected void [noderef] * drivers/vhost/vhost.c:763:17: sparse:got void * drivers/vhost/vhost.c:910:42: sparse: sparse: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:910:42: sparse:expected void [noderef] *addr drivers/vhost/vhost.c:910:42: sparse:got void *addr drivers/vhost/vhost.c:999:16: sparse: sparse: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:999:16: sparse:expected void *addr drivers/vhost/vhost.c:999:16: sparse:got restricted __virtio16 [noderef] * drivers/vhost/vhost.c:763:17: sparse: sparse: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:763:17: sparse:expected void [noderef] * drivers/vhost/vhost.c:763:17: sparse:got void * drivers/vhost/vhost.c:910:42: sparse: sparse: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:910:42: sparse:expected void [noderef] *addr drivers/vhost/vhost.c:910:42: sparse:got void *addr drivers/vhost/vhost.c:1005:16: sparse: sparse: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:1005:16: sparse:expected void *addr drivers/vhost/vhost.c:1005:16: sparse:got restricted __virtio16 [noderef] * drivers/vhost/vhost.c:763:17: sparse: sparse: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:763:17: sparse:expected void [
[vhost:linux-next 12/12] drivers/vhost/vhost.c:1968:11: note: in expansion of macro 'min'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: b072ae74df177c3ad7704c5fbe66e3f10aad9d4e commit: b072ae74df177c3ad7704c5fbe66e3f10aad9d4e [12/12] vhost: use vhost_desc instead of vhost_log config: s390-debug_defconfig (attached as .config) compiler: s390-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout b072ae74df177c3ad7704c5fbe66e3f10aad9d4e # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): In file included from include/linux/list.h:9:0, from include/linux/wait.h:7, from include/linux/eventfd.h:13, from drivers/vhost/vhost.c:13: drivers/vhost/vhost.c: In function 'vhost_log_write': include/linux/kernel.h:844:29: warning: comparison of distinct pointer types lacks a cast (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ^ include/linux/kernel.h:858:4: note: in expansion of macro '__typecheck' (__typecheck(x, y) && __no_side_effects(x, y)) ^~~ include/linux/kernel.h:868:24: note: in expansion of macro '__safe_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~ include/linux/kernel.h:877:19: note: in expansion of macro '__careful_cmp' #define min(x, y) __careful_cmp(x, y, <) ^ >> drivers/vhost/vhost.c:1968:11: note: in expansion of macro 'min' u64 l = min(log[i].len, len); ^~~ vim +/min +1968 drivers/vhost/vhost.c cc5e710759470b Jason Wang 2019-01-16 1948 b072ae74df177c Michael S. Tsirkin 2019-12-11 1949 int vhost_log_write(struct vhost_virtqueue *vq, struct vhost_desc *log, cc5e710759470b Jason Wang 2019-01-16 1950 unsigned int log_num, u64 len, struct iovec *iov, int count) 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1951 { 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1952 int i, r; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1953 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1954 /* Make sure data written is seen before log. */ 5659338c88963e Michael S. Tsirkin 2010-02-01 1955 smp_wmb(); cc5e710759470b Jason Wang 2019-01-16 1956 cc5e710759470b Jason Wang 2019-01-16 1957 if (vq->iotlb) { cc5e710759470b Jason Wang 2019-01-16 1958 for (i = 0; i < count; i++) { cc5e710759470b Jason Wang 2019-01-16 1959 r = log_write_hva(vq, (uintptr_t)iov[i].iov_base, cc5e710759470b Jason Wang 2019-01-16 1960 iov[i].iov_len); cc5e710759470b Jason Wang 2019-01-16 1961 if (r < 0) cc5e710759470b Jason Wang 2019-01-16 1962 return r; cc5e710759470b Jason Wang 2019-01-16 1963 } cc5e710759470b Jason Wang 2019-01-16 1964 return 0; cc5e710759470b Jason Wang 2019-01-16 1965 } cc5e710759470b Jason Wang 2019-01-16 1966 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1967 for (i = 0; i < log_num; ++i) { 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 @1968 u64 l = min(log[i].len, len); 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1969 r = log_write(vq->log_base, log[i].addr, l); 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1970 if (r < 0) 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1971 return r; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1972 len -= l; 5786aee8bf6d74 Michael S. Tsirkin 2010-09-22 1973 if (!len) { 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1974 if (vq->log_ctx) 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1975 eventfd_signal(vq->log_ctx, 1); 5786aee8bf6d74 Michael S. Tsirkin 2010-09-22 1976 return 0; 5786aee8bf6d74 Michael S. Tsirkin 2010-09-22 1977 } 5786aee8bf6d74 Michael S. Tsirkin 2010-09-22 1978 } 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1979 /* Length written exceeds what we have stored. This is a bug. */ 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1980 BUG(); 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1981 return 0; 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1982 } 6ac1afbf6132df Asias He 2013-05-06 1983 EXPORT_SYMBOL_GPL(vhost_log_write); 3a4d5c94e95935 Michael S. Tsirkin 2010-01-14 1984 :: The code at line 1968 was first introduced by commit :: 3a4d5c
[vhost:linux-next 3/11] drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2622:20: error: initialization from incompatible pointer type
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: b5fe11663b48ca267829b34a65b4133e4e34c993 commit: a256bb8c551310746843ed85de0416ae0571601e [3/11] netdev: pass the stuck queue to the timeout handler config: arm64-allyesconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout a256bb8c551310746843ed85de0416ae0571601e # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2622:20: error: >> initialization from incompatible pointer type >> [-Werror=incompatible-pointer-types] .ndo_tx_timeout = dpaa_tx_timeout, ^~~ drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2622:20: note: (near initialization for 'dpaa_ops.ndo_tx_timeout') cc1: some warnings being treated as errors vim +2622 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c 4664856e9ca2e5 Yangbo Lu2018-06-25 2617 9ad1a37493338c Madalin Bucur2016-11-15 2618 static const struct net_device_ops dpaa_ops = { 9ad1a37493338c Madalin Bucur2016-11-15 2619.ndo_open = dpaa_open, 9ad1a37493338c Madalin Bucur2016-11-15 2620.ndo_start_xmit = dpaa_start_xmit, 9ad1a37493338c Madalin Bucur2016-11-15 2621.ndo_stop = dpaa_eth_stop, 9ad1a37493338c Madalin Bucur2016-11-15 @2622.ndo_tx_timeout = dpaa_tx_timeout, 9ad1a37493338c Madalin Bucur2016-11-15 2623.ndo_get_stats64 = dpaa_get_stats64, 6e8b0ff1ba4cc1 Joakim Tjernlund 2018-12-14 2624.ndo_change_carrier = fixed_phy_change_carrier, 9ad1a37493338c Madalin Bucur2016-11-15 2625.ndo_set_mac_address = dpaa_set_mac_address, 9ad1a37493338c Madalin Bucur2016-11-15 2626.ndo_validate_addr = eth_validate_addr, 9ad1a37493338c Madalin Bucur2016-11-15 2627.ndo_set_rx_mode = dpaa_set_rx_mode, 1763413ac2c15f Michael Walle2017-02-20 2628.ndo_do_ioctl = dpaa_ioctl, 2ea08f8261b146 Camelia Groza2016-07-25 2629.ndo_setup_tc = dpaa_setup_tc, 9ad1a37493338c Madalin Bucur2016-11-15 2630 }; 9ad1a37493338c Madalin Bucur2016-11-15 2631 :: The code at line 2622 was first introduced by commit :: 9ad1a37493338cacf04e2c93acf44d151a7adda8 dpaa_eth: add support for DPAA Ethernet :: TO: Madalin Bucur :: CC: David S. Miller --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:linux-next 4/11] drivers/net/ethernet/mellanox/mlx4/en_netdev.c:1376:12: error: 'tx_ring' undeclared; did you mean 'en_print'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: b5fe11663b48ca267829b34a65b4133e4e34c993 commit: 1f4098ea671b092af3806789d89e278e1f08e222 [4/11] mlx4: use new txqueue timeout argument config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 1f4098ea671b092af3806789d89e278e1f08e222 # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=sparc64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from drivers/net/ethernet/mellanox/mlx4/en_netdev.c:50:0: drivers/net/ethernet/mellanox/mlx4/en_netdev.c: In function 'mlx4_en_tx_timeout': >> drivers/net/ethernet/mellanox/mlx4/en_netdev.c:1376:12: error: 'tx_ring' >> undeclared (first use in this function); did you mean 'en_print'? txqueue, tx_ring->qpn, tx_ring->sp_cqn, ^ drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:830:41: note: in definition of macro 'en_warn' en_print(KERN_WARNING, priv, format, ##__VA_ARGS__) ^~~ drivers/net/ethernet/mellanox/mlx4/en_netdev.c:1376:12: note: each undeclared identifier is reported only once for each function it appears in txqueue, tx_ring->qpn, tx_ring->sp_cqn, ^ drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:830:41: note: in definition of macro 'en_warn' en_print(KERN_WARNING, priv, format, ##__VA_ARGS__) ^~~ drivers/net/ethernet/mellanox/mlx4/en_netdev.c:1370:6: warning: unused variable 'i' [-Wunused-variable] int i; ^ vim +1376 drivers/net/ethernet/mellanox/mlx4/en_netdev.c 1365 1366 static void mlx4_en_tx_timeout(struct net_device *dev, unsigned int txqueue) 1367 { 1368 struct mlx4_en_priv *priv = netdev_priv(dev); 1369 struct mlx4_en_dev *mdev = priv->mdev; 1370 int i; 1371 1372 if (netif_msg_timer(priv)) 1373 en_warn(priv, "Tx timeout called on port:%d\n", priv->port); 1374 1375 en_warn(priv, "TX timeout on queue: %d, QP: 0x%x, CQ: 0x%x, Cons: 0x%x, Prod: 0x%x\n", > 1376 txqueue, tx_ring->qpn, tx_ring->sp_cqn, 1377 tx_ring->cons, tx_ring->prod); 1378 1379 priv->port_stats.tx_timeout++; 1380 en_dbg(DRV, priv, "Scheduling watchdog\n"); 1381 queue_work(mdev->workqueue, &priv->watchdog_task); 1382 } 1383 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH v2 3/3] vhost, kcov: collect coverage from vhost_worker
Hi Andrey, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.4-rc4 next-20191025] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/kcov-collect-coverage-from-usb-and-vhost/20191025-145734 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 39a38bcba4ab6e5285b07675b0e42c96eec35e67 config: s390-allmodconfig (attached as .config) compiler: s390-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> ERROR: "kcov_common_handle" [drivers/vhost/vhost.ko] undefined! ERROR: "kcov_remote_stop" [drivers/vhost/vhost.ko] undefined! ERROR: "kcov_remote_start" [drivers/vhost/vhost.ko] undefined! ERROR: "kcov_remote_stop" [drivers/usb/core/usbcore.ko] undefined! ERROR: "kcov_remote_start" [drivers/usb/core/usbcore.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 2/3] usb, kcov: collect coverage from hub_event
Hi Andrey, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.4-rc4 next-20191023] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/kcov-collect-coverage-from-usb-and-vhost/20191023-185245 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3b7c59a1950c75f2c0152e5a9cd77675b09233d6 config: s390-allmodconfig (attached as .config) compiler: s390-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> ERROR: "kcov_remote_stop" [drivers/usb/core/usbcore.ko] undefined! >> ERROR: "kcov_remote_start" [drivers/usb/core/usbcore.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 1/3] kcov: remote coverage support
Hi Andrey, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.4-rc4 next-20191023] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Andrey-Konovalov/kcov-collect-coverage-from-usb-and-vhost/20191023-185245 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3b7c59a1950c75f2c0152e5a9cd77675b09233d6 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): kernel/kcov.o: In function `kcov_remote_stop': >> kcov.c:(.text+0x1094): undefined reference to `__aeabi_uldivmod' kcov.c:(.text+0x1144): undefined reference to `__aeabi_uldivmod' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks
Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc4 next-20191022] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-simple-kms-Standardize-arguments-for-callbacks/20191023-073731 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3b7c59a1950c75f2c0152e5a9cd77675b09233d6 reproduce: # apt-get install sparse # sparse version: v0.6.1-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/gpu/drm/xen/xen_drm_front_kms.c:289:23: sparse: sparse: incorrect >> type in initializer (incompatible argument 1 (different base types)) @@ >> expected int enum drm_mode_status ( *mode_valid )( ... ) @@got int enum >> drm_mode_status ( *mode_valid )( ... ) @@ >> drivers/gpu/drm/xen/xen_drm_front_kms.c:289:23: sparse:expected int enum >> drm_mode_status ( *mode_valid )( ... ) >> drivers/gpu/drm/xen/xen_drm_front_kms.c:289:23: sparse:got int enum >> drm_mode_status ( * )( ... ) vim +289 drivers/gpu/drm/xen/xen_drm_front_kms.c c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 287 c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 288 static const struct drm_simple_display_pipe_funcs display_funcs = { c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 @289 .mode_valid = display_mode_valid, c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 290 .enable = display_enable, c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 291 .disable = display_disable, dd388ee1ecbb8c Daniel Vetter 2018-04-09 292 .prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb, c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 293 .update = display_update, c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 294 }; c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 295 :: The code at line 289 was first introduced by commit :: c575b7eeb89f94356997abd62d6d5a0590e259b7 drm/xen-front: Add support for Xen PV display frontend :: TO: Oleksandr Andrushchenko :: CC: Oleksandr Andrushchenko --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.4-rc4 next-20191022] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-simple-kms-Standardize-arguments-for-callbacks/20191023-073731 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3b7c59a1950c75f2c0152e5a9cd77675b09233d6 config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu//drm/xen/xen_drm_front_kms.c:289:16: error: initialization from >> incompatible pointer type [-Werror=incompatible-pointer-types] .mode_valid = display_mode_valid, ^~ drivers/gpu//drm/xen/xen_drm_front_kms.c:289:16: note: (near initialization for 'display_funcs.mode_valid') cc1: some warnings being treated as errors vim +289 drivers/gpu//drm/xen/xen_drm_front_kms.c c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 287 c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 288 static const struct drm_simple_display_pipe_funcs display_funcs = { c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 @289 .mode_valid = display_mode_valid, c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 290 .enable = display_enable, c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 291 .disable = display_disable, dd388ee1ecbb8c Daniel Vetter 2018-04-09 292 .prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb, c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 293 .update = display_update, c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 294 }; c575b7eeb89f94 Oleksandr Andrushchenko 2018-04-03 295 :: The code at line 289 was first introduced by commit :: c575b7eeb89f94356997abd62d6d5a0590e259b7 drm/xen-front: Add support for Xen PV display frontend :: TO: Oleksandr Andrushchenko :: CC: Oleksandr Andrushchenko --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:vhost 6/6] drivers/vhost/vhost.c:2672:9: error: 'desc' undeclared; did you mean 'rdtsc'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 2b91e7f7cb5a6f12a2f43b200cb2d65a218237ed commit: 2b91e7f7cb5a6f12a2f43b200cb2d65a218237ed [6/6] vhost: batching fetches config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-13) 7.4.0 reproduce: git checkout 2b91e7f7cb5a6f12a2f43b200cb2d65a218237ed # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/vhost/vhost.c: In function 'vhost_get_vq_desc_batch': >> drivers/vhost/vhost.c:2672:9: error: 'desc' undeclared (first use in this >> function); did you mean 'rdtsc'? if (!(desc->flags & VRING_DESC_F_NEXT)) ^~~~ rdtsc drivers/vhost/vhost.c:2672:9: note: each undeclared identifier is reported only once for each function it appears in vim +2672 drivers/vhost/vhost.c 2569 2570 /* This looks in the virtqueue and for the first available buffer, and converts 2571 * it to an iovec for convenient access. Since descriptors consist of some 2572 * number of output then some number of input descriptors, it's actually two 2573 * iovecs, but we pack them into one and note how many of each there were. 2574 * 2575 * This function returns the descriptor number found, or vq->num (which is 2576 * never a valid descriptor number) if none was found. A negative code is 2577 * returned on error. */ 2578 int vhost_get_vq_desc_batch(struct vhost_virtqueue *vq, 2579struct iovec iov[], unsigned int iov_size, 2580unsigned int *out_num, unsigned int *in_num, 2581struct vhost_log *log, unsigned int *log_num) 2582 { 2583 int ret = fetch_descs(vq); 2584 struct vhost_desc *last; 2585 u16 id; 2586 int i; 2587 2588 if (ret) 2589 return ret; 2590 2591 /* Note: indirect descriptors are not batched */ 2592 /* TODO: batch up to a limit */ 2593 last = peek_split_desc(vq); 2594 id = last->id; 2595 2596 if (last->flags & VRING_DESC_F_INDIRECT) { 2597 int r; 2598 2599 pop_split_desc(vq); 2600 r = fetch_indirect_descs(vq, last, id); 2601 if (unlikely(r < 0)) { 2602 if (r != -EAGAIN) 2603 vq_err(vq, "Failure detected " 2604 "in indirect descriptor at idx %d\n", id); 2605 return ret; 2606 } 2607 } 2608 2609 /* Now convert to IOV */ 2610 /* When we start there are none of either input nor output. */ 2611 *out_num = *in_num = 0; 2612 if (unlikely(log)) 2613 *log_num = 0; 2614 2615 for (i = vq->first_desc; i < vq->ndescs; ++i) { 2616 unsigned iov_count = *in_num + *out_num; 2617 struct vhost_desc *desc = &vq->descs[i]; 2618 int access; 2619 2620 if (desc->flags & ~VHOST_DESC_FLAGS) { 2621 vq_err(vq, "Unexpected flags: 0x%x at descriptor id 0x%x\n", 2622 desc->flags, desc->id); 2623 ret = -EINVAL; 2624 goto err; 2625 } 2626 if (desc->flags & VRING_DESC_F_WRITE) 2627 access = VHOST_ACCESS_WO; 2628 else 2629 access = VHOST_ACCESS_RO; 2630 ret = translate_desc(vq, desc->addr, 2631 desc->len, iov + iov_count, 2632 iov_size - iov_count, access); 2633 if (unlikely(ret < 0)) { 2634 if (ret != -EAGAIN) 2635 vq_err(vq, "Translation failure %d descriptor idx %d\n", 2636 ret, i); 2637 goto err; 2638 } 2639 if (access == VHOST_ACCESS_WO) { 2640 /* If this is an input descriptor, 2641 * increment that count. */ 2642 *in_num += ret; 2643 if (unlikely(log && ret)) { 2644 log[*log_num].addr = desc->addr; 2645
[vhost:vhost 6/6] drivers/vhost/vhost.c:2672:9: error: 'desc' undeclared
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 2b91e7f7cb5a6f12a2f43b200cb2d65a218237ed commit: 2b91e7f7cb5a6f12a2f43b200cb2d65a218237ed [6/6] vhost: batching fetches config: mips-allmodconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 2b91e7f7cb5a6f12a2f43b200cb2d65a218237ed # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/vhost/vhost.c: In function 'vhost_get_vq_desc_batch': >> drivers/vhost/vhost.c:2672:9: error: 'desc' undeclared (first use in this >> function) if (!(desc->flags & VRING_DESC_F_NEXT)) ^~~~ drivers/vhost/vhost.c:2672:9: note: each undeclared identifier is reported only once for each function it appears in vim +/desc +2672 drivers/vhost/vhost.c 2569 2570 /* This looks in the virtqueue and for the first available buffer, and converts 2571 * it to an iovec for convenient access. Since descriptors consist of some 2572 * number of output then some number of input descriptors, it's actually two 2573 * iovecs, but we pack them into one and note how many of each there were. 2574 * 2575 * This function returns the descriptor number found, or vq->num (which is 2576 * never a valid descriptor number) if none was found. A negative code is 2577 * returned on error. */ 2578 int vhost_get_vq_desc_batch(struct vhost_virtqueue *vq, 2579struct iovec iov[], unsigned int iov_size, 2580unsigned int *out_num, unsigned int *in_num, 2581struct vhost_log *log, unsigned int *log_num) 2582 { 2583 int ret = fetch_descs(vq); 2584 struct vhost_desc *last; 2585 u16 id; 2586 int i; 2587 2588 if (ret) 2589 return ret; 2590 2591 /* Note: indirect descriptors are not batched */ 2592 /* TODO: batch up to a limit */ 2593 last = peek_split_desc(vq); 2594 id = last->id; 2595 2596 if (last->flags & VRING_DESC_F_INDIRECT) { 2597 int r; 2598 2599 pop_split_desc(vq); 2600 r = fetch_indirect_descs(vq, last, id); 2601 if (unlikely(r < 0)) { 2602 if (r != -EAGAIN) 2603 vq_err(vq, "Failure detected " 2604 "in indirect descriptor at idx %d\n", id); 2605 return ret; 2606 } 2607 } 2608 2609 /* Now convert to IOV */ 2610 /* When we start there are none of either input nor output. */ 2611 *out_num = *in_num = 0; 2612 if (unlikely(log)) 2613 *log_num = 0; 2614 2615 for (i = vq->first_desc; i < vq->ndescs; ++i) { 2616 unsigned iov_count = *in_num + *out_num; 2617 struct vhost_desc *desc = &vq->descs[i]; 2618 int access; 2619 2620 if (desc->flags & ~VHOST_DESC_FLAGS) { 2621 vq_err(vq, "Unexpected flags: 0x%x at descriptor id 0x%x\n", 2622 desc->flags, desc->id); 2623 ret = -EINVAL; 2624 goto err; 2625 } 2626 if (desc->flags & VRING_DESC_F_WRITE) 2627 access = VHOST_ACCESS_WO; 2628 else 2629 access = VHOST_ACCESS_RO; 2630 ret = translate_desc(vq, desc->addr, 2631 desc->len, iov + iov_count, 2632 iov_size - iov_count, access); 2633 if (unlikely(ret < 0)) { 2634 if (ret != -EAGAIN) 2635 vq_err(vq, "Translation failure %d descriptor idx %d\n", 2636 ret, i); 2637 goto err; 2638 } 2639 if (access == VHOST_ACCESS_WO) { 2640 /* If this is an input descriptor, 2641 * increment that count. */ 2642 *in_num += ret; 2643 if (unl
Re: [PATCH] vhost: introduce mdev based hardware backend
Hi Tiwei, Thank you for the patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [cannot apply to v5.3 next-20190925] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Tiwei-Bie/vhost-introduce-mdev-based-hardware-backend/20190926-125932 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-13) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/vhost/mdev.c:13:10: fatal error: linux/virtio_mdev.h: No such file >> or directory #include ^ compilation terminated. vim +13 drivers/vhost/mdev.c > 13 #include 14 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 2/6] mdev: introduce device specific ops
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Jason-Wang/mdev-based-hardware-virtio-offloading-support/20190923-210738 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): In file included from include/linux/vfio_mdev.h:10:0, from :0: >> include/linux/mdev.h:25:34: warning: 'struct device' declared inside >> parameter list will not be visible outside of this definition or declaration int mdev_set_iommu_device(struct device *dev, struct device *iommu_device); ^~ >> include/linux/mdev.h:62:27: warning: 'struct kobject' declared inside >> parameter list will not be visible outside of this definition or declaration int (*create)(struct kobject *kobj, struct mdev_device *mdev); ^~~ >> include/linux/mdev.h:69:19: error: field 'attr' has incomplete type struct attribute attr; ^~~~ include/linux/mdev.h:70:25: warning: 'struct kobject' declared inside parameter list will not be visible outside of this definition or declaration ssize_t (*show)(struct kobject *kobj, struct device *dev, char *buf); ^~~ include/linux/mdev.h:71:26: warning: 'struct kobject' declared inside parameter list will not be visible outside of this definition or declaration ssize_t (*store)(struct kobject *kobj, struct device *dev, ^~~ >> include/linux/mdev.h:98:23: error: field 'driver' has incomplete type struct device_driver driver; ^~ >> include/linux/mdev.h:106:7: error: unknown type name 'guid_t' const guid_t *mdev_uuid(struct mdev_device *mdev); ^~ In file included from :0:0: >> include/linux/vfio_mdev.h:50:47: warning: 'struct vm_area_struct' declared >> inside parameter list will not be visible outside of this definition or >> declaration int (*mmap)(struct mdev_device *mdev, struct vm_area_struct *vma); ^~ vim +/attr +69 include/linux/mdev.h 7b96953bc640b6 Kirti Wankhede 2016-11-17 14 8ac13175cbe985 Lu Baolu2019-04-12 15 /* 8ac13175cbe985 Lu Baolu2019-04-12 16 * Called by the parent device driver to set the device which represents 8ac13175cbe985 Lu Baolu2019-04-12 17 * this mdev in iommu protection scope. By default, the iommu device is 8ac13175cbe985 Lu Baolu2019-04-12 18 * NULL, that indicates using vendor defined isolation. 8ac13175cbe985 Lu Baolu2019-04-12 19 * 8ac13175cbe985 Lu Baolu2019-04-12 20 * @dev: the mediated device that iommu will isolate. 8ac13175cbe985 Lu Baolu2019-04-12 21 * @iommu_device: a pci device which represents the iommu for @dev. 8ac13175cbe985 Lu Baolu2019-04-12 22 * 8ac13175cbe985 Lu Baolu2019-04-12 23 * Return 0 for success, otherwise negative error value. 8ac13175cbe985 Lu Baolu2019-04-12 24 */ 8ac13175cbe985 Lu Baolu2019-04-12 @25 int mdev_set_iommu_device(struct device *dev, struct device *iommu_device); 8ac13175cbe985 Lu Baolu2019-04-12 26 8ac13175cbe985 Lu Baolu2019-04-12 27 struct device *mdev_get_iommu_device(struct device *dev); 8ac13175cbe985 Lu Baolu2019-04-12 28 7b96953bc640b6 Kirti Wankhede 2016-11-17 29 /** 42930553a7c11f Alex Williamson 2016-12-30 30 * struct mdev_parent_ops - Structure to be registered for each parent device to 7b96953bc640b6 Kirti Wankhede 2016-11-17 31 * register the device to mdev module. 7b96953bc640b6 Kirti Wankhede 2016-11-17 32 * 7b96953bc640b6 Kirti Wankhede 2016-11-17 33 * @owner: The module owner. 7b96953bc640b6 Kirti Wankhede 2016-11-17 34 * @dev_attr_groups: Attributes of the parent device. 7b96953bc640b6 Kirti Wankhede 2016-11-17 35 * @mdev_attr_groups: Attributes of the mediated device. 7b96953bc640b6 Kirti Wankhede 2016-11-17 36 * @supported_type_
[vhost:linux-next 16/17] include/linux/page_reporting.h:9:34: note: in expansion of macro 'pageblock_order'
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: 39c226b6b576b23d6d558331e6895f02b0892555 commit: 990055c63121520ad29deca72b1167b392563ddd [16/17] virtio-balloon: Add support for providing unused page reports to host config: riscv-allmodconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 990055c63121520ad29deca72b1167b392563ddd # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): In file included from arch/riscv/include/asm/thread_info.h:11:0, from include/linux/thread_info.h:38, from include/asm-generic/preempt.h:5, from ./arch/riscv/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/radix-tree.h:14, from include/linux/idr.h:15, from include/linux/kernfs.h:13, from include/linux/sysfs.h:16, from include/linux/kobject.h:20, from include/linux/device.h:16, from drivers/scsi/snic/snic_attrs.c:19: include/linux/page_reporting.h: In function '__del_page_from_reported_list': arch/riscv/include/asm/page.h:24:22: error: 'PMD_SHIFT' undeclared (first use in this function); did you mean 'NMI_SHIFT'? #define HPAGE_SHIFT PMD_SHIFT ^ arch/riscv/include/asm/page.h:27:34: note: in expansion of macro 'HPAGE_SHIFT' #define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT) ^~~ include/linux/pageblock-flags.h:41:26: note: in expansion of macro 'HUGETLB_PAGE_ORDER' #define pageblock_order HUGETLB_PAGE_ORDER ^~ >> include/linux/page_reporting.h:9:34: note: in expansion of macro >> 'pageblock_order' #define PAGE_REPORTING_MIN_ORDER pageblock_order ^~~ include/linux/page_reporting.h:61:44: note: in expansion of macro 'PAGE_REPORTING_MIN_ORDER' zone->reported_pages[page_private(page) - PAGE_REPORTING_MIN_ORDER]--; ^~~~ arch/riscv/include/asm/page.h:24:22: note: each undeclared identifier is reported only once for each function it appears in #define HPAGE_SHIFT PMD_SHIFT ^ arch/riscv/include/asm/page.h:27:34: note: in expansion of macro 'HPAGE_SHIFT' #define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT) ^~~ include/linux/pageblock-flags.h:41:26: note: in expansion of macro 'HUGETLB_PAGE_ORDER' #define pageblock_order HUGETLB_PAGE_ORDER ^~ >> include/linux/page_reporting.h:9:34: note: in expansion of macro >> 'pageblock_order' #define PAGE_REPORTING_MIN_ORDER pageblock_order ^~~ include/linux/page_reporting.h:61:44: note: in expansion of macro 'PAGE_REPORTING_MIN_ORDER' zone->reported_pages[page_private(page) - PAGE_REPORTING_MIN_ORDER]--; ^~~~ include/linux/page_reporting.h: In function 'get_unreported_tail': arch/riscv/include/asm/page.h:24:22: error: 'PMD_SHIFT' undeclared (first use in this function); did you mean 'NMI_SHIFT'? #define HPAGE_SHIFT PMD_SHIFT ^ arch/riscv/include/asm/page.h:27:34: note: in expansion of macro 'HPAGE_SHIFT' #define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT) ^~~ include/linux/pageblock-flags.h:41:26: note: in expansion of macro 'HUGETLB_PAGE_ORDER' #define pageblock_order HUGETLB_PAGE_ORDER ^~ >> include/linux/page_reporting.h:9:34: note: in expansion of macro >> 'pageblock_order' #define PAGE_REPORTING_MIN_ORDER pageblock_order ^~~ include/linux/page_reporting.h:77:15: note: in expansion of macro 'PAGE_REPORTING_MIN_ORDER' if (order >= PAGE_REPORTING_MIN_ORDER && ^~~~ include/linux/page_reporting.h: In function 'add_page_to_reported_list': arch/riscv/include/asm/page.h:24:22: error: '
[vhost:linux-next 8/9] drivers/vhost/vhost.c:2076:5: note: in expansion of macro 'array_index_nospec'
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: f2c4b499aecc0c5a1ec67f3a2a7310cb7168a8ab commit: 4c145987a955269da79312a79ec26638712644bb [8/9] vhost: block speculation of translated descriptors config: mips-malta_kvm_defconfig (attached as .config) compiler: mipsel-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 4c145987a955269da79312a79ec26638712644bb # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:11:0, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/eventfd.h:13, from drivers/vhost/vhost.c:13: drivers/vhost/vhost.c: In function 'translate_desc': >> include/linux/compiler.h:350:38: error: call to '__compiletime_assert_2077' >> declared with attribute error: BUILD_BUG_ON failed: sizeof(_s) > sizeof(long) _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^ include/linux/compiler.h:331:4: note: in definition of macro '__compiletime_assert' prefix ## suffix();\ ^~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~ include/linux/build_bug.h:50:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^~~~ >> include/linux/nospec.h:55:2: note: in expansion of macro 'BUILD_BUG_ON' BUILD_BUG_ON(sizeof(_i) > sizeof(long)); \ ^~~~ >> drivers/vhost/vhost.c:2076:5: note: in expansion of macro >> 'array_index_nospec' array_index_nospec(addr - node->start, ^~ >> include/linux/compiler.h:350:38: error: call to '__compiletime_assert_2077' >> declared with attribute error: BUILD_BUG_ON failed: sizeof(_s) > sizeof(long) _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^ include/linux/compiler.h:331:4: note: in definition of macro '__compiletime_assert' prefix ## suffix();\ ^~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~ include/linux/build_bug.h:50:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) ^~~~ include/linux/nospec.h:56:2: note: in expansion of macro 'BUILD_BUG_ON' BUILD_BUG_ON(sizeof(_s) > sizeof(long)); \ ^~~~ >> drivers/vhost/vhost.c:2076:5: note: in expansion of macro >> 'array_index_nospec' array_index_nospec(addr - node->start, ^~ -- In file included from include/linux/kernel.h:11:0, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/eventfd.h:13, from drivers//vhost/vhost.c:13: drivers//vhost/vhost.c: In function 'translate_desc': >> include/linux/compiler.h:350:38: error: call to '__compiletime_assert_2077' >> declared with attribute error: BUILD_BUG_ON failed: sizeof(_s) > sizeof(long) _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^ include/linux/compiler.h:331:4: note: in definition of macro '__compiletime_assert' prefix ## suffix();\ ^~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~ include/linux/build_bug.h:39:37: note: in expansion of macro
[vhost:linux-next 14/17] include/linux/mmzone.h:815:3: error: implicit declaration of function 'move_page_to_reported_list'; did you mean 'move_to_free_list'?
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: 39c226b6b576b23d6d558331e6895f02b0892555 commit: 50ed0c2ecb2e254a50e4ad775840f29d42cf6c00 [14/17] mm: Introduce Reported pages config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 50ed0c2ecb2e254a50e4ad775840f29d42cf6c00 # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from include/linux/page_reporting.h:5:0, from :0: include/linux/mmzone.h: In function 'add_to_free_list_tail': include/linux/mmzone.h:791:27: error: implicit declaration of function 'get_unreported_tail' [-Werror=implicit-function-declaration] struct list_head *tail = get_unreported_tail(zone, order, migratetype); ^~~ include/linux/mmzone.h:791:27: warning: initialization makes pointer from integer without a cast [-Wint-conversion] include/linux/mmzone.h: In function 'move_to_free_list': include/linux/mmzone.h:807:27: warning: initialization makes pointer from integer without a cast [-Wint-conversion] struct list_head *tail = get_unreported_tail(zone, order, migratetype); ^~~ >> include/linux/mmzone.h:815:3: error: implicit declaration of function >> 'move_page_to_reported_list'; did you mean 'move_to_free_list'? >> [-Werror=implicit-function-declaration] move_page_to_reported_list(page, zone, migratetype); ^~ move_to_free_list include/linux/mmzone.h: In function 'del_page_from_free_list': include/linux/mmzone.h:831:3: error: implicit declaration of function 'del_page_from_reported_list'; did you mean 'del_page_from_free_list'? [-Werror=implicit-function-declaration] del_page_from_reported_list(page, zone); ^~~ del_page_from_free_list In file included from :0:0: include/linux/page_reporting.h: At top level: include/linux/page_reporting.h:74:1: error: conflicting types for 'get_unreported_tail' get_unreported_tail(struct zone *zone, unsigned int order, int migratetype) ^~~ In file included from include/linux/page_reporting.h:5:0, from :0: include/linux/mmzone.h:791:27: note: previous implicit declaration of 'get_unreported_tail' was here struct list_head *tail = get_unreported_tail(zone, order, migratetype); ^~~ In file included from :0:0: include/linux/page_reporting.h:106:20: warning: conflicting types for 'del_page_from_reported_list' static inline void del_page_from_reported_list(struct page *page, ^~~ include/linux/page_reporting.h:106:20: error: static declaration of 'del_page_from_reported_list' follows non-static declaration In file included from include/linux/page_reporting.h:5:0, from :0: include/linux/mmzone.h:831:3: note: previous implicit declaration of 'del_page_from_reported_list' was here del_page_from_reported_list(page, zone); ^~~ In file included from :0:0: include/linux/page_reporting.h:118:20: warning: conflicting types for 'move_page_to_reported_list' static inline void move_page_to_reported_list(struct page *page, ^~ include/linux/page_reporting.h:118:20: error: static declaration of 'move_page_to_reported_list' follows non-static declaration In file included from include/linux/page_reporting.h:5:0, from :0: include/linux/mmzone.h:815:3: note: previous implicit declaration of 'move_page_to_reported_list' was here move_page_to_reported_list(page, zone, migratetype); ^~ cc1: some warnings being treated as errors vim +815 include/linux/mmzone.h 786 787 /* Used for pages not on another list */ 788 static inline void add_to_free_list_tail(struct page *page, struct zone *zone, 789 unsigned int order, int migratetype) 790 { > 791 struct list_head *tail = get_unreported_tail(zone, order, > migratetype); 792 793 /* 794 * To prevent the unreported pages from being interleaved with the 795 * reported ones while we are actively processing pages
[vhost:linux-next 15/15] include/linux/page_reporting.h:10:34: error: 'HUGETLB_PAGE_ORDER' undeclared; did you mean 'IOREMAP_MAX_ORDER'?
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: c5db5a8d998da36ada7287aa53b4ed501a0a2b2b commit: c5db5a8d998da36ada7287aa53b4ed501a0a2b2b [15/15] virtio-balloon: Add support for providing unused page reports to host config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout c5db5a8d998da36ada7287aa53b4ed501a0a2b2b # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): arch/arm64/Makefile:56: CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will not be built arch/arm64/Makefile:56: CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will not be built In file included from include/linux/mmzone.h:775:0, from include/linux/gfp.h:6, from include/linux/xarray.h:14, from include/linux/radix-tree.h:18, from include/linux/idr.h:15, from include/linux/kernfs.h:13, from include/linux/sysfs.h:16, from include/linux/kobject.h:20, from include/linux/of.h:17, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from include/acpi/apei.h:9, from include/acpi/ghes.h:5, from include/linux/arm_sdei.h:14, from arch/arm64/kernel/asm-offsets.c:10: include/linux/page_reporting.h:9:37: warning: "HUGETLB_PAGE_ORDER" is not defined, evaluates to 0 [-Wundef] #if defined(CONFIG_HUGETLB_PAGE) && HUGETLB_PAGE_ORDER < MAX_ORDER ^~ include/linux/page_reporting.h: In function 'get_unreported_tail': >> include/linux/page_reporting.h:10:34: error: 'HUGETLB_PAGE_ORDER' undeclared >> (first use in this function); did you mean 'IOREMAP_MAX_ORDER'? #define PAGE_REPORTING_MIN_ORDER HUGETLB_PAGE_ORDER ^ >> include/linux/page_reporting.h:72:15: note: in expansion of macro >> 'PAGE_REPORTING_MIN_ORDER' if (order >= PAGE_REPORTING_MIN_ORDER && ^~~~ include/linux/page_reporting.h:10:34: note: each undeclared identifier is reported only once for each function it appears in #define PAGE_REPORTING_MIN_ORDER HUGETLB_PAGE_ORDER ^ >> include/linux/page_reporting.h:72:15: note: in expansion of macro >> 'PAGE_REPORTING_MIN_ORDER' if (order >= PAGE_REPORTING_MIN_ORDER && ^~~~ include/linux/page_reporting.h: In function 'add_page_to_reported_list': >> include/linux/page_reporting.h:10:34: error: 'HUGETLB_PAGE_ORDER' undeclared >> (first use in this function); did you mean 'IOREMAP_MAX_ORDER'? #define PAGE_REPORTING_MIN_ORDER HUGETLB_PAGE_ORDER ^ include/linux/page_reporting.h:94:31: note: in expansion of macro 'PAGE_REPORTING_MIN_ORDER' zone->reported_pages[order - PAGE_REPORTING_MIN_ORDER]++; ^~~~ include/linux/page_reporting.h: In function 'del_page_from_reported_list': >> include/linux/page_reporting.h:10:34: error: 'HUGETLB_PAGE_ORDER' undeclared >> (first use in this function); did you mean 'IOREMAP_MAX_ORDER'? #define PAGE_REPORTING_MIN_ORDER HUGETLB_PAGE_ORDER ^ include/linux/page_reporting.h:110:44: note: in expansion of macro 'PAGE_REPORTING_MIN_ORDER' zone->reported_pages[page_private(page) - PAGE_REPORTING_MIN_ORDER]--; ^~~~ include/linux/page_reporting.h: In function 'page_reporting_notify_free': >> include/linux/page_reporting.h:10:34: error: 'HUGETLB_PAGE_ORDER' undeclared >> (first use in this function); did you mean 'IOREMAP_MAX_ORDER'? #define PAGE_REPORTING_MIN_ORDER HUGETLB_PAGE_ORDER ^ include/linux/page_reporting.h:158:14: note: in expansion of macro 'PAGE_REPORTING_MIN_ORDER' if (order < PAGE_REPORTING_MIN_ORDER) ^~~~ make[2]: *** [arch/arm64/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[
[vhost:linux-next 13/15] arch/ia64/include/asm/page.h:51:23: warning: "hpage_shift" is not defined, evaluates to 0
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: c5db5a8d998da36ada7287aa53b4ed501a0a2b2b commit: b1b0d638e6f93b91cf34585350bb00035d066989 [13/15] mm: Introduce Reported pages config: ia64-defconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout b1b0d638e6f93b91cf34585350bb00035d066989 # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): In file included from arch/ia64/include/asm/ptrace.h:46:0, from arch/ia64/include/asm/processor.h:20, from arch/ia64/include/asm/thread_info.h:12, from include/linux/thread_info.h:38, from include/asm-generic/preempt.h:5, from ./arch/ia64/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/rcupdate.h:27, from include/linux/rculist.h:11, from include/linux/sched/signal.h:5, from arch/ia64/kernel/asm-offsets.c:10: >> arch/ia64/include/asm/page.h:51:23: warning: "hpage_shift" is not defined, >> evaluates to 0 [-Wundef] # define HPAGE_SHIFT hpage_shift ^ >> arch/ia64/include/asm/page.h:153:30: note: in expansion of macro >> 'HPAGE_SHIFT' # define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT) ^~~ include/linux/page_reporting.h:9:37: note: in expansion of macro 'HUGETLB_PAGE_ORDER' #if defined(CONFIG_HUGETLB_PAGE) && HUGETLB_PAGE_ORDER < MAX_ORDER ^~ -- In file included from arch/ia64/include/asm/ptrace.h:46:0, from arch/ia64/include/asm/processor.h:20, from arch/ia64/include/asm/thread_info.h:12, from include/linux/thread_info.h:38, from include/asm-generic/preempt.h:5, from ./arch/ia64/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/rcupdate.h:27, from include/linux/rculist.h:11, from include/linux/sched/signal.h:5, from arch/ia64/kernel/asm-offsets.c:10: >> arch/ia64/include/asm/page.h:51:23: warning: "hpage_shift" is not defined, >> evaluates to 0 [-Wundef] # define HPAGE_SHIFT hpage_shift ^ >> arch/ia64/include/asm/page.h:153:30: note: in expansion of macro >> 'HPAGE_SHIFT' # define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT) ^~~ include/linux/page_reporting.h:9:37: note: in expansion of macro 'HUGETLB_PAGE_ORDER' #if defined(CONFIG_HUGETLB_PAGE) && HUGETLB_PAGE_ORDER < MAX_ORDER ^~ :1511:2: warning: #warning syscall clone3 not implemented [-Wcpp] 4 real 3 user 1 sys 120.83% cpu make prepare vim +/hpage_shift +51 arch/ia64/include/asm/page.h ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005-04-16 47 0a41e250116058 include/asm-ia64/page.h Peter Chubb 2005-08-16 48 ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005-04-16 49 #ifdef CONFIG_HUGETLB_PAGE 0a41e250116058 include/asm-ia64/page.h Peter Chubb 2005-08-16 50 # define HPAGE_REGION_BASE RGN_BASE(RGN_HPAGE) ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005-04-16 @51 # define HPAGE_SHIFT hpage_shift ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005-04-16 52 # define HPAGE_SHIFT_DEFAULT 28 /* check ia64 SDM for architecture supported size */ ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005-04-16 53 # define HPAGE_SIZE (__IA64_UL_CONST(1) << HPAGE_SHIFT) ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005-04-16 54 # define HPAGE_MASK (~(HPAGE_SIZE - 1)) ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005-04-16 55 ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005-04-16 56 # define HAVE_ARCH_HUGETLB_UNMAPPED_AREA ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005-04-16 57 #endif /* CONFIG_HUGETLB_PAGE */ ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005-04-16 58 ^1da177e4c3f41 include/asm-ia64/page.h Linus Torvalds2005
[vhost:linux-next 13/15] htmldocs: mm/page_alloc.c:2207: warning: Function parameter or member 'order' not described in 'free_reported_page'
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: c5db5a8d998da36ada7287aa53b4ed501a0a2b2b commit: b1b0d638e6f93b91cf34585350bb00035d066989 [13/15] mm: Introduce Reported pages reproduce: make htmldocs If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): Warning: The Sphinx 'sphinx_rtd_theme' HTML theme was not found. Make sure you have the theme installed to produce pretty HTML output. Falling back to the default theme. WARNING: dot(1) not found, for better output quality install graphviz from http://www.graphviz.org WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) drivers/usb/typec/bus.c:1: warning: 'typec_altmode_register_driver' not found drivers/usb/typec/bus.c:1: warning: 'typec_altmode_unregister_driver' not found drivers/usb/typec/class.c:1: warning: 'typec_altmode_unregister_notifier' not found drivers/usb/typec/class.c:1: warning: 'typec_altmode_register_notifier' not found include/linux/w1.h:272: warning: Function parameter or member 'of_match_table' not described in 'w1_family' include/linux/lsm_hooks.h:1811: warning: Function parameter or member 'quotactl' not described in 'security_list_options' include/linux/lsm_hooks.h:1811: warning: Function parameter or member 'quota_on' not described in 'security_list_options' include/linux/lsm_hooks.h:1811: warning: Function parameter or member 'sb_free_mnt_opts' not described in 'security_list_options' include/linux/lsm_hooks.h:1811: warning: Function parameter or member 'sb_eat_lsm_opts' not described in 'security_list_options' include/linux/lsm_hooks.h:1811: warning: Function parameter or member 'sb_kern_mount' not described in 'security_list_options' include/linux/lsm_hooks.h:1811: warning: Function parameter or member 'sb_show_options' not described in 'security_list_options' include/linux/lsm_hooks.h:1811: warning: Function parameter or member 'sb_add_mnt_opt' not described in 'security_list_options' include/linux/lsm_hooks.h:1811: warning: Function parameter or member 'd_instantiate' not described in 'security_list_options' include/linux/lsm_hooks.h:1811: warning: Function parameter or member 'getprocattr' not described in 'security_list_options' include/linux/lsm_hooks.h:1811: warning: Function parameter or member 'setprocattr' not described in 'security_list_options' lib/genalloc.c:1: warning: 'gen_pool_add_virt' not found lib/genalloc.c:1: warning: 'gen_pool_alloc' not found lib/genalloc.c:1: warning: 'gen_pool_free' not found lib/genalloc.c:1: warning: 'gen_pool_alloc_algo' not found include/linux/regulator/machine.h:196: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints' include/linux/regulator/driver.h:223: warning: Function parameter or member 'resume' not described in 'regulator_ops' include/linux/spi/spi.h:190: warning: Function parameter or member 'driver_override' not described in 'spi_device' fs/direct-io.c:258: warning: Excess function parameter 'offset' description in 'dio_complete' fs/libfs.c:496: warning: Excess function parameter 'available' description in 'simple_write_end' fs/posix_acl.c:647: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode' fs/posix_acl.c:647: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode' fs/posix_acl.c:647: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode' include/linux/i2c.h:337: warning: Function parameter or member 'init_irq' not described in 'i2c_client' include/linux/input/sparse-keymap.h:43: warning: Function parameter or member 'sw' not described in 'key_entry' include/linux/skbuff.h:893: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff' include/linux/skbuff.h:893: warning: Function parameter or member 'list' not described in 'sk_buff' include/linux/skbuff.h:893: warning: Function parameter or member 'ip_defrag_offset' not described in 'sk_buff' include/linux/skbuff.h:893: warning: Function parameter or member 'skb_mstamp_ns' not described in 'sk_buff' include/linux/skbuff.h:893: warning: Function parameter or member &
[vhost:linux-next 4/5] kernel/rcu/tiny.c:138:22: error: 'rcu_data' undeclared
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: 25da3c2b43902852820e3231349085682e1a commit: 4cfd64ce2ad979cbd9a97e1500533d2f5f1355b8 [4/5] rcu: add count of outstanding callbacks config: i386-allnoconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-10) 7.4.0 reproduce: git checkout 4cfd64ce2ad979cbd9a97e1500533d2f5f1355b8 # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): In file included from include/asm-generic/percpu.h:7:0, from arch/x86/include/asm/percpu.h:556, from arch/x86/include/asm/preempt.h:6, from include/linux/preempt.h:78, from include/linux/spinlock.h:51, from include/linux/wait.h:9, from include/linux/completion.h:12, from kernel/rcu/tiny.c:12: kernel/rcu/tiny.c: In function 'call_rcu_outstanding': >> kernel/rcu/tiny.c:138:22: error: 'rcu_data' undeclared (first use in this >> function) rdp = this_cpu_ptr(&rcu_data); ^ include/linux/percpu-defs.h:220:47: note: in definition of macro '__verify_pcpu_ptr' const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \ ^~~ >> include/linux/percpu-defs.h:264:47: note: in expansion of macro >> 'VERIFY_PERCPU_PTR' #define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); }) ^ >> include/linux/percpu-defs.h:265:26: note: in expansion of macro 'per_cpu_ptr' #define raw_cpu_ptr(ptr) per_cpu_ptr(ptr, 0) ^~~ >> include/linux/percpu-defs.h:266:27: note: in expansion of macro 'raw_cpu_ptr' #define this_cpu_ptr(ptr) raw_cpu_ptr(ptr) ^~~ >> kernel/rcu/tiny.c:138:8: note: in expansion of macro 'this_cpu_ptr' rdp = this_cpu_ptr(&rcu_data); ^~~~ kernel/rcu/tiny.c:138:22: note: each undeclared identifier is reported only once for each function it appears in rdp = this_cpu_ptr(&rcu_data); ^ include/linux/percpu-defs.h:220:47: note: in definition of macro '__verify_pcpu_ptr' const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \ ^~~ >> include/linux/percpu-defs.h:264:47: note: in expansion of macro >> 'VERIFY_PERCPU_PTR' #define per_cpu_ptr(ptr, cpu) ({ (void)(cpu); VERIFY_PERCPU_PTR(ptr); }) ^ >> include/linux/percpu-defs.h:265:26: note: in expansion of macro 'per_cpu_ptr' #define raw_cpu_ptr(ptr) per_cpu_ptr(ptr, 0) ^~~ >> include/linux/percpu-defs.h:266:27: note: in expansion of macro 'raw_cpu_ptr' #define this_cpu_ptr(ptr) raw_cpu_ptr(ptr) ^~~ >> kernel/rcu/tiny.c:138:8: note: in expansion of macro 'this_cpu_ptr' rdp = this_cpu_ptr(&rcu_data); ^~~~ vim +/rcu_data +138 kernel/rcu/tiny.c --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:linux-next 12/19] drivers/vhost/vhost.h:196:22: error: field 'mmu_notifier' has incomplete type
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: aa5dc31069763f9b1afcfcf2583de258af44d72c commit: eb43203ceabbab75b07a526b59b34bc170e0dc2c [12/19] vhost: access vq metadata through kernel virtual address config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout eb43203ceabbab75b07a526b59b34bc170e0dc2c # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from drivers/vhost/net.c:37:0: >> drivers/vhost/vhost.h:196:22: error: field 'mmu_notifier' has incomplete type struct mmu_notifier mmu_notifier; ^~~~ vim +/mmu_notifier +196 drivers/vhost/vhost.h 193 194 struct vhost_dev { 195 struct mm_struct *mm; > 196 struct mmu_notifier mmu_notifier; 197 struct mutex mutex; 198 struct vhost_virtqueue **vqs; 199 int nvqs; 200 struct eventfd_ctx *log_ctx; 201 struct llist_head work_list; 202 struct task_struct *worker; 203 struct vhost_umem *umem; 204 struct vhost_umem *iotlb; 205 spinlock_t iotlb_lock; 206 struct list_head read_list; 207 struct list_head pending_list; 208 wait_queue_head_t wait; 209 int iov_limit; 210 int weight; 211 int byte_weight; 212 }; 213 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net] vhost: don't use kmap() to log dirty pages
Hi Jason, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vhost-don-t-use-kmap-to-log-dirty-pages/20190514-052319 config: i386-randconfig-x005-201919 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): drivers//vhost/vhost.c: In function 'log_write': >> drivers//vhost/vhost.c:1734:29: warning: cast from pointer to integer of >> different size [-Wpointer-to-int-cast] log_base = (void __user *)((u64)log_base & ~0x3ULL); ^ >> drivers//vhost/vhost.c:1734:13: warning: cast to pointer from integer of >> different size [-Wint-to-pointer-cast] log_base = (void __user *)((u64)log_base & ~0x3ULL); ^ drivers//vhost/vhost.c:1735:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] write_page += ((u64)log_base & 0x3ULL) * 8; ^ vim +1734 drivers//vhost/vhost.c 1724 1725 static int log_write(void __user *log_base, 1726 u64 write_address, u64 write_length) 1727 { 1728 u64 write_page = write_address / VHOST_PAGE_SIZE; 1729 int r; 1730 1731 if (!write_length) 1732 return 0; 1733 write_length += write_address % VHOST_PAGE_SIZE; > 1734 log_base = (void __user *)((u64)log_base & ~0x3ULL); 1735 write_page += ((u64)log_base & 0x3ULL) * 8; 1736 for (;;) { 1737 u32 __user *log = (u32 __user *)log_base + write_page / 32; 1738 int bit = write_page % 32; 1739 1740 r = set_bit_to_user(bit, log); 1741 if (r < 0) 1742 return r; 1743 if (write_length <= VHOST_PAGE_SIZE) 1744 break; 1745 write_length -= VHOST_PAGE_SIZE; 1746 write_page += 1; 1747 } 1748 return r; 1749 } 1750 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net v4] failover: allow name change on IFF_UP slave interfaces
Hi Si-Wei, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Si-Wei-Liu/failover-allow-name-change-on-IFF_UP-slave-interfaces/20190329-195445 config: x86_64-lkp (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): net/core/dev.c: In function 'dev_change_name': >> net/core/dev.c:1252:48: error: passing argument 2 of >> 'call_netdevice_notifiers_info' from incompatible pointer type >> [-Werror=incompatible-pointer-types] call_netdevice_notifiers_info(NETDEV_CHANGE, dev, ^~~ net/core/dev.c:164:12: note: expected 'struct netdev_notifier_info *' but argument is of type 'struct net_device *' static int call_netdevice_notifiers_info(unsigned long val, ^ >> net/core/dev.c:1252:3: error: too many arguments to function >> 'call_netdevice_notifiers_info' call_netdevice_notifiers_info(NETDEV_CHANGE, dev, ^ net/core/dev.c:164:12: note: declared here static int call_netdevice_notifiers_info(unsigned long val, ^ cc1: some warnings being treated as errors vim +/call_netdevice_notifiers_info +1252 net/core/dev.c 1166 1167 /** 1168 * dev_change_name - change name of a device 1169 * @dev: device 1170 * @newname: name (or format string) must be at least IFNAMSIZ 1171 * 1172 * Change name of a device, can pass format strings "eth%d". 1173 * for wildcarding. 1174 */ 1175 int dev_change_name(struct net_device *dev, const char *newname) 1176 { 1177 unsigned char old_assign_type; 1178 char oldname[IFNAMSIZ]; 1179 int err = 0; 1180 int ret; 1181 struct net *net; 1182 1183 ASSERT_RTNL(); 1184 BUG_ON(!dev_net(dev)); 1185 1186 net = dev_net(dev); 1187 1188 /* Allow failover slave to rename even when 1189 * it is up and running. 1190 * 1191 * Failover slaves are special, since userspace 1192 * might rename the slave after the interface 1193 * has been brought up and running due to 1194 * auto-enslavement. 1195 * 1196 * Failover users don't actually care about slave 1197 * name change, as they are only expected to operate 1198 * on master interface directly. 1199 */ 1200 if (dev->flags & IFF_UP && 1201 likely(!(dev->priv_flags & IFF_FAILOVER_SLAVE))) 1202 return -EBUSY; 1203 1204 write_seqcount_begin(&devnet_rename_seq); 1205 1206 if (strncmp(newname, dev->name, IFNAMSIZ) == 0) { 1207 write_seqcount_end(&devnet_rename_seq); 1208 return 0; 1209 } 1210 1211 memcpy(oldname, dev->name, IFNAMSIZ); 1212 1213 err = dev_get_valid_name(net, dev, newname); 1214 if (err < 0) { 1215 write_seqcount_end(&devnet_rename_seq); 1216 return err; 1217 } 1218 1219 if (oldname[0] && !strchr(oldname, '%')) 1220 netdev_info(dev, "renamed from %s\n", oldname); 1221 1222 old_assign_type = dev->name_assign_type; 1223 dev->name_assign_type = NET_NAME_RENAMED; 1224 1225 rollback: 1226 ret = device_rename(&dev->dev, dev->name); 1227 if (ret) { 1228 memcpy(dev->name, oldname, IFNAMSIZ); 1229 dev->name_assign_type = old_assign_type; 1230 write_seqcount_end(&devnet_rename_seq); 1231 return ret; 1232 } 1233 1234 write_seqcount_end(&devnet_rename_seq); 1235 1236 netdev_adjacent_rename_links(dev, oldname); 1237 1238 write_lock_bh(&dev_base_lock); 1239 hlist_del_rcu(&dev->name_hlist); 1240 write_unlock_bh(&dev_base_lock); 1241 1242 synchronize_rcu(); 1243 1244 write_lock_bh(&dev_base_lock); 1245 hlist_add_head_rcu(&dev->name_hlist, dev_name_hash(net, dev->name)); 1246 write_unlock_bh(&dev_base_lock); 1247 1248 if (unlikely(dev->flags & IFF_UP)) { 1249 struct netdev_notifier_change_info change_info; 1250 1251 change_info.flags_changed = 0; > 1252 call_netdevice_notifiers_info(NETDEV_CHANGE, dev, 1253&change_info.info); 1254 } 1255 1256 ret = call_netdevice_notifiers(NETDEV_CHANGENAME, dev);
Re: [PATCH net v3] failover: allow name change on IFF_UP slave interfaces
Hi Si-Wei, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Si-Wei-Liu/failover-allow-name-change-on-IFF_UP-slave-interfaces/20190329-020744 config: openrisc-or1ksim_defconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All errors (new ones prefixed by >>): net/core/dev.c: In function 'dev_change_name': >> net/core/dev.c:1277:9: error: too few arguments to function 'dev_open' ret = dev_open(dev); ^~~~ In file included from net/core/dev.c:93:0: include/linux/netdevice.h:2636:5: note: declared here int dev_open(struct net_device *dev, struct netlink_ext_ack *extack); ^~~~ vim +/dev_open +1277 net/core/dev.c 1166 1167 /** 1168 * dev_change_name - change name of a device 1169 * @dev: device 1170 * @newname: name (or format string) must be at least IFNAMSIZ 1171 * 1172 * Change name of a device, can pass format strings "eth%d". 1173 * for wildcarding. 1174 */ 1175 int dev_change_name(struct net_device *dev, const char *newname) 1176 { 1177 unsigned char old_assign_type; 1178 bool reopen_needed = false; 1179 char oldname[IFNAMSIZ]; 1180 int err = 0; 1181 int ret; 1182 struct net *net; 1183 1184 ASSERT_RTNL(); 1185 BUG_ON(!dev_net(dev)); 1186 1187 net = dev_net(dev); 1188 1189 /* Allow failover slave to rename even when 1190 * it is up and running. 1191 * 1192 * Failover slaves are special, since userspace 1193 * might rename the slave after the interface 1194 * has been brought up and running due to 1195 * auto-enslavement. 1196 * 1197 * Failover users don't actually care about slave 1198 * name change, as they are only expected to operate 1199 * on master interface directly. 1200 */ 1201 if (dev->flags & IFF_UP) { 1202 if (likely(!(dev->priv_flags & IFF_FAILOVER_SLAVE))) 1203 return -EBUSY; 1204 reopen_needed = true; 1205 } 1206 1207 write_seqcount_begin(&devnet_rename_seq); 1208 1209 if (strncmp(newname, dev->name, IFNAMSIZ) == 0) { 1210 write_seqcount_end(&devnet_rename_seq); 1211 return 0; 1212 } 1213 1214 memcpy(oldname, dev->name, IFNAMSIZ); 1215 1216 err = dev_get_valid_name(net, dev, newname); 1217 if (err < 0) { 1218 write_seqcount_end(&devnet_rename_seq); 1219 return err; 1220 } 1221 1222 if (reopen_needed) 1223 dev_close(dev); 1224 1225 if (oldname[0] && !strchr(oldname, '%')) 1226 netdev_info(dev, "renamed from %s\n", oldname); 1227 1228 old_assign_type = dev->name_assign_type; 1229 dev->name_assign_type = NET_NAME_RENAMED; 1230 1231 rollback: 1232 ret = device_rename(&dev->dev, dev->name); 1233 if (ret) { 1234 memcpy(dev->name, oldname, IFNAMSIZ); 1235 dev->name_assign_type = old_assign_type; 1236 write_seqcount_end(&devnet_rename_seq); 1237 if (err >= 0) 1238 err = ret; 1239 goto reopen; 1240 } 1241 1242 write_seqcount_end(&devnet_rename_seq); 1243 1244 netdev_adjacent_rename_links(dev, oldname); 1245 1246 write_lock_bh(&dev_base_lock); 1247 hlist_del_rcu(&dev->name_hlist); 1248 write_unlock_bh(&dev_base_lock); 1249 1250 synchronize_rcu(); 1251 1252 write_lock_bh(&dev_base_lock); 1253 hlist_add_head_rcu(&dev->name_hlist, dev_name_hash(net, dev->name)); 1254 write_unlock_bh(&dev_base_lock); 1255 1256 ret = call_netdevice_notifiers(NETDEV_CHANGENAME, dev); 1257 ret = notifier_to_errno(ret); 1258 1259 if (ret) { 1260 /* err >= 0 after dev_alloc_name() or stores the first errno */ 1261 if (err >= 0) { 1262 err = ret; 1263 write_seqcount_begin(&devnet_rename_seq); 1264 memcpy(dev->name, oldname, IFNAMSIZ); 1265 memcpy(oldname, newname, IFNAMSIZ); 1266
Re: [PATCH] drm/qxl: unbind vgacon
Hi Gerd, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc4 next-20190221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gerd-Hoffmann/drm-qxl-unbind-vgacon/20190222-030117 config: x86_64-randconfig-m2-02211051 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): ld: drivers/gpu/drm/qxl/qxl_drv.o: in function `qxl_pci_probe': >> drivers/gpu/drm/qxl/qxl_drv.c:94: undefined reference to `dummy_con' >> ld: drivers/gpu/drm/qxl/qxl_drv.c:94: undefined reference to >> `do_take_over_console' vim +94 drivers/gpu/drm/qxl/qxl_drv.c 61 62 static int 63 qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 64 { 65 struct qxl_device *qdev; 66 int ret; 67 68 if (pdev->revision < 4) { 69 DRM_ERROR("qxl too old, doesn't support client_monitors_config," 70" use xf86-video-qxl in user mode"); 71 return -EINVAL; /* TODO: ENODEV ? */ 72 } 73 74 qdev = kzalloc(sizeof(struct qxl_device), GFP_KERNEL); 75 if (!qdev) 76 return -ENOMEM; 77 78 ret = pci_enable_device(pdev); 79 if (ret) 80 goto free_dev; 81 82 ret = qxl_device_init(qdev, &qxl_driver, pdev); 83 if (ret) 84 goto disable_pci; 85 86 ret = qxl_modeset_init(qdev); 87 if (ret) 88 goto unload; 89 90 drm_kms_helper_poll_init(&qdev->ddev); 91 92 /* unbind vgacon to make sure it doesn't touch our vga registers */ 93 console_lock(); > 94 ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, true); 95 console_unlock(); 96 97 /* Complete initialization. */ 98 ret = drm_dev_register(&qdev->ddev, ent->driver_data); 99 if (ret) 100 goto modeset_cleanup; 101 102 return 0; 103 104 modeset_cleanup: 105 qxl_modeset_fini(qdev); 106 unload: 107 qxl_device_fini(qdev); 108 disable_pci: 109 pci_disable_device(pdev); 110 free_dev: 111 kfree(qdev); 112 return ret; 113 } 114 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] drm/qxl: unbind vgacon
Hi Gerd, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc4 next-20190221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gerd-Hoffmann/drm-qxl-unbind-vgacon/20190222-030117 config: x86_64-randconfig-l3-02212045 (attached as .config) compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> ERROR: "dummy_con" [drivers/gpu/drm/qxl/qxl.ko] undefined! >> ERROR: "do_take_over_console" [drivers/gpu/drm/qxl/qxl.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:linux-next 3/23] include/linux/swiotlb.h:105:20: error: static declaration of 'is_swiotlb_active' follows non-static declaration
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: 104f89a60ef5ec77d6f559eac4676844b3480740 commit: 155fcd8511de5f99c27a726e9153b87cce528b6e [3/23] swiotlb: Add is_swiotlb_active() function config: i386-tinyconfig (attached as .config) compiler: gcc-8 (Debian 8.2.0-14) 8.2.0 reproduce: git checkout 155fcd8511de5f99c27a726e9153b87cce528b6e # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): In file included from arch/x86/include/asm/swiotlb.h:5, from arch/x86/include/asm/dma-mapping.h:13, from include/linux/dma-mapping.h:261, from include/linux/skbuff.h:34, from include/net/net_namespace.h:36, from include/linux/inet.h:46, from include/linux/sunrpc/msg_prot.h:204, from include/linux/sunrpc/auth.h:16, from include/linux/nfs_fs.h:31, from init/do_mounts.c:22: include/linux/swiotlb.h:100:22: error: static declaration of 'swiotlb_max_mapping_size' follows non-static declaration static inline size_t swiotlb_max_mapping_size(struct device *dev) ^~~~ include/linux/swiotlb.h:65:8: note: previous declaration of 'swiotlb_max_mapping_size' was here size_t swiotlb_max_mapping_size(struct device *dev); ^~~~ >> include/linux/swiotlb.h:105:20: error: static declaration of >> 'is_swiotlb_active' follows non-static declaration static inline bool is_swiotlb_active(void) ^ include/linux/swiotlb.h:66:6: note: previous declaration of 'is_swiotlb_active' was here bool is_swiotlb_active(void); ^ vim +/is_swiotlb_active +105 include/linux/swiotlb.h 76 77 bool swiotlb_map(struct device *dev, phys_addr_t *phys, dma_addr_t *dma_addr, 78 size_t size, enum dma_data_direction dir, unsigned long attrs); 79 void __init swiotlb_exit(void); 80 unsigned int swiotlb_max_segment(void); 81 #else 82 #define swiotlb_force SWIOTLB_NO_FORCE 83 static inline bool is_swiotlb_buffer(phys_addr_t paddr) 84 { 85 return false; 86 } 87 static inline bool swiotlb_map(struct device *dev, phys_addr_t *phys, 88 dma_addr_t *dma_addr, size_t size, enum dma_data_direction dir, 89 unsigned long attrs) 90 { 91 return false; 92 } 93 static inline void swiotlb_exit(void) 94 { 95 } 96 static inline unsigned int swiotlb_max_segment(void) 97 { 98 return 0; 99 } > 100 static inline size_t swiotlb_max_mapping_size(struct device *dev) 101 { 102 return SIZE_MAX; 103 } 104 > 105 static inline bool is_swiotlb_active(void) 106 { 107 return false; 108 } 109 #endif /* CONFIG_SWIOTLB */ 110 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[vhost:linux-next 2/23] include/linux/swiotlb.h:99:22: error: static declaration of 'swiotlb_max_mapping_size' follows non-static declaration
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next head: 104f89a60ef5ec77d6f559eac4676844b3480740 commit: 951a381d4c0d45a9b44de30228c6ef17083854ea [2/23] swiotlb: Introduce swiotlb_max_mapping_size() config: i386-tinyconfig (attached as .config) compiler: gcc-8 (Debian 8.2.0-14) 8.2.0 reproduce: git checkout 951a381d4c0d45a9b44de30228c6ef17083854ea # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): vim +/swiotlb_max_mapping_size +99 include/linux/swiotlb.h 75 76 bool swiotlb_map(struct device *dev, phys_addr_t *phys, dma_addr_t *dma_addr, 77 size_t size, enum dma_data_direction dir, unsigned long attrs); 78 void __init swiotlb_exit(void); 79 unsigned int swiotlb_max_segment(void); 80 #else 81 #define swiotlb_force SWIOTLB_NO_FORCE 82 static inline bool is_swiotlb_buffer(phys_addr_t paddr) 83 { 84 return false; 85 } 86 static inline bool swiotlb_map(struct device *dev, phys_addr_t *phys, 87 dma_addr_t *dma_addr, size_t size, enum dma_data_direction dir, 88 unsigned long attrs) 89 { 90 return false; 91 } 92 static inline void swiotlb_exit(void) 93 { 94 } 95 static inline unsigned int swiotlb_max_segment(void) 96 { 97 return 0; 98 } > 99 static inline size_t swiotlb_max_mapping_size(struct device *dev) 100 { 101 return SIZE_MAX; 102 } 103 #endif /* CONFIG_SWIOTLB */ 104 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net 4/4] vhost: log dirty page correctly
Hi Jason, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Jason-Wang/Fix-various-issue-of-vhost/20181210-223236 config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): include/linux/slab.h:332:43: warning: dubious: x & !y include/linux/slab.h:332:43: warning: dubious: x & !y include/linux/slab.h:332:43: warning: dubious: x & !y drivers/vhost/vhost.c:704:17: warning: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:704:17:expected void [noderef] * drivers/vhost/vhost.c:704:17:got void * drivers/vhost/vhost.c:704:17: warning: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:704:17:expected void [noderef] * drivers/vhost/vhost.c:704:17:got void * include/linux/slab.h:332:43: warning: dubious: x & !y drivers/vhost/vhost.c:704:17: warning: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:704:17:expected void [noderef] * drivers/vhost/vhost.c:704:17:got void * >> drivers/vhost/vhost.c:1771:35: warning: cast removes address space '' >> of expression drivers/vhost/vhost.c:1776:42: warning: cast removes address space '' of expression drivers/vhost/vhost.c:1788:48: warning: cast removes address space '' of expression drivers/vhost/vhost.c:1819:13: warning: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:1819:13:expected void *addr drivers/vhost/vhost.c:1819:13:got restricted __virtio16 [noderef] * drivers/vhost/vhost.c:704:17: warning: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:704:17:expected void [noderef] * drivers/vhost/vhost.c:704:17:got void * drivers/vhost/vhost.c:851:42: warning: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:851:42:expected void [noderef] *addr drivers/vhost/vhost.c:851:42:got void *addr drivers/vhost/vhost.c:1837:13: warning: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:1837:13:expected void *addr drivers/vhost/vhost.c:1837:13:got restricted __virtio16 [noderef] [usertype] * drivers/vhost/vhost.c:704:17: warning: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:704:17:expected void [noderef] * drivers/vhost/vhost.c:704:17:got void * drivers/vhost/vhost.c:851:42: warning: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:851:42:expected void [noderef] *addr drivers/vhost/vhost.c:851:42:got void *addr drivers/vhost/vhost.c:1874:13: warning: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:1874:13:expected void *addr drivers/vhost/vhost.c:1874:13:got restricted __virtio16 [noderef] * drivers/vhost/vhost.c:704:17: warning: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:704:17:expected void [noderef] * drivers/vhost/vhost.c:704:17:got void * drivers/vhost/vhost.c:851:42: warning: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:851:42:expected void [noderef] *addr drivers/vhost/vhost.c:851:42:got void *addr drivers/vhost/vhost.c:2073:21: warning: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:2073:21:expected void *addr drivers/vhost/vhost.c:2073:21:got restricted __virtio16 [noderef] * drivers/vhost/vhost.c:704:17: warning: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:704:17:expected void [noderef] * drivers/vhost/vhost.c:704:17:got void * drivers/vhost/vhost.c:851:42: warning: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:851:42:expected void [noderef] *addr drivers/vhost/vhost.c:851:42:got void *addr drivers/vhost/vhost.c:2100:13: warning: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:2100:13:expected void *addr drivers/vhost/vhost.c:2100:13:got restricted __virtio16 [noderef] * drivers/vhost/vhost.c:704:17: warning: incorrect type in return expression (different address spaces) drivers/vhost/vhost.c:704:17:expected void [noderef] * drivers/vhost/vhost.c:704:17:got void * drivers/vhost/vhost.c:851:42: warning: incorrect type in argument 2 (different address spaces) drivers/vhost/vhost.c:851:42:expected void [noderef] *addr drivers/vhost/vhost.c:851:42:got void *addr drivers/vhost/vhost.c:2231:21: warning: incorrect type in argument 2 (differ
Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vhost-accelerate-metadata-access-through-vmap/20181214-200417 config: mips-malta_kvm_defconfig (attached as .config) compiler: mipsel-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=mips All errors (new ones prefixed by >>): drivers//vhost/vhost.c: In function 'vhost_init_vmap': >> drivers//vhost/vhost.c:648:3: error: implicit declaration of function >> 'release_pages'; did you mean 'release_task'? >> [-Werror=implicit-function-declaration] release_pages(pages, npinned); ^ release_task cc1: some warnings being treated as errors vim +648 drivers//vhost/vhost.c 619 620 static int vhost_init_vmap(struct vhost_vmap *map, unsigned long uaddr, 621 size_t size, int write) 622 { 623 struct page **pages; 624 int npages = DIV_ROUND_UP(size, PAGE_SIZE); 625 int npinned; 626 void *vaddr; 627 628 pages = kmalloc_array(npages, sizeof(struct page *), GFP_KERNEL); 629 if (!pages) 630 return -ENOMEM; 631 632 npinned = get_user_pages_fast(uaddr, npages, write, pages); 633 if (npinned != npages) 634 goto err; 635 636 vaddr = vmap(pages, npages, VM_MAP, PAGE_KERNEL); 637 if (!vaddr) 638 goto err; 639 640 map->pages = pages; 641 map->addr = vaddr + (uaddr & (PAGE_SIZE - 1)); 642 map->npages = npages; 643 644 return 0; 645 646 err: 647 if (npinned > 0) > 648 release_pages(pages, npinned); 649 kfree(pages); 650 return -EFAULT; 651 } 652 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net 4/4] vhost: log dirty page correctly
Hi Jason, I love your patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Jason-Wang/Fix-various-issue-of-vhost/20181210-223236 config: i386-randconfig-x072-201849 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers//vhost/vhost.c: In function 'log_used': >> drivers//vhost/vhost.c:1771:27: warning: cast from pointer to integer of >> different size [-Wpointer-to-int-cast] ret = translate_desc(vq, (u64)vq->used + used_offset, len, iov, 64, ^ drivers//vhost/vhost.c:1776:27: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ret = log_write_hva(vq, (u64)iov[i].iov_base, iov[i].iov_len); ^ drivers//vhost/vhost.c: In function 'vhost_log_write': drivers//vhost/vhost.c:1788:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] r = log_write_hva(vq, (u64)iov[i].iov_base, ^ Cyclomatic Complexity 5 include/linux/compiler.h:__read_once_size Cyclomatic Complexity 5 include/linux/compiler.h:__write_once_size Cyclomatic Complexity 1 arch/x86/include/asm/barrier.h:array_index_mask_nospec Cyclomatic Complexity 1 include/linux/kasan-checks.h:kasan_check_read Cyclomatic Complexity 1 include/linux/kasan-checks.h:kasan_check_write Cyclomatic Complexity 2 arch/x86/include/asm/bitops.h:set_bit Cyclomatic Complexity 2 arch/x86/include/asm/bitops.h:clear_bit Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:test_and_set_bit Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:constant_test_bit Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:variable_test_bit Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:fls Cyclomatic Complexity 1 include/linux/log2.h:__ilog2_u32 Cyclomatic Complexity 1 include/linux/list.h:INIT_LIST_HEAD Cyclomatic Complexity 1 include/linux/list.h:__list_del Cyclomatic Complexity 1 include/linux/list.h:list_empty Cyclomatic Complexity 1 arch/x86/include/asm/current.h:get_current Cyclomatic Complexity 3 include/linux/string.h:memset Cyclomatic Complexity 5 include/linux/string.h:memcpy Cyclomatic Complexity 1 include/asm-generic/getorder.h:__get_order Cyclomatic Complexity 1 arch/x86/include/asm/atomic.h:arch_atomic_dec_and_test Cyclomatic Complexity 1 include/asm-generic/atomic-instrumented.h:atomic_dec_and_test Cyclomatic Complexity 1 include/linux/err.h:PTR_ERR Cyclomatic Complexity 1 include/linux/thread_info.h:set_ti_thread_flag Cyclomatic Complexity 1 include/linux/thread_info.h:check_object_size Cyclomatic Complexity 5 include/linux/thread_info.h:check_copy_size Cyclomatic Complexity 1 arch/x86/include/asm/preempt.h:preempt_count Cyclomatic Complexity 1 include/linux/spinlock.h:spinlock_check Cyclomatic Complexity 1 include/linux/spinlock.h:spin_lock Cyclomatic Complexity 1 include/linux/spinlock.h:spin_unlock Cyclomatic Complexity 1 include/linux/wait.h:init_waitqueue_func_entry Cyclomatic Complexity 1 include/linux/llist.h:init_llist_head Cyclomatic Complexity 1 include/linux/llist.h:llist_empty Cyclomatic Complexity 1 include/linux/llist.h:llist_del_all Cyclomatic Complexity 1 include/linux/rbtree.h:rb_link_node Cyclomatic Complexity 3 include/linux/overflow.h:__ab_c_size Cyclomatic Complexity 1 include/linux/page_ref.h:page_ref_dec_and_test Cyclomatic Complexity 1 include/linux/sched.h:task_thread_info Cyclomatic Complexity 1 include/linux/sched.h:need_resched Cyclomatic Complexity 1 include/linux/mm.h:put_page_testzero Cyclomatic Complexity 1 include/linux/mm.h:put_devmap_managed_page Cyclomatic Complexity 1 include/uapi/linux/virtio_ring.h:vring_need_event Cyclomatic Complexity 1 include/linux/virtio_byteorder.h:virtio_legacy_is_little_endian Cyclomatic Complexity 2 include/linux/uio.h:copy_to_iter Cyclomatic Complexity 2 include/linux/uio.h:copy_from_iter Cyclomatic Complexity 2 include/linux/uio.h:copy_from_iter_full Cyclomatic Complexity 1 include/linux/uio.h:iov_iter_count Cyclomatic Complexity 1 include/linux/slab.h:kmalloc_type Cyclomatic Complexity 28 include/linux/slab.h:kmalloc_index Cyclomatic Complexity 67 include/linux/slab.h:kmalloc_large Cyclomatic Complexity 4 include/linux/slab.h:kmalloc Cyclomatic Complexity 1 arch/x86/include/asm/smap.h:clac Cyclomatic Complexity 1 arch/x86/include/asm/smap.h:stac Cyclomatic Complexity 1 arch/x86/include/asm/uaccess.h:set_fs Cyclomatic Complexity 1 arch/x86/include/asm/uaccess_32.h:raw_copy_to_user Cyclomatic Complexity 5 arch/x86/include/asm/uaccess_32.h:raw_copy_from_user Cyclomatic Complexity 1 include/linux/uaccess.h:__copy_from_user Cyclomatic Complexit
Re: Patch "x86/hyper-v: Enable PIT shutdown quirk" has been added to the 4.19-stable tree
Hi gregkh, I love your patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [cannot apply to v4.20-rc3 next-20181120] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/gregkh-linuxfoundation-org/Patch-x86-hyper-v-Enable-PIT-shutdown-quirk-has-been-added-to-the-4-19-stable-tree/20181120-042611 config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): >> arch/x86/kernel/cpu/mshyperv.c:297:9: error: undefined identifier >> 'i8253_clear_counter_on_shutdown' arch/x86/kernel/cpu/mshyperv.c:320:41: warning: symbol 'x86_hyper_ms_hyperv' was not declared. Should it be static? >> arch/x86/kernel/cpu/mshyperv.c:297:9: warning: generating address of >> non-lvalue (3) arch/x86/kernel/cpu/mshyperv.c: In function 'ms_hyperv_init_platform': arch/x86/kernel/cpu/mshyperv.c:297:2: error: 'i8253_clear_counter_on_shutdown' undeclared (first use in this function) i8253_clear_counter_on_shutdown = false; ^~~ arch/x86/kernel/cpu/mshyperv.c:297:2: note: each undeclared identifier is reported only once for each function it appears in vim +/i8253_clear_counter_on_shutdown +297 arch/x86/kernel/cpu/mshyperv.c 275 276 #if IS_ENABLED(CONFIG_HYPERV) && defined(CONFIG_KEXEC_CORE) 277 machine_ops.shutdown = hv_machine_shutdown; 278 machine_ops.crash_shutdown = hv_machine_crash_shutdown; 279 #endif 280 mark_tsc_unstable("running on Hyper-V"); 281 282 /* 283 * Generation 2 instances don't support reading the NMI status from 284 * 0x61 port. 285 */ 286 if (efi_enabled(EFI_BOOT)) 287 x86_platform.get_nmi_reason = hv_get_nmi_reason; 288 289 /* 290 * Hyper-V VMs have a PIT emulation quirk such that zeroing the 291 * counter register during PIT shutdown restarts the PIT. So it 292 * continues to interrupt @18.2 HZ. Setting i8253_clear_counter 293 * to false tells pit_shutdown() not to zero the counter so that 294 * the PIT really is shutdown. Generation 2 VMs don't have a PIT, 295 * and setting this value has no effect. 296 */ > 297 i8253_clear_counter_on_shutdown = false; 298 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: Patch "x86/hyper-v: Enable PIT shutdown quirk" has been added to the 4.19-stable tree
Hi gregkh, I love your patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [cannot apply to v4.20-rc3 next-20181119] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/gregkh-linuxfoundation-org/Patch-x86-hyper-v-Enable-PIT-shutdown-quirk-has-been-added-to-the-4-19-stable-tree/20181120-042611 config: i386-randconfig-x019-201846 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): arch/x86/kernel/cpu/mshyperv.c: In function 'ms_hyperv_init_platform': >> arch/x86/kernel/cpu/mshyperv.c:297:2: error: >> 'i8253_clear_counter_on_shutdown' undeclared (first use in this function) i8253_clear_counter_on_shutdown = false; ^~~ arch/x86/kernel/cpu/mshyperv.c:297:2: note: each undeclared identifier is reported only once for each function it appears in vim +/i8253_clear_counter_on_shutdown +297 arch/x86/kernel/cpu/mshyperv.c 275 276 #if IS_ENABLED(CONFIG_HYPERV) && defined(CONFIG_KEXEC_CORE) 277 machine_ops.shutdown = hv_machine_shutdown; 278 machine_ops.crash_shutdown = hv_machine_crash_shutdown; 279 #endif 280 mark_tsc_unstable("running on Hyper-V"); 281 282 /* 283 * Generation 2 instances don't support reading the NMI status from 284 * 0x61 port. 285 */ 286 if (efi_enabled(EFI_BOOT)) 287 x86_platform.get_nmi_reason = hv_get_nmi_reason; 288 289 /* 290 * Hyper-V VMs have a PIT emulation quirk such that zeroing the 291 * counter register during PIT shutdown restarts the PIT. So it 292 * continues to interrupt @18.2 HZ. Setting i8253_clear_counter 293 * to false tells pit_shutdown() not to zero the counter so that 294 * the PIT really is shutdown. Generation 2 VMs don't have a PIT, 295 * and setting this value has no effect. 296 */ > 297 i8253_clear_counter_on_shutdown = false; 298 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 1/1] Add vhost_blk driver
Hi Vitaly, Thank you for the patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on v4.19 next-20181102] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vitaly-Mayatskikh/vhost-add-vhost_blk-driver/20181103-084141 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next config: mips-allyesconfig (attached as .config) compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=mips All error/warnings (new ones prefixed by >>): drivers/vhost/blk.c: In function 'vhost_blk_iocb_complete': >> drivers/vhost/blk.c:129:2: error: implicit declaration of function >> 'vhost_vq_work_queue'; did you mean 'vhost_work_queue'? >> [-Werror=implicit-function-declaration] vhost_vq_work_queue(&req->q->vq, &req->q->w); ^~~ vhost_work_queue In file included from include/linux/kernel.h:14:0, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/vhost/blk.c:11: drivers/vhost/blk.c: In function 'vhost_blk_req_handle': >> drivers/vhost/blk.c:153:12: warning: format '%ld' expects argument of type >> 'long int', but argument 8 has type 'ssize_t {aka int}' [-Wformat=] pr_debug("%s: [pid:%d %s] %s sector %lld, len %ld\n", ^ include/linux/printk.h:292:21: note: in definition of macro 'pr_fmt' #define pr_fmt(fmt) fmt ^~~ include/linux/printk.h:340:2: note: in expansion of macro 'dynamic_pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ^~~~ >> drivers/vhost/blk.c:153:3: note: in expansion of macro 'pr_debug' pr_debug("%s: [pid:%d %s] %s sector %lld, len %ld\n", ^~~~ cc1: some warnings being treated as errors vim +129 drivers/vhost/blk.c 118 119 static void vhost_blk_iocb_complete(struct kiocb *iocb, long ret, long ret2) 120 { 121 struct vhost_blk_req *req = container_of(iocb, struct vhost_blk_req, 122 iocb); 123 124 pr_debug("%s vq[%d] req->index %d ret %ld ret2 %ld\n", __func__, 125 req->q->index, req->index, ret, ret2); 126 127 req->res = (ret == req->len) ? VIRTIO_BLK_S_OK : VIRTIO_BLK_S_IOERR; 128 llist_add(&req->list, &req->q->wl); > 129 vhost_vq_work_queue(&req->q->vq, &req->q->w); 130 } 131 132 static int vhost_blk_req_handle(struct vhost_blk_req *req) 133 { 134 struct vhost_blk *blk = req->q->blk; 135 struct vhost_virtqueue *vq = &req->q->vq; 136 int type = le32_to_cpu(req->hdr.type); 137 int ret; 138 u8 status; 139 140 if ((type == VIRTIO_BLK_T_IN) || (type == VIRTIO_BLK_T_OUT)) { 141 bool write = (type == VIRTIO_BLK_T_OUT); 142 int nr_seg = (write ? req->out_num : req->in_num) - 1; 143 unsigned long sector = le64_to_cpu(req->hdr.sector); 144 ssize_t len, rem_len; 145 146 if (!req->q->blk->backend) { 147 vq_err(vq, "blk %p no backend!\n", req->q->blk); 148 ret = -EINVAL; 149 goto out_err; 150 } 151 152 len = iov_length(&vq->iov[1], nr_seg); > 153 pr_debug("%s: [pid:%d %s] %s sector %lld, len %ld\n", 154 __func__, current->pid, current->comm, 155 write ? "WRITE" : "READ", req->hdr.sector, len); 156 157 req->len = len; 158 rem_len = len; 159 iov_iter_init(&req->i, (write ? WRITE : READ), 160write ? &req->out_iov[0] : &req->in_iov[0], 161nr_seg, len); 162 163 req->iocb.ki_pos = sector << 9; 164 req->iocb.ki_filp = blk->backend; 165 req->iocb.ki_complete = vhost_blk_iocb_complete; 166 req->iocb.ki_flags = IOCB_DIRECT; 167 168 if (write) 169 ret = call_write_iter(blk->backend, &req->iocb, 170&req->i); 171 else 172 ret = call_read_iter(blk->backend, &req->iocb, 173 &req->i); 174 175 if (ret != -EIOCBQUEUED) 176
Re: [PATCH] qxl: refactor to use drm_fb_helper_fbdev_setup
Hi Peter, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.19-rc3 next-20180910] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Peter-Wu/qxl-refactor-to-use-drm_fb_helper_fbdev_setup/20180911-071413 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/gpu/drm/qxl/qxl_drv.c:144:9: sparse: undefined identifier 'qxl_fbdev_set_suspend' drivers/gpu/drm/qxl/qxl_drv.c:181:9: sparse: undefined identifier 'qxl_fbdev_set_suspend' >> drivers/gpu/drm/qxl/qxl_drv.c:144:30: sparse: call with no type! drivers/gpu/drm/qxl/qxl_drv.c:181:30: sparse: call with no type! drivers/gpu/drm/qxl/qxl_drv.c: In function 'qxl_drm_freeze': drivers/gpu/drm/qxl/qxl_drv.c:144:2: error: implicit declaration of function 'qxl_fbdev_set_suspend'; did you mean 'fb_set_suspend'? [-Werror=implicit-function-declaration] qxl_fbdev_set_suspend(qdev, 1); ^ fb_set_suspend cc1: some warnings being treated as errors -- >> drivers/gpu/drm/qxl/qxl_fb.c:166:21: sparse: incorrect type in assignment >> (different address spaces) @@expected char const *data @@got char >> [noderchar const *data @@ drivers/gpu/drm/qxl/qxl_fb.c:166:21:expected char const *data drivers/gpu/drm/qxl/qxl_fb.c:166:21:got char [noderef] * include/linux/overflow.h:251:13: sparse: undefined identifier '__builtin_mul_overflow' include/linux/overflow.h:251:13: sparse: incorrect type in conditional include/linux/overflow.h:251:13:got void include/linux/overflow.h:251:13: sparse: call with no type! vim +166 drivers/gpu/drm/qxl/qxl_fb.c 130 131 /* 132 * FIXME 133 * It should not be necessary to have a special dirty() callback for fbdev. 134 */ 135 static int qxlfb_framebuffer_dirty(struct drm_framebuffer *fb, 136 struct drm_file *file_priv, 137 unsigned flags, unsigned color, 138 struct drm_clip_rect *clips, 139 unsigned num_clips) 140 { 141 struct qxl_device *qdev = fb->dev->dev_private; 142 struct fb_info *info = qdev->fb_helper.fbdev; 143 struct qxl_fb_image qxl_fb_image; 144 struct fb_image *image = &qxl_fb_image.fb_image; 145 146 /* TODO: hard coding 32 bpp */ 147 int stride = fb->pitches[0]; 148 149 /* 150 * we are using a shadow draw buffer, at qdev->surface0_shadow 151 */ 152 image->dx = clips->x1; 153 image->dy = clips->y1; 154 image->width = clips->x2 - clips->x1; 155 image->height = clips->y2 - clips->y1; 156 image->fg_color = 0x; /* unused, just to avoid uninitialized 157 warnings */ 158 image->bg_color = 0; 159 image->depth = 32; /* TODO: take from somewhere? */ 160 image->cmap.start = 0; 161 image->cmap.len = 0; 162 image->cmap.red = NULL; 163 image->cmap.green = NULL; 164 image->cmap.blue = NULL; 165 image->cmap.transp = NULL; > 166 image->data = info->screen_base + (clips->x1 * 4) + (stride * > clips->y1); 167 168 qxl_fb_image_init(&qxl_fb_image, qdev, info, NULL); 169 qxl_draw_opaque_fb(&qxl_fb_image, stride); 170 171 return 0; 172 } 173 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH] bochs: convert to drm_fb_helper_fbdev_setup/teardown
Hi Peter, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.19-rc2 next-20180906] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Peter-Wu/bochs-convert-to-drm_fb_helper_fbdev_setup-teardown/20180907-154819 config: i386-randconfig-x006-201835 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from include/asm-generic/bug.h:5:0, from arch/x86/include/asm/bug.h:83, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/mm.h:9, from drivers/gpu/drm/bochs/bochs_drv.c:8: drivers/gpu/drm/bochs/bochs_drv.c: In function 'bochs_pm_suspend': drivers/gpu/drm/bochs/bochs_drv.c:110:15: error: 'struct ' has no member named 'initialized' if (bochs->fb.initialized) { ^ include/linux/compiler.h:58:30: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^~~~ >> drivers/gpu/drm/bochs/bochs_drv.c:110:2: note: in expansion of macro 'if' if (bochs->fb.initialized) { ^~ drivers/gpu/drm/bochs/bochs_drv.c:110:15: error: 'struct ' has no member named 'initialized' if (bochs->fb.initialized) { ^ include/linux/compiler.h:58:42: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^~~~ >> drivers/gpu/drm/bochs/bochs_drv.c:110:2: note: in expansion of macro 'if' if (bochs->fb.initialized) { ^~ drivers/gpu/drm/bochs/bochs_drv.c:110:15: error: 'struct ' has no member named 'initialized' if (bochs->fb.initialized) { ^ include/linux/compiler.h:69:16: note: in definition of macro '__trace_if' __r = !!(cond); \ ^~~~ >> drivers/gpu/drm/bochs/bochs_drv.c:110:2: note: in expansion of macro 'if' if (bochs->fb.initialized) { ^~ drivers/gpu/drm/bochs/bochs_drv.c: In function 'bochs_pm_resume': drivers/gpu/drm/bochs/bochs_drv.c:127:15: error: 'struct ' has no member named 'initialized' if (bochs->fb.initialized) { ^ include/linux/compiler.h:58:30: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^~~~ drivers/gpu/drm/bochs/bochs_drv.c:127:2: note: in expansion of macro 'if' if (bochs->fb.initialized) { ^~ drivers/gpu/drm/bochs/bochs_drv.c:127:15: error: 'struct ' has no member named 'initialized' if (bochs->fb.initialized) { ^ include/linux/compiler.h:58:42: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^~~~ drivers/gpu/drm/bochs/bochs_drv.c:127:2: note: in expansion of macro 'if' if (bochs->fb.initialized) { ^~ drivers/gpu/drm/bochs/bochs_drv.c:127:15: error: 'struct ' has no member named 'initialized' if (bochs->fb.initialized) { ^ include/linux/compiler.h:69:16: note: in definition of macro '__trace_if' __r = !!(cond); \ ^~~~ drivers/gpu/drm/bochs/bochs_drv.c:127:2: note: in expansion of macro 'if' if (bochs->fb.initialized) { ^~ vim +/if +110 drivers/gpu/drm/bochs/bochs_drv.c 0a6659bd Gerd Hoffmann 2013-12-17 @8 #include 0a6659bd Gerd Hoffmann 2013-12-179 #include 0a6659bd Gerd Hoffmann 2013-12-17 10 #include 44adece5 Daniel Vetter 2016-08-10 11 #include 0a6659bd Gerd Hoffmann 2013-12-17 12 0a6659bd Gerd Hoffmann 2013-12-17 13 #include "bochs.h" 0a6659bd Gerd Hoffmann 2013-12-17 14 1acf5661 Max Staudt 2017-01-18 15 static int bochs_modeset = -1; 1acf5661 Max Staudt 2017-01-18 16 module_param_named(modeset, bochs_modeset, int, 0444); 1acf5661 Max Staudt 2017-01-18 17 MODULE_PARM_DESC(modeset, "enable/disable kernel modesetting"); 1acf5661 Max Staudt 2017-01-18 18 0a6659bd Gerd Hoffmann 2013-12-17 19 static bool enable_fbdev = true; 0a6659bd Gerd Hoffmann 2013-12-17 20 module_param_named(fbdev, enable_fbdev, bool, 0444); 0a6659bd Gerd Hoffmann 2013-12-17 21 MODULE_PARM_DESC(fbdev, "register fbdev device"); 0a6659bd Gerd Hoffmann 2013-12-17 22 0a6659bd Gerd Hoffmann 2013-12-17 23 /* -- */ 0a6659bd Gerd Hoffmann 2013-1
Re: [PATCH v3 04/13] fbdev: add remove_conflicting_pci_framebuffers()
Hi MichaĆ, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.19-rc2 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Micha-Miros-aw/remove_conflicting_framebuffers-cleanup/20180903-094322 reproduce: make htmldocs :: branch date: 5 hours ago :: commit date: 5 hours ago All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/linux/srcu.h:175: warning: Function parameter or member 'p' not described in 'srcu_dereference_notrace' include/linux/srcu.h:175: warning: Function parameter or member 'sp' not described in 'srcu_dereference_notrace' include/linux/gfp.h:1: warning: no structured comments found include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4381: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2328: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2328: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:977: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.status_driver_data' not described