Re: [vpp-dev] VPP C API application compilation issue on using S and W functions

[Chinmaya Aggarwal]

Hi Ole,
As suggested by you, we are trying vapi for our SRv6 use case, we were able to 
generate sr.api.json for sr.api using src/tools/vppapigen/generate_json.py. We 
then generated sr.api.vapi.h using src/vpp-api/vapi/vapi_c_gen.py. On going 
through sr.api.vapi.h, we found a function 
*vapi_set_vapi_msg_sr_policies_details_event_cb* (for *sr_policies_details* 
message), at first it seems that it registers a callback function for events, 
but we couldn't figure out what kind of events. Could you please help us 
understand its significance?

Thanks and Regards,
Chinmaya Agarwal.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#16849): https://lists.fd.io/g/vpp-dev/message/16849
Mute This Topic: https://lists.fd.io/mt/75100285/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] name filter fix in 1908

[Andrew Yourtchenko]

Hi Christian,

Ok so given it’s a fix, feel free to cherry-pick into 19.08 without the API 
version change, I will merge it.

--a

> On 30 Jun 2020, at 15:52, Ole Troan  wrote:
> 
> Hi Christian,
> 
> Changing the patch is fine. 
> The only use of version apart from human indications is for the is api 
> experimental or not by checkstyle-api
> Cheers 
> Ole 
> 
>> On 30 Jun 2020, at 15:38, Christian Hopps  wrote:
>> 
>> I noticed that it was the "patch" version number that changed. Semver 
>> claims the patch number indicates backwards compatible changes -- not sure 
>> how VPP API is using the "patch" number though. So when I resolved the 
>> conflict locally after cherry picking I just changed 3.1.1 to 3.1.2 to keep 
>> the spirit of the change. Reverting the version change upstream is another 
>> solution too, if that helps with the API crc/signature stuff. I don't fully 
>> comprehended the VPP API versioning, so better someone else makes that call.
>> 
>> Thanks,
>> Chris.
>> 
 On Jun 30, 2020, at 8:04 AM, Dave Barach (dbarach)  
 wrote:
>>> 
>>> Dear Chris,
>>> 
>>> In looking at the patch, I have a question: the API version number changed 
>>> despite the fact that the API itself was unchanged.
>>> 
>>> Should we revert the API version number bump and then cherry-pick to 19.08?
>>> 
>>> Looping in Ole for an opinion...
>>> 
>>> Thanks... Dave
>>> 
>>> -Original Message-
>>> From: vpp-dev@lists.fd.io  On Behalf Of Christian Hopps
>>> Sent: Tuesday, June 30, 2020 3:10 AM
>>> To: vpp-dev 
>>> Cc: Christian Hopps 
>>> Subject: [vpp-dev] name filter fix in 1908
>>> 
>>> Could this fix: https://gerrit.fd.io/r/c/vpp/+/23140
>>> 
>>> be pulled into stable/1908?
>>> 
>>> It applies clean after adapting the version number change to be compatible 
>>> with 1908 branch.
>>> 
>>> Thanks,
>>> Chris.
>>> 
>> 
> 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#16848): https://lists.fd.io/g/vpp-dev/message/16848
Mute This Topic: https://lists.fd.io/mt/75209217/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] name filter fix in 1908

[Ole Troan]

Hi Christian,

Changing the patch is fine. 
The only use of version apart from human indications is for the is api 
experimental or not by checkstyle-api  
Cheers 
Ole 

> On 30 Jun 2020, at 15:38, Christian Hopps  wrote:
> 
> I noticed that it was the "patch" version number that changed. Semver claims 
> the patch number indicates backwards compatible changes -- not sure how VPP 
> API is using the "patch" number though. So when I resolved the conflict 
> locally after cherry picking I just changed 3.1.1 to 3.1.2 to keep the spirit 
> of the change. Reverting the version change upstream is another solution too, 
> if that helps with the API crc/signature stuff. I don't fully comprehended 
> the VPP API versioning, so better someone else makes that call.
> 
> Thanks,
> Chris.
> 
>> On Jun 30, 2020, at 8:04 AM, Dave Barach (dbarach)  wrote:
>> 
>> Dear Chris,
>> 
>> In looking at the patch, I have a question: the API version number changed 
>> despite the fact that the API itself was unchanged.
>> 
>> Should we revert the API version number bump and then cherry-pick to 19.08?
>> 
>> Looping in Ole for an opinion...
>> 
>> Thanks... Dave
>> 
>> -Original Message-
>> From: vpp-dev@lists.fd.io  On Behalf Of Christian Hopps
>> Sent: Tuesday, June 30, 2020 3:10 AM
>> To: vpp-dev 
>> Cc: Christian Hopps 
>> Subject: [vpp-dev] name filter fix in 1908
>> 
>> Could this fix: https://gerrit.fd.io/r/c/vpp/+/23140
>> 
>> be pulled into stable/1908?
>> 
>> It applies clean after adapting the version number change to be compatible 
>> with 1908 branch.
>> 
>> Thanks,
>> Chris.
>> 
> 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#16847): https://lists.fd.io/g/vpp-dev/message/16847
Mute This Topic: https://lists.fd.io/mt/75209217/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] name filter fix in 1908

[Christian Hopps]

I noticed that it was the "patch" version number that changed. Semver claims 
the patch number indicates backwards compatible changes -- not sure how VPP API 
is using the "patch" number though. So when I resolved the conflict locally 
after cherry picking I just changed 3.1.1 to 3.1.2 to keep the spirit of the 
change. Reverting the version change upstream is another solution too, if that 
helps with the API crc/signature stuff. I don't fully comprehended the VPP API 
versioning, so better someone else makes that call.

Thanks,
Chris.

> On Jun 30, 2020, at 8:04 AM, Dave Barach (dbarach)  wrote:
> 
> Dear Chris,
> 
> In looking at the patch, I have a question: the API version number changed 
> despite the fact that the API itself was unchanged.
> 
> Should we revert the API version number bump and then cherry-pick to 19.08?
> 
> Looping in Ole for an opinion...
> 
> Thanks... Dave
> 
> -Original Message-
> From: vpp-dev@lists.fd.io  On Behalf Of Christian Hopps
> Sent: Tuesday, June 30, 2020 3:10 AM
> To: vpp-dev 
> Cc: Christian Hopps 
> Subject: [vpp-dev] name filter fix in 1908
> 
> Could this fix: https://gerrit.fd.io/r/c/vpp/+/23140
> 
> be pulled into stable/1908?
> 
> It applies clean after adapting the version number change to be compatible 
> with 1908 branch.
> 
> Thanks,
> Chris.
> 



signature.asc
Description: Message signed with OpenPGP
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#16846): https://lists.fd.io/g/vpp-dev/message/16846
Mute This Topic: https://lists.fd.io/mt/75209217/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] classify table, mask flow-label, version, and traffic-class NOT working #classify #vnet

[Dave Barach via lists.fd.io]

Patch on the way, thanks for the report.

From: vpp-dev@lists.fd.io  On Behalf Of mauricio.solisjr 
via lists.fd.io
Sent: Tuesday, June 30, 2020 7:53 AM
To: vpp-dev@lists.fd.io
Subject: [vpp-dev] classify table, mask flow-label, version, and traffic-class 
NOT working #classify #vnet

Hi
I've been trying to add a classify table using the following CLI:
classify table miss-next ip6-node ip6-lookup mask l3 ip6 flow-label

I noticed that in src/vnet/classify/vnet_classify.c the following lines cause 
the function "uword unformat_ip6_mask(...)" to return earlier than expected and 
not take "traffic-class", "flow-label", and "version" as mask l3 ip6 inputs:
 #define _(a) found_something += a;
  
foreach_ip6_proto_field;
 #undef _

  if (found_something == 0)
  return 0;
Even though "flow-label" is "something", we still return 0.

Is this expected behavior? I recompiled and added the following lines above the 
mentioned code in order to avoid the return 0:
found_something += version;   found_something += traffic_class;   
found_something += flow_label;
Regards,
Mauricio
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#16845): https://lists.fd.io/g/vpp-dev/message/16845
Mute This Topic: https://lists.fd.io/mt/75211945/21656
Mute #vnet: https://lists.fd.io/g/fdio+vpp-dev/mutehashtag/vnet
Mute #classify: https://lists.fd.io/g/fdio+vpp-dev/mutehashtag/classify
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] name filter fix in 1908

[Dave Barach via lists.fd.io]

Dear Chris,

In looking at the patch, I have a question: the API version number changed 
despite the fact that the API itself was unchanged.

Should we revert the API version number bump and then cherry-pick to 19.08? 

Looping in Ole for an opinion...

Thanks... Dave 

-Original Message-
From: vpp-dev@lists.fd.io  On Behalf Of Christian Hopps
Sent: Tuesday, June 30, 2020 3:10 AM
To: vpp-dev 
Cc: Christian Hopps 
Subject: [vpp-dev] name filter fix in 1908

Could this fix: https://gerrit.fd.io/r/c/vpp/+/23140

be pulled into stable/1908?

It applies clean after adapting the version number change to be compatible with 
1908 branch.

Thanks,
Chris.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#16844): https://lists.fd.io/g/vpp-dev/message/16844
Mute This Topic: https://lists.fd.io/mt/75209217/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] classify table, mask flow-label, version, and traffic-class NOT working #classify #vnet

[mauricio.solisjr via lists.fd.io]

Hi
I've been trying to add a classify table using the following CLI:
classify table miss-next ip6-node ip6-lookup mask l3 ip6 flow-label

I noticed that in src/vnet/classify/vnet_classify.c the following lines cause 
the function "uword unformat_ip6_mask(...)" to return earlier than expected and 
not take "traffic-class", "flow-label", and "version" as mask l3 ip6 inputs:

> 
> #define _(a) found_something += a;
> 
> foreach_ip6_proto_field (
> https://docs.fd.io/vpp/20.09/dc/d1c/vnet__classify_8c.html#ae2e9794ae2c59b43d0d663617f0ae791
> ) ;
> 
> #undef _
> 
> 
> 
> if (found_something == 0)
> 
> return 0;

Even though "flow-label" is "something", we still return 0.

*Is this expected behavior?* I recompiled and added the following lines above 
the mentioned code in order to avoid the return 0:
> 
> 
> found_something += version;   found_something += traffic_class;  
> found_something += flow_label;

Regards,
Mauricio
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#16843): https://lists.fd.io/g/vpp-dev/message/16843
Mute This Topic: https://lists.fd.io/mt/75211945/21656
Mute #classify: https://lists.fd.io/g/fdio+vpp-dev/mutehashtag/classify
Mute #vnet: https://lists.fd.io/g/fdio+vpp-dev/mutehashtag/vnet
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] name filter fix in 1908

[Christian Hopps]

Could this fix: https://gerrit.fd.io/r/c/vpp/+/23140

be pulled into stable/1908?

It applies clean after adapting the version number change to be compatible with 
1908 branch.

Thanks,
Chris.


signature.asc
Description: Message signed with OpenPGP
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#16842): https://lists.fd.io/g/vpp-dev/message/16842
Mute This Topic: https://lists.fd.io/mt/75209217/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-