I noticed that it was the "patch" version number that changed. Semver claims the patch number indicates backwards compatible changes -- not sure how VPP API is using the "patch" number though. So when I resolved the conflict locally after cherry picking I just changed 3.1.1 to 3.1.2 to keep the spirit of the change. Reverting the version change upstream is another solution too, if that helps with the API crc/signature stuff. I don't fully comprehended the VPP API versioning, so better someone else makes that call.
Thanks, Chris. > On Jun 30, 2020, at 8:04 AM, Dave Barach (dbarach) <[email protected]> wrote: > > Dear Chris, > > In looking at the patch, I have a question: the API version number changed > despite the fact that the API itself was unchanged. > > Should we revert the API version number bump and then cherry-pick to 19.08? > > Looping in Ole for an opinion... > > Thanks... Dave > > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Christian Hopps > Sent: Tuesday, June 30, 2020 3:10 AM > To: vpp-dev <[email protected]> > Cc: Christian Hopps <[email protected]> > Subject: [vpp-dev] name filter fix in 1908 > > Could this fix: https://gerrit.fd.io/r/c/vpp/+/23140 > > be pulled into stable/1908? > > It applies clean after adapting the version number change to be compatible > with 1908 branch. > > Thanks, > Chris. >
signature.asc
Description: Message signed with OpenPGP
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16846): https://lists.fd.io/g/vpp-dev/message/16846 Mute This Topic: https://lists.fd.io/mt/75209217/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
