Re: [vpp-dev] help with review

[Ole Troan via lists.fd.io]

Looks good to me. Merged.

Best regards,
Ole

> On 24 Jan 2023, at 08:55, Stanislav Zaikin  wrote:
> 
> Hello folks,
> 
> Any help with review is much appreciated. Both patches are waiting for quite 
> a long time.
> 
> - https://gerrit.fd.io/r/c/vpp/+/36721
> Short description: "autoendian" was broken for streLaming message types like:
>  service {
>   rpc lcp_itf_pair_get returns lcp_itf_pair_get_reply
> stream lcp_itf_pair_details;
> };
> vppapigen_c.py isn't generating boilerplate (endian handler, json handler, 
> format handler, erc) for such types (both for vpp side and for vapi).
> There's currently also no support for streaming services in VAPI/C++, I have 
> a patch for that, I will send it after this one will be merged (if it will be 
> merged in the end).
> 
> - https://gerrit.fd.io/r/c/vpp/+/36110
> Short description: there is a fast path in "ethernet-input" for whole frames 
> with ETH_INPUT_FRAME_F_SINGLE_SW_IF_IDX flag. The rest input nodes have this 
> snippet to allocate a frame per interface when receiving the packets (at 
> least in dpdk-input and memif-input). I thought it'd be useful to have this 
> fast path for tap interfaces. Theoretically it can be even measured with csit 
> but I didn't succeed at that :)
> 
> -- 
> Best regards
> Stanislav Zaikin
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22497): https://lists.fd.io/g/vpp-dev/message/22497
Mute This Topic: https://lists.fd.io/mt/96493146/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Python VPP_API_DIR

[Ole Troan via lists.fd.io]

Thanks Pim! I also wondered the other day where the env variable had disappeared to. 37792 merged. O. On 12 Dec 2022, at 00:44, Pim van Pelt via lists.fd.io  wrote:Of course, the link is https://gerrit.fd.io/r/c/vpp/+/37791groet,PimOn Mon, Dec 12, 2022 at 12:41 AM Pim van Pelt via lists.fd.io ipng...@lists.fd.io> wrote:Hoi,I am starting to work on a few APIs and noticed that the vpp_papi module's method find_api_dir promises that it will include VPP_API_DIR first, if specified in the environment. It doesn't actually do that.I wrote a changelist that prepends VPP_API_DIR if it exists. This is backwards compatible / benign because it would not have been useful before this change, and folks will not have it in their environment yet. While I'm here, I thought it would be good to make explicit that the 'dirs' argument is meant to be a list (except it is not initialized or checked, so any invocation without dirs=[] will crash)See ssh://pimvanp...@gerrit.fd.io:29418/vpp and please review/merge. Ole are you the Python API maintainer ?-- Pim van Pelt  PBVP1-RIPE - http://www.ipng.nl/



-- Pim van Pelt  PBVP1-RIPE - http://www.ipng.nl/


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22314): https://lists.fd.io/g/vpp-dev/message/22314
Mute This Topic: https://lists.fd.io/mt/95610877/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-