Re: [vpp-dev] Python VPP_API_DIR

Sun, 11 Dec 2022 23:19:47 -0800

Thanks Pim! I also wondered the other day where the env variable had disappeared to. 

37792 merged. 

O. 

On 12 Dec 2022, at 00:44, Pim van Pelt via lists.fd.io <[email protected]> wrote:


Of course, the link is https://gerrit.fd.io/r/c/vpp/+/37791

groet,
Pim

On Mon, Dec 12, 2022 at 12:41 AM Pim van Pelt via lists.fd.io <pim=[email protected]> wrote:
Hoi,

I am starting to work on a few APIs and noticed that the vpp_papi module's method find_api_dir promises that it will include VPP_API_DIR first, if specified in the environment. It doesn't actually do that.
I wrote a changelist that prepends VPP_API_DIR if it exists. This is backwards compatible / benign because it would not have been useful before this change, and folks will not have it in their environment yet. While I'm here, I thought it would be good to make explicit that the 'dirs' argument is meant to be a list (except it is not initialized or checked, so any invocation without dirs=[] will crash)

See ssh://[email protected]:29418/vpp and please review/merge. Ole are you the Python API maintainer ?

--
Pim van Pelt <[email protected]>
PBVP1-RIPE - http://www.ipng.nl/





--
Pim van Pelt <[email protected]>
PBVP1-RIPE - http://www.ipng.nl/



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22314): https://lists.fd.io/g/vpp-dev/message/22314
Mute This Topic: https://lists.fd.io/mt/95610877/21656
Group Owner: [email protected]
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to