Re: [vpp-dev] Discussion Topic: creating demo branches in git.fd.io/vpp

2017-11-15 Thread Ole Troan (otroan)
> The concern would be that without CI you have very limited visibility into 
> the impact of the patches pre-merge.  The automation at fd.io does a *lot* 
> for you…

Absolutely. For the hackathons CI was an order or two of magnitude too slow. 
And we would be doing the testing there and then.
I don’t know how applicable that experience is for someone who’s buildiing a 
demo though.

Cheers,
Ole



> On Wed, Nov 15, 2017 at 3:50 PM Jon Loeliger  wrote:
> On Wed, Nov 15, 2017 at 4:17 PM, Dave Wallace  wrote:
> Folks,
> 
> Per the action item from this yesterday's VPP weekly meeting, I'm asking for 
> opinions from the VPP community on allowing the creation of demo branches in 
> the VPP git repo.
> 
> ...
> 
> 
> Pro: Will allow utilization of LF infra to utilize CI process
> Pro: Will allow publishing of demo artifacts for ease of reproduction of the 
> demo.
> Con: Will pollute repo with ephemeral code that will rapidly become out of 
> date / dead.
> Con: Sets precedent which may cause large numbers of non-production branches 
> over time.
> 
> Please feel add additional Pro/Con comments here.  Comments are welcome from 
> all members of the VPP community.
> 
> Dave,
> 
> In my opinion, creating a cloned fork and adding demo code there would be a
> better approach.  And that demo code will likely become obsolete and bit-rot 
> over time,
> but it will forever be part of the repo.  Over time it will just be dead 
> weight bloat.
> The core code base should remain as a library and not get tied to any 
> specific application.
> 
> HTH,
> jdl
> 

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] jvpp core future test failure (gerrit 8743)

2017-10-13 Thread Ole Troan (otroan)
s/map/dns

if you were to cut and paste.


#define vl_msg_name_crc_list
#include 
#undef vl_msg_name_crc_list

static void
setup_message_id_table (api_main_t * am)
{
#define _(id,n,crc) vl_msg_api_add_msg_name_crc (am, #n "_" #crc, id);
  foreach_vl_msg_name_crc_dns;
#undef _
}

Ole

On 13 Oct 2017, at 19:46, Ole Troan mailto:otr...@cisco.com>> 
wrote:

Dear Dave,

I wonder if you forgot to hookup the messages in the CRC dictionary?

#define vl_msg_name_crc_list
#include 
#undef vl_msg_name_crc_list

static void
setup_message_id_table (api_main_t * am)
{
#define _(id,n,crc) vl_msg_api_add_msg_name_crc (am, #n "_" #crc, id);
  foreach_vl_msg_name_crc_map;
#undef _
}

If my guess is correct, I’’ have a chat with the Java guys if we can come up 
with a slightly more user-friendly error message. ;-)

Best regards,
Ole


On 13 Oct 2017, at 19:31, Dave Barach (dbarach) 
mailto:dbar...@cisco.com>> wrote:

Dear Ole,

See https://gerrit.fd.io/r/#/c/8743. It turns out that the java core future 
“make test” test fails as shown below.

The patch adds three xxx_reply_t binary api messages. See 
.../src/vnet/dns/dns.api.

It sure looks like the Java code knows about them, but isn’t doing a very good 
job of registering them. Note that I had to modify the binary API client 
library to keep Java from ASSERTing due to the NULL msg id’s squawked below.

What’s going on here? These messages work like a champ in vpp_api_test...

INFO: Testing Java future API for core plugin
[New Thread 0x7fffd5f9c700 (LWP 4611)]
vl_msg_api_config:671: Trying to register dns_enable_disable_reply with a NULL 
msg id!
vl_msg_api_config:671: Trying to register dns_name_server_add_del_reply with a 
NULL msg id!
vl_msg_api_config:671: Trying to register dns_resolve_name_reply with a NULL 
msg id!
[Thread 0x7fffd5f9c700 (LWP 4611) exited]
Exception in thread "main" java.lang.IllegalStateException: API mismatch 
detected: dns_resolve_name_reply_451ab6c0 is missing
 at io.fd.vpp.jvpp.core.JVppCoreImpl.init0(Native Method)
 at io.fd.vpp.jvpp.core.JVppCoreImpl.init(JVppCoreImpl.java:75)
 at io.fd.vpp.jvpp.JVppRegistryImpl.register(JVppRegistryImpl.java:72)
 at 
io.fd.vpp.jvpp.core.future.FutureJVppCoreFacade.(FutureJVppCoreFacade.java:25)
 at 
io.fd.vpp.jvpp.core.test.FutureApiTest.testFutureApi(FutureApiTest.java:50)
 at io.fd.vpp.jvpp.core.test.FutureApiTest.main(FutureApiTest.java:44)
[New Thread 0x7fffd54af700 (LWP 4612)]

Thanks… Dave


___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] jvpp core future test failure (gerrit 8743)

2017-10-13 Thread Ole Troan (otroan)
Dear Dave,

I wonder if you forgot to hookup the messages in the CRC dictionary?

#define vl_msg_name_crc_list
#include 
#undef vl_msg_name_crc_list

static void
setup_message_id_table (api_main_t * am)
{
#define _(id,n,crc) vl_msg_api_add_msg_name_crc (am, #n "_" #crc, id);
  foreach_vl_msg_name_crc_map;
#undef _
}

If my guess is correct, I’’ have a chat with the Java guys if we can come up 
with a slightly more user-friendly error message. ;-)

Best regards,
Ole


On 13 Oct 2017, at 19:31, Dave Barach (dbarach) 
mailto:dbar...@cisco.com>> wrote:

Dear Ole,

See https://gerrit.fd.io/r/#/c/8743. It turns out that the java core future 
“make test” test fails as shown below.

The patch adds three xxx_reply_t binary api messages. See 
.../src/vnet/dns/dns.api.

It sure looks like the Java code knows about them, but isn’t doing a very good 
job of registering them. Note that I had to modify the binary API client 
library to keep Java from ASSERTing due to the NULL msg id’s squawked below.

What’s going on here? These messages work like a champ in vpp_api_test...

INFO: Testing Java future API for core plugin
[New Thread 0x7fffd5f9c700 (LWP 4611)]
vl_msg_api_config:671: Trying to register dns_enable_disable_reply with a NULL 
msg id!
vl_msg_api_config:671: Trying to register dns_name_server_add_del_reply with a 
NULL msg id!
vl_msg_api_config:671: Trying to register dns_resolve_name_reply with a NULL 
msg id!
[Thread 0x7fffd5f9c700 (LWP 4611) exited]
Exception in thread "main" java.lang.IllegalStateException: API mismatch 
detected: dns_resolve_name_reply_451ab6c0 is missing
 at io.fd.vpp.jvpp.core.JVppCoreImpl.init0(Native Method)
 at io.fd.vpp.jvpp.core.JVppCoreImpl.init(JVppCoreImpl.java:75)
 at io.fd.vpp.jvpp.JVppRegistryImpl.register(JVppRegistryImpl.java:72)
 at 
io.fd.vpp.jvpp.core.future.FutureJVppCoreFacade.(FutureJVppCoreFacade.java:25)
 at 
io.fd.vpp.jvpp.core.test.FutureApiTest.testFutureApi(FutureApiTest.java:50)
 at io.fd.vpp.jvpp.core.test.FutureApiTest.main(FutureApiTest.java:44)
[New Thread 0x7fffd54af700 (LWP 4612)]

Thanks… Dave

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] plugins/flowprobe vs. vnet/flow

2017-06-16 Thread otroan
the Choonho,

> flowprobe and flow looks like ipfix.
> What is difference?

in short, src/vnet/flow is the "exporting process" and src/plugins/flowprobe is 
the "metering process".

flowprobe supports stateful L2, IP4, IP6 flows with reporting of L2, L3 and L4 
information.

the exporter only supports UDP/IP4 at the moment.

There are other metering processes as well. E.g. SNAT and IOAM.

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] ALG

2017-06-16 Thread otroan
Hi Denis,

> Today we are testing SNAT plugin and PPTP connection by public ip and this is 
> not working.
> Both machines have a static mapping, we are testing pptp by snat hairpin.
> Even if one machine (in outside VPP netwrok) can trying to connect to machine 
> in inside VPP network (with static mapping by public ip) - connection lost.
> To be sure, we are testing this connection by local ips and this works.
> Also, we are testing another two protocols - RTSP and L2TP and this works 
> fine...

And you do have a static mapping on SNAT as well?
https://wiki.fd.io/view/VPP/SNAT#1:1_NAT_example

Cause if you used NAPT, then this wouldn't work, given that PPTP is GRE(-ish).

Cheers,
Ole



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] 17.04 dot releases not pushed to Nexus

2017-06-16 Thread otroan
Hi Billy,

> I noticed that 17.04.1 and 17.04.2 releases were not pushed to Nexus (or I'm 
> looking in the wrong spot). I think they should be but was wondering if there 
> was a reason they weren't.
> 
> Example:
>
> https://nexus.fd.io/content/repositories/fd.io.ubuntu.xenial.main/io/fd/vpp/vpp/
>https://nexus.fd.io/content/repositories/fd.io.centos7/io/fd/vpp/vpp/

The reason is that I haven't pushed the button. Will do so ASAP.

(Which was caused by me waiting for some better processes around that button 
press. I ended up writing a small script to fill in the email template to LF).

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] plugins/flowprobe vs. vnet/flow

2017-06-16 Thread otroan
> the Choonho,

s/the/Dear//
:-)

> 
>> flowprobe and flow looks like ipfix.
>> What is difference?
> 
> in short, src/vnet/flow is the "exporting process" and src/plugins/flowprobe 
> is the "metering process".
> 
> flowprobe supports stateful L2, IP4, IP6 flows with reporting of L2, L3 and 
> L4 information.
> 
> the exporter only supports UDP/IP4 at the moment.
> 
> There are other metering processes as well. E.g. SNAT and IOAM.
> 
> Best regards,
> Ole



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] ALG

2017-06-14 Thread otroan
Hi Denis,

> We are trying to test SIP to asterisk (which outside VPP network) port 5060 
> UDP and its work normaly via SNAT plugin (static and dynamic nat working 
> well).Also we are trying to test SIP to yate (minimal sip server) inside VPP 
> network with SNAT hairpin and its work correctly too. And also we are 
> connected to yate from outside VPP network, this simply works! :-)
> 
> Also we are testing FTP client from Internet Explorer Windows 10 and IRC 
> client they are works well too.

That's cool!

> After that testing we need only PPTP protocol via S-NAT plugin, which not 
> work today.

I guess I need to read up on PPTP (sigh).
Does the protocol work through a 1:1 NAT today?

If so... what's the size of your external IPv4 pool?

Are you able to perform some measurements of the number of PPTP sessions?
Or rather the number of sessions you have which are not UDP, TCP. And sort them 
IP src, dst and protocol?

The question I want to answer is. How big must the external IPv4 pool be, for a 
transport layer independent NAT to function.
E.g. if all your PPTP sessions goes to _different_ destination addresses, a 
single IPv4 address works fine.
But if a larger number than the number of source addresses PPTP sessions go to 
the _same_ destination address we would be in trouble.

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] VPP API improvements - community discussion.

2017-06-13 Thread otroan
Jon,

> I don't know about user friendly; I can wade through the technical details.
> 
> I think one thing that is annoying about the API is a lack of consistency.
> Here are some examples:
> 
>- Sometimes the flag is "u8 is_ipv4", other times it is "u8 is_ipv6".
>- Sometimes the flag is "u8 is_ip4", other times it is "u8 is_ip6".

Annoying indeed.
For these one suggestion has been to remove them and instead use address/prefix 
types that have address-family included.

>- Sometimes the flag is "u8 is_add", or "u8 is_del", or "u32 is_add".

if we want something like a CRUD API, it might be better to have separate 
_delete messages.
Often they don't have same parameters like the _add. Opinions?

>- "is_enable" vs "is_enabled"
>- Some API calls are "foo_add_del", some are "foo_add_replace",
>  and some are "foo_add" and "foo_del"

Yep. Good if we could agree on one convention here.

> I know that sounds trivial.  I get that.  But it makes for tough anticipation
> and violates some principle of least-surprise-or-another.

Agree. I think this inconsistency just adds confusion and irritation too.

> 
> I get that different people work on different areas, but there needs to
> be some consistency both in the names of the API calls and within
> the API fields themselves.
> 
> It would be documentationally nice for the API comment blocks to
> explicitly denote what default values pertain to the fields of an API call.
> Similarly, denote what the values of the "invalid" entry are.  Is it 0?
> Or is it -1 or is it ~0?

Yes, I have also seen people want to add enums and perhaps do constants for 
these.

Cheers,
Ole



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] ALG

2017-06-13 Thread otroan
Denis,

> Hi! Im working on Internet service provider, and ALG require for clients 
> which connected to their offices via pptp, sip, etc.
> But current SNAT plugin in master (build #2482) doesnt support pptp proto 
> inside (maybe sip also).

Yeah, don't use PPTP. Insecure and broken.
SIP applications must use ICE.

I'm sure whomever is using PPTP is looking for an excuse to move away from that 
protocol. ;-)

Best regards,
Ole



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] How to get interface stats using python api?

2017-06-13 Thread otroan
Weitao,

> I noticed that in interface.api.
> 
> manual_print manual_endian define vnet_interface_combined_counters
> {
>   /* enums - plural - in vnet/interface.h */
>   u8 vnet_counter_type;
>   u32 first_sw_if_index;
>   u32 count;
>   vl_api_vlib_counter_t data[count];
> };
> 
> 
> Should vl_api_vlib_counter_t be u64? Is that right?

interface.api:
typeonly manual_print manual_endian define vlib_counter
{
  u64 packets;  /**< packet counter */
  u64 bytes;/**< byte counter  */
};

Cheers,
Ole


> 2017-06-13 18:56 GMT+08:00 :
> Hi again,
> 
> > I tried the method you told me, but the data that I got is '\x00'.
> >
> > Like this, vnet_interface_counters(_0=49, vnet_counter_type=1, 
> > is_combined=1, first_sw_if_index=0, count=7, 
> > data='\x00\x00\x00\x00\x00\x00\x00')
> >
> > I don't why this happened.
> 
> Ah, yes sorry. Forgot to tell you that it was broken prior to below commit.
> 
> You need:
> 
> commit ee551988bcce08ad7a15f71fb9d2239b4239ab08
> Author: Aloys Augustin 
> Date:   Fri Feb 17 14:55:29 2017 +0100
> 
> Fix vnet_interface_counters API definition
> 
> The api specification had u8 as data type, which caused the python
> binding to fail.
> Fixes VPP-642
> 
> Change-Id: I9ba97959740d44c8f4a12db9356d0d1bcd709a73
> Signed-off-by: Aloys Augustin 
> Signed-off-by: Ole Troan 
> 
> 
> And that changes vnet_interface_counters to a simple and a combined counters 
> version.
> 
> Sorry, for trickle feeding you information, my brain trashed in the middle of 
> the context switch. ;-)
> 
> Feel free to put something on the wiki as you go along.
> 
> Best regards,
> Ole
> 



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] How to get interface stats using python api?

2017-06-13 Thread otroan
Hi again,

> I tried the method you told me, but the data that I got is '\x00'.
> 
> Like this, vnet_interface_counters(_0=49, vnet_counter_type=1, is_combined=1, 
> first_sw_if_index=0, count=7, data='\x00\x00\x00\x00\x00\x00\x00')
> 
> I don't why this happened.

Ah, yes sorry. Forgot to tell you that it was broken prior to below commit.

You need:

commit ee551988bcce08ad7a15f71fb9d2239b4239ab08
Author: Aloys Augustin 
Date:   Fri Feb 17 14:55:29 2017 +0100

Fix vnet_interface_counters API definition

The api specification had u8 as data type, which caused the python
binding to fail.
Fixes VPP-642

Change-Id: I9ba97959740d44c8f4a12db9356d0d1bcd709a73
Signed-off-by: Aloys Augustin 
Signed-off-by: Ole Troan 


And that changes vnet_interface_counters to a simple and a combined counters 
version.

Sorry, for trickle feeding you information, my brain trashed in the middle of 
the context switch. ;-)

Feel free to put something on the wiki as you go along.

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] How to get interface stats using python api?

2017-06-13 Thread otroan
Hello,

> How to get interface stats using python api?
> For example, I want to know "GigabitEthernete/0/1" rx packets, what shoud I 
> do?

You register for stats with the want_stats call.
Before that you must register an event handler with VPP.register_event_callback

Then that callback will be called periodically with the stats messages.
VL_API_VNET_INTERFACE_COUNTERS, VL_API_VNET_IP6_FIB_COUNTERS and 
VL_API_VNET_IP4_FIB_COUNTERS if I remember correctly.

Ping me if you need more help.

Cheers,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] VPP Node Debug

2017-06-06 Thread otroan
Alessio,

> when you say
> 
> "You need to also start VPP with:
> punt { socket }"
> 
> do you mean to insert the above line in the /etc/vpp/startup.conf  ?

yes, you can do that.
or you can start VPP in the root build directory with: make run
and set the environment variable STARTUP_CONF to point to the configuration 
file.

my startup configuration looks like:

unix { interactive startup-config vpe.conf }
api-segment {  uid otroan gid otroan }
punt { socket /tmp/puntsocket}
plugins {
plugin dpdk_plugin.so { disable }
}

> What about the socket. Should I bind it to the NIC I am using for vpp or it 
> is a generic socket?

The punt socket is a Unix domain socket. SOCK_DGRAM.

> Thanks for the help. In case I will let it work I guess I will publish a 
> guide on it explaining all the trouble I passed through.

Great!

Best regards,
Ole

> 
> On Tue, Jun 6, 2017 at 10:19 AM,  wrote:
> Hi Alessio,
> 
> If you want to extend what I did (with the punt socket.
> 
> You need to also start VPP with:
> punt { socket }
> 
> Then you should see the print messages you added in on the VPP console / cli.
> 
> Best regards,
> Ole
> 
> > On 5 Jun 2017, at 19:49, Alessio Silvestro  wrote:
> >
> > Dear Ole,
> >
> > In order to avoid problems with vagrant, I installed VPP on ubuntu server 
> > 16.04.
> >
> > I start vpp with the command! $ sudo vpp unix interactive.
> >
> > After configuring correctly the interface I do $ set punt udp  in order 
> > to accept UDP traffic on the port .
> >
> > When I send 1 UDP packet I see the following trace:
> >
> > "
> >
> > vpp# show trace
> >
> > --- Start of thread 0 vpp_main ---
> >
> > Packet 1
> >
> > 00:00:49:978247: dpdk-input
> >
> >   GigabitEthernet0/9/0 rx queue 0
> >
> >   buffer 0x4db5: current data 14, length 46, free-list 0, clone-count 0, 
> > totlen-nifb 0, trace 0x0
> >
> >   PKT MBUF: port 0, nb_segs 1, pkt_len 60
> >
> > buf_len 2176, data_len 60, ol_flags 0x0, data_off 128, phys_addr 
> > 0x8ec36d80
> >
> > packet_type 0x0
> >
> >   IP4: 08:00:27:42:3e:65 -> 08:00:27:93:9a:be
> >
> >   UDP: 172.28.128.6 -> 172.28.128.5
> >
> > tos 0x00, ttl 64, length 35, checksum 0x49dc
> >
> > fragment id 0x98a9, flags DONT_FRAGMENT
> >
> >   UDP: 47743 -> 
> >
> > length 15, checksum 0x8a50
> >
> > 00:00:49:978287: ip4-input
> >
> >   UDP: 172.28.128.6 -> 172.28.128.5
> >
> > tos 0x00, ttl 64, length 35, checksum 0x49dc
> >
> > fragment id 0x98a9, flags DONT_FRAGMENT
> >
> >   UDP: 47743 -> 
> >
> > length 15, checksum 0x8a50
> >
> > 00:00:49:978292: ip4-lookup
> >
> >   fib 0 dpo-idx 6 flow hash: 0x
> >
> >   UDP: 172.28.128.6 -> 172.28.128.5
> >
> > tos 0x00, ttl 64, length 35, checksum 0x49dc
> >
> > fragment id 0x98a9, flags DONT_FRAGMENT
> >
> >   UDP: 47743 -> 
> >
> > length 15, checksum 0x8a50
> >
> > 00:00:49:978297: ip4-local
> >
> > UDP: 172.28.128.6 -> 172.28.128.5
> >
> >   tos 0x00, ttl 64, length 35, checksum 0x49dc
> >
> >   fragment id 0x98a9, flags DONT_FRAGMENT
> >
> > UDP: 47743 -> 
> >
> >   length 15, checksum 0x8a50
> >
> > 00:00:49:978299: ip4-udp-lookup
> >
> >   UDP: src-port 47743 dst-port 
> >
> > 00:00:49:978302: error-punt
> >
> >   ip4-udp-punt: udp port punt
> >
> > "
> >
> > which to me looks like the UDP traffic has been correctly received.
> >
> > My goal is to modify your code, which is at $TOPDIR/vpp/src/vnet/ip/punt.c, 
> > in order to start and understand how to deploy new code with VPP.
> >
> > I inserted several clib_warning("I am here") in the code. Then I run 
> > $TOPDIR/vpp make build-release to compile the new code. However, even if I 
> > am pretty sure the your code runs because of the trace above, I cannot see 
> > any output in /var/log/syslog as suggested by Chris nor in the console (I 
> > run with unix interactive).
> >
> > Do you have any idea why I cannot see any message in the log and/or how I 
> > can modify/debug your code with some prints and look at them somewhere?
> >
> > Thanks for the help.
> >
> > Best regards,
> > Alessio
> >
> >
> >
> > On Fri, Jun 2

Re: [vpp-dev] VPP Node Debug

2017-06-06 Thread otroan
Hi Alessio,

If you want to extend what I did (with the punt socket.

You need to also start VPP with:
punt { socket }

Then you should see the print messages you added in on the VPP console / cli.

Best regards,
Ole

> On 5 Jun 2017, at 19:49, Alessio Silvestro  wrote:
> 
> Dear Ole,
> 
> In order to avoid problems with vagrant, I installed VPP on ubuntu server 
> 16.04.
> 
> I start vpp with the command! $ sudo vpp unix interactive.
> 
> After configuring correctly the interface I do $ set punt udp  in order 
> to accept UDP traffic on the port .
> 
> When I send 1 UDP packet I see the following trace:
> 
> "
> 
> vpp# show trace
> 
> --- Start of thread 0 vpp_main ---
> 
> Packet 1
> 
> 00:00:49:978247: dpdk-input
> 
>   GigabitEthernet0/9/0 rx queue 0
> 
>   buffer 0x4db5: current data 14, length 46, free-list 0, clone-count 0, 
> totlen-nifb 0, trace 0x0
> 
>   PKT MBUF: port 0, nb_segs 1, pkt_len 60
> 
> buf_len 2176, data_len 60, ol_flags 0x0, data_off 128, phys_addr 
> 0x8ec36d80
> 
> packet_type 0x0
> 
>   IP4: 08:00:27:42:3e:65 -> 08:00:27:93:9a:be
> 
>   UDP: 172.28.128.6 -> 172.28.128.5
> 
> tos 0x00, ttl 64, length 35, checksum 0x49dc
> 
> fragment id 0x98a9, flags DONT_FRAGMENT
> 
>   UDP: 47743 -> 
> 
> length 15, checksum 0x8a50
> 
> 00:00:49:978287: ip4-input
> 
>   UDP: 172.28.128.6 -> 172.28.128.5
> 
> tos 0x00, ttl 64, length 35, checksum 0x49dc
> 
> fragment id 0x98a9, flags DONT_FRAGMENT
> 
>   UDP: 47743 -> 
> 
> length 15, checksum 0x8a50
> 
> 00:00:49:978292: ip4-lookup
> 
>   fib 0 dpo-idx 6 flow hash: 0x
> 
>   UDP: 172.28.128.6 -> 172.28.128.5
> 
> tos 0x00, ttl 64, length 35, checksum 0x49dc
> 
> fragment id 0x98a9, flags DONT_FRAGMENT
> 
>   UDP: 47743 -> 
> 
> length 15, checksum 0x8a50
> 
> 00:00:49:978297: ip4-local
> 
> UDP: 172.28.128.6 -> 172.28.128.5
> 
>   tos 0x00, ttl 64, length 35, checksum 0x49dc
> 
>   fragment id 0x98a9, flags DONT_FRAGMENT
> 
> UDP: 47743 -> 
> 
>   length 15, checksum 0x8a50
> 
> 00:00:49:978299: ip4-udp-lookup
> 
>   UDP: src-port 47743 dst-port 
> 
> 00:00:49:978302: error-punt
> 
>   ip4-udp-punt: udp port punt
> 
> "
> 
> which to me looks like the UDP traffic has been correctly received.
> 
> My goal is to modify your code, which is at $TOPDIR/vpp/src/vnet/ip/punt.c, 
> in order to start and understand how to deploy new code with VPP.
> 
> I inserted several clib_warning("I am here") in the code. Then I run 
> $TOPDIR/vpp make build-release to compile the new code. However, even if I am 
> pretty sure the your code runs because of the trace above, I cannot see any 
> output in /var/log/syslog as suggested by Chris nor in the console (I run 
> with unix interactive).
> 
> Do you have any idea why I cannot see any message in the log and/or how I can 
> modify/debug your code with some prints and look at them somewhere?
> 
> Thanks for the help.
> 
> Best regards,
> Alessio
> 
> 
> 
> On Fri, Jun 2, 2017 at 4:48 PM,  wrote:
> Alessio,
> 
> Run in the foreground with unix { interactive }.
> And directly from a the build directory.
> The vagrant stuff is mostly useful for demo and first look. Sounds like you 
> really want to do some development.
> 
> Cheers,
> Ole
> 
> > On 2 Jun 2017, at 13:31, Alessio Silvestro  wrote:
> >
> > I am running the vagrant machine provided, so I run on Ubuntu 16.04.02 TLS.
> >
> > I tried clib_warning(), clib_unix_warning(), clib_error() and 
> > clib_unix_error().
> >
> > I inserted that line in both vvp/src/vnet/ip/punt.c and 
> > vpp/src/vnet/ip/ip4_forward.c  in order to be sure that the packet was 
> > actually reaching the node.
> >
> > However, there is no sign in /var/log/syslog or anywhere else I can think 
> > of about that message
> >
> > Are you sure there is no other place where they can be printed?
> >
> > Thanks for the cooperation,
> > Alessio
> >
> > On Thu, Jun 1, 2017 at 7:26 PM, John Lo (loj)  wrote:
> > The output of clib_warning() call should be in the syslog. If running vpp 
> > in Ubuntu, take a look in /var/log/syslog.  -John
> >
> >
> >
> > From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
> > Behalf Of Alessio Silvestro
> > Sent: Thursday, June 01, 2017 12:11 PM
> > To: Luke, Chris 
> > Cc: vpp-dev@lists.fd.io
> > Subject: Re: [vpp-dev] VPP Node Debug
> >
> >
> >
> > I knew VPP run in user space and that printk is not the best option, 
> > however from the documentation it is not clear to me how to do that.
> >
> >
> >
> > For example now I inserted the command clib_warning("I am here!") in the 
> > node I create -- that from vppctl show trace I can see processes the 
> > packets.
> >
> >
> >
> > Where does it prints?
> >
> >
> >
> > Still I cannot figure it out.
> >
> >
> >
> > Thanks,
> >
> > Alessio
> >
> >
> >
> > On Thu, Jun 1, 2017 at 6:00 PM, Luke, Chris  wrote:
> >
> > printk() is typically a kernel thing, no? This isn’t ker

Re: [vpp-dev] VPP Node Debug

2017-06-02 Thread otroan
Alessio,

Run in the foreground with unix { interactive }.
And directly from a the build directory.
The vagrant stuff is mostly useful for demo and first look. Sounds like you 
really want to do some development.

Cheers,
Ole

> On 2 Jun 2017, at 13:31, Alessio Silvestro  wrote:
> 
> I am running the vagrant machine provided, so I run on Ubuntu 16.04.02 TLS.
> 
> I tried clib_warning(), clib_unix_warning(), clib_error() and 
> clib_unix_error().
> 
> I inserted that line in both vvp/src/vnet/ip/punt.c and 
> vpp/src/vnet/ip/ip4_forward.c  in order to be sure that the packet was 
> actually reaching the node.
> 
> However, there is no sign in /var/log/syslog or anywhere else I can think of 
> about that message
> 
> Are you sure there is no other place where they can be printed?
> 
> Thanks for the cooperation,
> Alessio
> 
> On Thu, Jun 1, 2017 at 7:26 PM, John Lo (loj)  wrote:
> The output of clib_warning() call should be in the syslog. If running vpp in 
> Ubuntu, take a look in /var/log/syslog.  -John
> 
> 
> 
> From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
> Behalf Of Alessio Silvestro
> Sent: Thursday, June 01, 2017 12:11 PM
> To: Luke, Chris 
> Cc: vpp-dev@lists.fd.io
> Subject: Re: [vpp-dev] VPP Node Debug
> 
> 
> 
> I knew VPP run in user space and that printk is not the best option, however 
> from the documentation it is not clear to me how to do that.
> 
> 
> 
> For example now I inserted the command clib_warning("I am here!") in the node 
> I create -- that from vppctl show trace I can see processes the packets.
> 
> 
> 
> Where does it prints?
> 
> 
> 
> Still I cannot figure it out.
> 
> 
> 
> Thanks,
> 
> Alessio
> 
> 
> 
> On Thu, Jun 1, 2017 at 6:00 PM, Luke, Chris  wrote:
> 
> printk() is typically a kernel thing, no? This isn’t kernel code. 😊
> 
> 
> 
> If you just want stuff on the console when running in a debugger, or 
> interactively, clib_warning() may be what you are looking for.
> 
> 
> 
> Chris.
> 
> 
> 
> 
> 
> From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
> Behalf Of Alessio Silvestro
> Sent: Thursday, June 1, 2017 10:35
> To: vpp-dev@lists.fd.io
> Subject: [vpp-dev] VPP Node Debug
> 
> 
> 
> Hi all,
> 
> 
> 
> I am using this code "https://gerrit.fd.io/r/#/c/6721/"; to in order to enable 
> an external process to receive UDP packets.
> 
> 
> 
> I tried to use printk -- including module.h in the c file.
> 
> 
> 
> When I compile VPP with:
> 
> 
> 
> TOPDIR/vpp make build-release
> 
> 
> 
> I got the following error
> 
> 
> 
> fatal error: linux/module.h: No such file or directory
> 
> compilation terminated.
> 
> 
> 
> Do you have any idea why?
> 
> 
> 
> Is there a better way to debug the code of a node in VPP?
> 
> 
> 
> Thanks,
> 
> Alessio
> 
> 
> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] VPP Node Debug

2017-06-01 Thread otroan
Alessio,

you may start VPP with the unix {interactive} options too...
e.g. put that line in the configuration file pointed to by STARTUP_CONF 
environment variable (see make help).
then do "make run" or "make debug".

please let me know your success with the punt socket feature. it is a little 
experimental.

Best regards,
Ole

> On 1 Jun 2017, at 18:10, Alessio Silvestro  wrote:
> 
> I knew VPP run in user space and that printk is not the best option, however 
> from the documentation it is not clear to me how to do that.
> 
> For example now I inserted the command clib_warning("I am here!") in the node 
> I create -- that from vppctl show trace I can see processes the packets.
> 
> Where does it prints?
> 
> Still I cannot figure it out.
> 
> Thanks,
> Alessio
> 
> On Thu, Jun 1, 2017 at 6:00 PM, Luke, Chris  wrote:
> printk() is typically a kernel thing, no? This isn’t kernel code. 😊
> 
> 
> 
> If you just want stuff on the console when running in a debugger, or 
> interactively, clib_warning() may be what you are looking for.
> 
> 
> 
> Chris.
> 
> 
> 
> 
> 
> From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
> Behalf Of Alessio Silvestro
> Sent: Thursday, June 1, 2017 10:35
> To: vpp-dev@lists.fd.io
> Subject: [vpp-dev] VPP Node Debug
> 
> 
> 
> Hi all,
> 
> 
> 
> I am using this code "https://gerrit.fd.io/r/#/c/6721/"; to in order to enable 
> an external process to receive UDP packets.
> 
> 
> 
> I tried to use printk -- including module.h in the c file.
> 
> 
> 
> When I compile VPP with:
> 
> 
> 
> TOPDIR/vpp make build-release
> 
> 
> 
> I got the following error
> 
> 
> 
> fatal error: linux/module.h: No such file or directory
> 
> compilation terminated.
> 
> 
> 
> Do you have any idea why?
> 
> 
> 
> Is there a better way to debug the code of a node in VPP?
> 
> 
> 
> Thanks,
> 
> Alessio
> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] VPP & UDP Traffic

2017-05-30 Thread otroan
Alessio,

I also did an experimental patch to drop chosen UDP packets to a UDS socket.
https://gerrit.fd.io/r/#/c/6721/

Currently being used for integration with DHCPKIT.

Cheers,
Ole

> On 30 May 2017, at 19:37, Florin Coras  wrote:
> 
> Hi Alessio,
> 
> Take a look at udp_register_dst_port () and at how it is used in other places 
> (e.g., lisp/vxlan).
> 
> Cheers,
> Florin
> 
>> On May 30, 2017, at 1:01 AM, Alessio Silvestro  
>> wrote:
>> 
>> Dear all,
>> 
>> I am currently working on VPP and I am interested in receiving UDP traffic 
>> at a specific port.
>> 
>> However, I have seen that the project regarding L4 protocols (e.g., TCP, 
>> UDP) namely TLDK (Transport Layer Development Kit), is still a project 
>> proposal.
>> 
>> Is there a simple way to listen to UDP traffic on the current VPP 
>> implementation -- considering that UDP does not need any special treatment 
>> (e.g., re-ordering, sequence number, etc.)?
>> 
>> Thanks for any help!
>> 
>> Best regards,
>> Alessio
>> ___
>> vpp-dev mailing list
>> vpp-dev@lists.fd.io
>> https://lists.fd.io/mailman/listinfo/vpp-dev
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] [Fds-dev] Does VPP support vlan 0?

2017-05-30 Thread otroan
Juraj,

> That's how I understand it. Doesn't that mean it should work without the 
> subinterface?
> 
> Configuring the sub-interface obviously works. I'm just confused about how 
> vpp handles this. For example, I don't need to configure sub-interface for 
> vlan 0 for linux interfaces - the packet doesn't get dropped.

I _think_ correct behaviour for RX on a routed interface is that the VLAN 0 tag 
should be ignored. And that you shouldn't need a subinterface in this case. If 
we require a subinterface, then we cannot receive tagged with 0 and untagged 
traffic on the same interface. Something I believe we have to do, if we want to 
be compliant for this case.

Open a JIRA?

Best regards,
Ole



> 
> Juraj
> 
> From: Wojciech Dec (wdec)
> Sent: Monday, 29 May, 2017 15:47
> To: Juraj Linkes -X (jlinkes - PANTHEON TECHNOLOGIES at Cisco) 
> ; John Lo (loj) ; vpp-dev@lists.fd.io
> Cc: fds-...@lists.opnfv.org
> Subject: Re: [Fds-dev] Does VPP support vlan 0?
> 
> A frame with VLAN 0 means “I’m on the default VLAN” and “here are my PCP 
> bits”.
> As John suggested, would be good to ry setting a sub-interface for 0.
> 
> Regards,
> -Wojciech.
> 
> 
> From:  on behalf of "Juraj Linkes -X 
> (jlinkes - PANTHEON TECHNOLOGIES at Cisco)" 
> Date: Monday, 29 May 2017 at 15:08
> To: "John Lo (loj)" , "vpp-dev@lists.fd.io" 
> 
> Cc: "fds-...@lists.opnfv.org" 
> Subject: Re: [Fds-dev] Does VPP support vlan 0?
> 
> Hi John,
> 
> UCS-B's drivers apparently send vlan 0 in native vlan. I'm just pointing out 
> that vpp treats vlan id 0 as a vlan when vlan 0 means it's not a vlan (if I 
> understand the IEEE Std 802.1Q correctly). Or am I missing something?
> 
> Thanks,
> Juraj
> 
> From: John Lo (loj)
> Sent: Thursday, 25 May, 2017 16:12
> To: Juraj Linkes -X (jlinkes - PANTHEON TECHNOLOGIES at Cisco) 
> ; vpp-dev@lists.fd.io
> Cc: Tomas Cechvala -X (tcechval - PANTHEON TECHNOLOGIES at Cisco) 
> ; fds-...@lists.opnfv.org
> Subject: RE: Does VPP support vlan 0?
> 
> Hi Juraj,
> 
> For an interface in L3 mode, any packet received with a VLAN tag must match a 
> sub-interface setup to expect that VLAN tag value. A way to handle this may 
> be to create a sub-interface matching VLAN 0, such as:
> 
> DBGvpp# create sub tuntap-0 0
> tuntap-0.0
> DBGvpp# sho int
>   Name   Idx   State  Counter  
> Count
> GigabitEthernet1b/0/0 3 up   rx packets   
>   44630
>  rx bytes 
> 4528252
>  tx packets   
>3105
>  tx bytes 
>  480292
>  drops
>   20672
>  punts
> 373
>  ip4  
>   23551
> GigabitEthernet4/0/0  2 up   rx packets   
>3070
>  rx bytes 
>  325990
>  tx packets   
>   23549
>  tx bytes 
> 2085942
>  drops
>  16
> local00down
> tuntap-0  1 up   tx packets   
> 373
>  tx bytes 
>   17158
> tuntap-0.05down
> vxlan_tunnel0 4 up   rx packets   
>   23549
>  rx bytes 
> 2085942
>  tx packets   
>3068
>  tx bytes 
>  436318
> DBGvpp# set int state tuntap-0.0 up
> 
> I have not tried this kind of setup before and do not know if other config 
> may be necessary to get this going. One question I do have is why are you 
> receiving a packet with VLAN tag 0 in your tap interface?
> 
> Hopefully this may work for you,
> John
> 
> From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
> Behalf Of Juraj Linkes -X (jlinkes - PANTHEON TECHNOLOGIES at Cisco)
> Sent: Thursday, May 25, 2017 4:19 AM
> To: vpp-dev@lists.fd.io
> Cc: Tomas Cechvala -X (tcechval - PANTHEON TECHNOLOGIES at Cisco) 
> ; fds-...@lists.opnfv.org
> Subject: Re: [vpp-dev] Does VPP support vlan 0?
> 
> Hello vpp-devs,
> 
> Has anyone looked at this?
> 
> Thanks,
> Juraj
> 
> From: Juraj Linkes -X (jlinkes - PANTHEON TECHNOLOGIES at Cisco)
> Sent: Tuesday, 23 May, 2017 15:47
> To: vpp-dev@lists.fd.io
> Cc: fds-...@lists.opnfv

Re: [vpp-dev] OPENFLOW

2017-05-30 Thread otroan
Hi there Ewan,

> Is there any plan to surpport openflow?

I thought that particular unicorn was dead. ;-)
But if you find a problem openflow solves...

What are you trying to do?

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] ALG

2017-05-26 Thread otroan
Hi there,

> Many applications have two channels, one is data channel, the other is 
> control channel, both have different ports,
> so we need ALG to help these protocols to cut through FW, i think it is a 
> pretty important feature and
> it has been surpported by almost every  manufacturer on their NAT devices.

It has been supported with varying success.
Take RFC5389 and the XOR-MAPPED-ADDRESS, where the STUN protocol where forced 
to hide IP addresses in the payload because misguided ALGs rewrote them.

ALGs are often more of a hinderance to application developers than not. ALGs 
are hard to get right, and they lead to ossification.
It is easier to write application if you have a predictable network. Any 
application on todays network either uses port 443 or it has to deal with NAT 
traversal.

The IPv4 Internet wth address exhaustion is evolving. Address sharing is a 
fundamental part of the architecture now. Take mechanisms like MAP-E (RFC7597) 
where ALGs will not be included.

If you have a specific request for a particular application we can talk about 
it. But in general my stance is "not the network's problem to solve".

Best regards,
Ole



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] The Case Of the Missing API Definition

2017-05-24 Thread otroan
Hi Jon,

Thanks for the poetry! ;-)

This is me in 01384fe
Apologies for that. Next time I see you let me bring both band aid and whiskey.

To my excuse, there has been this list of "broken" APIs maintained by the 
Python and Java language binding implementors. It's been on the todo list for a 
long time and I finally found some time to deal with them. Obviously not 
everyone was aware of those planned changes. I did include those I thought 
affected as code reviewers. #fail.

I feel your pain. How can we make this better?
1) Never change APIs, regardless the reason
2) Announce and discuss changes a priori. Separate mailing list for API changes?
{vpp-users, vpp-api-announce}
3) ...

Do we reach everyone using vpp on  vpp-dev and a heads-up there would suffice?

Cheers,
Ole






> On 23 May 2017, at 19:19, Jon Loeliger  wrote:
> 
> Folks,
> 
> I was causally walking down Update VPP Master Lane when I was
> suddenly attacked from behind by a case of the missing API call!
> I read vpp-dev mail daily, and I watch the Gerrit fervently, so I was
> pretty sure I wouldn't be blind-sided by this sort of Silent Gotcha.
> 
> But there was no mistaking it:  My API call bridge_domain_sw_if_details
> was gone.  And only two days ago too!  I was shocked.  Horrified, even.
> I knew the next build my code would fail.  There would be no updating
> to Top-Of-Tree VPP today.
> 
> What would I tell my boss?  *My* code was broken?  Surely you wouldn't
> expect me to fall on the "I'm sorry.  My code is broken." sword.  My own
> code!  Surely I could blame someone else?  I mean, what if there were
> some email from the developers?  A little heads-up that the API was on
> The Out and would soon go the way of Sonny Bono.  But no, no, there
> wasn't even a hint.
> 
> I was going to have to admit I failed to see this coming in the Gerrit 
> reviews.
> 
> And now, without even lunch, I would have to deduce what data used to be
> in that API call, and how it was cached in my VPP interface library, and yes,
> I'd have to scurry to find where that data was located now.
> 
> But how?  How could this be?  I lamented still.  I just knew last time *I*
> wanted an API interface change, I spent a week discussing it on the list,
> and, after deliberation a-plenty, a new API was needed, and then later,
> in fact after a complete release cycle, we could begin to discuss how the
> old API call might be deprecated and finally removed.  I longed for the day
> that we would finally make progress, content in the knowledge that we
> had not, in fact, blind-sided anyone with our API deprecation plan.
> 
> But those days are behind us now, and the future comes at us plenty fast.
> Commits are committed, and progress is progressed.  My scars are healing,
> and after all this water under and through the bridge, I have learned now to
> just laugh at these situations.
> 
> Ah, to be young again, and not have wasted my youth on backward compatibility
> and cheap Scotch.
> 
> jdl
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] ALG

2017-05-23 Thread otroan
Hi Ewan,

> Is there any plan to surpport ALG?

I am quite the non-believer with regards to ALGs.
But you can always make a proposal. What ALGs do you need and why?

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] five tuple nat

2017-05-20 Thread otroan
Hi,

> Thanks, it seems that there is no icmp procedure in det nat, why is it like 
> this?

Yes, there should be ICMP support.

E.g. through:

commit b33f413af46ec8dff7f222dbd5bc3bcec1502d3d
Author: Juraj Sloboda 
Date:   Wed Feb 8 23:54:21 2017 -0800

Add handling of ICMP error packets in SNAT (VPP-629)

Change-Id: I8d2022b7cb3ef3da736c085bccbb5b9c057a8d76
Signed-off-by: Juraj Sloboda  
> 
> Regards,
> Ewan
> ewan
> 
> From: otroan
> Date: 2017-04-25 16:06
> To: yugang
> CC: vpp-dev
> Subject: Re: [vpp-dev] five tuple nat
> Ewan,
> 
> > Do we have any plan to surpport  five tuple nat like linux kernel?
> 
> That should already be supported in the SNAT plugin.
> https://wiki.fd.io/view/VPP/SNAT
> 
> Best regards,
> Ole



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] sharding in tunnel

2017-05-08 Thread otroan
Hi Xyhue,

As far as I know IPv4 fragmentation / reassembly is not supported on the tunnel 
types you listed.
IP{4,6} fragmentation / reassembly is supported for IPv4 over IPv6 tunnels 
(src/vnet/map), but I think that's it.

In general the recommendation is to avoid fragmentation in tunnels because of 
the associated cost in reassembly for the tunnel endpoint. You _can_ of course, 
and feel free to have a go at implementing it if you like.

Best regards,
Ole

> A detailed description of my problem:
> I would like to test ip fragment reassembly,but it didn't work.Is there 
> anything wrong in my configuration:
> set interface mtu 2000 host-eth2
> 
> Did I miss anything configuration?
> If vpp support ip fragment reassembly on host interface . Does VPP support 
> the IP fragment reassembly on the virtual interface we created, such as the 
> GRE interface?
> 
> Thanks,
> xyxue
> 
> From: xy...@fiberhome.com
> Date: 2017-05-08 15:42
> To: otroan
> CC: vpp-dev
> Subject: Re: Re: [vpp-dev] sharding in tunnel
> 
> I'm sorry I didn't say it clearly.
> My questions:
> Does the VPP support ip fragment  in GRE、L2TP、MPLS tunnel?
> Whether the tunnel supports configuring the MTU?
> Whether the receiver supports  ip reassembly?
> 
> Thanks,
> xyxue
> 
> 
> From: otroan
> Date: 2017-05-08 15:16
> To: 薛欣颖
> CC: vpp-dev
> Subject: Re: [vpp-dev] sharding in tunnel
> > When the IP message enters the GRE、L2TP、MPLS tunnel, does the VPP support 
> > sharding?
> 
> I'm not quite sure what "sharding" would mean in this context.
> Are you thinking of point to multipoint tunnels? Or ECMP to a set of anycast 
> tunnel destinations or something completely different?
> 
> Cheers,
> Ole



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] sharding in tunnel

2017-05-08 Thread otroan
> When the IP message enters the GRE、L2TP、MPLS tunnel, does the VPP support 
> sharding?

I'm not quite sure what "sharding" would mean in this context.
Are you thinking of point to multipoint tunnels? Or ECMP to a set of anycast 
tunnel destinations or something completely different?

Cheers,
Ole



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Host with FDIO not acquiring global IPV6 address from ICMPv6 RA advertisement

2017-05-04 Thread otroan
Senthil,

> 
>A host with FDIO enable is connected to a Linux server with IPv6 
> forwarding enabled. The host does not acquire global IP address reacting to 
> the RA message from the router.
> Is there any configuration that has to be explicitly enabled in Host FDIO 
> so that it forms global IP address from the prefix advertised in the RA 
> message from the router..?
> Note: This function works well with a normal Linux host using kernel 
> stack..

You are right, host side SLAAC is not yet supported in VPP. Only manual 
configuration of IPv6 addresses.

I'll put it on my work list, unless you want to volunteer (or someone else)? :-)

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] ping to ip6 uses link local as source..

2017-04-27 Thread otroan
> I’d suggest a modification to ip6_interface_first_address to indicate whether 
> a link-local is ok. Then you can choose to ignore the link-local when the 
> ping’s destination is global scope.

At some point we need to implement RFC6724.

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] vpp_papi: No such message type or failed CRC checksum

2017-04-27 Thread otroan
Weitao,

> I installed vpp 17.04 release in a new clean ubuntu 16.04 server, except 
> that, I did nothing.
> 
> When I first connect vpp using python api,  the terminal show those DEBUG 
> messages.
> 
> Is this phenomenon right?

No. Turns out that the CRC table wasn't setup correctly for messages in those 
plugins / modules.
Shwetha promised to push a patch for these.
Thanks for finding!

Best regards,
Ole

> 
> 2017-04-25 16:47 GMT+08:00 :
> Hi,
> 
> This means that you give the Python API a JSON definition for an API message 
> not available on the running VPP instance.
> That might be caused by a plugin not loaded, version mismatch...
> 
> Best regards,
> Ole
> 
> > When I try to connect vpp using python api, it shows the debug messages.
> >
> > My codes:
> >
> > from vpp_papi import VPP
> > vpp = VPP()
> > vpp.connect('test')
> >
> >
> > And the terminal shows:
> >
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > udp_ping_add_del_reply_a08dec44
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_transit_disable_reply_405af39d
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_transit_disable_ee3cf5f9
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_vni_disable_reply_2e8d61fa
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > udp_ping_add_del_req_a7280e39
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_vni_enable_reply_6a273d6e
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_export_enable_disable_20586df7
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > udp_ping_export_reply_7f8a6c87
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_disable_reply_711375e4
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_enable_6bf84bd6
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_vni_disable_27392af3
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_transit_enable_reply_4dc0cf51
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_vni_enable_489195ec
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_disable_1a373a3b
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_enable_reply_ca79fc00
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > ioam_cache_ip6_enable_disable_reply_67f2a36b
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > ioam_cache_ip6_enable_disable_de631cb6
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_transit_enable_2c399a17
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > udp_ping_export_req_e43a0203
> > DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> > vxlan_gpe_ioam_export_enable_disable_reply_2baa825a
> > ___
> > vpp-dev mailing list
> > vpp-dev@lists.fd.io
> > https://lists.fd.io/mailman/listinfo/vpp-dev
> 
> 



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] How can I get API messages IDs?

2017-04-25 Thread otroan
Weitao,

> I'm using Python binding for the VPP API. I want to receive some asynchronous 
> messages and use the register_event_callback to register a 
> papi_event_handler, just like wiki Python Language Binding does.
> 
> But I dont know how to distinguish what kind of messages I received 
> asynchronously, so I want to know the message IDs for all API messages.
> 
> Is there any other way to do this without knowing message IDs?

The callback is called with msgname and result (named tuple).
You should be able to demux based on the message name.

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] vpp_papi: No such message type or failed CRC checksum

2017-04-25 Thread otroan
Hi,

This means that you give the Python API a JSON definition for an API message 
not available on the running VPP instance.
That might be caused by a plugin not loaded, version mismatch...

Best regards,
Ole

> When I try to connect vpp using python api, it shows the debug messages.
> 
> My codes:
> 
> from vpp_papi import VPP
> vpp = VPP()
> vpp.connect('test')
> 
> 
> And the terminal shows:
> 
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> udp_ping_add_del_reply_a08dec44
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_transit_disable_reply_405af39d
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_transit_disable_ee3cf5f9
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_vni_disable_reply_2e8d61fa
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> udp_ping_add_del_req_a7280e39
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_vni_enable_reply_6a273d6e
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_export_enable_disable_20586df7
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> udp_ping_export_reply_7f8a6c87
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_disable_reply_711375e4
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_enable_6bf84bd6
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_vni_disable_27392af3
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_transit_enable_reply_4dc0cf51
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_vni_enable_489195ec
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_disable_1a373a3b
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_enable_reply_ca79fc00
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> ioam_cache_ip6_enable_disable_reply_67f2a36b
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> ioam_cache_ip6_enable_disable_de631cb6
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_transit_enable_2c399a17
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> udp_ping_export_req_e43a0203
> DEBUG:vpp_papi:No such message type or failed CRC checksum: 
> vxlan_gpe_ioam_export_enable_disable_reply_2baa825a
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] How can I get API messages IDs?

2017-04-25 Thread otroan
Hi,

> Every API message has a ID number, where can I get the specific number?

The API client gets the message dictionary on connect.
The message ID numbers depend on the plugins loaded and so on.

There is an API where you can map name to ID.
vppapiclient.h:
  int vac_get_msg_index(unsigned char * name);

or you can iterate through
api_main_t *am = &api_main;
am->msg_index_by_name_and_crc;

Typically the language bindings would hide this for you. What are you trying to 
do?

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] five tuple nat

2017-04-25 Thread otroan
Ewan,

> Do we have any plan to surpport  five tuple nat like linux kernel?

That should already be supported in the SNAT plugin.
https://wiki.fd.io/view/VPP/SNAT

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Build error seen for stable/1704 build-release

2017-04-21 Thread otroan
Eric,

> Another issue that I’m seeing that I’d like confirmation if its local, 
> reproducible or expected.
> 
> I’m following directions @ 
> https://wiki.fd.io/view/VPP/Build,_install,_and_test_images, in particular 
> Steps 1A-3A.
> My setup:
> Checkout remote https://gerrit.fd.io/r/vpp branch stable/1704
> 
> make wipe-release #no issue
> make install-dep #no issue
> make build-release #snippet of errors seen below:
> 
> /home/eernst/go/src/gerrit.fd.io/vpp/build-data/../src/vnet/bfd/bfd_cli.c: In 
> function ‘bfd_cli_udp_session_add’:
> /home/eernst/go/src/gerrit.fd.io/vpp/build-data/../src/vnet/bfd/bfd_cli.c:428:17:
>  error: self-comparison always evaluates to true 
> [-Werror=tautological-compare]
>foreach_bfd_cli_udp_session_add_cli_param (CHECK_MANDATORY);
> 
> I see many instances of the error for this macro, and similar ones w/in 
> bfd_cli
> 
> Since this is a clean branch and install-dep succeeded, I would expect this 
> to build without issue.
> 
> Any ideas?
> 
> Sorry for being that guy with all the issues – thanks for the quick 
> responsiveness!

That's the guy we need! ;-)

Which compiler do you use?
Just built with gcc 5.4.0.

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] VPP 17.04 released

2017-04-19 Thread otroan
Chris,

> But also, eek! I think the 17.01 release notes didn't get dual-committed last 
> time around. It's empty.
> 
> I'm about to head out; I'll rustle that up when I get home if nobody else 
> beats me to it.

Merged in the 1701 release notes into stable/1704 and master now.
So a) we'll be OK for next round, b) we'll have it when/if we do a respin of 
17.04.

Cheers,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] VPP 17.04 released

2017-04-19 Thread otroan
Ed,

> Looks like:
> 
> https://gerrit.fd.io/r/#/c/5837/
> 
>  wasn't cherry picked down to stable/1704
> 
> Ole, could we get that cherry picked down and the release respun?

Yes, done. Let's hang out a few days for other issues.

> Also looks like we need a test for 'working out of the box on package 
> install'.

Yes. It worked fine when I tested it on my VMs.

Sounds like we should find ways of using the binary packages more frequently 
than just at release time...

Cheers,
Ole

> 
> On Wed, Apr 19, 2017 at 2:27 PM, Ernst, Eric  wrote:
> Excited to start looking @ memifc.  On 1701 the package worked out of the
> box; should I expect same for 1704 on Xenial?
> 
> I pulled from 
> https://nexus.fd.io/content/repositories/fd.io.stable.1704.ubuntu.xenial.main/
> after uninstalling prior vpp packages, and when starting the service I see:
> 
> Apr 19 14:20:09 eernstworkstation systemd[1]: Starting vector packet 
> processing engine...
> Apr 19 14:20:09 eernstworkstation systemd[1]: Started vector packet 
> processing engine.
> Apr 19 14:20:09 eernstworkstation vpp[10368]: vlib_plugin_early_init:360: 
> plugin path /usr/lib/vpp_plugins
> Apr 19 14:20:09 eernstworkstation vpp[10368]: vlib_call_all_config_functions: 
> unknown input `dpdk  '
> Apr 19 14:20:09 eernstworkstation systemd[1]: vpp.service: Main process 
> exited, code=exited, status=1/FAILURE
> Apr 19 14:20:09 eernstworkstation systemd[1]: vpp.service: Unit entered 
> failed state.
> Apr 19 14:20:09 eernstworkstation systemd[1]: vpp.service: Failed with result 
> 'exit-code'.
> Apr 19 14:20:10 eernstworkstation systemd[1]: vpp.service: Service hold-off 
> time over, scheduling restart.
> Apr 19 14:20:10 eernstworkstation systemd[1]: Stopped vector packet 
> processing engine.
> 
> 
> I see similar after a reboot.
> 
> Thanks!
> Eric
> 
> 
> 
> On Wed, Apr 19, 2017 at 02:14:48PM -0700, Ed Warnicke wrote:
> > Congratulations!
> >
> > Ed
> >
> > On Wed, Apr 19, 2017 at 1:46 PM, Luke, Chris  wrote:
> >
> > > Yay! Great stuff!
> > >
> > > But also, eek! I think the 17.01 release notes didn't get dual-committed
> > > last time around. It's empty.
> > >
> > > I'm about to head out; I'll rustle that up when I get home if nobody else
> > > beats me to it.
> > >
> > > Chris.
> > >
> > > > -Original Message-
> > > > From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io]
> > > On
> > > > Behalf Of otr...@employees.org
> > > > Sent: Wednesday, April 19, 2017 4:37 PM
> > > > To: vpp-dev 
> > > > Subject: [vpp-dev] VPP 17.04 released
> > > >
> > > > The images are built, the wiki is updated (let me know if something has
> > > been
> > > > missed).
> > > >
> > > > Release notes:
> > > > https://docs.fd.io/vpp/17.04/release_notes_1704.html
> > > >
> > > > Images at:
> > > > https://nexus.fd.io/
> > > >
> > > > Best regards,
> > > > Ole
> > > ___
> > > vpp-dev mailing list
> > > vpp-dev@lists.fd.io
> > > https://lists.fd.io/mailman/listinfo/vpp-dev
> > >
> 
> > ___
> > vpp-dev mailing list
> > vpp-dev@lists.fd.io
> > https://lists.fd.io/mailman/listinfo/vpp-dev
> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] VPP 17.04 released

2017-04-19 Thread otroan
The images are built, the wiki is updated (let me know if something has been 
missed).

Release notes:
https://docs.fd.io/vpp/17.04/release_notes_1704.html

Images at:
https://nexus.fd.io/

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] snat plugin make failed

2017-04-18 Thread otroan
Hi Juan,

I am not familiar with the Java stuff. I did remember having seen something 
similar in the past, but not lately.

Can you reproduce this on 17.04 or latest master?

Best regards,
Ole




> On 16 Apr 2017, at 09:44, Juan Salmon  wrote:
> 
> Hi,
> 
> I used VPP 17.01 stabe,
> When I install VPP via ./buid.sh every thing is OK.
> but when I  make snat plugin independently from its own directory, I see 
> following error:
> 
> 
> dir=`pwd`;  \
> mkdir -p snat/jvpp/target; \
> mkdir -p snat/jvpp/io/fd/vpp/jvpp/snat; \
> cd snat/jvpp/io/fd/vpp/jvpp/snat;   \
> mkdir -p dto future callfacade callback notification test;  \
> ./../../vpp-api/java/jvpp/gen/jvpp_gen.py -i ${dir}/snat.api.json 
> --plugin_name snat;   \
> cd -;   \
> mv -f snat/jvpp/io/fd/vpp/jvpp/snat/jvpp_snat_gen.h 
> snat/jvpp/jvpp_snat_gen.h;  \
> cp ./snat/jvpp/io/fd/vpp/jvpp/snat/test/*.java 
> snat/jvpp/io/fd/vpp/jvpp/snat/test/; \
> cd snat/jvpp;   \
> /usr/lib/jvm/java-8-openjdk-amd64//bin/javac -classpath 
> .:target:../../../../vpp-api/java/jvpp-registry-17.01.jar -d target 
> io/fd/vpp/jvpp/snat/*.java \
> io/fd/vpp/jvpp/snat/dto/*.java \
> io/fd/vpp/jvpp/snat/callback/*.java \
> io/fd/vpp/jvpp/snat/notification/*.java \
> io/fd/vpp/jvpp/snat/future/*.java   \
> io/fd/vpp/jvpp/snat/callfacade/*.java   \
> io/fd/vpp/jvpp/snat/test/*.java \
> || (echo "snat jvpp compilation failed: $?"; exit 1);   \
> /usr/lib/jvm/java-8-openjdk-amd64//bin//javah -classpath 
> .:target:../../../../vpp-api/java/jvpp-registry-17.01.jar -d . 
> io.fd.vpp.jvpp.snat.JVppSnatImpl ;
> /bin/bash: line 5: ./../../vpp-api/java/jvpp/gen/jvpp_gen.py: No such file or 
> directory
> /root/vpp/plugins/snat-plugin
> mv: cannot stat ‘snat/jvpp/io/fd/vpp/jvpp/snat/jvpp_snat_gen.h’: No such file 
> or directory
> cp: ‘./snat/jvpp/io/fd/vpp/jvpp/snat/test/CallbackApiTest.java’ and 
> ‘snat/jvpp/io/fd/vpp/jvpp/snat/test/CallbackApiTest.java’ are the same file
> javac: file not found: io/fd/vpp/jvpp/snat/*.java
> Usage: javac  
> use -help for a list of possible options
> snat jvpp compilation failed: 2
> Error: Could not find class file for 'io.fd.vpp.jvpp.snat.JVppSnatImpl'.
> make: *** [snat/jvpp/io_fd_vpp_jvpp_snat_JVppSnatImpl.h] Error 1
> 
> 
> Best Regards,
> Juan Salmon.
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] VPP project committer nomination: Sergio Gonzales Monroy

2017-03-27 Thread otroan
+1.

Best regards,
Ole


> On 27 Mar 2017, at 06:12, Damjan Marion (damarion)  wrote:
> 
> 
> Hello VPP committers,
> 
> I would like to nominate Sergio Gonzales Monroy as a VPP project committer.
> 
> History of Sergio’s merged contributions to the VPP project:
> 
> https://gerrit.fd.io/r/#/q/owner:sergio.gonzalez.monroy%2540intel.com+status:merged
> 
> shows significant amount of work done on VPP crypto/IPSec code including the 
> integration with DPDK CryptoDev.
> 
> Current VPP committers please vote (+1, 0, -1) by replying to this email 
> (reply-all), no later than 04.04.2017 6.00 AM PST.
> 
> Thanks,
> 
> Damjan
> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Building router plugin

2017-03-27 Thread otroan
> You basically have two options:
> 1. Teach your routing protocol daemon to directly talk to VPP for configuring 
> the FIB.
> 2. Do not modify the routing daemon and let VPP map routes written in the 
> kernel.
> 
> For 1, you will need the router plugin, but for packet punting only.
> 
> For 2., you will need both netlink+router plugins. The netlink plugin (which 
> actually more like a library), shouldn't require so much changes though.

With TCP support in VPP I was playing with the idea of integrating exaBGP as a 
VPP plugin.
Use the Python API binding to program routes, and receive the BGP stream across 
a fifo (or even the API).

Cheers,
Ole

>> Le 26 mars 2017 à 16:31, Łukasz Chrustek  a écrit :
>> 
>> Hello,
>> 
>> thank all of You for clarification of status router plugin.
>> 
>> I'm trying to use vpp+dpdk as bare metal linux ruter with bgp and ospf 
>> routing protocols, goal is to make very fast router with dynamic routing 
>> protocols. Can You advice is there any other way to exchange dynamic routing 
>> information between os and vpp ?
>> 
>> Regards
>> Lukasz
>> 
>> 
>> The mailman did not let my last message go through because it was too big so 
>> I am removing the previous threads to keep this message under 100KB limit.
>> 
>> Hello,
>> 
>> Dave and Pierre are correct, the router plugin is no longer being 
>> maintained. There was not much interest in the community for this project at 
>> the time and I have since moved on to other things.  I’d be happy to help a 
>> new maintainer with any questions they may have.
>> 
>> If you really want to just test it out, I suggest attempting to checkout a 
>> commit of VPP close to the last commit on the router plugin. Somewhere 
>> closely following VPP commit 0bfe5d8c792abcdb, “A Protocol Independent 
>> Hierarchical FIB (VPP-352)” will work (you might have to git bisect to get 
>> something that compiles right away).
>> 
>> If necessary, I can submit a patch to remove the router plugin from the VPP 
>> sandbox with a note on the wiki page mentioning the finalization of the 
>> project. I recall there being an 8-month time limit for these the sandbox 
>> projects.
>> 
>> -Jeff
>> 
>> 
>> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] vpp-api python error during vpp installation

2017-03-25 Thread otroan
Hi Igor,

> I've been trying configuring and installing vpp packages, but at the end of 
> the .deb packages this error appears as show in the attatched image. Does 
> anyone know how to fix it ?

There should be a fix for this in:
https://gerrit.fd.io/r/#/c/5799/

It is waiting for a dependency fix to ci-management.

Cheers,
Ole



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] VPP 17.04 RC1 - stable/1704 pulled

2017-03-22 Thread otroan
All,

The stable/1704 branch has been pulled and tags have been laid.
Master is now open again for all changes.

With regards to stable/1704 (from the release wiki):

Once we've pulled the 17.04 release throttle
We need to be disciplined with respect to bugfix commits. Here are a few 
common-sense suggestions:

• All bug fixes must be double-committed to the release throttle as 
well as to the master branch
• Commit first to the release throttle, then "git cherry-pick" 
into master
• Manual merges may be required, depending on the degree of 
divergence between throttle and master
• All bug fixes need to have a Jira ticket
• Please put Jira IDs into the commit messages.
• Please use the same Jira ID


Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] RC1 today 22nd of March

2017-03-21 Thread otroan
Just a reminder of the RC1 milestone today.
Let me know if there are urgent fixes you require to get in, otherwise I will 
notify when the release branch is pulled.

Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Make pkg-rpm seems to be failing...

2017-03-21 Thread otroan
Burt,

> Jon's assessment is more accurate than what I wrote previously. That's 
> because I was mashing together two issues that really are separate, but are 
> closely related. In my case, I know I was trying to play a game of using 
> minimal disk space, and I played a game at the start where I determined 
> dependencies manually (as I believe install-dep brings in more than a minimal 
> set.) I must have forgotten which copy I had played this game, and then I 
> complained that install-dep is missing things. And when I realized my error, 
> I felt embarrassed for delivering misinformation. I went overboard in 
> attempting to apologize for my error. But the other issue that Jon, you 
> correctly point out, is that Ole neglected to give any heads up that his 
> change requires re-running make install-dep. So maybe someone who is 120% 
> perfect, after seeing that Ole's change does not "just work" would then read 
> the change, and say, "OH, I need to rerun make install-dep."
> 
> I think the imperfect solution is that next time, the Heads up should appear, 
> at least on this list. Exactly the way Jon suggests.

You are right, I should absolutely have given a heads up. Sorry about that.

Best regards,
Ole

> 
> On Mon, Mar 20, 2017 at 11:53 AM, Jon Loeliger  wrote:
> Burt and Ole,
> 
> On Sun, Mar 19, 2017 at 7:26 AM,  wrote:
> 
> Hmm, so https://gerrit.fd.io/r/#/c/5781/
> isn't sufficient?
> 
> Necessary, yes.  Sufficient?  No.
> 
> On the other hand...
> 
> On Sun, Mar 19, 2017 at 11:51 AM, Burt Silverman  wrote:
> Ugh, I made a terrible bone head mistake... Possibly I never ran make 
> install-dep. Even if I had, I was unaware that it is a good idea to run it 
> again, just to be sure, in a case like this. I probably thought it was like 
> make bootstrap, where running a 2nd time doesn't help. Apologies to Ed and 
> Ole for misinformation. So, Jon, were you in the same boat with me -- didn't 
> do a double check of make install-dep? I guess so, because you still had the 
> problem after Ole's fix.
> 
> Burt
> 
> This was precisely the problem here.  I'll try to say this as
> politely as I can...  Wow.  That's some blind-siding sh*t.
> 
> So, let's talk about that a bit.
> 
> First, thank you for identifying the issue!  This does indeed
> fix the build locally, and bring us back to online par. Thank you!
> 
> Second, the notion of requiring repeated running of the make
> install-dep target as part of our daily build process from our
> CI engine is just not going to happen.  NFW.  We're not running
> anything has root like that.  It's a bad idea for many reasons.
> 
> On the flip side, I can make a job that "notices" a change in the
> installed packaged requirement and run that as, say, a daily job
> and incidentally notice that updates are needed.  Sure, polling
> like that sucks; an interrupt here with a simple "Heads up!  The
> install-deps have changed" would have been awesome!
> 
> Thanks,
> jdl
> 
> 



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] VPP Python API for create host-interface ?

2017-03-21 Thread otroan
Hi there,

> I am running the latest vpp code from master branch.
> I am looking at the python APIs that vpp provides.
> I am specifically trying to find the API for the following cli command -
> create host-interface  []
> 
> I could not find where exactly this is defined in the json files in 
> /usr/shar/vpp/api/
> Or is this not supported through API ?

Looks like we're not quite consistent on naming.
It is this API you are looking for I think:

/** \brief Create host-interface
@param client_index - opaque cookie to identify the sender
@param context - sender context, to match reply w/ request
@param host_if_name - interface name
@param hw_addr - interface MAC
@param use_random_hw_addr - use random generated MAC
*/
define af_packet_create
{
  u32 client_index;
  u32 context;

  u8 host_if_name[64];
  u8 hw_addr[6];
  u8 use_random_hw_addr;
};


Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Make pkg-rpm seems to be failing...

2017-03-19 Thread otroan

> On 19 Mar 2017, at 05:03, Burt Silverman  wrote:
> 
> I may have found it. Install python2-rpm-macros from yum.  Also install 
> python-rpm-macros. It's looking good.
> 
> Hopefully Ed or Ole can make sure those are part of the install-deps: unlike 
> some other things, these are not so easy to find.

Hmm, so https://gerrit.fd.io/r/#/c/5781/
isn't sufficient?

Best regards,
Ole


> 
> Burt
> 
> On Sat, Mar 18, 2017 at 6:10 PM, Jon Loeliger  wrote:
> 
> 
> On Fri, Mar 17, 2017 at 6:33 PM, Burt Silverman  wrote:
> It probably worked during a 12 hour window. I think Neale then made a 2nd 
> change incompatible with the earlier change.
> 
> Burt
> 
> Well, yeah, maybe.  But after doing the .end_node dance,
> I'm back to the %py2_build problem on a CentOS RPM build
> of "make pkg-rpm".
> 
> That's building commit:
> 
> commit 898273fbb588811824bb27ad0ef203d358a7121a
> Author: Neale Ranns 
> Date:   Sat Mar 18 02:57:38 2017 -0700
> 
> Check change in unnumbered setting before updating IP enabled state
> 
> Using "make bootstrap; make build-release; make pkg-rpm".
> 
> HTH,
> jdl
> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Make pkg-rpm seems to be failing...

2017-03-17 Thread otroan
Hi Jon,

> So, the "make pkg-rpm" target seems to be failing near a
> line like this:
> 
> # Python bindings
> cd /home/jdl/workspace/vpp/build-root/../src/vpp-api/python
> %py2_install
> 
> That is from the RPM tmp file.  The actual log of the error follows.
> 
> Anyone?

https://gerrit.fd.io/r/#/c/5783/

Please keep them coming! ;-)

Best regards,
Ole

> 
> + for file in '$(find 
> /var/lib/jenkins/workspace/build-ngr-rpm/build_root/BUILD/vpp/build-root/install-vpp-native/vpp/share/java
>  -type f -name '\''*.jar'\'' -print )'
> + install -p -m 644 
> /var/lib/jenkins/workspace/build-ngr-rpm/build_root/BUILD/vpp/build-root/install-vpp-native/vpp/share/java/jvpp-ioamexport-17.04.jar
>  
> /var/lib/jenkins/workspace/build-ngr-rpm/build_root/BUILD/vpp/build-root/rpm/BUILDROOT/vpp-1.0.0-1922~g6aa75af~b35.x86_64/usr/share/java
> + cd 
> /var/lib/jenkins/workspace/build-ngr-rpm/build_root/BUILD/vpp/build-root/../src/vpp-api/python
> + %py2_install
> /var/tmp/rpm-tmp.5NRgE0: line 95: fg: no job control
> error: Bad exit status from /var/tmp/rpm-tmp.5NRgE0 (%install)
> 
> 
> RPM build errors:
> Bad exit status from /var/tmp/rpm-tmp.5NRgE0 (%install)
> make[2]: *** [install-rpm] Error 1
> make[2]: Leaving directory 
> `/var/lib/jenkins/workspace/build-ngr-rpm/build_root/BUILD/vpp/build-root'
> make[1]: *** [pkg-rpm] Error 2
> 
> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] vpp rpms overlaping files

2017-03-17 Thread otroan
Ed,

Thanks for finding this.
It should be fixed in: https://gerrit.fd.io/r/#/c/5783/

Best regards,
Ole


> On 16 Mar 2017, at 15:53, Ed Warnicke  wrote:
> 
> OpNFV has discovered that we have overlapping files in vpp-devel and 
> vpp-python-api
> rpms.  It looks like vpp-python-api is being stuffed into vpp-devel.  Has 
> something changed here recently?
> 
> Ed
> 
> 
> Transaction check error:
>   file /usr/lib/python2.7/site-packages/jvppgen/__init__.py conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/__init__.pyc conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/__init__.pyo conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/callback_gen.py conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/callback_gen.pyc conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/callback_gen.pyo conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/dto_gen.py conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/dto_gen.pyc conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/dto_gen.pyo conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jni_gen.py conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jni_gen.pyc conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jni_gen.pyo conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_c_gen.py conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_c_gen.pyc conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_c_gen.pyo conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_callback_facade_gen.py 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_callback_facade_gen.pyc 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_callback_facade_gen.pyo 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_future_facade_gen.py 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_future_facade_gen.pyc 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_future_facade_gen.pyo 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_impl_gen.py conflicts

Re: [vpp-dev] Missing lib pneum during build?

2017-03-17 Thread otroan
Jon,

> 
> I am no fairly confident that this patch fixes the race condition issue
> that I was seeing.
> 
> Now.  I am now failry confident
> 
> And I am still seeing the build failure.  Is there any chance
> of getting this patch or a similar fix in place?

Yes, that should now be taken care of with https://gerrit.fd.io/r/#/c/5666/

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] vpp rpms overlaping files

2017-03-16 Thread otroan
Ed,

> OpNFV has discovered that we have overlapping files in vpp-devel and 
> vpp-python-api
> rpms.  It looks like vpp-python-api is being stuffed into vpp-devel.  Has 
> something changed here recently?

I repackaged python with a commit this morning:
https://gerrit.fd.io/r/#/c/5666/

Did I mess that up? Cause those files shouldn't even be in the Python RPM, they 
are from Java.

Cheers,
Ole


> 
> Ed
> 
> 
> Transaction check error:
>   file /usr/lib/python2.7/site-packages/jvppgen/__init__.py conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/__init__.pyc conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/__init__.pyo conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/callback_gen.py conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/callback_gen.pyc conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/callback_gen.pyo conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/dto_gen.py conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/dto_gen.pyc conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/dto_gen.pyo conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jni_gen.py conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jni_gen.pyc conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jni_gen.pyo conflicts between 
> attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_c_gen.py conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_c_gen.pyc conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_c_gen.pyo conflicts 
> between attempted installs of vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 
> and vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_callback_facade_gen.py 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_callback_facade_gen.pyc 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_callback_facade_gen.pyo 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_future_facade_gen.py 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_future_facade_gen.pyc 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-packages/jvppgen/jvpp_future_facade_gen.pyo 
> conflicts between attempted installs of 
> vpp-devel-17.04-rc0~440_ge9f929b~b2064.x86_64 and 
> vpp-api-python-17.04-rc0~440_ge9f929b~b2064.x86_64
>   file /usr/lib/python2.7/site-pa

[vpp-dev] Fixed offset from UTC meeting time?

2017-03-14 Thread otroan
All,

It was a very quiet meeting at 1600UTC today... Could we in the future have the 
meeting time set fixed against UTC so that we avoid any confusion whenever 
different regions of the world randomly chooses to move their clocks forward or 
backward?

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing lib pneum during build?

2017-03-08 Thread otroan
Jon,


> On 8 Mar 2017, at 01:34, Jon Loeliger  wrote:
> 
> On Mon, Mar 6, 2017 at 2:57 PM, Jon Loeliger  wrote:
> 
> Hi Billy,
> 
> S, despite the Peanut Gallery, I'm not yet crazy... :-)
> 
> Now all we have to do is find the missing dependency in a Makefile! :-)
> 
> Thanks,
> jdl
> 
> I may not be crazy (yet), but I am in a vacuum.
> 
> OK, as a review, here is the error message:
> 
> running build_ext
> building 'vpp_api' extension
> creating build
> creating build/temp.linux-x86_64-2.7
> creating build/temp.linux-x86_64-2.7/vpp_papi
> gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 
> -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 
> -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv 
> -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions 
> -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 
> -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -fPIC 
> -I/var/lib/jenkins/workspace/build-ngr-rpm/build_root/BUILD/vpp/build-root/install-vpp-native/vpp/include/
>  -I/usr/include/python2.7 -c vpp_papi/pneum_wrap.c -o 
> build/temp.linux-x86_64-2.7/vpp_papi/pneum_wrap.o
> creating build/lib.linux-x86_64-2.7
> gcc -pthread -shared -Wl,-z,relro 
> build/temp.linux-x86_64-2.7/vpp_papi/pneum_wrap.o 
> -L/var/lib/jenkins/workspace/build-ngr-rpm/build_root/BUILD/vpp/build-root/install-vpp-native/vpp/lib64
>  -L. -lpneum -lpython2.7 -o build/lib.linux-x86_64-2.7/vpp_api.so
> /bin/ld: cannot find -lpneum
> collect2: error: ld returned 1 exit status
> error: command 'gcc' failed with exit status 1
> make[7]: *** [install-exec-local] Error 1
> 
> 
> So, let's pick on install-exec-local.  That is from 
> src/vpp-api/python/Makefile.am:
> 
> install-exec-local:
> cd $(srcdir);   \
> mkdir -p $(pythondir);  \
> mkdir -p $(pyexecdir);  \
> PYTHONUSERBASE=$(prefix)\
> python setup.py build_ext -L $(libdir)  \
>   -I $(prefix)/include/ install --user
> 
> And the setup.py in that directory says:
> 
> setup (name = 'vpp_papi',
>version = '1.3',
>description = 'VPP Python binding',
>author = 'Ole Troan',
>author_email = 'o...@cisco.com',
>test_suite = 'tests',
>packages=['vpp_papi'],
>ext_modules = [
>Extension(
>'vpp_api',
>sources = ['vpp_papi/pneum_wrap.c'],
>libraries = ['pneum'],
>)],
>long_description = '''VPP Python language binding.''',
>zip_safe = True,
> )
> 
> Good, it lists pneum.  But the problem is, we shouldn't run this
> setup.py until after pneum is fully linked and on disk.  This happened
> too soon:
> 
> gcc -pthread -shared -Wl,-z,relro 
> build/temp.linux-x86_64-2.7/vpp_papi/pneum_wrap.o 
> -L/var/lib/jenkins/workspace/build-ngr-rpm/build_root/BUILD/vpp/build-root/install-vpp-native/vpp/lib64
>  -L. -lpneum -lpython2.7 -o build/lib.linux-x86_64-2.7/vpp_api.so
> /bin/ld: cannot find -lpneum
> 
> 
> Which means, the rule for vpp_api.so's dependencies, isn't listing the
> real pneum library properly.
> 
> I have no idea where that is supposed to take place yet.

I have also seen this error. What I suspect happens is that while pneum is 
already built and that the build dependency is correct, the library isn't 
installed under the install- directory yet.

I didn't manage to reproduce it right now, but would you mind trying this to 
see if it works:

diff --git a/src/vpp-api/python/Makefile.am b/src/vpp-api/python/Makefile.am
index 5407682..c60e4f4 100644
--- a/src/vpp-api/python/Makefile.am
+++ b/src/vpp-api/python/Makefile.am
@@ -39,7 +39,7 @@ libpneum_la_LDFLAGS = -module
 libpneum_la_CPPFLAGS =

 # TODO: Support both Python 2 and 3.
-install-exec-local:
+install-exec-local: install-libLTLIBRARIES
cd $(srcdir);   \
mkdir -p $(pythondir);  \
mkdir -p $(pyexecdir);  \


(In other news I am looking at using CFFI instead, and then the whole 
vpp_api.so would go away).

Cheers,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] VPP API Freeze date coming up -- March 8

2017-03-02 Thread otroan
All,

Please refer to the 17.04 release plan: 
https://wiki.fd.io/view/Projects/vpp/Release_Plans/Release_Plan_17.04

Any/all binary API changes must be merged no later than the F0 date, March 8th. 
Otherwise they will not make the 17.04 release. Other projects depend on that 
for their release planning. We do not have the option of slipping the F0 date 
to accommodate “last minute rush features.”

Between F0 and RC1 (March 22), the goal is to settle down the master branch. 
Housekeeping activities such as eliminating residual Coverity warnings occur 
between F0 and RC1.

Low-risk patches with contained blast radii - and no effect on binary APIs - 
may be accepted at committer's discretion between F0 and RC1.

The master branch reopens for normal work shortly after RC1.

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] system func in vpp

2017-03-01 Thread otroan
Ewan,

> I would like send five tuples 、 mac 、traffic etc. info out, which can be 
> display out some where.
> I will try shared memory api.

I also have an IPFIX node doing that. Exporting L2, L3 and L4 aggregated flow 
information.
It would also be possible to add other export formats to that.

Ping me if interested, the latest code isn't on gerrit yet.

Cheers,
Ole

> 
> Regards,
> Ewan
> yug...@telincn.com
> 
> From: Luke, Chris
> Date: 2017-03-01 20:14
> To: yug...@telincn.com; Dave Barach (dbarach); Ed Warnicke
> CC: vpp-dev
> Subject: RE: RE: [vpp-dev] system func in vpp
> A Unix domain socket would work, if you use it only from the main thread.
> 
> Instead though, VPP already has a performant binary API that uses shared 
> memory. Could you not use this? What sort of messages are you trying to send?
> 
> Chris.
> 
> From: yug...@telincn.com [mailto:yug...@telincn.com]
> Sent: Wednesday, March 1, 2017 4:38
> To: Dave Barach (dbarach) ; Luke, Chris 
> ; Ed Warnicke 
> Cc: vpp-dev 
> Subject: Re: RE: [vpp-dev] system func in vpp
> 
> Thanks.
> So it's not security to use unix socket too? If i want to send some data  
> from vpp to linux or to another process, any options?
> 
> Regards,
> Ewan
> yug...@telincn.com
> 
> From: Dave Barach (dbarach)
> Date: 2017-02-28 21:12
> To: Luke, Chris; yug...@telincn.com; Ed Warnicke
> CC: vpp-dev
> Subject: RE: [vpp-dev] system func in vpp
> See also src/vnet/unix/tuntap.c, which seems to already do pretty much what 
> you’re describing. It’s disabled by default. Use the command-line argument 
> “tuntap { enable }” to kick the tires.
> 
> In addition to the concerns which Chris mentioned, adding ‘system(“foo”)’ 
> calls to vpp is not a security best practice.
> 
> Thanks… Dave
> 
> From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
> Behalf Of Luke, Chris
> Sent: Tuesday, February 28, 2017 7:18 AM
> To: yug...@telincn.com; Ed Warnicke 
> Cc: vpp-dev 
> Subject: Re: [vpp-dev] system func in vpp
> 
> Using any syscall needs thinking through from inside VPP. Using system() or 
> similar is simply ill-advised; what you’re doing is best done outside of VPP 
> where the penalty of executing fork() is much diminished.
> 
> If you really must create these interfaces from inside VPP then I suggest you 
> look up the netlink ABI in Linux, which is what the ‘ip’ program uses, and 
> program it directly.
> 
> Chris.
> 
> From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
> Behalf Of yug...@telincn.com
> Sent: Monday, February 27, 2017 22:56
> To: Ed Warnicke 
> Cc: vpp-dev 
> Subject: Re: [vpp-dev] system func in vpp
> 
> I would like to add veth interface in vpp for every phy interface, " 
> system("ip link add vpp type veth peer name kernel-vpp") ".
> It's convenient  to do this from vpp.
> 
> Regards,
> Ewan.
> yug...@telincn.com
> 
> From: Ed Warnicke
> Date: 2017-02-28 11:44
> To: yug...@telincn.com
> CC: vpp-dev
> Subject: Re: Re: [vpp-dev] system func in vpp
> Why would you do that from within vpp?
> 
> Ed
> 
> On Mon, Feb 27, 2017 at 8:36 PM, yug...@telincn.com  
> wrote:
> "int system(const char *command)"
> 
> I would like to use this func to start another dameon , such as "  
> system("zebra -d")  ".
> 
> Regards,
> Ewan
> yug...@telincn.com
> 
> From: Ed Warnicke
> Date: 2017-02-28 11:15
> To: yug...@telincn.com
> CC: vpp-dev
> Subject: Re: [vpp-dev] system func in vpp
> I'm not quite sure what you mean by the 'func system'...
> 
> Ed
> 
> On Mon, Feb 27, 2017 at 7:26 PM, yug...@telincn.com  
> wrote:
> Hi, all
> 
> Does vpp can't use func  system? Any reason to this or what can i do  if i 
> really need ?
> 
> yug...@telincn.com
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev
> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] VPP 17.04: Week 9 status

2017-02-28 Thread otroan
Hi,

As the designated release manager for 17.04. Here is summary of what happened 
over the last two weeks.

Please remember the API freeze date on March 8th.

JIRA:
  Jong has created a new dashboard:
 https://jira.fd.io/secure/Dashboard.jspa?selectPageId=10700
  The idea is to map the JIRA components to the components in the MAINTAINER 
file.
  (Which I believe Damjan will post something for review on gerrit very soon).

Coverity:
  https://scan9.coverity.com/reports.htm#v30797/p12999
 - 18 outstanding issues
   LISP, API, L2 VTR, SR, IPsec
 I'll run git blame on these and nag people accordingly (if you don't mind too 
much).


67 commits.

f61bc52  BFD: disable debug prints (Klement Sekera)
ff54270  vlib: add VLIB_BUFFER_EXT_HDR_VALID flag (Neale Ranns)
39f9d8b  [Proxy] ARP tests (Damjan Marion)
3e7b569  Add GPE CLI/API for setting encap mode (Florin Coras)
646ba9b  fix:vxlan mcast adj - added as ucast dpo adj (Neale Ranns)
a83bc30  Load plugins in alphabetical order (Florin Coras)
239790f  BFD: echo function (Damjan Marion)
263440e  Add NSH to GPE decap path (Florin Coras)
5a72c1c  MFIB: changes to improve route add/delete performance (Damjan Marion)
b5b2ef5  Enable tests with VRF reset (Neale Ranns)
08a70f1  FIB: 1) fix pool realloc during prefix export. 2) don't walk off the 
end of the path-extension vector (Neale Ranns)
26cd8c1  VPP-650: handle buffer failure in vlib_buffer_copy(...) (Dave Barach)
02767e9  Fixed QAT device binding and device unbinding when vpp package is 
removed (Dave Barach)
bcc6aa4  MFIB memory leak. free the per-source interface hash (Florin Coras)
04197ee  VPP-279: Document changes for vnet/vnet/devices (Damjan Marion)
4a3f69c  Fix vpp built-in version of api_unformat_sw_if_index(...) (Florin 
Coras)
22dc9df  Remove prints from LISP test (Florin Coras)
def19da  Clean up "binary-api" help string, arg parse bugs (Dave Barach)
974cdc6  Fix LISP and ONE crc marcos (Florin Coras)
04f8d3f  Support multiple plugin build in the sample-plugin (Damjan Marion)
a9a20e7  VPP-635: CLI Memory leak with invalid parameter (Dave Barach)
2291a36  jvpp: remove unnecessary msg_id_base caching (Damjan Marion)
2dd6852  Consolidate DHCP v4 and V6 implementation. No functional change 
intended (Neale Ranns)
c8c5335  Add ref to test framework docs in doxygen output. (Dave Barach)
2d41f16  fix trace frame-queue unformat of index (Dave Barach)
954898f  Fix last run time update for timer wheel (Dave Barach)
d456020  Repair SNAT's IPFIX and IF-add-del test functions. (Dave Barach)
694396d  Add Overlay Network Engine API (Florin Coras)
20a175a  dhcp: multiple additions (Damjan Marion)
2e3677b  cryptodev:  Automatically download and build ISA-L Crypto library 
(Damjan Marion)
770e89e  Add basic 4o4 LISP unit test (Damjan Marion)
057bb8c  test: ip6 vrf instances multi-context test (CSIT-497) (Damjan Marion)
82786c4  Rename LISP GPE API to GPE (Florin Coras)
65e8457  VPP-540 : pbb tag rewrite details (John Lo)
9745ace  Update CSIT tests 170213 -> 170220 (Dave Wallace)
a8d9f30  FIB reset leaves residual routes. Wrong API used to remove the routes 
meant the lock count on the entry did not drop to zero (Florin Coras)
38206ee  LISP: don't show PITR generated mapping in dump call (Filip Tehlar)
6ca42d3  dpdk: updated build to automatically download Intel(R) Multi-Buffer 
Crypto for IPsec Library (Damjan Marion)
52456fc  CLI extension to add multiple (S,G)s at once and time it (Florin Coras)
5a8123b  Python test IP and MPLS objects conform to infra. Add IP[46] MFIB 
dump. (Florin Coras)
90c5572  make test: save + dump VPP api trace log; VPP-640 (Damjan Marion)
6cfc39c  Remove duplicate ip6 get interface address code (Damjan Marion)
c48829b  BFD: put session admin-up/admin-down (Damjan Marion)
cb33dc2  Implemented IKEv2 initiator features: - IKE_SA_INIT and IKE_AUTH 
initial exchanges - Delete IKA SA - Rekey and delete Child SA - Child SAs 
lifetime policy (Damjan Marion)
665e482  Fix handling of ping to SNAT out interface (Damjan Marion)
52a047a  ipsec: changed ipsec-input-ip6 node to be a sibling of 
ipsec-input-ip4, fixes a problem that occurs with cryptodev ipv6 input. (Damjan 
Marion)
681abe4  l2 input: avoid per-packet trace checks in the fast path (Damjan 
Marion)
6e9cf3b  Fix comment for num-mbufs default in startup.conf (Dave Barach)
5d81f45  dpdk: quad loop and prefetch in fill_free_list (Dave Barach)
4983e47  dpdk: bump to DPDK 17.02 (Dave Barach)
7be8a88  ioam: declare export_node instead of defining it in header file (Dave 
Barach)
d65c18d  api: remove debug print in api_main_init (Dave Barach)
83ed1f4  tw_timer_expire_timers() - add a maximum to the number of expiration 
per call (Damjan Marion)
b69111e  Add NSH load-balance and drop DPO (Damjan Marion)
6085e16  Fix NSH-LISP interface addition (Damjan Marion)
7bc7310  Fix crash on deleting previously activated IPv6 interface - VPP-636 
(John Lo)
a4cb12b  Fix sample plugin breakage. (Damjan Marion)
b33f413  Add handling of ICMP error packets in SNA

Re: [vpp-dev] Traceback Seen in invoke Python APIs with Parameters

2017-02-18 Thread Ole Troan (otroan)
Hi Hang,

You have to use named arguments. 
Change in 17.01. 

Best regards,
Ole

> On 18 Feb 2017, at 19:13, Hang Shi  wrote:
> 
> Hi, 
> 
> I am trying to use VPP python APIs and seeing the tracebacks (see below) for 
> Python APIs with parameters, while Python APIs without parameters are fine. 
> Will anyone help?  The APIs I tried is vpp.sw_interface_add_del_address.
> 
> below is the traceback and code snippets. Whole codes are attached as well. 
> 
> 
>  
> Traceback (most recent call last):
>   File "set_addr_test.py", line 53, in 
> main()
>   File "set_addr_test.py", line 45, in main
> loop = vpp.sw_interface_add_del_address(ifindex, 1, 1, 0, 16, addr)
> TypeError: () takes exactly 0 arguments (6 given)
> Cleaning up VPP on exit
>  
> 
> 
> 
>    
>   loop = vpp.create_loopback()
>   print(loop)
>   ifindex = loop.sw_if_index
>   print('{}'.format(ifindex))
> 
>   addr = str(IPv6Address(u'1::1').packed)
>   loop = vpp.sw_interface_add_del_address(ifindex, 1, 1, 0, 16, addr)
>   ...
>  
> 
> 
> The syntax from help  for this API: 
> 
> sw_interface_add_del_address(**kwargs)
> u16 _vl_msg_id, u32 client_index, u32 context, u32 sw_if_index, u8 
> is_add, u8 is_ipv6, u8 del_all, u8 address_length, u8 address
> 
> 
> 
> regards, 
> Hang
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev


Re: [vpp-dev] avoiding spoof protection for BFD ECHO packets

2017-02-17 Thread otroan
For IPv6 I would probably just have picked a separate IPv6 address for BFD and 
installed an entry for it in the FIB.
For IPv4... well you mistake me for someone who cares. ;-)

Cheers,
Ole


> On 17 Feb 2017, at 14:07, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES 
> at Cisco)  wrote:
> 
> Hi guys,
> 
> BFD echo function allows testing datapaths only and thus using more
> aggresive rates and faster detection by using packets, which are
> processed only by the sender and simply looped back by the receiver.
> Each peer declares the willingness/rate at which it will loop back
> echo packets and each side decides to use the feature or not locally.
> 
> For the BFD over UDP, the echo packets are recognized by having
> destination port 3785.
> 
> To implement this in VPP, we need to
> 
> 1.) loop back echo packets from remote side - this is easy, already done
> 2.) be able to send the packets out and receive them - this hits the
> current spoofing protection, when a packet with destination set to our
> own IP address gets dropped like this:
> 
> ...
> 00:00:00:708351: ip4-local
>UDP: 172.16.2.1 -> 172.16.1.1
>  tos 0x00, ttl 255, length 52, checksum 0x6096
>  fragment id 0x
>UDP: 49152 -> 3785
>  length 32, checksum 0x
> 00:00:00:708351: error-drop
>  ip4-input: ip4 spoofed local-address packet drops
> 
> in this example 172.16.1.1 is the address on the interface receiving the
> packet.
> 
> Discussion with Neale yielded a few possible solutions, none of which is
> great:
> 
> 1.) add input feature to siphon BFD packets instead of going to
> ip4-local node
> 2a.) skip checks in ip4-local node based on BFD ports
> 2b.) skip checks in ip4-local node based on UDP port registration (via
> udp_register_dst_port())
> 3.) add information for prefix/address to FIB to skip checks for this
> entry
> 
> based on discussion, here are the downsides of each:
> 
> 1.) taxes all input packets
> 2.) layering violation, caches misses in b.) case
> 3.) exposes VPP to spoofed packets for non-BFD traffic
> 
> based on these, 2.) seems to hurt the least.. with 2a.) being the
> easiest to implement to move forward..
> 
> I would appreciate thoughts/ideas from more experienced people..
> 
> Thanks,
> Klement
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] VPP 17.04: Week 6 status

2017-02-14 Thread otroan
Hi,

As the designated release manager for 17.04. Here is summary of what happened 
over the last week.

JIRA:
   230 To Do, 54 In Progress
   That still needs a cleanup.

   I have also as an experiment created a few JIRA components. (SNAT, Security 
Groups, Python API), with component owners, that are meant to match the 
maintainers. This way (if it works well), handling in incoming tickets should 
be more distributed and scale better.

Coverity:
  - 12 outstanding issues
  - IOAM (5)
  - LISP-GPE, IPsec, SR

21 commits.

a6bce49:LISP-reject-remote-mappings-that-have-as-locators-local-IPs (Filip 
Tehlar)
6fa5568:Fix-M-M2-macros-in-VAT (Filip Tehlar)
78edb8e:Multiple-platofrm-support-for-dpdk-Makefile-fix-optimizations (Damjan 
Marion)
e4ad8cc:VPP-630-Null-pointer-dereferences-in-vlib-unix-plugin.c (Ole Troan)
8ea6d71:Fix-source-address-reachability-check-for-ip6-local-packets 
(AkshayaNadahalli)
a57a970:BFD-modify-session-parameters (Klement Sekera)
7fce133:make-test-BFD-tests-speedup (Klement Sekera)
6f96649:BFD-minor-fixes (Klement Sekera)
c756c1c:Improve-MFIB-doxygen-help (Neale Ranns)
b91017a:make-test-work-around-scapy-truncated-packets (Klement Sekera)
fed79e8:Update-plugin-templates (Dave Barach)
fdd81af:VPP-632-InBand-OAM-Analyser (AkshayaNadahalli)
ce1b4c7:Basic-support-for-LISP-GPE-encapsulated-NSH-packets (Florin Coras)
466f0d4:Augment-IP_DETAILS-IP_ADDRESS_DETAILS-with-a-few-context-fields (Jon 
Loeliger)
0f438df:Out-of-tree-Build-Error-fix (AkshayaNadahalli)
3495cb6:Update-CSIT-tests-170129-170213 (Jan Gelety)
0b49e2b:vhost-user-fix-crash-when-descriptor-points-to-unknown-region (Damjan 
Marion)
f95b37e:Fix-typo-in-API-warning-message (Jon Loeliger)
0578cd1:Fix-is_server-flag-in-vhost-dump-VPP-562 (Marek Gradzki)
b05f1f0:Fix-coverity-issues-ioam (Shwetha Bhandari)
515f7c5:Merge-branch-master-of-ssh-gerrit.fd.io-29418-vpp (Ole Troan)



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] libpneum compilation flags

2017-02-10 Thread otroan
Gabriel,

> I am currently working on a patch to auto-detect the cache line size with a 
> m4 macro in autoconf (https://gerrit.fd.io/r/#/c/4576/)
> Part of it updates cache.h tests so that it raises an error if the cache line 
> length is undefined.
> 
> I am stuck at the libpneum compilation: it's a python module, so it has its 
> compilation flags defined in setup.py.
> This means that the vpp flags are not propagated to the libpneum, and I 
> believe this is a bug.
> I think the python api and the libpneum will get big changes soon anyway ...
> 
> How do you think I should handle this ?

Can you wait a few days? Or try with my CFFI patch?
The idea is to remove the C/Python vpp_api.so completely, and make the Python 
module pure Python. And libpenum completely built from within the VPP make 
system.

Cheers,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] VPP 17.04: Week 5 status

2017-02-07 Thread otroan
Hi,

As the designated release manager for 17.04 I thought I should put together a 
weekly status per email.
Please let me know if you find this useful (or hopefully not, cause then I'll 
stop doing it). ;-)

Last week we had 43 commits.

cisco.com   35 (68.63%)
netgate.com 6 (11.76%)
barachs.net 3 (5.88%)
intel.com   2 (3.92%)
gmail.com   2 (3.92%)
enea.com2 (3.92%)
suse.com1 (1.96%)

Most noteworthy was Barach's timer wheel work. We also see SNAT work on 
homegateway and CGN.
There is the tail end of the refactoring of the message API and Coverity fixes.

05b2bf2:MFIB-Coverity-warnings.-The-lock-macro-is-functionally-equivalent-but-more-expressive-and-might-appease-coverity
 (Neale Ranns)
0765c6e:VXLAN-small-changes-for-brevity (Eyal Bari)
3b14529:jvpp-fix-coverity-warn-reliance-on-default-encoding (Marek Gradzki)
d9b74a9:Update-CSIT-tests-170122-170129 (Jan Gelety)
e1ae29a:SNAT-Add-outbound-addresses-to-FIB-VPP-613 (Matus Fabian)
3ad7704:Prep-work-for-Coverity-upload-processing-via-Jenkins (Dave Barach)
c5fccc0:BFD-reformat-code-to-match-vpp-code-style (Klement Sekera)
eb82e7f:Fix-issue-with-apt-get-update-not-being-run-on-Ubuntu-16.04 (Ed 
Warnicke)
a93ea42:VXLAN-further-unify-ip4-ip6-ctl-plane-handling (Eyal Bari)
05a057b:LISP-enhance-binary-part-of-some-APIs (Filip Tehlar)
dccbee3:SNAT-changed-source-for-outbound-address-FIB-entry-VPP-613 (Matus 
Fabian)
ad623b1:dpdk-fix-crypto-coverity-warning (Sergio Gonzalez Monroy)
402ed31:BFD-improve-finding-of-ipv4-ipv6-headers (Klement Sekera)
b17dd96:BFD-SHA1-authentication (Klement Sekera)
460bc63:ENIC-driver-patch-to-fix-MAC-address-add-and-remove (Steve Shin)
ed0e49c:Update-default-Vagrant-box-to-Ubuntu-16.04-VPP-616 (Dave Wallace)
a9374df:Fix-SR-multicast-post-mfib-commit (Neale Ranns)
8a2aea3:Ensure-all-M-and-M2-second-parameters-are-the-message-pointer (Jon 
Loeliger)
614e97d:Convert-M-and-M2-macros-to-honor-their-second-mp-parameter (Jon 
Loeliger)
7bc770c:Convert-message-macro-S-to-accept-a-message-pointer-parameter (Jon 
Loeliger)
1f9191f:Localize-the-timeout-variable-within-the-W-message-macro (Jon Loeliger)
56c7b01:Refactor-fragile-msg-macro-W-and-W2-to-not-burry-return-control-flow 
(Jon Loeliger)
2d23eca:Remove-unnecessary-block-structure-around-CONTROL_PING-messages (Jon 
Loeliger)
85bb917:Added-support-for-openSUSE (Marco Varlese)
09d96f4:SNAT-Port-allocation-per-protocol (Matus Fabian)
2ae991e:SNAT-fix-invalid-outside-FIB-index (Matus Fabian)
3b46cba:Plugin-infrastructure-improvements (Damjan Marion)
9bea8fb:Next-node-frame-over-flow-after-replication (Neale Ranns)
5737d88:pep8-compliance-for-test_ip6.py (Neale Ranns)
e0cb0cc:Fix-CLI-help-message-for-set-ip-address (Matej Klotton)
62411e7:vhost-user-fix-missing-speculative-enqueue-unwind (Steven)
bfe4dfa:pg-add-trace-information-for-pg-tx-node (Damjan Marion)
d0f673e:dpdk-move-to-uio_pci_generic (Damjan Marion)
aaa396a:Test-checksyle-for-IP-mcast-tests (Neale Ranns)
8e8f98c:Wheel-timer-infra (Dave Barach)
71d73fe:fix-some-stored-but-never-read-warnings-raised-by-clang (Gabriel Ganne)
31c31aa:SNAT-initialize-outside-and-inside-FIB-index-in-snat_config (Matus 
Fabian)
b449f48:SNAT-fix-snat_add_static_mapping_command-uninitialized-variable (Matus 
Fabian)
6320514:make-test-fix-dependencies (Klement Sekera)
bd69a5f:vlib-remove-algned-unaligned-buffers-scheme (Damjan Marion)
104543f:make-test-improve-test-filtering (Klement Sekera)
614ac5d:Add-pool_get-_aligned-_will_expand (Dave Barach)
247d873:VPP-630-Null-pointer-dereferences-in-vlib-unix-plugin.c (Ole Troan)

JIRA status: 253 issues todo, 59 in progress.
See cummulative report: 
https://jira.fd.io/secure/RapidBoard.jspa?rapidView=20&projectKey=VPP&view=reporting&chart=cumulativeFlowDiagram&swimlane=50&swimlane=51&column=111&column=112&column=113

Please see the wiki for 17.04 planned features (and feel free to update):
https://wiki.fd.io/view/Projects/vpp/Release_Plans/Release_Plan_17.04

Best regards,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] [nsh_sfc-dev] Publising jvpp rc jars

2017-02-07 Thread otroan
Marek, Ed,

Assuming we want to have RC jars, what are the release mechanics required?

Ole

> On 6 Feb 2017, at 18:03, Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES 
> at Cisco)  wrote:
> 
> Hc2vpp also publishes RC debs and rpms. To build them reliably we need rc 
> jars.
> We use maven for build, so most convenient for us would be to have jvpp jars 
> in the fd.io.release repo.
> 
> Marek
> 
> From: Ed Warnicke (eaw)
> Sent: 6 lutego 2017 17:51
> To: Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) 
> 
> Cc: Ole Troan (otroan) ; Ni, Hongjun 
> ; vpp-dev@lists.fd.io; hc2...@lists.fd.io; 
> nsh_sfc-...@lists.fd.io
> Subject: Re: Publising jvpp rc jars
> 
> Question… why do we need RC jars and not just SNAPSHOTs?
> 
> Ed
> On Feb 6, 2017, at 9:30 AM, Marek Gradzki -X (mgradzki - PANTHEON 
> TECHNOLOGIES at Cisco)  wrote:
> 
> The only impediment for 17.01 was that we forgot to mention it on time.
> 
> We had a chat regarding the topic and,
> as far as I remember, you mentioned such change
> could affect all fd.io projects (don’t remember details),
> so we should move it to next release.
> 
> In case of 17.04, jvpp jars (at least currently) are part of vpp-api-java 
> package,
> so perhaps it could be easier now…
> 
> Regards,
> Marek
> 
> From: Ed Warnicke (eaw)
> Sent: 6 lutego 2017 17:22
> To: Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) 
> 
> Cc: Ole Troan (otroan) ; Ni, Hongjun 
> ; vpp-dev@lists.fd.io; hc2...@lists.fd.io; 
> nsh_sfc-...@lists.fd.io
> Subject: Re: Publising jvpp rc jars
> 
> What was the impediment for 17.01?
> 
> Ed
> On Feb 6, 2017, at 8:50 AM, Marek Gradzki -X (mgradzki - PANTHEON 
> TECHNOLOGIES at Cisco)  wrote:
> 
> Hi,
> 
> Would it be possible to publish jvpp rc jars in nexus for 17.04?
> 
> https://nexus.fd.io/content/repositories/fd.io.release/io/fd/vpp/
> 
> For 17.01 only rc debs and rpms were published.
> 
> Publishing rc jars would allow publishing rc artifacts by hc2vpp project (and 
> also nsh_sfc project we depend on).
> Currently hc2vpp rc artifacts have to depend on jvpp snapshots which is not 
> very reliable.
> 
> Thanks,
> Marek
> 
> ___
> nsh_sfc-dev mailing list
> nsh_sfc-...@lists.fd.io
> https://lists.fd.io/mailman/listinfo/nsh_sfc-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Router advertisment api

2017-02-06 Thread otroan
Hi Marek,

> I am looking into adding support for SLAAC configuration to Honeycomb.
> It looks like it can be configured from CLI using ip6 nd command.

The API also looks complete.

> And here come my questions:
> 
> 1)  Is there a difference between off-link and no-onlink flags (docs say 
> they both control L-bit in the same way)?

Having both is if nothing else confusing.
Looking at the code, it appears that the intention was that "offlink" 
controlled whether a connected route was installed in the FIB or not.
I would be quite happy if we removed the offlink parameter. And let something 
else ensure that there was or wasn't a suitable entry in the FIB.

> 2)  What is the default flag used for? E.g. is there a difference between:
> ip6 nd  prefix /
> and
> ip6 nd  prefix / default

From a brief glance at the code it appears the first adds a prefix with values 
set to zero, while the second sets it to the default set of recommend values 
specified in the RFC.

Cheers,
Ole


signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Fix for vpp-verify-master-ubuntu1604 build failures

2017-02-02 Thread otroan
Dave,

> https://gerrit.fd.io/r/#/c/4993/ should resolve this issue.  Can you confirm 
> that your patch was rebased correctly?

4830 failed after your rebase, but rebasing again earlier today and it went 
through.
Fingers crossed it is stable now.

O.


> 
> Thanks,
> -daw-
> 
> On 02/02/2017 03:57 AM, Ole Troan (otroan) wrote:
>> Dave,
>> 
>> On a rebased build I just hot the following... related?
>> 
>> O.
>> 
>> 08:08:01 + echo IS_CSIT_VPP_JOB=
>> 08:08:01 IS_CSIT_VPP_JOB=
>> 08:08:01 + git log --oneline
>> 08:08:01 + grep 37682e1
>> 08:08:01 + '[' x '!=' xTrue ']'
>> 08:08:01 + echo 'Building using "make verify"'
>> 08:08:01 Building using "make verify"
>> 08:08:01 + '[' x == xTrue ']'
>> 08:08:01 + make UNATTENDED=yes verify
>> 08:08:01 Reading package lists...
>> 08:08:01 Building dependency tree...
>> 08:08:01 Reading state information...
>> 08:08:01 Package pkg-config is not available, but is referred to by another 
>> package.
>> 08:08:01 This may mean that the package is missing, has been obsoleted, or
>> 08:08:01 is only available from another source
>> 08:08:01
>> 08:08:01 E: Package 'pkg-config' has no installation candidate
>> 08:08:01 E: Unable to locate package chrpath
>> 08:08:01 E: Unable to locate package default-jdk-headless
>> 08:08:01 Makefile:166: recipe for target 'install-dep' failed
>> 08:08:01 make: *** [install-dep] Error 100
>> 08:08:01 Build step 'Execute shell' marked build as failure
>> 08:08:01 [ssh-agent] Stopped.​
>> 
>> From: vpp-dev-boun...@lists.fd.io  on behalf of 
>> Dave Wallace 
>> Sent: Thursday, February 2, 2017 4:15 AM
>> To: vpp-dev
>> Subject: Re: [vpp-dev] Fix for vpp-verify-master-ubuntu1604 build failures
>> 
>> On 2/1/17 9:55 PM, Dave Wallace wrote:
>>> Folks,
>>> 
>>> After today's ubuntu mirror issue was resolved, Ed, Vanessa, and I 
>>> discovered another failure mode for the vpp-verify-master-ubuntu1604 verify 
>>> job.  In the process of diagnosing the failure, Ed discovered and fixed a 
>>> bug in "make verify" that was the root cause of this issue.
>>> 
>>> See https://gerrit.fd.io/r/#/c/4993/ for details.
>>> 
>>> I merged this patch and verified that it resolved the 
>>> vpp-verify-master-ubuntu1604 failure forhttps://gerrit.fd.io/r/#/c/4897.  I 
>>> have subsequently rebased all patches in the gerrit:vpp queue that were 
>>> open and current.  Any patch that has merge conflicts will need to be 
>>> rebased manually.
>>> 
>>> Thanks to Ed for his keen eyesight and Vanessa for cancelling her after 
>>> hours plans to stay and help resolve the issue.
>>> 
>>> I have also cherry-picked 4993 to stable/1701, but that still requires 
>>> merging.
>> 
>> Please disregard the following, it appears that the other jobs are waiting 
>> in the build queue and have not been posted to gerrit yet.
>>> I also noticed that stable/1701 only has verify jobs for ubuntu1404 and 
>>> centos7.  We should add a verify job for ubuntu1604 as well.
>> -daw-
>>> 
>>> Please help monitor the status of the verify jobs that are now in progress.
>>> 
>>> Thanks,
>>> -daw-
>> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev



signature.asc
Description: Message signed with OpenPGP
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Fix for vpp-verify-master-ubuntu1604 build failures

2017-02-02 Thread Ole Troan (otroan)
Dave,


On a rebased build I just hot the following... related?


O.


08:08:01 + echo IS_CSIT_VPP_JOB=

08:08:01 IS_CSIT_VPP_JOB=

08:08:01 + git log --oneline

08:08:01 + grep 37682e1

08:08:01 + '[' x '!=' xTrue ']'

08:08:01 + echo 'Building using "make verify"'

08:08:01 Building using "make verify"

08:08:01 + '[' x == xTrue ']'

08:08:01 + make UNATTENDED=yes verify

08:08:01 Reading package lists...

08:08:01 Building dependency tree...

08:08:01 Reading state information...

08:08:01 Package pkg-config is not available, but is referred to by another 
package.

08:08:01 This may mean that the package is missing, has been obsoleted, or

08:08:01 is only available from another source

08:08:01

08:08:01 E: Package 'pkg-config' has no installation candidate

08:08:01 E: Unable to locate package chrpath

08:08:01 E: Unable to locate package default-jdk-headless

08:08:01 Makefile:166: recipe for target 'install-dep' failed

08:08:01 make: *** [install-dep] Error 100

08:08:01 Build step 'Execute shell' marked build as failure

08:08:01 [ssh-agent] Stopped.?



From: vpp-dev-boun...@lists.fd.io  on behalf of 
Dave Wallace 
Sent: Thursday, February 2, 2017 4:15 AM
To: vpp-dev
Subject: Re: [vpp-dev] Fix for vpp-verify-master-ubuntu1604 build failures

On 2/1/17 9:55 PM, Dave Wallace wrote:
Folks,

After today's ubuntu mirror issue was resolved, Ed, Vanessa, and I discovered 
another failure mode for the vpp-verify-master-ubuntu1604 verify job.  In the 
process of diagnosing the failure, Ed discovered and fixed a bug in "make 
verify" that was the root cause of this issue.

See https://gerrit.fd.io/r/#/c/4993/ for details.

I merged this patch and verified that it resolved the 
vpp-verify-master-ubuntu1604 failure for https://gerrit.fd.io/r/#/c/4897.  I 
have subsequently rebased all patches in the gerrit:vpp queue that were open 
and current.  Any patch that has merge conflicts will need to be rebased 
manually.

Thanks to Ed for his keen eyesight and Vanessa for cancelling her after hours 
plans to stay and help resolve the issue.

I have also cherry-picked 4993 to stable/1701, but that still requires merging.

Please disregard the following, it appears that the other jobs are waiting in 
the build queue and have not been posted to gerrit yet.
I also noticed that stable/1701 only has verify jobs for ubuntu1404 and 
centos7.  We should add a verify job for ubuntu1604 as well.
-daw-

Please help monitor the status of the verify jobs that are now in progress.

Thanks,
-daw-

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Weird VPP API message processing failure

2017-01-17 Thread otroan
> We have seen a similar issue related to the same ‘API refactoring : dpdk’ 
> change.
> We are using an external API binding layer in C-language in our VPP based 
> solution.
> After the change, it took some digging to add –DDPDK=1 to get things back to 
> working.
> 
> Looking forward, should it be considered a standard practice in VPP for the 
> API (IDs) to be dependent on the features compiled (enabled) in VPP? 
> In such case, should we consider having a generated config.h (similar to 
> Linux kernel) to be included by the external C-code?

The API message id to name mapping is now part of the API itself.
See commit 557d128b

Use the  u32 vl_api_get_msg_index (u8 * name_and_crc) API.
Or do it via the pneum library.

O.


> 
> Thanks,
> -AI
> 
> From:  on behalf of Jon Loeliger 
> 
> Date: Tuesday, January 17, 2017 at 11:12 AM
> To: vpp-dev 
> Subject: Re: [vpp-dev] Weird VPP API message processing failure
> 
> 
> 
> On Mon, Jan 16, 2017 at 6:33 PM, Jon Loeliger  wrote:
> Folks, 
> 
> We are seeing a really strange VPP API message processing problem.
> The scenario goes like this...
> 
> 
> I've started to isolate it with git bisect, and so far I believe the
> behavior changed between these commits:
> 
> $ git log --oneline
> ...
> 553a411 VPP-585: vhost-user interface deletion leaks memory.
> ffc18f5 japi: include tests in jar files
> 738f3f2 API refactoring : dpdk
> 6bbf83a Revert "vppctl: bash completion for vppctl commands"
> 842b9c5 Self-service garbage collection for the API message allocator
> d995c75 vppctl: bash completion for vppctl commands
> 0d3c1cc VPP-279: af_packet via Command-line Arg should no longer be supported
> 48c1824 Update CSIT tests 170101 -> 170108
> ...
> 
> I've not had a chance to look at them yet, but of those, the most
> suspicious looking one to me is:
> 842b9c5 Self-service garbage collection for the API message allocator
> 
> If no one beats me to it, I'll continue bisecting it tomorrow...
> 
> Thanks,
> jdl
> 
> So, our message processing issue was one of the commits
> listed above.  Specifically, it is this:
> 738f3f2 API refactoring : dpdk
> 
> In that commit, API messages (and their IDs) are made conditionally
> present based on the symbol DPDK being greater than 0.  That has
> yielded an inconsistent build scenario where the include files used
> by other components do not have DPDK set, and the internally built
> components (vl_api_test) do see it set.  That results in API message
> IDs that are skewed by 6.
> 
> jdl
> 
> 
> 
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Weird VPP API message processing failure

2017-01-17 Thread otroan
Hi Jon,

> We are seeing a really strange VPP API message processing problem.
> The scenario goes like this...
> 
> Our CLI issues C API calls through the vlib API.  The messages hit
> the shared memory queue, but are not processed.  They sit there.

Is it VPP that does not process the messages or is it the client (your CLI) 
that does not process the replies?

> Later, we fire up, say, vppctl and do a "show api" command.  That
> causes the queue to be flushed and the first thing it does is process
> the outstanding API messages from our CLI.

>From a different process? Hmm, not sure I quite understand the scenario, but 
>this doesn't sound quite like how the API can be used.

Pointer to code?

Best regards,
Ole

> This used to work.  About two weeks ago I started pulling in the
> top-of-tree stuff to get us closer to development head and get
> some of the needed bug fixes.
> 
> I'm wondering if this sounds familiar to you at all?
> 
> I've started to isolate it with git bisect, and so far I believe the
> behavior changed between these commits:
> 
> $ git log --oneline
> ...
> 553a411 VPP-585: vhost-user interface deletion leaks memory.
> ffc18f5 japi: include tests in jar files
> 738f3f2 API refactoring : dpdk
> 6bbf83a Revert "vppctl: bash completion for vppctl commands"
> 842b9c5 Self-service garbage collection for the API message allocator
> d995c75 vppctl: bash completion for vppctl commands
> 0d3c1cc VPP-279: af_packet via Command-line Arg should no longer be supported
> 48c1824 Update CSIT tests 170101 -> 170108
> ...
> 
> I've not had a chance to look at them yet, but of those, the most
> suspicious looking one to me is:
> 842b9c5 Self-service garbage collection for the API message allocator
> 
> If no one beats me to it, I'll continue bisecting it tomorrow...
> 
> Thanks,
> jdl
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev


Re: [vpp-dev] Committer / Maintainer model.

2016-12-21 Thread Ole Troan (otroan)
Ray,

> Well if they are a 'committer' then dispense with the extra bureaucracy and 
> give them commit rights?

It's a matter of granularity really. 
I could certainly imagine myself only having control of vnet/map and  not want 
to have responsibility or authority over anything else. 

When it comes down to it this is all merits based anyway. 

I hoped more less centralized bureaucracy and more distributed power, but I am 
sure that's what the great Russian leaders over the past centuries tried to 
achieve too. :-)

Best regards,
Ole
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev


Re: [vpp-dev] Committer / Maintainer model.

2016-12-21 Thread Ole Troan (otroan)
Ray,

> I suspect the Maintainers versus Committers description was included for my 
> benefit :-)

Most definitely not! :-)
Agreeing on the right words to use for something is half the battle. 

> My 2c is that my experience of this model is that maintainers typically get 
> frustrated and disillusioned over time and become inactive, as they feel they 
> are minions, doing the tough and often invisble review work but with no real 
> authority over a feature. You end up with maintainer churn etc.
> 
> That is why I push for a strong correlation between maintainers and 
> committers. Committers should be a maintainer of something and the number of 
> maintainers who are not committers should be small. A maintainer with no 
> commit rights, should be a committer in waiting with a clear path to 
> graduating to be a committer.

I see that. Interesting to see how it develops. Not suggesting we should cast 
this in stone. . 

I imagined the opposite. That a maintainer had super-powers for his feature, 
but perhaps wasn't so interested in the rest of the system. Then the role of 
the committer is more one of architectural oversight and someone who ensures 
that the right hoops were jumped. 

I kind of think of a maintainer as a committer for a particular 
feature/area/plugin.

Try and then adjust as we go along?

Cheers,
Ole



> 
> Ray K
> 
>> On 21/12/2016 12:18, Ole Troan wrote:
>> Guys,
>> 
>> The discussion we had on the Tuesday meeting about the maintainers file got 
>> me thinking.
>> 
>> I think there are two problems with the current model.
>> - It puts a high burden on the committers, since at least one among the 
>> committer set has to know every piece of the code.
>>  Aka. it doesn't scale very well.
>> - It doesn't allow the code authors aka maintainers of a given component any 
>> control of changes to 'their' component.
>> 
>> Proposal:
>> 1) Each component has a set of owners (or named list).
>> 2) When a change is submitted. A gerrit hook processes the list of changed 
>> files, and automatically adds the component owner lists or individuals to 
>> the reviews list.
>>(e.g. Ole Troan (vnet/map), Neale Ranns (vnet/ip))
>> 3) A committer will then see when maintainers have +1 for each affected 
>> component. And then either submit or chase component owners for review.
>> 
>> A maintainer can then raise a "discuss" by a -1.
>> 
>> If there is support for this we need to:
>> - create maintainer file (and keep this up to date)
>> - write gerrit hook
>> 
>> Btw, Damjan pointed me to the Xen project's definition of maintainers vs 
>> committers:
>> 
>> Maintainers
>> 
>> Maintainers own one or several components in the Xen tree. A maintainer 
>> reviews and approves changes that affect their components. It is a 
>> maintainer's prime responsibility to review, comment on, co-ordinate and 
>> accept patches from other community member's and to maintain the design 
>> cohesion of their components. Maintainers are listed in a MAINTAINERS file 
>> in the root of the source tree.
>> 
>> Committers
>> 
>> Committers are Maintainers that are allowed to commit changes into the 
>> source code repository. The committer acts on the wishes of the maintainers 
>> and applies changes that have been approved by the respective maintainer(s) 
>> to the source tree. Due to their status in the community, committers can 
>> also act as referees should disagreements amongst maintainers arise. 
>> Committers are listed on the sub-project's team portal (e.g. Hypervisor team 
>> portal).
>> 
>> 
>> Views?
>> 
>> Best regards,
>> Ole
>> ___
>> vpp-dev mailing list
>> vpp-dev@lists.fd.io
>> https://lists.fd.io/mailman/listinfo/vpp-dev
>> 
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev


Re: [vpp-dev] Heads up: make test + API changes.

2016-12-07 Thread otroan
What ho,

> The new API Python changes also requires some changes to the test 
> infrastructure in test/
> Working out the issues now, expect to commit this evening. Until then don't 
> expect exhilarating happiness from make test.

"make test" should be all good to go now.

I noticed a couple of issues around robustness for receiving unexpected packets 
(e.g. MLD before ND NA) and I'll open jira's for those.
If we all work on making the tests useful and robust we'll hopefully get great 
benefits from them too (says the man who broke them in the first place. :-))

Cheers,
Ole

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev


Re: [vpp-dev] Vnet enum values in the python API

2016-12-06 Thread otroan
Neale,

> What’s the best (i.e. least error prone) way to export enum values to the 
> python API.
> 
> For example;
> From l2/l2_vtr.h:
> 
> /* VTR config options for API and CLI support */
> typedef enum
> {
>  …
> } l2_vtr_op_t;
> 
> Is required for use in (from vpe.py)
> 
> 
>  def l2_interface_vlan_tag_rewrite(
>   sw_if_index,
>vtr_op,  <<<
>   ):


I take it you want type checking? (otherwise you could just represent it as 
u32).

vpe.py has gone by the way.

Currently we got:

.api definition file -> vppapigen -> .json
vpp_papi.py processes the .json file and dynamically creates new abstract data 
types and function definitions.
currently only structs and function calls are supported.

not a bad idea to add enums though. you want me to have a look at it, or would 
you have a go?

Cheers,
Ole
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] VPP policy imposition meeting

2016-11-02 Thread otroan
Keith,

I'd certainly like to participate in that. Would it be possible to do it Friday 
or next week?
(And for Europeans remember that the US is still on daylight savings time.)

Best regards,
Ole


> On 1 Nov 2016, at 01:26, Keith Burns  wrote:
> 
> I scheduled a meeting on the fdio calendar for 7-8am Thursday Pacific 11/3.
> 
> Webex will be forthcoming.
> 
> This is per action item from last week's meeting.
> 
> Cheers
> Keith.
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev


Re: [vpp-dev] VPP policy imposition meeting

2016-11-02 Thread otroan
Keith,

I'd certainly like to participate in that. Would it be possible to do it Friday 
or next week?
(And for Europeans remember that the US is still on daylight savings time.)

Best regards,
Ole


> On 1 Nov 2016, at 01:26, Keith Burns  wrote:
> 
> I scheduled a meeting on the fdio calendar for 7-8am Thursday Pacific 11/3.
> 
> Webex will be forthcoming.
> 
> This is per action item from last week's meeting.
> 
> Cheers
> Keith.
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev


Re: [vpp-dev] VPP project committer nomination: Neale Ranns

2016-10-27 Thread otroan
> Would the current vpp committers please vote (+1, 0, -1) by email to 
> vpp-dev@lists.fd.io no later than Tuesday, 11/1 at 11:59pm EDT?

+1 (without doubt).

Cheers,
Ole

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev


Re: [vpp-dev] about snat limit bandwidth for snat address

2016-10-18 Thread otroan
Yu,

> I want to use the limit bandwidth for snat address, I do some work to
> 
> find whether this function is already done or not . But I don't find the 
> function in vpp .
> Does my result is right?Does community has the plan to develop it ?
> If community don't have enough free  time to develop it ,maybe i can develop 
> it and push it to vpp community 
> Any ideas about the snat address limit  bandwidth function?

Would you mind elaborating a little more what your idea is?

We have limits for the number of translations allowed per user.

Are you thinking of limits on the bandwidth used per inside IPv4 address (aka 
per-user)?
How and why would that be tied to the SNAT feature as opposed to a more general 
rate limiter?

Best regards,
Ole
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev