Re: [vpp-dev] VPP_STABLE_1710 Crash during IP Address Addition #vnet
Hi Jitendra, Addresses in overlapping subnets is not supported by VPP. The configuration you give below is not valid. /neale From: on behalf of "sainijite...@gmail.com" Date: Tuesday, 24 July 2018 at 07:57 To: "vpp-dev@lists.fd.io" Subject: Re: [vpp-dev] VPP_STABLE_1710 Crash during IP Address Addition #vnet Hi Neale, Thank you for the reply. I tried this patch but it blocks valid configuration as well. For example - set interface ip address EthernetSwitch2/0/0 10.10.10.33/24 <--- valid address create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.66/24 <--- valid address but not allowed since in same subnet Also, when i compare file "ip4_forward.c" from this patch against one in release 1804, the changes from this patch are not found in 1804. release 1804 does not block overlapping subnets and crash is fixed as well. Unable to pin down the exact changes that went in for this. Thanks Jitendra -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9925): https://lists.fd.io/g/vpp-dev/message/9925 Mute This Topic: https://lists.fd.io/mt/23791651/21656 Mute #vnet: https://lists.fd.io/mk?hashtag=vnet=1480452 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] VPP_STABLE_1710 Crash during IP Address Addition #vnet
Hi Neale, Thank you for the reply. I tried this patch but it blocks valid configuration as well. For example - set interface ip address EthernetSwitch2/0/0 10.10.10.33/24 <--- valid address create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.66/24 <--- valid address but not allowed since in same subnet Also, when i compare file "ip4_forward.c" from this patch against one in release 1804, the changes from this patch are not found in 1804. release 1804 does not block overlapping subnets and crash is fixed as well. Unable to pin down the exact changes that went in for this. Thanks Jitendra -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9916): https://lists.fd.io/g/vpp-dev/message/9916 Mute This Topic: https://lists.fd.io/mt/23791651/21656 Mute #vnet: https://lists.fd.io/mk?hashtag=vnet=1480452 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] VPP_STABLE_1710 Crash during IP Address Addition #vnet
Hi, I expected it was ‘fixed’ when we explicitly disallowed overlapping subnets: https://gerrit.fd.io/r/#/c/8057/ /neale From: on behalf of "sainijite...@gmail.com" Date: Monday, 23 July 2018 at 12:42 To: "vpp-dev@lists.fd.io" Subject: [vpp-dev] VPP_STABLE_1710 Crash during IP Address Addition #vnet [Edited Message Follows] Hello, We are using vpp stable release 1710 and encountered vpp crash in the following scenario (IP Address addition) - 1. configure ip 2. configure network / broadcast ip explicitly on same interface Same crash behavior is observed with VPP release 1801 but issue is not seen in release 1804. Since issue was fixed between release 1801 & 1804, I wanted to find out which code change exactly fixes this issue. Could someone please help to get some starting pointers here. In summary - If we have an issue which is fixed in some latest version of the vpp build, how do we track the changes which fixed the issues? Crash scenario example and backtrace - - create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.128/24 <--- valid address set interface ip address EthernetSwitch2/0/0 10.10.10.0/24 <--- network address <<< crash - - create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.128/24 <--- valid address set interface ip address EthernetSwitch2/0/0 10.10.10.255/24 <--- broadcast address <<< crash - - create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.0/24 <--- network address set interface ip address EthernetSwitch2/0/0 10.10.10.255/24 <--- broadcast address <<< crash - DBGvpp# set interface ip address VirtualFunctionEthernet0/5/0 10.10.10.128/24 DBGvpp# create sub VirtualFunctionEthernet0/5/0 8 VirtualFunctionEthernet0/5/0.8 DBGvpp# set interface ip address VirtualFunctionEthernet0/5/0.8 10.10.10.0/24 0: /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_path.c:2085 (fib_path_get_adj) assertion `dpo_is_adj(>fp_dpo)' fails Thread 1 "vpp_main" received signal SIGABRT, Aborted. 0x7601b428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 54 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory. (gdb) bt #0 0x7601b428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 #1 0x7601d02a in __GI_abort () at abort.c:89 #2 0x00406a34 in os_panic () at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vpp/vnet/main.c:268 #3 0x768018ff in debugger () at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vppinfra/error.c:84 #4 0x76801d07 in _clib_error (how_to_die=2, function_name=0x0, line_number=0, fmt=0x7754d770 "%s:%d (%s) assertion `%s' fails") at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vppinfra/error.c:143 #5 0x773b18ba in fib_path_get_adj (path_index=12) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_path.c:2085 #6 0x773ac75a in fib_path_list_get_adj (path_list_index=12, type=FIB_FORW_CHAIN_TYPE_UNICAST_IP4) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_path_list.c:1178 #7 0x7739edfe in fib_entry_src_interface_path_swap (src=0x7fffb6393cc4, entry=0x7fffb6aa6e64, pl_flags=FIB_PATH_LIST_FLAG_LOCAL, paths=0x7fffb62db94c) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_entry_src_interface.c:69 #8 0x7739d0cd in fib_entry_src_action_path_swap (fib_entry=0x7fffb6aa6e64, source=FIB_SOURCE_INTERFACE, flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL), rpaths=0x7fffb62db94c) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_entry_src.c:1205 #9 0x77399203 in fib_entry_update (fib_entry_index=8, source=FIB_SOURCE_INTERFACE, flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL), paths=0x7fffb62db94c) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_entry.c:1113 #10 0x7738491c in fib_table_entry_update (fib_index=0, prefix=0x7fffb62fe770, source=FIB_SOURCE_INTERFACE, flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL), paths=0x7fffb62db94c) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_table.c:743 #11 0x77384b14 in fib_table_entry_update_one_path (fib_index=0, prefix=0x7fffb62fe770, source=FIB_SOURCE_INTERFACE, flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL), next_hop_proto=DPO_PROTO_IP4, next_hop=
[vpp-dev] VPP_STABLE_1710 Crash during IP Address Addition #vnet
[Edited Message Follows] Hello, We are using vpp stable release 1710 and encountered vpp crash in the following scenario (IP Address addition) - 1. configure ip 2. configure network / broadcast ip explicitly on same interface Same crash behavior is observed with VPP release 1801 but issue is not seen in release 1804. Since issue was fixed between release 1801 & 1804, I wanted to find out which code change exactly fixes this issue. Could someone please help to get some starting pointers here. In summary - If we have an issue which is fixed in some latest version of the vpp build, how do we track the changes which fixed the issues? Crash scenario example and backtrace - - create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.128/24 <--- valid address set interface ip address EthernetSwitch2/0/0 10.10.10.0/24 <--- network address <<< crash - - create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.128/24 <--- valid address set interface ip address EthernetSwitch2/0/0 10.10.10.255/24 <--- broadcast address <<< crash - - create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.0/24 <--- network address set interface ip address EthernetSwitch2/0/0 10.10.10.255/24 <--- broadcast address <<< crash - DBGvpp# set interface ip address VirtualFunctionEthernet0/5/0 10.10.10.128/24 DBGvpp# create sub VirtualFunctionEthernet0/5/0 8 VirtualFunctionEthernet0/5/0.8 DBGvpp# set interface ip address VirtualFunctionEthernet0/5/0.8 10.10.10.0/24 0: /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_path.c:2085 (fib_path_get_adj) assertion `dpo_is_adj(>fp_dpo)' fails Thread 1 "vpp_main" received signal SIGABRT, Aborted. 0x7601b428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 54../sysdeps/unix/sysv/linux/raise.c: No such file or directory. (gdb) bt #0 0x7601b428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 #1 0x7601d02a in __GI_abort () at abort.c:89 #2 0x00406a34 in os_panic () at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vpp/vnet/main.c:268 #3 0x768018ff in debugger () at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vppinfra/error.c:84 #4 0x76801d07 in _clib_error (how_to_die=2, function_name=0x0, line_number=0, fmt=0x7754d770 "%s:%d (%s) assertion `%s' fails") at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vppinfra/error.c:143 #5 0x773b18ba in fib_path_get_adj (path_index=12) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_path.c:2085 #6 0x773ac75a in fib_path_list_get_adj (path_list_index=12, type=FIB_FORW_CHAIN_TYPE_UNICAST_IP4) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_path_list.c:1178 #7 0x7739edfe in fib_entry_src_interface_path_swap (src=0x7fffb6393cc4, entry=0x7fffb6aa6e64, pl_flags=FIB_PATH_LIST_FLAG_LOCAL, paths=0x7fffb62db94c) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_entry_src_interface.c:69 #8 0x7739d0cd in fib_entry_src_action_path_swap (fib_entry=0x7fffb6aa6e64, source=FIB_SOURCE_INTERFACE, flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL), rpaths=0x7fffb62db94c) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_entry_src.c:1205 #9 0x77399203 in fib_entry_update (fib_entry_index=8, source=FIB_SOURCE_INTERFACE, flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL), paths=0x7fffb62db94c) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_entry.c:1113 #10 0x7738491c in fib_table_entry_update (fib_index=0, prefix=0x7fffb62fe770, source=FIB_SOURCE_INTERFACE, flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL), paths=0x7fffb62db94c) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_table.c:743 #11 0x77384b14 in fib_table_entry_update_one_path (fib_index=0, prefix=0x7fffb62fe770, source=FIB_SOURCE_INTERFACE, flags=(FIB_ENTRY_FLAG_CONNECTED | FIB_ENTRY_FLAG_LOCAL), next_hop_proto=DPO_PROTO_IP4, next_hop=0x7fffb62fe774, next_hop_sw_if_index=3, next_hop_fib_index=4294967295, next_hop_weight=1, next_hop_labels=0x0, path_flags=FIB_ROUTE_PATH_FLAG_NONE) at /home/vagrant/jisaini/fdio/vpp/build-data/../src/vnet/fib/fib_table.c:781 #12 0x76d9a7b0 in ip4_add_interface_routes (sw_if_index=3, im=0x77880920 , fib_index=0, a=0x7fffb62e2760) at
[vpp-dev] VPP_STABLE_1710 Crash during IP Address Addition #vnet
Hello, We are using vpp stable release 1710 and encountered vpp crash in the following scenario (IP Address addition) - 1. configure ip 2. configure network / broadcast ip explicitly on same interface example : - create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.128/24 <--- valid address set interface ip address EthernetSwitch2/0/0 10.10.10.0/24 <--- network address <<< crash - - create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.128/24 <--- valid address set interface ip address EthernetSwitch2/0/0 10.10.10.255/24 <--- broadcast address <<< crash - - create sub EthernetSwitch2/0/0 8 set interface ip address EthernetSwitch2/0/0.8 10.10.10.0/24 <--- network address set interface ip address EthernetSwitch2/0/0 10.10.10.255/24 <--- broadcast address <<< crash - >> Query : Same crash behavior is observed with VPP release 1801 but issue is >> not seen in release 1804. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9909): https://lists.fd.io/g/vpp-dev/message/9909 Mute This Topic: https://lists.fd.io/mt/23791651/21656 Mute #vnet: https://lists.fd.io/mk?hashtag=vnet=1480452 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
