[warzone2100-dev] [Warzone 2100 Trac] #2455: leak fix

[Warzone 2100 Trac]

#2455: leak fix
+
Reporter:  antomL@… |Type:  bug
  Status:  new  |Priority:  major
   Milestone:  unspecified  |   Component:  other
 Version:  git/master   |Keywords:
Operating System:  Windows Vista 64bit  |  Blocked By:
Blocking:   |
+
 dudes, you have multiple memory leaks in the code.
 here is a fix for one of them.
 {{{
 diff --git a/lib/framework/configfile.cpp b/lib/framework/configfile.cpp
 index 8c31783..e392903 100644
 --- a/lib/framework/configfile.cpp
 +++ b/lib/framework/configfile.cpp
 @@ -231,6 +231,7 @@ static bool registry_save(const char* filename)
 size_t w = 0;
 size_t bufferSize = 0;
 unsigned int i;
 +   bool val;

 debug(LOG_WZ, Saving the registry to [directory: %s] %s,
 PHYSFS_getRealDir(filename), filename);
 for (i = 0; i  ARRAY_SIZE(registry); ++i)
 @@ -262,8 +263,9 @@ static bool registry_save(const char* filename)
 free(value);
 }
 }
 -
 -   return saveFile(filename, buffer, w);
 +   val = saveFile(filename, buffer, w);
 +   free(buffer);
 +   return val;
  }

  void setRegistryFilePath(const char* fileName)
 }}}

 dudes, CAN YOU PLEASE REVERT #2444? It causes 353 more warnings and is not
 needed.

-- 
Ticket URL: http://developer.wz2100.net/ticket/2455
Warzone 2100 Trac http://developer.wz2100.net/
The Warzone 2100 Project
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev

Re: [warzone2100-dev] [Warzone 2100 Trac] #340: Sensors and Jammers

[Warzone 2100 Trac]

#340: Sensors and Jammers
-+-
Reporter:  Per   |   Owner:  Per
Type:  patch (an actual patch, not   |  Status:  accepted
  a request for one) |   Milestone:  3.0
Priority:  normal| Version:  git/master
   Component:  Engine: other |Keywords:  ecm sensor
  Resolution:|  Blocked By:
Operating System:  All/Non-Specific  |
Blocking:|
-+-

Comment (by JustLooking2):

 I don't think visualization of ECM should be optional behind a hotkey,
 imho this is not optional information, but rather important one.

 What floats around in my mind about the visuals is that snow storm picture
 you get on analog television sets when there's bad reception. Something
 like this for the fog of war, if this is even possible with the engine. It
 will likely need some tweaking to find a balance between clarity (ie.
 What's happening? think new players, it has to be clear it's intentional
 and not a bug) and annoyance/distraction from gameplay (ie. we're upset
 already there's someone hiding, no need to add insult to injury by making
 people suffer an epileptic shock).

 Also I think it's important that it should not be possible to see which
 player is hiding, unless in LoS of a unit/building (command center
 probably can look further than a repair tower, but that's something else
 altogether).

 I only glanced at the forum and hope I didn't miss a discussion there. I
 just wanted to throw in my 2 cents.

-- 
Ticket URL: http://developer.wz2100.net/ticket/340#comment:23
Warzone 2100 Trac http://developer.wz2100.net/
The Warzone 2100 Project
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev