[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Davide Depau  changed:

   What|Removed |Added

   Assignee|wayland-bugs@lists.freedesk |dav...@depau.eu
   |top.org |
 Resolution|INVALID |---
 Status|RESOLVED|REOPENED

--- Comment #32 from Davide Depau  ---
Created attachment 138882
  --> https://bugs.freedesktop.org/attachment.cgi?id=138882=edit
0001-evdev-don-t-suspend-keyboard-on-ThinkPad-X1-Yoga-1st.patch

Sorry I forgot about this.
Not tested. I will test it later.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Peter Hutterer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEEDINFO|RESOLVED

--- Comment #31 from Peter Hutterer  ---
Closing due to needinfo, please re-open when the information was provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #30 from Davide Depau  ---
Hello Peter,
sorry I've been quite busy lately and had almost no free time.
I plan on working on this in around two weeks once I get some important
stuff done.

On Tue, Apr 3, 2018, 8:41 AM  wrote:

> *Comment # 29  on
> bug 103749  from Peter
> Hutterer  *
>
> ping?
>
> --
> You are receiving this mail because:
>
>- You are on the CC list for the bug.
>
> --

--

Davide Depau

Full-stack developer

http://www.gruppoyec.com


Tel: +39 327 798 7963 <3277987963>




Young Endeavor Consulting srls - via Tortona 33 Milano 20144.

P.IVA 01835450493 <0183%20545%200493>

Ai sensi del Decreto Legislativo n. 196/2003, si precisa che le
informazioni contenute in questo messaggio e negli eventuali allegati
sono riservate e per uso esclusivo del destinatario. Chiunque riceva
questo messaggio per errore, è pregato di distruggerlo e di informarci
immediatamente.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #29 from Peter Hutterer  ---
ping?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #28 from Davide Depau  ---
(In reply to Peter Hutterer from comment #27)
> Comment on attachment 138226 [details] [review]
> 0001-evdev-don-t-suspend-keyboard-on-the-X1-Yoga-1st-DEPAU.patch
> 
> Review of attachment 138226 [details] [review]:
> -
> 
> This should work, but it's inefficient. You're still pairing the tablet mode
> and the keyboard device, installing an event handler, etc. But then you just
> return early when the event comes in. The original patch from comment 15
> just skips the pairing, which means it should have the same effect. So it'd
> be useful to debug why the other patch didn't take effect in
> fallback_keyboard_pair_tablet_mode().

I'll try to check again tomorrow or in the next few days and come up with
something more efficient.

> ::: src/evdev-fallback.c
> @@ +1151,4 @@
> > swev = libinput_event_get_switch_event(event);
> > if (libinput_event_switch_get_switch(swev) !=
> > LIBINPUT_SWITCH_TABLET_MODE)
> > +return;
> 
> detritus, please remove
> 
> @@ +1155,3 @@
> >  
> > +if (device->model_flags & EVDEV_MODEL_TABLET_MODE_NO_SUSPEND)
> > +return;
> 
> please stick to the indentation rules the rest of libinput uses

IDE's fault ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #27 from Peter Hutterer  ---
Comment on attachment 138226
  --> https://bugs.freedesktop.org/attachment.cgi?id=138226
0001-evdev-don-t-suspend-keyboard-on-the-X1-Yoga-1st-DEPAU.patch

Review of attachment 138226:
-

This should work, but it's inefficient. You're still pairing the tablet mode
and the keyboard device, installing an event handler, etc. But then you just
return early when the event comes in. The original patch from comment 15 just
skips the pairing, which means it should have the same effect. So it'd be
useful to debug why the other patch didn't take effect in
fallback_keyboard_pair_tablet_mode().

::: src/evdev-fallback.c
@@ +1151,4 @@
>   swev = libinput_event_get_switch_event(event);
>   if (libinput_event_switch_get_switch(swev) !=
>   LIBINPUT_SWITCH_TABLET_MODE)
> +return;

detritus, please remove

@@ +1155,3 @@
>  
> +if (device->model_flags & EVDEV_MODEL_TABLET_MODE_NO_SUSPEND)
> +return;

please stick to the indentation rules the rest of libinput uses

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #26 from Davide Depau  ---
By the way, the patch should be applied on top of master.

See my fork: https://github.com/Depau/libinput/tree/tablet_mode

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #25 from Davide Depau  ---
Created attachment 138226
  --> https://bugs.freedesktop.org/attachment.cgi?id=138226=edit
0001-evdev-don-t-suspend-keyboard-on-the-X1-Yoga-1st-DEPAU.patch

I tried to check the code and came up with this patch, which fixes this issue.
For some reason, the touchpad not disabled issue seems fixed too. I really hope
somebody fixed it upstream while I was working on this, otherwise I would have
no idea on why it works.

I didn't spend too much time figuring out how libinput really works and how the
functions I changed are called, so I might have fixed it in the wrong place.

Let me know what you think.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Peter Hutterer  changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO

--- Comment #24 from Peter Hutterer  ---
(In reply to Davide Depau from comment #22)
> Created attachment 138192 [details]

event4  - tablet_mode_switch: activated for AT Translated Set 2
keyboard<->ThinkPad Extra Buttons


(In reply to Michał Kopeć from comment #23)
> Created attachment 138195 [details]

event4  - tablet_mode_switch: activated for AT Translated Set 2
keyboard<->ThinkPad Extra Buttons

same thing here

This indicates that the keyboard is still paired for the tablet mode switch. So
either the udev property isn't applied correctly, or the patch isn't working.
Unfortunately I don't currently have time to work on this, sorry.

However, it's easy to debug locally, sudo gdb ./builddir/libinput-debug-events
is all you need. The keyboard is only disabled in that libinput context so it
won't affect your session and you can fake a tablet mode switch with sudo
evemu-event --type EV_SW --code SW_TABLET_MODE --value 1 --sync (and then again
with value 0).


> the property does show up correctly when running udevadm test

just fwwiw: udevadm info shows the current properties, udevadm test shows the
ones to be applied. So without a restart, udevadm test won't really do
anything.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #23 from Michał Kopeć  ---
Created attachment 138195
  --> https://bugs.freedesktop.org/attachment.cgi?id=138195=edit
libinput debug-events --verbose with patch on ThinkPad X60 Tablet

Yes, the property does show up correctly when running udevadm test
/sys/class/input/event4. The patch does not seem to be working for me even
after a restart.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Davide Depau  changed:

   What|Removed |Added

 CC||dav...@depau.eu

--- Comment #22 from Davide Depau  ---
Created attachment 138192
  --> https://bugs.freedesktop.org/attachment.cgi?id=138192=edit
libinput debug-events --verbose with patch, ThinkPad X1 Yoga 1st

Coming here from 101008. I applied the patch to Libinput (latest git, I added
it to the AUR package: https://aur.archlinux.org/packages/libinput-git/, had a
hard time applying it due to changes in evdev.h) and it seems like it's not
working.

Side volume buttons and touchscreen Super key don't work. See `debug-events`
with patch applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Peter Hutterer  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---

--- Comment #21 from Peter Hutterer  ---
Does the LIBINPUT_MODEL_TABLET_MODE_NEEDS_KEYBOARD udev property show up on the
device when you apply the hwdb (and you'll need to restart too)? Please attach
the output of libinput debug-events --verbose with the patch applied

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Michał Kopeć  changed:

   What|Removed |Added

 CC||mkope...@gmail.com

--- Comment #20 from Michał Kopeć  ---
I've managed to adapt the patch (comment #15) to my specific machine and latest
libinput version, but there's no change in behaviour. Let me know if you want
me to run any tests or provide information about my configuration.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #19 from Michał Kopeć  ---
I have the same problem with my ThinkPad X60 hardware tablet buttons. Switching
the machine to laptop mode (rotating the screen) disables the buttons located
on the screen bezel. 

Components:
- libinput 1.10.2
- Arch Linux (kernel 4.15.8)
- GNOME Shell 3.26.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Peter Hutterer  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEEDINFO|RESOLVED

--- Comment #18 from Peter Hutterer  ---
sorry, closing after another 2+ weeks in needinfo. I can't merge these things
without testing the hwdb is not something I can test locally unless I have the
exact same device.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #17 from Phoebe  ---
I'm here! Sorry! Back from holidays.

I shall try building and get back to you.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #16 from Peter Hutterer  ---
ping?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #15 from Peter Hutterer  ---
Created attachment 136243
  --> https://bugs.freedesktop.org/attachment.cgi?id=136243=edit
0001-evdev-don-t-disable-the-keyboard-on-the-Yoga-1-in-ta.patch

Untested, please give it a try, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #14 from Peter Hutterer  ---
To identify the machine, use a DMI match, see
http://wayland.freedesktop.org/libinput/doc/latest/udev_config.html#hwdb for
more info. If you already have something semi-working, you could push it
somewhere (or just send me the patch) and I can see if I can clean it up
quickly. Not sure if I  get to it before you do though :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #13 from Phoebe  ---
Hi Peter,

Life got a bit busy so I haven't been had time to tidy this up to submit a
patch.

I also ran into some issues trying to find a way to actually identify the
machine(/keyboard) to write the appropriate udev rule. I was planning on
posting back for advice once I had a spare evening to get back to this.

Let me know if you'd rather take over and if there's anything I can contribute
to help that along.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Peter Hutterer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO

--- Comment #12 from Peter Hutterer  ---
Hey Phoebe, just wondering what the status of this is?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #11 from Peter Hutterer  ---
oh, good point. yes, if the keyboard is disabled anyway then it's much better
to just have a hw flag for this model and skip the whole code that manually
disables the keyboard.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #9 from Peter Hutterer  ---
there's nothing to ignore a group, sorry. short of just #if 0  in the code :)

The issue is likely one of the tests that triggers an SW_LID which logind takes
as signal to suspend. /etc/systemd/logind.conf has HandleLidSwitch which you
can set to ignore. That should do the trick.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #8 from Phoebe  ---
Point me elsewhere if this is the wrong place to ask this stuff, but-

I'm having trouble getting the full test suite to run properly on the
unmodified code. Is there some clever evocation to ignore a test group? 

I've followed the instructions to avoid tests interfering with xorg, but
something in (as far as I can tell) the lid:buggy group is triggering a system
shutdown.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #7 from Peter Hutterer  ---
not for this particular thing. the todo list is:
* write a test case, tablet_mode_disable_keyboard should serve as good
template. That way you can quickly test and iterate. Make yourself familiar
with the test suite, see
https://wayland.freedesktop.org/libinput/doc/latest/test-suite.html
* the hw quirk will need a hwdb entry, LIBINPUT_ATTR_TABLET_MODE_EXCLUDED_KEYS
or so. look at the history of the .hwdb entry to get a feel for how these are
added. Don't forget the parsing tests and the parser test
* for a device without that property empty keep the current code, might as well
keep it fully disabled (less wakeups)
* for devices with a property, set some state and discard any events except the
quirked ones.

I think that should be about it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #6 from Phoebe  ---
Sure, I'll have a crack at it.

Do you know off hand of any similar issues that have been solved in the past
that might serve as a reference? I'm open to any guidance or suggestions you
might have.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Peter Hutterer  changed:

   What|Removed |Added

 Status|NEEDINFO|ASSIGNED

--- Comment #5 from Peter Hutterer  ---
well, great. this is apparently wired up through the normal keyboard and
pretends to be a windows key. this is going to get a bit more complicated than
I expected because libinput needs to:
* have a hw quirk to note which event codes are permitted on this device even
when tablet mode is on
* have libinput handle this particular case accordingly
* have test cases for it

It's not technically hard, just needs the code to be written. If you want to
have a crack at it let me know because I'm pretty swamped right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #4 from Phoebe  ---
Created attachment 135478
  --> https://bugs.freedesktop.org/attachment.cgi?id=135478=edit
xinput list-props for the device

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

--- Comment #3 from Phoebe  ---
Created attachment 135477
  --> https://bugs.freedesktop.org/attachment.cgi?id=135477=edit
evemu-record output on /dev/input/event4

Ah, whoops!

I've attached a recording from evemu-record. I tapped the bezel button twice,
so there are two sets of events.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Peter Hutterer  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #2 from Peter Hutterer  ---
The xorg Input/libinput component is for the xf86-input-libinput driver, your
first guess was correct :)


I'll need an evemu-record of the device node that provides that button, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Peter Hutterer  changed:

   What|Removed |Added

 CC||peter.hutte...@who-t.net
Product|xorg|Wayland
 QA Contact|xorg-t...@lists.x.org   |
   Assignee|peter.hutte...@who-t.net|wayland-bugs@lists.freedesk
   ||top.org
  Component|Input/libinput  |libinput

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Phoebe  changed:

   What|Removed |Added

   Assignee|wayland-bugs@lists.freedesk |peter.hutte...@who-t.net
   |top.org |
  Component|libinput|Input/libinput
 QA Contact||xorg-t...@lists.x.org
Product|Wayland |xorg

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 103749] SW_TABLET_MODE disables monitor bezel button in tablet mode

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=103749

Bug ID: 103749
   Summary: SW_TABLET_MODE disables monitor bezel button in tablet
mode
   Product: Wayland
   Version: unspecified
  Hardware: Other
OS: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: libinput
  Assignee: wayland-bugs@lists.freedesktop.org
  Reporter: psagor...@gmail.com

Component/OS/Platform Detail: 

- libinput 1.9.1 on Xorg. Arch Linux (4.13.11-1)
- X1 Yoga laptop
- Hotkey handling with shxkd (can be reproduced with xev)

Description:

Converting the laptop to tablet mode disables the capacitive touch (windows)
button on the laptop's lower screen bezel. I believe this is not the intended
behaviour, that button should continue to behave as usual (since it is still
"user facing") in tablet mode.

Ordinarily (in laptop mode) the bezel button can be mapped via shxkd with
keycode 133 (Super_L), but in tablet mode these bindings stop working.

Steps to reproduce:

- In laptop mode, run xev (filtering KeyPress events)
$ xev | awk -F'[ )]+' '/^KeyPress/ { a[NR+2] } NR in a { printf "%-3s %s\n",
$5, $8 }'

- tapping the bezel button repeatedly produces:
133 Super_L
133 Super_L
133 Super_L

- with xev still running, switch to tablet mode
- tapping the windows button produces no output.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs