[webkit-changes] [88143] trunk/LayoutTests
Title: [88143] trunk/LayoutTests Revision 88143 Author o...@webkit.org Date 2011-06-05 23:12:05 -0700 (Sun, 05 Jun 2011) Log Message [Qt][WK2] Unreviewed. Update platform specific expected files after r88020. * platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: * platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (88142 => 88143) --- trunk/LayoutTests/ChangeLog 2011-06-06 05:54:27 UTC (rev 88142) +++ trunk/LayoutTests/ChangeLog 2011-06-06 06:12:05 UTC (rev 88143) @@ -1,5 +1,12 @@ 2011-06-05 Csaba Osztrogonác o...@webkit.org +[Qt][WK2] Unreviewed. Update platform specific expected files after r88020. + +* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: +* platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt: + +2011-06-05 Csaba Osztrogonác o...@webkit.org + [Qt] Unreviewed trivial fix. * platform/qt/Skipped: Remove svg/hixie/links/003-broken.xml, because it was deleted by r87518. Modified: trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt (88142 => 88143) --- trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt 2011-06-06 05:54:27 UTC (rev 88142) +++ trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-properties-expected.txt 2011-06-06 06:12:05 UTC (rev 88143) @@ -1413,6 +1413,8 @@ window.SVGAnimateColorElement.prototype [printed above as window.Element.prototype] window.SVGAnimateElement [object SVGAnimateElementConstructor] window.SVGAnimateElement.prototype [printed above as window.Element.prototype] +window.SVGAnimateMotionElement [object SVGAnimateMotionElementConstructor] +window.SVGAnimateMotionElement.prototype [printed above as window.Element.prototype] window.SVGAnimateTransformElement [object SVGAnimateTransformElementConstructor] window.SVGAnimateTransformElement.prototype [printed above as window.Element.prototype] window.SVGAnimatedAngle [object SVGAnimatedAngleConstructor] @@ -1641,6 +1643,8 @@ window.SVGLineElement.prototype [printed above as window.Element.prototype] window.SVGLinearGradientElement [object SVGLinearGradientElementConstructor] window.SVGLinearGradientElement.prototype [printed above as window.Element.prototype] +window.SVGMPathElement [object SVGMPathElementConstructor] +window.SVGMPathElement.prototype [printed above as window.Element.prototype] window.SVGMarkerElement [object SVGMarkerElementConstructor] window.SVGMarkerElement.SVG_MARKERUNITS_STROKEWIDTH [number] window.SVGMarkerElement.SVG_MARKERUNITS_UNKNOWN [number] Modified: trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt (88142 => 88143) --- trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt 2011-06-06 05:54:27 UTC (rev 88142) +++ trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt 2011-06-06 06:12:05 UTC (rev 88143) @@ -169,6 +169,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAngle') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateColorElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateElement') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateMotionElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateTransformElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimatedAngle') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimatedBoolean') is 'object' @@ -237,6 +238,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGLengthList') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGLineElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGLinearGradientElement') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMPathElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMarkerElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMaskElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMatrix') is 'object' ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88144] trunk
Title: [88144] trunk Revision 88144 Author commit-qu...@webkit.org Date 2011-06-06 00:27:29 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Mustafizur Rahaman mustaf.h...@gmail.com Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=48290 Removed LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html from failed/skipped test list * platform/chromium/test_expectations.txt: * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: 2011-06-06 Mustafizur Rahaman mustaf.h...@gmail.com Reviewed by Darin Adler. Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html https://bugs.webkit.org/show_bug.cgi?id=48290 highlight is not a valid globalComposite operation as per http://www.w3.org/TR/2011/WD-2dcontext-20110525/#compositing Therefore, removed the option from the source code. Tests: No new tests required. LayoutTests\canvas\philip\tests\2d.composite.operation.highlight.html can be used for testing. * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator CompositeOperator): * platform/graphics/GraphicsTypes.cpp: * platform/graphics/GraphicsTypes.h: * platform/graphics/cairo/CairoUtilities.cpp: (WebCore::toCairoOperator): * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformCompositeOperation): * platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::applyCompositeOperator): * platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::applyBlending): * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): * platform/graphics/skia/SkiaUtils.cpp: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/qt/Skipped trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/platform/graphics/GraphicsTypes.cpp trunk/Source/WebCore/platform/graphics/GraphicsTypes.h trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp trunk/Source/WebCore/platform/graphics/openvg/PainterOpenVG.cpp trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp trunk/Source/WebCore/platform/graphics/skia/SkiaUtils.cpp Diff Modified: trunk/LayoutTests/ChangeLog (88143 => 88144) --- trunk/LayoutTests/ChangeLog 2011-06-06 06:12:05 UTC (rev 88143) +++ trunk/LayoutTests/ChangeLog 2011-06-06 07:27:29 UTC (rev 88144) @@ -1,3 +1,16 @@ +2011-06-06 Mustafizur Rahaman mustaf.h...@gmail.com + +Reviewed by Darin Adler. + +https://bugs.webkit.org/show_bug.cgi?id=48290 +Removed LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html +from failed/skipped test list + +* platform/chromium/test_expectations.txt: +* platform/gtk/Skipped: +* platform/mac/Skipped: +* platform/qt/Skipped: + 2011-06-05 Csaba Osztrogonác o...@webkit.org [Qt][WK2] Unreviewed. Update platform specific expected files after r88020. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88143 => 88144) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-06 06:12:05 UTC (rev 88143) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-06 07:27:29 UTC (rev 88144) @@ -1977,7 +1977,6 @@ BUGWK48288 : canvas/philip/tests/2d.composite.operation.clear.html = TEXT BUGWK48289 : canvas/philip/tests/2d.composite.operation.darker.html = TEXT -BUGWK48290 : canvas/philip/tests/2d.composite.operation.highlight.html = TEXT BUGWK39177 : canvas/philip/tests/2d.composite.uncovered.fill.copy.html = TEXT BUGWK39177 : canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.html = TEXT BUGWK39177 : canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html = TEXT Modified: trunk/LayoutTests/platform/gtk/Skipped (88143 => 88144) --- trunk/LayoutTests/platform/gtk/Skipped 2011-06-06 06:12:05 UTC (rev 88143) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-06-06 07:27:29 UTC (rev 88144) @@ -1070,7 +1070,6 @@ #without our vendor prefix since it was around in canvas before the spec was written. canvas/philip/tests/2d.composite.operation.clear.html canvas/philip/tests/2d.composite.operation.darker.html -canvas/philip/tests/2d.composite.operation.highlight.html canvas/philip/tests/2d.composite.uncovered.fill.copy.html canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.html
[webkit-changes] [88145] trunk
Title: [88145] trunk Revision 88145 Author carlo...@webkit.org Date 2011-06-06 00:57:26 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Carlos Garcia Campos cgar...@igalia.com Unreviewed. Fix the GTK+ build. * GNUmakefile.am: Add _javascript_core_cflags variable. 2011-06-06 Carlos Garcia Campos cgar...@igalia.com Unreviewed. Fix the GTK+ build. * GNUmakefile.am: Add _javascript_core_cflags variable. 2011-06-06 Carlos Garcia Campos cgar...@igalia.com Unreviewed. Fix the GTK+ build. * GNUmakefile.am: Use _javascript_core_cflags when building libWebCoreInternals. Modified Paths trunk/ChangeLog trunk/GNUmakefile.am trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.am trunk/Tools/ChangeLog trunk/Tools/GNUmakefile.am Diff Modified: trunk/ChangeLog (88144 => 88145) --- trunk/ChangeLog 2011-06-06 07:27:29 UTC (rev 88144) +++ trunk/ChangeLog 2011-06-06 07:57:26 UTC (rev 88145) @@ -1,3 +1,9 @@ +2011-06-06 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Fix the GTK+ build. + +* GNUmakefile.am: Add _javascript_core_cflags variable. + 2011-06-04 Kevin Ollivier kev...@theolliviers.com [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures Modified: trunk/GNUmakefile.am (88144 => 88145) --- trunk/GNUmakefile.am 2011-06-06 07:27:29 UTC (rev 88144) +++ trunk/GNUmakefile.am 2011-06-06 07:57:26 UTC (rev 88145) @@ -53,6 +53,7 @@ MOFILES := _javascript_core_h_api := _javascript_core_cppflags:= +_javascript_core_cflags := _javascript_core_sources := _javascript_core_built_sources := _javascript_core_built_nosources := Modified: trunk/Source/_javascript_Core/ChangeLog (88144 => 88145) --- trunk/Source/_javascript_Core/ChangeLog 2011-06-06 07:27:29 UTC (rev 88144) +++ trunk/Source/_javascript_Core/ChangeLog 2011-06-06 07:57:26 UTC (rev 88145) @@ -1,3 +1,9 @@ +2011-06-06 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Fix the GTK+ build. + +* GNUmakefile.am: Add _javascript_core_cflags variable. + 2011-06-04 Kevin Ollivier kev...@theolliviers.com [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures Modified: trunk/Source/_javascript_Core/GNUmakefile.am (88144 => 88145) --- trunk/Source/_javascript_Core/GNUmakefile.am 2011-06-06 07:27:29 UTC (rev 88144) +++ trunk/Source/_javascript_Core/GNUmakefile.am 2011-06-06 07:57:26 UTC (rev 88145) @@ -35,9 +35,7 @@ libjavascriptcoregtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_la_CFLAGS = \ -fstrict-aliasing \ -O3 \ - $(global_cflags) \ - $(GLIB_CFLAGS) \ - $(UNICODE_CFLAGS) + $(_javascript_core_cflags) libjavascriptcoregtk_@WEBKITGTK_API_MAJOR_VERSION@_@WEBKITGTK_API_MINOR_VERSION@_la_CPPFLAGS = \ $(global_cppflags) \ @@ -70,6 +68,11 @@ -I$(top_builddir)/Source/_javascript_Core/parser \ -I$(top_builddir)/Source/_javascript_Core/runtime +_javascript_core_cflags += \ + $(global_cflags) \ + $(GLIB_CFLAGS) \ + $(UNICODE_CFLAGS) + Source/_javascript_Core/Lexer.lut.h: $(srcdir)/Source/_javascript_Core/create_hash_table $(srcdir)/Source/_javascript_Core/parser/Keywords.table $(AM_V_GEN)$(PERL) $^ $@ Modified: trunk/Tools/ChangeLog (88144 => 88145) --- trunk/Tools/ChangeLog 2011-06-06 07:27:29 UTC (rev 88144) +++ trunk/Tools/ChangeLog 2011-06-06 07:57:26 UTC (rev 88145) @@ -1,3 +1,9 @@ +2011-06-06 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Fix the GTK+ build. + +* GNUmakefile.am: Use _javascript_core_cflags when building libWebCoreInternals. + 2011-06-05 Alexey Proskuryakov a...@apple.com Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion Modified: trunk/Tools/GNUmakefile.am (88144 => 88145) --- trunk/Tools/GNUmakefile.am 2011-06-06 07:27:29 UTC (rev 88144) +++ trunk/Tools/GNUmakefile.am 2011-06-06 07:57:26 UTC (rev 88145) @@ -61,8 +61,12 @@ -I$(top_builddir)/DerivedSources/WebCore libWebCoreInternals_la_CXXFLAGS = \ + $(global_cxxflags) \ + $(libWebCoreInternals_la_CFLAGS) + +libWebCoreInternals_la_CFLAGS = \ -fno-strict-aliasing \ - $(global_cxxflags) + $(_javascript_core_cflags) # DumpRenderTree Programs_DumpRenderTree_CPPFLAGS = \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88146] trunk/Source/WebCore
Title: [88146] trunk/Source/WebCore
Revision 88146
Author h...@chromium.org
Date 2011-06-06 01:09:17 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-03 Hans Wennborg h...@chromium.org
Reviewed by Tony Gentilcore.
IndexedDB: Clean-up function prototypes in IDBLevelDBBackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=62013
Clean up the prototypes for cursor open functions by introducing the
CursorOptions struct.
Just clean-up, no new functionality so no new tests.
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::CursorOptions::CursorImplCommon::CursorImplCommon):
(WebCore::CursorOptions::CursorImplCommon::firstSeek):
(WebCore::CursorOptions::CursorImplCommon::continueFunction):
(WebCore::CursorOptions::ObjectStoreCursorImpl::create):
(WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::CursorOptions::IndexKeyCursorImpl::create):
(WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::CursorOptions::IndexCursorImpl::create):
(WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBLevelDBBackingStore.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (88145 => 88146)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 07:57:26 UTC (rev 88145)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 08:09:17 UTC (rev 88146)
@@ -1,3 +1,29 @@
+2011-06-03 Hans Wennborg h...@chromium.org
+
+Reviewed by Tony Gentilcore.
+
+IndexedDB: Clean-up function prototypes in IDBLevelDBBackingStore.cpp
+https://bugs.webkit.org/show_bug.cgi?id=62013
+
+Clean up the prototypes for cursor open functions by introducing the
+CursorOptions struct.
+
+Just clean-up, no new functionality so no new tests.
+
+* storage/IDBLevelDBBackingStore.cpp:
+(WebCore::CursorOptions::CursorImplCommon::CursorImplCommon):
+(WebCore::CursorOptions::CursorImplCommon::firstSeek):
+(WebCore::CursorOptions::CursorImplCommon::continueFunction):
+(WebCore::CursorOptions::ObjectStoreCursorImpl::create):
+(WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
+(WebCore::CursorOptions::IndexKeyCursorImpl::create):
+(WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl):
+(WebCore::CursorOptions::IndexCursorImpl::create):
+(WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl):
+(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
+(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
+(WebCore::IDBLevelDBBackingStore::openIndexCursor):
+
2011-06-06 Mustafizur Rahaman mustaf.h...@gmail.com
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/storage/IDBLevelDBBackingStore.cpp (88145 => 88146)
--- trunk/Source/WebCore/storage/IDBLevelDBBackingStore.cpp 2011-06-06 07:57:26 UTC (rev 88145)
+++ trunk/Source/WebCore/storage/IDBLevelDBBackingStore.cpp 2011-06-06 08:09:17 UTC (rev 88146)
@@ -816,6 +816,16 @@
}
namespace {
+
+struct CursorOptions {
+Vectorchar lowKey;
+bool lowOpen;
+Vectorchar highKey;
+bool highOpen;
+bool forward;
+bool unique;
+};
+
class CursorImplCommon : public IDBBackingStore::Cursor {
public:
// IDBBackingStore::Cursor
@@ -831,26 +841,16 @@
bool firstSeek();
protected:
-CursorImplCommon(LevelDBTransaction* transaction, const Vectorchar lowKey, bool lowOpen, const Vectorchar highKey, bool highOpen, bool forward, bool unique)
+CursorImplCommon(LevelDBTransaction* transaction, const CursorOptions cursorOptions)
: m_transaction(transaction)
-, m_lowKey(lowKey)
-, m_lowOpen(lowOpen)
-, m_highKey(highKey)
-, m_highOpen(highOpen)
-, m_forward(forward)
-, m_unique(unique)
+, m_cursorOptions(cursorOptions)
{
}
virtual ~CursorImplCommon() {}
LevelDBTransaction* m_transaction;
+CursorOptions m_cursorOptions;
OwnPtrLevelDBIterator m_iterator;
-Vectorchar m_lowKey;
-bool m_lowOpen;
-Vectorchar m_highKey;
-bool m_highOpen;
-bool m_forward;
-bool m_unique;
RefPtrIDBKey m_currentKey;
};
@@ -858,41 +858,41 @@
{
m_iterator = m_transaction-createIterator();
-if (m_forward)
-m_iterator-seek(m_lowKey);
+if (m_cursorOptions.forward)
+m_iterator-seek(m_cursorOptions.lowKey);
else
-m_iterator-seek(m_highKey);
+m_iterator-seek(m_cursorOptions.highKey);
for (;;) {
if (!m_iterator-isValid())
return false;
-if (m_forward m_highOpen
[webkit-changes] [88147] trunk/Source/WebKit2
Title: [88147] trunk/Source/WebKit2
Revision 88147
Author carlo...@webkit.org
Date 2011-06-06 01:35:50 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Carlos Garcia Campos cgar...@igalia.com
Reviewed by Anders Carlsson.
[UNIX] SOCK_DGRAM sockets are not notified when the other end closes the connection
https://bugs.webkit.org/show_bug.cgi?id=61538
Use SOCK_STREAM instead of SOCK_DGRAM sockets. Rework the message
receiver code to support stream sockets, since it requires to
handle message boundaries. The same code works for DGRAM sockets,
so this change shouldn't break other ports using DGRAM.
* Platform/CoreIPC/Connection.h:
* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::processMessage): Process messages from data
already received.
(CoreIPC::readBytesFromSocket): Read from socket using recvmsg().
(CoreIPC::Connection::readyReadHandler):
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM in
socketpair().
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/Connection.h
trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp
trunk/Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (88146 => 88147)
--- trunk/Source/WebKit2/ChangeLog 2011-06-06 08:09:17 UTC (rev 88146)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-06 08:35:50 UTC (rev 88147)
@@ -1 +1,24 @@
+2011-06-06 Carlos Garcia Campos cgar...@igalia.com
+
+Reviewed by Anders Carlsson.
+
+[UNIX] SOCK_DGRAM sockets are not notified when the other end closes the connection
+https://bugs.webkit.org/show_bug.cgi?id=61538
+
+Use SOCK_STREAM instead of SOCK_DGRAM sockets. Rework the message
+receiver code to support stream sockets, since it requires to
+handle message boundaries. The same code works for DGRAM sockets,
+so this change shouldn't break other ports using DGRAM.
+
+* Platform/CoreIPC/Connection.h:
+* Platform/CoreIPC/unix/ConnectionUnix.cpp:
+(CoreIPC::Connection::platformInitialize):
+(CoreIPC::Connection::processMessage): Process messages from data
+already received.
+(CoreIPC::readBytesFromSocket): Read from socket using recvmsg().
+(CoreIPC::Connection::readyReadHandler):
+* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
+(WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM in
+socketpair().
+
== Rolled over to ChangeLog-2011-06-04 ==
Modified: trunk/Source/WebKit2/Platform/CoreIPC/Connection.h (88146 => 88147)
--- trunk/Source/WebKit2/Platform/CoreIPC/Connection.h 2011-06-06 08:09:17 UTC (rev 88146)
+++ trunk/Source/WebKit2/Platform/CoreIPC/Connection.h 2011-06-06 08:35:50 UTC (rev 88147)
@@ -337,9 +337,12 @@
#elif USE(UNIX_DOMAIN_SOCKETS) || OS(SYMBIAN)
// Called on the connection queue.
void readyReadHandler();
+bool processMessage();
Vectoruint8_t m_readBuffer;
-size_t m_currentMessageSize;
+size_t m_readBufferSize;
+Vectorint m_fileDescriptors;
+size_t m_fileDescriptorsSize;
int m_socketDescriptor;
#if PLATFORM(QT)
Modified: trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp (88146 => 88147)
--- trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp 2011-06-06 08:09:17 UTC (rev 88146)
+++ trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp 2011-06-06 08:35:50 UTC (rev 88147)
@@ -93,7 +93,9 @@
{
m_socketDescriptor = identifier;
m_readBuffer.resize(messageMaxSize);
-m_currentMessageSize = 0;
+m_readBufferSize = 0;
+m_fileDescriptors.resize(attachmentMaxAmount);
+m_fileDescriptorsSize = 0;
#if PLATFORM(QT)
m_socketNotifier = 0;
@@ -157,116 +159,181 @@
T m_attachments;
};
-void Connection::readyReadHandler()
+bool Connection::processMessage()
{
+if (m_readBufferSize sizeof(MessageInfo))
+return false;
+
+uint8_t* messageData = m_readBuffer.data();
+MessageInfo messageInfo;
+memcpy(messageInfo, messageData, sizeof(messageInfo));
+messageData += sizeof(messageInfo);
+
+size_t messageLength = sizeof(MessageInfo) + messageInfo.attachmentCount() * sizeof(size_t) + (messageInfo.isMessageBodyOOL() ? 0 : messageInfo.bodySize());
+if (m_readBufferSize messageLength)
+return false;
+
DequeAttachment attachments;
-#if PLATFORM(QT)
-SocketNotifierResourceGuard socketNotifierEnabler(m_socketNotifier);
-#endif
AttachmentResourceGuardDequeAttachment, DequeAttachment::iterator attachementDisposer(attachments);
+RefPtrWebKit::SharedMemory oolMessageBody;
-OwnArrayPtrchar attachmentDescriptorBuffer = adoptArrayPtr(new char[CMSG_SPACE(sizeof(int) * (attachmentMaxAmount))]);
[webkit-changes] [88148] trunk
Title: [88148] trunk Revision 88148 Author commit-qu...@webkit.org Date 2011-06-06 01:46:21 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Mihnea Ovidenie mih...@adobe.com Reviewed by Kent Tamura. Add ENABLE(CSS_REGIONS) guard for CSS Regions support https://bugs.webkit.org/show_bug.cgi?id=61631 * Configurations/FeatureDefines.xcconfig: 2011-06-06 Mihnea Ovidenie mih...@adobe.com Reviewed by Kent Tamura. Add ENABLE(CSS_REGIONS) guard for CSS Regions support https://bugs.webkit.org/show_bug.cgi?id=61631 This patch modifies only the build system. Therefore, there are no new tests. * Configurations/FeatureDefines.xcconfig: 2011-06-06 Mihnea Ovidenie mih...@adobe.com Reviewed by Kent Tamura. Add ENABLE(CSS_REGIONS) guard for CSS Regions support https://bugs.webkit.org/show_bug.cgi?id=61631 * Configurations/FeatureDefines.xcconfig: 2011-06-06 Mihnea Ovidenie mih...@adobe.com Reviewed by Kent Tamura. Add ENABLE(CSS_REGIONS) guard for CSS Regions support https://bugs.webkit.org/show_bug.cgi?id=61631 * Configurations/FeatureDefines.xcconfig: 2011-06-06 Mihnea Ovidenie mih...@adobe.com Reviewed by Kent Tamura. Add ENABLE(CSS_REGIONS) guard for CSS Regions support https://bugs.webkit.org/show_bug.cgi?id=61631 * Scripts/build-webkit: 2011-06-06 Mihnea Ovidenie mih...@adobe.com Reviewed by Kent Tamura. Add ENABLE(CSS_REGIONS) guard for CSS Regions support https://bugs.webkit.org/show_bug.cgi?id=61631 * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/Scripts/build-webkit trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops Diff Modified: trunk/Source/_javascript_Core/ChangeLog (88147 => 88148) --- trunk/Source/_javascript_Core/ChangeLog 2011-06-06 08:35:50 UTC (rev 88147) +++ trunk/Source/_javascript_Core/ChangeLog 2011-06-06 08:46:21 UTC (rev 88148) @@ -1,3 +1,12 @@ +2011-06-06 Mihnea Ovidenie mih...@adobe.com + +Reviewed by Kent Tamura. + +Add ENABLE(CSS_REGIONS) guard for CSS Regions support +https://bugs.webkit.org/show_bug.cgi?id=61631 + +* Configurations/FeatureDefines.xcconfig: + 2011-06-06 Carlos Garcia Campos cgar...@igalia.com Unreviewed. Fix the GTK+ build. Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (88147 => 88148) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2011-06-06 08:35:50 UTC (rev 88147) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2011-06-06 08:46:21 UTC (rev 88148) @@ -62,6 +62,8 @@ ENABLE_CLIENT_BASED_GEOLOCATION = $(ENABLE_CLIENT_BASED_GEOLOCATION_$(REAL_PLATFORM_NAME)); ENABLE_CLIENT_BASED_GEOLOCATION_macosx = ENABLE_CLIENT_BASED_GEOLOCATION; +ENABLE_CSS_REGIONS = ; + ENABLE_DATABASE = ENABLE_DATABASE; ENABLE_DATALIST = $(ENABLE_DATALIST_$(REAL_PLATFORM_NAME)); @@ -135,4 +137,4 @@ ENABLE_XPATH = ENABLE_XPATH; ENABLE_XSLT = ENABLE_XSLT; -FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_QUOTA) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); +FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH)
[webkit-changes] [88149] trunk/LayoutTests
Title: [88149] trunk/LayoutTests
Revision 88149
Author morr...@google.com
Date 2011-06-06 02:29:45 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-02 MORITA Hajime morr...@google.com
Verify cloning meter and progress works
https://bugs.webkit.org/show_bug.cgi?id=61986
Added test cases for cloning meter and progress
* fast/dom/HTMLMeterElement/meter-clone-expected.txt: Added.
* fast/dom/HTMLMeterElement/meter-clone.html: Added.
* fast/dom/HTMLProgressElement/progress-clone-expected.txt: Added.
* fast/dom/HTMLProgressElement/progress-clone.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt
trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html
trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-clone-expected.txt
trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-clone.html
Diff
Modified: trunk/LayoutTests/ChangeLog (88148 => 88149)
--- trunk/LayoutTests/ChangeLog 2011-06-06 08:46:21 UTC (rev 88148)
+++ trunk/LayoutTests/ChangeLog 2011-06-06 09:29:45 UTC (rev 88149)
@@ -1,3 +1,15 @@
+2011-06-02 MORITA Hajime morr...@google.com
+
+Verify cloning meter and progress works
+https://bugs.webkit.org/show_bug.cgi?id=61986
+
+Added test cases for cloning meter and progress
+
+* fast/dom/HTMLMeterElement/meter-clone-expected.txt: Added.
+* fast/dom/HTMLMeterElement/meter-clone.html: Added.
+* fast/dom/HTMLProgressElement/progress-clone-expected.txt: Added.
+* fast/dom/HTMLProgressElement/progress-clone.html: Added.
+
2011-06-06 Mustafizur Rahaman mustaf.h...@gmail.com
Reviewed by Darin Adler.
Added: trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt (0 => 88149)
--- trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt 2011-06-06 09:29:45 UTC (rev 88149)
@@ -0,0 +1,9 @@
+PASS cloned.value is target.value
+PASS layoutTestController.shadowPseudoId(clonedShadowRoot.firstChild) is layoutTestController.shadowPseudoId(targetShadowRoot.firstChild)
+PASS layoutTestController.shadowPseudoId(clonedShadowRoot.firstChild.firstChild) is layoutTestController.shadowPseudoId(targetShadowRoot.firstChild.firstChild)
+PASS clonedShadowRoot.firstChild.firstChild.style.width is 70%
+PASS targetShadowRoot.firstChild.firstChild.style.width is 50%
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-clone-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html (0 => 88149)
--- trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html 2011-06-06 09:29:45 UTC (rev 88149)
@@ -0,0 +1,35 @@
+html
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+meter id=target min=0 max=100 value=50 style=-webkit-appearance: none; /
+script
+(function() {
+target = document.getElementById(target);
+cloned = target.cloneNode();
+document.body.insertBefore(cloned, target.nextSibling);
+
+if (!window.layoutTestController) {
+debug(You need layoutTestController to run this test.);
+return;
+}
+
+targetShadowRoot = layoutTestController.shadowRoot(target);
+clonedShadowRoot = layoutTestController.shadowRoot(cloned);
+
+shouldBe(cloned.value, target.value);
+shouldBe(layoutTestController.shadowPseudoId(clonedShadowRoot.firstChild), layoutTestController.shadowPseudoId(targetShadowRoot.firstChild));
+shouldBe(layoutTestController.shadowPseudoId(clonedShadowRoot.firstChild.firstChild), layoutTestController.shadowPseudoId(targetShadowRoot.firstChild.firstChild));
+cloned.value = 70;
+shouldBe(clonedShadowRoot.firstChild.firstChild.style.width, '70%');
+shouldBe(targetShadowRoot.firstChild.firstChild.style.width, '50%');
+})();
+var successfullyParsed = true;
+/script
+script src=""
+/body
+/html
Property changes on: trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-clone.html
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-clone-expected.txt (0 => 88149)
--- trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-clone-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-clone-expected.txt 2011-06-06 09:29:45 UTC (rev 88149)
@@ -0,0 +1,9 @@
+PASS cloned.value is target.value
+PASS layoutTestController.shadowPseudoId(clonedShadowRoot.firstChild) is
[webkit-changes] [88150] trunk/LayoutTests
Title: [88150] trunk/LayoutTests
Revision 88150
Author ma...@webkit.org
Date 2011-06-06 02:36:06 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Mario Sanchez Prada msanc...@igalia.com
Unreviewed, new baselines for GTK after r88029 and r80034.
* platform/gtk/fast/forms/selectlist-minsize-expected.png: Added.
* platform/gtk/fast/forms/selectlist-minsize-expected.txt: Added.
* platform/gtk/fullscreen/full-screen-placeholder-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/gtk/fast/forms/selectlist-minsize-expected.png
trunk/LayoutTests/platform/gtk/fast/forms/selectlist-minsize-expected.txt
trunk/LayoutTests/platform/gtk/fullscreen/full-screen-placeholder-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (88149 => 88150)
--- trunk/LayoutTests/ChangeLog 2011-06-06 09:29:45 UTC (rev 88149)
+++ trunk/LayoutTests/ChangeLog 2011-06-06 09:36:06 UTC (rev 88150)
@@ -1,3 +1,11 @@
+2011-06-06 Mario Sanchez Prada msanc...@igalia.com
+
+Unreviewed, new baselines for GTK after r88029 and r80034.
+
+* platform/gtk/fast/forms/selectlist-minsize-expected.png: Added.
+* platform/gtk/fast/forms/selectlist-minsize-expected.txt: Added.
+* platform/gtk/fullscreen/full-screen-placeholder-expected.txt: Added.
+
2011-06-02 MORITA Hajime morr...@google.com
Verify cloning meter and progress works
Added: trunk/LayoutTests/platform/gtk/fast/forms/selectlist-minsize-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/gtk/fast/forms/selectlist-minsize-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/gtk/fast/forms/selectlist-minsize-expected.txt (0 => 88150)
--- trunk/LayoutTests/platform/gtk/fast/forms/selectlist-minsize-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/forms/selectlist-minsize-expected.txt 2011-06-06 09:36:06 UTC (rev 88150)
@@ -0,0 +1,9 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x47
+ RenderBlock {HTML} at (0,0) size 800x47
+RenderBody {BODY} at (8,8) size 784x31
+ RenderMenuList {SELECT} at (2,2) size 28x27 [bgcolor=#FF] [border: (1px solid #00)]
+RenderBlock (anonymous) at (1,1) size 26x25
+ RenderBR at (3,3) size 0x19 [bgcolor=#FF]
+ RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/platform/gtk/fullscreen/full-screen-placeholder-expected.txt (0 => 88150)
--- trunk/LayoutTests/platform/gtk/fullscreen/full-screen-placeholder-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fullscreen/full-screen-placeholder-expected.txt 2011-06-06 09:36:06 UTC (rev 88150)
@@ -0,0 +1,17 @@
+This layout test checks that the offset positions of the blue and green divs does not change when the red div enters full-screen mode. Press go full-screen to begin.
+One
+Two
+EVENT(webkitfullscreenchange)
+EXPECTED (document.webkitCurrentFullScreenElement == '[object HTMLDivElement]') OK
+EXPECTED (one.offsetLeft == '68') OK
+EXPECTED (one.offsetTop == '59') OK
+EXPECTED (two.offsetLeft == '8') OK
+EXPECTED (two.offsetTop == '119') OK
+EVENT(webkitfullscreenchange)
+EXPECTED (document.webkitCurrentFullScreenElement == 'null') OK
+EXPECTED (one.offsetLeft == '68') OK
+EXPECTED (one.offsetTop == '59') OK
+EXPECTED (two.offsetLeft == '8') OK
+EXPECTED (two.offsetTop == '119') OK
+END OF TEST
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88151] trunk
Title: [88151] trunk Revision 88151 Author commit-qu...@webkit.org Date 2011-06-06 03:45:12 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Alexandru Chiculita ach...@adobe.com Reviewed by Kent Tamura. Add ENABLE_CSS_EXCLUSIONS support for build-webkit script https://bugs.webkit.org/show_bug.cgi?id=61628 * Configurations/FeatureDefines.xcconfig: 2011-06-06 Alexandru Chiculita ach...@adobe.com Reviewed by Kent Tamura. Add ENABLE_CSS_EXCLUSIONS support for build-webkit script https://bugs.webkit.org/show_bug.cgi?id=61628 This patch modifies only the build system. Therefore, there are no new tests. * Configurations/FeatureDefines.xcconfig: 2011-06-06 Alexandru Chiculita ach...@adobe.com Reviewed by Kent Tamura. Add ENABLE_CSS_EXCLUSIONS support for build-webkit script https://bugs.webkit.org/show_bug.cgi?id=61628 * Configurations/FeatureDefines.xcconfig: 2011-06-06 Alexandru Chiculita ach...@adobe.com Reviewed by Kent Tamura. Add ENABLE_CSS_EXCLUSIONS support for build-webkit script https://bugs.webkit.org/show_bug.cgi?id=61628 * Configurations/FeatureDefines.xcconfig: 2011-06-06 Alexandru Chiculita ach...@adobe.com Reviewed by Kent Tamura. Add ENABLE_CSS_EXCLUSIONS support for build-webkit script https://bugs.webkit.org/show_bug.cgi?id=61628 * Scripts/build-webkit: 2011-06-06 Alexandru Chiculita ach...@adobe.com Reviewed by Kent Tamura. Add ENABLE_CSS_EXCLUSIONS support for build-webkit script https://bugs.webkit.org/show_bug.cgi?id=61628 * win/tools/vsprops/FeatureDefines.vsprops: * win/tools/vsprops/FeatureDefinesCairo.vsprops: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/Scripts/build-webkit trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops Diff Modified: trunk/Source/_javascript_Core/ChangeLog (88150 => 88151) --- trunk/Source/_javascript_Core/ChangeLog 2011-06-06 09:36:06 UTC (rev 88150) +++ trunk/Source/_javascript_Core/ChangeLog 2011-06-06 10:45:12 UTC (rev 88151) @@ -1,3 +1,12 @@ +2011-06-06 Alexandru Chiculita ach...@adobe.com + +Reviewed by Kent Tamura. + +Add ENABLE_CSS_EXCLUSIONS support for build-webkit script +https://bugs.webkit.org/show_bug.cgi?id=61628 + +* Configurations/FeatureDefines.xcconfig: + 2011-06-06 Mihnea Ovidenie mih...@adobe.com Reviewed by Kent Tamura. Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (88150 => 88151) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2011-06-06 09:36:06 UTC (rev 88150) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2011-06-06 10:45:12 UTC (rev 88151) @@ -63,6 +63,7 @@ ENABLE_CLIENT_BASED_GEOLOCATION_macosx = ENABLE_CLIENT_BASED_GEOLOCATION; ENABLE_CSS_REGIONS = ; +ENABLE_CSS_EXCLUSIONS = ; ENABLE_DATABASE = ENABLE_DATABASE; @@ -137,4 +138,4 @@ ENABLE_XPATH = ENABLE_XPATH; ENABLE_XSLT = ENABLE_XSLT; -FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS_REGIONS) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILTERS) $(ENABLE_FILE_SYSTEM) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_MATHML) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_QUOTA) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XHTMLMP) $(ENABLE_XPATH) $(ENABLE_XSLT); +FEATURE_DEFINES = $(ENABLE_LINK_PREFETCH) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_WEBGL) $(ENABLE_3D_RENDERING)
[webkit-changes] [88154] trunk/LayoutTests
Title: [88154] trunk/LayoutTests Revision 88154 Author o...@webkit.org Date 2011-06-06 04:37:08 -0700 (Mon, 06 Jun 2011) Log Message [Qt][Mac] Skip failing tests. * platform/qt-mac/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (88153 => 88154) --- trunk/LayoutTests/ChangeLog 2011-06-06 11:22:34 UTC (rev 88153) +++ trunk/LayoutTests/ChangeLog 2011-06-06 11:37:08 UTC (rev 88154) @@ -1,3 +1,9 @@ +2011-06-06 Csaba Osztrogonác o...@webkit.org + +[Qt][Mac] Skip failing tests. + +* platform/qt-mac/Skipped: + 2011-06-06 Marcus Bulach bul...@chromium.org Reviewed by Unreviewed rebaseline. Modified: trunk/LayoutTests/platform/qt-mac/Skipped (88153 => 88154) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-06-06 11:22:34 UTC (rev 88153) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-06-06 11:37:08 UTC (rev 88154) @@ -4273,3 +4273,34 @@ fast/css/acid2-pixel.html http/tests/misc/acid2-pixel.html http/tests/misc/acid2.html + +# unskipped by r88152, but fail on Qt-Mac platform +editing/selection/select-across-readonly-input-1.html +editing/selection/select-across-readonly-input-2.html +editing/selection/select-across-readonly-input-3.html +editing/selection/select-across-readonly-input-4.html +editing/selection/select-across-readonly-input-5.html +fast/block/positioning/hiding-inside-relpositioned-inline.html +fast/forms/input-placeholder-text-indent.html +fast/html/details-add-details-child-1.html +fast/html/details-add-details-child-2.html +fast/html/details-nested-1.html +fast/html/details-nested-2.html +fast/html/details-replace-summary-child.html +fast/html/details-replace-text.html +fast/inline/nested-top-alignment.html +fast/table/dynamic-caption-add-before-child.xhtml +fast/table/dynamic-caption-add-remove-before-child.xhtml +fast/table/multiple-captions-display.xhtml +scrollbars/scrollbars-on-positioned-content.html +svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg +svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg +svg/W3C-SVG-1.1-SE/struct-use-14-f.svg +svg/custom/object-sizing-explicit-width-height.xhtml +svg/custom/object-sizing-no-width-height.xhtml +svg/custom/object-sizing.xhtml +svg/wicd/rightsizing-grid.xhtml +svg/wicd/test-rightsizing-a.xhtml +svg/wicd/test-rightsizing-b.xhtml +svg/wicd/test-scalable-background-image1.xhtml +svg/wicd/test-scalable-background-image2.xhtml ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88156] trunk/LayoutTests
Title: [88156] trunk/LayoutTests Revision 88156 Author o...@webkit.org Date 2011-06-06 04:58:43 -0700 (Mon, 06 Jun 2011) Log Message [Qt][WK2] Remove previously deleted tests from the Skipped list. * platform/qt-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (88155 => 88156) --- trunk/LayoutTests/ChangeLog 2011-06-06 11:53:18 UTC (rev 88155) +++ trunk/LayoutTests/ChangeLog 2011-06-06 11:58:43 UTC (rev 88156) @@ -1,5 +1,11 @@ 2011-06-06 Csaba Osztrogonác o...@webkit.org +[Qt][WK2] Remove previously deleted tests from the Skipped list. + +* platform/qt-wk2/Skipped: + +2011-06-06 Csaba Osztrogonác o...@webkit.org + [Qt][WK2] Skip failing tests. * platform/qt-wk2/Skipped: Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (88155 => 88156) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-06-06 11:53:18 UTC (rev 88155) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-06-06 11:58:43 UTC (rev 88156) @@ -836,7 +836,6 @@ # Qt WebKit2 needs plugins support fast/css/acid2-pixel.html fast/css/acid2.html -fast/dom/object-embed-plugin-scripting.html fast/events/tabindex-focus-blur-all.html fast/loader/loadInProgress.html http/tests/misc/acid2-pixel.html @@ -963,11 +962,9 @@ editing/pasteboard/4944770-1.html editing/pasteboard/4989774.html editing/pasteboard/5006779.html -editing/pasteboard/5027857.html editing/pasteboard/5028447.html editing/pasteboard/5065605.html editing/pasteboard/5071074.html -editing/pasteboard/5075944-2.html editing/pasteboard/5075944.html editing/pasteboard/5247341.html editing/pasteboard/5368833.html @@ -1284,7 +1281,6 @@ editing/inserting/typing-around-br-001.html editing/inserting/typing-around-image-001.html editing/pasteboard/4631972.html -editing/pasteboard/4700297.html editing/pasteboard/4744008.html editing/pasteboard/8145-1.html editing/pasteboard/8145-2.html @@ -3342,10 +3338,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=60074 http/tests/security/contentSecurityPolicy/eval-blocked.html -# [Qt][WK2] editing/pasteboard/do-not-copy-body-color.html fails -# https://bugs.webkit.org/show_bug.cgi?id=60076 -editing/pasteboard/do-not-copy-body-color.html - # New test introduced in http://trac.webkit.org/changeset/85818 editing/pasteboard/paste-placeholder-input.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88157] trunk/LayoutTests
Title: [88157] trunk/LayoutTests Revision 88157 Author bul...@chromium.org Date 2011-06-06 05:16:33 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Csaba Osztrogonác o...@webkit.org [Qt][WK2] Remove previously deleted tests from the Skipped list. * platform/qt-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (88156 => 88157) --- trunk/LayoutTests/ChangeLog 2011-06-06 11:58:43 UTC (rev 88156) +++ trunk/LayoutTests/ChangeLog 2011-06-06 12:16:33 UTC (rev 88157) @@ -20,6 +20,16 @@ Reviewed by Unreviewed rebaseline. +[chromium] Unreviewed, missing baselines following r88153 +https://bugs.webkit.org/show_bug.cgi?id=62121 + +* platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png: +* platform/chromium/test_expectations.txt: + +2011-06-06 Marcus Bulach bul...@chromium.org + +Reviewed by Unreviewed rebaseline. + [chromium] Unreviewed, further rebaseline for Chromium GPU media pixel tests following r88077 https://bugs.webkit.org/show_bug.cgi?id=62115 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88156 => 88157) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-06 11:58:43 UTC (rev 88156) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-06 12:16:33 UTC (rev 88157) @@ -3624,6 +3624,7 @@ BUGDPRANKE : fast/parser/_javascript_-url-compat-mode.html = TEXT PASS BUGCR80301 LEOPARD : fast/canvas/canvas-largedraws.html = TIMEOUT +BUGCR80301 WIN LINUX : fast/canvas/canvas-largedraws.html = CRASH // roll up from r84685:r84721?? BUGWK84665 : fast/dom/dataset-gc.html = TEXT @@ -4003,4 +4004,3 @@ BUGCR84157 GPU : fast/canvas/canvas-transform-skewed.html = IMAGE BUGCR84157 GPU : fast/canvas/zero-size-fill-rect.html = IMAGE BUGCR84157 BUGCR74979 GPU : media/video-canvas-alpha.html = IMAGE - Modified: trunk/LayoutTests/platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88158] trunk/LayoutTests
Title: [88158] trunk/LayoutTests Revision 88158 Author o...@webkit.org Date 2011-06-06 05:23:09 -0700 (Mon, 06 Jun 2011) Log Message [Qt] 6 tests have different results on 64 bit compared to 32 bit https://bugs.webkit.org/show_bug.cgi?id=52812 * platform/qt/Skipped: Add svg/custom/object-sizing-explicit-width-height.xhtml. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (88157 => 88158) --- trunk/LayoutTests/ChangeLog 2011-06-06 12:16:33 UTC (rev 88157) +++ trunk/LayoutTests/ChangeLog 2011-06-06 12:23:09 UTC (rev 88158) @@ -1,5 +1,12 @@ 2011-06-06 Csaba Osztrogonác o...@webkit.org +[Qt] 6 tests have different results on 64 bit compared to 32 bit +https://bugs.webkit.org/show_bug.cgi?id=52812 + +* platform/qt/Skipped: Add svg/custom/object-sizing-explicit-width-height.xhtml. + +2011-06-06 Csaba Osztrogonác o...@webkit.org + [Qt][WK2] Remove previously deleted tests from the Skipped list. * platform/qt-wk2/Skipped: Modified: trunk/LayoutTests/platform/qt/Skipped (88157 => 88158) --- trunk/LayoutTests/platform/qt/Skipped 2011-06-06 12:16:33 UTC (rev 88157) +++ trunk/LayoutTests/platform/qt/Skipped 2011-06-06 12:23:09 UTC (rev 88158) @@ -2412,6 +2412,7 @@ svg/custom/empty-merge.svg svg/custom/non-circular-marker-reference.svg svg/custom/non-scaling-stroke-markers.svg +svg/custom/object-sizing-explicit-width-height.xhtml svg/custom/recursive-filter.svg svg/custom/relative-sized-inner-svg.xhtml svg/custom/relative-sized-use-on-symbol.xhtml ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88160] trunk/LayoutTests
Title: [88160] trunk/LayoutTests Revision 88160 Author l...@webkit.org Date 2011-06-06 05:41:55 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Gabor Loki l...@webkit.org Rubber-stamped by Csaba Osztrogonác Skip a flakey test on ARM. * platform/qt-arm/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-arm/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (88159 => 88160) --- trunk/LayoutTests/ChangeLog 2011-06-06 12:32:32 UTC (rev 88159) +++ trunk/LayoutTests/ChangeLog 2011-06-06 12:41:55 UTC (rev 88160) @@ -1,3 +1,11 @@ +2011-06-06 Gabor Loki l...@webkit.org + +Rubber-stamped by Csaba Osztrogonác + +Skip a flakey test on ARM. + +* platform/qt-arm/Skipped: + 2011-06-04 Dominic Cooney domin...@chromium.org Reviewed by Dimitri Glazkov. Modified: trunk/LayoutTests/platform/qt-arm/Skipped (88159 => 88160) --- trunk/LayoutTests/platform/qt-arm/Skipped 2011-06-06 12:32:32 UTC (rev 88159) +++ trunk/LayoutTests/platform/qt-arm/Skipped 2011-06-06 12:41:55 UTC (rev 88160) @@ -45,6 +45,7 @@ # Flakey tests svg/animations/animate-mpath-insert.html +svg/dom/SVGScriptElement/script-load-and-error-events.svg # Flakey timed out tests fast/js/nested-object-gc.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88161] trunk/Tools
Title: [88161] trunk/Tools
Revision 88161
Author commit-qu...@webkit.org
Date 2011-06-06 06:19:23 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Barát Tibor barat.ti...@stud.u-szeged.hu
Reviewed by Csaba Osztrogonác.
[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::downloadRequest):
(LauncherWindow::fileDownloadFinished):
* QtTestBrowser/launcherwindow.h:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/QtTestBrowser/launcherwindow.cpp
trunk/Tools/QtTestBrowser/launcherwindow.h
Diff
Modified: trunk/Tools/ChangeLog (88160 => 88161)
--- trunk/Tools/ChangeLog 2011-06-06 12:41:55 UTC (rev 88160)
+++ trunk/Tools/ChangeLog 2011-06-06 13:19:23 UTC (rev 88161)
@@ -1,3 +1,16 @@
+2011-06-06 Barát Tibor barat.ti...@stud.u-szeged.hu
+
+Reviewed by Csaba Osztrogonác.
+
+[Qt] Implement download feature for QtTestBrowser
+https://bugs.webkit.org/show_bug.cgi?id=61865
+
+* QtTestBrowser/launcherwindow.cpp:
+(LauncherWindow::LauncherWindow):
+(LauncherWindow::downloadRequest):
+(LauncherWindow::fileDownloadFinished):
+* QtTestBrowser/launcherwindow.h:
+
2011-06-04 Dominic Cooney domin...@chromium.org
Reviewed by Dimitri Glazkov.
Modified: trunk/Tools/QtTestBrowser/launcherwindow.cpp (88160 => 88161)
--- trunk/Tools/QtTestBrowser/launcherwindow.cpp 2011-06-06 12:41:55 UTC (rev 88160)
+++ trunk/Tools/QtTestBrowser/launcherwindow.cpp 2011-06-06 13:19:23 UTC (rev 88161)
@@ -34,6 +34,10 @@
#include launcherwindow.h
#include urlloader.h
+#include QFileDialog
+#include QFileInfo
+#include QMessageBox
+#include QNetworkReply
const int gExitClickArea = 80;
QVectorint LauncherWindow::m_zoomLevels;
@@ -46,6 +50,7 @@
, m_inspector(0)
, m_formatMenuAction(0)
, m_zoomAnimation(0)
+, m_reply(0)
#ifndef QT_NO_LINEEDIT
, m_findFlag(0)
#endif
@@ -58,6 +63,8 @@
static_castQGraphicsView*(m_view)-setScene(sharedScene);
createChrome();
+
+connect(page(), SIGNAL(downloadRequested(const QNetworkRequest)), this, SLOT(downloadRequest(const QNetworkRequest)));
}
LauncherWindow::~LauncherWindow()
@@ -968,6 +975,32 @@
output Loaded: url.toString() endl;
}
+void LauncherWindow::downloadRequest(const QNetworkRequest request)
+{
+QNetworkAccessManager* manager = new QNetworkAccessManager(this);
+m_reply = manager-get(request);
+connect(m_reply, SIGNAL(finished()), this, SLOT(fileDownloadFinished()));
+}
+
+void LauncherWindow::fileDownloadFinished()
+{
+QFileInfo fileInf(m_reply-request().url().toString());
+QString requestFileName = QDir::homePath() + / + fileInf.fileName();
+QString fileName = QFileDialog::getSaveFileName(this, Save as..., requestFileName, All Files (*));
+
+if (fileName.isEmpty())
+return;
+if (m_reply-error() != QNetworkReply::NoError)
+QMessageBox::critical(this, QString(Download), QString(Download failed.));
+else {
+QFile file(fileName);
+file.open(QIODevice::WriteOnly);
+file.write(m_reply-readAll());
+file.close();
+QMessageBox::information(this, QString(Download), fileName + QString( downloaded successfully.));
+}
+}
+
void LauncherWindow::updateFPS(int fps)
{
QString fpsStatusText = QString(Current FPS: %1).arg(fps);
Modified: trunk/Tools/QtTestBrowser/launcherwindow.h (88160 => 88161)
--- trunk/Tools/QtTestBrowser/launcherwindow.h 2011-06-06 12:41:55 UTC (rev 88160)
+++ trunk/Tools/QtTestBrowser/launcherwindow.h 2011-06-06 13:19:23 UTC (rev 88161)
@@ -206,6 +206,8 @@
void showUserAgentDialog();
void printURL(const QUrl);
+void downloadRequest(const QNetworkRequest);
+void fileDownloadFinished();
public slots:
LauncherWindow* newWindow();
@@ -238,6 +240,7 @@
QAction* m_formatMenuAction;
QPropertyAnimation* m_zoomAnimation;
+QNetworkReply* m_reply;
QListQTouchEvent::TouchPoint m_touchPoints;
bool m_touchMocking;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88162] trunk/LayoutTests
Title: [88162] trunk/LayoutTests Revision 88162 Author bul...@chromium.org Date 2011-06-06 06:27:29 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Marcus Bulach bul...@chromium.org Reviewed by Unreviewed rebaseline. [chromium] Unreviewed, new baseline for GPU test. https://bugs.webkit.org/show_bug.cgi?id=62123 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (88161 => 88162) --- trunk/LayoutTests/ChangeLog 2011-06-06 13:19:23 UTC (rev 88161) +++ trunk/LayoutTests/ChangeLog 2011-06-06 13:27:29 UTC (rev 88162) @@ -1,3 +1,12 @@ +2011-06-06 Marcus Bulach bul...@chromium.org + +Reviewed by Unreviewed rebaseline. + +[chromium] Unreviewed, new baseline for GPU test. +https://bugs.webkit.org/show_bug.cgi?id=62123 + +* platform/chromium/test_expectations.txt: + 2011-06-06 Gabor Loki l...@webkit.org Rubber-stamped by Csaba Osztrogonác Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88161 => 88162) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-06 13:19:23 UTC (rev 88161) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-06 13:27:29 UTC (rev 88162) @@ -4004,3 +4004,5 @@ BUGCR84157 GPU : fast/canvas/canvas-transform-skewed.html = IMAGE BUGCR84157 GPU : fast/canvas/zero-size-fill-rect.html = IMAGE BUGCR84157 BUGCR74979 GPU : media/video-canvas-alpha.html = IMAGE + +BUGCR85051 WIN GPU : canvas/philip/tests/2d.composite.canvas.source-over.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88164] trunk/LayoutTests
Title: [88164] trunk/LayoutTests Revision 88164 Author o...@webkit.org Date 2011-06-06 06:53:39 -0700 (Mon, 06 Jun 2011) Log Message [Qt][Mac] Skip failing tests. * platform/qt-mac/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (88163 => 88164) --- trunk/LayoutTests/ChangeLog 2011-06-06 13:33:22 UTC (rev 88163) +++ trunk/LayoutTests/ChangeLog 2011-06-06 13:53:39 UTC (rev 88164) @@ -1,3 +1,9 @@ +2011-06-06 Csaba Osztrogonác o...@webkit.org + +[Qt][Mac] Skip failing tests. + +* platform/qt-mac/Skipped: + 2011-06-06 Zsolt Fehér h490...@stud.u-szeged.hu Reviewed by Csaba Osztrogonác. Modified: trunk/LayoutTests/platform/qt-mac/Skipped (88163 => 88164) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-06-06 13:33:22 UTC (rev 88163) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-06-06 13:53:39 UTC (rev 88164) @@ -4304,3 +4304,27 @@ svg/wicd/test-rightsizing-b.xhtml svg/wicd/test-scalable-background-image1.xhtml svg/wicd/test-scalable-background-image2.xhtml + +# unskipped by r88163, but fail on Qt-Mac platform +fast/frames/flattening/iframe-flattening-nested.html +fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html +fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html +fast/frames/flattening/iframe-flattening-out-of-view.html +svg/as-image/img-preserveAspectRatio-support-2.html +svg/as-image/svg-as-background-with-relative-size.html +svg/as-image/svg-as-background-with-viewBox.html +svg/custom/embedding-external-svgs.xhtml +svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml +svg/custom/object-sizing-height-50p-on-target-svg.xhtml +svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml +svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml +svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml +svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml +svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml +svg/custom/object-sizing-width-50p-on-target-svg.xhtml +svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml +svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml +svg/hixie/intrinsic/001.html +svg/hixie/intrinsic/002.html +svg/hixie/intrinsic/003.html +svg/text/scaling-font-with-geometric-precision.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88165] trunk/Source/WebKit2
Title: [88165] trunk/Source/WebKit2 Revision 88165 Author domin...@chromium.org Date 2011-06-06 07:12:11 -0700 (Mon, 06 Jun 2011) Log Message Unreviewed WinCairo build fix after r88159. * win/WebKit2CFLite.def: Export symbols for WebCoreTestSupport. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2CFLite.def Diff Modified: trunk/Source/WebKit2/ChangeLog (88164 => 88165) --- trunk/Source/WebKit2/ChangeLog 2011-06-06 13:53:39 UTC (rev 88164) +++ trunk/Source/WebKit2/ChangeLog 2011-06-06 14:12:11 UTC (rev 88165) @@ -1,3 +1,9 @@ +2011-06-06 Dominic Cooney domin...@chromium.org + +Unreviewed WinCairo build fix after r88159. + +* win/WebKit2CFLite.def: Export symbols for WebCoreTestSupport. + 2011-06-04 Dominic Cooney domin...@chromium.org Reviewed by Dimitri Glazkov. Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (88164 => 88165) --- trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-06-06 13:53:39 UTC (rev 88164) +++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-06-06 14:12:11 UTC (rev 88165) @@ -104,6 +104,7 @@ ??0Mutex@WTF@@QAE@XZ ??0ThreadCondition@WTF@@QAE@XZ ??1Mutex@WTF@@QAE@XZ +??1StringImpl@WTF@@QAE@XZ ??1ThreadCondition@WTF@@QAE@XZ ?broadcast@ThreadCondition@WTF@@QAEXXZ ?callOnMainThread@WTF@@YAXP6AXPAX@Z0@Z @@ -125,3 +126,8 @@ ?wait@ThreadCondition@WTF@@QAEXAAVMutex@2@@Z ?waitForThreadCompletion@WTF@@YAHIPAPAX@Z ?createThread@WTF@@YAIP6APAXPAX@Z0@Z + +; Re-exports from WebCore for WebCoreTestSupport +?getCachedDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PBUClassInfo@3@@Z +?cacheDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PAV23@PBUClassInfo@3@@Z +?virtualFunctionToPreventWeakVtable@JSDOMWrapper@WebCore@@MAEXXZ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88166] trunk/Source/WebCore
Title: [88166] trunk/Source/WebCore
Revision 88166
Author stevebl...@google.com
Date 2011-06-06 07:15:30 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Steve Block stevebl...@google.com
Reviewed by Yury Semikhatsky.
Use of ENABLE(INSPECTOR) is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=62118
Correctly guard implementation of ScriptProfiler.
No new tests, build fix only.
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::initialize):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (88165 => 88166)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 14:12:11 UTC (rev 88165)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 14:15:30 UTC (rev 88166)
@@ -1,3 +1,17 @@
+2011-06-06 Steve Block stevebl...@google.com
+
+Reviewed by Yury Semikhatsky.
+
+Use of ENABLE(INSPECTOR) is inconsistent
+https://bugs.webkit.org/show_bug.cgi?id=62118
+
+Correctly guard implementation of ScriptProfiler.
+
+No new tests, build fix only.
+
+* bindings/v8/ScriptProfiler.cpp:
+(WebCore::ScriptProfiler::initialize):
+
2011-06-04 Dominic Cooney domin...@chromium.org
Reviewed by Dimitri Glazkov.
Modified: trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp (88165 => 88166)
--- trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp 2011-06-06 14:12:11 UTC (rev 88165)
+++ trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp 2011-06-06 14:15:30 UTC (rev 88166)
@@ -40,6 +40,7 @@
namespace WebCore {
+#if ENABLE(INSPECTOR)
void ScriptProfiler::start(ScriptState* state, const String title)
{
v8::HandleScope hs;
@@ -108,10 +109,13 @@
Node* node = V8Node::toNative(wrapper.Asv8::Object());
return node ? new RetainedDOMInfo(node) : 0;
}
+#endif // ENABLE(INSPECTOR)
void ScriptProfiler::initialize()
{
+#if ENABLE(INSPECTOR)
v8::HeapProfiler::DefineWrapperClass(v8DOMSubtreeClassId, retainedDOMInfo);
+#endif // ENABLE(INSPECTOR)
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88167] trunk/Tools
Title: [88167] trunk/Tools
Revision 88167
Author o...@webkit.org
Date 2011-06-06 07:52:19 -0700 (Mon, 06 Jun 2011)
Log Message
[Qt] Implement download feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61865
Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow):
* QtTestBrowser/launcherwindow.h:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/QtTestBrowser/launcherwindow.cpp
trunk/Tools/QtTestBrowser/launcherwindow.h
Diff
Modified: trunk/Tools/ChangeLog (88166 => 88167)
--- trunk/Tools/ChangeLog 2011-06-06 14:15:30 UTC (rev 88166)
+++ trunk/Tools/ChangeLog 2011-06-06 14:52:19 UTC (rev 88167)
@@ -1,3 +1,14 @@
+2011-06-06 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Implement download feature for QtTestBrowser
+https://bugs.webkit.org/show_bug.cgi?id=61865
+
+Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
+
+* QtTestBrowser/launcherwindow.cpp:
+(LauncherWindow::LauncherWindow):
+* QtTestBrowser/launcherwindow.h:
+
2011-06-06 Barát Tibor barat.ti...@stud.u-szeged.hu
Reviewed by Csaba Osztrogonác.
Modified: trunk/Tools/QtTestBrowser/launcherwindow.cpp (88166 => 88167)
--- trunk/Tools/QtTestBrowser/launcherwindow.cpp 2011-06-06 14:15:30 UTC (rev 88166)
+++ trunk/Tools/QtTestBrowser/launcherwindow.cpp 2011-06-06 14:52:19 UTC (rev 88167)
@@ -34,10 +34,13 @@
#include launcherwindow.h
#include urlloader.h
+
+#if !defined(QT_NO_FILEDIALOG) !defined(QT_NO_MESSAGEBOX)
#include QFileDialog
#include QFileInfo
#include QMessageBox
#include QNetworkReply
+#endif
const int gExitClickArea = 80;
QVectorint LauncherWindow::m_zoomLevels;
@@ -50,7 +53,9 @@
, m_inspector(0)
, m_formatMenuAction(0)
, m_zoomAnimation(0)
+#if !defined(QT_NO_FILEDIALOG) !defined(QT_NO_MESSAGEBOX)
, m_reply(0)
+#endif
#ifndef QT_NO_LINEEDIT
, m_findFlag(0)
#endif
@@ -63,8 +68,9 @@
static_castQGraphicsView*(m_view)-setScene(sharedScene);
createChrome();
-
+#if !defined(QT_NO_FILEDIALOG) !defined(QT_NO_MESSAGEBOX)
connect(page(), SIGNAL(downloadRequested(const QNetworkRequest)), this, SLOT(downloadRequest(const QNetworkRequest)));
+#endif
}
LauncherWindow::~LauncherWindow()
@@ -975,6 +981,7 @@
output Loaded: url.toString() endl;
}
+#if !defined(QT_NO_FILEDIALOG) !defined(QT_NO_MESSAGEBOX)
void LauncherWindow::downloadRequest(const QNetworkRequest request)
{
QNetworkAccessManager* manager = new QNetworkAccessManager(this);
@@ -1000,6 +1007,7 @@
QMessageBox::information(this, QString(Download), fileName + QString( downloaded successfully.));
}
}
+#endif
void LauncherWindow::updateFPS(int fps)
{
Modified: trunk/Tools/QtTestBrowser/launcherwindow.h (88166 => 88167)
--- trunk/Tools/QtTestBrowser/launcherwindow.h 2011-06-06 14:15:30 UTC (rev 88166)
+++ trunk/Tools/QtTestBrowser/launcherwindow.h 2011-06-06 14:52:19 UTC (rev 88167)
@@ -206,8 +206,10 @@
void showUserAgentDialog();
void printURL(const QUrl);
+#if !defined(QT_NO_FILEDIALOG) !defined(QT_NO_MESSAGEBOX)
void downloadRequest(const QNetworkRequest);
void fileDownloadFinished();
+#endif
public slots:
LauncherWindow* newWindow();
@@ -240,7 +242,9 @@
QAction* m_formatMenuAction;
QPropertyAnimation* m_zoomAnimation;
+#if !defined(QT_NO_FILEDIALOG) !defined(QT_NO_MESSAGEBOX)
QNetworkReply* m_reply;
+#endif
QListQTouchEvent::TouchPoint m_touchPoints;
bool m_touchMocking;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88168] trunk/LayoutTests
Title: [88168] trunk/LayoutTests Revision 88168 Author o...@webkit.org Date 2011-06-06 07:57:30 -0700 (Mon, 06 Jun 2011) Log Message [Qt] 6 tests have different results on 64 bit compared to 32 bit https://bugs.webkit.org/show_bug.cgi?id=52812 * platform/qt/Skipped: Add svg/custom/embedding-external-svgs.xhtml. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (88167 => 88168) --- trunk/LayoutTests/ChangeLog 2011-06-06 14:52:19 UTC (rev 88167) +++ trunk/LayoutTests/ChangeLog 2011-06-06 14:57:30 UTC (rev 88168) @@ -1,5 +1,12 @@ 2011-06-06 Csaba Osztrogonác o...@webkit.org +[Qt] 6 tests have different results on 64 bit compared to 32 bit +https://bugs.webkit.org/show_bug.cgi?id=52812 + +* platform/qt/Skipped: Add svg/custom/embedding-external-svgs.xhtml. + +2011-06-06 Csaba Osztrogonác o...@webkit.org + [Qt][Mac] Skip failing tests. * platform/qt-mac/Skipped: Modified: trunk/LayoutTests/platform/qt/Skipped (88167 => 88168) --- trunk/LayoutTests/platform/qt/Skipped 2011-06-06 14:52:19 UTC (rev 88167) +++ trunk/LayoutTests/platform/qt/Skipped 2011-06-06 14:57:30 UTC (rev 88168) @@ -2409,6 +2409,7 @@ svg/custom/circular-marker-reference-2.svg svg/custom/circular-marker-reference-3.svg svg/custom/circular-marker-reference-4.svg +svg/custom/embedding-external-svgs.xhtml svg/custom/empty-merge.svg svg/custom/non-circular-marker-reference.svg svg/custom/non-scaling-stroke-markers.svg ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88170] trunk/Source/WebKit/chromium
Title: [88170] trunk/Source/WebKit/chromium
Revision 88170
Author tha...@chromium.org
Date 2011-06-06 09:48:07 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Nico Weber tha...@chromium.org
Reviewed by Dimitri Glazkov.
webkit/glue/webmediaplayer_impl.cc deletes an object of type
WebVideoFrame, which means this patch fixes a real bug, not just
a theoretical one.
[chromium] Give WebVideoFrame a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=61742
* public/WebVideoFrame.h:
(WebKit::WebVideoFrame::~WebVideoFrame):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebVideoFrame.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88169 => 88170)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-06 15:49:46 UTC (rev 88169)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-06 16:48:07 UTC (rev 88170)
@@ -1,3 +1,17 @@
+2011-06-06 Nico Weber tha...@chromium.org
+
+Reviewed by Dimitri Glazkov.
+
+webkit/glue/webmediaplayer_impl.cc deletes an object of type
+WebVideoFrame, which means this patch fixes a real bug, not just
+a theoretical one.
+
+[chromium] Give WebVideoFrame a virtual destructor
+https://bugs.webkit.org/show_bug.cgi?id=61742
+
+* public/WebVideoFrame.h:
+(WebKit::WebVideoFrame::~WebVideoFrame):
+
2011-06-04 Nico Weber tha...@chromium.org
Reviewed by James Robinson.
Modified: trunk/Source/WebKit/chromium/public/WebVideoFrame.h (88169 => 88170)
--- trunk/Source/WebKit/chromium/public/WebVideoFrame.h 2011-06-06 15:49:46 UTC (rev 88169)
+++ trunk/Source/WebKit/chromium/public/WebVideoFrame.h 2011-06-06 16:48:07 UTC (rev 88170)
@@ -56,6 +56,7 @@
SurfaceTypeTexture,
};
+virtual ~WebVideoFrame() { }
virtual SurfaceType surfaceType() const = 0;
virtual Format format() const = 0;
virtual unsigned width() const = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88173] trunk/Source/WebCore
Title: [88173] trunk/Source/WebCore Revision 88173 Author commit-qu...@webkit.org Date 2011-06-06 11:01:15 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Cary Clark carycl...@google.com Reviewed by Eric Seidel. Fix typo in CachedFont.cpp #define https://bugs.webkit.org/show_bug.cgi?id=62127 No new tests. The define typo in question is not yet enabled, so this change has no functional impact. * loader/cache/CachedFont.cpp: change SKIA_MAC_ON_CHROME to SKIA_ON_MAC_CHROME Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/cache/CachedFont.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (88172 => 88173) --- trunk/Source/WebCore/ChangeLog 2011-06-06 17:50:03 UTC (rev 88172) +++ trunk/Source/WebCore/ChangeLog 2011-06-06 18:01:15 UTC (rev 88173) @@ -1,3 +1,17 @@ +2011-06-06 Cary Clark carycl...@google.com + +Reviewed by Eric Seidel. + +Fix typo in CachedFont.cpp #define +https://bugs.webkit.org/show_bug.cgi?id=62127 + +No new tests. The define typo in question is +not yet enabled, so this change has no functional +impact. + +* loader/cache/CachedFont.cpp: +change SKIA_MAC_ON_CHROME to SKIA_ON_MAC_CHROME + 2011-06-03 Levi Weintraub le...@chromium.org Reviewed by Eric Seidel. Modified: trunk/Source/WebCore/loader/cache/CachedFont.cpp (88172 => 88173) --- trunk/Source/WebCore/loader/cache/CachedFont.cpp 2011-06-06 17:50:03 UTC (rev 88172) +++ trunk/Source/WebCore/loader/cache/CachedFont.cpp 2011-06-06 18:01:15 UTC (rev 88173) @@ -28,7 +28,7 @@ #include CachedFont.h // FIXME: This should really be a blacklist instead of a whitelist -#if USE(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) (!OS(DARWIN) || USE(SKIA_MAC_ON_CHROME))) || PLATFORM(HAIKU) || OS(WINCE) || PLATFORM(ANDROID) || PLATFORM(BREWMP) +#if USE(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) (!OS(DARWIN) || USE(SKIA_ON_MAC_CHROME))) || PLATFORM(HAIKU) || OS(WINCE) || PLATFORM(ANDROID) || PLATFORM(BREWMP) #define STORE_FONT_CUSTOM_PLATFORM_DATA #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88174] trunk
Title: [88174] trunk
Revision 88174
Author commit-qu...@webkit.org
Date 2011-06-06 11:03:05 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Shishir Agrawal shis...@chromium.org
Reviewed by Tony Gentilcore.
Add a prerender state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062
* fast/events/page-visibility-transition-test-expected.txt:
* fast/events/page-visibility-transition-test.html:
2011-06-06 Shishir Agrawal shis...@chromium.org
Reviewed by Tony Gentilcore.
Add a prerender state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062
* page/PageVisibilityState.cpp:
(WebCore::pageVisibilityStateString):
* page/PageVisibilityState.h:
2011-06-06 Shishir Agrawal shis...@chromium.org
Reviewed by Tony Gentilcore.
Add a prerender state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062
* public/WebPageVisibilityState.h:
* src/AssertMatchingEnums.cpp:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setVisibilityState):
2011-06-06 Shishir Agrawal shis...@chromium.org
Reviewed by Tony Gentilcore.
Add a prerender state for page visibility.
https://bugs.webkit.org/show_bug.cgi?id=62062
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setPageVisibility):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/page-visibility-transition-test-expected.txt
trunk/LayoutTests/fast/events/page-visibility-transition-test.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PageVisibilityState.cpp
trunk/Source/WebCore/page/PageVisibilityState.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebPageVisibilityState.h
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (88173 => 88174)
--- trunk/LayoutTests/ChangeLog 2011-06-06 18:01:15 UTC (rev 88173)
+++ trunk/LayoutTests/ChangeLog 2011-06-06 18:03:05 UTC (rev 88174)
@@ -1,3 +1,13 @@
+2011-06-06 Shishir Agrawal shis...@chromium.org
+
+Reviewed by Tony Gentilcore.
+
+Add a prerender state for page visibility.
+https://bugs.webkit.org/show_bug.cgi?id=62062
+
+* fast/events/page-visibility-transition-test-expected.txt:
+* fast/events/page-visibility-transition-test.html:
+
2011-06-06 Csaba Osztrogonác o...@webkit.org
[Qt] 6 tests have different results on 64 bit compared to 32 bit
Modified: trunk/LayoutTests/fast/events/page-visibility-transition-test-expected.txt (88173 => 88174)
--- trunk/LayoutTests/fast/events/page-visibility-transition-test-expected.txt 2011-06-06 18:01:15 UTC (rev 88173)
+++ trunk/LayoutTests/fast/events/page-visibility-transition-test-expected.txt 2011-06-06 18:03:05 UTC (rev 88174)
@@ -9,6 +9,8 @@
PASS document.webkitHidden is true
PASS document.webkitVisibilityState is hidden
PASS document.webkitHidden is true
+PASS document.webkitVisibilityState is prerender
+PASS document.webkitHidden is true
PASS document.webkitVisibilityState is visible
PASS document.webkitHidden is false
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/events/page-visibility-transition-test.html (88173 => 88174)
--- trunk/LayoutTests/fast/events/page-visibility-transition-test.html 2011-06-06 18:01:15 UTC (rev 88173)
+++ trunk/LayoutTests/fast/events/page-visibility-transition-test.html 2011-06-06 18:03:05 UTC (rev 88174)
@@ -22,6 +22,11 @@
layoutTestController.setPageVisibility(hidden);
}
+function makePagePrerender() {
+if (window.layoutTestController)
+layoutTestController.setPageVisibility(prerender);
+}
+
function checkIsPageVisible() {
shouldBeEqualToString(document.webkitVisibilityState, visible);
shouldBeFalse(document.webkitHidden);
@@ -32,11 +37,17 @@
shouldBeTrue(document.webkitHidden);
}
+function checkIsPagePrerendering() {
+shouldBeEqualToString(document.webkitVisibilityState, prerender);
+shouldBeTrue(document.webkitHidden);
+}
+
// We will try to change the visibility states as:
// 0 - visible. (Initial - i.e. on load).
// 1 - hidden (should fire event).
// 2 - hidden (no event).
-// 3 - visible (should fire event).
+// 3 - prerender (should fire event).
+// 4 - visible (should fire event).
var numVisibilityChanges = 0;
function startTest() {
@@ -61,13 +72,18 @@
makePageHidden();
checkIsPageHidden();
numVisibilityChanges++;
-makePageVisible();
+makePagePrerender();
return;
} else if (numVisibilityChanges == 2) {
testFailed(Invalid event fired on same state change.);
finishTest();
return;
} else if
[webkit-changes] [88175] trunk
Title: [88175] trunk
Revision 88175
Author yael.aha...@nokia.com
Date 2011-06-06 11:32:54 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Yael Aharon yael.aha...@nokia.com
Reviewed by Eric Seidel.
Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459
* fast/inline/inline-wrap-with-parent-padding.html: Added.
* platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
* platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
2011-06-06 Yael Aharon yael.aha...@nokia.com
Reviewed by Eric Seidel.
Inline elements are wrapped prematurely with non-zero border, margin or padding.
https://bugs.webkit.org/show_bug.cgi?id=60459
When an inline element has a right border/margin/padding and it has more than one descendant with no siblings,
the width of the right border/margin/padding should be included in line breaking calculation only once,
and not for each descendant.
Test: fast/inline/inline-wrap-with-parent-padding.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Added Paths
trunk/LayoutTests/fast/inline/inline-wrap-with-parent-padding.html
trunk/LayoutTests/platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png
trunk/LayoutTests/platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (88174 => 88175)
--- trunk/LayoutTests/ChangeLog 2011-06-06 18:03:05 UTC (rev 88174)
+++ trunk/LayoutTests/ChangeLog 2011-06-06 18:32:54 UTC (rev 88175)
@@ -1,3 +1,14 @@
+2011-06-06 Yael Aharon yael.aha...@nokia.com
+
+Reviewed by Eric Seidel.
+
+Inline elements are wrapped prematurely with non-zero border, margin or padding.
+https://bugs.webkit.org/show_bug.cgi?id=60459
+
+* fast/inline/inline-wrap-with-parent-padding.html: Added.
+* platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
+* platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
+
2011-06-06 Shishir Agrawal shis...@chromium.org
Reviewed by Tony Gentilcore.
Added: trunk/LayoutTests/fast/inline/inline-wrap-with-parent-padding.html (0 => 88175)
--- trunk/LayoutTests/fast/inline/inline-wrap-with-parent-padding.html (rev 0)
+++ trunk/LayoutTests/fast/inline/inline-wrap-with-parent-padding.html 2011-06-06 18:32:54 UTC (rev 88175)
@@ -0,0 +1,13 @@
+!DOCTYPE html
+html
+head
+style
+div { width: 320px; }
+/style
+/head
+body
+div style=border: 1px solid red
+span style=border: 1px solid green; padding-right: 15px-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span-- span--/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span/span
+/div
+/body
+/html
\ No newline at end of file
Added: trunk/LayoutTests/platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png (0 => 88175)
--- trunk/LayoutTests/platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/inline/inline-wrap-with-parent-padding-expected.png 2011-06-06 18:32:54 UTC (rev 88175)
@@ -0,0 +1,11 @@
+\x89PNG
+
+
+IHDR X \x9Av\x82p )tEXtchecksum 7c887338f071fa5651edec9073daa043K\xB1\xDAl \xEEiCCPICC Profile x\x85T\xCFkA\xFE6n\xA9\xD0Zk\xB2x\x90IY\xABhE\xD46\xFDbk \xDB \xB6E\x90d3I\xD6n6\xEB\xEE\xB5\xA5\x88\xE4\xE2\xD1*\xDEE\xED\xA1\xFF\x80 z\xF0d/J\x85ZE(ޫ(b\xA1-\xF1\xCDnL\xB6\xA5\xEA\xC0\xCE~\xF3\xDE7\xEF}ov\xDF
+r\xD24\xF5\x80\xE4
+\xC7R\xA2il|Bj\xFC\x88 \x8E\xA2 A4%U\xDB\xECN$A\x83s\xF9{\xE7\xD8z\x81[V\xC3{\xFBw\xB2w\xAD\x9AҶ\x9A\x84\xFD@\xE0G\x9A\xD9*\xB0\xEFq
+Y\x88ߡ)\xC7t\xDF\xE3\xD8\xF2\xEC\x8F9Nyx\xC1\xB5+=\xC4Y|@5-\xCEM\xB8S\xCD%\xD3@\x83H8\x94\xF5qR\x9C\x94\xD7 inf\xC6\xC8\xBDO\x90\xA6\xBB\xCC\xEE\xABb\xA1\x9CN\xF6\x90\xBD\x9D\xF4~N\xB3\xDE\xC2!\xC2 \xAD?F\xB8\x8D\x9E\xF5\x8C\xD5?\xE2a\xE1\xA4\xE6Ć= 5\xF4\xF8`\xB7\xA9\xF85\xC2_M'\xA2Tq\xD9.
+\xF1\x98\xAE\xFDV\xF2J\x82p\x908\xCAda\x80sZHO\xD7Ln\xF8\xBA\x87}\xD7\xAF\xE2wVQ\xE1y\x8Fg\xDE\xD4\xDD\xEFE\xDA\xAF0 \x9A
+HPEa\x98\xB0P@\x8614\xB2r?#\xAB\x93{2u$j\xBBtbD\xB1A{6\xDC=\xB7Q\xA4\xDD\xFE(q\x94C\xB5\x92\xFCA\xFE*\xAF\xC9O\xE5y\xF9\xCB\\xB0\xD8V\x{1D4B5B}\x9A\xBA\xF2\xE0;\xC5噹
[webkit-changes] [88176] trunk/Source/WebCore
Title: [88176] trunk/Source/WebCore
Revision 88176
Author le...@chromium.org
Date 2011-06-06 11:43:40 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Levi Weintraub le...@chromium.org
Reviewed by Eric Seidel.
Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62134
Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
IntPoint representing the paint offset instead of a pair of ints.
No new tests as this simple refactoring.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintContents):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintSelection):
* rendering/RenderBlock.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (88175 => 88176)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 18:32:54 UTC (rev 88175)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 18:43:40 UTC (rev 88176)
@@ -1,3 +1,23 @@
+2011-06-06 Levi Weintraub le...@chromium.org
+
+Reviewed by Eric Seidel.
+
+Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
+https://bugs.webkit.org/show_bug.cgi?id=62134
+
+Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
+IntPoint representing the paint offset instead of a pair of ints.
+
+No new tests as this simple refactoring.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::paintColumnRules):
+(WebCore::RenderBlock::paintColumnContents):
+(WebCore::RenderBlock::paintContents):
+(WebCore::RenderBlock::paintObject):
+(WebCore::RenderBlock::paintSelection):
+* rendering/RenderBlock.h:
+
2011-06-06 Yael Aharon yael.aha...@nokia.com
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (88175 => 88176)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-06-06 18:32:54 UTC (rev 88175)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-06-06 18:43:40 UTC (rev 88176)
@@ -2269,7 +2269,7 @@
layer()-paintOverflowControls(paintInfo.context, IntPoint(tx, ty), paintInfo.rect);
}
-void RenderBlock::paintColumnRules(PaintInfo paintInfo, int tx, int ty)
+void RenderBlock::paintColumnRules(PaintInfo paintInfo, const IntPoint paintOffset)
{
if (paintInfo.context-paintingDisabled())
return;
@@ -2309,9 +2309,9 @@
// Now paint the column rule.
if (i colCount - 1) {
-int ruleLeft = isHorizontalWritingMode() ? tx + ruleLogicalLeft - ruleWidth / 2 + ruleAdd : tx + borderBefore() + paddingBefore();
+int ruleLeft = isHorizontalWritingMode() ? paintOffset.x() + ruleLogicalLeft - ruleWidth / 2 + ruleAdd : paintOffset.x() + borderBefore() + paddingBefore();
int ruleRight = isHorizontalWritingMode() ? ruleLeft + ruleWidth : ruleLeft + contentWidth();
-int ruleTop = isHorizontalWritingMode() ? ty + borderTop() + paddingTop() : ty + ruleLogicalLeft - ruleWidth / 2 + ruleAdd;
+int ruleTop = isHorizontalWritingMode() ? paintOffset.y() + borderTop() + paddingTop() : paintOffset.y() + ruleLogicalLeft - ruleWidth / 2 + ruleAdd;
int ruleBottom = isHorizontalWritingMode() ? ruleTop + contentHeight() : ruleTop + ruleWidth;
drawLineForBoxSide(paintInfo.context, ruleLeft, ruleTop, ruleRight, ruleBottom,
style()-isLeftToRightDirection() ? BSLeft : BSRight, ruleColor, ruleStyle, 0, 0, antialias);
@@ -2321,7 +2321,7 @@
}
}
-void RenderBlock::paintColumnContents(PaintInfo paintInfo, int tx, int ty, bool paintingFloats)
+void RenderBlock::paintColumnContents(PaintInfo paintInfo, const IntPoint paintOffset, bool paintingFloats)
{
// We need to do multiple passes, breaking up our child painting into strips.
GraphicsContext* context = paintInfo.context;
@@ -2336,7 +2336,7 @@
flipForWritingMode(colRect);
int logicalLeftOffset = (isHorizontalWritingMode() ? colRect.x() : colRect.y()) - logicalLeftOffsetForContent();
IntSize offset = isHorizontalWritingMode() ? IntSize(logicalLeftOffset, currLogicalTopOffset) : IntSize(currLogicalTopOffset, logicalLeftOffset);
-colRect.move(tx, ty);
+colRect.moveBy(paintOffset);
PaintInfo info(paintInfo);
info.rect.intersect(colRect);
@@ -2348,12 +2348,11 @@
context-clip(colRect);
// Adjust our x and y when painting.
-int finalX = tx + offset.width();
-int finalY = ty +
[webkit-changes] [88177] trunk/Tools
Title: [88177] trunk/Tools
Revision 88177
Author x...@webkit.org
Date 2011-06-06 11:51:32 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Xan Lopez xlo...@igalia.com
Reviewed by Martin Robinson.
[GTK] Enable feature/symbol detection in NWRT/GTK
https://bugs.webkit.org/show_bug.cgi?id=62136
Disable feature detection through DRT, since we don't support it,
and set the libwebcore patch correctly so that symbol detection
through 'nm' works.
* Scripts/webkitpy/layout_tests/port/gtk.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py
Diff
Modified: trunk/Tools/ChangeLog (88176 => 88177)
--- trunk/Tools/ChangeLog 2011-06-06 18:43:40 UTC (rev 88176)
+++ trunk/Tools/ChangeLog 2011-06-06 18:51:32 UTC (rev 88177)
@@ -1,3 +1,16 @@
+2011-06-06 Xan Lopez xlo...@igalia.com
+
+Reviewed by Martin Robinson.
+
+[GTK] Enable feature/symbol detection in NWRT/GTK
+https://bugs.webkit.org/show_bug.cgi?id=62136
+
+Disable feature detection through DRT, since we don't support it,
+and set the libwebcore patch correctly so that symbol detection
+through 'nm' works.
+
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+
2011-06-06 Shishir Agrawal shis...@chromium.org
Reviewed by Tony Gentilcore.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (88176 => 88177)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-06-06 18:43:40 UTC (rev 88176)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-06-06 18:51:32 UTC (rev 88177)
@@ -103,3 +103,20 @@
def _is_redhat_based(self):
return self._filesystem.exists(self._filesystem.join('/etc', 'redhat-release'))
+
+def _path_to_webcore_library(self):
+gtk_library_names = [
+libwebkitgtk-1.0.so,
+libwebkitgtk-3.0.so,
+libwebkit2gtk-1.0.so,
+]
+
+for library in gtk_library_names:
+full_library = self._build_path(.libs, library)
+if os.path.isfile(full_library):
+return full_library
+
+return None
+
+def _runtime_feature_list(self):
+return None
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88178] trunk/Source
Title: [88178] trunk/Source Revision 88178 Author commit-qu...@webkit.org Date 2011-06-06 12:21:32 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Peter Kasting pkast...@google.com Reviewed by Antonio Gomes. Remove unnecessary args from scroll functions. https://bugs.webkit.org/show_bug.cgi?id=61648 No behavior change, so no tests. * WebCore.exp.in: * WebCore.order: * dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded): * editing/FrameSelection.cpp: (WebCore::FrameSelection::revealSelection): * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): * page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor): * rendering/RenderBox.cpp: (WebCore::RenderBox::canBeScrolledAndHasScrollableArea): (WebCore::RenderBox::canBeProgramaticallyScrolled): * rendering/RenderBox.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::autoscroll): * rendering/RenderLayer.h: * rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled): * rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled): 2011-06-06 Peter Kasting pkast...@google.com Reviewed by Antonio Gomes. Remove unnecessary args from scroll functions. https://bugs.webkit.org/show_bug.cgi?id=61648 * WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/WebCore.order trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/editing/FrameSelection.cpp trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h trunk/Source/WebCore/rendering/RenderListBox.h trunk/Source/WebCore/rendering/RenderTextControl.h trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebFrame.mm Diff Modified: trunk/Source/WebCore/ChangeLog (88177 => 88178) --- trunk/Source/WebCore/ChangeLog 2011-06-06 18:51:32 UTC (rev 88177) +++ trunk/Source/WebCore/ChangeLog 2011-06-06 19:21:32 UTC (rev 88178) @@ -1,3 +1,36 @@ +2011-06-06 Peter Kasting pkast...@google.com + +Reviewed by Antonio Gomes. + +Remove unnecessary args from scroll functions. +https://bugs.webkit.org/show_bug.cgi?id=61648 + +No behavior change, so no tests. + +* WebCore.exp.in: +* WebCore.order: +* dom/Element.cpp: +(WebCore::Element::scrollIntoView): +(WebCore::Element::scrollIntoViewIfNeeded): +* editing/FrameSelection.cpp: +(WebCore::FrameSelection::revealSelection): +* page/EventHandler.cpp: +(WebCore::EventHandler::handleMousePressEvent): +* page/FrameView.cpp: +(WebCore::FrameView::scrollToAnchor): +* rendering/RenderBox.cpp: +(WebCore::RenderBox::canBeScrolledAndHasScrollableArea): +(WebCore::RenderBox::canBeProgramaticallyScrolled): +* rendering/RenderBox.h: +* rendering/RenderLayer.cpp: +(WebCore::RenderLayer::scrollRectToVisible): +(WebCore::RenderLayer::autoscroll): +* rendering/RenderLayer.h: +* rendering/RenderListBox.h: +(WebCore::RenderListBox::canBeProgramaticallyScrolled): +* rendering/RenderTextControl.h: +(WebCore::RenderTextControl::canBeProgramaticallyScrolled): + 2011-06-06 Levi Weintraub le...@chromium.org Reviewed by Eric Seidel. Modified: trunk/Source/WebCore/WebCore.exp.in (88177 => 88178) --- trunk/Source/WebCore/WebCore.exp.in 2011-06-06 18:51:32 UTC (rev 88177) +++ trunk/Source/WebCore/WebCore.exp.in 2011-06-06 19:21:32 UTC (rev 88178) @@ -215,7 +215,7 @@ __ZN7WebCore11MemoryCache14evictResourcesEv __ZN7WebCore11MemoryCache19getOriginsWithCacheERN3WTF7HashSetINS1_6RefPtrINS_14SecurityOriginEEENS_18SecurityOriginHashENS1_10HashTraitsIS5_ __ZN7WebCore11MemoryCache25removeResourcesWithOriginEPNS_14SecurityOriginE -__ZN7WebCore11RenderLayer19scrollRectToVisibleERKNS_7IntRectEbRKNS_15ScrollAlignmentES6_ +__ZN7WebCore11RenderLayer19scrollRectToVisibleERKNS_7IntRectERKNS_15ScrollAlignmentES6_ __ZN7WebCore11globalPointERK8_NSPointP8NSWindow __ZN7WebCore11memoryCacheEv __ZN7WebCore11startOfWordERKNS_15VisiblePositionENS_9EWordSideE Modified: trunk/Source/WebCore/WebCore.order (88177 => 88178) --- trunk/Source/WebCore/WebCore.order 2011-06-06 18:51:32 UTC (rev 88177) +++ trunk/Source/WebCore/WebCore.order 2011-06-06 19:21:32 UTC (rev 88178) @@ -4208,7 +4208,7 @@
[webkit-changes] [88179] trunk/Tools
Title: [88179] trunk/Tools
Revision 88179
Author commit-qu...@webkit.org
Date 2011-06-06 12:36:08 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Yong Li y...@rim.com
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=62097
Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (88178 => 88179)
--- trunk/Tools/ChangeLog 2011-06-06 19:21:32 UTC (rev 88178)
+++ trunk/Tools/ChangeLog 2011-06-06 19:36:08 UTC (rev 88179)
@@ -1,3 +1,13 @@
+2011-06-06 Yong Li y...@rim.com
+
+Reviewed by Eric Seidel.
+
+https://bugs.webkit.org/show_bug.cgi?id=62097
+Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+
2011-06-06 Xan Lopez xlo...@igalia.com
Reviewed by Martin Robinson.
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (88178 => 88179)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-06-06 19:21:32 UTC (rev 88178)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-06-06 19:36:08 UTC (rev 88179)
@@ -2922,7 +2922,7 @@
# Check for plain bitfields declared without either singed or unsigned.
# Most compilers treat such bitfields as signed, but there are still compilers like
# RVCT 4.0 that use unsigned by default.
-matched = re.match(r'\s*((const|mutable)\s+)?(char|(short(\s+int)?)|int|long(\s+(long|int))?)\s+.+\s*:\s*\d+\s*;', line)
+matched = re.match(r'\s*((const|mutable)\s+)?(char|(short(\s+int)?)|int|long(\s+(long|int))?)\s+[a-zA-Z_][a-zA-Z0-9_]*\s*:\s*\d+\s*;', line)
if matched:
error(line_number, 'runtime/bitfields', 5,
'Please declare integral type bitfields with either signed or unsigned.')
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (88178 => 88179)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-06-06 19:21:32 UTC (rev 88178)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-06-06 19:36:08 UTC (rev 88179)
@@ -2381,6 +2381,7 @@
self.assert_lint('mutable short a : 14;', errmsg)
self.assert_lint('const char a : 6;', errmsg)
self.assert_lint('long int a : 30;', errmsg)
+self.assert_lint('int a = 1 ? 0 : 30;', '')
class CleansedLinesTest(unittest.TestCase):
def test_init(self):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88180] trunk/LayoutTests
Title: [88180] trunk/LayoutTests Revision 88180 Author vange...@chromium.org Date 2011-06-06 12:40:10 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Vangelis Kokkevis vange...@chromium.org Unreviewed. Layout test expectations fix. [chromium] Adjusting expectations for failing huge-layer-img.html * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (88179 => 88180) --- trunk/LayoutTests/ChangeLog 2011-06-06 19:36:08 UTC (rev 88179) +++ trunk/LayoutTests/ChangeLog 2011-06-06 19:40:10 UTC (rev 88180) @@ -1,3 +1,11 @@ +2011-06-06 Vangelis Kokkevis vange...@chromium.org + +Unreviewed. Layout test expectations fix. + +[chromium] Adjusting expectations for failing huge-layer-img.html + +* platform/chromium/test_expectations.txt: + 2011-06-06 Yael Aharon yael.aha...@nokia.com Reviewed by Eric Seidel. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88179 => 88180) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-06 19:36:08 UTC (rev 88179) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-06 19:40:10 UTC (rev 88180) @@ -992,7 +992,7 @@ BUGCR81858 WIN LINUX GPU : fast/canvas/canvas-longlived-context.html = PASS TEXT // Misc. render failures -BUGCR81718 WIN LINUX GPU : compositing/tiling/huge-layer-img.html = CRASH +BUGWK62138 WIN LINUX GPU : compositing/tiling/huge-layer-img.html = TEXT BUGCR81606 WIN LINUX GPU : fast/canvas/drawImage-with-globalAlpha.html = IMAGE // fillRect failures ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88182] trunk/LayoutTests
Title: [88182] trunk/LayoutTests Revision 88182 Author jber...@webkit.org Date 2011-06-06 12:57:32 -0700 (Mon, 06 Jun 2011) Log Message Windows DRT needs an implementation of shadowRoot. https://bugs.webkit.org/show_bug.cgi?id=59081 Skip more tests on Windows that use the Shadow DOM to get the bots green. * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (88181 => 88182) --- trunk/LayoutTests/ChangeLog 2011-06-06 19:42:54 UTC (rev 88181) +++ trunk/LayoutTests/ChangeLog 2011-06-06 19:57:32 UTC (rev 88182) @@ -1,3 +1,12 @@ +2011-06-06 Jessie Berlin jber...@apple.com + +Windows DRT needs an implementation of shadowRoot. +https://bugs.webkit.org/show_bug.cgi?id=59081 + +Skip more tests on Windows that use the Shadow DOM to get the bots green. + +* platform/win/Skipped: + 2011-06-06 Anna Cavender ann...@chromium.org Reviewed by David Levin. Modified: trunk/LayoutTests/platform/win/Skipped (88181 => 88182) --- trunk/LayoutTests/platform/win/Skipped 2011-06-06 19:42:54 UTC (rev 88181) +++ trunk/LayoutTests/platform/win/Skipped 2011-06-06 19:57:32 UTC (rev 88182) @@ -1284,6 +1284,8 @@ # Windows DRT needs an implementation of shadowRoot # https://bugs.webkit.org/show_bug.cgi?id=59081 +fast/dom/HTMLMeterElement/meter-clone.html +fast/dom/HTMLProgressElement/progress-clone.html fast/dom/shadow fast/html/clone-keygen.html fast/html/clone-range.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88184] trunk/LayoutTests
Title: [88184] trunk/LayoutTests Revision 88184 Author jber...@webkit.org Date 2011-06-06 13:14:35 -0700 (Mon, 06 Jun 2011) Log Message Update the Windows-specific results after r88020 in order to get the bots green. * platform/win/fast/dom/Window/window-property-descriptors-expected.txt: * platform/win/fast/dom/prototype-inheritance-expected.txt: * platform/win/fast/js/global-constructors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-expected.txt trunk/LayoutTests/platform/win/fast/js/global-constructors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (88183 => 88184) --- trunk/LayoutTests/ChangeLog 2011-06-06 19:57:36 UTC (rev 88183) +++ trunk/LayoutTests/ChangeLog 2011-06-06 20:14:35 UTC (rev 88184) @@ -1,5 +1,13 @@ 2011-06-06 Jessie Berlin jber...@apple.com +Update the Windows-specific results after r88020 in order to get the bots green. + +* platform/win/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/win/fast/dom/prototype-inheritance-expected.txt: +* platform/win/fast/js/global-constructors-expected.txt: + +2011-06-06 Jessie Berlin jber...@apple.com + Windows DRT needs an implementation of shadowRoot. https://bugs.webkit.org/show_bug.cgi?id=59081 Modified: trunk/LayoutTests/platform/win/fast/dom/Window/window-property-descriptors-expected.txt (88183 => 88184) --- trunk/LayoutTests/platform/win/fast/dom/Window/window-property-descriptors-expected.txt 2011-06-06 19:57:36 UTC (rev 88183) +++ trunk/LayoutTests/platform/win/fast/dom/Window/window-property-descriptors-expected.txt 2011-06-06 20:14:35 UTC (rev 88184) @@ -166,6 +166,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAngle') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateColorElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateElement') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateMotionElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateTransformElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimatedAngle') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimatedBoolean') is 'object' @@ -234,6 +235,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGLengthList') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGLineElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGLinearGradientElement') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMPathElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMarkerElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMaskElement') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMatrix') is 'object' Modified: trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-expected.txt (88183 => 88184) --- trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-expected.txt 2011-06-06 19:57:36 UTC (rev 88183) +++ trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-expected.txt 2011-06-06 20:14:35 UTC (rev 88184) @@ -325,6 +325,8 @@ PASS inner.SVGAnimateColorElement.constructor.isInner is true PASS inner.SVGAnimateElement.isInner is true PASS inner.SVGAnimateElement.constructor.isInner is true +PASS inner.SVGAnimateMotionElement.isInner is true +PASS inner.SVGAnimateMotionElement.constructor.isInner is true PASS inner.SVGAnimateTransformElement.isInner is true PASS inner.SVGAnimateTransformElement.constructor.isInner is true PASS inner.SVGAnimatedAngle.isInner is true @@ -461,6 +463,8 @@ PASS inner.SVGLineElement.constructor.isInner is true PASS inner.SVGLinearGradientElement.isInner is true PASS inner.SVGLinearGradientElement.constructor.isInner is true +PASS inner.SVGMPathElement.isInner is true +PASS inner.SVGMPathElement.constructor.isInner is true PASS inner.SVGMarkerElement.isInner is true PASS inner.SVGMarkerElement.constructor.isInner is true PASS inner.SVGMaskElement.isInner is true Modified: trunk/LayoutTests/platform/win/fast/js/global-constructors-expected.txt (88183 => 88184) --- trunk/LayoutTests/platform/win/fast/js/global-constructors-expected.txt 2011-06-06 19:57:36 UTC (rev 88183) +++ trunk/LayoutTests/platform/win/fast/js/global-constructors-expected.txt 2011-06-06 20:14:35 UTC (rev 88184) @@ -151,6 +151,7 @@ PASS SVGAngle.toString() is '[object SVGAngleConstructor]' PASS SVGAnimateColorElement.toString() is '[object SVGAnimateColorElementConstructor]' PASS SVGAnimateElement.toString() is '[object SVGAnimateElementConstructor]' +PASS SVGAnimateMotionElement.toString() is '[object SVGAnimateMotionElementConstructor]' PASS
[webkit-changes] [88186] trunk/Source/WebCore
Title: [88186] trunk/Source/WebCore
Revision 88186
Author le...@chromium.org
Date 2011-06-06 13:42:09 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-03 Levi Weintraub le...@chromium.org
Reviewed by Eric Seidel.
Switch paintSelection to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62059
Switching paintSelection to use an IntPoint to represent the paint offset
instead of a pair of ints.
No new tests since this is simple refactoring.
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):
* rendering/EllipsisBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintSelection):
* rendering/RenderBlock.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/EllipsisBox.cpp
trunk/Source/WebCore/rendering/EllipsisBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (88185 => 88186)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 20:18:58 UTC (rev 88185)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 20:42:09 UTC (rev 88186)
@@ -1,3 +1,24 @@
+2011-06-03 Levi Weintraub le...@chromium.org
+
+Reviewed by Eric Seidel.
+
+Switch paintSelection to use IntPoint
+https://bugs.webkit.org/show_bug.cgi?id=62059
+
+Switching paintSelection to use an IntPoint to represent the paint offset
+instead of a pair of ints.
+
+No new tests since this is simple refactoring.
+
+* rendering/EllipsisBox.cpp:
+(WebCore::EllipsisBox::paint):
+(WebCore::EllipsisBox::paintSelection):
+* rendering/EllipsisBox.h:
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::paintObject):
+(WebCore::RenderBlock::paintSelection):
+* rendering/RenderBlock.h:
+
2011-06-06 Emil A Eklund e...@chromium.org
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/rendering/EllipsisBox.cpp (88185 => 88186)
--- trunk/Source/WebCore/rendering/EllipsisBox.cpp 2011-06-06 20:18:58 UTC (rev 88185)
+++ trunk/Source/WebCore/rendering/EllipsisBox.cpp 2011-06-06 20:42:09 UTC (rev 88186)
@@ -46,7 +46,7 @@
const Font font = style-font();
if (selectionState() != RenderObject::SelectionNone) {
-paintSelection(context, paintOffset.x(), paintOffset.y(), style, font);
+paintSelection(context, paintOffset, style, font);
// Select the correct color for painting the text.
Color foreground = paintInfo.forceBlackText ? Color::black : renderer()-selectionForegroundColor();
@@ -81,7 +81,7 @@
return enclosingIntRect(font.selectionRectForText(RenderBlock::constructTextRun(renderer(), font, m_str, style, TextRun::AllowTrailingExpansion), IntPoint(x() + tx, y() + ty + root()-selectionTop()), root()-selectionHeight()));
}
-void EllipsisBox::paintSelection(GraphicsContext* context, int tx, int ty, RenderStyle* style, const Font font)
+void EllipsisBox::paintSelection(GraphicsContext* context, const IntPoint paintOffset, RenderStyle* style, const Font font)
{
Color textColor = style-visitedDependentColor(CSSPropertyColor);
Color c = m_renderer-selectionBackgroundColor();
@@ -96,9 +96,9 @@
GraphicsContextStateSaver stateSaver(*context);
int top = root()-selectionTop();
int h = root()-selectionHeight();
-context-clip(IntRect(x() + tx, top + ty, m_logicalWidth, h));
+context-clip(IntRect(x() + paintOffset.x(), top + paintOffset.y(), m_logicalWidth, h));
// FIXME: Why is this always LTR? Fix by passing correct text run flags below.
-context-drawHighlightForText(font, RenderBlock::constructTextRun(renderer(), font, m_str, style, TextRun::AllowTrailingExpansion), IntPoint(x() + tx, y() + ty + top), h, c, style-colorSpace());
+context-drawHighlightForText(font, RenderBlock::constructTextRun(renderer(), font, m_str, style, TextRun::AllowTrailingExpansion), IntPoint(x() + paintOffset.x(), y() + paintOffset.y() + top), h, c, style-colorSpace());
}
bool EllipsisBox::nodeAtPoint(const HitTestRequest request, HitTestResult result, const IntPoint pointInContainer, int tx, int ty, int lineTop, int lineBottom)
Modified: trunk/Source/WebCore/rendering/EllipsisBox.h (88185 => 88186)
--- trunk/Source/WebCore/rendering/EllipsisBox.h 2011-06-06 20:18:58 UTC (rev 88185)
+++ trunk/Source/WebCore/rendering/EllipsisBox.h 2011-06-06 20:42:09 UTC (rev 88186)
@@ -47,7 +47,7 @@
private:
virtual int height() const { return m_height; }
virtual RenderObject::SelectionState selectionState() { return m_selectionState; }
-void paintSelection(GraphicsContext*, int tx, int ty, RenderStyle*, const Font);
+void paintSelection(GraphicsContext*, const IntPoint, RenderStyle*, const Font);
int m_height;
AtomicString m_str;
___
webkit-changes mailing list
[webkit-changes] [88187] trunk
Title: [88187] trunk
Revision 88187
Author commit-qu...@webkit.org
Date 2011-06-06 14:15:45 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Paul Kinlan paulkin...@google.com
Reviewed by Jeremy Orlow.
Adds a test for firing popstate, using window.dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=62099
* fast/events/fire-popstate-event-expected.txt: Added.
* fast/events/fire-popstate-event.html: Added.
2011-06-06 Paul Kinlan paulkin...@google.com
Reviewed by Jeremy Orlow.
Let developers call createEvent(PopStateEvent), previously it wasn't
exposed and threw an exeception.
https://bugs.webkit.org/show_bug.cgi?id=62099
* WebCore/dom/Document.cpp:
* WebCore/dom/PopStateEvent.cpp:
* WebCore/dom/PopStateEvent.h:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/PopStateEvent.cpp
trunk/Source/WebCore/dom/PopStateEvent.h
Added Paths
trunk/LayoutTests/fast/events/fire-popstate-event-expected.txt
trunk/LayoutTests/fast/events/fire-popstate-event.html
Diff
Modified: trunk/LayoutTests/ChangeLog (88186 => 88187)
--- trunk/LayoutTests/ChangeLog 2011-06-06 20:42:09 UTC (rev 88186)
+++ trunk/LayoutTests/ChangeLog 2011-06-06 21:15:45 UTC (rev 88187)
@@ -1,3 +1,13 @@
+2011-06-06 Paul Kinlan paulkin...@google.com
+
+Reviewed by Jeremy Orlow.
+
+Adds a test for firing popstate, using window.dispatchEvent.
+https://bugs.webkit.org/show_bug.cgi?id=62099
+
+* fast/events/fire-popstate-event-expected.txt: Added.
+* fast/events/fire-popstate-event.html: Added.
+
2011-06-06 Jessie Berlin jber...@apple.com
Update the Windows-specific results after r88020 in order to get the bots green.
Added: trunk/LayoutTests/fast/events/fire-popstate-event-expected.txt (0 => 88187)
--- trunk/LayoutTests/fast/events/fire-popstate-event-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/fire-popstate-event-expected.txt 2011-06-06 21:15:45 UTC (rev 88187)
@@ -0,0 +1,10 @@
+Checks that the popstate event fires when dispatched via createEvent
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS Popstate state: (Success)
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/events/fire-popstate-event.html (0 => 88187)
--- trunk/LayoutTests/fast/events/fire-popstate-event.html (rev 0)
+++ trunk/LayoutTests/fast/events/fire-popstate-event.html 2011-06-06 21:15:45 UTC (rev 88187)
@@ -0,0 +1,33 @@
+
+html
+link rel=stylesheet href=""
+script src=""
+body style=min-width: 5000px; min-height: 5000px
+p id=description/p
+div id=console/div
+script
+description('Checks that the popstate event fires when dispatched via createEvent');
+
+_onpopstate_ = function(event)
+{
+if(!!event.state !!event.state.testValue)
+{
+testPassed('Popstate state: (' + event.state.testValue +')');
+}
+}
+
+_onload_ = function()
+{
+var evt = document.createEvent(PopStateEvent);
+evt.initPopStateEvent(popstate, false, false, { testValue: Success} );
+window.dispatchEvent(evt);
+}
+
+setTimeout(finishJSTest, 500);
+
+var successfullyParsed = true;
+var jsTestIsAsync = true;
+/script
+script src=""
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (88186 => 88187)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 20:42:09 UTC (rev 88186)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 21:15:45 UTC (rev 88187)
@@ -1,3 +1,15 @@
+2011-06-06 Paul Kinlan paulkin...@google.com
+
+Reviewed by Jeremy Orlow.
+
+Let developers call createEvent(PopStateEvent), previously it wasn't
+exposed and threw an exeception.
+https://bugs.webkit.org/show_bug.cgi?id=62099
+
+* WebCore/dom/Document.cpp:
+* WebCore/dom/PopStateEvent.cpp:
+* WebCore/dom/PopStateEvent.h:
+
2011-06-03 Levi Weintraub le...@chromium.org
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/dom/Document.cpp (88186 => 88187)
--- trunk/Source/WebCore/dom/Document.cpp 2011-06-06 20:42:09 UTC (rev 88186)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-06-06 21:15:45 UTC (rev 88187)
@@ -3465,6 +3465,8 @@
event = OverflowEvent::create();
else if (eventType == PageTransitionEvent)
event = PageTransitionEvent::create();
+else if (eventType == PopStateEvent)
+event = PopStateEvent::create();
else if (eventType == ProgressEvent)
event = ProgressEvent::create();
#if ENABLE(DOM_STORAGE)
Modified: trunk/Source/WebCore/dom/PopStateEvent.cpp (88186 => 88187)
--- trunk/Source/WebCore/dom/PopStateEvent.cpp 2011-06-06 20:42:09 UTC (rev 88186)
+++ trunk/Source/WebCore/dom/PopStateEvent.cpp 2011-06-06 21:15:45 UTC (rev 88187)
@@ -31,6 +31,11 @@
namespace WebCore {
[webkit-changes] [88188] trunk/Source/WebCore
Title: [88188] trunk/Source/WebCore
Revision 88188
Author le...@chromium.org
Date 2011-06-06 14:26:24 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Levi Weintraub le...@chromium.org
Reviewed by Eric Seidel.
Remove tx/ty offset from selectionRect
https://bugs.webkit.org/show_bug.cgi?id=62146
Removing unused offset parameters from selectionRect.
No new tests since this is just cleanup.
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::selectionRect):
* rendering/EllipsisBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
* rendering/InlineTextBox.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::ellipsisRectForBox):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::selectionRectForRepaint):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::selectionRect):
* rendering/svg/SVGInlineTextBox.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/EllipsisBox.cpp
trunk/Source/WebCore/rendering/EllipsisBox.h
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebCore/rendering/InlineTextBox.h
trunk/Source/WebCore/rendering/RenderText.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
trunk/Source/WebCore/rendering/svg/SVGInlineTextBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (88187 => 88188)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 21:15:45 UTC (rev 88187)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 21:26:24 UTC (rev 88188)
@@ -1,3 +1,31 @@
+2011-06-06 Levi Weintraub le...@chromium.org
+
+Reviewed by Eric Seidel.
+
+Remove tx/ty offset from selectionRect
+https://bugs.webkit.org/show_bug.cgi?id=62146
+
+Removing unused offset parameters from selectionRect.
+
+No new tests since this is just cleanup.
+
+* rendering/EllipsisBox.cpp:
+(WebCore::EllipsisBox::selectionRect):
+* rendering/EllipsisBox.h:
+* rendering/InlineTextBox.cpp:
+(WebCore::InlineTextBox::selectionRect):
+* rendering/InlineTextBox.h:
+* rendering/RenderText.cpp:
+(WebCore::RenderText::absoluteRectsForRange):
+(WebCore::ellipsisRectForBox):
+(WebCore::RenderText::absoluteQuadsForRange):
+(WebCore::RenderText::selectionRectForRepaint):
+* rendering/svg/RenderSVGInlineText.cpp:
+(WebCore::RenderSVGInlineText::localCaretRect):
+* rendering/svg/SVGInlineTextBox.cpp:
+(WebCore::SVGInlineTextBox::selectionRect):
+* rendering/svg/SVGInlineTextBox.h:
+
2011-06-06 Paul Kinlan paulkin...@google.com
Reviewed by Jeremy Orlow.
Modified: trunk/Source/WebCore/rendering/EllipsisBox.cpp (88187 => 88188)
--- trunk/Source/WebCore/rendering/EllipsisBox.cpp 2011-06-06 21:15:45 UTC (rev 88187)
+++ trunk/Source/WebCore/rendering/EllipsisBox.cpp 2011-06-06 21:26:24 UTC (rev 88188)
@@ -73,12 +73,12 @@
}
}
-IntRect EllipsisBox::selectionRect(int tx, int ty)
+IntRect EllipsisBox::selectionRect()
{
RenderStyle* style = m_renderer-style(m_firstLine);
const Font font = style-font();
// FIXME: Why is this always LTR? Fix by passing correct text run flags below.
-return enclosingIntRect(font.selectionRectForText(RenderBlock::constructTextRun(renderer(), font, m_str, style, TextRun::AllowTrailingExpansion), IntPoint(x() + tx, y() + ty + root()-selectionTop()), root()-selectionHeight()));
+return enclosingIntRect(font.selectionRectForText(RenderBlock::constructTextRun(renderer(), font, m_str, style, TextRun::AllowTrailingExpansion), IntPoint(x(), y() + root()-selectionTop()), root()-selectionHeight()));
}
void EllipsisBox::paintSelection(GraphicsContext* context, const IntPoint paintOffset, RenderStyle* style, const Font font)
Modified: trunk/Source/WebCore/rendering/EllipsisBox.h (88187 => 88188)
--- trunk/Source/WebCore/rendering/EllipsisBox.h 2011-06-06 21:15:45 UTC (rev 88187)
+++ trunk/Source/WebCore/rendering/EllipsisBox.h 2011-06-06 21:26:24 UTC (rev 88188)
@@ -42,7 +42,7 @@
virtual void paint(PaintInfo, const IntPoint, int lineTop, int lineBottom);
virtual bool nodeAtPoint(const HitTestRequest, HitTestResult, const IntPoint pointInContainer, int tx, int ty, int lineTop, int lineBottom);
void setSelectionState(RenderObject::SelectionState s) { m_selectionState = s; }
-IntRect selectionRect(int tx, int ty);
+IntRect selectionRect();
private:
virtual int height() const { return m_height; }
Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (88187 => 88188)
--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2011-06-06
[webkit-changes] [88189] trunk/Source/WebCore
Title: [88189] trunk/Source/WebCore
Revision 88189
Author e...@chromium.org
Date 2011-06-06 14:30:42 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Emil A Eklund e...@chromium.org
Reviewed by Eric Seidel.
Convert RenderBox::popContentsClip to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62132
Covered by existing tests.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::popContentsClip):
* rendering/RenderBox.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/RenderTableSection.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (88188 => 88189)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 21:26:24 UTC (rev 88188)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 21:30:42 UTC (rev 88189)
@@ -1,3 +1,22 @@
+2011-06-06 Emil A Eklund e...@chromium.org
+
+Reviewed by Eric Seidel.
+
+Convert RenderBox::popContentsClip to IntPoint
+https://bugs.webkit.org/show_bug.cgi?id=62132
+
+Covered by existing tests.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::paint):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::popContentsClip):
+* rendering/RenderBox.h:
+* rendering/RenderTable.cpp:
+(WebCore::RenderTable::paint):
+* rendering/RenderTableSection.cpp:
+(WebCore::RenderTableSection::paint):
+
2011-06-06 Levi Weintraub le...@chromium.org
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (88188 => 88189)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-06-06 21:26:24 UTC (rev 88188)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-06-06 21:30:42 UTC (rev 88189)
@@ -2260,7 +2260,7 @@
bool pushedClip = pushContentsClip(paintInfo, tx, ty);
paintObject(paintInfo, IntPoint(tx, ty));
if (pushedClip)
-popContentsClip(paintInfo, phase, tx, ty);
+popContentsClip(paintInfo, phase, IntPoint(tx, ty));
// Our scrollbar widgets paint exactly when we tell them to, so that they work properly with
// z-index. We paint after we painted the background/border, so that the scrollbars will
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (88188 => 88189)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2011-06-06 21:26:24 UTC (rev 88188)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2011-06-06 21:30:42 UTC (rev 88189)
@@ -1122,14 +1122,14 @@
return true;
}
-void RenderBox::popContentsClip(PaintInfo paintInfo, PaintPhase originalPhase, int tx, int ty)
+void RenderBox::popContentsClip(PaintInfo paintInfo, PaintPhase originalPhase, const IntPoint accumulatedOffset)
{
ASSERT(hasControlClip() || (hasOverflowClip() !layer()-isSelfPaintingLayer()));
paintInfo.context-restore();
if (originalPhase == PaintPhaseOutline) {
paintInfo.phase = PaintPhaseSelfOutline;
-paintObject(paintInfo, IntPoint(tx, ty));
+paintObject(paintInfo, accumulatedOffset);
paintInfo.phase = originalPhase;
} else if (originalPhase == PaintPhaseChildBlockBackground)
paintInfo.phase = originalPhase;
Modified: trunk/Source/WebCore/rendering/RenderBox.h (88188 => 88189)
--- trunk/Source/WebCore/rendering/RenderBox.h 2011-06-06 21:26:24 UTC (rev 88188)
+++ trunk/Source/WebCore/rendering/RenderBox.h 2011-06-06 21:30:42 UTC (rev 88189)
@@ -350,7 +350,7 @@
virtual bool hasControlClip() const { return false; }
virtual IntRect controlClipRect(const IntPoint) const { return IntRect(); }
bool pushContentsClip(PaintInfo, int tx, int ty);
-void popContentsClip(PaintInfo, PaintPhase originalPhase, int tx, int ty);
+void popContentsClip(PaintInfo, PaintPhase originalPhase, const IntPoint accumulatedOffset);
virtual void paintObject(PaintInfo, const IntPoint) { ASSERT_NOT_REACHED(); }
virtual void paintBoxDecorations(PaintInfo, const IntPoint);
Modified: trunk/Source/WebCore/rendering/RenderTable.cpp (88188 => 88189)
--- trunk/Source/WebCore/rendering/RenderTable.cpp 2011-06-06 21:26:24 UTC (rev 88188)
+++ trunk/Source/WebCore/rendering/RenderTable.cpp 2011-06-06 21:30:42 UTC (rev 88189)
@@ -470,7 +470,7 @@
bool pushedClip = pushContentsClip(paintInfo, tx, ty);
paintObject(paintInfo, IntPoint(tx, ty));
if (pushedClip)
-popContentsClip(paintInfo, paintPhase, tx, ty);
+popContentsClip(paintInfo, paintPhase, IntPoint(tx, ty));
}
void RenderTable::paintObject(PaintInfo paintInfo, const IntPoint
[webkit-changes] [88190] trunk/Source/WebCore
Title: [88190] trunk/Source/WebCore
Revision 88190
Author le...@chromium.org
Date 2011-06-06 14:35:56 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Levi Weintraub le...@chromium.org
Reviewed by Eric Seidel.
Switch paintOutline, paintContinuationOutlines, and paintOutlineForLine to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62137
Switching paintOutline, paintContinuationOutlines, and paintOutlineForLine to take an IntPoint
representing the paint offset instead of a pair of ints.
No new tests as this is simple refactoring.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintContinuationOutlines):
* rendering/RenderBlock.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):
* rendering/RenderInline.h:
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderInline.h
trunk/Source/WebCore/rendering/RenderLineBoxList.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (88189 => 88190)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 21:30:42 UTC (rev 88189)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 21:35:56 UTC (rev 88190)
@@ -1,3 +1,26 @@
+2011-06-06 Levi Weintraub le...@chromium.org
+
+Reviewed by Eric Seidel.
+
+Switch paintOutline, paintContinuationOutlines, and paintOutlineForLine to use IntPoint
+https://bugs.webkit.org/show_bug.cgi?id=62137
+
+Switching paintOutline, paintContinuationOutlines, and paintOutlineForLine to take an IntPoint
+representing the paint offset instead of a pair of ints.
+
+No new tests as this is simple refactoring.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::paintObject):
+(WebCore::RenderBlock::paintContinuationOutlines):
+* rendering/RenderBlock.h:
+* rendering/RenderInline.cpp:
+(WebCore::RenderInline::paintOutline):
+(WebCore::RenderInline::paintOutlineForLine):
+* rendering/RenderInline.h:
+* rendering/RenderLineBoxList.cpp:
+(WebCore::RenderLineBoxList::paint):
+
2011-06-06 Emil A Eklund e...@chromium.org
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (88189 => 88190)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-06-06 21:30:42 UTC (rev 88189)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-06-06 21:35:56 UTC (rev 88190)
@@ -2526,10 +2526,9 @@
if (!inlineEnclosedInSelfPaintingLayer)
cb-addContinuationWithOutline(inlineRenderer);
else if (!inlineRenderer-firstLineBox())
-inlineRenderer-paintOutline(paintInfo.context, paintOffset.x() - x() + inlineRenderer-containingBlock()-x(),
- paintOffset.y() - y() + inlineRenderer-containingBlock()-y());
+inlineRenderer-paintOutline(paintInfo.context, paintOffset - locationOffset() + inlineRenderer-containingBlock()-location());
}
-paintContinuationOutlines(paintInfo, paintOffset.x(), paintOffset.y());
+paintContinuationOutlines(paintInfo, paintOffset);
}
// 7. paint caret.
@@ -2660,7 +2659,7 @@
return continuations-contains(flow);
}
-void RenderBlock::paintContinuationOutlines(PaintInfo info, int tx, int ty)
+void RenderBlock::paintContinuationOutlines(PaintInfo info, const IntPoint paintOffset)
{
ContinuationOutlineTableMap* table = continuationOutlineTable();
if (table-isEmpty())
@@ -2669,19 +2668,18 @@
ListHashSetRenderInline** continuations = table-get(this);
if (!continuations)
return;
-
+
+IntPoint accumulatedPaintOffset = paintOffset;
// Paint each continuation outline.
ListHashSetRenderInline*::iterator end = continuations-end();
for (ListHashSetRenderInline*::iterator it = continuations-begin(); it != end; ++it) {
// Need to add in the coordinates of the intervening blocks.
RenderInline* flow = *it;
RenderBlock* block = flow-containingBlock();
-for ( ; block block != this; block = block-containingBlock()) {
-tx += block-x();
-ty += block-y();
-}
+for ( ; block block != this; block = block-containingBlock())
+accumulatedPaintOffset.move(block-location());
ASSERT(block);
-flow-paintOutline(info.context, tx, ty);
+flow-paintOutline(info.context, accumulatedPaintOffset);
}
// Delete
Modified: trunk/Source/WebCore/rendering/RenderBlock.h (88189 => 88190)
---
[webkit-changes] [88191] trunk/Source/WebKit/chromium
Title: [88191] trunk/Source/WebKit/chromium
Revision 88191
Author tha...@chromium.org
Date 2011-06-06 14:45:38 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Nico Weber tha...@chromium.org
Reviewed by James Robinson.
[chromium] Make WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's destructors virtual
https://bugs.webkit.org/show_bug.cgi?id=62148
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
* src/WebURLRequest.cpp:
(WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
* src/WebURLResponse.cpp:
(WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebURLRequest.cpp
trunk/Source/WebKit/chromium/src/WebURLResponse.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88190 => 88191)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-06 21:35:56 UTC (rev 88190)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-06 21:45:38 UTC (rev 88191)
@@ -1,3 +1,20 @@
+2011-06-06 Nico Weber tha...@chromium.org
+
+Reviewed by James Robinson.
+
+[chromium] Make WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's destructors virtual
+https://bugs.webkit.org/show_bug.cgi?id=62148
+
+This is _not_ to fix a real bug, just to make clang's
+-Wdelete-non-virtual-dtor happy. As discussed at
+http://codereview.chromium.org/7094005/, we prefer making leaf class
+destructors virtual over making the leaf classes final.
+
+* src/WebURLRequest.cpp:
+(WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
+* src/WebURLResponse.cpp:
+(WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
+
2011-06-06 Shishir Agrawal shis...@chromium.org
Reviewed by Tony Gentilcore.
Modified: trunk/Source/WebKit/chromium/src/WebURLRequest.cpp (88190 => 88191)
--- trunk/Source/WebKit/chromium/src/WebURLRequest.cpp 2011-06-06 21:35:56 UTC (rev 88190)
+++ trunk/Source/WebKit/chromium/src/WebURLRequest.cpp 2011-06-06 21:45:38 UTC (rev 88191)
@@ -79,6 +79,8 @@
m_allowStoredCredentials = p-m_allowStoredCredentials;
}
+virtual ~WebURLRequestPrivateImpl() { }
+
virtual void dispose() { delete this; }
ResourceRequest m_resourceRequestAllocation;
Modified: trunk/Source/WebKit/chromium/src/WebURLResponse.cpp (88190 => 88191)
--- trunk/Source/WebKit/chromium/src/WebURLResponse.cpp 2011-06-06 21:35:56 UTC (rev 88190)
+++ trunk/Source/WebKit/chromium/src/WebURLResponse.cpp 2011-06-06 21:45:38 UTC (rev 88191)
@@ -62,6 +62,8 @@
m_resourceResponse = m_resourceResponseAllocation;
}
+virtual ~WebURLResponsePrivateImpl() { }
+
virtual void dispose() { delete this; }
ResourceResponse m_resourceResponseAllocation;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88192] trunk/Source
Title: [88192] trunk/Source Revision 88192 Author dch...@chromium.org Date 2011-06-06 14:52:46 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Daniel Cheng dch...@chromium.org Reviewed by Tony Chang. [chromium] Delete dead clipboard code. https://bugs.webkit.org/show_bug.cgi?id=62113 No new tests since this change only deleted unused code. * WebCore.gypi: * platform/chromium/ChromiumDataObjectLegacy.cpp: Removed. * platform/chromium/ChromiumDataObjectLegacy.h: Removed. * platform/chromium/ReadableDataObject.cpp: Removed. * platform/chromium/ReadableDataObject.h: Removed. * platform/chromium/WritableDataObject.cpp: Removed. * platform/chromium/WritableDataObject.h: Removed. 2011-06-06 Daniel Cheng dch...@chromium.org Reviewed by Tony Chang. [chromium] Delete dead clipboard code. https://bugs.webkit.org/show_bug.cgi?id=62113 * src/WebDragData.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebDragData.cpp Removed Paths trunk/Source/WebCore/platform/chromium/ChromiumDataObjectLegacy.cpp trunk/Source/WebCore/platform/chromium/ChromiumDataObjectLegacy.h trunk/Source/WebCore/platform/chromium/ReadableDataObject.cpp trunk/Source/WebCore/platform/chromium/ReadableDataObject.h trunk/Source/WebCore/platform/chromium/WritableDataObject.cpp trunk/Source/WebCore/platform/chromium/WritableDataObject.h Diff Modified: trunk/Source/WebCore/ChangeLog (88191 => 88192) --- trunk/Source/WebCore/ChangeLog 2011-06-06 21:45:38 UTC (rev 88191) +++ trunk/Source/WebCore/ChangeLog 2011-06-06 21:52:46 UTC (rev 88192) @@ -1,3 +1,20 @@ +2011-06-06 Daniel Cheng dch...@chromium.org + +Reviewed by Tony Chang. + +[chromium] Delete dead clipboard code. +https://bugs.webkit.org/show_bug.cgi?id=62113 + +No new tests since this change only deleted unused code. + +* WebCore.gypi: +* platform/chromium/ChromiumDataObjectLegacy.cpp: Removed. +* platform/chromium/ChromiumDataObjectLegacy.h: Removed. +* platform/chromium/ReadableDataObject.cpp: Removed. +* platform/chromium/ReadableDataObject.h: Removed. +* platform/chromium/WritableDataObject.cpp: Removed. +* platform/chromium/WritableDataObject.h: Removed. + 2011-06-06 Levi Weintraub le...@chromium.org Reviewed by Eric Seidel. Modified: trunk/Source/WebCore/WebCore.gypi (88191 => 88192) --- trunk/Source/WebCore/WebCore.gypi 2011-06-06 21:45:38 UTC (rev 88191) +++ trunk/Source/WebCore/WebCore.gypi 2011-06-06 21:52:46 UTC (rev 88192) @@ -3784,8 +3784,6 @@ 'platform/cf/SharedBufferCF.cpp', 'platform/chromium/ChromiumDataObject.cpp', 'platform/chromium/ChromiumDataObject.h', -'platform/chromium/ChromiumDataObjectLegacy.cpp', -'platform/chromium/ChromiumDataObjectLegacy.h', 'platform/chromium/ClipboardChromium.cpp', 'platform/chromium/ClipboardChromium.h', 'platform/chromium/ClipboardChromiumLinux.cpp', @@ -3833,8 +3831,6 @@ 'platform/chromium/PopupMenuChromium.cpp', 'platform/chromium/PopupMenuChromium.h', 'platform/chromium/PopupMenuPrivate.h', -'platform/chromium/ReadableDataObject.cpp', -'platform/chromium/ReadableDataObject.h', 'platform/chromium/SSLKeyGeneratorChromium.cpp', 'platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h', 'platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm', @@ -3858,8 +3854,6 @@ 'platform/chromium/ThemeChromiumMac.mm', 'platform/chromium/TraceEvent.h', 'platform/chromium/WidgetChromium.cpp', -'platform/chromium/WritableDataObject.cpp', -'platform/chromium/WritableDataObject.h', 'platform/cocoa/KeyEventCocoa.h', 'platform/cocoa/KeyEventCocoa.mm', 'platform/efl/ClipboardEfl.cpp', Deleted: trunk/Source/WebCore/platform/chromium/ChromiumDataObjectLegacy.cpp (88191 => 88192) --- trunk/Source/WebCore/platform/chromium/ChromiumDataObjectLegacy.cpp 2011-06-06 21:45:38 UTC (rev 88191) +++ trunk/Source/WebCore/platform/chromium/ChromiumDataObjectLegacy.cpp 2011-06-06 21:52:46 UTC (rev 88192) @@ -1,249 +0,0 @@ -/* - * Copyright (c) 2008, 2009, Google Inc. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are - * met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above - * copyright notice, this list of conditions and the following
[webkit-changes] [88193] trunk/Source/WebCore
Title: [88193] trunk/Source/WebCore
Revision 88193
Author le...@chromium.org
Date 2011-06-06 15:00:10 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Levi Weintraub le...@chromium.org
Reviewed by Eric Seidel.
Switch paintScrollbar to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62151
Switching paintScrollbar to use IntPoint instead of a pair of ints.
No new tests since this is simple refactoring.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintObject):
(WebCore::RenderListBox::paintScrollbar):
* rendering/RenderListBox.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (88192 => 88193)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 21:52:46 UTC (rev 88192)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 22:00:10 UTC (rev 88193)
@@ -1,3 +1,19 @@
+2011-06-06 Levi Weintraub le...@chromium.org
+
+Reviewed by Eric Seidel.
+
+Switch paintScrollbar to use IntPoint
+https://bugs.webkit.org/show_bug.cgi?id=62151
+
+Switching paintScrollbar to use IntPoint instead of a pair of ints.
+
+No new tests since this is simple refactoring.
+
+* rendering/RenderListBox.cpp:
+(WebCore::RenderListBox::paintObject):
+(WebCore::RenderListBox::paintScrollbar):
+* rendering/RenderListBox.h:
+
2011-06-06 Daniel Cheng dch...@chromium.org
Reviewed by Tony Chang.
Modified: trunk/Source/WebCore/rendering/RenderListBox.cpp (88192 => 88193)
--- trunk/Source/WebCore/rendering/RenderListBox.cpp 2011-06-06 21:52:46 UTC (rev 88192)
+++ trunk/Source/WebCore/rendering/RenderListBox.cpp 2011-06-06 22:00:10 UTC (rev 88193)
@@ -279,11 +279,11 @@
// get rendered in the foreground or background phases
case PaintPhaseForeground:
if (m_vBar-isOverlayScrollbar())
-paintScrollbar(paintInfo, paintOffset.x(), paintOffset.y());
+paintScrollbar(paintInfo, paintOffset);
break;
case PaintPhaseBlockBackground:
if (!m_vBar-isOverlayScrollbar())
-paintScrollbar(paintInfo, paintOffset.x(), paintOffset.y());
+paintScrollbar(paintInfo, paintOffset);
break;
case PaintPhaseChildBlockBackground:
case PaintPhaseChildBlockBackgrounds: {
@@ -325,11 +325,11 @@
}
}
-void RenderListBox::paintScrollbar(PaintInfo paintInfo, int tx, int ty)
+void RenderListBox::paintScrollbar(PaintInfo paintInfo, const IntPoint paintOffset)
{
if (m_vBar) {
-IntRect scrollRect(tx + width() - borderRight() - m_vBar-width(),
- ty + borderTop(),
+IntRect scrollRect(paintOffset.x() + width() - borderRight() - m_vBar-width(),
+ paintOffset.y() + borderTop(),
m_vBar-width(),
height() - (borderTop() + borderBottom()));
m_vBar-setFrameRect(scrollRect);
Modified: trunk/Source/WebCore/rendering/RenderListBox.h (88192 => 88193)
--- trunk/Source/WebCore/rendering/RenderListBox.h 2011-06-06 21:52:46 UTC (rev 88192)
+++ trunk/Source/WebCore/rendering/RenderListBox.h 2011-06-06 22:00:10 UTC (rev 88193)
@@ -132,7 +132,7 @@
int numVisibleItems() const;
int numItems() const;
int listHeight() const;
-void paintScrollbar(PaintInfo, int tx, int ty);
+void paintScrollbar(PaintInfo, const IntPoint);
void paintItemForeground(PaintInfo, const IntPoint, int listIndex);
void paintItemBackground(PaintInfo, const IntPoint, int listIndex);
void scrollToRevealSelection();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88194] trunk/LayoutTests
Title: [88194] trunk/LayoutTests
Revision 88194
Author simon...@chromium.org
Date 2011-06-06 15:03:35 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 James Simonsen simon...@chromium.org
[Chromium] Unreviewed, added baseline for inline-wrap-with-parent-padding.html
* platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
* platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png
trunk/LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (88193 => 88194)
--- trunk/LayoutTests/ChangeLog 2011-06-06 22:00:10 UTC (rev 88193)
+++ trunk/LayoutTests/ChangeLog 2011-06-06 22:03:35 UTC (rev 88194)
@@ -1,3 +1,10 @@
+2011-06-06 James Simonsen simon...@chromium.org
+
+[Chromium] Unreviewed, added baseline for inline-wrap-with-parent-padding.html
+
+* platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
+* platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
+
2011-06-06 Paul Kinlan paulkin...@google.com
Reviewed by Jeremy Orlow.
Added: trunk/LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt (0 => 88194)
--- trunk/LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt 2011-06-06 22:03:35 UTC (rev 88194)
@@ -0,0 +1,79 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x58
+ RenderBlock {HTML} at (0,0) size 800x58
+RenderBody {BODY} at (8,8) size 784x42
+ RenderBlock {DIV} at (0,0) size 322x42 [border: (1px solid #FF)]
+RenderInline {SPAN} at (0,0) size 317x41 [border: (1px solid #008000)]
+ RenderText {#text} at (2,1) size 16x19
+text run at (2,1) width 16: --
+ RenderInline {SPAN} at (0,0) size 317x39
+RenderText {#text} at (18,1) size 16x19
+ text run at (18,1) width 16: --
+RenderInline {SPAN} at (0,0) size 317x39
+ RenderText {#text} at (34,1) size 16x19
+text run at (34,1) width 16: --
+ RenderInline {SPAN} at (0,0) size 317x39
+RenderText {#text} at (50,1) size 16x19
+ text run at (50,1) width 16: --
+RenderInline {SPAN} at (0,0) size 317x39
+ RenderText {#text} at (66,1) size 16x19
+text run at (66,1) width 16: --
+ RenderInline {SPAN} at (0,0) size 317x39
+RenderText {#text} at (82,1) size 16x19
+ text run at (82,1) width 16: --
+RenderInline {SPAN} at (0,0) size 317x39
+ RenderText {#text} at (98,1) size 16x19
+text run at (98,1) width 16: --
+ RenderInline {SPAN} at (0,0) size 317x39
+RenderText {#text} at (114,1) size 16x19
+ text run at (114,1) width 16: --
+RenderInline {SPAN} at (0,0) size 317x39
+ RenderText {#text} at (130,1) size 16x19
+text run at (130,1) width 16: --
+ RenderInline {SPAN} at (0,0) size 317x39
+RenderText {#text} at (146,1) size 16x19
+ text run at (146,1) width 16: --
+RenderInline {SPAN} at (0,0) size 317x39
+ RenderText {#text} at (162,1) size 16x19
+text run at (162,1) width 16: --
+ RenderInline {SPAN} at (0,0) size 317x39
+RenderText {#text} at (178,1) size 16x19
+ text run at (178,1) width 16: --
+RenderInline {SPAN} at (0,0) size 317x39
+ RenderText {#text} at (194,1) size 16x19
+text run at (194,1) width 16: --
+ RenderInline {SPAN} at (0,0) size 317x39
+RenderText {#text} at (210,1) size 16x19
+ text
[webkit-changes] [88196] trunk/Source/WebCore
Title: [88196] trunk/Source/WebCore
Revision 88196
Author le...@chromium.org
Date 2011-06-06 15:27:19 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Levi Weintraub le...@chromium.org
Reviewed by Eric Seidel.
Switch InlineFlowBox::paintMask to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62156
Switching InlineFlowBox::paintMask to take an IntPoint representing the paint
offset instead of a pair of ints.
No new tests as this is simple refactoring.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
(WebCore::InlineFlowBox::paintMask):
* rendering/InlineFlowBox.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineFlowBox.cpp
trunk/Source/WebCore/rendering/InlineFlowBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (88195 => 88196)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 22:13:08 UTC (rev 88195)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 22:27:19 UTC (rev 88196)
@@ -1,3 +1,20 @@
+2011-06-06 Levi Weintraub le...@chromium.org
+
+Reviewed by Eric Seidel.
+
+Switch InlineFlowBox::paintMask to use IntPoint
+https://bugs.webkit.org/show_bug.cgi?id=62156
+
+Switching InlineFlowBox::paintMask to take an IntPoint representing the paint
+offset instead of a pair of ints.
+
+No new tests as this is simple refactoring.
+
+* rendering/InlineFlowBox.cpp:
+(WebCore::InlineFlowBox::paint):
+(WebCore::InlineFlowBox::paintMask):
+* rendering/InlineFlowBox.h:
+
2011-06-06 Emil A Eklund e...@chromium.org
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/rendering/InlineFlowBox.cpp (88195 => 88196)
--- trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2011-06-06 22:13:08 UTC (rev 88195)
+++ trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2011-06-06 22:27:19 UTC (rev 88196)
@@ -991,7 +991,7 @@
paintInfo.outlineObjects-add(inlineFlow);
}
} else if (paintInfo.phase == PaintPhaseMask) {
-paintMask(paintInfo, paintOffset.x(), paintOffset.y());
+paintMask(paintInfo, paintOffset);
return;
} else {
// Paint our background, border and box-shadow.
@@ -1163,7 +1163,7 @@
}
}
-void InlineFlowBox::paintMask(PaintInfo paintInfo, int tx, int ty)
+void InlineFlowBox::paintMask(PaintInfo paintInfo, const IntPoint paintOffset)
{
if (!paintInfo.shouldPaintWithinRoot(renderer()) || renderer()-style()-visibility() != VISIBLE || paintInfo.phase != PaintPhaseMask)
return;
@@ -1176,8 +1176,7 @@
// Move x/y to our coordinates.
IntRect localRect(frameRect);
flipForWritingMode(localRect);
-tx += localRect.x();
-ty += localRect.y();
+IntPoint adjustedPaintOffset = paintOffset + localRect.location();
const NinePieceImage maskNinePieceImage = renderer()-style()-maskBoxImage();
StyleImage* maskBoxImage = renderer()-style()-maskBoxImage().image();
@@ -1198,7 +1197,7 @@
}
}
-IntRect paintRect = IntRect(IntPoint(tx, ty), frameRect.size());
+IntRect paintRect = IntRect(adjustedPaintOffset, frameRect.size());
paintFillLayers(paintInfo, Color(), renderer()-style()-maskLayers(), paintRect, compositeOp);
bool hasBoxImage = maskBoxImage maskBoxImage-canRender(renderer()-style()-effectiveZoom());
@@ -1208,7 +1207,7 @@
// The simple case is where we are the only box for this object. In those
// cases only a single call to draw is required.
if (!prevLineBox() !nextLineBox()) {
-boxModelObject()-paintNinePieceImage(paintInfo.context, IntRect(IntPoint(tx, ty), frameRect.size()), renderer()-style(), maskNinePieceImage, compositeOp);
+boxModelObject()-paintNinePieceImage(paintInfo.context, IntRect(adjustedPaintOffset, frameRect.size()), renderer()-style(), maskNinePieceImage, compositeOp);
} else {
// We have a mask image that spans multiple lines.
// We need to adjust _tx and _ty by the width of all previous lines.
@@ -1218,8 +1217,8 @@
int totalLogicalWidth = logicalOffsetOnLine;
for (InlineFlowBox* curr = this; curr; curr = curr-nextLineBox())
totalLogicalWidth += curr-logicalWidth();
-int stripX = tx - (isHorizontal() ? logicalOffsetOnLine : 0);
-int stripY = ty - (isHorizontal() ? 0 : logicalOffsetOnLine);
+int stripX = adjustedPaintOffset.x() - (isHorizontal() ? logicalOffsetOnLine : 0);
+int stripY = adjustedPaintOffset.y() - (isHorizontal() ? 0 : logicalOffsetOnLine);
int stripWidth = isHorizontal() ? totalLogicalWidth : frameRect.width();
int stripHeight = isHorizontal() ? frameRect.height() : totalLogicalWidth;
Modified: trunk/Source/WebCore/rendering/InlineFlowBox.h (88195 => 88196)
--- trunk/Source/WebCore/rendering/InlineFlowBox.h 2011-06-06 22:13:08 UTC
[webkit-changes] [88198] trunk/Source/WebCore
Title: [88198] trunk/Source/WebCore
Revision 88198
Author e...@chromium.org
Date 2011-06-06 16:01:25 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Emil A Eklund e...@chromium.org
Reviewed by Eric Seidel.
Convert RenderBox::pushContentsClip to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62133
Covered by existing tests.
* rendering/RenderBlock.cpp:
(WebCore::Covered by existing tests.RenderBlock::paint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pushContentsClip):
* rendering/RenderBox.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/RenderTableSection.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (88197 => 88198)
--- trunk/Source/WebCore/ChangeLog 2011-06-06 22:28:33 UTC (rev 88197)
+++ trunk/Source/WebCore/ChangeLog 2011-06-06 23:01:25 UTC (rev 88198)
@@ -1,3 +1,22 @@
+2011-06-06 Emil A Eklund e...@chromium.org
+
+Reviewed by Eric Seidel.
+
+Convert RenderBox::pushContentsClip to IntPoint
+https://bugs.webkit.org/show_bug.cgi?id=62133
+
+Covered by existing tests.
+
+* rendering/RenderBlock.cpp:
+(WebCore::Covered by existing tests.RenderBlock::paint):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::pushContentsClip):
+* rendering/RenderBox.h:
+* rendering/RenderTable.cpp:
+(WebCore::RenderTable::paint):
+* rendering/RenderTableSection.cpp:
+(WebCore::RenderTableSection::paint):
+
2011-06-06 Levi Weintraub le...@chromium.org
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (88197 => 88198)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-06-06 22:28:33 UTC (rev 88197)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-06-06 23:01:25 UTC (rev 88198)
@@ -2257,7 +2257,7 @@
return;
}
-bool pushedClip = pushContentsClip(paintInfo, tx, ty);
+bool pushedClip = pushContentsClip(paintInfo, IntPoint(tx, ty));
paintObject(paintInfo, IntPoint(tx, ty));
if (pushedClip)
popContentsClip(paintInfo, phase, IntPoint(tx, ty));
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (88197 => 88198)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2011-06-06 22:28:33 UTC (rev 88197)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2011-06-06 23:01:25 UTC (rev 88198)
@@ -1096,7 +1096,7 @@
#endif
-bool RenderBox::pushContentsClip(PaintInfo paintInfo, int tx, int ty)
+bool RenderBox::pushContentsClip(PaintInfo paintInfo, const IntPoint accumulatedOffset)
{
if (paintInfo.phase == PaintPhaseBlockBackground || paintInfo.phase == PaintPhaseSelfOutline || paintInfo.phase == PaintPhaseMask)
return false;
@@ -,13 +,13 @@
paintInfo.phase = PaintPhaseChildOutlines;
else if (paintInfo.phase == PaintPhaseChildBlockBackground) {
paintInfo.phase = PaintPhaseBlockBackground;
-paintObject(paintInfo, IntPoint(tx, ty));
+paintObject(paintInfo, accumulatedOffset);
paintInfo.phase = PaintPhaseChildBlockBackgrounds;
}
-IntRect clipRect(isControlClip ? controlClipRect(IntPoint(tx, ty)) : overflowClipRect(IntPoint(tx, ty)));
+IntRect clipRect(isControlClip ? controlClipRect(accumulatedOffset) : overflowClipRect(accumulatedOffset));
paintInfo.context-save();
if (style()-hasBorderRadius())
-paintInfo.context-addRoundedRectClip(style()-getRoundedBorderFor(IntRect(tx, ty, width(), height(;
+paintInfo.context-addRoundedRectClip(style()-getRoundedBorderFor(IntRect(accumulatedOffset, size(;
paintInfo.context-clip(clipRect);
return true;
}
Modified: trunk/Source/WebCore/rendering/RenderBox.h (88197 => 88198)
--- trunk/Source/WebCore/rendering/RenderBox.h 2011-06-06 22:28:33 UTC (rev 88197)
+++ trunk/Source/WebCore/rendering/RenderBox.h 2011-06-06 23:01:25 UTC (rev 88198)
@@ -349,7 +349,7 @@
IntRect clipRect(const IntPoint location);
virtual bool hasControlClip() const { return false; }
virtual IntRect controlClipRect(const IntPoint) const { return IntRect(); }
-bool pushContentsClip(PaintInfo, int tx, int ty);
+bool pushContentsClip(PaintInfo, const IntPoint accumulatedOffset);
void popContentsClip(PaintInfo, PaintPhase originalPhase, const IntPoint accumulatedOffset);
virtual void paintObject(PaintInfo, const IntPoint) { ASSERT_NOT_REACHED(); }
Modified: trunk/Source/WebCore/rendering/RenderTable.cpp (88197 => 88198)
--- trunk/Source/WebCore/rendering/RenderTable.cpp 2011-06-06 22:28:33
[webkit-changes] [88203] trunk/Source/WebKit/chromium
Title: [88203] trunk/Source/WebKit/chromium Revision 88203 Author tha...@chromium.org Date 2011-06-06 17:03:16 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Nico Weber tha...@chromium.org Reviewed by James Robinson. [chromium] Make WebViewImpl's destructor virtual https://bugs.webkit.org/show_bug.cgi?id=62155 This is _not_ to fix a real bug, just to make clang's -Wdelete-non-virtual-dtor happy. As discussed at http://codereview.chromium.org/7094005/, we prefer making leaf class destructors virtual over making the leaf classes final. * src/WebViewImpl.h: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebViewImpl.h Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (88202 => 88203) --- trunk/Source/WebKit/chromium/ChangeLog 2011-06-06 23:45:22 UTC (rev 88202) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-07 00:03:16 UTC (rev 88203) @@ -1,3 +1,17 @@ +2011-06-06 Nico Weber tha...@chromium.org + +Reviewed by James Robinson. + +[chromium] Make WebViewImpl's destructor virtual +https://bugs.webkit.org/show_bug.cgi?id=62155 + +This is _not_ to fix a real bug, just to make clang's +-Wdelete-non-virtual-dtor happy. As discussed at +http://codereview.chromium.org/7094005/, we prefer making leaf class +destructors virtual over making the leaf classes final. + +* src/WebViewImpl.h: + 2011-06-06 Daniel Cheng dch...@chromium.org Reviewed by Tony Chang. Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (88202 => 88203) --- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-06-06 23:45:22 UTC (rev 88202) +++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-06-07 00:03:16 UTC (rev 88203) @@ -382,7 +382,7 @@ }; WebViewImpl(WebViewClient*); -~WebViewImpl(); +virtual ~WebViewImpl(); // Returns true if the event was actually processed. bool keyEventDefault(const WebKeyboardEvent); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88204] trunk/Source/WebKit2
Title: [88204] trunk/Source/WebKit2
Revision 88204
Author sulli...@apple.com
Date 2011-06-06 17:07:10 -0700 (Mon, 06 Jun 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=62165
rdar://problem/9555835
WebKit2 find-on-page callback doesn’t handle kWKMoreThanMaximumMatchCount on PDF pages
Reviewed by Dan Bernstein.
* UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewController::findString):
Return kWKMoreThanMaximumMatchCount when appropriate, a la FindController::countStringMatches().
Also, skip counting all the matches if maxMatchCount is 0, to avoid (perhaps slowly) computing a
number that would be ignored.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/PDFViewController.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (88203 => 88204)
--- trunk/Source/WebKit2/ChangeLog 2011-06-07 00:03:16 UTC (rev 88203)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-07 00:07:10 UTC (rev 88204)
@@ -1,3 +1,17 @@
+2011-06-06 John Sullivan sulli...@apple.com
+
+Reviewed by Dan Bernstein.
+
+https://bugs.webkit.org/show_bug.cgi?id=62165
+rdar://problem/9555835
+WebKit2 find-on-page callback doesn’t handle kWKMoreThanMaximumMatchCount on PDF pages
+
+* UIProcess/API/mac/PDFViewController.mm:
+(WebKit::PDFViewController::findString):
+Return kWKMoreThanMaximumMatchCount when appropriate, a la FindController::countStringMatches().
+Also, skip counting all the matches if maxMatchCount is 0, to avoid (perhaps slowly) computing a
+number that would be ignored.
+
2011-06-06 Carlos Garcia Campos cgar...@igalia.com
Reviewed by Anders Carlsson.
Modified: trunk/Source/WebKit2/UIProcess/API/mac/PDFViewController.mm (88203 => 88204)
--- trunk/Source/WebKit2/UIProcess/API/mac/PDFViewController.mm 2011-06-07 00:03:16 UTC (rev 88203)
+++ trunk/Source/WebKit2/UIProcess/API/mac/PDFViewController.mm 2011-06-07 00:07:10 UTC (rev 88204)
@@ -609,15 +609,21 @@
BOOL wrapFlag = options FindOptionsWrapAround;
PDFSelection *selection = [m_wkPDFView.get() _nextMatchFor:string direction:forward caseSensitive:caseFlag wrap:wrapFlag fromSelection:[m_pdfView currentSelection] startInSelection:NO];
-NSUInteger matchCount = [m_wkPDFView.get() _countMatches:string caseSensitive:caseFlag];
-if (matchCount maxMatchCount)
-matchCount = maxMatchCount;
-
if (!selection) {
page()-didFailToFindString(string);
return;
}
+NSUInteger matchCount;
+if (!maxMatchCount) {
+// If the max was zero, any result means we exceeded the max. We can skip computing the actual count.
+matchCount = static_castunsigned(kWKMoreThanMaximumMatchCount);
+} else {
+matchCount = [m_wkPDFView.get() _countMatches:string caseSensitive:caseFlag];
+if (matchCount maxMatchCount)
+matchCount = static_castunsigned(kWKMoreThanMaximumMatchCount);
+}
+
[m_pdfView setCurrentSelection:selection];
[m_pdfView scrollSelectionToVisible:nil];
page()-didFindString(string, matchCount);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88206] trunk/LayoutTests
Title: [88206] trunk/LayoutTests Revision 88206 Author k...@chromium.org Date 2011-06-06 17:56:07 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 James Kozianski k...@chromium.org [Chromium] Unreviewed, update test_expectations.txt. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (88205 => 88206) --- trunk/LayoutTests/ChangeLog 2011-06-07 00:53:16 UTC (rev 88205) +++ trunk/LayoutTests/ChangeLog 2011-06-07 00:56:07 UTC (rev 88206) @@ -1,3 +1,9 @@ +2011-06-06 James Kozianski k...@chromium.org + +[Chromium] Unreviewed, update test_expectations.txt. + +* platform/chromium/test_expectations.txt: + 2011-06-06 Qi Zhang qi.2.zh...@nokia.com Reviewed by Kenneth Rohde Christiansen. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88205 => 88206) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-07 00:53:16 UTC (rev 88205) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-07 00:56:07 UTC (rev 88206) @@ -2966,8 +2966,6 @@ BUGWK54322 SNOWLEOPARD : svg/custom/acid3-test-77.html = TIMEOUT PASS BUGWK54322 SNOWLEOPARD : transitions/transition-end-event-rendering.html = PASS TEXT -BUGCR72861 : fast/css/test-setting-canvas-color.html = TEXT - // Release definitely renders wrong; debug differences from reference may just // need rebaseline. BUGWK54499 LINUX : svg/transforms/text-with-pattern-with-svg-transform.svg = IMAGE @@ -3234,7 +3232,7 @@ BUGWK58193 WIN7 : fast/text/backslash-to-yen-sign-euc.html = IMAGE+TEXT BUGWK58193 WIN7 : fast/text/backslash-to-yen-sign.html = IMAGE+TEXT BUGWK58193 WIN7 : fast/text/international/bidi-mirror-he-ar.html = IMAGE+TEXT -BUGWK58193 : fast/text/international/hindi-whitespace.html = IMAGE+TEXT +BUGWK58193 LINUX WIN7 : fast/text/international/hindi-whitespace.html = IMAGE+TEXT BUGWK58193 WIN7 : fast/text/international/khmer-selection.html = IMAGE+TEXT BUGWK58193 WIN7 : fast/text/international/plane2.html = IMAGE+TEXT BUGWK58193 WIN7 : svg/W3C-I18N/g-dirLTR-ubNone.svg = IMAGE+TEXT @@ -3390,9 +3388,6 @@ // Regression caused by r83669. Seems to be V8 related. BUGCR79259 : fast/js/array-proto-func-property-getter-except.html = TEXT -// Need to be re-baselined BUGCR79770 -BUGCR79770 WIN : fast/box-shadow/inset-with-extraordinary-radii-and-border.html = IMAGE - // Need rebaselining @@ -3627,7 +3622,6 @@ BUGDPRANKE : fast/parser/_javascript_-url-compat-mode.html = TEXT PASS BUGCR80301 LEOPARD : fast/canvas/canvas-largedraws.html = TIMEOUT -BUGCR80301 WIN LINUX : fast/canvas/canvas-largedraws.html = CRASH // roll up from r84685:r84721?? BUGWK84665 : fast/dom/dataset-gc.html = TEXT @@ -3635,7 +3629,7 @@ BUGWK60115 WIN LINUX : fast/multicol/shadow-breaking.html = IMAGE BUGWK60115 WIN : fast/text/shadow-translucent-fill.html = IMAGE BUGWK60115 LEOPARD : fast/text/shadow-translucent-fill.html = IMAGE -BUGWK60115 WIN MAC : fast/transforms/shadows.html = IMAGE +BUGWK60115 MAC : fast/transforms/shadows.html = IMAGE PASS BUGWK60115 WIN : svg/css/group-with-shadow.svg = IMAGE BUGWK60115 WIN : transitions/svg-text-shadow-transition.html = IMAGE BUGWK60115 WIN : svg/css/composite-shadow-text.svg = IMAGE @@ -3727,7 +3721,7 @@ BUGWK60112 : fast/css/epub-properties.html = TEXT -BUGWK60136 WIN : http/tests/xmlviewer/dumpAsText/xmlviewer.xml = TEXT +BUGWK60136 WIN : http/tests/xmlviewer/dumpAsText/xmlviewer.xml = TEXT PASS // Flakiness on canaries (noted ~ r85280) BUGDPRANKE SNOWLEOPARD DEBUG : svg/dom/vkern-element-crash.html = CRASH PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88211] trunk
Title: [88211] trunk
Revision 88211
Author morr...@google.com
Date 2011-06-06 18:44:26 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 MORITA Hajime morr...@google.com
Reviewed by Kent Tamura.
Assertion fails in TextCheckingHelper by right-clicking on input type=search
https://bugs.webkit.org/show_bug.cgi?id=61991
* editing/spelling/spellcheck-input-search-crash-expected.txt: Added.
* editing/spelling/spellcheck-input-search-crash.html: Added.
2011-06-06 MORITA Hajime morr...@google.com
Reviewed by Kent Tamura.
Assertion fails in TextCheckingHelper by right-clicking on input type=search
https://bugs.webkit.org/show_bug.cgi?id=61991
Added a guard bofore TextCheckingHelper construction sites.
Test: editing/spelling/spellcheck-input-search-crash.html
* editing/Editor.cpp:
(WebCore::Editor::isSelectionUngrammatical):
(WebCore::Editor::guessesForUngrammaticalSelection):
(WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
Added Paths
trunk/LayoutTests/editing/spelling/spellcheck-input-search-crash-expected.txt
trunk/LayoutTests/editing/spelling/spellcheck-input-search-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (88210 => 88211)
--- trunk/LayoutTests/ChangeLog 2011-06-07 01:35:52 UTC (rev 88210)
+++ trunk/LayoutTests/ChangeLog 2011-06-07 01:44:26 UTC (rev 88211)
@@ -1,3 +1,13 @@
+2011-06-06 MORITA Hajime morr...@google.com
+
+Reviewed by Kent Tamura.
+
+Assertion fails in TextCheckingHelper by right-clicking on input type=search
+https://bugs.webkit.org/show_bug.cgi?id=61991
+
+* editing/spelling/spellcheck-input-search-crash-expected.txt: Added.
+* editing/spelling/spellcheck-input-search-crash.html: Added.
+
2011-06-06 James Kozianski k...@chromium.org
[Chromium] Unreviewed, update test_expectations.txt.
Added: trunk/LayoutTests/editing/spelling/spellcheck-input-search-crash-expected.txt (0 => 88211)
--- trunk/LayoutTests/editing/spelling/spellcheck-input-search-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/spelling/spellcheck-input-search-crash-expected.txt 2011-06-07 01:44:26 UTC (rev 88211)
@@ -0,0 +1,10 @@
+This test passes if it doesn't crash and the context menu is shown for the search input
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS clicked is true
+
Property changes on: trunk/LayoutTests/editing/spelling/spellcheck-input-search-crash-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/editing/spelling/spellcheck-input-search-crash.html (0 => 88211)
--- trunk/LayoutTests/editing/spelling/spellcheck-input-search-crash.html (rev 0)
+++ trunk/LayoutTests/editing/spelling/spellcheck-input-search-crash.html 2011-06-07 01:44:26 UTC (rev 88211)
@@ -0,0 +1,35 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script src=""
+script
+var clicked = false;
+
+function handleClicked()
+{
+clicked = true;
+}
+
+function test()
+{
+description(This test passes if it doesn't crash and the context menu is shown for the search input);
+if (!window.eventSender)
+return;
+var target = document.getElementById(target);
+var clickX = target.offsetLeft + target.offsetWidth - 2;
+var clickY = target.offsetTop + target.offsetHeight / 2;
+eventSender.mouseMoveTo(clickX, clickY);
+eventSender.contextClick();
+shouldBe(clicked, true);
+}
+var successfullyParsed = true;
+/script
+/head
+body _onload_=test();
+p id=description/p
+div id=console/div
+input id=target type=search _oncontextmenu_=handleClicked()
+script src=""
+/body
+/html
Property changes on: trunk/LayoutTests/editing/spelling/spellcheck-input-search-crash.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (88210 => 88211)
--- trunk/Source/WebCore/ChangeLog 2011-06-07 01:35:52 UTC (rev 88210)
+++ trunk/Source/WebCore/ChangeLog 2011-06-07 01:44:26 UTC (rev 88211)
@@ -1,3 +1,19 @@
+2011-06-06 MORITA Hajime morr...@google.com
+
+Reviewed by Kent Tamura.
+
+Assertion fails in TextCheckingHelper by right-clicking on input type=search
+https://bugs.webkit.org/show_bug.cgi?id=61991
+
+Added a guard bofore TextCheckingHelper construction sites.
+
+Test: editing/spelling/spellcheck-input-search-crash.html
+
+* editing/Editor.cpp:
+(WebCore::Editor::isSelectionUngrammatical):
+(WebCore::Editor::guessesForUngrammaticalSelection):
+
[webkit-changes] [88214] trunk
Title: [88214] trunk
Revision 88214
Author simon.fra...@apple.com
Date 2011-06-06 21:12:32 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 Simon Fraser simon.fra...@apple.com
Reviewed by Dan Bernstein.
Incorrect rounding of color values during transitions
https://bugs.webkit.org/show_bug.cgi?id=62141
When blending integers, round to the nearest integer, instead of always rounding down.
Test: transitions/color-transition-rounding.html
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/AnimationBase.cpp
Added Paths
trunk/LayoutTests/transitions/color-transition-rounding-expected.txt
trunk/LayoutTests/transitions/color-transition-rounding.html
Diff
Modified: trunk/LayoutTests/ChangeLog (88213 => 88214)
--- trunk/LayoutTests/ChangeLog 2011-06-07 04:06:51 UTC (rev 88213)
+++ trunk/LayoutTests/ChangeLog 2011-06-07 04:12:32 UTC (rev 88214)
@@ -1,3 +1,15 @@
+2011-06-06 Simon Fraser simon.fra...@apple.com
+
+Reviewed by Dan Bernstein.
+
+Incorrect rounding of color values during transitions
+https://bugs.webkit.org/show_bug.cgi?id=62141
+
+Test that interpolates colors, and checks the rounding.
+
+* transitions/color-transition-rounding-expected.txt: Added.
+* transitions/color-transition-rounding.html: Added.
+
2011-06-06 Noel Gordon noel.gor...@gmail.com
Reviewed by Hajime Morita.
Added: trunk/LayoutTests/transitions/color-transition-rounding-expected.txt (0 => 88214)
--- trunk/LayoutTests/transitions/color-transition-rounding-expected.txt (rev 0)
+++ trunk/LayoutTests/transitions/color-transition-rounding-expected.txt 2011-06-07 04:12:32 UTC (rev 88214)
@@ -0,0 +1,5 @@
+This test will probably fail when run manually; it requires the pause API for accurate results.
+PASS - color property for test element at 0.4998s saw something close to: 127,0,128
+PASS - color property for test element at 0.5s saw something close to: 128,0,128
+PASS - color property for test element at 0.5002s saw something close to: 128,0,127
+
Added: trunk/LayoutTests/transitions/color-transition-rounding.html (0 => 88214)
--- trunk/LayoutTests/transitions/color-transition-rounding.html (rev 0)
+++ trunk/LayoutTests/transitions/color-transition-rounding.html 2011-06-07 04:12:32 UTC (rev 88214)
@@ -0,0 +1,40 @@
+!DOCTYPE
+
+html
+head
+ style
+#test {
+ color: #00F;
+ -webkit-transition: color 1s linear;
+}
+
+#test.changed {
+ color: #F00;
+}
+ /style
+ script src=""
+ script type=text/_javascript_
+const expectedValues = [
+ // [time, element-id, property, expected-value, tolerance, post-completion callback, should-be-transitioning]
+ [0.4998, 'test', 'color', [127, 0, 128], 0],
+ [0.5000, 'test', 'color', [128, 0, 128], 0],
+ [0.5002, 'test', 'color', [128, 0, 127], 0],
+];
+
+function setupTest()
+{
+ document.getElementById('test').className = 'changed';
+}
+
+runTransitionTest(expectedValues, setupTest, usePauseAPI);
+ /script
+/head
+body
+
+ div id=test
+This test will probably fail when run manually; it requires the pause API for accurate results.
+ /div
+
+ div id=result/div
+/body
+/html
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (88213 => 88214)
--- trunk/Source/WebCore/ChangeLog 2011-06-07 04:06:51 UTC (rev 88213)
+++ trunk/Source/WebCore/ChangeLog 2011-06-07 04:12:32 UTC (rev 88214)
@@ -1,3 +1,17 @@
+2011-06-06 Simon Fraser simon.fra...@apple.com
+
+Reviewed by Dan Bernstein.
+
+Incorrect rounding of color values during transitions
+https://bugs.webkit.org/show_bug.cgi?id=62141
+
+When blending integers, round to the nearest integer, instead of always rounding down.
+
+Test: transitions/color-transition-rounding.html
+
+* page/animation/AnimationBase.cpp:
+(WebCore::blendFunc):
+
2011-06-06 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r88202.
Modified: trunk/Source/WebCore/page/animation/AnimationBase.cpp (88213 => 88214)
--- trunk/Source/WebCore/page/animation/AnimationBase.cpp 2011-06-07 04:06:51 UTC (rev 88213)
+++ trunk/Source/WebCore/page/animation/AnimationBase.cpp 2011-06-07 04:12:32 UTC (rev 88214)
@@ -79,7 +79,7 @@
static inline int blendFunc(const AnimationBase*, int from, int to, double progress)
{
-return int(from + (to - from) * progress);
+return lround(from + (to - from) * progress);
}
static inline double blendFunc(const AnimationBase*, double from, double to, double progress)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88215] trunk/Source/WebCore
Title: [88215] trunk/Source/WebCore
Revision 88215
Author noam.rosent...@nokia.com
Date 2011-06-06 21:42:45 -0700 (Mon, 06 Jun 2011)
Log Message
2011-06-06 No'am Rosenthal noam.rosent...@nokia.com
Reviewed by Simon Fraser.
Allow copying of KeyframeValueList.
https://bugs.webkit.org/show_bug.cgi?id=62171
Make a deep copy of KeyframeValueList, copying each of the keyframes with a virtual clone() function.
No new functionality so no new tests.
* platform/graphics/GraphicsLayer.h:
(WebCore::FloatAnimationValue::clone):
(WebCore::TransformAnimationValue::TransformAnimationValue):
(WebCore::TransformAnimationValue::clone):
(WebCore::TransformAnimationValue::value):
(WebCore::KeyframeValueList::KeyframeValueList):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (88214 => 88215)
--- trunk/Source/WebCore/ChangeLog 2011-06-07 04:12:32 UTC (rev 88214)
+++ trunk/Source/WebCore/ChangeLog 2011-06-07 04:42:45 UTC (rev 88215)
@@ -1,3 +1,21 @@
+2011-06-06 No'am Rosenthal noam.rosent...@nokia.com
+
+Reviewed by Simon Fraser.
+
+Allow copying of KeyframeValueList.
+https://bugs.webkit.org/show_bug.cgi?id=62171
+
+Make a deep copy of KeyframeValueList, copying each of the keyframes with a virtual clone() function.
+
+No new functionality so no new tests.
+
+* platform/graphics/GraphicsLayer.h:
+(WebCore::FloatAnimationValue::clone):
+(WebCore::TransformAnimationValue::TransformAnimationValue):
+(WebCore::TransformAnimationValue::clone):
+(WebCore::TransformAnimationValue::value):
+(WebCore::KeyframeValueList::KeyframeValueList):
+
2011-06-06 Simon Fraser simon.fra...@apple.com
Reviewed by Dan Bernstein.
Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.h (88214 => 88215)
--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.h 2011-06-07 04:12:32 UTC (rev 88214)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.h 2011-06-07 04:42:45 UTC (rev 88215)
@@ -90,7 +90,6 @@
// represent values for properties being animated via the GraphicsLayer,
// without pulling in style-related data from outside of the platform directory.
class AnimationValue {
-WTF_MAKE_NONCOPYABLE(AnimationValue); WTF_MAKE_FAST_ALLOCATED;
public:
AnimationValue(float keyTime, PassRefPtrTimingFunction timingFunction = 0)
: m_keyTime(keyTime)
@@ -103,6 +102,7 @@
float keyTime() const { return m_keyTime; }
const TimingFunction* timingFunction() const { return m_timingFunction.get(); }
+virtual AnimationValue* clone() const = 0;
private:
float m_keyTime;
@@ -117,6 +117,7 @@
, m_value(value)
{
}
+virtual AnimationValue* clone() const { return new FloatAnimationValue(*this); }
float value() const { return m_value; }
@@ -131,26 +132,33 @@
: AnimationValue(keyTime, timingFunction)
{
if (value)
-m_value = adoptPtr(new TransformOperations(*value));
+m_value = *value;
}
+virtual AnimationValue* clone() const { return new TransformAnimationValue(*this); }
-const TransformOperations* value() const { return m_value.get(); }
+const TransformOperations* value() const { return m_value; }
private:
-OwnPtrTransformOperations m_value;
+TransformOperations m_value;
};
// Used to store a series of values in a keyframe list. Values will all be of the same type,
// which can be inferred from the property.
class KeyframeValueList {
-WTF_MAKE_NONCOPYABLE(KeyframeValueList); WTF_MAKE_FAST_ALLOCATED;
public:
KeyframeValueList(AnimatedPropertyID property)
: m_property(property)
{
}
-
+
+KeyframeValueList(const KeyframeValueList other)
+: m_property(other.property())
+{
+for (size_t i = 0; i other.m_values.size(); ++i)
+m_values.append(other.m_values[i]-clone());
+}
+
~KeyframeValueList()
{
deleteAllValues(m_values);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [88216] trunk/Source/WebCore
Title: [88216] trunk/Source/WebCore
Revision 88216
Author tk...@chromium.org
Date 2011-06-06 21:52:14 -0700 (Mon, 06 Jun 2011)
Log Message
Unreviewed, a crash fix by a roll out.
REGRESSION(r87980): Null pointer dereference in RenderTextControl::setInnerText()
https://bugs.webkit.org/show_bug.cgi?id=62116
Roll out the WebCore part of r87980.
* html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::destroyShadowSubtree):
* html/SearchInputType.h:
(WebCore::SearchInputType::innerBlockElement):
(WebCore::SearchInputType::resultsButtonElement):
(WebCore::SearchInputType::cancelButtonElement):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::TextFieldInputType):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::destroyShadowSubtree):
* html/TextFieldInputType.h:
(WebCore::TextFieldInputType::innerTextElement):
(WebCore::TextFieldInputType::innerSpinButtonElement):
(WebCore::TextFieldInputType::speechButtonElement):
(WebCore::TextFieldInputType::setInnerTextElement):
(WebCore::TextFieldInputType::setSpeechButtonElement):
* html/shadow/TextControlInnerElements.cpp:
* html/shadow/TextControlInnerElements.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/SearchInputType.cpp
trunk/Source/WebCore/html/SearchInputType.h
trunk/Source/WebCore/html/TextFieldInputType.cpp
trunk/Source/WebCore/html/TextFieldInputType.h
trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp
trunk/Source/WebCore/html/shadow/TextControlInnerElements.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (88215 => 88216)
--- trunk/Source/WebCore/ChangeLog 2011-06-07 04:42:45 UTC (rev 88215)
+++ trunk/Source/WebCore/ChangeLog 2011-06-07 04:52:14 UTC (rev 88216)
@@ -1,3 +1,33 @@
+2011-06-06 Kent Tamura tk...@chromium.org
+
+Unreviewed, a crash fix by a roll out.
+
+REGRESSION(r87980): Null pointer dereference in RenderTextControl::setInnerText()
+https://bugs.webkit.org/show_bug.cgi?id=62116
+
+Roll out the WebCore part of r87980.
+
+* html/SearchInputType.cpp:
+(WebCore::SearchInputType::SearchInputType):
+(WebCore::SearchInputType::createShadowSubtree):
+(WebCore::SearchInputType::destroyShadowSubtree):
+* html/SearchInputType.h:
+(WebCore::SearchInputType::innerBlockElement):
+(WebCore::SearchInputType::resultsButtonElement):
+(WebCore::SearchInputType::cancelButtonElement):
+* html/TextFieldInputType.cpp:
+(WebCore::TextFieldInputType::TextFieldInputType):
+(WebCore::TextFieldInputType::createShadowSubtree):
+(WebCore::TextFieldInputType::destroyShadowSubtree):
+* html/TextFieldInputType.h:
+(WebCore::TextFieldInputType::innerTextElement):
+(WebCore::TextFieldInputType::innerSpinButtonElement):
+(WebCore::TextFieldInputType::speechButtonElement):
+(WebCore::TextFieldInputType::setInnerTextElement):
+(WebCore::TextFieldInputType::setSpeechButtonElement):
+* html/shadow/TextControlInnerElements.cpp:
+* html/shadow/TextControlInnerElements.h:
+
2011-06-06 No'am Rosenthal noam.rosent...@nokia.com
Reviewed by Simon Fraser.
Modified: trunk/Source/WebCore/html/SearchInputType.cpp (88215 => 88216)
--- trunk/Source/WebCore/html/SearchInputType.cpp 2011-06-07 04:42:45 UTC (rev 88215)
+++ trunk/Source/WebCore/html/SearchInputType.cpp 2011-06-07 04:52:14 UTC (rev 88216)
@@ -40,6 +40,9 @@
inline SearchInputType::SearchInputType(HTMLInputElement* element)
: BaseTextInputType(element)
+, m_innerBlock(0)
+, m_resultsButton(0)
+, m_cancelButton(0)
{
}
@@ -63,54 +66,47 @@
return true;
}
-static const AtomicString innerBlockId()
-{
-DEFINE_STATIC_LOCAL(AtomicString, id, (innerBlock));
-return id;
-}
-
-static const AtomicString resultButtonId()
-{
-DEFINE_STATIC_LOCAL(AtomicString, id, (resultButton));
-return id;
-}
-
-static const AtomicString cancelButtonId()
-{
-DEFINE_STATIC_LOCAL(AtomicString, id, (cancelButton));
-return id;
-}
-
void SearchInputType::createShadowSubtree()
{
+ASSERT(!m_innerBlock);
+ASSERT(!innerTextElement());
+ASSERT(!m_resultsButton);
+ASSERT(!m_cancelButton);
+
+ExceptionCode ec = 0;
Document* document = element()-document();
RefPtrHTMLElement inner = TextControlInnerElement::create(document);
-HTMLElement* innerBlock = inner.get();
-appendChildAndSetId(element()-ensureShadowRoot(), inner.release(), innerBlockId());
+m_innerBlock = inner.get();
+element()-ensureShadowRoot()-appendChild(inner.release(), ec);
#if ENABLE(INPUT_SPEECH)
-if (element()-isSpeechEnabled())
-appendChildAndSetId(element()-ensureShadowRoot(), InputFieldSpeechButtonElement::create(document), speechButtonId());
+if (element()-isSpeechEnabled()) {
+
