[webkit-changes] [89540] trunk/LayoutTests
Title: [89540] trunk/LayoutTests
Revision 89540
Author pfeld...@chromium.org
Date 2011-06-22 23:58:29 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Pavel Feldman
Not reviewed: rebaseline chromium expectation.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Added Paths
trunk/LayoutTests/platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (89539 => 89540)
--- trunk/LayoutTests/ChangeLog 2011-06-23 06:46:56 UTC (rev 89539)
+++ trunk/LayoutTests/ChangeLog 2011-06-23 06:58:29 UTC (rev 89540)
@@ -1,3 +1,12 @@
+2011-06-22 Pavel Feldman
+
+Not reviewed: rebaseline chromium expectation.
+
+* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
+* platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
+* platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
2011-06-22 Dirk Schulze
Reviewed by Rob Buis.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (89539 => 89540)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-23 06:46:56 UTC (rev 89539)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-23 06:58:29 UTC (rev 89540)
@@ -3980,6 +3980,3 @@
BUGCR87070 WIN DEBUG : http/tests/security/_javascript_URL/xss-DENIED-to-_javascript_-url-in-foreign-domain-subframe.html = CRASH PASS
BUGCR87217 WIN LINUX GPU : compositing/layer-creation/spanOverlapsCanvas.html = TEXT
-
-BUGPFELDMAN WIN : svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg = IMAGE+TEXT
-BUGPFELDMAN MAC : svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg = IMAGE
Added: trunk/LayoutTests/platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt (0 => 89540)
--- trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt 2011-06-23 06:58:29 UTC (rev 89540)
@@ -0,0 +1,20 @@
+layer at (0,0) size 480x360
+ RenderView at (0,0) size 480x360
+layer at (0,0) size 480x360
+ RenderSVGRoot {svg} at (0,0) size 480x360
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGContainer {g} at (10,28) size 298x125
+ RenderSVGText {text} at (10,28) size 298x15 contains 1 chunk(s)
+RenderSVGInlineText {#text} at (0,0) size 298x15
+ chunk 1 text run 1 at (10.00,40.00) startOffset 0 endOffset 56 width 298.00: "Test pointer-events=\"painted\" with paint server fallback"
+ RenderSVGPath {rect} at (10,80) size 50x50 [fill={[type=SOLID] [color=#00]}] [x=10.00] [y=80.00] [width=50.00] [height=50.00]
+ RenderSVGPath {rect} at (10,80) size 50x50 [x=10.00] [y=80.00] [width=50.00] [height=50.00]
+ RenderSVGContainer {g} at (10,137) size 251x16
+RenderSVGText {text} at (10,137) size 251x16 contains 1 chunk(s)
+ RenderSVGInlineText {#text} at (0,0) size 251x16
+chunk 1 text run 1 at (10.00,150.00) startOffset 0 endOffset 44 width 251.00: "Move the pointing device over the rectangle."
+RenderSVGContainer {g} at (10,311) size 228x36
+ RenderSVGText {text} at (10,311) size 228x36 contains 1 chunk(s)
+RenderSVGInlineText {#text} at (0,0) size 228x36
+ chunk 1 text run 1 at (10.00,340.00) startOffset 0 endOffset 16 width 228.00: "$Revision: 1.4 $"
+RenderSVGPath {rect} at (0,0) size 480x360 [stroke={[type=SOLID] [color=#00]}] [x=1.00] [y=1.00] [width=478.00] [height=358.00]
Property changes on: trunk/Lay
[webkit-changes] [89539] trunk/Source/WebKit2
Title: [89539] trunk/Source/WebKit2
Revision 89539
Author carlo...@webkit.org
Date 2011-06-22 23:46:56 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Carlos Garcia Campos
Reviewed by Martin Robinson.
[UNIX] Increment/decrement module load conter in NetscapePluginModule::getPluginInfo()
https://bugs.webkit.org/show_bug.cgi?id=63150
Since the method is static, we are using
NetscapePluginModule::getOrCreate() to get the module. If it's
created, the load counter is 0, so that when module is deleted,
shutdown() hasn't been called and the destructor crashes in the
assert that checks the module has been removed from the
initialized module list. We should increment the load counter, and
decrement it before getPluginInfo() returns, so that
decrementLoadCount() will call shutdown() if counter is 0 and the
module will be deleted from the list.
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::NetscapePluginModule::getPluginInfo):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (89538 => 89539)
--- trunk/Source/WebKit2/ChangeLog 2011-06-23 06:46:55 UTC (rev 89538)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-23 06:46:56 UTC (rev 89539)
@@ -2,6 +2,26 @@
Reviewed by Martin Robinson.
+[UNIX] Increment/decrement module load conter in NetscapePluginModule::getPluginInfo()
+https://bugs.webkit.org/show_bug.cgi?id=63150
+
+Since the method is static, we are using
+NetscapePluginModule::getOrCreate() to get the module. If it's
+created, the load counter is 0, so that when module is deleted,
+shutdown() hasn't been called and the destructor crashes in the
+assert that checks the module has been removed from the
+initialized module list. We should increment the load counter, and
+decrement it before getPluginInfo() returns, so that
+decrementLoadCount() will call shutdown() if counter is 0 and the
+module will be deleted from the list.
+
+* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
+(WebKit::NetscapePluginModule::getPluginInfo):
+
+2011-06-22 Carlos Garcia Campos
+
+Reviewed by Martin Robinson.
+
[UNIX] Check for npp directly when getting X display in NetscapeBrowserFuncs
https://bugs.webkit.org/show_bug.cgi?id=63149
Modified: trunk/Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp (89538 => 89539)
--- trunk/Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp 2011-06-23 06:46:55 UTC (rev 89538)
+++ trunk/Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp 2011-06-23 06:46:56 UTC (rev 89539)
@@ -130,17 +130,23 @@
if (!pluginModule)
return false;
+pluginModule->incrementLoadCount();
+
plugin.path = pluginPath;
plugin.info.file = pathGetFileName(pluginPath);
Module* module = pluginModule->module();
NPP_GetValueProcPtr NPP_GetValue = module->functionPointer("NP_GetValue");
-if (!NPP_GetValue)
+if (!NPP_GetValue) {
+pluginModule->decrementLoadCount();
return false;
+}
NP_GetMIMEDescriptionFuncPtr NP_GetMIMEDescription = module->functionPointer("NP_GetMIMEDescription");
-if (!NP_GetMIMEDescription)
+if (!NP_GetMIMEDescription) {
+pluginModule->decrementLoadCount();
return false;
+}
char* buffer = 0;
NPError err = NPP_GetValue(0, NPPVpluginDescriptionString, &buffer);
@@ -148,11 +154,15 @@
plugin.info.desc = buffer;
const char* mimeDescription = NP_GetMIMEDescription();
-if (!mimeDescription)
+if (!mimeDescription) {
+pluginModule->decrementLoadCount();
return false;
+}
setMIMEDescription(mimeDescription, plugin);
+pluginModule->decrementLoadCount();
+
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89538] trunk/LayoutTests
Title: [89538] trunk/LayoutTests Revision 89538 Author pfeld...@chromium.org Date 2011-06-22 23:46:55 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Pavel Feldman Not reviewed: chromium expectations update. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (89537 => 89538) --- trunk/LayoutTests/ChangeLog 2011-06-23 06:44:36 UTC (rev 89537) +++ trunk/LayoutTests/ChangeLog 2011-06-23 06:46:55 UTC (rev 89538) @@ -32,6 +32,12 @@ * platform/chromium/test_expectations.txt: +2011-06-22 Pavel Feldman + +Not reviewed: chromium expectations update. + +* platform/chromium/test_expectations.txt: + 2011-06-22 Dominic Cooney Reviewed by Mark Rowe. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (89537 => 89538) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-23 06:44:36 UTC (rev 89537) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-23 06:46:55 UTC (rev 89538) @@ -3981,4 +3981,5 @@ BUGCR87217 WIN LINUX GPU : compositing/layer-creation/spanOverlapsCanvas.html = TEXT -BUGPFELDMAN WIN MAC : svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg = IMAGE +BUGPFELDMAN WIN : svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg = IMAGE+TEXT +BUGPFELDMAN MAC : svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89537] trunk/Source/WebKit2
Title: [89537] trunk/Source/WebKit2
Revision 89537
Author carlo...@webkit.org
Date 2011-06-22 23:44:36 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Carlos Garcia Campos
Reviewed by Martin Robinson.
[UNIX] Check for npp directly when getting X display in NetscapeBrowserFuncs
https://bugs.webkit.org/show_bug.cgi?id=63149
NetscapePlugin::fromNPP() shouldn't be called with a null npp, it
contains an assert that make it crash when building with debug enabled.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (89536 => 89537)
--- trunk/Source/WebKit2/ChangeLog 2011-06-23 06:31:46 UTC (rev 89536)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-23 06:44:36 UTC (rev 89537)
@@ -1,3 +1,16 @@
+2011-06-22 Carlos Garcia Campos
+
+Reviewed by Martin Robinson.
+
+[UNIX] Check for npp directly when getting X display in NetscapeBrowserFuncs
+https://bugs.webkit.org/show_bug.cgi?id=63149
+
+NetscapePlugin::fromNPP() shouldn't be called with a null npp, it
+contains an assert that make it crash when building with debug enabled.
+
+* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
+(WebKit::NPN_GetValue):
+
2011-06-22 Nate Chapin
Reviewed by Adam Barth.
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp (89536 => 89537)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp 2011-06-23 06:31:46 UTC (rev 89536)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp 2011-06-23 06:44:36 UTC (rev 89537)
@@ -504,8 +504,7 @@
break;
#elif PLUGIN_ARCHITECTURE(X11)
case NPNVxDisplay: {
- RefPtr plugin = NetscapePlugin::fromNPP(npp);
- if (!plugin)
+ if (!npp)
return NPERR_GENERIC_ERROR;
#if PLATFORM(QT)
*reinterpret_cast(value) = QX11Info::display();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89535] trunk/Source/WebCore
Title: [89535] trunk/Source/WebCore Revision 89535 Author dglaz...@chromium.org Date 2011-06-22 23:04:50 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Dimitri Glazkov Reviewed by Kent Tamura. Move file-choosing and icon-loading management to FileInputType https://bugs.webkit.org/show_bug.cgi?id=62069 1) Moved the duties of FileChooserClient and FileIconLoaderClient from RenderFileUploadControl to FileInputType, along with all of the supporting functions. 2) Moved Icon ownership to FileInputType and exposed accessor on HTMInputElement to allow RenderFileUploadControl to query current icon. As a result, RenderFileUploadControl is now completely stateless, which is neat and clean. Refactoring, covered by existing tests. * html/FileInputType.cpp: (WebCore::FileInputType::handleDOMActivateEvent): Moved logic here from RenderFileUploadControl. (WebCore::FileInputType::requestIcon): Ditto. (WebCore::FileInputType::filesChosen): Ditto. (WebCore::FileInputType::receiveDropForDirectoryUpload): Ditto. (WebCore::FileInputType::updateRendering): Ditto. (WebCore::FileInputType::chrome): Ditto. (WebCore::FileInputType::receiveDroppedFiles): Ditto. (WebCore::FileInputType::icon): Added. * html/FileInputType.h: * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer): Updated comment. (WebCore::HTMLInputElement::receiveDroppedFiles): Added to replace setFileListFromRenderer. (WebCore::HTMLInputElement::icon): Added. * html/HTMLInputElement.h: * html/InputType.cpp: (WebCore::InputType::receiveDroppedFiles): Added. (WebCore::InputType::icon): Added. * html/InputType.h: * page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Changed to use HTMLInputElement. Ahh, nice and clean! * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): Removed code that is no longer necessary. (WebCore::RenderFileUploadControl::updateFromElement): Ditto. (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use HTMLInputElement icon accessor. (WebCore::RenderFileUploadControl::paintObject): Ditto. * rendering/RenderFileUploadControl.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/FileInputType.cpp trunk/Source/WebCore/html/FileInputType.h trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLInputElement.h trunk/Source/WebCore/html/InputType.cpp trunk/Source/WebCore/html/InputType.h trunk/Source/WebCore/page/DragController.cpp trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp trunk/Source/WebCore/rendering/RenderFileUploadControl.h Diff Modified: trunk/Source/WebCore/ChangeLog (89534 => 89535) --- trunk/Source/WebCore/ChangeLog 2011-06-23 06:00:22 UTC (rev 89534) +++ trunk/Source/WebCore/ChangeLog 2011-06-23 06:04:50 UTC (rev 89535) @@ -1,3 +1,50 @@ +2011-06-22 Dimitri Glazkov + +Reviewed by Kent Tamura. + +Move file-choosing and icon-loading management to FileInputType +https://bugs.webkit.org/show_bug.cgi?id=62069 + +1) Moved the duties of FileChooserClient and FileIconLoaderClient from +RenderFileUploadControl to FileInputType, along with all of the +supporting functions. + +2) Moved Icon ownership to FileInputType and exposed accessor on +HTMInputElement to allow RenderFileUploadControl to query current icon. + +As a result, RenderFileUploadControl is now completely stateless, which is +neat and clean. + +Refactoring, covered by existing tests. + +* html/FileInputType.cpp: +(WebCore::FileInputType::handleDOMActivateEvent): Moved logic here from RenderFileUploadControl. +(WebCore::FileInputType::requestIcon): Ditto. +(WebCore::FileInputType::filesChosen): Ditto. +(WebCore::FileInputType::receiveDropForDirectoryUpload): Ditto. +(WebCore::FileInputType::updateRendering): Ditto. +(WebCore::FileInputType::chrome): Ditto. +(WebCore::FileInputType::receiveDroppedFiles): Ditto. +(WebCore::FileInputType::icon): Added. +* html/FileInputType.h: +* html/HTMLInputElement.cpp: +(WebCore::HTMLInputElement::setValueFromRenderer): Updated comment. +(WebCore::HTMLInputElement::receiveDroppedFiles): Added to replace setFileListFromRenderer. +(WebCore::HTMLInputElement::icon): Added. +* html/HTMLInputElement.h: +* html/InputType.cpp: +(WebCore::InputType::receiveDroppedFiles): Added. +(WebCore::InputType::icon): Added. +* html/InputType.h: +* page/DragController.cpp: +(WebCore::DragController::concludeEditDrag): Changed to use H
[webkit-changes] [89534] trunk/Source/WebCore
Title: [89534] trunk/Source/WebCore
Revision 89534
Author psola...@apple.com
Date 2011-06-22 23:00:22 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Pratik Solanki
Reviewed by Darin Adler.
Add NSError wrapper functions in ResourceError when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=63155
Add wrapper functions to ResourceError when building with USE(CFNETWORK). We need to create
a new NSError in ResourceError::nsError() since Safari has category methods on NSError and
passing a CFErrorRef back does not work even though CFErrorRef/NSErrror are toll-free
bridged.
No tests because no change in functionality.
* WebCore.exp.in:
* platform/network/cf/ResourceError.h:
* platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::nsError):
(WebCore::ResourceError::operator NSError *):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/platform/network/cf/ResourceError.h
trunk/Source/WebCore/platform/network/mac/ResourceErrorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (89533 => 89534)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 05:59:29 UTC (rev 89533)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 06:00:22 UTC (rev 89534)
@@ -1,3 +1,24 @@
+2011-06-22 Pratik Solanki
+
+Reviewed by Darin Adler.
+
+Add NSError wrapper functions in ResourceError when USE(CFNETWORK) is enabled
+https://bugs.webkit.org/show_bug.cgi?id=63155
+
+Add wrapper functions to ResourceError when building with USE(CFNETWORK). We need to create
+a new NSError in ResourceError::nsError() since Safari has category methods on NSError and
+passing a CFErrorRef back does not work even though CFErrorRef/NSErrror are toll-free
+bridged.
+
+No tests because no change in functionality.
+
+* WebCore.exp.in:
+* platform/network/cf/ResourceError.h:
+* platform/network/mac/ResourceErrorMac.mm:
+(WebCore::ResourceError::ResourceError):
+(WebCore::ResourceError::nsError):
+(WebCore::ResourceError::operator NSError *):
+
2011-06-22 Dominic Cooney
Reviewed by Mark Rowe.
Modified: trunk/Source/WebCore/WebCore.exp.in (89533 => 89534)
--- trunk/Source/WebCore/WebCore.exp.in 2011-06-23 05:59:29 UTC (rev 89533)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-06-23 06:00:22 UTC (rev 89534)
@@ -1896,7 +1896,9 @@
#endif
#if USE(CFNETWORK)
+__ZNK7WebCore13ResourceErrorcvP9__CFErrorEv
__ZN7WebCore12SchedulePairC1EP11__CFRunLoopPK10__CFString
#else
+__ZNK7WebCore13ResourceErrorcvP7NSErrorEv
__ZN7WebCore12SchedulePairC1EP9NSRunLoopPK10__CFString
#endif
Modified: trunk/Source/WebCore/platform/network/cf/ResourceError.h (89533 => 89534)
--- trunk/Source/WebCore/platform/network/cf/ResourceError.h 2011-06-23 05:59:29 UTC (rev 89533)
+++ trunk/Source/WebCore/platform/network/cf/ResourceError.h 2011-06-23 06:00:22 UTC (rev 89534)
@@ -31,14 +31,13 @@
#include
#if USE(CFNETWORK)
#include
-#else
+#endif
#ifdef __OBJC__
@class NSError;
#else
class NSError;
#endif
-#endif
namespace WebCore {
@@ -68,7 +67,9 @@
ResourceError(CFStreamError error);
CFStreamError cfStreamError() const;
operator CFStreamError() const;
-#else
+#endif
+
+#if PLATFORM(MAC)
ResourceError(NSError *);
NSError *nsError() const;
operator NSError *() const;
@@ -84,6 +85,9 @@
bool m_dataIsUpToDate;
#if USE(CFNETWORK)
mutable RetainPtr m_platformError;
+#if PLATFORM(MAC)
+mutable RetainPtr m_platformNSError;
+#endif
#if PLATFORM(WIN)
RetainPtr m_certificate;
#endif
Modified: trunk/Source/WebCore/platform/network/mac/ResourceErrorMac.mm (89533 => 89534)
--- trunk/Source/WebCore/platform/network/mac/ResourceErrorMac.mm 2011-06-23 05:59:29 UTC (rev 89533)
+++ trunk/Source/WebCore/platform/network/mac/ResourceErrorMac.mm 2011-06-23 06:00:22 UTC (rev 89534)
@@ -37,6 +37,36 @@
namespace WebCore {
+#if USE(CFNETWORK)
+
+ResourceError::ResourceError(NSError *error)
+: m_dataIsUpToDate(false)
+, m_platformError(reinterpret_cast(error))
+{
+m_isNull = !error;
+}
+
+NSError *ResourceError::nsError() const
+{
+if (m_isNull) {
+ASSERT(!m_platformError);
+return nil;
+}
+if (!m_platformNSError) {
+CFErrorRef error = m_platformError.get();
+RetainPtr userInfo(AdoptCF, (NSDictionary *) CFErrorCopyUserInfo(error));
+m_platformNSError.adoptNS([[NSError alloc] initWithDomain:(NSString *)CFErrorGetDomain(error) code:CFErrorGetCode(error) userInfo:userInfo.get()]);
+}
+return m_platformNSError.get();
+}
+
+ResourceError::operator NSError *() const
+{
+return nsError();
+}
+
+#else
+
ResourceError::ResourceError(NSError *nsError)
: m_dataIsUpToDate(false)
, m_platformError(n
[webkit-changes] [89533] trunk/LayoutTests
Title: [89533] trunk/LayoutTests Revision 89533 Author pfeld...@chromium.org Date 2011-06-22 22:59:29 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Pavel Feldman Not reviewed: chromium expectations update. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (89532 => 89533) --- trunk/LayoutTests/ChangeLog 2011-06-23 05:33:04 UTC (rev 89532) +++ trunk/LayoutTests/ChangeLog 2011-06-23 05:59:29 UTC (rev 89533) @@ -1,3 +1,9 @@ +2011-06-22 Pavel Feldman + +Not reviewed: chromium expectations update. + +* platform/chromium/test_expectations.txt: + 2011-06-22 Dominic Cooney Reviewed by Mark Rowe. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (89532 => 89533) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-23 05:33:04 UTC (rev 89532) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-23 05:59:29 UTC (rev 89533) @@ -2757,7 +2757,9 @@ BUGCR69571 : plugins/destroy-on-setwindow.html = CRASH TEXT // Failing after r75768 -BUGCR69639 : http/tests/loading/cross-origin-XHR-willLoadRequest.html = TEXT +// BUGCR69639 : http/tests/loading/cross-origin-XHR-willLoadRequest.html = TEXT +// Times out after r89503 +BUGWK63227 : http/tests/loading/cross-origin-XHR-willLoadRequest.html = TEXT TIMEOUT // Behavior changed in http://trac.webkit.org/changeset/76180, // need to investigate @@ -3976,3 +3978,7 @@ BUGCR87070 : fast/js/parser-xml-close-comment.html = TEXT // Sounds like a real regression. BUGCR87070 WIN DEBUG : http/tests/security/_javascript_URL/xss-DENIED-to-_javascript_-url-in-foreign-domain-subframe.html = CRASH PASS + +BUGCR87217 WIN LINUX GPU : compositing/layer-creation/spanOverlapsCanvas.html = TEXT + +BUGPFELDMAN WIN MAC : svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89532] trunk/Tools
Title: [89532] trunk/Tools Revision 89532 Author dba...@webkit.org Date 2011-06-22 22:33:04 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Daniel Bates Reviewed by Adam Barth. test-webkitpy --all errors out because scm_unittest.py can't find module checkout https://bugs.webkit.org/show_bug.cgi?id=62943 Remove "from .checkout import Checkout" from scm_unittest.py since it's included by Scripts/webkitpy/common/checkout/__init__.py. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py Diff Modified: trunk/Tools/ChangeLog (89531 => 89532) --- trunk/Tools/ChangeLog 2011-06-23 05:25:30 UTC (rev 89531) +++ trunk/Tools/ChangeLog 2011-06-23 05:33:04 UTC (rev 89532) @@ -1,3 +1,15 @@ +2011-06-22 Daniel Bates + +Reviewed by Adam Barth. + +test-webkitpy --all errors out because scm_unittest.py can't find module checkout +https://bugs.webkit.org/show_bug.cgi?id=62943 + +Remove "from .checkout import Checkout" from scm_unittest.py since it's included +by Scripts/webkitpy/common/checkout/__init__.py. + +* Scripts/webkitpy/common/checkout/scm/scm_unittest.py: + 2011-06-22 Dominic Cooney Reviewed by Mark Rowe. Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py (89531 => 89532) --- trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py 2011-06-23 05:25:30 UTC (rev 89531) +++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py 2011-06-23 05:33:04 UTC (rev 89532) @@ -45,7 +45,6 @@ import shutil from datetime import date -from .checkout import Checkout from webkitpy.common.config.committers import Committer # FIXME: This should not be needed from webkitpy.common.net.bugzilla import Attachment # FIXME: This should not be needed from webkitpy.common.system.executive import Executive, run_command, ScriptError ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89531] tags/Safari-534.49/
Title: [89531] tags/Safari-534.49/ Revision 89531 Author lforsch...@apple.com Date 2011-06-22 22:25:30 -0700 (Wed, 22 Jun 2011) Log Message New tag. Added Paths tags/Safari-534.49/ Diff Property changes: tags/Safari-534.49 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89530] trunk
Title: [89530] trunk Revision 89530 Author domin...@chromium.org Date 2011-06-22 22:09:24 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Dominic Cooney Reviewed by Mark Rowe. Add window.internals to WebKit2's WebKitTestRunner. https://bugs.webkit.org/show_bug.cgi?id=61073 * platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html 2011-06-22 Dominic Cooney Reviewed by Mark Rowe. Add window.internals to WebKit2's WebKitTestRunner. https://bugs.webkit.org/show_bug.cgi?id=61073 * Configurations/WebCoreTestSupport.xcconfig: * WebCore.xcodeproj/project.pbxproj: 2011-06-22 Dominic Cooney Reviewed by Mark Rowe. Add window.internals to WebKit2's WebKitTestRunner. https://bugs.webkit.org/show_bug.cgi?id=61073 * WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport 2011-06-22 Dominic Cooney Reviewed by Mark Rowe. Add window.internals to WebKit2's WebKitTestRunner. https://bugs.webkit.org/show_bug.cgi?id=61073 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/Skipped trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebKit.vcproj/WebKit.sln trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig trunk/Tools/WebKitTestRunner/Configurations/InjectedBundle.xcconfig trunk/Tools/WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops trunk/Tools/WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops trunk/Tools/WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj Diff Modified: trunk/LayoutTests/ChangeLog (89529 => 89530) --- trunk/LayoutTests/ChangeLog 2011-06-23 04:54:18 UTC (rev 89529) +++ trunk/LayoutTests/ChangeLog 2011-06-23 05:09:24 UTC (rev 89530) @@ -1,3 +1,12 @@ +2011-06-22 Dominic Cooney + +Reviewed by Mark Rowe. + +Add window.internals to WebKit2's WebKitTestRunner. +https://bugs.webkit.org/show_bug.cgi?id=61073 + +* platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html + 2011-06-22 Sam Weinig Reviewed by Adam Barth. Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (89529 => 89530) --- trunk/LayoutTests/platform/mac-wk2/Skipped 2011-06-23 04:54:18 UTC (rev 89529) +++ trunk/LayoutTests/platform/mac-wk2/Skipped 2011-06-23 05:09:24 UTC (rev 89530) @@ -1555,9 +1555,6 @@ # http://webkit.org/b/58990 editing/undo/undo-iframe-location-change.html -# https://bugs.webkit.org/show_bug.cgi?id=61073 -fast/harness/internals-object.html - ### END OF (1) Classified failures with bug reports Modified: trunk/Source/WebCore/ChangeLog (89529 => 89530) --- trunk/Source/WebCore/ChangeLog 2011-06-23 04:54:18 UTC (rev 89529) +++ trunk/Source/WebCore/ChangeLog 2011-06-23 05:09:24 UTC (rev 89530) @@ -1,3 +1,13 @@ +2011-06-22 Dominic Cooney + +Reviewed by Mark Rowe. + +Add window.internals to WebKit2's WebKitTestRunner. +https://bugs.webkit.org/show_bug.cgi?id=61073 + +* Configurations/WebCoreTestSupport.xcconfig: +* WebCore.xcodeproj/project.pbxproj: + 2011-06-22 Dimitri Glazkov Reviewed by Kent Tamura. Modified: trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig (89529 => 89530) --- trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig 2011-06-23 04:54:18 UTC (rev 89529) +++ trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig 2011-06-23 05:09:24 UTC (rev 89530) @@ -29,10 +29,12 @@ PRIVATE_HEADERS_FOLDER_PATH_Production = /usr/local/include/WebCoreTestSupport; INSTALL_PATH = $(INSTALL_PATH_$(CONFIGURATION)); -INSTALL_PATH_Debug = @executable_path; -INSTALL_PATH_Release = $(INSTALL_PATH_Debug); INSTALL_PATH_Production = /usr/local/lib; +LD_DYLIB_INSTALL_NAME = $(LD_DYLIB_INSTALL_NAME_$(CONFIGURATION)); +LD_DYLIB_INSTALL_NAME_Debug = @rpath/$(EXECUTABLE_PATH); +LD_DYLIB_INSTAL
[webkit-changes] [89529] trunk/Source/WebKit/chromium
Title: [89529] trunk/Source/WebKit/chromium Revision 89529 Author rn...@webkit.org Date 2011-06-22 21:54:18 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Ryosuke Niwa Reviewed by Kent Tamura. [chromium] Remove calls to Position::deprecatedNode https://bugs.webkit.org/show_bug.cgi?id=63226 Call containerNode instead of deprecatedNode. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::textInputType): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebViewImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (89528 => 89529) --- trunk/Source/WebKit/chromium/ChangeLog 2011-06-23 04:19:31 UTC (rev 89528) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-23 04:54:18 UTC (rev 89529) @@ -1,3 +1,15 @@ +2011-06-22 Ryosuke Niwa + +Reviewed by Kent Tamura. + +[chromium] Remove calls to Position::deprecatedNode +https://bugs.webkit.org/show_bug.cgi?id=63226 + +Call containerNode instead of deprecatedNode. + +* src/WebViewImpl.cpp: +(WebKit::WebViewImpl::textInputType): + 2011-06-22 Adam Barth Reviewed by Darin Fisher. Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (89528 => 89529) --- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-06-23 04:19:31 UTC (rev 89528) +++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-06-23 04:54:18 UTC (rev 89529) @@ -1453,7 +1453,7 @@ if (!selection) return type; -const Node* node = selection->start().deprecatedNode(); +const Node* node = selection->start().containerNode(); if (!node) return type; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89528] branches/safari-534-branch/Source/WebKit2
Title: [89528] branches/safari-534-branch/Source/WebKit2
Revision 89528
Author lforsch...@apple.com
Date 2011-06-22 21:19:31 -0700 (Wed, 22 Jun 2011)
Log Message
Merge r89436.
Modified Paths
branches/safari-534-branch/Source/WebKit2/ChangeLog
branches/safari-534-branch/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp
Diff
Modified: branches/safari-534-branch/Source/WebKit2/ChangeLog (89527 => 89528)
--- branches/safari-534-branch/Source/WebKit2/ChangeLog 2011-06-23 04:18:16 UTC (rev 89527)
+++ branches/safari-534-branch/Source/WebKit2/ChangeLog 2011-06-23 04:19:31 UTC (rev 89528)
@@ -1,5 +1,27 @@
2011-06-22 Lucas Forschler
+Merged 89436.
+
+2011-06-22 Adam Roben
+
+Don't use an alpha channel when drawing the web page on Windows
+
+We never use the alpha channel in the end anyway (because we never render into a layered
+window, which is the only kind of window that supports alpha). And using an alpha channel is
+tricky to get right since GDI doesn't support alpha (and often writes 0x0 into the alpha
+channel).
+
+Fixes REGRESSION (r88978): Text inside
+form controls looks really awful on Windows XP
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/WebPage/win/DrawingAreaImplWin.cpp:
+(WebKit::DrawingAreaImpl::createGraphicsContext): Specify false for the hasAlpha parameter
+to the GraphicsContext constructor.
+
+2011-06-22 Lucas Forschler
+
Merged 89398.
2011-06-21 Jer Noble
Modified: branches/safari-534-branch/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp (89527 => 89528)
--- branches/safari-534-branch/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp 2011-06-23 04:18:16 UTC (rev 89527)
+++ branches/safari-534-branch/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp 2011-06-23 04:19:31 UTC (rev 89528)
@@ -54,7 +54,10 @@
PassOwnPtr DrawingAreaImpl::createGraphicsContext(ShareableBitmap* bitmap)
{
HDC bitmapDC = bitmap->windowsContext();
-return adoptPtr(new GraphicsContext(bitmapDC, true));
+// FIXME: We should really be checking m_webPage->draws[Transparent]Background() to determine
+// whether to have an alpha channel or not. But currently we always render into a non-layered
+// window, so the alpha channel doesn't matter anyway.
+return adoptPtr(new GraphicsContext(bitmapDC, false));
}
} // namespace WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89527] branches/safari-534-branch/Source/WebKit2
Title: [89527] branches/safari-534-branch/Source/WebKit2
Revision 89527
Author lforsch...@apple.com
Date 2011-06-22 21:18:16 -0700 (Wed, 22 Jun 2011)
Log Message
Merge r89398.
Modified Paths
branches/safari-534-branch/Source/WebKit2/ChangeLog
branches/safari-534-branch/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm
Diff
Modified: branches/safari-534-branch/Source/WebKit2/ChangeLog (89526 => 89527)
--- branches/safari-534-branch/Source/WebKit2/ChangeLog 2011-06-23 03:55:53 UTC (rev 89526)
+++ branches/safari-534-branch/Source/WebKit2/ChangeLog 2011-06-23 04:18:16 UTC (rev 89527)
@@ -1,3 +1,22 @@
+2011-06-22 Lucas Forschler
+
+Merged 89398.
+
+2011-06-21 Jer Noble
+
+Reviewed by Simon Fraser.
+
+REGRESSION: Fullscreen videos are broken (affects embedded vimeo, vimeo.com, and apple.com)
+https://bugs.webkit.org/show_bug.cgi?id=63098
+
+
+Force a repaint after completing entering full-screen mode only after the notification
+is sent for the QTMovie to tear down its layer. Then, the QTMovie will build up its
+layer again during the repaint.
+
+* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
+(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
+
2011-06-14 Lucas Forschler
Merged 88978.
Modified: branches/safari-534-branch/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm (89526 => 89527)
--- branches/safari-534-branch/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm 2011-06-23 03:55:53 UTC (rev 89526)
+++ branches/safari-534-branch/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm 2011-06-23 04:18:16 UTC (rev 89527)
@@ -138,14 +138,14 @@
return;
if (!layer) {
-m_page->forceRepaintWithoutCallback();
-m_page->send(Messages::WebFullScreenManagerProxy::ExitAcceleratedCompositingMode());
-
PlatformLayer* rootPlatformLayer = m_rootLayer->platformLayer();
[[NSNotificationCenter defaultCenter] postNotificationName:@"WebKitLayerHostChanged" object:rootPlatformLayer userInfo:nil];
m_rootLayer->removeAllChildren();
m_rootLayer->syncCompositingStateForThisLayerOnly();
m_rootLayer = nullptr;
+
+m_page->forceRepaintWithoutCallback();
+m_page->send(Messages::WebFullScreenManagerProxy::ExitAcceleratedCompositingMode());
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89526] trunk/Source/WebCore
Title: [89526] trunk/Source/WebCore
Revision 89526
Author dglaz...@chromium.org
Date 2011-06-22 20:55:53 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Dimitri Glazkov
Reviewed by Kent Tamura.
Convert FileIconLoaderClient to "smart client" pattern, just like FileChooserClient.
https://bugs.webkit.org/show_bug.cgi?id=63224
Refactoring, covered by existing tests.
* platform/FileIconLoader.cpp:
(WebCore::FileIconLoaderClient::~FileIconLoaderClient): Changed to discard loader.
(WebCore::FileIconLoaderClient::newFileIconLoader): Added.
(WebCore::FileIconLoaderClient::discardLoader): Added.
* platform/FileIconLoader.h: Updated defs.
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::RenderFileUploadControl): Removed initialization of icon loader.
(WebCore::RenderFileUploadControl::~RenderFileUploadControl): Remove discarding of loader.
(WebCore::RenderFileUploadControl::requestIcon): Changed to use newFileIconLoader.
* rendering/RenderFileUploadControl.h: Updated defs.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/FileIconLoader.cpp
trunk/Source/WebCore/platform/FileIconLoader.h
trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp
trunk/Source/WebCore/rendering/RenderFileUploadControl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (89525 => 89526)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 03:49:06 UTC (rev 89525)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 03:55:53 UTC (rev 89526)
@@ -1,3 +1,23 @@
+2011-06-22 Dimitri Glazkov
+
+Reviewed by Kent Tamura.
+
+Convert FileIconLoaderClient to "smart client" pattern, just like FileChooserClient.
+https://bugs.webkit.org/show_bug.cgi?id=63224
+
+Refactoring, covered by existing tests.
+
+* platform/FileIconLoader.cpp:
+(WebCore::FileIconLoaderClient::~FileIconLoaderClient): Changed to discard loader.
+(WebCore::FileIconLoaderClient::newFileIconLoader): Added.
+(WebCore::FileIconLoaderClient::discardLoader): Added.
+* platform/FileIconLoader.h: Updated defs.
+* rendering/RenderFileUploadControl.cpp:
+(WebCore::RenderFileUploadControl::RenderFileUploadControl): Removed initialization of icon loader.
+(WebCore::RenderFileUploadControl::~RenderFileUploadControl): Remove discarding of loader.
+(WebCore::RenderFileUploadControl::requestIcon): Changed to use newFileIconLoader.
+* rendering/RenderFileUploadControl.h: Updated defs.
+
2011-06-22 Yael Aharon
Another unreviewed build fix after r89472.
Modified: trunk/Source/WebCore/platform/FileIconLoader.cpp (89525 => 89526)
--- trunk/Source/WebCore/platform/FileIconLoader.cpp 2011-06-23 03:49:06 UTC (rev 89525)
+++ trunk/Source/WebCore/platform/FileIconLoader.cpp 2011-06-23 03:55:53 UTC (rev 89526)
@@ -36,8 +36,23 @@
FileIconLoaderClient::~FileIconLoaderClient()
{
+discardLoader();
}
+FileIconLoader* FileIconLoaderClient::newFileIconLoader()
+{
+discardLoader();
+
+m_loader = FileIconLoader::create(this);
+return m_loader.get();
+}
+
+void FileIconLoaderClient::discardLoader()
+{
+if (m_loader)
+m_loader->disconnectClient();
+}
+
PassRefPtr FileIconLoader::create(FileIconLoaderClient* client)
{
return adoptRef(new FileIconLoader(client));
Modified: trunk/Source/WebCore/platform/FileIconLoader.h (89525 => 89526)
--- trunk/Source/WebCore/platform/FileIconLoader.h 2011-06-23 03:49:06 UTC (rev 89525)
+++ trunk/Source/WebCore/platform/FileIconLoader.h 2011-06-23 03:55:53 UTC (rev 89526)
@@ -31,17 +31,26 @@
#ifndef FileIconLoader_h
#define FileIconLoader_h
-#include
+#include
#include
namespace WebCore {
+class FileIconLoader;
class Icon;
class FileIconLoaderClient {
public:
virtual void updateRendering(PassRefPtr) = 0;
virtual ~FileIconLoaderClient();
+
+protected:
+FileIconLoader* newFileIconLoader();
+
+private:
+void discardLoader();
+
+RefPtr m_loader;
};
class FileIconLoader : public RefCounted {
Modified: trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp (89525 => 89526)
--- trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp 2011-06-23 03:49:06 UTC (rev 89525)
+++ trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp 2011-06-23 03:55:53 UTC (rev 89526)
@@ -56,7 +56,6 @@
RenderFileUploadControl::RenderFileUploadControl(HTMLInputElement* input)
: RenderBlock(input)
-, m_iconLoader(FileIconLoader::create(this))
{
ASSERT(input->files());
requestIcon(input->files()->filenames());
@@ -64,16 +63,15 @@
RenderFileUploadControl::~RenderFileUploadControl()
{
-m_iconLoader->disconnectClient();
}
-void RenderFileUploadControl::requestIcon(const Vector& filenames) const
+void RenderFileUploadControl::requestIcon(const Vector& filenames)
{
if (!filenames.size(
[webkit-changes] [89525] trunk/Source/WebCore
Title: [89525] trunk/Source/WebCore
Revision 89525
Author yael.aha...@nokia.com
Date 2011-06-22 20:49:06 -0700 (Wed, 22 Jun 2011)
Log Message
Another unreviewed build fix after r89472.
No new tests, just a build fix.
* rendering/svg/SVGResources.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGResources.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89524 => 89525)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 03:26:53 UTC (rev 89524)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 03:49:06 UTC (rev 89525)
@@ -1,5 +1,13 @@
2011-06-22 Yael Aharon
+Another unreviewed build fix after r89472.
+
+No new tests, just a build fix.
+
+* rendering/svg/SVGResources.cpp:
+
+2011-06-22 Yael Aharon
+
Unreviewed build fix after r89472.
No new tests, just a build fix.
Modified: trunk/Source/WebCore/rendering/svg/SVGResources.cpp (89524 => 89525)
--- trunk/Source/WebCore/rendering/svg/SVGResources.cpp 2011-06-23 03:26:53 UTC (rev 89524)
+++ trunk/Source/WebCore/rendering/svg/SVGResources.cpp 2011-06-23 03:49:06 UTC (rev 89525)
@@ -33,6 +33,10 @@
#include "SVGRenderStyle.h"
#include "SVGURIReference.h"
+#ifndef NDEBUG
+#include
+#endif
+
namespace WebCore {
SVGResources::SVGResources()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89524] trunk/Source/WebCore
Title: [89524] trunk/Source/WebCore
Revision 89524
Author yael.aha...@nokia.com
Date 2011-06-22 20:26:53 -0700 (Wed, 22 Jun 2011)
Log Message
Unreviewed build fix after r89472.
No new tests, just a build fix.
* rendering/InlineBox.cpp:
* rendering/RenderCounter.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineBox.cpp
trunk/Source/WebCore/rendering/RenderCounter.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89523 => 89524)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 03:07:58 UTC (rev 89523)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 03:26:53 UTC (rev 89524)
@@ -1,3 +1,12 @@
+2011-06-22 Yael Aharon
+
+Unreviewed build fix after r89472.
+
+No new tests, just a build fix.
+
+* rendering/InlineBox.cpp:
+* rendering/RenderCounter.cpp:
+
2011-06-22 Dimitri Glazkov
Reviewed by Kent Tamura.
Modified: trunk/Source/WebCore/rendering/InlineBox.cpp (89523 => 89524)
--- trunk/Source/WebCore/rendering/InlineBox.cpp 2011-06-23 03:07:58 UTC (rev 89523)
+++ trunk/Source/WebCore/rendering/InlineBox.cpp 2011-06-23 03:26:53 UTC (rev 89524)
@@ -27,6 +27,10 @@
#include "RenderBlock.h"
#include "RootInlineBox.h"
+#ifndef NDEBUG
+#include
+#endif
+
using namespace std;
namespace WebCore {
Modified: trunk/Source/WebCore/rendering/RenderCounter.cpp (89523 => 89524)
--- trunk/Source/WebCore/rendering/RenderCounter.cpp 2011-06-23 03:07:58 UTC (rev 89523)
+++ trunk/Source/WebCore/rendering/RenderCounter.cpp 2011-06-23 03:26:53 UTC (rev 89524)
@@ -32,6 +32,10 @@
#include "RenderStyle.h"
#include
+#ifndef NDEBUG
+#include
+#endif
+
namespace WebCore {
using namespace HTMLNames;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89523] trunk/Source/WebCore
Title: [89523] trunk/Source/WebCore
Revision 89523
Author dglaz...@chromium.org
Date 2011-06-22 20:07:58 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Dimitri Glazkov
Reviewed by Kent Tamura.
Add a helper function to FileList to retrieve a list of filenames.
https://bugs.webkit.org/show_bug.cgi?id=63222
Refactoring, covered by existing tests.
* fileapi/FileList.cpp:
(WebCore::FileList::filenames): Added.
* fileapi/FileList.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::RenderFileUploadControl): Changed to use newly added helper.
(WebCore::RenderFileUploadControl::click): Ditto.
(WebCore::RenderFileUploadControl::fileTextValue): Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/FileList.cpp
trunk/Source/WebCore/fileapi/FileList.h
trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89522 => 89523)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 02:31:11 UTC (rev 89522)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 03:07:58 UTC (rev 89523)
@@ -1,3 +1,20 @@
+2011-06-22 Dimitri Glazkov
+
+Reviewed by Kent Tamura.
+
+Add a helper function to FileList to retrieve a list of filenames.
+https://bugs.webkit.org/show_bug.cgi?id=63222
+
+Refactoring, covered by existing tests.
+
+* fileapi/FileList.cpp:
+(WebCore::FileList::filenames): Added.
+* fileapi/FileList.h:
+* rendering/RenderFileUploadControl.cpp:
+(WebCore::RenderFileUploadControl::RenderFileUploadControl): Changed to use newly added helper.
+(WebCore::RenderFileUploadControl::click): Ditto.
+(WebCore::RenderFileUploadControl::fileTextValue): Ditto.
+
2011-06-22 Sam Weinig
Reviewed by Adam Barth.
Modified: trunk/Source/WebCore/fileapi/FileList.cpp (89522 => 89523)
--- trunk/Source/WebCore/fileapi/FileList.cpp 2011-06-23 02:31:11 UTC (rev 89522)
+++ trunk/Source/WebCore/fileapi/FileList.cpp 2011-06-23 03:07:58 UTC (rev 89523)
@@ -41,4 +41,13 @@
return m_files[index].get();
}
+Vector FileList::filenames() const
+{
+Vector filenames;
+for (unsigned i = 0; i < m_files.size(); ++i)
+filenames.append(m_files[i]->path());
+
+return filenames;
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/fileapi/FileList.h (89522 => 89523)
--- trunk/Source/WebCore/fileapi/FileList.h 2011-06-23 02:31:11 UTC (rev 89522)
+++ trunk/Source/WebCore/fileapi/FileList.h 2011-06-23 03:07:58 UTC (rev 89523)
@@ -47,6 +47,7 @@
bool isEmpty() const { return m_files.isEmpty(); }
void clear() { m_files.clear(); }
void append(PassRefPtr file) { m_files.append(file); }
+Vector filenames() const;
private:
FileList();
Modified: trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp (89522 => 89523)
--- trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp 2011-06-23 02:31:11 UTC (rev 89522)
+++ trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp 2011-06-23 03:07:58 UTC (rev 89523)
@@ -54,20 +54,12 @@
const int defaultWidthNumChars = 34;
const int buttonShadowHeight = 2;
-static void filenamesFromFileList(const FileList* list, Vector& filenames)
-{
-unsigned length = list ? list->length() : 0;
-for (unsigned i = 0; i < length; ++i)
-filenames.append(list->item(i)->path());
-}
-
RenderFileUploadControl::RenderFileUploadControl(HTMLInputElement* input)
: RenderBlock(input)
, m_iconLoader(FileIconLoader::create(this))
{
-Vector filenames;
-filenamesFromFileList(input->files(), filenames);
-requestIcon(filenames);
+ASSERT(input->files());
+requestIcon(input->files()->filenames());
}
RenderFileUploadControl::~RenderFileUploadControl()
@@ -133,7 +125,8 @@
settings.allowsMultipleFiles = input->fastHasAttribute(multipleAttr);
#endif
settings.acceptTypes = input->accept();
-filenamesFromFileList(input->files(), settings.selectedFiles);
+ASSERT(input->files());
+settings.selectedFiles = input->files()->filenames();
chrome->runOpenPanel(frame(), newFileChooser(settings));
}
}
@@ -328,9 +321,9 @@
String RenderFileUploadControl::fileTextValue() const
{
-Vector filenames;
-filenamesFromFileList(static_cast(node())->files(), filenames);
-return theme()->fileListNameForWidth(filenames, style()->font(), maxFilenameWidth());
+HTMLInputElement* input = static_cast(node());
+ASSERT(input->files());
+return theme()->fileListNameForWidth(input->files()->filenames(), style()->font(), maxFilenameWidth());
}
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89522] trunk
Title: [89522] trunk Revision 89522 Author wei...@apple.com Date 2011-06-22 19:31:11 -0700 (Wed, 22 Jun 2011) Log Message Lower HTML parser DOM depth limit to 2048 https://bugs.webkit.org/show_bug.cgi?id=63219 Reviewed by Adam Barth. Source/WebCore: Lower the default depth limit from 4096 to 2048. There isn't a good reason to have such pathologically nested content, and by-and-large, the rendering code is not setup to support it that well. Adding this aggressive limit now will allow us to see if anything breaks in the nightlies. * page/Settings.h: LayoutTests: Update nest test to reflect new limit and remove tests that were testing specific behaviors of the old parser. * fast/parser/block-nesting-cap-expected.txt: * fast/parser/block-nesting-cap-table-expected.txt: Removed. * fast/parser/block-nesting-cap-table.html: Removed. * fast/parser/element-nesting-cap-expected.txt: Removed. * fast/parser/element-nesting-cap.html: Removed. * fast/parser/script-tests/block-nesting-cap-table.js: Removed. * fast/parser/script-tests/block-nesting-cap.js: * fast/parser/script-tests/element-nesting-cap.js: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt trunk/LayoutTests/fast/parser/script-tests/block-nesting-cap.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/Settings.h Removed Paths trunk/LayoutTests/fast/parser/block-nesting-cap-table-expected.txt trunk/LayoutTests/fast/parser/block-nesting-cap-table.html trunk/LayoutTests/fast/parser/element-nesting-cap-expected.txt trunk/LayoutTests/fast/parser/element-nesting-cap.html trunk/LayoutTests/fast/parser/script-tests/block-nesting-cap-table.js trunk/LayoutTests/fast/parser/script-tests/element-nesting-cap.js Diff Modified: trunk/LayoutTests/ChangeLog (89521 => 89522) --- trunk/LayoutTests/ChangeLog 2011-06-23 02:26:27 UTC (rev 89521) +++ trunk/LayoutTests/ChangeLog 2011-06-23 02:31:11 UTC (rev 89522) @@ -1,3 +1,22 @@ +2011-06-22 Sam Weinig + +Reviewed by Adam Barth. + +Lower HTML parser DOM depth limit to 2048 +https://bugs.webkit.org/show_bug.cgi?id=63219 + +Update nest test to reflect new limit and remove tests that were +testing specific behaviors of the old parser. + +* fast/parser/block-nesting-cap-expected.txt: +* fast/parser/block-nesting-cap-table-expected.txt: Removed. +* fast/parser/block-nesting-cap-table.html: Removed. +* fast/parser/element-nesting-cap-expected.txt: Removed. +* fast/parser/element-nesting-cap.html: Removed. +* fast/parser/script-tests/block-nesting-cap-table.js: Removed. +* fast/parser/script-tests/block-nesting-cap.js: +* fast/parser/script-tests/element-nesting-cap.js: Removed. + 2011-06-22 Kent Tamura [Win] media/media-controls-clone.html failing on Windows 7 Release (Tests) Modified: trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt (89521 => 89522) --- trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt 2011-06-23 02:26:27 UTC (rev 89521) +++ trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt 2011-06-23 02:31:11 UTC (rev 89522) @@ -1,11 +1,11 @@ -Test that the HTML parser does not allow the nesting depth of "block-level" elements to exceed 4096. +Test that the HTML parser does not allow the nesting depth of "block-level" elements to exceed 2048. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS d4096.parentNode === d4094 is true -PASS d4095.parentNode === d4094 is true -PASS d4096.previousSibling === d4095 is true +PASS d2048.parentNode === d2046 is true +PASS d2047.parentNode === d2046 is true +PASS d2048.previousSibling === d2047 is true PASS successfullyParsed is true TEST COMPLETE Deleted: trunk/LayoutTests/fast/parser/block-nesting-cap-table-expected.txt (89521 => 89522) --- trunk/LayoutTests/fast/parser/block-nesting-cap-table-expected.txt 2011-06-23 02:26:27 UTC (rev 89521) +++ trunk/LayoutTests/fast/parser/block-nesting-cap-table-expected.txt 2011-06-23 02:31:11 UTC (rev 89522) @@ -1,12 +0,0 @@ -Test that the HTML parser does not allow the nesting depth of "block-level" elements to exceed 4096 when using nested table tag - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -FAIL t1024.parentNode === td1022 should be true. Was false. -PASS t1023.parentNode === td1022 is true -FAIL t1024.previousSibling === t1023 should be true. Was false. -PASS successfullyParsed is true - -TEST COMPLETE - Deleted: trunk/LayoutTests/fast/parser/block-nesting-cap-table.html (89521 => 89522) --- trunk/LayoutTests/fast/parser/block-nesting-cap-table.html 2011-06-23 02:26:27 UTC (rev 89521) +++ trunk/LayoutTests/fast/parser/block-nesting-cap-table.html 2011-06-23 02:31:11 UTC (rev 89522) @@ -1,13 +0,0 @@ - - - - - - - -
[webkit-changes] [89521] trunk/Source/WebCore
Title: [89521] trunk/Source/WebCore
Revision 89521
Author jchaffr...@webkit.org
Date 2011-06-22 19:26:27 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Julien Chaffraix
Reviewed by Dimitri Glazkov.
Tighten type usage in the Shadow tree code
https://bugs.webkit.org/show_bug.cgi?id=63210
Refactoring only, no new test required.
* dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
* dom/Document.h:
Changed the argument of buildAccessKeyMap to TreeScope.
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::removeShadowRoot):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::shadowColorSwatch):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::shadowSelect):
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderThumbElementOf):
Use ShadowRoot for the previous call sites as this is what is
returned by shadowRoot().
* dom/Node.cpp:
(WebCore::traverseTreeAndMark): Renamed the parameter here as it is not
expected to be a shadow object. Just the rootNode of our traversal.
* dom/ShadowRoot.h: Made attach() public as it is public in ContainerNode
and we would do some casting to avoid the private attribute in ShadowRoot.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/ShadowRoot.h
trunk/Source/WebCore/html/ColorInputType.cpp
trunk/Source/WebCore/html/HTMLKeygenElement.cpp
trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89520 => 89521)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 02:14:30 UTC (rev 89520)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 02:26:27 UTC (rev 89521)
@@ -1,3 +1,36 @@
+2011-06-22 Julien Chaffraix
+
+Reviewed by Dimitri Glazkov.
+
+Tighten type usage in the Shadow tree code
+https://bugs.webkit.org/show_bug.cgi?id=63210
+
+Refactoring only, no new test required.
+
+* dom/Document.cpp:
+(WebCore::Document::buildAccessKeyMap):
+* dom/Document.h:
+Changed the argument of buildAccessKeyMap to TreeScope.
+
+* dom/Element.cpp:
+(WebCore::Element::attach):
+(WebCore::Element::removeShadowRoot):
+* html/ColorInputType.cpp:
+(WebCore::ColorInputType::shadowColorSwatch):
+* html/HTMLKeygenElement.cpp:
+(WebCore::HTMLKeygenElement::shadowSelect):
+* html/shadow/SliderThumbElement.cpp:
+(WebCore::sliderThumbElementOf):
+Use ShadowRoot for the previous call sites as this is what is
+returned by shadowRoot().
+
+* dom/Node.cpp:
+(WebCore::traverseTreeAndMark): Renamed the parameter here as it is not
+expected to be a shadow object. Just the rootNode of our traversal.
+
+* dom/ShadowRoot.h: Made attach() public as it is public in ContainerNode
+and we would do some casting to avoid the private attribute in ShadowRoot.
+
2011-06-22 Joseph Pecoraro
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/dom/Document.cpp (89520 => 89521)
--- trunk/Source/WebCore/dom/Document.cpp 2011-06-23 02:14:30 UTC (rev 89520)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-06-23 02:26:27 UTC (rev 89521)
@@ -618,7 +618,7 @@
return m_elementsByAccessKey.get(key.impl());
}
-void Document::buildAccessKeyMap(ContainerNode* root)
+void Document::buildAccessKeyMap(TreeScope* root)
{
for (Node* n = root; n; n = n->traverseNextNode(root)) {
if (!n->isElementNode())
Modified: trunk/Source/WebCore/dom/Document.h (89520 => 89521)
--- trunk/Source/WebCore/dom/Document.h 2011-06-23 02:14:30 UTC (rev 89520)
+++ trunk/Source/WebCore/dom/Document.h 2011-06-23 02:26:27 UTC (rev 89521)
@@ -1130,7 +1130,7 @@
void cacheDocumentElement() const;
-void buildAccessKeyMap(ContainerNode* root);
+void buildAccessKeyMap(TreeScope* root);
void createStyleSelector();
Modified: trunk/Source/WebCore/dom/Element.cpp (89520 => 89521)
--- trunk/Source/WebCore/dom/Element.cpp 2011-06-23 02:14:30 UTC (rev 89520)
+++ trunk/Source/WebCore/dom/Element.cpp 2011-06-23 02:26:27 UTC (rev 89521)
@@ -1019,7 +1019,7 @@
parentPusher.push();
ContainerNode::attach();
-if (Node* shadow = shadowRoot()) {
+if (ShadowRoot* shadow = shadowRoot()) {
parentPusher.push();
shadow->attach();
}
@@ -1217,7 +1217,7 @@
return;
ElementRareData* data = ""
-if (RefPtr oldRoot = data->m_shadowRoot) {
+if (RefPtr oldRoot = data->m_shadowRoot) {
data->m_shadowRoot = 0;
document()->removeFocusedNodeOfSubtree(oldRoot.get());
Modified: trunk/Source/WebCore/dom/Node.cpp (89520 =>
[webkit-changes] [89520] trunk/Tools
Title: [89520] trunk/Tools Revision 89520 Author e...@webkit.org Date 2011-06-22 19:14:30 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Eric Seidel Reviewed by Adam Barth. Make sheriff-bot rollout messages a little nicer https://bugs.webkit.org/show_bug.cgi?id=63107 itertools.chain.from_iterable is new in 2.6, use itertools.chain(*list) for 2.5 compat. * Scripts/webkitpy/tool/bot/irc_command.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py Diff Modified: trunk/Tools/ChangeLog (89519 => 89520) --- trunk/Tools/ChangeLog 2011-06-23 02:09:22 UTC (rev 89519) +++ trunk/Tools/ChangeLog 2011-06-23 02:14:30 UTC (rev 89520) @@ -2,6 +2,18 @@ Reviewed by Adam Barth. +Make sheriff-bot rollout messages a little nicer +https://bugs.webkit.org/show_bug.cgi?id=63107 + +itertools.chain.from_iterable is new in 2.6, +use itertools.chain(*list) for 2.5 compat. + +* Scripts/webkitpy/tool/bot/irc_command.py: + +2011-06-22 Eric Seidel + +Reviewed by Adam Barth. + Make sheriff-bot robust against exceptions from commands https://bugs.webkit.org/show_bug.cgi?id=63211 Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (89519 => 89520) --- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-06-23 02:09:22 UTC (rev 89519) +++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-06-23 02:14:30 UTC (rev 89520) @@ -81,7 +81,7 @@ def _responsible_nicknames_from_revisions(self, tool, sheriff, svn_revision_list): commit_infos = map(tool.checkout().commit_info_for_revision, svn_revision_list) nickname_lists = map(sheriff.responsible_nicknames_from_commit_info, commit_infos) -return sorted(set(itertools.chain.from_iterable(nickname_lists))) +return sorted(set(itertools.chain(*nickname_lists))) def _nicks_string(self, tool, sheriff, requester_nick, svn_revision_list): # FIXME: _parse_args guarentees that our svn_revision_list is all numbers. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89519] trunk/LayoutTests
Title: [89519] trunk/LayoutTests
Revision 89519
Author tk...@chromium.org
Date 2011-06-22 19:09:22 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Kent Tamura
[Win] media/media-controls-clone.html failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=63195
* platform/win/media/media-controls-clone-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/win/media/media-controls-clone-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (89518 => 89519)
--- trunk/LayoutTests/ChangeLog 2011-06-23 01:44:20 UTC (rev 89518)
+++ trunk/LayoutTests/ChangeLog 2011-06-23 02:09:22 UTC (rev 89519)
@@ -1,3 +1,10 @@
+2011-06-22 Kent Tamura
+
+[Win] media/media-controls-clone.html failing on Windows 7 Release (Tests)
+https://bugs.webkit.org/show_bug.cgi?id=63195
+
+* platform/win/media/media-controls-clone-expected.txt: Added.
+
2011-06-22 Matthew Delaney
Reviewed by James Robinson.
Added: trunk/LayoutTests/platform/win/media/media-controls-clone-expected.txt (0 => 89519)
--- trunk/LayoutTests/platform/win/media/media-controls-clone-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/media/media-controls-clone-expected.txt 2011-06-23 02:09:22 UTC (rev 89519)
@@ -0,0 +1,42 @@
+CONSOLE MESSAGE: line 3: ReferenceError: Can't find variable: run
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x324
+ RenderBlock {HTML} at (0,0) size 800x324
+RenderBody {BODY} at (8,8) size 784x308
+ RenderBlock {DIV} at (0,0) size 784x154
+RenderMedia {AUDIO} at (300,134) size 200x16
+ RenderBlock {DIV} at (0,154) size 784x154
+RenderMedia {AUDIO} at (300,134) size 200x16
+layer at (8,8) size 300x150
+ RenderVideo {VIDEO} at (0,0) size 300x150
+layer at (8,162) size 300x150
+ RenderVideo {VIDEO} at (0,0) size 300x150
+layer at (8,8) size 300x150
+ RenderBlock (relative positioned) {DIV} at (0,0) size 300x150
+layer at (8,142) size 300x16
+ RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,134) size 300x16
+RenderButton {INPUT} at (0,0) size 16x16
+RenderButton {INPUT} at (16,0) size 16x16
+RenderButton {INPUT} at (32,0) size 16x16
+layer at (308,142) size 200x16
+ RenderBlock (relative positioned) {DIV} at (0,0) size 200x16
+layer at (308,142) size 200x16
+ RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,0) size 200x16
+RenderButton {INPUT} at (0,0) size 16x16
+RenderButton {INPUT} at (16,0) size 16x16
+RenderButton {INPUT} at (32,0) size 16x16
+layer at (8,162) size 300x150
+ RenderBlock (relative positioned) {DIV} at (0,0) size 300x150
+layer at (8,296) size 300x16
+ RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,134) size 300x16
+RenderButton {INPUT} at (0,0) size 16x16
+RenderButton {INPUT} at (16,0) size 16x16
+RenderButton {INPUT} at (32,0) size 16x16
+layer at (308,296) size 200x16
+ RenderBlock (relative positioned) {DIV} at (0,0) size 200x16
+layer at (308,296) size 200x16
+ RenderDeprecatedFlexibleBox (positioned) {DIV} at (0,0) size 200x16
+RenderButton {INPUT} at (0,0) size 16x16
+RenderButton {INPUT} at (16,0) size 16x16
+RenderButton {INPUT} at (32,0) size 16x16
Property changes on: trunk/LayoutTests/platform/win/media/media-controls-clone-expected.txt
___
Added: svn:eol-style
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89518] trunk/Tools
Title: [89518] trunk/Tools
Revision 89518
Author e...@webkit.org
Date 2011-06-22 18:44:20 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Eric Seidel
Reviewed by Adam Barth.
Make sheriff-bot robust against exceptions from commands
https://bugs.webkit.org/show_bug.cgi?id=63211
sheriff-bot was acting strange this afternoon.
We don't know if this will fix the cause, but
at least it adds some unit tests and catches
one possible cause.
* Scripts/webkitpy/tool/bot/sheriffircbot.py:
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py
trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (89517 => 89518)
--- trunk/Tools/ChangeLog 2011-06-23 01:43:22 UTC (rev 89517)
+++ trunk/Tools/ChangeLog 2011-06-23 01:44:20 UTC (rev 89518)
@@ -1,3 +1,18 @@
+2011-06-22 Eric Seidel
+
+Reviewed by Adam Barth.
+
+Make sheriff-bot robust against exceptions from commands
+https://bugs.webkit.org/show_bug.cgi?id=63211
+
+sheriff-bot was acting strange this afternoon.
+We don't know if this will fix the cause, but
+at least it adds some unit tests and catches
+one possible cause.
+
+* Scripts/webkitpy/tool/bot/sheriffircbot.py:
+* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
+
2011-06-22 Mark Rowe
Reviewed by David Levin.
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py (89517 => 89518)
--- trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py 2011-06-23 01:43:22 UTC (rev 89517)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py 2011-06-23 01:44:20 UTC (rev 89518)
@@ -62,22 +62,27 @@
self._message_queue,
self._tool.wakeup_event)
-def process_message(self, message):
-(nick, request) = message
+def _parse_command_and_args(self, request):
tokenized_request = request.strip().split(" ")
-if not tokenized_request:
-return
command = irc_command.commands.get(tokenized_request[0])
args = tokenized_request[1:]
if not command:
# Give the peoples someone to talk with.
command = irc_command.Eliza
args = tokenized_request
-response = command().execute(nick, args, self._tool, self._sheriff)
-if response:
-self._tool.irc().post(response)
+return (command, args)
+def process_message(self, requester_nick, request):
+command, args = self._parse_command_and_args(request)
+try:
+response = command().execute(requester_nick, args, self._tool, self._sheriff)
+if response:
+self._tool.irc().post(response)
+except Exception, e:
+self._tool.irc().post("Exception executing command: %s" % e)
+
def process_pending_messages(self):
(messages, is_running) = self._message_queue.take_all()
for message in messages:
-self.process_message(message)
+(nick, request) = message
+self.process_message(nick, request)
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py (89517 => 89518)
--- trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py 2011-06-23 01:43:22 UTC (rev 89517)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py 2011-06-23 01:44:20 UTC (rev 89518)
@@ -30,6 +30,7 @@
import random
from webkitpy.common.system.outputcapture import OutputCapture
+from webkitpy.tool.bot import irc_command
from webkitpy.tool.bot.sheriff import Sheriff
from webkitpy.tool.bot.sheriffircbot import SheriffIRCBot
from webkitpy.tool.bot.sheriff_unittest import MockSheriffBot
@@ -45,6 +46,27 @@
class SheriffIRCBotTest(unittest.TestCase):
+def test_parse_command_and_args(self):
+tool = MockTool()
+bot = SheriffIRCBot(tool, Sheriff(tool, MockSheriffBot()))
+self.assertEqual(bot._parse_command_and_args(""), (irc_command.Eliza, [""]))
+self.assertEqual(bot._parse_command_and_args(" "), (irc_command.Eliza, [""]))
+self.assertEqual(bot._parse_command_and_args(" hi "), (irc_command.Hi, []))
+self.assertEqual(bot._parse_command_and_args(" hi there "), (irc_command.Hi, ["there"]))
+
+def test_exception_during_command(self):
+tool = MockTool()
+tool.ensure_irc_connected(None)
+bot = SheriffIRCBot(tool, Sheriff(tool, MockSheriffBot()))
+
+class CommandWithException(object):
+def execute(self, nick, args, tool, sheriff):
+raise Exception("mock_exception")
+
+bot._parse_command_and_args = lambda request: (CommandWithException, [])
+expected_stderr = 'MOCK: irc.post: Exception executing command: mock_excep
[webkit-changes] [89517] trunk/Source/WebCore
Title: [89517] trunk/Source/WebCore Revision 89517 Author joep...@webkit.org Date 2011-06-22 18:43:22 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Joseph Pecoraro Reviewed by Darin Adler. Remove comment about pages with frames not being page-cachable https://bugs.webkit.org/show_bug.cgi?id=63207 This comment was out of date. Caching pages with Frames in the PageCache has worked since 2009: Page Cache should support pages with frames * history/PageCache.cpp: (WebCore::PageCache::canCache): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/history/PageCache.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (89516 => 89517) --- trunk/Source/WebCore/ChangeLog 2011-06-23 01:36:42 UTC (rev 89516) +++ trunk/Source/WebCore/ChangeLog 2011-06-23 01:43:22 UTC (rev 89517) @@ -1,3 +1,17 @@ +2011-06-22 Joseph Pecoraro + +Reviewed by Darin Adler. + +Remove comment about pages with frames not being page-cachable +https://bugs.webkit.org/show_bug.cgi?id=63207 + +This comment was out of date. Caching pages with Frames in +the PageCache has worked since 2009: + Page Cache should support pages with frames + +* history/PageCache.cpp: +(WebCore::PageCache::canCache): + 2011-06-22 Yael Aharon Reviewed by Andreas Kling. Modified: trunk/Source/WebCore/history/PageCache.cpp (89516 => 89517) --- trunk/Source/WebCore/history/PageCache.cpp 2011-06-23 01:36:42 UTC (rev 89516) +++ trunk/Source/WebCore/history/PageCache.cpp 2011-06-23 01:43:22 UTC (rev 89517) @@ -299,8 +299,6 @@ // store the final page we end up on. // No point writing to the cache on a reload or loadSame, since we will just write // over it again when we leave that page. -// FIXME: - We should work out the complexities of caching pages with frames as they -// are the most interesting pages on the web, and often those that would benefit the most from caching! FrameLoadType loadType = page->mainFrame()->loader()->loadType(); return canCachePageContainingThisFrame(page->mainFrame()) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89516] trunk/Source
Title: [89516] trunk/Source
Revision 89516
Author yael.aha...@nokia.com
Date 2011-06-22 18:36:42 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Yael Aharon
Reviewed by Andreas Kling.
[Qt] Add a build flag for building with libxml2 and libxslt.
https://bugs.webkit.org/show_bug.cgi?id=63113
* wtf/Platform.h:
2011-06-22 Yael Aharon
Reviewed by Andreas Kling.
[Qt] Add a build flag for building with libxml2 and libxslt.
https://bugs.webkit.org/show_bug.cgi?id=63113
No new tests. If this new flag was set by default, we could unskip
existing xmlviewer tests.
* CodeGenerators.pri:
* WebCore.pri:
* WebCore.pro:
* features.pri:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/CodeGenerators.pri
trunk/Source/WebCore/WebCore.pri
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebCore/features.pri
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (89515 => 89516)
--- trunk/Source/_javascript_Core/ChangeLog 2011-06-23 01:34:11 UTC (rev 89515)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-06-23 01:36:42 UTC (rev 89516)
@@ -1,3 +1,12 @@
+2011-06-22 Yael Aharon
+
+Reviewed by Andreas Kling.
+
+[Qt] Add a build flag for building with libxml2 and libxslt.
+https://bugs.webkit.org/show_bug.cgi?id=63113
+
+* wtf/Platform.h:
+
2011-06-22 Sheriff Bot
Unreviewed, rolling out r89489.
Modified: trunk/Source/_javascript_Core/wtf/Platform.h (89515 => 89516)
--- trunk/Source/_javascript_Core/wtf/Platform.h 2011-06-23 01:34:11 UTC (rev 89515)
+++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-06-23 01:36:42 UTC (rev 89516)
@@ -1117,9 +1117,11 @@
/* Use the QXmlStreamReader implementation for XMLDocumentParser */
/* Use the QXmlQuery implementation for XSLTProcessor */
#if PLATFORM(QT)
+#if !USE(LIBXML2)
#define WTF_USE_QXMLSTREAM 1
#define WTF_USE_QXMLQUERY 1
#endif
+#endif
#if PLATFORM(MAC)
/* Complex text framework */
Modified: trunk/Source/WebCore/ChangeLog (89515 => 89516)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 01:34:11 UTC (rev 89515)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 01:36:42 UTC (rev 89516)
@@ -1,3 +1,18 @@
+2011-06-22 Yael Aharon
+
+Reviewed by Andreas Kling.
+
+[Qt] Add a build flag for building with libxml2 and libxslt.
+https://bugs.webkit.org/show_bug.cgi?id=63113
+
+No new tests. If this new flag was set by default, we could unskip
+existing xmlviewer tests.
+
+* CodeGenerators.pri:
+* WebCore.pri:
+* WebCore.pro:
+* features.pri:
+
2011-06-22 Ryosuke Niwa
Yet another build fix after r89472.
Modified: trunk/Source/WebCore/CodeGenerators.pri (89515 => 89516)
--- trunk/Source/WebCore/CodeGenerators.pri 2011-06-23 01:34:11 UTC (rev 89515)
+++ trunk/Source/WebCore/CodeGenerators.pri 2011-06-23 01:36:42 UTC (rev 89516)
@@ -22,6 +22,13 @@
CSSBISON = $$PWD/css/CSSGrammar.y
+contains(DEFINES, ENABLE_XSLT=1) {
+contains(DEFINES, WTF_USE_LIBXML2=1) {
+XMLVIEWER_CSS = $$PWD/xml/XMLViewer.css
+XMLVIEWER_JS = $$PWD/xml/XMLViewer.js
+}
+}
+
HTML_NAMES = $$PWD/html/HTMLTagNames.in
XML_NAMES = $$PWD/xml/xmlattrs.in
@@ -777,6 +784,30 @@
colordata.depends = $$PWD/make-hash-tools.pl
addExtraCompiler(colordata)
+contains(DEFINES, ENABLE_XSLT=1) {
+contains(DEFINES, WTF_USE_LIBXML2=1) {
+# GENERATOR 8-D:
+xmlviewercss.output = $${WC_GENERATED_SOURCES_DIR}/XMLViewerCSS.h
+xmlviewercss.input = XMLVIEWER_CSS
+xmlviewercss.wkScript = $$PWD/inspector/xxd.pl
+xmlviewercss.commands = perl $$xmlviewercss.wkScript XMLViewer_css $$XMLVIEWER_CSS $${WC_GENERATED_SOURCES_DIR}/XMLViewerCSS.h
+xmlviewercss.clean = ${QMAKE_FILE_OUT}
+xmlviewercss.depends = $$PWD/inspector/xxd.pl
+xmlviewercss.wkAddOutputToSources = false
+addExtraCompiler(xmlviewercss)
+
+# GENERATOR 8-E:
+xmlviewerjs.output = $${WC_GENERATED_SOURCES_DIR}/XMLViewerJS.h
+xmlviewerjs.input = XMLVIEWER_JS
+xmlviewerjs.wkScript = $$PWD/inspector/xxd.pl
+xmlviewerjs.commands = perl $$xmlviewerjs.wkScript XMLViewer_js $$XMLVIEWER_JS $${WC_GENERATED_SOURCES_DIR}/XMLViewerJS.h
+xmlviewerjs.clean = ${QMAKE_FILE_OUT}
+xmlviewerjs.depends = $$PWD/inspector/xxd.pl
+xmlviewerjs.wkAddOutputToSources = false
+addExtraCompiler(xmlviewerjs)
+}
+}
+
# GENERATOR 9:
stylesheets.wkScript = $$PWD/css/make-css-file-arrays.pl
stylesheets.output = $${WC_GENERATED_SOURCES_DIR}/UserAgentStyleSheetsData.cpp
Modified: trunk/Source/WebCore/WebCore.pri (89515 => 89516)
--- trunk/Source/WebCore/WebCore.pri 2011-06-23 01:34:11 UTC (rev 89515)
+++ trunk/Source/WebCore/WebCore.pri 2011-06-23 01:36:42 UTC (rev 89516)
@@ -167,9 +167,17 @@
}
contains(DEFINES, ENABLE_XSLT=1) {
-QT *= xmlpatterns
+contains(DEFINES, WTF_USE_LIBXML2=1) {
+PKGCONFIG += li
[webkit-changes] [89515] trunk/Tools
Title: [89515] trunk/Tools
Revision 89515
Author mr...@apple.com
Date 2011-06-22 18:34:11 -0700 (Wed, 22 Jun 2011)
Log Message
TestWebKitAPI Xcode project has bogus settings since r86287
Reviewed by David Levin.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
be relative to the built products directory rather than using a hard-coded path. Remove the
explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
rather than in the .xcodeproj directly.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Diff
Modified: trunk/Tools/ChangeLog (89514 => 89515)
--- trunk/Tools/ChangeLog 2011-06-23 01:27:19 UTC (rev 89514)
+++ trunk/Tools/ChangeLog 2011-06-23 01:34:11 UTC (rev 89515)
@@ -1,3 +1,15 @@
+2011-06-22 Mark Rowe
+
+Reviewed by David Levin.
+
+ TestWebKitAPI Xcode project has bogus settings since r86287
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
+be relative to the built products directory rather than using a hard-coded path. Remove the
+explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
+as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
+rather than in the .xcodeproj directly.
+
2011-06-22 Dirk Pranke
Reviewed by Ojan Vafai.
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (89514 => 89515)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2011-06-23 01:27:19 UTC (rev 89514)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2011-06-23 01:34:11 UTC (rev 89515)
@@ -174,7 +174,7 @@
C0ADBE8412FCA6B600D2C129 /* simple-form.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "simple-form.html"; sourceTree = ""; };
C0BD669C131D3CF700E18F2A /* ResponsivenessTimerDoesntFireEarly.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ResponsivenessTimerDoesntFireEarly.cpp; sourceTree = ""; };
C0BD669E131D3CFF00E18F2A /* ResponsivenessTimerDoesntFireEarly_Bundle.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ResponsivenessTimerDoesntFireEarly_Bundle.cpp; sourceTree = ""; };
- F3FC3EE213678B7300126A65 /* libgtest.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; name = libgtest.a; path = ../../WebKitBuild/Debug/libgtest.a; sourceTree = SOURCE_ROOT; };
+ F3FC3EE213678B7300126A65 /* libgtest.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; path = libgtest.a; sourceTree = BUILT_PRODUCTS_DIR; };
F6F3F29013342FEB00A6BF19 /* CookieManager.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CookieManager.cpp; sourceTree = ""; };
/* End PBXFileReference section */
@@ -506,15 +506,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = BC90958012554CF900083756 /* TestWebKitAPI.xcconfig */;
buildSettings = {
-FRAMEWORK_SEARCH_PATHS = "$(inherited)";
-HEADER_SEARCH_PATHS = (
- ../../Source/ThirdParty/gtest/include,
- "$(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders",
-);
-LIBRARY_SEARCH_PATHS = (
- "$(inherited)",
- "\"$(SRCROOT)/../../WebKitBuild/Debug\"",
-);
};
name = Debug;
};
@@ -522,15 +513,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = BC90958012554CF900083756 /* TestWebKitAPI.xcconfig */;
buildSettings = {
-FRAMEWORK_SEARCH_PATHS = "$(inherited)";
-HEADER_SEARCH_PATHS = (
- ../../Source/ThirdParty/gtest/include,
- "$(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders",
-);
-LIBRARY_SEARCH_PATHS = (
- "$(inherited)",
- "\"$(SRCROOT)/../../WebKitBuild/Release\"",
-);
};
name = Release;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89514] trunk/Source/WebCore
Title: [89514] trunk/Source/WebCore
Revision 89514
Author rn...@webkit.org
Date 2011-06-22 18:27:19 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Ryosuke Niwa
Yet another build fix after r89472.
* html/parser/HTMLFormattingElementList.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLFormattingElementList.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89513 => 89514)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 01:20:45 UTC (rev 89513)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 01:27:19 UTC (rev 89514)
@@ -1,5 +1,11 @@
2011-06-22 Ryosuke Niwa
+Yet another build fix after r89472.
+
+* html/parser/HTMLFormattingElementList.cpp:
+
+2011-06-22 Ryosuke Niwa
+
Another build fix after r89472.
* dom/DocumentMarkerController.cpp:
Modified: trunk/Source/WebCore/html/parser/HTMLFormattingElementList.cpp (89513 => 89514)
--- trunk/Source/WebCore/html/parser/HTMLFormattingElementList.cpp 2011-06-23 01:20:45 UTC (rev 89513)
+++ trunk/Source/WebCore/html/parser/HTMLFormattingElementList.cpp 2011-06-23 01:27:19 UTC (rev 89514)
@@ -29,6 +29,10 @@
#include "Element.h"
#include "NotImplemented.h"
+#ifndef NDEBUG
+#include
+#endif
+
namespace WebCore {
HTMLFormattingElementList::HTMLFormattingElementList()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89513] trunk/Source/WebCore
Title: [89513] trunk/Source/WebCore
Revision 89513
Author rn...@webkit.org
Date 2011-06-22 18:20:45 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Ryosuke Niwa
Another build fix after r89472.
* dom/DocumentMarkerController.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DocumentMarkerController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89512 => 89513)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 01:17:31 UTC (rev 89512)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 01:20:45 UTC (rev 89513)
@@ -1,5 +1,11 @@
2011-06-22 Ryosuke Niwa
+Another build fix after r89472.
+
+* dom/DocumentMarkerController.cpp:
+
+2011-06-22 Ryosuke Niwa
+
Build fix after r89472.
* css/CSSStyleDeclaration.cpp:
Modified: trunk/Source/WebCore/dom/DocumentMarkerController.cpp (89512 => 89513)
--- trunk/Source/WebCore/dom/DocumentMarkerController.cpp 2011-06-23 01:17:31 UTC (rev 89512)
+++ trunk/Source/WebCore/dom/DocumentMarkerController.cpp 2011-06-23 01:20:45 UTC (rev 89513)
@@ -33,6 +33,10 @@
#include "RenderedDocumentMarker.h"
#include "TextIterator.h"
+#ifndef NDEBUG
+#include
+#endif
+
namespace WebCore {
inline bool DocumentMarkerController::possiblyHasMarkers(DocumentMarker::MarkerTypes types)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89512] trunk/Tools
Title: [89512] trunk/Tools
Revision 89512
Author dpra...@chromium.org
Date 2011-06-22 18:17:31 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Dirk Pranke
Reviewed by Ojan Vafai.
new-run-webkit-tests: remove obsolete port.shut_down_http_server method
https://bugs.webkit.org/show_bug.cgi?id=59993
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/gtk.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/win.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py
Property Changed
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
Diff
Modified: trunk/Tools/ChangeLog (89511 => 89512)
--- trunk/Tools/ChangeLog 2011-06-23 01:15:41 UTC (rev 89511)
+++ trunk/Tools/ChangeLog 2011-06-23 01:17:31 UTC (rev 89512)
@@ -1,3 +1,21 @@
+2011-06-22 Dirk Pranke
+
+Reviewed by Ojan Vafai.
+
+new-run-webkit-tests: remove obsolete port.shut_down_http_server method
+https://bugs.webkit.org/show_bug.cgi?id=59993
+
+* Scripts/webkitpy/layout_tests/port/base.py:
+* Scripts/webkitpy/layout_tests/port/base_unittest.py:
+* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
+* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
+* Scripts/webkitpy/layout_tests/port/chromium_win.py:
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+* Scripts/webkitpy/layout_tests/port/mac.py:
+* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
+* Scripts/webkitpy/layout_tests/port/qt.py:
+* Scripts/webkitpy/layout_tests/port/win.py:
+
2011-06-22 Luke Macpherson
Reviewed by Andreas Kling.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (89511 => 89512)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-06-23 01:15:41 UTC (rev 89511)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-06-23 01:17:31 UTC (rev 89512)
@@ -912,13 +912,6 @@
This is likely used only by wdiff_text()"""
raise NotImplementedError('Port._path_to_wdiff')
-def _shut_down_http_server(self, pid):
-"""Forcefully and synchronously kills the web server.
-
-This routine should only be called from http_server.py or its
-subclasses."""
-raise NotImplementedError('Port._shut_down_http_server')
-
def _webkit_baseline_path(self, platform):
"""Return the full path to the top of the baseline tree for a
given platform."""
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py (89511 => 89512)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py 2011-06-23 01:15:41 UTC (rev 89511)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py 2011-06-23 01:17:31 UTC (rev 89512)
@@ -288,7 +288,6 @@
self.assertVirtual(port._path_to_lighttpd_modules)
self.assertVirtual(port._path_to_lighttpd_php)
self.assertVirtual(port._path_to_wdiff)
-self.assertVirtual(port._shut_down_http_server, None)
def test_virtual_driver_method(self):
self.assertRaises(NotImplementedError, base.Driver, base.Port(),
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py (89511 => 89512)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py 2011-06-23 01:15:41 UTC (rev 89511)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py 2011-06-23 01:17:31 UTC (rev 89512)
@@ -30,8 +30,6 @@
"""Chromium Linux implementation of the Port interface."""
import logging
-import os
-import signal
import chromium
@@ -204,27 +202,3 @@
def _is_redhat_based(self):
return self._filesystem.exists(self._filesystem.join('/etc', 'redhat-release'))
-
-def _shut_down_http_server(self, server_pid):
-"""Shut down the lighttpd web server. Blocks until it's fully
-shut down.
-
-Args:
-server_pid: The process ID of the running server.
-"""
-# server_pid is not set whe
[webkit-changes] [89511] trunk/LayoutTests
Title: [89511] trunk/LayoutTests Revision 89511 Author mdela...@apple.com Date 2011-06-22 18:15:41 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Matthew Delaney Reviewed by James Robinson. Fixing test spanOverlapsCanvas.html to properly use layer tree text and rebaselining test off that for windows and mac. https://bugs.webkit.org/show_bug.cgi?id=63190 * compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt. * compositing/layer-creation/spanOverlapsCanvas.html: * platform/mac-snowleopard/compositing: Added. * platform/mac-snowleopard/compositing/layer-creation: Added. * platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added. * platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed. * platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html trunk/LayoutTests/platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt Added Paths trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas-expected.txt trunk/LayoutTests/platform/mac-snowleopard/compositing/ trunk/LayoutTests/platform/mac-snowleopard/compositing/layer-creation/ trunk/LayoutTests/platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt Removed Paths trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (89510 => 89511) --- trunk/LayoutTests/ChangeLog 2011-06-23 01:10:25 UTC (rev 89510) +++ trunk/LayoutTests/ChangeLog 2011-06-23 01:15:41 UTC (rev 89511) @@ -1,3 +1,18 @@ +2011-06-22 Matthew Delaney + +Reviewed by James Robinson. + +Fixing test spanOverlapsCanvas.html to properly use layer tree text and rebaselining test off that for windows and mac. +https://bugs.webkit.org/show_bug.cgi?id=63190 + +* compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt. +* compositing/layer-creation/spanOverlapsCanvas.html: +* platform/mac-snowleopard/compositing: Added. +* platform/mac-snowleopard/compositing/layer-creation: Added. +* platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added. +* platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Removed. +* platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: + 2011-06-22 Mark Pilgrim Reviewed by Adam Barth. Copied: trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas-expected.txt (from rev 89495, trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt) (0 => 89511) --- trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas-expected.txt (rev 0) +++ trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas-expected.txt 2011-06-23 01:15:41 UTC (rev 89511) @@ -0,0 +1,21 @@ +(GraphicsLayer + (bounds 800.00 600.00) + (children 1 +(GraphicsLayer + (bounds 800.00 600.00) + (children 2 +(GraphicsLayer + (position 8.00 8.00) + (bounds 100.00 50.00) + (drawsContent 1) +) +(GraphicsLayer + (position 8.00 8.00) + (bounds 100.00 50.00) + (drawsContent 1) +) + ) +) + ) +) + Modified: trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html (89510 => 89511) --- trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html 2011-06-23 01:10:25 UTC (rev 89510) +++ trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html 2011-06-23 01:15:41 UTC (rev 89511) @@ -5,26 +5,38 @@- window.layoutTestController && window.layoutTestController.layerTreeAsText();function init() { var ctx = document.getElementById("world").getContext("2d"); ctx.fillStyle = "red"; ctx.fillRect(0,0,ctx.canvas.width,ctx.canvas.height); + +if (window.layoutTestController) { +window.layoutTestController.dumpAsText(true); +var console = document.getElementById("layeroutput"); +console.innerHTML = window.layoutTestController.layerTreeAsText(); +} }-#headerbar {+#output +{ width: 100px; height: 50px;
[webkit-changes] [89510] trunk/Tools
Title: [89510] trunk/Tools
Revision 89510
Author macpher...@chromium.org
Date 2011-06-22 18:10:25 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Luke Macpherson
Reviewed by Andreas Kling.
Move macpherson from contributor list to committer list.
https://bugs.webkit.org/show_bug.cgi?id=63179
* Scripts/webkitpy/common/config/committers.py:
Move macpherson from contributor list to committer list.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/ChangeLog (89509 => 89510)
--- trunk/Tools/ChangeLog 2011-06-23 01:07:19 UTC (rev 89509)
+++ trunk/Tools/ChangeLog 2011-06-23 01:10:25 UTC (rev 89510)
@@ -1,3 +1,13 @@
+2011-06-22 Luke Macpherson
+
+Reviewed by Andreas Kling.
+
+Move macpherson from contributor list to committer list.
+https://bugs.webkit.org/show_bug.cgi?id=63179
+
+* Scripts/webkitpy/common/config/committers.py:
+Move macpherson from contributor list to committer list.
+
2011-06-22 David Levin
Reviewed by Adam Barth.
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (89509 => 89510)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-06-23 01:07:19 UTC (rev 89509)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-06-23 01:10:25 UTC (rev 89510)
@@ -83,7 +83,6 @@
Contributor("Ian Hickson", "i...@hixie.ch", "hixie"),
Contributor("John Bates", ["jba...@google.com", "jba...@chromium.org"], "jbates"),
Contributor("John Bauman", ["jbau...@chromium.org", "jbau...@google.com"], "jbauman"),
-Contributor("Luke Macpherson", ["macpher...@chromium.org", "macpher...@google.com"], "macpherson"),
Contributor("Naoki Takano", "takano.na...@gmail.com", "honten"),
Contributor("Nat Duca", ["nd...@chromium.org", "nd...@google.com"], "nduca"),
Contributor("Pierre Rossi", "pierre.ro...@gmail.com", "elproxy"),
@@ -206,6 +205,7 @@
Committer("Lucas De Marchi", ["demar...@webkit.org", "lucas.demar...@profusion.mobi"], "demarchi"),
Committer("Lucas Forschler", ["lforsch...@apple.com"], "lforschler"),
Committer("Luiz Agostini", ["l...@webkit.org", "luiz.agost...@openbossa.org"], "lca"),
+Committer("Luke Macpherson", ["macpher...@chromium.org", "macpher...@google.com"], "macpherson"),
Committer("Mads Ager", "a...@chromium.org"),
Committer("Mahesh Kulkarni", "mahesh.kulka...@nokia.com", "maheshk"),
Committer("Marcus Voltis Bulach", "bul...@chromium.org"),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89509] trunk
Title: [89509] trunk
Revision 89509
Author commit-qu...@webkit.org
Date 2011-06-22 18:07:19 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Ryuan Choi
Reviewed by Antonio Gomes.
[EFL] Add an option to enable Device Orientation Event.
https://bugs.webkit.org/show_bug.cgi?id=63120
ADD ENABLE_DEVICE_ORIENTATION.
* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:
2011-06-22 Ryuan Choi
Reviewed by Antonio Gomes.
[EFL] Add an option to enable Device Orientation Event.
https://bugs.webkit.org/show_bug.cgi?id=63120
* CMakeListsEfl.txt: Add files to build with ENABLE_DEVICE_ORIENTATION.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Create DeviceOrientationClientEfl and DeviceMotionClientEfl.
Modified Paths
trunk/ChangeLog
trunk/Source/WebKit/efl/CMakeListsEfl.txt
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
trunk/Source/cmake/OptionsEfl.cmake
trunk/Source/cmakeconfig.h.cmake
Diff
Modified: trunk/ChangeLog (89508 => 89509)
--- trunk/ChangeLog 2011-06-23 01:05:17 UTC (rev 89508)
+++ trunk/ChangeLog 2011-06-23 01:07:19 UTC (rev 89509)
@@ -1,3 +1,15 @@
+2011-06-22 Ryuan Choi
+
+Reviewed by Antonio Gomes.
+
+[EFL] Add an option to enable Device Orientation Event.
+https://bugs.webkit.org/show_bug.cgi?id=63120
+
+ADD ENABLE_DEVICE_ORIENTATION.
+
+* Source/cmake/OptionsEfl.cmake:
+* Source/cmakeconfig.h.cmake:
+
2011-06-22 Nate Chapin
Reviewed by Adam Barth.
Modified: trunk/Source/WebKit/efl/CMakeListsEfl.txt (89508 => 89509)
--- trunk/Source/WebKit/efl/CMakeListsEfl.txt 2011-06-23 01:05:17 UTC (rev 89508)
+++ trunk/Source/WebKit/efl/CMakeListsEfl.txt 2011-06-23 01:07:19 UTC (rev 89509)
@@ -50,6 +50,8 @@
LIST(APPEND WebKit_SOURCES
efl/WebCoreSupport/ChromeClientEfl.cpp
+efl/WebCoreSupport/DeviceOrientationClientEfl.cpp
+efl/WebCoreSupport/DeviceMotionClientEfl.cpp
efl/WebCoreSupport/DragClientEfl.cpp
efl/WebCoreSupport/EditorClientEfl.cpp
efl/WebCoreSupport/FrameLoaderClientEfl.cpp
Modified: trunk/Source/WebKit/efl/ChangeLog (89508 => 89509)
--- trunk/Source/WebKit/efl/ChangeLog 2011-06-23 01:05:17 UTC (rev 89508)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-06-23 01:07:19 UTC (rev 89509)
@@ -2,6 +2,17 @@
Reviewed by Antonio Gomes.
+[EFL] Add an option to enable Device Orientation Event.
+https://bugs.webkit.org/show_bug.cgi?id=63120
+
+* CMakeListsEfl.txt: Add files to build with ENABLE_DEVICE_ORIENTATION.
+* ewk/ewk_view.cpp:
+(_ewk_view_priv_new): Create DeviceOrientationClientEfl and DeviceMotionClientEfl.
+
+2011-06-22 Ryuan Choi
+
+Reviewed by Antonio Gomes.
+
[EFL] Add DeviceOrientationClientEfl and DeviceMotionClientEfl.
https://bugs.webkit.org/show_bug.cgi?id=63125
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (89508 => 89509)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-06-23 01:05:17 UTC (rev 89508)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-06-23 01:07:19 UTC (rev 89509)
@@ -52,6 +52,11 @@
#include
#include
+#if ENABLE(DEVICE_ORIENTATION)
+#include "DeviceMotionClientEfl.h"
+#include "DeviceOrientationClientEfl.h"
+#endif
+
#define ZOOM_MIN (0.05)
#define ZOOM_MAX (4.0)
@@ -543,6 +548,10 @@
pageClients.editorClient = static_cast(new WebCore::EditorClientEfl(sd->self));
pageClients.dragClient = static_cast(new WebCore::DragClientEfl);
pageClients.inspectorClient = static_cast(new WebCore::InspectorClientEfl);
+#if ENABLE(DEVICE_ORIENTATION)
+pageClients.deviceMotionClient = static_cast(new WebCore::DeviceMotionClientEfl);
+pageClients.deviceOrientationClient = static_cast(new WebCore::DeviceOrientationClientEfl);
+#endif
priv->page = new WebCore::Page(pageClients);
if (!priv->page) {
CRITICAL("Could not create WebKit Page");
Modified: trunk/Source/cmake/OptionsEfl.cmake (89508 => 89509)
--- trunk/Source/cmake/OptionsEfl.cmake 2011-06-23 01:05:17 UTC (rev 89508)
+++ trunk/Source/cmake/OptionsEfl.cmake 2011-06-23 01:07:19 UTC (rev 89509)
@@ -66,6 +66,7 @@
WEBKIT_FEATURE(ENABLE_DATAGRID "Enable datagrid" DEFAULT OFF)
WEBKIT_FEATURE(ENABLE_DATALIST "Enable datalist" DEFAULT ON HTML)
WEBKIT_FEATURE(ENABLE_DATA_TRANSFER_ITEMS "Enable data transfer items" DEFAULT OFF)
+WEBKIT_FEATURE(ENABLE_DEVICE_ORIENTATION "Enable device orientation" DEFAULT OFF)
WEBKIT_FEATURE(ENABLE_DOM_STORAGE "Enable DOM storage" DEFAULT ON)
WEBKIT_FEATURE(ENABLE_EVENTSOURCE "Enable event source" DEFAULT ON)
WEBKIT_FEATURE(ENABLE_FAST_MALLOC "Enable TCmalloc instead of system's allocator" DEFAULT ON)
Modified: trunk/Source/cmakeconfig.h.cmake (89508 => 89509)
--- trunk/Source/cmakeconfig.h.cmake 2011-06-23 01:05:17 UTC (rev 89508)
+++ trunk/Source/cmakeconfig.h.cmake 2011-06-23 01:07:19 UTC (rev 89509)
@@ -12,6 +12,7 @
[webkit-changes] [89508] trunk/Tools
Title: [89508] trunk/Tools
Revision 89508
Author le...@chromium.org
Date 2011-06-22 18:05:17 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 David Levin
Reviewed by Adam Barth.
check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
https://bugs.webkit.org/show_bug.cgi?id=63204
* Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
with similar code for the parameter checking.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
those done for single lines since they don't make sense in that case (variable decls look like function decls).
Removed some redundant comments (one of which was slightly wrong).
Added checks for the new functionality and minor other test changes.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (89507 => 89508)
--- trunk/Tools/ChangeLog 2011-06-23 01:05:09 UTC (rev 89507)
+++ trunk/Tools/ChangeLog 2011-06-23 01:05:17 UTC (rev 89508)
@@ -1,3 +1,17 @@
+2011-06-22 David Levin
+
+Reviewed by Adam Barth.
+
+check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
+https://bugs.webkit.org/show_bug.cgi?id=63204
+
+* Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
+ with similar code for the parameter checking.
+* Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
+ those done for single lines since they don't make sense in that case (variable decls look like function decls).
+ Removed some redundant comments (one of which was slightly wrong).
+ Added checks for the new functionality and minor other test changes.
+
2011-06-22 Nate Chapin
Reviewed by Adam Barth.
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (89507 => 89508)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-06-23 01:05:09 UTC (rev 89507)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-06-23 01:05:17 UTC (rev 89508)
@@ -1566,6 +1566,24 @@
return True
+def check_function_definition_and_pass_ptr(type_text, row, location_description, error):
+"""Check that function definitions for use Pass*Ptr instead of *Ptr.
+
+Args:
+ type_text: A string containing the type. (For return values, it may contain more than the type.)
+ row: The row number of the type.
+ location_description: Used to indicate where the type is. This is either 'parameter' or 'return'.
+ error: The function to call with any errors found.
+"""
+match_ref_or_own_ptr = '(?=\W|^)(Ref|Own)Ptr(?=\W)'
+bad_type_usage = search(match_ref_or_own_ptr, type_text)
+if not bad_type_usage:
+return
+type_name = bad_type_usage.group(0)
+error(row, 'readability/pass_ptr', 5,
+ 'The %s type should use Pass%s instead of %s.' % (location_description, type_name, type_name))
+
+
def check_function_definition(filename, file_extension, clean_lines, line_number, function_state, error):
"""Check that function definitions for style issues.
@@ -1597,13 +1615,11 @@
error(function_state.function_name_start_position.row, 'readability/webkit_api', 5,
'WEBKIT_API should not be used with a pure virtual function.')
+check_function_definition_and_pass_ptr(modifiers_and_return_type, function_state.function_name_start_position.row, 'return', error)
+
parameter_list = function_state.parameter_list()
for parameter in parameter_list:
-bad_parameter_type = search('(?=\W|^)(Ref|Own)Ptr(?=\W)', parameter.type)
-if bad_parameter_type:
-type_name = bad_parameter_type.group(0)
-error(parameter.row, 'readability/pass_ptr', 5,
- 'The parameter type should use Pass%s instead of %s.' % (type_name, type_name))
+check_function_definition_and_pass_ptr(parameter.type, parameter.row, 'parameter', error)
# Do checks specific to function declarations and parameter names.
if not function_state.is_declaration or not parameter.name:
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (89507 => 89508)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-06-23 01:05:09 UTC (rev 89507)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-06-23 01:05:17 UTC (rev 89508)
@@ -259,6 +259,7 @@
'-legal/copyright',
'-readability/fn_size',
'-readability/parameter_name',
+ '-readability/pass_ptr',
'-whitespace/ending_newline')
return self.perform_lint(code,
[webkit-changes] [89507] trunk/Source/WebCore
Title: [89507] trunk/Source/WebCore Revision 89507 Author rn...@webkit.org Date 2011-06-22 18:05:09 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Ryosuke Niwa Build fix after r89472. * css/CSSStyleDeclaration.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSStyleDeclaration.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (89506 => 89507) --- trunk/Source/WebCore/ChangeLog 2011-06-23 00:57:42 UTC (rev 89506) +++ trunk/Source/WebCore/ChangeLog 2011-06-23 01:05:09 UTC (rev 89507) @@ -1,3 +1,9 @@ +2011-06-22 Ryosuke Niwa + +Build fix after r89472. + +* css/CSSStyleDeclaration.cpp: + 2011-06-22 Mark Pilgrim Reviewed by Adam Barth. Modified: trunk/Source/WebCore/css/CSSStyleDeclaration.cpp (89506 => 89507) --- trunk/Source/WebCore/css/CSSStyleDeclaration.cpp 2011-06-23 00:57:42 UTC (rev 89506) +++ trunk/Source/WebCore/css/CSSStyleDeclaration.cpp 2011-06-23 01:05:09 UTC (rev 89507) @@ -31,6 +31,9 @@ #include "SVGElement.h" #include #include +#ifndef NDEBUG +#include +#endif using namespace WTF; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89506] trunk
Title: [89506] trunk
Revision 89506
Author commit-qu...@webkit.org
Date 2011-06-22 17:57:42 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Mark Pilgrim
Reviewed by Adam Barth.
IndexedDB open (database) should NOT throw if name is null
https://bugs.webkit.org/show_bug.cgi?id=63110
* storage/indexeddb/database-name-undefined-expected.txt:
* storage/indexeddb/database-name-undefined.html: removed some code here
because it's duplicated in the mozilla/open-database-null-name test
* storage/indexeddb/mozilla/open-database-null-name-expected.txt:
* storage/indexeddb/mozilla/open-database-null-name.html: fixed expected
behavior (db.name ends up as four-character string "null")
2011-06-22 Mark Pilgrim
Reviewed by Adam Barth.
IndexedDB open (database) should NOT throw if name is null
https://bugs.webkit.org/show_bug.cgi?id=63110
* storage/IDBFactory.idl: remove ConvertNullToNullString flag on
name argument, let IDL code generator stringify null value to "null"
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/database-name-undefined-expected.txt
trunk/LayoutTests/storage/indexeddb/database-name-undefined.html
trunk/LayoutTests/storage/indexeddb/mozilla/open-database-null-name-expected.txt
trunk/LayoutTests/storage/indexeddb/mozilla/open-database-null-name.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBFactory.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (89505 => 89506)
--- trunk/LayoutTests/ChangeLog 2011-06-23 00:45:26 UTC (rev 89505)
+++ trunk/LayoutTests/ChangeLog 2011-06-23 00:57:42 UTC (rev 89506)
@@ -1,3 +1,17 @@
+2011-06-22 Mark Pilgrim
+
+Reviewed by Adam Barth.
+
+IndexedDB open (database) should NOT throw if name is null
+https://bugs.webkit.org/show_bug.cgi?id=63110
+
+* storage/indexeddb/database-name-undefined-expected.txt:
+* storage/indexeddb/database-name-undefined.html: removed some code here
+because it's duplicated in the mozilla/open-database-null-name test
+* storage/indexeddb/mozilla/open-database-null-name-expected.txt:
+* storage/indexeddb/mozilla/open-database-null-name.html: fixed expected
+behavior (db.name ends up as four-character string "null")
+
2011-06-22 Nate Chapin
Reviewed by Adam Barth.
Modified: trunk/LayoutTests/storage/indexeddb/database-name-undefined-expected.txt (89505 => 89506)
--- trunk/LayoutTests/storage/indexeddb/database-name-undefined-expected.txt 2011-06-23 00:45:26 UTC (rev 89505)
+++ trunk/LayoutTests/storage/indexeddb/database-name-undefined-expected.txt 2011-06-23 00:57:42 UTC (rev 89506)
@@ -12,7 +12,6 @@
IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;
PASS IDBKeyRange == null is false
PASS indexedDB.open(); threw exception TypeError: Not enough arguments.
-PASS indexedDB.open(null); threw exception Error: NON_TRANSIENT_ERR: DOM IDBDatabase Exception 2.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/storage/indexeddb/database-name-undefined.html (89505 => 89506)
--- trunk/LayoutTests/storage/indexeddb/database-name-undefined.html 2011-06-23 00:45:26 UTC (rev 89505)
+++ trunk/LayoutTests/storage/indexeddb/database-name-undefined.html 2011-06-23 00:57:42 UTC (rev 89506)
@@ -27,7 +27,6 @@
shouldBeFalse("IDBKeyRange == null");
shouldThrow("indexedDB.open();");
-shouldThrow("indexedDB.open(null);");
done();
}
Modified: trunk/LayoutTests/storage/indexeddb/mozilla/open-database-null-name-expected.txt (89505 => 89506)
--- trunk/LayoutTests/storage/indexeddb/mozilla/open-database-null-name-expected.txt 2011-06-23 00:45:26 UTC (rev 89505)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/open-database-null-name-expected.txt 2011-06-23 00:57:42 UTC (rev 89506)
@@ -1,4 +1,4 @@
-Test IndexedDB: should throw when opening a database with a null name
+Test IndexedDB: should NOT throw when opening a database with a null name
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
@@ -9,9 +9,9 @@
PASS IDBDatabaseException == null is false
IDBTransaction = window.IDBTransaction || window.webkitIDBTransaction;
PASS IDBTransaction == null is false
-Expecting exception from indexedDB.open(null, description)
-PASS Exception was thrown.
-PASS code is IDBDatabaseException.NON_TRANSIENT_ERR
+indexedDB.open(null);
+db = event.target.result
+PASS db.name is 'null'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/storage/indexeddb/mozilla/open-database-null-name.html (89505 => 89506)
--- trunk/LayoutTests/storage/indexeddb/mozilla/open-database-null-name.html 2011-06-23 00:45:26 UTC (rev 89505)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/open-database-null-name.html 2011-06-23 00:57:42 UTC (rev 89506)
@@ -17,7 +17,7 @@
[webkit-changes] [89505] trunk/Source/WebCore
Title: [89505] trunk/Source/WebCore
Revision 89505
Author rn...@webkit.org
Date 2011-06-22 17:45:26 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Ryosuke Niwa
Reviewed by Darin Adler.
Add a Position constructor that takes (Text*, unsigned offset)
https://bugs.webkit.org/show_bug.cgi?id=63181
Added Position::Position(PassRefPtr, unsigned offset) and deployed in a couple of places
by replacing the calls to the old constructor.
* dom/Position.cpp:
(WebCore::Position::Position): Added.
* dom/Position.h:
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::replaceSelectedTextInNode): Calls new constructor; extracted
from InsertTextCommand::performTrivialReplace and ReplaceSelectionCommand::performTrivialReplace.
(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Calls new constructor
* editing/CompositeEditCommand.h:
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::performTrivialReplace): Calls replaceSelectedTextInNode.
(WebCore::InsertTextCommand::input): Calls new constructor.
(WebCore::InsertTextCommand::insertTab): Use RefPtr instead of a raw pointer.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::performTrivialReplace): Calls replaceSelectedTextInNode.
* editing/visible_units.cpp:
(WebCore::startPositionForLine): Calls new constructor.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex): Calls new constructor; calls endPosition
on Range instead of avoid manually constructing a VisiblePosition out of endContainer and endOffset.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp
trunk/Source/WebCore/dom/Position.h
trunk/Source/WebCore/editing/CompositeEditCommand.cpp
trunk/Source/WebCore/editing/CompositeEditCommand.h
trunk/Source/WebCore/editing/InsertTextCommand.cpp
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp
trunk/Source/WebCore/editing/visible_units.cpp
trunk/Source/WebCore/rendering/RenderTextControl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89504 => 89505)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 00:39:10 UTC (rev 89504)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 00:45:26 UTC (rev 89505)
@@ -1,3 +1,33 @@
+2011-06-22 Ryosuke Niwa
+
+Reviewed by Darin Adler.
+
+Add a Position constructor that takes (Text*, unsigned offset)
+https://bugs.webkit.org/show_bug.cgi?id=63181
+
+Added Position::Position(PassRefPtr, unsigned offset) and deployed in a couple of places
+by replacing the calls to the old constructor.
+
+* dom/Position.cpp:
+(WebCore::Position::Position): Added.
+* dom/Position.h:
+* editing/CompositeEditCommand.cpp:
+(WebCore::CompositeEditCommand::replaceSelectedTextInNode): Calls new constructor; extracted
+from InsertTextCommand::performTrivialReplace and ReplaceSelectionCommand::performTrivialReplace.
+(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Calls new constructor
+* editing/CompositeEditCommand.h:
+* editing/InsertTextCommand.cpp:
+(WebCore::InsertTextCommand::performTrivialReplace): Calls replaceSelectedTextInNode.
+(WebCore::InsertTextCommand::input): Calls new constructor.
+(WebCore::InsertTextCommand::insertTab): Use RefPtr instead of a raw pointer.
+* editing/ReplaceSelectionCommand.cpp:
+(WebCore::ReplaceSelectionCommand::performTrivialReplace): Calls replaceSelectedTextInNode.
+* editing/visible_units.cpp:
+(WebCore::startPositionForLine): Calls new constructor.
+* rendering/RenderTextControl.cpp:
+(WebCore::RenderTextControl::visiblePositionForIndex): Calls new constructor; calls endPosition
+on Range instead of avoid manually constructing a VisiblePosition out of endContainer and endOffset.
+
2011-06-22 Adam Barth
Reviewed by Darin Fisher.
Modified: trunk/Source/WebCore/dom/Position.cpp (89504 => 89505)
--- trunk/Source/WebCore/dom/Position.cpp 2011-06-23 00:39:10 UTC (rev 89504)
+++ trunk/Source/WebCore/dom/Position.cpp 2011-06-23 00:45:26 UTC (rev 89505)
@@ -103,6 +103,15 @@
ASSERT(anchorType == PositionIsOffsetInAnchor);
}
+Position::Position(PassRefPtr textNode, unsigned offset)
+: m_anchorNode(textNode)
+, m_offset(static_cast(offset))
+, m_anchorType(PositionIsOffsetInAnchor)
+, m_isLegacyEditingPosition(false)
+{
+ASSERT(m_anchorNode);
+}
+
void Position::moveToPosition(PassRefPtr node, int offset)
{
ASSERT(!editingIgnoresContent(node.get()));
Modified: trunk/Source/WebCore/dom/Position.h (89504 => 89505)
--- trunk/Source/WebCore/dom/Position.h 2011-06-23 00:39:10 UTC (rev 89504)
+++ trunk/Source/WebCore/dom/Position.h
[webkit-changes] [89504] trunk/Source
Title: [89504] trunk/Source
Revision 89504
Author aba...@webkit.org
Date 2011-06-22 17:39:10 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Adam Barth
Reviewed by Darin Fisher.
[Chromium] Add WebDocument APIs for the functions moving from WebFrame
https://bugs.webkit.org/show_bug.cgi?id=62831
* dom/Document.cpp:
(WebCore::Document::openSearchDescriptionURL):
- This function exists to service a Chromium WebKit API, but it's
generally purpose and might be useful to other ports. The
algorithm has some strange early exits, which I've marked with
FIXME comments.
* dom/Document.h:
2011-06-22 Adam Barth
Reviewed by Darin Fisher.
[Chromium] Add WebDocument APIs for the functions moving from WebFrame
https://bugs.webkit.org/show_bug.cgi?id=62831
The next phase will be to change all the callers and then remove all
the code inside the ifdef.
* public/WebDocument.h:
- Add new APIs.
* public/WebFrame.h:
- These two APIs were too disgusting. I could not, in good
conscience, touch them.
* public/WebSecurityOrigin.h:
- Turns out this API is supposed to be on WebSecurityOrigin, not
WebDocument.
* src/WebDocument.cpp:
- Implement the APIs.
(WebKit::WebDocument::url):
(WebKit::WebDocument::securityOrigin):
(WebKit::WebDocument::encoding):
(WebKit::WebDocument::openSearchDescriptionURL):
(WebKit::WebDocument::forms):
(WebKit::WebDocument::insertStyleText):
* src/WebFrameImpl.cpp:
- Change these implements to just be stubs that call into the real
implementations in WebDocument.
(WebKit::WebFrameImpl::url):
(WebKit::WebFrameImpl::openSearchDescriptionURL):
(WebKit::WebFrameImpl::encoding):
(WebKit::WebFrameImpl::forms):
(WebKit::WebFrameImpl::securityOrigin):
(WebKit::WebFrameImpl::grantUniversalAccess):
(WebKit::WebFrameImpl::insertStyleText):
(WebKit::WebFrameImpl::contentAsMarkup):
* src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::grantUniversalAccess):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDocument.h
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/public/WebSecurityOrigin.h
trunk/Source/WebKit/chromium/src/WebDocument.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebSecurityOrigin.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89503 => 89504)
--- trunk/Source/WebCore/ChangeLog 2011-06-23 00:28:56 UTC (rev 89503)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 00:39:10 UTC (rev 89504)
@@ -1,3 +1,18 @@
+2011-06-22 Adam Barth
+
+Reviewed by Darin Fisher.
+
+[Chromium] Add WebDocument APIs for the functions moving from WebFrame
+https://bugs.webkit.org/show_bug.cgi?id=62831
+
+* dom/Document.cpp:
+(WebCore::Document::openSearchDescriptionURL):
+- This function exists to service a Chromium WebKit API, but it's
+ generally purpose and might be useful to other ports. The
+ algorithm has some strange early exits, which I've marked with
+ FIXME comments.
+* dom/Document.h:
+
2011-06-22 Nate Chapin
Reviewed by Adam Barth.
Modified: trunk/Source/WebCore/dom/Document.cpp (89503 => 89504)
--- trunk/Source/WebCore/dom/Document.cpp 2011-06-23 00:28:56 UTC (rev 89503)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-06-23 00:39:10 UTC (rev 89504)
@@ -3950,6 +3950,37 @@
return command(this, commandName).value();
}
+KURL Document::openSearchDescriptionURL()
+{
+static const char* const openSearchMIMEType = "application/opensearchdescription+xml";
+static const char* const openSearchRelation = "search";
+
+// FIXME: Why do only top-level frames have openSearchDescriptionURLs?
+if (!frame() || frame()->tree()->parent())
+return KURL();
+
+// FIXME: Why do we need to wait for FrameStateComplete?
+if (frame()->loader()->state() != FrameStateComplete)
+return KURL();
+
+if (!head())
+return KURL();
+
+RefPtr children = head()->children();
+for (Node* child = children->firstItem(); child; child = children->nextItem()) {
+if (!child->isHTMLElement() || !static_cast(child)->hasTagName(linkTag))
+continue;
+HTMLLinkElement* linkElement = static_cast(child);
+if (!equalIgnoringCase(linkElement->type(), openSearchMIMEType) || !equalIgnoringCase(linkElement->rel(), openSearchRelation))
+continue;
+if (linkElement->href().isEmpty())
+
[webkit-changes] [89503] trunk
Title: [89503] trunk Revision 89503 Author jap...@chromium.org Date 2011-06-22 17:28:56 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Nate Chapin Reviewed by Adam Barth. Add symbols required for window.internals. https://bugs.webkit.org/show_bug.cgi?id=62066 * Source/autotools/symbols.filter: 2011-06-22 Nate Chapin Reviewed by Adam Barth. Test updates for https://bugs.webkit.org/show_bug.cgi?id=62066. * fast/preloader/scan-body-from-head-import.html: Use window.internals. * fast/preloader/scan-body-from-head-script.html: Use window.internals. * http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt: * http/tests/loading/cross-origin-XHR-willLoadRequest.html: * http/tests/loading/preload-append-scan-expected.txt: * http/tests/loading/preload-append-scan.php: Use window.internals. * http/tests/misc/favicon-loads-with-icon-loading-override-expected.txt: * http/tests/misc/link-rel-icon-beforeload-expected.txt: * platform/chromium-linux/fast/preloader/scan-body-from-head-script-expected.txt: Removed. 2011-06-22 Nate Chapin Reviewed by Adam Barth. Don't let all subresources keep isLoadingInAPISense() from returning false, only requests that affect CachedResourceRequest::requestCount(). Also, add a callback to Internals to determine whether a resource has been preloaded. https://bugs.webkit.org/show_bug.cgi?id=62066 * WebCore.exp.in: * dom/Document.cpp: Add m_loadEventFinished. * dom/Document.h: * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense): * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::isPreloaded): * loader/cache/CachedResourceLoader.h: * testing/Internals.cpp: (WebCore::Internals::isPreloaded): * testing/Internals.h: * testing/Internals.idl: 2011-06-22 Nate Chapin Reviewed by Adam Barth. Add win symbols for new window.internals functionality. https://bugs.webkit.org/show_bug.cgi?id=62066 * win/WebKit2.def: 2011-06-22 Nate Chapin Reviewed by Adam Barth. Add libsoup to libWebCoreInternals build. https://bugs.webkit.org/show_bug.cgi?id=62066 * GNUmakefile.am: Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/preloader/scan-body-from-head-import-expected.txt trunk/LayoutTests/fast/preloader/scan-body-from-head-import.html trunk/LayoutTests/fast/preloader/scan-body-from-head-script-expected.txt trunk/LayoutTests/fast/preloader/scan-body-from-head-script.html trunk/LayoutTests/http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt trunk/LayoutTests/http/tests/loading/cross-origin-XHR-willLoadRequest.html trunk/LayoutTests/http/tests/loading/preload-append-scan-expected.txt trunk/LayoutTests/http/tests/loading/preload-append-scan.php trunk/LayoutTests/http/tests/misc/favicon-loads-with-icon-loading-override-expected.txt trunk/LayoutTests/http/tests/misc/link-rel-icon-beforeload-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/loader/DocumentLoader.cpp trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp trunk/Source/WebCore/loader/cache/CachedResourceLoader.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2.def trunk/Source/autotools/symbols.filter trunk/Tools/ChangeLog trunk/Tools/GNUmakefile.am Removed Paths trunk/LayoutTests/platform/chromium-linux/fast/preloader/scan-body-from-head-script-expected.txt Diff Modified: trunk/ChangeLog (89502 => 89503) --- trunk/ChangeLog 2011-06-23 00:18:39 UTC (rev 89502) +++ trunk/ChangeLog 2011-06-23 00:28:56 UTC (rev 89503) @@ -1,3 +1,12 @@ +2011-06-22 Nate Chapin + +Reviewed by Adam Barth. + +Add symbols required for window.internals. +https://bugs.webkit.org/show_bug.cgi?id=62066 + +* Source/autotools/symbols.filter: + 2011-06-22 Martin Robinson Reviewed by Adam Roben. Modified: trunk/LayoutTests/ChangeLog (89502 => 89503) --- trunk/LayoutTests/ChangeLog 2011-06-23 00:18:39 UTC (rev 89502) +++ trunk/LayoutTests/ChangeLog 2011-06-23 00:28:56 UTC (rev 89503) @@ -1,3 +1,19 @@ +2011-06-22 Nate Chapin + +Reviewed by Adam Barth. + +Test updates for https://bugs.webkit.org/show_bug.cgi?id=62066. + +* fast/preloader/scan-body-from-head-import.html: Use window.internals. +* fast/preloader/scan-body-from-head-script.html: Use window.internals. +* http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt: +* http/tests
[webkit-changes] [89502] trunk/Tools
Title: [89502] trunk/Tools
Revision 89502
Author dpra...@chromium.org
Date 2011-06-22 17:18:39 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Dirk Pranke
Reviewed by Tony Chang.
nrwt: handle missing httpd cleanly
https://bugs.webkit.org/show_bug.cgi?id=62027
We had reverted the change in r89414, so this adds it back in
(modifying check_sys_deps() in port/base.py to check for an
installed web server).
This change then fixes the change in r89414 to stub out the
check_sys_deps() in the test port so that the unit tests run correctly.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/test.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py
Diff
Modified: trunk/Tools/ChangeLog (89501 => 89502)
--- trunk/Tools/ChangeLog 2011-06-23 00:17:08 UTC (rev 89501)
+++ trunk/Tools/ChangeLog 2011-06-23 00:18:39 UTC (rev 89502)
@@ -1,3 +1,20 @@
+2011-06-22 Dirk Pranke
+
+Reviewed by Tony Chang.
+
+nrwt: handle missing httpd cleanly
+https://bugs.webkit.org/show_bug.cgi?id=62027
+
+We had reverted the change in r89414, so this adds it back in
+(modifying check_sys_deps() in port/base.py to check for an
+installed web server).
+
+This change then fixes the change in r89414 to stub out the
+check_sys_deps() in the test port so that the unit tests run correctly.
+
+* Scripts/webkitpy/layout_tests/port/base.py:
+* Scripts/webkitpy/layout_tests/port/test.py:
+
2011-06-22 David Levin
Reviewed by Adam Barth.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (89501 => 89502)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-06-23 00:17:08 UTC (rev 89501)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-06-23 00:18:39 UTC (rev 89502)
@@ -188,6 +188,8 @@
This step can be skipped with --nocheck-sys-deps.
Returns whether the system is properly configured."""
+if needs_http:
+return self.check_httpd()
return True
def check_image_diff(self, override_step=None, logging=True):
@@ -227,6 +229,18 @@
return True
+def check_httpd(self):
+if self.get_option('use_apache'):
+path = self._path_to_apache()
+else:
+path = self._path_to_lighttpd()
+
+try:
+return self._executive.run_command([path, "-v"], return_exit_code=True) == 0
+except OSError, e:
+_log.error("No httpd found. Cannot run http tests.")
+return False
+
def compare_text(self, expected_text, actual_text):
"""Return whether or not the two strings are *not* equal. This
routine is used to diff text output.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py (89501 => 89502)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py 2011-06-23 00:17:08 UTC (rev 89501)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py 2011-06-23 00:18:39 UTC (rev 89502)
@@ -303,6 +303,9 @@
def check_build(self, needs_http):
return True
+def check_sys_deps(self, needs_http):
+return True
+
def default_configuration(self):
return 'Release'
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89501] trunk/Source/WebKit/mac
Title: [89501] trunk/Source/WebKit/mac
Revision 89501
Author wei...@apple.com
Date 2011-06-22 17:17:08 -0700 (Wed, 22 Jun 2011)
Log Message
Roll out r89469 (Add preference for setting the html parser depth limit)
The preference is not needed at this time, so there is no reason to expose it.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (89500 => 89501)
--- trunk/Source/WebKit/mac/ChangeLog 2011-06-23 00:16:03 UTC (rev 89500)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-06-23 00:17:08 UTC (rev 89501)
@@ -1,5 +1,18 @@
2011-06-22 Sam Weinig
+Roll out r89469 (Add preference for setting the html parser depth limit)
+
+The preference is not needed at this time, so there is no reason to expose it.
+
+* WebView/WebPreferenceKeysPrivate.h:
+* WebView/WebPreferences.mm:
+(+[WebPreferences initialize]):
+* WebView/WebPreferencesPrivate.h:
+* WebView/WebView.mm:
+(-[WebView _preferencesChanged:]):
+
+2011-06-22 Sam Weinig
+
Reviewed by Adam Barth.
Add preference for setting the html parser depth limit
Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (89500 => 89501)
--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2011-06-23 00:16:03 UTC (rev 89500)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2011-06-23 00:17:08 UTC (rev 89501)
@@ -120,7 +120,6 @@
#define WebKitTextDirectionSubmenuInclusionBehaviorPreferenceKey @"WebKitTextDirectionSubmenuInclusionBehaviorPreferenceKey"
#define WebKitEditingBehaviorPreferenceKey @"WebKitEditingBehavior"
#define WebKitUsePreHTML5ParserQuirksKey @"WebKitUsePreHTML5ParserQuirks"
-#define WebKitMaximumHTMLParserDOMTreeDepthKey @"WebKitMaximumHTMLParserDOMTreeDepth"
// CoreGraphics deferred updates are disabled if WebKitEnableCoalescedUpdatesPreferenceKey is set
// to NO, or has no value. For compatibility with Mac OS X 10.4.6, deferred updates are OFF by
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (89500 => 89501)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2011-06-23 00:16:03 UTC (rev 89500)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2011-06-23 00:17:08 UTC (rev 89501)
@@ -39,7 +39,6 @@
#import "WebNSDictionaryExtras.h"
#import "WebNSURLExtras.h"
#import
-#import
NSString *WebPreferencesChangedNotification = @"WebPreferencesChangedNotification";
NSString *WebPreferencesRemovedNotification = @"WebPreferencesRemovedNotification";
@@ -376,7 +375,6 @@
[NSNumber numberWithBool:NO], WebKitMemoryInfoEnabledPreferenceKey,
[NSNumber numberWithBool:YES], WebKitHyperlinkAuditingEnabledPreferenceKey,
[NSNumber numberWithBool:NO], WebKitUsePreHTML5ParserQuirksKey,
-[NSNumber numberWithUnsignedInt:WebCore::Settings::defaultMaximumHTMLParserDOMTreeDepth], WebKitMaximumHTMLParserDOMTreeDepthKey,
[NSNumber numberWithBool:YES], WebKitAVFoundationEnabledKey,
[NSNumber numberWithLongLong:WebCore::ApplicationCacheStorage::noQuota()], WebKitApplicationCacheTotalQuota,
[NSNumber numberWithLongLong:WebCore::ApplicationCacheStorage::noQuota()], WebKitApplicationCacheDefaultOriginQuota,
@@ -1410,16 +1408,6 @@
[self _setBoolValue:flag forKey:WebKitUsePreHTML5ParserQuirksKey];
}
-- (void)setMaximumHTMLParserDOMTreeDepth:(unsigned)depth
-{
-[self _setIntegerValue:depth forKey:WebKitMaximumHTMLParserDOMTreeDepthKey];
-}
-
-- (unsigned)maximumHTMLParserDOMTreeDepth
-{
-return [self _integerValueForKey:WebKitMaximumHTMLParserDOMTreeDepthKey];
-}
-
- (void)didRemoveFromWebView
{
ASSERT(_private->numWebViews);
Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (89500 => 89501)
--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2011-06-23 00:16:03 UTC (rev 89500)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2011-06-23 00:17:08 UTC (rev 89501)
@@ -238,9 +238,6 @@
- (void)setUsePreHTML5ParserQuirks:(BOOL)flag;
- (BOOL)usePreHTML5ParserQuirks;
-- (void)setMaximumHTMLParserDOMTreeDepth:(unsigned)depth;
-- (unsigned)maximumHTMLParserDOMTreeDepth;
-
- (void)setLoadsSiteIconsIgnoringImageLoadingPreference: (BOOL)flag;
- (BOOL)loadsSiteIconsIgnoringImageLoadingPreference;
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (89500 => 89501)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2011-06-23 00:16:03 UTC (rev 89500)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2011-06-23 00:17:08 UTC (rev 89501)
@@ -1570,7 +1570,6 @@
[webkit-changes] [89500] trunk/LayoutTests
Title: [89500] trunk/LayoutTests Revision 89500 Author jber...@webkit.org Date 2011-06-22 17:16:03 -0700 (Wed, 22 Jun 2011) Log Message [WebKit2 Tests] plugins/npruntime/embed-property-equality.html failing since introduction in r88679. https://bugs.webkit.org/show_bug.cgi?id=63205 Add expected failing result in order to get the bots green. * platform/mac-wk2/plugins: Added. * platform/mac-wk2/plugins/npruntime: Added. * platform/mac-wk2/plugins/npruntime/embed-property-equality-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/mac-wk2/plugins/ trunk/LayoutTests/platform/mac-wk2/plugins/npruntime/ trunk/LayoutTests/platform/mac-wk2/plugins/npruntime/embed-property-equality-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (89499 => 89500) --- trunk/LayoutTests/ChangeLog 2011-06-23 00:01:53 UTC (rev 89499) +++ trunk/LayoutTests/ChangeLog 2011-06-23 00:16:03 UTC (rev 89500) @@ -1,3 +1,15 @@ +2011-06-22 Jessie Berlin + +[WebKit2 Tests] plugins/npruntime/embed-property-equality.html failing since introduction in +r88679. +https://bugs.webkit.org/show_bug.cgi?id=63205 + +Add expected failing result in order to get the bots green. + +* platform/mac-wk2/plugins: Added. +* platform/mac-wk2/plugins/npruntime: Added. +* platform/mac-wk2/plugins/npruntime/embed-property-equality-expected.txt: Added. + 2011-06-22 Ojan Vafai Update listing for perf tests to list each individual test. Added: trunk/LayoutTests/platform/mac-wk2/plugins/npruntime/embed-property-equality-expected.txt (0 => 89500) --- trunk/LayoutTests/platform/mac-wk2/plugins/npruntime/embed-property-equality-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac-wk2/plugins/npruntime/embed-property-equality-expected.txt 2011-06-23 00:16:03 UTC (rev 89500) @@ -0,0 +1,4 @@ +Test equality of plugin object properties. + + +Send two references of a _javascript_ object to the plugin for identity comparison in C++ FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89499] trunk/Source/WebCore
Title: [89499] trunk/Source/WebCore
Revision 89499
Author crog...@google.com
Date 2011-06-22 17:01:53 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Chris Rogers
Reviewed by David Levin.
Use create() method for AsyncAudioDecoder::DecodingTask
https://bugs.webkit.org/show_bug.cgi?id=63198
No new tests. This doesn't change any JS API.
* webaudio/AsyncAudioDecoder.cpp:
(WebCore::AsyncAudioDecoder::decodeAsync):
(WebCore::AsyncAudioDecoder::DecodingTask::create):
* webaudio/AsyncAudioDecoder.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AsyncAudioDecoder.cpp
trunk/Source/WebCore/webaudio/AsyncAudioDecoder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (89498 => 89499)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 23:57:14 UTC (rev 89498)
+++ trunk/Source/WebCore/ChangeLog 2011-06-23 00:01:53 UTC (rev 89499)
@@ -1,3 +1,17 @@
+2011-06-22 Chris Rogers
+
+Reviewed by David Levin.
+
+Use create() method for AsyncAudioDecoder::DecodingTask
+https://bugs.webkit.org/show_bug.cgi?id=63198
+
+No new tests. This doesn't change any JS API.
+
+* webaudio/AsyncAudioDecoder.cpp:
+(WebCore::AsyncAudioDecoder::decodeAsync):
+(WebCore::AsyncAudioDecoder::DecodingTask::create):
+* webaudio/AsyncAudioDecoder.h:
+
2011-06-22 Sheriff Bot
Unreviewed, rolling out r89489.
Modified: trunk/Source/WebCore/webaudio/AsyncAudioDecoder.cpp (89498 => 89499)
--- trunk/Source/WebCore/webaudio/AsyncAudioDecoder.cpp 2011-06-22 23:57:14 UTC (rev 89498)
+++ trunk/Source/WebCore/webaudio/AsyncAudioDecoder.cpp 2011-06-23 00:01:53 UTC (rev 89499)
@@ -60,7 +60,7 @@
if (!audioData)
return;
-OwnPtr decodingTask = adoptPtr(new DecodingTask(audioData, sampleRate, successCallback, errorCallback));
+OwnPtr decodingTask = DecodingTask::create(audioData, sampleRate, successCallback, errorCallback);
m_queue.append(decodingTask.release()); // note that ownership of the task is effectively taken by the queue.
}
@@ -90,6 +90,11 @@
}
}
+PassOwnPtr AsyncAudioDecoder::DecodingTask::create(ArrayBuffer* audioData, double sampleRate, PassRefPtr successCallback, PassRefPtr errorCallback)
+{
+return adoptPtr(new DecodingTask(audioData, sampleRate, successCallback, errorCallback));
+}
+
AsyncAudioDecoder::DecodingTask::DecodingTask(ArrayBuffer* audioData, double sampleRate, PassRefPtr successCallback, PassRefPtr errorCallback)
: m_audioData(audioData)
, m_sampleRate(sampleRate)
Modified: trunk/Source/WebCore/webaudio/AsyncAudioDecoder.h (89498 => 89499)
--- trunk/Source/WebCore/webaudio/AsyncAudioDecoder.h 2011-06-22 23:57:14 UTC (rev 89498)
+++ trunk/Source/WebCore/webaudio/AsyncAudioDecoder.h 2011-06-23 00:01:53 UTC (rev 89499)
@@ -41,6 +41,7 @@
// Upon successful decoding, a completion callback will be invoked with the decoded PCM data in an AudioBuffer.
class AsyncAudioDecoder {
+WTF_MAKE_NONCOPYABLE(AsyncAudioDecoder);
public:
AsyncAudioDecoder();
~AsyncAudioDecoder();
@@ -52,11 +53,13 @@
class DecodingTask {
WTF_MAKE_NONCOPYABLE(DecodingTask);
public:
-DecodingTask(ArrayBuffer* audioData, double sampleRate, PassRefPtr successCallback, PassRefPtr errorCallback);
-
+static PassOwnPtr create(ArrayBuffer* audioData, double sampleRate, PassRefPtr successCallback, PassRefPtr errorCallback);
+
void decode();
private:
+DecodingTask(ArrayBuffer* audioData, double sampleRate, PassRefPtr successCallback, PassRefPtr errorCallback);
+
ArrayBuffer* audioData() { return m_audioData.get(); }
double sampleRate() const { return m_sampleRate; }
AudioBufferCallback* successCallback() { return m_successCallback.get(); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89498] trunk/LayoutTests
Title: [89498] trunk/LayoutTests Revision 89498 Author o...@chromium.org Date 2011-06-22 16:57:14 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Ojan Vafai Update listing for perf tests to list each individual test. A number of the tests in this directory are not flaky. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (89497 => 89498) --- trunk/LayoutTests/ChangeLog 2011-06-22 23:56:22 UTC (rev 89497) +++ trunk/LayoutTests/ChangeLog 2011-06-22 23:57:14 UTC (rev 89498) @@ -1,3 +1,10 @@ +2011-06-22 Ojan Vafai + +Update listing for perf tests to list each individual test. +A number of the tests in this directory are not flaky. + +* platform/chromium/test_expectations.txt: + 2011-06-22 Dmitry Titov [Chromium] Unreviewed, baseline for new test added in http://trac.webkit.org/changeset/89490 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (89497 => 89498) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-22 23:56:22 UTC (rev 89497) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-22 23:57:14 UTC (rev 89498) @@ -87,6 +87,9 @@ BUGCR24182 SLOW : http/tests/cache/subresource-failover-to-network.html = PASS BUGCR24182 WIN DEBUG SLOW : fast/parser/block-nesting-cap.html = PASS +BUGCR24182 DEBUG SLOW : perf/array-push-pop.html = PASS +BUGCR24182 SLOW : perf/array-reverse.html = PASS + // Usually <1s in release, ~1s in debug, but occasionally >5s in release. BUGCR27335 XP RELEASE : plugins/embed-attributes-setting.html = PASS TIMEOUT BUGCR27335 XP DEBUG SLOW : plugins/embed-attributes-setting.html = PASS @@ -2252,10 +2255,12 @@ // Started to crash around Chromium r56408. BUGCR52573 LINUX RELEASE : fast/js/array-every.html = PASS CRASH -BUGWK44199 : perf = PASS TEXT -BUGWK44199 BUGWK63057 DEBUG : perf/array-binary-search.html = PASS TEXT TIMEOUT MISSING -BUGWK44199 BUGWK63057 RELEASE : perf/array-binary-search.html = PASS TEXT MISSING -BUGWK44199 DEBUG : perf/class-list-remove.html = PASS TEXT TIMEOUT +BUGCR66466 SLOW : perf/array-nested-loop.html = PASS TEXT +BUGWK44199 SLOW : perf/class-list-remove.html = PASS TEXT +BUGWK44199 : perf/clone-with-focus.html = PASS TEXT TIMEOUT +BUGWK44199 SLOW : perf/mouse-event.html = PASS TEXT +BUGWK44199 SLOW : perf/typing-at-end-of-line.html = PASS TEXT +BUGWK44199 BUGWK63057 : perf/array-binary-search.html = PASS TEXT TIMEOUT MISSING // Failing after http://trac.webkit.org/changeset/65665/ BUGWK44278 MAC WIN LINUX : svg/transforms/text-with-mask-with-svg-transform.svg = IMAGE+TEXT IMAGE @@ -2661,8 +2666,6 @@ // memory and thus leading to unpredictable results. BUGCR66099 SKIP : fast/js/array-sort-modifying-tostring.html = TEXT CRASH TIMEOUT -BUGCR66466 MAC WIN DEBUG SLOW : perf/array-nested-loop.html = PASS TEXT - BUGCR66683 WIN LINUX : fast/canvas/canvas-draw-canvas-on-canvas-shadow.html = TEXT BUGCR66686 : fast/loader/user-stylesheet-fast-path.html = TEXT @@ -3537,14 +3540,11 @@ BUGDPRANKE MAC DEBUG : transitions/cancel-transition.html = TEXT PASS -BUGDPRANKE LINUX DEBUG : perf/array-nested-loop.html = TEXT TIMEOUT PASS BUGDPRANKE LINUX DEBUG : fast/dom/Node/mutation-blur.html = CRASH PASS // flakiness BUGDPRANKE DEBUG : http/tests/navigation/forward-to-fragment-fires-onload.html = TIMEOUT PASS BUGDPRANKE LINUX RELEASE : http/tests/navigation/forward-to-fragment-fires-onload.html = TIMEOUT PASS -BUGDPRANKE WIN DEBUG : perf/mouse-event.html = TEXT TIMEOUT PASS -BUGDPRANKE WIN DEBUG : perf/typing-at-end-of-line.html = TEXT TIMEOUT PASS BUGDPRANKE DEBUG : fast/notifications/notifications-display-close-events.html = TIMEOUT PASS BUGDPRANKE DEBUG : fast/css-generated-content/table-row-group-to-inline.html = IMAGE+TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89497] trunk/Tools
Title: [89497] trunk/Tools
Revision 89497
Author le...@chromium.org
Date 2011-06-22 16:56:22 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 David Levin
Reviewed by Adam Barth.
check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
https://bugs.webkit.org/show_bug.cgi?id=63188
* Scripts/webkitpy/style/checkers/cpp.py: Added the check.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (89496 => 89497)
--- trunk/Tools/ChangeLog 2011-06-22 23:55:53 UTC (rev 89496)
+++ trunk/Tools/ChangeLog 2011-06-22 23:56:22 UTC (rev 89497)
@@ -1,3 +1,13 @@
+2011-06-22 David Levin
+
+Reviewed by Adam Barth.
+
+check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
+https://bugs.webkit.org/show_bug.cgi?id=63188
+
+* Scripts/webkitpy/style/checkers/cpp.py: Added the check.
+* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
+
2011-06-22 Tony Chang
Reviewed by Ojan Vafai.
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (89496 => 89497)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-06-22 23:55:53 UTC (rev 89496)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-06-22 23:56:22 UTC (rev 89497)
@@ -1597,12 +1597,16 @@
error(function_state.function_name_start_position.row, 'readability/webkit_api', 5,
'WEBKIT_API should not be used with a pure virtual function.')
-# Do checks specific to function declaractions.
-if not function_state.is_declaration:
-return
parameter_list = function_state.parameter_list()
for parameter in parameter_list:
-if not parameter.name:
+bad_parameter_type = search('(?=\W|^)(Ref|Own)Ptr(?=\W)', parameter.type)
+if bad_parameter_type:
+type_name = bad_parameter_type.group(0)
+error(parameter.row, 'readability/pass_ptr', 5,
+ 'The parameter type should use Pass%s instead of %s.' % (type_name, type_name))
+
+# Do checks specific to function declarations and parameter names.
+if not function_state.is_declaration or not parameter.name:
continue
# Check the parameter name against the function name for single parameter set functions.
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (89496 => 89497)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-06-22 23:55:53 UTC (rev 89496)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-06-22 23:56:22 UTC (rev 89497)
@@ -3257,6 +3257,20 @@
'}',
'')
+def test_ref_ptr_parameter_value(self):
+self.assert_pass_ptr_check(
+'int myFunction(RefPtr)\n'
+'{\n'
+'}',
+'The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]')
+
+def test_own_ptr_parameter_value(self):
+self.assert_pass_ptr_check(
+'int myFunction(OwnPtr)\n'
+'{\n'
+'}',
+'The parameter type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5]')
+
def test_ref_ptr_member_variable(self):
self.assert_pass_ptr_check(
'class Foo {'
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89496] trunk/Source
Title: [89496] trunk/Source Revision 89496 Author commit-qu...@webkit.org Date 2011-06-22 16:55:53 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Sheriff Bot Unreviewed, rolling out r89489. http://trac.webkit.org/changeset/89489 https://bugs.webkit.org/show_bug.cgi?id=63203 Broke chromium mac build on build.webkit.org (Requested by abarth on #webkit). * wtf/Platform.h: 2011-06-22 Sheriff Bot Unreviewed, rolling out r89489. http://trac.webkit.org/changeset/89489 https://bugs.webkit.org/show_bug.cgi?id=63203 Broke chromium mac build on build.webkit.org (Requested by abarth on #webkit). * WebCore.gyp/WebCore.gyp: * loader/cache/CachedFont.cpp: * platform/chromium/DragImageRef.h: * platform/graphics/FloatPoint.h: * platform/graphics/FloatRect.h: * platform/graphics/FloatSize.h: * platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::hash): * platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add): (WebCore::GlyphBuffer::expandLastAdvance): * platform/graphics/IntPoint.h: * platform/graphics/IntRect.h: * platform/graphics/IntSize.h: * platform/graphics/SimpleFontData.h: * platform/graphics/cg/FloatPointCG.cpp: * platform/graphics/cg/FloatRectCG.cpp: * platform/graphics/cg/FloatSizeCG.cpp: * platform/graphics/cg/IntPointCG.cpp: * platform/graphics/cg/IntRectCG.cpp: * platform/graphics/cg/IntSizeCG.cpp: * platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::createFontCustomPlatformData): * platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): 2011-06-22 Sheriff Bot Unreviewed, rolling out r89489. http://trac.webkit.org/changeset/89489 https://bugs.webkit.org/show_bug.cgi?id=63203 Broke chromium mac build on build.webkit.org (Requested by abarth on #webkit). * WebKit.gyp: * features.gypi: * public/WebCommon.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gyp/WebCore.gyp trunk/Source/WebCore/loader/cache/CachedFont.cpp trunk/Source/WebCore/platform/chromium/DragImageRef.h trunk/Source/WebCore/platform/graphics/FloatPoint.h trunk/Source/WebCore/platform/graphics/FloatRect.h trunk/Source/WebCore/platform/graphics/FloatSize.h trunk/Source/WebCore/platform/graphics/FontPlatformData.h trunk/Source/WebCore/platform/graphics/GlyphBuffer.h trunk/Source/WebCore/platform/graphics/IntPoint.h trunk/Source/WebCore/platform/graphics/IntRect.h trunk/Source/WebCore/platform/graphics/IntSize.h trunk/Source/WebCore/platform/graphics/SimpleFontData.h trunk/Source/WebCore/platform/graphics/cg/FloatPointCG.cpp trunk/Source/WebCore/platform/graphics/cg/FloatRectCG.cpp trunk/Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp trunk/Source/WebCore/platform/graphics/cg/IntPointCG.cpp trunk/Source/WebCore/platform/graphics/cg/IntRectCG.cpp trunk/Source/WebCore/platform/graphics/cg/IntSizeCG.cpp trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/features.gypi trunk/Source/WebKit/chromium/public/WebCommon.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (89495 => 89496) --- trunk/Source/_javascript_Core/ChangeLog 2011-06-22 23:53:17 UTC (rev 89495) +++ trunk/Source/_javascript_Core/ChangeLog 2011-06-22 23:55:53 UTC (rev 89496) @@ -1,3 +1,14 @@ +2011-06-22 Sheriff Bot + +Unreviewed, rolling out r89489. +http://trac.webkit.org/changeset/89489 +https://bugs.webkit.org/show_bug.cgi?id=63203 + +Broke chromium mac build on build.webkit.org (Requested by +abarth on #webkit). + +* wtf/Platform.h: + 2011-06-22 Cary Clark Reviewed by Darin Fisher. Modified: trunk/Source/_javascript_Core/wtf/Platform.h (89495 => 89496) --- trunk/Source/_javascript_Core/wtf/Platform.h 2011-06-22 23:53:17 UTC (rev 89495) +++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-06-22 23:55:53 UTC (rev 89496) @@ -543,14 +543,10 @@ #define WTF_USE_CA 1 #endif -/* USE(SKIA) for Win/Linux, CG for Mac, unless enabled */ +/* USE(SKIA) for Win/Linux, CG for Mac */ #if PLATFORM(CHROMIUM) #if OS(DARWIN) -#if USE(SKIA_ON_MAC_CHROMIUM) -#define WTF_USE_SKIA 1 -#else #define WTF_USE_CG 1 -#endif #define WTF_USE_ATSUI 1 #define WTF_USE_CORE_TEXT 1 #define WTF_USE_ICCJPEG 1 Modified: trunk/Source/WebCore/ChangeLog (89495 => 89496)
[webkit-changes] [89495] trunk/Source/WebCore
Title: [89495] trunk/Source/WebCore
Revision 89495
Author macpher...@chromium.org
Date 2011-06-22 16:53:17 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Luke Macpherson
Reviewed by James Robinson.
Remove comment that snuck in via copy & paste.
https://bugs.webkit.org/show_bug.cgi?id=63177
No new tests / no code changes.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator short):
Removed incorrect comment.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (89494 => 89495)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 23:51:24 UTC (rev 89494)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 23:53:17 UTC (rev 89495)
@@ -1,3 +1,16 @@
+2011-06-22 Luke Macpherson
+
+Reviewed by James Robinson.
+
+Remove comment that snuck in via copy & paste.
+https://bugs.webkit.org/show_bug.cgi?id=63177
+
+No new tests / no code changes.
+
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::operator short):
+Removed incorrect comment.
+
2011-06-22 Annie Sullivan
Reviewed by Ryosuke Niwa.
Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (89494 => 89495)
--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2011-06-22 23:51:24 UTC (rev 89494)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2011-06-22 23:53:17 UTC (rev 89495)
@@ -56,7 +56,7 @@
template<> inline CSSPrimitiveValue::operator short() const
{
-if (m_type == CSS_NUMBER) // Valid for CSS outline-style
+if (m_type == CSS_NUMBER)
return static_cast(m_value.num);
ASSERT_NOT_REACHED();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89494] trunk/LayoutTests
Title: [89494] trunk/LayoutTests
Revision 89494
Author dim...@chromium.org
Date 2011-06-22 16:51:24 -0700 (Wed, 22 Jun 2011)
Log Message
[Chromium] Unreviewed, baseline for a new test added in http://trac.webkit.org/changeset/89490
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (89493 => 89494)
--- trunk/LayoutTests/ChangeLog 2011-06-22 23:43:01 UTC (rev 89493)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 23:51:24 UTC (rev 89494)
@@ -1,5 +1,12 @@
2011-06-22 Dmitry Titov
+[Chromium] Unreviewed, baseline for new test added in http://trac.webkit.org/changeset/89490
+
+* platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
+* platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
+
+2011-06-22 Dmitry Titov
+
[Chromium] Unreviewed, rebaseline tests after http://trac.webkit.org/changeset/89475/
* platform/chromium-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png:
Added: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt (0 => 89494)
--- trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt 2011-06-22 23:51:24 UTC (rev 89494)
@@ -0,0 +1,20 @@
+layer at (0,0) size 480x360
+ RenderView at (0,0) size 480x360
+layer at (0,0) size 480x360
+ RenderSVGRoot {svg} at (0,0) size 480x360
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGContainer {g} at (10,28) size 298x125
+ RenderSVGText {text} at (10,28) size 298x15 contains 1 chunk(s)
+RenderSVGInlineText {#text} at (0,0) size 298x15
+ chunk 1 text run 1 at (10.00,40.00) startOffset 0 endOffset 56 width 298.00: "Test pointer-events=\"painted\" with paint server fallback"
+ RenderSVGPath {rect} at (10,80) size 50x50 [fill={[type=SOLID] [color=#00]}] [x=10.00] [y=80.00] [width=50.00] [height=50.00]
+ RenderSVGPath {rect} at (10,80) size 50x50 [x=10.00] [y=80.00] [width=50.00] [height=50.00]
+ RenderSVGContainer {g} at (10,137) size 251x16
+RenderSVGText {text} at (10,137) size 251x16 contains 1 chunk(s)
+ RenderSVGInlineText {#text} at (0,0) size 251x16
+chunk 1 text run 1 at (10.00,150.00) startOffset 0 endOffset 44 width 251.00: "Move the pointing device over the rectangle."
+RenderSVGContainer {g} at (10,311) size 228x36
+ RenderSVGText {text} at (10,311) size 228x36 contains 1 chunk(s)
+RenderSVGInlineText {#text} at (0,0) size 228x36
+ chunk 1 text run 1 at (10.00,340.00) startOffset 0 endOffset 16 width 228.00: "$Revision: 1.4 $"
+RenderSVGPath {rect} at (0,0) size 480x360 [stroke={[type=SOLID] [color=#00]}] [x=1.00] [y=1.00] [width=478.00] [height=358.00]
Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt
___
Added: svn:eol-style
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89493] trunk/LayoutTests
Title: [89493] trunk/LayoutTests Revision 89493 Author dim...@chromium.org Date 2011-06-22 16:43:01 -0700 (Wed, 22 Jun 2011) Log Message [Chromium] Unreviewed, rebaseline tests after http://trac.webkit.org/changeset/89475/ * platform/chromium-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png: * platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png: Added. * platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png: * platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png trunk/LayoutTests/platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (89492 => 89493) --- trunk/LayoutTests/ChangeLog 2011-06-22 23:18:57 UTC (rev 89492) +++ trunk/LayoutTests/ChangeLog 2011-06-22 23:43:01 UTC (rev 89493) @@ -1,3 +1,12 @@ +2011-06-22 Dmitry Titov + +[Chromium] Unreviewed, rebaseline tests after http://trac.webkit.org/changeset/89475/ + +* platform/chromium-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png: +* platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png: Added. +* platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png: +* platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.png: + 2011-06-22 Annie Sullivan Reviewed by Ryosuke Niwa. Added: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png ___ Added: svn:mime-type Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89492] trunk
Title: [89492] trunk
Revision 89492
Author commit-qu...@webkit.org
Date 2011-06-22 16:18:57 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Annie Sullivan
Reviewed by Ryosuke Niwa.
REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
https://bugs.webkit.org/show_bug.cgi?id=61594
Adds two layout tests to verify that hitting enter in the middle of the span splits the span correctly
and places the cursor in the correct position.
* editing/inserting/return-key-before-br-in-span-expected.txt: Added.
* editing/inserting/return-key-before-br-in-span.html: Added.
* editing/inserting/return-key-middle-of-span-expected.txt: Added.
* editing/inserting/return-key-middle-of-span.html: Added.
2011-06-22 Annie Sullivan
Reviewed by Ryosuke Niwa.
REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
https://bugs.webkit.org/show_bug.cgi?id=61594
When the tree is split at the cursor in InsertParagraphSeparatorCommand, it is possible for the position
split at to be at the end of a text node. The code assumes the position is at the start of the node, so
pass the correct node into splitTreeToNode() in that case.
Tests: editing/inserting/return-key-before-br-in-span.html
editing/inserting/return-key-middle-of-span.html
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp
Added Paths
trunk/LayoutTests/editing/inserting/return-key-before-br-in-span-expected.txt
trunk/LayoutTests/editing/inserting/return-key-before-br-in-span.html
trunk/LayoutTests/editing/inserting/return-key-middle-of-span-expected.txt
trunk/LayoutTests/editing/inserting/return-key-middle-of-span.html
Diff
Modified: trunk/LayoutTests/ChangeLog (89491 => 89492)
--- trunk/LayoutTests/ChangeLog 2011-06-22 23:09:17 UTC (rev 89491)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 23:18:57 UTC (rev 89492)
@@ -1,3 +1,18 @@
+2011-06-22 Annie Sullivan
+
+Reviewed by Ryosuke Niwa.
+
+REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
+https://bugs.webkit.org/show_bug.cgi?id=61594
+
+Adds two layout tests to verify that hitting enter in the middle of the span splits the span correctly
+and places the cursor in the correct position.
+
+* editing/inserting/return-key-before-br-in-span-expected.txt: Added.
+* editing/inserting/return-key-before-br-in-span.html: Added.
+* editing/inserting/return-key-middle-of-span-expected.txt: Added.
+* editing/inserting/return-key-middle-of-span.html: Added.
+
2011-06-22 Jessie Berlin
Add more "CONSOLE MESSAGE: line 0: SVG animation pause API missing!" tests to the WK2
Added: trunk/LayoutTests/editing/inserting/return-key-before-br-in-span-expected.txt (0 => 89492)
--- trunk/LayoutTests/editing/inserting/return-key-before-br-in-span-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/inserting/return-key-before-br-in-span-expected.txt 2011-06-22 23:18:57 UTC (rev 89492)
@@ -0,0 +1,10 @@
+This sets the selection to the end of the first line, and hits the enter key.
+Expected behavior: a div is created around the second line, and the cursor is placed at the start of the second line. See bug 61594.
+|
+| id="wrapper"
+| "First line"
+|
+|
+| <#selection-caret>
+|
+| "Second line"
Added: trunk/LayoutTests/editing/inserting/return-key-before-br-in-span.html (0 => 89492)
--- trunk/LayoutTests/editing/inserting/return-key-before-br-in-span.html (rev 0)
+++ trunk/LayoutTests/editing/inserting/return-key-before-br-in-span.html 2011-06-22 23:18:57 UTC (rev 89492)
@@ -0,0 +1,15 @@
+
+
+
+First lineSecond line
+
+Markup.description("This sets the selection to the end of the first line, and hits the enter key.\n"
++ "Expected behavior: a div is created around the second line, and the cursor is placed at the "
++ "start of the second line. See bug 61594.");
+var sel = window.getSelection();
+sel.setPosition(document.getElementById("wrapper"), 1);
+document.execCommand("InsertParagraph", false, null);
+Markup.dump(root);
+
+
Added: trunk/LayoutTests/editing/inserting/return-key-middle-of-span-expected.txt (0 => 89492)
--- trunk/LayoutTests/editing/inserting/return-key-middle-of-span-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/inserting/return-key-middle-of-span-expected.txt 2011-06-22 23:18:57 UTC (rev 89492)
@@ -0,0 +1,10 @@
+This sets the selection to the middle of the first line, and hits the enter key.
+Expected behavior: the text node is spl
[webkit-changes] [89491] trunk/LayoutTests
Title: [89491] trunk/LayoutTests Revision 89491 Author jber...@webkit.org Date 2011-06-22 16:09:17 -0700 (Wed, 22 Jun 2011) Log Message Add more "CONSOLE MESSAGE: line 0: SVG animation pause API missing!" tests to the WK2 Skipped list to get the bots green. * platform/mac-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (89490 => 89491) --- trunk/LayoutTests/ChangeLog 2011-06-22 22:42:01 UTC (rev 89490) +++ trunk/LayoutTests/ChangeLog 2011-06-22 23:09:17 UTC (rev 89491) @@ -1,3 +1,10 @@ +2011-06-22 Jessie Berlin + +Add more "CONSOLE MESSAGE: line 0: SVG animation pause API missing!" tests to the WK2 +Skipped list to get the bots green. + +* platform/mac-wk2/Skipped: + 2011-06-22 Rob Buis Reviewed by Nikolas Zimmermann. Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (89490 => 89491) --- trunk/LayoutTests/platform/mac-wk2/Skipped 2011-06-22 22:42:01 UTC (rev 89490) +++ trunk/LayoutTests/platform/mac-wk2/Skipped 2011-06-22 23:09:17 UTC (rev 89491) @@ -466,7 +466,9 @@ svg/animations/svgnumber-animation-1.html svg/animations/svgnumber-animation-2.html svg/animations/svgnumber-animation-3.html - +svg/animations/svgrect-animation-1.html +svg/animations/svgrect-animation-2.html +svg/animations/svgstring-animation-fallback-to-discrete.html svg/custom/absolute-sized-content-with-resources.xhtml svg/custom/circle-move-invalidation.svg svg/custom/clip-path-child-changes.svg ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89490] trunk
Title: [89490] trunk
Revision 89490
Author rwlb...@webkit.org
Date 2011-06-22 15:42:01 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Rob Buis
Reviewed by Nikolas Zimmermann.
SVG1.1SE test with pointer-events and invalid gradient fill fails
https://bugs.webkit.org/show_bug.cgi?id=63109
* platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
* svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg: Added.
* svg/custom/pointer-events-invalid-fill-expected.txt: Added.
* svg/custom/pointer-events-invalid-fill.svg: Added.
2011-06-22 Rob Buis
Reviewed by Nikolas Zimmermann.
SVG1.1SE test with pointer-events and invalid gradient fill fails
https://bugs.webkit.org/show_bug.cgi?id=63109
Properly detect fill/stroke properties of type SVG_PAINTTYPE_URI_NONE, store it in SVGPaint
and don't apply the paint if the uri lookup fails.
Tests: svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg
svg/custom/pointer-events-invalid-fill.svg
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* rendering/svg/RenderSVGResource.cpp:
(WebCore::requestPaintingResource):
* svg/SVGPaint.h:
(WebCore::SVGPaint::createURIAndNone):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/SVGCSSParser.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResource.cpp
trunk/Source/WebCore/svg/SVGPaint.h
Added Paths
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt
trunk/LayoutTests/svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg
trunk/LayoutTests/svg/custom/pointer-events-invalid-fill-expected.txt
trunk/LayoutTests/svg/custom/pointer-events-invalid-fill.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (89489 => 89490)
--- trunk/LayoutTests/ChangeLog 2011-06-22 22:35:38 UTC (rev 89489)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 22:42:01 UTC (rev 89490)
@@ -1,3 +1,16 @@
+2011-06-22 Rob Buis
+
+Reviewed by Nikolas Zimmermann.
+
+SVG1.1SE test with pointer-events and invalid gradient fill fails
+https://bugs.webkit.org/show_bug.cgi?id=63109
+
+* platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
+* platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
+* svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg: Added.
+* svg/custom/pointer-events-invalid-fill-expected.txt: Added.
+* svg/custom/pointer-events-invalid-fill.svg: Added.
+
2011-06-22 Matthew Delaney
Reviewed by Adam Roben.
Added: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt (0 => 89490)
--- trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt 2011-06-22 22:42:01 UTC (rev 89490)
@@ -0,0 +1,20 @@
+layer at (0,0) size 480x360
+ RenderView at (0,0) size 480x360
+layer at (0,0) size 480x360
+ RenderSVGRoot {svg} at (0,0) size 480x360
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGContainer {g} at (10,28) size 297x125
+ RenderSVGText {text} at (10,28) size 297x15 contains 1 chunk(s)
+RenderSVGInlineText {#text} at (0,0) size 297x15
+ chunk 1 text run 1 at (10.00,40.00) startOffset 0 endOffset 56 width 297.00: "Test pointer-events=\"painted\" with paint server fallback"
+ RenderSVGPath {rect} at (10,80) size 50x50 [fill={[type=SOLID] [color=#00]}] [x=10.00] [y=80.00] [width=50.00] [height=50.00]
+ RenderSVGPath {rect} at (10,80) size 50x50 [x=10.00] [y=80.00] [width=50.00] [height=50.00]
+ RenderSVGContainer {g} at (10,137) size 257x16
+RenderSVGText {text} at (10,137) size 257x16 contains 1 chunk(s)
+ RenderSVGInlineText {#text} at (0,0) size 257x16
+chunk 1 text run 1 at (10.00,150.00) startOffset 0 endOffset 44 width 257.00: "Move the pointing device over the rectangle."
+RenderSVGContainer {g} at (10,310) size 231x38
+ RenderSVGText {text} at (10,310) size 231x38 contains 1 chunk(s)
+RenderSVGInlineText {#text} at (0,0) size 231x38
+ chunk 1 text run 1 at (10.00,340.00) startOffset 0 endOffset 16 width 231.00: "$Revision: 1.4 $"
+RenderSVGPath {rect} at (0,0) size 480x360 [stroke={[type=SOLID] [color=#00]}
[webkit-changes] [89488] trunk/LayoutTests
Title: [89488] trunk/LayoutTests
Revision 89488
Author mdela...@apple.com
Date 2011-06-22 15:28:43 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Matthew Delaney
Reviewed by Adam Roben.
Setting expected results for platform/win
https://bugs.webkit.org/show_bug.cgi?id=63190
* platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (89487 => 89488)
--- trunk/LayoutTests/ChangeLog 2011-06-22 22:27:50 UTC (rev 89487)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 22:28:43 UTC (rev 89488)
@@ -1,3 +1,12 @@
+2011-06-22 Matthew Delaney
+
+Reviewed by Adam Roben.
+
+Setting expected results for platform/win
+https://bugs.webkit.org/show_bug.cgi?id=63190
+
+* platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
+
2011-06-22 Adam Roben
Add Windows expected results for some new tests from r87779
Added: trunk/LayoutTests/platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt (0 => 89488)
--- trunk/LayoutTests/platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt 2011-06-22 22:28:43 UTC (rev 89488)
@@ -0,0 +1,9 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x70
+ RenderBlock {HTML} at (0,0) size 800x70
+RenderBody {BODY} at (8,8) size 784x54
+ RenderHTMLCanvas {CANVAS} at (0,0) size 100x50
+ RenderText {#text} at (0,0) size 0x0
+layer at (8,8) size 100x50
+ RenderBlock (positioned) {DIV} at (8,8) size 100x50 [bgcolor=#008000]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89487] trunk/LayoutTests
Title: [89487] trunk/LayoutTests
Revision 89487
Author aro...@apple.com
Date 2011-06-22 15:27:50 -0700 (Wed, 22 Jun 2011)
Log Message
Add Windows expected results for some new tests from r87779
These differ from Mac due to some small rounding differences in a path.
* platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt
trunk/LayoutTests/platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt
trunk/LayoutTests/platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt
trunk/LayoutTests/platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (89486 => 89487)
--- trunk/LayoutTests/ChangeLog 2011-06-22 22:12:56 UTC (rev 89486)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 22:27:50 UTC (rev 89487)
@@ -1,5 +1,16 @@
2011-06-22 Adam Roben
+Add Windows expected results for some new tests from r87779
+
+These differ from Mac due to some small rounding differences in a path.
+
+* platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
+* platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
+* platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
+* platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
+
+2011-06-22 Adam Roben
+
Skip some flaky animation tests on Windows
See and .
Added: trunk/LayoutTests/platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt (0 => 89487)
--- trunk/LayoutTests/platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt 2011-06-22 22:27:50 UTC (rev 89487)
@@ -0,0 +1,20 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 500x154 layerType: background only
+layer at (0,0) size 125x112
+ RenderBlock (positioned) zI: -1 {div} at (0,0) size 125x112 [bgcolor=#FF]
+layer at (0,0) size 500x154 layerType: foreground only
+ RenderBlock {html} at (0,0) size 500x154
+RenderBody {body} at (0,0) size 500x154
+ RenderBlock {p} at (0,0) size 500x154
+RenderEmbeddedObject {object} at (0,0) size 250x150
+ layer at (0,0) size 250x150
+RenderView at (0,0) size 250x150
+ layer at (0,0) size 250x112
+RenderSVGRoot {svg} at (0,0) size 125x112
+ RenderSVGPath {rect} at (0,0) size 125x112 [fill={[type=SOLID] [color=#ADD8E6]}] [x=0.00] [y=0.00] [width=125.00] [height=112.50]
+ RenderSVGPath {rect} at (6,5) size 113x102 [fill={[type=SOLID] [color=#008000]}] [x=6.25] [y=5.63] [width=112.50] [height=101.25]
+layer at (0,117) size 125x112
+ RenderSVGRoot {svg} at (0,117) size 125x112
+RenderSVGPath {rect} at (0,117) size 125x112 [fill={[type=SOLID] [color=#ADD8E6]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]
+RenderSVGPath {rect} at (6,122) size 113x102 [fill={[type=SOLID] [color=#008000]}] [x=5.00] [y=5.00] [width=90.00] [height=90.00]
Added: trunk/LayoutTests/platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt (0 => 89487)
--- trunk/LayoutTests/platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt 2011-06-22 22:27:50 UTC (rev 89487)
@@ -0,0 +1,20 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 500x154 layerType: background only
+layer at (0,0) size 125x112
+ RenderBlock (positioned) zI: -1 {div} at (0,0) size 125x112 [bgcolor=#FF]
+layer at (0,0) size 500x154 layerType: foreground only
+ RenderBlock {html} at (0,0) size 500x154
+RenderBody {body} at (0,0) size 500x154
+ RenderBlock {p} at (0,0) size 500x154
+RenderEmbeddedObject {object} at (0,0) size 250x150
+ layer at (0,0) size 250x150
+RenderView at (0,0) size 250x150
+ layer at (0,0) size 125x112
+RenderSVGRoot {svg} at (0,0) size 125x112
+ RenderSVGPath {rect} a
[webkit-changes] [89486] trunk/Tools
Title: [89486] trunk/Tools
Revision 89486
Author t...@chromium.org
Date 2011-06-22 15:12:56 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Tony Chang
Reviewed by Ojan Vafai.
Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
https://bugs.webkit.org/show_bug.cgi?id=62891
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (89485 => 89486)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2011-06-22 22:07:15 UTC (rev 89485)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2011-06-22 22:12:56 UTC (rev 89486)
@@ -59,6 +59,7 @@
{ "name": "google-linux-2", "platform": "chromium-linux" },
{ "name": "google-new-tests", "platform": "mac-snowleopard" },
{ "name": "google-new-tests-leopard", "platform": "mac-leopard" },
+{ "name": "google-linux-flexbox", "platform": "chromium-linux" },
{ "name": "wincairo-1", "platform": "wincairo" },
@@ -223,6 +224,11 @@
"slavenames": ["google-new-tests"]
},
{
+ "name": "Chromium Linux Release (Flexbox)", "type": "NewBuildAndTest", "builddir": "chromium-linux-flexbox",
+ "platform": "chromium-linux", "configuration": "release", "architectures": ["i386"],
+ "slavenames": ["google-linux-flexbox"]
+},
+{
"name": "WinCairo Debug (Build)", "type": "Build", "builddir": "win-cairo-debug",
"platform": "wincairo", "configuration": "debug", "architectures": ["i386"],
"slavenames": ["wincairo-1"]
@@ -244,7 +250,7 @@
"Qt Linux Release", "Qt Linux Release minimal", "Qt Linux ARMv7 Release",
"Qt Windows 32-bit Release", "Qt Windows 32-bit Debug",
"Chromium Win Release", "Chromium Mac Release", "Chromium Linux Release",
- "Chromium Win Release (Tests)", "Chromium Mac Release (Tests)", "Chromium Linux Release (Tests)",
+ "Chromium Win Release (Tests)", "Chromium Mac Release (Tests)", "Chromium Linux Release (Tests)", "Chromium Linux Release (Flexbox)",
"WinCairo Debug (Build)", "WinCE Release (Build)", "EFL Linux Release (Build)"]
},
{ "type": "PlatformSpecificScheduler", "platform": "mac-leopard", "branch": "trunk", "treeStableTimer": 45.0,
Modified: trunk/Tools/ChangeLog (89485 => 89486)
--- trunk/Tools/ChangeLog 2011-06-22 22:07:15 UTC (rev 89485)
+++ trunk/Tools/ChangeLog 2011-06-22 22:12:56 UTC (rev 89486)
@@ -1,3 +1,12 @@
+2011-06-22 Tony Chang
+
+Reviewed by Ojan Vafai.
+
+Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
+https://bugs.webkit.org/show_bug.cgi?id=62891
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
2011-06-22 Dirk Pranke
Reviewed by Ojan Vafai.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89485] trunk/LayoutTests
Title: [89485] trunk/LayoutTests Revision 89485 Author aro...@apple.com Date 2011-06-22 15:07:15 -0700 (Wed, 22 Jun 2011) Log Message Skip some flaky animation tests on Windows See and . * platform/win/Skipped: Added animations/animation-direction-normal.html and animations/play-state-paused.html. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (89484 => 89485) --- trunk/LayoutTests/ChangeLog 2011-06-22 22:02:06 UTC (rev 89484) +++ trunk/LayoutTests/ChangeLog 2011-06-22 22:07:15 UTC (rev 89485) @@ -1,5 +1,14 @@ 2011-06-22 Adam Roben +Skip some flaky animation tests on Windows + +See and . + +* platform/win/Skipped: Added animations/animation-direction-normal.html and +animations/play-state-paused.html. + +2011-06-22 Adam Roben + Disable zoom-svg-through-object-with-*.xhtml These tests are flaky. See . Modified: trunk/LayoutTests/platform/win/Skipped (89484 => 89485) --- trunk/LayoutTests/platform/win/Skipped 2011-06-22 22:02:06 UTC (rev 89484) +++ trunk/LayoutTests/platform/win/Skipped 2011-06-22 22:07:15 UTC (rev 89485) @@ -432,6 +432,12 @@ http/tests/inspector/resource-tree/resource-tree-reload.html http/tests/inspector/resource-tree/resource-tree-frame-add.html +# Flaky http://webkit.org/b/62561 +animations/animation-direction-normal.html + +# Flaky http://webkit.org/b/62569 +animations/play-state-paused.html + ### No bugs filed about the below yet### ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89484] trunk/LayoutTests
Title: [89484] trunk/LayoutTests Revision 89484 Author aro...@apple.com Date 2011-06-22 15:02:06 -0700 (Wed, 22 Jun 2011) Log Message Disable zoom-svg-through-object-with-*.xhtml These tests are flaky. See . * platform/chromium/test_expectations.txt: * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: Removed mentions of these tests. * svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml. * svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml. * svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html. * svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml. * svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html. * svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml. * svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-text.xhtml. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/qt/Skipped Added Paths trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled Removed Paths trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-text.xhtml Diff Modified: trunk/LayoutTests/ChangeLog (89483 => 89484) --- trunk/LayoutTests/ChangeLog 2011-06-22 21:52:30 UTC (rev 89483) +++ trunk/LayoutTests/ChangeLog 2011-06-22 22:02:06 UTC (rev 89484) @@ -1,3 +1,23 @@ +2011-06-22 Adam Roben + +Disable zoom-svg-through-object-with-*.xhtml + +These tests are flaky. See . + +* platform/chromium/test_expectations.txt: +* platform/gtk/Skipped: +* platform/mac/Skipped: +* platform/qt/Skipped: +Removed mentions of these tests. + +* svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml. +* svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml. +* svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html. +* svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml. +* svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html. +* svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml. +* svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-text.xhtml. + 2011-06-22 Balazs Kelemen Reviewed by Andreas Kling. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (89483 => 89484) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-22 21:52:30 UTC (rev 89483) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-22 22:02:06 UTC (rev 89484) @@ -3864,16 +3864,7 @@
[webkit-changes] [89483] trunk/Tools
Title: [89483] trunk/Tools Revision 89483 Author dpra...@chromium.org Date 2011-06-22 14:52:30 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Dirk Pranke Reviewed by Ojan Vafai. nrwt: don't look for http lock when running the test port https://bugs.webkit.org/show_bug.cgi?id=63158 * Scripts/webkitpy/layout_tests/port/mock_drt.py: * Scripts/webkitpy/layout_tests/port/test.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py Diff Modified: trunk/Tools/ChangeLog (89482 => 89483) --- trunk/Tools/ChangeLog 2011-06-22 21:40:58 UTC (rev 89482) +++ trunk/Tools/ChangeLog 2011-06-22 21:52:30 UTC (rev 89483) @@ -1,3 +1,13 @@ +2011-06-22 Dirk Pranke + +Reviewed by Ojan Vafai. + +nrwt: don't look for http lock when running the test port +https://bugs.webkit.org/show_bug.cgi?id=63158 + +* Scripts/webkitpy/layout_tests/port/mock_drt.py: +* Scripts/webkitpy/layout_tests/port/test.py: + 2011-06-22 Balazs Kelemen Reviewed by Andreas Kling. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py (89482 => 89483) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py 2011-06-22 21:40:58 UTC (rev 89482) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py 2011-06-22 21:52:30 UTC (rev 89483) @@ -62,12 +62,6 @@ def __getattr__(self, name): return getattr(self.__delegate, name) -def acquire_http_lock(self): -pass - -def release_http_lock(self): -pass - def check_build(self, needs_http): return True @@ -109,6 +103,9 @@ def start_websocket_server(self): pass +def acquire_http_lock(self): +pass + def stop_helper(self): pass @@ -118,7 +115,10 @@ def stop_websocket_server(self): pass +def release_http_lock(self): +pass + def main(argv, fs, stdin, stdout, stderr): """Run the tests.""" Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py (89482 => 89483) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py 2011-06-22 21:40:58 UTC (rev 89482) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py 2011-06-22 21:52:30 UTC (rev 89483) @@ -338,12 +338,18 @@ def start_websocket_server(self): pass +def acquire_http_lock(self): +pass + def stop_http_server(self): pass def stop_websocket_server(self): pass +def release_http_lock(self): +pass + def path_to_test_expectations_file(self): return self._expectations_path ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89482] trunk
Title: [89482] trunk
Revision 89482
Author kbal...@webkit.org
Date 2011-06-22 14:40:58 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Balazs Kelemen
Reviewed by Andreas Kling.
[Qt][WK2] Set up plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63066
* platform/qt-wk2/Skipped:
Unskip passing plugin tests and create a new group for those
that still fail for some reason.
2011-06-22 Balazs Kelemen
Reviewed by Andreas Kling.
[Qt][WK2] Set up plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63066
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
Force windowless mode for the test plugin because we
don't support windowed plugins yet.
2011-06-22 Balazs Kelemen
Reviewed by Andreas Kling.
[Qt][WK2] Set up plugin tests
https://bugs.webkit.org/show_bug.cgi?id=63066
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::initializeTestPluginDirectory):
Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
of the test plugin like DRT does.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (89481 => 89482)
--- trunk/LayoutTests/ChangeLog 2011-06-22 21:38:46 UTC (rev 89481)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 21:40:58 UTC (rev 89482)
@@ -1,3 +1,14 @@
+2011-06-22 Balazs Kelemen
+
+Reviewed by Andreas Kling.
+
+[Qt][WK2] Set up plugin tests
+https://bugs.webkit.org/show_bug.cgi?id=63066
+
+* platform/qt-wk2/Skipped:
+Unskip passing plugin tests and create a new group for those
+that still fail for some reason.
+
2011-06-22 Jessie Berlin
WebKit2 needs layoutTestController.overridePreference.
Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (89481 => 89482)
--- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-06-22 21:38:46 UTC (rev 89481)
+++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-06-22 21:40:58 UTC (rev 89482)
@@ -808,17 +808,6 @@
svg/zoom/page/zoom-coords-viewattr-01-b.svg
svg/zoom/text/zoom-coords-viewattr-01-b.svg
-# Qt WebKit2 needs plugins support
-fast/css/acid2-pixel.html
-fast/css/acid2.html
-fast/events/tabindex-focus-blur-all.html
-fast/loader/loadInProgress.html
-http/tests/misc/acid2-pixel.html
-http/tests/misc/acid2.html
-http/tests/plugins
-plugins
-java
-
# WebKit2 needs layoutTestController.overridePreference
#
# Get accelerated compositing working with webkit2
@@ -1501,6 +1490,22 @@
http/tests/security/cross-frame-access-protocol-explicit-domain.html
http/tests/security/cross-frame-access-protocol.html
+# Unexplained plugin failures
+plugins/document-open.html
+plugins/embed-prefers-plugins-for-images.html
+plugins/geturlnotify-during-document-teardown.html
+plugins/plugin-initiate-popup-window.html
+plugins/mouse-events-fixedpos.html
+plugins/netscape-dom-access.html
+plugins/npp-set-window-called-during-destruction.html
+plugins/open-and-close-window-with-plugin.html
+plugins/plugin-initiatate-popup-window.html
+plugins/plugin-_javascript_-access.html
+plugins/reloadplugins-and-pages.html
+plugins/destroy-stream-twice.html
+plugins/object-embed-plugin-scripting.html
+plugins/npruntime/npruntime.html
+
# Unexplained failures
fast/dom/beforeload/remove-frame-in-beforeload-listener.html
fast/dom/css-cached-import-rule.html
Modified: trunk/Source/WebKit2/ChangeLog (89481 => 89482)
--- trunk/Source/WebKit2/ChangeLog 2011-06-22 21:38:46 UTC (rev 89481)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-22 21:40:58 UTC (rev 89482)
@@ -1,3 +1,15 @@
+2011-06-22 Balazs Kelemen
+
+Reviewed by Andreas Kling.
+
+[Qt][WK2] Set up plugin tests
+https://bugs.webkit.org/show_bug.cgi?id=63066
+
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::createPlugin):
+Force windowless mode for the test plugin because we
+don't support windowed plugins yet.
+
2011-06-22 Geoffrey Garen
Reviewed by Oliver Hunt.
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (89481 => 89482)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2011-06-22 21:38:46 UTC (rev 89481)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2011-06-22 21:40:58 UTC (rev 89482)
@@ -1273,6 +1273,9 @@
parameters.values.append("opaque");
} else if (equalIgnoringCase(parameters.values[wmodeIndex], "window"))
parameters.values[wmodeIndex] = "opaque";
+} else if (equalIgnoringCase(mimeType, "application/x-webkit-test-netscape")) {
[webkit-changes] [89481] trunk/LayoutTests
Title: [89481] trunk/LayoutTests Revision 89481 Author jber...@webkit.org Date 2011-06-22 14:38:46 -0700 (Wed, 22 Jun 2011) Log Message WebKit2 needs layoutTestController.overridePreference. https://bugs.webkit.org/show_bug.cgi?id=42197 Add more tests that use layoutTestController.overridePreference to the WK2 Skipped list. * platform/mac-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (89480 => 89481) --- trunk/LayoutTests/ChangeLog 2011-06-22 21:33:35 UTC (rev 89480) +++ trunk/LayoutTests/ChangeLog 2011-06-22 21:38:46 UTC (rev 89481) @@ -1,3 +1,12 @@ +2011-06-22 Jessie Berlin + +WebKit2 needs layoutTestController.overridePreference. +https://bugs.webkit.org/show_bug.cgi?id=42197 + +Add more tests that use layoutTestController.overridePreference to the WK2 Skipped list. + +* platform/mac-wk2/Skipped: + 2011-06-22 Mark Pilgrim Reviewed by Adam Barth. Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (89480 => 89481) --- trunk/LayoutTests/platform/mac-wk2/Skipped 2011-06-22 21:33:35 UTC (rev 89480) +++ trunk/LayoutTests/platform/mac-wk2/Skipped 2011-06-22 21:38:46 UTC (rev 89481) @@ -899,9 +899,12 @@ http/tests/navigation/go-back-to-error-page.html http/tests/navigation/ping-cookie.html plugins/application-plugin-plugins-disabled.html +fast/canvas/webgl/canvas-zero-size.html fast/canvas/webgl/context-lost-restored.html fast/canvas/webgl/context-lost.html +fast/canvas/webgl/drawingbuffer-test.html fast/canvas/webgl/uninitialized-test.html +compositing/iframes/page-cache-layer-tree.html compositing/webgl/webgl-background-color.html compositing/webgl/webgl-reflection.html compositing/webgl/webgl-no-alpha.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89480] trunk/Tools
Title: [89480] trunk/Tools
Revision 89480
Author e...@webkit.org
Date 2011-06-22 14:33:35 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Eric Seidel
Reviewed by Ojan Vafai.
Make sheriff-bot rollout messages a little nicer
https://bugs.webkit.org/show_bug.cgi?id=63107
It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
into urls myself. So I have now fixed its "preparing" message to include a url.
I also figured that I should make the messages mention all of the responsible parties
so that rollouts are never surprises. If you're in the channel and were involved
in a patch, you will see if someone is using sheriff-bot to rollout a patch.
As part of doing this I also changed (and tested) _parse_args to fail-fast
when given invalid args.
* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
* Scripts/webkitpy/tool/bot/sheriff.py:
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py
trunk/Tools/Scripts/webkitpy/tool/bot/sheriff.py
trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (89479 => 89480)
--- trunk/Tools/ChangeLog 2011-06-22 21:23:16 UTC (rev 89479)
+++ trunk/Tools/ChangeLog 2011-06-22 21:33:35 UTC (rev 89480)
@@ -1,3 +1,25 @@
+2011-06-22 Eric Seidel
+
+Reviewed by Ojan Vafai.
+
+Make sheriff-bot rollout messages a little nicer
+https://bugs.webkit.org/show_bug.cgi?id=63107
+
+It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
+into urls myself. So I have now fixed its "preparing" message to include a url.
+
+I also figured that I should make the messages mention all of the responsible parties
+so that rollouts are never surprises. If you're in the channel and were involved
+in a patch, you will see if someone is using sheriff-bot to rollout a patch.
+
+As part of doing this I also changed (and tested) _parse_args to fail-fast
+when given invalid args.
+
+* Scripts/webkitpy/tool/bot/irc_command.py:
+* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
+* Scripts/webkitpy/tool/bot/sheriff.py:
+* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
+
2011-06-22 Dirk Pranke
Reviewed by Tony Chang.
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (89479 => 89480)
--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-06-22 21:23:16 UTC (rev 89479)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-06-22 21:33:35 UTC (rev 89480)
@@ -26,6 +26,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import itertools
import random
from webkitpy.common.config import irc as config_irc
@@ -56,46 +57,65 @@
class Rollout(IRCCommand):
def _parse_args(self, args):
-read_revision = True
-rollout_reason = []
+if not args:
+return (None, None)
+
# the first argument must be a revision number
-svn_revision_list = [args[0].lstrip("r")]
-if not svn_revision_list[0].isdigit():
-read_revision = False
+first_revision = args[0].lstrip("r")
+if not first_revision.isdigit():
+return (None, None)
+parsing_revision = True
+svn_revision_list = [int(first_revision)]
+rollout_reason = []
for arg in args[1:]:
-if arg.lstrip("r").isdigit() and read_revision:
-svn_revision_list.append(arg.lstrip("r"))
+if arg.lstrip("r").isdigit() and parsing_revision:
+svn_revision_list.append(int(arg.lstrip("r")))
else:
-read_revision = False
+parsing_revision = False
rollout_reason.append(arg)
+rollout_reason = " ".join(rollout_reason)
return svn_revision_list, rollout_reason
+def _responsible_nicknames_from_revisions(self, tool, sheriff, svn_revision_list):
+commit_infos = map(tool.checkout().commit_info_for_revision, svn_revision_list)
+nickname_lists = map(sheriff.responsible_nicknames_from_commit_info, commit_infos)
+return sorted(set(itertools.chain.from_iterable(nickname_lists)))
+
+def _nicks_string(self, tool, sheriff, requester_nick, svn_revision_list):
+# FIXME: _parse_args guarentees that our svn_revision_list is all numbers.
+# However, it's possible our checkout will not include one of the revisions,
+# so we may need to catch exceptions from commit_info_for_revision here.
+target_nicks = [re
[webkit-changes] [89479] trunk
Title: [89479] trunk
Revision 89479
Author commit-qu...@webkit.org
Date 2011-06-22 14:23:16 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Mark Pilgrim
Reviewed by Adam Barth.
IndexedDB createIndex should NOT throw if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=63114
* storage/indexeddb/mozilla/create-index-null-name-expected.txt:
* storage/indexeddb/mozilla/create-index-null-name.html:
2011-06-22 Mark Pilgrim
Reviewed by Adam Barth.
IndexedDB createIndex should NOT throw if name arg is null
https://bugs.webkit.org/show_bug.cgi?id=63114
* storage/IDBObjectStore.idl: remove ConvertNullToNullString flag
so null values will be stringified as "null", as per WebIDL spec.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name-expected.txt
trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBObjectStore.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (89478 => 89479)
--- trunk/LayoutTests/ChangeLog 2011-06-22 21:14:38 UTC (rev 89478)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 21:23:16 UTC (rev 89479)
@@ -1,3 +1,13 @@
+2011-06-22 Mark Pilgrim
+
+Reviewed by Adam Barth.
+
+IndexedDB createIndex should NOT throw if name arg is null
+https://bugs.webkit.org/show_bug.cgi?id=63114
+
+* storage/indexeddb/mozilla/create-index-null-name-expected.txt:
+* storage/indexeddb/mozilla/create-index-null-name.html:
+
2011-06-22 Jessie Berlin
REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on
Modified: trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name-expected.txt (89478 => 89479)
--- trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name-expected.txt 2011-06-22 21:14:38 UTC (rev 89478)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name-expected.txt 2011-06-22 21:23:16 UTC (rev 89479)
@@ -12,9 +12,9 @@
request = db.setVersion('1')
Deleted all object stores.
objectStore = db.createObjectStore('a', { keyPath: 'id', autoIncrement: true });
-Expecting exception from index = objectStore.createIndex(null, null);
-PASS Exception was thrown.
-PASS code is IDBDatabaseException.NON_TRANSIENT_ERR
+index = objectStore.createIndex(null, null);
+PASS index.name is 'null'
+PASS index.keyPath is 'null'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name.html (89478 => 89479)
--- trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name.html 2011-06-22 21:14:38 UTC (rev 89478)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/create-index-null-name.html 2011-06-22 21:23:16 UTC (rev 89479)
@@ -50,7 +50,9 @@
objectStore = evalAndLog("objectStore = db.createObjectStore('a', { keyPath: 'id', autoIncrement: true });");
-index = evalAndExpectException("index = objectStore.createIndex(null, null);", "IDBDatabaseException.NON_TRANSIENT_ERR");
+index = evalAndLog("index = objectStore.createIndex(null, null);");
+shouldBe("index.name", "'null'");
+shouldBe("index.keyPath", "'null'");
done();
}
Modified: trunk/Source/WebCore/ChangeLog (89478 => 89479)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 21:14:38 UTC (rev 89478)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 21:23:16 UTC (rev 89479)
@@ -1,3 +1,13 @@
+2011-06-22 Mark Pilgrim
+
+Reviewed by Adam Barth.
+
+IndexedDB createIndex should NOT throw if name arg is null
+https://bugs.webkit.org/show_bug.cgi?id=63114
+
+* storage/IDBObjectStore.idl: remove ConvertNullToNullString flag
+so null values will be stringified as "null", as per WebIDL spec.
+
2011-06-22 Chris Rogers
Reviewed by Kenneth Russell.
Modified: trunk/Source/WebCore/storage/IDBObjectStore.idl (89478 => 89479)
--- trunk/Source/WebCore/storage/IDBObjectStore.idl 2011-06-22 21:14:38 UTC (rev 89478)
+++ trunk/Source/WebCore/storage/IDBObjectStore.idl 2011-06-22 21:23:16 UTC (rev 89479)
@@ -44,7 +44,7 @@
raises (IDBDatabaseException);
[CallWith=ScriptExecutionContext] IDBRequest openCursor(in [Optional] IDBKeyRange range, in [Optional] unsigned short direction)
raises (IDBDatabaseException);
-IDBIndex createIndex(in [ConvertNullToNullString] DOMString name, in [ConvertNullToNullString] DOMString keyPath, in [Optional] OptionsObject options)
+IDBIndex createIndex(in DOMString name, in DOMString keyPath, in [Optional] OptionsObject options)
raises (IDBDatabaseException);
IDBIndex index(in DOMString name)
raises (IDBDatabaseException);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listi
[webkit-changes] [89478] trunk/Source/WebCore
Title: [89478] trunk/Source/WebCore Revision 89478 Author crog...@google.com Date 2011-06-22 14:14:38 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Chris Rogers Reviewed by Kenneth Russell. AudioContext needs non-blocking call to create AudioBuffer from audio file data https://bugs.webkit.org/show_bug.cgi?id=61947 No new tests since audio API is not yet implemented. * DerivedSources.make: * WebCore.gypi: * WebCore.xcodeproj/project.pbxproj: * webaudio/AsyncAudioDecoder.cpp: Added. (WebCore::AsyncAudioDecoder::AsyncAudioDecoder): (WebCore::AsyncAudioDecoder::~AsyncAudioDecoder): (WebCore::AsyncAudioDecoder::decodeAsync): (WebCore::AsyncAudioDecoder::threadEntry): (WebCore::AsyncAudioDecoder::runLoop): (WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask): (WebCore::AsyncAudioDecoder::DecodingTask::decode): (WebCore::AsyncAudioDecoder::DecodingTask::notifyCompleteDispatch): (WebCore::AsyncAudioDecoder::DecodingTask::notifyComplete): * webaudio/AsyncAudioDecoder.h: Added. (WebCore::AsyncAudioDecoder::DecodingTask::audioData): (WebCore::AsyncAudioDecoder::DecodingTask::sampleRate): (WebCore::AsyncAudioDecoder::DecodingTask::successCallback): (WebCore::AsyncAudioDecoder::DecodingTask::errorCallback): (WebCore::AsyncAudioDecoder::DecodingTask::audioBuffer): * webaudio/AudioBufferCallback.h: Added. (WebCore::AudioBufferCallback::~AudioBufferCallback): * webaudio/AudioBufferCallback.idl: Added. * webaudio/AudioContext.cpp: (WebCore::AudioContext::decodeAudioData): * webaudio/AudioContext.h: * webaudio/AudioContext.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/webaudio/AudioContext.cpp trunk/Source/WebCore/webaudio/AudioContext.h trunk/Source/WebCore/webaudio/AudioContext.idl Added Paths trunk/Source/WebCore/webaudio/AsyncAudioDecoder.cpp trunk/Source/WebCore/webaudio/AsyncAudioDecoder.h trunk/Source/WebCore/webaudio/AudioBufferCallback.h trunk/Source/WebCore/webaudio/AudioBufferCallback.idl Diff Modified: trunk/Source/WebCore/ChangeLog (89477 => 89478) --- trunk/Source/WebCore/ChangeLog 2011-06-22 20:55:48 UTC (rev 89477) +++ trunk/Source/WebCore/ChangeLog 2011-06-22 21:14:38 UTC (rev 89478) @@ -1,3 +1,39 @@ +2011-06-22 Chris Rogers + +Reviewed by Kenneth Russell. + +AudioContext needs non-blocking call to create AudioBuffer from audio file data +https://bugs.webkit.org/show_bug.cgi?id=61947 + +No new tests since audio API is not yet implemented. + +* DerivedSources.make: +* WebCore.gypi: +* WebCore.xcodeproj/project.pbxproj: +* webaudio/AsyncAudioDecoder.cpp: Added. +(WebCore::AsyncAudioDecoder::AsyncAudioDecoder): +(WebCore::AsyncAudioDecoder::~AsyncAudioDecoder): +(WebCore::AsyncAudioDecoder::decodeAsync): +(WebCore::AsyncAudioDecoder::threadEntry): +(WebCore::AsyncAudioDecoder::runLoop): +(WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask): +(WebCore::AsyncAudioDecoder::DecodingTask::decode): +(WebCore::AsyncAudioDecoder::DecodingTask::notifyCompleteDispatch): +(WebCore::AsyncAudioDecoder::DecodingTask::notifyComplete): +* webaudio/AsyncAudioDecoder.h: Added. +(WebCore::AsyncAudioDecoder::DecodingTask::audioData): +(WebCore::AsyncAudioDecoder::DecodingTask::sampleRate): +(WebCore::AsyncAudioDecoder::DecodingTask::successCallback): +(WebCore::AsyncAudioDecoder::DecodingTask::errorCallback): +(WebCore::AsyncAudioDecoder::DecodingTask::audioBuffer): +* webaudio/AudioBufferCallback.h: Added. +(WebCore::AudioBufferCallback::~AudioBufferCallback): +* webaudio/AudioBufferCallback.idl: Added. +* webaudio/AudioContext.cpp: +(WebCore::AudioContext::decodeAudioData): +* webaudio/AudioContext.h: +* webaudio/AudioContext.idl: + 2011-06-22 Beth Dakin Reviewed by Simon Fraser. Modified: trunk/Source/WebCore/DerivedSources.make (89477 => 89478) --- trunk/Source/WebCore/DerivedSources.make 2011-06-22 20:55:48 UTC (rev 89477) +++ trunk/Source/WebCore/DerivedSources.make 2011-06-22 21:14:38 UTC (rev 89478) @@ -55,6 +55,7 @@ AbstractWorker \ Attr \ AudioBuffer \ +AudioBufferCallback \ AudioBufferSourceNode \ AudioChannelSplitter \ AudioChannelMerger \ Modified: trunk/Source/WebCore/WebCore.gypi (89477 => 89478) --- trunk/Source/WebCore/WebCore.gypi 2011-06-22 20:55:48 UTC (rev 89477) +++ trunk/Source/WebCore/WebCore.gypi 2011-06-22 21:14:38 UTC (rev 89478) @@ -1415,6 +1415,7 @@ 'storage/StorageInfoQ
[webkit-changes] [89477] trunk/LayoutTests
Title: [89477] trunk/LayoutTests Revision 89477 Author jber...@webkit.org Date 2011-06-22 13:55:48 -0700 (Wed, 22 Jun 2011) Log Message REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on SnowLeopard Intel Release (Tests), Windows 7 Release (Tests). https://bugs.webkit.org/show_bug.cgi?id=63178 Add failing expected results in order to get the bots green. * platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (89476 => 89477) --- trunk/LayoutTests/ChangeLog 2011-06-22 20:44:42 UTC (rev 89476) +++ trunk/LayoutTests/ChangeLog 2011-06-22 20:55:48 UTC (rev 89477) @@ -1,3 +1,13 @@ +2011-06-22 Jessie Berlin + +REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on +SnowLeopard Intel Release (Tests), Windows 7 Release (Tests). +https://bugs.webkit.org/show_bug.cgi?id=63178 + +Add failing expected results in order to get the bots green. + +* platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt: Added. + 2011-06-22 Tony Chang Add test that got renamed. Should have been included with r89466. Added: trunk/LayoutTests/platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt (0 => 89477) --- trunk/LayoutTests/platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt 2011-06-22 20:55:48 UTC (rev 89477) @@ -0,0 +1,22 @@ +Tests WebInspector extension API + +Page reloaded. +Started extension. +Running tests... +RUNNING TEST: extension_testGetRedirectResourceContent +content: null, encoding: +RUNNING TEST: extension_testRedirectResourceFinished +Finished resource: http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?status=302 +Finished resource: http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?redirected=true +RUNNING TEST: extension_testRedirectResourcesInHAR +Resources in HAR: +http://127.0.0.1:8000/inspector/extensions-resources-redirect.html +http://127.0.0.1:8000/inspector/extensions-resources-test.js +http://127.0.0.1:8000/inspector/extensions-test.js +http://127.0.0.1:8000/inspector/inspector-test.js +http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?redirected=true +http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?redirected=true +http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?status=302 +http://127.0.0.1:8000/loading/resources/redirect-methods-result.php?status=302 +All tests done. + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89476] trunk/LayoutTests
Title: [89476] trunk/LayoutTests
Revision 89476
Author t...@chromium.org
Date 2011-06-22 13:44:42 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Tony Chang
Add test that got renamed. Should have been included with r89466.
* storage/indexeddb/keypath-basics.html: Renamed from LayoutTests/storage/indexeddb/keypath-as-array.html.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/storage/indexeddb/keypath-basics.html
Removed Paths
trunk/LayoutTests/storage/indexeddb/keypath-as-array.html
Diff
Modified: trunk/LayoutTests/ChangeLog (89475 => 89476)
--- trunk/LayoutTests/ChangeLog 2011-06-22 20:43:11 UTC (rev 89475)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 20:44:42 UTC (rev 89476)
@@ -1,3 +1,9 @@
+2011-06-22 Tony Chang
+
+Add test that got renamed. Should have been included with r89466.
+
+* storage/indexeddb/keypath-basics.html: Renamed from LayoutTests/storage/indexeddb/keypath-as-array.html.
+
2011-06-22 Beth Dakin
Reviewed by Simon Fraser.
Deleted: trunk/LayoutTests/storage/indexeddb/keypath-as-array.html (89475 => 89476)
--- trunk/LayoutTests/storage/indexeddb/keypath-as-array.html 2011-06-22 20:43:11 UTC (rev 89475)
+++ trunk/LayoutTests/storage/indexeddb/keypath-as-array.html 2011-06-22 20:44:42 UTC (rev 89476)
@@ -1,65 +0,0 @@
-
-
-
-
-
-
-
-
-
-description("Test IndexedDB key path corner cases");
-if (window.layoutTestController)
-layoutTestController.waitUntilDone();
-
-function test()
-{
-indexedDB = evalAndLog("indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;");
-shouldBeFalse("indexedDB == null");
-IDBDatabaseException = evalAndLog("IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;");
-shouldBeFalse("IDBDatabaseException == null");
-IDBCursor = evalAndLog("IDBCursor = window.IDBCursor || window.webkitIDBCursor;");
-shouldBeFalse("IDBCursor == null");
-IDBKeyRange = evalAndLog("IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;");
-shouldBeFalse("IDBKeyRange == null");
-
-name = window.location.pathname;
-description = "My Test Database";
-request = evalAndLog("indexedDB.open(name, description)");
-request._onsuccess_ = openSuccess;
-request._onerror_ = unexpectedErrorCallback;
-}
-
-function openSuccess()
-{
-db = evalAndLog("db = event.target.result");
-
-request = evalAndLog("request = db.setVersion('1')");
-request._onsuccess_ = testGroup1;
-request._onerror_ = unexpectedErrorCallback;
-}
-
-function testGroup1()
-{
-deleteAllObjectStores(db);
-
-debug("test keypath as array");
-evalAndLog("db.createObjectStore('foo', {keyPath: ['foo'], autoIncrement: true})");
-evalAndLog("db.createObjectStore('foobar', {keyPath: ['foo', 'bar'], autoIncrement: true})");
-evalAndLog("db.createObjectStore('empty', {keyPath: [], autoIncrement: true})");
-evalAndLog("db.createObjectStore('nested', {keyPath: [[]], autoIncrement: true})");
-evalAndLog("db.createObjectStore('arrayofempty', {keyPath: ['', ''], autoIncrement: true})");
-evalAndLog("db.createObjectStore('arrayoffloat', {keyPath: [1.0, 2.0], autoIncrement: true})");
-done();
-}
-
-var successfullyParsed = true;
-
-test();
-
-
-
-
Copied: trunk/LayoutTests/storage/indexeddb/keypath-basics.html (from rev 89475, trunk/LayoutTests/storage/indexeddb/keypath-as-array.html) (0 => 89476)
--- trunk/LayoutTests/storage/indexeddb/keypath-basics.html (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/keypath-basics.html 2011-06-22 20:44:42 UTC (rev 89476)
@@ -0,0 +1,79 @@
+
+
+
+
+
+
+
+
+
+description("Test for valid and invalid keypaths");
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+function test()
+{
+indexedDB = evalAndLog("indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;");
+shouldBeFalse("indexedDB == null");
+IDBDatabaseException = evalAndLog("IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;");
+shouldBeFalse("IDBDatabaseException == null");
+IDBCursor = evalAndLog("IDBCursor = window.IDBCursor || window.webkitIDBCursor;");
+shouldBeFalse("IDBCursor == null");
+IDBKeyRange = evalAndLog("IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;");
+shouldBeFalse("IDBKeyRange == null");
+
+name = window.location.pathname;
+description = "My Test Database";
+request = evalAndLog("indexedDB.open(name, description)");
+request._onsuccess_ = openSuccess;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function openSuccess()
+{
+db = evalAndLog("db = event.target.result");
+
+request = evalAndLog("request = db.setVersion('1')");
+request._onsuccess_ = testValidKeyPaths;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function testValidKeyPaths()
+{
+deleteAllObjectSt
[webkit-changes] [89475] trunk
Title: [89475] trunk
Revision 89475
Author bda...@apple.com
Date 2011-06-22 13:43:11 -0700 (Wed, 22 Jun 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=63174
Don't draw the borders as one path unless there really are 4 borders
-and corresponding-
Reviewed by Simon Fraser.
Source/WebCore:
If any of the border edges have no width, then allEdgesVisible should be set to
false since borders without width will not be visible.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
LayoutTests:
* fast/borders/only-one-border-with-width.html: Added.
* platform/mac/fast/borders/only-one-border-with-width-expected.png: Added.
* platform/mac/fast/borders/only-one-border-with-width-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
Added Paths
trunk/LayoutTests/fast/borders/only-one-border-with-width.html
trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.png
trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (89474 => 89475)
--- trunk/LayoutTests/ChangeLog 2011-06-22 20:39:01 UTC (rev 89474)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 20:43:11 UTC (rev 89475)
@@ -1,3 +1,16 @@
+2011-06-22 Beth Dakin
+
+Reviewed by Simon Fraser.
+
+https://bugs.webkit.org/show_bug.cgi?id=63174
+Don't draw the borders as one path unless there really are 4 borders
+-and corresponding-
+
+
+* fast/borders/only-one-border-with-width.html: Added.
+* platform/mac/fast/borders/only-one-border-with-width-expected.png: Added.
+* platform/mac/fast/borders/only-one-border-with-width-expected.txt: Added.
+
2011-06-22 Matthew Delaney
Reviewed by Oliver Hunt.
Added: trunk/LayoutTests/fast/borders/only-one-border-with-width.html (0 => 89475)
--- trunk/LayoutTests/fast/borders/only-one-border-with-width.html (rev 0)
+++ trunk/LayoutTests/fast/borders/only-one-border-with-width.html 2011-06-22 20:43:11 UTC (rev 89475)
@@ -0,0 +1,25 @@
+
+
+
+
+
+
+div {
+ margin: 20px;
+ box-sizing: border-box;
+ display: block;
+ width: 100px;
+ min-height: 50px;
+ border-right: 5px solid rgba(0, 0, 0, 0.15);
+ border-radius: 10px;
+ border-bottom-right-radius: 0px 0px;
+ border-top-right-radius: 0px 0px;
+}
+
+
+
+
+
+
+
+
Added: trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.txt (0 => 89475)
--- trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.txt 2011-06-22 20:43:11 UTC (rev 89475)
@@ -0,0 +1,6 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x90
+ RenderBlock {HTML} at (0,0) size 800x90
+RenderBody {BODY} at (8,20) size 784x50
+ RenderBlock {DIV} at (20,0) size 100x50 [border: (5px solid #0026) none]
Modified: trunk/Source/WebCore/ChangeLog (89474 => 89475)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 20:39:01 UTC (rev 89474)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 20:43:11 UTC (rev 89475)
@@ -1,3 +1,17 @@
+2011-06-22 Beth Dakin
+
+Reviewed by Simon Fraser.
+
+https://bugs.webkit.org/show_bug.cgi?id=63174
+Don't draw the borders as one path unless there really are 4 borders
+-and corresponding-
+
+
+If any of the border edges have no width, then allEdgesVisible should be set to
+false since borders without width will not be visible.
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::paintBorder):
+
2011-06-22 Matthew Delaney
Reviewed by Oliver Hunt.
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (89474 => 89475)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2011-06-22 20:39:01 UTC (rev 89474)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2011-06-22 20:43:11 UTC (rev 89475)
@@ -1383,8 +1383,10 @@
continue;
}
-if (!currEdge.width)
+if (!currEdge.width) {
+allEdgesVisible = false;
continue;
+}
if (firstVisibleEdge == -1)
firstVisibleEdge = i;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-chan
[webkit-changes] [89474] trunk
Title: [89474] trunk
Revision 89474
Author mdela...@apple.com
Date 2011-06-22 13:39:01 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Matthew Delaney
Reviewed by Oliver Hunt.
Canvas in layer obscures overlapping span
https://bugs.webkit.org/show_bug.cgi?id=63161
Test: compositing/layer-creation/spanOverlapsCanvas.html
* rendering/RenderLayer.cpp: Added checks for canvas to be layered properly.
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::isSelfPaintingLayer):
2011-06-22 Matthew Delaney
Reviewed by Oliver Hunt.
Canvas in layer obscures overlapping span
https://bugs.webkit.org/show_bug.cgi?id=63161
* compositing/layer-creation/spanOverlapsCanvas.html: Added.
* platform/mac/compositing/layer-creation: Added.
* platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
* platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html
trunk/LayoutTests/platform/mac/compositing/layer-creation/
trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png
trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (89473 => 89474)
--- trunk/LayoutTests/ChangeLog 2011-06-22 20:35:27 UTC (rev 89473)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 20:39:01 UTC (rev 89474)
@@ -1,3 +1,15 @@
+2011-06-22 Matthew Delaney
+
+Reviewed by Oliver Hunt.
+
+Canvas in layer obscures overlapping span
+https://bugs.webkit.org/show_bug.cgi?id=63161
+
+* compositing/layer-creation/spanOverlapsCanvas.html: Added.
+* platform/mac/compositing/layer-creation: Added.
+* platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
+* platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
+
2011-06-22 Jessie Berlin
REGRESSION (r89426-r89428): inspector/console/console-trace-in-eval.html failing on
Added: trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html (0 => 89474)
--- trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html (rev 0)
+++ trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html 2011-06-22 20:39:01 UTC (rev 89474)
@@ -0,0 +1,30 @@
+
+
+
+
+
+
+
+ window.layoutTestController && window.layoutTestController.layerTreeAsText();
+
+ function init() {
+ var ctx = document.getElementById("world").getContext("2d");
+ ctx.fillStyle = "red";
+ ctx.fillRect(0,0,ctx.canvas.width,ctx.canvas.height);
+ }
+
+
+
+#headerbar {
+width: 100px;
+height: 50px;
+background-color: green;
+position: absolute;
+}
+
+
+
+
+
+
+
Added: trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt (0 => 89474)
--- trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt 2011-06-22 20:39:01 UTC (rev 89474)
@@ -0,0 +1,10 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x70
+ RenderBlock {HTML} at (0,0) size 800x70
+RenderBody {BODY} at (8,8) size 784x54
+ RenderText {#text} at (0,0) size 0x0
+layer at (8,8) size 100x50
+ RenderHTMLCanvas {CANVAS} at (0,0) size 100x50
+layer at (8,8) size 100x50
+ RenderBlock (positioned) {DIV} at (8,8) size 100x50 [bgcolor=#008000]
Modified: trunk/Source/WebCore/ChangeLog (89473 => 89474)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 20:35:27 UTC (rev 89473)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 20:39:01 UTC (rev 89474)
@@ -1,3 +1,16 @@
+2011-06-22 Matthew Delaney
+
+Reviewed by Oliver Hunt.
+
+Canvas in layer obscures overlapping span
+https://bugs.webkit.org/show_bug.cgi?id=63161
+
+Test: compositing/layer-creation/spanOverlapsCanvas.html
+
+* rendering/RenderLayer.cpp: Added checks for canvas to be layered properly.
+(WebCore::RenderLayer::shouldBeNormalFlowOnly):
+(WebCore::RenderLayer::isSelfPaintingLayer):
+
2011-06-22 Chris Rogers
Reviewed by Kenneth Russell.
Modified: trunk/Source/W
[webkit-changes] [89473] trunk/LayoutTests
Title: [89473] trunk/LayoutTests Revision 89473 Author jber...@webkit.org Date 2011-06-22 13:35:27 -0700 (Wed, 22 Jun 2011) Log Message REGRESSION (r89426-r89428): inspector/console/console-trace-in-eval.html failing on SnowLeopard Intel Release (Tests) and Windows 7 Release (Tests). https://bugs.webkit.org/show_bug.cgi?id=63175 Add platform-specific results to in order to get the bots green. * platform/mac/inspector/console: Added. * platform/mac/inspector/console/console-trace-in-eval-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/mac/inspector/console/ trunk/LayoutTests/platform/mac/inspector/console/console-trace-in-eval-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (89472 => 89473) --- trunk/LayoutTests/ChangeLog 2011-06-22 20:29:58 UTC (rev 89472) +++ trunk/LayoutTests/ChangeLog 2011-06-22 20:35:27 UTC (rev 89473) @@ -1,5 +1,16 @@ 2011-06-22 Jessie Berlin +REGRESSION (r89426-r89428): inspector/console/console-trace-in-eval.html failing on +SnowLeopard Intel Release (Tests) and Windows 7 Release (Tests). +https://bugs.webkit.org/show_bug.cgi?id=63175 + +Add platform-specific results to in order to get the bots green. + +* platform/mac/inspector/console: Added. +* platform/mac/inspector/console/console-trace-in-eval-expected.txt: Added. + +2011-06-22 Jessie Berlin + WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks. https://bugs.webkit.org/show_bug.cgi?id=42331 Added: trunk/LayoutTests/platform/mac/inspector/console/console-trace-in-eval-expected.txt (0 => 89473) --- trunk/LayoutTests/platform/mac/inspector/console/console-trace-in-eval-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac/inspector/console/console-trace-in-eval-expected.txt 2011-06-22 20:35:27 UTC (rev 89473) @@ -0,0 +1,4 @@ +Tests that when console.trace is called in eval'ed script ending with //@ sourceURL=url it will dump a stack trace that will have the url as the script source. Bug 47252. + +console.trace()baevalSource + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89472] trunk/Source
Title: [89472] trunk/Source
Revision 89472
Author gga...@apple.com
Date 2011-06-22 13:29:58 -0700 (Wed, 22 Jun 2011)
Log Message
Source/_javascript_Core: * interpreter/RegisterFile.h: Removed unnecessary #include .
Reviewed by Oliver Hunt.
Source/WebKit2: Removed unnecessary #include .
Reviewed by Oliver Hunt.
* PluginProcess/mac/PluginProcessMainMac.mm:
* Shared/WebMemorySampler.cpp:
* UIProcess/WebFrameProxy.cpp:
* UIProcess/WebProcessProxy.cpp:
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
* WebProcess/mac/WebProcessMac.mm: Added #include back to places where it
was needed.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/RegisterFile.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm
trunk/Source/WebKit2/Shared/WebMemorySampler.cpp
trunk/Source/WebKit2/UIProcess/WebFrameProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp
trunk/Source/WebKit2/WebProcess/mac/WebProcessMac.mm
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (89471 => 89472)
--- trunk/Source/_javascript_Core/ChangeLog 2011-06-22 20:17:16 UTC (rev 89471)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-06-22 20:29:58 UTC (rev 89472)
@@ -2,6 +2,12 @@
Reviewed by Oliver Hunt.
+* interpreter/RegisterFile.h: Removed unnecessary #include .
+
+2011-06-22 Geoffrey Garen
+
+Reviewed by Oliver Hunt.
+
Removed the conceit that global variables are local variables when running global code
https://bugs.webkit.org/show_bug.cgi?id=63106
Modified: trunk/Source/_javascript_Core/interpreter/RegisterFile.h (89471 => 89472)
--- trunk/Source/_javascript_Core/interpreter/RegisterFile.h 2011-06-22 20:17:16 UTC (rev 89471)
+++ trunk/Source/_javascript_Core/interpreter/RegisterFile.h 2011-06-22 20:29:58 UTC (rev 89472)
@@ -34,7 +34,6 @@
#include
#include
#include
-#include
namespace JSC {
Modified: trunk/Source/WebKit2/ChangeLog (89471 => 89472)
--- trunk/Source/WebKit2/ChangeLog 2011-06-22 20:17:16 UTC (rev 89471)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-22 20:29:58 UTC (rev 89472)
@@ -1,3 +1,17 @@
+2011-06-22 Geoffrey Garen
+
+Reviewed by Oliver Hunt.
+
+Removed unnecessary #include .
+
+* PluginProcess/mac/PluginProcessMainMac.mm:
+* Shared/WebMemorySampler.cpp:
+* UIProcess/WebFrameProxy.cpp:
+* UIProcess/WebProcessProxy.cpp:
+* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
+* WebProcess/mac/WebProcessMac.mm: Added #include back to places where it
+was needed.
+
2011-06-22 Balazs Kelemen
Unreviewed build fix after r89461.
Modified: trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm (89471 => 89472)
--- trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm 2011-06-22 20:17:16 UTC (rev 89471)
+++ trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm 2011-06-22 20:29:58 UTC (rev 89472)
@@ -39,6 +39,7 @@
#import
#import
#import
+#include
// FIXME: We should be doing this another way.
extern "C" kern_return_t bootstrap_look_up2(mach_port_t, const name_t, mach_port_t*, pid_t, uint64_t);
Modified: trunk/Source/WebKit2/Shared/WebMemorySampler.cpp (89471 => 89472)
--- trunk/Source/WebKit2/Shared/WebMemorySampler.cpp 2011-06-22 20:17:16 UTC (rev 89471)
+++ trunk/Source/WebKit2/Shared/WebMemorySampler.cpp 2011-06-22 20:29:58 UTC (rev 89472)
@@ -28,6 +28,7 @@
#if ENABLE(MEMORY_SAMPLER)
+#include
#include
using namespace WebCore;
Modified: trunk/Source/WebKit2/UIProcess/WebFrameProxy.cpp (89471 => 89472)
--- trunk/Source/WebKit2/UIProcess/WebFrameProxy.cpp 2011-06-22 20:17:16 UTC (rev 89471)
+++ trunk/Source/WebKit2/UIProcess/WebFrameProxy.cpp 2011-06-22 20:29:58 UTC (rev 89472)
@@ -34,6 +34,7 @@
#include "WebPageProxy.h"
#include
#include
+#include
#include
using namespace WebCore;
Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (89471 => 89472)
--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2011-06-22 20:17:16 UTC (rev 89471)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp 2011-06-22 20:29:58 UTC (rev 89472)
@@ -38,6 +38,7 @@
#include "WebProcessMessages.h"
#include "WebProcessProxyMessages.h"
#include
+#include
#include
#include
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp (89471 => 89472)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp 2011-06-22 20:17:16 UTC (rev 89471)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp 2011-06-22 20:29:58 UTC (rev 89472)
@@ -28,6 +28,7 @@
#include "WKBundleAPICast.h"
#include "WKBundleInitialize.h"
+#include
#include
#include
#include
Modified: trunk/Source/WebKit2/WebProcess/mac/WebProcessMac.mm (89471 => 89472)
--- trunk/Source/We
[webkit-changes] [89471] trunk/Source/WebCore
Title: [89471] trunk/Source/WebCore
Revision 89471
Author crog...@google.com
Date 2011-06-22 13:17:16 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Chris Rogers
Reviewed by Kenneth Russell.
AudioContext noteGrainOn() method should not apply explicit windowing
https://bugs.webkit.org/show_bug.cgi?id=63005
No new tests since audio API is not yet implemented.
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::readFromBuffer):
* webaudio/AudioBufferSourceNode.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AudioBufferSourceNode.cpp
trunk/Source/WebCore/webaudio/AudioBufferSourceNode.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (89470 => 89471)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 20:15:05 UTC (rev 89470)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 20:17:16 UTC (rev 89471)
@@ -1,3 +1,16 @@
+2011-06-22 Chris Rogers
+
+Reviewed by Kenneth Russell.
+
+AudioContext noteGrainOn() method should not apply explicit windowing
+https://bugs.webkit.org/show_bug.cgi?id=63005
+
+No new tests since audio API is not yet implemented.
+
+* webaudio/AudioBufferSourceNode.cpp:
+(WebCore::AudioBufferSourceNode::readFromBuffer):
+* webaudio/AudioBufferSourceNode.h:
+
2011-06-22 Kentaro Hara
Reviewed by Tony Chang.
Modified: trunk/Source/WebCore/webaudio/AudioBufferSourceNode.cpp (89470 => 89471)
--- trunk/Source/WebCore/webaudio/AudioBufferSourceNode.cpp 2011-06-22 20:15:05 UTC (rev 89470)
+++ trunk/Source/WebCore/webaudio/AudioBufferSourceNode.cpp 2011-06-22 20:17:16 UTC (rev 89471)
@@ -323,44 +323,15 @@
if (!isDestinationGood)
return;
-if (m_isGrain)
-readFromBufferWithGrainEnvelope(sourceL, sourceR, destinationL, destinationR, framesToProcess);
-else {
-// Simply copy the data from the source buffer to the destination.
-memcpy(destinationL, sourceL, sizeof(float) * framesToProcess);
-if (numberOfChannels == 2)
-memcpy(destinationR, sourceR, sizeof(float) * framesToProcess);
-}
+// Simply copy the data from the source buffer to the destination.
+memcpy(destinationL, sourceL, sizeof(float) * framesToProcess);
+if (numberOfChannels == 2)
+memcpy(destinationR, sourceR, sizeof(float) * framesToProcess);
// Advance the buffer's read index.
m_readIndex += framesToProcess;
}
-void AudioBufferSourceNode::readFromBufferWithGrainEnvelope(float* sourceL, float* sourceR, float* destinationL, float* destinationR, size_t framesToProcess)
-{
-ASSERT(sourceL && destinationL);
-if (!sourceL || !destinationL)
-return;
-
-int grainFrameLength = static_cast(m_grainDuration * m_buffer->sampleRate());
-bool isStereo = sourceR && destinationR;
-
-int n = framesToProcess;
-while (n--) {
-// Apply the grain envelope.
-float x = static_cast(m_grainFrameCount) / static_cast(grainFrameLength);
-m_grainFrameCount++;
-
-x = min(1.0f, x);
-float grainEnvelope = sinf(piFloat * x);
-
-*destinationL++ = grainEnvelope * *sourceL++;
-
-if (isStereo)
-*destinationR++ = grainEnvelope * *sourceR++;
-}
-}
-
void AudioBufferSourceNode::reset()
{
m_resampler.reset();
Modified: trunk/Source/WebCore/webaudio/AudioBufferSourceNode.h (89470 => 89471)
--- trunk/Source/WebCore/webaudio/AudioBufferSourceNode.h 2011-06-22 20:15:05 UTC (rev 89470)
+++ trunk/Source/WebCore/webaudio/AudioBufferSourceNode.h 2011-06-22 20:17:16 UTC (rev 89471)
@@ -143,9 +143,6 @@
// A grain envelope will be applied if m_isGrain is set to true.
void readFromBuffer(AudioBus* destinationBus, size_t framesToProcess);
-// readFromBufferWithGrainEnvelope() is a low-level blitter which reads from the AudioBuffer and applies a grain envelope.
-void readFromBufferWithGrainEnvelope(float* sourceL, float* sourceR, float* destinationL, float* destinationR, size_t framesToProcess);
-
// Handles the time when we reach the end of sample data (non-looping) or the noteOff() time has been reached.
void finish();
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89469] trunk/Source/WebKit/mac
Title: [89469] trunk/Source/WebKit/mac
Revision 89469
Author wei...@apple.com
Date 2011-06-22 13:13:53 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Sam Weinig
Reviewed by Adam Barth.
Add preference for setting the html parser depth limit
https://bugs.webkit.org/show_bug.cgi?id=63163
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]):
(-[WebPreferences maximumHTMLParserDOMTreeDepth]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Add private preference for setting the parser depth limit.
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (89468 => 89469)
--- trunk/Source/WebKit/mac/ChangeLog 2011-06-22 20:12:01 UTC (rev 89468)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-06-22 20:13:53 UTC (rev 89469)
@@ -1,3 +1,20 @@
+2011-06-22 Sam Weinig
+
+Reviewed by Adam Barth.
+
+Add preference for setting the html parser depth limit
+https://bugs.webkit.org/show_bug.cgi?id=63163
+
+* WebView/WebPreferenceKeysPrivate.h:
+* WebView/WebPreferences.mm:
+(+[WebPreferences initialize]):
+(-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]):
+(-[WebPreferences maximumHTMLParserDOMTreeDepth]):
+* WebView/WebPreferencesPrivate.h:
+* WebView/WebView.mm:
+(-[WebView _preferencesChanged:]):
+Add private preference for setting the parser depth limit.
+
2011-06-22 Ryosuke Niwa
Reviewed by Darin Adler.
Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (89468 => 89469)
--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2011-06-22 20:12:01 UTC (rev 89468)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2011-06-22 20:13:53 UTC (rev 89469)
@@ -120,6 +120,7 @@
#define WebKitTextDirectionSubmenuInclusionBehaviorPreferenceKey @"WebKitTextDirectionSubmenuInclusionBehaviorPreferenceKey"
#define WebKitEditingBehaviorPreferenceKey @"WebKitEditingBehavior"
#define WebKitUsePreHTML5ParserQuirksKey @"WebKitUsePreHTML5ParserQuirks"
+#define WebKitMaximumHTMLParserDOMTreeDepthKey @"WebKitMaximumHTMLParserDOMTreeDepth"
// CoreGraphics deferred updates are disabled if WebKitEnableCoalescedUpdatesPreferenceKey is set
// to NO, or has no value. For compatibility with Mac OS X 10.4.6, deferred updates are OFF by
Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (89468 => 89469)
--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2011-06-22 20:12:01 UTC (rev 89468)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2011-06-22 20:13:53 UTC (rev 89469)
@@ -39,6 +39,7 @@
#import "WebNSDictionaryExtras.h"
#import "WebNSURLExtras.h"
#import
+#import
NSString *WebPreferencesChangedNotification = @"WebPreferencesChangedNotification";
NSString *WebPreferencesRemovedNotification = @"WebPreferencesRemovedNotification";
@@ -375,6 +376,7 @@
[NSNumber numberWithBool:NO], WebKitMemoryInfoEnabledPreferenceKey,
[NSNumber numberWithBool:YES], WebKitHyperlinkAuditingEnabledPreferenceKey,
[NSNumber numberWithBool:NO], WebKitUsePreHTML5ParserQuirksKey,
+[NSNumber numberWithUnsignedInt:WebCore::Settings::defaultMaximumHTMLParserDOMTreeDepth], WebKitMaximumHTMLParserDOMTreeDepthKey,
[NSNumber numberWithBool:YES], WebKitAVFoundationEnabledKey,
[NSNumber numberWithLongLong:WebCore::ApplicationCacheStorage::noQuota()], WebKitApplicationCacheTotalQuota,
[NSNumber numberWithLongLong:WebCore::ApplicationCacheStorage::noQuota()], WebKitApplicationCacheDefaultOriginQuota,
@@ -1408,6 +1410,16 @@
[self _setBoolValue:flag forKey:WebKitUsePreHTML5ParserQuirksKey];
}
+- (void)setMaximumHTMLParserDOMTreeDepth:(unsigned)depth
+{
+[self _setIntegerValue:depth forKey:WebKitMaximumHTMLParserDOMTreeDepthKey];
+}
+
+- (unsigned)maximumHTMLParserDOMTreeDepth
+{
+return [self _integerValueForKey:WebKitMaximumHTMLParserDOMTreeDepthKey];
+}
+
- (void)didRemoveFromWebView
{
ASSERT(_private->numWebViews);
Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (89468 => 89469)
--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2011-06-22 20:12:01 UTC (rev 89468)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2011-06-22 20:13:53 UTC (rev 89469)
@@ -238,6 +238,9 @@
- (void)setUsePreHTML5ParserQuirks:(BOOL)flag;
- (BOOL)usePreHTML5ParserQuirks;
+- (void)setMaximumHTMLParserDOMTreeDepth:(unsigned)depth;
+- (unsigned)maximumHTMLParserDOMTreeDepth;
+
- (void)setLoadsS
[webkit-changes] [89468] trunk/LayoutTests
Title: [89468] trunk/LayoutTests Revision 89468 Author jber...@webkit.org Date 2011-06-22 13:12:01 -0700 (Wed, 22 Jun 2011) Log Message WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks. https://bugs.webkit.org/show_bug.cgi?id=42331 Add another test that uses dumpFrameLoadCallbacks to the WK2 Skipped list. * platform/mac-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (89467 => 89468) --- trunk/LayoutTests/ChangeLog 2011-06-22 20:11:00 UTC (rev 89467) +++ trunk/LayoutTests/ChangeLog 2011-06-22 20:12:01 UTC (rev 89468) @@ -1,3 +1,12 @@ +2011-06-22 Jessie Berlin + +WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks. +https://bugs.webkit.org/show_bug.cgi?id=42331 + +Add another test that uses dumpFrameLoadCallbacks to the WK2 Skipped list. + +* platform/mac-wk2/Skipped: + 2011-06-22 Kentaro Hara Reviewed by Tony Chang. Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (89467 => 89468) --- trunk/LayoutTests/platform/mac-wk2/Skipped 2011-06-22 20:11:00 UTC (rev 89467) +++ trunk/LayoutTests/platform/mac-wk2/Skipped 2011-06-22 20:12:01 UTC (rev 89468) @@ -1102,6 +1102,7 @@ http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html +webarchive/loading/_javascript_-url-iframe-crash.html webarchive/loading/mainresource-null-mimetype-crash.html webarchive/loading/missing-data.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89467] trunk/Source/WebKit2
Title: [89467] trunk/Source/WebKit2
Revision 89467
Author kbal...@webkit.org
Date 2011-06-22 13:11:00 -0700 (Wed, 22 Jun 2011)
Log Message
Unreviewed build fix after r89461.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformSetFocus):
Forgot to name the parameter, fix it.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (89466 => 89467)
--- trunk/Source/WebKit2/ChangeLog 2011-06-22 20:09:05 UTC (rev 89466)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-22 20:11:00 UTC (rev 89467)
@@ -1,5 +1,13 @@
2011-06-22 Balazs Kelemen
+Unreviewed build fix after r89461.
+
+* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+(WebKit::NetscapePlugin::platformSetFocus):
+Forgot to name the parameter, fix it.
+
+2011-06-22 Balazs Kelemen
+
Reviewed by Darin Adler.
[X11][WK2] Implement NetscapePlugin::platformSetFocus
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (89466 => 89467)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-06-22 20:09:05 UTC (rev 89466)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-06-22 20:11:00 UTC (rev 89467)
@@ -433,7 +433,7 @@
return NPP_HandleEvent(&xEvent);
}
-void NetscapePlugin::platformSetFocus(bool)
+void NetscapePlugin::platformSetFocus(bool focusIn)
{
if (m_isWindowed)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89466] trunk
Title: [89466] trunk
Revision 89466
Author commit-qu...@webkit.org
Date 2011-06-22 13:09:05 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Kentaro Hara
Reviewed by Tony Chang.
Check |keypath| argument of createObjectStore(). Remove storage/indexeddb/keypath-as-array.html.
https://bugs.webkit.org/show_bug.cgi?id=63054
At the head of createObjectStore(), we parse |keypath| argument and throw an exception
if the |keypath| is invalid. With this parsing, we remove keypath-as-array.html because
the current keypath parser does not support an array of keypath and (more importantly)
the current implementation of ObjectStore does not support multiple keypaths.
We added keypath-basics.html that demonstrates that we do not support an array of keypaths.
* storage/indexeddb/keypath-as-array-expected.txt: Removed.
* storage/indexeddb/keypath-as-array.html: Removed.
* storage/indexeddb/keypath-basics-expected.txt: Added.
* storage/indexeddb/keypath-basics.html: Added.
2011-06-22 Kentaro Hara
Reviewed by Tony Chang.
Check |keypath| argument of createObjectStore(). Remove storage/indexeddb/keypath-as-array.html.
https://bugs.webkit.org/show_bug.cgi?id=63054
At the head of createObjectStore(), we parse |keypath| argument and throw an exception
if the |keypath| is invalid. With this parsing, we remove keypath-as-array.html because
the current keypath parser does not support an array of keypath and (more importantly)
the current implementation of ObjectStore does not support multiple keypaths.
We added keypath-basics.html that demonstrates that we do not support an array of keypaths.
Tests: storage/indexeddb/keypath-basics.html
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
* storage/IDBKeyPath.cpp:
(WebCore::IDBIsValidKeyPath):
* storage/IDBKeyPath.h:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBDatabase.cpp
trunk/Source/WebCore/storage/IDBKeyPath.cpp
trunk/Source/WebCore/storage/IDBKeyPath.h
Added Paths
trunk/LayoutTests/storage/indexeddb/keypath-basics-expected.txt
Removed Paths
trunk/LayoutTests/storage/indexeddb/keypath-as-array-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (89465 => 89466)
--- trunk/LayoutTests/ChangeLog 2011-06-22 20:07:37 UTC (rev 89465)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 20:09:05 UTC (rev 89466)
@@ -1,3 +1,21 @@
+2011-06-22 Kentaro Hara
+
+Reviewed by Tony Chang.
+
+Check |keypath| argument of createObjectStore(). Remove storage/indexeddb/keypath-as-array.html.
+https://bugs.webkit.org/show_bug.cgi?id=63054
+
+At the head of createObjectStore(), we parse |keypath| argument and throw an exception
+if the |keypath| is invalid. With this parsing, we remove keypath-as-array.html because
+the current keypath parser does not support an array of keypath and (more importantly)
+the current implementation of ObjectStore does not support multiple keypaths.
+We added keypath-basics.html that demonstrates that we do not support an array of keypaths.
+
+* storage/indexeddb/keypath-as-array-expected.txt: Removed.
+* storage/indexeddb/keypath-as-array.html: Removed.
+* storage/indexeddb/keypath-basics-expected.txt: Added.
+* storage/indexeddb/keypath-basics.html: Added.
+
2011-06-22 Geoffrey Garen
Reviewed by Oliver Hunt.
Deleted: trunk/LayoutTests/storage/indexeddb/keypath-as-array-expected.txt (89465 => 89466)
--- trunk/LayoutTests/storage/indexeddb/keypath-as-array-expected.txt 2011-06-22 20:07:37 UTC (rev 89465)
+++ trunk/LayoutTests/storage/indexeddb/keypath-as-array-expected.txt 2011-06-22 20:09:05 UTC (rev 89466)
@@ -1,28 +0,0 @@
-Test IndexedDB key path corner cases
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;
-PASS indexedDB == null is false
-IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;
-PASS IDBDatabaseException == null is false
-IDBCursor = window.IDBCursor || window.webkitIDBCursor;
-PASS IDBCursor == null is false
-IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;
-PASS IDBKeyRange == null is false
-indexedDB.open(name, description)
-db = event.target.result
-request = db.setVersion('1')
-Deleted all object stores.
-test keypath as array
-db.createObjectStore('foo', {keyPath: ['foo'], autoIncrement: true})
-db.createObjectStore('foobar', {keyPath: ['foo', 'bar'], autoIncrement: true})
-db.createObjectStore('empty', {keyPath: [], autoIncrement: true})
-db.createObjectStore('nested', {keyPath: [[]], autoIncrement: true})
-db.createObjectStore('arrayofempty', {keyPath: [
[webkit-changes] [89464] trunk/LayoutTests
Title: [89464] trunk/LayoutTests Revision 89464 Author jber...@webkit.org Date 2011-06-22 13:06:42 -0700 (Wed, 22 Jun 2011) Log Message REGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html failing on SnowLeopard Intel Release (Tests). https://bugs.webkit.org/show_bug.cgi?id=63169 Add (failing?) expected results to get the bots green. * platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (89463 => 89464) --- trunk/LayoutTests/ChangeLog 2011-06-22 20:04:09 UTC (rev 89463) +++ trunk/LayoutTests/ChangeLog 2011-06-22 20:06:42 UTC (rev 89464) @@ -1,3 +1,13 @@ +2011-06-22 Jessie Berlin + +REGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html failing +on SnowLeopard Intel Release (Tests). +https://bugs.webkit.org/show_bug.cgi?id=63169 + +Add (failing?) expected results to get the bots green. + +* platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Added. + 2011-06-22 Dmitry Titov [Chromium] Unreviewed update of test expectations. Added: trunk/LayoutTests/platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt (0 => 89464) --- trunk/LayoutTests/platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt 2011-06-22 20:06:42 UTC (rev 89464) @@ -0,0 +1,6 @@ +main frame - didStartProvisionalLoadForFrame +main frame - didCommitLoadForFrame +main frame - willPerformClientRedirectToURL: rchive +main frame - didFinishDocumentLoadForFrame +main frame - didFinishLoadForFrame + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89462] trunk
Title: [89462] trunk
Revision 89462
Author commit-qu...@webkit.org
Date 2011-06-22 12:57:13 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Young Han Lee
Reviewed by Simon Fraser.
animation-timing-function property with a list uses first item for all animations
https://bugs.webkit.org/show_bug.cgi?id=60303
When an element has multiple animations that have different timingFunctions,
the progress of each animation should be calculated using its respective timingFunction.
But at this point, the timingFunction of the first animation is only used for the
calculation, regardless of how many animations the element has.
The code for getting a timingFunction is changed by this patch
so that the timingFunction of the correct animation searched by its name will be used.
* animations/multiple-animations-timing-function-expected.txt: Added.
* animations/multiple-animations-timing-function.html: Added.
2011-06-22 Young Han Lee
Reviewed by Simon Fraser.
animation-timing-function property with a list uses first item for all animations
https://bugs.webkit.org/show_bug.cgi?id=60303
When an element has multiple animations that have different timingFunctions,
the progress of each animation should be calculated using its respective timingFunction.
But at this point, the timingFunction of the first animation is only used for the
calculation, regardless of how many animations the element has.
The code for getting a timingFunction is changed by this patch
so that the timingFunction of the correct animation searched by its name will be used.
Test: animations/multiple-animations-timing-function.html
* page/animation/KeyframeAnimation.cpp:
(WebCore::getAnimationFromStyleByName):
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp
Added Paths
trunk/LayoutTests/animations/multiple-animations-timing-function-expected.txt
trunk/LayoutTests/animations/multiple-animations-timing-function.html
Diff
Modified: trunk/LayoutTests/ChangeLog (89461 => 89462)
--- trunk/LayoutTests/ChangeLog 2011-06-22 19:55:35 UTC (rev 89461)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 19:57:13 UTC (rev 89462)
@@ -1,3 +1,21 @@
+2011-06-22 Young Han Lee
+
+Reviewed by Simon Fraser.
+
+animation-timing-function property with a list uses first item for all animations
+https://bugs.webkit.org/show_bug.cgi?id=60303
+
+When an element has multiple animations that have different timingFunctions,
+the progress of each animation should be calculated using its respective timingFunction.
+But at this point, the timingFunction of the first animation is only used for the
+calculation, regardless of how many animations the element has.
+
+The code for getting a timingFunction is changed by this patch
+so that the timingFunction of the correct animation searched by its name will be used.
+
+* animations/multiple-animations-timing-function-expected.txt: Added.
+* animations/multiple-animations-timing-function.html: Added.
+
2011-06-22 Sheriff Bot
Unreviewed, rolling out r89407, r89409, r89410, and r89411.
Added: trunk/LayoutTests/animations/multiple-animations-timing-function-expected.txt (0 => 89462)
--- trunk/LayoutTests/animations/multiple-animations-timing-function-expected.txt (rev 0)
+++ trunk/LayoutTests/animations/multiple-animations-timing-function-expected.txt 2011-06-22 19:57:13 UTC (rev 89462)
@@ -0,0 +1,5 @@
+PASS - "left" property for "box" element at 0.5s saw something close to: 18
+PASS - "left" property for "box" element at 1.5s saw something close to: 124
+PASS - "top" property for "box" element at 0.5s saw something close to: 75
+PASS - "top" property for "box" element at 1.5s saw something close to: 181
+
Added: trunk/LayoutTests/animations/multiple-animations-timing-function.html (0 => 89462)
--- trunk/LayoutTests/animations/multiple-animations-timing-function.html (rev 0)
+++ trunk/LayoutTests/animations/multiple-animations-timing-function.html 2011-06-22 19:57:13 UTC (rev 89462)
@@ -0,0 +1,42 @@
+
+
+
+#box {
+position: relative;
+height: 100px;
+width: 100px;
+margin: 20px;
+background-color: red;
+-webkit-animation:
+horizontal 2s ease-in 1 alternate,
+vertical 2s ease-out 1 alternate;
+}
+
+@-webkit-keyframes horizontal {
+from { left: 0px; }
+to { left: 200px; }
+}
+
+@-webkit-keyframes vertical {
+from { top: 0px; }
+to { top:
[webkit-changes] [89461] trunk/Source/WebKit2
Title: [89461] trunk/Source/WebKit2
Revision 89461
Author kbal...@webkit.org
Date 2011-06-22 12:55:35 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Balazs Kelemen
Reviewed by Darin Adler.
[X11][WK2] Implement NetscapePlugin::platformSetFocus
https://bugs.webkit.org/show_bug.cgi?id=63154
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformSetFocus):
Implement focus setting based on the WebKit1 path.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (89460 => 89461)
--- trunk/Source/WebKit2/ChangeLog 2011-06-22 19:55:23 UTC (rev 89460)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-22 19:55:35 UTC (rev 89461)
@@ -1,3 +1,14 @@
+2011-06-22 Balazs Kelemen
+
+Reviewed by Darin Adler.
+
+[X11][WK2] Implement NetscapePlugin::platformSetFocus
+https://bugs.webkit.org/show_bug.cgi?id=63154
+
+* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+(WebKit::NetscapePlugin::platformSetFocus):
+Implement focus setting based on the WebKit1 path.
+
2011-06-22 Eunmi Lee
Reviewed by Martin Robinson.
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (89460 => 89461)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-06-22 19:55:23 UTC (rev 89460)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-06-22 19:55:35 UTC (rev 89461)
@@ -435,7 +435,17 @@
void NetscapePlugin::platformSetFocus(bool)
{
-notImplemented();
+if (m_isWindowed)
+return;
+
+XEvent xEvent;
+initializeXEvent(xEvent);
+XFocusChangeEvent& focusEvent = xEvent.xfocus;
+focusEvent.type = focusIn ? kFocusInType : kFocusOutType;
+focusEvent.mode = NotifyNormal;
+focusEvent.detail = NotifyDetailNone;
+
+NPP_HandleEvent(&xEvent);
}
bool NetscapePlugin::platformHandleMouseEnterEvent(const WebMouseEvent& event)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89459] trunk/Tools
Title: [89459] trunk/Tools
Revision 89459
Author dpra...@chromium.org
Date 2011-06-22 12:52:25 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Dirk Pranke
Reviewed by Tony Chang.
run-webkit-websocketserver fails to stop websocket server
https://bugs.webkit.org/show_bug.cgi?id=63123
There's a ten-character change in new-run-webkit-websocketserver
that fixes the actual bug, and then we update the code in
new-run-webkit-httpd to do the actual stop call, and add more tests
(refactoring the existing test code so that it is shared).
* Scripts/new-run-webkit-httpd:
* Scripts/new-run-webkit-websocketserver:
* Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/new-run-webkit-httpd
trunk/Tools/Scripts/new-run-webkit-websocketserver
trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py
Property Changed
trunk/Tools/Scripts/new-run-webkit-websocketserver
Diff
Modified: trunk/Tools/ChangeLog (89458 => 89459)
--- trunk/Tools/ChangeLog 2011-06-22 19:47:07 UTC (rev 89458)
+++ trunk/Tools/ChangeLog 2011-06-22 19:52:25 UTC (rev 89459)
@@ -1,3 +1,19 @@
+2011-06-22 Dirk Pranke
+
+Reviewed by Tony Chang.
+
+run-webkit-websocketserver fails to stop websocket server
+https://bugs.webkit.org/show_bug.cgi?id=63123
+
+There's a ten-character change in new-run-webkit-websocketserver
+that fixes the actual bug, and then we update the code in
+new-run-webkit-httpd to do the actual stop call, and add more tests
+(refactoring the existing test code so that it is shared).
+
+* Scripts/new-run-webkit-httpd:
+* Scripts/new-run-webkit-websocketserver:
+* Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
+
2011-06-22 Adam Roben
Add links to existing bugs related to failing tests on TestFailures page
Modified: trunk/Tools/Scripts/new-run-webkit-httpd (89458 => 89459)
--- trunk/Tools/Scripts/new-run-webkit-httpd 2011-06-22 19:47:07 UTC (rev 89458)
+++ trunk/Tools/Scripts/new-run-webkit-httpd 2011-06-22 19:52:25 UTC (rev 89459)
@@ -70,13 +70,9 @@
if options.server == 'start':
httpd.start()
else:
-# FIXME: We use _shut_down_http_server() instead of stop_http_server()
-# because stop() only works if start() was called previously in the
-# same process. _shut_down() is too coarse and may kill unrelated
-# web servers, so this is a hack. We should change the interface so we
-# can rely on pid files or something.
-port_obj._shut_down_http_server(None)
+httpd.stop()
+
def main():
option_parser = optparse.OptionParser()
option_parser.add_option('-k', '--server',
Modified: trunk/Tools/Scripts/new-run-webkit-websocketserver (89458 => 89459)
--- trunk/Tools/Scripts/new-run-webkit-websocketserver 2011-06-22 19:47:07 UTC (rev 89458)
+++ trunk/Tools/Scripts/new-run-webkit-websocketserver 2011-06-22 19:52:25 UTC (rev 89459)
@@ -102,7 +102,7 @@
if 'start' == options.server:
pywebsocket.start()
else:
-pywebsocket.stop(force=True)
+pywebsocket.stop()
if '__main__' == __name__:
main()
Property changes on: trunk/Tools/Scripts/new-run-webkit-websocketserver
___
Added: svn:executable
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py (89458 => 89459)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py 2011-06-22 19:47:07 UTC (rev 89458)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py 2011-06-22 19:52:25 UTC (rev 89459)
@@ -26,8 +26,10 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-"""Integration testing for the new-run-webkit-httpd script"""
+"""Integration tests for the new-run-webkit-httpd and new-run-webkit-websocketserver scripts"""
+# FIXME: Rename this file to something more descriptive.
+
import errno
import os
import socket
@@ -39,50 +41,62 @@
from webkitpy.layout_tests.port import port_testcase
-class NewRunWebKitHTTPdTest(unittest.TestCase):
-"""Tests that new-run-webkit-httpd must pass."""
-HTTP_PORTS = (8000, 8080, 8443)
+class BaseTest(unittest.TestCase):
+"""Basic framework for script tests."""
+HOST = 'localhost'
-def assert_servers_are_down(self, host, ports):
+# Override in actual test classes.
+PORTS = None
+SCRIPT_NAME = None
+
+def assert_servers_are_down(self, ports=None):
+ports = ports or self.PORTS
for port in ports:
try:
test_socket = socket.socket()
-test_socket.connect((host
[webkit-changes] [89458] trunk/Source/WebKit/efl
Title: [89458] trunk/Source/WebKit/efl Revision 89458 Author commit-qu...@webkit.org Date 2011-06-22 12:47:07 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Ryuan Choi Reviewed by Antonio Gomes. [EFL] Add DeviceOrientationClientEfl and DeviceMotionClientEfl. https://bugs.webkit.org/show_bug.cgi?id=63125 Add dummy files to build with ENABLE_DEVICE_ORIENTATION. * WebCoreSupport/DeviceMotionClientEfl.cpp: Added. (WebCore::DeviceMotionClientEfl::DeviceMotionClientEfl): (WebCore::DeviceMotionClientEfl::~DeviceMotionClientEfl): (WebCore::DeviceMotionClientEfl::deviceMotionControllerDestroyed): (WebCore::DeviceMotionClientEfl::setController): (WebCore::DeviceMotionClientEfl::startUpdating): (WebCore::DeviceMotionClientEfl::stopUpdating): (WebCore::DeviceMotionClientEfl::currentDeviceMotion): * WebCoreSupport/DeviceMotionClientEfl.h: Added. * WebCoreSupport/DeviceOrientationClientEfl.cpp: Added. (WebCore::DeviceOrientationClientEfl::DeviceOrientationClientEfl): (WebCore::DeviceOrientationClientEfl::~DeviceOrientationClientEfl): (WebCore::DeviceOrientationClientEfl::deviceOrientationControllerDestroyed): (WebCore::DeviceOrientationClientEfl::setController): (WebCore::DeviceOrientationClientEfl::startUpdating): (WebCore::DeviceOrientationClientEfl::stopUpdating): (WebCore::DeviceOrientationClientEfl::lastOrientation): * WebCoreSupport/DeviceOrientationClientEfl.h: Added. Modified Paths trunk/Source/WebKit/efl/ChangeLog Added Paths trunk/Source/WebKit/efl/WebCoreSupport/DeviceMotionClientEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/DeviceMotionClientEfl.h trunk/Source/WebKit/efl/WebCoreSupport/DeviceOrientationClientEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/DeviceOrientationClientEfl.h Diff Modified: trunk/Source/WebKit/efl/ChangeLog (89457 => 89458) --- trunk/Source/WebKit/efl/ChangeLog 2011-06-22 19:39:41 UTC (rev 89457) +++ trunk/Source/WebKit/efl/ChangeLog 2011-06-22 19:47:07 UTC (rev 89458) @@ -1,3 +1,31 @@ +2011-06-22 Ryuan Choi + +Reviewed by Antonio Gomes. + +[EFL] Add DeviceOrientationClientEfl and DeviceMotionClientEfl. +https://bugs.webkit.org/show_bug.cgi?id=63125 + +Add dummy files to build with ENABLE_DEVICE_ORIENTATION. + +* WebCoreSupport/DeviceMotionClientEfl.cpp: Added. +(WebCore::DeviceMotionClientEfl::DeviceMotionClientEfl): +(WebCore::DeviceMotionClientEfl::~DeviceMotionClientEfl): +(WebCore::DeviceMotionClientEfl::deviceMotionControllerDestroyed): +(WebCore::DeviceMotionClientEfl::setController): +(WebCore::DeviceMotionClientEfl::startUpdating): +(WebCore::DeviceMotionClientEfl::stopUpdating): +(WebCore::DeviceMotionClientEfl::currentDeviceMotion): +* WebCoreSupport/DeviceMotionClientEfl.h: Added. +* WebCoreSupport/DeviceOrientationClientEfl.cpp: Added. +(WebCore::DeviceOrientationClientEfl::DeviceOrientationClientEfl): +(WebCore::DeviceOrientationClientEfl::~DeviceOrientationClientEfl): +(WebCore::DeviceOrientationClientEfl::deviceOrientationControllerDestroyed): +(WebCore::DeviceOrientationClientEfl::setController): +(WebCore::DeviceOrientationClientEfl::startUpdating): +(WebCore::DeviceOrientationClientEfl::stopUpdating): +(WebCore::DeviceOrientationClientEfl::lastOrientation): +* WebCoreSupport/DeviceOrientationClientEfl.h: Added. + 2011-06-20 Dimitri Glazkov Reviewed by Kent Tamura. Added: trunk/Source/WebKit/efl/WebCoreSupport/DeviceMotionClientEfl.cpp (0 => 89458) --- trunk/Source/WebKit/efl/WebCoreSupport/DeviceMotionClientEfl.cpp (rev 0) +++ trunk/Source/WebKit/efl/WebCoreSupport/DeviceMotionClientEfl.cpp 2011-06-22 19:47:07 UTC (rev 89458) @@ -0,0 +1,72 @@ +/* + * Copyright (C) 2011 Samsung Electronics + * + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR + * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, + * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMI
[webkit-changes] [89457] trunk/Source/WebCore
Title: [89457] trunk/Source/WebCore
Revision 89457
Author mnaga...@chromium.org
Date 2011-06-22 12:39:41 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-20 Mikhail Naganov
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Improve speed of heap profiles dominators view.
https://bugs.webkit.org/show_bug.cgi?id=62979
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotArraySlice.prototype.item):
(WebInspector.HeapSnapshotArraySlice.prototype.slice):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
(WebInspector.HeapSnapshot.prototype._buildReverseIndex.var):
(WebInspector.HeapSnapshot.prototype._buildReverseIndex):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype._getDominatedIndex):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForDominator):
(WebInspector.HeapSnapshotFilteredOrderedIterator):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype._createIterationOrder):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get length):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems):
(WebInspector.HeapSnapshotNodesProvider):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForDominator):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (89456 => 89457)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 19:26:46 UTC (rev 89456)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 19:39:41 UTC (rev 89457)
@@ -1,3 +1,33 @@
+2011-06-20 Mikhail Naganov
+
+Reviewed by Pavel Feldman.
+
+Web Inspector: [Chromium] Improve speed of heap profiles dominators view.
+https://bugs.webkit.org/show_bug.cgi?id=62979
+
+* inspector/front-end/DetailedHeapshotGridNodes.js:
+(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
+* inspector/front-end/HeapSnapshot.js:
+(WebInspector.HeapSnapshotArraySlice.prototype.item):
+(WebInspector.HeapSnapshotArraySlice.prototype.slice):
+(WebInspector.HeapSnapshot.prototype.dispose):
+(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
+(WebInspector.HeapSnapshot.prototype._buildReverseIndex.var):
+(WebInspector.HeapSnapshot.prototype._buildReverseIndex):
+(WebInspector.HeapSnapshot.prototype._buildRetainers):
+(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
+(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
+(WebInspector.HeapSnapshot.prototype._getDominatedIndex):
+(WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
+(WebInspector.HeapSnapshot.prototype.createNodesProviderForDominator):
+(WebInspector.HeapSnapshotFilteredOrderedIterator):
+(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype._createIterationOrder):
+(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get length):
+(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems):
+(WebInspector.HeapSnapshotNodesProvider):
+* inspector/front-end/HeapSnapshotProxy.js:
+(WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForDominator):
+
2011-06-22 Sreeram Ramachandran
Reviewed by Pavel Feldman.
Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js (89456 => 89457)
--- trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js 2011-06-22 19:26:46 UTC (rev 89456)
+++ trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js 2011-06-22 19:39:41 UTC (rev 89457)
@@ -700,12 +700,9 @@
_createProvider: function(snapshot, nodeIndex)
{
var showHiddenData = WebInspector.DetailedHeapshotView.prototype.showHiddenData;
-return snapshot.createNodesProvider(
+return snapshot.createNodesProviderForDominator(nodeIndex,
"function (node) {" +
-" var dominatorIndex = node.dominatorIndex;" +
-" return dominatorIndex === " + nodeIndex +
-" && dominatorIndex !== node.nodeIndex" +
-" && (" + showHiddenData + "
[webkit-changes] [89456] trunk/Source/WebCore
Title: [89456] trunk/Source/WebCore
Revision 89456
Author commit-qu...@webkit.org
Date 2011-06-22 12:26:46 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Sreeram Ramachandran
Reviewed by Pavel Feldman.
Web Inspector: Restore console messages when restoring inspector state
https://bugs.webkit.org/show_bug.cgi?id=63146
No new tests (no change in functionality, only in display).
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::restore):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::restoreInspectorStateFromCookie):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp
trunk/Source/WebCore/inspector/InspectorConsoleAgent.h
trunk/Source/WebCore/inspector/InspectorController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89455 => 89456)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 19:02:24 UTC (rev 89455)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 19:26:46 UTC (rev 89456)
@@ -1,3 +1,18 @@
+2011-06-22 Sreeram Ramachandran
+
+Reviewed by Pavel Feldman.
+
+Web Inspector: Restore console messages when restoring inspector state
+https://bugs.webkit.org/show_bug.cgi?id=63146
+
+No new tests (no change in functionality, only in display).
+
+* inspector/InspectorConsoleAgent.cpp:
+(WebCore::InspectorConsoleAgent::restore):
+* inspector/InspectorConsoleAgent.h:
+* inspector/InspectorController.cpp:
+(WebCore::InspectorController::restoreInspectorStateFromCookie):
+
2011-06-22 Adam Barth
Attempt to fix the GTK build after my incomplete rollout of 88332.
Modified: trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp (89455 => 89456)
--- trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp 2011-06-22 19:02:24 UTC (rev 89455)
+++ trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp 2011-06-22 19:26:46 UTC (rev 89456)
@@ -115,6 +115,15 @@
m_counts.clear();
}
+void InspectorConsoleAgent::restore()
+{
+if (m_inspectorState->getBoolean(ConsoleAgentState::consoleMessagesEnabled)) {
+ErrorString error;
+int expiredCount;
+enable(&error, &expiredCount);
+}
+}
+
void InspectorConsoleAgent::setFrontend(InspectorFrontend* frontend)
{
m_frontend = frontend->console();
Modified: trunk/Source/WebCore/inspector/InspectorConsoleAgent.h (89455 => 89456)
--- trunk/Source/WebCore/inspector/InspectorConsoleAgent.h 2011-06-22 19:02:24 UTC (rev 89455)
+++ trunk/Source/WebCore/inspector/InspectorConsoleAgent.h 2011-06-22 19:26:46 UTC (rev 89456)
@@ -63,6 +63,7 @@
void disable(ErrorString*);
void clearConsoleMessages(ErrorString* error);
void reset();
+void restore();
void setFrontend(InspectorFrontend*);
void clearFrontend();
Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (89455 => 89456)
--- trunk/Source/WebCore/inspector/InspectorController.cpp 2011-06-22 19:02:24 UTC (rev 89455)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp 2011-06-22 19:26:46 UTC (rev 89456)
@@ -332,6 +332,7 @@
m_domAgent->restore();
m_resourceAgent->restore();
m_timelineAgent->restore();
+m_consoleAgent->restore();
#if ENABLE(DATABASE)
m_databaseAgent->restore();
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89455] trunk/Source/WebCore
Title: [89455] trunk/Source/WebCore Revision 89455 Author aba...@webkit.org Date 2011-06-22 12:02:24 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Adam Barth Attempt to fix the GTK build after my incomplete rollout of 88332. * GNUmakefile.list.am: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am Diff Modified: trunk/Source/WebCore/ChangeLog (89454 => 89455) --- trunk/Source/WebCore/ChangeLog 2011-06-22 18:57:04 UTC (rev 89454) +++ trunk/Source/WebCore/ChangeLog 2011-06-22 19:02:24 UTC (rev 89455) @@ -1,3 +1,9 @@ +2011-06-22 Adam Barth + +Attempt to fix the GTK build after my incomplete rollout of 88332. + +* GNUmakefile.list.am: + 2011-06-22 Sam Weinig Reviewed by Adam Barth. Modified: trunk/Source/WebCore/GNUmakefile.list.am (89454 => 89455) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-06-22 18:57:04 UTC (rev 89454) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-06-22 19:02:24 UTC (rev 89455) @@ -1885,10 +1885,6 @@ Source/WebCore/html/ResetInputType.h \ Source/WebCore/html/SearchInputType.cpp \ Source/WebCore/html/SearchInputType.h \ - Source/WebCore/html/SpellcheckRange.cpp \ - Source/WebCore/html/SpellcheckRange.h \ - Source/WebCore/html/SpellcheckRangeList.cpp \ - Source/WebCore/html/SpellcheckRangeList.h \ Source/WebCore/html/StepRange.cpp \ Source/WebCore/html/StepRange.h \ Source/WebCore/html/SubmitInputType.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89454] trunk/Source/WebKit/qt
Title: [89454] trunk/Source/WebKit/qt
Revision 89454
Author ademar.r...@openbossa.org
Date 2011-06-22 11:57:04 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Ademar de Souza Reis Jr.
Reviewed by Holger Freyther.
[Qt] Fix Qt namespace on QDeclarativeWebView autotest
https://bugs.webkit.org/show_bug.cgi?id=63147
Applications (such as the test runner) are not supposed to be wrapped
by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
QtWebKit) with a specific namespace won't work (will result in main
being undefined).
This was the only test wrapped by these macros, all others are fine.
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove
namespace macros.
Modified Paths
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (89453 => 89454)
--- trunk/Source/WebKit/qt/ChangeLog 2011-06-22 18:26:03 UTC (rev 89453)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-06-22 18:57:04 UTC (rev 89454)
@@ -1,3 +1,20 @@
+2011-06-22 Ademar de Souza Reis Jr.
+
+Reviewed by Holger Freyther.
+
+[Qt] Fix Qt namespace on QDeclarativeWebView autotest
+https://bugs.webkit.org/show_bug.cgi?id=63147
+
+Applications (such as the test runner) are not supposed to be wrapped
+by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
+QtWebKit) with a specific namespace won't work (will result in main
+being undefined).
+
+This was the only test wrapped by these macros, all others are fine.
+
+* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove
+namespace macros.
+
2011-06-20 Dimitri Glazkov
Reviewed by Kent Tamura.
Modified: trunk/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp (89453 => 89454)
--- trunk/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp 2011-06-22 18:26:03 UTC (rev 89453)
+++ trunk/Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp 2011-06-22 18:57:04 UTC (rev 89454)
@@ -14,8 +14,6 @@
#include
#include "qdeclarativewebview_p.h"
-QT_BEGIN_NAMESPACE
-
class tst_QDeclarativeWebView : public QObject {
Q_OBJECT
@@ -548,5 +546,3 @@
QTEST_MAIN(tst_QDeclarativeWebView)
#include "tst_qdeclarativewebview.moc"
-
-QT_END_NAMESPACE
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89453] trunk
Title: [89453] trunk Revision 89453 Author wei...@apple.com Date 2011-06-22 11:26:03 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Sam Weinig Reviewed by Adam Barth. HTML parser should limit element depth of produced tree https://bugs.webkit.org/show_bug.cgi?id=63082 Test by: fast/parser/block-nesting-cap.html fast/parser/element-nesting-cap.html * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): (WebCore::HTMLConstructionSite::HTMLConstructionSite): * html/parser/HTMLConstructionSite.h: Limit the DOM tree depth by turning attempts to add a child passed a certain threshold (configurable by Settings::maximumDOMTreeDepth) into a sibling. * html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::maximumDOMTreeDepth): * html/parser/HTMLDocumentParser.h: Pass the maximumDOMTreeDepth to the TreeBuilder. * html/parser/HTMLElementStack.cpp: (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::popAll): (WebCore::HTMLElementStack::insertAbove): (WebCore::HTMLElementStack::pushCommon): (WebCore::HTMLElementStack::popCommon): (WebCore::HTMLElementStack::removeNonTopCommon): * html/parser/HTMLElementStack.h: (WebCore::HTMLElementStack::size): Keep track of the size of the element stack. * html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): * html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create): Pass the maximumDOMTreeDepth to the construction site. * page/Settings.cpp: (WebCore::Settings::Settings): * page/Settings.h: (WebCore::Settings::setMaximumHTMLParserDOMTreeDepth): (WebCore::Settings::maximumHTMLParserDOMTreeDepth): Add a setting to control the maximum DOM tree depth that the parser will produce. 2011-06-22 Sam Weinig Reviewed by Adam Barth. HTML parser should limit element depth of produced tree https://bugs.webkit.org/show_bug.cgi?id=63082 * fast/parser/block-nesting-cap-expected.txt: * fast/parser/element-nesting-cap-expected.txt: Update expectations for new parser depth limit. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt trunk/LayoutTests/fast/parser/element-nesting-cap-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp trunk/Source/WebCore/html/parser/HTMLConstructionSite.h trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp trunk/Source/WebCore/html/parser/HTMLDocumentParser.h trunk/Source/WebCore/html/parser/HTMLElementStack.cpp trunk/Source/WebCore/html/parser/HTMLElementStack.h trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h trunk/Source/WebCore/page/Settings.cpp trunk/Source/WebCore/page/Settings.h Diff Modified: trunk/LayoutTests/ChangeLog (89452 => 89453) --- trunk/LayoutTests/ChangeLog 2011-06-22 18:12:43 UTC (rev 89452) +++ trunk/LayoutTests/ChangeLog 2011-06-22 18:26:03 UTC (rev 89453) @@ -1,3 +1,14 @@ +2011-06-22 Sam Weinig + +Reviewed by Adam Barth. + +HTML parser should limit element depth of produced tree +https://bugs.webkit.org/show_bug.cgi?id=63082 + +* fast/parser/block-nesting-cap-expected.txt: +* fast/parser/element-nesting-cap-expected.txt: +Update expectations for new parser depth limit. + 2011-06-22 Adam Barth Rollout 88332. Modified: trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt (89452 => 89453) --- trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt 2011-06-22 18:12:43 UTC (rev 89452) +++ trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt 2011-06-22 18:26:03 UTC (rev 89453) @@ -3,9 +3,9 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -FAIL d4096.parentNode === d4094 should be true. Was false. +PASS d4096.parentNode === d4094 is true PASS d4095.parentNode === d4094 is true -FAIL d4096.previousSibling === d4095 should be true. Was false. +PASS d4096.previousSibling === d4095 is true PASS successfullyParsed is true TEST COMPLETE Modified: trunk/LayoutTests/fast/parser/element-nesting-cap-expected.txt (89452 => 89453) --- trunk/LayoutTests/fast/parser/element-nesting-cap-expected.txt 2011-06-22 18:12:43 UTC (rev 89452) +++ trunk/LayoutTests/fast/parser/element-nesting-cap-expected.txt 2011-06-22 18:26:03 UTC (rev 89453) @@ -4,8 +4,8 @@ FAIL s3.parentNode === s1 should be true. Was false. -PASS s2.parentNode === s1 is true -FAIL s3.previousSibling === s2 should be true. Was false. +FAIL s2.parentNode === s1 should be true. Was
[webkit-changes] [89451] trunk
Title: [89451] trunk Revision 89451 Author commit-qu...@webkit.org Date 2011-06-22 11:03:33 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Mark Pilgrim Reviewed by Adam Barth. IndexedDB: fix multiple issues in IDBDatabase.idl https://bugs.webkit.org/show_bug.cgi?id=63140 * storage/indexeddb/createObjectStore-name-argument-required-expected.txt: Added. * storage/indexeddb/createObjectStore-name-argument-required.html: Added. * storage/indexeddb/createObjectStore-null-name-expected.txt: Added. * storage/indexeddb/createObjectStore-null-name.html: Added. * storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt: Added. * storage/indexeddb/deleteObjectStore-name-argument-required.html: Added. * storage/indexeddb/deleteObjectStore-null-name-expected.txt: Added. * storage/indexeddb/deleteObjectStore-null-name.html: Added. * storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt: * storage/indexeddb/mozilla/create-objectstore-null-name.html: * storage/indexeddb/setVersion-null-expected.txt: Added. * storage/indexeddb/setVersion-null.html: Added. * storage/indexeddb/setVersion-undefined-expected.txt: * storage/indexeddb/setVersion-undefined.html: * storage/indexeddb/transaction-and-objectstore-calls-expected.txt: * storage/indexeddb/transaction-and-objectstore-calls.html: * storage/indexeddb/transaction-crash-on-abort-expected.txt: * storage/indexeddb/transaction-crash-on-abort.html: * storage/indexeddb/transaction-read-only-expected.txt: * storage/indexeddb/transaction-read-only.html: * storage/indexeddb/transaction-storeNames-required-expected.txt: Added. * storage/indexeddb/transaction-storeNames-required.html: Added. 2011-06-22 Mark Pilgrim Reviewed by Adam Barth. IndexedDB: fix multiple issues in IDBDatabase.idl https://bugs.webkit.org/show_bug.cgi?id=63140 Tests: storage/indexeddb/createObjectStore-name-argument-required.html storage/indexeddb/createObjectStore-null-name.html storage/indexeddb/deleteObjectStore-name-argument-required.html storage/indexeddb/deleteObjectStore-null-name.html storage/indexeddb/setVersion-null.html storage/indexeddb/transaction-storeNames-required.html * storage/IDBDatabase.idl: remove LegacyDefaultOptionalArguments so all functions will throw TypeError when called with too few arguments, as per WebIDL spec. Also remove ConvertNullToNullString flags so null values are stringified as "null" (also as per WebIDL spec). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt trunk/LayoutTests/storage/indexeddb/mozilla/create-objectstore-null-name.html trunk/LayoutTests/storage/indexeddb/setVersion-undefined-expected.txt trunk/LayoutTests/storage/indexeddb/setVersion-undefined.html trunk/LayoutTests/storage/indexeddb/transaction-and-objectstore-calls-expected.txt trunk/LayoutTests/storage/indexeddb/transaction-and-objectstore-calls.html trunk/LayoutTests/storage/indexeddb/transaction-crash-on-abort-expected.txt trunk/LayoutTests/storage/indexeddb/transaction-crash-on-abort.html trunk/LayoutTests/storage/indexeddb/transaction-read-only-expected.txt trunk/LayoutTests/storage/indexeddb/transaction-read-only.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/storage/IDBDatabase.idl Added Paths trunk/LayoutTests/storage/indexeddb/createObjectStore-name-argument-required-expected.txt trunk/LayoutTests/storage/indexeddb/createObjectStore-name-argument-required.html trunk/LayoutTests/storage/indexeddb/createObjectStore-null-name-expected.txt trunk/LayoutTests/storage/indexeddb/createObjectStore-null-name.html trunk/LayoutTests/storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt trunk/LayoutTests/storage/indexeddb/deleteObjectStore-name-argument-required.html trunk/LayoutTests/storage/indexeddb/deleteObjectStore-null-name-expected.txt trunk/LayoutTests/storage/indexeddb/deleteObjectStore-null-name.html trunk/LayoutTests/storage/indexeddb/setVersion-null-expected.txt trunk/LayoutTests/storage/indexeddb/setVersion-null.html trunk/LayoutTests/storage/indexeddb/transaction-storeNames-required-expected.txt trunk/LayoutTests/storage/indexeddb/transaction-storeNames-required.html Diff Modified: trunk/LayoutTests/ChangeLog (89450 => 89451) --- trunk/LayoutTests/ChangeLog 2011-06-22 17:53:18 UTC (rev 89450) +++ trunk/LayoutTests/ChangeLog 2011-06-22 18:03:33 UTC (rev 89451) @@ -1,3 +1,33 @@ +2011-06-22 Mark Pilgrim + +Reviewed by Adam Barth. + +IndexedDB: fix multiple issues in IDBDatabase.idl +https://bugs.webkit.org/show_bug.cgi?id=63140 + +* storage/indexeddb/createObjectS
[webkit-changes] [89450] trunk/LayoutTests
Title: [89450] trunk/LayoutTests Revision 89450 Author mdela...@apple.com Date 2011-06-22 10:53:18 -0700 (Wed, 22 Jun 2011) Log Message Adding a mac platform expected result for webgl test to help fix burning bot. Filed https://bugs.webkit.org/show_bug.cgi?id=63151 for a real fix * platform/mac/fast/canvas/webgl/data-view-test-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/mac/fast/canvas/webgl/data-view-test-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (89449 => 89450) --- trunk/LayoutTests/ChangeLog 2011-06-22 17:51:59 UTC (rev 89449) +++ trunk/LayoutTests/ChangeLog 2011-06-22 17:53:18 UTC (rev 89450) @@ -1,3 +1,10 @@ +2011-06-22 Matthew Delaney + +Adding a mac platform expected result for webgl test to help fix burning bot. +Filed https://bugs.webkit.org/show_bug.cgi?id=63151 for a real fix + +* platform/mac/fast/canvas/webgl/data-view-test-expected.txt: Added. + 2011-06-22 Julien Chaffraix Reviewed by Darin Adler. Added: trunk/LayoutTests/platform/mac/fast/canvas/webgl/data-view-test-expected.txt (0 => 89450) --- trunk/LayoutTests/platform/mac/fast/canvas/webgl/data-view-test-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac/fast/canvas/webgl/data-view-test-expected.txt 2011-06-22 17:53:18 UTC (rev 89450) @@ -0,0 +1,816 @@ +Test DataView. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +Test for constructor not called as a function +PASS DataView(new ArrayBuffer) threw exception + +Test for constructor taking 1 argument +PASS view = new DataView(arayBuffer) is defined. +PASS view.byteOffset is 0 +PASS view.byteLength is 2 + +Test for constructor taking 2 arguments +PASS view = new DataView(arayBuffer, 1) is defined. +PASS view.byteOffset is 1 +PASS view.byteLength is 1 + +Test for constructor taking 3 arguments +PASS view = new DataView(arayBuffer, 0, 1) is defined. +PASS view.byteOffset is 0 +PASS view.byteLength is 1 + +Test for constructor throwing exception +PASS view = new DataView(arayBuffer, 0, 3) threw exception Error: INDEX_SIZE_ERR: DOM Exception 1. +PASS view = new DataView(arayBuffer, 1, 2) threw exception Error: INDEX_SIZE_ERR: DOM Exception 1. +PASS view = new DataView(arayBuffer, 2, 1) threw exception Error: INDEX_SIZE_ERR: DOM Exception 1. + +Test for get methods that work +PASS view.getInt8(0) is 0 +PASS view.getInt8(8) is -128 +PASS view.getInt8(15) is -1 +PASS view.getUint8(0) is 0 +PASS view.getUint8(8) is 128 +PASS view.getUint8(15) is 255 +PASS view.getInt16(0, true) is 256 +PASS view.getInt16(5, true) is 26213 +PASS view.getInt16(9, true) is -32127 +PASS view.getInt16(14, true) is -2 +PASS view.getInt16(0) is 1 +PASS view.getInt16(5) is 25958 +PASS view.getInt16(9) is -32382 +PASS view.getInt16(14) is -257 +PASS view.getUint16(0, true) is 256 +PASS view.getUint16(5, true) is 26213 +PASS view.getUint16(9, true) is 33409 +PASS view.getUint16(14, true) is 65534 +PASS view.getUint16(0) is 1 +PASS view.getUint16(5) is 25958 +PASS view.getUint16(9) is 33154 +PASS view.getUint16(14) is 65279 +PASS view.getInt32(0, true) is 50462976 +PASS view.getInt32(3, true) is 1717920771 +PASS view.getInt32(6, true) is -2122291354 +PASS view.getInt32(9, true) is -58490239 +PASS view.getInt32(12, true) is -66052 +PASS view.getInt32(0) is 66051 +PASS view.getInt32(3) is 56911206 +PASS view.getInt32(6) is 1718059137 +PASS view.getInt32(9) is -2122152964 +PASS view.getInt32(12) is -50462977 +PASS view.getUint32(0, true) is 50462976 +PASS view.getUint32(3, true) is 1717920771 +PASS view.getUint32(6, true) is 2172675942 +PASS view.getUint32(9, true) is 4236477057 +PASS view.getUint32(12, true) is 4294901244 +PASS view.getUint32(0) is 66051 +PASS view.getUint32(3) is 56911206 +PASS view.getUint32(6) is 1718059137 +PASS view.getUint32(9) is 2172814332 +PASS view.getUint32(12) is 4244504319 +PASS view.getFloat32(0, true) is 10 +PASS view.getFloat32(3, true) is 10 +PASS view.getFloat32(7, true) is 10 +PASS view.getFloat32(10, true) is 10 +PASS view.getFloat32(0, false) is 10 +PASS view.getFloat32(3, false) is 10 +PASS view.getFloat32(7, false) is 10 +PASS view.getFloat32(10, false) is 10 +PASS view.getFloat32(0, true) is 1.230190734863 +PASS view.getFloat32(3, true) is 1.230190734863 +PASS view.getFloat32(7, true) is 1.230190734863 +PASS view.getFloat32(10, true) is 1.230190734863 +PASS view.getFloat32(0, false) is 1.230190734863 +PASS view.getFloat32(3, false) is 1.230190734863 +PASS view.getFloat32(7, false) is 1.230190734863 +PASS view.getFloat32(10, false) is 1.230190734863 +PASS view.getFloat32(0, true) is -45621.37109375 +PASS view.getFloat32(3, true) is -45621.37109375 +PASS view.getFloat32(7, true) is -45621.37109375 +PASS view.getFloat32(10, true) is -45621.37109375 +PASS view.getFloat32(0, false) is -45621.37109375 +PASS view.getFloat32(3, fal
[webkit-changes] [89449] trunk/Source/WebCore
Title: [89449] trunk/Source/WebCore
Revision 89449
Author commit-qu...@webkit.org
Date 2011-06-22 10:51:59 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Vsevolod Vlasov
Reviewed by Pavel Feldman.
Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend.
https://bugs.webkit.org/show_bug.cgi?id=63069
* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::getResourceContent):
(WebCore::InspectorPageAgent::searchInResources):
* inspector/InspectorPageAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::getResourceContent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._innerRequestContent.onResourceContent):
(WebInspector.Resource.prototype._innerRequestContent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp
trunk/Source/WebCore/inspector/InspectorResourceAgent.h
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp
trunk/Source/WebCore/inspector/front-end/NetworkManager.js
trunk/Source/WebCore/inspector/front-end/Resource.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (89448 => 89449)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 17:42:28 UTC (rev 89448)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 17:51:59 UTC (rev 89449)
@@ -1,3 +1,28 @@
+2011-06-22 Vsevolod Vlasov
+
+Reviewed by Pavel Feldman.
+
+Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend.
+https://bugs.webkit.org/show_bug.cgi?id=63069
+
+* inspector/Inspector.json:
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::cachedResourceContent):
+(WebCore::InspectorPageAgent::resourceContent):
+(WebCore::InspectorPageAgent::getResourceContent):
+(WebCore::InspectorPageAgent::searchInResources):
+* inspector/InspectorPageAgent.h:
+* inspector/InspectorResourceAgent.cpp:
+(WebCore::InspectorResourceAgent::getResourceContent):
+* inspector/InspectorResourceAgent.h:
+* inspector/InspectorStyleSheet.cpp:
+(WebCore::InspectorStyleSheet::resourceStyleSheetText):
+* inspector/front-end/NetworkManager.js:
+(WebInspector.NetworkManager.prototype.requestContent):
+* inspector/front-end/Resource.js:
+(WebInspector.Resource.prototype._innerRequestContent.onResourceContent):
+(WebInspector.Resource.prototype._innerRequestContent):
+
2011-06-22 Luke Macpherson
Reviewed by Dimitri Glazkov.
Modified: trunk/Source/WebCore/inspector/Inspector.json (89448 => 89449)
--- trunk/Source/WebCore/inspector/Inspector.json 2011-06-22 17:42:28 UTC (rev 89448)
+++ trunk/Source/WebCore/inspector/Inspector.json 2011-06-22 17:51:59 UTC (rev 89449)
@@ -161,11 +161,11 @@
"description": "Returns content of the given resource.",
"parameters": [
{ "name": "frameId", "type": "string", "description": "Frame id to get resource for." },
-{ "name": "url", "type": "string", "description": "URL of the resource to get content for." },
-{ "name": "base64Encode", "type": "boolean", "optional": true, "description": "Requests that resource content is served as base64." }
+{ "name": "url", "type": "string", "description": "URL of the resource to get content for." }
],
"returns": [
-{ "name": "content", "type": "string", "description": "Resource content." }
+{ "name": "content", "type": "string", "description": "Resource content." },
+{ "name": "base64Encoded", "type": "boolean", "description": "True, if content was served as base64." }
]
},
{
@@ -490,11 +490,11 @@
"name": "getResourceContent",
"description": "Returns content of the given resource.",
"parameters": [
-{ "name": "identifier", "type": "integer", "description": "Identifier of the resource to get content for." },
-{ "name": "base64Encode", "type": "boolean", "optional": true, "description": "Requests that resource con
[webkit-changes] [89448] trunk/Source/WebCore
Title: [89448] trunk/Source/WebCore
Revision 89448
Author macpher...@chromium.org
Date 2011-06-22 10:42:28 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Luke Macpherson
Reviewed by Dimitri Glazkov.
Support cast from CSSPrimitiveValue to short and use for CSSPropertyWidows and CSSPropertyOrphans.
https://bugs.webkit.org/show_bug.cgi?id=62964
No new tests / refactoring only.
* css/CSSPrimitiveValueMappings.h:
Support cast to/from short.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use cast to short to allow CSSPropertWidows and CSSPropertyOrphans to use existing macro.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89447 => 89448)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 17:27:22 UTC (rev 89447)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 17:42:28 UTC (rev 89448)
@@ -1,3 +1,18 @@
+2011-06-22 Luke Macpherson
+
+Reviewed by Dimitri Glazkov.
+
+Support cast from CSSPrimitiveValue to short and use for CSSPropertyWidows and CSSPropertyOrphans.
+https://bugs.webkit.org/show_bug.cgi?id=62964
+
+No new tests / refactoring only.
+
+* css/CSSPrimitiveValueMappings.h:
+Support cast to/from short.
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+Use cast to short to allow CSSPropertWidows and CSSPropertyOrphans to use existing macro.
+
2011-06-22 Eunmi Lee
Reviewed by Martin Robinson.
Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (89447 => 89448)
--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2011-06-22 17:27:22 UTC (rev 89447)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2011-06-22 17:42:28 UTC (rev 89448)
@@ -47,6 +47,22 @@
namespace WebCore {
+template<> inline CSSPrimitiveValue::CSSPrimitiveValue(short i)
+: m_type(CSS_NUMBER)
+, m_hasCachedCSSText(false)
+{
+m_value.num = static_cast(i);
+}
+
+template<> inline CSSPrimitiveValue::operator short() const
+{
+if (m_type == CSS_NUMBER) // Valid for CSS outline-style
+return static_cast(m_value.num);
+
+ASSERT_NOT_REACHED();
+return 0;
+}
+
template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EBorderStyle e)
: m_type(CSS_IDENT)
, m_hasCachedCSSText(false)
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (89447 => 89448)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-06-22 17:27:22 UTC (rev 89447)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-06-22 17:42:28 UTC (rev 89448)
@@ -4030,23 +4030,11 @@
return;
}
case CSSPropertyWidows:
-{
-HANDLE_INHERIT_AND_INITIAL(widows, Widows)
-if (!primitiveValue || primitiveValue->primitiveType() != CSSPrimitiveValue::CSS_NUMBER)
-return;
-m_style->setWidows(primitiveValue->getIntValue());
+HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(widows, Widows)
return;
-}
-
case CSSPropertyOrphans:
-{
-HANDLE_INHERIT_AND_INITIAL(orphans, Orphans)
-if (!primitiveValue || primitiveValue->primitiveType() != CSSPrimitiveValue::CSS_NUMBER)
-return;
-m_style->setOrphans(primitiveValue->getIntValue());
+HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(orphans, Orphans)
return;
-}
-
// length, percent, number
case CSSPropertyLineHeight:
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89447] trunk/Tools
Title: [89447] trunk/Tools Revision 89447 Author aro...@apple.com Date 2011-06-22 10:27:22 -0700 (Wed, 22 Jun 2011) Log Message Add links to existing bugs related to failing tests on TestFailures page I changed the layout of the page a little to make it easier to read with all the new information. Passing/failing revisions have been moved down below the list of tests to be closer to the existing bugs and the new bug link. And each set of tests and its relevant information is in a light gray box. Fixes TestFailures page should link to existing bugs when possible Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added. (Bugzilla): This new class represents a single Bugzilla instance. (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality, passing the resulting bug titles and URLs to the callback when complete. If called multiple times with the same query before the query returns, caches the callbacks so that only one query is sent over the wire. When the query completes, all pending callbacks are called. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: (#failure-history): Reduce the margin/padding on the top-level list a bit. (#failure-history > li): Put each set of tests in a gray box, and indent most information inside the box. (.test-list): Unindent the list of failing tests so it is visually at the top level. (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of each box isn't a big empty space. (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be quite long. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: (addQueryParametersToURL): New function extracted from ViewController.prototype._domForNewAndExistingBugs. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: (ViewController): Take and store an optional Bugzilla instance. (ViewController.prototype._displayBuilder): Give the top-level list an id for styling purposes and move the list of failing tests above all other information. Only show bug information once we've determined the most-recent passing revision for a set of tests. It's not that useful to file a new bug before this information has been determined, and searching for existing bugs before we've figured out which tests started failing at the same time would end up giving you information about a bunch of unrelated tests. (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla instance, just returns an empty DocumentFragment. Starts a search for bugs related to the failing tests, and adds links to the bugs when the search completes. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a Bugzilla instance for bugs.webkit.org to the ViewController. Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html trunk/Tools/ChangeLog Added Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js Diff Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js (0 => 89447) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js (rev 0) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js 2011-06-22 17:27:22 UTC (rev 89447) @@ -0,0 +1,73 @@ +/* + * Copyright (C) 2011 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCU
[webkit-changes] [89446] trunk/LayoutTests
Title: [89446] trunk/LayoutTests Revision 89446 Author jchaffr...@webkit.org Date 2011-06-22 10:19:10 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Julien Chaffraix Reviewed by Darin Adler. Assertion failure in RenderBlock::createLineBoxes() when a legend has display: inline https://bugs.webkit.org/show_bug.cgi?id=23753 The bug got fixed, so landing the test case. * fast/dom/legend-display-inline-expected.txt: Added. * fast/dom/legend-display-inline.html: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/fast/dom/legend-display-inline-expected.txt trunk/LayoutTests/fast/dom/legend-display-inline.html Diff Modified: trunk/LayoutTests/ChangeLog (89445 => 89446) --- trunk/LayoutTests/ChangeLog 2011-06-22 17:17:51 UTC (rev 89445) +++ trunk/LayoutTests/ChangeLog 2011-06-22 17:19:10 UTC (rev 89446) @@ -1,3 +1,15 @@ +2011-06-22 Julien Chaffraix + +Reviewed by Darin Adler. + +Assertion failure in RenderBlock::createLineBoxes() when a legend has display: inline +https://bugs.webkit.org/show_bug.cgi?id=23753 + +The bug got fixed, so landing the test case. + +* fast/dom/legend-display-inline-expected.txt: Added. +* fast/dom/legend-display-inline.html: Added. + 2011-06-22 Matthew Delaney Reverting rebaseline from r89434, because it needs more investigation. Added: trunk/LayoutTests/fast/dom/legend-display-inline-expected.txt (0 => 89446) --- trunk/LayoutTests/fast/dom/legend-display-inline-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/legend-display-inline-expected.txt 2011-06-22 17:19:10 UTC (rev 89446) @@ -0,0 +1,4 @@ +foo +Bug 23753: Assertion failure in RenderBlock::createLineBoxes() when a legend has display: inline + +This test PASSED if it did not crash Added: trunk/LayoutTests/fast/dom/legend-display-inline.html (0 => 89446) --- trunk/LayoutTests/fast/dom/legend-display-inline.html (rev 0) +++ trunk/LayoutTests/fast/dom/legend-display-inline.html 2011-06-22 17:19:10 UTC (rev 89446) @@ -0,0 +1,6 @@ +foo +Bug +This test PASSED if it did not crash +if (window.layoutTestController) +layoutTestController.dumpAsText(); + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89445] branches/chromium/782
Title: [89445] branches/chromium/782
Revision 89445
Author jchaffr...@webkit.org
Date 2011-06-22 10:17:51 -0700 (Wed, 22 Jun 2011)
Log Message
Merge 89183 - 2011-06-17 Julien Chaffraix
Reviewed by Darin Adler.
Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=62884
* svg/custom/assert-empty-layout-attributes-expected.txt: Added.
* svg/custom/assert-empty-layout-attributes.svg: Added.
2011-06-17 Julien Chaffraix
Reviewed by Darin Adler.
Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=62884
Test: svg/custom/assert-empty-layout-attributes.svg
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Added a early return here.
It is not needed to do the text layout algorithm if you don't have any layout information as
your size is (0, 0) anyway.
TBR=jchaffr...@webkit.org
Review URL: http://codereview.chromium.org/7231014
Modified Paths
branches/chromium/782/LayoutTests/ChangeLog
branches/chromium/782/Source/WebCore/ChangeLog
branches/chromium/782/Source/WebCore/rendering/svg/SVGRootInlineBox.cpp
Added Paths
branches/chromium/782/LayoutTests/svg/custom/assert-empty-layout-attributes-expected.txt
branches/chromium/782/LayoutTests/svg/custom/assert-empty-layout-attributes.svg
Diff
Modified: branches/chromium/782/LayoutTests/ChangeLog (89444 => 89445)
--- branches/chromium/782/LayoutTests/ChangeLog 2011-06-22 17:14:49 UTC (rev 89444)
+++ branches/chromium/782/LayoutTests/ChangeLog 2011-06-22 17:17:51 UTC (rev 89445)
@@ -13,6 +13,16 @@
* platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
* svg/text/scaling-font-with-geometric-precision.html: Added.
+2011-06-17 Julien Chaffraix
+
+Reviewed by Darin Adler.
+
+Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
+https://bugs.webkit.org/show_bug.cgi?id=62884
+
+* svg/custom/assert-empty-layout-attributes-expected.txt: Added.
+* svg/custom/assert-empty-layout-attributes.svg: Added.
+
2011-06-09 Julien Chaffraix
Reviewed by Darin Adler.
Copied: branches/chromium/782/LayoutTests/svg/custom/assert-empty-layout-attributes-expected.txt (from rev 89183, trunk/LayoutTests/svg/custom/assert-empty-layout-attributes-expected.txt) (0 => 89445)
--- branches/chromium/782/LayoutTests/svg/custom/assert-empty-layout-attributes-expected.txt (rev 0)
+++ branches/chromium/782/LayoutTests/svg/custom/assert-empty-layout-attributes-expected.txt 2011-06-22 17:17:51 UTC (rev 89445)
@@ -0,0 +1,2 @@
+Test for https://bugs.webkit.org/show_bug.cgi?id=62884
+This test passes if it did not crash
Copied: branches/chromium/782/LayoutTests/svg/custom/assert-empty-layout-attributes.svg (from rev 89183, trunk/LayoutTests/svg/custom/assert-empty-layout-attributes.svg) (0 => 89445)
--- branches/chromium/782/LayoutTests/svg/custom/assert-empty-layout-attributes.svg (rev 0)
+++ branches/chromium/782/LayoutTests/svg/custom/assert-empty-layout-attributes.svg 2011-06-22 17:17:51 UTC (rev 89445)
@@ -0,0 +1,21 @@
+
+
+
+
+*:after {
+content: "x"
+}
+
+
+
+
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+Test for https://bugs.webkit.org/show_bug.cgi?id=62884
+This test passes if it did not crash
+
Modified: branches/chromium/782/Source/WebCore/ChangeLog (89444 => 89445)
--- branches/chromium/782/Source/WebCore/ChangeLog 2011-06-22 17:14:49 UTC (rev 89444)
+++ branches/chromium/782/Source/WebCore/ChangeLog 2011-06-22 17:17:51 UTC (rev 89445)
@@ -14,6 +14,20 @@
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
+2011-06-17 Julien Chaffraix
+
+Reviewed by Darin Adler.
+
+Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
+https://bugs.webkit.org/show_bug.cgi?id=62884
+
+Test: svg/custom/assert-empty-layout-attributes.svg
+
+* rendering/svg/SVGRootInlineBox.cpp:
+(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Added a early return here.
+It is not needed to do the text layout algorithm if you don't have any layout information as
+your size is (0, 0) anyway.
+
2011-06-09 Julien Chaffraix
Reviewed by Darin Adler.
Modified: branches/chromium/782/Source/WebCore/rendering/svg/SVGRootInlineBox.cpp (89444 => 89445)
--- branches/chromium/782/Source/WebCore/rendering/svg/SVGRootInlineBox.cpp 2011-06-22 17:14:49 UTC (rev 89444)
+++ branches/chromium/782/Source/WebCo
[webkit-changes] [89444] trunk/LayoutTests
Title: [89444] trunk/LayoutTests Revision 89444 Author mdela...@apple.com Date 2011-06-22 10:14:49 -0700 (Wed, 22 Jun 2011) Log Message Undoing possibly incorrect rebaseline from r89434 for webgl test. Filed follow up bug. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/canvas/webgl/data-view-test-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (89443 => 89444) --- trunk/LayoutTests/ChangeLog 2011-06-22 17:13:32 UTC (rev 89443) +++ trunk/LayoutTests/ChangeLog 2011-06-22 17:14:49 UTC (rev 89444) @@ -1,3 +1,10 @@ +2011-06-22 Matthew Delaney + +Reverting rebaseline from r89434, because it needs more investigation. +Filed this bug for figuring it out: https://bugs.webkit.org/show_bug.cgi?id=63151 + +* fast/canvas/webgl/data-view-test-expected.txt: + 2011-06-22 Pavel Feldman Reviewed by Yury Semikhatsky. Modified: trunk/LayoutTests/fast/canvas/webgl/data-view-test-expected.txt (89443 => 89444) --- trunk/LayoutTests/fast/canvas/webgl/data-view-test-expected.txt 2011-06-22 17:13:32 UTC (rev 89443) +++ trunk/LayoutTests/fast/canvas/webgl/data-view-test-expected.txt 2011-06-22 17:14:49 UTC (rev 89444) @@ -305,8 +305,8 @@ PASS view.getUint16() threw exception TypeError: Not enough arguments. PASS view.getInt32() threw exception TypeError: Not enough arguments. PASS view.getUint32() threw exception TypeError: Not enough arguments. -PASS view.getFloat32() threw exception SyntaxError: Not enough arguments. -PASS view.getFloat64() threw exception SyntaxError: Not enough arguments. +PASS view.getFloat32() threw exception TypeError: Not enough arguments. +PASS view.getFloat64() threw exception TypeError: Not enough arguments. Test for set methods that work PASS view.setInt8(0, 0) is undefined. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89443] branches/chromium/782
Title: [89443] branches/chromium/782
Revision 89443
Author jchaffr...@webkit.org
Date 2011-06-22 10:13:32 -0700 (Wed, 22 Jun 2011)
Log Message
Merge 88474 - 2011-06-09 Julien Chaffraix
Reviewed by Darin Adler.
Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
* fast/css/webkit-keyframes-crash-expected.txt: Added.
* fast/css/webkit-keyframes-crash.html: Added.
2011-06-09 Julien Chaffraix
Reviewed by Darin Adler.
WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
Test: fast/css/webkit-keyframes-crash.html
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed
to return a non-null pointer. Thus null-check here like the rest of the code.
TBR=jchaffr...@webkit.org
Review URL: http://codereview.chromium.org/7231013
Modified Paths
branches/chromium/782/LayoutTests/ChangeLog
branches/chromium/782/Source/WebCore/ChangeLog
branches/chromium/782/Source/WebCore/css/WebKitCSSKeyframesRule.cpp
Added Paths
branches/chromium/782/LayoutTests/fast/css/webkit-keyframes-crash-expected.txt
branches/chromium/782/LayoutTests/fast/css/webkit-keyframes-crash.html
Diff
Modified: branches/chromium/782/LayoutTests/ChangeLog (89442 => 89443)
--- branches/chromium/782/LayoutTests/ChangeLog 2011-06-22 16:57:08 UTC (rev 89442)
+++ branches/chromium/782/LayoutTests/ChangeLog 2011-06-22 17:13:32 UTC (rev 89443)
@@ -13,6 +13,16 @@
* platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
* svg/text/scaling-font-with-geometric-precision.html: Added.
+2011-06-09 Julien Chaffraix
+
+Reviewed by Darin Adler.
+
+Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
+https://bugs.webkit.org/show_bug.cgi?id=62384
+
+* fast/css/webkit-keyframes-crash-expected.txt: Added.
+* fast/css/webkit-keyframes-crash.html: Added.
+
2011-06-08 John Bauman
Reviewed by James Robinson.
Copied: branches/chromium/782/LayoutTests/fast/css/webkit-keyframes-crash-expected.txt (from rev 88474, trunk/LayoutTests/fast/css/webkit-keyframes-crash-expected.txt) (0 => 89443)
--- branches/chromium/782/LayoutTests/fast/css/webkit-keyframes-crash-expected.txt (rev 0)
+++ branches/chromium/782/LayoutTests/fast/css/webkit-keyframes-crash-expected.txt 2011-06-22 17:13:32 UTC (rev 89443)
@@ -0,0 +1,5 @@
+Test for bug 62384: WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
+
+This test passed if it did not crash
+
+PASSED
Copied: branches/chromium/782/LayoutTests/fast/css/webkit-keyframes-crash.html (from rev 88474, trunk/LayoutTests/fast/css/webkit-keyframes-crash.html) (0 => 89443)
--- branches/chromium/782/LayoutTests/fast/css/webkit-keyframes-crash.html (rev 0)
+++ branches/chromium/782/LayoutTests/fast/css/webkit-keyframes-crash.html 2011-06-22 17:13:32 UTC (rev 89443)
@@ -0,0 +1,24 @@
+
+
+Test for bug
+This test passed if it did not crash
+FAILED (test not run)
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function main(){
+var e = window.document.styleSheets[0].cssRules[0];
+e.cssRules.item().parentStyleSheet.removeRule();
+e.name = 'bar';
+document.getElementById('console').innerHTML = "PASSED";
+}
+window._onload_ = main;
+
+
+@-webkit-keyframes foo {
+0% {foo: bar;}
+}
+
+
+
Modified: branches/chromium/782/Source/WebCore/ChangeLog (89442 => 89443)
--- branches/chromium/782/Source/WebCore/ChangeLog 2011-06-22 16:57:08 UTC (rev 89442)
+++ branches/chromium/782/Source/WebCore/ChangeLog 2011-06-22 17:13:32 UTC (rev 89443)
@@ -14,6 +14,19 @@
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
+2011-06-09 Julien Chaffraix
+
+Reviewed by Darin Adler.
+
+WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
+https://bugs.webkit.org/show_bug.cgi?id=62384
+
+Test: fast/css/webkit-keyframes-crash.html
+
+* css/WebKitCSSKeyframesRule.cpp:
+(WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed
+to return a non-null pointer. Thus null-check here like the rest of the code.
+
2011-06-08 John Bauman
Reviewed by James Robinson.
Modified: branches/chromium/782/Source/WebCore/css/WebKitCSSKeyframesRule.cpp (89442 => 89443)
--- branches/chromium/782/Source/WebCore/css/WebKitCSSKeyframesRule.cpp 2011-06-22 16:57:08 UTC (rev 89442)
+++ branches/chromium/782/Source/WebCore/css/WebKitCSSKeyframesRule.cpp 2011-06-22 17:13:32 UTC (rev 89443
[webkit-changes] [89442] trunk/Source
Title: [89442] trunk/Source Revision 89442 Author commit-qu...@webkit.org Date 2011-06-22 09:57:08 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Eunmi Lee Reviewed by Martin Robinson. Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port. https://bugs.webkit.org/show_bug.cgi?id=62848 This patch will make GtkWidgetBackingStore shareable with EFL port. It is a preparation to integrate WebKit2's BackingStoreGtk.cpp and BackingStoreEfl.cpp as a BackingStoreCairo.cpp. * GNUmakefile.am: * GNUmakefile.list.am: * platform/graphics/cairo/CairoUtilities.cpp: (WebCore::copyRectFromOneSurfaceToAnother): * platform/graphics/cairo/CairoUtilities.h: * platform/cairo/WidgetBackingStore.h: Added. * platform/gtk/GtkWidgetBackingStore.h: Removed. * platform/gtk/GtkWidgetBackingStoreCairo.cpp: (WebCore::createSurfaceForBackingStore): (WebCore::WidgetBackingStorePrivate::create): (WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate): (WebCore::WidgetBackingStore::create): (WebCore::WidgetBackingStore::WidgetBackingStore): (WebCore::WidgetBackingStore::~WidgetBackingStore): (WebCore::WidgetBackingStore::cairoSurface): (WebCore::WidgetBackingStore::scroll): * platform/gtk/GtkWidgetBackingStoreX11.cpp: (WebCore::WidgetBackingStorePrivate::create): (WebCore::WidgetBackingStorePrivate::~WidgetBackingStorePrivate): (WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate): (WebCore::WidgetBackingStore::create): (WebCore::WidgetBackingStore::WidgetBackingStore): (WebCore::WidgetBackingStore::~WidgetBackingStore): (WebCore::WidgetBackingStore::cairoSurface): (WebCore::WidgetBackingStore::scroll): 2011-06-22 Eunmi Lee Reviewed by Martin Robinson. Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port. https://bugs.webkit.org/show_bug.cgi?id=62848 Change GtkWidgetBackingStore to WidgetBackingStore in the BackingStore.h and gtk/BackingStoreGtk.cpp. * UIProcess/BackingStore.h: * UIProcess/gtk/BackingStoreGtk.cpp: (WebKit::BackingStore::incorporateUpdate): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.h trunk/Source/WebCore/platform/gtk/GtkWidgetBackingStoreCairo.cpp trunk/Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/BackingStore.h trunk/Source/WebKit2/UIProcess/gtk/BackingStoreGtk.cpp Added Paths trunk/Source/WebCore/platform/cairo/ trunk/Source/WebCore/platform/cairo/WidgetBackingStore.h Removed Paths trunk/Source/WebCore/platform/gtk/GtkWidgetBackingStore.h Diff Modified: trunk/Source/WebCore/ChangeLog (89441 => 89442) --- trunk/Source/WebCore/ChangeLog 2011-06-22 16:46:33 UTC (rev 89441) +++ trunk/Source/WebCore/ChangeLog 2011-06-22 16:57:08 UTC (rev 89442) @@ -1,3 +1,40 @@ +2011-06-22 Eunmi Lee + +Reviewed by Martin Robinson. + +Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port. +https://bugs.webkit.org/show_bug.cgi?id=62848 + +This patch will make GtkWidgetBackingStore shareable with EFL port. +It is a preparation to integrate WebKit2's BackingStoreGtk.cpp and +BackingStoreEfl.cpp as a BackingStoreCairo.cpp. + +* GNUmakefile.am: +* GNUmakefile.list.am: +* platform/graphics/cairo/CairoUtilities.cpp: +(WebCore::copyRectFromOneSurfaceToAnother): +* platform/graphics/cairo/CairoUtilities.h: +* platform/cairo/WidgetBackingStore.h: Added. +* platform/gtk/GtkWidgetBackingStore.h: Removed. +* platform/gtk/GtkWidgetBackingStoreCairo.cpp: +(WebCore::createSurfaceForBackingStore): +(WebCore::WidgetBackingStorePrivate::create): +(WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate): +(WebCore::WidgetBackingStore::create): +(WebCore::WidgetBackingStore::WidgetBackingStore): +(WebCore::WidgetBackingStore::~WidgetBackingStore): +(WebCore::WidgetBackingStore::cairoSurface): +(WebCore::WidgetBackingStore::scroll): +* platform/gtk/GtkWidgetBackingStoreX11.cpp: +(WebCore::WidgetBackingStorePrivate::create): +(WebCore::WidgetBackingStorePrivate::~WidgetBackingStorePrivate): +(WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate): +(WebCore::WidgetBackingStore::create): +(WebCore::WidgetBackingStore::WidgetBackingStore): +(WebCore::WidgetBackingStore::~WidgetBackingStore): +
[webkit-changes] [89441] trunk/Source/WebCore
Title: [89441] trunk/Source/WebCore
Revision 89441
Author simon.fra...@apple.com
Date 2011-06-22 09:46:33 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Simon Fraser
Reviewed by Dan Bernstein.
Update position, bounds and anchor point in GraphicsLayerCA all at once
https://bugs.webkit.org/show_bug.cgi?id=63148
Since position, bounds and anchor point are inter-dependent, avoid
redundant work by simply updating them all at the same time.
No behavior changes, so no new tests.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setPosition):
(WebCore::GraphicsLayerCA::setAnchorPoint):
(WebCore::GraphicsLayerCA::setSize):
(WebCore::GraphicsLayerCA::setBoundsOrigin):
(WebCore::GraphicsLayerCA::setAllowTiledLayer):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
* platform/graphics/ca/GraphicsLayerCA.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (89440 => 89441)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 16:45:47 UTC (rev 89440)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 16:46:33 UTC (rev 89441)
@@ -1,3 +1,27 @@
+2011-06-22 Simon Fraser
+
+Reviewed by Dan Bernstein.
+
+Update position, bounds and anchor point in GraphicsLayerCA all at once
+https://bugs.webkit.org/show_bug.cgi?id=63148
+
+Since position, bounds and anchor point are inter-dependent, avoid
+redundant work by simply updating them all at the same time.
+
+No behavior changes, so no new tests.
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::setPosition):
+(WebCore::GraphicsLayerCA::setAnchorPoint):
+(WebCore::GraphicsLayerCA::setSize):
+(WebCore::GraphicsLayerCA::setBoundsOrigin):
+(WebCore::GraphicsLayerCA::setAllowTiledLayer):
+(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
+(WebCore::GraphicsLayerCA::updateGeometry):
+(WebCore::GraphicsLayerCA::ensureStructuralLayer):
+(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
+* platform/graphics/ca/GraphicsLayerCA.h:
+
2011-06-22 Ryosuke Niwa
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (89440 => 89441)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2011-06-22 16:45:47 UTC (rev 89440)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2011-06-22 16:46:33 UTC (rev 89441)
@@ -381,7 +381,7 @@
return;
GraphicsLayer::setPosition(point);
-noteLayerPropertyChanged(PositionChanged);
+noteLayerPropertyChanged(GeometryChanged);
}
void GraphicsLayerCA::setAnchorPoint(const FloatPoint3D& point)
@@ -390,7 +390,7 @@
return;
GraphicsLayer::setAnchorPoint(point);
-noteLayerPropertyChanged(AnchorPointChanged);
+noteLayerPropertyChanged(GeometryChanged);
}
void GraphicsLayerCA::setSize(const FloatSize& size)
@@ -399,7 +399,7 @@
return;
GraphicsLayer::setSize(size);
-noteLayerPropertyChanged(BoundsChanged);
+noteLayerPropertyChanged(GeometryChanged);
}
void GraphicsLayerCA::setBoundsOrigin(const FloatPoint& origin)
@@ -408,7 +408,7 @@
return;
GraphicsLayer::setBoundsOrigin(origin);
-noteLayerPropertyChanged(BoundsChanged);
+noteLayerPropertyChanged(GeometryChanged);
}
void GraphicsLayerCA::setTransform(const TransformationMatrix& t)
@@ -506,7 +506,7 @@
m_allowTiledLayer = allowTiledLayer;
// Handling this as a BoundsChanged will cause use to switch in or out of tiled layer as needed
-noteLayerPropertyChanged(BoundsChanged);
+noteLayerPropertyChanged(GeometryChanged);
}
void GraphicsLayerCA::setBackgroundColor(const Color& color)
@@ -855,14 +855,8 @@
if (m_uncommittedChanges & ChildrenChanged)
updateSublayerList();
-if (m_uncommittedChanges & PositionChanged)
-updateLayerPosition();
-
-if (m_uncommittedChanges & AnchorPointChanged)
-updateAnchorPoint();
-
-if (m_uncommittedChanges & BoundsChanged)
-updateBounds();
+if (m_uncommittedChanges & GeometryChanged)
+updateGeometry();
if (m_uncommittedChanges & TransformChanged)
updateTransform();
@@ -976,14 +970,18 @@
m_layer->setSublayers(newSublayers);
}
-void GraphicsLayerCA::updateLayerPosition()
+void GraphicsLayerCA::updateGeometry()
{
+bool needTiledLayer = requiresTiledLayer(m_size);
+if (needTiledLayer != m_usingTiledLayer)
+
[webkit-changes] [89440] trunk/Source
Title: [89440] trunk/Source Revision 89440 Author rn...@webkit.org Date 2011-06-22 09:45:47 -0700 (Wed, 22 Jun 2011) Log Message 2011-06-22 Ryosuke Niwa Reviewed by Darin Adler. Make instantiation of legacy editing position more explicit https://bugs.webkit.org/show_bug.cgi?id=63037 Create new positions since we can't create a legacy editing position outside of WebCore anymore. * WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition. (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto. 2011-06-22 Ryosuke Niwa Reviewed by Darin Adler. Make instantiation of legacy editing position more explicit https://bugs.webkit.org/show_bug.cgi?id=63037 Replaced the constructor of Position class that used to instantiate a legacy editing position by a function called createLegacyEditingPosition. * WebCore.exp.in: Removed the constructor from the list. * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData): Calls createLegacyEditingPosition. * accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::nodeTextChangePlatformNotification): No longer uses Positions to instantiate a range. * dom/Position.cpp: (WebCore::Position::Position): New constructor takes LegacyEditingOffset, which can only be instantiated by createLegacyEditingPosition. (WebCore::Position::previous): Calls createLegacyEditingPosition. (WebCore::Position::next): Ditto. (WebCore::Position::upstream): Ditto. (WebCore::Position::downstream): Ditto. * dom/Position.h: Added new Position::LegacyEditingOffset class to hide the legacy constructor from the world. (WebCore::Position::LegacyEditingOffset::value): Added. (WebCore::Position::LegacyEditingOffset::LegacyEditingOffset): Added. (WebCore::createLegacyEditingPosition): Added. * dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): Calls createLegacyEditingPosition. * dom/RangeBoundaryPoint.h: (WebCore::RangeBoundaryPoint::toPosition): Ditto. * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): Instantiates new Position instead of old one; this is always safe since the anchor node is always a text node. * editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): Calls createLegacyEditingPosition. (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Ditto. * editing/markup.cpp: (WebCore::StyledMarkupAccumulator::renderedText): Ditto. * editing/visible_units.cpp: (WebCore::previousBoundary): Ditto. (WebCore::previousLinePosition): Ditto. (WebCore::nextLinePosition): Ditto. * page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): Ditto. (WebCore::DOMSelection::setBaseAndExtent): Ditto. (WebCore::DOMSelection::setPosition): Ditto. (WebCore::DOMSelection::extend): Ditto. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForBox): Ditto. * rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint): Calls Position() instead of Position(0, 0). * rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): Calls createLegacyEditingPosition.s Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp trunk/Source/WebCore/dom/Position.cpp trunk/Source/WebCore/dom/Position.h trunk/Source/WebCore/dom/PositionIterator.cpp trunk/Source/WebCore/dom/RangeBoundaryPoint.h trunk/Source/WebCore/editing/InsertTextCommand.cpp trunk/Source/WebCore/editing/VisiblePosition.cpp trunk/Source/WebCore/editing/markup.cpp trunk/Source/WebCore/editing/visible_units.cpp trunk/Source/WebCore/page/DOMSelection.cpp trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebFrame.mm Diff Modified: trunk/Source/WebCore/ChangeLog (89439 => 89440) --- trunk/Source/WebCore/ChangeLog 2011-06-22 16:24:52 UTC (rev 89439) +++ trunk/Source/WebCore/ChangeLog 2011-06-22 16:45:47 UTC (rev 89440) @@ -1,3 +1,57 @@ +2011-06-22 Ryosuke Niwa + +Reviewed by Darin Adler. + +Make instantiation of legacy editing position more explicit +https://bugs.webkit.org/show_bug.cgi?id=63037 + +Replaced the constructor of Position class that used to instantiate a legacy editing position +by a function called createLegacyEditingPosition. + +
[webkit-changes] [89439] trunk
Title: [89439] trunk
Revision 89439
Author pfeld...@chromium.org
Date 2011-06-22 09:24:52 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Pavel Feldman
Reviewed by Yury Semikhatsky.
Web Inspector: split setAttributes and setAttributeValue.
https://bugs.webkit.org/show_bug.cgi?id=63138
* inspector/elements/set-attribute.html:
* inspector/elements/set-attribute-expected.txt:
2011-06-22 Pavel Feldman
Reviewed by Yury Semikhatsky.
Web Inspector: split setAttributes and setAttributeValue.
https://bugs.webkit.org/show_bug.cgi?id=63138
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesText):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.setAttribute):
(WebInspector.DOMNode.prototype.setAttributeValue):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/elements/set-attribute-expected.txt
trunk/LayoutTests/inspector/elements/set-attribute.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/InspectorDOMAgent.h
trunk/Source/WebCore/inspector/front-end/DOMAgent.js
Diff
Modified: trunk/LayoutTests/ChangeLog (89438 => 89439)
--- trunk/LayoutTests/ChangeLog 2011-06-22 16:21:33 UTC (rev 89438)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 16:24:52 UTC (rev 89439)
@@ -1,3 +1,13 @@
+2011-06-22 Pavel Feldman
+
+Reviewed by Yury Semikhatsky.
+
+Web Inspector: split setAttributes and setAttributeValue.
+https://bugs.webkit.org/show_bug.cgi?id=63138
+
+* inspector/elements/set-attribute.html:
+* inspector/elements/set-attribute-expected.txt:
+
2011-06-22 Eric Carlson
Reviewed by Dan Bernstein.
Modified: trunk/LayoutTests/inspector/elements/set-attribute-expected.txt (89438 => 89439)
--- trunk/LayoutTests/inspector/elements/set-attribute-expected.txt 2011-06-22 16:21:33 UTC (rev 89438)
+++ trunk/LayoutTests/inspector/elements/set-attribute-expected.txt 2011-06-22 16:24:52 UTC (rev 89439)
@@ -5,11 +5,23 @@
= Original
-Running: testSetAttribute
-= Set attribute =
+Running: testAttributeUpdated
+= On attribute set =
-Running: testRemoveAttribute
-=== Removed attribute ===
+Running: testAttributeRemoved
+=== On attribute removed ===
+Running: testSetAttributeValue
+=== Set attribute value ===
+
+
+Running: testSetAttributeText
+=== Set attribute as text ===
+
+
+Running: testRemoveAttributeAsText
+=== Remove attribute as text ===
+
+
Modified: trunk/LayoutTests/inspector/elements/set-attribute.html (89438 => 89439)
--- trunk/LayoutTests/inspector/elements/set-attribute.html 2011-06-22 16:21:33 UTC (rev 89438)
+++ trunk/LayoutTests/inspector/elements/set-attribute.html 2011-06-22 16:24:52 UTC (rev 89439)
@@ -33,27 +33,69 @@
InspectorTest.selectNodeWithId("node", callback);
},
-function testSetAttribute(next)
+function testAttributeUpdated(next)
{
function callback()
{
-InspectorTest.addResult("= Set attribute =");
+WebInspector.domAgent.removeEventListener(WebInspector.DOMAgent.Events.AttrModified, callback);
+InspectorTest.addResult("= On attribute set =");
InspectorTest.dumpElementsTree(targetNode);
next();
}
+WebInspector.domAgent.addEventListener(WebInspector.DOMAgent.Events.AttrModified, callback);
InspectorTest.evaluateInPage("setAttribute('name', 'value')");
-InspectorTest.addSniffer(WebInspector.StylesSidebarPane.prototype, "_rebuildUpdate", callback);
},
-function testRemoveAttribute(next) {
+function testAttributeRemoved(next)
+{
function callback()
{
-InspectorTest.addResult("=== Removed attribute ===");
+WebInspector.domAgent.removeEventListener(WebInspector.DOMAgent.Events.AttrModified, callback);
+InspectorTest.addResult("=== On attribute removed ===");
InspectorTest.dumpElementsTree(targetNode);
next();
}
+WebInspector.domAgent.addEventListener(WebInspector.DOMAgent.Events.AttrModified, callback);
InspectorTest.evaluateInPage("removeAttribute('name')");
-InspectorTest.addSniffer(WebInspector.StylesSidebarPane.prototype, "_rebuildUpdate", callback);
+},
+
+function testSetAttributeValue(next)
+{
+function callback()
+{
+WebInspector.domAgent.removeEventListener(WebInspector.DOMAgent.Events.
[webkit-changes] [89438] trunk/Tools
Title: [89438] trunk/Tools
Revision 89438
Author carlo...@webkit.org
Date 2011-06-22 09:21:33 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Carlos Garcia Campos
Reviewed by Martin Robinson.
[GTK] Apply current view settings to newly created views in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=63142
* GtkLauncher/main.c:
(createWebViewCb):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/GtkLauncher/main.c
Diff
Modified: trunk/Tools/ChangeLog (89437 => 89438)
--- trunk/Tools/ChangeLog 2011-06-22 16:20:07 UTC (rev 89437)
+++ trunk/Tools/ChangeLog 2011-06-22 16:21:33 UTC (rev 89438)
@@ -2,6 +2,16 @@
Reviewed by Martin Robinson.
+[GTK] Apply current view settings to newly created views in GtkLauncher
+https://bugs.webkit.org/show_bug.cgi?id=63142
+
+* GtkLauncher/main.c:
+(createWebViewCb):
+
+2011-06-22 Carlos Garcia Campos
+
+Reviewed by Martin Robinson.
+
[GTK] Use GOption to parse main arguments in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=63060
Modified: trunk/Tools/GtkLauncher/main.c (89437 => 89438)
--- trunk/Tools/GtkLauncher/main.c 2011-06-22 16:20:07 UTC (rev 89437)
+++ trunk/Tools/GtkLauncher/main.c 2011-06-22 16:21:33 UTC (rev 89438)
@@ -109,6 +109,7 @@
{
WebKitWebView *newWebView;
createWindow(&newWebView);
+webkit_web_view_set_settings(newWebView, webkit_web_view_get_settings(webView));
return newWebView;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89437] trunk/LayoutTests/ChangeLog
Title: [89437] trunk/LayoutTests/ChangeLog Revision 89437 Author mdela...@apple.com Date 2011-06-22 09:20:07 -0700 (Wed, 22 Jun 2011) Log Message Added rev to ChangeLog for tree burning fix. Modified Paths trunk/LayoutTests/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (89436 => 89437) --- trunk/LayoutTests/ChangeLog 2011-06-22 16:11:54 UTC (rev 89436) +++ trunk/LayoutTests/ChangeLog 2011-06-22 16:20:07 UTC (rev 89437) @@ -10,7 +10,7 @@ 2011-06-22 Matthew Delaney Fixing burning mac SL trees. These tests's expected results needed -updating after parts of them were fixed recently. +updating after parts of them were fixed recently in r89315. * fast/canvas/webgl/data-view-test-expected.txt: * platform/mac/canvas/philip/tests/2d.missingargs-expected.txt: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89436] trunk/Source/WebKit2
Title: [89436] trunk/Source/WebKit2
Revision 89436
Author aro...@apple.com
Date 2011-06-22 09:11:54 -0700 (Wed, 22 Jun 2011)
Log Message
Don't use an alpha channel when drawing the web page on Windows
We never use the alpha channel in the end anyway (because we never render into a layered
window, which is the only kind of window that supports alpha). And using an alpha channel is
tricky to get right since GDI doesn't support alpha (and often writes 0x0 into the alpha
channel).
Fixes REGRESSION (r88978): Text inside
form controls looks really awful on Windows XP
Reviewed by Anders Carlsson.
* WebProcess/WebPage/win/DrawingAreaImplWin.cpp:
(WebKit::DrawingAreaImpl::createGraphicsContext): Specify false for the hasAlpha parameter
to the GraphicsContext constructor.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (89435 => 89436)
--- trunk/Source/WebKit2/ChangeLog 2011-06-22 16:03:55 UTC (rev 89435)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-22 16:11:54 UTC (rev 89436)
@@ -1,3 +1,21 @@
+2011-06-22 Adam Roben
+
+Don't use an alpha channel when drawing the web page on Windows
+
+We never use the alpha channel in the end anyway (because we never render into a layered
+window, which is the only kind of window that supports alpha). And using an alpha channel is
+tricky to get right since GDI doesn't support alpha (and often writes 0x0 into the alpha
+channel).
+
+Fixes REGRESSION (r88978): Text inside
+form controls looks really awful on Windows XP
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/WebPage/win/DrawingAreaImplWin.cpp:
+(WebKit::DrawingAreaImpl::createGraphicsContext): Specify false for the hasAlpha parameter
+to the GraphicsContext constructor.
+
2011-06-22 Carlos Garcia Campos
Reviewed by Martin Robinson.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp (89435 => 89436)
--- trunk/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp 2011-06-22 16:03:55 UTC (rev 89435)
+++ trunk/Source/WebKit2/WebProcess/WebPage/win/DrawingAreaImplWin.cpp 2011-06-22 16:11:54 UTC (rev 89436)
@@ -54,7 +54,10 @@
PassOwnPtr DrawingAreaImpl::createGraphicsContext(ShareableBitmap* bitmap)
{
HDC bitmapDC = bitmap->windowsContext();
-return adoptPtr(new GraphicsContext(bitmapDC, true));
+// FIXME: We should really be checking m_webPage->draws[Transparent]Background() to determine
+// whether to have an alpha channel or not. But currently we always render into a non-layered
+// window, so the alpha channel doesn't matter anyway.
+return adoptPtr(new GraphicsContext(bitmapDC, false));
}
} // namespace WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89435] trunk/LayoutTests
Title: [89435] trunk/LayoutTests
Revision 89435
Author eric.carl...@apple.com
Date 2011-06-22 09:03:55 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Eric Carlson
Reviewed by Dan Bernstein.
video-loop.html sometimes fails on slow system
https://bugs.webkit.org/show_bug.cgi?id=63143
* media/video-loop.html: Don't seek if an exception will be generated.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-loop.html
Diff
Modified: trunk/LayoutTests/ChangeLog (89434 => 89435)
--- trunk/LayoutTests/ChangeLog 2011-06-22 15:57:33 UTC (rev 89434)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 16:03:55 UTC (rev 89435)
@@ -1,3 +1,12 @@
+2011-06-22 Eric Carlson
+
+Reviewed by Dan Bernstein.
+
+video-loop.html sometimes fails on slow system
+https://bugs.webkit.org/show_bug.cgi?id=63143
+
+* media/video-loop.html: Don't seek if an exception will be generated.
+
2011-06-22 Matthew Delaney
Fixing burning mac SL trees. These tests's expected results needed
Modified: trunk/LayoutTests/media/video-loop.html (89434 => 89435)
--- trunk/LayoutTests/media/video-loop.html 2011-06-22 15:57:33 UTC (rev 89434)
+++ trunk/LayoutTests/media/video-loop.html 2011-06-22 16:03:55 UTC (rev 89435)
@@ -10,6 +10,11 @@
function play()
{
+if (video.readyState < HTMLMediaElement.HAVE_METADATA) {
+setTimeout(play, 100);
+return;
+}
+
if (++playCount > 1)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89434] trunk/LayoutTests
Title: [89434] trunk/LayoutTests Revision 89434 Author mdela...@apple.com Date 2011-06-22 08:57:33 -0700 (Wed, 22 Jun 2011) Log Message Fixing burning mac SL trees. These tests's expected results needed updating after parts of them were fixed recently. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/canvas/webgl/data-view-test-expected.txt trunk/LayoutTests/platform/mac/canvas/philip/tests/2d.missingargs-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (89433 => 89434) --- trunk/LayoutTests/ChangeLog 2011-06-22 15:44:04 UTC (rev 89433) +++ trunk/LayoutTests/ChangeLog 2011-06-22 15:57:33 UTC (rev 89434) @@ -1,3 +1,11 @@ +2011-06-22 Matthew Delaney + +Fixing burning mac SL trees. These tests's expected results needed +updating after parts of them were fixed recently. + +* fast/canvas/webgl/data-view-test-expected.txt: +* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt: + 2011-06-22 Dirk Schulze Reviewed by Nikolas Zimmermann. Modified: trunk/LayoutTests/fast/canvas/webgl/data-view-test-expected.txt (89433 => 89434) --- trunk/LayoutTests/fast/canvas/webgl/data-view-test-expected.txt 2011-06-22 15:44:04 UTC (rev 89433) +++ trunk/LayoutTests/fast/canvas/webgl/data-view-test-expected.txt 2011-06-22 15:57:33 UTC (rev 89434) @@ -305,8 +305,8 @@ PASS view.getUint16() threw exception TypeError: Not enough arguments. PASS view.getInt32() threw exception TypeError: Not enough arguments. PASS view.getUint32() threw exception TypeError: Not enough arguments. -PASS view.getFloat32() threw exception TypeError: Not enough arguments. -PASS view.getFloat64() threw exception TypeError: Not enough arguments. +PASS view.getFloat32() threw exception SyntaxError: Not enough arguments. +PASS view.getFloat64() threw exception SyntaxError: Not enough arguments. Test for set methods that work PASS view.setInt8(0, 0) is undefined. Modified: trunk/LayoutTests/platform/mac/canvas/philip/tests/2d.missingargs-expected.txt (89433 => 89434) --- trunk/LayoutTests/platform/mac/canvas/philip/tests/2d.missingargs-expected.txt 2011-06-22 15:44:04 UTC (rev 89433) +++ trunk/LayoutTests/platform/mac/canvas/philip/tests/2d.missingargs-expected.txt 2011-06-22 15:57:33 UTC (rev 89434) @@ -68,12 +68,6 @@ Failed assertion: should throw exception of type TypeError: ctx.arc(0, 0, 1, 0) Failed assertion: should throw exception of type TypeError: ctx.isPointInPath() Failed assertion: should throw exception of type TypeError: ctx.isPointInPath(0) -Failed assertion: expected exception of type TypeError, got: SyntaxError: Not enough arguments -Failed assertion: expected exception of type TypeError, got: SyntaxError: Not enough arguments -Failed assertion: expected exception of type TypeError, got: SyntaxError: Not enough arguments -Failed assertion: expected exception of type TypeError, got: SyntaxError: Not enough arguments -Failed assertion: expected exception of type TypeError, got: SyntaxError: Not enough arguments -Failed assertion: expected exception of type TypeError, got: SyntaxError: Not enough arguments Failed assertion: should throw exception of type TypeError: ctx.measureText() Failed assertion: should throw exception of type TypeError: ctx.createImageData() Failed assertion: expected exception of type TypeError, got: Error: NOT_SUPPORTED_ERR: DOM Exception 9 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
