[webkit-changes] [91558] trunk/Source/JavaScriptCore
Title: [91558] trunk/Source/_javascript_Core Revision 91558 Author barraclo...@apple.com Date 2011-07-21 23:55:41 -0700 (Thu, 21 Jul 2011) Log Message Windows build fix * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def Diff Modified: trunk/Source/_javascript_Core/ChangeLog (91557 => 91558) --- trunk/Source/_javascript_Core/ChangeLog 2011-07-22 06:28:14 UTC (rev 91557) +++ trunk/Source/_javascript_Core/ChangeLog 2011-07-22 06:55:41 UTC (rev 91558) @@ -1,3 +1,9 @@ +2011-07-21 Gavin Barraclough + +Windows build fix + +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: + 2011-07-21 Ryosuke Niwa Build fix after r91555. Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (91557 => 91558) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-07-22 06:28:14 UTC (rev 91557) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-07-22 06:55:41 UTC (rev 91558) @@ -339,6 +339,7 @@ ?toNumber@JSCell@JSC@@UBENPAVExecState@2@@Z ?toNumber@JSObject@JSC@@UBENPAVExecState@2@@Z ?toNumber@JSString@JSC@@EBENPAVExecState@2@@Z +?toNumberSlowCase@JSValue@JSC@@ABENPAVExecState@2@@Z ?toObject@JSCell@JSC@@UBEPAVJSObject@2@PAVExecState@2@PAVJSGlobalObject@2@@Z ?toObject@JSObject@JSC@@UBEPAV12@PAVExecState@2@PAVJSGlobalObject@2@@Z ?toObjectSlowCase@JSValue@JSC@@ABEPAVJSObject@2@PAVExecState@2@PAVJSGlobalObject@2@@Z ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91557] trunk/Source/JavaScriptCore
Title: [91557] trunk/Source/_javascript_Core Revision 91557 Author rn...@webkit.org Date 2011-07-21 23:28:14 -0700 (Thu, 21 Jul 2011) Log Message Build fix after r91555. * _javascript_Core.exp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.exp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (91556 => 91557) --- trunk/Source/_javascript_Core/ChangeLog 2011-07-22 05:35:38 UTC (rev 91556) +++ trunk/Source/_javascript_Core/ChangeLog 2011-07-22 06:28:14 UTC (rev 91557) @@ -1,3 +1,9 @@ +2011-07-21 Ryosuke Niwa + +Build fix after r91555. + +* _javascript_Core.exp: + 2011-07-21 Gavin Barraclough https://bugs.webkit.org/show_bug.cgi?id=19271 Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (91556 => 91557) --- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-07-22 05:35:38 UTC (rev 91556) +++ trunk/Source/_javascript_Core/_javascript_Core.exp 2011-07-22 06:28:14 UTC (rev 91557) @@ -552,6 +552,7 @@ __ZNK3JSC6JSCell9toBooleanEPNS_9ExecStateE __ZNK3JSC7ArgList8getSliceEiRS0_ __ZNK3JSC7JSArray12subclassDataEv +__ZNK3JSC7JSValue16toNumberSlowCaseEPNS_9ExecStateE __ZNK3JSC7JSValue16toObjectSlowCaseEPNS_9ExecStateEPNS_14JSGlobalObjectE __ZNK3JSC7JSValue19synthesizePrototypeEPNS_9ExecStateE __ZNK3JSC7JSValue20toThisObjectSlowCaseEPNS_9ExecStateE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91556] trunk
Title: [91556] trunk Revision 91556 Author tk...@chromium.org Date 2011-07-21 22:35:38 -0700 (Thu, 21 Jul 2011) Log Message A trivial fix for r91550. https://bugs.webkit.org/show_bug.cgi?id=65001 Source/WebCore: Need to update placeholder visibility when the owner elemnent style is changed. * html/HTMLTextFormControlElement.h: Make updatePlaceholderVisibility() public. * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange): Call updatePlaceholderVisibility(). LayoutTests: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLTextFormControlElement.h trunk/Source/WebCore/rendering/RenderTextControl.cpp Diff Modified: trunk/LayoutTests/ChangeLog (91555 => 91556) --- trunk/LayoutTests/ChangeLog 2011-07-22 05:34:08 UTC (rev 91555) +++ trunk/LayoutTests/ChangeLog 2011-07-22 05:35:38 UTC (rev 91556) @@ -1,3 +1,10 @@ +2011-07-21 Kent Tamura + +A trivial fix for r91550. +https://bugs.webkit.org/show_bug.cgi?id=65001 + +* platform/chromium/test_expectations.txt: + 2011-07-21 Gavin Barraclough https://bugs.webkit.org/show_bug.cgi?id=64875 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (91555 => 91556) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-22 05:34:08 UTC (rev 91555) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-22 05:35:38 UTC (rev 91556) @@ -3846,4 +3846,3 @@ BUGRNIWA : fast/css/absolute-child-with-percent-height-inside-relative-parent.html = MISSING BUGWK65009 MAC : scrollbars/scrollbar-drag-thumb-with-large-content.html = TEXT -BUGWK65010 : fast/forms/placeholder-in-invisible-elements.html = IMAGE Modified: trunk/Source/WebCore/ChangeLog (91555 => 91556) --- trunk/Source/WebCore/ChangeLog 2011-07-22 05:34:08 UTC (rev 91555) +++ trunk/Source/WebCore/ChangeLog 2011-07-22 05:35:38 UTC (rev 91556) @@ -1,3 +1,15 @@ +2011-07-21 Kent Tamura + +A trivial fix for r91550. +https://bugs.webkit.org/show_bug.cgi?id=65001 + +Need to update placeholder visibility when the owner elemnent style is changed. + +* html/HTMLTextFormControlElement.h: Make updatePlaceholderVisibility() public. +* rendering/RenderTextControl.cpp: +(WebCore::RenderTextControl::styleDidChange): +Call updatePlaceholderVisibility(). + 2011-07-21 Pratik Solanki https://bugs.webkit.org/show_bug.cgi?id=65002 Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.h (91555 => 91556) --- trunk/Source/WebCore/html/HTMLTextFormControlElement.h 2011-07-22 05:34:08 UTC (rev 91555) +++ trunk/Source/WebCore/html/HTMLTextFormControlElement.h 2011-07-22 05:35:38 UTC (rev 91556) @@ -48,6 +48,7 @@ String strippedPlaceholder() const; bool placeholderShouldBeVisible() const; virtual HTMLElement* placeholderElement() const = 0; +void updatePlaceholderVisibility(bool); int indexForVisiblePosition(const VisiblePosition&) const; int selectionStart() const; @@ -76,7 +77,6 @@ protected: HTMLTextFormControlElement(const QualifiedName&, Document*, HTMLFormElement*); -void updatePlaceholderVisibility(bool); virtual void updatePlaceholderText() = 0; virtual void parseMappedAttribute(Attribute*); Modified: trunk/Source/WebCore/rendering/RenderTextControl.cpp (91555 => 91556) --- trunk/Source/WebCore/rendering/RenderTextControl.cpp 2011-07-22 05:34:08 UTC (rev 91555) +++ trunk/Source/WebCore/rendering/RenderTextControl.cpp 2011-07-22 05:35:38 UTC (rev 91556) @@ -102,6 +102,7 @@ innerTextRenderer->setStyle(createInnerTextStyle(style())); innerText->setNeedsStyleRecalc(); } +textFormControlElement()->updatePlaceholderVisibility(false); } static inline bool updateUserModifyProperty(Node* node, RenderStyle* style) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91555] trunk/Source/JavaScriptCore
Title: [91555] trunk/Source/_javascript_Core
Revision 91555
Author barraclo...@apple.com
Date 2011-07-21 22:34:08 -0700 (Thu, 21 Jul 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=19271
eliminate PIC branches by changing NaN handling in JSValue::toNumber
Reviewed by Sam Weinig.
Moving the non-numeric cases out of line seems to be a consistent
win on SunSpider for me, to the order of about 0.5%.
* runtime/JSCell.h:
(JSC::JSCell::JSValue::toNumber):
- Changed to only handle values that are already numbers, moce non-numeric cases out of line.
* runtime/JSValue.cpp:
(JSC::JSValue::toNumberSlowCase):
- Added toNumberSlowCase, handling non-numeric cases.
* runtime/JSValue.h:
- Add declaration of toNumberSlowCase.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSValue.cpp
trunk/Source/_javascript_Core/runtime/JSValue.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (91554 => 91555)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-22 05:27:03 UTC (rev 91554)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-22 05:34:08 UTC (rev 91555)
@@ -1,5 +1,24 @@
2011-07-21 Gavin Barraclough
+https://bugs.webkit.org/show_bug.cgi?id=19271
+eliminate PIC branches by changing NaN handling in JSValue::toNumber
+
+Reviewed by Sam Weinig.
+
+Moving the non-numeric cases out of line seems to be a consistent
+win on SunSpider for me, to the order of about 0.5%.
+
+* runtime/JSCell.h:
+(JSC::JSCell::JSValue::toNumber):
+- Changed to only handle values that are already numbers, moce non-numeric cases out of line.
+* runtime/JSValue.cpp:
+(JSC::JSValue::toNumberSlowCase):
+- Added toNumberSlowCase, handling non-numeric cases.
+* runtime/JSValue.h:
+- Add declaration of toNumberSlowCase.
+
+2011-07-21 Gavin Barraclough
+
https://bugs.webkit.org/show_bug.cgi?id=64875
Use of `yield` keyword is broken
Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (91554 => 91555)
--- trunk/Source/_javascript_Core/runtime/JSCell.h 2011-07-22 05:27:03 UTC (rev 91554)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h 2011-07-22 05:34:08 UTC (rev 91555)
@@ -324,11 +324,7 @@
return asInt32();
if (isDouble())
return asDouble();
-if (isCell())
-return asCell()->toNumber(exec);
-if (isTrue())
-return 1.0;
-return isUndefined() ? std::numeric_limits::quiet_NaN() : 0; // null and false both convert to 0.
+return toNumberSlowCase(exec);
}
inline JSValue JSValue::getJSNumber()
Modified: trunk/Source/_javascript_Core/runtime/JSValue.cpp (91554 => 91555)
--- trunk/Source/_javascript_Core/runtime/JSValue.cpp 2011-07-22 05:27:03 UTC (rev 91554)
+++ trunk/Source/_javascript_Core/runtime/JSValue.cpp 2011-07-22 05:34:08 UTC (rev 91555)
@@ -54,6 +54,16 @@
return trunc(toNumber(exec));
}
+double JSValue::toNumberSlowCase(ExecState* exec) const
+{
+ASSERT(!isInt32() && !isDouble());
+if (isCell())
+return asCell()->toNumber(exec);
+if (isTrue())
+return 1.0;
+return isUndefined() ? std::numeric_limits::quiet_NaN() : 0; // null and false both convert to 0.
+}
+
JSObject* JSValue::toObjectSlowCase(ExecState* exec, JSGlobalObject* globalObject) const
{
ASSERT(!isCell());
Modified: trunk/Source/_javascript_Core/runtime/JSValue.h (91554 => 91555)
--- trunk/Source/_javascript_Core/runtime/JSValue.h 2011-07-22 05:27:03 UTC (rev 91554)
+++ trunk/Source/_javascript_Core/runtime/JSValue.h 2011-07-22 05:34:08 UTC (rev 91555)
@@ -236,6 +236,7 @@
JSValue(HashTableDeletedValueTag);
inline const JSValue asValue() const { return *this; }
+double toNumberSlowCase(ExecState*) const;
JSObject* toObjectSlowCase(ExecState*, JSGlobalObject*) const;
JSObject* toThisObjectSlowCase(ExecState*) const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91554] trunk/Source/WebCore
Title: [91554] trunk/Source/WebCore
Revision 91554
Author psola...@apple.com
Date 2011-07-21 22:27:03 -0700 (Thu, 21 Jul 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=65002
Get authentication to work with USE(CFNETWORK) on Mac
Reviewed by David Kilzer.
Instead of creating a new CFURLAuthChallengeRef, we save and reuse the same object as the
one given to us by CFNetwork.
* platform/network/mac/AuthenticationMac.mm:
(-[WebCoreAuthenticationClientAsChallengeSender setCFChallenge:]): Accessor methods for the
new CFURLAuthChallengeRef ivar.
(-[WebCoreAuthenticationClientAsChallengeSender cfChallenge]):
(WebCore::core): Create AuthenticationChallenge using the saved CFURLAuthChallengeRef.
(WebCore::mac): Use the CFURLAuthChallengeRef object in AuthenticationChallenge instead of
creating a new one.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (91553 => 91554)
--- trunk/Source/WebCore/ChangeLog 2011-07-22 05:24:24 UTC (rev 91553)
+++ trunk/Source/WebCore/ChangeLog 2011-07-22 05:27:03 UTC (rev 91554)
@@ -1,3 +1,21 @@
+2011-07-21 Pratik Solanki
+
+https://bugs.webkit.org/show_bug.cgi?id=65002
+Get authentication to work with USE(CFNETWORK) on Mac
+
+Reviewed by David Kilzer.
+
+Instead of creating a new CFURLAuthChallengeRef, we save and reuse the same object as the
+one given to us by CFNetwork.
+
+* platform/network/mac/AuthenticationMac.mm:
+(-[WebCoreAuthenticationClientAsChallengeSender setCFChallenge:]): Accessor methods for the
+new CFURLAuthChallengeRef ivar.
+(-[WebCoreAuthenticationClientAsChallengeSender cfChallenge]):
+(WebCore::core): Create AuthenticationChallenge using the saved CFURLAuthChallengeRef.
+(WebCore::mac): Use the CFURLAuthChallengeRef object in AuthenticationChallenge instead of
+creating a new one.
+
2011-07-21 Kent Tamura
REGRESSION(r90971): Placeholder and search cancel button are visible even in elements with visibility:hidden.
Modified: trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm (91553 => 91554)
--- trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm 2011-07-22 05:24:24 UTC (rev 91553)
+++ trunk/Source/WebCore/platform/network/mac/AuthenticationMac.mm 2011-07-22 05:27:03 UTC (rev 91554)
@@ -43,7 +43,6 @@
@end
@interface NSURLAuthenticationChallenge (Details)
--(CFURLAuthChallengeRef)_createCFAuthChallenge;
+(NSURLAuthenticationChallenge *)_authenticationChallengeForCFAuthChallenge:(CFURLAuthChallengeRef)cfChallenge sender:(id )sender;
@end
@@ -59,6 +58,9 @@
@interface WebCoreAuthenticationClientAsChallengeSender : NSObject
{
AuthenticationClient* m_client;
+#if USE(CFNETWORK)
+CFURLAuthChallengeRef m_cfChallenge;
+#endif
}
- (id)initWithAuthenticationClient:(AuthenticationClient*)client;
- (AuthenticationClient*)client;
@@ -104,6 +106,18 @@
m_client->receivedCancellation(core(challenge));
}
+#if USE(CFNETWORK)
+- (void)setCFChallenge:(CFURLAuthChallengeRef)challenge
+{
+m_cfChallenge = challenge;
+}
+
+- (CFURLAuthChallengeRef)cfChallenge
+{
+return m_cfChallenge;
+}
+#endif
+
@end
namespace WebCore {
@@ -113,8 +127,7 @@
AuthenticationChallenge core(NSURLAuthenticationChallenge *macChallenge)
{
WebCoreAuthenticationClientAsChallengeSender *challengeSender = (WebCoreAuthenticationClientAsChallengeSender*) [macChallenge sender];
-AuthenticationClient* authClient = [challengeSender client];
-return AuthenticationChallenge([macChallenge _createCFAuthChallenge], authClient);
+return AuthenticationChallenge([challengeSender cfChallenge], [challengeSender client]);
}
Credential core(NSURLCredential *macCredential)
@@ -137,7 +150,10 @@
{
AuthenticationClient* authClient = coreChallenge.authenticationClient();
RetainPtr challengeSender(AdoptNS, [[WebCoreAuthenticationClientAsChallengeSender alloc] initWithAuthenticationClient:authClient]);
-RetainPtr authChallenge(AdoptCF, createCF(coreChallenge));
+RetainPtr authChallenge = coreChallenge.cfURLAuthChallengeRef();
+if (!authChallenge)
+authChallenge.adoptCF(createCF(coreChallenge));
+[challengeSender.get() setCFChallenge:authChallenge.get()];
return [[NSURLAuthenticationChallenge _authenticationChallengeForCFAuthChallenge:authChallenge.get() sender:challengeSender.get()] autorelease];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91552] trunk/LayoutTests
Title: [91552] trunk/LayoutTests Revision 91552 Author rn...@webkit.org Date 2011-07-21 22:06:33 -0700 (Thu, 21 Jul 2011) Log Message Add a failing expectation for fast/forms/placeholder-in-invisible-elements.html added by r91550 on Chromium. The failure is tracked by the bug 65010. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (91551 => 91552) --- trunk/LayoutTests/ChangeLog 2011-07-22 04:55:34 UTC (rev 91551) +++ trunk/LayoutTests/ChangeLog 2011-07-22 05:06:33 UTC (rev 91552) @@ -1,5 +1,12 @@ 2011-07-21 Ryosuke Niwa +Add a failing expectation for fast/forms/placeholder-in-invisible-elements.html +added by r91550 on Chromium. The failure is tracked by the bug 65010. + +* platform/chromium/test_expectations.txt: + +2011-07-21 Ryosuke Niwa + Remove wrong test expectation added in r91490. Also add failing test expectation for scrollbar-drag-thumb-with-large-content.html, tracked by the bug 65009. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (91551 => 91552) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-22 04:55:34 UTC (rev 91551) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-22 05:06:33 UTC (rev 91552) @@ -3846,3 +3846,4 @@ BUGRNIWA : fast/css/absolute-child-with-percent-height-inside-relative-parent.html = MISSING BUGWK65009 MAC : scrollbars/scrollbar-drag-thumb-with-large-content.html = TEXT +BUGWK65010 : fast/forms/placeholder-in-invisible-elements.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91551] trunk/LayoutTests
Title: [91551] trunk/LayoutTests Revision 91551 Author rn...@webkit.org Date 2011-07-21 21:55:34 -0700 (Thu, 21 Jul 2011) Log Message Remove wrong test expectation added in r91490. Also add failing test expectation for scrollbar-drag-thumb-with-large-content.html, tracked by the bug 65009. * platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt: Removed. * platform/chromium/test_expectations.txt Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Removed Paths trunk/LayoutTests/platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (91550 => 91551) --- trunk/LayoutTests/ChangeLog 2011-07-22 03:31:27 UTC (rev 91550) +++ trunk/LayoutTests/ChangeLog 2011-07-22 04:55:34 UTC (rev 91551) @@ -1,3 +1,12 @@ +2011-07-21 Ryosuke Niwa + +Remove wrong test expectation added in r91490. + +Also add failing test expectation for scrollbar-drag-thumb-with-large-content.html, tracked by the bug 65009. + +* platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt: Removed. +* platform/chromium/test_expectations.txt + 2011-07-21 Kent Tamura REGRESSION(r90971): Placeholder and search cancel button are visible even in elements with visibility:hidden. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (91550 => 91551) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-22 03:31:27 UTC (rev 91550) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-22 04:55:34 UTC (rev 91551) @@ -3844,3 +3844,5 @@ BUGRNIWA WIN : http/tests/inspector/resource-tree/resource-tree-non-unique-url.html = TEXT BUGRNIWA : fast/css/absolute-child-with-percent-height-inside-relative-parent.html = MISSING + +BUGWK65009 MAC : scrollbars/scrollbar-drag-thumb-with-large-content.html = TEXT Deleted: trunk/LayoutTests/platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt (91550 => 91551) --- trunk/LayoutTests/platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt 2011-07-22 03:31:27 UTC (rev 91550) +++ trunk/LayoutTests/platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt 2011-07-22 04:55:34 UTC (rev 91551) @@ -1,24 +0,0 @@ -Absolute position -Relative position -Fixed position -First Second -This cell has borderTopExtra -Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. -Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. -In columns -Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. - -Div with transform -Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. - -In RTL overflow -Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. - -PASS: event at (112, 62) hit abs-box at offset (32, 37) -FAIL: event at (157, 32) expected to hit rel-box at (22, 24) but hit rel-box at (22, 22) -PASS: event at (410, 30) hit fixed-box at offset (10, 10) -FAIL: event at (36, 272) expected to hit with-bordertopextra at (4, 4) but hit filler at (56, 372) -FAIL: event at (639, 207) expected to hit in-columns at (173, -172) but hit in-columns at (173, -205) -FAIL: event at (563, 410) expected to hit inside-overflow at (7, 6) but hit overflow-contents at (178, 112) -FAIL: event at (112, 369) expected to hit transformed at (11, 16) but hit transformed at (7, 2) - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91550] trunk
Title: [91550] trunk
Revision 91550
Author tk...@chromium.org
Date 2011-07-21 20:31:27 -0700 (Thu, 21 Jul 2011)
Log Message
REGRESSION(r90971): Placeholder and search cancel button are visible even in elements with visibility:hidden.
https://bugs.webkit.org/show_bug.cgi?id=65001
Reviewed by Dimitri Glazkov.
Source/WebCore:
Tests: fast/forms/placeholder-in-invisible-elements.html
fast/forms/search-cancel-in-invisible-elements.html
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Don't show the placeholder if the 'visibility' property of the owner element is 'hidden.'
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton): ditto.
LayoutTests:
* fast/forms/placeholder-in-invisible-elements-expected.html: Added.
* fast/forms/placeholder-in-invisible-elements.html: Added.
* fast/forms/search-cancel-in-invisible-elements-expected.html: Added.
* fast/forms/search-cancel-in-invisible-elements.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
Added Paths
trunk/LayoutTests/fast/forms/placeholder-in-invisible-elements-expected.html
trunk/LayoutTests/fast/forms/placeholder-in-invisible-elements.html
trunk/LayoutTests/fast/forms/search-cancel-in-invisible-elements-expected.html
trunk/LayoutTests/fast/forms/search-cancel-in-invisible-elements.html
Diff
Modified: trunk/LayoutTests/ChangeLog (91549 => 91550)
--- trunk/LayoutTests/ChangeLog 2011-07-22 03:27:30 UTC (rev 91549)
+++ trunk/LayoutTests/ChangeLog 2011-07-22 03:31:27 UTC (rev 91550)
@@ -1,3 +1,15 @@
+2011-07-21 Kent Tamura
+
+REGRESSION(r90971): Placeholder and search cancel button are visible even in elements with visibility:hidden.
+https://bugs.webkit.org/show_bug.cgi?id=65001
+
+Reviewed by Dimitri Glazkov.
+
+* fast/forms/placeholder-in-invisible-elements-expected.html: Added.
+* fast/forms/placeholder-in-invisible-elements.html: Added.
+* fast/forms/search-cancel-in-invisible-elements-expected.html: Added.
+* fast/forms/search-cancel-in-invisible-elements.html: Added.
+
2011-07-21 Shinya Kawanaka
The input[type="number"] with step="any" should not suffer from step mismatch.
Added: trunk/LayoutTests/fast/forms/placeholder-in-invisible-elements-expected.html (0 => 91550)
--- trunk/LayoutTests/fast/forms/placeholder-in-invisible-elements-expected.html (rev 0)
+++ trunk/LayoutTests/fast/forms/placeholder-in-invisible-elements-expected.html 2011-07-22 03:31:27 UTC (rev 91550)
@@ -0,0 +1,3 @@
+
+
+
Property changes on: trunk/LayoutTests/fast/forms/placeholder-in-invisible-elements-expected.html
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/forms/placeholder-in-invisible-elements.html (0 => 91550)
--- trunk/LayoutTests/fast/forms/placeholder-in-invisible-elements.html (rev 0)
+++ trunk/LayoutTests/fast/forms/placeholder-in-invisible-elements.html 2011-07-22 03:31:27 UTC (rev 91550)
@@ -0,0 +1,16 @@
+
+
+
+
+
+
+
+
+
+
+
+
+document.getElementById('i').style.visibility = 'hidden';
+
+
+
Property changes on: trunk/LayoutTests/fast/forms/placeholder-in-invisible-elements.html
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/forms/search-cancel-in-invisible-elements-expected.html (0 => 91550)
--- trunk/LayoutTests/fast/forms/search-cancel-in-invisible-elements-expected.html (rev 0)
+++ trunk/LayoutTests/fast/forms/search-cancel-in-invisible-elements-expected.html 2011-07-22 03:31:27 UTC (rev 91550)
@@ -0,0 +1,3 @@
+
+
+
Property changes on: trunk/LayoutTests/fast/forms/search-cancel-in-invisible-elements-expected.html
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/forms/search-cancel-in-invisible-elements.html (0 => 91550)
--- trunk/LayoutTests/fast/forms/search-cancel-in-invisible-elements.html (rev 0)
+++ trunk/LayoutTests/fast/forms/search-cancel-in-invisible-elements.html 2011-07-22 03:31:27 UTC (rev 91550)
@@ -0,0 +1,12 @@
+
+
+
+
+
+
+
+
+document.getElementById('s').style.visibility = 'hidden';
+
+
+
Property changes on: trunk/LayoutTests/fast/forms/search-cancel-in-invisible-elements.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (91549 => 91550)
--- trunk/Source/WebCore/ChangeLog 2011-07-22 03:27:30 UTC (rev 91549)
+++ trunk/Source/WebCore/ChangeLog 2011-07-22 03:31:27 UTC (rev 91550)
@@ -1,3 +1,19 @@
+2011-07-21 Kent Tamura
+
+REGRESSION(r90971): Placeholder
[webkit-changes] [91549] trunk
Title: [91549] trunk
Revision 91549
Author commit-qu...@webkit.org
Date 2011-07-21 20:27:30 -0700 (Thu, 21 Jul 2011)
Log Message
The input[type="number"] with step="any" should not suffer from step mismatch.
https://bugs.webkit.org/show_bug.cgi?id=64858
Patch by Shinya Kawanaka on 2011-07-21
Reviewed by Kent Tamura.
Source/WebCore:
Added check step="any" not to suffer from step mismatch.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::applyStep): Added check step="any".
(WebCore::HTMLInputElement::alignValueForStep): Added.
LayoutTests:
Added test cases of input[type="number"] with step="any"
* fast/forms/input-stepup-stepdown-expected.txt: added the test cases.
* fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
* fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: ditto.
* fast/forms/script-tests/input-stepup-stepdown.js: ditto.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/input-stepup-stepdown-expected.txt
trunk/LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt
trunk/LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js
trunk/LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
Diff
Modified: trunk/LayoutTests/ChangeLog (91548 => 91549)
--- trunk/LayoutTests/ChangeLog 2011-07-22 03:12:43 UTC (rev 91548)
+++ trunk/LayoutTests/ChangeLog 2011-07-22 03:27:30 UTC (rev 91549)
@@ -1,3 +1,17 @@
+2011-07-21 Shinya Kawanaka
+
+The input[type="number"] with step="any" should not suffer from step mismatch.
+https://bugs.webkit.org/show_bug.cgi?id=64858
+
+Reviewed by Kent Tamura.
+
+Added test cases of input[type="number"] with step="any"
+
+* fast/forms/input-stepup-stepdown-expected.txt: added the test cases.
+* fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
+* fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: ditto.
+* fast/forms/script-tests/input-stepup-stepdown.js: ditto.
+
2011-07-21 Robin Qiu
https://bugs.webkit.org/show_bug.cgi?id=60737
Modified: trunk/LayoutTests/fast/forms/input-stepup-stepdown-expected.txt (91548 => 91549)
--- trunk/LayoutTests/fast/forms/input-stepup-stepdown-expected.txt 2011-07-22 03:12:43 UTC (rev 91548)
+++ trunk/LayoutTests/fast/forms/input-stepup-stepdown-expected.txt 2011-07-22 03:27:30 UTC (rev 91549)
@@ -139,6 +139,9 @@
Step=any
PASS stepUp("0", "any", null) threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
PASS stepDown("0", "any", null) threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
+Step=any corner case
+PASS stepUpExplicitBounds("0", "100", "any", "1.5", "1") threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
+PASS stepDownExplicitBounds("0", "100", "any", "1.5", "1") threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
Overflow/underflow
PASS stepDown("1", "1", "0") is "0"
PASS stepDown("0", "1", "0") threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
Modified: trunk/LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt (91548 => 91549)
--- trunk/LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt 2011-07-22 03:12:43 UTC (rev 91548)
+++ trunk/LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt 2011-07-22 03:27:30 UTC (rev 91549)
@@ -116,6 +116,9 @@
Step=any
PASS stepUp("0", "any", null) is "1"
PASS stepDown("0", "any", null) is "-1"
+Step=any corner case
+PASS stepUpExplicitBounds("0", "100", "any", "1.5", "1") is "2.5"
+PASS stepDownExplicitBounds("0", "100", "any", "1.5", "1") is "0.5"
Overflow/underflow
PASS stepDown("1", "1", "0") is "0"
PASS stepDown("0", "1", "0") is "0"
Modified: trunk/LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js (91548 => 91549)
--- trunk/LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js 2011-07-22 03:12:43 UTC (rev 91548)
+++ trunk/LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js 2011-07-22 03:27:30 UTC (rev 91549)
@@ -199,6 +199,9 @@
debug('Step=any');
shouldBe('stepUp("0", "any", null)', '"1"');
shouldBe('stepDown("0", "any", null)', '"-1"');
+debug('Step=any corner case');
+shouldBe('stepUpExplicitBounds("0", "100", "any", "1.5", "1")', '"2.5"');
+shouldBe('stepDownExplicitBounds("0", "100", "any", "1.5", "1")', '"0.5"');
debug('Overflow/underflow');
shouldBe('stepDown("1", "1", "0")', '"0"');
shouldBe('stepDown("0", "1", "0")', '"0"');
Modified: trunk/LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js (91548 => 91549)
--- trunk/LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js 2011-07-22 03:12:43 UTC (rev 91548)
+++ trunk/LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js 2011-07-22 03:27:30 UTC (rev 91549)
@@ -194,6 +194,9
[webkit-changes] [91548] trunk/Source/WebCore
Title: [91548] trunk/Source/WebCore Revision 91548 Author morr...@google.com Date 2011-07-21 20:12:43 -0700 (Thu, 21 Jul 2011) Log Message [Refactoring] ShadowContentSelector should be ShadowInclusionSelector https://bugs.webkit.org/show_bug.cgi?id=64850 Reviewed by Dimitri Glazkov. Renamed: - ShadowContentSelector -> ShadowInclusionSelector - ShadowContentSelector::findInclusionFor -> ShadowInclusionSelector::findFor - ShadowContentSelector::selectInclusion -> ShadowInclusionSelector::select - ShadowContentSelector::unselectInclusion -> ShadowInclusionSelector::unselect - ShadowContentSelector::didSelectInclusion -> ShadowInclusionSelector::didSelect - ShadowContentSelector::willSelectInclusionOver -> ShadowInclusionSelector::willSelectOver - ShadowContentSelector::hasChildren -> ShadowInclusionSelector::hasCandidates No new tests. Just a textual change. * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * dom/DOMAllInOne.cpp: * dom/NodeRenderingContext.cpp: * dom/ShadowContentElement.cpp: (WebCore::ShadowContentElement::attach): (WebCore::ShadowContentElement::detach): * dom/ShadowInclusionSelector.cpp: Renamed from Source/WebCore/dom/ShadowContentSelector.cpp. (WebCore::ShadowInclusion::append): (WebCore::ShadowInclusion::unlink): (WebCore::ShadowInclusionList::ShadowInclusionList): (WebCore::ShadowInclusionList::~ShadowInclusionList): (WebCore::ShadowInclusionList::find): (WebCore::ShadowInclusionList::clear): (WebCore::ShadowInclusionList::append): (WebCore::ShadowInclusionSelector::ShadowInclusionSelector): (WebCore::ShadowInclusionSelector::~ShadowInclusionSelector): (WebCore::ShadowInclusionSelector::select): (WebCore::ShadowInclusionSelector::unselect): (WebCore::ShadowInclusionSelector::findFor): (WebCore::ShadowInclusionSelector::didSelect): (WebCore::ShadowInclusionSelector::willSelectOver): * dom/ShadowInclusionSelector.h: Renamed from Source/WebCore/dom/ShadowContentSelector.h. (WebCore::ShadowInclusion::includer): (WebCore::ShadowInclusion::content): (WebCore::ShadowInclusion::next): (WebCore::ShadowInclusion::previous): (WebCore::ShadowInclusion::ShadowInclusion): (WebCore::ShadowInclusion::create): (WebCore::ShadowInclusionList::first): (WebCore::ShadowInclusionList::last): (WebCore::ShadowInclusionList::isEmpty): (WebCore::ShadowInclusionSet::add): (WebCore::ShadowInclusionSet::remove): (WebCore::ShadowInclusionSet::isEmpty): (WebCore::ShadowInclusionSet::Translator::hash): (WebCore::ShadowInclusionSet::Translator::equal): (WebCore::ShadowInclusionSet::Hash::hash): (WebCore::ShadowInclusionSet::Hash::equal): (WebCore::ShadowInclusionSet::find): (WebCore::ShadowInclusionSelector::hasCandidates): * dom/ShadowRoot.cpp: (WebCore::ShadowRoot::includerFor): (WebCore::ShadowRoot::attach): (WebCore::ShadowRoot::inclusions): (WebCore::ShadowRoot::ensureInclusions): * dom/ShadowRoot.h: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.pro trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/DOMAllInOne.cpp trunk/Source/WebCore/dom/NodeRenderingContext.cpp trunk/Source/WebCore/dom/ShadowContentElement.cpp trunk/Source/WebCore/dom/ShadowRoot.cpp trunk/Source/WebCore/dom/ShadowRoot.h Added Paths trunk/Source/WebCore/dom/ShadowInclusionSelector.cpp trunk/Source/WebCore/dom/ShadowInclusionSelector.h Removed Paths trunk/Source/WebCore/dom/ShadowContentSelector.cpp trunk/Source/WebCore/dom/ShadowContentSelector.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (91547 => 91548) --- trunk/Source/WebCore/CMakeLists.txt 2011-07-22 03:00:52 UTC (rev 91547) +++ trunk/Source/WebCore/CMakeLists.txt 2011-07-22 03:12:43 UTC (rev 91548) @@ -576,7 +576,7 @@ dom/SelectElement.cpp dom/SelectorNodeList.cpp dom/ShadowContentElement.cpp -dom/ShadowContentSelector.cpp +dom/ShadowInclusionSelector.cpp dom/ShadowRoot.cpp dom/SpaceSplitString.cpp dom/StaticHashSetNodeList.cpp Modified: trunk/Source/WebCore/ChangeLog (91547 => 91548) --- trunk/Source/WebCore/ChangeLog 2011-07-22 03:00:52 UTC (rev 91547) +++ trunk/Source/WebCore/ChangeLog 2011-07-22 03:12:43 UTC (rev 91548) @@ -1,3 +1,73 @@ +2011-07-21 MORITA Hajime + +[Refactoring] ShadowContentSelector should be ShadowInclusionSelector +https://bugs.webkit.org/show_bug.cgi?id=64850 + +Reviewed by Dimitri Glazkov. + +Renamed: +- ShadowContentSelector -> ShadowInclusionSelector +- ShadowContentSelector::findInclusionFor -> ShadowInclusionSelector::findFor +- ShadowContentSelector::selectInclusion -> ShadowInclusionSelector::select +- ShadowContentSelector::unselectInclusion -> ShadowInclusionSelector::unselect +- ShadowContentSelector
[webkit-changes] [91547] trunk
Title: [91547] trunk
Revision 91547
Author commit-qu...@webkit.org
Date 2011-07-21 20:00:52 -0700 (Thu, 21 Jul 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=60737
ThumbPosition() in ScrollbarTheme should be ceiled before returned.
Otherwise, some topest/leftest content can not be shown by dragging
scrollbar thumb.
Source/WebCore:
Patch by Robin Qiu on 2011-07-21
Reviewed by Antonio Gomes.
Test: scrollbars/scrollbar-drag-thumb-with-large-content.html
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::thumbPosition):
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::thumbPosition):
LayoutTests:
Patch by Robin Qiu on 2011-07-21
Reviewed by Antonio Gomes.
* scrollbars/scrollbar-drag-thumb-with-large-content-expected.txt: Added.
* scrollbars/scrollbar-drag-thumb-with-large-content.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp
trunk/Source/WebCore/platform/qt/ScrollbarThemeQt.cpp
Added Paths
trunk/LayoutTests/scrollbars/scrollbar-drag-thumb-with-large-content-expected.txt
trunk/LayoutTests/scrollbars/scrollbar-drag-thumb-with-large-content.html
Diff
Modified: trunk/LayoutTests/ChangeLog (91546 => 91547)
--- trunk/LayoutTests/ChangeLog 2011-07-22 02:46:49 UTC (rev 91546)
+++ trunk/LayoutTests/ChangeLog 2011-07-22 03:00:52 UTC (rev 91547)
@@ -1,3 +1,16 @@
+2011-07-21 Robin Qiu
+
+https://bugs.webkit.org/show_bug.cgi?id=60737
+
+ThumbPosition() in ScrollbarTheme should be ceiled before returned.
+Otherwise, some topest/leftest content can not be shown by dragging
+scrollbar thumb.
+
+Reviewed by Antonio Gomes.
+
+* scrollbars/scrollbar-drag-thumb-with-large-content-expected.txt: Added.
+* scrollbars/scrollbar-drag-thumb-with-large-content.html: Added.
+
2011-07-21 Ryosuke Niwa
Chromium test expectation update after r91533.
Added: trunk/LayoutTests/scrollbars/scrollbar-drag-thumb-with-large-content-expected.txt (0 => 91547)
--- trunk/LayoutTests/scrollbars/scrollbar-drag-thumb-with-large-content-expected.txt (rev 0)
+++ trunk/LayoutTests/scrollbars/scrollbar-drag-thumb-with-large-content-expected.txt 2011-07-22 03:00:52 UTC (rev 91547)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/scrollbars/scrollbar-drag-thumb-with-large-content.html (0 => 91547)
--- trunk/LayoutTests/scrollbars/scrollbar-drag-thumb-with-large-content.html (rev 0)
+++ trunk/LayoutTests/scrollbars/scrollbar-drag-thumb-with-large-content.html 2011-07-22 03:00:52 UTC (rev 91547)
@@ -0,0 +1,53 @@
+
+
+
+Bug 60737 test case
+
+/* Use customized scrollbar to avoid platform differences. */
+
+
+
+
+
+
+
+
+Test did not run.
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+var container = document.getElementById("container");
+container.scrollLeft = 2;
+// Drag scrollbar thumber to left most:
+if (window.eventSender) {
+eventSender.mouseMoveTo(30, 145);
+eventSender.mouseDown();
+eventSender.mouseMoveTo(0, 145);
+eventSender.mouseUp();
+}
+if (window.layoutTestController)
+document.getElementById("result").innerText = container.scrollLeft == 0 ? "PASS" : "FAIL";
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (91546 => 91547)
--- trunk/Source/WebCore/ChangeLog 2011-07-22 02:46:49 UTC (rev 91546)
+++ trunk/Source/WebCore/ChangeLog 2011-07-22 03:00:52 UTC (rev 91547)
@@ -1,3 +1,21 @@
+2011-07-21 Robin Qiu
+
+https://bugs.webkit.org/show_bug.cgi?id=60737
+
+ThumbPosition() in ScrollbarTheme should be ceiled before returned.
+Otherwise, some topest/leftest content can not be shown by dragging
+scrollbar thumb.
+
+
+Reviewed by Antonio Gomes.
+
+Test: scrollbars/scrollbar-drag-thumb-with-large-content.html
+
+* platform/ScrollbarThemeComposite.cpp:
+(WebCore::ScrollbarThemeComposite::thumbPosition):
+* platform/qt/ScrollbarThemeQt.cpp:
+(WebCore::ScrollbarThemeQt::thumbPosition):
+
2011-07-21 Si
[webkit-changes] [91546] trunk/Tools
Title: [91546] trunk/Tools
Revision 91546
Author aro...@apple.com
Date 2011-07-21 19:46:49 -0700 (Thu, 21 Jul 2011)
Log Message
Fix typo in TestFailures
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js (91545 => 91546)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-07-22 01:34:48 UTC (rev 91545)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-07-22 02:46:49 UTC (rev 91546)
@@ -204,7 +204,7 @@
// FIXME: Maybe some of this code should go in LayoutTestHistoryAnalyzer, or some other class?
var self = this;
-trac.getCommitDataForRevisionRange('trunk', firstSuspectRevision, lastSuspectRevision, function(commits) {
+trac.commitDataForRevisionRange('trunk', firstSuspectRevision, lastSuspectRevision, function(commits) {
var failingTestNamesWithoutExtensions = failingTestNames.map(removePathExtension);
var suspectCommits = commits.filter(function(commit) {
return failingTestNamesWithoutExtensions.some(function(testName) {
Modified: trunk/Tools/ChangeLog (91545 => 91546)
--- trunk/Tools/ChangeLog 2011-07-22 01:34:48 UTC (rev 91545)
+++ trunk/Tools/ChangeLog 2011-07-22 02:46:49 UTC (rev 91546)
@@ -1,3 +1,9 @@
+2011-07-21 Adam Roben
+
+Fix typo in TestFailures
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+
2011-07-21 Ojan Vafai
simplify gtest display now that we strip modifiers from the JSON
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91545] trunk/LayoutTests
Title: [91545] trunk/LayoutTests Revision 91545 Author rn...@webkit.org Date 2011-07-21 18:34:48 -0700 (Thu, 21 Jul 2011) Log Message Chromium test expectation update after r91533. fast/css/absolute-child-with-percent-height-inside-relative-parent.html is missing a pixel result. A patch to add the pixel result has been uploaded to the bug 64046. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (91544 => 91545) --- trunk/LayoutTests/ChangeLog 2011-07-22 01:12:49 UTC (rev 91544) +++ trunk/LayoutTests/ChangeLog 2011-07-22 01:34:48 UTC (rev 91545) @@ -1,3 +1,11 @@ +2011-07-21 Ryosuke Niwa + +Chromium test expectation update after r91533. +fast/css/absolute-child-with-percent-height-inside-relative-parent.html is missing a pixel result. +A patch to add the pixel result has been uploaded to the bug 64046. + +* platform/chromium/test_expectations.txt: + 2011-07-21 Kulanthaivel Palanichamy Test to cover absolutely positioned child with percentage height Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (91544 => 91545) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-22 01:12:49 UTC (rev 91544) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-22 01:34:48 UTC (rev 91545) @@ -3842,3 +3842,5 @@ BUGRNIWA WIN : fast/multicol/vertical-lr/float-multicol.html = IMAGE+TEXT BUGRNIWA WIN : fast/multicol/vertical-rl/float-multicol.html = IMAGE+TEXT BUGRNIWA WIN : http/tests/inspector/resource-tree/resource-tree-non-unique-url.html = TEXT + +BUGRNIWA : fast/css/absolute-child-with-percent-height-inside-relative-parent.html = MISSING ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91544] branches/safari-534.51-branch/Source
Title: [91544] branches/safari-534.51-branch/Source Revision 91544 Author lforsch...@apple.com Date 2011-07-21 18:12:49 -0700 (Thu, 21 Jul 2011) Log Message Versioning. Modified Paths branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig (91543 => 91544) --- branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-07-22 01:11:28 UTC (rev 91543) +++ branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-07-22 01:12:49 UTC (rev 91544) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (91543 => 91544) --- branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-07-22 01:11:28 UTC (rev 91543) +++ branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-07-22 01:12:49 UTC (rev 91544) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig (91543 => 91544) --- branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig 2011-07-22 01:11:28 UTC (rev 91543) +++ branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig 2011-07-22 01:12:49 UTC (rev 91544) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig (91543 => 91544) --- branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-07-22 01:11:28 UTC (rev 91543) +++ branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-07-22 01:12:49 UTC (rev 91544) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig (91543 => 91544) --- branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-07-22 01:11:28 UTC (rev 91543) +++ branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-07-22 01:12:49 UTC (rev 91544) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91543] tags/Safari-534.51.2/
Title: [91543] tags/Safari-534.51.2/ Revision 91543 Author lforsch...@apple.com Date 2011-07-21 18:11:28 -0700 (Thu, 21 Jul 2011) Log Message New tag. Added Paths tags/Safari-534.51.2/ Diff Property changes: tags/Safari-534.51.2 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91542] trunk/Source/WebCore
Title: [91542] trunk/Source/WebCore
Revision 91542
Author simon.fra...@apple.com
Date 2011-07-21 18:02:35 -0700 (Thu, 21 Jul 2011)
Log Message
GraphicsLayers in subframes can get sync'd multiple times
https://bugs.webkit.org/show_bug.cgi?id=52489
Reviewed by James Robinson.
Avoid doing a 'syncCompositingState' pass on the GraphicsLayers
for subframes, when those GraphicsLayers are rooted in the
parent document.
* page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame): Add a parameter
that contains the rootmost frame on which sync was called. This is used
to indicate to the compositor whether it's the root of the sync.
(WebCore::FrameView::syncCompositingStateIncludingSubframes): Pass the current
Frame in.
(WebCore::FrameView::paintContents): The sync is for this frame, so pass m_frame.
* page/FrameView.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges): New parameter
to specify whether this compositor is in the rootmost Frame being flushed.
We can avoid doing work if we know that flushing some ancestor frame would
have also traversed our GraphicsLayers.
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::isFlushingLayers): Make this private, since
callers are probably most intersted in enclosingCompositorFlushingLayers().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (91541 => 91542)
--- trunk/Source/WebCore/ChangeLog 2011-07-22 00:48:07 UTC (rev 91541)
+++ trunk/Source/WebCore/ChangeLog 2011-07-22 01:02:35 UTC (rev 91542)
@@ -1,3 +1,31 @@
+2011-07-21 Simon Fraser
+
+GraphicsLayers in subframes can get sync'd multiple times
+https://bugs.webkit.org/show_bug.cgi?id=52489
+
+Reviewed by James Robinson.
+
+Avoid doing a 'syncCompositingState' pass on the GraphicsLayers
+for subframes, when those GraphicsLayers are rooted in the
+parent document.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::syncCompositingStateForThisFrame): Add a parameter
+that contains the rootmost frame on which sync was called. This is used
+to indicate to the compositor whether it's the root of the sync.
+(WebCore::FrameView::syncCompositingStateIncludingSubframes): Pass the current
+Frame in.
+(WebCore::FrameView::paintContents): The sync is for this frame, so pass m_frame.
+* page/FrameView.h:
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::flushPendingLayerChanges): New parameter
+to specify whether this compositor is in the rootmost Frame being flushed.
+We can avoid doing work if we know that flushing some ancestor frame would
+have also traversed our GraphicsLayers.
+* rendering/RenderLayerCompositor.h:
+(WebCore::RenderLayerCompositor::isFlushingLayers): Make this private, since
+callers are probably most intersted in enclosingCompositorFlushingLayers().
+
2011-07-21 Rafael Brandao
Local files cannot load icons.
Modified: trunk/Source/WebCore/page/FrameView.cpp (91541 => 91542)
--- trunk/Source/WebCore/page/FrameView.cpp 2011-07-22 00:48:07 UTC (rev 91541)
+++ trunk/Source/WebCore/page/FrameView.cpp 2011-07-22 01:02:35 UTC (rev 91542)
@@ -684,7 +684,7 @@
return view->compositor()->layerForScrollCorner();
}
-bool FrameView::syncCompositingStateForThisFrame()
+bool FrameView::syncCompositingStateForThisFrame(Frame* rootFrameForSync)
{
ASSERT(m_frame->view() == this);
RenderView* view = m_frame->contentRenderer();
@@ -696,7 +696,7 @@
if (needsLayout())
return false;
-view->compositor()->flushPendingLayerChanges();
+view->compositor()->flushPendingLayerChanges(rootFrameForSync == m_frame);
#if ENABLE(FULLSCREEN_API)
// The fullScreenRenderer's graphicsLayer has been re-parented, and the above recursive syncCompositingState
@@ -789,10 +789,10 @@
bool FrameView::syncCompositingStateIncludingSubframes()
{
#if USE(ACCELERATED_COMPOSITING)
-bool allFramesSynced = syncCompositingStateForThisFrame();
+bool allFramesSynced = syncCompositingStateForThisFrame(m_frame.get());
for (Frame* child = m_frame->tree()->firstChild(); child; child = child->tree()->traverseNext(m_frame.get())) {
-bool synced = child->view()->syncCompositingStateForThisFrame();
+bool synced = child->view()->syncCompositingStateForThisFrame(m_frame.get());
allFramesSynced &= synced;
}
return allFramesSynced;
@@ -2523,7 +2523,7 @@
#if USE(ACCELERATED_COMPOSITING)
if (!p->paintingDisabled())
-syncCompositingStateForThisFrame();
+syncCompositingStateForThisFrame(m_frame.get());
[webkit-changes] [91541] trunk/Tools
Title: [91541] trunk/Tools
Revision 91541
Author o...@chromium.org
Date 2011-07-21 17:48:07 -0700 (Thu, 21 Jul 2011)
Log Message
simplify gtest display now that we strip modifiers from the JSON
https://bugs.webkit.org/show_bug.cgi?id=64990
Reviewed by Adam Barth.
Now that names are normalized, we can remove all the code that
handles gtest name changes (e.g. for adding modifiers like DISABLED_).
Instead, if you try to list a test with a modifier in it, we need
to strip the modifier so we get the normalized value.
We also get rid of the concept of extra/missing expectations for gtests.
In a patch soon, we'll stop showing extra/missing expectations from the UI
entirely and only leave it for the special updating test_expectations.txt
view of the dashboard, which doesn't apply to gtests.
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js
Diff
Modified: trunk/Tools/ChangeLog (91540 => 91541)
--- trunk/Tools/ChangeLog 2011-07-22 00:40:30 UTC (rev 91540)
+++ trunk/Tools/ChangeLog 2011-07-22 00:48:07 UTC (rev 91541)
@@ -1,3 +1,23 @@
+2011-07-21 Ojan Vafai
+
+simplify gtest display now that we strip modifiers from the JSON
+https://bugs.webkit.org/show_bug.cgi?id=64990
+
+Reviewed by Adam Barth.
+
+Now that names are normalized, we can remove all the code that
+handles gtest name changes (e.g. for adding modifiers like DISABLED_).
+Instead, if you try to list a test with a modifier in it, we need
+to strip the modifier so we get the normalized value.
+
+We also get rid of the concept of extra/missing expectations for gtests.
+In a patch soon, we'll stop showing extra/missing expectations from the UI
+entirely and only leave it for the special updating test_expectations.txt
+view of the dashboard, which doesn't apply to gtests.
+
+* TestResultServer/static-dashboards/flakiness_dashboard.html:
+* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
+
2011-07-21 Adam Barth
Refactor Trac.js for use in garden-o-matic
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html (91540 => 91541)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-22 00:40:30 UTC (rev 91540)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-22 00:48:07 UTC (rev 91541)
@@ -314,8 +314,7 @@
var ALL = 'ALL';
var FORWARD = 'forward';
var BACKWARD = 'backward';
-var GTEST_FLAKY_MARKER = '\.FLAKY_';
-var GTEST_FAILS_MARKER = '\.FAILS_';
+var GTEST_MODIFIERS = ['FLAKY', 'FAILS', 'MAYBE', 'DISABLED'];
var TEST_URL_BASE_PATH_TRAC = 'http://trac.webkit.org/browser/trunk/LayoutTests/';
var TEST_URL_BASE_PATH = "http://svn.webkit.org/repository/webkit/trunk/LayoutTests/";
var TEST_RESULTS_BASE_PATH = 'http://build.chromium.org/f/chromium/layout_test_results/';
@@ -611,29 +610,30 @@
return individualTestsForSubstringList();
}
-function individualTestsForSubstringList()
+function substringList()
{
// Convert windows slashes to unix slashes.
var tests = g_currentState.tests.replace(/\\/g, '/');
var separator = stringContains(tests, ' ') ? ' ' : ',';
var testList = tests.split(separator);
-if (!isLayoutTestResults()) {
-testList.forEach(function(element) {
-// Make sure to search for the flaky/fails and non-flaky/non-fails
-// names for a test.
-// e.g. for test Foo.Bar, also search for Foo.FLAKY_Bar.
-if (stringContains(element, GTEST_FLAKY_MARKER))
-testList.push(element.replace(GTEST_FLAKY_MARKER, '.'));
-else if (stringContains(element, GTEST_FAILS_MARKER))
-testList.push(element.replace(GTEST_FAILS_MARKER, '.'));
-else {
-testList.push(element.replace('.', GTEST_FLAKY_MARKER));
-testList.push(element.replace('.', GTEST_FAILS_MARKER));
-}
+if (isLayoutTestResults())
+return testList;
+
+var testListWithoutModifiers = [];
+testList.forEach(function(path) {
+GTEST_MODIFIERS.forEach(function(modifier) {
+path = path.replace('.' + modifier + '_', '.');
});
-}
+testListWithoutModifiers.push(path);
+});
+return testListWithoutModifiers;
+}
+function individualTestsForSubstringList()
+{
+var testList = substringList();
+
// Put the tests into an object first and then move them into an array
// as a way of deduping.
var testsMap = {};
@@ -1161,12 +1161,6 @@
extraExpectations.push('PASS');
}
-} else {
-var isMarkedFlaky = stringContains(resu
[webkit-changes] [91540] trunk/Source/WebCore
Title: [91540] trunk/Source/WebCore Revision 91540 Author commit-qu...@webkit.org Date 2011-07-21 17:40:30 -0700 (Thu, 21 Jul 2011) Log Message Local files cannot load icons. https://bugs.webkit.org/show_bug.cgi?id=62459 Previous policy only allowed favicons for pages whose protocol was part of HTTP family. Changed that to allow to any url that's not empty and whose protocol is not "about". Also added this check where it attempts to start loading the favicon, so it can avoid wasting time downloading a resource that won't be stored and won't be used. Patch by Rafael Brandao on 2011-07-21 Reviewed by Adam Barth. Test: manual-tests/resources/favicon-loads-for-local-files.html * loader/icon/IconController.cpp: (WebCore::IconController::startLoader): Added check to avoid to request a favicon when there's no way to store it. * loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::documentCanHaveIcon): Renamed function "pageCanHaveIcon" to reflect better which url we're handling. (WebCore::IconDatabase::synchronousIconForPageURL): Ditto. (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto. (WebCore::IconDatabase::retainIconForPageURL): Ditto. (WebCore::IconDatabase::releaseIconForPageURL): Ditto. (WebCore::IconDatabase::setIconURLForPageURL): Ditto. (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto. (WebCore::IconDatabase::importIconURLForPageURL): Ditto. (WebCore::IconDatabase::performURLImport): Ditto. * loader/icon/IconDatabase.h: * loader/icon/IconDatabaseBase.h: (WebCore::IconDatabaseBase::documentCanHaveIcon): Added it as virtual to replace its default behavior of not allowing favicons when we have IconDatabase enabled. * manual-tests/resources/favicon-loads-for-local-files.html: Added. * manual-tests/resources/favicon.png: Added. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/icon/IconController.cpp trunk/Source/WebCore/loader/icon/IconDatabase.cpp trunk/Source/WebCore/loader/icon/IconDatabase.h trunk/Source/WebCore/loader/icon/IconDatabaseBase.h Added Paths trunk/Source/WebCore/manual-tests/resources/favicon-loads-for-local-files.html trunk/Source/WebCore/manual-tests/resources/favicon.png Diff Modified: trunk/Source/WebCore/ChangeLog (91539 => 91540) --- trunk/Source/WebCore/ChangeLog 2011-07-22 00:36:26 UTC (rev 91539) +++ trunk/Source/WebCore/ChangeLog 2011-07-22 00:40:30 UTC (rev 91540) @@ -1,3 +1,41 @@ +2011-07-21 Rafael Brandao + +Local files cannot load icons. +https://bugs.webkit.org/show_bug.cgi?id=62459 + +Previous policy only allowed favicons for pages whose protocol was part of HTTP family. +Changed that to allow to any url that's not empty and whose protocol is not "about". +Also added this check where it attempts to start loading the favicon, so it can avoid +wasting time downloading a resource that won't be stored and won't be used. + +Reviewed by Adam Barth. + +Test: manual-tests/resources/favicon-loads-for-local-files.html + +* loader/icon/IconController.cpp: +(WebCore::IconController::startLoader): Added check to avoid to request a favicon +when there's no way to store it. + +* loader/icon/IconDatabase.cpp: +(WebCore::IconDatabase::documentCanHaveIcon): Renamed function "pageCanHaveIcon" +to reflect better which url we're handling. + +(WebCore::IconDatabase::synchronousIconForPageURL): Ditto. +(WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto. +(WebCore::IconDatabase::retainIconForPageURL): Ditto. +(WebCore::IconDatabase::releaseIconForPageURL): Ditto. +(WebCore::IconDatabase::setIconURLForPageURL): Ditto. +(WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto. +(WebCore::IconDatabase::importIconURLForPageURL): Ditto. +(WebCore::IconDatabase::performURLImport): Ditto. +* loader/icon/IconDatabase.h: +* loader/icon/IconDatabaseBase.h: +(WebCore::IconDatabaseBase::documentCanHaveIcon): Added it as virtual to replace its +default behavior of not allowing favicons when we have IconDatabase enabled. + +* manual-tests/resources/favicon-loads-for-local-files.html: Added. +* manual-tests/resources/favicon.png: Added. + 2011-07-21 Kulanthaivel Palanichamy Fix for bug 64046 - Wrong image height in absolutely positioned div in Modified: trunk/Source/WebCore/loader/icon/IconController.cpp (91539 => 91540) --- trunk/Source/WebCore/loader/icon/IconController.cpp 2011-07-22 00:36:26 UTC (rev 91539) +++ trunk/Source/WebCore/loader/icon/IconController.cpp 2011-07-22 00:40:30 UTC (rev 91540) @@ -113,6 +113,10 @@ if (!iconDatabase().isEnabled()) return; +ASSERT(!m_frame->tree()->parent()); +if (!iconDatabase().documentCanHaveIcon(m_frame->document()->url())) +return; + KURL iconURL(url()); String urlString(ico
[webkit-changes] [91539] branches/safari-534.51-branch/Source/WebKit2
Title: [91539] branches/safari-534.51-branch/Source/WebKit2
Revision 91539
Author lforsch...@apple.com
Date 2011-07-21 17:36:26 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r90198.
Modified Paths
branches/safari-534.51-branch/Source/WebKit2/ChangeLog
branches/safari-534.51-branch/Source/WebKit2/Platform/cg/CGUtilities.cpp
branches/safari-534.51-branch/Source/WebKit2/Platform/cg/CGUtilities.h
branches/safari-534.51-branch/Source/WebKit2/Shared/ShareableBitmap.h
branches/safari-534.51-branch/Source/WebKit2/Shared/UpdateInfo.cpp
branches/safari-534.51-branch/Source/WebKit2/Shared/UpdateInfo.h
branches/safari-534.51-branch/Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp
branches/safari-534.51-branch/Source/WebKit2/UIProcess/BackingStore.cpp
branches/safari-534.51-branch/Source/WebKit2/UIProcess/BackingStore.h
branches/safari-534.51-branch/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
branches/safari-534.51-branch/Source/WebKit2/UIProcess/mac/BackingStoreMac.mm
branches/safari-534.51-branch/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
Diff
Modified: branches/safari-534.51-branch/Source/WebKit2/ChangeLog (91538 => 91539)
--- branches/safari-534.51-branch/Source/WebKit2/ChangeLog 2011-07-22 00:29:31 UTC (rev 91538)
+++ branches/safari-534.51-branch/Source/WebKit2/ChangeLog 2011-07-22 00:36:26 UTC (rev 91539)
@@ -1,5 +1,62 @@
2011-07-21 Lucas Forschler
+Merged 90198.
+
+2011-06-30 Darin Adler
+
+Reviewed by Anders Carlsson.
+
+[WebKit2] Consider scale factor when allocating backing store
+https://bugs.webkit.org/show_bug.cgi?id=63766
+
+This is the first step in considering scale factor. It considers
+scale factor for the primary backing store, not graphics layers,
+and for CG only.
+
+* Platform/cg/CGUtilities.cpp:
+(WebKit::paintImage): Added a scale factor argument.
+(WebKit::paintBitmapContext): Pass 1 for scale factor.
+* Platform/cg/CGUtilities.h: Updated for above.
+
+* Shared/ShareableBitmap.h: Added an overload of paint that can handle
+a scale factor.
+
+* Shared/UpdateInfo.cpp:
+(WebKit::UpdateInfo::encode): Encode scale factor.
+(WebKit::UpdateInfo::decode): Decode scale factor.
+* Shared/UpdateInfo.h: Added scale factor.
+
+* Shared/cg/ShareableBitmapCG.cpp:
+(WebKit::ShareableBitmap::paint): Added the overload that can handle
+a scale factor.
+
+* UIProcess/BackingStore.cpp:
+(WebKit::BackingStore::create): Take a scale factor.
+(WebKit::BackingStore::BackingStore): Store the scale factor.
+(WebKit::BackingStore::incorporateUpdate): Consider the scale factor
+when asserting the size is correct.
+
+* UIProcess/BackingStore.h: Add a scale factor.
+
+* UIProcess/DrawingAreaProxyImpl.cpp:
+(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): Check the
+scale factor too when deciding whether to reuse a backing store.
+(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Pass in the scale
+factor when creating a backing store.
+
+* UIProcess/mac/BackingStoreMac.mm:
+(WebKit::BackingStore::incorporateUpdate): Take the scale factor into
+account when painting.
+
+* WebProcess/WebPage/DrawingAreaImpl.cpp:
+(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Put the
+scale factor into the UpdateInfo.
+(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Ditto.
+(WebKit::DrawingAreaImpl::display): Take the scale factor into account
+when allocating the bitmap and creating a graphics context for it.
+
+2011-07-21 Lucas Forschler
+
Merged 90087.
2011-07-21 Lucas Forschler
Modified: branches/safari-534.51-branch/Source/WebKit2/Platform/cg/CGUtilities.cpp (91538 => 91539)
--- branches/safari-534.51-branch/Source/WebKit2/Platform/cg/CGUtilities.cpp 2011-07-22 00:29:31 UTC (rev 91538)
+++ branches/safari-534.51-branch/Source/WebKit2/Platform/cg/CGUtilities.cpp 2011-07-22 00:36:26 UTC (rev 91539)
@@ -30,28 +30,28 @@
namespace WebKit {
-void paintImage(CGContextRef context, CGImageRef image, CGPoint destination, CGRect source)
+void paintImage(CGContextRef context, CGImageRef image, CGFloat scaleFactor, CGPoint destination, CGRect source)
{
CGContextSaveGState(context);
CGContextClipToRect(context, CGRectMake(destination.x, destination.y, source.size.width, source.size.height));
CGContextScaleCTM(context, 1, -1);
-size_t imageHeight = CGImageGetHeight(image);
-size_t imageWidth = CGImageGetWidth(image);
+CGFloat imageHeight = CGImageGetHeight(image) / scaleFactor;
+CGFloat imageWidth = CGImageGetWidth(image) / scaleFactor;
CGFloat destX = destination.x - source.origin.x;
-CGFloat destY = -static_cast(imageHeight) - destination.y + source.origin.y;
+CGFloat destY = -imageHeigh
[webkit-changes] [91538] trunk/Tools
Title: [91538] trunk/Tools
Revision 91538
Author aba...@webkit.org
Date 2011-07-21 17:29:31 -0700 (Thu, 21 Jul 2011)
Log Message
Refactor Trac.js for use in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=64998
Reviewed by Adam Roben.
This patch refactors Trac.js to match the architecture and style of
garden-o-matic. I've also factored AsynchronousCache out of Trac (and
moved it to base) because it was redundant with some other code we
already had.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
(FailingTestsBugForm):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder.start):
(ViewController.prototype._displayBuilder):
(ViewController.prototype._domForRegressionRange.trac.getCommitDataForRevisionRange):
(ViewController.prototype._domForRegressionRange):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js (91537 => 91538)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js 2011-07-22 00:23:39 UTC (rev 91537)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js 2011-07-22 00:29:31 UTC (rev 91538)
@@ -23,10 +23,9 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-function FailingTestsBugForm(bugzilla, trac, tester, failingBuildName, passingBuildName, failingTests) {
+function FailingTestsBugForm(bugzilla, tester, failingBuildName, passingBuildName, failingTests) {
TestRelatedBugForm.call(this, bugzilla, tester);
-this._trac = trac;
this._failingBuildName = failingBuildName;
this._passingBuildName = passingBuildName;
this._failingTests = failingTests;
@@ -48,11 +47,11 @@
if (this._passingBuildName) {
endOfFirstSentence = 'started failing on ' + this._tester.name;
if (firstSuspectRevision === lastSuspectRevision)
-endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>';
+endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + trac.changesetURL(firstSuspectRevision) + '>';
else
endOfFirstSentence += ' between r' + firstSuspectRevision + ' and r' + lastSuspectRevision + ' (inclusive)';
} else
-endOfFirstSentence = (this._failingTests.length === 1 ? 'has' : 'have') + ' been failing on ' + this._tester.name + ' since at least r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>';
+endOfFirstSentence = (this._failingTests.length === 1 ? 'has' : 'have') + ' been failing on ' + this._tester.name + ' since at least r' + firstSuspectRevision + ' <' + trac.changesetURL(firstSuspectRevision) + '>';
var description;
if (this._failingTests.length === 1)
description = this._failingTests[0] + ' ' + endOfFirstSentence + '.\n\n';
@@ -64,7 +63,7 @@
+ '\n\n';
}
if (firstSuspectRevision !== lastSuspectRevision)
-description += this._trac.logURL('trunk', firstSuspectRevision, lastSuspectRevision) + '\n\n';
+description += trac.logURL('trunk', firstSuspectRevision, lastSuspectRevision) + '\n\n';
if (this._passingBuildName)
description += this._tester.resultsPageURL(this._passingBuildName) + ' passed\n';
[webkit-changes] [91537] branches/safari-534.51-branch
Title: [91537] branches/safari-534.51-branch
Revision 91537
Author lforsch...@apple.com
Date 2011-07-21 17:23:39 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r90166.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/rendering/svg/RenderSVGInline.cpp
branches/safari-534.51-branch/Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp
branches/safari-534.51-branch/Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp
Added Paths
branches/safari-534.51-branch/LayoutTests/svg/custom/crash-textPath-attributes-expected.txt
branches/safari-534.51-branch/LayoutTests/svg/custom/crash-textPath-attributes.html
branches/safari-534.51-branch/LayoutTests/svg/custom/resources/crash-textPath-attributes-iframe.svg
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91536 => 91537)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-22 00:21:36 UTC (rev 91536)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-22 00:23:39 UTC (rev 91537)
@@ -1,5 +1,20 @@
2011-07-21 Lucas Forschler
+Merged 90166.
+
+2011-06-30 Julien Chaffraix
+
+Reviewed by Nikolas Zimmermann.
+
+Update SVG position values on SVG DOM updates
+https://bugs.webkit.org/show_bug.cgi?id=62439
+
+* svg/custom/crash-textPath-attributes-expected.txt: Added.
+* svg/custom/crash-textPath-attributes.html: Added.
+* svg/custom/resources/crash-textPath-attributes-iframe.svg: Added.
+
+2011-07-21 Lucas Forschler
+
Merged 90156.
2011-06-30 Julien Chaffraix
Copied: branches/safari-534.51-branch/LayoutTests/svg/custom/crash-textPath-attributes-expected.txt (from rev 90166, trunk/LayoutTests/svg/custom/crash-textPath-attributes-expected.txt) (0 => 91537)
--- branches/safari-534.51-branch/LayoutTests/svg/custom/crash-textPath-attributes-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/svg/custom/crash-textPath-attributes-expected.txt 2011-07-22 00:23:39 UTC (rev 91537)
@@ -0,0 +1,4 @@
+
+Test for Update SVG position values on SVG DOM updates
+
+This test PASSES if he does not crash
Copied: branches/safari-534.51-branch/LayoutTests/svg/custom/crash-textPath-attributes.html (from rev 90166, trunk/LayoutTests/svg/custom/crash-textPath-attributes.html) (0 => 91537)
--- branches/safari-534.51-branch/LayoutTests/svg/custom/crash-textPath-attributes.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/svg/custom/crash-textPath-attributes.html 2011-07-22 00:23:39 UTC (rev 91537)
@@ -0,0 +1,13 @@
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function go(oIframe) {
+ var oSelection = oIframe.contentWindow.getSelection();
+ oSelection.selectAllChildren(oIframe.contentDocument);
+ oSelection.deleteFromDocument();
+}
+
+Test for
+This test PASSES if he does not crash
Copied: branches/safari-534.51-branch/LayoutTests/svg/custom/resources/crash-textPath-attributes-iframe.svg (from rev 90166, trunk/LayoutTests/svg/custom/resources/crash-textPath-attributes-iframe.svg) (0 => 91537)
--- branches/safari-534.51-branch/LayoutTests/svg/custom/resources/crash-textPath-attributes-iframe.svg (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/svg/custom/resources/crash-textPath-attributes-iframe.svg 2011-07-22 00:23:39 UTC (rev 91537)
@@ -0,0 +1,3 @@
+
+x
Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (91536 => 91537)
--- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-22 00:21:36 UTC (rev 91536)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-22 00:23:39 UTC (rev 91537)
@@ -1,5 +1,31 @@
2011-07-21 Lucas Forschler
+Merged 90166.
+
+2011-06-30 Julien Chaffraix
+
+Reviewed by Nikolas Zimmermann.
+
+Update SVG position values on SVG DOM updates
+https://bugs.webkit.org/show_bug.cgi?id=62439
+
+Test: svg/custom/crash-textPath-attributes.html
+
+* rendering/svg/RenderSVGInline.cpp:
+(WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs
+to update its positioning information.
+
+* rendering/svg/SVGInlineFlowBox.cpp:
+(WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox
+like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).
+
+* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
+(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear
+our cached layout attributes every time we invalidate them. This avoids keeping stale
+attribute that have a backpointer to a RenderObject.
+
+2011-07-21 Lucas Forschler
+
Merged 90156.
2011-06-30 Julien Chaffraix
Modif
[webkit-changes] [91536] branches/safari-534.51-branch
Title: [91536] branches/safari-534.51-branch
Revision 91536
Author lforsch...@apple.com
Date 2011-07-21 17:21:36 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r90156.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/svg/SVGTextContentElement.cpp
branches/safari-534.51-branch/Source/WebCore/svg/SVGTextContentElement.h
branches/safari-534.51-branch/Source/WebCore/svg/SVGTextPositioningElement.cpp
branches/safari-534.51-branch/Source/WebCore/svg/SVGTextPositioningElement.h
Added Paths
branches/safari-534.51-branch/LayoutTests/svg/custom/crash-text-in-textpath-expected.txt
branches/safari-534.51-branch/LayoutTests/svg/custom/crash-text-in-textpath.svg
branches/safari-534.51-branch/LayoutTests/svg/custom/text-node-in-text-invalidated-expected.txt
branches/safari-534.51-branch/LayoutTests/svg/custom/text-node-in-text-invalidated.svg
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91535 => 91536)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-22 00:18:42 UTC (rev 91535)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-22 00:21:36 UTC (rev 91536)
@@ -1,5 +1,25 @@
2011-07-21 Lucas Forschler
+Merged 90156.
+
+2011-06-30 Julien Chaffraix
+
+Reviewed by Nikolas Zimmermann.
+
+Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
+https://bugs.webkit.org/show_bug.cgi?id=63076
+
+* svg/custom/crash-text-in-textpath-expected.txt: Added.
+* svg/custom/crash-text-in-textpath.svg: Added.
+Original crashing test case.
+
+* svg/custom/text-node-in-text-invalidated-expected.txt: Added.
+* svg/custom/text-node-in-text-invalidated.svg: Added.
+This test case was not crashing. However it is good to make sure this change
+did not regress that.
+
+2011-07-21 Lucas Forschler
+
Merged 90130.
2011-06-29 Abhishek Arya
Copied: branches/safari-534.51-branch/LayoutTests/svg/custom/crash-text-in-textpath-expected.txt (from rev 90156, trunk/LayoutTests/svg/custom/crash-text-in-textpath-expected.txt) (0 => 91536)
--- branches/safari-534.51-branch/LayoutTests/svg/custom/crash-text-in-textpath-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/svg/custom/crash-text-in-textpath-expected.txt 2011-07-22 00:21:36 UTC (rev 91536)
@@ -0,0 +1,3 @@
+foo
+Test for bug 63076: Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
+This test passes if it does not crash
Copied: branches/safari-534.51-branch/LayoutTests/svg/custom/crash-text-in-textpath.svg (from rev 90156, trunk/LayoutTests/svg/custom/crash-text-in-textpath.svg) (0 => 91536)
--- branches/safari-534.51-branch/LayoutTests/svg/custom/crash-text-in-textpath.svg (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/svg/custom/crash-text-in-textpath.svg 2011-07-22 00:21:36 UTC (rev 91536)
@@ -0,0 +1,20 @@
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+// This triggers a layout before adding the #text node.
+document.getElementById('textPath').scrollIntoView('foo');
+
+foo
+
+// This triggers a layout after adding the #text node to fire the ASSERT.
+document.getElementById('textPath').scrollIntoView('foo');
+
+
+
+Test for bug
+This test passes if it does not crash
+
Copied: branches/safari-534.51-branch/LayoutTests/svg/custom/text-node-in-text-invalidated-expected.txt (from rev 90156, trunk/LayoutTests/svg/custom/text-node-in-text-invalidated-expected.txt) (0 => 91536)
--- branches/safari-534.51-branch/LayoutTests/svg/custom/text-node-in-text-invalidated-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/svg/custom/text-node-in-text-invalidated-expected.txt 2011-07-22 00:21:36 UTC (rev 91536)
@@ -0,0 +1,3 @@
+foo bar
+Test for bug 63076: Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
+This test passes if it does not crash
Copied: branches/safari-534.51-branch/LayoutTests/svg/custom/text-node-in-text-invalidated.svg (from rev 90156, trunk/LayoutTests/svg/custom/text-node-in-text-invalidated.svg) (0 => 91536)
--- branches/safari-534.51-branch/LayoutTests/svg/custom/text-node-in-text-invalidated.svg (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/svg/custom/text-node-in-text-invalidated.svg 2011-07-22 00:21:36 UTC (rev 91536)
@@ -0,0 +1,20 @@
+
+
+bar
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+// This triggers a layout before adding the #text node.
+document.getElementById('text').scrollIntoView('foo');
+
+var text = document.getElementById('text');
+tex
[webkit-changes] [91535] branches/safari-534.51-branch
Title: [91535] branches/safari-534.51-branch
Revision 91535
Author lforsch...@apple.com
Date 2011-07-21 17:18:42 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r90130.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extractContents.html
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/dom/Range.cpp
Added Paths
branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt
branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash.html
branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt
branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2.html
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91534 => 91535)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-22 00:15:18 UTC (rev 91534)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-22 00:18:42 UTC (rev 91535)
@@ -1,5 +1,25 @@
2011-07-21 Lucas Forschler
+Merged 90130.
+
+2011-06-29 Abhishek Arya
+
+Reviewed by Ryosuke Niwa.
+
+Crash when calling DOMSubtreeModified event when extracting range
+contents.
+https://bugs.webkit.org/show_bug.cgi?id=63650
+
+* fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt: Added.
+* fast/dom/Range/range-extract-contents-event-fire-crash.html: Added.
+* fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt: Added.
+* fast/dom/Range/range-extract-contents-event-fire-crash2.html: Added.
+* fast/dom/Range/range-extractContents.html: remove the appending of fragment
+in this crasher test since we now refptr the nodes and leftContents will be visible.
+This crasher test does not need to show the extractContents fragment.
+
+2011-07-21 Lucas Forschler
+
Merged 90068.
2011-06-23 Abhishek Arya
Copied: branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt (from rev 90130, trunk/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt) (0 => 91535)
--- branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash-expected.txt 2011-07-22 00:18:42 UTC (rev 91535)
@@ -0,0 +1 @@
+PASS: does not crash
Copied: branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash.html (from rev 90130, trunk/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash.html) (0 => 91535)
--- branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash.html 2011-07-22 00:18:42 UTC (rev 91535)
@@ -0,0 +1,32 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function runTest()
+{
+document.removeEventListener("DOMSubtreeModified", runTest, false);
+document.body.innerHTML = 'PASS: does not crash';
+}
+
+document.addEventListener("DOMSubtreeModified", runTest, false);
+
+var r = document.createRange();
+r.setStartBefore(document.getElementById('start'));
+r.setEndAfter(document.getElementById('end'));
+r.extractContents();
+
+
+
Copied: branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt (from rev 90130, trunk/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt) (0 => 91535)
--- branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2-expected.txt 2011-07-22 00:18:42 UTC (rev 91535)
@@ -0,0 +1 @@
+PASS: does not crash
Copied: branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2.html (from rev 90130, trunk/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2.html) (0 => 91535)
--- branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/dom/Range/range-extract-contents-event-fire-crash2.html 2011-07-22 00:18:42 UTC (rev 91535)
@@ -0,0 +1,30 @@
+
+
+
+
+
+
+
+
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function runTest()
+{
+
[webkit-changes] [91534] branches/safari-534.51-branch/Source
Title: [91534] branches/safari-534.51-branch/Source
Revision 91534
Author lforsch...@apple.com
Date 2011-07-21 17:15:18 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r90087.
Modified Paths
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in
branches/safari-534.51-branch/Source/WebCore/WebCore.gyp/WebCore.gyp
branches/safari-534.51-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/safari-534.51-branch/Source/WebCore/platform/mac/CursorMac.mm
branches/safari-534.51-branch/Source/WebCore/platform/mac/WebCoreSystemInterface.h
branches/safari-534.51-branch/Source/WebCore/platform/mac/WebCoreSystemInterface.mm
branches/safari-534.51-branch/Source/WebKit/mac/ChangeLog
branches/safari-534.51-branch/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm
branches/safari-534.51-branch/Source/WebKit2/ChangeLog
branches/safari-534.51-branch/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm
Removed Paths
branches/safari-534.51-branch/Source/WebCore/Resources/crossHairCursor.png
branches/safari-534.51-branch/Source/WebCore/Resources/notAllowedCursor.png
Diff
Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (91533 => 91534)
--- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-22 00:14:42 UTC (rev 91533)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-22 00:15:18 UTC (rev 91534)
@@ -1,5 +1,30 @@
2011-07-21 Lucas Forschler
+Merged 90087.
+
+2011-06-29 Darin Adler
+
+Reviewed by Dan Bernstein.
+
+[Mac] Use system cursors instead of custom bitmaps where possible
+https://bugs.webkit.org/show_bug.cgi?id=63679
+
+* Resources/crossHairCursor.png: Removed.
+* Resources/notAllowedCursor.png: Removed.
+* WebCore.exp.in: Added wkCursor.
+* WebCore/WebCore.gyp/WebCore.gyp: Removed the two now-unused PNG files.
+* WebCore.xcodeproj/project.pbxproj: Ditto.
+
+* platform/mac/CursorMac.mm:
+(WebCore::Cursor::ensurePlatformCursor): Use NSCursor API for Cross, Hand,
+VerticalText, ContextMenu, Copy, and NotAllowed. Use wkCursor for Move,
+Alias, Progress, and the resize and panning cursors.
+
+* platform/mac/WebCoreSystemInterface.h: Added wkCursor.
+* platform/mac/WebCoreSystemInterface.mm: Ditto.
+
+2011-07-21 Lucas Forschler
+
Merged 90068.
2011-06-23 Abhishek Arya
Deleted: branches/safari-534.51-branch/Source/WebCore/Resources/crossHairCursor.png
(Binary files differ)
Deleted: branches/safari-534.51-branch/Source/WebCore/Resources/notAllowedCursor.png
(Binary files differ)
Modified: branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in (91533 => 91534)
--- branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in 2011-07-22 00:14:42 UTC (rev 91533)
+++ branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in 2011-07-22 00:15:18 UTC (rev 91534)
@@ -1466,6 +1466,7 @@
_wkWillEndLiveResize
_wkWillStartLiveResize
_wkAVAssetResolvedURL
+_wkCursor
#else
_wkGetNSEventMomentumPhase
#endif
Modified: branches/safari-534.51-branch/Source/WebCore/WebCore.gyp/WebCore.gyp (91533 => 91534)
--- branches/safari-534.51-branch/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-07-22 00:14:42 UTC (rev 91533)
+++ branches/safari-534.51-branch/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-07-22 00:15:18 UTC (rev 91534)
@@ -1566,7 +1566,6 @@
'../Resources/cellCursor.png',
'../Resources/contextMenuCursor.png',
'../Resources/copyCursor.png',
- '../Resources/crossHairCursor.png',
'../Resources/eastResizeCursor.png',
'../Resources/eastWestResizeCursor.png',
'../Resources/helpCursor.png',
@@ -1581,7 +1580,6 @@
'../Resources/northSouthResizeCursor.png',
'../Resources/northWestResizeCursor.png',
'../Resources/northWestSouthEastResizeCursor.png',
- '../Resources/notAllowedCursor.png',
'../Resources/progressCursor.png',
'../Resources/southEastResizeCursor.png',
'../Resources/southResizeCursor.png',
Modified: branches/safari-534.51-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj (91533 => 91534)
--- branches/safari-534.51-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-07-22 00:14:42 UTC (rev 91533)
+++ branches/safari-534.51-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-07-22 00:15:18 UTC (rev 91534)
@@ -975,8 +975,6 @@
45099C411370A7800058D513 /* IconURL.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 45099C401370A7800058D513 /* IconURL.cpp */; };
45BAC2B01360BBAB005DA258 /* IconURL.h in Headers */ = {isa = PBXBuildFile; fileRef = 45BAC2AF1360BBAB005DA258 /* IconURL.h */; settings = {ATTRIBUTES = (Private, ); }; };
4614A1FE0B23A8D600446E1C /* copyCursor.png in Resources */ = {isa = PBXBuildFile; fileRef = 4614A1FD0B23A8D600446E1C /* copyCursor.png
[webkit-changes] [91533] trunk
Title: [91533] trunk
Revision 91533
Author commit-qu...@webkit.org
Date 2011-07-21 17:14:42 -0700 (Thu, 21 Jul 2011)
Log Message
Source/WebCore: Fix for bug 64046 - Wrong image height in absolutely positioned div in
relatively positioned parent with bottom padding.
https://bugs.webkit.org/show_bug.cgi?id=64046
Patch by Kulanthaivel Palanichamy on 2011-07-21
Reviewed by David Hyatt.
Test: fast/css/absolute-child-with-percent-height-inside-relative-parent.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::availableLogicalHeightUsing):
LayoutTests: Test to cover absolutely positioned child with percentage height
in relatively positioned parent with bottom padding.
https://bugs.webkit.org/show_bug.cgi?id=64046
Patch by Kulanthaivel Palanichamy on 2011-07-21
Reviewed by David Hyatt.
* fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
* fast/css/absolute-child-with-percent-height-inside-relative-parent.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
Added Paths
trunk/LayoutTests/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt
trunk/LayoutTests/fast/css/absolute-child-with-percent-height-inside-relative-parent.html
Diff
Modified: trunk/LayoutTests/ChangeLog (91532 => 91533)
--- trunk/LayoutTests/ChangeLog 2011-07-22 00:00:47 UTC (rev 91532)
+++ trunk/LayoutTests/ChangeLog 2011-07-22 00:14:42 UTC (rev 91533)
@@ -1,3 +1,14 @@
+2011-07-21 Kulanthaivel Palanichamy
+
+Test to cover absolutely positioned child with percentage height
+in relatively positioned parent with bottom padding.
+https://bugs.webkit.org/show_bug.cgi?id=64046
+
+Reviewed by David Hyatt.
+
+* fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
+* fast/css/absolute-child-with-percent-height-inside-relative-parent.html: Added.
+
2011-07-21 Gavin Peters
Extend the protector of a CSS style sheet. Because checkLoaded() can recursively delete
Added: trunk/LayoutTests/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt (0 => 91533)
--- trunk/LayoutTests/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt 2011-07-22 00:14:42 UTC (rev 91533)
@@ -0,0 +1,12 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderText {#text} at (0,0) size 0x0
+layer at (87,8) size 627x230
+ RenderBlock (relative positioned) {DIV} at (79,0) size 627x230 [bgcolor=#FF]
+layer at (87,8) size 501x230
+ RenderBlock (positioned) {DIV} at (0,0) size 501x230 [bgcolor=#FF]
+RenderImage {IMG} at (51,0) size 400x230
+RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/fast/css/absolute-child-with-percent-height-inside-relative-parent.html (0 => 91533)
--- trunk/LayoutTests/fast/css/absolute-child-with-percent-height-inside-relative-parent.html (rev 0)
+++ trunk/LayoutTests/fast/css/absolute-child-with-percent-height-inside-relative-parent.html 2011-07-22 00:14:42 UTC (rev 91533)
@@ -0,0 +1,20 @@
+
+
+
+body {text-align:center;}
+body * {
+width: 80%;
+display: inline-block;
+}
+body > div {background: blue;}
+body > div > div {background: red;}
+
+
+
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (91532 => 91533)
--- trunk/Source/WebCore/ChangeLog 2011-07-22 00:00:47 UTC (rev 91532)
+++ trunk/Source/WebCore/ChangeLog 2011-07-22 00:14:42 UTC (rev 91533)
@@ -1,3 +1,16 @@
+2011-07-21 Kulanthaivel Palanichamy
+
+Fix for bug 64046 - Wrong image height in absolutely positioned div in
+relatively positioned parent with bottom padding.
+https://bugs.webkit.org/show_bug.cgi?id=64046
+
+Reviewed by David Hyatt.
+
+Test: fast/css/absolute-child-with-percent-height-inside-relative-parent.html
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::availableLogicalHeightUsing):
+
2011-07-21 Gavin Peters
Extend the protector of a CSS style sheet. Because checkLoaded() can recursively delete
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (91532 => 91533)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2011-07-22 00:00:47 UTC (rev 91532)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2011-07-22 00:14:42 UTC (rev 91533)
@@ -2055,8 +2055,17 @@
if (isTableCell() && (h.isAuto() || h.isPercent()))
return overrideHeight() - borderAndPaddingLogicalWidth();
-if (h.isPercent())
- return computeContentBoxLogicalHeight(h.calcValue(contai
[webkit-changes] [91532] trunk/Source/WebCore/ChangeLog
Title: [91532] trunk/Source/WebCore/ChangeLog Revision 91532 Author mdela...@apple.com Date 2011-07-21 17:00:47 -0700 (Thu, 21 Jul 2011) Log Message Changelog fix for 91496 Modified Paths trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/ChangeLog (91531 => 91532) --- trunk/Source/WebCore/ChangeLog 2011-07-21 23:53:30 UTC (rev 91531) +++ trunk/Source/WebCore/ChangeLog 2011-07-22 00:00:47 UTC (rev 91532) @@ -42,47 +42,6 @@ * rendering/RenderBlock.cpp: (WebCore::RenderBlock::MarginInfo::MarginInfo): -2011-07-19 Matthew Delaney - -Add fast path for ImageBuffer::draw -https://bugs.webkit.org/show_bug.cgi?id=64535 - -Reviewed by Simon Fraser. - -No new tests. This patch doesn't change behavior; current tests are sufficient. - -* platform/graphics/GraphicsContext.cpp: -(WebCore::GraphicsContext::drawImage): Moved the main method version next to wrapper versions. - -* platform/graphics/ImageBuffer.h: -1) Added BackingStoreCopy enum for choosing to copy backing store or not in copyImage(). -2) Added copyNativeImage() behind USE(CG) - same as copyImage() but gives NativeImagePtr. -* platform/graphics/cg/ImageBufferCG.cpp: Added new methods described above. - -* platform/graphics/GraphicsContext.h: Adding drawNativeImage() for fast draw path. -* platform/graphics/cg/GraphicsContextCG.cpp: -(WebCore::GraphicsContext::drawNativeImage): Added. Draws a nativeImagePtr into context. - -* platform/graphics/Image.h: Added imageWithColorSpace behind CG platform ifdef -* platform/graphics/cg/ImageCG.cpp: -(WebCore::BitmapImage::draw): Refactored out actual image drawing code into GraphicsContext, -so that it can be used by more than just BitmapImage without having to copy code. -(WebCore::Image::imageWithColorSpace): Made into an Image class function. - -Updated copyImage() to for BackingStoreCopy: -* platform/graphics/qt/ImageBufferQt.cpp -* platform/graphics/filters/FETile.cpp -* platform/graphics/cairo/ImageBufferCairo.cpp -* platform/graphics/skia/ImageBufferSkia.cpp -* platform/graphics/wx/ImageBufferWx.cpp -* platform/graphics/wince/ImageBufferWinCE.cpp -* svg/SVGFEImageElement.cpp -* svg/graphics/SVGImage.cpp -* html/HTMLCanvasElement.cpp -* html/canvas/WebGLRenderingContext.cpp -* rendering/svg/RenderSVGResourcePattern.cpp - -<<< .mine 2011-07-21 Matthew Delaney Add fast path for ImageBuffer::draw, Take 2. @@ -110,7 +69,7 @@ so that it can be used by more than just BitmapImage without having to copy code. (WebCore::Image::imageWithColorSpace): Made into an Image class function. -Updated copyImage() to for BackingStoreCopy: +Updated copyImage() to use BackingStoreCopy: * platform/graphics/qt/ImageBufferQt.cpp * platform/graphics/filters/FETile.cpp * platform/graphics/cairo/ImageBufferCairo.cpp @@ -123,7 +82,6 @@ * html/canvas/WebGLRenderingContext.cpp * rendering/svg/RenderSVGResourcePattern.cpp -=== 2011-07-21 David Kilzer Clean up generated HTMLEntityTable.cpp output ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91531] trunk
Title: [91531] trunk
Revision 91531
Author gav...@chromium.org
Date 2011-07-21 16:53:30 -0700 (Thu, 21 Jul 2011)
Log Message
Extend the protector of a CSS style sheet. Because checkLoaded() can recursively delete
parent style elements, the protector should be extended to include the parent call.
https://bugs.webkit.org/show_bug.cgi?id=64736
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/css/css-imports-2.html
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::checkLoaded):
LayoutTests:
* fast/css/css-imports-2-expected.txt: Added.
* fast/css/css-imports-2.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSheet.cpp
Added Paths
trunk/LayoutTests/fast/css/css-imports-2-expected.txt
trunk/LayoutTests/fast/css/css-imports-2.html
Diff
Modified: trunk/LayoutTests/ChangeLog (91530 => 91531)
--- trunk/LayoutTests/ChangeLog 2011-07-21 23:29:00 UTC (rev 91530)
+++ trunk/LayoutTests/ChangeLog 2011-07-21 23:53:30 UTC (rev 91531)
@@ -1,3 +1,15 @@
+2011-07-21 Gavin Peters
+
+Extend the protector of a CSS style sheet. Because checkLoaded() can recursively delete
+parent style elements, the protector should be extended to include the parent call.
+
+https://bugs.webkit.org/show_bug.cgi?id=64736
+
+Reviewed by Simon Fraser.
+
+* fast/css/css-imports-2-expected.txt: Added.
+* fast/css/css-imports-2.html: Added.
+
2011-07-21 Ryosuke Niwa
Temporarily add failing test expectation for multi column tests after r91497.
Added: trunk/LayoutTests/fast/css/css-imports-2-expected.txt (0 => 91531)
--- trunk/LayoutTests/fast/css/css-imports-2-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/css-imports-2-expected.txt 2011-07-21 23:53:30 UTC (rev 91531)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/fast/css/css-imports-2.html (0 => 91531)
--- trunk/LayoutTests/fast/css/css-imports-2.html (rev 0)
+++ trunk/LayoutTests/fast/css/css-imports-2.html 2011-07-21 23:53:30 UTC (rev 91531)
@@ -0,0 +1,9 @@
+
+@import url('resources/css-imports.css');
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+document.body.innerHTML = "PASS";
+
+
Modified: trunk/Source/WebCore/ChangeLog (91530 => 91531)
--- trunk/Source/WebCore/ChangeLog 2011-07-21 23:29:00 UTC (rev 91530)
+++ trunk/Source/WebCore/ChangeLog 2011-07-21 23:53:30 UTC (rev 91531)
@@ -1,3 +1,17 @@
+2011-07-21 Gavin Peters
+
+Extend the protector of a CSS style sheet. Because checkLoaded() can recursively delete
+parent style elements, the protector should be extended to include the parent call.
+
+https://bugs.webkit.org/show_bug.cgi?id=64736
+
+Reviewed by Simon Fraser.
+
+Test: fast/css/css-imports-2.html
+
+* css/CSSStyleSheet.cpp:
+(WebCore::CSSStyleSheet::checkLoaded):
+
2011-07-21 Kenneth Russell
Update webglcontextlost / webglcontextrestored delivery to match spec changes
Modified: trunk/Source/WebCore/css/CSSStyleSheet.cpp (91530 => 91531)
--- trunk/Source/WebCore/css/CSSStyleSheet.cpp 2011-07-21 23:29:00 UTC (rev 91530)
+++ trunk/Source/WebCore/css/CSSStyleSheet.cpp 2011-07-21 23:53:30 UTC (rev 91531)
@@ -220,13 +220,13 @@
{
if (isLoading())
return;
-if (parent())
-parent()->checkLoaded();
// Avoid |this| being deleted by scripts that run via
// ScriptableDocumentParser::executeScriptsWaitingForStylesheets().
// See .
RefPtr protector(this);
+if (parent())
+parent()->checkLoaded();
m_loadCompleted = ownerNode() ? ownerNode()->sheetLoaded() : true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91530] trunk/LayoutTests
Title: [91530] trunk/LayoutTests Revision 91530 Author rn...@webkit.org Date 2011-07-21 16:29:00 -0700 (Thu, 21 Jul 2011) Log Message Temporarily add failing test expectation for multi column tests after r91497. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (91529 => 91530) --- trunk/LayoutTests/ChangeLog 2011-07-21 23:28:06 UTC (rev 91529) +++ trunk/LayoutTests/ChangeLog 2011-07-21 23:29:00 UTC (rev 91530) @@ -1,5 +1,11 @@ 2011-07-21 Ryosuke Niwa +Temporarily add failing test expectation for multi column tests after r91497. + +* platform/chromium/test_expectations.txt: + +2011-07-21 Ryosuke Niwa + Chromium test expectation update for svg/W3C-SVG-1.1-SE/color-prop-05-t.svg. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (91529 => 91530) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-21 23:28:06 UTC (rev 91529) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-21 23:29:00 UTC (rev 91530) @@ -3789,3 +3789,56 @@ BUGWK64951 : fast/frames/meta-refresh-user-gesture.html = CRASH TIMEOUT PASS BUGWK64976 : svg/W3C-SVG-1.1-SE/color-prop-05-t.svg = IMAGE + +BUGRNIWA LINUX : fast/multicol/scrolling-overflow.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/single-line.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/span/anonymous-before-child-parent-crash.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/span/anonymous-split-block-crash.html= TEXT +BUGRNIWA LINUX : fast/multicol/span/anonymous-style-inheritance.html= TEXT +BUGRNIWA LINUX : fast/multicol/span/span-as-immediate-child-complex-splitting.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/span/span-as-immediate-child-generated-content.html= TEXT +BUGRNIWA LINUX : fast/multicol/span/span-as-immediate-child-property-removal.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/span/span-as-immediate-columns-child-dynamic.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/span/span-as-immediate-columns-child-removal.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/span/span-as-immediate-columns-child.html= TEXT +BUGRNIWA LINUX : fast/multicol/span/span-as-nested-columns-child-dynamic.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/span/span-as-nested-columns-child.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/span/span-margin-collapsing.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/vertical-lr/float-multicol.html = IMAGE+TEXT +BUGRNIWA LINUX : fast/multicol/vertical-rl/float-multicol.html = IMAGE+TEXT + +BUGRNIWA MAC : fast/multicol/vertical-rl/float-multicol.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/vertical-lr/float-multicol.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/span/span-margin-collapsing.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/span/span-as-nested-columns-child.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/span/span-as-nested-columns-child-dynamic.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/span/span-as-immediate-columns-child.html = TEXT +BUGRNIWA MAC : fast/multicol/span/span-as-immediate-columns-child-removal.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/span/span-as-immediate-columns-child-dynamic.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/span/span-as-immediate-child-property-removal.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/span/span-as-immediate-child-generated-content.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/span/span-as-immediate-child-complex-splitting.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/span/anonymous-style-inheritance.html = TEXT +BUGRNIWA MAC : fast/multicol/span/anonymous-split-block-crash.html = TEXT +BUGRNIWA MAC : fast/multicol/span/anonymous-before-child-parent-crash.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/single-line.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/scrolling-overflow.html = IMAGE+TEXT +BUGRNIWA MAC : fast/multicol/float-multicol.html = IMAGE+TEXT + +BUGRNIWA WIN : fast/multicol/scrolling-overflow.html = IMAGE+TEXT +BUGRNIWA WIN : fast/multicol/single-line.html = IMAGE+TEXT +BUGRNIWA WIN : fast/multicol/span/anonymous-before-child-parent-crash.html = IMAGE+TEXT +BUGRNIWA WIN : fast/multicol/span/anonymous-split-block-crash.html = TEXT +BUGRNIWA WIN : fast/multicol/span/anonymous-style-inheritance.html = TEXT +BUGRNIWA WIN : fast/multicol/span/span-as-immediate-child-complex-splitting.html = IMAGE+TEXT +BUGRNIWA WIN : fast/multicol/span/span-as-immediate-child-generated-content.html = TEXT +BUGRNIWA WIN : fast/multicol/span/span-as-immediate-child-property-removal.html = IMAGE+TEXT +BUGRNIWA WIN : fast/multicol/span/span-as-immediate-columns-child-dynamic.html = TEXT +BUGRNIWA WIN : fast/multicol/span/span-as-immediate-columns-child-removal.html = IMAGE+TEXT +BUGRNIWA WIN : fast/multicol/span/span-as-immediate-columns-child.html = TEXT
[webkit-changes] [91529] trunk/Tools
Title: [91529] trunk/Tools
Revision 91529
Author o...@chromium.org
Date 2011-07-21 16:28:06 -0700 (Thu, 21 Jul 2011)
Log Message
Fix issue throwing a 500 to the bots. We were modifying
the dictionary during an iteration over it's keys and would get
RuntimeError: dictionary changed size during iteration
* TestResultServer/model/jsonresults.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/model/jsonresults.py
trunk/Tools/TestResultServer/model/jsonresults_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (91528 => 91529)
--- trunk/Tools/ChangeLog 2011-07-21 23:21:42 UTC (rev 91528)
+++ trunk/Tools/ChangeLog 2011-07-21 23:28:06 UTC (rev 91529)
@@ -1,3 +1,11 @@
+2011-07-21 Ojan Vafai
+
+Fix issue throwing a 500 to the bots. We were modifying
+the dictionary during an iteration over it's keys and would get
+RuntimeError: dictionary changed size during iteration
+
+* TestResultServer/model/jsonresults.py:
+
2011-07-21 Adam Barth
ORWT fails to consume some NRWT arguments
Modified: trunk/Tools/TestResultServer/model/jsonresults.py (91528 => 91529)
--- trunk/Tools/TestResultServer/model/jsonresults.py 2011-07-21 23:21:42 UTC (rev 91528)
+++ trunk/Tools/TestResultServer/model/jsonresults.py 2011-07-21 23:28:06 UTC (rev 91529)
@@ -209,14 +209,14 @@
@classmethod
def _remove_gtest_modifiers(cls, builder, json):
tests = json[builder][JSON_RESULTS_TESTS]
+new_tests = {}
for name, test in tests.iteritems():
new_name = name.replace('.FLAKY_', '.', 1)
new_name = new_name.replace('.FAILS_', '.', 1)
new_name = new_name.replace('.MAYBE_', '.', 1)
new_name = new_name.replace('.DISABLED_', '.', 1)
-if new_name != name:
-tests[new_name] = test
-del tests[name]
+new_tests[new_name] = test
+json[builder][JSON_RESULTS_TESTS] = new_tests
@classmethod
def _check_json(cls, builder, json):
Modified: trunk/Tools/TestResultServer/model/jsonresults_unittest.py (91528 => 91529)
--- trunk/Tools/TestResultServer/model/jsonresults_unittest.py 2011-07-21 23:21:42 UTC (rev 91528)
+++ trunk/Tools/TestResultServer/model/jsonresults_unittest.py 2011-07-21 23:28:06 UTC (rev 91529)
@@ -618,6 +618,9 @@
"foo.DISABLED_bar2": {
"results": "[1,\"I\"]",
"times": "[1,0]"},
+ "foo.bar3": {
+ "results": "[1,\"I\"]",
+ "times": "[1,0]"},
"foo.FAILS_bar3": {
"results": "[1,\"I\"]",
"times": "[1,0]"},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91528] trunk/LayoutTests
Title: [91528] trunk/LayoutTests Revision 91528 Author rn...@webkit.org Date 2011-07-21 16:21:42 -0700 (Thu, 21 Jul 2011) Log Message Chromium test expectation update for svg/W3C-SVG-1.1-SE/color-prop-05-t.svg. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (91527 => 91528) --- trunk/LayoutTests/ChangeLog 2011-07-21 23:14:36 UTC (rev 91527) +++ trunk/LayoutTests/ChangeLog 2011-07-21 23:21:42 UTC (rev 91528) @@ -1,3 +1,9 @@ +2011-07-21 Ryosuke Niwa + +Chromium test expectation update for svg/W3C-SVG-1.1-SE/color-prop-05-t.svg. + +* platform/chromium/test_expectations.txt: + 2011-07-21 Jessie Berlin Implement spinbutton support in RenderThemeSafari. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (91527 => 91528) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-21 23:14:36 UTC (rev 91527) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-21 23:21:42 UTC (rev 91528) @@ -3788,4 +3788,4 @@ BUGWK64951 : fast/frames/meta-refresh-user-gesture.html = CRASH TIMEOUT PASS -BUGWK64976 : svg/W3C-SVG-1.1-SE/color-prop-05-t.svg = IMAGE+TEXT +BUGWK64976 : svg/W3C-SVG-1.1-SE/color-prop-05-t.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91527] branches/safari-534.51-branch
Title: [91527] branches/safari-534.51-branch Revision 91527 Author lforsch...@apple.com Date 2011-07-21 16:14:36 -0700 (Thu, 21 Jul 2011) Log Message Merge r90068. Modified Paths branches/safari-534.51-branch/LayoutTests/ChangeLog branches/safari-534.51-branch/Source/WebCore/ChangeLog branches/safari-534.51-branch/Source/WebCore/rendering/RenderBlock.cpp branches/safari-534.51-branch/Source/WebCore/rendering/RenderReplaced.cpp branches/safari-534.51-branch/Source/WebCore/rendering/RenderReplaced.h branches/safari-534.51-branch/Source/WebCore/rendering/RenderWidget.cpp Added Paths branches/safari-534.51-branch/LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt branches/safari-534.51-branch/LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash.html branches/safari-534.51-branch/LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt branches/safari-534.51-branch/LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash.html Diff Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91526 => 91527) --- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 22:57:01 UTC (rev 91526) +++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 23:14:36 UTC (rev 91527) @@ -1,5 +1,23 @@ 2011-07-21 Lucas Forschler +Merged 90068. + +2011-06-23 Abhishek Arya + +Reviewed by James Robinson. + +Tests that we do not crash when failing to remove the linebreak +object(widget, block, replaced, etc) from parent block lineboxes. The +testcase tries to fuzz over the list of html and svg tags. +https://bugs.webkit.org/show_bug.cgi?id=60307 + +* fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt: Added. +* fast/block/block-not-removed-from-parent-lineboxes-crash.html: Added. +* fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt: Added. +* fast/block/child-not-removed-from-parent-lineboxes-crash.html: Added. + +2011-07-21 Lucas Forschler + Merged 90038. 2011-06-29 Darin Adler Copied: branches/safari-534.51-branch/LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt (from rev 90068, trunk/LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt) (0 => 91527) --- branches/safari-534.51-branch/LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt (rev 0) +++ branches/safari-534.51-branch/LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash-expected.txt 2011-07-21 23:14:36 UTC (rev 91527) @@ -0,0 +1 @@ +PASS: does not crash Copied: branches/safari-534.51-branch/LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash.html (from rev 90068, trunk/LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash.html) (0 => 91527) --- branches/safari-534.51-branch/LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash.html (rev 0) +++ branches/safari-534.51-branch/LayoutTests/fast/block/block-not-removed-from-parent-lineboxes-crash.html 2011-07-21 23:14:36 UTC (rev 91527) @@ -0,0 +1,18 @@ + + + +ABCD + +if (window.layoutTestController) +layoutTestController.dumpAsText(); + +document.body.offsetTop; +test1.style.display = ""; +document.body.offsetTop; +test2.parentNode.removeChild(test2); + +document.body.offsetTop; +document.body.innerHTML = "PASS: does not crash"; + + + Copied: branches/safari-534.51-branch/LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt (from rev 90068, trunk/LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt) (0 => 91527) --- branches/safari-534.51-branch/LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt (rev 0) +++ branches/safari-534.51-branch/LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash-expected.txt 2011-07-21 23:14:36 UTC (rev 91527) @@ -0,0 +1 @@ +PASS: does not crash Copied: branches/safari-534.51-branch/LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash.html (from rev 90068, trunk/LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash.html) (0 => 91527) --- branches/safari-534.51-branch/LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash.html (rev 0) +++ branches/safari-534.51-branch/LayoutTests/fast/block/child-not-removed-from-parent-lineboxes-crash.html 2011-07-21 23:14:36 UTC (rev 91527) @@ -0,0 +1,28 @@ + + + + +if (window.layoutTestController) +layoutTestController.dumpAsText(); + +var tags = ['a', 'abbr', 'acronym', 'address', 'applet', 'area', 'article', 'aside', 'audio', 'b', 'base', 'basefont', 'bdo', 'bgsound', 'big', 'blockquote', 'body', 'br', 'button', 'canvas', 'caption', 'center', 'cite', 'code', 'col', 'colgroup', 'co
[webkit-changes] [91526] trunk/Tools
Title: [91526] trunk/Tools
Revision 91526
Author aba...@webkit.org
Date 2011-07-21 15:57:01 -0700 (Thu, 21 Jul 2011)
Log Message
ORWT fails to consume some NRWT arguments
https://bugs.webkit.org/show_bug.cgi?id=64988
Reviewed by Adam Roben.
* Scripts/old-run-webkit-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/old-run-webkit-tests
Diff
Modified: trunk/Tools/ChangeLog (91525 => 91526)
--- trunk/Tools/ChangeLog 2011-07-21 22:34:56 UTC (rev 91525)
+++ trunk/Tools/ChangeLog 2011-07-21 22:57:01 UTC (rev 91526)
@@ -1,5 +1,14 @@
2011-07-21 Adam Barth
+ORWT fails to consume some NRWT arguments
+https://bugs.webkit.org/show_bug.cgi?id=64988
+
+Reviewed by Adam Roben.
+
+* Scripts/old-run-webkit-tests:
+
+2011-07-21 Adam Barth
+
Merge TestFailures and garden-o-matic unit tests harness
https://bugs.webkit.org/show_bug.cgi?id=64984
Modified: trunk/Tools/Scripts/old-run-webkit-tests (91525 => 91526)
--- trunk/Tools/Scripts/old-run-webkit-tests 2011-07-21 22:34:56 UTC (rev 91525)
+++ trunk/Tools/Scripts/old-run-webkit-tests 2011-07-21 22:57:01 UTC (rev 91526)
@@ -378,10 +378,10 @@
'verbose|v' => \$verbose,
'webkit-test-runner|2' => \$useWebKitTestRunner,
# These arguments are ignored (but are used by new-run-webkit-tests).
-'builder-name' => \$builderName,
-'build-number' => \$buildNumber,
-'master-name' => \$masterName,
-'test-results-server' => \$testResultsServer,
+'builder-name=s' => \$builderName,
+'build-number=s' => \$buildNumber,
+'master-name=s' => \$masterName,
+'test-results-server=s' => \$testResultsServer,
);
if (!$getOptionsResult || $showHelp) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91525] trunk/LayoutTests
Title: [91525] trunk/LayoutTests Revision 91525 Author jber...@webkit.org Date 2011-07-21 15:34:56 -0700 (Thu, 21 Jul 2011) Log Message Implement spinbutton support in RenderThemeSafari. https://bugs.webkit.org/show_bug.cgi?id=54662 Yet another spinbutton test ... * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (91524 => 91525) --- trunk/LayoutTests/ChangeLog 2011-07-21 22:31:55 UTC (rev 91524) +++ trunk/LayoutTests/ChangeLog 2011-07-21 22:34:56 UTC (rev 91525) @@ -3,6 +3,15 @@ Implement spinbutton support in RenderThemeSafari. https://bugs.webkit.org/show_bug.cgi?id=54662 +Yet another spinbutton test ... + +* platform/win/Skipped: + +2011-07-21 Jessie Berlin + +Implement spinbutton support in RenderThemeSafari. +https://bugs.webkit.org/show_bug.cgi?id=54662 + Add another spinbutton test to the Skipped list to get the bots green. * platform/win/Skipped: Modified: trunk/LayoutTests/platform/win/Skipped (91524 => 91525) --- trunk/LayoutTests/platform/win/Skipped 2011-07-21 22:31:55 UTC (rev 91524) +++ trunk/LayoutTests/platform/win/Skipped 2011-07-21 22:34:56 UTC (rev 91525) @@ -1081,6 +1081,7 @@ # Implement spinbutton support in RenderThemeSafari # https://bugs.webkit.org/show_bug.cgi?id=54662 +fast/forms/input-appearance-number-rtl.html fast/forms/input-appearance-spinbutton-disabled-readonly.html fast/forms/input-appearance-spinbutton-layer.html fast/forms/input-appearance-spinbutton-visibility.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91524] trunk/Tools
Title: [91524] trunk/Tools Revision 91524 Author aba...@webkit.org Date 2011-07-21 15:31:55 -0700 (Thu, 21 Jul 2011) Log Message Merge TestFailures and garden-o-matic unit tests harness https://bugs.webkit.org/show_bug.cgi?id=64984 Reviewed by Adam Roben. One unit testing framework is better than two. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Removed. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html trunk/Tools/ChangeLog Removed Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html Diff Deleted: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html (91523 => 91524) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html 2011-07-21 22:27:00 UTC (rev 91523) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html 2011-07-21 22:31:55 UTC (rev 91524) @@ -1,24 +0,0 @@ - - - - - -Gardening Server _javascript_ Unit Tests - - - - -
[webkit-changes] [91523] branches/safari-534.51-branch
Title: [91523] branches/safari-534.51-branch
Revision 91523
Author lforsch...@apple.com
Date 2011-07-21 15:27:00 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r90038.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/loader/FrameLoader.cpp
branches/safari-534.51-branch/Source/WebKit2/ChangeLog
branches/safari-534.51-branch/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
Added Paths
branches/safari-534.51-branch/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded-expected.txt
branches/safari-534.51-branch/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded.html
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91522 => 91523)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 22:24:50 UTC (rev 91522)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 22:27:00 UTC (rev 91523)
@@ -1,5 +1,19 @@
2011-07-21 Lucas Forschler
+Merged 90038.
+
+2011-06-29 Darin Adler
+
+Reviewed by Anders Carlsson.
+
+[WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
+https://bugs.webkit.org/show_bug.cgi?id=63483
+
+* fast/loader/create-frame-in-DOMContentLoaded-expected.txt: Added.
+* fast/loader/create-frame-in-DOMContentLoaded.html: Added.
+
+2011-07-21 Lucas Forschler
+
Merged 89836.
2011-06-27 Abhishek Arya
Copied: branches/safari-534.51-branch/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded-expected.txt (from rev 90038, trunk/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded-expected.txt) (0 => 91523)
--- branches/safari-534.51-branch/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded-expected.txt 2011-07-21 22:27:00 UTC (rev 91523)
@@ -0,0 +1,5 @@
+A) Entered DOMContentLoaded event handler function.
+C) Entered load event handler function.
+D) Exiting load event handler function.
+Test passed if messages A, B, C, D were all in order and there was no crash.
+B) Exiting DOMContentLoaded event handler function.
Copied: branches/safari-534.51-branch/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded.html (from rev 90038, trunk/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded.html) (0 => 91523)
--- branches/safari-534.51-branch/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded.html 2011-07-21 22:27:00 UTC (rev 91523)
@@ -0,0 +1,31 @@
+
+
+var frame;
+function print(message)
+{
+var line = document.createElement("div");
+line.appendChild(document.createTextNode(message));
+document.body.appendChild(line);
+}
+function handleDOMContentLoadedEvent()
+{
+document.body.removeChild(document.body.firstChild);
+print("A) Entered DOMContentLoaded event handler function.");
+frame = document.createElement("iframe");
+document.body.appendChild(frame);
+print("B) Exiting DOMContentLoaded event handler function.");
+}
+function handleLoadEvent()
+{
+print("C) Entered load event handler function.");
+document.body.removeChild(frame);
+print("D) Exiting load event handler function.");
+print("Test passed if messages A, B, C, D were all in order and there was no crash.");
+}
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+addEventListener("load", handleLoadEvent);
+addEventListener("DOMContentLoaded", handleDOMContentLoadedEvent);
+
+
+TEST DID NOT RUN YET
Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (91522 => 91523)
--- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 22:24:50 UTC (rev 91522)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 22:27:00 UTC (rev 91523)
@@ -1,5 +1,25 @@
2011-07-21 Lucas Forschler
+Merged 90038.
+
+2011-06-29 Darin Adler
+
+Reviewed by Anders Carlsson.
+
+[WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
+https://bugs.webkit.org/show_bug.cgi?id=63483
+
+Test: fast/loader/create-frame-in-DOMContentLoaded.html
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::init): Added an assertion.
+(WebCore::FrameLoader::finishedLoadingDocument): Removed a non-helpful #if
+statement. The rule that we do not call the client when creating the initial
+empty document was nominally specific to Windows and Chromium but is needed
+for all platforms.
+
+2011-07-21 Lucas Forschler
+
Merged 89836.
2011-06-27 Abhishek Arya
Modified: branches/safari-534.51-branch/Source/WebCore/loader/FrameLoader.cpp (91522 => 91523)
--- branches/safari-534.5
[webkit-changes] [91521] trunk/LayoutTests
Title: [91521] trunk/LayoutTests Revision 91521 Author jber...@webkit.org Date 2011-07-21 15:22:32 -0700 (Thu, 21 Jul 2011) Log Message Implement spinbutton support in RenderThemeSafari. https://bugs.webkit.org/show_bug.cgi?id=54662 Add another spinbutton test to the Skipped list to get the bots green. * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (91520 => 91521) --- trunk/LayoutTests/ChangeLog 2011-07-21 22:22:29 UTC (rev 91520) +++ trunk/LayoutTests/ChangeLog 2011-07-21 22:22:32 UTC (rev 91521) @@ -1,3 +1,12 @@ +2011-07-21 Jessie Berlin + +Implement spinbutton support in RenderThemeSafari. +https://bugs.webkit.org/show_bug.cgi?id=54662 + +Add another spinbutton test to the Skipped list to get the bots green. + +* platform/win/Skipped: + 2011-07-21 Kenneth Russell Update webglcontextlost / webglcontextrestored delivery to match spec changes Modified: trunk/LayoutTests/platform/win/Skipped (91520 => 91521) --- trunk/LayoutTests/platform/win/Skipped 2011-07-21 22:22:29 UTC (rev 91520) +++ trunk/LayoutTests/platform/win/Skipped 2011-07-21 22:22:32 UTC (rev 91521) @@ -1079,14 +1079,15 @@ # LayoutTestController::isPageBoxVisible, pageAreaRectInPixels, and preferredPageSizeInPixels are not implemented yet for WIN. printing/page-format-data.html -# Need to implement inner-spin-button -# https://bugs.webkit.org/show_bug.cgi?id=38381 +# Implement spinbutton support in RenderThemeSafari +# https://bugs.webkit.org/show_bug.cgi?id=54662 fast/forms/input-appearance-spinbutton-disabled-readonly.html fast/forms/input-appearance-spinbutton-layer.html fast/forms/input-appearance-spinbutton-visibility.html fast/forms/input-number-events.html fast/forms/input-number-large-padding.html fast/forms/input-spinbutton-capturing.html +fast/forms/spin-button-gets-disabled-or-readonly.html # Color input is not yet enabled. fast/forms/color ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91520] branches/safari-534.51-branch
Title: [91520] branches/safari-534.51-branch
Revision 91520
Author lforsch...@apple.com
Date 2011-07-21 15:22:29 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r89831.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/editing/TextIterator.cpp
Added Paths
branches/safari-534.51-branch/LayoutTests/editing/text-iterator/first-letter-rtl-crash-expected.txt
branches/safari-534.51-branch/LayoutTests/editing/text-iterator/first-letter-rtl-crash.html
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91519 => 91520)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 22:20:44 UTC (rev 91519)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 22:22:29 UTC (rev 91520)
@@ -1,5 +1,22 @@
2011-07-21 Lucas Forschler
+Merged 89831.
+
+2011-06-27 Ryosuke Niwa
+
+Reviewed by Kent Tamura.
+
+Crash in TextIterator
+https://bugs.webkit.org/show_bug.cgi?id=63334
+
+Added a test to ensure WebKit does not crash when iterating through letters in a RTL block
+with first-letter rule applied where letters are not contiguous.
+
+* editing/text-iterator/first-letter-rtl-crash-expected.txt: Added.
+* editing/text-iterator/first-letter-rtl-crash.html: Added.
+
+2011-07-21 Lucas Forschler
+
Merged 89780.
2011-07-21 Lucas Forschler
Copied: branches/safari-534.51-branch/LayoutTests/editing/text-iterator/first-letter-rtl-crash-expected.txt (from rev 89831, trunk/LayoutTests/editing/text-iterator/first-letter-rtl-crash-expected.txt) (0 => 91520)
--- branches/safari-534.51-branch/LayoutTests/editing/text-iterator/first-letter-rtl-crash-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/editing/text-iterator/first-letter-rtl-crash-expected.txt 2011-07-21 22:22:29 UTC (rev 91520)
@@ -0,0 +1,3 @@
+
+This test ensures WebKit does not crash when first-letter rule is applied to LTR letters that are not visually contiguous to each other.
+PASS
Copied: branches/safari-534.51-branch/LayoutTests/editing/text-iterator/first-letter-rtl-crash.html (from rev 89831, trunk/LayoutTests/editing/text-iterator/first-letter-rtl-crash.html) (0 => 91520)
--- branches/safari-534.51-branch/LayoutTests/editing/text-iterator/first-letter-rtl-crash.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/editing/text-iterator/first-letter-rtl-crash.html 2011-07-21 22:22:29 UTC (rev 91520)
@@ -0,0 +1,17 @@
+
+
+
+body:first-letter { color: black; }
+
+
+
+function run() {
+document.execCommand('findString', false, '!ABC');
+document.body.innerHTML = '
This test ensures WebKit does not crash when first-letter rule is applied to LTR letters that ' +
+' are not visually contiguous to each other.
PASS';
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+}
+
+
+!ABC
Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (91519 => 91520)
--- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 22:20:44 UTC (rev 91519)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 22:22:29 UTC (rev 91520)
@@ -1,5 +1,27 @@
2011-07-21 Lucas Forschler
+Merged 89831.
+
+2011-06-27 Ryosuke Niwa
+
+Reviewed by Kent Tamura.
+
+Crash in TextIterator
+https://bugs.webkit.org/show_bug.cgi?id=63334
+
+Fix a crash in TextIterator. Keep m_sortedTextBoxes and renderer consistent
+and check !m_offset when handling first letter.
+
+Also add more assertions to help detecting similar bugs.
+
+Test: editing/text-iterator/first-letter-rtl-crash.html
+
+* editing/TextIterator.cpp:
+(WebCore::TextIterator::handleTextNode):
+(WebCore::TextIterator::emitText):
+
+2011-07-21 Lucas Forschler
+
Merged 89780.
2011-06-26 Adam Barth
Modified: branches/safari-534.51-branch/Source/WebCore/editing/TextIterator.cpp (91519 => 91520)
--- branches/safari-534.51-branch/Source/WebCore/editing/TextIterator.cpp 2011-07-21 22:20:44 UTC (rev 91519)
+++ branches/safari-534.51-branch/Source/WebCore/editing/TextIterator.cpp 2011-07-21 22:22:29 UTC (rev 91520)
@@ -459,7 +459,7 @@
emitCharacter(' ', m_node, 0, runStart, runStart);
return false;
}
-if (!m_handledFirstLetter && renderer->isTextFragment()) {
+if (!m_handledFirstLetter && renderer->isTextFragment() && !m_offset) {
handleTextNodeFirstLetter(static_cast(renderer));
if (m_firstLetterText) {
String firstLetter = m_firstLetterText->text();
@@ -496,6 +496,14 @@
return true;
}
+
+m_textBox = renderer->firstTextBox();
+if (!m_handledFirstLetter && renderer->isTextFragment() && !m_offset)
+handleTextNodeFirs
[webkit-changes] [91518] trunk/Tools
Title: [91518] trunk/Tools
Revision 91518
Author o...@chromium.org
Date 2011-07-21 15:13:33 -0700 (Thu, 21 Jul 2011)
Log Message
fix links on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64832
Reviewed by Tony Chang.
Make them actual anchor tags and linkify the test name instead of
adding an extra link. Also simplify the update view since we now
show the linkified test name.
* TestResultServer/static-dashboards/flakiness_dashboard.html:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html
Diff
Modified: trunk/Tools/ChangeLog (91517 => 91518)
--- trunk/Tools/ChangeLog 2011-07-21 22:09:11 UTC (rev 91517)
+++ trunk/Tools/ChangeLog 2011-07-21 22:13:33 UTC (rev 91518)
@@ -1,3 +1,16 @@
+2011-07-19 Ojan Vafai
+
+fix links on the flakiness dashboard
+https://bugs.webkit.org/show_bug.cgi?id=64832
+
+Reviewed by Tony Chang.
+
+Make them actual anchor tags and linkify the test name instead of
+adding an extra link. Also simplify the update view since we now
+show the linkified test name.
+
+* TestResultServer/static-dashboards/flakiness_dashboard.html:
+
2011-07-21 Adam Barth
webkit.org builders should upload results to test-results AppEngine instance
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html (91517 => 91518)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-21 22:09:11 UTC (rev 91517)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-21 22:13:33 UTC (rev 91518)
@@ -1197,7 +1197,7 @@
function linkHTMLToOpenWindow(url, text)
{
-return '' + text + '';
+return '' + text + '';
}
// FIXME: replaced with chromiumRevisionLink/webKitRevisionLink
@@ -1300,12 +1300,6 @@
showPopup(e, html);
}
-function showPopupForTest(e, test)
-{
-showPopup(e, htmlForIndividulTestOnAllBuilders(test));
-appendExpectations();
-}
-
function htmlForTestResults(test)
{
if (!g_currentState.showRunsOnBuilderPage && !isCrossBuilderView())
@@ -1726,10 +1720,14 @@
function showUpdateInfoForTest(testsNeedingUpdate, keys)
{
var test = keys[g_currentState.updateIndex];
-document.body.innerHTML = '' + test + '' +
-'' + (g_currentState.updateIndex + 1) + ' of ' +
-+ keys.length + ' tests';
+document.body.innerHTML = '';
+// FIXME: Make this DOM creation less verbose.
+var index = document.createElement('div');
+index.style.cssFloat = 'right';
+index.textContent = (g_currentState.updateIndex + 1) + ' of ' + keys.length + ' tests';
+document.body.appendChild(index);
+
var buttonRegion = document.createElement('div');
var includeBtn = document.createElement('input');
includeBtn.type = 'button';
@@ -1854,12 +1852,14 @@
var testResults = g_testToResultsMap[test];
var master;
var html = '';
+if (isLayoutTestResults()) {
+var tracURL = TEST_URL_BASE_PATH_TRAC + test
+html += '' + linkHTMLToOpenWindow(tracURL, test) + '';
+} else
+html += '' + test + '';
+
if (testResults && testResults.length) {
master = builderMaster(testResults[0].builder);
-if (isLayoutTestResults()) {
-var tracURL = TEST_URL_BASE_PATH_TRAC + test
-html += linkHTMLToOpenWindow(tracURL, tracURL);
-}
html +='If a builder is not listed, that means the builder ' +
'does not run that test (e.g. it is skipped) or all runs of the ' +
@@ -2364,7 +2364,7 @@
{
var testsHTML = [];
for (var i = 0; i < tests.length; i++)
-testsHTML.push('' + tests[i] + '' + htmlForIndividulTestOnAllBuilders(tests[i]));
+testsHTML.push(htmlForIndividulTestOnAllBuilders(tests[i]));
return testsHTML.join('');
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91517] branches/safari-534.51-branch
Title: [91517] branches/safari-534.51-branch Revision 91517 Author lforsch...@apple.com Date 2011-07-21 15:09:11 -0700 (Thu, 21 Jul 2011) Log Message Merge r89780. Modified Paths branches/safari-534.51-branch/LayoutTests/ChangeLog branches/safari-534.51-branch/Source/WebCore/ChangeLog branches/safari-534.51-branch/Source/WebCore/dom/Document.h Added Paths branches/safari-534.51-branch/LayoutTests/fast/forms/form-associated-element-crash3-expected.txt branches/safari-534.51-branch/LayoutTests/fast/forms/form-associated-element-crash3.html Diff Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91516 => 91517) --- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 22:09:03 UTC (rev 91516) +++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 22:09:11 UTC (rev 91517) @@ -1,5 +1,19 @@ 2011-07-21 Lucas Forschler +Merged 89780. + +2011-07-21 Lucas Forschler + +Reviewed by Kent Tamura. + +m_formElementsWithFormAttribute doesn't ref the objects it holds +https://bugs.webkit.org/show_bug.cgi?id=62956 + +* fast/forms/form-associated-element-crash3-expected.txt: Added. +* fast/forms/form-associated-element-crash3.html: Added. + +2011-07-21 Lucas Forschler + Merged 89769. 2011-06-26 Dan Bernstein Copied: branches/safari-534.51-branch/LayoutTests/fast/forms/form-associated-element-crash3-expected.txt (from rev 89780, trunk/LayoutTests/fast/forms/form-associated-element-crash3-expected.txt) (0 => 91517) --- branches/safari-534.51-branch/LayoutTests/fast/forms/form-associated-element-crash3-expected.txt (rev 0) +++ branches/safari-534.51-branch/LayoutTests/fast/forms/form-associated-element-crash3-expected.txt 2011-07-21 22:09:11 UTC (rev 91517) @@ -0,0 +1 @@ +This test passes if it doesn't crash. Note: You might need to reload this test many times (or run the test under valgrind / ASAN) to see a crash. Copied: branches/safari-534.51-branch/LayoutTests/fast/forms/form-associated-element-crash3.html (from rev 89780, trunk/LayoutTests/fast/forms/form-associated-element-crash3.html) (0 => 91517) --- branches/safari-534.51-branch/LayoutTests/fast/forms/form-associated-element-crash3.html (rev 0) +++ branches/safari-534.51-branch/LayoutTests/fast/forms/form-associated-element-crash3.html 2011-07-21 22:09:11 UTC (rev 91517) @@ -0,0 +1,16 @@ + + +if (window.layoutTestController) +layoutTestController.dumpAsText(); + +This test passes if it doesn't crash. Note: You might need to reload this test +many times (or run the test under valgrind / ASAN) to see a crash. + + + + + + + + + Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (91516 => 91517) --- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 22:09:03 UTC (rev 91516) +++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 22:09:11 UTC (rev 91517) @@ -1,5 +1,20 @@ 2011-07-21 Lucas Forschler +Merged 89780. + +2011-06-26 Adam Barth + +Reviewed by Kent Tamura. + +m_formElementsWithFormAttribute doesn't ref the objects it holds +https://bugs.webkit.org/show_bug.cgi?id=62956 + +Test: fast/forms/form-associated-element-crash3.html + +* dom/Document.h: + +2011-07-21 Lucas Forschler + Merged 89769. 2011-06-26 Dan Bernstein Modified: branches/safari-534.51-branch/Source/WebCore/dom/Document.h (91516 => 91517) --- branches/safari-534.51-branch/Source/WebCore/dom/Document.h 2011-07-21 22:09:03 UTC (rev 91516) +++ branches/safari-534.51-branch/Source/WebCore/dom/Document.h 2011-07-21 22:09:11 UTC (rev 91517) @@ -1251,7 +1251,7 @@ typedef ListHashSet FormElementListHashSet; FormElementListHashSet m_formElementsWithState; -typedef ListHashSet FormAssociatedElementListHashSet; +typedef ListHashSet, 32> FormAssociatedElementListHashSet; FormAssociatedElementListHashSet m_formElementsWithFormAttribute; typedef HashMap, FormElementKeyHash, FormElementKeyHashTraits> FormElementStateMap; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91516] trunk/Tools
Title: [91516] trunk/Tools
Revision 91516
Author aba...@webkit.org
Date 2011-07-21 15:09:03 -0700 (Thu, 21 Jul 2011)
Log Message
webkit.org builders should upload results to test-results AppEngine instance
https://bugs.webkit.org/show_bug.cgi?id=64979
Reviewed by Adam Roben.
The master just needs to pass some flags to NRWT. This patch also lets
ORWT consume the flags (ignoring them) so we can pass the flags
unconditionally.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* Scripts/old-run-webkit-tests:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
trunk/Tools/Scripts/old-run-webkit-tests
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (91515 => 91516)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-21 22:02:54 UTC (rev 91515)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-21 22:09:03 UTC (rev 91516)
@@ -195,9 +195,19 @@
name = "layout-test"
description = ["layout-tests running"]
descriptionDone = ["layout-tests"]
-command = ["perl", "./Tools/Scripts/run-webkit-tests", "--no-launch-safari", "--no-new-test-results",
- "--no-sample-on-timeout", "--results-directory", "layout-test-results", "--use-remote-links-to-tests",
- WithProperties("--%(configuration)s"), "--exit-after-n-crashes-or-timeouts", "20", "--exit-after-n-failures", "500"]
+command = ["perl", "./Tools/Scripts/run-webkit-tests",
+ "--no-launch-safari",
+ "--no-new-test-results",
+ "--no-sample-on-timeout",
+ "--results-directory", "layout-test-results",
+ "--use-remote-links-to-tests",
+ "--builder-name", WithProperties("%(buildername)s"),
+ "--build-number", WithProperties("%(buildnumber)s"),
+ "--master-name", "webkit.org",
+ "--test-results-server", "test-results.appspot.com",
+ WithProperties("--%(configuration)s"),
+ "--exit-after-n-crashes-or-timeouts", "20",
+ "--exit-after-n-failures", "500"]
def __init__(self, buildJSCTool=True, *args, **kwargs):
self.buildJSCTool = buildJSCTool
Modified: trunk/Tools/ChangeLog (91515 => 91516)
--- trunk/Tools/ChangeLog 2011-07-21 22:02:54 UTC (rev 91515)
+++ trunk/Tools/ChangeLog 2011-07-21 22:09:03 UTC (rev 91516)
@@ -1,3 +1,17 @@
+2011-07-21 Adam Barth
+
+webkit.org builders should upload results to test-results AppEngine instance
+https://bugs.webkit.org/show_bug.cgi?id=64979
+
+Reviewed by Adam Roben.
+
+The master just needs to pass some flags to NRWT. This patch also lets
+ORWT consume the flags (ignoring them) so we can pass the flags
+unconditionally.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+* Scripts/old-run-webkit-tests:
+
2011-07-21 Ojan Vafai
normalize gtest names in the result json
Modified: trunk/Tools/Scripts/old-run-webkit-tests (91515 => 91516)
--- trunk/Tools/Scripts/old-run-webkit-tests 2011-07-21 22:02:54 UTC (rev 91515)
+++ trunk/Tools/Scripts/old-run-webkit-tests 2011-07-21 22:09:03 UTC (rev 91516)
@@ -179,6 +179,12 @@
my $useWebKitTestRunner = 0;
my $noBuildDumpTool = 0;
+# These arguments are ignored, but exist for compatibility with new-run-webkit-tests.
+my $builderName = '';
+my $buildNumber = '';
+my $masterName = '';
+my $testResultsServer = '';
+
my @leaksFilenames;
if (isWindows() || isMsys()) {
@@ -371,6 +377,11 @@
'valgrind' => \$useValgrind,
'verbose|v' => \$verbose,
'webkit-test-runner|2' => \$useWebKitTestRunner,
+# These arguments are ignored (but are used by new-run-webkit-tests).
+'builder-name' => \$builderName,
+'build-number' => \$buildNumber,
+'master-name' => \$masterName,
+'test-results-server' => \$testResultsServer,
);
if (!$getOptionsResult || $showHelp) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91515] trunk/Tools
Title: [91515] trunk/Tools
Revision 91515
Author o...@chromium.org
Date 2011-07-21 15:02:54 -0700 (Thu, 21 Jul 2011)
Log Message
normalize gtest names in the result json
https://bugs.webkit.org/show_bug.cgi?id=64971
Reviewed by Eric Seidel.
This will make the resulting JSON smaller and make the
flakiness dashboard much more sane (e.g. we won't need to
show you the FLAKY_ version and the normal version).
* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/model/jsonresults.py
trunk/Tools/TestResultServer/model/jsonresults_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (91514 => 91515)
--- trunk/Tools/ChangeLog 2011-07-21 22:01:07 UTC (rev 91514)
+++ trunk/Tools/ChangeLog 2011-07-21 22:02:54 UTC (rev 91515)
@@ -1,3 +1,17 @@
+2011-07-21 Ojan Vafai
+
+normalize gtest names in the result json
+https://bugs.webkit.org/show_bug.cgi?id=64971
+
+Reviewed by Eric Seidel.
+
+This will make the resulting JSON smaller and make the
+flakiness dashboard much more sane (e.g. we won't need to
+show you the FLAKY_ version and the normal version).
+
+* TestResultServer/model/jsonresults.py:
+* TestResultServer/model/jsonresults_unittest.py:
+
2011-07-21 Eric Seidel
Unreviewed. Reenable ORWT for the --leaks bot.
Modified: trunk/Tools/TestResultServer/model/jsonresults.py (91514 => 91515)
--- trunk/Tools/TestResultServer/model/jsonresults.py 2011-07-21 22:01:07 UTC (rev 91514)
+++ trunk/Tools/TestResultServer/model/jsonresults.py 2011-07-21 22:02:54 UTC (rev 91515)
@@ -207,6 +207,18 @@
return result
@classmethod
+def _remove_gtest_modifiers(cls, builder, json):
+tests = json[builder][JSON_RESULTS_TESTS]
+for name, test in tests.iteritems():
+new_name = name.replace('.FLAKY_', '.', 1)
+new_name = new_name.replace('.FAILS_', '.', 1)
+new_name = new_name.replace('.MAYBE_', '.', 1)
+new_name = new_name.replace('.DISABLED_', '.', 1)
+if new_name != name:
+tests[new_name] = test
+del tests[name]
+
+@classmethod
def _check_json(cls, builder, json):
version = json[JSON_RESULTS_VERSION_KEY]
if version > JSON_RESULTS_HIERARCHICAL_VERSION:
@@ -248,6 +260,9 @@
if not cls._check_json(builder, incremental_json):
return None
+# FIXME: We should probably avoid doing this for layout tests.
+cls._remove_gtest_modifiers(builder, incremental_json)
+
logging.info("Loading existing aggregated json...")
aggregated_json = cls._load_json(aggregated)
if not aggregated_json:
Modified: trunk/Tools/TestResultServer/model/jsonresults_unittest.py (91514 => 91515)
--- trunk/Tools/TestResultServer/model/jsonresults_unittest.py 2011-07-21 22:01:07 UTC (rev 91514)
+++ trunk/Tools/TestResultServer/model/jsonresults_unittest.py 2011-07-21 22:02:54 UTC (rev 91515)
@@ -596,5 +596,53 @@
# Expected results
["001.html", "002.html"])
+def test_remove_gtest_modifiers(self):
+self._test_merge(
+# Aggregated results
+{"builds": ["2", "1"],
+ "tests": {"foo.bar": {
+ "results": "[50,\"F\"]",
+ "times": "[50,0]"},
+ "foo.bar2": {
+ "results": "[100,\"I\"]",
+ "times": "[100,0]"},
+ "foo.FAILS_bar3": {
+ "results": "[100,\"I\"]",
+ "times": "[100,0]"},
+ }},
+# Incremental results
+{"builds": ["3"],
+ "tests": {"foo.FLAKY_bar": {
+ "results": "[1,\"F\"]",
+ "times": "[1,0]"},
+ "foo.DISABLED_bar2": {
+ "results": "[1,\"I\"]",
+ "times": "[1,0]"},
+ "foo.FAILS_bar3": {
+ "results": "[1,\"I\"]",
+ "times": "[1,0]"},
+ "foo.MAYBE_bar4": {
+ "results": "[1,\"I\"]",
+ "times": "[1,0]"}},
+ "version": 4},
+# Expected results
+{"builds": ["3", "2", "1"],
+ "tests": {"foo.bar": {
+ "results": "[51,\"F\"]",
+ "times": "[51,0]"},
+ "foo.bar2": {
+ "results": "[101,\"I\"]",
+ "times": "[101,0]"},
+ "foo.bar3": {
+ "results": "[1,\"I\"]",
+ "times": "[1,0]"},
+ "foo.FAILS_bar3": {
+
[webkit-changes] [91514] branches/safari-534.51-branch
Title: [91514] branches/safari-534.51-branch
Revision 91514
Author lforsch...@apple.com
Date 2011-07-21 15:01:07 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r89769.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Added Paths
branches/safari-534.51-branch/LayoutTests/fast/text/midword-break-before-surrogate-pair.html
branches/safari-534.51-branch/LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-expected.png
branches/safari-534.51-branch/LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-expected.txt
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91513 => 91514)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:59:09 UTC (rev 91513)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 22:01:07 UTC (rev 91514)
@@ -1,5 +1,18 @@
2011-07-21 Lucas Forschler
+Merged 89769.
+
+2011-06-26 Dan Bernstein
+
+Reviewed by Darin Adler.
+
+With word-break: break-all, words do not break correctly before a surrogate pair
+https://bugs.webkit.org/show_bug.cgi?id=63401
+
+* fast/text/midword-break-before-surrogate-pair.html: Added.
+
+2011-07-21 Lucas Forschler
+
Merged 89614.
2011-06-23 Gavin Barraclough
Copied: branches/safari-534.51-branch/LayoutTests/fast/text/midword-break-before-surrogate-pair.html (from rev 89769, trunk/LayoutTests/fast/text/midword-break-before-surrogate-pair.html) (0 => 91514)
--- branches/safari-534.51-branch/LayoutTests/fast/text/midword-break-before-surrogate-pair.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/text/midword-break-before-surrogate-pair.html 2011-07-21 22:01:07 UTC (rev 91514)
@@ -0,0 +1,3 @@
+
+𝄐𝄐
+
Copied: branches/safari-534.51-branch/LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-expected.png (from rev 89769, trunk/LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-expected.png)
(Binary files differ)
Copied: branches/safari-534.51-branch/LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-expected.txt (from rev 89769, trunk/LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-expected.txt) (0 => 91514)
--- branches/safari-534.51-branch/LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-expected.txt 2011-07-21 22:01:07 UTC (rev 91514)
@@ -0,0 +1,9 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 186x92 [border: (3px solid #FF)]
+RenderText {#text} at (3,3) size 168x84
+ text run at (3,3) width 168: "\x{D834}\x{DD10}\x{D834}\x{DD10}\x{D834}\x{DD10}\x{D834}\x{DD10}\x{D834}\x{DD10}\x{D834}\x{DD10}\x{D834}\x{DD10}"
+ text run at (3,46) width 72: "\x{D834}\x{DD10}\x{D834}\x{DD10}\x{D834}\x{DD10}"
Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (91513 => 91514)
--- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 21:59:09 UTC (rev 91513)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 22:01:07 UTC (rev 91514)
@@ -1,5 +1,25 @@
2011-07-21 Lucas Forschler
+Merged 89769.
+
+2011-06-26 Dan Bernstein
+
+Reviewed by Darin Adler.
+
+With word-break: break-all, words do not break correctly before a surrogate pair
+https://bugs.webkit.org/show_bug.cgi?id=63401
+
+The code to check for mid-word breaks accumulates width one character at a time. It was actually
+measuring the two parts of the surrogate pair individually, so they appeared to have zero width.
+Fixed by checking for surrogate pairs and measuring the pair as one unit.
+
+Test: fast/text/midword-break-before-surrogate-pair.html
+
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::RenderBlock::LineBreaker::nextLineBreak):
+
+2011-07-21 Lucas Forschler
+
Merged 89595.
2011-06-23 Abhishek Arya
Modified: branches/safari-534.51-branch/Source/WebCore/rendering/RenderBlockLineLayout.cpp (91513 => 91514)
--- branches/safari-534.51-branch/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2011-07-21 21:59:09 UTC (rev 91513)
+++ branches/safari-534.51-branch/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2011-07-21 22:01:07 UTC (rev 91514)
@@ -2080,9 +2080,11 @@
currentCharacterIsWS = currentCharacterIsSpace || (breakNBSP && c == noBreakSpace);
+bool midWordBreakIsBeforeSurrogatePair = false;
[webkit-changes] [91513] branches/safari-534.51-branch/Source/WebKit2
Title: [91513] branches/safari-534.51-branch/Source/WebKit2
Revision 91513
Author lforsch...@apple.com
Date 2011-07-21 14:59:09 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r89720.
Modified Paths
branches/safari-534.51-branch/Source/WebKit2/ChangeLog
branches/safari-534.51-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp
Diff
Modified: branches/safari-534.51-branch/Source/WebKit2/ChangeLog (91512 => 91513)
--- branches/safari-534.51-branch/Source/WebKit2/ChangeLog 2011-07-21 21:58:10 UTC (rev 91512)
+++ branches/safari-534.51-branch/Source/WebKit2/ChangeLog 2011-07-21 21:59:09 UTC (rev 91513)
@@ -1,5 +1,24 @@
2011-07-21 Lucas Forschler
+Merged 89720.
+
+2011-07-21 Lucas Forschler
+
+Reviewed by John Sullivan.
+
+Drag-and-drop tab in same window makes web process falsely report unresponsiveness
+https://bugs.webkit.org/show_bug.cgi?id=63369
+
+
+If the view becomes invisible, stop the responsiveness timer, because we might not get any
+messages that will cause it to stop (such as painting notifications since we don't paint
+when we're not visible).
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::viewStateDidChange):
+
+2011-07-21 Lucas Forschler
+
Merged 88667.
2011-06-13 Sam Weinig
Modified: branches/safari-534.51-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp (91512 => 91513)
--- branches/safari-534.51-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-07-21 21:58:10 UTC (rev 91512)
+++ branches/safari-534.51-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-07-21 21:59:09 UTC (rev 91513)
@@ -631,6 +631,13 @@
m_isVisible = isVisible;
m_drawingArea->visibilityDidChange();
m_drawingArea->setPageIsVisible(isVisible);
+
+if (!m_isVisible) {
+// If we've started the responsiveness timer as part of telling the web process to update the backing store
+// state, it might not send back a reply (since it won't paint anything if the web page is hidden) so we
+// stop the unresponsiveness timer here.
+process()->responsivenessTimer()->stop();
+}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91512] branches/safari-534.51-branch
Title: [91512] branches/safari-534.51-branch
Revision 91512
Author lforsch...@apple.com
Date 2011-07-21 14:58:10 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r89614.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/Source/_javascript_Core/ChangeLog
branches/safari-534.51-branch/Source/_javascript_Core/yarr/YarrInterpreter.cpp
branches/safari-534.51-branch/Source/_javascript_Core/yarr/YarrJIT.cpp
Added Paths
branches/safari-534.51-branch/LayoutTests/fast/regex/overflow-expected.txt
branches/safari-534.51-branch/LayoutTests/fast/regex/overflow.html
branches/safari-534.51-branch/LayoutTests/fast/regex/script-tests/overflow.js
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91511 => 91512)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:54:03 UTC (rev 91511)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:58:10 UTC (rev 91512)
@@ -1,5 +1,22 @@
2011-07-21 Lucas Forschler
+Merged 89614.
+
+2011-06-23 Gavin Barraclough
+
+Reviewed by Oliver Hunt.
+
+https://bugs.webkit.org/show_bug.cgi?id=61585
+Crash running regexp /(?:(?=g))|(?:m).{2147483648,}/
+
+Add regression tests where an alterative has a size of ~2^31.
+
+* fast/regex/overflow-expected.txt: Added.
+* fast/regex/overflow.html: Added.
+* fast/regex/script-tests/overflow.js: Added.
+
+2011-07-21 Lucas Forschler
+
Merged 89595.
2011-06-23 Abhishek Arya
Copied: branches/safari-534.51-branch/LayoutTests/fast/regex/overflow-expected.txt (from rev 89614, trunk/LayoutTests/fast/regex/overflow-expected.txt) (0 => 91512)
--- branches/safari-534.51-branch/LayoutTests/fast/regex/overflow-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/regex/overflow-expected.txt 2011-07-21 21:58:10 UTC (rev 91512)
@@ -0,0 +1,11 @@
+This test checks expressions with alternative lengths of appox. 2^31.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS regexp1.exec('') is null
+PASS regexp2.exec('') is null
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: branches/safari-534.51-branch/LayoutTests/fast/regex/overflow.html (from rev 89614, trunk/LayoutTests/fast/regex/overflow.html) (0 => 91512)
--- branches/safari-534.51-branch/LayoutTests/fast/regex/overflow.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/regex/overflow.html 2011-07-21 21:58:10 UTC (rev 91512)
@@ -0,0 +1,13 @@
+
+
+
+
+
+
+
+
[webkit-changes] [91511] branches/safari-534.51-branch
Title: [91511] branches/safari-534.51-branch
Revision 91511
Author lforsch...@apple.com
Date 2011-07-21 14:54:03 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r89595.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/css/MediaQueryEvaluator.cpp
branches/safari-534.51-branch/Source/WebCore/css/MediaQueryEvaluator.h
Added Paths
branches/safari-534.51-branch/LayoutTests/fast/css/media-query-evaluator-crash-expected.txt
branches/safari-534.51-branch/LayoutTests/fast/css/media-query-evaluator-crash.html
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91510 => 91511)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:53:12 UTC (rev 91510)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:54:03 UTC (rev 91511)
@@ -1,5 +1,19 @@
2011-07-21 Lucas Forschler
+Merged 89595.
+
+2011-06-23 Abhishek Arya
+
+Reviewed by Adam Barth.
+
+Tests that we do not crash when doing a media query match.
+https://bugs.webkit.org/show_bug.cgi?id=63264
+
+* fast/css/media-query-evaluator-crash-expected.txt: Added.
+* fast/css/media-query-evaluator-crash.html: Added.
+
+2011-07-21 Lucas Forschler
+
Merged 89492.
2011-06-22 Annie Sullivan
Copied: branches/safari-534.51-branch/LayoutTests/fast/css/media-query-evaluator-crash-expected.txt (from rev 89595, trunk/LayoutTests/fast/css/media-query-evaluator-crash-expected.txt) (0 => 91511)
--- branches/safari-534.51-branch/LayoutTests/fast/css/media-query-evaluator-crash-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/css/media-query-evaluator-crash-expected.txt 2011-07-21 21:54:03 UTC (rev 91511)
@@ -0,0 +1 @@
+Test passes if it does not crash.
Copied: branches/safari-534.51-branch/LayoutTests/fast/css/media-query-evaluator-crash.html (from rev 89595, trunk/LayoutTests/fast/css/media-query-evaluator-crash.html) (0 => 91511)
--- branches/safari-534.51-branch/LayoutTests/fast/css/media-query-evaluator-crash.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/css/media-query-evaluator-crash.html 2011-07-21 21:54:03 UTC (rev 91511)
@@ -0,0 +1,12 @@
+
+Test passes if it does not crash.
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var iframe = document.getElementById("test");
+var obj = iframe.contentWindow.matchMedia("(min-width: 0em)");
+
+
+
Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (91510 => 91511)
--- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 21:53:12 UTC (rev 91510)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 21:54:03 UTC (rev 91511)
@@ -1,5 +1,23 @@
2011-07-21 Lucas Forschler
+Merged 89595.
+
+2011-06-23 Abhishek Arya
+
+Reviewed by Adam Barth.
+
+RefPtr m_style in MediaQueryEvaluator in case of callers like
+MediaQueryMatcher::prepareEvaluator that do not retain its reference.
+https://bugs.webkit.org/show_bug.cgi?id=63264
+
+Test: fast/css/media-query-evaluator-crash.html
+
+* css/MediaQueryEvaluator.cpp:
+(WebCore::MediaQueryEvaluator::eval):
+* css/MediaQueryEvaluator.h:
+
+2011-07-21 Lucas Forschler
+
Merged 89492.
2011-06-22 Annie Sullivan
Modified: branches/safari-534.51-branch/Source/WebCore/css/MediaQueryEvaluator.cpp (91510 => 91511)
--- branches/safari-534.51-branch/Source/WebCore/css/MediaQueryEvaluator.cpp 2011-07-21 21:53:12 UTC (rev 91510)
+++ branches/safari-534.51-branch/Source/WebCore/css/MediaQueryEvaluator.cpp 2011-07-21 21:54:03 UTC (rev 91511)
@@ -532,7 +532,7 @@
// used
EvalFunc func = gFunctionMap->get(expr->mediaFeature().impl());
if (func)
-return func(expr->value(), m_style, m_frame, NoPrefix);
+return func(expr->value(), m_style.get(), m_frame, NoPrefix);
return false;
}
Modified: branches/safari-534.51-branch/Source/WebCore/css/MediaQueryEvaluator.h (91510 => 91511)
--- branches/safari-534.51-branch/Source/WebCore/css/MediaQueryEvaluator.h 2011-07-21 21:53:12 UTC (rev 91510)
+++ branches/safari-534.51-branch/Source/WebCore/css/MediaQueryEvaluator.h 2011-07-21 21:54:03 UTC (rev 91511)
@@ -83,7 +83,7 @@
private:
String m_mediaType;
Frame* m_frame; // not owned
-RenderStyle* m_style; // not owned
+RefPtr m_style;
bool m_expResult;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91510] trunk/Source/WebKit/chromium
Title: [91510] trunk/Source/WebKit/chromium
Revision 91510
Author c...@chromium.org
Date 2011-07-21 14:53:12 -0700 (Thu, 21 Jul 2011)
Log Message
2011-07-20 Cris Neckar
Hook v8 up to cryptographicallyRandomValues as an entropy source.
https://bugs.webkit.org/show_bug.cgi?id=64887
Reviewed by Adam Barth.
* src/WebKit.cpp:
(WebKit::generateEntropy):
(WebKit::initialize):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebKit.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (91509 => 91510)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-07-21 21:50:10 UTC (rev 91509)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-07-21 21:53:12 UTC (rev 91510)
@@ -1,3 +1,14 @@
+2011-07-20 Cris Neckar
+
+Hook v8 up to cryptographicallyRandomValues as an entropy source.
+https://bugs.webkit.org/show_bug.cgi?id=64887
+
+Reviewed by Adam Barth.
+
+* src/WebKit.cpp:
+(WebKit::generateEntropy):
+(WebKit::initialize):
+
2011-07-21 Vsevolod Vlasov
[Chromium DevTools] Remove unused method setAgentIdentifierPrefix from WebDevToolAgent.
Modified: trunk/Source/WebKit/chromium/src/WebKit.cpp (91509 => 91510)
--- trunk/Source/WebKit/chromium/src/WebKit.cpp 2011-07-21 21:50:10 UTC (rev 91509)
+++ trunk/Source/WebKit/chromium/src/WebKit.cpp 2011-07-21 21:53:12 UTC (rev 91510)
@@ -37,6 +37,7 @@
#include "Settings.h"
#include "TextEncoding.h"
#include "V8Binding.h"
+#include "WebKitClient.h"
#include "WebMediaPlayerClientImpl.h"
#include "WebSocket.h"
#include "WorkerContextExecutionProxy.h"
@@ -55,6 +56,15 @@
static WebKitClient* s_webKitClient = 0;
static bool s_layoutTestMode = false;
+static bool generateEntropy(unsigned char* buffer, size_t length)
+{
+if (s_webKitClient) {
+s_webKitClient->cryptographicallyRandomValues(buffer, length);
+return true;
+}
+return false;
+}
+
void initialize(WebKitClient* webKitClient)
{
ASSERT(!s_webKitInitialized);
@@ -77,6 +87,7 @@
// this, initializing this lazily probably doesn't buy us much.
WebCore::UTF8Encoding();
+v8::V8::SetEntropySource(&generateEntropy);
v8::V8::Initialize();
WebCore::V8BindingPerIsolateData::ensureInitialized(v8::Isolate::GetCurrent());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91509] branches/safari-534.51-branch
Title: [91509] branches/safari-534.51-branch
Revision 91509
Author lforsch...@apple.com
Date 2011-07-21 14:50:10 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r89492.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp
Added Paths
branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-before-br-in-span-expected.txt
branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-before-br-in-span.html
branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-middle-of-span-expected.txt
branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-middle-of-span.html
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91508 => 91509)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:48:32 UTC (rev 91508)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:50:10 UTC (rev 91509)
@@ -1,5 +1,24 @@
2011-07-21 Lucas Forschler
+Merged 89492.
+
+2011-06-22 Annie Sullivan
+
+Reviewed by Ryosuke Niwa.
+
+REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
+https://bugs.webkit.org/show_bug.cgi?id=61594
+
+Adds two layout tests to verify that hitting enter in the middle of the span splits the span correctly
+and places the cursor in the correct position.
+
+* editing/inserting/return-key-before-br-in-span-expected.txt: Added.
+* editing/inserting/return-key-before-br-in-span.html: Added.
+* editing/inserting/return-key-middle-of-span-expected.txt: Added.
+* editing/inserting/return-key-middle-of-span.html: Added.
+
+2011-07-21 Lucas Forschler
+
Merged 89474.
2011-06-22 Matthew Delaney
Copied: branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-before-br-in-span-expected.txt (from rev 89492, trunk/LayoutTests/editing/inserting/return-key-before-br-in-span-expected.txt) (0 => 91509)
--- branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-before-br-in-span-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-before-br-in-span-expected.txt 2011-07-21 21:50:10 UTC (rev 91509)
@@ -0,0 +1,10 @@
+This sets the selection to the end of the first line, and hits the enter key.
+Expected behavior: a div is created around the second line, and the cursor is placed at the start of the second line. See bug 61594.
+|
+| id="wrapper"
+| "First line"
+|
+|
+| <#selection-caret>
+|
+| "Second line"
Copied: branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-before-br-in-span.html (from rev 89492, trunk/LayoutTests/editing/inserting/return-key-before-br-in-span.html) (0 => 91509)
--- branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-before-br-in-span.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-before-br-in-span.html 2011-07-21 21:50:10 UTC (rev 91509)
@@ -0,0 +1,15 @@
+
+
+
+First lineSecond line
+
+Markup.description("This sets the selection to the end of the first line, and hits the enter key.\n"
++ "Expected behavior: a div is created around the second line, and the cursor is placed at the "
++ "start of the second line. See bug 61594.");
+var sel = window.getSelection();
+sel.setPosition(document.getElementById("wrapper"), 1);
+document.execCommand("InsertParagraph", false, null);
+Markup.dump(root);
+
+
Copied: branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-middle-of-span-expected.txt (from rev 89492, trunk/LayoutTests/editing/inserting/return-key-middle-of-span-expected.txt) (0 => 91509)
--- branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-middle-of-span-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-middle-of-span-expected.txt 2011-07-21 21:50:10 UTC (rev 91509)
@@ -0,0 +1,10 @@
+This sets the selection to the middle of the first line, and hits the enter key.
+Expected behavior: the text node is split at the cursor. The span is cloned, and everything that was split out is placed inside the clone in a new div which is a child of the root. See bug 61594.
+|
+| id="wrapper"
+| "First"
+|
+|
+| "<#selection-caret> line"
+|
+| "Second line"
Copied: branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-middle-of-span.html (from rev 89492, trunk/LayoutTests/editing/inserting/return-key-middle-of-span.html) (0 => 91509)
--- branches/safari-534.51-branch/LayoutTests/editing/inserting/return-key-middle-of-span.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/editing/inserting/return-
[webkit-changes] [91508] trunk/Tools
Title: [91508] trunk/Tools
Revision 91508
Author e...@webkit.org
Date 2011-07-21 14:48:32 -0700 (Thu, 21 Jul 2011)
Log Message
Unreviewed. Reenable ORWT for the --leaks bot.
Something is still wrong with the leaks summarizing
but I'm about to head out on vacation for 2 weeks,
so it's best to just revert back to ORWT until I'm back.
* Scripts/run-webkit-tests:
(usingLeaks):
(useNewRunWebKitTests):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-tests
Diff
Modified: trunk/Tools/ChangeLog (91507 => 91508)
--- trunk/Tools/ChangeLog 2011-07-21 21:48:27 UTC (rev 91507)
+++ trunk/Tools/ChangeLog 2011-07-21 21:48:32 UTC (rev 91508)
@@ -1,3 +1,14 @@
+2011-07-21 Eric Seidel
+
+Unreviewed. Reenable ORWT for the --leaks bot.
+Something is still wrong with the leaks summarizing
+but I'm about to head out on vacation for 2 weeks,
+so it's best to just revert back to ORWT until I'm back.
+
+* Scripts/run-webkit-tests:
+(usingLeaks):
+(useNewRunWebKitTests):
+
2011-07-21 Ojan Vafai
cleanup jsonresults.py style in preparation for making some changes
Modified: trunk/Tools/Scripts/run-webkit-tests (91507 => 91508)
--- trunk/Tools/Scripts/run-webkit-tests 2011-07-21 21:48:27 UTC (rev 91507)
+++ trunk/Tools/Scripts/run-webkit-tests 2011-07-21 21:48:32 UTC (rev 91508)
@@ -65,6 +65,13 @@
return grep(/(-2|--webkit-test-runner)/, @ARGV);
}
+sub usingLeaks()
+{
+# NRWT doesn't support --leaks yet.
+# https://bugs.webkit.org/show_bug.cgi?id=63832
+return grep(/--leaks/, @ARGV);
+}
+
sub useNewRunWebKitTests()
{
# Change this check to control which platforms use new-run-webkit-tests by default.
@@ -82,7 +89,7 @@
return (!usingWebKit2() and !isDarwin() and !isARM() and (getQtVersion() ne "4.8"));
}
-return ((isLeopard() or isSnowLeopard() or isGtk()) and !usingWebKit2());
+return ((isLeopard() or isSnowLeopard() or isGtk()) and !usingWebKit2() and !usingLeaks());
}
my $harnessName = "old-run-webkit-tests";
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91507] branches/safari-534.51-branch
Title: [91507] branches/safari-534.51-branch
Revision 91507
Author lforsch...@apple.com
Date 2011-07-21 14:48:27 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r89474.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
branches/safari-534.51-branch/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html
branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/
branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png
branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt
Removed Paths
branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png
branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91506 => 91507)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:46:43 UTC (rev 91506)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:48:27 UTC (rev 91507)
@@ -1,5 +1,21 @@
2011-07-21 Lucas Forschler
+Merged 89474.
+
+2011-06-22 Matthew Delaney
+
+Reviewed by Oliver Hunt.
+
+Canvas in layer obscures overlapping span
+https://bugs.webkit.org/show_bug.cgi?id=63161
+
+* compositing/layer-creation/spanOverlapsCanvas.html: Added.
+* platform/mac/compositing/layer-creation: Added.
+* platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
+* platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
+
+2011-07-21 Lucas Forschler
+
Merged 89397.
2011-06-21 Matthew Delaney
Copied: branches/safari-534.51-branch/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html (from rev 89474, trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html) (0 => 91507)
--- branches/safari-534.51-branch/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html 2011-07-21 21:48:27 UTC (rev 91507)
@@ -0,0 +1,30 @@
+
+
+
+
+
+
+
+ window.layoutTestController && window.layoutTestController.layerTreeAsText();
+
+ function init() {
+ var ctx = document.getElementById("world").getContext("2d");
+ ctx.fillStyle = "red";
+ ctx.fillRect(0,0,ctx.canvas.width,ctx.canvas.height);
+ }
+
+
+
+#headerbar {
+width: 100px;
+height: 50px;
+background-color: green;
+position: absolute;
+}
+
+
+
+
+
+
+
Deleted: branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png
(Binary files differ)
Copied: branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png (from rev 89474, trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png)
(Binary files differ)
Deleted: branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt (89474 => 91507)
--- trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt 2011-06-22 20:39:01 UTC (rev 89474)
+++ branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt 2011-07-21 21:48:27 UTC (rev 91507)
@@ -1,10 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x70
- RenderBlock {HTML} at (0,0) size 800x70
-RenderBody {BODY} at (8,8) size 784x54
- RenderText {#text} at (0,0) size 0x0
-layer at (8,8) size 100x50
- RenderHTMLCanvas {CANVAS} at (0,0) size 100x50
-layer at (8,8) size 100x50
- RenderBlock (positioned) {DIV} at (8,8) size 100x50 [bgcolor=#008000]
Copied: branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt (from rev 89474, trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt) (0 => 91507)
--- branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt 2011-07-21 21:48:27 UTC (rev 91507)
@@ -0,0 +1,10 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x70
+ RenderBlock {HTML} at (0,0) size 800x70
+RenderBody {BODY} at (8,8) size 784x54
+ RenderText {#text} at (0,0) size 0x0
+layer at (8,8) size 100
[webkit-changes] [91506] branches/safari-534.51-branch
Title: [91506] branches/safari-534.51-branch
Revision 91506
Author lforsch...@apple.com
Date 2011-07-21 14:46:43 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r89397.
Modified Paths
branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
Added Paths
branches/safari-534.51-branch/LayoutTests/fast/css/color-leakage.html
branches/safari-534.51-branch/LayoutTests/platform/mac/fast/css/color-leakage-expected.png
branches/safari-534.51-branch/LayoutTests/platform/mac/fast/css/color-leakage-expected.txt
Diff
Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91505 => 91506)
--- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:44:39 UTC (rev 91505)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:46:43 UTC (rev 91506)
@@ -1,5 +1,21 @@
2011-07-21 Lucas Forschler
+Merged 89397.
+
+2011-06-21 Matthew Delaney
+
+Reviewed by Simon Fraser.
+
+beginTransparencyLayer leaves context color out of sync, bleeds color into text
+https://bugs.webkit.org/show_bug.cgi?id=63093
+
+* fast/css/color-leakage.html: Added pixel regression test that previously would have the
+ border's color spilling into the text.
+* platform/mac/fast/css/color-leakage-expected.png: Added.
+* platform/mac/fast/css/color-leakage-expected.txt: Added.
+
+2011-07-21 Lucas Forschler
+
Merged 89313.
2011-06-20 Tim Horton
Copied: branches/safari-534.51-branch/LayoutTests/fast/css/color-leakage.html (from rev 89397, trunk/LayoutTests/fast/css/color-leakage.html) (0 => 91506)
--- branches/safari-534.51-branch/LayoutTests/fast/css/color-leakage.html (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/fast/css/color-leakage.html 2011-07-21 21:46:43 UTC (rev 91506)
@@ -0,0 +1,25 @@
+
+
+
+
+ @font-face {
+font-family: 'Ahem';
+src: url('resources/Ahem.ttf');
+ }
+ div {
+display: block;
+font-family: Ahem;
+font-size: 30px;
+color: black;
+border-top: 5px solid blue;
+border-bottom: 5px solid rgba(0,0,0,0.9);
+width: 650px;
+ }
+
+
+
+
+This should be black.
+
+
+
Copied: branches/safari-534.51-branch/LayoutTests/platform/mac/fast/css/color-leakage-expected.png (from rev 89397, trunk/LayoutTests/platform/mac/fast/css/color-leakage-expected.png)
(Binary files differ)
Copied: branches/safari-534.51-branch/LayoutTests/platform/mac/fast/css/color-leakage-expected.txt (from rev 89397, trunk/LayoutTests/platform/mac/fast/css/color-leakage-expected.txt) (0 => 91506)
--- branches/safari-534.51-branch/LayoutTests/platform/mac/fast/css/color-leakage-expected.txt (rev 0)
+++ branches/safari-534.51-branch/LayoutTests/platform/mac/fast/css/color-leakage-expected.txt 2011-07-21 21:46:43 UTC (rev 91506)
@@ -0,0 +1,8 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 650x40 [border: (5px solid #FF) none (5px solid #00E6) none]
+RenderText {#text} at (0,5) size 630x30
+ text run at (0,5) width 630: "This should be black."
Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (91505 => 91506)
--- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 21:44:39 UTC (rev 91505)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 21:46:43 UTC (rev 91506)
@@ -1,5 +1,23 @@
2011-07-21 Lucas Forschler
+Merged 89397.
+
+2011-06-21 Matthew Delaney
+
+Reviewed by Simon Fraser.
+
+beginTransparencyLayer leaves context color out of sync, bleeds color into text
+https://bugs.webkit.org/show_bug.cgi?id=63093
+
+Test: fast/css/color-leakage.html
+
+* platform/graphics/cg/GraphicsContextCG.cpp: Swap out CGContextSave/Restore with
+GraphicsContext::save/restore to keep the context in sync with its CG context
+(WebCore::GraphicsContext::beginTransparencyLayer): Added save(), removed redundant calls.
+(WebCore::GraphicsContext::endTransparencyLayer): Added restore(), removed redundant calls.
+
+2011-07-21 Lucas Forschler
+
Merged 89313.
2011-06-20 Tim Horton
Modified: branches/safari-534.51-branch/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (91505 => 91506)
--- branches/safari-534.51-branch/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2011-07-21 21:44:39 UTC (rev 91505)
+++ branches/safari-534.51-branch/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2011-07-21 21:46:43 UTC (rev 91506)
@@ -893,8 +893,10 @@
{
if (paintingDisabled())
return;
+
+s
[webkit-changes] [91504] trunk
Title: [91504] trunk
Revision 91504
Author k...@google.com
Date 2011-07-21 14:43:10 -0700 (Thu, 21 Jul 2011)
Log Message
Update webglcontextlost / webglcontextrestored delivery to match spec changes
https://bugs.webkit.org/show_bug.cgi?id=58621
Reviewed by James Robinson.
Source/WebCore:
Updated conditions under which webglcontextrestored event is
delivered to be spec compliant.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::loseContext):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
* html/canvas/WebGLRenderingContext.h:
LayoutTests:
Updated layout test to test spec compliant behavior.
* fast/canvas/webgl/context-lost-restored-expected.txt:
* fast/canvas/webgl/context-lost-restored.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/webgl/context-lost-restored-expected.txt
trunk/LayoutTests/fast/canvas/webgl/context-lost-restored.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.h
Diff
Modified: trunk/LayoutTests/ChangeLog (91503 => 91504)
--- trunk/LayoutTests/ChangeLog 2011-07-21 21:42:51 UTC (rev 91503)
+++ trunk/LayoutTests/ChangeLog 2011-07-21 21:43:10 UTC (rev 91504)
@@ -1,3 +1,15 @@
+2011-07-21 Kenneth Russell
+
+Update webglcontextlost / webglcontextrestored delivery to match spec changes
+https://bugs.webkit.org/show_bug.cgi?id=58621
+
+Reviewed by James Robinson.
+
+Updated layout test to test spec compliant behavior.
+
+* fast/canvas/webgl/context-lost-restored-expected.txt:
+* fast/canvas/webgl/context-lost-restored.html:
+
2011-07-21 Ryosuke Niwa
Chromium rebaselines after r91493.
Modified: trunk/LayoutTests/fast/canvas/webgl/context-lost-restored-expected.txt (91503 => 91504)
--- trunk/LayoutTests/fast/canvas/webgl/context-lost-restored-expected.txt 2011-07-21 21:42:51 UTC (rev 91503)
+++ trunk/LayoutTests/fast/canvas/webgl/context-lost-restored-expected.txt 2011-07-21 21:43:10 UTC (rev 91504)
@@ -40,6 +40,7 @@
PASS gl.useProgram(program) was expected value: NO_ERROR.
PASS gl.bindBuffer(gl.ARRAY_BUFFER, bufferObjects[0]) was expected value: NO_ERROR.
+PASS extension.restoreContext() was expected value: NO_ERROR.
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/canvas/webgl/context-lost-restored.html (91503 => 91504)
--- trunk/LayoutTests/fast/canvas/webgl/context-lost-restored.html 2011-07-21 21:42:51 UTC (rev 91503)
+++ trunk/LayoutTests/fast/canvas/webgl/context-lost-restored.html 2011-07-21 21:43:10 UTC (rev 91504)
@@ -15,6 +15,7 @@
var program;
var texture;
var texColor = [255, 10, 20, 255];
+var allowRestore;
function init()
{
@@ -58,10 +59,11 @@
debug("Test losing a context and inability to restore it.");
canvas.addEventListener("webglcontextlost", testLostContext);
+canvas.addEventListener("webglcontextrestored", testShouldNotRestoreContext);
+allowRestore = false;
testOriginalContext();
extension.loseContext();
-// FIXME: this isn't yet spec compliant.
shouldGenerateGLError(gl, gl.INVALID_OPERATION, "extension.restoreContext()");
debug("");
}
@@ -75,10 +77,11 @@
canvas.addEventListener("webglcontextlost", testLostContext);
canvas.addEventListener("webglcontextrestored", testRestoredContext);
+allowRestore = true;
testOriginalContext();
extension.loseContext();
-extension.restoreContext();
+shouldGenerateGLError(gl, gl.NO_ERROR, "extension.restoreContext()");
debug("");
}
@@ -110,15 +113,23 @@
debug("");
}
-function testLostContext()
+function testLostContext(e)
{
debug("Test lost context");
shouldBeTrue("gl.isContextLost()");
shouldBe("gl.getError()", "gl.CONTEXT_LOST_WEBGL");
shouldBe("gl.getError()", "gl.NO_ERROR");
debug("");
+if (allowRestore)
+e.preventDefault();
}
+function testShouldNotRestoreContext(e)
+{
+testFailed("Should not restore the context unless preventDefault is called on the context lost event");
+debug("");
+}
+
function testResources(expected)
{
var tests = [
Modified: trunk/Source/WebCore/ChangeLog (91503 => 91504)
--- trunk/Source/WebCore/ChangeLog 2011-07-21 21:42:51 UTC (rev 91503)
+++ trunk/Source/WebCore/ChangeLog 2011-07-21 21:43:10 UTC (rev 91504)
@@ -1,3 +1,19 @@
+2011-07-21 Kenneth Russell
+
+Update webglcontextlost / webglcontextrestored delivery to match spec changes
+https://bugs.webkit.org/show_bug.cgi?id=58621
+
+Reviewed by James Robinson.
+
+Updated conditions under which webglcontextrestored event is
+delivered to be spec compliant.
+
+* html/canvas/WebGLRenderingContext.cpp:
+(WebCore::WebGLRenderingContext::WebGLRenderingContext):
+(WebCore::WebGLRenderingContext::loseContext):
[webkit-changes] [91503] branches/safari-534.51-branch
Title: [91503] branches/safari-534.51-branch Revision 91503 Author lforsch...@apple.com Date 2011-07-21 14:42:51 -0700 (Thu, 21 Jul 2011) Log Message Merge r89165. Modified Paths branches/safari-534.51-branch/LayoutTests/ChangeLog branches/safari-534.51-branch/Source/WebCore/ChangeLog branches/safari-534.51-branch/Source/WebCore/rendering/RenderBlock.cpp branches/safari-534.51-branch/Source/WebCore/rendering/RenderBlock.h Added Paths branches/safari-534.51-branch/LayoutTests/fast/block/float/float-not-removed-from-next-sibling5-expected.txt branches/safari-534.51-branch/LayoutTests/fast/block/float/float-not-removed-from-next-sibling5.html Diff Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91502 => 91503) --- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:38:56 UTC (rev 91502) +++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:42:51 UTC (rev 91503) @@ -1,5 +1,20 @@ 2011-07-21 Lucas Forschler +Merged 89165. + +2011-06-17 Abhishek Arya + +Reviewed by Dave Hyatt. + +Tests that we do not crash when unable to remove floats from +parent's next siblings blocks. +https://bugs.webkit.org/show_bug.cgi?id=62875 + +* fast/block/float/float-not-removed-from-next-sibling5-expected.txt: Added. +* fast/block/float/float-not-removed-from-next-sibling5.html: Added. + +2011-07-21 Lucas Forschler + Merged 88987. 2011-06-15 Abhishek Arya Copied: branches/safari-534.51-branch/LayoutTests/fast/block/float/float-not-removed-from-next-sibling5-expected.txt (from rev 89165, trunk/LayoutTests/fast/block/float/float-not-removed-from-next-sibling5-expected.txt) (0 => 91503) --- branches/safari-534.51-branch/LayoutTests/fast/block/float/float-not-removed-from-next-sibling5-expected.txt (rev 0) +++ branches/safari-534.51-branch/LayoutTests/fast/block/float/float-not-removed-from-next-sibling5-expected.txt 2011-07-21 21:42:51 UTC (rev 91503) @@ -0,0 +1,4 @@ +Test passes if it does not crash. +A A + + Copied: branches/safari-534.51-branch/LayoutTests/fast/block/float/float-not-removed-from-next-sibling5.html (from rev 89165, trunk/LayoutTests/fast/block/float/float-not-removed-from-next-sibling5.html) (0 => 91503) --- branches/safari-534.51-branch/LayoutTests/fast/block/float/float-not-removed-from-next-sibling5.html (rev 0) +++ branches/safari-534.51-branch/LayoutTests/fast/block/float/float-not-removed-from-next-sibling5.html 2011-07-21 21:42:51 UTC (rev 91503) @@ -0,0 +1,26 @@ + +Test passes if it does not crash. + + + + + + + + +A A + + + + +if (window.layoutTestController) +layoutTestController.dumpAsText(); + +document.body.offsetTop; +test3.style.position = 'absolute'; +test2.style.position = 'absolute'; +document.body.offsetTop; +test1.style.height = '1'; +test2.style.display = 'none'; + + Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (91502 => 91503) --- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 21:38:56 UTC (rev 91502) +++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 21:42:51 UTC (rev 91503) @@ -1,5 +1,25 @@ 2011-07-21 Lucas Forschler +Merged 89165. + +2011-06-17 Abhishek Arya + +Reviewed by Dave Hyatt. + +When we lose ability to propagate floats, need to find topmost +parent with that overhanging float, and then iterate over its +sibling blocks to remove the float. +https://bugs.webkit.org/show_bug.cgi?id=62875 + +Test: fast/block/float/float-not-removed-from-next-sibling5.html + +* rendering/RenderBlock.cpp: +(WebCore::RenderBlock::styleDidChange): +(WebCore::RenderBlock::hasOverhangingFloat): +* rendering/RenderBlock.h: + +2011-07-21 Lucas Forschler + Merged 89067. 2011-06-16 Abhishek Arya Modified: branches/safari-534.51-branch/Source/WebCore/rendering/RenderBlock.cpp (91502 => 91503) --- branches/safari-534.51-branch/Source/WebCore/rendering/RenderBlock.cpp 2011-07-21 21:38:56 UTC (rev 91502) +++ branches/safari-534.51-branch/Source/WebCore/rendering/RenderBlock.cpp 2011-07-21 21:42:51 UTC (rev 91503) @@ -262,12 +262,33 @@ } // After our style changed, if we lose our ability to propagate floats into next sibling -// blocks, then we need to mark our descendants with floats for layout and clear all floats -// from next sibling blocks that exist in our floating objects list. See bug 56299. +// blocks, then we need to find the top most parent containing that overhanging float and +// then mark its descendants with floats for layout and clear all floats from its next +// sibling blocks that exist in our floating objects list. See bug 56299 and 62875. bool canPropagateFloatIntoSibling = !isFloatin
[webkit-changes] [91502] branches/safari-534.51-branch/Source/WebCore
Title: [91502] branches/safari-534.51-branch/Source/WebCore
Revision 91502
Author lforsch...@apple.com
Date 2011-07-21 14:38:56 -0700 (Thu, 21 Jul 2011)
Log Message
Merge r89067.
Modified Paths
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/dom/Document.cpp
Diff
Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (91501 => 91502)
--- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 21:37:16 UTC (rev 91501)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-07-21 21:38:56 UTC (rev 91502)
@@ -1,5 +1,22 @@
2011-07-21 Lucas Forschler
+Merged 89067.
+
+2011-06-16 Abhishek Arya
+
+Reviewed by Adam Barth.
+
+RefPtr frame since it can get removed in
+FrameLoader::finishedParsing.
+https://bugs.webkit.org/show_bug.cgi?id=62812
+
+Tests: already tested by fast/parser/document-write-into-initial-document.html.
+
+* dom/Document.cpp:
+(WebCore::Document::finishedParsing):
+
+2011-07-21 Lucas Forschler
+
Merged 88987.
2011-06-15 Abhishek Arya
Modified: branches/safari-534.51-branch/Source/WebCore/dom/Document.cpp (91501 => 91502)
--- branches/safari-534.51-branch/Source/WebCore/dom/Document.cpp 2011-07-21 21:37:16 UTC (rev 91501)
+++ branches/safari-534.51-branch/Source/WebCore/dom/Document.cpp 2011-07-21 21:38:56 UTC (rev 91502)
@@ -4259,7 +4259,7 @@
if (!m_documentTiming.domContentLoadedEventEnd)
m_documentTiming.domContentLoadedEventEnd = currentTime();
-if (Frame* f = frame()) {
+if (RefPtr f = frame()) {
// FrameLoader::finishedParsing() might end up calling Document::implicitClose() if all
// resource loads are complete. HTMLObjectElements can start loading their resources from
// post attach callbacks triggered by recalcStyle(). This means if we parse out an
@@ -4271,7 +4271,7 @@
f->loader()->finishedParsing();
-InspectorInstrumentation::domContentLoadedEventFired(f, url());
+InspectorInstrumentation::domContentLoadedEventFired(f.get(), url());
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [91501] branches/safari-534.51-branch
Title: [91501] branches/safari-534.51-branch Revision 91501 Author lforsch...@apple.com Date 2011-07-21 14:37:16 -0700 (Thu, 21 Jul 2011) Log Message Merge r88987. Modified Paths branches/safari-534.51-branch/LayoutTests/ChangeLog branches/safari-534.51-branch/Source/WebCore/ChangeLog branches/safari-534.51-branch/Source/WebCore/dom/Document.cpp Added Paths branches/safari-534.51-branch/LayoutTests/fast/dom/body-clone-link-decl-parent-crash-expected.txt branches/safari-534.51-branch/LayoutTests/fast/dom/body-clone-link-decl-parent-crash.html branches/safari-534.51-branch/LayoutTests/fast/dom/styled-clone-inline-style-decl-parent-crash-expected.txt branches/safari-534.51-branch/LayoutTests/fast/dom/styled-clone-inline-style-decl-parent-crash.html branches/safari-534.51-branch/LayoutTests/fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash-expected.txt branches/safari-534.51-branch/LayoutTests/fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html Diff Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (91500 => 91501) --- branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:34:36 UTC (rev 91500) +++ branches/safari-534.51-branch/LayoutTests/ChangeLog 2011-07-21 21:37:16 UTC (rev 91501) @@ -1,3 +1,22 @@ +2011-07-21 Lucas Forschler + +Merged 88987. + +2011-06-15 Abhishek Arya + +Reviewed by Antti Koivisto. + +Tests that accessing the parent stylesheet in nodes (not in document) +do not result in crash when document is cleared. +https://bugs.webkit.org/show_bug.cgi?id=62586 + +* fast/dom/body-clone-link-decl-parent-crash-expected.txt: Added. +* fast/dom/body-clone-link-decl-parent-crash.html: Added. +* fast/dom/styled-clone-inline-style-decl-parent-crash-expected.txt: Added. +* fast/dom/styled-clone-inline-style-decl-parent-crash.html: Added. +* fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash-expected.txt: Added. +* fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html: Added. + 2011-07-20 Lucas Forschler Merged 88601. Copied: branches/safari-534.51-branch/LayoutTests/fast/dom/body-clone-link-decl-parent-crash-expected.txt (from rev 88987, trunk/LayoutTests/fast/dom/body-clone-link-decl-parent-crash-expected.txt) (0 => 91501) --- branches/safari-534.51-branch/LayoutTests/fast/dom/body-clone-link-decl-parent-crash-expected.txt (rev 0) +++ branches/safari-534.51-branch/LayoutTests/fast/dom/body-clone-link-decl-parent-crash-expected.txt 2011-07-21 21:37:16 UTC (rev 91501) @@ -0,0 +1,5 @@ +Test passes if it does not crash. +PASS successfullyParsed is true + +TEST COMPLETE + Copied: branches/safari-534.51-branch/LayoutTests/fast/dom/body-clone-link-decl-parent-crash.html (from rev 88987, trunk/LayoutTests/fast/dom/body-clone-link-decl-parent-crash.html) (0 => 91501) --- branches/safari-534.51-branch/LayoutTests/fast/dom/body-clone-link-decl-parent-crash.html (rev 0) +++ branches/safari-534.51-branch/LayoutTests/fast/dom/body-clone-link-decl-parent-crash.html 2011-07-21 21:37:16 UTC (rev 91501) @@ -0,0 +1,28 @@ + + + + + +Test passes if it does not crash. + +