[webkit-changes] [92167] trunk
Title: [92167] trunk
Revision 92167
Author pfeld...@chromium.org
Date 2011-08-02 01:03:17 -0700 (Tue, 02 Aug 2011)
Log Message
Web Inspector: button + New style rule
https://bugs.webkit.org/show_bug.cgi?id=65409
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/styles/styles-add-new-rule.html
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
LayoutTests:
* inspector/styles/styles-add-new-rule-expected.txt: Added.
* inspector/styles/styles-add-new-rule.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Added Paths
trunk/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt
trunk/LayoutTests/inspector/styles/styles-add-new-rule.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92166 => 92167)
--- trunk/LayoutTests/ChangeLog 2011-08-02 03:47:48 UTC (rev 92166)
+++ trunk/LayoutTests/ChangeLog 2011-08-02 08:03:17 UTC (rev 92167)
@@ -1,3 +1,13 @@
+2011-08-01 Pavel Feldman pfeld...@google.com
+
+Web Inspector: button + New style rule
+https://bugs.webkit.org/show_bug.cgi?id=65409
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/styles/styles-add-new-rule-expected.txt: Added.
+* inspector/styles/styles-add-new-rule.html: Added.
+
2011-08-01 Anders Carlsson ander...@apple.com
Update Lion specific test results.
Added: trunk/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt (0 => 92167)
--- trunk/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt 2011-08-02 08:03:17 UTC (rev 92167)
@@ -0,0 +1,26 @@
+Tests that adding a new rule works after sitching nodes.
+
+Text
+After adding new rule (inspected):
+[expanded] element.style { ()
+font-size: 12px;
+
+ Matched CSS Rules
+[expanded] #inspected { (via inspector)
+
+[expanded] div { (user agent stylesheet)
+display: block;
+
+
+After adding new rule (other):
+[expanded] element.style { ()
+color: red;
+
+ Matched CSS Rules
+[expanded] #other { (via inspector)
+
+[expanded] div { (user agent stylesheet)
+display: block;
+
+
+
Property changes on: trunk/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/styles/styles-add-new-rule.html (0 => 92167)
--- trunk/LayoutTests/inspector/styles/styles-add-new-rule.html (rev 0)
+++ trunk/LayoutTests/inspector/styles/styles-add-new-rule.html 2011-08-02 08:03:17 UTC (rev 92167)
@@ -0,0 +1,54 @@
+html
+head
+script src=""
+script src=""
+script
+
+function test()
+{
+WebInspector.showPanel(elements);
+InspectorTest.selectNodeAndWaitForStyles(inspected, step1);
+
+var treeElement;
+
+function step1()
+{
+// Click add new rule
+document.getElementById(add-style-button-test-id).click();
+InspectorTest.selectNodeAndWaitForStyles(other, step2);
+}
+
+function step2() {
+// Click add new rule
+document.getElementById(add-style-button-test-id).click();
+InspectorTest.selectNodeAndWaitForStyles(inspected, step3);
+}
+
+function step3()
+{
+InspectorTest.addResult(After adding new rule (inspected):);
+InspectorTest.dumpSelectedElementStyles(true, false, true);
+InspectorTest.selectNodeAndWaitForStyles(other, step4);
+}
+
+function step4()
+{
+InspectorTest.addResult(After adding new rule (other):);
+InspectorTest.dumpSelectedElementStyles(true, false, true);
+InspectorTest.completeTest();
+}
+}
+
+/script
+/head
+
+body _onload_=runTest()
+p
+Tests that adding a new rule works after sitching nodes.
+/p
+
+div id=inspected style=font-size: 12pxText/div
+div id=other style=color:red/div
+
+/body
+/html
Property changes on: trunk/LayoutTests/inspector/styles/styles-add-new-rule.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (92166 => 92167)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 03:47:48 UTC (rev 92166)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 08:03:17 UTC (rev 92167)
@@ -1,3 +1,16 @@
+2011-08-01 Pavel Feldman pfeld...@google.com
+
+Web Inspector: button + New style rule
+https://bugs.webkit.org/show_bug.cgi?id=65409
+
+Reviewed by Yury Semikhatsky.
+
+Test: inspector/styles/styles-add-new-rule.html
+
+* inspector/front-end/StylesSidebarPane.js:
+(WebInspector.StylesSidebarPane):
+(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
+
2011-08-01 Luke Macpherson macpher...@chromium.org
[webkit-changes] [92171] trunk/Source/WebCore
Title: [92171] trunk/Source/WebCore
Revision 92171
Author pfeld...@chromium.org
Date 2011-08-02 02:25:06 -0700 (Tue, 02 Aug 2011)
Log Message
Web Inspector: _normalizeEventTypes (via console's monitorEvents) doesnt handle all events like 'search' and other atypical ones.
https://bugs.webkit.org/show_bug.cgi?id=65468
Reviewed by Yury Semikhatsky.
* inspector/InjectedScriptSource.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptSource.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (92170 => 92171)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 09:20:57 UTC (rev 92170)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 09:25:06 UTC (rev 92171)
@@ -1,5 +1,14 @@
2011-08-02 Pavel Feldman pfeld...@google.com
+Web Inspector: _normalizeEventTypes (via console's monitorEvents) doesnt handle all events like 'search' and other atypical ones.
+https://bugs.webkit.org/show_bug.cgi?id=65468
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/InjectedScriptSource.js:
+
+2011-08-02 Pavel Feldman pfeld...@google.com
+
Web Inspector: 404/errors should get a RED visual treatment so easier to identify.
https://bugs.webkit.org/show_bug.cgi?id=65471
Modified: trunk/Source/WebCore/inspector/InjectedScriptSource.js (92170 => 92171)
--- trunk/Source/WebCore/inspector/InjectedScriptSource.js 2011-08-02 09:20:57 UTC (rev 92170)
+++ trunk/Source/WebCore/inspector/InjectedScriptSource.js 2011-08-02 09:25:06 UTC (rev 92171)
@@ -661,16 +661,18 @@
_normalizeEventTypes: function(types)
{
if (typeof types === undefined)
-types = [ mouse, key, load, unload, abort, error, select, change, submit, reset, focus, blur, resize, scroll ];
+types = [ mouse, key, control, load, unload, abort, error, select, change, submit, reset, focus, blur, resize, scroll, search, devicemotion, deviceorientation ];
else if (typeof types === string)
types = [ types ];
var result = [];
for (var i = 0; i types.length; i++) {
if (types[i] === mouse)
-result.splice(0, 0, mousedown, mouseup, click, dblclick, mousemove, mouseover, mouseout);
+result.splice(0, 0, mousedown, mouseup, click, dblclick, mousemove, mouseover, mouseout, mousewheel);
else if (types[i] === key)
-result.splice(0, 0, keydown, keyup, keypress);
+result.splice(0, 0, keydown, keyup, keypress, textInput);
+else if (types[i] === control)
+result.splice(0, 0, resize, scroll, zoom, focus, blur, select, change, submit, reset);
else
result.push(types[i]);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92172] trunk/LayoutTests
Title: [92172] trunk/LayoutTests
Revision 92172
Author o...@webkit.org
Date 2011-08-02 02:47:10 -0700 (Tue, 02 Aug 2011)
Log Message
[Qt] Unreviewed gardening after r92127.
* platform/qt/editing/selection/4397952-expected.png: Updated.
* platform/qt/editing/selection/4397952-expected.txt: Updated.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/editing/selection/4397952-expected.png
trunk/LayoutTests/platform/qt/editing/selection/4397952-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (92171 => 92172)
--- trunk/LayoutTests/ChangeLog 2011-08-02 09:25:06 UTC (rev 92171)
+++ trunk/LayoutTests/ChangeLog 2011-08-02 09:47:10 UTC (rev 92172)
@@ -1,3 +1,10 @@
+2011-08-02 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Unreviewed gardening after r92127.
+
+* platform/qt/editing/selection/4397952-expected.png: Updated.
+* platform/qt/editing/selection/4397952-expected.txt: Updated.
+
2011-08-01 Pavel Feldman pfeld...@google.com
Web Inspector: button + New style rule
Modified: trunk/LayoutTests/platform/qt/editing/selection/4397952-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/qt/editing/selection/4397952-expected.txt (92171 => 92172)
--- trunk/LayoutTests/platform/qt/editing/selection/4397952-expected.txt 2011-08-02 09:25:06 UTC (rev 92171)
+++ trunk/LayoutTests/platform/qt/editing/selection/4397952-expected.txt 2011-08-02 09:47:10 UTC (rev 92172)
@@ -13,11 +13,11 @@
text run at (0,0) width 284: This tests caret movement across buttons.
text run at (284,0) width 327: The caret should be just after the second button.
RenderBlock {DIV} at (0,38) size 784x37
-RenderButton {INPUT} at (2,2) size 40x33 [color=#1B1918] [bgcolor=#C0C0C0]
+RenderButton {INPUT} at (2,2) size 40x33 [bgcolor=#C0C0C0]
RenderBlock (anonymous) at (6,6) size 28x21
RenderText at (0,0) size 28x21
text run at (0,0) width 28: Foo
-RenderButton {INPUT} at (46,2) size 37x33 [color=#1B1918] [bgcolor=#C0C0C0]
+RenderButton {INPUT} at (46,2) size 37x33 [bgcolor=#C0C0C0]
RenderBlock (anonymous) at (6,6) size 25x21
RenderText at (0,0) size 25x21
text run at (0,0) width 25: Bar
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92173] trunk/LayoutTests
Title: [92173] trunk/LayoutTests Revision 92173 Author ham...@chromium.org Date 2011-08-02 02:50:44 -0700 (Tue, 02 Aug 2011) Log Message Layout Test fast/text/international/bidi-mirror-he-ar.html is failing https://bugs.webkit.org/show_bug.cgi?id=65524 Just update test_expectations.txt * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92172 => 92173) --- trunk/LayoutTests/ChangeLog 2011-08-02 09:47:10 UTC (rev 92172) +++ trunk/LayoutTests/ChangeLog 2011-08-02 09:50:44 UTC (rev 92173) @@ -1,3 +1,12 @@ +2011-08-02 Shinichiro Hamaji ham...@chromium.org + +Layout Test fast/text/international/bidi-mirror-he-ar.html is failing +https://bugs.webkit.org/show_bug.cgi?id=65524 + +Just update test_expectations.txt + +* platform/chromium/test_expectations.txt: + 2011-08-02 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed gardening after r92127. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92172 => 92173) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 09:47:10 UTC (rev 92172) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 09:50:44 UTC (rev 92173) @@ -3665,3 +3665,7 @@ BUGWK65453 MAC : fast/css/outline-auto-empty-rects.html = IMAGE BUGWK65462 VISTA : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT + +// Just needs rebaselines? +BUGWK65524 WIN : fast/text/international/bidi-mirror-he-ar.html = IMAGE +BUGWK65524 WIN : fast/text/justify-ideograph-leading-expansion.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92174] trunk/LayoutTests
Title: [92174] trunk/LayoutTests Revision 92174 Author ham...@chromium.org Date 2011-08-02 03:49:51 -0700 (Tue, 02 Aug 2011) Log Message Chromium test_expectations.txt update for r92165 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92173 => 92174) --- trunk/LayoutTests/ChangeLog 2011-08-02 09:50:44 UTC (rev 92173) +++ trunk/LayoutTests/ChangeLog 2011-08-02 10:49:51 UTC (rev 92174) @@ -1,5 +1,11 @@ 2011-08-02 Shinichiro Hamaji ham...@chromium.org +Chromium test_expectations.txt update for r92165 + +* platform/chromium/test_expectations.txt: + +2011-08-02 Shinichiro Hamaji ham...@chromium.org + Layout Test fast/text/international/bidi-mirror-he-ar.html is failing https://bugs.webkit.org/show_bug.cgi?id=65524 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92173 => 92174) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 09:50:44 UTC (rev 92173) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 10:49:51 UTC (rev 92174) @@ -3669,3 +3669,10 @@ // Just needs rebaselines? BUGWK65524 WIN : fast/text/international/bidi-mirror-he-ar.html = IMAGE BUGWK65524 WIN : fast/text/justify-ideograph-leading-expansion.html = IMAGE + +// The expectations were modified by http://trac.webkit.org/changeset/92165 +// May just need rebaselines. +BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-1-expected.html +BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-3-expected.html +BUG_HAMAJI MAC : fast/forms/textarea-placeholder-visibility-1-expected.html +BUG_HAMAJI MAC : fast/forms/textarea-placeholder-visibility-2-expected.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92175] trunk/LayoutTests
Title: [92175] trunk/LayoutTests Revision 92175 Author o...@webkit.org Date 2011-08-02 03:57:53 -0700 (Tue, 02 Aug 2011) Log Message [Qt] Unreviewed gardening. Paint the Qt bot green. * platform/qt/Skipped: Skip failing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92174 => 92175) --- trunk/LayoutTests/ChangeLog 2011-08-02 10:49:51 UTC (rev 92174) +++ trunk/LayoutTests/ChangeLog 2011-08-02 10:57:53 UTC (rev 92175) @@ -1,3 +1,9 @@ +2011-08-02 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed gardening. Paint the Qt bot green. + +* platform/qt/Skipped: Skip failing tests. + 2011-08-02 Shinichiro Hamaji ham...@chromium.org Chromium test_expectations.txt update for r92165 Modified: trunk/LayoutTests/platform/qt/Skipped (92174 => 92175) --- trunk/LayoutTests/platform/qt/Skipped 2011-08-02 10:49:51 UTC (rev 92174) +++ trunk/LayoutTests/platform/qt/Skipped 2011-08-02 10:57:53 UTC (rev 92175) @@ -717,6 +717,11 @@ # https://bugs.webkit.org/show_bug.cgi?id=58396 http/tests/misc/favicon-loads-with-icon-loading-override.html +# Missing layoutTestController.setAlwaysAcceptCookies +http/tests/security/cookies/third-party-cookie-blocking-main-frame.html +http/tests/security/cookies/third-party-cookie-blocking-user-action.html +http/tests/security/cookies/third-party-cookie-blocking.html + # = # # Failing SVG tests # = # @@ -2229,3 +2234,12 @@ # https://bugs.webkit.org/show_bug.cgi?id=65364 http/tests/inspector/network/network-initiator.html http/tests/inspector/network/network-request-revision-content.html + +# [Qt]Web Inspector: http/tests/inspector/network/network-sidebar-width.html fails +# https://bugs.webkit.org/show_bug.cgi?id=65526 +http/tests/inspector/network/network-sidebar-width.html + +# Web Inspector: REGRESSION(r92105): It made 2 tests fail +# https://bugs.webkit.org/show_bug.cgi?id=65525 +inspector/debugger/scripts-panel.html +inspector/debugger/scripts-sorting.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92177] trunk/LayoutTests
Title: [92177] trunk/LayoutTests Revision 92177 Author o...@webkit.org Date 2011-08-02 04:06:03 -0700 (Tue, 02 Aug 2011) Log Message [Qt][Mac] Unreviewed gardening. Paint the Qt Snow Leopard bot green. * platform/qt-mac/Skipped: Skip a failing test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92176 => 92177) --- trunk/LayoutTests/ChangeLog 2011-08-02 11:00:53 UTC (rev 92176) +++ trunk/LayoutTests/ChangeLog 2011-08-02 11:06:03 UTC (rev 92177) @@ -1,5 +1,11 @@ 2011-08-02 Csaba Osztrogonác o...@webkit.org +[Qt][Mac] Unreviewed gardening. Paint the Qt Snow Leopard bot green. + +* platform/qt-mac/Skipped: Skip a failing test. + +2011-08-02 Csaba Osztrogonác o...@webkit.org + [Qt] Unreviewed gardening. * platform/qt/Skipped: Add comment after r92175. Modified: trunk/LayoutTests/platform/qt-mac/Skipped (92176 => 92177) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-08-02 11:00:53 UTC (rev 92176) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-08-02 11:06:03 UTC (rev 92177) @@ -5014,3 +5014,6 @@ editing/unsupported-content/table-delete-003.html editing/unsupported-content/table-type-after.html editing/unsupported-content/table-type-before.html + +# Qt specific result was added by r92163, but it fails on Qt-Mac platform +svg/custom/repaint-shadow.svg ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92178] trunk/LayoutTests
Title: [92178] trunk/LayoutTests Revision 92178 Author ham...@chromium.org Date 2011-08-02 05:02:10 -0700 (Tue, 02 Aug 2011) Log Message Fix malformed chromium test expectation introduced by r92173 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92177 => 92178) --- trunk/LayoutTests/ChangeLog 2011-08-02 11:06:03 UTC (rev 92177) +++ trunk/LayoutTests/ChangeLog 2011-08-02 12:02:10 UTC (rev 92178) @@ -1,3 +1,9 @@ +2011-08-02 Shinichiro Hamaji ham...@chromium.org + +Fix malformed chromium test expectation introduced by r92173 + +* platform/chromium/test_expectations.txt: + 2011-08-02 Csaba Osztrogonác o...@webkit.org [Qt][Mac] Unreviewed gardening. Paint the Qt Snow Leopard bot green. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92177 => 92178) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 11:06:03 UTC (rev 92177) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 12:02:10 UTC (rev 92178) @@ -3672,7 +3672,7 @@ // The expectations were modified by http://trac.webkit.org/changeset/92165 // May just need rebaselines. -BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-1-expected.html -BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-3-expected.html -BUG_HAMAJI MAC : fast/forms/textarea-placeholder-visibility-1-expected.html -BUG_HAMAJI MAC : fast/forms/textarea-placeholder-visibility-2-expected.html +BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-1-expected.html = TEXT +BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-3-expected.html = TEXT +BUG_HAMAJI MAC : fast/forms/textarea-placeholder-visibility-1-expected.html = TEXT +BUG_HAMAJI MAC : fast/forms/textarea-placeholder-visibility-2-expected.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92179] trunk/Source/WebKit/qt
Title: [92179] trunk/Source/WebKit/qt Revision 92179 Author o...@webkit.org Date 2011-08-02 05:13:07 -0700 (Tue, 02 Aug 2011) Log Message [Qt] Fix tst_QWebElement::render() API test https://bugs.webkit.org/show_bug.cgi?id=65243 Patch by Kristóf Kosztyó kosztyo.kris...@stud.u-szeged.hu on 2011-08-02 Reviewed by Csaba Osztrogonác. * tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail (tst_QWebElement::render): Modified Paths trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp Diff Modified: trunk/Source/WebKit/qt/ChangeLog (92178 => 92179) --- trunk/Source/WebKit/qt/ChangeLog 2011-08-02 12:02:10 UTC (rev 92178) +++ trunk/Source/WebKit/qt/ChangeLog 2011-08-02 12:13:07 UTC (rev 92179) @@ -1,5 +1,15 @@ 2011-08-02 Kristóf Kosztyó kosztyo.kris...@stud.u-szeged.hu +[Qt] Fix tst_QWebElement::render() API test +https://bugs.webkit.org/show_bug.cgi?id=65243 + +Reviewed by Csaba Osztrogonác. + +* tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail +(tst_QWebElement::render): + +2011-08-02 Kristóf Kosztyó kosztyo.kris...@stud.u-szeged.hu + [Qt] tst_QWebElement::style() fails because QWebElement::CascadedStyle doesn't work as expected https://bugs.webkit.org/show_bug.cgi?id=65244 Modified: trunk/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp (92178 => 92179) --- trunk/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp 2011-08-02 12:02:10 UTC (rev 92178) +++ trunk/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp 2011-08-02 12:13:07 UTC (rev 92179) @@ -989,6 +989,7 @@ imgs[0].render(painter1); painter1.end(); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65243, Continue); QVERIFY(image1 == testImage); // render image 2nd time to make sure that cached rendering works fine @@ -998,6 +999,7 @@ imgs[0].render(painter2); painter2.end(); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65243, Continue); QVERIFY(image2 == testImage); // compare table rendered through QWebElement::render to whole page table rendering @@ -1034,6 +1036,9 @@ #endif painter.end(); +// The first chunk in this test is passing, but the others are failing +if (x 0) +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65243, Continue); QVERIFY(chunk == image4.copy(chunkPaintRect)); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92180] trunk/Source/WebKit/qt
Title: [92180] trunk/Source/WebKit/qt Revision 92180 Author o...@webkit.org Date 2011-08-02 05:13:22 -0700 (Tue, 02 Aug 2011) Log Message [Qt] Fix tst_QWebFrame::connectAndDisconnect() API test https://bugs.webkit.org/show_bug.cgi?id=65170 Patch by Kristóf Kosztyó kosztyo.kris...@stud.u-szeged.hu on 2011-08-02 Reviewed by Csaba Osztrogonác. * tests/qwebframe/tst_qwebframe.cpp: Mark failing test case as expected fail (tst_QWebFrame::connectAndDisconnect): Modified Paths trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp Diff Modified: trunk/Source/WebKit/qt/ChangeLog (92179 => 92180) --- trunk/Source/WebKit/qt/ChangeLog 2011-08-02 12:13:07 UTC (rev 92179) +++ trunk/Source/WebKit/qt/ChangeLog 2011-08-02 12:13:22 UTC (rev 92180) @@ -1,5 +1,15 @@ 2011-08-02 Kristóf Kosztyó kosztyo.kris...@stud.u-szeged.hu +[Qt] Fix tst_QWebFrame::connectAndDisconnect() API test +https://bugs.webkit.org/show_bug.cgi?id=65170 + +Reviewed by Csaba Osztrogonác. + +* tests/qwebframe/tst_qwebframe.cpp: Mark failing test case as expected fail +(tst_QWebFrame::connectAndDisconnect): + +2011-08-02 Kristóf Kosztyó kosztyo.kris...@stud.u-szeged.hu + [Qt] Fix tst_QWebElement::render() API test https://bugs.webkit.org/show_bug.cgi?id=65243 Modified: trunk/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp (92179 => 92180) --- trunk/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp 2011-08-02 12:13:07 UTC (rev 92179) +++ trunk/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp 2011-08-02 12:13:22 UTC (rev 92180) @@ -1454,6 +1454,7 @@ QCOMPARE(evalJS(gotSignal), sTrue); QCOMPARE(evalJS(signalArgs.length == 0), sTrue); QCOMPARE(evalJS(signalSender),evalJS(myObject)); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65170, Continue); QCOMPARE(evalJS(slotThisObject == window), sTrue); evalJS(gotSignal = false); @@ -1559,6 +1560,7 @@ // one argument QCOMPARE(evalJS(myObject.mySignalWithIntArg.connect(myObject.mySlotWithIntArg)), sUndefined); m_myObject-resetQtFunctionInvoked(); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65170, Continue); QCOMPARE(evalJS(myObject.mySignalWithIntArg(123)), sUndefined); QCOMPARE(m_myObject-qtFunctionInvoked(), 21); QCOMPARE(m_myObject-qtFunctionActuals().size(), 1); @@ -1567,6 +1569,7 @@ QCOMPARE(evalJS(myObject.mySignalWithIntArg.connect(myObject.mySlotWithDoubleArg)), sUndefined); m_myObject-resetQtFunctionInvoked(); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65170, Continue); QCOMPARE(evalJS(myObject.mySignalWithIntArg(123)), sUndefined); QCOMPARE(m_myObject-qtFunctionInvoked(), 22); QCOMPARE(m_myObject-qtFunctionActuals().size(), 1); @@ -1575,6 +1578,7 @@ QCOMPARE(evalJS(myObject.mySignalWithIntArg.connect(myObject.mySlotWithStringArg)), sUndefined); m_myObject-resetQtFunctionInvoked(); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65170, Continue); QCOMPARE(evalJS(myObject.mySignalWithIntArg(123)), sUndefined); QCOMPARE(m_myObject-qtFunctionInvoked(), 23); QCOMPARE(m_myObject-qtFunctionActuals().size(), 1); @@ -1584,6 +1588,7 @@ // connecting to overloaded slot QCOMPARE(evalJS(myObject.mySignalWithIntArg.connect(myObject.myOverloadedSlot)), sUndefined); m_myObject-resetQtFunctionInvoked(); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65170, Continue); QCOMPARE(evalJS(myObject.mySignalWithIntArg(123)), sUndefined); QCOMPARE(m_myObject-qtFunctionInvoked(), 26); // double overload QCOMPARE(m_myObject-qtFunctionActuals().size(), 1); @@ -1592,6 +1597,7 @@ QCOMPARE(evalJS(myObject.mySignalWithIntArg.connect(myObject['myOverloadedSlot(int)'])), sUndefined); m_myObject-resetQtFunctionInvoked(); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65170, Continue); QCOMPARE(evalJS(myObject.mySignalWithIntArg(456)), sUndefined); QCOMPARE(m_myObject-qtFunctionInvoked(), 28); // int overload QCOMPARE(m_myObject-qtFunctionActuals().size(), 1); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92181] trunk/LayoutTests
Title: [92181] trunk/LayoutTests Revision 92181 Author ham...@chromium.org Date 2011-08-02 05:34:36 -0700 (Tue, 02 Aug 2011) Log Message Malformed chromium test expectation fix, again. Sorry for the spam... * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92180 => 92181) --- trunk/LayoutTests/ChangeLog 2011-08-02 12:13:22 UTC (rev 92180) +++ trunk/LayoutTests/ChangeLog 2011-08-02 12:34:36 UTC (rev 92181) @@ -1,5 +1,11 @@ 2011-08-02 Shinichiro Hamaji ham...@chromium.org +Malformed chromium test expectation fix, again. Sorry for the spam... + +* platform/chromium/test_expectations.txt: + +2011-08-02 Shinichiro Hamaji ham...@chromium.org + Fix malformed chromium test expectation introduced by r92173 * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92180 => 92181) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 12:13:22 UTC (rev 92180) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 12:34:36 UTC (rev 92181) @@ -3672,7 +3672,7 @@ // The expectations were modified by http://trac.webkit.org/changeset/92165 // May just need rebaselines. -BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-1-expected.html = TEXT -BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-3-expected.html = TEXT -BUG_HAMAJI MAC : fast/forms/textarea-placeholder-visibility-1-expected.html = TEXT -BUG_HAMAJI MAC : fast/forms/textarea-placeholder-visibility-2-expected.html = TEXT +BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-1.html = TEXT +BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-3.html = TEXT +BUG_HAMAJI MAC : fast/forms/textarea-placeholder-visibility-1.html = TEXT +BUG_HAMAJI MAC : fast/forms/textarea-placeholder-visibility-2.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92182] trunk/Source/WebKit/qt
Title: [92182] trunk/Source/WebKit/qt Revision 92182 Author o...@webkit.org Date 2011-08-02 05:38:12 -0700 (Tue, 02 Aug 2011) Log Message [Qt] Fix tst_QWebPage::viewModes() API test https://bugs.webkit.org/show_bug.cgi?id=65531 Patch by Kristóf Kosztyó kosztyo.kris...@stud.u-szeged.hu on 2011-08-02 Reviewed by Csaba Osztrogonác. * tests/qwebpage/tst_qwebpage.cpp: Mark failing test case as expected fail (tst_QWebPage::viewModes): Modified Paths trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp Diff Modified: trunk/Source/WebKit/qt/ChangeLog (92181 => 92182) --- trunk/Source/WebKit/qt/ChangeLog 2011-08-02 12:34:36 UTC (rev 92181) +++ trunk/Source/WebKit/qt/ChangeLog 2011-08-02 12:38:12 UTC (rev 92182) @@ -1,5 +1,15 @@ 2011-08-02 Kristóf Kosztyó kosztyo.kris...@stud.u-szeged.hu +[Qt] Fix tst_QWebPage::viewModes() API test +https://bugs.webkit.org/show_bug.cgi?id=65531 + +Reviewed by Csaba Osztrogonác. + +* tests/qwebpage/tst_qwebpage.cpp: Mark failing test case as expected fail +(tst_QWebPage::viewModes): + +2011-08-02 Kristóf Kosztyó kosztyo.kris...@stud.u-szeged.hu + [Qt] Fix tst_QWebFrame::connectAndDisconnect() API test https://bugs.webkit.org/show_bug.cgi?id=65170 Modified: trunk/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp (92181 => 92182) --- trunk/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp 2011-08-02 12:34:36 UTC (rev 92181) +++ trunk/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp 2011-08-02 12:38:12 UTC (rev 92182) @@ -493,12 +493,15 @@ m_page-setProperty(_q_viewMode, minimized); QVariant empty = m_page-mainFrame()-evaluateJavaScript(window.styleMedia.matchMedium(\(-webkit-view-mode)\)); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65531, Continue); QVERIFY(empty.type() == QVariant::Bool empty.toBool()); QVariant minimized = m_page-mainFrame()-evaluateJavaScript(window.styleMedia.matchMedium(\(-webkit-view-mode: minimized)\)); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65531, Continue); QVERIFY(minimized.type() == QVariant::Bool minimized.toBool()); QVariant maximized = m_page-mainFrame()-evaluateJavaScript(window.styleMedia.matchMedium(\(-webkit-view-mode: maximized)\)); +QEXPECT_FAIL(, https://bugs.webkit.org/show_bug.cgi?id=65531, Continue); QVERIFY(maximized.type() == QVariant::Bool !maximized.toBool()); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92183] trunk/Source
Title: [92183] trunk/Source
Revision 92183
Author commit-qu...@webkit.org
Date 2011-08-02 06:39:26 -0700 (Tue, 02 Aug 2011)
Log Message
Custom cursors cause the WebProcess to crash
https://bugs.webkit.org/show_bug.cgi?id=64802
Patch by Amruth Raj amruth...@motorola.com on 2011-08-02
Reviewed by Martin Robinson.
Source/WebCore:
* WebCore.exp.in:
Source/WebKit2:
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPCencode): In case of a NULL cursor image, encode a bool indicating that.
(CoreIPCdecode): Decode the image only if required.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92182 => 92183)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 12:38:12 UTC (rev 92182)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 13:39:26 UTC (rev 92183)
@@ -1,3 +1,12 @@
+2011-08-02 Amruth Raj amruth...@motorola.com
+
+Custom cursors cause the WebProcess to crash
+https://bugs.webkit.org/show_bug.cgi?id=64802
+
+Reviewed by Martin Robinson.
+
+* WebCore.exp.in:
+
2011-08-02 Pavel Feldman pfeld...@google.com
Web Inspector: _normalizeEventTypes (via console's monitorEvents) doesnt handle all events like 'search' and other atypical ones.
Modified: trunk/Source/WebCore/WebCore.exp.in (92182 => 92183)
--- trunk/Source/WebCore/WebCore.exp.in 2011-08-02 12:38:12 UTC (rev 92182)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-08-02 13:39:26 UTC (rev 92183)
@@ -748,6 +748,7 @@
__ZN7WebCore5Frame9nodeImageEPNS_4NodeE
__ZN7WebCore5Frame9scalePageEfRKNS_8IntPointE
__ZN7WebCore5FrameD1Ev
+__ZN7WebCore5Image9nullImageEv
__ZN7WebCore5Image12supportsTypeERKN3WTF6StringE
__ZN7WebCore5Image20loadPlatformResourceEPKc
__ZN7WebCore5Range10selectNodeEPNS_4NodeERi
Modified: trunk/Source/WebKit2/ChangeLog (92182 => 92183)
--- trunk/Source/WebKit2/ChangeLog 2011-08-02 12:38:12 UTC (rev 92182)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-02 13:39:26 UTC (rev 92183)
@@ -1,3 +1,14 @@
+2011-08-02 Amruth Raj amruth...@motorola.com
+
+Custom cursors cause the WebProcess to crash
+https://bugs.webkit.org/show_bug.cgi?id=64802
+
+Reviewed by Martin Robinson.
+
+* Shared/WebCoreArgumentCoders.cpp:
+(CoreIPCencode): In case of a NULL cursor image, encode a bool indicating that.
+(CoreIPCdecode): Decode the image only if required.
+
2011-08-01 Scott Graham scot...@chromium.org
REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
Modified: trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp (92182 => 92183)
--- trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp 2011-08-02 12:38:12 UTC (rev 92182)
+++ trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp 2011-08-02 13:39:26 UTC (rev 92183)
@@ -321,6 +321,12 @@
if (cursor.type() != Cursor::Custom)
return;
+if (cursor.image()-isNull()) {
+encoder-encodeBool(false); // There is no valid image being encoded.
+return;
+}
+
+encoder-encodeBool(true);
encodeImage(encoder, cursor.image());
encoder-encode(cursor.hotSpot());
}
@@ -344,6 +350,15 @@
return true;
}
+bool isValidImagePresent;
+if (!decoder-decode(isValidImagePresent))
+return false;
+
+if (!isValidImagePresent) {
+cursor = Cursor(Image::nullImage(), IntPoint());
+return true;
+}
+
RefPtrImage image;
if (!decodeImage(decoder, image))
return false;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92191] trunk/Tools
Title: [92191] trunk/Tools
Revision 92191
Author commit-qu...@webkit.org
Date 2011-08-02 08:25:33 -0700 (Tue, 02 Aug 2011)
Log Message
CSS Regions build bot should archive and upload output files
https://bugs.webkit.org/show_bug.cgi?id=65200
Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
in config.json, called upload that when set to true will force the upload to the buildmaster server.
The features argument is now taken into account when determining the name of the archive on the server. That
was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.
Patch by Alexandru Chiculita ach...@adobe.com on 2011-08-02
Reviewed by Adam Roben.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (92190 => 92191)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2011-08-02 15:18:31 UTC (rev 92190)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2011-08-02 15:25:33 UTC (rev 92191)
@@ -259,6 +259,7 @@
},
{ name: CSSRegions SnowLeopard Intel Release (Build), type: Build, builddir: cssregions-snowleopard-intel-release,
platform: mac-snowleopard, configuration: release, architectures: [x86_64], features: [css-regions, css-exclusions],
+ upload: true,
slavenames: [adobe-mac-slave1]
}
],
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (92190 => 92191)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-08-02 15:18:31 UTC (rev 92190)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-08-02 15:25:33 UTC (rev 92191)
@@ -131,13 +131,26 @@
class UploadBuiltProduct(transfer.FileUpload):
slavesrc = WithProperties(WebKitBuild/%(configuration)s.zip)
-masterdest = WithProperties(archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(got_revision)s.zip)
+masterdest = WithProperties(archives/%(fullPlatform)s-%(architecture)s-%(configuration)s%(extraFeatures)s/%(got_revision)s.zip,
+extraFeatures=lambda properties: UploadBuiltProduct.determineExtraFeatures(properties))
haltOnFailure = True
def __init__(self):
transfer.FileUpload.__init__(self, self.slavesrc, self.masterdest, mode=0644)
+@staticmethod
+def determineExtraFeatures(properties):
+if not properties.hasProperty(features):
+return ''
+features = properties.getProperty(features)
+if not len(features):
+return ''
+result = '-with-' + '-and-'.join(features)
+# Just to make sure no feature will add invalid chars, we allow only letters here.
+result = re.sub('[^a-zA-Z]', '-', result)
+return result
+
class DownloadBuiltProduct(transfer.FileDownload):
slavedest = WithProperties(WebKitBuild/%(configuration)s.zip)
mastersrc = WithProperties(archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(got_revision)s.zip)
@@ -591,7 +604,7 @@
class Factory(factory.BuildFactory):
-def __init__(self, platform, configuration, architectures, buildOnly, features=None):
+def __init__(self, platform, configuration, architectures, buildOnly, features=None, **kwargs):
factory.BuildFactory.__init__(self)
self.addStep(ConfigureBuild, platform=platform, configuration=configuration, architecture= .join(architectures), buildOnly=buildOnly, features=features)
self.addStep(CheckOutSource)
@@ -603,12 +616,13 @@
self.addStep(InstallChromiumDependencies)
class BuildFactory(Factory):
-def __init__(self, platform, configuration, architectures, triggers=None, **kwargs):
+def __init__(self, platform, configuration, architectures, triggers=None, upload=False, **kwargs):
Factory.__init__(self, platform, configuration, architectures, True, **kwargs)
self.addStep(CompileWebKit)
-if triggers:
+if triggers or upload:
self.addStep(ArchiveBuiltProduct)
self.addStep(UploadBuiltProduct)
+if triggers:
self.addStep(trigger.Trigger, schedulerNames=triggers)
def unitTestsSupported(configuration, platform):
@@ -725,7 +739,8 @@
factoryArgs.append(value)
factoryKwArgs = {
-
[webkit-changes] [92192] trunk
Title: [92192] trunk
Revision 92192
Author apav...@chromium.org
Date 2011-08-02 08:51:31 -0700 (Tue, 02 Aug 2011)
Log Message
Web Inspector: img[width=90] or align attributes shouldnt be shown above element.style block (as they have lower specificity)
https://bugs.webkit.org/show_bug.cgi?id=65514
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/StylesSidebarPane.js:
LayoutTests:
* inspector/elements/elements-panel-styles-expected.txt:
* inspector/elements/elements-panel-styles.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt
trunk/LayoutTests/inspector/elements/elements-panel-styles.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Diff
Modified: trunk/LayoutTests/ChangeLog (92191 => 92192)
--- trunk/LayoutTests/ChangeLog 2011-08-02 15:25:33 UTC (rev 92191)
+++ trunk/LayoutTests/ChangeLog 2011-08-02 15:51:31 UTC (rev 92192)
@@ -1,3 +1,13 @@
+2011-08-02 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: img[width=90] or align attributes shouldnt be shown above element.style block (as they have lower specificity)
+https://bugs.webkit.org/show_bug.cgi?id=65514
+
+Reviewed by Pavel Feldman.
+
+* inspector/elements/elements-panel-styles-expected.txt:
+* inspector/elements/elements-panel-styles.html:
+
2011-08-01 Andrey Kosyakov ca...@chromium.org
Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken
Modified: trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt (92191 => 92192)
--- trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt 2011-08-02 15:25:33 UTC (rev 92191)
+++ trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt 2011-08-02 15:51:31 UTC (rev 92192)
@@ -31,6 +31,8 @@
.foo - 0px elements-panel-styles.css:14
margin-top: 10px;
.foo - 10px elements-panel-styles.css:14
+text-align: -webkit-left;
+div[align=left] - -webkit-left
[expanded] element.style { ()
display: none;
@@ -62,6 +64,9 @@
[expanded] div { (user agent stylesheet)
/-- overloaded --/ display: block;
+[expanded] div[align=left] { ()
+text-align: -webkit-left;
+
Inherited from div#container
[expanded] #container { (elements-panel-styles.css:5)
font-family: serif;
Modified: trunk/LayoutTests/inspector/elements/elements-panel-styles.html (92191 => 92192)
--- trunk/LayoutTests/inspector/elements/elements-panel-styles.html 2011-08-02 15:25:33 UTC (rev 92191)
+++ trunk/LayoutTests/inspector/elements/elements-panel-styles.html 2011-08-02 15:51:31 UTC (rev 92192)
@@ -26,7 +26,7 @@
/p
div id=container
-div id=foo class=foo style=display:noneFoo/div
+div id=foo class=foo style=display:none align=leftFoo/div
/div
/body
Modified: trunk/Source/WebCore/ChangeLog (92191 => 92192)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 15:25:33 UTC (rev 92191)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 15:51:31 UTC (rev 92192)
@@ -1,3 +1,12 @@
+2011-08-02 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: img[width=90] or align attributes shouldnt be shown above element.style block (as they have lower specificity)
+https://bugs.webkit.org/show_bug.cgi?id=65514
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/StylesSidebarPane.js:
+
2011-08-02 Gyuyoung Kim gyuyoung@samsung.com
[EFL] Add fullscreen button to media control UI.
Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (92191 => 92192)
--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-08-02 15:25:33 UTC (rev 92191)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-08-02 15:51:31 UTC (rev 92192)
@@ -366,17 +366,7 @@
styleRules.push({ computedStyle: true, selectorText: , style: nodeComputedStyle, editable: false });
-var styleAttributes = {};
-for (var name in styles.styleAttributes) {
-var attrStyle = { style: styles.styleAttributes[name], editable: false };
-attrStyle.selectorText = WebInspector.panels.elements.treeOutline.nodeNameToCorrectCase(node.nodeName()) + [ + name;
-if (node.getAttribute(name))
-attrStyle.selectorText += = + node.getAttribute(name);
-attrStyle.selectorText += ];
-styleRules.push(attrStyle);
-}
-
-// Show element's Style Attributes
+// Inline style has the greatest specificity.
if (styles.inlineStyle node.nodeType() === Node.ELEMENT_NODE) {
var inlineStyle = { selectorText: element.style, style: styles.inlineStyle, isAttribute: true };
styleRules.push(inlineStyle);
@@ -390,6 +380,17 @@
styleRules.push({ style: rule.style, selectorText: rule.selectorText, sourceURL: rule.sourceURL, rule: rule, editable: !!(rule.style
[webkit-changes] [92193] trunk/LayoutTests
Title: [92193] trunk/LayoutTests Revision 92193 Author o...@webkit.org Date 2011-08-02 08:52:42 -0700 (Tue, 02 Aug 2011) Log Message Web Inspector: REGRESSION(r92105): It made 2 tests fail https://bugs.webkit.org/show_bug.cgi?id=65525 * platform/qt/Skipped: Unskip tests, because r92185 fixed the bug. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92192 => 92193) --- trunk/LayoutTests/ChangeLog 2011-08-02 15:51:31 UTC (rev 92192) +++ trunk/LayoutTests/ChangeLog 2011-08-02 15:52:42 UTC (rev 92193) @@ -1,3 +1,10 @@ +2011-08-02 Csaba Osztrogonác o...@webkit.org + +Web Inspector: REGRESSION(r92105): It made 2 tests fail +https://bugs.webkit.org/show_bug.cgi?id=65525 + +* platform/qt/Skipped: Unskip tests, because r92185 fixed the bug. + 2011-08-02 Alexander Pavlov apav...@chromium.org Web Inspector: img[width=90] or align attributes shouldnt be shown above element.style block (as they have lower specificity) Modified: trunk/LayoutTests/platform/qt/Skipped (92192 => 92193) --- trunk/LayoutTests/platform/qt/Skipped 2011-08-02 15:51:31 UTC (rev 92192) +++ trunk/LayoutTests/platform/qt/Skipped 2011-08-02 15:52:42 UTC (rev 92193) @@ -2238,8 +2238,3 @@ # [Qt]Web Inspector: http/tests/inspector/network/network-sidebar-width.html fails # https://bugs.webkit.org/show_bug.cgi?id=65526 http/tests/inspector/network/network-sidebar-width.html - -# Web Inspector: REGRESSION(r92105): It made 2 tests fail -# https://bugs.webkit.org/show_bug.cgi?id=65525 -inspector/debugger/scripts-panel.html -inspector/debugger/scripts-sorting.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92194] trunk
Title: [92194] trunk
Revision 92194
Author vse...@chromium.org
Date 2011-08-02 08:54:35 -0700 (Tue, 02 Aug 2011)
Log Message
Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors.
https://bugs.webkit.org/show_bug.cgi?id=65466
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/network/network-initiator-from-console.html
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
LayoutTests:
* http/tests/inspector/network/network-initiator-from-console-expected.txt: Added.
* http/tests/inspector/network/network-initiator-from-console.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
Added Paths
trunk/LayoutTests/http/tests/inspector/network/network-initiator-from-console-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-initiator-from-console.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92193 => 92194)
--- trunk/LayoutTests/ChangeLog 2011-08-02 15:52:42 UTC (rev 92193)
+++ trunk/LayoutTests/ChangeLog 2011-08-02 15:54:35 UTC (rev 92194)
@@ -1,3 +1,13 @@
+2011-08-01 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors.
+https://bugs.webkit.org/show_bug.cgi?id=65466
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/network/network-initiator-from-console-expected.txt: Added.
+* http/tests/inspector/network/network-initiator-from-console.html: Added.
+
2011-08-02 Csaba Osztrogonác o...@webkit.org
Web Inspector: REGRESSION(r92105): It made 2 tests fail
Added: trunk/LayoutTests/http/tests/inspector/network/network-initiator-from-console-expected.txt (0 => 92194)
--- trunk/LayoutTests/http/tests/inspector/network/network-initiator-from-console-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-initiator-from-console-expected.txt 2011-08-02 15:54:35 UTC (rev 92194)
@@ -0,0 +1,6 @@
+CONSOLE MESSAGE: line 1: Done.
+Tests that there is no _javascript_ error when console evaluation causes resource loading.
+
+Bug 65466
+Page reloaded.
+
Property changes on: trunk/LayoutTests/http/tests/inspector/network/network-initiator-from-console-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/inspector/network/network-initiator-from-console.html (0 => 92194)
--- trunk/LayoutTests/http/tests/inspector/network/network-initiator-from-console.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-initiator-from-console.html 2011-08-02 15:54:35 UTC (rev 92194)
@@ -0,0 +1,53 @@
+html
+head
+script src=""
+script src=""
+script
+var test = function()
+{
+InspectorTest.reloadPage(step1);
+
+function findResourceByURL(url)
+{
+var resources = WebInspector.networkLog.resources;
+for (var i = 0; i resources.length; ++i) {
+if (url.test(resources[i].url))
+return resources[i];
+}
+}
+
+function step1()
+{
+InspectorTest.addSniffer(WebInspector.ConsoleView.prototype, addMessage, step2);
+WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.ResourceStarted, onResource);
+var str = ;
+str += var s = document.createElement(\script\);;
+str += s.src = ""
+str += document.head.appendChild(s);;
+WebInspector.console.evalInInspectedWindow(str, console, true, undefined, undefined, function(){})
+}
+
+function onResource(event)
+{
+var resource = event.data;
+if (/script.js/.test(resource.url))
+step2();
+}
+
+function step2()
+{
+if (!findResourceByURL(/script.js/))
+return;
+
+WebInspector.panels.network.show();
+InspectorTest.completeTest();
+}
+}
+
+/script
+/head
+body _onload_=runTest()
+pTests that there is no _javascript_ error when console evaluation causes resource loading./p
+a href="" 65466/a
+/body
+/html
Property changes on: trunk/LayoutTests/http/tests/inspector/network/network-initiator-from-console.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (92193 => 92194)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 15:52:42 UTC (rev 92193)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 15:54:35 UTC (rev 92194)
@@ -1,3 +1,15 @@
+2011-08-01 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors.
+https://bugs.webkit.org/show_bug.cgi?id=65466
+
+Reviewed by Pavel Feldman.
+
+Test:
[webkit-changes] [92196] trunk
Title: [92196] trunk
Revision 92196
Author podivi...@chromium.org
Date 2011-08-02 08:59:55 -0700 (Tue, 02 Aug 2011)
Log Message
Web Inspector: merge FormattedSourceFile into SourceFile.
https://bugs.webkit.org/show_bug.cgi?id=65411
Reviewed by Pavel Feldman.
Prepare for splitting SourceFile into RawSourceCode and UISourceCode:
* merge FormattedSourceFile into SourceFile
* rename SourceFile to RawSourceCode
* hide formatter worker lazy creation in ScriptFormatter
Source/WebCore:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._scriptLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter):
(WebInspector.ScriptFormatter.prototype._didFormatContent):
(WebInspector.ScriptFormatter.prototype.get _worker):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.didRequestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype._didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.RawSourceCode.prototype._invokeRequestContentCallbacks):
LayoutTests:
* inspector/debugger/source-file.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/source-file.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/ScriptFormatter.js
trunk/Source/WebCore/inspector/front-end/SourceFile.js
Diff
Modified: trunk/LayoutTests/ChangeLog (92195 => 92196)
--- trunk/LayoutTests/ChangeLog 2011-08-02 15:58:53 UTC (rev 92195)
+++ trunk/LayoutTests/ChangeLog 2011-08-02 15:59:55 UTC (rev 92196)
@@ -1,3 +1,17 @@
+2011-07-30 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: merge FormattedSourceFile into SourceFile.
+https://bugs.webkit.org/show_bug.cgi?id=65411
+
+Reviewed by Pavel Feldman.
+
+Prepare for splitting SourceFile into RawSourceCode and UISourceCode:
+ * merge FormattedSourceFile into SourceFile
+ * rename SourceFile to RawSourceCode
+ * hide formatter worker lazy creation in ScriptFormatter
+
+* inspector/debugger/source-file.html:
+
2011-08-01 Vsevolod Vlasov vse...@chromium.org
Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors.
Modified: trunk/LayoutTests/inspector/debugger/source-file.html (92195 => 92196)
--- trunk/LayoutTests/inspector/debugger/source-file.html 2011-08-02 15:58:53 UTC (rev 92195)
+++ trunk/LayoutTests/inspector/debugger/source-file.html 2011-08-02 15:59:55 UTC (rev 92196)
@@ -54,7 +54,7 @@
function testPlainConvertLocation(next)
{
var script = new WebInspector.Script(1, foo.js, 0, 0, 20, 80, undefined, undefined, false);
-var sourceFile = new WebInspector.SourceFile(id, script);
+var sourceFile = new WebInspector.RawSourceCode(id, script);
checkUILocation(sourceFile, 10, 20, sourceFile.rawLocationToUILocation(rl(10, 20)));
checkRawLocation(script, 30, 40, sourceFile.uiLocationToRawLocation(30, 40));
@@ -66,7 +66,7 @@
{
var script1 = new WebInspector.Script(1, foo.js, 10, 20, 30, 40, undefined, undefined, false);
var script2 = new WebInspector.Script(2, foo.js, 50, 60, 70, 80, undefined, undefined, false);
-var sourceFile = new WebInspector.SourceFile(id, script1);
+var sourceFile = new WebInspector.RawSourceCode(id, script1);
sourceFile.addScript(script2);
checkUILocation(sourceFile, 20, 0, sourceFile.rawLocationToUILocation(rl(20, 0)));
@@ -81,7 +81,8 @@
function testFormattedConvertLocation(next)
{
var script = new WebInspector.Script(1, foo.js, 0, 0, 20, 80, undefined, undefined, false);
-var sourceFile = new WebInspector.FormattedSourceFile(id, script, null, mockScriptFormatter);
+var sourceFile = new WebInspector.RawSourceCode(id, script, mockScriptFormatter);
+sourceFile.setFormatted(true);
function didCreateSourceMapping()
{
@@ -96,7 +97,8 @@
{
var script1 = new WebInspector.Script(1, foo.js, 10, 20, 30, 40, undefined, undefined, false);
var script2 = new WebInspector.Script(2, foo.js, 50, 60, 70, 80, undefined, undefined, false);
-var sourceFile = new WebInspector.FormattedSourceFile(id, script1, null, mockScriptFormatter);
+var sourceFile = new WebInspector.RawSourceCode(id, script1,
[webkit-changes] [92197] trunk/Source/WebCore
Title: [92197] trunk/Source/WebCore
Revision 92197
Author commit-qu...@webkit.org
Date 2011-08-02 09:34:36 -0700 (Tue, 02 Aug 2011)
Log Message
[Qt] Simplify Path::translate() implementation.
https://bugs.webkit.org/show_bug.cgi?id=65540
Patch by Andreas Kling kl...@webkit.org on 2011-08-02
Reviewed by Benjamin Poulain.
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::translate):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/qt/PathQt.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92196 => 92197)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 15:59:55 UTC (rev 92196)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 16:34:36 UTC (rev 92197)
@@ -1,3 +1,13 @@
+2011-08-02 Andreas Kling kl...@webkit.org
+
+[Qt] Simplify Path::translate() implementation.
+https://bugs.webkit.org/show_bug.cgi?id=65540
+
+Reviewed by Benjamin Poulain.
+
+* platform/graphics/qt/PathQt.cpp:
+(WebCore::Path::translate):
+
2011-07-30 Pavel Podivilov podivi...@chromium.org
Web Inspector: merge FormattedSourceFile into SourceFile.
Modified: trunk/Source/WebCore/platform/graphics/qt/PathQt.cpp (92196 => 92197)
--- trunk/Source/WebCore/platform/graphics/qt/PathQt.cpp 2011-08-02 15:59:55 UTC (rev 92196)
+++ trunk/Source/WebCore/platform/graphics/qt/PathQt.cpp 2011-08-02 16:34:36 UTC (rev 92197)
@@ -144,9 +144,7 @@
void Path::translate(const FloatSize size)
{
-QTransform matrix;
-matrix.translate(size.width(), size.height());
-m_path = m_path * matrix;
+m_path.translate(size.width(), size.height());
}
FloatRect Path::boundingRect() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92198] trunk/Source/WebKit2
Title: [92198] trunk/Source/WebKit2
Revision 92198
Author jocelyn.turco...@nokia.com
Date 2011-08-02 10:00:08 -0700 (Tue, 02 Aug 2011)
Log Message
TiledDrawingArea: Handle update requests in the order they were received.
https://bugs.webkit.org/show_bug.cgi?id=64365
Reviewed by Andreas Kling.
TiledDrawingAreaProxy::createTiles() uses the distance of tiles to the
center of the viewport to decide which tile should be rendered first.
This logic is useless if the requests are not handled in the same order
as they were received.
Now use a list instead of a map to hold pending tile update requests.
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::cancelTileUpdate):
(WebKit::TiledDrawingArea::requestTileUpdate):
* WebProcess/WebPage/TiledDrawingArea.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp
trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (92197 => 92198)
--- trunk/Source/WebKit2/ChangeLog 2011-08-02 16:34:36 UTC (rev 92197)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-02 17:00:08 UTC (rev 92198)
@@ -1,3 +1,22 @@
+2011-07-12 Jocelyn Turcotte jocelyn.turco...@nokia.com
+
+TiledDrawingArea: Handle update requests in the order they were received.
+https://bugs.webkit.org/show_bug.cgi?id=64365
+
+Reviewed by Andreas Kling.
+
+TiledDrawingAreaProxy::createTiles() uses the distance of tiles to the
+center of the viewport to decide which tile should be rendered first.
+This logic is useless if the requests are not handled in the same order
+as they were received.
+Now use a list instead of a map to hold pending tile update requests.
+
+* WebProcess/WebPage/TiledDrawingArea.cpp:
+(WebKit::TiledDrawingArea::tileUpdateTimerFired):
+(WebKit::TiledDrawingArea::cancelTileUpdate):
+(WebKit::TiledDrawingArea::requestTileUpdate):
+* WebProcess/WebPage/TiledDrawingArea.h:
+
2011-08-02 Amruth Raj amruth...@motorola.com
Custom cursors cause the WebProcess to crash
Modified: trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp (92197 => 92198)
--- trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp 2011-08-02 16:34:36 UTC (rev 92197)
+++ trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp 2011-08-02 17:00:08 UTC (rev 92198)
@@ -165,11 +165,10 @@
{
ASSERT(!m_pendingUpdates.isEmpty());
-UpdateMap::iterator it = m_pendingUpdates.begin();
-TileUpdate update = it-second;
-m_pendingUpdates.remove(it);
+OwnPtrTileUpdate update = m_pendingUpdates.first().release();
+m_pendingUpdates.removeFirst();
-updateTile(update.tileID, update.dirtyRect, update.scale);
+updateTile(update-tileID, update-dirtyRect, update-scale);
if (m_pendingUpdates.isEmpty())
m_webPage-send(Messages::DrawingAreaProxy::AllTileUpdatesProcessed());
@@ -179,10 +178,13 @@
void TiledDrawingArea::cancelTileUpdate(int tileID)
{
-UpdateMap::iterator it = m_pendingUpdates.find(tileID);
-if (it == m_pendingUpdates.end())
-return;
-m_pendingUpdates.remove(it);
+UpdateList::iterator end = m_pendingUpdates.end();
+for (UpdateList::iterator it = m_pendingUpdates.begin(); it != end; ++it) {
+if ((*it)-tileID == tileID) {
+m_pendingUpdates.remove(it);
+break;
+}
+}
if (m_pendingUpdates.isEmpty()) {
m_webPage-send(Messages::DrawingAreaProxy::AllTileUpdatesProcessed());
m_tileUpdateTimer.stop();
@@ -191,17 +193,20 @@
void TiledDrawingArea::requestTileUpdate(int tileID, const WebCore::IntRect dirtyRect, float scale)
{
-UpdateMap::iterator it = m_pendingUpdates.find(tileID);
-if (it != m_pendingUpdates.end())
-it-second.dirtyRect.unite(dirtyRect);
-else {
-TileUpdate update;
-update.tileID = tileID;
-update.dirtyRect = dirtyRect;
-update.scale = scale;
-m_pendingUpdates.add(tileID, update);
-scheduleTileUpdate();
+UpdateList::iterator end = m_pendingUpdates.end();
+for (UpdateList::iterator it = m_pendingUpdates.begin(); it != end; ++it) {
+if ((*it)-tileID == tileID) {
+(*it)-dirtyRect.unite(dirtyRect);
+return;
+}
}
+
+OwnPtrTileUpdate update(adoptPtr(new TileUpdate));
+update-tileID = tileID;
+update-dirtyRect = dirtyRect;
+update-scale = scale;
+m_pendingUpdates.append(update.release());
+scheduleTileUpdate();
}
} // namespace WebKit
Modified: trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.h (92197 => 92198)
--- trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.h 2011-08-02 16:34:36 UTC (rev 92197)
+++ trunk/Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.h 2011-08-02 17:00:08 UTC (rev 92198)
@@ -31,7 +31,7
[webkit-changes] [92199] trunk/Source/WebKit2
Title: [92199] trunk/Source/WebKit2
Revision 92199
Author jocelyn.turco...@nokia.com
Date 2011-08-02 10:00:28 -0700 (Tue, 02 Aug 2011)
Log Message
[Qt] Add QtWebProcess in PATH at runtime for WebKit2 API auto tests.
https://bugs.webkit.org/show_bug.cgi?id=65378
Reviewed by Benjamin Poulain.
This prevent the runner of the tests from having to add it to PATH himself.
* UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::tst_CommonViewTests):
* UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
(tst_QDesktopWebView::tst_QDesktopWebView):
* UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
(tst_QTouchWebView::tst_QTouchWebView):
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/API/qt/tests/util.cpp: Copied from Source/WebKit2/UIProcess/API/qt/tests/util.h.
Move definitions to a cpp file to prevent unused static symbol warnings.
(addQtWebProcessToPath):
(waitForSignal):
* UIProcess/API/qt/tests/util.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp
trunk/Source/WebKit2/UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/tests/tests.pri
trunk/Source/WebKit2/UIProcess/API/qt/tests/util.h
Added Paths
trunk/Source/WebKit2/UIProcess/API/qt/tests/util.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (92198 => 92199)
--- trunk/Source/WebKit2/ChangeLog 2011-08-02 17:00:08 UTC (rev 92198)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-02 17:00:28 UTC (rev 92199)
@@ -1,3 +1,25 @@
+2011-07-29 Jocelyn Turcotte jocelyn.turco...@nokia.com
+
+[Qt] Add QtWebProcess in PATH at runtime for WebKit2 API auto tests.
+https://bugs.webkit.org/show_bug.cgi?id=65378
+
+Reviewed by Benjamin Poulain.
+
+This prevent the runner of the tests from having to add it to PATH himself.
+
+* UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
+(tst_CommonViewTests::tst_CommonViewTests):
+* UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
+(tst_QDesktopWebView::tst_QDesktopWebView):
+* UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
+(tst_QTouchWebView::tst_QTouchWebView):
+* UIProcess/API/qt/tests/tests.pri:
+* UIProcess/API/qt/tests/util.cpp: Copied from Source/WebKit2/UIProcess/API/qt/tests/util.h.
+Move definitions to a cpp file to prevent unused static symbol warnings.
+(addQtWebProcessToPath):
+(waitForSignal):
+* UIProcess/API/qt/tests/util.h:
+
2011-07-12 Jocelyn Turcotte jocelyn.turco...@nokia.com
TiledDrawingArea: Handle update requests in the order they were received.
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp (92198 => 92199)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp 2011-08-02 17:00:08 UTC (rev 92198)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp 2011-08-02 17:00:28 UTC (rev 92199)
@@ -25,6 +25,9 @@
class tst_CommonViewTests : public QObject {
Q_OBJECT
+public:
+tst_CommonViewTests();
+
private slots:
void init();
void cleanup();
@@ -44,6 +47,11 @@
QScopedPointerWebViewAbstraction viewAbstraction;
};
+tst_CommonViewTests::tst_CommonViewTests()
+{
+addQtWebProcessToPath();
+}
+
void tst_CommonViewTests::init()
{
viewAbstraction.reset(new WebViewAbstraction);
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp (92198 => 92199)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp 2011-08-02 17:00:08 UTC (rev 92198)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp 2011-08-02 17:00:28 UTC (rev 92199)
@@ -26,6 +26,8 @@
class tst_QDesktopWebView : public QObject {
Q_OBJECT
+public:
+tst_QDesktopWebView();
private slots:
void init();
@@ -39,6 +41,11 @@
QScopedPointerTestWindow m_window;
};
+tst_QDesktopWebView::tst_QDesktopWebView()
+{
+addQtWebProcessToPath();
+}
+
void tst_QDesktopWebView::init()
{
m_window.reset(new TestWindow(new QDesktopWebView()));
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp (92198 => 92199)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp 2011-08-02 17:00:08 UTC (rev 92198)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp 2011-08-02 17:00:28 UTC (rev 92199)
@@ -22,6 +22,7 @@
#include qtouchwebpage.h
#include qtouchwebview.h
#include ../testwindow.h
+#include ../util.h
Q_DECLARE_METATYPE(QTouchWebPage*);
@@ -43,6 +44,7 @@
tst_QTouchWebView::tst_QTouchWebView()
{
+addQtWebProcessToPath();
[webkit-changes] [92200] trunk
Title: [92200] trunk
Revision 92200
Author commit-qu...@webkit.org
Date 2011-08-02 10:08:18 -0700 (Tue, 02 Aug 2011)
Log Message
hover then un-hover makes state change
https://bugs.webkit.org/show_bug.cgi?id=56401
Patch by Mihnea Ovidenie mih...@adobe.com on 2011-08-02
Reviewed by David Hyatt.
Source/WebCore:
When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous
block with inline children. If it is, then we should change the insertion point to the first child of the
anonymous block, otherwise the 'before' pseudo-element ends up in a different block. We choose the insertion
point to be the first child only if the anonymous block has children, otherwise the before element ends up
in a wrong block.
Tests: fast/dynamic/hover-before-position-after-style-change.html
fast/dynamic/hover-before-position-after-style-change2.html
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
LayoutTests:
* fast/dynamic/hover-before-position-after-style-change-expected.txt: Added.
* fast/dynamic/hover-before-position-after-style-change.html: Added.
* fast/dynamic/hover-before-position-after-style-change2-expected.txt: Added.
* fast/dynamic/hover-before-position-after-style-change2.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObjectChildList.cpp
Added Paths
trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change-expected.txt
trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change.html
trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change2-expected.txt
trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change2.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92199 => 92200)
--- trunk/LayoutTests/ChangeLog 2011-08-02 17:00:28 UTC (rev 92199)
+++ trunk/LayoutTests/ChangeLog 2011-08-02 17:08:18 UTC (rev 92200)
@@ -1,3 +1,15 @@
+2011-08-02 Mihnea Ovidenie mih...@adobe.com
+
+hover then un-hover makes state change
+https://bugs.webkit.org/show_bug.cgi?id=56401
+
+Reviewed by David Hyatt.
+
+* fast/dynamic/hover-before-position-after-style-change-expected.txt: Added.
+* fast/dynamic/hover-before-position-after-style-change.html: Added.
+* fast/dynamic/hover-before-position-after-style-change2-expected.txt: Added.
+* fast/dynamic/hover-before-position-after-style-change2.html: Added.
+
2011-07-30 Pavel Podivilov podivi...@chromium.org
Web Inspector: merge FormattedSourceFile into SourceFile.
Added: trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change-expected.txt (0 => 92200)
--- trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change-expected.txt 2011-08-02 17:08:18 UTC (rev 92200)
@@ -0,0 +1,4 @@
+Test for https://bugs.webkit.org/show_bug.cgi?id=56401 Hover the mouse over the Inline text. The test passes if Inline is not placed on a new line.
+
+PASS
+
Added: trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change.html (0 => 92200)
--- trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change.html (rev 0)
+++ trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change.html 2011-08-02 17:08:18 UTC (rev 92200)
@@ -0,0 +1,56 @@
+!DOCTYPE HTML
+html
+head
+style
+div { width:100px; height:100px;}
+div#outsideDiv:before { content: ; }
+div#outsideDiv:hover:before { content: ; }
+/style
+p
+Test for a href=""
+Hover the mouse over the Inline text. The test passes if Inline is not placed on a new line.
+/p
+/head
+body
+div id=console/div
+div id=outsideDiv _onmouseover_=checkTestResult()
+spanInline/span
+div id=insideDivBlock/p
+/div
+script
+function getElementTop(elementId)
+{
+var elem = document.getElementById(elementId);
+return elem.getBoundingClientRect().top;
+}
+
+function simulateMouseMove()
+{
+var outsideDivTop = getElementTop(outsideDiv);
+if (window.eventSender)
+eventSender.mouseMoveTo(50, outsideDivTop);
+}
+
+function checkTestResult()
+{
+var outsideDivTop = getElementTop(outsideDiv);
+var insideDivTop = getElementTop(insideDiv);
+document.getElementById(console).innerText = (insideDivOriginalTop != insideDivTop) ? FAIL : PASS;
+if (window.layoutTestController)
+document.getElementById(outsideDiv).style.visibility = 'hidden';
+
[webkit-changes] [92201] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Title: [92201] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Revision 92201
Author wsiegr...@apple.com
Date 2011-08-02 10:16:23 -0700 (Tue, 02 Aug 2011)
Log Message
Removed a dangling reference to Leopard Intel Release (Build).
Unreviewed.
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (92200 => 92201)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2011-08-02 17:08:18 UTC (rev 92200)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2011-08-02 17:16:23 UTC (rev 92201)
@@ -273,7 +273,7 @@
WinCairo Debug (Build), WinCE Release (Build), EFL Linux Release (Build)]
},
{ type: PlatformSpecificScheduler, platform: mac-leopard, branch: trunk, treeStableTimer: 45.0,
- builderNames: [Leopard Intel Release (Build), Leopard Intel Debug (Build)]
+ builderNames: [Leopard Intel Debug (Build)]
},
{ type: PlatformSpecificScheduler, platform: mac-snowleopard, branch: trunk, treeStableTimer: 45.0,
builderNames: [SnowLeopard Intel Release (Build), SnowLeopard Intel Leaks, SnowLeopard Intel Debug (Build),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92203] trunk/Source/WebCore
Title: [92203] trunk/Source/WebCore
Revision 92203
Author tha...@chromium.org
Date 2011-08-02 10:33:45 -0700 (Tue, 02 Aug 2011)
Log Message
[chromium] Fix unresolved symbols error when linking to libwebkit.dylib
https://bugs.webkit.org/show_bug.cgi?id=65498
Reviewed by Dimitri Glazkov.
* WebCore.gyp/mac/adjust_visibility.sh:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh
Diff
Modified: trunk/Source/WebCore/ChangeLog (92202 => 92203)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 17:31:52 UTC (rev 92202)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 17:33:45 UTC (rev 92203)
@@ -1,3 +1,12 @@
+2011-08-02 Nico Weber tha...@chromium.org
+
+[chromium] Fix unresolved symbols error when linking to libwebkit.dylib
+https://bugs.webkit.org/show_bug.cgi?id=65498
+
+Reviewed by Dimitri Glazkov.
+
+* WebCore.gyp/mac/adjust_visibility.sh:
+
2011-08-02 Mihnea Ovidenie mih...@adobe.com
hover then un-hover makes state change
Modified: trunk/Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh (92202 => 92203)
--- trunk/Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh 2011-08-02 17:31:52 UTC (rev 92202)
+++ trunk/Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh 2011-08-02 17:33:45 UTC (rev 92203)
@@ -79,6 +79,17 @@
# Change directories to extract the archive to ensure correct pathnames.
(cd ${ARCH_DIR} ar -x ${INPUT_NAME})
+ # libWebKitSystemInterfaceLeopard.a's cuDbUtils.o references a few symbols
+ # that are not defined in any framework in OS X 10.5. If it's linked into a
+ # libwebkit.dylib with -Wl,-all_load, linking to libwebkit.dylib will result
+ # in these unresolved symbols:
+ # __ZN8Security12KeychainCore6Schema22X509CrlSchemaIndexListE$non_lazy_ptr
+ # __ZN8Security12KeychainCore6Schema23X509CrlSchemaIndexCountE$non_lazy_ptr
+ # __ZN8Security12KeychainCore6Schema26X509CrlSchemaAttributeListE$non_lazy_ptr
+ # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr
+ # Since nothing in cuDbUtils.o is needed, just remove it.
+ rm ${ARCH_DIR}/cuDbUtils.o
+
# Use ld -r to relink each object that was in the archive. Providing an
# empty -exported_symbols_list will transform all symbols to private_extern;
# these symbols are retained with -keep_private_externs.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92205] trunk/LayoutTests
Title: [92205] trunk/LayoutTests Revision 92205 Author e...@google.com Date 2011-08-02 10:37:47 -0700 (Tue, 02 Aug 2011) Log Message [chromium] Remove expectations for no longer crashing tests. https://bugs.webkit.org/show_bug.cgi?id=65155 Unreviewed expectation update. These were fixed after Chromium r94376, r94374, r94373. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92204 => 92205) --- trunk/LayoutTests/ChangeLog 2011-08-02 17:36:47 UTC (rev 92204) +++ trunk/LayoutTests/ChangeLog 2011-08-02 17:37:47 UTC (rev 92205) @@ -1,3 +1,14 @@ +2011-08-02 Adrienne Walker e...@google.com + +[chromium] Remove expectations for no longer crashing tests. +https://bugs.webkit.org/show_bug.cgi?id=65155 + +Unreviewed expectation update. + +These were fixed after Chromium r94376, r94374, r94373. + +* platform/chromium/test_expectations.txt: + 2011-08-02 Mihnea Ovidenie mih...@adobe.com hover then un-hover makes state change Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92204 => 92205) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 17:36:47 UTC (rev 92204) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 17:37:47 UTC (rev 92205) @@ -2489,7 +2489,7 @@ BUGCR66085 LINUX : editing/selection/3690703-2.html = PASS TIMEOUT BUGCR66085 LINUX : fast/dom/Geolocation/disconnected-frame-permission-denied.html = PASS TIMEOUT BUGCR66085 WIN LINUX : fast/events/5056619.html = PASS TIMEOUT -//BUGCR66085 LINUX : fast/js/cyclic-proto.html = PASS TIMEOUT +BUGCR66085 LINUX : fast/js/cyclic-proto.html = PASS TIMEOUT BUGCR66085 WIN LINUX : fast/replaced/css-content-and-webkit-mask-box-image-crash.html = PASS TIMEOUT BUGCR66085 LINUX : http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html = PASS TIMEOUT @@ -3330,7 +3330,7 @@ BUGCR82881 MAC LINUX XP VISTA : http/tests/appcache/interrupted-update.html = PASS TEXT // Flaky on Linux -//BUGCR82891 LINUX : fast/speech/input-appearance-numberandspeech.html = TEXT IMAGE+TEXT PASS +BUGCR82891 LINUX : fast/speech/input-appearance-numberandspeech.html = TEXT IMAGE+TEXT PASS BUGCR82891 LINUX : fast/speech/input-appearance-searchandspeech.html = FAIL PASS BUGCR82891 LINUX : fast/speech/input-appearance-speechbutton.html = TEXT IMAGE+TEXT PASS @@ -3636,18 +3636,6 @@ BUGWK65124 : fast/blockflow/japanese-rl-text-with-broken-font.html = FAIL BUGWK65124 WIN : fast/blockflow/japanese-rl-text.html = IMAGE+TEXT -BUGWK65129 : media/media-controls-clone.html = CRASH PASS - -BUGWK65149 LINUX : userscripts/user-script-image-document.html = CRASH PASS - -BUGWK65152 : fast/js/cyclic-proto.html = CRASH PASS -BUGWK65152 : fast/js/cyclic-prototypes.html = CRASH PASS - -BUGWK65155 : fast/selectors/001.html = CRASH PASS -BUGWK65155 : media/audio-only-video-intrinsic-size.html = CRASH PASS -BUGWK65155 : fast/dom/beforeload/script-before-load-dynamic.html = CRASH PASS -BUGWK65155 : fast/speech/input-appearance-numberandspeech.html = CRASH PASS FAIL - BUGWK65199 : fast/blockflow/broken-ideograph-small-caps.html = PASS FAIL BUGWK65219 WIN : webaudio/test-basic.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92206] trunk/Source
Title: [92206] trunk/Source
Revision 92206
Author nd...@chromium.org
Date 2011-08-02 10:53:44 -0700 (Tue, 02 Aug 2011)
Log Message
[chromium] Remove resizeOnscreenContent from LRC. It can be derived.
https://bugs.webkit.org/show_bug.cgi?id=65519
Reviewed by James Robinson.
Source/WebCore:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::setViewport):
* platform/graphics/chromium/LayerRendererChromium.h:
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92205 => 92206)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 17:37:47 UTC (rev 92205)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 17:53:44 UTC (rev 92206)
@@ -1,3 +1,14 @@
+2011-08-02 Nat Duca nd...@chromium.org
+
+[chromium] Remove resizeOnscreenContent from LRC. It can be derived.
+https://bugs.webkit.org/show_bug.cgi?id=65519
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::setViewport):
+* platform/graphics/chromium/LayerRendererChromium.h:
+
2011-08-02 Nico Weber tha...@chromium.org
[chromium] Fix unresolved symbols error when linking to libwebkit.dylib
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (92205 => 92206)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-08-02 17:37:47 UTC (rev 92205)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-08-02 17:53:44 UTC (rev 92206)
@@ -518,6 +518,8 @@
m_viewportScrollPosition = scrollPosition;
if (visibleRectChanged) {
+if (m_context)
+m_context-reshape(std::max(1, visibleRect.width()), std::max(1, visibleRect.height()));
// Reset the current render surface to force an update of the viewport and
// projection matrix next time useRenderSurface is called.
m_currentRenderSurface = 0;
@@ -1124,13 +1126,6 @@
}
-
-void LayerRendererChromium::resizeOnscreenContent(const IntSize size)
-{
-if (m_context)
-m_context-reshape(size.width(), size.height());
-}
-
bool LayerRendererChromium::initializeSharedObjects()
{
TRACE_EVENT(LayerRendererChromium::initializeSharedObjects, this, 0);
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h (92205 => 92206)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h 2011-08-02 17:37:47 UTC (rev 92205)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h 2011-08-02 17:53:44 UTC (rev 92206)
@@ -138,8 +138,6 @@
const CCVideoLayerImpl::RGBAProgram* videoLayerRGBAProgram();
const CCVideoLayerImpl::YUVProgram* videoLayerYUVProgram();
-void resizeOnscreenContent(const IntSize);
-
void getFramebufferPixels(void *pixels, const IntRect rect);
TextureManager* contentsTextureManager() const { return m_contentsTextureManager.get(); }
Modified: trunk/Source/WebKit/chromium/ChangeLog (92205 => 92206)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-02 17:37:47 UTC (rev 92205)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-02 17:53:44 UTC (rev 92206)
@@ -1,3 +1,14 @@
+2011-08-02 Nat Duca nd...@chromium.org
+
+[chromium] Remove resizeOnscreenContent from LRC. It can be derived.
+https://bugs.webkit.org/show_bug.cgi?id=65519
+
+Reviewed by James Robinson.
+
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::resize):
+(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
+
2011-08-01 Jean-luc Brouillet jean...@chromium.org
Removing old source files in gyp files that slow build
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (92205 => 92206)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-08-02 17:37:47 UTC (rev 92205)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-08-02 17:53:44 UTC (rev 92206)
@@ -1004,13 +1004,6 @@
m_client-didInvalidateRect(damagedRect);
}
}
-
-#if USE(ACCELERATED_COMPOSITING)
-if (m_layerRenderer isAcceleratedCompositingActive()) {
-m_layerRenderer-resizeOnscreenContent(IntSize(max(1, m_size.width),
- max(1, m_size.height)));
-}
-#endif
}
void WebViewImpl::willEndLiveResize()
@@ -2529,8 +2522,7 @@
m_client-didActivateAcceleratedCompositing(false);
} else if (m_layerRenderer) {
m_isAcceleratedCompositingActive = true;
-
[webkit-changes] [92209] trunk/LayoutTests
Title: [92209] trunk/LayoutTests
Revision 92209
Author ander...@apple.com
Date 2011-08-02 11:29:24 -0700 (Tue, 02 Aug 2011)
Log Message
Add Snow Leopard specific test results.
* platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
* platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
* platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
* platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (92208 => 92209)
--- trunk/LayoutTests/ChangeLog 2011-08-02 18:26:29 UTC (rev 92208)
+++ trunk/LayoutTests/ChangeLog 2011-08-02 18:29:24 UTC (rev 92209)
@@ -1,3 +1,12 @@
+2011-08-02 Anders Carlsson ander...@apple.com
+
+Add Snow Leopard specific test results.
+
+* platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
+* platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
+* platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
+* platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
+
2011-08-02 Ryosuke Niwa rn...@webkit.org
Remove time out expectation since media/track has been added to the skipped list on GTK.
Added: trunk/LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt (0 => 92209)
--- trunk/LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt 2011-08-02 18:29:24 UTC (rev 92209)
@@ -0,0 +1,15 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 343x18
+ text run at (0,0) width 343: Focus the field, focus away, then focus the field again.
+ RenderBlock {DIV} at (0,34) size 784x23
+RenderTextControl {INPUT} at (2,2) size 125x19 [bgcolor=#FF] [border: (2px inset #00)]
+RenderText {#text} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+layer at (13,47) size 119x13
+ RenderBlock {DIV} at (3,3) size 119x13
+caret: position 0 of child 0 {DIV} of {#shadow-root} of child 1 {INPUT} of child 3 {DIV} of body
Added: trunk/LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt (0 => 92209)
--- trunk/LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt 2011-08-02 18:29:24 UTC (rev 92209)
@@ -0,0 +1,16 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 382x18
+ text run at (0,0) width 382: Focus field with a placeholder, then type, then delete all text.
+ RenderBlock {DIV} at (0,34) size 784x23
+RenderTextControl {INPUT} at (2,2) size 125x19 [bgcolor=#FF] [border: (2px inset #00)]
+RenderText {#text} at (0,0) size 0x0
+RenderText {#text} at (0,0) size 0x0
+layer at (13,47) size 119x13
+ RenderBlock {DIV} at (3,3) size 119x13
+RenderBR {BR} at (1,0) size 0x13
+caret: position 0 of child 0 {BR} of child 0 {DIV} of {#shadow-root} of child 1 {INPUT} of child 3 {DIV} of body
Added: trunk/LayoutTests/platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt (0 => 92209)
--- trunk/LayoutTests/platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt 2011-08-02 18:29:24 UTC (rev 92209)
@@ -0,0 +1,16 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x18
+
[webkit-changes] [92210] trunk/Source
Title: [92210] trunk/Source Revision 92210 Author je...@apple.com Date 2011-08-02 11:29:59 -0700 (Tue, 02 Aug 2011) Log Message Move WTF_USE_AVFOUNDATION from _javascript_Core/wtf/platform.h to WebCore/config.h https://bugs.webkit.org/show_bug.cgi?id=65552 Since this is a WebCore feature, there's no need to define it in _javascript_Core/wtf/platform.h. Reviewed by Adam Roben. Source/_javascript_Core: * wtf/Platform.h: Removed WTF_USE_AVFOUNDATION. Source/WebCore: No change in functionality, so new tests. * config.h: Added WTF_USE_AVFOUNDATION. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/config.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (92209 => 92210) --- trunk/Source/_javascript_Core/ChangeLog 2011-08-02 18:29:24 UTC (rev 92209) +++ trunk/Source/_javascript_Core/ChangeLog 2011-08-02 18:29:59 UTC (rev 92210) @@ -1,3 +1,14 @@ +2011-08-02 Jeff Miller je...@apple.com + +Move WTF_USE_AVFOUNDATION from _javascript_Core/wtf/platform.h to WebCore/config.h +https://bugs.webkit.org/show_bug.cgi?id=65552 + +Since this is a WebCore feature, there's no need to define it in _javascript_Core/wtf/platform.h. + +Reviewed by Adam Roben. + +* wtf/Platform.h: Removed WTF_USE_AVFOUNDATION. + 2011-08-01 Jean-luc Brouillet jean...@chromium.org Removing old source files in gyp files that slow build Modified: trunk/Source/_javascript_Core/wtf/Platform.h (92209 => 92210) --- trunk/Source/_javascript_Core/wtf/Platform.h 2011-08-02 18:29:24 UTC (rev 92209) +++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-08-02 18:29:59 UTC (rev 92210) @@ -1153,10 +1153,6 @@ #define WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK 1 #endif -#if PLATFORM(MAC) !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) -#define WTF_USE_AVFOUNDATION 1 -#endif - #if COMPILER(GCC) #define WARN_UNUSED_RETURN __attribute__ ((warn_unused_result)) #else Modified: trunk/Source/WebCore/ChangeLog (92209 => 92210) --- trunk/Source/WebCore/ChangeLog 2011-08-02 18:29:24 UTC (rev 92209) +++ trunk/Source/WebCore/ChangeLog 2011-08-02 18:29:59 UTC (rev 92210) @@ -1,3 +1,16 @@ +2011-08-02 Jeff Miller je...@apple.com + +Move WTF_USE_AVFOUNDATION from _javascript_Core/wtf/platform.h to WebCore/config.h +https://bugs.webkit.org/show_bug.cgi?id=65552 + +Since this is a WebCore feature, there's no need to define it in _javascript_Core/wtf/platform.h. + +Reviewed by Adam Roben. + +No change in functionality, so new tests. + +* config.h: Added WTF_USE_AVFOUNDATION. + 2011-08-02 Alexandru Chiculita ach...@adobe.com Split RenderBlock::layoutRunsAndFloats into multiple methods Modified: trunk/Source/WebCore/config.h (92209 => 92210) --- trunk/Source/WebCore/config.h 2011-08-02 18:29:24 UTC (rev 92209) +++ trunk/Source/WebCore/config.h 2011-08-02 18:29:59 UTC (rev 92210) @@ -203,7 +203,6 @@ #endif #endif /* USE(CG) */ - #if PLATFORM(WIN) USE(CG) #define WTF_USE_SAFARI_THEME 1 #endif @@ -218,3 +217,7 @@ #include bridge/npruntime_internal.h #endif +#if PLATFORM(MAC) !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) +#define WTF_USE_AVFOUNDATION 1 +#endif + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92211] trunk/LayoutTests
Title: [92211] trunk/LayoutTests Revision 92211 Author z...@google.com Date 2011-08-02 11:32:12 -0700 (Tue, 02 Aug 2011) Log Message Unreviewed, test expectation updates, gardener stuff. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92210 => 92211) --- trunk/LayoutTests/ChangeLog 2011-08-02 18:29:59 UTC (rev 92210) +++ trunk/LayoutTests/ChangeLog 2011-08-02 18:32:12 UTC (rev 92211) @@ -1,3 +1,9 @@ +2011-08-02 Zhenyao Mo z...@google.com + +Unreviewed, test expectation updates, gardener stuff. + +* platform/chromium/test_expectations.txt: + 2011-08-02 Anders Carlsson ander...@apple.com Add Snow Leopard specific test results. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92210 => 92211) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 18:29:59 UTC (rev 92210) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 18:32:12 UTC (rev 92211) @@ -650,7 +650,7 @@ BUGWK62309 WIN DEBUG : inspector/styles/styles-disable-then-change.html = PASS TIMEOUT BUGCR89372 DEBUG : inspector/styles/styles-iframe.html = PASS TIMEOUT -BUGWK62309 WIN : inspector/styles/parse-utf8-bom.html = PASS TEXT +BUGWK62309 WIN LINUX DEBUG : inspector/styles/parse-utf8-bom.html = PASS TIMEOUT BUGWK62309 WIN : inspector/styles/styles-source-lines.html = PASS TEXT BUGPFELDMAN : inspector/debugger/debugger-activation-crash2.html = PASS TEXT TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92213] trunk
Title: [92213] trunk
Revision 92213
Author vse...@chromium.org
Date 2011-08-02 11:41:36 -0700 (Tue, 02 Aug 2011)
Log Message
Web Inspector: Remove initator column for JSC, fix network resource initiator tests.
https://bugs.webkit.org/show_bug.cgi?id=65534
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._toggleGridMode):
(WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
* inspector/front-end/Settings.js:
Source/WebKit/chromium:
* src/js/DevTools.js:
():
LayoutTests:
* http/tests/inspector/network/network-initiator-expected.txt:
* http/tests/inspector/network/network-initiator.html:
* platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Copied from LayoutTests/http/tests/inspector/network/network-initiator-expected.txt.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/network/network-initiator-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-initiator.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/DevTools.js
Added Paths
trunk/LayoutTests/platform/chromium/http/tests/inspector/network/network-initiator-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (92212 => 92213)
--- trunk/LayoutTests/ChangeLog 2011-08-02 18:32:46 UTC (rev 92212)
+++ trunk/LayoutTests/ChangeLog 2011-08-02 18:41:36 UTC (rev 92213)
@@ -1,3 +1,14 @@
+2011-08-02 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Remove initator column for JSC, fix network resource initiator tests.
+https://bugs.webkit.org/show_bug.cgi?id=65534
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/network/network-initiator-expected.txt:
+* http/tests/inspector/network/network-initiator.html:
+* platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Copied from LayoutTests/http/tests/inspector/network/network-initiator-expected.txt.
+
2011-08-02 Zhenyao Mo z...@google.com
Unreviewed, test expectation updates, gardener stuff.
Modified: trunk/LayoutTests/http/tests/inspector/network/network-initiator-expected.txt (92212 => 92213)
--- trunk/LayoutTests/http/tests/inspector/network/network-initiator-expected.txt 2011-08-02 18:32:46 UTC (rev 92212)
+++ trunk/LayoutTests/http/tests/inspector/network/network-initiator-expected.txt 2011-08-02 18:41:36 UTC (rev 92213)
@@ -11,8 +11,6 @@
http://127.0.0.1:8000/inspector/network/network-initiator.html 99
http://127.0.0.1:8000/inspector/network/resources/resource.php?type=imagerandom=1size=200: parser
http://127.0.0.1:8000/inspector/network/network-initiator.html 100
-http://127.0.0.1:8000/inspector/network/resources/resource.php?type=imagerandom=1size=300: script
-http://127.0.0.1:8000/inspector/network/network-initiator.html 17
-http://127.0.0.1:8000/inspector/network/resources/resource.php?type=imagerandom=1size=400: script
-http://127.0.0.1:8000/inspector/network/network-initiator.html 29
+http://127.0.0.1:8000/inspector/network/resources/resource.php?type=imagerandom=1size=300: other
+http://127.0.0.1:8000/inspector/network/resources/resource.php?type=imagerandom=1size=400: other
Modified: trunk/LayoutTests/http/tests/inspector/network/network-initiator.html (92212 => 92213)
--- trunk/LayoutTests/http/tests/inspector/network/network-initiator.html 2011-08-02 18:32:46 UTC (rev 92212)
+++ trunk/LayoutTests/http/tests/inspector/network/network-initiator.html 2011-08-02 18:41:36 UTC (rev 92213)
@@ -9,7 +9,7 @@
{
// We need to setTimeout, to make sure that style recalculation scheduling
// is really triggered by adding a class to the div.
-window.setTimeout(addClassToDivStep2.bind(this), 0);
+window.setTimeout(addClassToDivStep2, 0);
}
function addClassToDivStep2()
Copied: trunk/LayoutTests/platform/chromium/http/tests/inspector/network/network-initiator-expected.txt (from rev 92212, trunk/LayoutTests/http/tests/inspector/network/network-initiator-expected.txt) (0 => 92213)
--- trunk/LayoutTests/platform/chromium/http/tests/inspector/network/network-initiator-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/inspector/network/network-initiator-expected.txt 2011-08-02 18:41:36 UTC (rev 92213)
@@ -0,0 +1,18 @@
+CONSOLE MESSAGE: line 34: Done.
+Tests resources initiator for images initiated by IMG tag, static CSS, CSS class added from _javascript_ and XHR.
+
+Bug 65105
+This
[webkit-changes] [92214] branches/safari-534.51-branch
Title: [92214] branches/safari-534.51-branch Revision 92214 Author lforsch...@apple.com Date 2011-08-02 11:45:32 -0700 (Tue, 02 Aug 2011) Log Message Merge r91616. Modified Paths branches/safari-534.51-branch/Source/WebCore/ChangeLog branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in branches/safari-534.51-branch/Source/WebCore/platform/mac/WebCoreSystemInterface.h branches/safari-534.51-branch/Source/WebCore/platform/mac/WebCoreSystemInterface.mm branches/safari-534.51-branch/Source/WebKit2/ChangeLog branches/safari-534.51-branch/Source/WebKit2/WebProcess/Cookies/mac/WebCookieManagerMac.mm branches/safari-534.51-branch/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm branches/safari-534.51-branch/WebKitLibraries/ChangeLog branches/safari-534.51-branch/WebKitLibraries/WebKitSystemInterface.h branches/safari-534.51-branch/WebKitLibraries/libWebKitSystemInterfaceLeopard.a branches/safari-534.51-branch/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a Diff Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (92213 => 92214) --- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-08-02 18:41:36 UTC (rev 92213) +++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-08-02 18:45:32 UTC (rev 92214) @@ -1,3 +1,18 @@ +2011-08-02 Lucas Forschler lforsch...@apple.com + +Merged 91616. + +2011-07-22 Jessie Berlin jber...@apple.com + +[WebKit2] Changing the cookie accept policy in Private Browsing doesn’t work +https://bugs.webkit.org/show_bug.cgi?id=64997 + +Reviewed by Ada Chan. + +* WebCore.exp.in: +* platform/mac/WebCoreSystemInterface.h: +* platform/mac/WebCoreSystemInterface.mm: + 2011-07-29 Lucas Forschler lforsch...@apple.com Merged 91222. Modified: branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in (92213 => 92214) --- branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in 2011-08-02 18:41:36 UTC (rev 92213) +++ branches/safari-534.51-branch/Source/WebCore/WebCore.exp.in 2011-08-02 18:45:32 UTC (rev 92214) @@ -1394,6 +1394,7 @@ _wkSetCONNECTProxyForStream _wkSetCookieStoragePrivateBrowsingEnabled _wkSetDragImage +_wkSetHTTPCookieAcceptPolicy _wkSetHTTPCookiesForURL _wkSetHTTPPipeliningMaximumPriority _wkSetHTTPPipeliningMinimumFastLanePriority Modified: branches/safari-534.51-branch/Source/WebCore/platform/mac/WebCoreSystemInterface.h (92213 => 92214) --- branches/safari-534.51-branch/Source/WebCore/platform/mac/WebCoreSystemInterface.h 2011-08-02 18:41:36 UTC (rev 92213) +++ branches/safari-534.51-branch/Source/WebCore/platform/mac/WebCoreSystemInterface.h 2011-08-02 18:45:32 UTC (rev 92214) @@ -296,6 +296,7 @@ typedef struct OpaqueCFHTTPCookieStorage* CFHTTPCookieStorageRef; extern CFHTTPCookieStorageRef (*wkCopyHTTPCookieStorage)(CFURLStorageSessionRef); extern unsigned (*wkGetHTTPCookieAcceptPolicy)(CFHTTPCookieStorageRef); +extern void (*wkSetHTTPCookieAcceptPolicy)(CFHTTPCookieStorageRef, unsigned); extern NSArray *(*wkHTTPCookiesForURL)(CFHTTPCookieStorageRef, NSURL *); extern void (*wkSetHTTPCookiesForURL)(CFHTTPCookieStorageRef, NSArray *, NSURL *, NSURL *); extern void (*wkDeleteHTTPCookie)(CFHTTPCookieStorageRef, NSHTTPCookie *); Modified: branches/safari-534.51-branch/Source/WebCore/platform/mac/WebCoreSystemInterface.mm (92213 => 92214) --- branches/safari-534.51-branch/Source/WebCore/platform/mac/WebCoreSystemInterface.mm 2011-08-02 18:41:36 UTC (rev 92213) +++ branches/safari-534.51-branch/Source/WebCore/platform/mac/WebCoreSystemInterface.mm 2011-08-02 18:45:32 UTC (rev 92214) @@ -183,6 +183,7 @@ NSURLRequest* (*wkCopyRequestWithStorageSession)(CFURLStorageSessionRef, NSURLRequest*); CFHTTPCookieStorageRef (*wkCopyHTTPCookieStorage)(CFURLStorageSessionRef); unsigned (*wkGetHTTPCookieAcceptPolicy)(CFHTTPCookieStorageRef); +void (*wkSetHTTPCookieAcceptPolicy)(CFHTTPCookieStorageRef, unsigned); NSArray *(*wkHTTPCookiesForURL)(CFHTTPCookieStorageRef, NSURL *); void (*wkSetHTTPCookiesForURL)(CFHTTPCookieStorageRef, NSArray *, NSURL *, NSURL *); void (*wkDeleteHTTPCookie)(CFHTTPCookieStorageRef, NSHTTPCookie *); Modified: branches/safari-534.51-branch/Source/WebKit2/ChangeLog (92213 => 92214) --- branches/safari-534.51-branch/Source/WebKit2/ChangeLog 2011-08-02 18:41:36 UTC (rev 92213) +++ branches/safari-534.51-branch/Source/WebKit2/ChangeLog 2011-08-02 18:45:32 UTC (rev 92214) @@ -1,3 +1,20 @@ +2011-08-02 Lucas Forschler lforsch...@apple.com + +Merged 91616. + +2011-07-22 Jessie Berlin jber...@apple.com + +[WebKit2] Changing the cookie accept policy in Private Browsing doesn’t work. +https://bugs.webkit.org/show_bug.cgi?id=64997 + +Reviewed by Ada Chan. + +* WebProcess/Cookies/mac/WebCookieManagerMac.mm: +(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): +Set the policy on the Cookie Storage used by the Private Browsing Storage Session as
[webkit-changes] [92215] trunk/LayoutTests
Title: [92215] trunk/LayoutTests Revision 92215 Author z...@google.com Date 2011-08-02 12:15:04 -0700 (Tue, 02 Aug 2011) Log Message Unreviewed, rebaseline, gardener stuff. * platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: * platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png trunk/LayoutTests/platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (92214 => 92215) --- trunk/LayoutTests/ChangeLog 2011-08-02 18:45:32 UTC (rev 92214) +++ trunk/LayoutTests/ChangeLog 2011-08-02 19:15:04 UTC (rev 92215) @@ -1,3 +1,11 @@ +2011-08-02 Zhenyao Mo z...@google.com + +Unreviewed, rebaseline, gardener stuff. + +* platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: +* platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: +* platform/chromium/test_expectations.txt: + 2011-08-02 Vsevolod Vlasov vse...@chromium.org Web Inspector: Remove initator column for JSC, fix network resource initiator tests. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92214 => 92215) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 18:45:32 UTC (rev 92214) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 19:15:04 UTC (rev 92215) @@ -3655,10 +3655,6 @@ BUGWK65462 VISTA : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT -// Just needs rebaselines? -BUGWK65524 WIN : fast/text/international/bidi-mirror-he-ar.html = IMAGE -BUGWK65524 WIN : fast/text/justify-ideograph-leading-expansion.html = IMAGE - // The expectations were modified by http://trac.webkit.org/changeset/92165 // May just need rebaselines. BUG_HAMAJI MAC : fast/forms/input-placeholder-visibility-1.html = TEXT Modified: trunk/LayoutTests/platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92216] trunk/Source/WebKit/efl
Title: [92216] trunk/Source/WebKit/efl
Revision 92216
Author commit-qu...@webkit.org
Date 2011-08-02 12:50:06 -0700 (Tue, 02 Aug 2011)
Log Message
[EFL] Ignore empty requests on policy decisions.
https://bugs.webkit.org/show_bug.cgi?id=64536
Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-08-02
Reviewed by Kenneth Rohde Christiansen.
This is the same fix introduced in the GTK+ port in r41313: empty
request should be ignored, so tests such as
fast/loader/empty-embed-src-attribute.html do not crash.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (92215 => 92216)
--- trunk/Source/WebKit/efl/ChangeLog 2011-08-02 19:15:04 UTC (rev 92215)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-08-02 19:50:06 UTC (rev 92216)
@@ -1,3 +1,19 @@
+2011-08-02 Raphael Kubo da Costa k...@profusion.mobi
+
+[EFL] Ignore empty requests on policy decisions.
+https://bugs.webkit.org/show_bug.cgi?id=64536
+
+Reviewed by Kenneth Rohde Christiansen.
+
+This is the same fix introduced in the GTK+ port in r41313: empty
+request should be ignored, so tests such as
+fast/loader/empty-embed-src-attribute.html do not crash.
+
+* WebCoreSupport/FrameLoaderClientEfl.cpp:
+(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
+(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
+(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
+
2011-08-02 Eunsol Park eunsol47.p...@samsung.com
[EFL] Remove overlapping recursive layout function
Modified: trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp (92215 => 92216)
--- trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp 2011-08-02 19:15:04 UTC (rev 92215)
+++ trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp 2011-08-02 19:50:06 UTC (rev 92216)
@@ -283,20 +283,32 @@
m_response = response;
}
-void FrameLoaderClientEfl::dispatchDecidePolicyForResponse(FramePolicyFunction function, const ResourceResponse response, const ResourceRequest)
+void FrameLoaderClientEfl::dispatchDecidePolicyForResponse(FramePolicyFunction function, const ResourceResponse response, const ResourceRequest resourceRequest)
{
// we need to call directly here (currently callPolicyFunction does that!)
ASSERT(function);
+
+if (resourceRequest.isNull()) {
+callPolicyFunction(function, PolicyIgnore);
+return;
+}
+
if (canShowMIMEType(response.mimeType()))
callPolicyFunction(function, PolicyUse);
else
callPolicyFunction(function, PolicyDownload);
}
-void FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function, const NavigationAction action, const ResourceRequest, PassRefPtrFormState, const String)
+void FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function, const NavigationAction action, const ResourceRequest resourceRequest, PassRefPtrFormState, const String)
{
ASSERT(function);
ASSERT(m_frame);
+
+if (resourceRequest.isNull()) {
+callPolicyFunction(function, PolicyIgnore);
+return;
+}
+
// if not acceptNavigationRequest - look at Qt - PolicyIgnore;
// FIXME: do proper check and only reset forms when on PolicyIgnore
Frame* f = ewk_frame_core_get(m_frame);
@@ -308,6 +320,12 @@
{
ASSERT(function);
ASSERT(m_frame);
+
+if (resourceRequest.isNull()) {
+callPolicyFunction(function, PolicyIgnore);
+return;
+}
+
// if not acceptNavigationRequest - look at Qt - PolicyIgnore;
// FIXME: do proper check and only reset forms when on PolicyIgnore
char* url = ""
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92217] trunk/Source/JavaScriptCore
Title: [92217] trunk/Source/_javascript_Core
Revision 92217
Author fpi...@apple.com
Date 2011-08-02 12:57:06 -0700 (Tue, 02 Aug 2011)
Log Message
JSC does a GC even when the heap still has free pages
https://bugs.webkit.org/show_bug.cgi?id=65445
Reviewed by Oliver Hunt.
If the high watermark is not reached, then we allocate new blocks as
before. If the current watermark does reach (or exceed) the high
watermark, then we check if there is a block on the free block pool.
If there is, we simply allocation from it. If there isn't, we
invoke a collectin as before. This effectively couples the elastic
scavenging to the collector's decision function. That is, if an
application rapidly varies its heap usage (sometimes using more and
sometimes less) then the collector will not thrash as it used to.
But if heap usage drops and stays low then the scavenger thread and
the GC will eventually reach a kind of consensus: the GC will set
the watermark low because of low heap usage, and the scavenger thread
will steadily eliminate pages from the free page pool, until the size
of the free pool is below the high watermark.
On command-line, this is neutral on SunSpider and Kraken and a 3% win
on V8. In browser, this is a 1% win on V8 and neutral on the other
two.
* heap/Heap.cpp:
(JSC::Heap::allocateSlowCase):
(JSC::Heap::allocateBlock):
* heap/Heap.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (92216 => 92217)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-02 19:50:06 UTC (rev 92216)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-02 19:57:06 UTC (rev 92217)
@@ -1,3 +1,33 @@
+2011-08-02 Filip Pizlo fpi...@apple.com
+
+JSC does a GC even when the heap still has free pages
+https://bugs.webkit.org/show_bug.cgi?id=65445
+
+Reviewed by Oliver Hunt.
+
+If the high watermark is not reached, then we allocate new blocks as
+before. If the current watermark does reach (or exceed) the high
+watermark, then we check if there is a block on the free block pool.
+If there is, we simply allocation from it. If there isn't, we
+invoke a collectin as before. This effectively couples the elastic
+scavenging to the collector's decision function. That is, if an
+application rapidly varies its heap usage (sometimes using more and
+sometimes less) then the collector will not thrash as it used to.
+But if heap usage drops and stays low then the scavenger thread and
+the GC will eventually reach a kind of consensus: the GC will set
+the watermark low because of low heap usage, and the scavenger thread
+will steadily eliminate pages from the free page pool, until the size
+of the free pool is below the high watermark.
+
+On command-line, this is neutral on SunSpider and Kraken and a 3% win
+on V8. In browser, this is a 1% win on V8 and neutral on the other
+two.
+
+* heap/Heap.cpp:
+(JSC::Heap::allocateSlowCase):
+(JSC::Heap::allocateBlock):
+* heap/Heap.h:
+
2011-08-02 Jeff Miller je...@apple.com
Move WTF_USE_AVFOUNDATION from _javascript_Core/wtf/platform.h to WebCore/config.h
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (92216 => 92217)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2011-08-02 19:50:06 UTC (rev 92216)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2011-08-02 19:57:06 UTC (rev 92217)
@@ -404,8 +404,16 @@
if (LIKELY(result != 0))
return result;
-if (m_newSpace.waterMark() m_newSpace.highWaterMark() || !m_isSafeToCollect) {
-m_newSpace.addBlock(sizeClass, allocateBlock(sizeClass.cellSize));
+AllocationEffort allocationEffort;
+
+if (m_newSpace.waterMark() m_newSpace.highWaterMark() || !m_isSafeToCollect)
+allocationEffort = AllocationMustSucceed;
+else
+allocationEffort = AllocationCanFail;
+
+MarkedBlock* block = allocateBlock(sizeClass.cellSize, allocationEffort);
+if (block) {
+m_newSpace.addBlock(sizeClass, block);
void* result = tryAllocate(sizeClass);
ASSERT(result);
return result;
@@ -420,7 +428,7 @@
ASSERT(m_newSpace.waterMark() m_newSpace.highWaterMark());
-m_newSpace.addBlock(sizeClass, allocateBlock(sizeClass.cellSize));
+m_newSpace.addBlock(sizeClass, allocateBlock(sizeClass.cellSize, AllocationMustSucceed));
result = tryAllocate(sizeClass);
ASSERT(result);
@@ -694,11 +702,14 @@
return true;
}
-MarkedBlock* Heap::allocateBlock(size_t cellSize)
+MarkedBlock* Heap::allocateBlock(size_t cellSize, Heap::AllocationEffort allocationEffort)
{
MarkedBlock* block;
#if !ENABLE(LAZY_BLOCK_FREEING)
+if (allocationEffort == AllocationCanFail)
+
[webkit-changes] [92219] trunk
Title: [92219] trunk
Revision 92219
Author joc...@chromium.org
Date 2011-08-02 13:00:46 -0700 (Tue, 02 Aug 2011)
Log Message
Tools: Implement WebPermissionClient::allowPlugins for layout tests
https://bugs.webkit.org/show_bug.cgi?id=33991
Reviewed by Adam Barth.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setPluginsAllowed):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/WebPermissions.cpp:
(WebPermissions::allowPlugins):
(WebPermissions::setPluginsAllowed):
(WebPermissions::reset):
* DumpRenderTree/chromium/WebPermissions.h:
LayoutTests: Add a test for FrameLoaderClient::allowPlugins
https://bugs.webkit.org/show_bug.cgi?id=33991
Reviewed by Adam Barth.
* platform/chromium/permissionclient/plugin-permission-expected.txt: Added.
* platform/chromium/permissionclient/plugin-permission.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h
trunk/Tools/DumpRenderTree/chromium/WebPermissions.cpp
trunk/Tools/DumpRenderTree/chromium/WebPermissions.h
Added Paths
trunk/LayoutTests/platform/chromium/permissionclient/plugin-permission-expected.txt
trunk/LayoutTests/platform/chromium/permissionclient/plugin-permission.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92218 => 92219)
--- trunk/LayoutTests/ChangeLog 2011-08-02 19:57:38 UTC (rev 92218)
+++ trunk/LayoutTests/ChangeLog 2011-08-02 20:00:46 UTC (rev 92219)
@@ -1,3 +1,13 @@
+2011-08-02 Jochen Eisinger joc...@chromium.org
+
+Add a test for FrameLoaderClient::allowPlugins
+https://bugs.webkit.org/show_bug.cgi?id=33991
+
+Reviewed by Adam Barth.
+
+* platform/chromium/permissionclient/plugin-permission-expected.txt: Added.
+* platform/chromium/permissionclient/plugin-permission.html: Added.
+
2011-08-02 Zhenyao Mo z...@google.com
Unreviewed, rebaseline, gardener stuff.
Added: trunk/LayoutTests/platform/chromium/permissionclient/plugin-permission-expected.txt (0 => 92219)
--- trunk/LayoutTests/platform/chromium/permissionclient/plugin-permission-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/permissionclient/plugin-permission-expected.txt 2011-08-02 20:00:46 UTC (rev 92219)
@@ -0,0 +1,3 @@
+
+PASS: first plugin loaded
+
Added: trunk/LayoutTests/platform/chromium/permissionclient/plugin-permission.html (0 => 92219)
--- trunk/LayoutTests/platform/chromium/permissionclient/plugin-permission.html (rev 0)
+++ trunk/LayoutTests/platform/chromium/permissionclient/plugin-permission.html 2011-08-02 20:00:46 UTC (rev 92219)
@@ -0,0 +1,54 @@
+html
+head
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function log(a)
+{
+document.getElementById(results).innerHTML += a + br;
+}
+
+function test()
+{
+var plugin = document.createElement('embed');
+plugin.setAttribute(type, application/x-webkit-test-netscape);
+plugin.setAttribute(onNew, loadedFirst());
+document.getElementById(plugins).appendChild(plugin);
+}
+
+function done()
+{
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+function loadedFirst()
+{
+log(PASS: first plugin loaded);
+if (window.layoutTestController layoutTestController.setPluginsAllowed)
+layoutTestController.setPluginsAllowed(false);
+else
+log(This test requires layoutTestController.setPluginsAllowed, so it be can't run in a browser.);
+
+var plugin = document.createElement('embed');
+plugin.setAttribute(type, application/x-webkit-test-netscape);
+plugin.setAttribute(onNew, loadedSecond());
+document.getElementById(plugins).appendChild(plugin);
+window.setTimeout(done, 5);
+}
+
+function loadedSecond()
+{
+log(FAIL: second plugin loaded);
+}
+/script
+/head
+body _onload_=test()
+ div id=plugins
+ /div
+ div id=results/div
+/body
+/html
Modified: trunk/Tools/ChangeLog (92218 => 92219)
--- trunk/Tools/ChangeLog 2011-08-02 19:57:38 UTC (rev 92218)
+++ trunk/Tools/ChangeLog 2011-08-02 20:00:46 UTC (rev 92219)
@@ -1,3 +1,20 @@
+2011-08-02 Jochen Eisinger joc...@chromium.org
+
+Implement WebPermissionClient::allowPlugins for layout tests
+https://bugs.webkit.org/show_bug.cgi?id=33991
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/LayoutTestController.cpp:
+(LayoutTestController::LayoutTestController):
+(LayoutTestController::setPluginsAllowed):
+* DumpRenderTree/chromium/LayoutTestController.h:
+* DumpRenderTree/chromium/WebPermissions.cpp:
+(WebPermissions::allowPlugins):
+(WebPermissions::setPluginsAllowed):
+(WebPermissions::reset):
+*
[webkit-changes] [92220] trunk/Tools
Title: [92220] trunk/Tools Revision 92220 Author commit-qu...@webkit.org Date 2011-08-02 13:06:53 -0700 (Tue, 02 Aug 2011) Log Message Buildbot: The Properties object has no hasProperty method in buildbot 8.3 https://bugs.webkit.org/show_bug.cgi?id=65554 Using has_key instead of hasProperty in order to support buildbot 8.3. Patch by Alexandru Chiculita ach...@adobe.com on 2011-08-02 Reviewed by Adam Roben. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (92219 => 92220) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-08-02 20:00:46 UTC (rev 92219) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-08-02 20:06:53 UTC (rev 92220) @@ -140,7 +140,7 @@ @staticmethod def determineExtraFeatures(properties): -if not properties.hasProperty(features): +if not properties.has_key(features): return '' features = properties.getProperty(features) if not len(features): Modified: trunk/Tools/ChangeLog (92219 => 92220) --- trunk/Tools/ChangeLog 2011-08-02 20:00:46 UTC (rev 92219) +++ trunk/Tools/ChangeLog 2011-08-02 20:06:53 UTC (rev 92220) @@ -1,3 +1,14 @@ +2011-08-02 Alexandru Chiculita ach...@adobe.com + +Buildbot: The Properties object has no hasProperty method in buildbot 8.3 +https://bugs.webkit.org/show_bug.cgi?id=65554 + +Using has_key instead of hasProperty in order to support buildbot 8.3. + +Reviewed by Adam Roben. + +* BuildSlaveSupport/build.webkit.org-config/master.cfg: + 2011-08-02 Jochen Eisinger joc...@chromium.org Implement WebPermissionClient::allowPlugins for layout tests ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92222] trunk/LayoutTests
Title: [9] trunk/LayoutTests Revision 9 Author z...@google.com Date 2011-08-02 13:31:29 -0700 (Tue, 02 Aug 2011) Log Message Unreviewed, test expectations update, gardener stuff. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92221 => 9) --- trunk/LayoutTests/ChangeLog 2011-08-02 20:12:07 UTC (rev 92221) +++ trunk/LayoutTests/ChangeLog 2011-08-02 20:31:29 UTC (rev 9) @@ -1,3 +1,9 @@ +2011-08-02 Zhenyao Mo z...@google.com + +Unreviewed, test expectations update, gardener stuff. + +* platform/chromium/test_expectations.txt: + 2011-08-02 Jochen Eisinger joc...@chromium.org Add a test for FrameLoaderClient::allowPlugins Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92221 => 9) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 20:12:07 UTC (rev 92221) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 20:31:29 UTC (rev 9) @@ -654,6 +654,9 @@ BUGWK62309 WIN : inspector/styles/styles-source-lines.html = PASS TEXT BUGPFELDMAN : inspector/debugger/debugger-activation-crash2.html = PASS TEXT TIMEOUT + +BUGWK65558 WIN LINUX : http/tests/inspector/network/disabled-cache-crash.html = PASS TEXT MISSING + // - // Other // - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92224] trunk/Source
Title: [92224] trunk/Source
Revision 92224
Author fpi...@apple.com
Date 2011-08-02 13:40:17 -0700 (Tue, 02 Aug 2011)
Log Message
JSC GC is far too conservative about growing the heap size, particularly
on desktop platforms
https://bugs.webkit.org/show_bug.cgi?id=65438
Reviewed by Oliver Hunt.
Source/_javascript_Core:
The minimum heap size is now 16MB instead of 512KB, provided all of the
following are true:
a) ENABLE(LARGE_HEAP) is set, which currently only happens on
x86 targets, but could reasonably happen on any platform that is
known to have a decent amount of RAM.
b) JSGlobalData is initialized with HeapSize = LargeHeap, which
currently only happens when it's the JSDOMWindowBase in WebCore or
in the jsc command-line tool.
This is a 4.1% speed-up on SunSpider.
* _javascript_Core.exp:
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collect):
* heap/Heap.h:
* jsc.cpp:
(main):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::createLeaked):
(JSC::JSGlobalData::sharedInstance):
* runtime/JSGlobalData.h:
* wtf/Platform.h:
Source/WebCore:
No change in behavior, thus no new tests.
Pass the LargeHeap hint to JSGlobalData when creating the JSC runtime
instance corresponding to non-worker JS code.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (92223 => 92224)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-02 20:38:04 UTC (rev 92223)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-02 20:40:17 UTC (rev 92224)
@@ -1,5 +1,40 @@
2011-08-02 Filip Pizlo fpi...@apple.com
+JSC GC is far too conservative about growing the heap size, particularly
+on desktop platforms
+https://bugs.webkit.org/show_bug.cgi?id=65438
+
+Reviewed by Oliver Hunt.
+
+The minimum heap size is now 16MB instead of 512KB, provided all of the
+following are true:
+a) ENABLE(LARGE_HEAP) is set, which currently only happens on
+ x86 targets, but could reasonably happen on any platform that is
+ known to have a decent amount of RAM.
+b) JSGlobalData is initialized with HeapSize = LargeHeap, which
+ currently only happens when it's the JSDOMWindowBase in WebCore or
+ in the jsc command-line tool.
+
+This is a 4.1% speed-up on SunSpider.
+
+* _javascript_Core.exp:
+* heap/Heap.cpp:
+(JSC::Heap::Heap):
+(JSC::Heap::collect):
+* heap/Heap.h:
+* jsc.cpp:
+(main):
+* runtime/JSGlobalData.cpp:
+(JSC::JSGlobalData::JSGlobalData):
+(JSC::JSGlobalData::createContextGroup):
+(JSC::JSGlobalData::create):
+(JSC::JSGlobalData::createLeaked):
+(JSC::JSGlobalData::sharedInstance):
+* runtime/JSGlobalData.h:
+* wtf/Platform.h:
+
+2011-08-02 Filip Pizlo fpi...@apple.com
+
JSC does a GC even when the heap still has free pages
https://bugs.webkit.org/show_bug.cgi?id=65445
Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (92223 => 92224)
--- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-08-02 20:38:04 UTC (rev 92223)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp 2011-08-02 20:40:17 UTC (rev 92224)
@@ -125,7 +125,7 @@
__ZN3JSC12DateInstanceC1EPNS_9ExecStateEPNS_9StructureEd
__ZN3JSC12JSGlobalData10ClientDataD2Ev
__ZN3JSC12JSGlobalData11jsArrayVPtrE
-__ZN3JSC12JSGlobalData12createLeakedENS_15ThreadStackTypeE
+__ZN3JSC12JSGlobalData12createLeakedENS_15ThreadStackTypeENS_8HeapSizeE
__ZN3JSC12JSGlobalData12jsStringVPtrE
__ZN3JSC12JSGlobalData12stopSamplingEv
__ZN3JSC12JSGlobalData13startSamplingEv
@@ -137,7 +137,7 @@
#ifndef NDEBUG
__ZN3JSC12JSGlobalData23releaseExecutableMemoryEv
#endif
-__ZN3JSC12JSGlobalData6createENS_15ThreadStackTypeE
+__ZN3JSC12JSGlobalData6createENS_15ThreadStackTypeENS_8HeapSizeE
__ZN3JSC12JSGlobalDataD1Ev
__ZN3JSC12RegExpObject6s_infoE
__ZN3JSC12RegExpObjectC1EPNS_14JSGlobalObjectEPNS_9StructureEPNS_6RegExpE
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (92223 => 92224)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2011-08-02 20:38:04 UTC (rev 92223)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2011-08-02 20:40:17 UTC (rev 92224)
@@ -42,7 +42,15 @@
namespace {
-const size_t minBytesPerCycle = 512 * 1024;
+static size_t
[webkit-changes] [92226] trunk/Source/JavaScriptCore
Title: [92226] trunk/Source/_javascript_Core Revision 92226 Author ander...@apple.com Date 2011-08-02 13:52:12 -0700 (Tue, 02 Aug 2011) Log Message Fix a Windows build error. * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def Diff Modified: trunk/Source/_javascript_Core/ChangeLog (92225 => 92226) --- trunk/Source/_javascript_Core/ChangeLog 2011-08-02 20:47:40 UTC (rev 92225) +++ trunk/Source/_javascript_Core/ChangeLog 2011-08-02 20:52:12 UTC (rev 92226) @@ -1,3 +1,9 @@ +2011-08-02 Anders Carlsson ander...@apple.com + +Fix a Windows build error. + +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: + 2011-08-02 Filip Pizlo fpi...@apple.com JSC GC is far too conservative about growing the heap size, particularly Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (92225 => 92226) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-08-02 20:47:40 UTC (rev 92225) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-08-02 20:52:12 UTC (rev 92226) @@ -96,13 +96,11 @@ ?convertUTF8ToUTF16@Unicode@WTF@@YA?AW4ConversionResult@12@PAPBDPBDPAPA_WPA_W_N@Z ?create@ByteArray@WTF@@SA?AV?$PassRefPtr@VByteArray@WTF@@@2@I@Z ?create@JSByteArray@JSC@@SAPAV12@PAVExecState@2@PAVStructure@2@PAVByteArray@WTF@@@Z -?create@JSGlobalData@JSC@@SA?AV?$PassRefPtr@VJSGlobalData@JSC@@@WTF@@W4ThreadStackType@2@@Z ?create@OpaqueJSString@@SA?AV?$PassRefPtr@UOpaqueJSString@@@WTF@@ABVUString@JSC@@@Z ?create@RegExp@JSC@@SAPAV12@AAVJSGlobalData@2@ABVUString@2@W4RegExpFlags@2@@Z ?createEmptyString@SmallStrings@JSC@@AAEXPAVJSGlobalData@2@@Z ?createError@JSC@@YAPAVJSObject@1@PAVExecState@1@ABVUString@1@@Z ?createInterruptedExecutionException@JSC@@YAPAVJSObject@1@PAVJSGlobalData@1@@Z -?createLeaked@JSGlobalData@JSC@@SA?AV?$PassRefPtr@VJSGlobalData@JSC@@@WTF@@W4ThreadStackType@2@@Z ?createRangeError@JSC@@YAPAVJSObject@1@PAVExecState@1@ABVUString@1@@Z ?createReferenceError@JSC@@YAPAVJSObject@1@PAVExecState@1@ABVUString@1@@Z ?createSingleCharacterString@SmallStrings@JSC@@AAEXPAVJSGlobalData@2@E@Z ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92227] trunk/Source/WebCore
Title: [92227] trunk/Source/WebCore
Revision 92227
Author senorbla...@chromium.org
Date 2011-08-02 14:06:10 -0700 (Tue, 02 Aug 2011)
Log Message
[Chromium] Remove an unnecessary readback during accelerated
canvas-to-canvas draws.
https://bugs.webkit.org/show_bug.cgi?id=65560
Reviewed by James Robinson.
No new tests. (Printing has few tests, sadly.)
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::draw):
Revert most of the changes to this file from
http://trac.webkit.org/changeset/91870, except for the call which makes
the source context current, so that the readPixels() still works.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92226 => 92227)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 20:52:12 UTC (rev 92226)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 21:06:10 UTC (rev 92227)
@@ -1,3 +1,20 @@
+2011-08-02 Stephen White senorbla...@chromium.org
+
+[Chromium] Remove an unnecessary readback during accelerated
+canvas-to-canvas draws.
+https://bugs.webkit.org/show_bug.cgi?id=65560
+
+Reviewed by James Robinson.
+
+No new tests. (Printing has few tests, sadly.)
+
+* platform/graphics/skia/ImageBufferSkia.cpp:
+(WebCore::ImageBuffer::draw):
+Revert most of the changes to this file from
+http://trac.webkit.org/changeset/91870, except for the call which makes
+the source context current, so that the readPixels() still works.
+
+
2011-08-02 Filip Pizlo fpi...@apple.com
JSC GC is far too conservative about growing the heap size, particularly
Modified: trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (92226 => 92227)
--- trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2011-08-02 20:52:12 UTC (rev 92226)
+++ trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2011-08-02 21:06:10 UTC (rev 92227)
@@ -112,12 +112,15 @@
void ImageBuffer::draw(GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect destRect, const FloatRect srcRect,
CompositeOperator op, bool useLowQualityScale)
{
+// Set both graphics contexts current. This looks a little weird, but is
+// necessary since we may be drawing from an accelerated to
+// non-accelerated context (e.g., printing), or vice versa. Note that it
+// only works because the context is actually the same underlying context
+// (or null), since we use one context for accelerated drawing. If that
+// assumption changes, we'll have to revisit this code.
+context-platformContext()-makeGrContextCurrent();
m_context-platformContext()-makeGrContextCurrent();
-SkDevice* srcDevice = m_context-platformContext()-canvas()-getDevice();
-SkBitmap bitmap = srcDevice-accessBitmap(false);
-SkAutoLockPixels bitmapLock(bitmap);
-context-platformContext()-makeGrContextCurrent();
-RefPtrImage image = BitmapImageSingleFrameSkia::create(bitmap, context == m_context);
+RefPtrImage image = BitmapImageSingleFrameSkia::create(*m_data.m_platformContext.bitmap(), context == m_context);
context-drawImage(image.get(), styleColorSpace, destRect, srcRect, op, useLowQualityScale);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92228] trunk/LayoutTests
Title: [92228] trunk/LayoutTests
Revision 92228
Author ander...@apple.com
Date 2011-08-02 14:06:38 -0700 (Tue, 02 Aug 2011)
Log Message
Reviewed by Sam Weinig.
* fast/blockflow/japanese-rl-text-with-broken-font.html:
This test would create an empty RenderText after the change to make it asynchronous.
Fix this by putting the script inside the head.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/blockflow/japanese-rl-text-with-broken-font.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92227 => 92228)
--- trunk/LayoutTests/ChangeLog 2011-08-02 21:06:10 UTC (rev 92227)
+++ trunk/LayoutTests/ChangeLog 2011-08-02 21:06:38 UTC (rev 92228)
@@ -1,3 +1,11 @@
+2011-08-02 Anders Carlsson ander...@apple.com
+
+Reviewed by Sam Weinig.
+
+* fast/blockflow/japanese-rl-text-with-broken-font.html:
+This test would create an empty RenderText after the change to make it asynchronous.
+Fix this by putting the script inside the head.
+
2011-08-02 Van Lam van...@google.com
--webkit-visual-word: ctrl-arrow is not able to reach the boundary of line
Modified: trunk/LayoutTests/fast/blockflow/japanese-rl-text-with-broken-font.html (92227 => 92228)
--- trunk/LayoutTests/fast/blockflow/japanese-rl-text-with-broken-font.html 2011-08-02 21:06:10 UTC (rev 92227)
+++ trunk/LayoutTests/fast/blockflow/japanese-rl-text-with-broken-font.html 2011-08-02 21:06:38 UTC (rev 92228)
@@ -12,14 +12,17 @@
font-size: 16pt;
}
/style
+script
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+window._onload_ = function() {
+document.body.offsetTop;
+if (window.layoutTestController)
+setTimeout(function() { layoutTestController.notifyDone(); }, 100);
+}
+/script
/head
body style=border:5px solid black;
せっかく見つけたすばらしい記事がどこにあったか忘れてしまった経験はありますかならタイトルとアドレスだけでなく、訪問したウェブページのコンテンツからも検索することができます。せっかく見つけたすばらしい記事がどこにあったか忘れてしまった経験はありますか ならタイトルとアドレスだけでなく、訪問したウェブページのコンテンツからも検索することができます。訪問したウェブページのコンテンツからも検索することができます。せっかく見つけたすばらしい記事がどこにあったか忘れてしまった経験はありますか ならタイトルとアドレスだけでなく、訪問
-script
-if (window.layoutTestController) {
-layoutTestController.waitUntilDone();
-document.body.offsetTop;
-setTimeout(function() { layoutTestController.notifyDone(); }, 100);
-}
-/script
/body
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92229] trunk/LayoutTests
Title: [92229] trunk/LayoutTests Revision 92229 Author z...@google.com Date 2011-08-02 14:08:18 -0700 (Tue, 02 Aug 2011) Log Message Unreviewed, test expectations update, gardener stuff. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92228 => 92229) --- trunk/LayoutTests/ChangeLog 2011-08-02 21:06:38 UTC (rev 92228) +++ trunk/LayoutTests/ChangeLog 2011-08-02 21:08:18 UTC (rev 92229) @@ -1,3 +1,9 @@ +2011-08-02 Zhenyao Mo z...@google.com + +Unreviewed, test expectations update, gardener stuff. + +* platform/chromium/test_expectations.txt: + 2011-08-02 Anders Carlsson ander...@apple.com Reviewed by Sam Weinig. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92228 => 92229) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 21:06:38 UTC (rev 92228) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-02 21:08:18 UTC (rev 92229) @@ -1575,6 +1575,8 @@ BUGCR26042 DEBUG : http/tests/security/mixedContent/insecure-plugin-in-iframe.html = PASS TEXT BUGCR26042 LINUX RELEASE : http/tests/security/mixedContent/insecure-plugin-in-iframe.html = PASS TEXT +BUGWK65567 WIN LINUX DEBUG : http/tests/security/mixedContent/insecure-script-in-iframe.html = PASS TEXT + // Incorrect baseline removed. BUGCR25433 WIN LINUX : css2.1/t040103-ident-03-c.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92230] trunk/Source/JavaScriptCore
Title: [92230] trunk/Source/_javascript_Core Revision 92230 Author ander...@apple.com Date 2011-08-02 14:13:05 -0700 (Tue, 02 Aug 2011) Log Message Fix Windows build. * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def Diff Modified: trunk/Source/_javascript_Core/ChangeLog (92229 => 92230) --- trunk/Source/_javascript_Core/ChangeLog 2011-08-02 21:08:18 UTC (rev 92229) +++ trunk/Source/_javascript_Core/ChangeLog 2011-08-02 21:13:05 UTC (rev 92230) @@ -1,5 +1,11 @@ 2011-08-02 Anders Carlsson ander...@apple.com +Fix Windows build. + +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: + +2011-08-02 Anders Carlsson ander...@apple.com + Fix a Windows build error. * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (92229 => 92230) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-08-02 21:08:18 UTC (rev 92229) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-08-02 21:13:05 UTC (rev 92230) @@ -96,11 +96,13 @@ ?convertUTF8ToUTF16@Unicode@WTF@@YA?AW4ConversionResult@12@PAPBDPBDPAPA_WPA_W_N@Z ?create@ByteArray@WTF@@SA?AV?$PassRefPtr@VByteArray@WTF@@@2@I@Z ?create@JSByteArray@JSC@@SAPAV12@PAVExecState@2@PAVStructure@2@PAVByteArray@WTF@@@Z +?create@JSGlobalData@JSC@@SA?AV?$PassRefPtr@VJSGlobalData@JSC@@@WTF@@W4ThreadStackType@2@W4HeapSize@2@@Z ?create@OpaqueJSString@@SA?AV?$PassRefPtr@UOpaqueJSString@@@WTF@@ABVUString@JSC@@@Z ?create@RegExp@JSC@@SAPAV12@AAVJSGlobalData@2@ABVUString@2@W4RegExpFlags@2@@Z ?createEmptyString@SmallStrings@JSC@@AAEXPAVJSGlobalData@2@@Z ?createError@JSC@@YAPAVJSObject@1@PAVExecState@1@ABVUString@1@@Z ?createInterruptedExecutionException@JSC@@YAPAVJSObject@1@PAVJSGlobalData@1@@Z +?createLeaked@JSGlobalData@JSC@@SA?AV?$PassRefPtr@VJSGlobalData@JSC@@@WTF@@W4ThreadStackType@2@W4HeapSize@2@@Z ?createRangeError@JSC@@YAPAVJSObject@1@PAVExecState@1@ABVUString@1@@Z ?createReferenceError@JSC@@YAPAVJSObject@1@PAVExecState@1@ABVUString@1@@Z ?createSingleCharacterString@SmallStrings@JSC@@AAEXPAVJSGlobalData@2@E@Z ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92231] trunk/Source
Title: [92231] trunk/Source
Revision 92231
Author msab...@apple.com
Date 2011-08-02 14:19:05 -0700 (Tue, 02 Aug 2011)
Log Message
Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
https://bugs.webkit.org/show_bug.cgi?id=65502
Reviewed by Anders Carlsson.
Source/_javascript_Core:
With the fix of the issues causing madvise MADV_FREE_REUSABLE to fail,
added an assert to the return code of madvise to catch any regressions.
* wtf/TCSystemAlloc.cpp:
(TCMalloc_SystemRelease):
Source/WebCore:
Change the vm_copy in PurgeableBuffer::create to be a memcpy. The
vm_copy causes the process to have additional references to the same
memory region. These additional reference caused madvise(MADV_FREE_REUSABLE)
to fail when it encountered such pages.
No tests added this is a resource defect and not a functional issue.
* platform/mac/PurgeableBufferMac.cpp:
(WebCore::PurgeableBuffer::create):
Source/WebKit2:
Changed OOL message to use MACH_MSG_PHYSICAL_COPY flag instead of virtual flag
so that the original memory region isn't referenced by the message and ultimately
the receiving process. The additional reference caused madvise(MADV_FREE_REUSABLE)
to fail when it encountered such pages.
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/TCSystemAlloc.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/PurgeableBufferMac.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (92230 => 92231)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-02 21:13:05 UTC (rev 92230)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-02 21:19:05 UTC (rev 92231)
@@ -1,3 +1,16 @@
+2011-08-01 Michael Saboff msab...@apple.com
+
+Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
+https://bugs.webkit.org/show_bug.cgi?id=65502
+
+Reviewed by Anders Carlsson.
+
+With the fix of the issues causing madvise MADV_FREE_REUSABLE to fail,
+added an assert to the return code of madvise to catch any regressions.
+
+* wtf/TCSystemAlloc.cpp:
+(TCMalloc_SystemRelease):
+
2011-08-02 Anders Carlsson ander...@apple.com
Fix Windows build.
Modified: trunk/Source/_javascript_Core/wtf/TCSystemAlloc.cpp (92230 => 92231)
--- trunk/Source/_javascript_Core/wtf/TCSystemAlloc.cpp 2011-08-02 21:13:05 UTC (rev 92230)
+++ trunk/Source/_javascript_Core/wtf/TCSystemAlloc.cpp 2011-08-02 21:19:05 UTC (rev 92231)
@@ -392,7 +392,12 @@
void TCMalloc_SystemRelease(void* start, size_t length)
{
-while (madvise(start, length, MADV_FREE_REUSABLE) == -1 errno == EAGAIN) { }
+int madviseResult;
+
+while ((madviseResult = madvise(start, length, MADV_FREE_REUSABLE)) == -1 errno == EAGAIN) { }
+
+// Although really advisory, if madvise fail, we want to know about it.
+ASSERT_UNUSED(madviseResult, madviseResult != -1);
}
#elif HAVE(MADV_FREE) || HAVE(MADV_DONTNEED)
Modified: trunk/Source/WebCore/ChangeLog (92230 => 92231)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 21:13:05 UTC (rev 92230)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 21:19:05 UTC (rev 92231)
@@ -1,3 +1,20 @@
+2011-08-01 Michael Saboff msab...@apple.com
+
+Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
+https://bugs.webkit.org/show_bug.cgi?id=65502
+
+Reviewed by Anders Carlsson.
+
+Change the vm_copy in PurgeableBuffer::create to be a memcpy. The
+vm_copy causes the process to have additional references to the same
+memory region. These additional reference caused madvise(MADV_FREE_REUSABLE)
+to fail when it encountered such pages.
+
+No tests added this is a resource defect and not a functional issue.
+
+* platform/mac/PurgeableBufferMac.cpp:
+(WebCore::PurgeableBuffer::create):
+
2011-08-02 Stephen White senorbla...@chromium.org
[Chromium] Remove an unnecessary readback during accelerated
Modified: trunk/Source/WebCore/platform/mac/PurgeableBufferMac.cpp (92230 => 92231)
--- trunk/Source/WebCore/platform/mac/PurgeableBufferMac.cpp 2011-08-02 21:13:05 UTC (rev 92230)
+++ trunk/Source/WebCore/platform/mac/PurgeableBufferMac.cpp 2011-08-02 21:19:05 UTC (rev 92231)
@@ -64,14 +64,8 @@
if (ret != KERN_SUCCESS)
return nullptr;
-ret = vm_copy(mach_task_self(), reinterpret_castvm_address_t(data), size, buffer);
+memcpy(reinterpret_castchar*(buffer), data, size);
-ASSERT(ret == KERN_SUCCESS);
-if (ret != KERN_SUCCESS) {
-vm_deallocate(mach_task_self(), buffer, size);
-return nullptr;
-}
-
return adoptPtr(new PurgeableBuffer(reinterpret_castchar*(buffer), size));
}
Modified:
[webkit-changes] [92232] trunk/LayoutTests
Title: [92232] trunk/LayoutTests Revision 92232 Author ander...@apple.com Date 2011-08-02 14:22:22 -0700 (Tue, 02 Aug 2011) Log Message Add scrollbars/scrollbar-drag-thumb-with-large-content.html to the Skipped list. * platform/mac/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92231 => 92232) --- trunk/LayoutTests/ChangeLog 2011-08-02 21:19:05 UTC (rev 92231) +++ trunk/LayoutTests/ChangeLog 2011-08-02 21:22:22 UTC (rev 92232) @@ -1,3 +1,9 @@ +2011-08-02 Anders Carlsson ander...@apple.com + +Add scrollbars/scrollbar-drag-thumb-with-large-content.html to the Skipped list. + +* platform/mac/Skipped: + 2011-08-02 Zhenyao Mo z...@google.com Unreviewed, test expectations update, gardener stuff. Modified: trunk/LayoutTests/platform/mac/Skipped (92231 => 92232) --- trunk/LayoutTests/platform/mac/Skipped 2011-08-02 21:19:05 UTC (rev 92231) +++ trunk/LayoutTests/platform/mac/Skipped 2011-08-02 21:22:22 UTC (rev 92232) @@ -407,3 +407,7 @@ # Tests for WebVTT parser for track. Feature is not yet functional. # https://bugs.webkit.org/show_bug.cgi?id=43668 media/track/ + +# REGRESSION (r91547): scrollbars/scrollbar-drag-thumb-with-large-content.html failing on SnowLeopard Intel Release (Tests) +# https://bugs.webkit.org/show_bug.cgi?id=65434 +scrollbars/scrollbar-drag-thumb-with-large-content.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92233] trunk/Source/JavaScriptCore
Title: [92233] trunk/Source/_javascript_Core
Revision 92233
Author fpi...@apple.com
Date 2011-08-02 14:22:34 -0700 (Tue, 02 Aug 2011)
Log Message
JSC GC uses dummy cells to avoid having to remember which cells
it has already destroyed
https://bugs.webkit.org/show_bug.cgi?id=65556
Reviewed by Oliver Hunt.
This gets rid of dummy cells, and ensures that it's not necessary
to invoke a destructor on cells that have already been swept. In
the common case, a block knows that either all of its free cells
still need to have destructors called, or none of them do, which
minimizes the amount of branching that needs to happen per cell
when performing a sweep.
This is performance neutral on SunSpider and V8. It is meant as
a stepping stone to simplify the implementation of more
sophisticated sweeping algorithms.
* heap/Heap.cpp:
(JSC::CountFunctor::ClearMarks::operator()):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::initForCellSize):
(JSC::MarkedBlock::callDestructor):
(JSC::MarkedBlock::specializedReset):
(JSC::MarkedBlock::reset):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::produceFreeList):
(JSC::MarkedBlock::lazySweep):
(JSC::MarkedBlock::blessNewBlockForFastPath):
(JSC::MarkedBlock::blessNewBlockForSlowPath):
(JSC::MarkedBlock::canonicalizeBlock):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::FreeCell::setNoObject):
(JSC::MarkedBlock::setDestructorState):
(JSC::MarkedBlock::destructorState):
(JSC::MarkedBlock::notifyMayHaveFreshFreeCells):
* runtime/JSCell.cpp:
* runtime/JSCell.h:
(JSC::JSCell::JSCell::JSCell):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
* runtime/JSGlobalData.h:
* runtime/Structure.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/MarkedBlock.cpp
trunk/Source/_javascript_Core/heap/MarkedBlock.h
trunk/Source/_javascript_Core/runtime/JSCell.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
trunk/Source/_javascript_Core/runtime/Structure.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (92232 => 92233)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-02 21:22:22 UTC (rev 92232)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-02 21:22:34 UTC (rev 92233)
@@ -1,3 +1,50 @@
+2011-08-02 Filip Pizlo fpi...@apple.com
+
+JSC GC uses dummy cells to avoid having to remember which cells
+it has already destroyed
+https://bugs.webkit.org/show_bug.cgi?id=65556
+
+Reviewed by Oliver Hunt.
+
+This gets rid of dummy cells, and ensures that it's not necessary
+to invoke a destructor on cells that have already been swept. In
+the common case, a block knows that either all of its free cells
+still need to have destructors called, or none of them do, which
+minimizes the amount of branching that needs to happen per cell
+when performing a sweep.
+
+This is performance neutral on SunSpider and V8. It is meant as
+a stepping stone to simplify the implementation of more
+sophisticated sweeping algorithms.
+
+* heap/Heap.cpp:
+(JSC::CountFunctor::ClearMarks::operator()):
+* heap/MarkedBlock.cpp:
+(JSC::MarkedBlock::initForCellSize):
+(JSC::MarkedBlock::callDestructor):
+(JSC::MarkedBlock::specializedReset):
+(JSC::MarkedBlock::reset):
+(JSC::MarkedBlock::specializedSweep):
+(JSC::MarkedBlock::sweep):
+(JSC::MarkedBlock::produceFreeList):
+(JSC::MarkedBlock::lazySweep):
+(JSC::MarkedBlock::blessNewBlockForFastPath):
+(JSC::MarkedBlock::blessNewBlockForSlowPath):
+(JSC::MarkedBlock::canonicalizeBlock):
+* heap/MarkedBlock.h:
+(JSC::MarkedBlock::FreeCell::setNoObject):
+(JSC::MarkedBlock::setDestructorState):
+(JSC::MarkedBlock::destructorState):
+(JSC::MarkedBlock::notifyMayHaveFreshFreeCells):
+* runtime/JSCell.cpp:
+* runtime/JSCell.h:
+(JSC::JSCell::JSCell::JSCell):
+* runtime/JSGlobalData.cpp:
+(JSC::JSGlobalData::JSGlobalData):
+(JSC::JSGlobalData::clearBuiltinStructures):
+* runtime/JSGlobalData.h:
+* runtime/Structure.h:
+
2011-08-01 Michael Saboff msab...@apple.com
Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (92232 => 92233)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2011-08-02 21:22:22 UTC (rev 92232)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2011-08-02 21:22:34 UTC (rev 92233)
@@ -108,6 +108,7 @@
inline void ClearMarks::operator()(MarkedBlock* block)
{
block-clearMarks();
+block-notifyMayHaveFreshFreeCells();
}
[webkit-changes] [92236] trunk/Source/WebCore
Title: [92236] trunk/Source/WebCore
Revision 92236
Author commit-qu...@webkit.org
Date 2011-08-02 14:35:15 -0700 (Tue, 02 Aug 2011)
Log Message
Remove LegacyDefaultOptionalArguments flag from CSS IDL files
https://bugs.webkit.org/show_bug.cgi?id=65341
Patch by Mark Pilgrim pilg...@chromium.org on 2011-08-02
Reviewed by Adam Barth.
No new tests. All existing tests pass.
* css/CSSMediaRule.idl:
* css/CSSPrimitiveValue.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleSheet.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/MediaQueryList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSMatrix.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSMediaRule.idl
trunk/Source/WebCore/css/CSSPrimitiveValue.idl
trunk/Source/WebCore/css/CSSRuleList.idl
trunk/Source/WebCore/css/CSSStyleDeclaration.idl
trunk/Source/WebCore/css/CSSStyleSheet.idl
trunk/Source/WebCore/css/CSSValueList.idl
trunk/Source/WebCore/css/MediaList.idl
trunk/Source/WebCore/css/MediaQueryList.idl
trunk/Source/WebCore/css/MediaQueryListListener.idl
trunk/Source/WebCore/css/StyleMedia.idl
trunk/Source/WebCore/css/StyleSheetList.idl
trunk/Source/WebCore/css/WebKitCSSKeyframesRule.idl
trunk/Source/WebCore/css/WebKitCSSMatrix.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (92235 => 92236)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 21:35:15 UTC (rev 92236)
@@ -1,3 +1,26 @@
+2011-08-02 Mark Pilgrim pilg...@chromium.org
+
+Remove LegacyDefaultOptionalArguments flag from CSS IDL files
+https://bugs.webkit.org/show_bug.cgi?id=65341
+
+Reviewed by Adam Barth.
+
+No new tests. All existing tests pass.
+
+* css/CSSMediaRule.idl:
+* css/CSSPrimitiveValue.idl:
+* css/CSSRuleList.idl:
+* css/CSSStyleDeclaration.idl:
+* css/CSSStyleSheet.idl:
+* css/CSSValueList.idl:
+* css/MediaList.idl:
+* css/MediaQueryList.idl:
+* css/MediaQueryListListener.idl:
+* css/StyleMedia.idl:
+* css/StyleSheetList.idl:
+* css/WebKitCSSKeyframesRule.idl:
+* css/WebKitCSSMatrix.idl:
+
2011-08-02 Robert Kroeger rjkro...@chromium.org
[chromium] Layering violations in gesture recognizer
Modified: trunk/Source/WebCore/css/CSSMediaRule.idl (92235 => 92236)
--- trunk/Source/WebCore/css/CSSMediaRule.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/CSSMediaRule.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -21,16 +21,14 @@
module css {
// Introduced in DOM Level 2:
-interface [
-LegacyDefaultOptionalArguments,
-] CSSMediaRule : CSSRule {
+interface CSSMediaRule : CSSRule {
readonly attribute MediaList media;
readonly attribute CSSRuleList cssRules;
-[OldStyleObjC] unsigned long insertRule(in DOMString rule,
- in unsigned long index)
+[OldStyleObjC] unsigned long insertRule(in [Optional=CallWithDefaultValue] DOMString rule,
+ in [Optional=CallWithDefaultValue] unsigned long index)
raises(DOMException);
-void deleteRule(in unsigned long index)
+void deleteRule(in [Optional=CallWithDefaultValue] unsigned long index)
raises(DOMException);
};
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.idl (92235 => 92236)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.idl 2011-08-02 21:33:48 UTC (rev 92235)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.idl 2011-08-02 21:35:15 UTC (rev 92236)
@@ -19,9 +19,7 @@
module css {
-interface [
-LegacyDefaultOptionalArguments,
-] CSSPrimitiveValue : CSSValue {
+interface CSSPrimitiveValue : CSSValue {
// UnitTypes
const unsigned short CSS_UNKNOWN= 0;
@@ -53,13 +51,13 @@
readonly attribute unsigned short primitiveType;
-[OldStyleObjC] void setFloatValue(in unsigned short unitType,
- in float floatValue)
+[OldStyleObjC] void setFloatValue(in [Optional=CallWithDefaultValue] unsigned short unitType,
+ in [Optional=CallWithDefaultValue] float floatValue)
raises(DOMException);
-float getFloatValue(in unsigned short unitType)
+float getFloatValue(in [Optional=CallWithDefaultValue] unsigned short unitType)
raises(DOMException);
-[OldStyleObjC] void setStringValue(in unsigned short stringType,
- in DOMString stringValue)
+[OldStyleObjC] void setStringValue(in [Optional=CallWithDefaultValue] unsigned short stringType,
+
[webkit-changes] [92237] trunk/Source/WebCore
Title: [92237] trunk/Source/WebCore
Revision 92237
Author commit-qu...@webkit.org
Date 2011-08-02 14:36:52 -0700 (Tue, 02 Aug 2011)
Log Message
Remove LegacyDefaultOptionalArguments flag from SVG IDL files
https://bugs.webkit.org/show_bug.cgi?id=65337
Patch by Mark Pilgrim pilg...@chromium.org on 2011-08-02
Reviewed by Nikolas Zimmermann.
No new tests, all existing tests pass.
* svg/ElementTimeControl.idl:
* svg/SVGAnimationElement.idl:
* svg/SVGDocument.idl:
* svg/SVGElementInstance.idl:
* svg/SVGElementInstanceList.idl:
* svg/SVGException.idl:
* svg/SVGFEDropShadowElement.idl:
* svg/SVGFEGaussianBlurElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFilterElement.idl:
* svg/SVGLocatable.idl:
* svg/SVGMarkerElement.idl:
* svg/SVGPathElement.idl:
* svg/SVGSVGElement.idl:
* svg/SVGStylable.idl:
* svg/SVGStyleElement.idl:
* svg/SVGTests.idl:
* svg/SVGTextContentElement.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/ElementTimeControl.idl
trunk/Source/WebCore/svg/SVGAnimationElement.idl
trunk/Source/WebCore/svg/SVGDocument.idl
trunk/Source/WebCore/svg/SVGElementInstance.idl
trunk/Source/WebCore/svg/SVGElementInstanceList.idl
trunk/Source/WebCore/svg/SVGException.idl
trunk/Source/WebCore/svg/SVGFEDropShadowElement.idl
trunk/Source/WebCore/svg/SVGFEGaussianBlurElement.idl
trunk/Source/WebCore/svg/SVGFEMorphologyElement.idl
trunk/Source/WebCore/svg/SVGFilterElement.idl
trunk/Source/WebCore/svg/SVGLocatable.idl
trunk/Source/WebCore/svg/SVGMarkerElement.idl
trunk/Source/WebCore/svg/SVGPathElement.idl
trunk/Source/WebCore/svg/SVGSVGElement.idl
trunk/Source/WebCore/svg/SVGStylable.idl
trunk/Source/WebCore/svg/SVGStyleElement.idl
trunk/Source/WebCore/svg/SVGTests.idl
trunk/Source/WebCore/svg/SVGTextContentElement.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (92236 => 92237)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 21:35:15 UTC (rev 92236)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 21:36:52 UTC (rev 92237)
@@ -1,5 +1,33 @@
2011-08-02 Mark Pilgrim pilg...@chromium.org
+Remove LegacyDefaultOptionalArguments flag from SVG IDL files
+https://bugs.webkit.org/show_bug.cgi?id=65337
+
+Reviewed by Nikolas Zimmermann.
+
+No new tests, all existing tests pass.
+
+* svg/ElementTimeControl.idl:
+* svg/SVGAnimationElement.idl:
+* svg/SVGDocument.idl:
+* svg/SVGElementInstance.idl:
+* svg/SVGElementInstanceList.idl:
+* svg/SVGException.idl:
+* svg/SVGFEDropShadowElement.idl:
+* svg/SVGFEGaussianBlurElement.idl:
+* svg/SVGFEMorphologyElement.idl:
+* svg/SVGFilterElement.idl:
+* svg/SVGLocatable.idl:
+* svg/SVGMarkerElement.idl:
+* svg/SVGPathElement.idl:
+* svg/SVGSVGElement.idl:
+* svg/SVGStylable.idl:
+* svg/SVGStyleElement.idl:
+* svg/SVGTests.idl:
+* svg/SVGTextContentElement.idl:
+
+2011-08-02 Mark Pilgrim pilg...@chromium.org
+
Remove LegacyDefaultOptionalArguments flag from CSS IDL files
https://bugs.webkit.org/show_bug.cgi?id=65341
Modified: trunk/Source/WebCore/svg/ElementTimeControl.idl (92236 => 92237)
--- trunk/Source/WebCore/svg/ElementTimeControl.idl 2011-08-02 21:35:15 UTC (rev 92236)
+++ trunk/Source/WebCore/svg/ElementTimeControl.idl 2011-08-02 21:36:52 UTC (rev 92237)
@@ -27,15 +27,14 @@
module svg {
interface [
-LegacyDefaultOptionalArguments,
Conditional=SVG,
ObjCProtocol,
OmitConstructor
] ElementTimeControl {
void beginElement();
-void beginElementAt(in float offset);
+void beginElementAt(in [Optional=CallWithDefaultValue] float offset);
void endElement();
-void endElementAt(in float offset);
+void endElementAt(in [Optional=CallWithDefaultValue] float offset);
};
}
Modified: trunk/Source/WebCore/svg/SVGAnimationElement.idl (92236 => 92237)
--- trunk/Source/WebCore/svg/SVGAnimationElement.idl 2011-08-02 21:35:15 UTC (rev 92236)
+++ trunk/Source/WebCore/svg/SVGAnimationElement.idl 2011-08-02 21:36:52 UTC (rev 92237)
@@ -26,7 +26,6 @@
module svg {
interface [
-LegacyDefaultOptionalArguments,
Conditional=SVG_ANIMATION,
OmitConstructor
] SVGAnimationElement : SVGElement,
Modified: trunk/Source/WebCore/svg/SVGDocument.idl (92236 => 92237)
--- trunk/Source/WebCore/svg/SVGDocument.idl 2011-08-02 21:35:15 UTC (rev 92236)
+++ trunk/Source/WebCore/svg/SVGDocument.idl 2011-08-02 21:36:52 UTC (rev 92237)
@@ -22,13 +22,12 @@
module svg {
interface [
-LegacyDefaultOptionalArguments,
Conditional=SVG
] SVGDocument : Document {
readonly attribute SVGSVGElementrootElement;
// Overwrite the one in events::DocumentEvent
-Event createEvent(in DOMString eventType)
+Event createEvent(in [Optional=CallWithDefaultValue] DOMString eventType)
[webkit-changes] [92238] trunk/Source/WebCore
Title: [92238] trunk/Source/WebCore
Revision 92238
Author commit-qu...@webkit.org
Date 2011-08-02 15:11:30 -0700 (Tue, 02 Aug 2011)
Log Message
Chromium: Update forked ScrollbarThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=6
Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.
Patch by Sailesh Agrawal s...@chromium.org on 2011-08-02
Reviewed by James Robinson.
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterSetEnabled):
* platform/chromium/ScrollbarThemeChromiumMac.h:
(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
(WebCore::ScrollbarThemeChromiumMac::paint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h
trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (92237 => 92238)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 21:36:52 UTC (rev 92237)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 22:11:30 UTC (rev 92238)
@@ -1,3 +1,25 @@
+2011-08-02 Sailesh Agrawal s...@chromium.org
+
+Chromium: Update forked ScrollbarThemeChromiumMac.mm
+https://bugs.webkit.org/show_bug.cgi?id=6
+
+Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.
+
+Reviewed by James Robinson.
+
+* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
+* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
+(wkScrollbarPainterSetEnabled):
+* platform/chromium/ScrollbarThemeChromiumMac.h:
+(WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
+* platform/chromium/ScrollbarThemeChromiumMac.mm:
+(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
+(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
+(WebCore::toScrollbarPainterKnobStyle):
+(WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
+(WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
+(WebCore::ScrollbarThemeChromiumMac::paint):
+
2011-08-02 Mark Pilgrim pilg...@chromium.org
Remove LegacyDefaultOptionalArguments flag from SVG IDL files
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h (92237 => 92238)
--- trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h 2011-08-02 21:36:52 UTC (rev 92237)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h 2011-08-02 22:11:30 UTC (rev 92238)
@@ -61,6 +61,7 @@
void wkScrollbarPainterPaintKnob(WKScrollbarPainterRef);
int wkScrollbarMinimumThumbLength(WKScrollbarPainterRef);
void wkScrollbarPainterSetDelegate(WKScrollbarPainterRef, id scrollbarPainterDelegate);
+void wkScrollbarPainterSetEnabled(WKScrollbarPainterRef, bool enabled);
CGFloat wkScrollbarPainterTrackAlpha(WKScrollbarPainterRef);
WKScrollbarPainterRef wkMakeScrollbarPainter(int controlSize, bool isHorizontal);
int wkScrollbarThickness(int controlSize);
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm (92237 => 92238)
--- trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm 2011-08-02 21:36:52 UTC (rev 92237)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm 2011-08-02 22:11:30 UTC (rev 92238)
@@ -187,6 +187,11 @@
[painter setDelegate:scrollbarPainterDelegate];
}
+void wkScrollbarPainterSetEnabled(WKScrollbarPainterRef painter, bool enabled)
+{
+[painter setEnabled:enabled];
+}
+
CGFloat wkScrollbarPainterTrackAlpha(WKScrollbarPainterRef painter)
{
return [painter trackAlpha];
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h (92237 => 92238)
--- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h 2011-08-02 21:36:52 UTC (rev 92237)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h 2011-08-02 22:11:30 UTC (rev 92238)
@@ -40,12 +40,15 @@
ScrollbarThemeChromiumMac();
virtual ~ScrollbarThemeChromiumMac();
+virtual void updateEnabledState(Scrollbar*);
+
virtual bool paint(Scrollbar*, GraphicsContext* context, const IntRect damageRect);
virtual int scrollbarThickness(ScrollbarControlSize = RegularScrollbar);
virtual bool supportsControlTints() const { return true; }
[webkit-changes] [92239] trunk/Source/WebCore
Title: [92239] trunk/Source/WebCore
Revision 92239
Author gav...@chromium.org
Date 2011-08-02 15:17:51 -0700 (Tue, 02 Aug 2011)
Log Message
fail earlier to track down null CachedScript execution
https://bugs.webkit.org/show_bug.cgi?id=65563
Over in http://code.google.com/p/chromium/issues/detail?id=75604 I can't reproduce the problem. Careful reading of the code hasn't led me
to an obvious cause either. This patch should cause failure earlier, and lead to better stacks. I'll watch Chrome Canary's crash
uploads carefully, and remove this CRASH() (and fix the underlying problem) once I understand it.
Reviewed by Alexey Proskuryakov.
No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.
* dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::queueScriptForExecution):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ScriptRunner.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92238 => 92239)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 22:11:30 UTC (rev 92238)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 22:17:51 UTC (rev 92239)
@@ -1,3 +1,19 @@
+2011-08-02 Gavin Peters gav...@chromium.org
+
+fail earlier to track down null CachedScript execution
+https://bugs.webkit.org/show_bug.cgi?id=65563
+
+Over in http://code.google.com/p/chromium/issues/detail?id=75604 I can't reproduce the problem. Careful reading of the code hasn't led me
+to an obvious cause either. This patch should cause failure earlier, and lead to better stacks. I'll watch Chrome Canary's crash
+uploads carefully, and remove this CRASH() (and fix the underlying problem) once I understand it.
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.
+
+* dom/ScriptRunner.cpp:
+(WebCore::ScriptRunner::queueScriptForExecution):
+
2011-08-02 Sailesh Agrawal s...@chromium.org
Chromium: Update forked ScrollbarThemeChromiumMac.mm
Modified: trunk/Source/WebCore/dom/ScriptRunner.cpp (92238 => 92239)
--- trunk/Source/WebCore/dom/ScriptRunner.cpp 2011-08-02 22:11:30 UTC (rev 92238)
+++ trunk/Source/WebCore/dom/ScriptRunner.cpp 2011-08-02 22:17:51 UTC (rev 92239)
@@ -52,6 +52,11 @@
void ScriptRunner::queueScriptForExecution(ScriptElement* scriptElement, CachedResourceHandleCachedScript cachedScript, ExecutionType executionType)
{
ASSERT(scriptElement);
+
+// Temporary: intended to help debug how null CachedScript objects can even get queued for execution, which
+// seems to sometimes happen (see http://code.google.com/p/chromium/issues/detail?id=75604 )
+if (!cachedScript.get())
+CRASH();
Element* element = scriptElement-element();
ASSERT(element);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92241] trunk/Source/WebCore
Title: [92241] trunk/Source/WebCore Revision 92241 Author commit-qu...@webkit.org Date 2011-08-02 15:41:55 -0700 (Tue, 02 Aug 2011) Log Message Remove LegacyDefaultOptionalArguments flag from EventSource.idl https://bugs.webkit.org/show_bug.cgi?id=65568 Patch by Mark Pilgrim pilg...@chromium.org on 2011-08-02 Reviewed by Adam Barth. No new tests, all existing tests pass. * page/EventSource.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/EventSource.idl Diff Modified: trunk/Source/WebCore/ChangeLog (92240 => 92241) --- trunk/Source/WebCore/ChangeLog 2011-08-02 22:19:25 UTC (rev 92240) +++ trunk/Source/WebCore/ChangeLog 2011-08-02 22:41:55 UTC (rev 92241) @@ -1,3 +1,14 @@ +2011-08-02 Mark Pilgrim pilg...@chromium.org + +Remove LegacyDefaultOptionalArguments flag from EventSource.idl +https://bugs.webkit.org/show_bug.cgi?id=65568 + +Reviewed by Adam Barth. + +No new tests, all existing tests pass. + +* page/EventSource.idl: + 2011-08-02 Gavin Peters gav...@chromium.org fail earlier to track down null CachedScript execution Modified: trunk/Source/WebCore/page/EventSource.idl (92240 => 92241) --- trunk/Source/WebCore/page/EventSource.idl 2011-08-02 22:19:25 UTC (rev 92240) +++ trunk/Source/WebCore/page/EventSource.idl 2011-08-02 22:41:55 UTC (rev 92241) @@ -33,7 +33,6 @@ interface [ Conditional=EVENTSOURCE, -LegacyDefaultOptionalArguments, ActiveDOMObject, CanBeConstructed, CustomConstructFunction, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92242] trunk/Source/WebCore
Title: [92242] trunk/Source/WebCore
Revision 92242
Author commit-qu...@webkit.org
Date 2011-08-02 15:47:08 -0700 (Tue, 02 Aug 2011)
Log Message
Remove LegacyDefaultOptionalArguments flag from SpeechInputResultList.idl
https://bugs.webkit.org/show_bug.cgi?id=65570
Patch by Mark Pilgrim pilg...@chromium.org on 2011-08-02
Reviewed by Adam Barth.
No new tests, all existing tests pass
* page/SpeechInputResultList.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/SpeechInputResultList.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (92241 => 92242)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 22:41:55 UTC (rev 92241)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 22:47:08 UTC (rev 92242)
@@ -1,5 +1,16 @@
2011-08-02 Mark Pilgrim pilg...@chromium.org
+Remove LegacyDefaultOptionalArguments flag from SpeechInputResultList.idl
+https://bugs.webkit.org/show_bug.cgi?id=65570
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass
+
+* page/SpeechInputResultList.idl:
+
+2011-08-02 Mark Pilgrim pilg...@chromium.org
+
Remove LegacyDefaultOptionalArguments flag from EventSource.idl
https://bugs.webkit.org/show_bug.cgi?id=65568
Modified: trunk/Source/WebCore/page/SpeechInputResultList.idl (92241 => 92242)
--- trunk/Source/WebCore/page/SpeechInputResultList.idl 2011-08-02 22:41:55 UTC (rev 92241)
+++ trunk/Source/WebCore/page/SpeechInputResultList.idl 2011-08-02 22:47:08 UTC (rev 92242)
@@ -26,7 +26,6 @@
module core {
interface [
-LegacyDefaultOptionalArguments,
HasIndexGetter,
Conditional=INPUT_SPEECH
] SpeechInputResultList {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92246] trunk/Source/WebCore
Title: [92246] trunk/Source/WebCore
Revision 92246
Author commit-qu...@webkit.org
Date 2011-08-02 16:41:25 -0700 (Tue, 02 Aug 2011)
Log Message
Remove LegacyDefaultOptionalArguments flag from WebKitAnimationList.idl
https://bugs.webkit.org/show_bug.cgi?id=65571
Patch by Mark Pilgrim pilg...@chromium.org on 2011-08-02
Reviewed by Adam Barth.
No new tests, all existing tests pass.
* page/WebKitAnimationList.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/WebKitAnimationList.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (92245 => 92246)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 23:20:44 UTC (rev 92245)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 23:41:25 UTC (rev 92246)
@@ -1,3 +1,14 @@
+2011-08-02 Mark Pilgrim pilg...@chromium.org
+
+Remove LegacyDefaultOptionalArguments flag from WebKitAnimationList.idl
+https://bugs.webkit.org/show_bug.cgi?id=65571
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass.
+
+* page/WebKitAnimationList.idl:
+
2011-08-02 James Robinson jam...@chromium.org
[chromium] Decouple layer visibility calculations from render surfaces / computed draw transforms
Modified: trunk/Source/WebCore/page/WebKitAnimationList.idl (92245 => 92246)
--- trunk/Source/WebCore/page/WebKitAnimationList.idl 2011-08-02 23:20:44 UTC (rev 92245)
+++ trunk/Source/WebCore/page/WebKitAnimationList.idl 2011-08-02 23:41:25 UTC (rev 92246)
@@ -26,7 +26,6 @@
module html {
interface [
-LegacyDefaultOptionalArguments,
HasIndexGetter
] WebKitAnimationList {
readonly attribute unsigned long length;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92247] trunk/Source/WebCore
Title: [92247] trunk/Source/WebCore
Revision 92247
Author commit-qu...@webkit.org
Date 2011-08-02 16:47:26 -0700 (Tue, 02 Aug 2011)
Log Message
Remove LegacyDefaultOptionalArguments flag from History.idl
https://bugs.webkit.org/show_bug.cgi?id=65572
Patch by Mark Pilgrim pilg...@chromium.org on 2011-08-02
Reviewed by Adam Barth.
No new tests, all existing tests pass.
* page/History.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/History.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (92246 => 92247)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 23:41:25 UTC (rev 92246)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 23:47:26 UTC (rev 92247)
@@ -1,5 +1,16 @@
2011-08-02 Mark Pilgrim pilg...@chromium.org
+Remove LegacyDefaultOptionalArguments flag from History.idl
+https://bugs.webkit.org/show_bug.cgi?id=65572
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass.
+
+* page/History.idl:
+
+2011-08-02 Mark Pilgrim pilg...@chromium.org
+
Remove LegacyDefaultOptionalArguments flag from WebKitAnimationList.idl
https://bugs.webkit.org/show_bug.cgi?id=65571
Modified: trunk/Source/WebCore/page/History.idl (92246 => 92247)
--- trunk/Source/WebCore/page/History.idl 2011-08-02 23:41:25 UTC (rev 92246)
+++ trunk/Source/WebCore/page/History.idl 2011-08-02 23:47:26 UTC (rev 92247)
@@ -26,7 +26,6 @@
module window {
interface [
-LegacyDefaultOptionalArguments,
#if defined(V8_BINDING) V8_BINDING
CheckDomainSecurity,
#endif
@@ -41,7 +40,7 @@
[DoNotCheckDomainSecurity, CallWith=ScriptExecutionContext] void back();
[DoNotCheckDomainSecurity, CallWith=ScriptExecutionContext] void forward();
-[DoNotCheckDomainSecurity, CallWith=ScriptExecutionContext] void go(in long distance);
+[DoNotCheckDomainSecurity, CallWith=ScriptExecutionContext] void go(in [Optional=CallWithDefaultValue] long distance);
[Custom, EnabledAtRuntime] void pushState(in any data, in DOMString title, in optional DOMString url)
raises(DOMException);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92248] trunk/Source/WebCore
Title: [92248] trunk/Source/WebCore
Revision 92248
Author z...@google.com
Date 2011-08-02 17:02:01 -0700 (Tue, 02 Aug 2011)
Log Message
Unreviewed, rolling out r92238.
http://trac.webkit.org/changeset/92238
https://bugs.webkit.org/show_bug.cgi?id=6
fail fast/events/scrollbar-double-click.html on Mac
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
(WebCore::toScrollbarPainterKnobStyle):
(WebCore::ScrollbarThemeChromiumMac::paint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h
trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (92247 => 92248)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 23:47:26 UTC (rev 92247)
+++ trunk/Source/WebCore/ChangeLog 2011-08-03 00:02:01 UTC (rev 92248)
@@ -1,3 +1,20 @@
+2011-08-02 Zhenyao Mo z...@google.com
+
+Unreviewed, rolling out r92238.
+http://trac.webkit.org/changeset/92238
+https://bugs.webkit.org/show_bug.cgi?id=6
+
+fail fast/events/scrollbar-double-click.html on Mac
+
+* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
+* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
+* platform/chromium/ScrollbarThemeChromiumMac.h:
+* platform/chromium/ScrollbarThemeChromiumMac.mm:
+(WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
+(WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
+(WebCore::toScrollbarPainterKnobStyle):
+(WebCore::ScrollbarThemeChromiumMac::paint):
+
2011-08-02 Mark Pilgrim pilg...@chromium.org
Remove LegacyDefaultOptionalArguments flag from History.idl
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h (92247 => 92248)
--- trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h 2011-08-02 23:47:26 UTC (rev 92247)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h 2011-08-03 00:02:01 UTC (rev 92248)
@@ -61,7 +61,6 @@
void wkScrollbarPainterPaintKnob(WKScrollbarPainterRef);
int wkScrollbarMinimumThumbLength(WKScrollbarPainterRef);
void wkScrollbarPainterSetDelegate(WKScrollbarPainterRef, id scrollbarPainterDelegate);
-void wkScrollbarPainterSetEnabled(WKScrollbarPainterRef, bool enabled);
CGFloat wkScrollbarPainterTrackAlpha(WKScrollbarPainterRef);
WKScrollbarPainterRef wkMakeScrollbarPainter(int controlSize, bool isHorizontal);
int wkScrollbarThickness(int controlSize);
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm (92247 => 92248)
--- trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm 2011-08-02 23:47:26 UTC (rev 92247)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm 2011-08-03 00:02:01 UTC (rev 92248)
@@ -187,11 +187,6 @@
[painter setDelegate:scrollbarPainterDelegate];
}
-void wkScrollbarPainterSetEnabled(WKScrollbarPainterRef painter, bool enabled)
-{
-[painter setEnabled:enabled];
-}
-
CGFloat wkScrollbarPainterTrackAlpha(WKScrollbarPainterRef painter)
{
return [painter trackAlpha];
Modified: trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h (92247 => 92248)
--- trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h 2011-08-02 23:47:26 UTC (rev 92247)
+++ trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h 2011-08-03 00:02:01 UTC (rev 92248)
@@ -40,15 +40,12 @@
ScrollbarThemeChromiumMac();
virtual ~ScrollbarThemeChromiumMac();
-virtual void updateEnabledState(Scrollbar*);
-
virtual bool paint(Scrollbar*, GraphicsContext* context, const IntRect damageRect);
virtual int scrollbarThickness(ScrollbarControlSize = RegularScrollbar);
virtual bool supportsControlTints() const { return true; }
virtual bool usesOverlayScrollbars() const;
-virtual void updateScrollbarOverlayStyle(Scrollbar*);
virtual double initialAutoscrollTimerDelay();
virtual double autoscrollTimerDelay();
@@ -69,8 +66,6 @@
virtual IntRect forwardButtonRect(Scrollbar*, ScrollbarPart, bool painting = false);
virtual IntRect trackRect(Scrollbar*, bool painting = false);
-virtual int maxOverlapBetweenPages() { return 40; }
-
virtual int minimumThumbLength(Scrollbar*);
virtual bool shouldCenterOnThumb(Scrollbar*, const PlatformMouseEvent);
Modified:
[webkit-changes] [92249] trunk/Source/WebCore
Title: [92249] trunk/Source/WebCore
Revision 92249
Author jp...@apple.com
Date 2011-08-02 17:04:06 -0700 (Tue, 02 Aug 2011)
Log Message
Add namespace prefix support in XML tokenizer
https://bugs.webkit.org/show_bug.cgi?id=65578
Reviewed by Adam Barth.
This also changes markup debug printing to print to stderr instead of stdout
* xml/parser/MarkupTokenBase.h:
(WebCore::MarkupTokenBase::printString):
* xml/parser/XMLToken.h:
(WebCore::XMLToken::XMLDeclarationData::XMLDeclarationData):
(WebCore::XMLToken::clear):
(WebCore::XMLToken::appendToName):
(WebCore::XMLToken::name):
(WebCore::XMLToken::target):
(WebCore::XMLToken::data):
(WebCore::XMLToken::prefix):
(WebCore::XMLToken::xmlDeclarationData):
(WebCore::XMLToken::endPrefix):
(WebCore::XMLToken::hasPrefix):
(WebCore::XMLToken::endAttributePrefix):
(WebCore::XMLToken::attributeHasPrefix):
(WebCore::XMLToken::printAttrs):
(WebCore::XMLToken::print):
* xml/parser/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::nextToken):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/parser/MarkupTokenBase.h
trunk/Source/WebCore/xml/parser/XMLToken.h
trunk/Source/WebCore/xml/parser/XMLTokenizer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92248 => 92249)
--- trunk/Source/WebCore/ChangeLog 2011-08-03 00:02:01 UTC (rev 92248)
+++ trunk/Source/WebCore/ChangeLog 2011-08-03 00:04:06 UTC (rev 92249)
@@ -1,3 +1,32 @@
+2011-08-02 Jeffrey Pfau jp...@apple.com
+
+Add namespace prefix support in XML tokenizer
+https://bugs.webkit.org/show_bug.cgi?id=65578
+
+Reviewed by Adam Barth.
+
+This also changes markup debug printing to print to stderr instead of stdout
+
+* xml/parser/MarkupTokenBase.h:
+(WebCore::MarkupTokenBase::printString):
+* xml/parser/XMLToken.h:
+(WebCore::XMLToken::XMLDeclarationData::XMLDeclarationData):
+(WebCore::XMLToken::clear):
+(WebCore::XMLToken::appendToName):
+(WebCore::XMLToken::name):
+(WebCore::XMLToken::target):
+(WebCore::XMLToken::data):
+(WebCore::XMLToken::prefix):
+(WebCore::XMLToken::xmlDeclarationData):
+(WebCore::XMLToken::endPrefix):
+(WebCore::XMLToken::hasPrefix):
+(WebCore::XMLToken::endAttributePrefix):
+(WebCore::XMLToken::attributeHasPrefix):
+(WebCore::XMLToken::printAttrs):
+(WebCore::XMLToken::print):
+* xml/parser/XMLTokenizer.cpp:
+(WebCore::XMLTokenizer::nextToken):
+
2011-08-02 Zhenyao Mo z...@google.com
Unreviewed, rolling out r92238.
Modified: trunk/Source/WebCore/xml/parser/MarkupTokenBase.h (92248 => 92249)
--- trunk/Source/WebCore/xml/parser/MarkupTokenBase.h 2011-08-03 00:02:01 UTC (rev 92248)
+++ trunk/Source/WebCore/xml/parser/MarkupTokenBase.h 2011-08-03 00:04:06 UTC (rev 92249)
@@ -51,28 +51,29 @@
WTF::VectorUChar m_publicIdentifier;
WTF::VectorUChar m_systemIdentifier;
};
-
-templatetypename TypeSet, typename DoctypeData = DoctypeDataBase
-class MarkupTokenBase {
-WTF_MAKE_NONCOPYABLE(MarkupTokenBase);
-WTF_MAKE_FAST_ALLOCATED;
-public:
-typedef TypeSet Type;
+class AttributeBase {
+public:
class Range {
public:
int m_start;
int m_end;
};
-class Attribute {
-public:
-Range m_nameRange;
-Range m_valueRange;
-WTF::VectorUChar, 32 m_name;
-WTF::VectorUChar, 32 m_value;
-};
+Range m_nameRange;
+Range m_valueRange;
+WTF::VectorUChar, 32 m_name;
+WTF::VectorUChar, 32 m_value;
+};
+templatetypename TypeSet, typename DoctypeData = DoctypeDataBase, typename AttributeType = AttributeBase
+class MarkupTokenBase {
+WTF_MAKE_NONCOPYABLE(MarkupTokenBase);
+WTF_MAKE_FAST_ALLOCATED;
+public:
+typedef TypeSet Type;
+typedef AttributeType Attribute;
+
typedef WTF::VectorAttribute, 10 AttributeList;
typedef WTF::VectorUChar, 1024 DataVector;
@@ -334,20 +335,8 @@
{
DataVector::const_iterator iter = string.begin();
for (; iter != string.end(); ++iter)
-printf(%lc, wchar_t(*iter));
+fprintf(stderr, %lc, wchar_t(*iter));
}
-
-void printAttrs() const
-{
-typename AttributeList::const_iterator iter = m_attributes.begin();
-for (; iter != m_attributes.end(); ++iter) {
-printf( );
-printString(iter-m_name);
-printf(=\);
-printString(iter-m_value);
-printf(\);
-}
-}
#endif // NDEBUG
inline void appendToName(UChar character)
@@ -367,7 +356,7 @@
friend class AtomicHTMLToken;
typename Type::Type m_type;
-Range m_range; // Always starts at zero.
+typename Attribute::Range m_range; // Always starts at zero.
int m_baseOffset;
DataVector m_data;
Modified: trunk/Source/WebCore/xml/parser/XMLToken.h (92248 => 92249)
--- trunk/Source/WebCore/xml/parser/XMLToken.h 2011-08-03
[webkit-changes] [92250] trunk/Source/JavaScriptCore
Title: [92250] trunk/Source/_javascript_Core
Revision 92250
Author oli...@apple.com
Date 2011-08-02 17:41:11 -0700 (Tue, 02 Aug 2011)
Log Message
Simplify JSFunction creation for functions written in JS
https://bugs.webkit.org/show_bug.cgi?id=65422
Reviewed by Gavin Barraclough.
Remove hash lookups used to write name property and transition
function structure by caching the resultant structure and property
offset in JSGlobalObject. This doesn't impact performance, but
we can use this change to make other improvements later.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
* runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::FunctionExecutable::jsName):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::namedFunctionStructure):
(JSC::JSGlobalObject::functionNameOffset):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Executable.cpp
trunk/Source/_javascript_Core/runtime/Executable.h
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (92249 => 92250)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-03 00:04:06 UTC (rev 92249)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-03 00:41:11 UTC (rev 92250)
@@ -1,3 +1,28 @@
+2011-07-30 Oliver Hunt oli...@apple.com
+
+Simplify JSFunction creation for functions written in JS
+https://bugs.webkit.org/show_bug.cgi?id=65422
+
+Reviewed by Gavin Barraclough.
+
+Remove hash lookups used to write name property and transition
+function structure by caching the resultant structure and property
+offset in JSGlobalObject. This doesn't impact performance, but
+we can use this change to make other improvements later.
+
+* runtime/Executable.cpp:
+(JSC::FunctionExecutable::FunctionExecutable):
+* runtime/Executable.h:
+(JSC::ScriptExecutable::ScriptExecutable):
+(JSC::FunctionExecutable::jsName):
+* runtime/JSFunction.cpp:
+(JSC::JSFunction::JSFunction):
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::reset):
+* runtime/JSGlobalObject.h:
+(JSC::JSGlobalObject::namedFunctionStructure):
+(JSC::JSGlobalObject::functionNameOffset):
+
2011-08-02 Filip Pizlo fpi...@apple.com
JSC GC uses dummy cells to avoid having to remember which cells
Modified: trunk/Source/_javascript_Core/runtime/Executable.cpp (92249 => 92250)
--- trunk/Source/_javascript_Core/runtime/Executable.cpp 2011-08-03 00:04:06 UTC (rev 92249)
+++ trunk/Source/_javascript_Core/runtime/Executable.cpp 2011-08-03 00:41:11 UTC (rev 92250)
@@ -144,6 +144,7 @@
{
m_firstLine = firstLine;
m_lastLine = lastLine;
+m_nameValue.set(globalData, this, jsString(globalData, name.ustring()));
}
FunctionExecutable::FunctionExecutable(ExecState* exec, const Identifier name, const SourceCode source, bool forceUsesArguments, FunctionParameters* parameters, bool inStrictContext, int firstLine, int lastLine)
@@ -156,6 +157,7 @@
{
m_firstLine = firstLine;
m_lastLine = lastLine;
+m_nameValue.set(exec-globalData(), this, jsString(exec-globalData(), name.ustring()));
}
@@ -439,6 +441,8 @@
COMPILE_ASSERT(StructureFlags OverridesVisitChildren, OverridesVisitChildrenWithoutSettingFlag);
ASSERT(structure()-typeInfo().overridesVisitChildren());
ScriptExecutable::visitChildren(visitor);
+if (m_nameValue)
+visitor.append(m_nameValue);
if (m_codeBlockForCall)
m_codeBlockForCall-visitAggregate(visitor);
if (m_codeBlockForConstruct)
Modified: trunk/Source/_javascript_Core/runtime/Executable.h (92249 => 92250)
--- trunk/Source/_javascript_Core/runtime/Executable.h 2011-08-03 00:04:06 UTC (rev 92249)
+++ trunk/Source/_javascript_Core/runtime/Executable.h 2011-08-03 00:41:11 UTC (rev 92250)
@@ -226,7 +226,7 @@
{
#if ENABLE(CODEBLOCK_SAMPLING)
if (SamplingTool* sampler = globalData.interpreter-sampler())
-sampler-notifyOfScope(*globalData, this);
+sampler-notifyOfScope(globalData, this);
#else
UNUSED_PARAM(globalData);
#endif
@@ -478,6 +478,7 @@
}
const Identifier name() { return m_name; }
+JSString* nameValue() const { return m_nameValue.get(); }
size_t parameterCount() const { return m_parameters-size(); }
unsigned capturedVariableCount() const { return m_numCapturedVariables; }
UString paramString() const;
@@ -509,6 +510,7 @@
OwnPtrFunctionCodeBlock m_codeBlockForCall;
OwnPtrFunctionCodeBlock m_codeBlockForConstruct;
Identifier m_name;
+
[webkit-changes] [92251] trunk/Source/JavaScriptCore
Title: [92251] trunk/Source/_javascript_Core
Revision 92251
Author fpi...@apple.com
Date 2011-08-02 18:48:13 -0700 (Tue, 02 Aug 2011)
Log Message
JSC GC may not be able to reuse partially-free blocks after a
full collection
https://bugs.webkit.org/show_bug.cgi?id=65585
Reviewed by Darin Adler.
This fixes the linked list management bug. This fix is performance
neutral on SunSpider.
* heap/NewSpace.cpp:
(JSC::NewSpace::removeBlock):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/NewSpace.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (92250 => 92251)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-03 00:41:11 UTC (rev 92250)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-03 01:48:13 UTC (rev 92251)
@@ -1,3 +1,17 @@
+2011-08-02 Filip Pizlo fpi...@apple.com
+
+JSC GC may not be able to reuse partially-free blocks after a
+full collection
+https://bugs.webkit.org/show_bug.cgi?id=65585
+
+Reviewed by Darin Adler.
+
+This fixes the linked list management bug. This fix is performance
+neutral on SunSpider.
+
+* heap/NewSpace.cpp:
+(JSC::NewSpace::removeBlock):
+
2011-07-30 Oliver Hunt oli...@apple.com
Simplify JSFunction creation for functions written in JS
Modified: trunk/Source/_javascript_Core/heap/NewSpace.cpp (92250 => 92251)
--- trunk/Source/_javascript_Core/heap/NewSpace.cpp 2011-08-03 00:41:11 UTC (rev 92250)
+++ trunk/Source/_javascript_Core/heap/NewSpace.cpp 2011-08-03 01:48:13 UTC (rev 92251)
@@ -58,7 +58,8 @@
{
block-setInNewSpace(false);
SizeClass sizeClass = sizeClassFor(block-cellSize());
-sizeClass.nextBlock = block-next();
+if (sizeClass.nextBlock == block)
+sizeClass.nextBlock = block-next();
sizeClass.blockList.remove(block);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92253] trunk/Source/WebCore
Title: [92253] trunk/Source/WebCore
Revision 92253
Author macpher...@chromium.org
Date 2011-08-02 19:11:09 -0700 (Tue, 02 Aug 2011)
Log Message
Clean up value clampling in CSSStyleSelector and CSSPrimitiveValue.
https://bugs.webkit.org/show_bug.cgi?id=65441
Reviewed by Simon Fraser.
No new tests / refactoring only.
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::getFloatValue):
Implement in terms of the new templated getValue().
(WebCore::CSSPrimitiveValue::getIntValue):
Implement in terms of the new templated getValue().
(WebCore::CSSPrimitiveValue::getValue):
Templated getValue that works for all numeric types.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use getValueshort instead of rolling-your-own clamp to short.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92252 => 92253)
--- trunk/Source/WebCore/ChangeLog 2011-08-03 01:58:06 UTC (rev 92252)
+++ trunk/Source/WebCore/ChangeLog 2011-08-03 02:11:09 UTC (rev 92253)
@@ -1,3 +1,24 @@
+2011-08-02 Luke Macpherson macpher...@chromium.org
+
+Clean up value clampling in CSSStyleSelector and CSSPrimitiveValue.
+https://bugs.webkit.org/show_bug.cgi?id=65441
+
+Reviewed by Simon Fraser.
+
+No new tests / refactoring only.
+
+* css/CSSPrimitiveValue.h:
+(WebCore::CSSPrimitiveValue::getFloatValue):
+Implement in terms of the new templated getValue().
+(WebCore::CSSPrimitiveValue::getIntValue):
+Implement in terms of the new templated getValue().
+(WebCore::CSSPrimitiveValue::getValue):
+Templated getValue that works for all numeric types.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+Use getValueshort instead of rolling-your-own clamp to short.
+
2011-08-02 Julien Chaffraix jchaffr...@webkit.org
RenderObject::computeRectForRepaint and clippedOverflowRectForRepaint should be const
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.h (92252 => 92253)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.h 2011-08-03 01:58:06 UTC (rev 92252)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.h 2011-08-03 02:11:09 UTC (rev 92253)
@@ -157,14 +157,18 @@
double getDoubleValue() const { return m_value.num; }
void setFloatValue(unsigned short unitType, double floatValue, ExceptionCode);
-float getFloatValue(unsigned short unitType, ExceptionCode ec) const { return clampToFloat(getDoubleValue(unitType, ec)); }
-float getFloatValue(unsigned short unitType) const { return clampToFloat(getDoubleValue(unitType)); }
-float getFloatValue() const { return clampToFloat(m_value.num); }
+float getFloatValue(unsigned short unitType, ExceptionCode ec) const { return getValuefloat(unitType, ec); }
+float getFloatValue(unsigned short unitType) const { return getValuefloat(unitType); }
+float getFloatValue() const { return getValuefloat(); }
-int getIntValue(unsigned short unitType, ExceptionCode ec) const { return clampToInteger(getDoubleValue(unitType, ec)); }
-int getIntValue(unsigned short unitType) const { return clampToInteger(getDoubleValue(unitType)); }
-int getIntValue() const { return clampToInteger(m_value.num); }
+int getIntValue(unsigned short unitType, ExceptionCode ec) const { return getValueint(unitType, ec); }
+int getIntValue(unsigned short unitType) const { return getValueint(unitType); }
+int getIntValue() const { return getValueint(); }
+templatetypename T inline T getValue(unsigned short unitType, ExceptionCode ec) const { return clampToT(getDoubleValue(unitType, ec)); }
+templatetypename T inline T getValue(unsigned short unitType) const { return clampToT(getDoubleValue(unitType)); }
+templatetypename T inline T getValue() const { return clampToT(m_value.num); }
+
void setStringValue(unsigned short stringType, const String stringValue, ExceptionCode);
String getStringValue(ExceptionCode) const;
String getStringValue() const;
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (92252 => 92253)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-08-03 01:58:06 UTC (rev 92252)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-08-03 02:11:09 UTC (rev 92253)
@@ -4496,7 +4496,7 @@
if (!primitiveValue || primitiveValue-primitiveType() != CSSPrimitiveValue::CSS_NUMBER)
return; // Error case.
// Clamp opacity to the range 0-1
-m_style-setOpacity(min(1.0f, max(0.0f, primitiveValue-getFloatValue(;
+m_style-setOpacity(clampTofloat(primitiveValue-getDoubleValue(), 0, 1));
return;
case CSSPropertyWebkitBoxAlign:
HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(boxAlign, BoxAlign)
@@ -4770,7 +4770,7 @@
if (primitiveValue-getIdent() == CSSValueAuto)
[webkit-changes] [92254] trunk/Source
Title: [92254] trunk/Source Revision 92254 Author le...@chromium.org Date 2011-08-02 19:28:33 -0700 (Tue, 02 Aug 2011) Log Message Add asserts to RefCounted to make sure ref/deref happens on the right thread. https://bugs.webkit.org/show_bug.cgi?id=31639 Reviewed by Dmitry Titov. Source/_javascript_Core: * GNUmakefile.list.am: Added new files to the build. * _javascript_Core.gypi: Ditto. * _javascript_Core.vcproj/WTF/WTF.vcproj: Ditto. * _javascript_Core.xcodeproj/project.pbxproj: Ditto. * jit/ExecutableAllocator.h: (JSC::ExecutablePool::ExecutablePool): Turned off checks for this due to not being able to figure out what was guarding it (bug 58091). * parser/SourceProvider.h: (JSC::SourceProvider::SourceProvider): Ditto. * wtf/CMakeLists.txt: Added new files to the build. * wtf/ThreadRestrictionVerifier.h: Added. Everything is done in the header to avoid the issue with exports that are only useful in debug but still needing to export them. * wtf/RefCounted.h: (WTF::RefCountedBase::ref): Added checks using the non thread safe verifier. and filed bug 58171 about making it stricter. (WTF::RefCountedBase::hasOneRef): Ditto. (WTF::RefCountedBase::refCount): Ditto. (WTF::RefCountedBase::setMutexForVerifier): Expose a way to change the checks to be based on a mutex. This is in the header to avoid adding more exports from _javascript_Core. (WTF::RefCountedBase::deprecatedTurnOffVerifier): Temporary way to turn off verification. Filed bug 58174 to remove this method. (WTF::RefCountedBase::derefBase): * wtf/SizeLimits.cpp: Adjusted the debug size check for RefCounted. * wtf/text/CString.h: (WTF::CStringBuffer::CStringBuffer): Turned off checks for this while a fix is being done in Chromium (bug 58093). Source/_javascript_Glue: * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added. Source/WebCore: No new functionality exposed so no new tests. (The change is basically adding more testing.) * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added. * loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable. (WebCore::IconDatabase::setIconDataForIconURL): Ditto. (WebCore::IconDatabase::getOrCreateIconRecord): Ditto. (WebCore::IconDatabase::readFromDatabase): Ditto. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/_javascript_Core/_javascript_Core.gypi trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTF.vcproj trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/jit/ExecutableAllocator.h trunk/Source/_javascript_Core/parser/SourceProvider.h trunk/Source/_javascript_Core/wtf/CMakeLists.txt trunk/Source/_javascript_Core/wtf/RefCounted.h trunk/Source/_javascript_Core/wtf/SizeLimits.cpp trunk/Source/_javascript_Core/wtf/text/CString.h trunk/Source/_javascript_Glue/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/icon/IconDatabase.cpp Added Paths trunk/Source/_javascript_Core/wtf/ThreadRestrictionVerifier.h trunk/Source/_javascript_Glue/ForwardingHeaders/wtf/ThreadRestrictionVerifier.h trunk/Source/WebCore/ForwardingHeaders/wtf/ThreadRestrictionVerifier.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (92253 => 92254) --- trunk/Source/_javascript_Core/ChangeLog 2011-08-03 02:11:09 UTC (rev 92253) +++ trunk/Source/_javascript_Core/ChangeLog 2011-08-03 02:28:33 UTC (rev 92254) @@ -1,3 +1,38 @@ +2011-08-01 David Levin le...@chromium.org + +Add asserts to RefCounted to make sure ref/deref happens on the right thread. +https://bugs.webkit.org/show_bug.cgi?id=31639 + +Reviewed by Dmitry Titov. + +* GNUmakefile.list.am: Added new files to the build. +* _javascript_Core.gypi: Ditto. +* _javascript_Core.vcproj/WTF/WTF.vcproj: Ditto. +* _javascript_Core.xcodeproj/project.pbxproj: Ditto. +* jit/ExecutableAllocator.h: +(JSC::ExecutablePool::ExecutablePool): Turned off checks for this +due to not being able to figure out what was guarding it (bug 58091). +* parser/SourceProvider.h: +(JSC::SourceProvider::SourceProvider): Ditto. +* wtf/CMakeLists.txt: Added new files to the build. +* wtf/ThreadRestrictionVerifier.h: Added. +Everything is done in the header to avoid the issue with exports +that are only useful in debug but still needing to export them. +* wtf/RefCounted.h: +(WTF::RefCountedBase::ref): Added checks using the non thread safe verifier. +and filed bug 58171 about making it stricter. +(WTF::RefCountedBase::hasOneRef): Ditto. +(WTF::RefCountedBase::refCount): Ditto. +(WTF::RefCountedBase::setMutexForVerifier): Expose a way to change the checks to be based +on a mutex. This is in the header to avoid adding more exports from _javascript_Core. +
[webkit-changes] [92256] trunk/Source/WebCore
Title: [92256] trunk/Source/WebCore
Revision 92256
Author hay...@chromium.org
Date 2011-08-02 20:25:57 -0700 (Tue, 02 Aug 2011)
Log Message
Make EventDispatchMediator RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=65529
Reviewed by Dimitri Glazkov.
Make EventDispatchMediator RefCounted so that it can be enqueued into a
ScopedEventQueue and called later.
A necessary change for ScopedEventQueue should be addressed in another patch.
No changes to functionality so no new tests.
* dom/Event.cpp:
(WebCore::EventDispatchMediator::create):
* dom/Event.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventDispatcher.h:
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEventDispatchMediator::create):
* dom/KeyboardEvent.h:
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::create):
* dom/MouseEvent.h:
* dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):
* dom/WheelEvent.cpp:
(WebCore::WheelEventDispatchMediator::create):
* dom/WheelEvent.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Event.cpp
trunk/Source/WebCore/dom/Event.h
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/EventDispatcher.h
trunk/Source/WebCore/dom/KeyboardEvent.cpp
trunk/Source/WebCore/dom/KeyboardEvent.h
trunk/Source/WebCore/dom/MouseEvent.cpp
trunk/Source/WebCore/dom/MouseEvent.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/WheelEvent.cpp
trunk/Source/WebCore/dom/WheelEvent.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92255 => 92256)
--- trunk/Source/WebCore/ChangeLog 2011-08-03 02:52:17 UTC (rev 92255)
+++ trunk/Source/WebCore/ChangeLog 2011-08-03 03:25:57 UTC (rev 92256)
@@ -1,3 +1,37 @@
+2011-08-02 Hayato Ito hay...@chromium.org
+
+Make EventDispatchMediator RefCounted.
+https://bugs.webkit.org/show_bug.cgi?id=65529
+
+Reviewed by Dimitri Glazkov.
+
+Make EventDispatchMediator RefCounted so that it can be enqueued into a
+ScopedEventQueue and called later.
+A necessary change for ScopedEventQueue should be addressed in another patch.
+
+No changes to functionality so no new tests.
+
+* dom/Event.cpp:
+(WebCore::EventDispatchMediator::create):
+* dom/Event.h:
+* dom/EventDispatcher.cpp:
+(WebCore::EventDispatcher::dispatchEvent):
+* dom/EventDispatcher.h:
+* dom/KeyboardEvent.cpp:
+(WebCore::KeyboardEventDispatchMediator::create):
+* dom/KeyboardEvent.h:
+* dom/MouseEvent.cpp:
+(WebCore::MouseEventDispatchMediator::create):
+* dom/MouseEvent.h:
+* dom/Node.cpp:
+(WebCore::Node::dispatchEvent):
+(WebCore::Node::dispatchKeyEvent):
+(WebCore::Node::dispatchMouseEvent):
+(WebCore::Node::dispatchWheelEvent):
+* dom/WheelEvent.cpp:
+(WebCore::WheelEventDispatchMediator::create):
+* dom/WheelEvent.h:
+
2011-08-02 David Reveman reve...@chromium.org
[Chromium] Use edge-distance method for layer anti-aliasing.
Modified: trunk/Source/WebCore/dom/Event.cpp (92255 => 92256)
--- trunk/Source/WebCore/dom/Event.cpp 2011-08-03 02:52:17 UTC (rev 92255)
+++ trunk/Source/WebCore/dom/Event.cpp 2011-08-03 03:25:57 UTC (rev 92256)
@@ -289,6 +289,11 @@
m_underlyingEvent = ue;
}
+PassRefPtrEventDispatchMediator EventDispatchMediator::create(PassRefPtrEvent event)
+{
+return adoptRef(new EventDispatchMediator(event));
+}
+
EventDispatchMediator::EventDispatchMediator(PassRefPtrEvent event)
: m_event(event)
{
Modified: trunk/Source/WebCore/dom/Event.h (92255 => 92256)
--- trunk/Source/WebCore/dom/Event.h 2011-08-03 02:52:17 UTC (rev 92255)
+++ trunk/Source/WebCore/dom/Event.h 2011-08-03 03:25:57 UTC (rev 92256)
@@ -199,14 +199,15 @@
RefPtrEvent m_underlyingEvent;
};
-class EventDispatchMediator {
+class EventDispatchMediator : public RefCountedEvent {
public:
-explicit EventDispatchMediator(PassRefPtrEvent);
+static PassRefPtrEventDispatchMediator create(PassRefPtrEvent);
virtual ~EventDispatchMediator();
virtual bool dispatchEvent(EventDispatcher*) const;
protected:
+explicit EventDispatchMediator(PassRefPtrEvent);
EventDispatchMediator();
Event* event() const;
Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (92255 => 92256)
--- trunk/Source/WebCore/dom/EventDispatcher.cpp 2011-08-03 02:52:17 UTC (rev 92255)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp 2011-08-03 03:25:57 UTC (rev 92256)
@@ -46,12 +46,12 @@
static HashSetNode** gNodesDispatchingSimulatedClicks = 0;
-bool EventDispatcher::dispatchEvent(Node* node, const EventDispatchMediator mediator)
+bool EventDispatcher::dispatchEvent(Node* node, PassRefPtrEventDispatchMediator mediator)
{
ASSERT(!eventDispatchForbidden());
EventDispatcher
[webkit-changes] [92257] trunk/LayoutTests
Title: [92257] trunk/LayoutTests Revision 92257 Author jam...@google.com Date 2011-08-02 20:26:43 -0700 (Tue, 02 Aug 2011) Log Message Expectation follow-up for r92255 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92256 => 92257) --- trunk/LayoutTests/ChangeLog 2011-08-03 03:25:57 UTC (rev 92256) +++ trunk/LayoutTests/ChangeLog 2011-08-03 03:26:43 UTC (rev 92257) @@ -1,3 +1,9 @@ +2011-08-02 James Robinson jam...@chromium.org + +Expectation follow-up for r92255 + +* platform/chromium/test_expectations.txt: + 2011-08-02 David Reveman reve...@chromium.org [Chromium] Use edge-distance method for layer anti-aliasing. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92256 => 92257) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-03 03:25:57 UTC (rev 92256) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-03 03:26:43 UTC (rev 92257) @@ -2704,25 +2704,42 @@ // 2 pixel stretching when rendering some videos with the GPU (Now it's flaky) BUGCR74102 GPU LINUX : media/video-controls-rendering.html = IMAGE PASS -BUGWK64942 : compositing/color-matching/image-color-matching.html = IMAGE -BUGWK64942 : compositing/geometry/ancestor-overflow-change.html = IMAGE -BUGWK64942 : compositing/geometry/fixed-position.html = IMAGE -BUGWK64942 : compositing/geometry/layer-due-to-layer-children-deep.html = IMAGE -BUGWK64942 : compositing/geometry/layer-due-to-layer-children.html = IMAGE -BUGWK64942 : compositing/geometry/vertical-scroll-composited.html = IMAGE -BUGWK64942 : compositing/overflow/fixed-position-ancestor-clip.html = IMAGE -BUGWK64942 : compositing/reflections/nested-reflection-transition.html = IMAGE -BUGWK64942 : compositing/reflections/transform-inside-reflection.html = IMAGE -BUGWK64942 : compositing/shadows/shadow-drawing.html = IMAGE -BUGWK64942 : compositing/transitions/scale-transition-no-start.html = IMAGE -BUGWK64942 : media/video-transformed.html = IMAGE -BUGWK64942 : media/video-zoom-controls.html = IMAGE -BUGWK64942 : platform/chromium/compositing/backface-visibility-transformed.html = IMAGE -BUGWK64942 : platform/chromium/compositing/huge-layer-rotated.html = IMAGE -BUGWK64942 : platform/chromium/compositing/perpendicular-layer-sorting.html = IMAGE -BUGWK64942 : platform/chromium/compositing/tiny-layer-rotated.html = IMAGE +BUGWK64942 GPU : compositing/color-matching/image-color-matching.html = IMAGE +BUGWK64942 GPU RELEASE LINUX : compositing/direct-image-compositing.html = IMAGE +BUGWK64942 GPU WIN MAC : compositing/direct-image-compositing.html = IMAGE +BUGWK64942 GPU : compositing/geometry/ancestor-overflow-change.html = IMAGE +BUGWK64942 GPU RELEASE LINUX : compositing/geometry/fixed-in-composited.html = IMAGE +BUGWK64942 GPU WIN MAC : compositing/geometry/fixed-in-composited.html = IMAGE +BUGWK64942 GPU : compositing/geometry/fixed-position.html = IMAGE +BUGWK64942 GPU : compositing/geometry/layer-due-to-layer-children-deep.html = IMAGE +BUGWK64942 GPU : compositing/geometry/layer-due-to-layer-children.html = IMAGE +BUGWK64942 GPU WIN : compositing/geometry/tall-page-composited.html = IMAGE +BUGWK64942 GPU RELEASE LINUX : compositing/geometry/tall-page-composited.html = IMAGE +BUGWK64942 GPU : compositing/geometry/vertical-scroll-composited.html = IMAGE +BUGWK64942 GPU RELEASE LINUX : compositing/masks/masked-ancestor.html = IMAGE +BUGWK64942 GPU WIN MAC : compositing/masks/masked-ancestor.html = IMAGE +BUGWK64942 GPU RELEASE LINUX : compositing/masks/simple-composited-mask.html = IMAGE +BUGWK64942 GPU WIN MAC : compositing/masks/simple-composited-mask.html = IMAGE +BUGWK64942 GPU : compositing/overflow/fixed-position-ancestor-clip.html = IMAGE +BUGWK64942 GPU : compositing/reflections/nested-reflection-transition.html = IMAGE +BUGWK64942 GPU : compositing/reflections/transform-inside-reflection.html = IMAGE +BUGWK64942 GPU : compositing/shadows/shadow-drawing.html = IMAGE +BUGWK64942 GPU : compositing/transitions/scale-transition-no-start.html = IMAGE +BUGWK64942 GPU RELEASE LINUX : fast/canvas/canvas-text-alignment.html = IMAGE +BUGWK64942 GPU WIN MAC : fast/canvas/canvas-text-alignment.html = IMAGE +BUGWK64942 GPU RELEASE LINUX : fast/canvas/image-object-in-canvas.html = IMAGE +BUGWK64942 GPU WIN MAC : fast/canvas/image-object-in-canvas.html = IMAGE +BUGWK64942 GPU : media/video-transformed.html = IMAGE +BUGWK64942 GPU : media/video-zoom-controls.html = IMAGE +BUGWK64942 GPU WIN : media/video-zoom.html = IMAGE +BUGWK64942 GPU RELEASE LINUX : media/video-zoom.html = IMAGE +BUGWK64942 GPU : platform/chromium/compositing/backface-visibility-transformed.html = IMAGE +BUGWK64942 GPU : platform/chromium/compositing/huge-layer-rotated.html = IMAGE +BUGWK64942 GPU RELEASE LINUX : platform/chromium/compositing/layout-width-change.html = IMAGE
[webkit-changes] [92258] trunk/LayoutTests
Title: [92258] trunk/LayoutTests Revision 92258 Author jam...@google.com Date 2011-08-02 20:59:03 -0700 (Tue, 02 Aug 2011) Log Message More expectation updates for r92255 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92257 => 92258) --- trunk/LayoutTests/ChangeLog 2011-08-03 03:26:43 UTC (rev 92257) +++ trunk/LayoutTests/ChangeLog 2011-08-03 03:59:03 UTC (rev 92258) @@ -1,5 +1,11 @@ 2011-08-02 James Robinson jam...@chromium.org +More expectation updates for r92255 + +* platform/chromium/test_expectations.txt: + +2011-08-02 James Robinson jam...@chromium.org + Expectation follow-up for r92255 * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92257 => 92258) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-03 03:26:43 UTC (rev 92257) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-03 03:59:03 UTC (rev 92258) @@ -2739,6 +2739,7 @@ BUGWK64942 GPU WIN MAC : platform/chromium/compositing/layout-width-change.html = IMAGE BUGWK64942 GPU : platform/chromium/compositing/perpendicular-layer-sorting.html = IMAGE BUGWK64942 GPU : platform/chromium/compositing/tiny-layer-rotated.html = IMAGE +BUGWK64942 GPU MAC : compositing/geometry/horizontal-scroll-composited.html = IMAGE BUGCR72223 : media/video-frame-accurate-seek.html = IMAGE PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92259] trunk/Source/WebCore
Title: [92259] trunk/Source/WebCore
Revision 92259
Author commit-qu...@webkit.org
Date 2011-08-02 21:26:52 -0700 (Tue, 02 Aug 2011)
Log Message
Unreviewed, rolling out r92256.
http://trac.webkit.org/changeset/92256
https://bugs.webkit.org/show_bug.cgi?id=65593
Causing tons of crashes on the chromium win bots (Requested by
jamesr on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-08-02
* dom/Event.cpp:
* dom/Event.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventDispatcher.h:
* dom/KeyboardEvent.cpp:
* dom/KeyboardEvent.h:
* dom/MouseEvent.cpp:
* dom/MouseEvent.h:
* dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchWheelEvent):
* dom/WheelEvent.cpp:
* dom/WheelEvent.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Event.cpp
trunk/Source/WebCore/dom/Event.h
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/EventDispatcher.h
trunk/Source/WebCore/dom/KeyboardEvent.cpp
trunk/Source/WebCore/dom/KeyboardEvent.h
trunk/Source/WebCore/dom/MouseEvent.cpp
trunk/Source/WebCore/dom/MouseEvent.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/WheelEvent.cpp
trunk/Source/WebCore/dom/WheelEvent.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92258 => 92259)
--- trunk/Source/WebCore/ChangeLog 2011-08-03 03:59:03 UTC (rev 92258)
+++ trunk/Source/WebCore/ChangeLog 2011-08-03 04:26:52 UTC (rev 92259)
@@ -1,3 +1,29 @@
+2011-08-02 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r92256.
+http://trac.webkit.org/changeset/92256
+https://bugs.webkit.org/show_bug.cgi?id=65593
+
+Causing tons of crashes on the chromium win bots (Requested by
+jamesr on #webkit).
+
+* dom/Event.cpp:
+* dom/Event.h:
+* dom/EventDispatcher.cpp:
+(WebCore::EventDispatcher::dispatchEvent):
+* dom/EventDispatcher.h:
+* dom/KeyboardEvent.cpp:
+* dom/KeyboardEvent.h:
+* dom/MouseEvent.cpp:
+* dom/MouseEvent.h:
+* dom/Node.cpp:
+(WebCore::Node::dispatchEvent):
+(WebCore::Node::dispatchKeyEvent):
+(WebCore::Node::dispatchMouseEvent):
+(WebCore::Node::dispatchWheelEvent):
+* dom/WheelEvent.cpp:
+* dom/WheelEvent.h:
+
2011-08-02 Hayato Ito hay...@chromium.org
Make EventDispatchMediator RefCounted.
Modified: trunk/Source/WebCore/dom/Event.cpp (92258 => 92259)
--- trunk/Source/WebCore/dom/Event.cpp 2011-08-03 03:59:03 UTC (rev 92258)
+++ trunk/Source/WebCore/dom/Event.cpp 2011-08-03 04:26:52 UTC (rev 92259)
@@ -289,11 +289,6 @@
m_underlyingEvent = ue;
}
-PassRefPtrEventDispatchMediator EventDispatchMediator::create(PassRefPtrEvent event)
-{
-return adoptRef(new EventDispatchMediator(event));
-}
-
EventDispatchMediator::EventDispatchMediator(PassRefPtrEvent event)
: m_event(event)
{
Modified: trunk/Source/WebCore/dom/Event.h (92258 => 92259)
--- trunk/Source/WebCore/dom/Event.h 2011-08-03 03:59:03 UTC (rev 92258)
+++ trunk/Source/WebCore/dom/Event.h 2011-08-03 04:26:52 UTC (rev 92259)
@@ -199,15 +199,14 @@
RefPtrEvent m_underlyingEvent;
};
-class EventDispatchMediator : public RefCountedEvent {
+class EventDispatchMediator {
public:
-static PassRefPtrEventDispatchMediator create(PassRefPtrEvent);
+explicit EventDispatchMediator(PassRefPtrEvent);
virtual ~EventDispatchMediator();
virtual bool dispatchEvent(EventDispatcher*) const;
protected:
-explicit EventDispatchMediator(PassRefPtrEvent);
EventDispatchMediator();
Event* event() const;
Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (92258 => 92259)
--- trunk/Source/WebCore/dom/EventDispatcher.cpp 2011-08-03 03:59:03 UTC (rev 92258)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp 2011-08-03 04:26:52 UTC (rev 92259)
@@ -46,12 +46,12 @@
static HashSetNode** gNodesDispatchingSimulatedClicks = 0;
-bool EventDispatcher::dispatchEvent(Node* node, PassRefPtrEventDispatchMediator mediator)
+bool EventDispatcher::dispatchEvent(Node* node, const EventDispatchMediator mediator)
{
ASSERT(!eventDispatchForbidden());
EventDispatcher dispatcher(node);
-return mediator-dispatchEvent(dispatcher);
+return mediator.dispatchEvent(dispatcher);
}
static EventTarget* findElementInstance(Node* referenceNode)
Modified: trunk/Source/WebCore/dom/EventDispatcher.h (92258 => 92259)
--- trunk/Source/WebCore/dom/EventDispatcher.h 2011-08-03 03:59:03 UTC (rev 92258)
+++ trunk/Source/WebCore/dom/EventDispatcher.h 2011-08-03 04:26:52 UTC (rev 92259)
@@ -48,9 +48,8 @@
class EventDispatcher {
public:
-static bool dispatchEvent(Node*, PassRefPtrEventDispatchMediator);
+static bool dispatchEvent(Node*, const EventDispatchMediator);
static void dispatchScopedEvent(Node*, PassRefPtrEvent);
-
[webkit-changes] [92261] trunk/Source/WebCore
Title: [92261] trunk/Source/WebCore
Revision 92261
Author psola...@apple.com
Date 2011-08-02 22:07:51 -0700 (Tue, 02 Aug 2011)
Log Message
Crash in ResourceResponse::platformCompare() with USE(CFNETWORK)
https://bugs.webkit.org/show_bug.cgi?id=65584
Reviewed by David Kilzer.
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformCompare): Don't call CFEqual with 0 as an argument.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92260 => 92261)
--- trunk/Source/WebCore/ChangeLog 2011-08-03 04:37:51 UTC (rev 92260)
+++ trunk/Source/WebCore/ChangeLog 2011-08-03 05:07:51 UTC (rev 92261)
@@ -1,3 +1,13 @@
+2011-08-02 Pratik Solanki psola...@apple.com
+
+Crash in ResourceResponse::platformCompare() with USE(CFNETWORK)
+https://bugs.webkit.org/show_bug.cgi?id=65584
+
+Reviewed by David Kilzer.
+
+* platform/network/cf/ResourceResponseCFNet.cpp:
+(WebCore::ResourceResponse::platformCompare): Don't call CFEqual with 0 as an argument.
+
2011-08-02 Takashi Toyoshima toyos...@chromium.org
WebSocket: Should be closed by receiving invalid continuation frame.
Modified: trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp (92260 => 92261)
--- trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp 2011-08-03 04:37:51 UTC (rev 92260)
+++ trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp 2011-08-03 05:07:51 UTC (rev 92261)
@@ -137,6 +137,9 @@
bool ResourceResponse::platformCompare(const ResourceResponse a, const ResourceResponse b)
{
+// CFEqual crashes if you pass it 0 so do an early check before calling it.
+if (!a.cfURLResponse() || !b.cfURLResponse())
+return a.cfURLResponse() == b.cfURLResponse();
return CFEqual(a.cfURLResponse(), b.cfURLResponse());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
