[webkit-changes] [93088] trunk/LayoutTests

[zoltan]

Title: [93088] trunk/LayoutTests








Revision 93088
Author zol...@webkit.org
Date 2011-08-16 01:57:13 -0700 (Tue, 16 Aug 2011)


Log Message
[Qt] Ossyize editing/deleting/regional-indicators.html since it fails after r93068
https://bugs.webkit.org/show_bug.cgi?id=66268

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (93087 => 93088)

--- trunk/LayoutTests/ChangeLog	2011-08-16 07:00:44 UTC (rev 93087)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 08:57:13 UTC (rev 93088)
@@ -1,3 +1,10 @@
+2011-08-16  Zoltan Horvath  zol...@webkit.org
+
+[Qt] Ossyize editing/deleting/regional-indicators.html since it fails after r93068
+https://bugs.webkit.org/show_bug.cgi?id=66268
+
+* platform/qt/Skipped:
+
 2011-08-15  MORITA Hajime  morr...@google.com
 
 REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating textarea value.


Modified: trunk/LayoutTests/platform/qt/Skipped (93087 => 93088)

--- trunk/LayoutTests/platform/qt/Skipped	2011-08-16 07:00:44 UTC (rev 93087)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-08-16 08:57:13 UTC (rev 93088)
@@ -2362,3 +2362,7 @@
 # [Qt] Implement layouTestController.setShouldStayOnPageAfterHandlingBeforeUnload
 # https://bugs.webkit.org/show_bug.cgi?id=66162
 fast/loader/form-submission-after-beforeunload-cancel.html
+
+# [Qt] editing/deleting/regional-indicators.html after r93068
+# https://bugs.webkit.org/show_bug.cgi?id=66268
+editing/deleting/regional-indicators.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93089] trunk/LayoutTests

[vsevik]

Title: [93089] trunk/LayoutTests








Revision 93089
Author vse...@chromium.org
Date 2011-08-16 03:04:55 -0700 (Tue, 16 Aug 2011)


Log Message
Web Inspector: resource-tree-errors-reload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=66217

Reviewed by Pavel Feldman.

* http/tests/inspector/resource-tree/resource-tree-errors-reload.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-errors-reload.html




Diff

Modified: trunk/LayoutTests/ChangeLog (93088 => 93089)

--- trunk/LayoutTests/ChangeLog	2011-08-16 08:57:13 UTC (rev 93088)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 10:04:55 UTC (rev 93089)
@@ -1,3 +1,12 @@
+2011-08-15  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: resource-tree-errors-reload.html is flaky.
+https://bugs.webkit.org/show_bug.cgi?id=66217
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/resource-tree/resource-tree-errors-reload.html:
+
 2011-08-16  Zoltan Horvath  zol...@webkit.org
 
 [Qt] Ossyize editing/deleting/regional-indicators.html since it fails after r93068


Modified: trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-errors-reload.html (93088 => 93089)

--- trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-errors-reload.html	2011-08-16 08:57:13 UTC (rev 93088)
+++ trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-errors-reload.html	2011-08-16 10:04:55 UTC (rev 93089)
@@ -11,8 +11,34 @@
 
 function test()
 {
-InspectorTest.reloadPage(step1);
+var resourcesWereFinished = false;
+var pageWasReloaded = false;
 
+WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.FrameDetached, frameDetached);
+InspectorTest.reloadPage(pageReloaded);
+
+function frameDetached()
+{
+InspectorTest.runAfterResourcesAreFinished([resource-tree-errors-reload.html], resourcesFinished);
+}
+
+function resourcesFinished()
+{
+if (pageWasReloaded)
+step1();
+else
+resourcesWereFinished = true;
+}
+
+function pageReloaded()
+{
+if (resourcesWereFinished)
+step1();
+else
+pageWasReloaded = true;
+
+}
+
 function step1()
 {
 var resource = WebInspector.resourceTreeModel.resourceForURL(http://127.0.0.1:8000/inspector/resource-tree/resource-tree-errors-reload.html);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93090] trunk/Tools

[dino]

Title: [93090] trunk/Tools








Revision 93090
Author d...@apple.com
Date 2011-08-16 04:35:17 -0700 (Tue, 16 Aug 2011)


Log Message
Move me from contributor to reviewer.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (93089 => 93090)

--- trunk/Tools/ChangeLog	2011-08-16 10:04:55 UTC (rev 93089)
+++ trunk/Tools/ChangeLog	2011-08-16 11:35:17 UTC (rev 93090)
@@ -1,3 +1,9 @@
+2011-08-16  Dean Jackson  d...@apple.com
+
+Move me from contributor to reviewer.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2011-08-15  Dimitri Glazkov  dglaz...@chromium.org
 
 garden-o-matic frontend needs model.commitDataForRevisionRange function.


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (93089 => 93090)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-08-16 10:04:55 UTC (rev 93089)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-08-16 11:35:17 UTC (rev 93090)
@@ -138,7 +138,6 @@
 Committer(Cris Neckar, c...@chromium.org, cneckar),
 Committer(Daniel Cheng, dch...@chromium.org, dcheng),
 Committer(David Smith, [catfish@gmail.com, dsm...@webkit.org], catfishman),
-Committer(Dean Jackson, d...@apple.com, dino),
 Committer(Diego Gonzalez, [diego...@webkit.org, diego.gonza...@openbossa.org], diegohcg),
 Committer(Dmitry Lomov, [dslo...@google.com, dslo...@chromium.org], dslomov),
 Committer(Dominic Cooney, domin...@chromium.org, dominicc),
@@ -313,6 +312,7 @@
 Reviewer(David Hyatt, hy...@apple.com, hyatt),
 Reviewer(David Kilzer, [ddkil...@webkit.org, ddkil...@apple.com], ddkilzer),
 Reviewer(David Levin, le...@chromium.org, dave_levin),
+Reviewer(Dean Jackson, d...@apple.com, dino),
 Reviewer(Dimitri Glazkov, dglaz...@chromium.org, dglazkov),
 Reviewer(Dirk Pranke, dpra...@chromium.org, dpranke),
 Reviewer(Dirk Schulze, k...@webkit.org, krit),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93091] trunk/LayoutTests

[abecsi]

Title: [93091] trunk/LayoutTests








Revision 93091
Author abe...@webkit.org
Date 2011-08-16 05:46:59 -0700 (Tue, 16 Aug 2011)


Log Message
WebKitTestRunner needs a more-complete implementation of eventSender
https://bugs.webkit.org/show_bug.cgi?id=42194

Unreviewed gardening.

* platform/wk2/Skipped: skip editing/input/style-change-during-input.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (93090 => 93091)

--- trunk/LayoutTests/ChangeLog	2011-08-16 11:35:17 UTC (rev 93090)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 12:46:59 UTC (rev 93091)
@@ -1,3 +1,12 @@
+2011-08-16  Andras Becsi  abe...@webkit.org
+
+WebKitTestRunner needs a more-complete implementation of eventSender
+https://bugs.webkit.org/show_bug.cgi?id=42194
+
+Unreviewed gardening.
+
+* platform/wk2/Skipped: skip editing/input/style-change-during-input.html
+
 2011-08-15  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: resource-tree-errors-reload.html is flaky.


Modified: trunk/LayoutTests/platform/wk2/Skipped (93090 => 93091)

--- trunk/LayoutTests/platform/wk2/Skipped	2011-08-16 11:35:17 UTC (rev 93090)
+++ trunk/LayoutTests/platform/wk2/Skipped	2011-08-16 12:46:59 UTC (rev 93091)
@@ -90,6 +90,7 @@
 editing/input/option-page-up-down.html
 editing/input/page-up-down-scrolls.html
 editing/input/scroll-viewport-page-up-down.html
+editing/input/style-change-during-input.html
 editing/inserting/typing-tab-designmode-forms.html
 editing/inserting/typing-tab-designmode.html
 editing/pasteboard/4944770-2.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93092] trunk/Source/WebKit/gtk

[kov]

Title: [93092] trunk/Source/WebKit/gtk








Revision 93092
Author k...@webkit.org
Date 2011-08-16 06:01:42 -0700 (Tue, 16 Aug 2011)


Log Message
Add _javascript_coregtk to the introspection build, to fix it.

Patch by Gustavo Noronha Silva  gustavo.noro...@collabora.com in 2011-08-16
Reviewed by Xan Lopez.

* GNUmakefile.am:

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/GNUmakefile.am




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (93091 => 93092)

--- trunk/Source/WebKit/gtk/ChangeLog	2011-08-16 12:46:59 UTC (rev 93091)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-08-16 13:01:42 UTC (rev 93092)
@@ -1,3 +1,11 @@
+2011-08-16  Gustavo Noronha Silva  gustavo.noro...@collabora.com
+
+Add _javascript_coregtk to the introspection build, to fix it.
+
+Reviewed by Xan Lopez.
+
+* GNUmakefile.am:
+
 2011-08-15  Dmitry Titov  dim...@chromium.org
 
 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters


Modified: trunk/Source/WebKit/gtk/GNUmakefile.am (93091 => 93092)

--- trunk/Source/WebKit/gtk/GNUmakefile.am	2011-08-16 12:46:59 UTC (rev 93091)
+++ trunk/Source/WebKit/gtk/GNUmakefile.am	2011-08-16 13:01:42 UTC (rev 93092)
@@ -279,6 +279,7 @@
 	 --include=JSCore-@WEBKITGTK_API_VERSION@ \
 	 --include=Soup-2.4 \
 	 --library=webkitgtk-@WEBKITGTK_API_VERSION@ \
+	 --library=_javascript_coregtk-@WEBKITGTK_API_VERSION@ \
 	 --libtool=$(LIBTOOL) \
 	 --pkg=gobject-2.0 \
 	 --pkg=gtk+-@GTK_API_VERSION@ \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93093] trunk/Source

[benjamin . poulain]

Title: [93093] trunk/Source








Revision 93093
Author benjamin.poul...@nokia.com
Date 2011-08-16 06:11:23 -0700 (Tue, 16 Aug 2011)


Log Message
[Qt] Missing spell check support
https://bugs.webkit.org/show_bug.cgi?id=44114

Patch by Lindsay Mathieson lindsay.mathie...@gmail.com on 2011-08-16
Reviewed by Benjamin Poulain.

Source/WebCore: 

Add drawErrorUnderline() from Cairo to render the line for text checking on the Qt port.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::drawErrorUnderline):
(WebCore::GraphicsContext::drawLineForTextChecking):

Source/WebKit/qt: 

Added a platform plugin to allow spell and grammar check in QtWebKit.

* Api/qwebkitplatformplugin.h:
* QtWebKit.pro:
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientQt::isGrammarCheckingEnabled):
(WebCore::EditorClientQt::toggleContinuousSpellChecking):
(WebCore::EditorClientQt::toggleGrammarChecking):
* WebCoreSupport/EditorClientQt.h:
(WebCore::EditorClientQt::textChecker):
* WebCoreSupport/QtPlatformPlugin.cpp:
(WebCore::QtPlatformPlugin::createSpellChecker):
* WebCoreSupport/QtPlatformPlugin.h:
* WebCoreSupport/TextCheckerClientQt.cpp: Added.
(convertToVectorList):
(WebCore::TextCheckerClientQt::ignoreWordInSpellDocument):
(WebCore::TextCheckerClientQt::learnWord):
(WebCore::TextCheckerClientQt::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::TextCheckerClientQt::checkSpellingOfString):
(WebCore::TextCheckerClientQt::checkGrammarOfString):
(WebCore::TextCheckerClientQt::getGuessesForWord):
(WebCore::TextCheckerClientQt::isContinousSpellCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleContinousSpellChecking):
(WebCore::TextCheckerClientQt::isGrammarCheckingEnabled):
(WebCore::TextCheckerClientQt::toggleGrammarChecking):
(WebCore::TextCheckerClientQt::loadSpellChecker):
* WebCoreSupport/TextCheckerClientQt.h: Added.
(WebCore::TextCheckerClientQt::requestCheckingOfString):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp
trunk/Source/WebKit/qt/Api/qwebkitplatformplugin.h
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/QtWebKit.pro
trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h
trunk/Source/WebKit/qt/WebCoreSupport/QtPlatformPlugin.cpp
trunk/Source/WebKit/qt/WebCoreSupport/QtPlatformPlugin.h


Added Paths

trunk/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93092 => 93093)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 13:01:42 UTC (rev 93092)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 13:11:23 UTC (rev 93093)
@@ -1,3 +1,16 @@
+2011-08-16  Lindsay Mathieson   lindsay.mathie...@gmail.com
+
+[Qt] Missing spell check support
+https://bugs.webkit.org/show_bug.cgi?id=44114
+
+Reviewed by Benjamin Poulain.
+
+Add drawErrorUnderline() from Cairo to render the line for text checking on the Qt port.
+
+* platform/graphics/qt/GraphicsContextQt.cpp:
+(WebCore::drawErrorUnderline):
+(WebCore::GraphicsContext::drawLineForTextChecking):
+
 2011-08-15  MORITA Hajime  morr...@google.com
 
 REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating textarea value.


Modified: trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp (93092 => 93093)

--- trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp	2011-08-16 13:01:42 UTC (rev 93092)
+++ trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp	2011-08-16 13:11:23 UTC (rev 93093)
@@ -900,12 +900,106 @@
 drawLine(IntPoint(startPoint.x(), startPoint.y()), IntPoint(endPoint.x(), endPoint.y()));
 }
 
-void GraphicsContext::drawLineForTextChecking(const FloatPoint, float, TextCheckingLineStyle)
+
+/*
+ *   NOTE: This code is completely based upon the one from
+ *   Source/WebCore/platform/graphics/cairo/DrawErrorUnderline.{h|cpp}
+ *
+ *   Draws an error underline that looks like one of:
+ *
+ *   H   EH
+ *  /\  /\  /\/\  /\   -
+ *A/  \/  \/  \ A/  \/  \  |
+ * \   \  /\  /   /D \   \  /\ |
+ *  \   \/  C   \/   /\   \/   C  \| height = heightSquares * square
+ *   \  /\  F   /  \  F   /\   \   |
+ *\/  \/\/  \   \G |
+ * \  /\  /  \  /\  /  |
+ *  \/  \/\/  \/   -
+ *  B B
+ *  |---|
+ *unitWidth = (heightSquares - 1) * square
+ *
+ *  The x, y, width, height passed in give the desired bounding box;
+ *  x/width are adjusted to make the underline a integer number of units wide.
+*/
+static void 

[webkit-changes] [93094] trunk/LayoutTests

[steveblock]

Title: [93094] trunk/LayoutTests








Revision 93094
Author stevebl...@google.com
Date 2011-08-16 06:38:54 -0700 (Tue, 16 Aug 2011)


Log Message
fix

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93093 => 93094)

--- trunk/LayoutTests/ChangeLog	2011-08-16 13:11:23 UTC (rev 93093)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 13:38:54 UTC (rev 93094)
@@ -1,3 +1,13 @@
+2011-08-16  Steve Block  stevebl...@google.com
+
+Set failing expectation for fast/canvas/webgl/uninitialized-test.html on Linux dbg
+
+See http://code.google.com/p/chromium/issues/detail?id=93044
+
+Unreviewed gardening.
+
+* platform/chromium/test_expectations.txt:
+
 2011-08-16  Andras Becsi  abe...@webkit.org
 
 WebKitTestRunner needs a more-complete implementation of eventSender


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93093 => 93094)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 13:11:23 UTC (rev 93093)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 13:38:54 UTC (rev 93094)
@@ -3674,3 +3674,5 @@
 
 // New test in r93068
 BUGWK66268 : editing/deleting/regional-indicators.html = TEXT
+
+BUGCR93044 LINUX DEBUG : fast/canvas/webgl/uninitialized-test.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93096] trunk/Source/WebKit/chromium

[mnaganov]

Title: [93096] trunk/Source/WebKit/chromium








Revision 93096
Author mnaga...@chromium.org
Date 2011-08-16 07:15:35 -0700 (Tue, 16 Aug 2011)


Log Message
Web Inspector: [Chromium] Fix 'inspector_resources' target to depend on 'concatenated_heap_snapshot_worker_js'
https://bugs.webkit.org/show_bug.cgi?id=66300

Reviewed by Pavel Feldman.

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (93095 => 93096)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-08-16 13:41:51 UTC (rev 93095)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-08-16 14:15:35 UTC (rev 93096)
@@ -1,3 +1,12 @@
+2011-08-16  Mikhail Naganov  mnaga...@chromium.org
+
+Web Inspector: [Chromium] Fix 'inspector_resources' target to depend on 'concatenated_heap_snapshot_worker_js'
+https://bugs.webkit.org/show_bug.cgi?id=66300
+
+Reviewed by Pavel Feldman.
+
+* WebKit.gyp:
+
 2011-08-15  Dmitry Titov  dim...@chromium.org
 
 [Chromium] Add WebFrameClient::didAdoptURLLoader() notification


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (93095 => 93096)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2011-08-16 13:41:51 UTC (rev 93095)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2011-08-16 14:15:35 UTC (rev 93096)
@@ -742,6 +742,7 @@
 'conditions': [
 ['debug_devtools==0', {
 'dependencies': ['concatenated_devtools_js',
+ 'concatenated_heap_snapshot_worker_js',
  'concatenated_script_formatter_worker_js',
  'concatenated_devtools_css'],
 }],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93099] trunk/LayoutTests

[steveblock]

Title: [93099] trunk/LayoutTests








Revision 93099
Author stevebl...@google.com
Date 2011-08-16 07:42:28 -0700 (Tue, 16 Aug 2011)


Log Message
Add TIMEOUT expectation for editing/deleting/regional-indicators.html
https://bugs.webkit.org/show_bug.cgi?id=66268

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93098 => 93099)

--- trunk/LayoutTests/ChangeLog	2011-08-16 14:39:23 UTC (rev 93098)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 14:42:28 UTC (rev 93099)
@@ -1,3 +1,12 @@
+2011-08-16  Steve Block  stevebl...@google.com
+
+Add TIMEOUT expectation for editing/deleting/regional-indicators.html
+https://bugs.webkit.org/show_bug.cgi?id=66268
+
+Unreviewed gardening.
+
+* platform/chromium/test_expectations.txt:
+
 2011-08-16  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: nuke background events collection (dead feature)


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93098 => 93099)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 14:39:23 UTC (rev 93098)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 14:42:28 UTC (rev 93099)
@@ -3673,6 +3673,6 @@
 BUGWK63796 MAC WIN : css3/font-feature-settings-rendering.html = MISSING FAIL
 
 // New test in r93068
-BUGWK66268 : editing/deleting/regional-indicators.html = TEXT
+BUGWK66268 : editing/deleting/regional-indicators.html = TEXT TIMEOUT
 
 BUGCR93044 LINUX DEBUG : fast/canvas/webgl/uninitialized-test.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93100] trunk/LayoutTests

[steveblock]

Title: [93100] trunk/LayoutTests








Revision 93100
Author stevebl...@google.com
Date 2011-08-16 07:50:02 -0700 (Tue, 16 Aug 2011)


Log Message
Set TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html on Linux dbg

See http://code.google.com/p/chromium/issues/detail?id=93044

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93099 => 93100)

--- trunk/LayoutTests/ChangeLog	2011-08-16 14:42:28 UTC (rev 93099)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 14:50:02 UTC (rev 93100)
@@ -1,5 +1,15 @@
 2011-08-16  Steve Block  stevebl...@google.com
 
+Set TIMEOUT expectation for fast/canvas/webgl/uninitialized-test.html on Linux dbg
+
+See http://code.google.com/p/chromium/issues/detail?id=93044
+
+Unreviewed gardening.
+
+* platform/chromium/test_expectations.txt:
+
+2011-08-16  Steve Block  stevebl...@google.com
+
 Add TIMEOUT expectation for editing/deleting/regional-indicators.html
 https://bugs.webkit.org/show_bug.cgi?id=66268
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93099 => 93100)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 14:42:28 UTC (rev 93099)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 14:50:02 UTC (rev 93100)
@@ -3675,4 +3675,4 @@
 // New test in r93068
 BUGWK66268 : editing/deleting/regional-indicators.html = TEXT TIMEOUT
 
-BUGCR93044 LINUX DEBUG : fast/canvas/webgl/uninitialized-test.html = TEXT
+BUGCR93044 LINUX DEBUG : fast/canvas/webgl/uninitialized-test.html = TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93101] trunk/Source/WebCore

[pfeldman]

Title: [93101] trunk/Source/WebCore








Revision 93101
Author pfeld...@chromium.org
Date 2011-08-16 07:53:32 -0700 (Tue, 16 Aug 2011)


Log Message
Web Inspector: hide non-conservative methods from the protocol documentation.
https://bugs.webkit.org/show_bug.cgi?id=66301

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json




Diff

Modified: trunk/Source/WebCore/ChangeLog (93100 => 93101)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 14:50:02 UTC (rev 93100)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 14:53:32 UTC (rev 93101)
@@ -1,3 +1,12 @@
+2011-08-16  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: hide non-conservative methods from the protocol documentation.
+https://bugs.webkit.org/show_bug.cgi?id=66301
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/Inspector.json:
+
 2011-08-16  Andras Becsi  abe...@webkit.org
 
 Web Inspector: nuke background events collection (dead feature)


Modified: trunk/Source/WebCore/inspector/Inspector.json (93100 => 93101)

--- trunk/Source/WebCore/inspector/Inspector.json	2011-08-16 14:50:02 UTC (rev 93100)
+++ trunk/Source/WebCore/inspector/Inspector.json	2011-08-16 14:53:32 UTC (rev 93101)
@@ -77,7 +77,8 @@
 { name: name, type: string, optional: true, description: Frame's name as specified in the tag. },
 { name: url, type: string, description: Frame document's URL. },
 { name: mimeType, type: string, description: Frame document's mimeType as determined by the browser. }
-]
+],
+hidden: true
 },
 {
 id: FrameResourceTree,
@@ -97,7 +98,8 @@
 },
 description: Information about frame resources.
 }
-]
+],
+hidden: true
 },
 {
 id: SearchResult,
@@ -107,7 +109,8 @@
 	{ name: url, type: string, description: Resource URL. },
 { name: frameId, type: string, description: Resource frame id. },
 { name: matchesCount, type: number, description: Number of matches in the resource content. }
-]
+],
+hidden: true
 }
 ],
 commands: [
@@ -115,10 +118,12 @@
 name: addScriptToEvaluateOnLoad,
 parameters: [
 { name: scriptSource, type: string }
-]
+],
+hidden: true
 },
 {
-name: removeAllScriptsToEvaluateOnLoad
+name: removeAllScriptsToEvaluateOnLoad,
+hidden: true
 },
 {
 name: reload,
@@ -141,7 +146,8 @@
 { name: cookies, type: array, items: { $ref: Cookie}, description: Array of cookie objects. },
 { name: cookiesString, type: string, description: document.cookie string representation of the cookies. }
 ],
-description: Returns all browser cookies. Depending on the backend support, will either return detailed cookie information in the codecookie/code field or string cookie representation using codecookieString/code.
+description: Returns all browser cookies. Depending on the backend support, will either return detailed cookie information in the codecookie/code field or string cookie representation using codecookieString/code.,
+hidden: true
 },
 {
 name: deleteCookie,
@@ -149,14 +155,16 @@
 { name: cookieName, type: string, description: Name of the cookie to remove. },
 { name: domain, type: string, description: Domain of the cookie to remove. }
 ],
-description: Deletes browser cookie with given name for the given domain.
+description: Deletes browser cookie with given name for the given domain.,
+hidden: true
 },
 {
 name: getResourceTree,
 description: Returns present frame / resource tree structure.,
 returns: [
 { name: frameTree, $ref: FrameResourceTree, description: Present frame / resource tree structure. }
-]
+],
+hidden: true
 },
 {
 name: getResourceContent,
@@ -168,7 +176,8 @@
 returns: [
 { name: content, type: string, description: Resource content. },
 { name: base64Encoded, type: boolean, description: True, if content was served as base64. }
-]
+],
+hidden: true

[webkit-changes] [93103] trunk/LayoutTests

[aroben]

Title: [93103] trunk/LayoutTests








Revision 93103
Author aro...@apple.com
Date 2011-08-16 08:33:11 -0700 (Tue, 16 Aug 2011)


Log Message
Update Windows Sputnik results for ICU 4.6

Windows now fails these tests due to changes in ICU. Mac fails these tests, too, though in a
different way. Alexey tells me that these tests are silly because they check compliance with
a particular version of Unicode. Given this, it doesn't seem that a bug is required to track
this change in behavior.

* platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt:
* platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt:
* platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt:
* platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt
trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt
trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt
trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93102 => 93103)

--- trunk/LayoutTests/ChangeLog	2011-08-16 15:16:20 UTC (rev 93102)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 15:33:11 UTC (rev 93103)
@@ -1,5 +1,19 @@
 2011-08-16  Adam Roben  aro...@apple.com
 
+Update Windows Sputnik results for ICU 4.6
+
+Windows now fails these tests due to changes in ICU. Mac fails these tests, too, though in a
+different way. Alexey tells me that these tests are silly because they check compliance with
+a particular version of Unicode. Given this, it doesn't seem that a bug is required to track
+this change in behavior.
+
+* platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt:
+* platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt:
+* platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt:
+* platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt:
+
+2011-08-16  Adam Roben  aro...@apple.com
+
 Skip some tests that fail/time out on Windows with Safari 5.1's Apple Application Support (AAS)
 
 Since these failures are likely to be due to bugs in non-WebKit components, they are tracked


Modified: trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt (93102 => 93103)

--- trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt	2011-08-16 15:16:20 UTC (rev 93102)
+++ trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt	2011-08-16 15:33:11 UTC (rev 93103)
@@ -1,6 +1,6 @@
 S7.6_A3.1
 
-PASS 
+FAIL SputnikError: #0524-0527 
 
 TEST COMPLETE
 


Modified: trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt (93102 => 93103)

--- trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt	2011-08-16 15:16:20 UTC (rev 93102)
+++ trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt	2011-08-16 15:33:11 UTC (rev 93103)
@@ -1,6 +1,6 @@
 S7.6_A3.2
 
-PASS 
+FAIL SputnikError: #0524-0527 
 
 TEST COMPLETE
 


Modified: trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt (93102 => 93103)

--- trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt	2011-08-16 15:16:20 UTC (rev 93102)
+++ trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt	2011-08-16 15:33:11 UTC (rev 93103)
@@ -1,6 +1,6 @@
 S7.6_A5.3_T1
 
-PASS 
+FAIL SputnikError: #0524-0527 
 
 TEST COMPLETE
 


Modified: trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt (93102 => 93103)

--- trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt	2011-08-16 15:16:20 UTC (rev 93102)
+++ trunk/LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt	2011-08-16 15:33:11 UTC (rev 93103)
@@ -1,6 +1,6 @@
 S7.6_A5.3_T2
 
-PASS 
+FAIL SputnikError: #0524-0527 
 
 TEST COMPLETE
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93104] trunk/LayoutTests

[aroben]

Title: [93104] trunk/LayoutTests








Revision 93104
Author aro...@apple.com
Date 2011-08-16 08:51:37 -0700 (Tue, 16 Aug 2011)


Log Message
Share Sputnik Unicode results between Lion and Windows

Both Lion and Windows use ICU 4.6, so they have the same behavior on these tests.

* platform/mac-lion/Skipped: Removed these tests.

* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-lion/Skipped


Added Paths

trunk/LayoutTests/platform/mac/sputnik/
trunk/LayoutTests/platform/mac/sputnik/Unicode/
trunk/LayoutTests/platform/mac/sputnik/Unicode/Unicode_510/
trunk/LayoutTests/platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt
trunk/LayoutTests/platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt
trunk/LayoutTests/platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt
trunk/LayoutTests/platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/sputnik/
trunk/LayoutTests/platform/mac-snowleopard/sputnik/Unicode/
trunk/LayoutTests/platform/mac-snowleopard/sputnik/Unicode/Unicode_510/
trunk/LayoutTests/platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt


Removed Paths

trunk/LayoutTests/platform/win/sputnik/Unicode/




Diff

Modified: trunk/LayoutTests/ChangeLog (93103 => 93104)

--- trunk/LayoutTests/ChangeLog	2011-08-16 15:33:11 UTC (rev 93103)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 15:51:37 UTC (rev 93104)
@@ -1,5 +1,22 @@
 2011-08-16  Adam Roben  aro...@apple.com
 
+Share Sputnik Unicode results between Lion and Windows
+
+Both Lion and Windows use ICU 4.6, so they have the same behavior on these tests.
+
+* platform/mac-lion/Skipped: Removed these tests.
+
+* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
+* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
+* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
+* platform/mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
+* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt.
+* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
+* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
+* platform/mac/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Renamed from LayoutTests/platform/win/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
+
+2011-08-16  Adam Roben  aro...@apple.com
+
 Update Windows Sputnik results for ICU 4.6
 
 Windows now fails these tests due to changes in ICU. Mac fails these tests, too, though in a


Copied: trunk/LayoutTests/platform/mac/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt (from rev 93103, 

[webkit-changes] [93106] trunk/LayoutTests

[aroben]

Title: [93106] trunk/LayoutTests








Revision 93106
Author aro...@apple.com
Date 2011-08-16 09:00:25 -0700 (Tue, 16 Aug 2011)


Log Message
Stop skipping the web-apps tests I just landed results for on Lion

* platform/mac-lion/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-lion/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (93105 => 93106)

--- trunk/LayoutTests/ChangeLog	2011-08-16 15:57:24 UTC (rev 93105)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 16:00:25 UTC (rev 93106)
@@ -1,5 +1,11 @@
 2011-08-16  Adam Roben  aro...@apple.com
 
+Stop skipping the web-apps tests I just landed results for on Lion
+
+* platform/mac-lion/Skipped:
+
+2011-08-16  Adam Roben  aro...@apple.com
+
 Check in expected failure results for some web-apps tests on Lion and Windows
 
 Since these failures are likely due to bugs in non-WebKit components, they are tracked by


Modified: trunk/LayoutTests/platform/mac-lion/Skipped (93105 => 93106)

--- trunk/LayoutTests/platform/mac-lion/Skipped	2011-08-16 15:57:24 UTC (rev 93105)
+++ trunk/LayoutTests/platform/mac-lion/Skipped	2011-08-16 16:00:25 UTC (rev 93106)
@@ -148,8 +148,6 @@
 http/tests/multipart/invalid-image-data-standalone.html
 http/tests/navigation/anchor-basic.html
 http/tests/xmlhttprequest/basic-auth-nopassword.html
-http/tests/xmlhttprequest/web-apps/012.html
-http/tests/xmlhttprequest/web-apps/013.html
 platform/mac/fast/forms/listbox-scrollbar-hit-test.html
 platform/mac/fast/overflow/overflow-scrollbar-hit-test.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93108] trunk

[eric . carlson]

Title: [93108] trunk








Revision 93108
Author eric.carl...@apple.com
Date 2011-08-16 09:13:09 -0700 (Tue, 16 Aug 2011)


Log Message
2011-08-16  Eric Carlson  eric.carl...@apple.com

[REGRESSION] Media controls should always be enabled when scripting is disabled
https://bugs.webkit.org/show_bug.cgi?id=66303

Reviewed by Dimitri Glazkov.

Tests: media/video-controls-no-scripting-iframe.html
   media/video-controls-no-scripting.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged): Move the controls enabling/disabling code
to configureMediaControls.
(WebCore::HTMLMediaElement::prepareForLoad): Call configureMediaControls.
(WebCore::HTMLMediaElement::configureMediaControls): New, move code duplicated in 
attributeChanged and preDispatchEventHandler here.
(WebCore::HTMLMediaElement::preDispatchEventHandler): Move the controls enabling/disabling code
to configureMediaControls.
* html/HTMLMediaElement.h:

2011-08-16  Eric Carlson  eric.carl...@apple.com

[REGRESSION] Media controls should always be enabled when scripting is disabled
https://bugs.webkit.org/show_bug.cgi?id=66303

Reviewed by Dimitri Glazkov.

* media/video-controls-no-scripting-expected.txt: Added.
* media/video-controls-no-scripting-iframe.html: Added.
* media/video-controls-no-scripting.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h


Added Paths

trunk/LayoutTests/media/video-controls-no-scripting-expected.txt
trunk/LayoutTests/media/video-controls-no-scripting-iframe.html
trunk/LayoutTests/media/video-controls-no-scripting.html




Diff

Modified: trunk/LayoutTests/ChangeLog (93107 => 93108)

--- trunk/LayoutTests/ChangeLog	2011-08-16 16:03:02 UTC (rev 93107)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 16:13:09 UTC (rev 93108)
@@ -1,3 +1,14 @@
+2011-08-16  Eric Carlson  eric.carl...@apple.com
+
+[REGRESSION] Media controls should always be enabled when scripting is disabled
+https://bugs.webkit.org/show_bug.cgi?id=66303
+
+Reviewed by Dimitri Glazkov.
+
+* media/video-controls-no-scripting-expected.txt: Added.
+* media/video-controls-no-scripting-iframe.html: Added.
+* media/video-controls-no-scripting.html: Added.
+
 2011-08-16  Adam Roben  aro...@apple.com
 
 Stop skipping the web-apps tests I just landed results for on Lion


Added: trunk/LayoutTests/media/video-controls-no-scripting-expected.txt (0 => 93108)

--- trunk/LayoutTests/media/video-controls-no-scripting-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/video-controls-no-scripting-expected.txt	2011-08-16 16:13:09 UTC (rev 93108)
@@ -0,0 +1,9 @@
+
+Tests that the built-in controls are always enabled when _javascript_ is disabled.
+
+EXPECTED (internals.shadowRoot(video) != 'null') OK
+EXPECTED (controls.offsetTop + controls.offsetHeight = '240') OK
+EXPECTED (getComputedStyle(controls).opacity == '1') OK
+
+END OF TEST
+


Added: trunk/LayoutTests/media/video-controls-no-scripting-iframe.html (0 => 93108)

--- trunk/LayoutTests/media/video-controls-no-scripting-iframe.html	(rev 0)
+++ trunk/LayoutTests/media/video-controls-no-scripting-iframe.html	2011-08-16 16:13:09 UTC (rev 93108)
@@ -0,0 +1,25 @@
+!doctype html
+html
+head
+style #error { display: none; } /style
+script
+function showErrorMsg() 
+{
+document.getElementById('error').style.display = 'block';
+}
+/script
+/head
+
+body _onload_=showErrorMsg()
+
+video
+source src="" type=video/mp4
+source src="" type=video/ogg
+/video
+
+noscriptpScripting is DISABLED./p/noscript
+
+p id=errorERROR: _javascript_ must be disabled for this test./p
+
+/body
+/html


Added: trunk/LayoutTests/media/video-controls-no-scripting.html (0 => 93108)

--- trunk/LayoutTests/media/video-controls-no-scripting.html	(rev 0)
+++ trunk/LayoutTests/media/video-controls-no-scripting.html	2011-08-16 16:13:09 UTC (rev 93108)
@@ -0,0 +1,35 @@
+!doctype html
+html
+head
+script src="" type=text/_javascript_/script
+script
+function setup()
+{
+if (!window.layoutTestController) {
+consoleWrite(This test only works in DRT.);
+return;
+}
+
+video = document.getElementById(fr).contentDocument.querySelector(video);
+testExpected(internals.shadowRoot(video), null, !=);
+controls =  internals.shadowRoot(video).firstChild.firstChild;
+testExpected(controls.offsetTop + controls.offsetHeight, 

[webkit-changes] [93109] trunk/Source/WebCore

[macpherson]

Title: [93109] trunk/Source/WebCore








Revision 93109
Author macpher...@chromium.org
Date 2011-08-16 09:18:20 -0700 (Tue, 16 Aug 2011)


Log Message
Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=66279

Reviewed by Simon Fraser.

No new tests - no functionality changed - simple refactoring only.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.
This works because PrimitiveValue now supports cast to int.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (93108 => 93109)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 16:13:09 UTC (rev 93108)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 16:18:20 UTC (rev 93109)
@@ -1,3 +1,17 @@
+2011-08-16  Luke Macpherson   macpher...@chromium.org
+
+Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty()
+https://bugs.webkit.org/show_bug.cgi?id=66279
+
+Reviewed by Simon Fraser.
+
+No new tests - no functionality changed - simple refactoring only.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.
+This works because PrimitiveValue now supports cast to int.
+
 2011-08-16  Eric Carlson  eric.carl...@apple.com
 
 [REGRESSION] Media controls should always be enabled when scripting is disabled


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (93108 => 93109)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-16 16:13:09 UTC (rev 93108)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-16 16:18:20 UTC (rev 93109)
@@ -4700,13 +4700,11 @@
 m_style-setFlowThread(primitiveValue-getStringValue());
 return;
 case CSSPropertyWebkitContentOrder:
-HANDLE_INHERIT_AND_INITIAL(regionIndex, RegionIndex);
-m_style-setRegionIndex(primitiveValue-getIntValue());
+HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(regionIndex, RegionIndex);
 return;
 case CSSPropertyWebkitRegionOverflow:
 HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(regionOverflow, RegionOverflow);
 return;
-
 case CSSPropertyWebkitMarqueeDirection:
 HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(marqueeDirection, MarqueeDirection)
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93111] trunk/Tools

[aroben]

Title: [93111] trunk/Tools








Revision 93111
Author aro...@apple.com
Date 2011-08-16 09:27:54 -0700 (Tue, 16 Aug 2011)


Log Message
Teach TestFailures how to interpret unfinished test runs

Fixes http://webkit.org/b/66309 TestFailures thinks all tests passed in
http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Look for isFinished in the layout-test step
rather than isStarted so that we don't count builds for which the test run never finished.
Bumped the cache version to evict old, buggy cached data.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
Added a test for the above, and made a somewhat synthetic test more realistic by including
more of the actual JSON data from build.webkit.org.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
cached data.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js (93110 => 93111)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js	2011-08-16 16:19:18 UTC (rev 93110)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js	2011-08-16 16:27:54 UTC (rev 93111)
@@ -100,7 +100,7 @@
 
 getNumberOfFailingTests: function(buildNumber, callback) {
 var cacheKey = this.name + '_getNumberOfFailingTests_' + buildNumber;
-const currentCachedDataVersion = 1;
+const currentCachedDataVersion = 2;
 if (PersistentCache.contains(cacheKey)) {
 var cachedData = PersistentCache.get(cacheKey);
 if (cachedData.version === currentCachedDataVersion) {
@@ -120,8 +120,8 @@
 return;
 }
 
-if (!('isStarted' in layoutTestStep)) {
-// run-webkit-tests never even ran.
+if (!('isFinished' in layoutTestStep)) {
+// run-webkit-tests never even ran, or didn't finish running.
 PersistentCache.set(cacheKey, result);
 callback(result.failureCount, result.tooManyFailures);
 return;


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js (93110 => 93111)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js	2011-08-16 16:19:18 UTC (rev 93110)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js	2011-08-16 16:27:54 UTC (rev 93111)
@@ -63,8 +63,9 @@
 const jsonData = {
 steps: [
 {
+isFinished: true,
+isStarted: true,
 name: 'layout-test',
-isStarted: true,
 results: [
 2,
 [
@@ -179,4 +180,28 @@
 });
 });
 
+test(getNumberOfFailingTests treats unfinished test runs as errors, 4, function() {
+const jsonData = {
+steps: [
+{
+isStarted: true, 
+name: layout-test, 
+step_number: 5, 
+text: [
+layout-tests running
+], 
+times: [
+1312989295.518481, 
+null
+]
+}, 
+],
+};
+
+runGetNumberOfFailingTestsTest(jsonData, function(failureCount, tooManyFailures) {
+equal(failureCount, -1);
+equal(tooManyFailures, false);
+});
+});
+
 })();


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js (93110 => 93111)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js	2011-08-16 16:19:18 UTC (rev 93110)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js	2011-08-16 16:27:54 UTC (rev 93111)
@@ -30,7 +30,7 @@
 LayoutTestResultsLoader.prototype = {
 start: function(buildName, callback, errorCallback) {
 var cacheKey = 'LayoutTestResultsLoader.' + this._builder.name + '.' + buildName;
-const currentCachedDataVersion = 6;
+const currentCachedDataVersion = 7;
 if (PersistentCache.contains(cacheKey)) {
 var cachedData = PersistentCache.get(cacheKey);
 if 

[webkit-changes] [93112] trunk/LayoutTests

[aroben]

Title: [93112] trunk/LayoutTests








Revision 93112
Author aro...@apple.com
Date 2011-08-16 09:28:24 -0700 (Tue, 16 Aug 2011)


Log Message
Add Lion/Windows expected results for an Inspector test

The only difference from the cross-platform results is that the .js resources are now given
a MIME type of text/plain.

This test reloads the page before dumping it in HAR format. In Lion (and Safari 5.1 on
Windows), CFNetwork no longer uses the file extension as a fallback when determining the
MIME type for 304 cached responses. This matches Chrome. See rdar://problem/9313303.

* platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt: Copied from http/tests/inspector/resource-har-conversion-expected.txt.
* platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/mac/http/tests/inspector/resource-har-conversion-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/http/tests/inspector/
trunk/LayoutTests/platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93111 => 93112)

--- trunk/LayoutTests/ChangeLog	2011-08-16 16:27:54 UTC (rev 93111)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 16:28:24 UTC (rev 93112)
@@ -1,3 +1,17 @@
+2011-08-16  Adam Roben  aro...@apple.com
+
+Add Lion/Windows expected results for an Inspector test
+
+The only difference from the cross-platform results is that the .js resources are now given
+a MIME type of text/plain.
+
+This test reloads the page before dumping it in HAR format. In Lion (and Safari 5.1 on
+Windows), CFNetwork no longer uses the file extension as a fallback when determining the
+MIME type for 304 cached responses. This matches Chrome. See rdar://problem/9313303.
+
+* platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt: Copied from http/tests/inspector/resource-har-conversion-expected.txt.
+* platform/mac/http/tests/inspector/resource-har-conversion-expected.txt: Added.
+
 2011-08-16  Eric Carlson  eric.carl...@apple.com
 
 [REGRESSION] Media controls should always be enabled when scripting is disabled


Added: trunk/LayoutTests/platform/mac/http/tests/inspector/resource-har-conversion-expected.txt (0 => 93112)

--- trunk/LayoutTests/platform/mac/http/tests/inspector/resource-har-conversion-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/http/tests/inspector/resource-har-conversion-expected.txt	2011-08-16 16:28:24 UTC (rev 93112)
@@ -0,0 +1,214 @@
+Tests conversion of Inspector's resource representation into HAR format.
+
+Page reloaded.
+{
+version : string
+creator : {
+name : WebInspector
+version : string
+}
+pages : [
+{
+startedDateTime : object
+id : string
+title : 
+pageTimings : {
+onContentLoad : number
+onLoad : number
+}
+}
+]
+entries : [
+{
+pageref : http://127.0.0.1:8000/inspector/resource-har-conversion.html
+startedDateTime : object
+time : number
+request : {
+method : GET
+url : http://127.0.0.1:8000/inspector/inspector-test.js
+headers : object
+queryString : [
+]
+cookies : [
+{
+name : a
+value : b
+path : /path
+domain : example.com
+expires : null
+httpOnly : false
+secure : false
+}
+{
+name : a1
+value : b1
+path : undefined
+domain : undefined
+expires : null
+httpOnly : false
+secure : false
+}
+{
+name : c1
+value : d1
+path : undefined
+domain : undefined
+expires : null
+httpOnly : false
+secure : false
+}
+]
+headersSize : -1
+bodySize : number
+}
+response : {
+status : 304
+statusText : Not Modified
+headers : object
+cookies : [
+{
+name : x
+value : y
+path : /path
+domain : example.com
+expires : null
+  

[webkit-changes] [93113] trunk/LayoutTests

[tony]

Title: [93113] trunk/LayoutTests








Revision 93113
Author t...@chromium.org
Date 2011-08-16 09:31:49 -0700 (Tue, 16 Aug 2011)


Log Message
Copy the results of http/tests/xmlhttprequest/web-apps/01[23].html
to the chromium platform dir.  The mac failing results (r93105) were
getting picked up by the chromium port.

* platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
* platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/
trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt
trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93112 => 93113)

--- trunk/LayoutTests/ChangeLog	2011-08-16 16:28:24 UTC (rev 93112)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 16:31:49 UTC (rev 93113)
@@ -1,3 +1,12 @@
+2011-08-16  Tony Chang  t...@chromium.org
+
+Copy the results of http/tests/xmlhttprequest/web-apps/01[23].html
+to the chromium platform dir.  The mac failing results (r93105) were
+getting picked up by the chromium port.
+
+* platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt: Added.
+* platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt: Added.
+
 2011-08-16  Adam Roben  aro...@apple.com
 
 Add Lion/Windows expected results for an Inspector test


Added: trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt (0 => 93113)

--- trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt	2011-08-16 16:31:49 UTC (rev 93113)
@@ -0,0 +1 @@
+PASS
Property changes on: trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/012-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt (0 => 93113)

--- trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt	2011-08-16 16:31:49 UTC (rev 93113)
@@ -0,0 +1 @@
+PASS
Property changes on: trunk/LayoutTests/platform/chromium/http/tests/xmlhttprequest/web-apps/013-expected.txt
___


Added: svn:eol-style




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93114] trunk/Source/WebCore

[commit-queue]

Title: [93114] trunk/Source/WebCore








Revision 93114
Author commit-qu...@webkit.org
Date 2011-08-16 09:34:05 -0700 (Tue, 16 Aug 2011)


Log Message
Chromium Mac: Rubber banding gutter drawing
https://bugs.webkit.org/show_bug.cgi?id=66226

Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.

Patch by Alexei Svitkine asvitk...@chromium.org on 2011-08-16
Reviewed by Dimitri Glazkov.

No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::paintOverhangAreas):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paintOverhangAreas):
* platform/ScrollbarThemeComposite.h:
* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollbarTheme.h
trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp
trunk/Source/WebCore/platform/ScrollbarThemeComposite.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93113 => 93114)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 16:31:49 UTC (rev 93113)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 16:34:05 UTC (rev 93114)
@@ -1,3 +1,31 @@
+2011-08-16  Alexei Svitkine  asvitk...@chromium.org
+
+Chromium Mac: Rubber banding gutter drawing
+https://bugs.webkit.org/show_bug.cgi?id=66226
+
+Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
+draw the overhang areas.
+Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
+Add a different implementation for Chromium Mac.
+
+Reviewed by Dimitri Glazkov.
+
+No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
+
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::wheelEvent):
+* platform/ScrollbarTheme.h:
+(WebCore::ScrollbarTheme::paintOverhangAreas):
+* platform/ScrollbarThemeComposite.cpp:
+(WebCore::ScrollbarThemeComposite::paintOverhangAreas):
+* platform/ScrollbarThemeComposite.h:
+* platform/chromium/ScrollbarThemeChromiumMac.h:
+* platform/chromium/ScrollbarThemeChromiumMac.mm:
+(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
+(WebCore::scrollbarStateToThemeState):
+(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
+(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
+
 2011-08-16  Luke Macpherson   macpher...@chromium.org
 
 Support cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector.


Modified: trunk/Source/WebCore/platform/ScrollView.cpp (93113 => 93114)

--- trunk/Source/WebCore/platform/ScrollView.cpp	2011-08-16 16:31:49 UTC (rev 93113)
+++ trunk/Source/WebCore/platform/ScrollView.cpp	2011-08-16 16:34:05 UTC (rev 93114)
@@ -1086,17 +1086,9 @@
 }
 }
 
-void ScrollView::paintOverhangAreas(GraphicsContext* context, const IntRect horizontalOverhangRect, const IntRect verticalOverhangRect, const IntRect)
+void ScrollView::paintOverhangAreas(GraphicsContext* context, const IntRect horizontalOverhangRect, const IntRect verticalOverhangRect, const IntRect dirtyRect)
 {
-// FIXME: This should be checking the dirty rect.
-
-context-setFillColor(Color::white, ColorSpaceDeviceRGB);
-if (!horizontalOverhangRect.isEmpty())
-context-fillRect(horizontalOverhangRect);
-
-context-setFillColor(Color::white, ColorSpaceDeviceRGB);
-if (!verticalOverhangRect.isEmpty())
-context-fillRect(verticalOverhangRect);
+ScrollbarTheme::nativeTheme()-paintOverhangAreas(this, context, horizontalOverhangRect, verticalOverhangRect, dirtyRect);
 }
 
 bool ScrollView::isPointInScrollbarCorner(const IntPoint windowPoint)


Modified: trunk/Source/WebCore/platform/ScrollbarTheme.h (93113 => 93114)

--- trunk/Source/WebCore/platform/ScrollbarTheme.h	2011-08-16 16:31:49 UTC (rev 93113)
+++ trunk/Source/WebCore/platform/ScrollbarTheme.h	2011-08-16 16:34:05 UTC (rev 93114)
@@ -82,6 +82,8 @@
 virtual void paintScrollCorner(ScrollView*, GraphicsContext* context, const IntRect cornerRect) { defaultPaintScrollCorner(context, cornerRect); }
 static void 

[webkit-changes] [93115] trunk/LayoutTests

[aroben]

Title: [93115] trunk/LayoutTests








Revision 93115
Author aro...@apple.com
Date 2011-08-16 09:39:08 -0700 (Tue, 16 Aug 2011)


Log Message
Remove Windows-specific hyphenation test results now that hyphenation works on Windows

* platform/win/fast/text/hyphenate-first-word-expected.txt: Removed.
* platform/win/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
* platform/win/fast/text/hyphenate-locale-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/win/fast/text/hyphenate-first-word-expected.txt
trunk/LayoutTests/platform/win/fast/text/hyphenate-limit-before-after-expected.txt
trunk/LayoutTests/platform/win/fast/text/hyphenate-locale-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93114 => 93115)

--- trunk/LayoutTests/ChangeLog	2011-08-16 16:34:05 UTC (rev 93114)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 16:39:08 UTC (rev 93115)
@@ -1,3 +1,11 @@
+2011-08-16  Adam Roben  aro...@apple.com
+
+Remove Windows-specific hyphenation test results now that hyphenation works on Windows
+
+* platform/win/fast/text/hyphenate-first-word-expected.txt: Removed.
+* platform/win/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
+* platform/win/fast/text/hyphenate-locale-expected.txt: Removed.
+
 2011-08-16  Tony Chang  t...@chromium.org
 
 Copy the results of http/tests/xmlhttprequest/web-apps/01[23].html


Deleted: trunk/LayoutTests/platform/win/fast/text/hyphenate-first-word-expected.txt (93114 => 93115)

--- trunk/LayoutTests/platform/win/fast/text/hyphenate-first-word-expected.txt	2011-08-16 16:34:05 UTC (rev 93114)
+++ trunk/LayoutTests/platform/win/fast/text/hyphenate-first-word-expected.txt	2011-08-16 16:39:08 UTC (rev 93115)
@@ -1,8 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
-  RenderBlock {DIV} at (0,0) size 226x116 [border: (3px solid #00)]
-RenderText {#text} at (3,3) size 429x110
-  text run at (3,3) width 429: declination


Deleted: trunk/LayoutTests/platform/win/fast/text/hyphenate-limit-before-after-expected.txt (93114 => 93115)

--- trunk/LayoutTests/platform/win/fast/text/hyphenate-limit-before-after-expected.txt	2011-08-16 16:34:05 UTC (rev 93114)
+++ trunk/LayoutTests/platform/win/fast/text/hyphenate-limit-before-after-expected.txt	2011-08-16 16:39:08 UTC (rev 93115)
@@ -1,74 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
-  RenderBlock {DIV} at (8,8) size 126x60 [border: (3px solid #00)]
-RenderText {#text} at (3,3) size 70x54
-  text run at (3,3) width 51: There is
-  text run at (3,21) width 70: remarkable
-  text run at (3,39) width 60: evidence.
-  RenderText {#text} at (142,47) size 4x18
-text run at (142,47) width 4:  
-  RenderBlock {DIV} at (154,8) size 126x60 [border: (3px solid #00)]
-RenderText {#text} at (3,3) size 70x54
-  text run at (3,3) width 51: There is
-  text run at (3,21) width 70: remarkable
-  text run at (3,39) width 60: evidence.
-  RenderText {#text} at (288,47) size 4x18
-text run at (288,47) width 4:  
-  RenderBlock {DIV} at (300,8) size 126x60 [border: (3px solid #00)]
-RenderText {#text} at (3,3) size 70x54
-  text run at (3,3) width 51: There is
-  text run at (3,21) width 70: remarkable
-  text run at (3,39) width 60: evidence.
-  RenderText {#text} at (434,47) size 4x18
-text run at (434,47) width 4:  
-  RenderBlock {DIV} at (446,8) size 126x60 [border: (3px solid #00)]
-RenderText {#text} at (3,3) size 70x54
-  text run at (3,3) width 51: There is
-  text run at (3,21) width 70: remarkable
-  text run at (3,39) width 60: evidence.
-  RenderText {#text} at (580,47) size 4x18
-text run at (580,47) width 4:  
-  RenderBlock {DIV} at (592,8) size 126x60 [border: (3px solid #00)]
-RenderText {#text} at (3,3) size 70x54
-  text run at (3,3) width 51: There is
-  text run at (3,21) width 70: remarkable
-  text run at (3,39) width 60: evidence.
-  RenderText {#text} at (726,47) size 4x18
-text run at (726,47) width 4:  
-  RenderBlock {DIV} at (8,84) size 126x60 [border: (3px solid #00)]
-RenderText {#text} at (3,3) size 70x54
-  text run at (3,3) width 51: There is
-  text run at (3,21) width 70: remarkable
-  text run at (3,39) width 60: evidence.
-  RenderText {#text} at (142,123) size 4x18
-text run at (142,123) width 4:  
-  RenderBlock {DIV} at (154,84) size 126x60 [border: (3px solid #00)]
-

[webkit-changes] [93116] trunk/LayoutTests

[aroben]

Title: [93116] trunk/LayoutTests








Revision 93116
Author aro...@apple.com
Date 2011-08-16 09:44:14 -0700 (Tue, 16 Aug 2011)


Log Message
Update Windows results after r92890

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/fast/dom/Window/window-property-descriptors-expected.txt
trunk/LayoutTests/platform/win/fast/js/global-constructors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93115 => 93116)

--- trunk/LayoutTests/ChangeLog	2011-08-16 16:39:08 UTC (rev 93115)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 16:44:14 UTC (rev 93116)
@@ -1,5 +1,12 @@
 2011-08-16  Adam Roben  aro...@apple.com
 
+Update Windows results after r92890
+
+* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
+* platform/win/fast/js/global-constructors-expected.txt:
+
+2011-08-16  Adam Roben  aro...@apple.com
+
 Remove Windows-specific hyphenation test results now that hyphenation works on Windows
 
 * platform/win/fast/text/hyphenate-first-word-expected.txt: Removed.


Modified: trunk/LayoutTests/platform/win/fast/dom/Window/window-property-descriptors-expected.txt (93115 => 93116)

--- trunk/LayoutTests/platform/win/fast/dom/Window/window-property-descriptors-expected.txt	2011-08-16 16:39:08 UTC (rev 93115)
+++ trunk/LayoutTests/platform/win/fast/dom/Window/window-property-descriptors-expected.txt	2011-08-16 16:44:14 UTC (rev 93116)
@@ -121,6 +121,7 @@
 PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLTextAreaElement') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLTitleElement') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLUListElement') is 'object'
+PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLUnknownElement') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'HTMLVideoElement') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'HashChangeEvent') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'Image') is 'object'


Modified: trunk/LayoutTests/platform/win/fast/js/global-constructors-expected.txt (93115 => 93116)

--- trunk/LayoutTests/platform/win/fast/js/global-constructors-expected.txt	2011-08-16 16:39:08 UTC (rev 93115)
+++ trunk/LayoutTests/platform/win/fast/js/global-constructors-expected.txt	2011-08-16 16:44:14 UTC (rev 93116)
@@ -115,6 +115,7 @@
 PASS HTMLTextAreaElement.toString() is '[object HTMLTextAreaElementConstructor]'
 PASS HTMLTitleElement.toString() is '[object HTMLTitleElementConstructor]'
 PASS HTMLUListElement.toString() is '[object HTMLUListElementConstructor]'
+PASS HTMLUnknownElement.toString() is '[object HTMLUnknownElementConstructor]'
 PASS HTMLVideoElement.toString() is '[object HTMLVideoElementConstructor]'
 PASS HashChangeEvent.toString() is '[object HashChangeEventConstructor]'
 PASS Image.toString() is '[object ImageConstructor]'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93117] trunk/LayoutTests

[tony]

Title: [93117] trunk/LayoutTests








Revision 93117
Author t...@chromium.org
Date 2011-08-16 09:46:10 -0700 (Tue, 16 Aug 2011)


Log Message
[chromium] Mark media/video-source-error.html as flaky in Debug.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93116 => 93117)

--- trunk/LayoutTests/ChangeLog	2011-08-16 16:44:14 UTC (rev 93116)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 16:46:10 UTC (rev 93117)
@@ -1,3 +1,9 @@
+2011-08-16  Tony Chang  t...@chromium.org
+
+[chromium] Mark media/video-source-error.html as flaky in Debug.
+
+* platform/chromium/test_expectations.txt:
+
 2011-08-16  Adam Roben  aro...@apple.com
 
 Update Windows results after r92890


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93116 => 93117)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 16:44:14 UTC (rev 93116)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 16:46:10 UTC (rev 93117)
@@ -3676,3 +3676,5 @@
 BUGWK66268 : editing/deleting/regional-indicators.html = TEXT TIMEOUT
 
 BUGCR93044 LINUX DEBUG : fast/canvas/webgl/uninitialized-test.html = TIMEOUT
+
+BUGWK66310 DEBUG : media/video-source-error.html = TEXT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93118] branches/safari-534.51-branch/LayoutTests/ChangeLog

[lforschler]

Title: [93118] branches/safari-534.51-branch/LayoutTests/ChangeLog








Revision 93118
Author lforsch...@apple.com
Date 2011-08-16 09:55:28 -0700 (Tue, 16 Aug 2011)


Log Message
Merge r36608.

Modified Paths

branches/safari-534.51-branch/LayoutTests/ChangeLog




Diff

Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (93117 => 93118)

--- branches/safari-534.51-branch/LayoutTests/ChangeLog	2011-08-16 16:46:10 UTC (rev 93117)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog	2011-08-16 16:55:28 UTC (rev 93118)
@@ -1,5 +1,18 @@
 2011-08-11  Lucas Forschler  lforsch...@apple.com
 
+Merged 36608
+
+2008-09-18  Mark Rowe  mr...@apple.com
+
+Rubber-stamped by Sam Weinig.
+
+Change test to not attempt to access a remote host.  This stops
+DRT from printing a warning to stderr while running this test.
+
+* fast/loader/cancel-load-during-port-block-timer.html:
+
+2011-08-11  Lucas Forschler  lforsch...@apple.com
+
 Merged 92692
 
 2011-08-09  Abhishek Arya  infe...@chromium.org






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93119] trunk/LayoutTests

[aroben]

Title: [93119] trunk/LayoutTests








Revision 93119
Author aro...@apple.com
Date 2011-08-16 09:56:02 -0700 (Tue, 16 Aug 2011)


Log Message
Update Windows results for a fast/text test for Safari 5.1's AAS

The results are now more like Mac's. Dan Bernstein says this is probably a progression.

* platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93118 => 93119)

--- trunk/LayoutTests/ChangeLog	2011-08-16 16:55:28 UTC (rev 93118)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 16:56:02 UTC (rev 93119)
@@ -1,3 +1,11 @@
+2011-08-16  Adam Roben  aro...@apple.com
+
+Update Windows results for a fast/text test for Safari 5.1's AAS
+
+The results are now more like Mac's. Dan Bernstein says this is probably a progression.
+
+* platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt:
+
 2011-08-16  Tony Chang  t...@chromium.org
 
 [chromium] Mark media/video-source-error.html as flaky in Debug.


Modified: trunk/LayoutTests/platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt (93118 => 93119)

--- trunk/LayoutTests/platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt	2011-08-16 16:55:28 UTC (rev 93118)
+++ trunk/LayoutTests/platform/win/fast/text/justify-ideograph-leading-expansion-expected.txt	2011-08-16 16:56:02 UTC (rev 93119)
@@ -3,7 +3,7 @@
 layer at (0,0) size 800x600
   RenderBlock {HTML} at (0,0) size 800x600
 RenderBody {BODY} at (8,8) size 784x584
-  RenderBlock {DIV} at (0,0) size 784x142
+  RenderBlock {DIV} at (0,0) size 784x124
 RenderBlock {DIV} at (0,0) size 106x42 [border: (3px solid #00)]
   RenderText {#text} at (3,3) size 80x18
 text run at (3,3) width 80: a. b. 
@@ -17,11 +17,10 @@
   RenderText {#text} at (3,3) size 100x36
 text run at (3,3) width 100: a. b. i\x{306F}
 text run at (3,21) width 56: xxx
-RenderBlock {DIV} at (0,100) size 106x42 [border: (3px solid #00)]
-  RenderText {#text} at (3,3) size 168x36
-text run at (3,3) width 168: x
-text run at (3,21) width 32: \x{FF08}\x{624B}\x{FF09}
-  RenderBlock {DIV} at (0,150) size 784x142
+RenderBlock {DIV} at (0,100) size 106x24 [border: (3px solid #00)]
+  RenderText {#text} at (3,3) size 200x18
+text run at (3,3) width 200: x\x{FF08}\x{624B}\x{FF09}
+  RenderBlock {DIV} at (0,132) size 784x124
 RenderBlock {DIV} at (0,0) size 106x42 [border: (3px solid #00)]
   RenderText {#text} at (3,3) size 80x18
 text run at (3,3) width 80: a. b. 
@@ -35,7 +34,6 @@
   RenderText {#text} at (3,3) size 100x36
 text run at (3,3) width 100: a. b. i\x{306F}
 text run at (3,21) width 56: xxx
-RenderBlock {DIV} at (0,100) size 106x42 [border: (3px solid #00)]
-  RenderText {#text} at (3,3) size 168x36
-text run at (3,3) width 168: x
-text run at (3,21) width 32: \x{FF08}\x{624B}\x{FF09}
+RenderBlock {DIV} at (0,100) size 106x24 [border: (3px solid #00)]
+  RenderText {#text} at (3,3) size 200x18
+text run at (3,3) width 200: x\x{FF08}\x{624B}\x{FF09}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93120] trunk/Source/WebCore

[tony]

Title: [93120] trunk/Source/WebCore








Revision 93120
Author t...@chromium.org
Date 2011-08-16 09:57:42 -0700 (Tue, 16 Aug 2011)


Log Message
Unreviewed, rolling out r93114.
http://trac.webkit.org/changeset/93114
https://bugs.webkit.org/show_bug.cgi?id=66226

broke the chromium mac compile

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollbarTheme.h:
* platform/ScrollbarThemeComposite.cpp:
* platform/ScrollbarThemeComposite.h:
* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
* platform/mac/ScrollbarThemeMac.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollbarTheme.h
trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp
trunk/Source/WebCore/platform/ScrollbarThemeComposite.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93119 => 93120)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 16:56:02 UTC (rev 93119)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 16:57:42 UTC (rev 93120)
@@ -1,3 +1,23 @@
+2011-08-16  Tony Chang  t...@chromium.org
+
+Unreviewed, rolling out r93114.
+http://trac.webkit.org/changeset/93114
+https://bugs.webkit.org/show_bug.cgi?id=66226
+
+broke the chromium mac compile
+
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::wheelEvent):
+* platform/ScrollbarTheme.h:
+* platform/ScrollbarThemeComposite.cpp:
+* platform/ScrollbarThemeComposite.h:
+* platform/chromium/ScrollbarThemeChromiumMac.h:
+* platform/chromium/ScrollbarThemeChromiumMac.mm:
+(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
+(WebCore::scrollbarStateToThemeState):
+(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
+* platform/mac/ScrollbarThemeMac.h:
+
 2011-08-16  Alexei Svitkine  asvitk...@chromium.org
 
 Chromium Mac: Rubber banding gutter drawing


Modified: trunk/Source/WebCore/platform/ScrollView.cpp (93119 => 93120)

--- trunk/Source/WebCore/platform/ScrollView.cpp	2011-08-16 16:56:02 UTC (rev 93119)
+++ trunk/Source/WebCore/platform/ScrollView.cpp	2011-08-16 16:57:42 UTC (rev 93120)
@@ -1086,9 +1086,17 @@
 }
 }
 
-void ScrollView::paintOverhangAreas(GraphicsContext* context, const IntRect horizontalOverhangRect, const IntRect verticalOverhangRect, const IntRect dirtyRect)
+void ScrollView::paintOverhangAreas(GraphicsContext* context, const IntRect horizontalOverhangRect, const IntRect verticalOverhangRect, const IntRect)
 {
-ScrollbarTheme::nativeTheme()-paintOverhangAreas(this, context, horizontalOverhangRect, verticalOverhangRect, dirtyRect);
+// FIXME: This should be checking the dirty rect.
+
+context-setFillColor(Color::white, ColorSpaceDeviceRGB);
+if (!horizontalOverhangRect.isEmpty())
+context-fillRect(horizontalOverhangRect);
+
+context-setFillColor(Color::white, ColorSpaceDeviceRGB);
+if (!verticalOverhangRect.isEmpty())
+context-fillRect(verticalOverhangRect);
 }
 
 bool ScrollView::isPointInScrollbarCorner(const IntPoint windowPoint)


Modified: trunk/Source/WebCore/platform/ScrollbarTheme.h (93119 => 93120)

--- trunk/Source/WebCore/platform/ScrollbarTheme.h	2011-08-16 16:56:02 UTC (rev 93119)
+++ trunk/Source/WebCore/platform/ScrollbarTheme.h	2011-08-16 16:57:42 UTC (rev 93120)
@@ -82,8 +82,6 @@
 virtual void paintScrollCorner(ScrollView*, GraphicsContext* context, const IntRect cornerRect) { defaultPaintScrollCorner(context, cornerRect); }
 static void defaultPaintScrollCorner(GraphicsContext* context, const IntRect cornerRect) { context-fillRect(cornerRect, Color::white, ColorSpaceDeviceRGB); }
 
-virtual void paintOverhangAreas(ScrollView*, GraphicsContext*, const IntRect, const IntRect, const IntRect) { }
-
 virtual bool shouldCenterOnThumb(Scrollbar*, const PlatformMouseEvent) { return false; }
 virtual bool shouldSnapBackToDragOrigin(Scrollbar*, const PlatformMouseEvent) { return false; }
 virtual bool shouldDragDocumentInsteadOfThumb(Scrollbar*, const PlatformMouseEvent) { return false; }


Modified: trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp (93119 => 93120)

--- trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp	2011-08-16 16:56:02 UTC (rev 93119)
+++ trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp	2011-08-16 16:57:42 UTC (rev 93120)
@@ -315,15 +315,4 @@
 context-fillRect(cornerRect, Color::white, ColorSpaceDeviceRGB);
 }
 
-void ScrollbarThemeComposite::paintOverhangAreas(ScrollView*, GraphicsContext* context, const IntRect 

[webkit-changes] [93121] branches/safari-534.51-branch/LayoutTests/ChangeLog

[lforschler]

Title: [93121] branches/safari-534.51-branch/LayoutTests/ChangeLog








Revision 93121
Author lforsch...@apple.com
Date 2011-08-16 09:59:04 -0700 (Tue, 16 Aug 2011)


Log Message
rollout incorrect submit of 93118.

Modified Paths

branches/safari-534.51-branch/LayoutTests/ChangeLog




Diff

Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (93120 => 93121)

--- branches/safari-534.51-branch/LayoutTests/ChangeLog	2011-08-16 16:57:42 UTC (rev 93120)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog	2011-08-16 16:59:04 UTC (rev 93121)
@@ -1,18 +1,5 @@
 2011-08-11  Lucas Forschler  lforsch...@apple.com
 
-Merged 36608
-
-2008-09-18  Mark Rowe  mr...@apple.com
-
-Rubber-stamped by Sam Weinig.
-
-Change test to not attempt to access a remote host.  This stops
-DRT from printing a warning to stderr while running this test.
-
-* fast/loader/cancel-load-during-port-block-timer.html:
-
-2011-08-11  Lucas Forschler  lforsch...@apple.com
-
 Merged 92692
 
 2011-08-09  Abhishek Arya  infe...@chromium.org






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93122] trunk/Source/WebCore

[pfeldman]

Title: [93122] trunk/Source/WebCore








Revision 93122
Author pfeld...@chromium.org
Date 2011-08-16 10:15:06 -0700 (Tue, 16 Aug 2011)


Log Message
Web Inspector: force pseudo element state when checking it in the styles sidebar.
https://bugs.webkit.org/show_bug.cgi?id=66292

This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
they are guarded with the inline checks for the front-end count.

Reviewed by David Hyatt.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::styleRulesForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* css/CSSStyleSelector.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::computePseudoClassMask):
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::getStylesForNode):
(WebCore::InspectorCSSAgent::didRemoveDocument):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::clearPseudoState):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::disconnectFrontend):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::forcePseudoStateImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::forcePseudoState):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h
trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp
trunk/Source/WebCore/inspector/InspectorCSSAgent.h
trunk/Source/WebCore/inspector/InspectorController.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93121 => 93122)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 16:59:04 UTC (rev 93121)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 17:15:06 UTC (rev 93122)
@@ -1,3 +1,39 @@
+2011-08-16  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: force pseudo element state when checking it in the styles sidebar.
+https://bugs.webkit.org/show_bug.cgi?id=66292
+
+This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation
+calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:
+they are guarded with the inline checks for the front-end count.
+
+Reviewed by David Hyatt.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::initForStyleResolve):
+(WebCore::CSSStyleSelector::styleRulesForElement):
+(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
+(WebCore::CSSStyleSelector::checkSelector):
+(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
+(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+* css/CSSStyleSelector.h:
+* inspector/InspectorCSSAgent.cpp:
+(WebCore::computePseudoClassMask):
+(WebCore::InspectorCSSAgent::InspectorCSSAgent):
+(WebCore::InspectorCSSAgent::clearFrontend):
+(WebCore::InspectorCSSAgent::forcePseudoState):
+(WebCore::InspectorCSSAgent::getStylesForNode):
+(WebCore::InspectorCSSAgent::didRemoveDocument):
+(WebCore::InspectorCSSAgent::didRemoveDOMNode):
+(WebCore::InspectorCSSAgent::clearPseudoState):
+* inspector/InspectorCSSAgent.h:
+* inspector/InspectorController.cpp:
+(WebCore::InspectorController::disconnectFrontend):
+* inspector/InspectorInstrumentation.cpp:
+(WebCore::InspectorInstrumentation::forcePseudoStateImpl):
+* inspector/InspectorInstrumentation.h:
+(WebCore::InspectorInstrumentation::forcePseudoState):
+
 2011-08-16  Tony Chang  t...@chromium.org
 
 Unreviewed, rolling out r93114.


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (93121 => 93122)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-16 16:59:04 UTC (rev 93121)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-16 17:15:06 UTC (rev 93122)
@@ -68,6 +68,7 @@
 #include HTMLNames.h
 #include HTMLProgressElement.h
 #include HTMLTextAreaElement.h
+#include InspectorInstrumentation.h
 #include KeyframeList.h
 #include LinkHash.h
 #include LocaleToScriptMapping.h
@@ -894,8 +895,6 @@
 m_ruleList = 0;
 
 m_fontDirty = false;
-
-m_forcePseudoClassMask = DoNotForcePseudoClassMask;
 }
 
 static inline const AtomicString* linkAttribute(Node* node)
@@ -2031,12 +2030,12 @@
 }
 }
 
-PassRefPtrCSSRuleList CSSStyleSelector::styleRulesForElement(Element* e, unsigned 

[webkit-changes] [93123] trunk/LayoutTests

[tony]

Title: [93123] trunk/LayoutTests








Revision 93123
Author t...@chromium.org
Date 2011-08-16 10:16:27 -0700 (Tue, 16 Aug 2011)


Log Message
Move media/video-controls-no-scripting-iframe.html into the resources
subdir since it's not a standalone test.

Also add chromium baseline (the top of the video control is in a
different place).

* media/resources/video-controls-no-scripting-iframe.html: Renamed from LayoutTests/media/video-controls-no-scripting-iframe.html.
* media/video-controls-no-scripting.html:
* platform/chromium/media/video-controls-no-scripting-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-controls-no-scripting.html


Added Paths

trunk/LayoutTests/media/resources/video-controls-no-scripting-iframe.html
trunk/LayoutTests/platform/chromium/media/video-controls-no-scripting-expected.txt


Removed Paths

trunk/LayoutTests/media/video-controls-no-scripting-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (93122 => 93123)

--- trunk/LayoutTests/ChangeLog	2011-08-16 17:15:06 UTC (rev 93122)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 17:16:27 UTC (rev 93123)
@@ -1,3 +1,15 @@
+2011-08-16  Tony Chang  t...@chromium.org
+
+Move media/video-controls-no-scripting-iframe.html into the resources
+subdir since it's not a standalone test.
+
+Also add chromium baseline (the top of the video control is in a
+different place).
+
+* media/resources/video-controls-no-scripting-iframe.html: Renamed from LayoutTests/media/video-controls-no-scripting-iframe.html.
+* media/video-controls-no-scripting.html:
+* platform/chromium/media/video-controls-no-scripting-expected.txt: Added.
+
 2011-08-16  Adam Roben  aro...@apple.com
 
 Update Windows results for a fast/text test for Safari 5.1's AAS


Copied: trunk/LayoutTests/media/resources/video-controls-no-scripting-iframe.html (from rev 93120, trunk/LayoutTests/media/video-controls-no-scripting-iframe.html) (0 => 93123)

--- trunk/LayoutTests/media/resources/video-controls-no-scripting-iframe.html	(rev 0)
+++ trunk/LayoutTests/media/resources/video-controls-no-scripting-iframe.html	2011-08-16 17:16:27 UTC (rev 93123)
@@ -0,0 +1,25 @@
+!doctype html
+html
+head
+style #error { display: none; } /style
+script
+function showErrorMsg() 
+{
+document.getElementById('error').style.display = 'block';
+}
+/script
+/head
+
+body _onload_=showErrorMsg()
+
+video
+source src="" type=video/mp4
+source src="" type=video/ogg
+/video
+
+noscriptpScripting is DISABLED./p/noscript
+
+p id=errorERROR: _javascript_ must be disabled for this test./p
+
+/body
+/html


Property changes: trunk/LayoutTests/media/resources/video-controls-no-scripting-iframe.html



Added: svn:eol-style

Deleted: trunk/LayoutTests/media/video-controls-no-scripting-iframe.html (93122 => 93123)

--- trunk/LayoutTests/media/video-controls-no-scripting-iframe.html	2011-08-16 17:15:06 UTC (rev 93122)
+++ trunk/LayoutTests/media/video-controls-no-scripting-iframe.html	2011-08-16 17:16:27 UTC (rev 93123)
@@ -1,25 +0,0 @@
-!doctype html
-html
-head
-style #error { display: none; } /style
-script
-function showErrorMsg() 
-{
-document.getElementById('error').style.display = 'block';
-}
-/script
-/head
-
-body _onload_=showErrorMsg()
-
-video
-source src="" type=video/mp4
-source src="" type=video/ogg
-/video
-
-noscriptpScripting is DISABLED./p/noscript
-
-p id=errorERROR: _javascript_ must be disabled for this test./p
-
-/body
-/html


Modified: trunk/LayoutTests/media/video-controls-no-scripting.html (93122 => 93123)

--- trunk/LayoutTests/media/video-controls-no-scripting.html	2011-08-16 17:15:06 UTC (rev 93122)
+++ trunk/LayoutTests/media/video-controls-no-scripting.html	2011-08-16 17:16:27 UTC (rev 93123)
@@ -24,7 +24,7 @@
 
 body
 
-iframe sandbox src="" id=fr style=width: 400px; height: 320px; border: 1px solid black;/iframe
+iframe sandbox src="" id=fr style=width: 400px; height: 320px; border: 1px solid black;/iframe
 
 pTests that the built-in controls are always enabled when _javascript_ is disabled./p
 pre id=console/pre


Added: trunk/LayoutTests/platform/chromium/media/video-controls-no-scripting-expected.txt (0 => 93123)

--- trunk/LayoutTests/platform/chromium/media/video-controls-no-scripting-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/media/video-controls-no-scripting-expected.txt	2011-08-16 17:16:27 UTC (rev 93123)
@@ -0,0 +1,9 @@
+
+Tests that the built-in controls are always enabled when _javascript_ is disabled.
+
+EXPECTED 

[webkit-changes] [93124] trunk/LayoutTests

[tony]

Title: [93124] trunk/LayoutTests








Revision 93124
Author t...@chromium.org
Date 2011-08-16 10:23:02 -0700 (Tue, 16 Aug 2011)


Log Message
Copy the results of http/tests/inspector/resource-har-conversion.html
to the chromium platform dir.  The mac result (r93112) was getting
picked up by the chromium port.

* platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93123 => 93124)

--- trunk/LayoutTests/ChangeLog	2011-08-16 17:16:27 UTC (rev 93123)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 17:23:02 UTC (rev 93124)
@@ -1,5 +1,13 @@
 2011-08-16  Tony Chang  t...@chromium.org
 
+Copy the results of http/tests/inspector/resource-har-conversion.html
+to the chromium platform dir.  The mac result (r93112) was getting
+picked up by the chromium port.
+
+* platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Added.
+
+2011-08-16  Tony Chang  t...@chromium.org
+
 Move media/video-controls-no-scripting-iframe.html into the resources
 subdir since it's not a standalone test.
 


Added: trunk/LayoutTests/platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt (0 => 93124)

--- trunk/LayoutTests/platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt	2011-08-16 17:23:02 UTC (rev 93124)
@@ -0,0 +1,226 @@
+Tests conversion of Inspector's resource representation into HAR format.
+
+Page reloaded.
+{
+version : string
+creator : {
+name : WebInspector
+version : string
+}
+pages : [
+{
+startedDateTime : object
+id : string
+title : 
+pageTimings : {
+onContentLoad : number
+onLoad : number
+}
+}
+]
+entries : [
+{
+pageref : http://127.0.0.1:8000/inspector/resource-har-conversion.html
+startedDateTime : object
+time : number
+request : {
+method : GET
+url : http://127.0.0.1:8000/inspector/inspector-test.js
+httpVersion : HTTP/1.1
+headers : object
+queryString : [
+]
+cookies : [
+{
+name : a
+value : b
+path : /path
+domain : example.com
+expires : null
+httpOnly : false
+secure : false
+}
+{
+name : a1
+value : b1
+path : undefined
+domain : undefined
+expires : null
+httpOnly : false
+secure : false
+}
+{
+name : c1
+value : d1
+path : undefined
+domain : undefined
+expires : null
+httpOnly : false
+secure : false
+}
+]
+headersSize : number
+bodySize : number
+}
+response : {
+status : 304
+statusText : Not Modified
+httpVersion : HTTP/1.1
+headers : object
+cookies : [
+{
+name : x
+value : y
+path : /path
+domain : example.com
+expires : null
+httpOnly : true
+secure : true
+}
+{
+name : x1
+value : y1
+path : undefined
+domain : undefined
+expires : null
+httpOnly : false
+secure : false
+}
+{
+name : z2
+value : y2
+path : undefined
+domain : undefined
+expires : null
+httpOnly : false
+secure : false
+}
+]
+content : {
+size : number
+compression : number
+

[webkit-changes] [93125] trunk/Source/WebCore

[pfeldman]

Title: [93125] trunk/Source/WebCore








Revision 93125
Author pfeld...@chromium.org
Date 2011-08-16 10:27:24 -0700 (Tue, 16 Aug 2011)


Log Message
Web Inspector: convert DOM breakpoint types to strings.
https://bugs.webkit.org/show_bug.cgi?id=66304

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::domTypeForName):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp
trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h
trunk/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (93124 => 93125)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 17:23:02 UTC (rev 93124)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 17:27:24 UTC (rev 93125)
@@ -1,5 +1,21 @@
 2011-08-16  Pavel Feldman  pfeld...@google.com
 
+Web Inspector: convert DOM breakpoint types to strings.
+https://bugs.webkit.org/show_bug.cgi?id=66304
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/Inspector.json:
+* inspector/InspectorDOMDebuggerAgent.cpp:
+(WebCore::domTypeForName):
+(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
+(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
+* inspector/InspectorDOMDebuggerAgent.h:
+* inspector/front-end/DOMBreakpointsSidebarPane.js:
+(WebInspector.DOMBreakpointsSidebarPane):
+
+2011-08-16  Pavel Feldman  pfeld...@google.com
+
 Web Inspector: force pseudo element state when checking it in the styles sidebar.
 https://bugs.webkit.org/show_bug.cgi?id=66292
 


Modified: trunk/Source/WebCore/inspector/Inspector.json (93124 => 93125)

--- trunk/Source/WebCore/inspector/Inspector.json	2011-08-16 17:23:02 UTC (rev 93124)
+++ trunk/Source/WebCore/inspector/Inspector.json	2011-08-16 17:27:24 UTC (rev 93125)
@@ -1694,20 +1694,28 @@
 {
 domain: DOMDebugger,
 description: DOM debugging allows setting breakpoints on particular DOM operations and events. _javascript_ execution will stop on these operations as if there was a regular breakpoint set.,
+types: [
+{
+id: DOMBreakpointType,
+type: string,
+enum: [subtree-modified, attribute-modified, node-removed],
+description: DOM breakpoint type.
+}
+],
 commands: [
 {
 name: setDOMBreakpoint,
 parameters: [
 { name: nodeId, type: integer, description: Identifier of the node to set breakpoint on. },
-{ name: type, type: integer, description: Type of the operation to stop upon. }
+{ name: type, $ref: DOMBreakpointType, description: Type of the operation to stop upon. }
 ],
-description: Sets breakpoint on particular operation with DOM. 
+description: Sets breakpoint on particular operation with DOM.
 },
 {
 name: removeDOMBreakpoint,
 parameters: [
 { name: nodeId, type: integer, description: Identifier of the node to remove breakpoint from. },
-{ name: type, type: integer, description: Type of the breakpoint to remove. }
+{ name: type, $ref: DOMBreakpointType, description: Type of the breakpoint to remove. }
 ],
 description: Removes DOM breakpoint that was set using codesetDOMBreakpoint/code.
 },


Modified: trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp (93124 => 93125)

--- trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp	2011-08-16 17:23:02 UTC (rev 93124)
+++ trunk/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp	2011-08-16 17:27:24 UTC (rev 93125)
@@ -179,11 +179,34 @@
 }
 }
 
-void InspectorDOMDebuggerAgent::setDOMBreakpoint(ErrorString*, int nodeId, int type)
+static int domTypeForName(const String typeString)
 {
+if (typeString == subtree-modified)
+return SubtreeModified;
+if (typeString == attribute-modified)
+return AttributeModified;
+if (typeString == node-removed)
+return NodeRemoved;
+return SubtreeModified;
+}
+
+static String domTypeName(int type)
+{
+switch (type) {
+case SubtreeModified: return subtree-modified;
+case AttributeModified: return attribute-modified;
+case NodeRemoved: return node-removed;
+default: break;
+}
+return ;
+}
+
+void InspectorDOMDebuggerAgent::setDOMBreakpoint(ErrorString*, int nodeId, const String 

[webkit-changes] [93126] trunk/Source/WebKit/chromium

[mnaganov]

Title: [93126] trunk/Source/WebKit/chromium








Revision 93126
Author mnaga...@chromium.org
Date 2011-08-16 10:31:41 -0700 (Tue, 16 Aug 2011)


Log Message
Web Inspector: [Chromium] Add deployment of NetworkPanel .css files to concatenated version
https://bugs.webkit.org/show_bug.cgi?id=66316

Reviewed by NOBODY (OOPS!).

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (93125 => 93126)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-08-16 17:27:24 UTC (rev 93125)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-08-16 17:31:41 UTC (rev 93126)
@@ -1,5 +1,14 @@
 2011-08-16  Mikhail Naganov  mnaga...@chromium.org
 
+Web Inspector: [Chromium] Add deployment of NetworkPanel .css files to concatenated version
+https://bugs.webkit.org/show_bug.cgi?id=66316
+
+Reviewed by Pavel Feldman.
+
+* WebKit.gyp:
+
+2011-08-16  Mikhail Naganov  mnaga...@chromium.org
+
 Web Inspector: [Chromium] Fix 'inspector_resources' target to depend on 'concatenated_heap_snapshot_worker_js'
 https://bugs.webkit.org/show_bug.cgi?id=66300
 


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (93125 => 93126)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2011-08-16 17:27:24 UTC (rev 93125)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2011-08-16 17:31:41 UTC (rev 93126)
@@ -1343,6 +1343,12 @@
 'outputs': ['(PRODUCT_DIR)/resources/inspector/devTools.css'],
 'action': ['python', '@(_script_name)', '@(_input_page)', '@(_search_path)', '@(_outputs)'],
 }],
+'copies': [{
+'destination': '(PRODUCT_DIR)/resources/inspector',
+'files': [
+'@(webinspector_standalone_css_files)',
+],
+}],
 },
 ],
 }],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93129] trunk/LayoutTests

[tony]

Title: [93129] trunk/LayoutTests








Revision 93129
Author t...@chromium.org
Date 2011-08-16 11:04:54 -0700 (Tue, 16 Aug 2011)


Log Message
[chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in
debug (not just snowleopard).

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93128 => 93129)

--- trunk/LayoutTests/ChangeLog	2011-08-16 18:03:29 UTC (rev 93128)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 18:04:54 UTC (rev 93129)
@@ -1,3 +1,10 @@
+2011-08-16  Tony Chang  t...@chromium.org
+
+[chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in
+debug (not just snowleopard).
+
+* platform/chromium/test_expectations.txt:
+
 2011-08-16  Adam Roben  aro...@apple.com
 
 Add Windows expected results for resource-har-conversion.html


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93128 => 93129)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 18:03:29 UTC (rev 93128)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 18:04:54 UTC (rev 93129)
@@ -3212,7 +3212,6 @@
 BUGCR86340 : fast/filesystem/file-writer-write-overlapped.html = PASS CRASH TEXT
 
 // flakiness on deps bots (noted ~ r83108)
-BUGDPRANKE WIN DEBUG CPU : fast/css/last-of-type-pseudo-class.html = PASS TEXT
 BUGDPRANKE WIN DEBUG CPU : http/tests/eventsource/eventsource-reconnect.html = PASS TEXT
 BUGDPRANKE WIN : http/tests/navigation/ping-same-origin.html = PASS TIMEOUT TEXT
 BUGDPRANKE WIN DEBUG : http/tests/security/credentials-in-referer.html = PASS TIMEOUT
@@ -3529,7 +3528,7 @@
 // Quota enforcement not yet implemented for LevelDB back-end.
 BUGCR83652 : storage/indexeddb/database-quota.html = TEXT
 
-BUGCR88311 SNOWLEOPARD DEBUG : fast/css/last-of-type-pseudo-class.html = TEXT
+BUGCR88311 DEBUG : fast/css/last-of-type-pseudo-class.html = PASS TEXT
 
 BUGWK63902 MAC WIN : svg/animations/svgtransform-animation-1.html = PASS TEXT
 
@@ -3673,8 +3672,8 @@
 BUGWK63796 MAC WIN : css3/font-feature-settings-rendering.html = MISSING FAIL
 
 // New test in r93068
-BUGWK66268 : editing/deleting/regional-indicators.html = TEXT TIMEOUT
+BUGWK66268 : editing/deleting/regional-indicators.html = TIMEOUT TEXT
 
 BUGCR93044 LINUX DEBUG : fast/canvas/webgl/uninitialized-test.html = TIMEOUT
 
-BUGWK66310 DEBUG : media/video-source-error.html = TEXT PASS
+BUGWK66310 DEBUG : media/video-source-error.html = PASS TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93130] trunk/Source/WebCore

[jpfau]

Title: [93130] trunk/Source/WebCore








Revision 93130
Author jp...@apple.com
Date 2011-08-16 11:07:20 -0700 (Tue, 16 Aug 2011)


Log Message
New XML parser: Replace assertions regarding character data in the prolog with proper checks
https://bugs.webkit.org/show_bug.cgi?id=66269

Reviewed by Adam Barth.

This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.

* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processProcessingInstruction):
(WebCore::XMLTreeBuilder::processXMLDeclaration):
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::enterText):
(WebCore::XMLTreeBuilder::failOnText):
* xml/parser/XMLTreeBuilder.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/parser/XMLTreeBuilder.cpp
trunk/Source/WebCore/xml/parser/XMLTreeBuilder.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93129 => 93130)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 18:04:54 UTC (rev 93129)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 18:07:20 UTC (rev 93130)
@@ -1,3 +1,20 @@
+2011-08-16  Jeffrey Pfau  jp...@apple.com
+
+New XML parser: Replace assertions regarding character data in the prolog with proper checks
+https://bugs.webkit.org/show_bug.cgi?id=66269
+
+Reviewed by Adam Barth.
+
+This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.
+
+* xml/parser/XMLTreeBuilder.cpp:
+(WebCore::XMLTreeBuilder::processProcessingInstruction):
+(WebCore::XMLTreeBuilder::processXMLDeclaration):
+(WebCore::XMLTreeBuilder::processDOCTYPE):
+(WebCore::XMLTreeBuilder::enterText):
+(WebCore::XMLTreeBuilder::failOnText):
+* xml/parser/XMLTreeBuilder.h:
+
 2011-08-16  Alexander Pavlov  apav...@chromium.org
 
 Web Inspector: word wrap long edits


Modified: trunk/Source/WebCore/xml/parser/XMLTreeBuilder.cpp (93129 => 93130)

--- trunk/Source/WebCore/xml/parser/XMLTreeBuilder.cpp	2011-08-16 18:04:54 UTC (rev 93129)
+++ trunk/Source/WebCore/xml/parser/XMLTreeBuilder.cpp	2011-08-16 18:07:20 UTC (rev 93130)
@@ -100,7 +100,9 @@
 
 void XMLTreeBuilder::processProcessingInstruction(const AtomicXMLToken token)
 {
-ASSERT(!m_leafText);
+if (!failOnText())
+return;
+
 // FIXME: fall back if we can't handle the PI ourself.
 
 add(ProcessingInstruction::create(m_document, token.target(), token.data()));
@@ -108,7 +110,8 @@
 
 void XMLTreeBuilder::processXMLDeclaration(const AtomicXMLToken token)
 {
-ASSERT(!m_leafText);
+if (!failOnText())
+return;
 
 ExceptionCode ec = 0;
 
@@ -134,7 +137,8 @@
 DEFINE_STATIC_LOCAL(AtomicString, xhtmlMathMLSVG, (-//W3C//DTD XHTML 1.1 plus MathML 2.0 plus SVG 1.1//EN));
 DEFINE_STATIC_LOCAL(AtomicString, xhtmlMobile, (-//WAPFORUM//DTD XHTML Mobile 1.0//EN));
 
-ASSERT(!m_leafText);
+if (!failOnText())
+return;
 
 AtomicString publicIdentifier(token.publicIdentifier().data(), token.publicIdentifier().size());
 AtomicString systemIdentifier(token.systemIdentifier().data(), token.systemIdentifier().size());
@@ -330,7 +334,7 @@
 void XMLTreeBuilder::enterText()
 {
 if (!m_sawFirstElement) {
-// FIXME: ensure it's just whitespace
+// FIXME: Guarantee the text is only whitespace.
 return;
 }
 
@@ -348,6 +352,17 @@
 m_leafText.clear();
 }
 
+bool XMLTreeBuilder::failOnText()
+{
+if (!m_leafText)
+return true;
+
+// FIXME: Guarantee the text is only whitespace.
+
+m_leafText.clear();
+return true;
+}
+
 XMLTreeBuilder::NodeStackItem::NodeStackItem(PassRefPtrContainerNode n, NodeStackItem* parent)
 : m_node(n)
 {


Modified: trunk/Source/WebCore/xml/parser/XMLTreeBuilder.h (93129 => 93130)

--- trunk/Source/WebCore/xml/parser/XMLTreeBuilder.h	2011-08-16 18:04:54 UTC (rev 93129)
+++ trunk/Source/WebCore/xml/parser/XMLTreeBuilder.h	2011-08-16 18:07:20 UTC (rev 93130)
@@ -95,6 +95,7 @@
 void appendToText(const UChar* characters, size_t length);
 void enterText();
 void exitText();
+bool failOnText();
 
 AtomicString namespaceForPrefix(AtomicString prefix, AtomicString fallback);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93132] trunk/LayoutTests

[tony]

Title: [93132] trunk/LayoutTests








Revision 93132
Author t...@chromium.org
Date 2011-08-16 11:36:18 -0700 (Tue, 16 Aug 2011)


Log Message
[chromium] Mark svg/wicd/test-rightsizing-a.xhtml as flakey.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93131 => 93132)

--- trunk/LayoutTests/ChangeLog	2011-08-16 18:23:44 UTC (rev 93131)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 18:36:18 UTC (rev 93132)
@@ -1,5 +1,11 @@
 2011-08-16  Tony Chang  t...@chromium.org
 
+[chromium] Mark svg/wicd/test-rightsizing-a.xhtml as flakey.
+
+* platform/chromium/test_expectations.txt:
+
+2011-08-16  Tony Chang  t...@chromium.org
+
 [chromium] Mark fast/css/last-of-type-pseudo-class.html as flaky in
 debug (not just snowleopard).
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93131 => 93132)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 18:23:44 UTC (rev 93131)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 18:36:18 UTC (rev 93132)
@@ -3423,7 +3423,8 @@
 // Weird failures only on debug bots after r87526.
 BUGADAMK DEBUG : svg/custom/object-sizing-explicit-height.xhtml = PASS IMAGE+TEXT
 BUGADAMK DEBUG : svg/custom/object-sizing-explicit-width.xhtml = PASS IMAGE+TEXT
-BUGADAMK SNOWLEOPARD DEBUG : svg/wicd/test-rightsizing-a.xhtml = PASS IMAGE+TEXT
+BUGWK66320 SNOWLEOPARD RELEASE : svg/wicd/test-rightsizing-a.xhtml = PASS IMAGE+TEXT
+BUGWK66320 DEBUG : svg/wicd/test-rightsizing-a.xhtml = PASS IMAGE+TEXT
 
 // After r87526, these all have extra scrollbars where the platform/mac expectations do not.
 BUGWK61664 LINUX : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93136] trunk/Source/WebCore

[commit-queue]

Title: [93136] trunk/Source/WebCore








Revision 93136
Author commit-qu...@webkit.org
Date 2011-08-16 11:45:35 -0700 (Tue, 16 Aug 2011)


Log Message
Chromium Mac: Rubber banding gutter drawing
https://bugs.webkit.org/show_bug.cgi?id=66226

Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
draw the overhang areas.
Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
Add a different implementation for Chromium Mac.

Patch by Alexei Svitkine asvitk...@chromium.org on 2011-08-16
Reviewed by Dimitri Glazkov.

No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::paintOverhangAreas):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paintOverhangAreas):
* platform/ScrollbarThemeComposite.h:
* platform/chromium/ScrollbarThemeChromiumMac.h:
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollbarTheme.h
trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp
trunk/Source/WebCore/platform/ScrollbarThemeComposite.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h
trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm
trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93135 => 93136)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 18:44:01 UTC (rev 93135)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 18:45:35 UTC (rev 93136)
@@ -1,3 +1,31 @@
+2011-08-16  Alexei Svitkine  asvitk...@chromium.org
+
+Chromium Mac: Rubber banding gutter drawing
+https://bugs.webkit.org/show_bug.cgi?id=66226
+
+Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to
+draw the overhang areas.
+Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().
+Add a different implementation for Chromium Mac.
+
+Reviewed by Dimitri Glazkov.
+
+No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.
+
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::wheelEvent):
+* platform/ScrollbarTheme.h:
+(WebCore::ScrollbarTheme::paintOverhangAreas):
+* platform/ScrollbarThemeComposite.cpp:
+(WebCore::ScrollbarThemeComposite::paintOverhangAreas):
+* platform/ScrollbarThemeComposite.h:
+* platform/chromium/ScrollbarThemeChromiumMac.h:
+* platform/chromium/ScrollbarThemeChromiumMac.mm:
+(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
+(WebCore::scrollbarStateToThemeState):
+(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
+(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):
+
 2011-08-12  Wyatt Carss  wca...@chromium.org
 
 Programmatically set selection should not have direction on Mac


Modified: trunk/Source/WebCore/platform/ScrollView.cpp (93135 => 93136)

--- trunk/Source/WebCore/platform/ScrollView.cpp	2011-08-16 18:44:01 UTC (rev 93135)
+++ trunk/Source/WebCore/platform/ScrollView.cpp	2011-08-16 18:45:35 UTC (rev 93136)
@@ -1086,17 +1086,9 @@
 }
 }
 
-void ScrollView::paintOverhangAreas(GraphicsContext* context, const IntRect horizontalOverhangRect, const IntRect verticalOverhangRect, const IntRect)
+void ScrollView::paintOverhangAreas(GraphicsContext* context, const IntRect horizontalOverhangRect, const IntRect verticalOverhangRect, const IntRect dirtyRect)
 {
-// FIXME: This should be checking the dirty rect.
-
-context-setFillColor(Color::white, ColorSpaceDeviceRGB);
-if (!horizontalOverhangRect.isEmpty())
-context-fillRect(horizontalOverhangRect);
-
-context-setFillColor(Color::white, ColorSpaceDeviceRGB);
-if (!verticalOverhangRect.isEmpty())
-context-fillRect(verticalOverhangRect);
+ScrollbarTheme::nativeTheme()-paintOverhangAreas(this, context, horizontalOverhangRect, verticalOverhangRect, dirtyRect);
 }
 
 bool ScrollView::isPointInScrollbarCorner(const IntPoint windowPoint)


Modified: trunk/Source/WebCore/platform/ScrollbarTheme.h (93135 => 93136)

--- trunk/Source/WebCore/platform/ScrollbarTheme.h	2011-08-16 18:44:01 UTC (rev 93135)
+++ trunk/Source/WebCore/platform/ScrollbarTheme.h	2011-08-16 18:45:35 UTC (rev 93136)
@@ -82,6 +82,8 @@
 virtual void paintScrollCorner(ScrollView*, GraphicsContext* context, const IntRect cornerRect) { defaultPaintScrollCorner(context, cornerRect); }
 static void 

[webkit-changes] [93137] branches/safari-534.51-branch/Source/WebCore

[lforschler]

Title: [93137] branches/safari-534.51-branch/Source/WebCore








Revision 93137
Author lforsch...@apple.com
Date 2011-08-16 11:49:42 -0700 (Tue, 16 Aug 2011)


Log Message
Merge r92977.

Modified Paths

branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp




Diff

Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (93136 => 93137)

--- branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-16 18:45:35 UTC (rev 93136)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-16 18:49:42 UTC (rev 93137)
@@ -1,5 +1,46 @@
 2011-08-16  Lucas Forschler  lforsch...@apple.com
 
+Merged 92977
+
+2011-08-12  Jeff Miller  je...@apple.com
+
+Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed
+https://bugs.webkit.org/show_bug.cgi?id=65724
+
+Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an
+ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage
+access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete
+AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).
+
+Reviewed by Eric Carlson.
+
+No new tests, uses existing media tests.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::AVFWrapper::callbackContext): Added.
+(WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.
+(WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.
+(WebCore::AVFWrapper::mapLock): Added.
+(WebCore::AVFWrapper::map): Added.
+(WebCore::AVFWrapper::addToMap): Added.
+(WebCore::AVFWrapper::removeFromMap): Added.
+(WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.
+(WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.
+(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.
+(WebCore::AVFWrapper::createPlayer): Use callbackContext().
+(WebCore::AVFWrapper::createPlayerItem): Use callbackContext().
+(WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.
+(WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.
+(WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.
+(WebCore::AVFWrapper::checkPlayability): Use callbackContext().
+(WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.
+(WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext().
+(WebCore::AVFWrapper::seekCompletedCallback): Retrieve AVFWrapper using the HashMap.
+(WebCore::AVFWrapper::seekToTime): Use callbackContext().
+(WebCore::AVFWrapper::platformLayer): Remove overly noisy LOG().
+
+2011-08-16  Lucas Forschler  lforsch...@apple.com
+
 Merged 88444
 
 2011-06-08  Mikołaj Małecki  m.male...@samsung.com


Modified: branches/safari-534.51-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp (93136 => 93137)

--- branches/safari-534.51-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-16 18:45:35 UTC (rev 93136)
+++ branches/safari-534.51-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-16 18:49:42 UTC (rev 93137)
@@ -45,6 +45,7 @@
 
 #include delayimp.h
 #include dispatch/dispatch.h
+#include wtf/HashMap.h
 #include wtf/Threading.h
 #include wtf/UnusedParam.h
 
@@ -122,9 +123,19 @@
 inline dispatch_queue_t dispatchQueue() const { return m_notificationQueue; }
 
 private:
+inline void* callbackContext() const { return reinterpret_castvoid*(m_objectID); }
+
+static Mutex mapLock();
+static HashMapuintptr_t, AVFWrapper* map();
+static AVFWrapper* avfWrapperForCallbackContext(void*);
+void addToMap();
+void removeFromMap() const;
+
 static void disconnectAndDeleteAVFWrapper(void*);
-static void deleteAVFWrapper(void*);
 
+static uintptr_t s_nextAVFWrapperObjectID;
+uintptr_t m_objectID;
+
 MediaPlayerPrivateAVFoundationCF* m_owner;
 
 RetainPtrAVCFPlayerRef m_avPlayer;
@@ -141,6 +152,8 @@
 OwnPtrLayerClient m_layerClient;
 };
 
+uintptr_t AVFWrapper::s_nextAVFWrapperObjectID;
+
 class LayerClient : public PlatformCALayerClient {
 public:
 

[webkit-changes] [93138] trunk/Websites/webkit.org

[dbates]

Title: [93138] trunk/Websites/webkit.org








Revision 93138
Author dba...@webkit.org
Date 2011-08-16 11:56:43 -0700 (Tue, 16 Aug 2011)


Log Message
2011-08-16  Daniel Bates  dba...@webkit.org

Add myself to the list of individual members in the WebKit Security Group.

Rubber-stamped by Eric Seidel.

* security/security-group-members.html:

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/security/security-group-members.html




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (93137 => 93138)

--- trunk/Websites/webkit.org/ChangeLog	2011-08-16 18:49:42 UTC (rev 93137)
+++ trunk/Websites/webkit.org/ChangeLog	2011-08-16 18:56:43 UTC (rev 93138)
@@ -1,3 +1,11 @@
+2011-08-16  Daniel Bates  dba...@webkit.org
+
+Add myself to the list of individual members in the WebKit Security Group.
+
+Rubber-stamped by Eric Seidel.
+
+* security/security-group-members.html:
+
 2011-08-09  Anders Carlsson  ander...@apple.com
 
 Broken link to LICENSE on contributing code page


Modified: trunk/Websites/webkit.org/security/security-group-members.html (93137 => 93138)

--- trunk/Websites/webkit.org/security/security-group-members.html	2011-08-16 18:49:42 UTC (rev 93137)
+++ trunk/Websites/webkit.org/security/security-group-members.html	2011-08-16 18:56:43 UTC (rev 93138)
@@ -11,6 +11,7 @@
 liAdam Barth
 liAlexey Proskuryakov
 liCollin Jackson
+liDaniel Bates
 liEric Seidel
 liIan Hickson
 liMaciej Stachowiak






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93139] trunk/LayoutTests

[aroben]

Title: [93139] trunk/LayoutTests








Revision 93139
Author aro...@apple.com
Date 2011-08-16 12:12:42 -0700 (Tue, 16 Aug 2011)


Log Message
Add Windows expected results for some canvas tests

canvas doesn't use accelerated compositing on Windows like it does on Lion.

* platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
* platform/win/fast/repaint/canvas-putImageData-expected.txt: Copied from platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt
trunk/LayoutTests/platform/win/fast/repaint/canvas-putImageData-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93138 => 93139)

--- trunk/LayoutTests/ChangeLog	2011-08-16 18:56:43 UTC (rev 93138)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 19:12:42 UTC (rev 93139)
@@ -1,3 +1,12 @@
+2011-08-16  Adam Roben  aro...@apple.com
+
+Add Windows expected results for some canvas tests
+
+canvas doesn't use accelerated compositing on Windows like it does on Lion.
+
+* platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Copied from platform/mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
+* platform/win/fast/repaint/canvas-putImageData-expected.txt: Copied from platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt.
+
 2011-08-12  Wyatt Carss  wca...@chromium.org
 
 Programmatically set selection should not have direction on Mac


Added: trunk/LayoutTests/platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt (0 => 93139)

--- trunk/LayoutTests/platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt	2011-08-16 19:12:42 UTC (rev 93139)
@@ -0,0 +1 @@
+


Added: trunk/LayoutTests/platform/win/fast/repaint/canvas-putImageData-expected.txt (0 => 93139)

--- trunk/LayoutTests/platform/win/fast/repaint/canvas-putImageData-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/win/fast/repaint/canvas-putImageData-expected.txt	2011-08-16 19:12:42 UTC (rev 93139)
@@ -0,0 +1,8 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+  RenderHTMLCanvas {CANVAS} at (0,0) size 100x100
+  RenderText {#text} at (0,0) size 0x0
+  RenderText {#text} at (0,0) size 0x0






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93140] trunk/Source/WebCore

[joepeck]

Title: [93140] trunk/Source/WebCore








Revision 93140
Author joep...@webkit.org
Date 2011-08-16 12:18:11 -0700 (Tue, 16 Aug 2011)


Log Message
Abandoned Memory: Temporary CSS Fonts May Never Be Purged
https://bugs.webkit.org/show_bug.cgi?id=66153

Reviewed by Dan Bernstein.

While a remote CSS font face is loading we fallback to a
temporary font. We don't want to retain the fallback font
because noone takes ownership of the temporary font. This
patch adds a way to get an uncached fallback font, which
plumbs the ShouldRetain enum through the different platform
implementations of getLastResortFallbackFont.

No new tests, no functional change.

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* platform/graphics/FontCache.cpp:
(WebCore::FontCache::getNonRetainedLastResortFallbackFont):
* platform/graphics/FontCache.h:
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
(WebCore::getLastResortFallbackFontProc):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/haiku/FontCacheHaiku.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/pango/FontCachePango.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/wince/FontCacheWinCE.cpp:
* platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getLastResortFallbackFont):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceSource.cpp
trunk/Source/WebCore/platform/graphics/FontCache.cpp
trunk/Source/WebCore/platform/graphics/FontCache.h
trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp
trunk/Source/WebCore/platform/graphics/chromium/FontCacheLinux.cpp
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
trunk/Source/WebCore/platform/graphics/haiku/FontCacheHaiku.cpp
trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
trunk/Source/WebCore/platform/graphics/pango/FontCachePango.cpp
trunk/Source/WebCore/platform/graphics/qt/FontCacheQt.cpp
trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp
trunk/Source/WebCore/platform/graphics/wince/FontCacheWinCE.cpp
trunk/Source/WebCore/platform/graphics/wx/FontCacheWx.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (93139 => 93140)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 19:12:42 UTC (rev 93139)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 19:18:11 UTC (rev 93140)
@@ -1,3 +1,48 @@
+2011-08-16  Joseph Pecoraro  joep...@webkit.org
+
+Abandoned Memory: Temporary CSS Fonts May Never Be Purged
+https://bugs.webkit.org/show_bug.cgi?id=66153
+
+Reviewed by Dan Bernstein.
+
+While a remote CSS font face is loading we fallback to a
+temporary font. We don't want to retain the fallback font
+because noone takes ownership of the temporary font. This
+patch adds a way to get an uncached fallback font, which
+plumbs the ShouldRetain enum through the different platform
+implementations of getLastResortFallbackFont.
+
+No new tests, no functional change.
+
+* css/CSSFontFaceSource.cpp:
+(WebCore::CSSFontFaceSource::getFontData):
+* platform/graphics/FontCache.cpp:
+(WebCore::FontCache::getNonRetainedLastResortFallbackFont):
+* platform/graphics/FontCache.h:
+* platform/graphics/chromium/FontCacheChromiumWin.cpp:
+(WebCore::fontDataFromDescriptionAndLogFont):
+(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
+(WebCore::getLastResortFallbackFontProc):
+(WebCore::FontCache::getLastResortFallbackFont):
+* platform/graphics/chromium/FontCacheLinux.cpp:
+(WebCore::FontCache::getLastResortFallbackFont):
+* platform/graphics/freetype/FontCacheFreeType.cpp:
+(WebCore::FontCache::getLastResortFallbackFont):
+* platform/graphics/haiku/FontCacheHaiku.cpp:
+(WebCore::FontCache::getLastResortFallbackFont):
+* platform/graphics/mac/FontCacheMac.mm:
+(WebCore::FontCache::getLastResortFallbackFont):
+* platform/graphics/pango/FontCachePango.cpp:
+(WebCore::FontCache::getLastResortFallbackFont):
+* platform/graphics/qt/FontCacheQt.cpp:
+(WebCore::FontCache::getLastResortFallbackFont):
+* platform/graphics/win/FontCacheWin.cpp:
+

[webkit-changes] [93141] branches/safari-534.51-branch/Source/WebCore

[lforschler]

Title: [93141] branches/safari-534.51-branch/Source/WebCore








Revision 93141
Author lforsch...@apple.com
Date 2011-08-16 12:34:30 -0700 (Tue, 16 Aug 2011)


Log Message
Merge r93047.

Modified Paths

branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp




Diff

Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (93140 => 93141)

--- branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-16 19:18:11 UTC (rev 93140)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog	2011-08-16 19:34:30 UTC (rev 93141)
@@ -1,5 +1,25 @@
 2011-08-16  Lucas Forschler  lforsch...@apple.com
 
+Merged 93047
+
+2011-08-12  Jeff Miller  je...@apple.com
+
+MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
+https://bugs.webkit.org/show_bug.cgi?id=66171
+
+MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
+to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC.  I also added better logging to notificationCallback().
+
+Reviewed by Jon Honeycutt.
+
+No new tests, uses existing media tests.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
+(WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.
+
+2011-08-16  Lucas Forschler  lforsch...@apple.com
+
 Merged 92977
 
 2011-08-12  Jeff Miller  je...@apple.com


Modified: branches/safari-534.51-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp (93140 => 93141)

--- branches/safari-534.51-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-16 19:18:11 UTC (rev 93140)
+++ branches/safari-534.51-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-16 19:34:30 UTC (rev 93141)
@@ -388,7 +388,7 @@
 MediaPlayerPrivateAVFoundation::ItemStatus MediaPlayerPrivateAVFoundationCF::playerItemStatus() const
 {
 if (!avPlayerItem(m_avfWrapper))
-return MediaPlayerPrivateAVFoundation::MediaPlayerAVPlayerItemStatusUnknown;
+return MediaPlayerPrivateAVFoundation::MediaPlayerAVPlayerItemStatusDoesNotExist;
 
 AVCFPlayerItemStatus status = AVCFPlayerItemGetStatus(avPlayerItem(m_avfWrapper), 0);
 if (status == AVCFPlayerItemStatusUnknown)
@@ -1041,7 +1041,11 @@
 return;
 }
 
-LOG(Media, AVFWrapper::notificationCallback(%p), self);
+#if !LOG_DISABLED
+char notificationName[256];
+CFStringGetCString(propertyName, notificationName, sizeof(notificationName), kCFStringEncodingASCII);
+LOG(Media, AVFWrapper::notificationCallback(%p) %s, self, notificationName);
+#endif
 
 if (CFEqual(propertyName, AVCFPlayerItemDidPlayToEndTimeNotification))
 self-m_owner-scheduleMainThreadNotification(MediaPlayerPrivateAVFoundation::Notification::ItemDidPlayToEndTime);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93142] branches/safari-534.51-branch

[lforschler]

Title: [93142] branches/safari-534.51-branch








Revision 93142
Author lforsch...@apple.com
Date 2011-08-16 12:40:10 -0700 (Tue, 16 Aug 2011)


Log Message
Merge r93048.

Modified Paths

branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/LayoutTests/fast/js/preventExtensions-expected.txt
branches/safari-534.51-branch/LayoutTests/fast/js/script-tests/preventExtensions.js
branches/safari-534.51-branch/Source/_javascript_Core/ChangeLog
branches/safari-534.51-branch/Source/_javascript_Core/runtime/JSObject.h




Diff

Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (93141 => 93142)

--- branches/safari-534.51-branch/LayoutTests/ChangeLog	2011-08-16 19:34:30 UTC (rev 93141)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog	2011-08-16 19:40:10 UTC (rev 93142)
@@ -1,3 +1,18 @@
+2011-08-16  Lucas Forschler  lforsch...@apple.com
+
+Merged 93048
+
+2011-08-15  Gavin Barraclough  barraclo...@apple.com
+
+Crash accessing static property on sealed object
+https://bugs.webkit.org/show_bug.cgi?id=66242
+
+Reviewed by Sam Weinig.
+
+* fast/js/preventExtensions-expected.txt:
+* fast/js/script-tests/preventExtensions.js:
+- added test case.
+
 2011-08-11  Lucas Forschler  lforsch...@apple.com
 
 Merged 92692


Modified: branches/safari-534.51-branch/LayoutTests/fast/js/preventExtensions-expected.txt (93141 => 93142)

--- branches/safari-534.51-branch/LayoutTests/fast/js/preventExtensions-expected.txt	2011-08-16 19:34:30 UTC (rev 93141)
+++ branches/safari-534.51-branch/LayoutTests/fast/js/preventExtensions-expected.txt	2011-08-16 19:40:10 UTC (rev 93142)
@@ -10,6 +10,7 @@
 PASS test(preventExtensions(obj())) is (b:4)
 PASS test(seal(obj())) is (a:1)(b:4)S
 PASS test(freeze(obj())) is (a:1)(b:2)SF
+PASS Object.preventExtensions(Math); Math.sqrt(4) is 2
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: branches/safari-534.51-branch/LayoutTests/fast/js/script-tests/preventExtensions.js (93141 => 93142)

--- branches/safari-534.51-branch/LayoutTests/fast/js/script-tests/preventExtensions.js	2011-08-16 19:34:30 UTC (rev 93141)
+++ branches/safari-534.51-branch/LayoutTests/fast/js/script-tests/preventExtensions.js	2011-08-16 19:40:10 UTC (rev 93142)
@@ -65,4 +65,7 @@
 shouldBe('test(seal(obj()))', '(a:1)(b:4)S'); // sealed, CANNOT delete a, can modify b, and CANNOT add c
 shouldBe('test(freeze(obj()))', '(a:1)(b:2)SF'); // sealed and frozen, CANNOT delete a, CANNOT modify b, and CANNOT add c
 
+// check that we can still access static properties on an object after calling preventExtensions.
+shouldBe('Object.preventExtensions(Math); Math.sqrt(4)', '2');
+
 successfullyParsed = true;
\ No newline at end of file


Modified: branches/safari-534.51-branch/Source/_javascript_Core/ChangeLog (93141 => 93142)

--- branches/safari-534.51-branch/Source/_javascript_Core/ChangeLog	2011-08-16 19:34:30 UTC (rev 93141)
+++ branches/safari-534.51-branch/Source/_javascript_Core/ChangeLog	2011-08-16 19:40:10 UTC (rev 93142)
@@ -1,5 +1,20 @@
 2011-08-16  Lucas Forschler  lforsch...@apple.com
 
+Merged 93048
+
+2011-08-15  Gavin Barraclough  barraclo...@apple.com
+
+Crash accessing static property on sealed object
+https://bugs.webkit.org/show_bug.cgi?id=66242
+
+Reviewed by Sam Weinig.
+
+* runtime/JSObject.h:
+(JSC::JSObject::putDirectInternal):
+- should only check isExtensible if checkReadOnly.
+
+2011-08-16  Lucas Forschler  lforsch...@apple.com
+
 Merged 88444
 
 2011-06-08  Mikołaj Małecki  m.male...@samsung.com


Modified: branches/safari-534.51-branch/Source/_javascript_Core/runtime/JSObject.h (93141 => 93142)

--- branches/safari-534.51-branch/Source/_javascript_Core/runtime/JSObject.h	2011-08-16 19:34:30 UTC (rev 93141)
+++ branches/safari-534.51-branch/Source/_javascript_Core/runtime/JSObject.h	2011-08-16 19:40:10 UTC (rev 93142)
@@ -633,7 +633,7 @@
 return true;
 }
 
-if (!isExtensible())
+if (checkReadOnly  !isExtensible())
 return false;
 
 size_t currentCapacity = m_structure-propertyStorageCapacity();
@@ -697,7 +697,7 @@
 return true;
 }
 
-if (!isExtensible())
+if (checkReadOnly  !isExtensible())
 return false;
 
 Structure* structure = Structure::addPropertyTransition(globalData, m_structure.get(), propertyName, attributes, specificFunction, offset);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93143] branches/safari-534.51-branch

[lforschler]

Title: [93143] branches/safari-534.51-branch








Revision 93143
Author lforsch...@apple.com
Date 2011-08-16 12:42:07 -0700 (Tue, 16 Aug 2011)


Log Message
Merge r93070.

Modified Paths

branches/safari-534.51-branch/LayoutTests/ChangeLog
branches/safari-534.51-branch/LayoutTests/fast/js/kde/script-tests/operators.js
branches/safari-534.51-branch/Source/_javascript_Core/ChangeLog
branches/safari-534.51-branch/Source/_javascript_Core/dfg/DFGOperations.cpp
branches/safari-534.51-branch/Source/_javascript_Core/dfg/DFGOperations.h




Diff

Modified: branches/safari-534.51-branch/LayoutTests/ChangeLog (93142 => 93143)

--- branches/safari-534.51-branch/LayoutTests/ChangeLog	2011-08-16 19:40:10 UTC (rev 93142)
+++ branches/safari-534.51-branch/LayoutTests/ChangeLog	2011-08-16 19:42:07 UTC (rev 93143)
@@ -1,5 +1,37 @@
 2011-08-16  Lucas Forschler  lforsch...@apple.com
 
+Merged 93070
+
+2011-08-15  Gavin Barraclough  barraclo...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=66263
+DFG JIT does not always zero extend boolean result of DFG operations
+
+Reviewed by Sam Weinig.
+
+* fast/js/kde/script-tests/operators.js:
+(nonSpeculativeNotInner):
+(nonSpeculativeNot):
+(nonSpeculativeLessInner):
+(nonSpeculativeLess):
+(nonSpeculativeLessEqInner):
+(nonSpeculativeLessEq):
+(nonSpeculativeGreaterInner):
+(nonSpeculativeGreater):
+(nonSpeculativeGreaterEqInner):
+(nonSpeculativeGreaterEq):
+(nonSpeculativeEqualInner):
+(nonSpeculativeEqual):
+(nonSpeculativeNotEqualInner):
+(nonSpeculativeNotEqual):
+(nonSpeculativeStrictEqualInner):
+(nonSpeculativeStrictEqual):
+(nonSpeculativeStrictNotEqualInner):
+(nonSpeculativeStrictNotEqual):
+- Add tests cases that will hit the non-spec path.
+
+2011-08-16  Lucas Forschler  lforsch...@apple.com
+
 Merged 93048
 
 2011-08-15  Gavin Barraclough  barraclo...@apple.com


Modified: branches/safari-534.51-branch/LayoutTests/fast/js/kde/script-tests/operators.js (93142 => 93143)

--- branches/safari-534.51-branch/LayoutTests/fast/js/kde/script-tests/operators.js	2011-08-16 19:40:10 UTC (rev 93142)
+++ branches/safari-534.51-branch/LayoutTests/fast/js/kde/script-tests/operators.js	2011-08-16 19:42:07 UTC (rev 93143)
@@ -1,3 +1,102 @@
+function nonSpeculativeNotInner(argument, o1, o2)
+{
+// The + operator on objects is a reliable way to avoid the speculative JIT path for now at least.
+o1 + o2;
+return !argument;
+}
+function nonSpeculativeNot(argument)
+{
+return nonSpeculativeNotInner(argument, {}, {});
+}
+
+function nonSpeculativeLessInner(a, b, o1, o2)
+{
+// The + operator on objects is a reliable way to avoid the speculative JIT path for now at least.
+o1 + o2;
+return a  b;
+}
+function nonSpeculativeLess(a, b)
+{
+return nonSpeculativeLessInner(a, b, {}, {});
+}
+
+function nonSpeculativeLessEqInner(a, b, o1, o2)
+{
+// The + operator on objects is a reliable way to avoid the speculative JIT path for now at least.
+o1 + o2;
+return a = b;
+}
+function nonSpeculativeLessEq(a, b)
+{
+return nonSpeculativeLessEqInner(a, b, {}, {});
+}
+
+function nonSpeculativeGreaterInner(a, b, o1, o2)
+{
+// The + operator on objects is a reliable way to avoid the speculative JIT path for now at least.
+o1 + o2;
+return a  b;
+}
+function nonSpeculativeGreater(a, b)
+{
+return nonSpeculativeGreaterInner(a, b, {}, {});
+}
+
+function nonSpeculativeGreaterEqInner(a, b, o1, o2)
+{
+// The + operator on objects is a reliable way to avoid the speculative JIT path for now at least.
+o1 + o2;
+return a = b;
+}
+function nonSpeculativeGreaterEq(a, b)
+{
+return nonSpeculativeGreaterEqInner(a, b, {}, {});
+}
+
+function nonSpeculativeEqualInner(a, b, o1, o2)
+{
+// The + operator on objects is a reliable way to avoid the speculative JIT path for now at least.
+o1 + o2;
+return a == b;
+}
+function nonSpeculativeEqual(a, b)
+{
+return nonSpeculativeEqualInner(a, b, {}, {});
+}
+
+function nonSpeculativeNotEqualInner(a, b, o1, o2)
+{
+// The + operator on objects is a reliable way to avoid the speculative JIT path for now at least.
+o1 + o2;
+return a != b;
+}
+function nonSpeculativeNotEqual(a, b)
+{
+return nonSpeculativeNotEqualInner(a, b, {}, {});
+}
+
+function nonSpeculativeStrictEqualInner(a, b, o1, o2)
+{
+// The + operator on objects is a reliable way to avoid the speculative JIT path for now at least.
+o1 + o2;
+return a === b;
+}
+function nonSpeculativeStrictEqual(a, b)
+{
+return nonSpeculativeStrictEqualInner(a, b, {}, {});
+}
+
+function nonSpeculativeStrictNotEqualInner(a, b, o1, o2)
+{
+// The + operator on objects is a reliable way to avoid the 

[webkit-changes] [93144] trunk

[hyatt]

Title: [93144] trunk








Revision 93144
Author hy...@apple.com
Date 2011-08-16 12:43:21 -0700 (Tue, 16 Aug 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=66254

Source/WebCore: 

Make region invalidation and repainting work properly. We do this by making RenderFlowThreads into
repaint containers and then issuing new repaints in the regions that contain the invalidated flow thread
content.

Reviewed by Simon Fraser.

Added new tests in fast/repaint.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingRenderFlowThread):
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::repaintUsingContainer):
* rendering/RenderObject.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::renderFlowThreadWithName):
* rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThreads):

LayoutTests: 

Make regions repaint properly. Added new repaint tests.

Reviewed by Simon Fraser.

* fast/repaint/japanese-rl-selection-repaint-in-regions.html: Added.
* fast/repaint/line-flow-with-floats-in-regions.html: Added.
* fast/repaint/overflow-flipped-writing-mode-block-in-regions.html: Added.
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
* platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
* platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h


Added Paths

trunk/LayoutTests/fast/repaint/japanese-rl-selection-repaint-in-regions.html
trunk/LayoutTests/fast/repaint/line-flow-with-floats-in-regions.html
trunk/LayoutTests/fast/repaint/overflow-flipped-writing-mode-block-in-regions.html
trunk/LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png
trunk/LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt
trunk/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png
trunk/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt
trunk/LayoutTests/platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png
trunk/LayoutTests/platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93143 => 93144)

--- trunk/LayoutTests/ChangeLog	2011-08-16 19:42:07 UTC (rev 93143)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 19:43:21 UTC (rev 93144)
@@ -1,3 +1,21 @@
+2011-08-16  David Hyatt  hy...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=66254
+
+Make regions repaint properly. Added new repaint tests.
+
+Reviewed by Simon Fraser.
+
+* fast/repaint/japanese-rl-selection-repaint-in-regions.html: Added.
+* fast/repaint/line-flow-with-floats-in-regions.html: Added.
+* fast/repaint/overflow-flipped-writing-mode-block-in-regions.html: Added.
+* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
+* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
+* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
+* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
+* platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
+* platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
+
 2011-08-16  Adam Roben  aro...@apple.com
 
 Add Windows expected results for some canvas tests


Added: trunk/LayoutTests/fast/repaint/japanese-rl-selection-repaint-in-regions.html (0 => 93144)

--- trunk/LayoutTests/fast/repaint/japanese-rl-selection-repaint-in-regions.html	(rev 0)
+++ trunk/LayoutTests/fast/repaint/japanese-rl-selection-repaint-in-regions.html	2011-08-16 19:43:21 UTC (rev 93144)
@@ -0,0 +1,31 @@
+!doctype html
+html style=border:10px solid maroon; -webkit-writing-mode:vertical-rl
+head
+meta http-equiv=content-type content=text/html; charset=UTF-8
+script src=""
+script
+function repaintTest()
+{
+if (eventSender) {
+eventSender.mouseMoveTo(660, 300);
+

[webkit-changes] [93145] trunk/Tools

[dino]

Title: [93145] trunk/Tools








Revision 93145
Author d...@apple.com
Date 2011-08-16 12:48:41 -0700 (Tue, 16 Aug 2011)


Log Message
Adding Ted hober O'Connor as a non-committing contributor.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (93144 => 93145)

--- trunk/Tools/ChangeLog	2011-08-16 19:43:21 UTC (rev 93144)
+++ trunk/Tools/ChangeLog	2011-08-16 19:48:41 UTC (rev 93145)
@@ -1,3 +1,9 @@
+2011-08-16  Dean Jackson  d...@apple.com
+
+Adding Ted hober O'Connor as a non-committing contributor.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2011-08-16  Adam Roben  aro...@apple.com
 
 Teach TestFailures how to interpret unfinished test runs


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (93144 => 93145)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-08-16 19:43:21 UTC (rev 93144)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-08-16 19:48:41 UTC (rev 93145)
@@ -78,6 +78,7 @@
 Contributor(David Dorwin, ddor...@chromium.org, ddorwin),
 Contributor(David Grogan, dgro...@chromium.org, dgrogan),
 Contributor(Douglas Davidson, ddavi...@apple.com),
+Contributor(Edward O'Connor, eocon...@apple.com, hober),
 Contributor(Finnur Thorarinsson, fin...@chromium.org, finnur),
 Contributor(Greg Simon, gregsi...@chromium.org, gregsimon),
 Contributor(Gregg Tavares, [g...@google.com, g...@chromium.org], gman),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93146] trunk/Source/WebCore

[aroben]

Title: [93146] trunk/Source/WebCore








Revision 93146
Author aro...@apple.com
Date 2011-08-16 12:50:09 -0700 (Tue, 16 Aug 2011)


Log Message
Make placeholder text remain visible until a character is typed on Windows

Fixes http://webkit.org/b/66319 Placeholder text in text fields disappears when the field
is focused on Windows, which doesn't match Lion or Windows native text fields

Covered by existing tests (which are currently failing on the bots until this patch lands).

Reviewed by Dave Hyatt.

* rendering/RenderThemeSafari.h:
(WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):
* rendering/RenderThemeWin.h:
(WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
Added overrides to return true.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeSafari.h
trunk/Source/WebCore/rendering/RenderThemeWin.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93145 => 93146)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 19:48:41 UTC (rev 93145)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 19:50:09 UTC (rev 93146)
@@ -1,3 +1,20 @@
+2011-08-16  Adam Roben  aro...@apple.com
+
+Make placeholder text remain visible until a character is typed on Windows
+
+Fixes http://webkit.org/b/66319 Placeholder text in text fields disappears when the field
+is focused on Windows, which doesn't match Lion or Windows native text fields
+
+Covered by existing tests (which are currently failing on the bots until this patch lands).
+
+Reviewed by Dave Hyatt.
+
+* rendering/RenderThemeSafari.h:
+(WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):
+* rendering/RenderThemeWin.h:
+(WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):
+Added overrides to return true.
+
 2011-08-16  David Hyatt  hy...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=66254


Modified: trunk/Source/WebCore/rendering/RenderThemeSafari.h (93145 => 93146)

--- trunk/Source/WebCore/rendering/RenderThemeSafari.h	2011-08-16 19:48:41 UTC (rev 93145)
+++ trunk/Source/WebCore/rendering/RenderThemeSafari.h	2011-08-16 19:50:09 UTC (rev 93146)
@@ -138,6 +138,8 @@
 virtual bool paintMediaSliderThumb(RenderObject*, const PaintInfo, const IntRect);
 #endif
 
+virtual bool shouldShowPlaceholderWhenFocused() const { return true; }
+
 private:
 RenderThemeSafari();
 virtual ~RenderThemeSafari();


Modified: trunk/Source/WebCore/rendering/RenderThemeWin.h (93145 => 93146)

--- trunk/Source/WebCore/rendering/RenderThemeWin.h	2011-08-16 19:48:41 UTC (rev 93145)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.h	2011-08-16 19:50:09 UTC (rev 93146)
@@ -144,6 +144,8 @@
 virtual IntPoint volumeSliderOffsetFromMuteButton(RenderBox*, const IntSize) const;
 #endif
 
+virtual bool shouldShowPlaceholderWhenFocused() const { return true; }
+
 private:
 enum ControlSubPart {
 None,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93147] trunk/Source/WebCore

[joepeck]

Title: [93147] trunk/Source/WebCore








Revision 93147
Author joep...@webkit.org
Date 2011-08-16 13:10:08 -0700 (Tue, 16 Aug 2011)


Log Message
Unreviewed Windows and Chromium Windows build fix after r93140.

* platform/graphics/FontCache.h:
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::getLastResortFallbackFontProc):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCache.h
trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp
trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (93146 => 93147)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 19:50:09 UTC (rev 93146)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 20:10:08 UTC (rev 93147)
@@ -1,3 +1,16 @@
+2011-08-16  Joseph Pecoraro  joep...@webkit.org
+
+Unreviewed Windows and Chromium Windows build fix after r93140.
+
+* platform/graphics/FontCache.h:
+* platform/graphics/chromium/FontCacheChromiumWin.cpp:
+(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
+(WebCore::getLastResortFallbackFontProc):
+(WebCore::FontCache::getLastResortFallbackFont):
+* platform/graphics/win/FontCacheWin.cpp:
+(WebCore::FontCache::fontDataFromDescriptionAndLogFont):
+(WebCore::FontCache::getLastResortFallbackFont):
+
 2011-08-16  Adam Roben  aro...@apple.com
 
 Make placeholder text remain visible until a character is typed on Windows


Modified: trunk/Source/WebCore/platform/graphics/FontCache.h (93146 => 93147)

--- trunk/Source/WebCore/platform/graphics/FontCache.h	2011-08-16 19:50:09 UTC (rev 93146)
+++ trunk/Source/WebCore/platform/graphics/FontCache.h	2011-08-16 20:10:08 UTC (rev 93147)
@@ -97,6 +97,14 @@
 size_t inactiveFontDataCount();
 void purgeInactiveFontData(int count = INT_MAX);
 
+#if PLATFORM(WIN)
+#if !PLATFORM(CHROMIUM)
+SimpleFontData* fontDataFromDescriptionAndLogFont(const FontDescription, ShouldRetain, const LOGFONT font, AtomicString outFontFamilyName);
+#else
+SimpleFontData* fontDataFromDescriptionAndLogFont(const FontDescription, ShouldRetain, const LOGFONT font, wchar_t* outFontFamilyName);
+#endif // PLATFORM(CHROMIUM)
+#endif // PLATFORM(WIN)
+
 private:
 FontCache();
 ~FontCache();


Modified: trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp (93146 => 93147)

--- trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp	2011-08-16 19:50:09 UTC (rev 93146)
+++ trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp	2011-08-16 20:10:08 UTC (rev 93147)
@@ -325,9 +325,9 @@
 }
 
 // Tries the given font and save it |outFontFamilyName| if it succeeds.
-static SimpleFontData* fontDataFromDescriptionAndLogFont(FontCache* fontCache, const FontDescription fontDescription, ShouldRetain shouldRetain, const LOGFONT font, wchar_t* outFontFamilyName)
+SimpleFontData* FontCache::fontDataFromDescriptionAndLogFont(const FontDescription fontDescription, ShouldRetain shouldRetain, const LOGFONT font, wchar_t* outFontFamilyName)
 {
-SimpleFontData* fontData = fontCache-getCachedFontData(fontDescription, font.lfFaceName, false, shouldRetain);
+SimpleFontData* fontData = getCachedFontData(fontDescription, font.lfFaceName, false, shouldRetain);
 if (fontData)
 memcpy(outFontFamilyName, font.lfFaceName, sizeof(font.lfFaceName));
 return fontData;
@@ -419,7 +419,7 @@
 static int CALLBACK getLastResortFallbackFontProc(const LOGFONT* logFont, const TEXTMETRIC* metrics, DWORD fontType, LPARAM lParam)
 {
 GetLastResortFallbackFontProcData* procData = reinterpret_castGetLastResortFallbackFontProcData*(lParam);
-procData-m_fontData = fontDataFromDescriptionAndLogFont(procData-m_fontCache, *procData-m_fontDescription, procData-m_shouldRetain, *logFont, procData-m_fontName);
+procData-m_fontData = procData-m_fontCache-fontDataFromDescriptionAndLogFont(*procData-m_fontDescription, procData-m_shouldRetain, *logFont, procData-m_fontName);
 return !procData-m_fontData;
 }
 
@@ -552,7 +552,7 @@
 if (HFONT defaultGUIFont = static_castHFONT(GetStockObject(DEFAULT_GUI_FONT))) {
 LOGFONT defaultGUILogFont;
 GetObject(defaultGUIFont, sizeof(defaultGUILogFont), defaultGUILogFont);
-if (simpleFont = fontDataFromDescriptionAndLogFont(this, description, shouldRetain, defaultGUILogFont, fallbackFontName))
+if (simpleFont = fontDataFromDescriptionAndLogFont(description, shouldRetain, defaultGUILogFont, fallbackFontName))
 return simpleFont;
 }
 
@@ -560,15 +560,15 @@
 NONCLIENTMETRICS nonClientMetrics = {0};
 nonClientMetrics.cbSize = 

[webkit-changes] [93148] trunk/LayoutTests

[eric . carlson]

Title: [93148] trunk/LayoutTests








Revision 93148
Author eric.carl...@apple.com
Date 2011-08-16 13:13:15 -0700 (Tue, 16 Aug 2011)


Log Message
Make video-controls-no-scripting.html results platform independent.

* media/video-controls-no-scripting-expected.txt:
* media/video-controls-no-scripting.html:
* platform/chromium/media/video-controls-no-scripting-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-controls-no-scripting-expected.txt
trunk/LayoutTests/media/video-controls-no-scripting.html


Removed Paths

trunk/LayoutTests/platform/chromium/media/video-controls-no-scripting-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93147 => 93148)

--- trunk/LayoutTests/ChangeLog	2011-08-16 20:10:08 UTC (rev 93147)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 20:13:15 UTC (rev 93148)
@@ -1,3 +1,11 @@
+2011-08-16  Eric Carlson  eric.carl...@apple.com
+
+Make video-controls-no-scripting.html results platform independent.
+
+* media/video-controls-no-scripting-expected.txt:
+* media/video-controls-no-scripting.html:
+* platform/chromium/media/video-controls-no-scripting-expected.txt: Removed.
+
 2011-08-16  David Hyatt  hy...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=66254


Modified: trunk/LayoutTests/media/video-controls-no-scripting-expected.txt (93147 => 93148)

--- trunk/LayoutTests/media/video-controls-no-scripting-expected.txt	2011-08-16 20:10:08 UTC (rev 93147)
+++ trunk/LayoutTests/media/video-controls-no-scripting-expected.txt	2011-08-16 20:13:15 UTC (rev 93148)
@@ -2,7 +2,7 @@
 Tests that the built-in controls are always enabled when _javascript_ is disabled.
 
 EXPECTED (internals.shadowRoot(video) != 'null') OK
-EXPECTED (controls.offsetTop + controls.offsetHeight = '240') OK
+EXPECTED (controls.offsetTop + controls.offsetHeight = 'video.offsetHeight') OK
 EXPECTED (getComputedStyle(controls).opacity == '1') OK
 
 END OF TEST


Modified: trunk/LayoutTests/media/video-controls-no-scripting.html (93147 => 93148)

--- trunk/LayoutTests/media/video-controls-no-scripting.html	2011-08-16 20:10:08 UTC (rev 93147)
+++ trunk/LayoutTests/media/video-controls-no-scripting.html	2011-08-16 20:13:15 UTC (rev 93148)
@@ -13,7 +13,10 @@
 video = document.getElementById(fr).contentDocument.querySelector(video);
 testExpected(internals.shadowRoot(video), null, !=);
 controls =  internals.shadowRoot(video).firstChild.firstChild;
-testExpected(controls.offsetTop + controls.offsetHeight, video.offsetHeight, =);
+
+// Don't use testExpected() for the control location because not all ports use the same size controls.
+reportExpected((controls.offsetTop + controls.offsetHeight) = video.offsetHeight, controls.offsetTop + controls.offsetHeight, =, video.offsetHeight, controls.offsetTop + controls.offsetHeight);
+
 testExpected(getComputedStyle(controls).opacity, 1);
 
 consoleWrite();


Deleted: trunk/LayoutTests/platform/chromium/media/video-controls-no-scripting-expected.txt (93147 => 93148)

--- trunk/LayoutTests/platform/chromium/media/video-controls-no-scripting-expected.txt	2011-08-16 20:10:08 UTC (rev 93147)
+++ trunk/LayoutTests/platform/chromium/media/video-controls-no-scripting-expected.txt	2011-08-16 20:13:15 UTC (rev 93148)
@@ -1,9 +0,0 @@
-
-Tests that the built-in controls are always enabled when _javascript_ is disabled.
-
-EXPECTED (internals.shadowRoot(video) != 'null') OK
-EXPECTED (controls.offsetTop + controls.offsetHeight = '150') OK
-EXPECTED (getComputedStyle(controls).opacity == '1') OK
-
-END OF TEST
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93149] trunk/Source/WebCore

[joepeck]

Title: [93149] trunk/Source/WebCore








Revision 93149
Author joep...@webkit.org
Date 2011-08-16 13:28:38 -0700 (Tue, 16 Aug 2011)


Log Message
Unreviewed Chromium Windows build fix after r93140.

* platform/graphics/FontCache.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93148 => 93149)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 20:13:15 UTC (rev 93148)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 20:28:38 UTC (rev 93149)
@@ -1,5 +1,11 @@
 2011-08-16  Joseph Pecoraro  joep...@webkit.org
 
+Unreviewed Chromium Windows build fix after r93140.
+
+* platform/graphics/FontCache.h:
+
+2011-08-16  Joseph Pecoraro  joep...@webkit.org
+
 Unreviewed Windows and Chromium Windows build fix after r93140.
 
 * platform/graphics/FontCache.h:


Modified: trunk/Source/WebCore/platform/graphics/FontCache.h (93148 => 93149)

--- trunk/Source/WebCore/platform/graphics/FontCache.h	2011-08-16 20:13:15 UTC (rev 93148)
+++ trunk/Source/WebCore/platform/graphics/FontCache.h	2011-08-16 20:28:38 UTC (rev 93149)
@@ -98,12 +98,10 @@
 void purgeInactiveFontData(int count = INT_MAX);
 
 #if PLATFORM(WIN)
-#if !PLATFORM(CHROMIUM)
 SimpleFontData* fontDataFromDescriptionAndLogFont(const FontDescription, ShouldRetain, const LOGFONT font, AtomicString outFontFamilyName);
-#else
+#elif PLATFORM(CHROMIUM)  OS(WINDOWS)
 SimpleFontData* fontDataFromDescriptionAndLogFont(const FontDescription, ShouldRetain, const LOGFONT font, wchar_t* outFontFamilyName);
-#endif // PLATFORM(CHROMIUM)
-#endif // PLATFORM(WIN)
+#endif
 
 private:
 FontCache();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93150] trunk

[commit-queue]

Title: [93150] trunk








Revision 93150
Author commit-qu...@webkit.org
Date 2011-08-16 13:44:51 -0700 (Tue, 16 Aug 2011)


Log Message
Unmatrix algorithm implementation is wrong
https://bugs.webkit.org/show_bug.cgi?id=66080

Patch by Mihnea Ovidenie mih...@adobe.com on 2011-08-16
Reviewed by Dean Jackson.

Source/WebCore:

Current version of the algorithm negates only the scaleX while
it should negate also scaleY and scaleZ when appropriate.

Test: animations/animation-matrix-negative-scale-unmatrix.html

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::decompose):

LayoutTests:

* animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
* animations/animation-matrix-negative-scale-unmatrix.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp


Added Paths

trunk/LayoutTests/animations/animation-matrix-negative-scale-unmatrix-expected.txt
trunk/LayoutTests/animations/animation-matrix-negative-scale-unmatrix.html




Diff

Modified: trunk/LayoutTests/ChangeLog (93149 => 93150)

--- trunk/LayoutTests/ChangeLog	2011-08-16 20:28:38 UTC (rev 93149)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 20:44:51 UTC (rev 93150)
@@ -1,3 +1,13 @@
+2011-08-16  Mihnea Ovidenie  mih...@adobe.com
+
+Unmatrix algorithm implementation is wrong
+https://bugs.webkit.org/show_bug.cgi?id=66080
+
+Reviewed by Dean Jackson.
+
+* animations/animation-matrix-negative-scale-unmatrix-expected.txt: Added.
+* animations/animation-matrix-negative-scale-unmatrix.html: Added.
+
 2011-08-16  Eric Carlson  eric.carl...@apple.com
 
 Make video-controls-no-scripting.html results platform independent.


Added: trunk/LayoutTests/animations/animation-matrix-negative-scale-unmatrix-expected.txt (0 => 93150)

--- trunk/LayoutTests/animations/animation-matrix-negative-scale-unmatrix-expected.txt	(rev 0)
+++ trunk/LayoutTests/animations/animation-matrix-negative-scale-unmatrix-expected.txt	2011-08-16 20:44:51 UTC (rev 93150)
@@ -0,0 +1 @@
+PASS


Added: trunk/LayoutTests/animations/animation-matrix-negative-scale-unmatrix.html (0 => 93150)

--- trunk/LayoutTests/animations/animation-matrix-negative-scale-unmatrix.html	(rev 0)
+++ trunk/LayoutTests/animations/animation-matrix-negative-scale-unmatrix.html	2011-08-16 20:44:51 UTC (rev 93150)
@@ -0,0 +1,61 @@
+!doctype html
+html
+head
+!--
+This test performs an animation of the matrix operator. The matrix is defined so that the
+decomposition (unmatrix) algorithm is tested on the path where the matrix is negated and the
+the scaling factors are also negated.
+The animation is started and a snapshot is taken after start. The d component of matrix
+should be negative.
+--
+style type=text/css media=screen
+#box {
+width: 100px;
+height: 100px;
+background-color: blue;
+-webkit-animation-duration: 1s;
+}
+
+@-webkit-keyframes anim {
+from { -webkit-transform: matrix(1, 0, 0, -1, 0, 0); }
+to { -webkit-transform: matrix(1, 0, 0, 1, 0, 0); }
+}
+/style
+script type=text/_javascript_ charset=utf-8
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+result = PASS;
+
+function snapshot()
+{
+var boxComputedStyle = window.getComputedStyle(document.getElementById('box'));
+var matrix = new WebKitCSSMatrix(boxComputedStyle.webkitTransform);
+
+// d component (scaleY) should be negative.
+if (matrix[d]  0)
+result = FAIL(scaleY was positive, expected to be negative);
+
+document.getElementById('result').innerHTML = result;
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+function startAnimation()
+{
+document.getElementById(box).style.webkitAnimationName = anim;
+}
+
+document.addEventListener('webkitAnimationStart', snapshot, false);
+/script
+/head
+body
+div id=box/div
+div id=result/div
+script
+startAnimation();
+/script
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (93149 => 93150)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 20:28:38 UTC (rev 93149)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 20:44:51 UTC (rev 93150)
@@ -1,3 +1,18 @@
+2011-08-16  Mihnea Ovidenie  mih...@adobe.com
+
+Unmatrix algorithm implementation is wrong
+

[webkit-changes] [93151] trunk/Source/WebCore

[joepeck]

Title: [93151] trunk/Source/WebCore








Revision 93151
Author joep...@webkit.org
Date 2011-08-16 13:47:24 -0700 (Tue, 16 Aug 2011)


Log Message
Unreviewed Chromium Windows build fix after r93140. Take 2.

This just makes the troublesome enum public. If this
fixes the build I will file a follow-up bug to clean-up
these build issues and either keep the enum public and
cleanup other functions or restore the enum to private.
There is no harm in making the enum public right now.

* platform/graphics/FontCache.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93150 => 93151)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 20:44:51 UTC (rev 93150)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 20:47:24 UTC (rev 93151)
@@ -17,10 +17,22 @@
 
 Unreviewed Chromium Windows build fix after r93140.
 
+This just makes the troublesome enum public. If this
+fixes the build I will file a follow-up bug to clean-up
+these build issues and either keep the enum public and
+cleanup other functions or restore the enum to private.
+There is no harm in making the enum public right now.
+
 * platform/graphics/FontCache.h:
 
 2011-08-16  Joseph Pecoraro  joep...@webkit.org
 
+Unreviewed Chromium Windows build fix after r93140.
+
+* platform/graphics/FontCache.h:
+
+2011-08-16  Joseph Pecoraro  joep...@webkit.org
+
 Unreviewed Windows and Chromium Windows build fix after r93140.
 
 * platform/graphics/FontCache.h:


Modified: trunk/Source/WebCore/platform/graphics/FontCache.h (93150 => 93151)

--- trunk/Source/WebCore/platform/graphics/FontCache.h	2011-08-16 20:44:51 UTC (rev 93150)
+++ trunk/Source/WebCore/platform/graphics/FontCache.h	2011-08-16 20:47:24 UTC (rev 93151)
@@ -53,12 +53,12 @@
 class FontCache {
 friend class FontCachePurgePreventer;
 
-enum ShouldRetain { Retain, DoNotRetain };
-
 WTF_MAKE_NONCOPYABLE(FontCache); WTF_MAKE_FAST_ALLOCATED;
 public:
 friend FontCache* fontCache();
 
+enum ShouldRetain { Retain, DoNotRetain };
+
 const FontData* getFontData(const Font, int familyIndex, FontSelector*);
 void releaseFontData(const SimpleFontData*);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93152] trunk/Tools

[dglazkov]

Title: [93152] trunk/Tools








Revision 93152
Author dglaz...@chromium.org
Date 2011-08-16 13:57:28 -0700 (Tue, 16 Aug 2011)


Log Message
garden-o-matic needs a summary view with actions for each problem.
https://bugs.webkit.org/show_bug.cgi?id=66144

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html
trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html (93151 => 93152)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html	2011-08-16 20:47:24 UTC (rev 93151)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html	2011-08-16 20:57:28 UTC (rev 93152)
@@ -56,6 +56,8 @@
 script src=""
 script src=""
 script src=""
+script src=""
+script src=""
 
 !-- FIXME: We should have tests for these files! --
 script src=""


Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js (0 => 93152)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js	2011-08-16 20:57:28 UTC (rev 93152)
@@ -0,0 +1,69 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+(function() {
+
+var g_actions = new ui.notifications.Stream();
+var g_info = new ui.notifications.Stream();
+
+var g_updateTimerId = 0;
+var g_testFailures = new base.UpdateTracker();
+
+function update()
+{
+// FIXME: This should be a button with a progress element.
+var updating = new ui.notifications.Info(Updating ...);
+g_info.push(updating);
+
+// FIXME: Also provide information on bot failures.
+base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
+model.analyzeUnexpectedFailures(function(failureAnalysis) {
+var key = failureAnalysis.newestPassingRevision + + + failureAnalysis.oldestFailingRevision;
+var failure = g_testFailures.get(key);
+if (!failure) {
+failure = 

[webkit-changes] [93153] trunk/LayoutTests

[tony]

Title: [93153] trunk/LayoutTests








Revision 93153
Author t...@chromium.org
Date 2011-08-16 14:01:19 -0700 (Tue, 16 Aug 2011)


Log Message
[chromium] Mark new tests as failing.  Will pull results from the
bots when they cycle.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93152 => 93153)

--- trunk/LayoutTests/ChangeLog	2011-08-16 20:57:28 UTC (rev 93152)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 21:01:19 UTC (rev 93153)
@@ -1,3 +1,10 @@
+2011-08-16  Tony Chang  t...@chromium.org
+
+[chromium] Mark new tests as failing.  Will pull results from the
+bots when they cycle.
+
+* platform/chromium/test_expectations.txt:
+
 2011-08-16  Mihnea Ovidenie  mih...@adobe.com
 
 Unmatrix algorithm implementation is wrong


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93152 => 93153)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 20:57:28 UTC (rev 93152)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 21:01:19 UTC (rev 93153)
@@ -3678,3 +3678,8 @@
 BUGCR93044 LINUX DEBUG : fast/canvas/webgl/uninitialized-test.html = TIMEOUT
 
 BUGWK66310 DEBUG : media/video-source-error.html = PASS TEXT
+
+// Three new tests in r93144.  Probably just needs new baselines.
+BUGTONY : fast/repaint/japanese-rl-selection-repaint-in-regions.html = IMAGE+TEXT IMAGE
+BUGTONY : fast/repaint/overflow-flipped-writing-mode-block-in-regions.html = IMAGE
+BUGTONY : fast/repaint/line-flow-with-floats-in-regions.html = IMAGE+TEXT IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93154] trunk/LayoutTests

[tony]

Title: [93154] trunk/LayoutTests








Revision 93154
Author t...@chromium.org
Date 2011-08-16 14:12:10 -0700 (Tue, 16 Aug 2011)


Log Message
[chromium] fast/css/custom-font-xheight.html is hitting an assert
in debug on Linux.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93153 => 93154)

--- trunk/LayoutTests/ChangeLog	2011-08-16 21:01:19 UTC (rev 93153)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 21:12:10 UTC (rev 93154)
@@ -1,5 +1,12 @@
 2011-08-16  Tony Chang  t...@chromium.org
 
+[chromium] fast/css/custom-font-xheight.html is hitting an assert
+in debug on Linux.
+
+* platform/chromium/test_expectations.txt:
+
+2011-08-16  Tony Chang  t...@chromium.org
+
 [chromium] Mark new tests as failing.  Will pull results from the
 bots when they cycle.
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93153 => 93154)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 21:01:19 UTC (rev 93153)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 21:12:10 UTC (rev 93154)
@@ -3683,3 +3683,5 @@
 BUGTONY : fast/repaint/japanese-rl-selection-repaint-in-regions.html = IMAGE+TEXT IMAGE
 BUGTONY : fast/repaint/overflow-flipped-writing-mode-block-in-regions.html = IMAGE
 BUGTONY : fast/repaint/line-flow-with-floats-in-regions.html = IMAGE+TEXT IMAGE
+
+BUGWK66328 LINUX DEBUG : fast/css/custom-font-xheight.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93155] trunk/Tools

[aroben]

Title: [93155] trunk/Tools








Revision 93155
Author aro...@apple.com
Date 2011-08-16 14:12:44 -0700 (Tue, 16 Aug 2011)


Log Message
Teach TestFailures that tests that have failed or passed many times in a row are not flaky

The basic strategy here is that once a test has failed or passed many times in a row we
never again consider it as a possibly flaky test. It's a simple strategy but seems to result
in many fewer false positives than our current behavior.

Fixes http://webkit.org/b/66327 TestFailures page considers far too many tests to be
flaky, including tests that failed for a while but then were fixed

Reviewed by Dan Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
(FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
number of non-too-many-failure builds we've seen.
(FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
tests, keep track of how many times they have passed or failed in a row. If they pass or
fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
considered flaky it doesn't matter how many times it passes or fails.)

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
Added tests for the above.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js (93154 => 93155)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js	2011-08-16 21:12:10 UTC (rev 93154)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js	2011-08-16 21:12:44 UTC (rev 93155)
@@ -25,6 +25,7 @@
 
 function FlakyLayoutTestDetector() {
 this._tests = {};
+this._buildCount = 0;
 }
 
 FlakyLayoutTestDetector.prototype = {
@@ -37,11 +38,20 @@
 return newFlakyTests;
 }
 
+++this._buildCount;
+
 // Record failing tests.
 for (var testName in failingTests) {
 if (!(testName in this._tests)) {
+   if (this._buildCount  this._maximumFailOrPassCount) {
+   // This test hasn't failed in the _maximumFailOrPassCount most recent builds, so
+   // don't consider it to be flaky. In fact, we don't have to track it at all!
+   continue;
+   }
+
 this._tests[testName] = {
 state: this._states.LastSeenFailing,
+count: 0,
 history: [],
 };
 }
@@ -49,7 +59,11 @@
 var testData = this._tests[testName];
 testData.history.push({ build: buildName, result: failingTests[testName] });
 
-if (testData.state === this._states.LastSeenPassing) {
+if (testData.state === this._states.LastSeenFailing) {
+++testData.count;
+if (testData.count  this._maximumFailOrPassCount)
+testData.state = this._states.NotFlaky;
+} else if (testData.state === this._states.LastSeenPassing) {
 testData.state = this._states.PossiblyFlaky;
 newFlakyTests.push(testName);
 }
@@ -63,8 +77,14 @@
 var testData = this._tests[testName];
 testData.history.push({ build: buildName, result: { failureType: 'pass' } });
 
-if (testData.state === this._states.LastSeenFailing)
+if (testData.state === this._states.LastSeenPassing) {
+++testData.count;
+if (testData.count  this._maximumFailOrPassCount)
+testData.state = this._states.NotFlaky;
+} else if (testData.state === this._states.LastSeenFailing) {
 testData.state = this._states.LastSeenPassing;
+testData.count = 1;
+}
 }
 
 return newFlakyTests;
@@ -82,9 +102,14 @@
 return Object.keys(self._tests).filter(function(testName) { return self._tests[testName].state === self._states.PossiblyFlaky });
 },
 
+// If a test has recently failed or passed more than this number of times in a row we don't
+// consider it to be flaky.
+_maximumFailOrPassCount: 9,
+
 _states: {
 LastSeenFailing: 0,
 LastSeenPassing: 1,
 PossiblyFlaky: 2,
+NotFlaky: 3,
 },
 };


Modified: 

[webkit-changes] [93156] trunk/Source/WebCore

[joepeck]

Title: [93156] trunk/Source/WebCore








Revision 93156
Author joep...@webkit.org
Date 2011-08-16 14:19:11 -0700 (Tue, 16 Aug 2011)


Log Message
Unreviewed Chromium Windows build fix after r93140. Take 3.

Include the proper includes!

* platform/graphics/FontCache.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93155 => 93156)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 21:12:44 UTC (rev 93155)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 21:19:11 UTC (rev 93156)
@@ -1,3 +1,10 @@
+2011-08-16  Joseph Pecoraro  joep...@webkit.org
+
+Unreviewed Chromium Windows build fix after r93140. Take 3.
+Include the proper includes!
+
+* platform/graphics/FontCache.h:
+
 2011-08-16  Mihnea Ovidenie  mih...@adobe.com
 
 Unmatrix algorithm implementation is wrong


Modified: trunk/Source/WebCore/platform/graphics/FontCache.h (93155 => 93156)

--- trunk/Source/WebCore/platform/graphics/FontCache.h	2011-08-16 21:12:44 UTC (rev 93155)
+++ trunk/Source/WebCore/platform/graphics/FontCache.h	2011-08-16 21:19:11 UTC (rev 93156)
@@ -35,7 +35,8 @@
 #include wtf/Vector.h
 #include wtf/unicode/Unicode.h
 
-#if PLATFORM(WIN)
+#if OS(WINDOWS)
+#include windows.h
 #include objidl.h
 #include mlang.h
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93157] trunk/Source/WebCore

[senorblanco]

Title: [93157] trunk/Source/WebCore








Revision 93157
Author senorbla...@chromium.org
Date 2011-08-16 14:32:39 -0700 (Tue, 16 Aug 2011)


Log Message
Canvas resizing can be slow
https://bugs.webkit.org/show_bug.cgi?id=66251

Canvas resizing was slow due to re-allocation of the ImageBuffer on
each size change (width or height).  This was introduced inadvertently
by calls to isAccelerated() during canvas reset().  Since we won't 
know if we have successfully accelerated until ImageBuffer creation,
move the compositor invalidation to createImageBuffer() as well.
This patch also attempts to unify the Skia and CG accelerated canvas
paths.  The DrawingBuffer used by the Skia path is now owned by 
ImageBuffer[Skia], similar to how the IOSurface is owned by
ImageBuffer[CG].  Some of the logic for when to accelerate was moved
into HTMLCanvasElement and unified with the CG path.  Acceleration is
also now enabled by the same Accelerated ImageBuffer create flag
used by the CG path.  DrawingBuffer is now re-created even for a 
same-size change (same as the memory buffer), but we speed it up
by calling GraphicsContext3D::texImage2D() with a NULL pixels ptr
instead of GraphicsContext3D::teximage2DResourceSafe() (no need to
clear it, since it's done with a glClear anyway).

Reviewed by Kenneth Russell.

Covered by existing tests in fast/canvas and canvas/philip.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
Don't call isAccelerated() from reset(), since we don't want to
inadvertently create the ImageBuffer.  Also, since we won't know if
we have successfully accelerated until createImageBuffer() is
called, defer the compositor invalidation to createImageBuffer() as
well.
(WebCore::HTMLCanvasElement::shouldAccelerate):
Unify the CG and Skia ports' logic for when to accelerate (Skia
logic moved in from CanvasRenderingContext2D).
(WebCore::HTMLCanvasElement::createImageBuffer):
Use the unified shouldAccelerate() logic, and pass it as a flag
to ImageBuffer.  Do compositor invalidation as well.
* html/HTMLCanvasElement.h:
(WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
Expose hasCreatedImageBuffer() publically, so
CanvasRenderingContext2D::isAccelerated() doesn't inadvertently create
it.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
Remove all acceleration setting and resetting, since it's now done
during ImageBuffer creation.
(WebCore::CanvasRenderingContext2D::isAccelerated):
Check if the image buffer was created, so we don't inadvertently
create it here.
(WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):
Don't call GraphicsContext3D::paintsIntoCanvasBuffer(), since its
WebViewImpl may be null.  Ask the render tree instead.
(WebCore::CanvasRenderingContext2D::reset):
Don't reset acceleration here, since we don't own it anymore.
(WebCore::CanvasRenderingContext2D::platformLayer):
Call into the ImageBuffer to get our PlatformLayer.
* html/canvas/CanvasRenderingContext2D.h:
Remove m_drawingBuffer, and all acceleration-related calls.
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/GraphicsContext.h:
Remove setGraphicsContext3D(), and paintsIntoImageBuffer().
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::platformLayer):
Implement a dummy platformLayer() call for non-skia ports.
* platform/graphics/ImageBuffer.h:
Declare a platformLayer() call (USE(ACCELERATED_COMPOSITING) only).
* platform/graphics/chromium/ImageBufferDataSkia.h:
Add a DrawingBuffer data member.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::reset):
Use texImage2D() with a NULL ptr, not texImage2DResourceSafe().
Since we immediately clear the framebuffer via glClear(), this whole
resource safe business is overkill.
* platform/graphics/skia/GraphicsContextSkia.cpp:
Remove setGraphicsContext3D() and paintsIntoImageBuffer().  This
functionality is handled by ImageBuffer now.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
Give the ImageBufferData ownership of the DrawingBuffer.
(WebCore::ImageBuffer::platformLayer):
Implement an accessor for the DrawingBuffer's PlatformLayer.
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setGraphicsContext3D):
* platform/graphics/skia/PlatformContextSkia.h:
Remove isPathSkiaSafe() extern (unused).
Remove paintsIntoImageBuffer() (now unused).  Remove IntSize param
from setGraphicsContext3D() (unused).

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCanvasElement.cpp
trunk/Source/WebCore/html/HTMLCanvasElement.h
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/ImageBuffer.cpp

[webkit-changes] [93158] trunk/LayoutTests

[aroben]

Title: [93158] trunk/LayoutTests








Revision 93158
Author aro...@apple.com
Date 2011-08-16 14:32:48 -0700 (Tue, 16 Aug 2011)


Log Message
Skip another test that relies on eventSender.scalePageBy on Windows

* platform/win/Skipped: Added fast/repaint/background-scaling.html.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (93157 => 93158)

--- trunk/LayoutTests/ChangeLog	2011-08-16 21:32:39 UTC (rev 93157)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 21:32:48 UTC (rev 93158)
@@ -1,3 +1,9 @@
+2011-08-16  Adam Roben  aro...@apple.com
+
+Skip another test that relies on eventSender.scalePageBy on Windows
+
+* platform/win/Skipped: Added fast/repaint/background-scaling.html.
+
 2011-08-16  Tony Chang  t...@chromium.org
 
 [chromium] fast/css/custom-font-xheight.html is hitting an assert


Modified: trunk/LayoutTests/platform/win/Skipped (93157 => 93158)

--- trunk/LayoutTests/platform/win/Skipped	2011-08-16 21:32:39 UTC (rev 93157)
+++ trunk/LayoutTests/platform/win/Skipped	2011-08-16 21:32:48 UTC (rev 93158)
@@ -1297,6 +1297,7 @@
 fast/dom/Element/scale-page-client-rects.html
 fast/dom/Range/scale-page-bounding-client-rect.html
 fast/dom/Range/scale-page-client-rects.html
+fast/repaint/background-scaling.html
 fast/repaint/scale-page-shrink.html
 fast/transforms/selection-bounds-in-transformed-view.html
 fast/events/scroll-in-scaled-page-with-overflow-hidden.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93159] trunk/LayoutTests

[aroben]

Title: [93159] trunk/LayoutTests








Revision 93159
Author aro...@apple.com
Date 2011-08-16 14:35:05 -0700 (Tue, 16 Aug 2011)


Log Message
Add Windows results for overlapped-iframe-iframe.html

The Windows results match the cross-platform results, not the Mac results.

* platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt: Copied from compositing/iframes/overlapped-iframe-iframe-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93158 => 93159)

--- trunk/LayoutTests/ChangeLog	2011-08-16 21:32:48 UTC (rev 93158)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 21:35:05 UTC (rev 93159)
@@ -1,5 +1,13 @@
 2011-08-16  Adam Roben  aro...@apple.com
 
+Add Windows results for overlapped-iframe-iframe.html
+
+The Windows results match the cross-platform results, not the Mac results.
+
+* platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt: Copied from compositing/iframes/overlapped-iframe-iframe-expected.txt.
+
+2011-08-16  Adam Roben  aro...@apple.com
+
 Skip another test that relies on eventSender.scalePageBy on Windows
 
 * platform/win/Skipped: Added fast/repaint/background-scaling.html.


Added: trunk/LayoutTests/platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt (0 => 93159)

--- trunk/LayoutTests/platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt	2011-08-16 21:35:05 UTC (rev 93159)
@@ -0,0 +1,52 @@
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (children 1
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (children 2
+(GraphicsLayer
+  (bounds 304.00 304.00)
+  (drawsContent 1)
+  (children 1
+(GraphicsLayer
+  (position 2.00 2.00)
+  (children 1
+(GraphicsLayer
+  (bounds 300.00 300.00)
+  (children 1
+(GraphicsLayer
+  (children 1
+(GraphicsLayer
+  (bounds 300.00 300.00)
+  (children 1
+(GraphicsLayer
+  (bounds 300.00 300.00)
+  (drawsContent 1)
+  (children 1
+(GraphicsLayer
+  (position 18.00 10.00)
+  (bounds 210.00 210.00)
+  (drawsContent 1)
+)
+  )
+)
+  )
+)
+  )
+)
+  )
+)
+  )
+)
+  )
+)
+(GraphicsLayer
+  (position 250.00 0.00)
+  (bounds 304.00 304.00)
+  (drawsContent 1)
+)
+  )
+)
+  )
+)
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93160] trunk/Source/WebCore

[joepeck]

Title: [93160] trunk/Source/WebCore








Revision 93160
Author joep...@webkit.org
Date 2011-08-16 14:39:32 -0700 (Tue, 16 Aug 2011)


Log Message
Unreviewed Chromium Windows build fix after r93140. Take 4.

Namespace the now public enum as FontCache::ShouldRetain.

* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (93159 => 93160)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 21:35:05 UTC (rev 93159)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 21:39:32 UTC (rev 93160)
@@ -1,3 +1,11 @@
+2011-08-16  Joseph Pecoraro  joep...@webkit.org
+
+Unreviewed Chromium Windows build fix after r93140. Take 4.
+Namespace the now public enum as FontCache::ShouldRetain.
+
+* platform/graphics/chromium/FontCacheChromiumWin.cpp:
+(WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):
+
 2011-08-15  Stephen White  senorbla...@chromium.org
 
 Canvas resizing can be slow


Modified: trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp (93159 => 93160)

--- trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp	2011-08-16 21:35:05 UTC (rev 93159)
+++ trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp	2011-08-16 21:39:32 UTC (rev 93160)
@@ -400,7 +400,7 @@
 }
 
 struct GetLastResortFallbackFontProcData {
-GetLastResortFallbackFontProcData(FontCache* fontCache, const FontDescription* fontDescription, ShouldRetain shouldRetain, wchar_t* fontName)
+GetLastResortFallbackFontProcData(FontCache* fontCache, const FontDescription* fontDescription, FontCache::ShouldRetain shouldRetain, wchar_t* fontName)
 : m_fontCache(fontCache)
 , m_fontDescription(fontDescription)
 , m_shouldRetain(shouldRetain)
@@ -411,7 +411,7 @@
 
 FontCache* m_fontCache;
 const FontDescription* m_fontDescription;
-ShouldRetain m_shouldRetain;
+FontCache::ShouldRetain m_shouldRetain;
 wchar_t* m_fontName;
 SimpleFontData* m_fontData;
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93161] trunk/Tools

[dglazkov]

Title: [93161] trunk/Tools








Revision 93161
Author dglaz...@chromium.org
Date 2011-08-16 14:55:42 -0700 (Tue, 16 Aug 2011)


Log Message
Summary view should not add multiple entries for the same test failure.
https://bugs.webkit.org/show_bug.cgi?id=66318

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js (93160 => 93161)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js	2011-08-16 21:39:32 UTC (rev 93160)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js	2011-08-16 21:55:42 UTC (rev 93161)
@@ -63,6 +63,12 @@
 g_updateTimerId = window.setInterval(update, config.kUpdateFrequency);
 document.body.insertBefore(g_actions, document.body.firstChild);
 document.body.insertBefore(g_info, document.body.firstChild);
+var button = document.body.insertBefore(document.createElement(button), document.body.firstChild);
+button.addEventListener(click, function()
+{
+update();
+}, false);
+button.textContent = 'update';
 update();
 });
 


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (93160 => 93161)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js	2011-08-16 21:39:32 UTC (rev 93160)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js	2011-08-16 21:55:42 UTC (rev 93161)
@@ -82,6 +82,10 @@
 {
 // FIXME: Show type of failure and where it's failing.
 this.textContent = failureAnalysis.testName;
+},
+equals: function(failureAnalysis)
+{
+return this.textContent == failureAnalysis.testName;
 }
 })
 
@@ -121,11 +125,18 @@
 this._causes = problem.appendChild(document.createElement('ul'));
 this._causes.className = 'causes';
 },
+containsFailureAnalysis: function(failureAnalysis)
+{
+return Array.prototype.some.call(this._tests.children, function(child) {
+return child.equals(failureAnalysis);
+});
+},
 addFailureAnalysis: function(failureAnalysis)
 {
-// FIXME: Add in order.
-// FIXME: Don't add more than once.
+if (this.containsFailureAnalysis(failureAnalysis))
+return;
 // FIXME: Retrieve date from failureAnalysis and set this._time.
+// FIXME: Add in order by time.
 return this._tests.appendChild(new ui.notifications.FailingTest(failureAnalysis));
 },
 addCommitData: function(commitData)


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (93160 => 93161)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js	2011-08-16 21:39:32 UTC (rev 93160)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js	2011-08-16 21:55:42 UTC (rev 93161)
@@ -46,10 +46,12 @@
 ok(info.dismiss);
 });
 
-test('ui.notifications.FailingTest', 2, function() {
+test('ui.notifications.FailingTest', 4, function() {
 var failingTest = new ui.notifications.FailingTest({testName: 'test'});
 equal(failingTest.tagName, 'LI');
 equal(failingTest.innerHTML, 'test');
+ok(failingTest.equals({testName: 'test'}));
+ok(!failingTest.equals({testName: 'foo'}));
 });
 
 test('ui.notifications.SuspiciousCommit', 2, function() {
@@ -58,12 +60,16 @@
 equal(suspiciousCommit.innerHTML, 'div class=descriptiona href="" author (reviewer)/divul class=actionslibuttonRoll out/button/li/ul');
 });
 
-test('ui.notifications.TestFailures', 4, function() {
+test('ui.notifications.TestFailures', 7, function() {
 var testFailures = new ui.notifications.TestFailures();
 equal(testFailures.tagName, 'LI');
 equal(testFailures.innerHTML, 'timeJust Now/timediv class=whatdiv class=problemul 

[webkit-changes] [93162] trunk/LayoutTests

[aroben]

Title: [93162] trunk/LayoutTests








Revision 93162
Author aro...@apple.com
Date 2011-08-16 15:01:52 -0700 (Tue, 16 Aug 2011)


Log Message
Add Windows results for scripts-panel.html

The Windows results match the cross-platform results, not the Mac results.

* platform/win/inspector/debugger/scripts-panel-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/win/inspector/debugger/
trunk/LayoutTests/platform/win/inspector/debugger/scripts-panel-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93161 => 93162)

--- trunk/LayoutTests/ChangeLog	2011-08-16 21:55:42 UTC (rev 93161)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 22:01:52 UTC (rev 93162)
@@ -1,5 +1,13 @@
 2011-08-16  Adam Roben  aro...@apple.com
 
+Add Windows results for scripts-panel.html
+
+The Windows results match the cross-platform results, not the Mac results.
+
+* platform/win/inspector/debugger/scripts-panel-expected.txt: Added.
+
+2011-08-16  Adam Roben  aro...@apple.com
+
 Add Windows results for overlapped-iframe-iframe.html
 
 The Windows results match the cross-platform results, not the Mac results.


Added: trunk/LayoutTests/platform/win/inspector/debugger/scripts-panel-expected.txt (0 => 93162)

--- trunk/LayoutTests/platform/win/inspector/debugger/scripts-panel-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/win/inspector/debugger/scripts-panel-expected.txt	2011-08-16 22:01:52 UTC (rev 93162)
@@ -0,0 +1,38 @@
+Tests that scripts panel UI elements work as intended.
+
+
+Running: testInitialLoad
+Source requested for foo.js
+Dump files select:
+bar.js
+baz.js
+foo.js
+Source requested for baz.js
+
+Running: testHistory
+Source requested for index.html
+Source requested for script1.js
+Source requested for script2.js
+Source requested for script3.js
+
+Running: testFilesSelect
+?a=b(?a=b)
+...oong_url(very_long_url)
+— example.com —
+?a=b(http://example.com/?a=b)
+— localhost —
+LayoutTests/inspector/debugger/foo/bar
+script.js(root/foo/bar/script.js)
+script.js?a=1(root/foo/bar/script.js?a=1)
+script.js?a=2(root/foo/bar/script.js?a=2)
+LayoutTests/inspector/debugger/foo/baz
+script.js(root/foo/baz/script.js)
+— Content scripts —
+contentScript.js?a=1(root/foo/bar/contentScript.js?a=1)
+contentScript.js?a=2(root/foo/bar/contentScript.js?a=2)
+contentScript2.js?a=1(root/foo/bar/contentScript2.js?a=1)
+
+Running: testSourceReplaced
+Source requested for foo.js
+Source requested for bar.js
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93163] trunk/Tools

[dglazkov]

Title: [93163] trunk/Tools








Revision 93163
Author dglaz...@chromium.org
Date 2011-08-16 15:07:41 -0700 (Tue, 16 Aug 2011)


Log Message
garden-o-matic frontend needs a friendly relative time description method.
https://bugs.webkit.org/show_bug.cgi?id=66324

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js (93162 => 93163)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js	2011-08-16 22:01:52 UTC (rev 93162)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js	2011-08-16 22:07:41 UTC (rev 93163)
@@ -300,4 +300,53 @@
 return extended;
 }
 
+function createRelativeTimeDescriptor(divisorInMilliseconds, unit)
+{
+return function(delta) {
+var deltaInUnits = delta / divisorInMilliseconds;
+return (deltaInUnits).toFixed(0) + ' ' + unit + (deltaInUnits = 2 ? 's' : '') + ' ago';
+}
+}
+
+var kMinuteInMilliseconds = 60 * 1000;
+var kRelativeTimeSlots = [
+{
+maxMilliseconds: kMinuteInMilliseconds,
+describe: function(delta) { return 'Just now'; }
+},
+{
+maxMilliseconds: 60 * kMinuteInMilliseconds,
+describe: createRelativeTimeDescriptor(kMinuteInMilliseconds, 'minute')
+},
+{
+maxMilliseconds: 24 * 60 * kMinuteInMilliseconds,
+describe: createRelativeTimeDescriptor(60 * kMinuteInMilliseconds, 'hour')
+},
+{
+maxMilliseconds: Number.MAX_VALUE,
+describe: createRelativeTimeDescriptor(24 * 60 * kMinuteInMilliseconds, 'day')
+}
+];
+
+/*
+Represent time as descriptive text, relative to now and gradually decreasing in precision:
+delta  1 minutes = Just Now
+delta  60 minutes = X minute[s] ago
+delta  24 hours = X hour[s] ago
+delta  inf = X day[s] ago
+*/
+base.relativizeTime = function(time)
+{
+var result;
+var delta = new Date().getTime() - time;
+kRelativeTimeSlots.some(function(slot) {
+if (delta = slot.maxMilliseconds)
+return false;
+
+result = slot.describe(delta);
+return true;
+});
+return result;
+}
+
 })();


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js (93162 => 93163)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js	2011-08-16 22:01:52 UTC (rev 93162)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js	2011-08-16 22:07:41 UTC (rev 93163)
@@ -372,4 +372,29 @@
 document.body.removeChild(document.body.lastChild);
 });
 
+test(relativizeTime, 11, function() {
+var time = new Date();
+equals(base.relativizeTime(time), Just now);
+time.setMinutes(time.getMinutes() - 1);
+equals(base.relativizeTime(time), 1 minute ago);
+time.setMinutes(time.getMinutes() - 1);
+equals(base.relativizeTime(time), 2 minutes ago);
+time.setMinutes(time.getMinutes() - 1);
+equals(base.relativizeTime(time), 3 minutes ago);
+time.setMinutes(time.getMinutes() - 56);
+equals(base.relativizeTime(time), 59 minutes ago);
+time.setMinutes(time.getMinutes() - 1);
+equals(base.relativizeTime(time), 1 hour ago);
+time.setHours(time.getHours() - 1);
+equals(base.relativizeTime(time), 2 hours ago);
+time.setHours(time.getHours() - 21);
+equals(base.relativizeTime(time), 23 hours ago);
+time.setHours(time.getHours() - 1);
+equals(base.relativizeTime(time), 1 day ago);
+time.setDate(time.getDate() - 1);
+equals(base.relativizeTime(time), 2 days ago);
+time.setTime(0);
+equals(base.relativizeTime(time), 15203 days ago);
+})
+
 })();


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (93162 => 93163)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js	2011-08-16 22:01:52 UTC (rev 93162)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js	2011-08-16 22:07:41 

[webkit-changes] [93168] trunk/LayoutTests/platform

[abarth]

Title: [93168] trunk/LayoutTests/platform








Revision 93168
Author aba...@webkit.org
Date 2011-08-16 15:21:12 -0700 (Tue, 16 Aug 2011)


Log Message
This patch prepares for chromium-mac to mean Skia instead of CoreGraphics.

Added Paths

trunk/LayoutTests/platform/chromium-cg-mac-leopard/


Removed Paths

trunk/LayoutTests/platform/chromium-mac-leopard/




Diff

Property changes: trunk/LayoutTests/platform/chromium-cg-mac-leopard



Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93170] trunk/LayoutTests

[rniwa]

Title: [93170] trunk/LayoutTests








Revision 93170
Author rn...@webkit.org
Date 2011-08-16 15:35:03 -0700 (Tue, 16 Aug 2011)


Log Message
Skip tests modified by r93134 on WebKit2 since they now sets editing behavior explicitly,
which WebKitTestRunner does not support yet.

* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (93169 => 93170)

--- trunk/LayoutTests/ChangeLog	2011-08-16 22:25:14 UTC (rev 93169)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 22:35:03 UTC (rev 93170)
@@ -1,3 +1,10 @@
+2011-08-16  Ryosuke Niwa  rn...@webkit.org
+
+Skip tests modified by r93134 on WebKit2 since they now sets editing behavior explicitly,
+which WebKitTestRunner does not support yet.
+
+* platform/wk2/Skipped:
+
 2011-08-16  Tony Chang  t...@chromium.org
 
 [chromium] fast/css/custom-font-xheight.html is asserting on all


Modified: trunk/LayoutTests/platform/wk2/Skipped (93169 => 93170)

--- trunk/LayoutTests/platform/wk2/Skipped	2011-08-16 22:25:14 UTC (rev 93169)
+++ trunk/LayoutTests/platform/wk2/Skipped	2011-08-16 22:35:03 UTC (rev 93170)
@@ -1425,6 +1425,9 @@
 editing/style/iframe-onload-crash-win.html
 fast/events/backspace-navigates-back.html
 fast/forms/selection-direction.html
+editing/deleting/paragraph-in-preserveNewline.html
+editing/deleting/whitespace-pre-1.html
+editing/selection/programmatic-selection-on-mac-is-directionless.html
 
 # WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
 # https://bugs.webkit.org/show_bug.cgi?id=42691






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93171] trunk

[joepeck]

Title: [93171] trunk








Revision 93171
Author joep...@webkit.org
Date 2011-08-16 15:58:26 -0700 (Tue, 16 Aug 2011)


Log Message
http://webkit.org/b/66328 ASSERT in fast/css/custom-font-xheight.html

Reviewed by Dan Bernstein.

In r93140 the temporary font created for a remote CSS font face
was created without being retained. We need to protect the
font from being purged while we hold onto it, so add a font cache
purge preventer.

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):

* platform/chromium/test_expectations.txt:
Unskipped.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceSource.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (93170 => 93171)

--- trunk/LayoutTests/ChangeLog	2011-08-16 22:35:03 UTC (rev 93170)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 22:58:26 UTC (rev 93171)
@@ -1,3 +1,13 @@
+2011-08-16  Joseph Pecoraro  joep...@webkit.org
+
+Unreviewed, unskipping the test.
+
+ASSERT in fast/css/custom-font-xheight.html
+https://bugs.webkit.org/show_bug.cgi?id=66328
+
+* platform/chromium/test_expectations.txt:
+Test should no longer ASSERT.
+
 2011-08-16  Ryosuke Niwa  rn...@webkit.org
 
 Skip tests modified by r93134 on WebKit2 since they now sets editing behavior explicitly,


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93170 => 93171)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 22:35:03 UTC (rev 93170)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-16 22:58:26 UTC (rev 93171)
@@ -3384,7 +3384,7 @@
 BUGCR83499 : fast/box-shadow/scaled-box-shadow.html = PASS IMAGE+TEXT IMAGE
 BUGCR83499 MAC : fast/box-shadow/box-shadow-transformed.html = PASS IMAGE+TEXT IMAGE
 
-BUGCR83504 WIN RELEASE : fast/css/custom-font-xheight.html = PASS TIMEOUT
+BUGCR83504 WIN : fast/css/custom-font-xheight.html = PASS TIMEOUT
 
 // New test from WK r87026
 BUGCR83555 LINUX WIN : fast/block/positioning/058.html = IMAGE+TEXT
@@ -3683,9 +3683,5 @@
 BUGTONY : fast/repaint/overflow-flipped-writing-mode-block-in-regions.html = IMAGE
 BUGTONY : fast/repaint/line-flow-with-floats-in-regions.html = IMAGE+TEXT IMAGE
 
-// When removing, make sure to update the WIN line to apply to debug and
-// release.
-BUGWK66328 DEBUG : fast/css/custom-font-xheight.html = CRASH
-
 BUGWK66338 MAC : fast/repaint/background-scaling.html = IMAGE
 BUGWK66338 MAC : fast/repaint/scale-page-shrink.html = IMAGE


Modified: trunk/Source/WebCore/ChangeLog (93170 => 93171)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 22:35:03 UTC (rev 93170)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 22:58:26 UTC (rev 93171)
@@ -1,5 +1,20 @@
 2011-08-16  Joseph Pecoraro  joep...@webkit.org
 
+ASSERT in fast/css/custom-font-xheight.html
+https://bugs.webkit.org/show_bug.cgi?id=66328
+
+Reviewed by Dan Bernstein.
+
+In r93140 the temporary font created for a remote CSS font face
+was created without being retained. We need to protect the
+font from being purged while we hold onto it, so add a font cache
+purge preventer.
+
+* css/CSSFontFaceSource.cpp:
+(WebCore::CSSFontFaceSource::getFontData):
+
+2011-08-16  Joseph Pecoraro  joep...@webkit.org
+
 Unreviewed Chromium Windows build fix after r93140. Take 4.
 Namespace the now public enum as FontCache::ShouldRetain.
 


Modified: trunk/Source/WebCore/css/CSSFontFaceSource.cpp (93170 => 93171)

--- trunk/Source/WebCore/css/CSSFontFaceSource.cpp	2011-08-16 22:35:03 UTC (rev 93170)
+++ trunk/Source/WebCore/css/CSSFontFaceSource.cpp	2011-08-16 22:58:26 UTC (rev 93171)
@@ -185,8 +185,10 @@
 if (!m_loadStartTimer.isActive())
 m_loadStartTimer.startOneShot(0);
 
-SimpleFontData* tempData = fontCache()-getNonRetainedLastResortFallbackFont(fontDescription);
-fontData = adoptPtr(new SimpleFontData(tempData-platformData(), true, true));
+// This temporary font is not retained and should not be returned.
+FontCachePurgePreventer fontCachePurgePreventer;
+SimpleFontData* temporaryFont = fontCache()-getNonRetainedLastResortFallbackFont(fontDescription);
+fontData = adoptPtr(new SimpleFontData(temporaryFont-platformData(), true, true));
 }
 
 SimpleFontData* fontDataRawPtr = fontData.leakPtr();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93172] trunk/LayoutTests

[tony]

Title: [93172] trunk/LayoutTests








Revision 93172
Author t...@chromium.org
Date 2011-08-16 16:12:14 -0700 (Tue, 16 Aug 2011)


Log Message
Add placeholder directories so the chromium canary bots can update.

* platform/chromium-mac: Added.
* platform/chromium-mac/fast: Added.
* platform/chromium-mac/fast/events: Added.
* platform/chromium-mac/http: Added.
* platform/chromium-mac/http/tests: Added.
* platform/chromium-mac/http/tests/workers: Added.
* platform/chromium-mac/storage: Added.
* platform/chromium-mac/storage/domstorage: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac/
trunk/LayoutTests/platform/chromium-mac/fast/
trunk/LayoutTests/platform/chromium-mac/fast/events/
trunk/LayoutTests/platform/chromium-mac/http/
trunk/LayoutTests/platform/chromium-mac/http/tests/
trunk/LayoutTests/platform/chromium-mac/http/tests/workers/
trunk/LayoutTests/platform/chromium-mac/storage/
trunk/LayoutTests/platform/chromium-mac/storage/domstorage/




Diff

Modified: trunk/LayoutTests/ChangeLog (93171 => 93172)

--- trunk/LayoutTests/ChangeLog	2011-08-16 22:58:26 UTC (rev 93171)
+++ trunk/LayoutTests/ChangeLog	2011-08-16 23:12:14 UTC (rev 93172)
@@ -1,3 +1,16 @@
+2011-08-16  Tony Chang  t...@chromium.org
+
+Add placeholder directories so the chromium canary bots can update.
+
+* platform/chromium-mac: Added.
+* platform/chromium-mac/fast: Added.
+* platform/chromium-mac/fast/events: Added.
+* platform/chromium-mac/http: Added.
+* platform/chromium-mac/http/tests: Added.
+* platform/chromium-mac/http/tests/workers: Added.
+* platform/chromium-mac/storage: Added.
+* platform/chromium-mac/storage/domstorage: Added.
+
 2011-08-16  Joseph Pecoraro  joep...@webkit.org
 
 Unreviewed, unskipping the test.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93173] trunk/Tools

[abarth]

Title: [93173] trunk/Tools








Revision 93173
Author aba...@webkit.org
Date 2011-08-16 16:12:51 -0700 (Tue, 16 Aug 2011)


Log Message
Fold bulk-optimize-baselines into optimize-baselines
https://bugs.webkit.org/show_bug.cgi?id=66345

Reviewed by James Robinson.

bulk-optimize-baselines is now a superset of optimize-baselines, so
they can be combined.

* Scripts/webkitpy/tool/commands/rebaseline.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py




Diff

Modified: trunk/Tools/ChangeLog (93172 => 93173)

--- trunk/Tools/ChangeLog	2011-08-16 23:12:14 UTC (rev 93172)
+++ trunk/Tools/ChangeLog	2011-08-16 23:12:51 UTC (rev 93173)
@@ -1,5 +1,17 @@
 2011-08-16  Adam Barth  aba...@webkit.org
 
+Fold bulk-optimize-baselines into optimize-baselines
+https://bugs.webkit.org/show_bug.cgi?id=66345
+
+Reviewed by James Robinson.
+
+bulk-optimize-baselines is now a superset of optimize-baselines, so
+they can be combined.
+
+* Scripts/webkitpy/tool/commands/rebaseline.py:
+
+2011-08-16  Adam Barth  aba...@webkit.org
+
 Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
 https://bugs.webkit.org/show_bug.cgi?id=66334
 


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py (93172 => 93173)

--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py	2011-08-16 23:12:14 UTC (rev 93172)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py	2011-08-16 23:12:51 UTC (rev 93173)
@@ -105,7 +105,7 @@
 class OptimizeBaselines(AbstractDeclarativeCommand):
 name = optimize-baselines
 help_text = Reshuffles the baselines for the given test to use as litte space on disk as possible.
-argument_names = TEST_NAME
+argument_names = TEST_NAMES
 
 def _optimize_baseline(self, test_name):
 for suffix in _baseline_suffix_list:
@@ -115,19 +115,6 @@
 
 def execute(self, options, args, tool):
 self._baseline_optimizer = BaselineOptimizer(tool.scm(), tool.filesystem)
-self._optimize_baseline(args[0])
-
-
-class BulkOptimizeBaselines(OptimizeBaselines):
-name = bulk-optimize-baselines
-help_text = Reshuffles the baselines for tests to use as litte space on disk as possible.
-argument_names = TEST_NAMES
-
-def _to_test_name(self, file_name):
-return self._tool.filesystem.relpath(file_name, self._port.layout_tests_dir())
-
-def execute(self, options, args, tool):
-self._baseline_optimizer = BaselineOptimizer(tool.scm(), tool.filesystem)
 self._port = factory.get(chromium-win-win7)  # FIXME: This should be selectable.
 
 for test_name in map(self._to_test_name, test_files.find(self._port, args)):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93174] trunk/Source/WebCore

[commit-queue]

Title: [93174] trunk/Source/WebCore








Revision 93174
Author commit-qu...@webkit.org
Date 2011-08-16 16:16:17 -0700 (Tue, 16 Aug 2011)


Log Message
Fix spelling error.
https://bugs.webkit.org/show_bug.cgi?id=66261

Patch by Scott Byer scottb...@chromium.org on 2011-08-16
Reviewed by Adam Barth.

No functional change, no tests needed.

* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::notifyPositionChanged):
* platform/ScrollAnimator.h:
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
* platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):
* platform/chromium/ScrollAnimatorChromiumMac.h:
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollAnimator.cpp
trunk/Source/WebCore/platform/ScrollAnimator.h
trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp
trunk/Source/WebCore/platform/ScrollAnimatorWin.cpp
trunk/Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.h
trunk/Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (93173 => 93174)

--- trunk/Source/WebCore/ChangeLog	2011-08-16 23:12:51 UTC (rev 93173)
+++ trunk/Source/WebCore/ChangeLog	2011-08-16 23:16:17 UTC (rev 93174)
@@ -1,3 +1,36 @@
+2011-08-16  Scott Byer  scottb...@chromium.org
+
+Fix spelling error.
+https://bugs.webkit.org/show_bug.cgi?id=66261
+
+Reviewed by Adam Barth.
+
+No functional change, no tests needed.
+
+* platform/ScrollAnimator.cpp:
+(WebCore::ScrollAnimator::scroll):
+(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
+(WebCore::ScrollAnimator::notifyPositionChanged):
+* platform/ScrollAnimator.h:
+* platform/ScrollAnimatorNone.cpp:
+(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
+(WebCore::ScrollAnimatorNone::animationTimerFired):
+* platform/ScrollAnimatorWin.cpp:
+(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
+(WebCore::ScrollAnimatorWin::animateScroll):
+* platform/chromium/ScrollAnimatorChromiumMac.h:
+* platform/chromium/ScrollAnimatorChromiumMac.mm:
+(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
+(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
+(WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
+(WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):
+* platform/mac/ScrollAnimatorMac.h:
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
+(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
+(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
+(WebCore::ScrollAnimatorMac::notifyPositionChanged):
+
 2011-08-16  Joseph Pecoraro  joep...@webkit.org
 
 ASSERT in fast/css/custom-font-xheight.html


Modified: trunk/Source/WebCore/platform/ScrollAnimator.cpp (93173 => 93174)

--- trunk/Source/WebCore/platform/ScrollAnimator.cpp	2011-08-16 23:12:51 UTC (rev 93173)
+++ trunk/Source/WebCore/platform/ScrollAnimator.cpp	2011-08-16 23:16:17 UTC (rev 93174)
@@ -67,7 +67,7 @@
 return false;
 *currentPos = newPos;
 
-notityPositionChanged();
+notifyPositionChanged();
 
 return true;
 }
@@ -77,7 +77,7 @@
 if (m_currentPosX != offset.x() || m_currentPosY != offset.y()) {
 m_currentPosX = offset.x();
 m_currentPosY = offset.y();
-notityPositionChanged();
+notifyPositionChanged();
 }
 }
 
@@ -124,7 +124,7 @@
 return FloatPoint(m_currentPosX, m_currentPosY);
 }
 
-void ScrollAnimator::notityPositionChanged()
+void ScrollAnimator::notifyPositionChanged()
 {
 m_scrollableArea-setScrollOffsetFromAnimation(IntPoint(m_currentPosX, m_currentPosY));
 }


Modified: trunk/Source/WebCore/platform/ScrollAnimator.h (93173 => 93174)

--- trunk/Source/WebCore/platform/ScrollAnimator.h	2011-08-16 23:12:51 UTC (rev 93173)
+++ 

[webkit-changes] [93175] trunk/Tools

[abarth]

Title: [93175] trunk/Tools








Revision 93175
Author aba...@webkit.org
Date 2011-08-16 16:26:17 -0700 (Tue, 16 Aug 2011)


Log Message
Add webkit-patch analyze-baselines, as requested by jamesr.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
* Scripts/webkitpy/tool/commands/rebaseline.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py




Diff

Modified: trunk/Tools/ChangeLog (93174 => 93175)

--- trunk/Tools/ChangeLog	2011-08-16 23:16:17 UTC (rev 93174)
+++ trunk/Tools/ChangeLog	2011-08-16 23:26:17 UTC (rev 93175)
@@ -1,5 +1,12 @@
 2011-08-16  Adam Barth  aba...@webkit.org
 
+Add webkit-patch analyze-baselines, as requested by jamesr.
+
+* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
+* Scripts/webkitpy/tool/commands/rebaseline.py:
+
+2011-08-16  Adam Barth  aba...@webkit.org
+
 Fold bulk-optimize-baselines into optimize-baselines
 https://bugs.webkit.org/show_bug.cgi?id=66345
 


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py (93174 => 93175)

--- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py	2011-08-16 23:16:17 UTC (rev 93174)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py	2011-08-16 23:26:17 UTC (rev 93175)
@@ -150,6 +150,10 @@
 self._filesystem.write_binary_file(destination, data_for_result[result])
 self._scm.add(destination)
 
+def directories_by_result(self, baseline_name):
+results_by_directory = self._read_results_by_directory(baseline_name)
+return _invert_dictionary(results_by_directory)
+
 def optimize(self, baseline_name):
 results_by_directory, new_results_by_directory = self._find_optimal_result_placement(baseline_name)
 if self._results_by_port_name(results_by_directory) != self._results_by_port_name(new_results_by_directory):


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py (93174 => 93175)

--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py	2011-08-16 23:16:17 UTC (rev 93174)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py	2011-08-16 23:26:17 UTC (rev 93175)
@@ -30,6 +30,7 @@
 import re
 import shutil
 import urllib
+import pprint
 
 import webkitpy.common.config.urls as config_urls
 from webkitpy.common.checkout.baselineoptimizer import BaselineOptimizer
@@ -104,7 +105,7 @@
 
 class OptimizeBaselines(AbstractDeclarativeCommand):
 name = optimize-baselines
-help_text = Reshuffles the baselines for the given test to use as litte space on disk as possible.
+help_text = Reshuffles the baselines for the given tests to use as litte space on disk as possible.
 argument_names = TEST_NAMES
 
 def _optimize_baseline(self, test_name):
@@ -113,6 +114,9 @@
 if not self._baseline_optimizer.optimize(baseline_name):
 print Hueristics failed to optimize %s % baseline_name
 
+def _to_test_name(self, file_name): 
+return self._tool.filesystem.relpath(file_name, self._port.layout_tests_dir())
+
 def execute(self, options, args, tool):
 self._baseline_optimizer = BaselineOptimizer(tool.scm(), tool.filesystem)
 self._port = factory.get(chromium-win-win7)  # FIXME: This should be selectable.
@@ -122,6 +126,31 @@
 self._optimize_baseline(test_name)
 
 
+class AnalyzeBaselines(AbstractDeclarativeCommand):
+name = analyze-baselines
+help_text = Analyzes the baselines for the given tests and displays which ones have the same hash.
+argument_names = TEST_NAMES
+
+def _analyze_baseline(self, test_name):
+for suffix in _baseline_suffix_list:
+baseline_name = _baseline_name(self._tool.filesystem, test_name, suffix)
+directories_by_result = self._baseline_optimizer.directories_by_result(baseline_name)
+if directories_by_result:
+print '== ', baseline_name, ' =='
+pprint.pprint(directories_by_result)
+print
+
+def _to_test_name(self, file_name): 
+return self._tool.filesystem.relpath(file_name, self._port.layout_tests_dir())
+
+def execute(self, options, args, tool):
+self._baseline_optimizer = BaselineOptimizer(tool.scm(), tool.filesystem)
+self._port = factory.get(chromium-win-win7)  # FIXME: This should be selectable.
+
+for test_name in map(self._to_test_name, test_files.find(self._port, args)):
+self._analyze_baseline(test_name)
+
+
 class RebaselineExpectations(AbstractDeclarativeCommand):
 name = rebaseline-expectations
 help_text = Rebaselines the tests indicated in test_expectations.txt.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93178] trunk/Tools

[abarth]

Title: [93178] trunk/Tools








Revision 93178
Author aba...@webkit.org
Date 2011-08-16 16:51:37 -0700 (Tue, 16 Aug 2011)


Log Message
Change webkit-patch analyze-baselines to print in a more unix-friendly way
https://bugs.webkit.org/show_bug.cgi?id=66349

Reviewed by James Robinson.

As requested by jamesr.

* Scripts/webkitpy/tool/commands/rebaseline.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py




Diff

Modified: trunk/Tools/ChangeLog (93177 => 93178)

--- trunk/Tools/ChangeLog	2011-08-16 23:30:13 UTC (rev 93177)
+++ trunk/Tools/ChangeLog	2011-08-16 23:51:37 UTC (rev 93178)
@@ -1,3 +1,14 @@
+2011-08-16  Adam Barth  aba...@webkit.org
+
+Change webkit-patch analyze-baselines to print in a more unix-friendly way
+https://bugs.webkit.org/show_bug.cgi?id=66349
+
+Reviewed by James Robinson.
+
+As requested by jamesr.
+
+* Scripts/webkitpy/tool/commands/rebaseline.py:
+
 2011-08-16  Eric Seidel  e...@webkit.org
 
 REGRESSION(92717): WinPort needs to parse version information from port_name


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py (93177 => 93178)

--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py	2011-08-16 23:30:13 UTC (rev 93177)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py	2011-08-16 23:51:37 UTC (rev 93178)
@@ -30,7 +30,6 @@
 import re
 import shutil
 import urllib
-import pprint
 
 import webkitpy.common.config.urls as config_urls
 from webkitpy.common.checkout.baselineoptimizer import BaselineOptimizer
@@ -128,17 +127,21 @@
 
 class AnalyzeBaselines(AbstractDeclarativeCommand):
 name = analyze-baselines
-help_text = Analyzes the baselines for the given tests and displays which ones have the same hash.
+help_text = Analyzes the baselines for the given tests and prints results that are identical.
 argument_names = TEST_NAMES
 
+def _print(self, baseline_name, directories_by_result):
+for result, directories in directories_by_result.items():
+if len(directories) = 1:
+continue
+results_names = [self._tool.filesystem.join(directory, baseline_name) for directory in directories]
+print ' '.join(results_names)
+
 def _analyze_baseline(self, test_name):
 for suffix in _baseline_suffix_list:
 baseline_name = _baseline_name(self._tool.filesystem, test_name, suffix)
 directories_by_result = self._baseline_optimizer.directories_by_result(baseline_name)
-if directories_by_result:
-print '== ', baseline_name, ' =='
-pprint.pprint(directories_by_result)
-print
+self._print(baseline_name, directories_by_result)
 
 def _to_test_name(self, file_name): 
 return self._tool.filesystem.relpath(file_name, self._port.layout_tests_dir())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93179] branches/safari-534.51-branch/Source

[lforschler]

Title: [93179] branches/safari-534.51-branch/Source








Revision 93179
Author lforsch...@apple.com
Date 2011-08-16 17:05:15 -0700 (Tue, 16 Aug 2011)


Log Message
Versioning.

Modified Paths

branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig (93178 => 93179)

--- branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-08-16 23:51:37 UTC (rev 93178)
+++ branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-08-17 00:05:15 UTC (rev 93179)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 14;
+TINY_VERSION = 16;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (93178 => 93179)

--- branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-08-16 23:51:37 UTC (rev 93178)
+++ branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-08-17 00:05:15 UTC (rev 93179)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 14;
+TINY_VERSION = 16;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig (93178 => 93179)

--- branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig	2011-08-16 23:51:37 UTC (rev 93178)
+++ branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig	2011-08-17 00:05:15 UTC (rev 93179)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 14;
+TINY_VERSION = 16;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig (93178 => 93179)

--- branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-08-16 23:51:37 UTC (rev 93178)
+++ branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-08-17 00:05:15 UTC (rev 93179)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 14;
+TINY_VERSION = 16;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig (93178 => 93179)

--- branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-08-16 23:51:37 UTC (rev 93178)
+++ branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-08-17 00:05:15 UTC (rev 93179)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 14;
+TINY_VERSION = 16;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93180] tags/Safari-534.51.16/

[lforschler]

Title: [93180] tags/Safari-534.51.16/








Revision 93180
Author lforsch...@apple.com
Date 2011-08-16 17:06:48 -0700 (Tue, 16 Aug 2011)


Log Message
New tag.

Added Paths

tags/Safari-534.51.16/




Diff

Property changes: tags/Safari-534.51.16



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93181] branches/safari-534.51-branch/Source

[lforschler]

Title: [93181] branches/safari-534.51-branch/Source








Revision 93181
Author lforsch...@apple.com
Date 2011-08-16 17:07:24 -0700 (Tue, 16 Aug 2011)


Log Message
Versioning.

Modified Paths

branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig (93180 => 93181)

--- branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-08-17 00:06:48 UTC (rev 93180)
+++ branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-08-17 00:07:24 UTC (rev 93181)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 16;
+TINY_VERSION = 17;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (93180 => 93181)

--- branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-08-17 00:06:48 UTC (rev 93180)
+++ branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-08-17 00:07:24 UTC (rev 93181)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 16;
+TINY_VERSION = 17;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig (93180 => 93181)

--- branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig	2011-08-17 00:06:48 UTC (rev 93180)
+++ branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig	2011-08-17 00:07:24 UTC (rev 93181)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 16;
+TINY_VERSION = 17;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig (93180 => 93181)

--- branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-08-17 00:06:48 UTC (rev 93180)
+++ branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-08-17 00:07:24 UTC (rev 93181)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 16;
+TINY_VERSION = 17;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig (93180 => 93181)

--- branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-08-17 00:06:48 UTC (rev 93180)
+++ branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-08-17 00:07:24 UTC (rev 93181)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 16;
+TINY_VERSION = 17;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93182] trunk/Source

[commit-queue]

Title: [93182] trunk/Source








Revision 93182
Author commit-qu...@webkit.org
Date 2011-08-16 17:16:22 -0700 (Tue, 16 Aug 2011)


Log Message
Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions
https://bugs.webkit.org/show_bug.cgi?id=65694

Patch by Per-Erik Brodin per-erik.bro...@ericsson.com on 2011-08-16
Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests since there is no change in behavior.

* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
* loader/ThreadableLoader.h:
(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
* notifications/Notification.cpp:
(WebCore::Notification::startLoading):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::loadAsynchronously):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/FileReaderLoader.cpp
trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp
trunk/Source/WebCore/loader/ThreadableLoader.h
trunk/Source/WebCore/notifications/Notification.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (93181 => 93182)

--- trunk/Source/WebCore/ChangeLog	2011-08-17 00:07:24 UTC (rev 93181)
+++ trunk/Source/WebCore/ChangeLog	2011-08-17 00:16:22 UTC (rev 93182)
@@ -1,3 +1,24 @@
+2011-08-16  Per-Erik Brodin  per-erik.bro...@ericsson.com
+
+Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions
+https://bugs.webkit.org/show_bug.cgi?id=65694
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests since there is no change in behavior.
+
+* fileapi/FileReaderLoader.cpp:
+(WebCore::FileReaderLoader::start):
+* loader/DocumentThreadableLoader.cpp:
+(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
+(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
+* loader/ThreadableLoader.h:
+(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
+* notifications/Notification.cpp:
+(WebCore::Notification::startLoading):
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::createRequest):
+
 2011-08-16  Scott Byer  scottb...@chromium.org
 
 Fix spelling error.


Modified: trunk/Source/WebCore/fileapi/FileReaderLoader.cpp (93181 => 93182)

--- trunk/Source/WebCore/fileapi/FileReaderLoader.cpp	2011-08-17 00:07:24 UTC (rev 93181)
+++ trunk/Source/WebCore/fileapi/FileReaderLoader.cpp	2011-08-17 00:16:22 UTC (rev 93182)
@@ -88,7 +88,7 @@
 ThreadableLoaderOptions options;
 options.sendLoadCallbacks = true;
 options.sniffContent = false;
-options.forcePreflight = false;
+options.preflightPolicy = ConsiderPreflight;
 options.allowCredentials = true;
 options.crossOriginRequestPolicy = DenyCrossOriginRequests;
 


Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp (93181 => 93182)

--- trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp	2011-08-17 00:07:24 UTC (rev 93181)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp	2011-08-17 00:16:22 UTC (rev 93182)
@@ -98,7 +98,7 @@
 OwnPtrResourceRequest crossOriginRequest = adoptPtr(new ResourceRequest(request));
 updateRequestForAccessControl(*crossOriginRequest, securityOrigin(), m_options.allowCredentials);
 
-if (!m_options.forcePreflight  isSimpleCrossOriginAccessRequest(crossOriginRequest-httpMethod(), crossOriginRequest-httpHeaderFields()))
+if ((m_options.preflightPolicy == ConsiderPreflight  isSimpleCrossOriginAccessRequest(crossOriginRequest-httpMethod(), crossOriginRequest-httpHeaderFields())) || m_options.preflightPolicy == PreventPreflight)
 makeSimpleCrossOriginAccessRequest(*crossOriginRequest);
 else {
 m_actualRequest = crossOriginRequest.release();
@@ -112,7 +112,8 @@
 
 void DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest(const ResourceRequest request)
 {
-ASSERT(isSimpleCrossOriginAccessRequest(request.httpMethod(), request.httpHeaderFields()));
+ASSERT(m_options.preflightPolicy != ForcePreflight);
+ASSERT(m_options.preflightPolicy == PreventPreflight || isSimpleCrossOriginAccessRequest(request.httpMethod(), request.httpHeaderFields()));
 
 // Cross-origin requests are only defined for HTTP. We would catch this when checking response headers later, but there is no reason to send a request that's guaranteed to be denied.
 // FIXME: Consider allowing simple CORS requests to non-HTTP URLs.


Modified: trunk/Source/WebCore/loader/ThreadableLoader.h (93181 => 93182)

--- trunk/Source/WebCore/loader/ThreadableLoader.h	

[webkit-changes] [93183] trunk/Tools

[eric]

Title: [93183] trunk/Tools








Revision 93183
Author e...@webkit.org
Date 2011-08-16 17:55:27 -0700 (Tue, 16 Aug 2011)


Log Message
REGRESSION(92717): WinPort needs to parse version information from port_name
https://bugs.webkit.org/show_bug.cgi?id=66325

Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).

* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (93182 => 93183)

--- trunk/Tools/ChangeLog	2011-08-17 00:16:22 UTC (rev 93182)
+++ trunk/Tools/ChangeLog	2011-08-17 00:55:27 UTC (rev 93183)
@@ -1,3 +1,13 @@
+2011-08-16  Eric Seidel  e...@webkit.org
+
+REGRESSION(92717): WinPort needs to parse version information from port_name
+https://bugs.webkit.org/show_bug.cgi?id=66325
+
+Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
+
+* Scripts/webkitpy/layout_tests/port/mac.py:
+* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
+
 2011-08-16  Adam Barth  aba...@webkit.org
 
 Change webkit-patch analyze-baselines to print in a more unix-friendly way


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (93182 => 93183)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py	2011-08-17 00:16:22 UTC (rev 93182)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py	2011-08-17 00:55:27 UTC (rev 93183)
@@ -96,7 +96,7 @@
 return map(self._webkit_baseline_path, fallback_names)
 
 def setup_environ_for_server(self, server_name=None):
-env = super(MacPort, self).setup_environ_for_server(self, server_name)
+env = super(MacPort, self).setup_environ_for_server(server_name)
 if server_name == self.driver_name():
 if self.get_option('leaks'):
 env['MallocStackLogging'] = '1'


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py (93182 => 93183)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py	2011-08-17 00:16:22 UTC (rev 93182)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py	2011-08-17 00:55:27 UTC (rev 93183)
@@ -111,6 +111,12 @@
 
 self.assertRaises(AssertionError, self.assert_name, None, '10.3.1', 'should-raise-assertion-so-this-value-does-not-matter')
 
+def test_setup_environ_for_server(self):
+port = MacPort(options=MockOptions(leaks=True, guard_malloc=True))
+env = port.setup_environ_for_server(port.driver_name())
+self.assertEquals(env['MallocStackLogging'], '1')
+self.assertEquals(env['DYLD_INSERT_LIBRARIES'], '/usr/lib/libgmalloc.dylib')
+
 def _assert_search_path(self, search_paths, version, use_webkit2=False):
 # FIXME: Port constructors should not parse the port name, but
 # rather be passed components (directly or via setters).  Once






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93185] trunk/LayoutTests

[rniwa]

Title: [93185] trunk/LayoutTests








Revision 93185
Author rn...@webkit.org
Date 2011-08-16 18:11:04 -0700 (Tue, 16 Aug 2011)


Log Message
More rebaselines for Windows WebKit2 port.

* platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
* platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt:
* platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt
trunk/LayoutTests/platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt
trunk/LayoutTests/platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (93184 => 93185)

--- trunk/LayoutTests/ChangeLog	2011-08-17 00:57:31 UTC (rev 93184)
+++ trunk/LayoutTests/ChangeLog	2011-08-17 01:11:04 UTC (rev 93185)
@@ -1,3 +1,11 @@
+2011-08-16  Ryosuke Niwa  rn...@webkit.org
+
+More rebaselines for Windows WebKit2 port.
+
+* platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
+* platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt:
+* platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt:
+
 2011-08-16  Hayato Ito  hay...@chromium.org
 
 Implement proper handling of events which happen in children of shadow hosts.


Modified: trunk/LayoutTests/platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt (93184 => 93185)

--- trunk/LayoutTests/platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt	2011-08-17 00:57:31 UTC (rev 93184)
+++ trunk/LayoutTests/platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt	2011-08-17 01:11:04 UTC (rev 93185)
@@ -17,35 +17,35 @@
 layer at (0,0) size 800x600
   RenderBlock {HTML} at (0,0) size 800x600
 RenderBody {BODY} at (8,8) size 784x584
-  RenderBlock {DIV} at (0,0) size 784x238 [border: (2px solid #FF)]
-RenderBlock {DIV} at (14,14) size 756x83
-  RenderText {#text} at (0,0) size 66x26
-text run at (0,0) width 66: Tests: 
+  RenderBlock {DIV} at (0,0) size 784x240 [border: (2px solid #FF)]
+RenderBlock {DIV} at (14,14) size 756x84
+  RenderText {#text} at (0,0) size 67x28
+text run at (0,0) width 67: Tests: 
   RenderBR {BR} at (0,0) size 0x0
-  RenderText {#text} at (0,27) size 679x55
-text run at (0,27) width 679: Deleting when a selection starts in the middle of the last paragraph and
-text run at (0,55) width 347: extends to the end of that paragraph
-RenderBlock {DIV} at (14,113) size 756x111
-  RenderText {#text} at (0,0) size 189x26
+  RenderText {#text} at (0,28) size 690x56
+text run at (0,28) width 690: Deleting when a selection starts in the middle of the last paragraph and
+text run at (0,56) width 348: extends to the end of that paragraph
+RenderBlock {DIV} at (14,114) size 756x112
+  RenderText {#text} at (0,0) size 189x28
 text run at (0,0) width 189: Expected Results: 
-  RenderBR {BR} at (189,21) size 0x0
-  RenderText {#text} at (0,27) size 729x83
-text run at (0,27) width 729: Should see the four lines in the red box. First line should be \one\. Next one
-text run at (0,55) width 166: should be \two\. 
-text run at (166,55) width 506: Next one should be \three\. Last one should be \fo\.
-text run at (0,83) width 658: Insertion point should be blinking at the start of the fourth (last) line.
-  RenderBlock {DIV} at (0,262) size 784x116
+  RenderBR {BR} at (189,22) size 0x0
+  RenderText {#text} at (0,28) size 738x84
+text run at (0,28) width 738: Should see the four lines in the red box. First line should be \one\. Next one
+text run at (0,56) width 167: should be \two\. 
+text run at (167,56) width 508: Next one should be \three\. Last one should be \fo\.
+text run at (0,84) width 668: Insertion point should be blinking at the start of the fourth (last) line.
+  RenderBlock {DIV} at (0,264) size 784x116
 RenderBlock {DIV} at (0,0) size 784x116 [border: (2px solid #FF)]
   RenderBlock (anonymous) at (2,2) size 780x28
-RenderText {#text} at (0,0) size 35x27
+RenderText {#text} at (0,0) size 35x28
   text run at (0,0) width 35: one
   RenderBlock {P} at (2,30) size 780x28
-RenderText {#text} at (0,0) size 36x27
+RenderText {#text} at (0,0) size 36x28
   text run at (0,0) width 36: two
   RenderBlock {P} at (2,58) size 780x28
-RenderText {#text} at (0,0) size 49x27
+RenderText {#text} at (0,0) size 49x28
   text run at 

[webkit-changes] [93186] trunk

[commit-queue]

Title: [93186] trunk








Revision 93186
Author commit-qu...@webkit.org
Date 2011-08-16 18:24:44 -0700 (Tue, 16 Aug 2011)


Log Message
Computing screen-space transform for LayerChromium and CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=66114

Patch by Shawn Singh shawnsi...@chromium.org on 2011-08-16
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/backface-visibility-hierarchical-transform.html

Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform.   The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl).  This transform
will also be used for other things, such as HUD drawing, in upcoming
patches.

Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility.  Now it simply uses the screen space transform.

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::screenSpaceDrawTransform):
(WebCore::LayerChromium::setScreenSpaceDrawTransform):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::calculateDrawTransformsAndVisibility):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::screenSpaceDrawTransform):
(WebCore::CCLayerImpl::setScreenSpaceDrawTransform):

LayoutTests:

This case tests if backface visibility properly accounts for a hierarchy
of transforms.

* compositing/backface-visibility-hierarchical-transform-expected.png: Added.
* compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
* compositing/backface-visibility-hierarchical-transform.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h


Added Paths

trunk/LayoutTests/compositing/backface-visibility-hierarchical-transform-expected.png
trunk/LayoutTests/compositing/backface-visibility-hierarchical-transform-expected.txt
trunk/LayoutTests/compositing/backface-visibility-hierarchical-transform.html




Diff

Modified: trunk/LayoutTests/ChangeLog (93185 => 93186)

--- trunk/LayoutTests/ChangeLog	2011-08-17 01:11:04 UTC (rev 93185)
+++ trunk/LayoutTests/ChangeLog	2011-08-17 01:24:44 UTC (rev 93186)
@@ -1,3 +1,17 @@
+2011-08-16  Shawn Singh  shawnsi...@chromium.org
+
+Computing screen-space transform for LayerChromium and CCLayerImpl
+https://bugs.webkit.org/show_bug.cgi?id=66114
+
+Reviewed by James Robinson.
+
+This case tests if backface visibility properly accounts for a hierarchy
+of transforms.
+
+* compositing/backface-visibility-hierarchical-transform-expected.png: Added.
+* compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
+* compositing/backface-visibility-hierarchical-transform.html: Added.
+
 2011-08-16  Ryosuke Niwa  rn...@webkit.org
 
 More rebaselines for Windows WebKit2 port.


Added: trunk/LayoutTests/compositing/backface-visibility-hierarchical-transform-expected.png (0 => 93186)

--- trunk/LayoutTests/compositing/backface-visibility-hierarchical-transform-expected.png	(rev 0)
+++ trunk/LayoutTests/compositing/backface-visibility-hierarchical-transform-expected.png	2011-08-17 01:24:44 UTC (rev 93186)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksume43420b383792f6c4145eca7e3911331g\xED\xCF\xE0
+\xD0IDATx\x9C\xED\xDC1
+\xC30EA)\xF8\xDE\xC6'\xDF\xDC \xD5#1Ӫ\xF9\xE5c\xED\x99Yto8\x8D\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\xD8\xF5\xFBy?\xFB?;0\xB7?\xF1
\x80\xB5\\xB0r \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b{f\xDE\xDEp,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\xD8\xF5\xFBy?\xFB?;0\xB7?\xF1
\x80\xB5\\xB0r \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b 

[webkit-changes] [93187] trunk/LayoutTests

[hayato]

Title: [93187] trunk/LayoutTests








Revision 93187
Author hay...@chromium.org
Date 2011-08-16 18:29:17 -0700 (Tue, 16 Aug 2011)


Log Message
Add two sample mismatch reftests to make sure that reftests work correctly.
https://bugs.webkit.org/show_bug.cgi?id=66218

Reviewed by Tony Chang.

One mismatch reftest is expected to pass, the other is expected to
fail. The failed one is marked as 'WONTFIX' in test expectations
in chromium port and is skipped in other ports.

* fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html: Added.
* fast/harness/sample-fail-mismatch-reftest.html: Added.
* fast/harness/sample-mismatch-reftest-expected-mismatch.html: Added.
* fast/harness/sample-mismatch-reftest.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped


Added Paths

trunk/LayoutTests/fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html
trunk/LayoutTests/fast/harness/sample-fail-mismatch-reftest.html
trunk/LayoutTests/fast/harness/sample-mismatch-reftest-expected-mismatch.html
trunk/LayoutTests/fast/harness/sample-mismatch-reftest.html




Diff

Modified: trunk/LayoutTests/ChangeLog (93186 => 93187)

--- trunk/LayoutTests/ChangeLog	2011-08-17 01:24:44 UTC (rev 93186)
+++ trunk/LayoutTests/ChangeLog	2011-08-17 01:29:17 UTC (rev 93187)
@@ -1,3 +1,24 @@
+2011-08-16  Hayato Ito  hay...@chromium.org
+
+Add two sample mismatch reftests to make sure that reftests work correctly.
+https://bugs.webkit.org/show_bug.cgi?id=66218
+
+Reviewed by Tony Chang.
+
+One mismatch reftest is expected to pass, the other is expected to
+fail. The failed one is marked as 'WONTFIX' in test expectations
+in chromium port and is skipped in other ports.
+
+* fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html: Added.
+* fast/harness/sample-fail-mismatch-reftest.html: Added.
+* fast/harness/sample-mismatch-reftest-expected-mismatch.html: Added.
+* fast/harness/sample-mismatch-reftest.html: Added.
+* platform/chromium/test_expectations.txt:
+* platform/gtk/Skipped:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+
 2011-08-16  Shawn Singh  shawnsi...@chromium.org
 
 Computing screen-space transform for LayerChromium and CCLayerImpl


Added: trunk/LayoutTests/fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html (0 => 93187)

--- trunk/LayoutTests/fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html	(rev 0)
+++ trunk/LayoutTests/fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html	2011-08-17 01:29:17 UTC (rev 93187)
@@ -0,0 +1 @@
+This mismatch reftest is expected to fail.
Property changes on: trunk/LayoutTests/fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/harness/sample-fail-mismatch-reftest.html (0 => 93187)

--- trunk/LayoutTests/fast/harness/sample-fail-mismatch-reftest.html	(rev 0)
+++ trunk/LayoutTests/fast/harness/sample-fail-mismatch-reftest.html	2011-08-17 01:29:17 UTC (rev 93187)
@@ -0,0 +1 @@
+This mismatch reftest is expected to fail.
Property changes on: trunk/LayoutTests/fast/harness/sample-fail-mismatch-reftest.html
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/harness/sample-mismatch-reftest-expected-mismatch.html (0 => 93187)

--- trunk/LayoutTests/fast/harness/sample-mismatch-reftest-expected-mismatch.html	(rev 0)
+++ trunk/LayoutTests/fast/harness/sample-mismatch-reftest-expected-mismatch.html	2011-08-17 01:29:17 UTC (rev 93187)
@@ -0,0 +1,2 @@
+This is a sample mismatch reftest.
+This line exists only in '-expected-mismatch.html'.
Property changes on: trunk/LayoutTests/fast/harness/sample-mismatch-reftest-expected-mismatch.html
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/harness/sample-mismatch-reftest.html (0 => 93187)

--- trunk/LayoutTests/fast/harness/sample-mismatch-reftest.html	(rev 0)
+++ trunk/LayoutTests/fast/harness/sample-mismatch-reftest.html	2011-08-17 01:29:17 UTC (rev 93187)
@@ -0,0 +1 @@
+This is a sample mismatch reftest.
Property changes on: trunk/LayoutTests/fast/harness/sample-mismatch-reftest.html
___


Added: svn:eol-style

Modified: 

[webkit-changes] [93189] trunk/Source/JavaScriptCore

[msaboff]

Title: [93189] trunk/Source/_javascript_Core








Revision 93189
Author msab...@apple.com
Date 2011-08-16 18:34:29 -0700 (Tue, 16 Aug 2011)


Log Message
Crash in Structure::visitChildren running iAd.js regression test suite under memory pressure
https://bugs.webkit.org/show_bug.cgi?id=66351

JIT::privateCompilePutByIdTransition expects that regT0 and regT1
have the basePayload and baseTag respectively.  In some cases,
we may get to this generated code with one or both of these
registers trash.  One know case is that regT0 on ARM may be
trashed as regT0 (r0) is also arg0 and can be overrun with sp due
to calls to JIT::restoreReturnAddress().  This patch uses the
values on the stack.  A longer term solution is to work out all
cases so that the register entry assumptions can assured.

While fixing this, also determined that the additional stack offset
of sizeof(void*) is not needed for ARM.

Reviewed by Gavin Barraclough.

* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (93188 => 93189)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-17 01:32:20 UTC (rev 93188)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-17 01:34:29 UTC (rev 93189)
@@ -1,3 +1,25 @@
+2011-08-16  Michael Saboff  msab...@apple.com
+
+Crash in Structure::visitChildren running iAd.js regression test suite under memory pressure
+https://bugs.webkit.org/show_bug.cgi?id=66351
+
+JIT::privateCompilePutByIdTransition expects that regT0 and regT1
+have the basePayload and baseTag respectively.  In some cases,
+we may get to this generated code with one or both of these
+registers trash.  One know case is that regT0 on ARM may be
+trashed as regT0 (r0) is also arg0 and can be overrun with sp due
+to calls to JIT::restoreReturnAddress().  This patch uses the
+values on the stack.  A longer term solution is to work out all
+cases so that the register entry assumptions can assured.
+
+While fixing this, also determined that the additional stack offset
+of sizeof(void*) is not needed for ARM.
+
+Reviewed by Gavin Barraclough.
+
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::privateCompilePutByIdTransition):
+
 2011-08-15  Gavin Barraclough  barraclo...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=66263


Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp (93188 => 93189)

--- trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp	2011-08-17 01:32:20 UTC (rev 93188)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp	2011-08-17 01:34:29 UTC (rev 93189)
@@ -470,8 +470,17 @@
 
 void JIT::privateCompilePutByIdTransition(StructureStubInfo* stubInfo, Structure* oldStructure, Structure* newStructure, size_t cachedOffset, StructureChain* chain, ReturnAddressPtr returnAddress, bool direct)
 {
-// It is assumed that regT0 contains the basePayload and regT1 contains the baseTag.  The value can be found on the stack.
-
+// The code below assumes that regT0 contains the basePayload and regT1 contains the baseTag. Restore them from the stack.
+#if CPU(MIPS) || CPU(SH4) || CPU(ARM)
+// For MIPS, we don't add sizeof(void*) to the stack offset.
+load32(Address(stackPointerRegister, OBJECT_OFFSETOF(JITStackFrame, args[0]) + OBJECT_OFFSETOF(JSValue, u.asBits.payload)), regT0);
+// For MIPS, we don't add sizeof(void*) to the stack offset.
+load32(Address(stackPointerRegister, OBJECT_OFFSETOF(JITStackFrame, args[0]) + OBJECT_OFFSETOF(JSValue, u.asBits.tag)), regT1);
+#else
+load32(Address(stackPointerRegister, OBJECT_OFFSETOF(JITStackFrame, args[0]) + sizeof(void*) + OBJECT_OFFSETOF(JSValue, u.asBits.payload)), regT0);
+load32(Address(stackPointerRegister, OBJECT_OFFSETOF(JITStackFrame, args[0]) + sizeof(void*) + OBJECT_OFFSETOF(JSValue, u.asBits.tag)), regT1);
+#endif
+
 JumpList failureCases;
 failureCases.append(branch32(NotEqual, regT1, TrustedImm32(JSValue::CellTag)));
 failureCases.append(branchPtr(NotEqual, Address(regT0, JSCell::structureOffset()), TrustedImmPtr(oldStructure)));
@@ -498,14 +507,24 @@
 stubCall.addArgument(TrustedImm32(oldStructure-propertyStorageCapacity()));
 stubCall.addArgument(TrustedImm32(newStructure-propertyStorageCapacity()));
 stubCall.call(regT0);
-
+
 restoreReturnAddressBeforeReturn(regT3);
+
+#if CPU(MIPS) || CPU(SH4) || CPU(ARM)
+// For MIPS, we don't add sizeof(void*) to the stack offset.
+load32(Address(stackPointerRegister, OBJECT_OFFSETOF(JITStackFrame, args[0]) + OBJECT_OFFSETOF(JSValue, u.asBits.payload)), regT0);
+// For MIPS, we don't add sizeof(void*) to the stack offset.
+load32(Address(stackPointerRegister, 

[webkit-changes] [93190] trunk/Tools

[abarth]

Title: [93190] trunk/Tools








Revision 93190
Author aba...@webkit.org
Date 2011-08-16 18:38:35 -0700 (Tue, 16 Aug 2011)


Log Message
Add a CG qualifier similar to the GPU qualifier
https://bugs.webkit.org/show_bug.cgi?id=66359

Reviewed by Eric Seidel.

Once we have a Skia configuration on Chromium Mac, we'll use this CG
qualifier to note that expectations apply only to the CG configuration.

* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (93189 => 93190)

--- trunk/Tools/ChangeLog	2011-08-17 01:34:29 UTC (rev 93189)
+++ trunk/Tools/ChangeLog	2011-08-17 01:38:35 UTC (rev 93190)
@@ -1,3 +1,16 @@
+2011-08-16  Adam Barth  aba...@webkit.org
+
+Add a CG qualifier similar to the GPU qualifier
+https://bugs.webkit.org/show_bug.cgi?id=66359
+
+Reviewed by Eric Seidel.
+
+Once we have a Skia configuration on Chromium Mac, we'll use this CG
+qualifier to note that expectations apply only to the CG configuration.
+
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
+
 2011-08-16  Eric Seidel  e...@webkit.org
 
 REGRESSION(92717): WinPort needs to parse version information from port_name


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (93189 => 93190)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2011-08-17 01:34:29 UTC (rev 93189)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2011-08-17 01:38:35 UTC (rev 93190)
@@ -68,7 +68,7 @@
 ('lucid', 'x86'),
 ('lucid', 'x86_64'))
 
-ALL_GRAPHICS_TYPES = ('cpu', 'gpu')
+ALL_GRAPHICS_TYPES = ('cpu', 'gpu', 'cg')
 
 ALL_BASELINE_VARIANTS = [
 'chromium-cg-mac-snowleopard', 'chromium-cg-mac-leopard',


Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py (93189 => 93190)

--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py	2011-08-17 01:34:29 UTC (rev 93189)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py	2011-08-17 01:38:35 UTC (rev 93190)
@@ -92,9 +92,11 @@
 self.assertEquals(extrapolator.extrapolate_test_configurations(Webkit Win), set([TestConfiguration(version='xp', architecture='x86', build_type='release', graphics_type='cpu')]))
 self.assertEquals(extrapolator.extrapolate_test_configurations(Webkit Vista), set([
 TestConfiguration(version='vista', architecture='x86', build_type='debug', graphics_type='cpu'),
+TestConfiguration(version='vista', architecture='x86', build_type='debug', graphics_type='cg'),
 TestConfiguration(version='vista', architecture='x86', build_type='debug', graphics_type='gpu'),
 TestConfiguration(version='vista', architecture='x86', build_type='release', graphics_type='gpu'),
-TestConfiguration(version='vista', architecture='x86', build_type='release', graphics_type='cpu')]))
+TestConfiguration(version='vista', architecture='x86', build_type='release', graphics_type='cpu'),
+TestConfiguration(version='vista', architecture='x86', build_type='release', graphics_type='cg')]))
 self.assertRaises(KeyError, extrapolator.extrapolate_test_configurations, Potato)
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93191] trunk/LayoutTests

[abarth]

Title: [93191] trunk/LayoutTests








Revision 93191
Author aba...@webkit.org
Date 2011-08-16 18:41:29 -0700 (Tue, 16 Aug 2011)


Log Message
Add new chromium-mac-leopard directory to match the chromium-mac that
tony^work added.  This directory will house Skia results for Chromium Mac.

* platform/chromium-mac-leopard: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/




Diff

Modified: trunk/LayoutTests/ChangeLog (93190 => 93191)

--- trunk/LayoutTests/ChangeLog	2011-08-17 01:38:35 UTC (rev 93190)
+++ trunk/LayoutTests/ChangeLog	2011-08-17 01:41:29 UTC (rev 93191)
@@ -1,3 +1,10 @@
+2011-08-16  Adam Barth  aba...@webkit.org
+
+Add new chromium-mac-leopard directory to match the chromium-mac that
+tony^work added.  This directory will house Skia results for Chromium Mac.
+
+* platform/chromium-mac-leopard: Added.
+
 2011-08-16  Hayato Ito  hay...@chromium.org
 
 Add two sample mismatch reftests to make sure that reftests work correctly.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93193] branches/chromium/835/Source/WebCore/loader/ CrossOriginAccessControl.cpp

[levin]

Title: [93193] branches/chromium/835/Source/WebCore/loader/CrossOriginAccessControl.cpp








Revision 93193
Author le...@chromium.org
Date 2011-08-16 18:54:03 -0700 (Tue, 16 Aug 2011)


Log Message
Merge 93188 - REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

* loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for origin in here.

TBR=le...@chromium.org
Review URL: http://codereview.chromium.org/7669011

Modified Paths

branches/chromium/835/Source/WebCore/loader/CrossOriginAccessControl.cpp




Diff

Modified: branches/chromium/835/Source/WebCore/loader/CrossOriginAccessControl.cpp (93192 => 93193)

--- branches/chromium/835/Source/WebCore/loader/CrossOriginAccessControl.cpp	2011-08-17 01:41:56 UTC (rev 93192)
+++ branches/chromium/835/Source/WebCore/loader/CrossOriginAccessControl.cpp	2011-08-17 01:54:03 UTC (rev 93193)
@@ -46,7 +46,8 @@
 if (equalIgnoringCase(name, accept)
 || equalIgnoringCase(name, accept-language)
 || equalIgnoringCase(name, content-language)
-|| equalIgnoringCase(name, origin))
+|| equalIgnoringCase(name, origin)
+|| equalIgnoringCase(name, referer))
 return true;
 
 // Preflight is required for MIME types that can not be sent via form submission.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93194] trunk/Source/WebCore

[jeffm]

Title: [93194] trunk/Source/WebCore








Revision 93194
Author je...@apple.com
Date 2011-08-16 21:49:15 -0700 (Tue, 16 Aug 2011)


Log Message
Apple's Windows production build should fail to compile if AVFoundation is not enabled
https://bugs.webkit.org/show_bug.cgi?id=66339

Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Reviewed by Darin Adler.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (93193 => 93194)

--- trunk/Source/WebCore/ChangeLog	2011-08-17 01:54:03 UTC (rev 93193)
+++ trunk/Source/WebCore/ChangeLog	2011-08-17 04:49:15 UTC (rev 93194)
@@ -1,3 +1,14 @@
+2011-08-16  Jeff Miller  je...@apple.com
+
+Apple's Windows production build should fail to compile if AVFoundation is not enabled
+https://bugs.webkit.org/show_bug.cgi?id=66339
+
+Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
+
+Reviewed by Darin Adler.
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).
+
 2011-08-16  David Levin  le...@chromium.org
 
 REGRESSION (r89086): All worker xhr requests trigger preflight requests.


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp (93193 => 93194)

--- trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-17 01:54:03 UTC (rev 93193)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp	2011-08-17 04:49:15 UTC (rev 93194)
@@ -25,8 +25,10 @@
 
 #include config.h
 
-#if PLATFORM(WIN)  ENABLE(VIDEO)  USE(AVFOUNDATION)
+#if PLATFORM(WIN) ENABLE(VIDEO) 
 
+#if USE(AVFOUNDATION)
+
 #include MediaPlayerPrivateAVFoundationCF.h
 
 #include ApplicationCacheResource.h
@@ -1271,4 +1273,10 @@
 
 } // namespace WebCore
 
-#endif // PLATFORM(WIN)  ENABLE(VIDEO)  USE(AVFOUNDATION)
+#else
+// AVFoundation should always be enabled for Apple production builds.
+#if __PRODUCTION__  !USE(AVFOUNDATION)
+#error AVFoundation is not enabled!
+#endif // __PRODUCTION__  !USE(AVFOUNDATION)
+#endif // USE(AVFOUNDATION)
+#endif // PLATFORM(WIN)  ENABLE(VIDEO)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93195] trunk/Source/WebCore

[macpherson]

Title: [93195] trunk/Source/WebCore








Revision 93195
Author macpher...@chromium.org
Date 2011-08-16 21:51:25 -0700 (Tue, 16 Aug 2011)


Log Message
Represent RenderStyle::textOverflow property using an enum instead of a bool.
https://bugs.webkit.org/show_bug.cgi?id=66356

Reviewed by Dan Bernstein.

No new tests - no behavioral changes.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from TextOverflow to CSSPrimitiveValue.
(WebCore::CSSPrimitiveValue::operator TextOverflow):
Support cast from CSSPrimitiveValue to TextOverflow.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textOverflow):
Return TextOverflow enum.
(WebCore::InheritedFlags::setTextOverflow):
Accept TextOverflow enum parameter.
(WebCore::InheritedFlags::initialTextOverflow):
Return TextOverflowClip.
* rendering/style/RenderStyleConstants.h:
Define TextOverflow enum.
* rendering/style/StyleRareNonInheritedData.h:
Change representation of text overflow from bool to one-bit unsigned.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (93194 => 93195)

--- trunk/Source/WebCore/ChangeLog	2011-08-17 04:49:15 UTC (rev 93194)
+++ trunk/Source/WebCore/ChangeLog	2011-08-17 04:51:25 UTC (rev 93195)
@@ -1,3 +1,32 @@
+2011-08-16  Luke Macpherson   macpher...@chromium.org
+
+Represent RenderStyle::textOverflow property using an enum instead of a bool.
+https://bugs.webkit.org/show_bug.cgi?id=66356
+
+Reviewed by Dan Bernstein.
+
+No new tests - no behavioral changes.
+
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+Support cast from TextOverflow to CSSPrimitiveValue.
+(WebCore::CSSPrimitiveValue::operator TextOverflow):
+Support cast from CSSPrimitiveValue to TextOverflow.
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.
+* rendering/style/RenderStyle.h:
+(WebCore::InheritedFlags::textOverflow):
+Return TextOverflow enum.
+(WebCore::InheritedFlags::setTextOverflow):
+Accept TextOverflow enum parameter.
+(WebCore::InheritedFlags::initialTextOverflow):
+Return TextOverflowClip.
+* rendering/style/RenderStyleConstants.h:
+Define TextOverflow enum.
+* rendering/style/StyleRareNonInheritedData.h:
+Change representation of text overflow from bool to one-bit unsigned.
+
 2011-08-16  Jeff Miller  je...@apple.com
 
 Apple's Windows production build should fail to compile if AVFoundation is not enabled


Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (93194 => 93195)

--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2011-08-17 04:49:15 UTC (rev 93194)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2011-08-17 04:51:25 UTC (rev 93195)
@@ -2321,6 +2321,33 @@
 }
 }
 
+template inline CSSPrimitiveValue::CSSPrimitiveValue(TextOverflow overflow)
+: m_type(CSS_IDENT)
+, m_hasCachedCSSText(false)
+{
+switch (overflow) {
+case TextOverflowClip:
+m_value.ident = CSSValueClip;
+break;
+case TextOverflowEllipsis:
+m_value.ident = CSSValueEllipsis;
+break;
+}
+}
+
+template inline CSSPrimitiveValue::operator TextOverflow() const
+{
+switch (m_value.ident) {
+case CSSValueClip:
+return TextOverflowClip;
+case CSSValueEllipsis:
+return TextOverflowEllipsis;
+default:
+ASSERT_NOT_REACHED();
+return TextOverflowClip;
+}
+}
+
 template inline CSSPrimitiveValue::CSSPrimitiveValue(TextEmphasisFill fill)
 : m_type(CSS_IDENT)
 , m_hasCachedCSSText(false)


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (93194 => 93195)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-17 04:49:15 UTC (rev 93194)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-17 04:51:25 UTC (rev 93195)
@@ -4698,10 +4698,7 @@
 case CSSPropertyTextOverflow: {
 // This property is supported by WinIE, and so we leave off the -webkit- in order to
 // work with WinIE-specific pages that use the property.
-HANDLE_INHERIT_AND_INITIAL(textOverflow, TextOverflow)
-if (!primitiveValue || !primitiveValue-getIdent())
-return;
-m_style-setTextOverflow(primitiveValue-getIdent() == CSSValueEllipsis);
+