[webkit-changes] [93494] trunk/LayoutTests
Title: [93494] trunk/LayoutTests Revision 93494 Author zol...@webkit.org Date 2011-08-22 01:05:59 -0700 (Mon, 22 Aug 2011) Log Message [Qt][ARM] Skip flaky tests. * platform/qt-arm/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-arm/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (93493 => 93494) --- trunk/LayoutTests/ChangeLog 2011-08-22 04:04:06 UTC (rev 93493) +++ trunk/LayoutTests/ChangeLog 2011-08-22 08:05:59 UTC (rev 93494) @@ -1,3 +1,9 @@ +2011-08-22 Zoltan Horvath + +[Qt][ARM] Skip flaky tests. + +* platform/qt-arm/Skipped: + 2011-08-21 Darin Adler Update results for more tests affected by the addition of the Modified: trunk/LayoutTests/platform/qt-arm/Skipped (93493 => 93494) --- trunk/LayoutTests/platform/qt-arm/Skipped 2011-08-22 04:04:06 UTC (rev 93493) +++ trunk/LayoutTests/platform/qt-arm/Skipped 2011-08-22 08:05:59 UTC (rev 93494) @@ -47,6 +47,8 @@ # Flakey tests svg/animations/animate-mpath-insert.html svg/dom/SVGScriptElement/script-load-and-error-events.svg +http/tests/cache/subresource-multiple-instances.html +http/tests/inspector/resource-tree/resource-tree-errors-reload.html # Flakey timed out tests fast/js/nested-object-gc.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93495] branches/chromium/835
Title: [93495] branches/chromium/835
Revision 93495
Author cev...@google.com
Date 2011-08-22 01:39:01 -0700 (Mon, 22 Aug 2011)
Log Message
Merge 93397
BUG=76771
Review URL: http://codereview.chromium.org/7697013
Modified Paths
branches/chromium/835/LayoutTests/platform/chromium/test_expectations.txt
branches/chromium/835/Source/WebCore/bindings/v8/V8GCController.cpp
Diff
Modified: branches/chromium/835/LayoutTests/platform/chromium/test_expectations.txt (93494 => 93495)
--- branches/chromium/835/LayoutTests/platform/chromium/test_expectations.txt 2011-08-22 08:05:59 UTC (rev 93494)
+++ branches/chromium/835/LayoutTests/platform/chromium/test_expectations.txt 2011-08-22 08:39:01 UTC (rev 93495)
@@ -198,6 +198,15 @@
// Would have to be implemented much differently to work in v8.
WONTFIX : fast/dom/gc-10.html = FAIL
+// Proper retention of CSS objects is tricky. Disable the tests for now.
+
+BUGWK66377 : fast/dom/StyleSheet/gc-declaration-parent-rule.html = TEXT
+BUGWK66377 : fast/dom/StyleSheet/gc-inline-style-cssvalues.html = TEXT
+BUGWK66377 : fast/dom/StyleSheet/gc-parent-rule.html = TEXT
+BUGWK66377 : fast/dom/StyleSheet/gc-parent-stylesheet.html = TEXT
+BUGWK66377 : fast/dom/StyleSheet/gc-rule-children-wrappers.html = TEXT
+BUGWK66377 : fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml = TEXT
+
// This fails because we're missing various useless apple-specific
// properties on the window object.
// This test also timeouts in Debug mode.
Modified: branches/chromium/835/Source/WebCore/bindings/v8/V8GCController.cpp (93494 => 93495)
--- branches/chromium/835/Source/WebCore/bindings/v8/V8GCController.cpp 2011-08-22 08:05:59 UTC (rev 93494)
+++ branches/chromium/835/Source/WebCore/bindings/v8/V8GCController.cpp 2011-08-22 08:39:01 UTC (rev 93495)
@@ -286,40 +286,6 @@
return GroupId(root);
}
-static GroupId calculateGroupId(StyleBase* styleBase)
-{
-ASSERT(styleBase);
-StyleBase* current = styleBase;
-StyleSheet* styleSheet = 0;
-while (true) {
-// Special case: CSSStyleDeclarations might be either inline and in this case
-// we need to group them with their node or regular ones.
-if (current->isMutableStyleDeclaration()) {
-CSSMutableStyleDeclaration* cssMutableStyleDeclaration = static_cast(current);
-if (cssMutableStyleDeclaration->isInlineStyleDeclaration())
-return calculateGroupId(cssMutableStyleDeclaration->node());
-// Either we have no parent, or this parent is a CSSRule.
-ASSERT(cssMutableStyleDeclaration->parent() == cssMutableStyleDeclaration->parentRule());
-}
-
-if (current->isStyleSheet())
-styleSheet = static_cast(current);
-
-StyleBase* parent = current->parent();
-if (!parent)
-break;
-current = parent;
-}
-
-if (styleSheet) {
-if (Node* ownerNode = styleSheet->ownerNode())
-return calculateGroupId(ownerNode);
-return GroupId(styleSheet);
-}
-
-return GroupId(current);
-}
-
class GrouperVisitor : public DOMWrapperMap::Visitor, public DOMWrapperMap::Visitor {
public:
void visitDOMWrapper(DOMDataStore* store, Node* node, v8::Persistent wrapper)
@@ -347,49 +313,6 @@
void visitDOMWrapper(DOMDataStore* store, void* object, v8::Persistent wrapper)
{
-WrapperTypeInfo* typeInfo = V8DOMWrapper::domWrapperType(wrapper);
-
-if (typeInfo->isSubclass(&V8StyleSheetList::info)) {
-StyleSheetList* styleSheetList = static_cast(object);
-GroupId groupId(styleSheetList);
-if (Document* document = styleSheetList->document())
-groupId = GroupId(document);
-m_grouper.append(GrouperItem(groupId, wrapper));
-
-} else if (typeInfo->isSubclass(&V8DOMImplementation::info)) {
-DOMImplementation* domImplementation = static_cast(object);
-GroupId groupId(domImplementation);
-if (Document* document = domImplementation->document())
-groupId = GroupId(document);
-m_grouper.append(GrouperItem(groupId, wrapper));
-
-} else if (typeInfo->isSubclass(&V8StyleSheet::info) || typeInfo->isSubclass(&V8CSSRule::info)) {
-m_grouper.append(GrouperItem(calculateGroupId(static_cast(object)), wrapper));
-
-} else if (typeInfo->isSubclass(&V8CSSStyleDeclaration::info)) {
-CSSStyleDeclaration* cssStyleDeclaration = static_cast(object);
-
-GroupId groupId = calculateGroupId(cssStyleDeclaration);
-m_grouper.append(GrouperItem(groupId, wrapper));
-
-// Keep alive "dirty" primitive values (i.e. the ones that
-// have user-added properties) by creating implicit
-// references between the style declaration and the values
-// in it.
-if (cssStyleDeclaration->isMutableStyleDeclaration()) {
-CSSMutableS
[webkit-changes] [93496] branches/chromium/835
Title: [93496] branches/chromium/835
Revision 93496
Author cev...@google.com
Date 2011-08-22 01:49:53 -0700 (Mon, 22 Aug 2011)
Log Message
Merge 92132
BUG=89991
Review URL: http://codereview.chromium.org/7693022
Modified Paths
branches/chromium/835/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Added Paths
branches/chromium/835/LayoutTests/fast/block/update-midpoints-for-trailing-boxes-crash-expected.txt
branches/chromium/835/LayoutTests/fast/block/update-midpoints-for-trailing-boxes-crash.html
Diff
Copied: branches/chromium/835/LayoutTests/fast/block/update-midpoints-for-trailing-boxes-crash-expected.txt (from rev 92132, trunk/LayoutTests/fast/block/update-midpoints-for-trailing-boxes-crash-expected.txt) (0 => 93496)
--- branches/chromium/835/LayoutTests/fast/block/update-midpoints-for-trailing-boxes-crash-expected.txt (rev 0)
+++ branches/chromium/835/LayoutTests/fast/block/update-midpoints-for-trailing-boxes-crash-expected.txt 2011-08-22 08:49:53 UTC (rev 93496)
@@ -0,0 +1 @@
+PASS, does not crash
Copied: branches/chromium/835/LayoutTests/fast/block/update-midpoints-for-trailing-boxes-crash.html (from rev 92132, trunk/LayoutTests/fast/block/update-midpoints-for-trailing-boxes-crash.html) (0 => 93496)
--- branches/chromium/835/LayoutTests/fast/block/update-midpoints-for-trailing-boxes-crash.html (rev 0)
+++ branches/chromium/835/LayoutTests/fast/block/update-midpoints-for-trailing-boxes-crash.html 2011-08-22 08:49:53 UTC (rev 93496)
@@ -0,0 +1,28 @@
+
+
+
+
+.a {
+ display: table-cell;
+ white-space: nowrap;
+}
+.b {
+ padding-left: 4px;
+ white-space: pre-wrap;
+}
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
+
+
+PASS,
+
+does not crash
+
+
+
+
+
Modified: branches/chromium/835/Source/WebCore/rendering/RenderBlockLineLayout.cpp (93495 => 93496)
--- branches/chromium/835/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2011-08-22 08:39:01 UTC (rev 93495)
+++ branches/chromium/835/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2011-08-22 08:49:53 UTC (rev 93496)
@@ -1838,7 +1838,7 @@
if (lineMidpointState.numMidpoints % 2) {
// Find the trailing space object's midpoint.
int trailingSpaceMidpoint = lineMidpointState.numMidpoints - 1;
-for ( ; trailingSpaceMidpoint >= 0 && lineMidpointState.midpoints[trailingSpaceMidpoint].m_obj != m_whitespace; --trailingSpaceMidpoint) { }
+for ( ; trailingSpaceMidpoint > 0 && lineMidpointState.midpoints[trailingSpaceMidpoint].m_obj != m_whitespace; --trailingSpaceMidpoint) { }
ASSERT(trailingSpaceMidpoint >= 0);
if (collapseFirstSpace == CollapseFirstSpace)
lineMidpointState.midpoints[trailingSpaceMidpoint].m_pos--;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93497] branches/chromium/835
Title: [93497] branches/chromium/835
Revision 93497
Author cev...@google.com
Date 2011-08-22 01:56:12 -0700 (Mon, 22 Aug 2011)
Log Message
Merge 93227
BUG=92959
Review URL: http://codereview.chromium.org/7694026
Modified Paths
branches/chromium/835/Source/WebCore/dom/ProcessingInstruction.cpp
branches/chromium/835/Source/WebCore/dom/StyleElement.cpp
branches/chromium/835/Source/WebCore/dom/StyleElement.h
branches/chromium/835/Source/WebCore/html/HTMLLinkElement.cpp
branches/chromium/835/Source/WebCore/html/HTMLStyleElement.cpp
branches/chromium/835/Source/WebCore/svg/SVGStyleElement.cpp
Added Paths
branches/chromium/835/LayoutTests/svg/dom/resources/stylesheet-candidate-node-crash.svg
branches/chromium/835/LayoutTests/svg/dom/stylesheet-candidate-node-crash-main-expected.txt
branches/chromium/835/LayoutTests/svg/dom/stylesheet-candidate-node-crash-main.html
Diff
Copied: branches/chromium/835/LayoutTests/svg/dom/resources/stylesheet-candidate-node-crash.svg (from rev 93227, trunk/LayoutTests/svg/dom/resources/stylesheet-candidate-node-crash.svg) (0 => 93497)
--- branches/chromium/835/LayoutTests/svg/dom/resources/stylesheet-candidate-node-crash.svg (rev 0)
+++ branches/chromium/835/LayoutTests/svg/dom/resources/stylesheet-candidate-node-crash.svg 2011-08-22 08:56:12 UTC (rev 93497)
@@ -0,0 +1,8 @@
+
+
+PASS
+
+
+
Copied: branches/chromium/835/LayoutTests/svg/dom/stylesheet-candidate-node-crash-main-expected.txt (from rev 93227, trunk/LayoutTests/svg/dom/stylesheet-candidate-node-crash-main-expected.txt) (0 => 93497)
--- branches/chromium/835/LayoutTests/svg/dom/stylesheet-candidate-node-crash-main-expected.txt (rev 0)
+++ branches/chromium/835/LayoutTests/svg/dom/stylesheet-candidate-node-crash-main-expected.txt 2011-08-22 08:56:12 UTC (rev 93497)
@@ -0,0 +1 @@
+Test passes if it does not crash.
Copied: branches/chromium/835/LayoutTests/svg/dom/stylesheet-candidate-node-crash-main.html (from rev 93227, trunk/LayoutTests/svg/dom/stylesheet-candidate-node-crash-main.html) (0 => 93497)
--- branches/chromium/835/LayoutTests/svg/dom/stylesheet-candidate-node-crash-main.html (rev 0)
+++ branches/chromium/835/LayoutTests/svg/dom/stylesheet-candidate-node-crash-main.html 2011-08-22 08:56:12 UTC (rev 93497)
@@ -0,0 +1,19 @@
+
+
+Test passes if it does not crash.
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function runTest() {
+svgdoc = document.getElementById('root').contentDocument;
+var style = document.createElement('style');
+var test1 = svgdoc.getElementById('test1');
+test1.appendChild(style);
+svgdoc.getElementById('test2').setAttribute('xlink:href', 0);
+svgdoc.getElementById('test').setAttribute('stroke', 0);
+}
+
+
+
+
Modified: branches/chromium/835/Source/WebCore/dom/ProcessingInstruction.cpp (93496 => 93497)
--- branches/chromium/835/Source/WebCore/dom/ProcessingInstruction.cpp 2011-08-22 08:49:53 UTC (rev 93496)
+++ branches/chromium/835/Source/WebCore/dom/ProcessingInstruction.cpp 2011-08-22 08:56:12 UTC (rev 93497)
@@ -62,6 +62,9 @@
if (m_cachedSheet)
m_cachedSheet->removeClient(this);
+
+if (inDocument())
+document()->removeStyleSheetCandidateNode(this);
}
void ProcessingInstruction::setData(const String& data, ExceptionCode&)
Modified: branches/chromium/835/Source/WebCore/dom/StyleElement.cpp (93496 => 93497)
--- branches/chromium/835/Source/WebCore/dom/StyleElement.cpp 2011-08-22 08:49:53 UTC (rev 93496)
+++ branches/chromium/835/Source/WebCore/dom/StyleElement.cpp 2011-08-22 08:56:12 UTC (rev 93497)
@@ -84,6 +84,15 @@
document->styleSelectorChanged(DeferRecalcStyle);
}
+void StyleElement::clearDocumentData(Document* document, Element* element)
+{
+if (m_sheet)
+m_sheet->clearOwnerNode();
+
+if (element->inDocument())
+document->removeStyleSheetCandidateNode(element);
+}
+
void StyleElement::childrenChanged(Element* element)
{
ASSERT(element);
Modified: branches/chromium/835/Source/WebCore/dom/StyleElement.h (93496 => 93497)
--- branches/chromium/835/Source/WebCore/dom/StyleElement.h 2011-08-22 08:49:53 UTC (rev 93496)
+++ branches/chromium/835/Source/WebCore/dom/StyleElement.h 2011-08-22 08:56:12 UTC (rev 93497)
@@ -45,6 +45,7 @@
void insertedIntoDocument(Document*, Element*);
void removedFromDocument(Document*, Element*);
+void clearDocumentData(Document*, Element*);
void childrenChanged(Element*);
void finishParsingChildren(Element*);
Modified: branches/chromium/835/Source/WebCore/html/HTMLLinkElement.cpp (93496 => 93497)
--- branches/chromium/835/Source/WebCore/html/HTMLLinkElement.cpp 2011-08-22 08:49:53 UTC (rev 93496)
+++ branches/chromium/835/Source/WebCore/html/HTMLLinkElement.cpp 2011-08-22 08:56:12 UTC (rev 93497)
@@ -76,6 +76,9 @@
m_cachedSheet->removeClient(this);
removePendingSheet();
}
+
+
[webkit-changes] [93498] branches/chromium/835
Title: [93498] branches/chromium/835
Revision 93498
Author cev...@google.com
Date 2011-08-22 02:04:29 -0700 (Mon, 22 Aug 2011)
Log Message
Merge 93032
BUG=92769
Review URL: http://codereview.chromium.org/7693023
Modified Paths
branches/chromium/835/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
Added Paths
branches/chromium/835/LayoutTests/fast/html/process-end-tag-for-inbody-crash-expected.txt
branches/chromium/835/LayoutTests/fast/html/process-end-tag-for-inbody-crash.html
Diff
Copied: branches/chromium/835/LayoutTests/fast/html/process-end-tag-for-inbody-crash-expected.txt (from rev 93032, trunk/LayoutTests/fast/html/process-end-tag-for-inbody-crash-expected.txt) (0 => 93498)
--- branches/chromium/835/LayoutTests/fast/html/process-end-tag-for-inbody-crash-expected.txt (rev 0)
+++ branches/chromium/835/LayoutTests/fast/html/process-end-tag-for-inbody-crash-expected.txt 2011-08-22 09:04:29 UTC (rev 93498)
@@ -0,0 +1 @@
+PASS
Copied: branches/chromium/835/LayoutTests/fast/html/process-end-tag-for-inbody-crash.html (from rev 93032, trunk/LayoutTests/fast/html/process-end-tag-for-inbody-crash.html) (0 => 93498)
--- branches/chromium/835/LayoutTests/fast/html/process-end-tag-for-inbody-crash.html (rev 0)
+++ branches/chromium/835/LayoutTests/fast/html/process-end-tag-for-inbody-crash.html 2011-08-22 09:04:29 UTC (rev 93498)
@@ -0,0 +1,8 @@
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+document.body.innerHTML = "PASS";
+
+
Modified: branches/chromium/835/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (93497 => 93498)
--- branches/chromium/835/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2011-08-22 08:56:12 UTC (rev 93497)
+++ branches/chromium/835/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2011-08-22 09:04:29 UTC (rev 93498)
@@ -605,13 +605,13 @@
m_framesetOk = false;
HTMLElementStack::ElementRecord* nodeRecord = m_tree.openElements()->topRecord();
while (1) {
-ContainerNode* node = nodeRecord->node();
-if (shouldClose(node)) {
+RefPtr node = nodeRecord->node();
+if (shouldClose(node.get())) {
ASSERT(node->isElementNode());
-processFakeEndTag(toElement(node)->tagQName());
+processFakeEndTag(toElement(node.get())->tagQName());
break;
}
-if (isSpecialNode(node) && !node->hasTagName(addressTag) && !node->hasTagName(divTag) && !node->hasTagName(pTag))
+if (isSpecialNode(node.get()) && !node->hasTagName(addressTag) && !node->hasTagName(divTag) && !node->hasTagName(pTag))
break;
nodeRecord = nodeRecord->next();
}
@@ -1556,7 +1556,7 @@
ASSERT(token.type() == HTMLTokenTypes::EndTag);
HTMLElementStack::ElementRecord* record = m_tree.openElements()->topRecord();
while (1) {
-ContainerNode* node = record->node();
+RefPtr node = record->node();
if (node->hasLocalName(token.name())) {
m_tree.generateImpliedEndTags();
// FIXME: The ElementRecord pointed to by record might be deleted by
@@ -1570,13 +1570,13 @@
// http://www.w3.org/Bugs/Public/show_bug.cgi?id=10080
// We might have already popped the node for the token in
// generateImpliedEndTags, just abort.
-if (!m_tree.openElements()->contains(toElement(node)))
+if (!m_tree.openElements()->contains(toElement(node.get(
return;
}
-m_tree.openElements()->popUntilPopped(toElement(node));
+m_tree.openElements()->popUntilPopped(toElement(node.get()));
return;
}
-if (isSpecialNode(node)) {
+if (isSpecialNode(node.get())) {
parseError(token);
return;
}
@@ -1633,7 +1633,7 @@
}
// 4.
ASSERT(furthestBlock->isAbove(formattingElementRecord));
-ContainerNode* commonAncestor = formattingElementRecord->next()->node();
+RefPtr commonAncestor = formattingElementRecord->next()->node();
// 5.
HTMLFormattingElementList::Bookmark bookmark = m_tree.activeFormattingElements()->bookmarkFor(formattingElement);
// 6.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93499] branches/chromium/835
Title: [93499] branches/chromium/835
Revision 93499
Author cev...@google.com
Date 2011-08-22 02:07:56 -0700 (Mon, 22 Aug 2011)
Log Message
Merge 93347
BUG=90357
Review URL: http://codereview.chromium.org/7696023
Modified Paths
branches/chromium/835/LayoutTests/editing/text-iterator/first-letter-word-boundary-expected.txt
branches/chromium/835/LayoutTests/editing/text-iterator/first-letter-word-boundary.html
branches/chromium/835/Source/WebCore/editing/TextIterator.cpp
branches/chromium/835/Source/WebCore/editing/TextIterator.h
Added Paths
branches/chromium/835/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt
branches/chromium/835/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash.html
Diff
Copied: branches/chromium/835/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt (from rev 93347, trunk/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt) (0 => 93499)
--- branches/chromium/835/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt (rev 0)
+++ branches/chromium/835/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt 2011-08-22 09:07:56 UTC (rev 93499)
@@ -0,0 +1 @@
+PASS if WebKit did not hit assertions
Copied: branches/chromium/835/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash.html (from rev 93347, trunk/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash.html) (0 => 93499)
--- branches/chromium/835/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash.html (rev 0)
+++ branches/chromium/835/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash.html 2011-08-22 09:07:56 UTC (rev 93499)
@@ -0,0 +1,15 @@
+
+div:first-letter { margin-top: 0em; }
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+function done() {
+document.body.innerHTML = 'PASS if WebKit did not hit assertions';
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+AB
Modified: branches/chromium/835/LayoutTests/editing/text-iterator/first-letter-word-boundary-expected.txt (93498 => 93499)
--- branches/chromium/835/LayoutTests/editing/text-iterator/first-letter-word-boundary-expected.txt 2011-08-22 09:04:29 UTC (rev 93498)
+++ branches/chromium/835/LayoutTests/editing/text-iterator/first-letter-word-boundary-expected.txt 2011-08-22 09:07:56 UTC (rev 93499)
@@ -2,9 +2,9 @@
hello world'
white-space: normal;
-FAIL: moving forward by word put caret at offset 4 but expected 6
-PASS: moving backward by word put caret at offset 0
+FAIL: moving forward by word from offset 4 put caret at offset 10 but expected 6
+PASS: moving backward by word from offset 4 put caret at offset 1
white-space: pre;
-FAIL: moving forward by word put caret at offset 4 but expected 6
-PASS: moving backward by word put caret at offset 0
+FAIL: moving forward by word from offset 4 put caret at offset 10 but expected 6
+PASS: moving backward by word from offset 4 put caret at offset 1
Modified: branches/chromium/835/LayoutTests/editing/text-iterator/first-letter-word-boundary.html (93498 => 93499)
--- branches/chromium/835/LayoutTests/editing/text-iterator/first-letter-word-boundary.html 2011-08-22 09:04:29 UTC (rev 93498)
+++ branches/chromium/835/LayoutTests/editing/text-iterator/first-letter-word-boundary.html 2011-08-22 09:07:56 UTC (rev 93499)
@@ -20,7 +20,8 @@
layoutTestController.dumpAsText();
function runTest(actor, expectedOffset) {
-var action = "" + ' put caret at offset ';
+window.getSelection().setPosition(test.firstChild, 4);
+var action = "" + ' from offset ' + 4 + ' put caret at offset ';
var startOffset = window.getSelection().getRangeAt(0).startOffset;
action += startOffset;
if (startOffset == expectedOffset)
@@ -31,16 +32,15 @@
var test = document.getElementById('test');
var console = document.getElementById('console');
-window.getSelection().setPosition(test, 0);
console.innerHTML += 'white-space: normal;\n';
runTest(function () {window.getSelection().modify('move', 'forward', 'word'); return 'moving forward by word';}, 6);
-runTest(function () {window.getSelection().modify('move', 'backward', 'word'); return 'moving backward by word';}, 0);
+runTest(function () {window.getSelection().modify('move', 'backward', 'word'); return 'moving backward by word';}, 1);
console.innerHTML += 'white-space: pre;\n';
test.style.whiteSpace = 'pre';
runTest(function () {window.getSelection().modify('move', 'forward', 'word'); return 'moving forward by word';}, 6);
-runTest(function () {window.getSelection().modify('move', 'backward', 'word'); return 'moving backward by word';}, 0);
+runTest(function () {window.getSelection().modify('m
[webkit-changes] [93500] trunk/LayoutTests
Title: [93500] trunk/LayoutTests Revision 93500 Author zol...@webkit.org Date 2011-08-22 02:09:01 -0700 (Mon, 22 Aug 2011) Log Message [Qt][ARM] Add bug report to flaky tests http/tests/cache/subresource-multiple-instances.html https://bugs.webkit.org/show_bug.cgi?id=66652 http/tests/inspector/resource-tree/resource-tree-errors-reload.html https://bugs.webkit.org/show_bug.cgi?id=66653 * platform/qt-arm/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-arm/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (93499 => 93500) --- trunk/LayoutTests/ChangeLog 2011-08-22 09:07:56 UTC (rev 93499) +++ trunk/LayoutTests/ChangeLog 2011-08-22 09:09:01 UTC (rev 93500) @@ -1,5 +1,17 @@ 2011-08-22 Zoltan Horvath +[Qt][ARM] Add bug report to flaky tests + +http/tests/cache/subresource-multiple-instances.html +https://bugs.webkit.org/show_bug.cgi?id=66652 + +http/tests/inspector/resource-tree/resource-tree-errors-reload.html +https://bugs.webkit.org/show_bug.cgi?id=66653 + +* platform/qt-arm/Skipped: + +2011-08-22 Zoltan Horvath + [Qt][ARM] Skip flaky tests. * platform/qt-arm/Skipped: Modified: trunk/LayoutTests/platform/qt-arm/Skipped (93499 => 93500) --- trunk/LayoutTests/platform/qt-arm/Skipped 2011-08-22 09:07:56 UTC (rev 93499) +++ trunk/LayoutTests/platform/qt-arm/Skipped 2011-08-22 09:09:01 UTC (rev 93500) @@ -47,10 +47,17 @@ # Flakey tests svg/animations/animate-mpath-insert.html svg/dom/SVGScriptElement/script-load-and-error-events.svg + +# Flakey timed out tests + +# [Qt][ARM] http/tests/cache/subresource-multiple-instances.html is flaky (timeout) +# https://bugs.webkit.org/show_bug.cgi?id=66652 http/tests/cache/subresource-multiple-instances.html + +# [Qt][ARM] http/tests/inspector/resource-tree/resource-tree-errors-reload.html is flaky (timeout) +# https://bugs.webkit.org/show_bug.cgi?id=66653 http/tests/inspector/resource-tree/resource-tree-errors-reload.html -# Flakey timed out tests fast/js/nested-object-gc.html # https://bugs.webkit.org/show_bug.cgi?id=64452 http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93501] trunk
Title: [93501] trunk Revision 93501 Author podivi...@chromium.org Date 2011-08-22 02:17:00 -0700 (Mon, 22 Aug 2011) Log Message Web Inspector: extract breakpoint management code to a separate class and add tests. https://bugs.webkit.org/show_bug.cgi?id=66224 Reviewed by Pavel Feldman. Source/WebCore: Test: inspector/debugger/breakpoint-manager.html * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/BreakpointManager.js: Added. (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype.uiSourceCodeAdded): (WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode): (WebInspector.BreakpointManager.prototype.setBreakpoint): (WebInspector.BreakpointManager.prototype.removeBreakpoint): (WebInspector.BreakpointManager.prototype._materializeBreakpoint): (WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged): (WebInspector.BreakpointManager.prototype._addBreakpointToUI): (WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI): (WebInspector.BreakpointManager.prototype._moveBreakpointInUI): (WebInspector.BreakpointManager.prototype._breakpoints): (WebInspector.BreakpointManager.prototype._breakpoint): (WebInspector.BreakpointManager.prototype._forEachBreakpoint): (WebInspector.BreakpointManager.prototype._setBreakpointInDebugger): (WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger): (WebInspector.BreakpointManager.prototype._breakpointResolved): (WebInspector.BreakpointManager.prototype.serializeBreakpoints): (WebInspector.BreakpointManager.prototype.reset): (WebInspector.BreakpointManager.prototype.debuggerReset): (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.serialize): (WebInspector.Breakpoint.deserialize): * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation): * inspector/front-end/SourceFile.js: (WebInspector.RawSourceCode.prototype.get rawSourceCode): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: LayoutTests: * inspector/debugger/breakpoint-manager-expected.txt: Added. * inspector/debugger/breakpoint-manager.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/front-end/DebuggerModel.js trunk/Source/WebCore/inspector/front-end/SourceFile.js trunk/Source/WebCore/inspector/front-end/WebKit.qrc trunk/Source/WebCore/inspector/front-end/inspector.html Added Paths trunk/LayoutTests/inspector/debugger/breakpoint-manager-expected.txt trunk/LayoutTests/inspector/debugger/breakpoint-manager.html trunk/Source/WebCore/inspector/front-end/BreakpointManager.js Diff Modified: trunk/LayoutTests/ChangeLog (93500 => 93501) --- trunk/LayoutTests/ChangeLog 2011-08-22 09:09:01 UTC (rev 93500) +++ trunk/LayoutTests/ChangeLog 2011-08-22 09:17:00 UTC (rev 93501) @@ -1,3 +1,13 @@ +2011-08-18 Pavel Podivilov + +Web Inspector: extract breakpoint management code to a separate class and add tests. +https://bugs.webkit.org/show_bug.cgi?id=66224 + +Reviewed by Pavel Feldman. + +* inspector/debugger/breakpoint-manager-expected.txt: Added. +* inspector/debugger/breakpoint-manager.html: Added. + 2011-08-22 Zoltan Horvath [Qt][ARM] Add bug report to flaky tests Added: trunk/LayoutTests/inspector/debugger/breakpoint-manager-expected.txt (0 => 93501) --- trunk/LayoutTests/inspector/debugger/breakpoint-manager-expected.txt (rev 0) +++ trunk/LayoutTests/inspector/debugger/breakpoint-manager-expected.txt 2011-08-22 09:17:00 UTC (rev 93501) @@ -0,0 +1,64 @@ +Tests BreakpointManager class. + + +Running: uiSourceCodeAdded +breakpointAdded(a.js, 10, foo == bar, true) +breakpointAdded(a.js, 20, , false) +breakpointAdded(b.js, 3, , true) +debuggerModel.setBreakpoint(a.js:10:0) + +Running: setAndRemoveBreakpoints +breakpointAdded(a.js, 10, foo == bar, true) +breakpointAdded(a.js, 20, , false) +breakpointAdded(b.js, 3, , true) +debuggerModel.setBreakpoint(a.js:10:0) +breakpointAdded(a.js, 30, , true) +debuggerModel.setBreakpoint(a.js:30:0) +breakpointRemoved(a.js, 30) +breakpointRemoved(a.js, 10) +debuggerModel.removeBreakpoint(a.js:10:0) +breakpointRemoved(a.js, 20) +debuggerModel.removeBreakpoint(a.js:30:0) + +Running: setBreakpointOnComment +breakpointAdded(a.js, 15, , true) +debuggerModel.setBreakpoint(a.js:15:0) +breakpointRemoved(a.js, 15) +breakpointAdded(a.js, 16, , true) + +Running: setBreakpointOutsideOfScript +breakpointAdded(a.js, 15, , true) +debuggerModel.setBreakpoint(a.js:15:0) + +Running: testNavigation +breakpointAdded(a.js, 10, foo == bar, true) +breakpointAdded(a.js, 20, , false) +breakpointAdded(b.js, 3, , true) +debuggerModel.setBreakpoint(a.js:10:0) + +Navigate to B. +debuggerModel.setBreakpoint(b.js:3:0) + +Navigate back to A. +breakpointRemoved(a.js, 10) +breakpointAdded(a.js, 11
[webkit-changes] [93502] trunk/Tools
Title: [93502] trunk/Tools
Revision 93502
Author o...@webkit.org
Date 2011-08-22 03:05:48 -0700 (Mon, 22 Aug 2011)
Log Message
[ORWT] Fix --reset-results --add-platform-exceptions combo
https://bugs.webkit.org/show_bug.cgi?id=65464
Patch by Kristóf Kosztyó on 2011-08-22
Reviewed by Csaba Osztrogonác.
* Scripts/old-run-webkit-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/old-run-webkit-tests
Diff
Modified: trunk/Tools/ChangeLog (93501 => 93502)
--- trunk/Tools/ChangeLog 2011-08-22 09:17:00 UTC (rev 93501)
+++ trunk/Tools/ChangeLog 2011-08-22 10:05:48 UTC (rev 93502)
@@ -1,3 +1,12 @@
+2011-08-22 Kristóf Kosztyó
+
+[ORWT] Fix --reset-results --add-platform-exceptions combo
+https://bugs.webkit.org/show_bug.cgi?id=65464
+
+Reviewed by Csaba Osztrogonác.
+
+* Scripts/old-run-webkit-tests:
+
2011-08-20 Adam Barth
garden-o-matic summary.html should have UI for examining failures
Modified: trunk/Tools/Scripts/old-run-webkit-tests (93501 => 93502)
--- trunk/Tools/Scripts/old-run-webkit-tests 2011-08-22 09:17:00 UTC (rev 93501)
+++ trunk/Tools/Scripts/old-run-webkit-tests 2011-08-22 10:05:48 UTC (rev 93502)
@@ -954,8 +954,13 @@
}
if ($resetResults || !-f $expectedPNGPath) {
-mkpath catfile($expectedPixelDir, dirname($base)) if $testDirectory ne $expectedPixelDir;
-writeToFile($expectedPNGPath, $actualPNG);
+if (!$addPlatformExceptions) {
+mkpath catfile($expectedPixelDir, dirname($base)) if $testDirectory ne $expectedPixelDir;
+writeToFile($expectedPNGPath, $actualPNG);
+} else {
+mkpath catfile($platformTestDirectory, dirname($base));
+writeToFile("$platformTestDirectory/$base-$expectedTag.png", $actualPNG);
+}
}
}
@@ -969,8 +974,13 @@
$result = "new";
if ($generateNewResults || $resetResults) {
-mkpath catfile($expectedDir, dirname($base)) if $testDirectory ne $expectedDir;
-writeToFile("$expectedDir/$expectedFileName", $actual);
+if (!$addPlatformExceptions) {
+mkpath catfile($expectedDir, dirname($base)) if $testDirectory ne $expectedDir;
+writeToFile("$expectedDir/$expectedFileName", $actual);
+} else {
+mkpath catfile($platformTestDirectory, dirname($base));
+writeToFile("$platformTestDirectory/$expectedFileName", $actual);
+}
}
deleteExpectedAndActualResults($base);
recordActualResultsAndDiff($base, $actual);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93503] trunk/Source/WebCore
Title: [93503] trunk/Source/WebCore
Revision 93503
Author kei...@webkit.org
Date 2011-08-22 04:53:19 -0700 (Mon, 22 Aug 2011)
Log Message
Chrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets a new color
https://bugs.webkit.org/show_bug.cgi?id=66658
Reviewed by Kent Tamura.
* html/ColorInputType.cpp:
(WebCore::ColorInputType::colorSelected): Call setValueFromRenderer instead of setValue.
* html/ColorInputType.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/ColorInputType.cpp
trunk/Source/WebCore/html/ColorInputType.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (93502 => 93503)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 10:05:48 UTC (rev 93502)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 11:53:19 UTC (rev 93503)
@@ -1,3 +1,14 @@
+2011-08-22 Keishi Hattori
+
+Chrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets a new color
+https://bugs.webkit.org/show_bug.cgi?id=66658
+
+Reviewed by Kent Tamura.
+
+* html/ColorInputType.cpp:
+(WebCore::ColorInputType::colorSelected): Call setValueFromRenderer instead of setValue.
+* html/ColorInputType.h:
+
2011-08-18 Pavel Podivilov
Web Inspector: extract breakpoint management code to a separate class and add tests.
Modified: trunk/Source/WebCore/html/ColorInputType.cpp (93502 => 93503)
--- trunk/Source/WebCore/html/ColorInputType.cpp 2011-08-22 10:05:48 UTC (rev 93502)
+++ trunk/Source/WebCore/html/ColorInputType.cpp 2011-08-22 11:53:19 UTC (rev 93503)
@@ -105,11 +105,6 @@
return Color(element()->value());
}
-void ColorInputType::setValueAsColor(const Color& color) const
-{
-element()->setValue(color.serialized(), true);
-}
-
void ColorInputType::createShadowSubtree()
{
Document* document = element()->document();
@@ -174,7 +169,8 @@
{
if (element()->disabled() || element()->readOnly())
return;
-setValueAsColor(color);
+element()->setValueFromRenderer(color.serialized());
+updateColorSwatch();
}
bool ColorInputType::isColorInputType() const
Modified: trunk/Source/WebCore/html/ColorInputType.h (93502 => 93503)
--- trunk/Source/WebCore/html/ColorInputType.h 2011-08-22 10:05:48 UTC (rev 93502)
+++ trunk/Source/WebCore/html/ColorInputType.h 2011-08-22 11:53:19 UTC (rev 93503)
@@ -53,7 +53,6 @@
virtual String fallbackValue();
virtual String sanitizeValue(const String&);
virtual Color valueAsColor() const;
-virtual void setValueAsColor(const Color&) const;
virtual void createShadowSubtree();
virtual void valueChanged();
virtual void handleClickEvent(MouseEvent*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93504] trunk/Tools
Title: [93504] trunk/Tools
Revision 93504
Author o...@webkit.org
Date 2011-08-22 05:03:19 -0700 (Mon, 22 Aug 2011)
Log Message
Update contributor list.
Reviewed by Zoltan Herczeg.
* Scripts/webkitpy/common/config/committers.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/ChangeLog (93503 => 93504)
--- trunk/Tools/ChangeLog 2011-08-22 11:53:19 UTC (rev 93503)
+++ trunk/Tools/ChangeLog 2011-08-22 12:03:19 UTC (rev 93504)
@@ -1,3 +1,11 @@
+2011-08-22 Csaba Osztrogonác
+
+Update contributor list.
+
+Reviewed by Zoltan Herczeg.
+
+* Scripts/webkitpy/common/config/committers.py:
+
2011-08-22 Kristóf Kosztyó
[ORWT] Fix --reset-results --add-platform-exceptions combo
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (93503 => 93504)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-08-22 11:53:19 UTC (rev 93503)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-08-22 12:03:19 UTC (rev 93504)
@@ -72,6 +72,7 @@
contributors_who_are_not_committers = [
Contributor("Alexey Marinichev", ["amarinic...@chromium.org", "amarinic...@google.com"], "amarinichev"),
Contributor("Ami Fischman", "fisch...@chromium.org", "amifischman0"),
+Contributor("Andras Piroska", "pand...@inf.u-szeged.hu", "andris88"),
Contributor("Anna Cavender", "ann...@chromium.org", "annacc"),
Contributor("Anne van Kesteren", "annevankesteren+web...@gmail.com", "annevk"),
Contributor("Annie Sullivan", "sulli...@chromium.org", "annie"),
@@ -79,15 +80,21 @@
Contributor("David Grogan", "dgro...@chromium.org", "dgrogan"),
Contributor("Douglas Davidson", "ddavi...@apple.com"),
Contributor("Edward O'Connor", "eocon...@apple.com", "hober"),
+Contributor("Felician Marton", "felic...@inf.u-szeged.hu", "Felician"),
Contributor("Finnur Thorarinsson", "fin...@chromium.org", "finnur"),
Contributor("Greg Simon", "gregsi...@chromium.org", "gregsimon"),
Contributor("Gregg Tavares", ["g...@google.com", "g...@chromium.org"], "gman"),
Contributor("Ian Hickson", "i...@hixie.ch", "hixie"),
Contributor("John Bates", ["jba...@google.com", "jba...@chromium.org"], "jbates"),
Contributor("John Bauman", ["jbau...@chromium.org", "jbau...@google.com"], "jbauman"),
+Contributor("Kristof Kosztyo", "kkris...@inf.u-szeged.hu", "kkristof"),
+Contributor("Oliver Varga", "voli...@inf.u-szeged.hu", "TwistO"),
+Contributor("Peter Gal", "galpe...@inf.u-szeged.hu", "elecro"),
Contributor("Pierre Rossi", "pierre.ro...@gmail.com", "elproxy"),
Contributor("Tab Atkins", ["tabatk...@google.com", "jackalm...@gmail.com"], "tabatkins"),
+Contributor("Tamas Czene", "tcz...@inf.u-szeged.hu", "tczene"),
Contributor("Wyatt Carss", "wca...@chromium.org", "wcarss"),
+Contributor("Zsolt Feher", "fehe...@inf.u-szeged.hu", "Smith"),
]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93505] trunk/LayoutTests
Title: [93505] trunk/LayoutTests
Revision 93505
Author commit-qu...@webkit.org
Date 2011-08-22 05:06:38 -0700 (Mon, 22 Aug 2011)
Log Message
[Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open.
https://bugs.webkit.org/show_bug.cgi?id=66649
Patch by Takashi Toyoshima on 2011-08-22
Reviewed by Kent Tamura.
* http/tests/websocket/tests/hybi/close-before-open-expected.txt:
* http/tests/websocket/tests/hybi/close-before-open.html:
Add new URL to reproduce the problem.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/websocket/tests/hybi/close-before-open-expected.txt
trunk/LayoutTests/http/tests/websocket/tests/hybi/close-before-open.html
Diff
Modified: trunk/LayoutTests/ChangeLog (93504 => 93505)
--- trunk/LayoutTests/ChangeLog 2011-08-22 12:03:19 UTC (rev 93504)
+++ trunk/LayoutTests/ChangeLog 2011-08-22 12:06:38 UTC (rev 93505)
@@ -1,3 +1,14 @@
+2011-08-22 Takashi Toyoshima
+
+[Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open.
+https://bugs.webkit.org/show_bug.cgi?id=66649
+
+Reviewed by Kent Tamura.
+
+* http/tests/websocket/tests/hybi/close-before-open-expected.txt:
+* http/tests/websocket/tests/hybi/close-before-open.html:
+Add new URL to reproduce the problem.
+
2011-08-18 Pavel Podivilov
Web Inspector: extract breakpoint management code to a separate class and add tests.
Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/close-before-open-expected.txt (93504 => 93505)
--- trunk/LayoutTests/http/tests/websocket/tests/hybi/close-before-open-expected.txt 2011-08-22 12:03:19 UTC (rev 93504)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/close-before-open-expected.txt 2011-08-22 12:06:38 UTC (rev 93505)
@@ -1,9 +1,11 @@
CONSOLE MESSAGE: line 0: WebSocket is closed before the connection is established.
+CONSOLE MESSAGE: line 0: WebSocket is closed before the connection is established.
Test if Web Socket fires close event when WebSocket is opened and closed fore open event is received.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-closed
+closed on test 1
+closed on test 2
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/close-before-open.html (93504 => 93505)
--- trunk/LayoutTests/http/tests/websocket/tests/hybi/close-before-open.html 2011-08-22 12:03:19 UTC (rev 93504)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/close-before-open.html 2011-08-22 12:06:38 UTC (rev 93505)
@@ -14,13 +14,28 @@
if (window.layoutTestController)
layoutTestController.overridePreference("WebKitHixie76WebSocketProtocolEnabled", 0);
-var ws = new WebSocket("ws://127.0.0.1:8880/websocket/tests/hybi/hanging-handshake");
-ws._onclose_ = function() {
-debug("closed");
-finishJSTest();
+var urls = [
+"ws://127.0.0.1:8880/websocket/tests/hybi/hanging-handshake",
+"ws://127.0.0.1:8880/websocket/tests/hybi/close-code-and-reason"
+];
+
+var testId = 0;
+
+var test = function() {
+if (0 != testId)
+debug("closed on test " + testId);
+if (2 == testId)
+finishJSTest();
+else {
+ws = new WebSocket(urls[testId++]);
+ws._onclose_ = test;
+ws.close();
+}
};
+
+test();
+
var successfullyParsed = true;
-ws.close();
[webkit-changes] [93506] trunk/LayoutTests
Title: [93506] trunk/LayoutTests Revision 93506 Author vita...@chromium.org Date 2011-08-22 05:22:24 -0700 (Mon, 22 Aug 2011) Log Message 2011-08-22 Vitaly Repeshko [chromium] Updating test expectations. Unreviewed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (93505 => 93506) --- trunk/LayoutTests/ChangeLog 2011-08-22 12:06:38 UTC (rev 93505) +++ trunk/LayoutTests/ChangeLog 2011-08-22 12:22:24 UTC (rev 93506) @@ -1,3 +1,11 @@ +2011-08-22 Vitaly Repeshko + +[chromium] Updating test expectations. + +Unreviewed. + +* platform/chromium/test_expectations.txt: + 2011-08-22 Takashi Toyoshima [Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93505 => 93506) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-22 12:06:38 UTC (rev 93505) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-22 12:22:24 UTC (rev 93506) @@ -3691,3 +3691,5 @@ BUGWK66577 LEOPARD : fast/events/touch/touch-gesture-scroll.html = TIMEOUT BUGWK66577 LEOPARD : fast/events/touch/touch-target-limited.html = TIMEOUT BUGWK66577 LEOPARD : fast/events/touch/touch-target.html = TIMEOUT + +BUGV8_1634 : fast/js/const.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93507] trunk/Source/WebCore
Title: [93507] trunk/Source/WebCore
Revision 93507
Author benjamin.poul...@nokia.com
Date 2011-08-22 06:26:47 -0700 (Mon, 22 Aug 2011)
Log Message
Fix generate-inspector-idl for Python3 after r93396
https://bugs.webkit.org/show_bug.cgi?id=3
Reviewed by Andreas Kling.
In Python3, print is a function instead of a language keyword. Using parentheses
around the argument ensures the code works for both Python 2 and 3.
* inspector/generate-inspector-idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/generate-inspector-idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (93506 => 93507)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 12:22:24 UTC (rev 93506)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 13:26:47 UTC (rev 93507)
@@ -1,3 +1,15 @@
+2011-08-22 Benjamin Poulain
+
+Fix generate-inspector-idl for Python3 after r93396
+https://bugs.webkit.org/show_bug.cgi?id=3
+
+Reviewed by Andreas Kling.
+
+In Python3, print is a function instead of a language keyword. Using parentheses
+around the argument ensures the code works for both Python 2 and 3.
+
+* inspector/generate-inspector-idl:
+
2011-08-22 Keishi Hattori
Chrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets a new color
Modified: trunk/Source/WebCore/inspector/generate-inspector-idl (93506 => 93507)
--- trunk/Source/WebCore/inspector/generate-inspector-idl 2011-08-22 12:22:24 UTC (rev 93506)
+++ trunk/Source/WebCore/inspector/generate-inspector-idl 2011-08-22 13:26:47 UTC (rev 93507)
@@ -108,7 +108,7 @@
ref_type = ref_types[type_id]
return type_traits[ref_type["type"]]
else:
-print "Type not found: " + type_id
+print("Type not found: " + type_id)
return "!! Type not found: " + type_id
for domain in json_api:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93508] trunk/LayoutTests
Title: [93508] trunk/LayoutTests
Revision 93508
Author o...@webkit.org
Date 2011-08-22 06:43:30 -0700 (Mon, 22 Aug 2011)
Log Message
[NRWT] Fix "Only unexpected results" option of results.html
https://bugs.webkit.org/show_bug.cgi?id=66657
Patch by Kristóf Kosztyó on 2011-08-22
Reviewed by Csaba Osztrogonác.
* fast/harness/results.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/harness/results.html
Diff
Modified: trunk/LayoutTests/ChangeLog (93507 => 93508)
--- trunk/LayoutTests/ChangeLog 2011-08-22 13:26:47 UTC (rev 93507)
+++ trunk/LayoutTests/ChangeLog 2011-08-22 13:43:30 UTC (rev 93508)
@@ -1,3 +1,12 @@
+2011-08-22 Kristóf Kosztyó
+
+[NRWT] Fix "Only unexpected results" option of results.html
+https://bugs.webkit.org/show_bug.cgi?id=66657
+
+Reviewed by Csaba Osztrogonác.
+
+* fast/harness/results.html:
+
2011-08-22 Vitaly Repeshko
[chromium] Updating test expectations.
Modified: trunk/LayoutTests/fast/harness/results.html (93507 => 93508)
--- trunk/LayoutTests/fast/harness/results.html 2011-08-22 13:26:47 UTC (rev 93507)
+++ trunk/LayoutTests/fast/harness/results.html 2011-08-22 13:43:30 UTC (rev 93508)
@@ -871,7 +871,7 @@
function updateExpectedFailures()
{
-document.getElementById('unexpected-style').innerText = onlyShowUnexpectedFailures() ?
+document.getElementById('unexpected-style').textContent = onlyShowUnexpectedFailures() ?
'.expected { display: none; }' : '';
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93509] trunk/Tools
Title: [93509] trunk/Tools
Revision 93509
Author kbal...@webkit.org
Date 2011-08-22 08:17:13 -0700 (Mon, 22 Aug 2011)
Log Message
[Qt] ImageDiff does not consider --tolerance
https://bugs.webkit.org/show_bug.cgi?id=66299
Reviewed by Csaba Osztrogonác.
* DumpRenderTree/qt/ImageDiff.cpp:
(main):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp
Diff
Modified: trunk/Tools/ChangeLog (93508 => 93509)
--- trunk/Tools/ChangeLog 2011-08-22 13:43:30 UTC (rev 93508)
+++ trunk/Tools/ChangeLog 2011-08-22 15:17:13 UTC (rev 93509)
@@ -1,3 +1,13 @@
+2011-08-22 Balazs Kelemen
+
+[Qt] ImageDiff does not consider --tolerance
+https://bugs.webkit.org/show_bug.cgi?id=66299
+
+Reviewed by Csaba Osztrogonác.
+
+* DumpRenderTree/qt/ImageDiff.cpp:
+(main):
+
2011-08-22 Csaba Osztrogonác
Update contributor list.
Modified: trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp (93508 => 93509)
--- trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp 2011-08-22 13:43:30 UTC (rev 93508)
+++ trunk/Tools/DumpRenderTree/qt/ImageDiff.cpp 2011-08-22 15:17:13 UTC (rev 93509)
@@ -123,9 +123,9 @@
difference = qMax(difference, qreal(0.01));
}
-if (!count) {
+if (!difference)
fprintf(stdout, "diff: %01.2f%% passed\n", difference);
-} else {
+else {
QBuffer buffer;
buffer.open(QBuffer::WriteOnly);
diffImage.save(&buffer, "PNG");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93510] trunk/Source/WebCore
Title: [93510] trunk/Source/WebCore
Revision 93510
Author loi...@chromium.org
Date 2011-08-22 08:36:28 -0700 (Mon, 22 Aug 2011)
Log Message
Web Inspector: bind registerDomainDispatcher to domain names.
https://bugs.webkit.org/show_bug.cgi?id=66670
jscompiler can't be used for validating domain events dispatchers because registerDomainDispatcher is too generic.
I'd like to introduce named versions per each domain.
Reviewed by Pavel Feldman.
* inspector/CodeGeneratorInspector.pm:
(GenerateInterface):
(generateBackendStubJS):
* inspector/front-end/ApplicationCacheItemsView.js:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
* inspector/front-end/DOMStorage.js:
* inspector/front-end/Database.js:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
* inspector/front-end/TimelineManager.js:
(WebInspector.TimelineDispatcher):
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager):
* inspector/front-end/inspector.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm
trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
trunk/Source/WebCore/inspector/front-end/DOMAgent.js
trunk/Source/WebCore/inspector/front-end/DOMStorage.js
trunk/Source/WebCore/inspector/front-end/Database.js
trunk/Source/WebCore/inspector/front-end/DebuggerModel.js
trunk/Source/WebCore/inspector/front-end/NetworkManager.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js
trunk/Source/WebCore/inspector/front-end/TimelineManager.js
trunk/Source/WebCore/inspector/front-end/WorkerManager.js
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (93509 => 93510)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 15:36:28 UTC (rev 93510)
@@ -1,3 +1,35 @@
+2011-08-22 Ilya Tikhonovsky
+
+Web Inspector: bind registerDomainDispatcher to domain names.
+https://bugs.webkit.org/show_bug.cgi?id=66670
+
+jscompiler can't be used for validating domain events dispatchers because registerDomainDispatcher is too generic.
+I'd like to introduce named versions per each domain.
+
+Reviewed by Pavel Feldman.
+
+* inspector/CodeGeneratorInspector.pm:
+(GenerateInterface):
+(generateBackendStubJS):
+* inspector/front-end/ApplicationCacheItemsView.js:
+* inspector/front-end/ConsoleView.js:
+* inspector/front-end/DOMAgent.js:
+(WebInspector.DOMAgent):
+* inspector/front-end/DOMStorage.js:
+* inspector/front-end/Database.js:
+* inspector/front-end/DebuggerModel.js:
+(WebInspector.DebuggerModel):
+* inspector/front-end/NetworkManager.js:
+(WebInspector.NetworkDispatcher):
+* inspector/front-end/ProfilesPanel.js:
+* inspector/front-end/ResourceTreeModel.js:
+(WebInspector.ResourceTreeModel):
+* inspector/front-end/TimelineManager.js:
+(WebInspector.TimelineDispatcher):
+* inspector/front-end/WorkerManager.js:
+(WebInspector.WorkerManager):
+* inspector/front-end/inspector.js:
+
2011-08-22 Benjamin Poulain
Fix generate-inspector-idl for Python3 after r93396
Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm (93509 => 93510)
--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm 2011-08-22 15:17:13 UTC (rev 93509)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm 2011-08-22 15:36:28 UTC (rev 93510)
@@ -245,6 +245,7 @@
my @frontendConstantDeclarations;
my @frontendConstantDefinitions;
my @frontendFooter;
+my @frontendDomains;
# Default constructor
sub new
@@ -304,6 +305,7 @@
);
generateFunctions($interface, \%agent);
if (@{$agent{methodDeclarations}}) {
+push(@frontendDomains, $interface->name);
generateAgentDeclaration($interface, \%agent);
}
}
@@ -755,6 +757,7 @@
sub generateBackendStubJS
{
+my $JSRegisterDomainDispatchers = join("\n", map("this.register" . $_ . "Dispatcher = this._registerDomainDispatcher.bind(this, \"" . $_ ."\");", @frontendDomains));
my $JSStubs = join("\n", @backendJSStubs);
my $JSEvents = join("\n", @backendJSEvents);
my $inspectorBackendStubJS = << "EOF";
@@ -769,6 +772,7 @@
this._eventArgs = {};
$JSStubs
$JSEvents
+$JSRegisterDomainDispatchers
}
InspectorBackendStub.prototype = {
@@ -854,7 +858,7 @@
InspectorFrontendHost.sendMessageToBackend(message);
},
-registerDomainDispatcher: function(domain, dispa
[webkit-changes] [93511] trunk/Tools
Title: [93511] trunk/Tools
Revision 93511
Author commit-qu...@webkit.org
Date 2011-08-22 08:52:12 -0700 (Mon, 22 Aug 2011)
Log Message
Add myself to the contributor list.
https://bugs.webkit.org/show_bug.cgi?id=66674
Patch by Peter Beverloo on 2011-08-22
Reviewed by Tony Gentilcore.
* Scripts/webkitpy/common/config/committers.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/ChangeLog (93510 => 93511)
--- trunk/Tools/ChangeLog 2011-08-22 15:36:28 UTC (rev 93510)
+++ trunk/Tools/ChangeLog 2011-08-22 15:52:12 UTC (rev 93511)
@@ -1,3 +1,12 @@
+2011-08-22 Peter Beverloo
+
+Add myself to the contributor list.
+https://bugs.webkit.org/show_bug.cgi?id=66674
+
+Reviewed by Tony Gentilcore.
+
+* Scripts/webkitpy/common/config/committers.py:
+
2011-08-22 Balazs Kelemen
[Qt] ImageDiff does not consider --tolerance
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (93510 => 93511)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-08-22 15:36:28 UTC (rev 93510)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-08-22 15:52:12 UTC (rev 93511)
@@ -89,6 +89,7 @@
Contributor("John Bauman", ["jbau...@chromium.org", "jbau...@google.com"], "jbauman"),
Contributor("Kristof Kosztyo", "kkris...@inf.u-szeged.hu", "kkristof"),
Contributor("Oliver Varga", "voli...@inf.u-szeged.hu", "TwistO"),
+Contributor("Peter Beverloo", "pe...@chromium.org", "beverloo"),
Contributor("Peter Gal", "galpe...@inf.u-szeged.hu", "elecro"),
Contributor("Pierre Rossi", "pierre.ro...@gmail.com", "elproxy"),
Contributor("Tab Atkins", ["tabatk...@google.com", "jackalm...@gmail.com"], "tabatkins"),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93512] trunk/Source
Title: [93512] trunk/Source
Revision 93512
Author commit-qu...@webkit.org
Date 2011-08-22 09:02:11 -0700 (Mon, 22 Aug 2011)
Log Message
Source/WebCore: [Chromium] Crash when allocation of very large canvas fails
https://bugs.webkit.org/show_bug.cgi?id=66563
Replacing the crash with a more graceful failure: canvas
will not render.
Patch by Justin Novosad on 2011-08-22
Reviewed by Stephen White.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
Invoking TryCreateBitmapCanvas instead of CreateBitmapCanvas
This is the non-crashing version of the factory function.
It returns NULL if allocation fails. Code for handling
NULL pointer was already in place.
Source/WebKit/chromium: [Chromium] Crash when allocation of very large canvas fails
https://bugs.webkit.org/show_bug.cgi?id=66563
Patch by Justin Novosad on 2011-08-22
Reviewed by Stephen White.
* DEPS:
Bumping up the chrome DEPS to pick up 97474, which is
required by this patch.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebCore/ChangeLog (93511 => 93512)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 15:52:12 UTC (rev 93511)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 16:02:11 UTC (rev 93512)
@@ -1,3 +1,19 @@
+2011-08-22 Justin Novosad
+
+[Chromium] Crash when allocation of very large canvas fails
+https://bugs.webkit.org/show_bug.cgi?id=66563
+Replacing the crash with a more graceful failure: canvas
+will not render.
+
+Reviewed by Stephen White.
+
+* platform/graphics/skia/ImageBufferSkia.cpp:
+(WebCore::ImageBuffer::ImageBuffer):
+Invoking TryCreateBitmapCanvas instead of CreateBitmapCanvas
+This is the non-crashing version of the factory function.
+It returns NULL if allocation fails. Code for handling
+NULL pointer was already in place.
+
2011-08-22 Ilya Tikhonovsky
Web Inspector: bind registerDomainDispatcher to domain names.
Modified: trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (93511 => 93512)
--- trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2011-08-22 15:52:12 UTC (rev 93511)
+++ trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2011-08-22 16:02:11 UTC (rev 93512)
@@ -67,7 +67,7 @@
, m_size(size)
, m_accelerateRendering(false)
{
-OwnPtr canvas = adoptPtr(skia::CreateBitmapCanvas(size.width(), size.height(), false));
+OwnPtr canvas = adoptPtr(skia::TryCreateBitmapCanvas(size.width(), size.height(), false));
if (!canvas) {
success = false;
return;
Modified: trunk/Source/WebKit/chromium/ChangeLog (93511 => 93512)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-22 15:52:12 UTC (rev 93511)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-22 16:02:11 UTC (rev 93512)
@@ -1,3 +1,14 @@
+2011-08-22 Justin Novosad
+
+[Chromium] Crash when allocation of very large canvas fails
+https://bugs.webkit.org/show_bug.cgi?id=66563
+
+Reviewed by Stephen White.
+
+* DEPS:
+Bumping up the chrome DEPS to pick up 97474, which is
+required by this patch.
+
2011-08-20 Nebojsa Ciric
Add dependency on v8-i18n library. We used v8 repository before.
Modified: trunk/Source/WebKit/chromium/DEPS (93511 => 93512)
--- trunk/Source/WebKit/chromium/DEPS 2011-08-22 15:52:12 UTC (rev 93511)
+++ trunk/Source/WebKit/chromium/DEPS 2011-08-22 16:02:11 UTC (rev 93512)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '96940'
+ 'chromium_rev': '97474'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93513] trunk/LayoutTests
Title: [93513] trunk/LayoutTests
Revision 93513
Author mrobin...@webkit.org
Date 2011-08-22 10:07:55 -0700 (Mon, 22 Aug 2011)
Log Message
[GTK] Some GTK+-specific font-face tests fail on the bots
https://bugs.webkit.org/show_bug.cgi?id=65820
Fix the timing issues in this test.
Reviewed by Philippe Normand.
* platform/gtk/fonts/custom-font-missing-glyphs.html: Delay the test completion until
after document.readyState moves to "complete" and a short timeout.
* platform/gtk/fonts/font-face-with-complex-text.html: Ditto.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fonts/custom-font-missing-glyphs.html
trunk/LayoutTests/platform/gtk/fonts/font-face-with-complex-text.html
Diff
Modified: trunk/LayoutTests/ChangeLog (93512 => 93513)
--- trunk/LayoutTests/ChangeLog 2011-08-22 16:02:11 UTC (rev 93512)
+++ trunk/LayoutTests/ChangeLog 2011-08-22 17:07:55 UTC (rev 93513)
@@ -1,3 +1,16 @@
+2011-08-22 Martin Robinson
+
+[GTK] Some GTK+-specific font-face tests fail on the bots
+https://bugs.webkit.org/show_bug.cgi?id=65820
+
+Fix the timing issues in this test.
+
+Reviewed by Philippe Normand.
+
+* platform/gtk/fonts/custom-font-missing-glyphs.html: Delay the test completion until
+after document.readyState moves to "complete" and a short timeout.
+* platform/gtk/fonts/font-face-with-complex-text.html: Ditto.
+
2011-08-22 Kristóf Kosztyó
[NRWT] Fix "Only unexpected results" option of results.html
Modified: trunk/LayoutTests/platform/gtk/fonts/custom-font-missing-glyphs.html (93512 => 93513)
--- trunk/LayoutTests/platform/gtk/fonts/custom-font-missing-glyphs.html 2011-08-22 16:02:11 UTC (rev 93512)
+++ trunk/LayoutTests/platform/gtk/fonts/custom-font-missing-glyphs.html 2011-08-22 17:07:55 UTC (rev 93513)
@@ -6,6 +6,15 @@
font-family: MostlyEmptyFont;
}
+
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+document._onreadystatechange_ = function() {
+if (document.readyState === 'complete')
+setTimeout(function() {layoutTestController.notifyDone();}, 100);
+};
+}
+
A B C D E F G H I J K L M N O P Q R S T U V W X Y Z
Modified: trunk/LayoutTests/platform/gtk/fonts/font-face-with-complex-text.html (93512 => 93513)
--- trunk/LayoutTests/platform/gtk/fonts/font-face-with-complex-text.html 2011-08-22 16:02:11 UTC (rev 93512)
+++ trunk/LayoutTests/platform/gtk/fonts/font-face-with-complex-text.html 2011-08-22 17:07:55 UTC (rev 93513)
@@ -8,6 +8,15 @@
}
body { text-rendering: geometricPrecision; }
+
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+document._onreadystatechange_ = function() {
+if (document.readyState === 'complete')
+setTimeout(function() {layoutTestController.notifyDone();}, 100);
+};
+}
+
This text should be rendered with the default font:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93514] trunk
Title: [93514] trunk
Revision 93514
Author infe...@chromium.org
Date 2011-08-22 10:33:59 -0700 (Mon, 22 Aug 2011)
Log Message
Crash in FocusController::advanceFocusInDocumentOrder
https://bugs.webkit.org/show_bug.cgi?id=66678
Source/WebCore:
RefPtr the focusable node to prevent getting deleted by mutation
event.
Reviewed by Dave Hyatt.
Test: fast/frames/focus-controller-crash-change-event.html
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
LayoutTests:
Reviewed by Dave Hyatt.
* fast/frames/focus-controller-crash-change-event-expected.txt: Added.
* fast/frames/focus-controller-crash-change-event.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FocusController.cpp
Added Paths
trunk/LayoutTests/fast/frames/focus-controller-crash-change-event-expected.txt
trunk/LayoutTests/fast/frames/focus-controller-crash-change-event.html
Diff
Modified: trunk/LayoutTests/ChangeLog (93513 => 93514)
--- trunk/LayoutTests/ChangeLog 2011-08-22 17:07:55 UTC (rev 93513)
+++ trunk/LayoutTests/ChangeLog 2011-08-22 17:33:59 UTC (rev 93514)
@@ -1,3 +1,13 @@
+2011-08-22 Abhishek Arya
+
+Crash in FocusController::advanceFocusInDocumentOrder
+https://bugs.webkit.org/show_bug.cgi?id=66678
+
+Reviewed by Dave Hyatt.
+
+* fast/frames/focus-controller-crash-change-event-expected.txt: Added.
+* fast/frames/focus-controller-crash-change-event.html: Added.
+
2011-08-22 Martin Robinson
[GTK] Some GTK+-specific font-face tests fail on the bots
Added: trunk/LayoutTests/fast/frames/focus-controller-crash-change-event-expected.txt (0 => 93514)
--- trunk/LayoutTests/fast/frames/focus-controller-crash-change-event-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/frames/focus-controller-crash-change-event-expected.txt 2011-08-22 17:33:59 UTC (rev 93514)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/fast/frames/focus-controller-crash-change-event.html (0 => 93514)
--- trunk/LayoutTests/fast/frames/focus-controller-crash-change-event.html (rev 0)
+++ trunk/LayoutTests/fast/frames/focus-controller-crash-change-event.html 2011-08-22 17:33:59 UTC (rev 93514)
@@ -0,0 +1,32 @@
+
+
+Press a key!
+
+
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
+}
+
+a.addEventListener("change", function() {
+b.innerHTML = "PASS";
+
+ if (window.layoutTestController)
+ layoutTestController.notifyDone();
+});
+
+a.addEventListener("keyup", function() {
+var e = document.createEvent("KeyboardEvent");
+e.initKeyboardEvent('keydown', true, true, document.defaultView, 'U+0009', 0, false, false, false, false, false);
+a.dispatchEvent(e);
+})
+
+document.body.offsetTop;
+a.focus();
+
+if (window.layoutTestController)
+eventSender.keyDown('a');
+
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (93513 => 93514)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 17:07:55 UTC (rev 93513)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 17:33:59 UTC (rev 93514)
@@ -1,3 +1,18 @@
+2011-08-22 Abhishek Arya
+
+Crash in FocusController::advanceFocusInDocumentOrder
+https://bugs.webkit.org/show_bug.cgi?id=66678
+
+RefPtr the focusable node to prevent getting deleted by mutation
+event.
+
+Reviewed by Dave Hyatt.
+
+Test: fast/frames/focus-controller-crash-change-event.html
+
+* page/FocusController.cpp:
+(WebCore::FocusController::advanceFocusInDocumentOrder):
+
2011-08-22 Justin Novosad
[Chromium] Crash when allocation of very large canvas fails
Modified: trunk/Source/WebCore/page/FocusController.cpp (93513 => 93514)
--- trunk/Source/WebCore/page/FocusController.cpp 2011-08-22 17:07:55 UTC (rev 93513)
+++ trunk/Source/WebCore/page/FocusController.cpp 2011-08-22 17:33:59 UTC (rev 93514)
@@ -246,7 +246,7 @@
document->updateLayoutIgnorePendingStylesheets();
-Node* node = findFocusableNodeAcrossTreeScope(direction, currentNode ? currentNode->treeScope() : document, currentNode, event);
+RefPtr node = findFocusableNodeAcrossTreeScope(direction, currentNode ? currentNode->treeScope() : document, currentNode, event);
if (!node) {
// We didn't find a node to focus, so we should try to pass focus to Chrome.
@@ -259,7 +259,7 @@
// Chrome doesn't want focus, so we should wrap focus.
node = findFocusableNode(direction, m_page->mainFrame()->document(), 0, event);
-node = findFocusableNodeDecendingDownIntoFrameDocumentOrShadowRoot(direction, node, event);
+node = findFocusableNodeDecendingDownIntoFrameDocumentOrShadowRoot(direction, node.get(), event);
if (!node)
return false;
@@ -278,7 +278,7 @@
if (node->isFrameOwnerElement()) {
// We focus frames rat
[webkit-changes] [93515] trunk/Tools
Title: [93515] trunk/Tools
Revision 93515
Author commit-qu...@webkit.org
Date 2011-08-22 10:49:24 -0700 (Mon, 22 Aug 2011)
Log Message
Pass --makeargs of build-webkit to chromium linux builder
https://bugs.webkit.org/show_bug.cgi?id=66361
Patch by Xianzhu Wang on 2011-08-22
Reviewed by Tony Chang.
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(buildChromiumMakefile):
(buildChromium):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (93514 => 93515)
--- trunk/Tools/ChangeLog 2011-08-22 17:33:59 UTC (rev 93514)
+++ trunk/Tools/ChangeLog 2011-08-22 17:49:24 UTC (rev 93515)
@@ -1,3 +1,15 @@
+2011-08-22 Xianzhu Wang
+
+Pass --makeargs of build-webkit to chromium linux builder
+https://bugs.webkit.org/show_bug.cgi?id=66361
+
+Reviewed by Tony Chang.
+
+* Scripts/build-webkit:
+* Scripts/webkitdirs.pm:
+(buildChromiumMakefile):
+(buildChromium):
+
2011-08-22 Peter Beverloo
Add myself to the contributor list.
Modified: trunk/Tools/Scripts/build-webkit (93514 => 93515)
--- trunk/Tools/Scripts/build-webkit 2011-08-22 17:33:59 UTC (rev 93514)
+++ trunk/Tools/Scripts/build-webkit 2011-08-22 17:49:24 UTC (rev 93515)
@@ -578,6 +578,7 @@
@options = @ARGV;
# Chromium doesn't build by project directories.
@projects = ();
+push @options, "--makeargs=" . $makeArgs if $makeArgs;
my $result = buildChromium($clean, @options);
exit exitStatus($result) if exitStatus($result);
}
Modified: trunk/Tools/Scripts/webkitdirs.pm (93514 => 93515)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-08-22 17:33:59 UTC (rev 93514)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-08-22 17:49:24 UTC (rev 93515)
@@ -1823,17 +1823,22 @@
return buildAutotoolsProject($project, $clean, @buildArgs);
}
-sub buildChromiumMakefile($$)
+sub buildChromiumMakefile($$@)
{
-my ($target, $clean) = @_;
+my ($target, $clean, @options) = @_;
if ($clean) {
return system qw(rm -rf out);
}
my $config = configuration();
my $numCpus = numberOfCPUs();
-my @command = ("make", "-fMakefile.chromium", "-j$numCpus", "BUILDTYPE=$config", $target);
-print join(" ", @command) . "\n";
-return system @command;
+my $makeArgs;
+for (@options) {
+$makeArgs = $1 if /^--makeargs=(.*)/i;
+}
+$makeArgs = "-j$numCpus" if not $makeArgs;
+my $command = "make -fMakefile.chromium $makeArgs BUILDTYPE=$config $target";
+print "$command\n";
+return system $command;
}
sub buildChromiumVisualStudioProject($$)
@@ -1894,7 +1899,7 @@
$result = buildChromiumVisualStudioProject("Source/WebKit/chromium/WebKit.sln", $clean);
} elsif (isLinux()) {
# Linux build - build using make.
-$ result = buildChromiumMakefile("all", $clean);
+$result = buildChromiumMakefile("all", $clean, @options);
} else {
print STDERR "This platform is not supported by chromium.\n";
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93517] trunk
Title: [93517] trunk Revision 93517 Author commit-qu...@webkit.org Date 2011-08-22 11:00:59 -0700 (Mon, 22 Aug 2011) Log Message Patch by Young Han Lee on 2011-08-22 Reviewed by Dirk Schulze. SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end https://bugs.webkit.org/show_bug.cgi?id=63553 calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle of the animation duration. (e.g. begin="0s" end="2s" dur="3s") This change makes the function return the animations's true progress instead of 100% when the animation ends. Source/WebCore: Test: svg/animations/animate-end-attribute.html * svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat): LayoutTests: * svg/animations/animate-end-attribute-expected.txt: Added. * svg/animations/animate-end-attribute.html: Added. * svg/animations/script-tests/animate-end-attribute.js: Added. (sample1): (sample2): (sample3): (executeTest): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp Added Paths trunk/LayoutTests/svg/animations/animate-end-attribute-expected.txt trunk/LayoutTests/svg/animations/animate-end-attribute.html trunk/LayoutTests/svg/animations/script-tests/animate-end-attribute.js Diff Modified: trunk/LayoutTests/ChangeLog (93516 => 93517) --- trunk/LayoutTests/ChangeLog 2011-08-22 17:49:52 UTC (rev 93516) +++ trunk/LayoutTests/ChangeLog 2011-08-22 18:00:59 UTC (rev 93517) @@ -1,3 +1,25 @@ +2011-08-22 Young Han Lee + +Reviewed by Dirk Schulze. + +SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end +https://bugs.webkit.org/show_bug.cgi?id=63553 + +calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever +elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle +of the animation duration. (e.g. begin="0s" end="2s" dur="3s") + +This change makes the function return the animations's true progress instead of 100% +when the animation ends. + +* svg/animations/animate-end-attribute-expected.txt: Added. +* svg/animations/animate-end-attribute.html: Added. +* svg/animations/script-tests/animate-end-attribute.js: Added. +(sample1): +(sample2): +(sample3): +(executeTest): + 2011-08-22 Abhishek Arya Crash in FocusController::advanceFocusInDocumentOrder Added: trunk/LayoutTests/svg/animations/animate-end-attribute-expected.txt (0 => 93517) --- trunk/LayoutTests/svg/animations/animate-end-attribute-expected.txt (rev 0) +++ trunk/LayoutTests/svg/animations/animate-end-attribute-expected.txt 2011-08-22 18:00:59 UTC (rev 93517) @@ -0,0 +1,10 @@ +SVG 1.1 dynamic animation tests + +PASS rect.x.baseVal.value is 100 +PASS rect.x.baseVal.value is 50 +PASS rect.x.baseVal.value is 200 +PASS rect.x.baseVal.value is 200 +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/svg/animations/animate-end-attribute.html (0 => 93517) --- trunk/LayoutTests/svg/animations/animate-end-attribute.html (rev 0) +++ trunk/LayoutTests/svg/animations/animate-end-attribute.html 2011-08-22 18:00:59 UTC (rev 93517) @@ -0,0 +1,15 @@ + + + + + +SVG 1.1 dynamic animation tests + + +
[webkit-changes] [93519] trunk/LayoutTests
Title: [93519] trunk/LayoutTests Revision 93519 Author commit-qu...@webkit.org Date 2011-08-22 11:06:00 -0700 (Mon, 22 Aug 2011) Log Message [Chromium] plugins/keyboard-events.html should pass on linux/mac https://bugs.webkit.org/show_bug.cgi?id=65964 Patch by Noel Gordon on 2011-08-22 Reviewed by Tony Chang. Update the Chromium Linux test results following r88712. Also rebaseline test results for Chromium Mac. Note the WebKit Mac and Win ports both report 0 for the line number for all console.log() events. The Chromium port reports the actual line number, hence the need for separate test results for Chromium. The test now runs, and passes on all the Chromium ports, following r87855. The test confirms user-plugin interactivity, so we don't regress sites like youtube.com. Refer to bug 34936. * platform/chromium-linux/plugins/keyboard-events-expected.txt: Added. * platform/chromium-mac/plugins/keyboard-events-expected.txt: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-linux/plugins/keyboard-events-expected.txt trunk/LayoutTests/platform/chromium-mac/plugins/ trunk/LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (93518 => 93519) --- trunk/LayoutTests/ChangeLog 2011-08-22 18:03:49 UTC (rev 93518) +++ trunk/LayoutTests/ChangeLog 2011-08-22 18:06:00 UTC (rev 93519) @@ -1,3 +1,21 @@ +2011-08-22 Noel Gordon + +[Chromium] plugins/keyboard-events.html should pass on linux/mac +https://bugs.webkit.org/show_bug.cgi?id=65964 + +Reviewed by Tony Chang. + +Update the Chromium Linux test results following r88712. Also rebaseline test results +for Chromium Mac. Note the WebKit Mac and Win ports both report 0 for the line number +for all console.log() events. The Chromium port reports the actual line number, hence +the need for separate test results for Chromium. The test now runs, and passes on all +the Chromium ports, following r87855. The test confirms user-plugin interactivity, so +we don't regress sites like youtube.com. Refer to bug 34936. + +* platform/chromium-linux/plugins/keyboard-events-expected.txt: Added. +* platform/chromium-mac/plugins/keyboard-events-expected.txt: Added. +* platform/chromium/test_expectations.txt: + 2011-08-22 Ben Wells Rebaseline for webkit bug 65295 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93518 => 93519) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-22 18:03:49 UTC (rev 93518) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-22 18:06:00 UTC (rev 93519) @@ -747,9 +747,6 @@ BUGCR37962 MAC : plugins/iframe-shims.html = PASS TIMEOUT TEXT BUGCR10351 MAC : plugins/inner-html-display-none.html = FAIL BUGWK48164 : plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html = TEXT -// Need to implement NPP_HandleEvent in the layout_test_plugin -// WIN started failing during webkit roll 62670 -> 62844. -BUGCR38353 LINUX MAC : plugins/keyboard-events.html = TEXT // Object.keys on an NPObject produces the wrong output. BUGCR21901 : plugins/npruntime/enumerate.html = TEXT BUGCR50787 : plugins/npruntime/plugin-scriptable-object-invoke-default.html = TEXT Added: trunk/LayoutTests/platform/chromium-linux/plugins/keyboard-events-expected.txt (0 => 93519) --- trunk/LayoutTests/platform/chromium-linux/plugins/keyboard-events-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-linux/plugins/keyboard-events-expected.txt 2011-08-22 18:06:00 UTC (rev 93519) @@ -0,0 +1,11 @@ +CONSOLE MESSAGE: line 18: PLUGIN: getFocusEvent +CONSOLE MESSAGE: line 18: PLUGIN: mouseDown at (12, 12) +CONSOLE MESSAGE: line 19: PLUGIN: mouseUp at (12, 12) +CONSOLE MESSAGE: line 22: PLUGIN: keyDown ' ' +CONSOLE MESSAGE: line 22: PLUGIN: keyUp ' ' +CONSOLE MESSAGE: line 23: PLUGIN: keyDown ' ' +CONSOLE MESSAGE: line 23: PLUGIN: keyUp ' ' +CONSOLE MESSAGE: line 24: PLUGIN: keyDown ' ' +CONSOLE MESSAGE: line 24: PLUGIN: keyUp ' ' + +This test checks if a plug-in can receive keyboard events sent from eventSender. This is a test for Bug 34936. Added: trunk/LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt (0 => 93519) --- trunk/LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt 2011-08-22 18:06:00 UTC (rev 93519) @@ -0,0 +1,11 @@ +CONSOLE MESSAGE: line 18: PLUGIN: getFocusEvent +CONSOLE MESSAGE: line 18: PLUGIN: mouseDown at (12, 12) +CONSOLE MESSAGE: line 19: PLUGIN: mouseUp at (12, 12) +CONSOLE MESSAGE: line 22: PLUGIN: keyDown 'a' +CONSOLE MESSAGE: line 22: PLUGIN: keyUp 'a' +CONSOLE MESSAGE: line
[webkit-changes] [93520] trunk/LayoutTests
Title: [93520] trunk/LayoutTests Revision 93520 Author e...@google.com Date 2011-08-22 11:07:22 -0700 (Mon, 22 Aug 2011) Log Message [chromium] Skip rtl-composited, as it causes other tests to crash. Unreviewed expectation change. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (93519 => 93520) --- trunk/LayoutTests/ChangeLog 2011-08-22 18:06:00 UTC (rev 93519) +++ trunk/LayoutTests/ChangeLog 2011-08-22 18:07:22 UTC (rev 93520) @@ -1,3 +1,11 @@ +2011-08-22 Adrienne Walker + +[chromium] Skip rtl-composited, as it causes other tests to crash. + +Unreviewed expectation change. + +* platform/chromium/test_expectations.txt: + 2011-08-22 Noel Gordon [Chromium] plugins/keyboard-events.html should pass on linux/mac Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93519 => 93520) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-22 18:06:00 UTC (rev 93519) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-22 18:07:22 UTC (rev 93520) @@ -168,6 +168,8 @@ // Tests for WebVTT parser for . Feature is not yet functional. BUGWK43668 SKIP : media/track/ = TIMEOUT +BUGCR86239 MAC GPU SKIP : compositing/geometry/rtl-composited.html = PASS + // - // WONTFIX TESTS // - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93521] trunk
Title: [93521] trunk
Revision 93521
Author jap...@chromium.org
Date 2011-08-22 11:12:45 -0700 (Mon, 22 Aug 2011)
Log Message
Source/WebCore: Unload events can crash us when they blank out
a parent frame.
https://bugs.webkit.org/show_bug.cgi?id=64741
Reviewed by Adam Barth.
Test: fast/loader/document-destruction-within-unload.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading): Prevent unload events
from going into infinite recursion.
(WebCore::FrameLoader::setDocumentLoader): Ensure we don't
let set m_documentLoader to a DocumentLoader with a null Frame*.
(WebCore::FrameLoader::detachChildren): Save off a vector of
children to detach, rather than doing it inline.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=64741.
Reviewed by Adam Barth.
* fast/loader/document-destruction-within-unload-expected.txt: Added.
* fast/loader/document-destruction-within-unload.html: Added.
* fast/loader/resources/document-destruction-within-unload-iframe.html: Added.
* fast/loader/resources/document-destruction-within-unload.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
Added Paths
trunk/LayoutTests/fast/loader/document-destruction-within-unload-expected.txt
trunk/LayoutTests/fast/loader/document-destruction-within-unload.html
trunk/LayoutTests/fast/loader/resources/document-destruction-within-unload-iframe.html
trunk/LayoutTests/fast/loader/resources/document-destruction-within-unload.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (93520 => 93521)
--- trunk/LayoutTests/ChangeLog 2011-08-22 18:07:22 UTC (rev 93520)
+++ trunk/LayoutTests/ChangeLog 2011-08-22 18:12:45 UTC (rev 93521)
@@ -1,3 +1,14 @@
+2011-08-22 Nate Chapin
+
+Test for https://bugs.webkit.org/show_bug.cgi?id=64741.
+
+Reviewed by Adam Barth.
+
+* fast/loader/document-destruction-within-unload-expected.txt: Added.
+* fast/loader/document-destruction-within-unload.html: Added.
+* fast/loader/resources/document-destruction-within-unload-iframe.html: Added.
+* fast/loader/resources/document-destruction-within-unload.svg: Added.
+
2011-08-22 Adrienne Walker
[chromium] Skip rtl-composited, as it causes other tests to crash.
Added: trunk/LayoutTests/fast/loader/document-destruction-within-unload-expected.txt (0 => 93521)
--- trunk/LayoutTests/fast/loader/document-destruction-within-unload-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/loader/document-destruction-within-unload-expected.txt 2011-08-22 18:12:45 UTC (rev 93521)
@@ -0,0 +1,2 @@
+
+For the test to pass there should be no crash.
Added: trunk/LayoutTests/fast/loader/document-destruction-within-unload.html (0 => 93521)
--- trunk/LayoutTests/fast/loader/document-destruction-within-unload.html (rev 0)
+++ trunk/LayoutTests/fast/loader/document-destruction-within-unload.html 2011-08-22 18:12:45 UTC (rev 93521)
@@ -0,0 +1,17 @@
+
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function done() {
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+For the test to pass there should be no crash.
+
+
Added: trunk/LayoutTests/fast/loader/resources/document-destruction-within-unload-iframe.html (0 => 93521)
--- trunk/LayoutTests/fast/loader/resources/document-destruction-within-unload-iframe.html (rev 0)
+++ trunk/LayoutTests/fast/loader/resources/document-destruction-within-unload-iframe.html 2011-08-22 18:12:45 UTC (rev 93521)
@@ -0,0 +1,18 @@
+
+
+
+function runTest() {
+var test = document.getElementById('root').contentDocument;
+test.firstChild.setAttribute('onunload', "parent.clearUs();");
+location.reload();
+}
+
+function clearUs() {
+document.write();
+parent.done();
+}
+
+
+
+
Added: trunk/LayoutTests/fast/loader/resources/document-destruction-within-unload.svg (0 => 93521)
--- trunk/LayoutTests/fast/loader/resources/document-destruction-within-unload.svg (rev 0)
+++ trunk/LayoutTests/fast/loader/resources/document-destruction-within-unload.svg 2011-08-22 18:12:45 UTC (rev 93521)
@@ -0,0 +1,2 @@
+
+
Modified: trunk/Source/WebCore/ChangeLog (93520 => 93521)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 18:07:22 UTC (rev 93520)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 18:12:45 UTC (rev 93521)
@@ -1,3 +1,21 @@
+2011-08-22 Nate Chapin
+
+Unload events can crash us when they blank out
+a parent frame.
+https://bugs.webkit.org/show_bug.cgi?id=64741
+
+Reviewed by Adam Barth.
+
+Test: fast/loader/document-destruction-within-unload.html
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::stopLoading): Prevent unload events
+from going into infinite recursion.
+(WebCore::FrameLo
[webkit-changes] [93522] trunk/Tools
Title: [93522] trunk/Tools
Revision 93522
Author dglaz...@chromium.org
Date 2011-08-22 11:15:48 -0700 (Mon, 22 Aug 2011)
Log Message
garden-o-matic's relative time display should be updated regularly.
https://bugs.webkit.org/show_bug.cgi?id=66682
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (93521 => 93522)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2011-08-22 18:12:45 UTC (rev 93521)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js 2011-08-22 18:15:48 UTC (rev 93522)
@@ -67,5 +67,8 @@
var kTenMinutesInMilliseconds = 10 * 60 * 1000;
config.kUpdateFrequency = kTenMinutesInMilliseconds;
+config.kRelativeTimeUpdateFrequency = 1000;
+
+
})();
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (93521 => 93522)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-08-22 18:12:45 UTC (rev 93521)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-08-22 18:15:48 UTC (rev 93522)
@@ -80,22 +80,6 @@
}
});
-var Time = base.extends('time', {
-init: function()
-{
-this.setDate(new Date());
-},
-date: function()
-{
-return this._date;
-},
-setDate: function(date)
-{
-this._date = date;
-this.textContent = base.relativizeTime(date);
-}
-});
-
ui.notifications.FailingTest = base.extends('li', {
init: function(failureAnalysis)
{
@@ -135,7 +119,7 @@
ui.notifications.Failure = base.extends(ui.notifications.Notification, {
init: function()
{
-this._time = this.insertBefore(new Time(), this.firstChild);
+this._time = this.insertBefore(new ui.RelativeTime(), this.firstChild);
this._problem = this._what.appendChild(document.createElement('div'));
this._problem.className = 'problem';
this._effects = this._problem.appendChild(document.createElement('ul'));
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (93521 => 93522)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-08-22 18:12:45 UTC (rev 93521)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-08-22 18:15:48 UTC (rev 93522)
@@ -94,7 +94,7 @@
var testFailures = new ui.notifications.TestFailures();
equal(testFailures.tagName, 'LI');
equal(testFailures.innerHTML,
-'Just now' +
+'Just now' +
'' +
'' +
'' +
@@ -106,7 +106,7 @@
'');
testFailures.addFailureAnalysis({testName: 'test'});
equal(testFailures.innerHTML,
-'Just now' +
+'Just now' +
'' +
'' +
'' +
@@ -122,7 +122,7 @@
ok(!testFailures.containsFailureAnalysis({testName: 'foo'}));
testFailures.addFailureAnalysis({testName: 'test'});
equal(testFailures.innerHTML,
-'Just now' +
+'Just now' +
'' +
'' +
'' +
@@ -138,7 +138,7 @@
time.setMinutes(time.getMinutes() - 10);
testFailures.addCommitData({revision: 1, time: time, title: "title", author: "author", reviewer: "reviewer"});
equal(testFailures.innerHTML,
-'10 minutes ago' +
+'10 minutes ago' +
'' +
'' +
'' +
@@ -165,7 +165,7 @@
var builderFailing = new ui.notifications.BuildersFailing();
builderFailing.setFailingBuilders(['WebKit Linux', 'Webkit Vista']);
equal(builderFailing.innerHTML,
-'Just now' +
+'Just now' +
'' +
'Build Failed:' +
'' +
M
[webkit-changes] [93523] trunk/Source/WebCore
Title: [93523] trunk/Source/WebCore Revision 93523 Author commit-qu...@webkit.org Date 2011-08-22 11:18:59 -0700 (Mon, 22 Aug 2011) Log Message [chromium] Content and render surface textures not freed when compositor context destroyed https://bugs.webkit.org/show_bug.cgi?id=66589 Patch by James Robinson on 2011-08-22 Reviewed by Kenneth Russell. Explicitly delete all managed textures when destroying the compositor context. This regressed due to a combination of using share groups (so destroying a context no longer implicitly releases all resources in that context) and switching the TextureManager over to support deferred texture destruction. We sadly don't have a way to construct automated tests for resource leaks currently. * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::cleanupSharedObjects): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (93522 => 93523) --- trunk/Source/WebCore/ChangeLog 2011-08-22 18:15:48 UTC (rev 93522) +++ trunk/Source/WebCore/ChangeLog 2011-08-22 18:18:59 UTC (rev 93523) @@ -1,3 +1,22 @@ +2011-08-22 James Robinson + +[chromium] Content and render surface textures not freed when compositor context destroyed +https://bugs.webkit.org/show_bug.cgi?id=66589 + +Reviewed by Kenneth Russell. + +Explicitly delete all managed textures when destroying the compositor +context. This regressed due to a combination of using share groups +(so destroying a context no longer implicitly releases all resources +in that context) and switching the TextureManager over to support +deferred texture destruction. + +We sadly don't have a way to construct automated tests for resource +leaks currently. + +* platform/graphics/chromium/LayerRendererChromium.cpp: +(WebCore::LayerRendererChromium::cleanupSharedObjects): + 2011-08-22 Nate Chapin Unload events can crash us when they blank out Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (93522 => 93523) --- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-08-22 18:15:48 UTC (rev 93522) +++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-08-22 18:18:59 UTC (rev 93523) @@ -1283,7 +1283,13 @@ GLC(m_context.get(), m_context->deleteFramebuffer(m_offscreenFramebufferId)); // Clear tilers before the texture manager, as they have references to textures. +m_contentsTextureManager->unprotectAllTextures(); +m_contentsTextureManager->reduceMemoryToLimit(0); +m_contentsTextureManager->deleteEvictedTextures(m_context.get()); m_contentsTextureManager.clear(); +m_renderSurfaceTextureManager->unprotectAllTextures(); +m_renderSurfaceTextureManager->reduceMemoryToLimit(0); +m_renderSurfaceTextureManager->deleteEvictedTextures(m_context.get()); m_renderSurfaceTextureManager.clear(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93526] trunk/Source/WebCore
Title: [93526] trunk/Source/WebCore
Revision 93526
Author e...@google.com
Date 2011-08-22 11:49:42 -0700 (Mon, 22 Aug 2011)
Log Message
[chromium] Fix nullptr deref when switching composited tabs
https://bugs.webkit.org/show_bug.cgi?id=66691
Reviewed by James Robinson.
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::protectTileTextures):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (93525 => 93526)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 18:30:27 UTC (rev 93525)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 18:49:42 UTC (rev 93526)
@@ -1,3 +1,13 @@
+2011-08-22 Adrienne Walker
+
+[chromium] Fix nullptr deref when switching composited tabs
+https://bugs.webkit.org/show_bug.cgi?id=66691
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::protectTileTextures):
+
2011-08-22 James Robinson
[chromium] Content and render surface textures not freed when compositor context destroyed
Modified: trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp (93525 => 93526)
--- trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2011-08-22 18:30:27 UTC (rev 93525)
+++ trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2011-08-22 18:49:42 UTC (rev 93526)
@@ -357,7 +357,7 @@
void TiledLayerChromium::protectTileTextures(const IntRect& contentRect)
{
-if (contentRect.isEmpty())
+if (!m_tiler || contentRect.isEmpty())
return;
int left, top, right, bottom;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93527] trunk/Tools
Title: [93527] trunk/Tools Revision 93527 Author dpra...@chromium.org Date 2011-08-22 12:03:59 -0700 (Mon, 22 Aug 2011) Log Message fix the GPU bot names on the layout test dashboard https://bugs.webkit.org/show_bug.cgi?id=66697 Reviewed by Dimitri Glazkov. * TestResultServer/static-dashboards/builders.js: Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestResultServer/static-dashboards/builders.js Diff Modified: trunk/Tools/ChangeLog (93526 => 93527) --- trunk/Tools/ChangeLog 2011-08-22 18:49:42 UTC (rev 93526) +++ trunk/Tools/ChangeLog 2011-08-22 19:03:59 UTC (rev 93527) @@ -1,3 +1,12 @@ +2011-08-22 Dirk Pranke + +fix the GPU bot names on the layout test dashboard +https://bugs.webkit.org/show_bug.cgi?id=66697 + +Reviewed by Dimitri Glazkov. + +* TestResultServer/static-dashboards/builders.js: + 2011-08-22 Dimitri Glazkov garden-o-matic's relative time display should be updated regularly. Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (93526 => 93527) --- trunk/Tools/TestResultServer/static-dashboards/builders.js 2011-08-22 18:49:42 UTC (rev 93526) +++ trunk/Tools/TestResultServer/static-dashboards/builders.js 2011-08-22 19:03:59 UTC (rev 93527) @@ -144,11 +144,11 @@ ['Webkit Linux 32 - GPU'], ['Webkit Linux (dbg)(1) - GPU'], ['Webkit Linux (dbg)(2) - GPU'], -['Webkit Mac10.5 - GPU'], -['Webkit Mac10.5 (dbg)(1) - GPU'], -['Webkit Mac10.5 (dbg)(2) - GPU'], -['Webkit Mac10.6 - GPU'], -['Webkit Mac10.6 (dbg) - GPU'] +['Webkit Mac10.5 (CG) - GPU'], +['Webkit Mac10.5 (CG)(dbg)(1) - GPU'], +['Webkit Mac10.5 (CG)(dbg)(2) - GPU'], +['Webkit Mac10.6 (CG) - GPU'], +['Webkit Mac10.6 (CG)(dbg) - GPU'] ]; associateBuildersWithMaster(CHROMIUM_GPU_MESA_BUILDERS, CHROMIUM_WEBKIT_BUILDER_MASTER); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93528] trunk
Title: [93528] trunk Revision 93528 Author t...@chromium.org Date 2011-08-22 12:08:36 -0700 (Mon, 22 Aug 2011) Log Message Add CSS parsing of -webkit-flex-order https://bugs.webkit.org/show_bug.cgi?id=65384 Source/WebCore: The property is an int described here: http://dev.w3.org/csswg/css3-flexbox/#flex-order Doesn't do anything yet, just hooking it up. Reviewed by Ojan Vafai. * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): * css/CSSPropertyNames.in: * css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::flexOrder): (WebCore::InheritedFlags::setFlexOrder): (WebCore::InheritedFlags::initialFlexOrder): * rendering/style/StyleFlexibleBoxData.cpp: (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleFlexibleBoxData::operator==): * rendering/style/StyleFlexibleBoxData.h: LayoutTests: Reviewed by Ojan Vafai. * css3/flexbox/css-properties-expected.txt: * css3/flexbox/css-properties.html: * css3/flexbox/script-tests/css-properties.js: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/flexbox/css-properties-expected.txt trunk/LayoutTests/css3/flexbox/css-properties.html trunk/LayoutTests/css3/flexbox/script-tests/css-properties.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/StyleFlexibleBoxData.cpp trunk/Source/WebCore/rendering/style/StyleFlexibleBoxData.h Diff Modified: trunk/LayoutTests/ChangeLog (93527 => 93528) --- trunk/LayoutTests/ChangeLog 2011-08-22 19:03:59 UTC (rev 93527) +++ trunk/LayoutTests/ChangeLog 2011-08-22 19:08:36 UTC (rev 93528) @@ -1,3 +1,14 @@ +2011-08-22 Tony Chang + +Add CSS parsing of -webkit-flex-order +https://bugs.webkit.org/show_bug.cgi?id=65384 + +Reviewed by Ojan Vafai. + +* css3/flexbox/css-properties-expected.txt: +* css3/flexbox/css-properties.html: +* css3/flexbox/script-tests/css-properties.js: + 2011-08-22 Nate Chapin Test for https://bugs.webkit.org/show_bug.cgi?id=64741. Modified: trunk/LayoutTests/css3/flexbox/css-properties-expected.txt (93527 => 93528) --- trunk/LayoutTests/css3/flexbox/css-properties-expected.txt 2011-08-22 19:03:59 UTC (rev 93527) +++ trunk/LayoutTests/css3/flexbox/css-properties-expected.txt 2011-08-22 19:08:36 UTC (rev 93528) @@ -8,6 +8,13 @@ PASS div.style.display is "-webkit-inline-flexbox" PASS div.style.display is "-webkit-inline-flexbox" PASS div.style.display is "block" +PASS flexitem.style.webkitFlexOrder is "" +PASS flexitem.style.webkitFlexOrder is "2" +PASS flexitem.style.webkitFlexOrder is "-1" +PASS flexitem.style.webkitFlexOrder is "0" +PASS flexitem.style.webkitFlexOrder is "0" +PASS flexitem.style.webkitFlexOrder is "0" +PASS flexitem.style.webkitFlexOrder is "" PASS successfullyParsed is true TEST COMPLETE Modified: trunk/LayoutTests/css3/flexbox/css-properties.html (93527 => 93528) --- trunk/LayoutTests/css3/flexbox/css-properties.html 2011-08-22 19:03:59 UTC (rev 93527) +++ trunk/LayoutTests/css3/flexbox/css-properties.html 2011-08-22 19:08:36 UTC (rev 93528) @@ -6,6 +6,9 @@ + + +
[webkit-changes] [93529] trunk/LayoutTests
Title: [93529] trunk/LayoutTests
Revision 93529
Author rn...@webkit.org
Date 2011-08-22 12:12:59 -0700 (Mon, 22 Aug 2011)
Log Message
editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=66551
Reviewed by Adam Roben.
Replaced leapForward by dummy clicks to make it work on Windows and other ports.
* editing/selection/caret-at-bidi-boundary.html:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/selection/caret-at-bidi-boundary.html
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
Diff
Modified: trunk/LayoutTests/ChangeLog (93528 => 93529)
--- trunk/LayoutTests/ChangeLog 2011-08-22 19:08:36 UTC (rev 93528)
+++ trunk/LayoutTests/ChangeLog 2011-08-22 19:12:59 UTC (rev 93529)
@@ -1,3 +1,17 @@
+2011-08-22 Ryosuke Niwa
+
+editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added
+https://bugs.webkit.org/show_bug.cgi?id=66551
+
+Reviewed by Adam Roben.
+
+Replaced leapForward by dummy clicks to make it work on Windows and other ports.
+
+* editing/selection/caret-at-bidi-boundary.html:
+* platform/gtk/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+
2011-08-22 Tony Chang
Add CSS parsing of -webkit-flex-order
Modified: trunk/LayoutTests/editing/selection/caret-at-bidi-boundary.html (93528 => 93529)
--- trunk/LayoutTests/editing/selection/caret-at-bidi-boundary.html 2011-08-22 19:08:36 UTC (rev 93528)
+++ trunk/LayoutTests/editing/selection/caret-at-bidi-boundary.html 2011-08-22 19:12:59 UTC (rev 93529)
@@ -55,7 +55,11 @@
var previousOffset = -1;
var j = 0;
for (var x = 5; x <= target.offsetWidth - 5; x++) {
-eventSender.leapForward(1000);
+// Reset the click count
+eventSender.mouseMoveTo(1, 1);
+eventSender.mouseDown();
+eventSender.mouseUp();
+
eventSender.mouseMoveTo(target.offsetLeft + x, y);
eventSender.mouseDown();
eventSender.mouseUp();
Modified: trunk/LayoutTests/platform/gtk/Skipped (93528 => 93529)
--- trunk/LayoutTests/platform/gtk/Skipped 2011-08-22 19:08:36 UTC (rev 93528)
+++ trunk/LayoutTests/platform/gtk/Skipped 2011-08-22 19:12:59 UTC (rev 93529)
@@ -1621,7 +1621,3 @@
# This test verifies that a mismatch reftest will fail as intended if both results are same.
fast/harness/sample-fail-mismatch-reftest.html
-
-# [GTK] editing/selection/caret-at-bidi-boundary.html times out
-# https://bugs.webkit.org/show_bug.cgi?id=66621
-editing/selection/caret-at-bidi-boundary.html
Modified: trunk/LayoutTests/platform/qt/Skipped (93528 => 93529)
--- trunk/LayoutTests/platform/qt/Skipped 2011-08-22 19:08:36 UTC (rev 93528)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-08-22 19:12:59 UTC (rev 93529)
@@ -2373,10 +2373,6 @@
# This test verifies that a mismatch reftest will fail as intended if both results are same.
fast/harness/sample-fail-mismatch-reftest.html
-# [Qt] editing/selection/caret-at-bidi-boundary.html times out after r93369
-# https://bugs.webkit.org/show_bug.cgi?id=66514
-editing/selection/caret-at-bidi-boundary.html
-
# [Qt] editing/spelling/spelling-insert-html.html fails
# https://bugs.webkit.org/show_bug.cgi?id=66619
editing/spelling/spelling-insert-html.html
Modified: trunk/LayoutTests/platform/win/Skipped (93528 => 93529)
--- trunk/LayoutTests/platform/win/Skipped 2011-08-22 19:08:36 UTC (rev 93528)
+++ trunk/LayoutTests/platform/win/Skipped 2011-08-22 19:12:59 UTC (rev 93529)
@@ -1398,7 +1398,3 @@
# editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added
# https://bugs.webkit.org/show_bug.cgi?id=66551
editing/selection/caret-at-bidi-boundary.html
-
-# [Win] editing/spelling/spelling-insert-html.html fails
-# https://bugs.webkit.org/show_bug.cgi?id=66620
-editing/spelling/spelling-insert-html.html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93530] trunk/Tools
Title: [93530] trunk/Tools
Revision 93530
Author jam...@google.com
Date 2011-08-22 12:35:50 -0700 (Mon, 22 Aug 2011)
Log Message
[chromium] Update builder names for chromium gpu bots due to CG switchover
https://bugs.webkit.org/show_bug.cgi?id=66693
Reviewed by Dirk Pranke.
Update the port and builder names for the chromium mac gpu bots to
account for the CG transition.
* Scripts/webkitpy/layout_tests/port/builders.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (93529 => 93530)
--- trunk/Tools/ChangeLog 2011-08-22 19:12:59 UTC (rev 93529)
+++ trunk/Tools/ChangeLog 2011-08-22 19:35:50 UTC (rev 93530)
@@ -1,3 +1,15 @@
+2011-08-22 James Robinson
+
+[chromium] Update builder names for chromium gpu bots due to CG switchover
+https://bugs.webkit.org/show_bug.cgi?id=66693
+
+Reviewed by Dirk Pranke.
+
+Update the port and builder names for the chromium mac gpu bots to
+account for the CG transition.
+
+* Scripts/webkitpy/layout_tests/port/builders.py:
+
2011-08-22 Dirk Pranke
fix the GPU bot names on the layout test dashboard
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py (93529 => 93530)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py 2011-08-22 19:12:59 UTC (rev 93529)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py 2011-08-22 19:35:50 UTC (rev 93530)
@@ -51,14 +51,13 @@
"Webkit Mac10.5 (CG)(dbg)(2)": {"port_name": "chromium-cg-mac-leopard", "specifiers": set(["leopard", "debug"])},
"Webkit Mac10.6 (CG)": {"port_name": "chromium-cg-mac-snowleopard", "specifiers": set(["snowleopard"])},
"Webkit Mac10.6 (CG)(dbg)": {"port_name": "chromium-cg-mac-snowleopard", "specifiers": set(["snowleopard", "debug"])},
-"Webkit Mac10.6 - GPU": {"port_name": "chromium-gpu-mac-snowleopard", "specifiers": set(["snowleopard", "gpu"])},
"Webkit Win - GPU": {"port_name": "chromium-gpu-win-xp", "specifiers": set(["xp", "release", "gpu"])},
"Webkit Win7 - GPU": {"port_name": "chromium-gpu-win-win7", "specifiers": set(["win7", "vista", "release", "gpu"])},
# FIXME: For some reason, these port names don't work correctly.
# "Webkit Linux - GPU": {"port_name": "chromium-gpu-linux-x86_64", "specifiers": set(["linux", "gpu"])},
# "Webkit Linux 32 - GPU": {"port_name": "chromium-gpu-linux-x86", "specifiers": set(["linux", "x86", "gpu"])},
-"Webkit Mac10.5 - GPU": {"port_name": "chromium-gpu-mac-leopard", "specifiers": set(["leopard", "gpu"])},
-"Webkit Mac10.6 - GPU": {"port_name": "chromium-gpu-mac-snowleopard", "specifiers": set(["mac", "gpu"])},
+"Webkit Mac10.5 (CG) - GPU": {"port_name": "chromium-gpu-cg-mac-leopard", "specifiers": set(["leopard", "gpu"])},
+"Webkit Mac10.6 (CG) - GPU": {"port_name": "chromium-gpu-cg-mac-snowleopard", "specifiers": set(["mac", "gpu"])},
# These builders are on build.webkit.org.
"GTK Linux 32-bit Debug": {"port_name": "gtk", "specifiers": set(["gtk"])},
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (93529 => 93530)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-08-22 19:12:59 UTC (rev 93529)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-08-22 19:35:50 UTC (rev 93530)
@@ -44,13 +44,13 @@
elif platform.startswith('linux'):
port_name = 'chromium-gpu-linux'
elif platform == 'darwin':
-port_name = 'chromium-gpu-mac'
+port_name = 'chromium-gpu-cg-mac'
else:
raise NotImplementedError('unsupported platform: %s' % platform)
if port_name.startswith('chromium-gpu-linux'):
return ChromiumGpuLinuxPort(port_name=port_name, **kwargs)
-if port_name.startswith('chromium-gpu-mac'):
+if port_name.startswith('chromium-gpu-cg-mac'):
return ChromiumGpuMacPort(port_name=port_name, **kwargs)
if port_name.startswith('chromium-gpu-win'):
return ChromiumGpuWinPort(port_name=port_name, **kwargs)
@@ -77,7 +77,7 @@
def _tests(port, paths):
if not paths:
paths = ['compositing', 'platform/chromium/compositing', 'media', 'animations/3d']
-if not port.name().startswith('chromium-gpu-mac'):
+if not port.name().startswith('chromium-gpu-cg-mac'):
# Canvas is not yet accelerated on the Mac, so there's no point
# in running the tests there.
paths += ['fast/canvas', 'canvas/philip']
@@ -102,12 +102,12 @@
class ChromiumGpuMacPort(chromium_mac.ChromiumMacPort):
-def __init__(self, port_name='chromium-gpu-mac', **kwargs):
+def __init__(self, port_name='chromium-gpu-cg-mac', **kwargs):
chromium_mac.ChromiumMacPort.__init__(self
[webkit-changes] [93531] trunk/Source/WebCore
Title: [93531] trunk/Source/WebCore
Revision 93531
Author commit-qu...@webkit.org
Date 2011-08-22 13:05:51 -0700 (Mon, 22 Aug 2011)
Log Message
FrameSelection::setNonDirectionalSelectionIfNeeded should not have a FrameSelection passed to it
https://bugs.webkit.org/show_bug.cgi?id=66636
Patch by Wyatt Carss on 2011-08-22
Reviewed by Darin Adler.
setNonDirectionalSelection was moved into FrameSelection in r93134 for
bug 60529, and still took a FrameSelection as an argument, which has been removed.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/FrameSelection.cpp
trunk/Source/WebCore/editing/FrameSelection.h
trunk/Source/WebCore/page/EventHandler.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (93530 => 93531)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 19:35:50 UTC (rev 93530)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 20:05:51 UTC (rev 93531)
@@ -1,3 +1,16 @@
+2011-08-22 Wyatt Carss
+
+FrameSelection::setNonDirectionalSelectionIfNeeded should not have a FrameSelection passed to it
+https://bugs.webkit.org/show_bug.cgi?id=66636
+
+Reviewed by Darin Adler.
+
+setNonDirectionalSelection was moved into FrameSelection in r93134 for
+bug 60529, and still took a FrameSelection as an argument, which has been removed.
+
+* editing/FrameSelection.cpp:
+(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
+
2011-08-22 Tony Chang
Add CSS parsing of -webkit-flex-order
@@ -261,7 +274,7 @@
Add HTMLSourceElement to DOMWindow.idl for consistency. Constructors for
all elements should be available on DOMWindow.
- * bindings/generic/RuntimeEnabledFeatures.cpp:
+* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
* bindings/generic/RuntimeEnabledFeatures.h:
* page/DOMWindow.idl:
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (93530 => 93531)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2011-08-22 19:35:50 UTC (rev 93530)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2011-08-22 20:05:51 UTC (rev 93531)
@@ -163,15 +163,14 @@
updateCaretRect(document, m_position);
}
-void FrameSelection::setNonDirectionalSelectionIfNeeded(FrameSelection* selection, const VisibleSelection& passedNewSelection, TextGranularity granularity)
+void FrameSelection::setNonDirectionalSelectionIfNeeded(const VisibleSelection& passedNewSelection, TextGranularity granularity)
{
-ASSERT(selection);
VisibleSelection newSelection = passedNewSelection;
if (shouldAlwaysUseDirectionalSelection(m_frame))
newSelection.setIsDirectional(true);
-if (selection->selection() == newSelection || !selection->shouldChangeSelection(newSelection))
+if (m_selection == newSelection || !shouldChangeSelection(newSelection))
return;
setSelection(newSelection, granularity);
Modified: trunk/Source/WebCore/editing/FrameSelection.h (93530 => 93531)
--- trunk/Source/WebCore/editing/FrameSelection.h 2011-08-22 19:35:50 UTC (rev 93530)
+++ trunk/Source/WebCore/editing/FrameSelection.h 2011-08-22 20:05:51 UTC (rev 93531)
@@ -223,7 +223,7 @@
bool shouldChangeSelection(const VisibleSelection&) const;
bool shouldDeleteSelection(const VisibleSelection&) const;
-void setNonDirectionalSelectionIfNeeded(FrameSelection*, const VisibleSelection&, TextGranularity);
+void setNonDirectionalSelectionIfNeeded(const VisibleSelection&, TextGranularity);
void setFocusedNodeIfNeeded();
void notifyRendererOfSelectionChange(EUserTriggered);
Modified: trunk/Source/WebCore/page/EventHandler.cpp (93530 => 93531)
--- trunk/Source/WebCore/page/EventHandler.cpp 2011-08-22 19:35:50 UTC (rev 93530)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2011-08-22 20:05:51 UTC (rev 93531)
@@ -287,7 +287,7 @@
m_selectionInitiationState = PlacedCaret;
}
-m_frame->selection()->setNonDirectionalSelectionIfNeeded(m_frame->selection(), newSelection, granularity);
+m_frame->selection()->setNonDirectionalSelectionIfNeeded(newSelection, granularity);
return true;
}
@@ -690,7 +690,7 @@
if (m_frame->selection()->granularity() != CharacterGranularity)
newSelection.expandUsingGranularity(m_frame->selection()->granularity());
-m_frame->selection()->setNonDirectionalSelectionIfNeeded(m_frame->selection(), newSelection, m_frame->selection()->granularity());
+m_frame->selection()->setNonDirectionalSelectionIfNeeded(newSelection, m_frame->selection()->granularity());
}
#endif // ENABLE(DRAG_SUPPORT)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93532] trunk
Title: [93532] trunk Revision 93532 Author pkast...@chromium.org Date 2011-08-22 13:23:58 -0700 (Mon, 22 Aug 2011) Log Message Unreviewed, rolling out r93517. http://trac.webkit.org/changeset/93517 https://bugs.webkit.org/show_bug.cgi?id=63553 Breaks GTK Linux and Chromium Win Source/WebCore: * svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat): LayoutTests: * svg/animations/animate-end-attribute-expected.txt: Removed. * svg/animations/animate-end-attribute.html: Removed. * svg/animations/script-tests/animate-end-attribute.js: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp Removed Paths trunk/LayoutTests/svg/animations/animate-end-attribute-expected.txt trunk/LayoutTests/svg/animations/animate-end-attribute.html trunk/LayoutTests/svg/animations/script-tests/animate-end-attribute.js Diff Modified: trunk/LayoutTests/ChangeLog (93531 => 93532) --- trunk/LayoutTests/ChangeLog 2011-08-22 20:05:51 UTC (rev 93531) +++ trunk/LayoutTests/ChangeLog 2011-08-22 20:23:58 UTC (rev 93532) @@ -1,3 +1,15 @@ +2011-08-22 Peter Kasting + +Unreviewed, rolling out r93517. +http://trac.webkit.org/changeset/93517 +https://bugs.webkit.org/show_bug.cgi?id=63553 + +Breaks GTK Linux and Chromium Win + +* svg/animations/animate-end-attribute-expected.txt: Removed. +* svg/animations/animate-end-attribute.html: Removed. +* svg/animations/script-tests/animate-end-attribute.js: Removed. + 2011-08-22 Ryosuke Niwa editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added Deleted: trunk/LayoutTests/svg/animations/animate-end-attribute-expected.txt (93531 => 93532) --- trunk/LayoutTests/svg/animations/animate-end-attribute-expected.txt 2011-08-22 20:05:51 UTC (rev 93531) +++ trunk/LayoutTests/svg/animations/animate-end-attribute-expected.txt 2011-08-22 20:23:58 UTC (rev 93532) @@ -1,10 +0,0 @@ -SVG 1.1 dynamic animation tests - -PASS rect.x.baseVal.value is 100 -PASS rect.x.baseVal.value is 50 -PASS rect.x.baseVal.value is 200 -PASS rect.x.baseVal.value is 200 -PASS successfullyParsed is true - -TEST COMPLETE - Deleted: trunk/LayoutTests/svg/animations/animate-end-attribute.html (93531 => 93532) --- trunk/LayoutTests/svg/animations/animate-end-attribute.html 2011-08-22 20:05:51 UTC (rev 93531) +++ trunk/LayoutTests/svg/animations/animate-end-attribute.html 2011-08-22 20:23:58 UTC (rev 93532) @@ -1,15 +0,0 @@ - - - - - -SVG 1.1 dynamic animation tests - - -
[webkit-changes] [93534] trunk/LayoutTests
Title: [93534] trunk/LayoutTests Revision 93534 Author jam...@google.com Date 2011-08-22 13:38:52 -0700 (Mon, 22 Aug 2011) Log Message [chromium] Rename chromium-gpu-mac to chromium-gpu-cg-mac * platform/chromium-gpu-cg-mac: Copied from LayoutTests/platform/chromium-gpu-mac. * platform/chromium-gpu-mac: Removed. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-gpu-cg-mac/ Removed Paths trunk/LayoutTests/platform/chromium-gpu-mac/ Diff Modified: trunk/LayoutTests/ChangeLog (93533 => 93534) --- trunk/LayoutTests/ChangeLog 2011-08-22 20:34:56 UTC (rev 93533) +++ trunk/LayoutTests/ChangeLog 2011-08-22 20:38:52 UTC (rev 93534) @@ -1,3 +1,10 @@ +2011-08-22 James Robinson + +[chromium] Rename chromium-gpu-mac to chromium-gpu-cg-mac + +* platform/chromium-gpu-cg-mac: Copied from LayoutTests/platform/chromium-gpu-mac. +* platform/chromium-gpu-mac: Removed. + 2011-08-22 Peter Kasting Unreviewed, rolling out r93517. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93535] trunk/Source/WebKit/chromium
Title: [93535] trunk/Source/WebKit/chromium
Revision 93535
Author dglaz...@chromium.org
Date 2011-08-22 13:39:11 -0700 (Mon, 22 Aug 2011)
Log Message
Roll Chromium DEPS to 97698.
* DEPS: Rolled.
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (93534 => 93535)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-22 20:38:52 UTC (rev 93534)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-22 20:39:11 UTC (rev 93535)
@@ -1,3 +1,9 @@
+2011-08-22 Dimitri Glazkov
+
+Roll Chromium DEPS to 97698.
+
+* DEPS: Rolled.
+
2011-08-22 Justin Novosad
[Chromium] Crash when allocation of very large canvas fails
Modified: trunk/Source/WebKit/chromium/DEPS (93534 => 93535)
--- trunk/Source/WebKit/chromium/DEPS 2011-08-22 20:38:52 UTC (rev 93534)
+++ trunk/Source/WebKit/chromium/DEPS 2011-08-22 20:39:11 UTC (rev 93535)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '97474'
+ 'chromium_rev': '97698'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93536] trunk/LayoutTests
Title: [93536] trunk/LayoutTests Revision 93536 Author le...@chromium.org Date 2011-08-22 13:45:20 -0700 (Mon, 22 Aug 2011) Log Message REGRESSION (r89086): All worker xhr requests trigger preflight requests. https://bugs.webkit.org/show_bug.cgi?id=66340 Reviewed by Darin Adler. Added tests which are similar to the non worker test with the same name. * http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt: Added. * http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html: Added. * http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple-test.js: Added. * http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple.js: Added. * http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt: Added. * http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple.html: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html trunk/LayoutTests/http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple-test.js trunk/LayoutTests/http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple.js trunk/LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple.html Property Changed trunk/LayoutTests/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (93535 => 93536) --- trunk/LayoutTests/ChangeLog 2011-08-22 20:39:11 UTC (rev 93535) +++ trunk/LayoutTests/ChangeLog 2011-08-22 20:45:20 UTC (rev 93536) @@ -1,3 +1,19 @@ +2011-08-22 David Levin + +REGRESSION (r89086): All worker xhr requests trigger preflight requests. +https://bugs.webkit.org/show_bug.cgi?id=66340 + +Reviewed by Darin Adler. + +Added tests which are similar to the non worker test with the same name. + +* http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt: Added. +* http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html: Added. +* http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple-test.js: Added. +* http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple.js: Added. +* http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt: Added. +* http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple.html: Added. + 2011-08-22 James Robinson [chromium] Rename chromium-gpu-mac to chromium-gpu-cg-mac Property changes on: trunk/LayoutTests/ChangeLog ___ Deleted: svn:executable Added: trunk/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt (0 => 93536) --- trunk/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt 2011-08-22 20:45:20 UTC (rev 93536) @@ -0,0 +1,6 @@ +CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load http://localhost:8000/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin. +GET should not trigger a preflight request from a worker unless it has non-simple headers. + +PASS: Cross-domain access allowed for simple get. +PASS: Exception thrown. Cross-domain access was denied in 'send'. [NETWORK_ERR: XMLHttpRequest Exception 101]. +DONE Property changes on: trunk/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt ___ Added: svn:eol-style Added: trunk/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html (0 => 93536) --- trunk/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html (rev 0) +++ trunk/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html 2011-08-22 20:45:20 UTC (rev 93536) @@ -0,0 +1,7 @@ + +GET should not trigger a preflight request from a worker unless it has non-simple headers. + +
[webkit-changes] [93537] trunk/Source/WebKit/chromium
Title: [93537] trunk/Source/WebKit/chromium
Revision 93537
Author dglaz...@chromium.org
Date 2011-08-22 13:53:40 -0700 (Mon, 22 Aug 2011)
Log Message
Remove third_party/leveldb, because it's no longer used and doesn't exist downstream.
* DEPS: Done it.
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (93536 => 93537)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-22 20:45:20 UTC (rev 93536)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-22 20:53:40 UTC (rev 93537)
@@ -1,5 +1,11 @@
2011-08-22 Dimitri Glazkov
+Remove third_party/leveldb, because it's no longer used and doesn't exist downstream.
+
+* DEPS: Done it.
+
+2011-08-22 Dimitri Glazkov
+
Roll Chromium DEPS to 97698.
* DEPS: Rolled.
Modified: trunk/Source/WebKit/chromium/DEPS (93536 => 93537)
--- trunk/Source/WebKit/chromium/DEPS 2011-08-22 20:45:20 UTC (rev 93536)
+++ trunk/Source/WebKit/chromium/DEPS 2011-08-22 20:53:40 UTC (rev 93537)
@@ -127,9 +127,6 @@
From('chromium_deps', 'src/third_party/yasm/source/patched-yasm'),
'third_party/libjpeg_turbo':
From('chromium_deps', 'src/third_party/libjpeg_turbo'),
- # TODO(dgrogan): Remove third_party/leveldb after WebCore.gyp is updated.
- 'third_party/leveldb':
-From('chromium_deps', 'src/third_party/leveldb'),
'third_party/leveldatabase/src':
From('chromium_deps', 'src/third_party/leveldatabase/src'),
'third_party/snappy/src':
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93538] trunk
Title: [93538] trunk Revision 93538 Author commit-qu...@webkit.org Date 2011-08-22 14:04:33 -0700 (Mon, 22 Aug 2011) Log Message [CSSRegions] RenderFlowThread layout should use the attached region sizes https://bugs.webkit.org/show_bug.cgi?id=66143 Source/WebCore: When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no need to put that on the LayoutState. The right offset used to layout the inlines inside a RenderFlowThread is now adjusted to fit inside the current region. Patch by Alexandru Chiculita on 2011-08-22 Reviewed by David Hyatt. Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html fast/regions/webkit-flow-inlines-inside-regions-bounds.html * rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::adjustForRegionFittingIfNeeded): (WebCore::RenderBlock::logicalRightOffsetForLine): * rendering/RenderBlock.h: * rendering/RenderFlowThread.cpp: (WebCore::RenderFlowThread::RenderFlowThread): (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer): (WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer): (WebCore::RenderFlowThread::layout): (WebCore::RenderFlowThread::renderRegionForLine): (WebCore::RenderFlowThread::regionLogicalWidthForLine): * rendering/RenderFlowThread.h: (WebCore::RegionFittingDisabler::RegionFittingDisabler): (WebCore::RegionFittingDisabler::~RegionFittingDisabler): * rendering/RenderRegion.cpp: (WebCore::RenderRegion::layout): * rendering/RenderRegion.h: * rendering/RenderView.cpp: (WebCore::RenderView::RenderView): * rendering/RenderView.h: (WebCore::RenderView::hasRenderFlowThread): (WebCore::RenderView::currentRenderFlowThread): (WebCore::RenderView::setCurrentRenderFlowThread): (WebCore::RenderView::pushLayoutState): LayoutTests: Patch by Alexandru Chiculita on 2011-08-22 Reviewed by David Hyatt. * fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added. * fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added. * fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added. * fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Added. * fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Added. * fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/LayoutState.cpp trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBlock.h trunk/Source/WebCore/rendering/RenderFlowThread.cpp trunk/Source/WebCore/rendering/RenderFlowThread.h trunk/Source/WebCore/rendering/RenderRegion.cpp trunk/Source/WebCore/rendering/RenderRegion.h trunk/Source/WebCore/rendering/RenderView.cpp trunk/Source/WebCore/rendering/RenderView.h Added Paths trunk/LayoutTests/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt trunk/LayoutTests/fast/regions/webkit-flow-floats-inside-regions-bounds.html trunk/LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt trunk/LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt trunk/LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html trunk/LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds.html Diff Modified: trunk/LayoutTests/ChangeLog (93537 => 93538) --- trunk/LayoutTests/ChangeLog 2011-08-22 20:53:40 UTC (rev 93537) +++ trunk/LayoutTests/ChangeLog 2011-08-22 21:04:33 UTC (rev 93538) @@ -1,3 +1,17 @@ +2011-08-22 Alexandru Chiculita + +[CSSRegions] RenderFlowThread layout should use the attached region sizes +https://bugs.webkit.org/show_bug.cgi?id=66143 + +Reviewed by David Hyatt. + +* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added. +* fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added. +* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added. +* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Added. +* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Added. +* fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added. + 2011-08-22 David Levin REGRESSION (r89086): All worker xhr requests trigger preflight requests. Added: trunk/LayoutTests/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt (0 => 93538) --- trunk/LayoutTests/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt (rev 0) +++ trunk/LayoutTests/fast/regions/webkit-flow-floats-inside-re
[webkit-changes] [93539] trunk/Source/WebKit2
Title: [93539] trunk/Source/WebKit2 Revision 93539 Author ander...@apple.com Date 2011-08-22 14:05:33 -0700 (Mon, 22 Aug 2011) Log Message Update the current NSTextInputContext whenever the plug-in complex text input state changes https://bugs.webkit.org/show_bug.cgi?id=66709 Reviewed by Sam Weinig. Call [NSTextInputContext currentInputContext] which will force AppKit to update the current input context. Fixes a rare case when the out-of-line editing window wouldn't appear. * UIProcess/API/mac/WKView.mm: (-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (93538 => 93539) --- trunk/Source/WebKit2/ChangeLog 2011-08-22 21:04:33 UTC (rev 93538) +++ trunk/Source/WebKit2/ChangeLog 2011-08-22 21:05:33 UTC (rev 93539) @@ -1,3 +1,16 @@ +2011-08-22 Anders Carlsson + +Update the current NSTextInputContext whenever the plug-in complex text input state changes +https://bugs.webkit.org/show_bug.cgi?id=66709 + +Reviewed by Sam Weinig. + +Call [NSTextInputContext currentInputContext] which will force AppKit to update the current input +context. Fixes a rare case when the out-of-line editing window wouldn't appear. + +* UIProcess/API/mac/WKView.mm: +(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]): + 2011-08-19 Anders Carlsson Another attempt at fixing the Windows build. Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (93538 => 93539) --- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-08-22 21:04:33 UTC (rev 93538) +++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-08-22 21:05:33 UTC (rev 93539) @@ -2309,6 +2309,9 @@ // Inform the out of line window that the input source changed. [[WKTextInputWindowController sharedTextInputWindowController] keyboardInputSourceChanged]; } + +// This will force the current input context to be updated to its correct value. +[NSTextInputContext currentInputContext]; } - (void)_setPageHasCustomRepresentation:(BOOL)pageHasCustomRepresentation ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93540] trunk/Source/WebCore
Title: [93540] trunk/Source/WebCore
Revision 93540
Author carycl...@google.com
Date 2011-08-22 14:07:03 -0700 (Mon, 22 Aug 2011)
Log Message
Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
https://bugs.webkit.org/show_bug.cgi?id=66703
This error was detected by the debug build of the Chromium WebKit
Canary.
Reviewed by James Robinson.
No new tests. This change suppresses a compile-time warning
but does not affect the generated code.
* platform/graphics/mac/FontCustomPlatformData.h:
Replaced struct with class in a forward reference.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (93539 => 93540)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 21:05:33 UTC (rev 93539)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 21:07:03 UTC (rev 93540)
@@ -1,3 +1,19 @@
+2011-08-22 Cary Clark
+
+Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
+https://bugs.webkit.org/show_bug.cgi?id=66703
+
+This error was detected by the debug build of the Chromium WebKit
+Canary.
+
+Reviewed by James Robinson.
+
+No new tests. This change suppresses a compile-time warning
+but does not affect the generated code.
+
+* platform/graphics/mac/FontCustomPlatformData.h:
+Replaced struct with class in a forward reference.
+
2011-08-22 Alexandru Chiculita
[CSSRegions] RenderFlowThread layout should use the attached region sizes
Modified: trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h (93539 => 93540)
--- trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h 2011-08-22 21:05:33 UTC (rev 93539)
+++ trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h 2011-08-22 21:07:03 UTC (rev 93540)
@@ -34,7 +34,7 @@
typedef UInt32 ATSFontRef;
#if USE(SKIA_ON_MAC_CHROMIUM)
-struct SkTypeface;
+class SkTypeface;
#endif
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93541] trunk/LayoutTests
Title: [93541] trunk/LayoutTests Revision 93541 Author pkast...@chromium.org Date 2011-08-22 14:13:35 -0700 (Mon, 22 Aug 2011) Log Message [chromium] Disable compositing tests for Leopard. Reviewed by James Robinson. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (93540 => 93541) --- trunk/LayoutTests/ChangeLog 2011-08-22 21:07:03 UTC (rev 93540) +++ trunk/LayoutTests/ChangeLog 2011-08-22 21:13:35 UTC (rev 93541) @@ -1,3 +1,11 @@ +2011-08-22 Peter Kasting + +[chromium] Disable compositing tests for Leopard. + +Reviewed by James Robinson. + +* platform/chromium/test_expectations.txt: + 2011-08-22 Alexandru Chiculita [CSSRegions] RenderFlowThread layout should use the attached region sizes Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93540 => 93541) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-22 21:07:03 UTC (rev 93540) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-22 21:13:35 UTC (rev 93541) @@ -257,10 +257,15 @@ // Compositing tests will never pass in the non-accelerated GPU code // paths. -BUGCR15733 SKIP WONTFIX CPU : compositing = PASS TIMEOUT FAIL -BUGCR15733 SKIP WONTFIX CPU : platform/chromium/compositing = PASS TIMEOUT FAIL -BUGCR15733 SKIP WONTFIX CPU : animations/3d = PASS TIMEOUT FAIL +SKIP WONTFIX CPU : compositing = PASS TIMEOUT FAIL +SKIP WONTFIX CPU : platform/chromium/compositing = PASS TIMEOUT FAIL +SKIP WONTFIX CPU : animations/3d = PASS TIMEOUT FAIL +// We don't ship compositing on Leopard. +SKIP WONTFIX GPU LEOPARD : compositing = PASS TIMEOUT FAIL +SKIP WONTFIX GPU LEOPARD : platform/chromium/compositing = PASS TIMEOUT FAIL +SKIP WONTFIX GPU LEOPARD : animations/3d = PASS TIMEOUT FAIL + // Run the Mac-specific platform tests, but only to check for crashes. WONTFIX : platform/gtk = FAIL PASS WONTFIX : platform/mac = FAIL PASS TIMEOUT @@ -2648,10 +2653,7 @@ // // We only maintain pixel GPU baselines for Snow Leopard -WONTFIX GPU LEOPARD : compositing = IMAGE PASS -WONTFIX GPU LEOPARD : platform/chromium/compositing = IMAGE PASS WONTFIX GPU LEOPARD : media = IMAGE PASS -WONTFIX GPU LEOPARD : animations/3d = IMAGE PASS // Will need windows and linux baselines BUGWK58182 GPU : compositing/images/content-image-change.html = PASS FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93542] trunk/Source/WebCore
Title: [93542] trunk/Source/WebCore
Revision 93542
Author nd...@chromium.org
Date 2011-08-22 14:23:23 -0700 (Mon, 22 Aug 2011)
Log Message
[chromium] Make compositor context current before querying for extensions
https://bugs.webkit.org/show_bug.cgi?id=66696
Reviewed by James Robinson.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (93541 => 93542)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 21:13:35 UTC (rev 93541)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 21:23:23 UTC (rev 93542)
@@ -1,3 +1,13 @@
+2011-08-22 Nat Duca
+
+[chromium] Make compositor context current before querying for extensions
+https://bugs.webkit.org/show_bug.cgi?id=66696
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::initialize):
+
2011-08-22 Cary Clark
Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (93541 => 93542)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-08-22 21:13:35 UTC (rev 93541)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-08-22 21:23:23 UTC (rev 93542)
@@ -479,9 +479,9 @@
bool LayerRendererChromium::initialize()
{
+m_context->makeContextCurrent();
#if USE(SKIA)
if (settings().acceleratePainting) {
-m_context->makeContextCurrent();
m_skiaContext = adoptPtr(GrContext::CreateGLShaderContext());
// Limit the number of textures we hold in the bitmap->texture cache.
static const int maxTextureCacheCount = 512;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93543] trunk/Source/WebKit2
Title: [93543] trunk/Source/WebKit2 Revision 93543 Author ander...@apple.com Date 2011-08-22 14:35:23 -0700 (Mon, 22 Aug 2011) Log Message The UI process should keep track of whether a plug-in has focus or not https://bugs.webkit.org/show_bug.cgi?id=66712 Reviewed by Darin Adler. This is in preparation for implementing the updated Cocoa text input model. Pipe through whether a plug-in and its containing window has focus or not, from the plug-in process and all the way to the UI process. * PluginProcess/PluginControllerProxy.h: * PluginProcess/mac/PluginControllerProxyMac.mm: (WebKit::PluginControllerProxy::pluginFocusOrWindowFocusChanged): * UIProcess/API/mac/PageClientImpl.h: * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::pluginFocusOrWindowFocusChanged): * UIProcess/API/mac/WKView.mm: (-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]): * UIProcess/API/mac/WKViewInternal.h: * UIProcess/PageClient.h: * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged): * WebProcess/Plugins/Netscape/NetscapePlugin.h: * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformSetFocus): (WebKit::NetscapePlugin::windowFocusChanged): (WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged): * WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm: (WebKit::PluginProxy::pluginFocusOrWindowFocusChanged): * WebProcess/Plugins/PluginController.h: * WebProcess/Plugins/PluginProxy.h: * WebProcess/Plugins/PluginProxy.messages.in: * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::pluginFocusOrWindowFocusChanged): * WebProcess/Plugins/PluginView.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h trunk/Source/WebKit2/UIProcess/PageClient.h trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm trunk/Source/WebKit2/WebProcess/Plugins/PluginController.h trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h Diff Modified: trunk/Source/WebKit2/ChangeLog (93542 => 93543) --- trunk/Source/WebKit2/ChangeLog 2011-08-22 21:23:23 UTC (rev 93542) +++ trunk/Source/WebKit2/ChangeLog 2011-08-22 21:35:23 UTC (rev 93543) @@ -1,5 +1,45 @@ 2011-08-22 Anders Carlsson +The UI process should keep track of whether a plug-in has focus or not +https://bugs.webkit.org/show_bug.cgi?id=66712 + +Reviewed by Darin Adler. + +This is in preparation for implementing the updated Cocoa text input model. + +Pipe through whether a plug-in and its containing window has focus or not, from the +plug-in process and all the way to the UI process. + +* PluginProcess/PluginControllerProxy.h: +* PluginProcess/mac/PluginControllerProxyMac.mm: +(WebKit::PluginControllerProxy::pluginFocusOrWindowFocusChanged): +* UIProcess/API/mac/PageClientImpl.h: +* UIProcess/API/mac/PageClientImpl.mm: +(WebKit::PageClientImpl::pluginFocusOrWindowFocusChanged): +* UIProcess/API/mac/WKView.mm: +(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]): +* UIProcess/API/mac/WKViewInternal.h: +* UIProcess/PageClient.h: +* UIProcess/WebPageProxy.h: +* UIProcess/WebPageProxy.messages.in: +* UIProcess/mac/WebPageProxyMac.mm: +(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged): +* WebProcess/Plugins/Netscape/NetscapePlugin.h: +* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: +(WebKit::NetscapePlugin::platformSetFocus): +(WebKit::NetscapePlugin::windowFocusChanged): +(WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged): +* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm: +(WebKit::PluginProxy::pluginFocusOrWindowFocusChanged): +* WebProcess/Plugins/PluginController.h: +* WebProcess/Plugins/PluginProxy.h: +* WebProcess/Plugins/PluginProxy.messages.in: +* WebProcess/Plugins/PluginView.cpp: +(WebKit::PluginView::pluginFocusOrWindowFocusChanged): +* WebProcess/Plugins/PluginView.h: + +2011-08
[webkit-changes] [93544] trunk/Source/WebKit2
Title: [93544] trunk/Source/WebKit2 Revision 93544 Author ander...@apple.com Date 2011-08-22 14:38:41 -0700 (Mon, 22 Aug 2011) Log Message Use -[NSApplication updateWindows] to update the current input context https://bugs.webkit.org/show_bug.cgi?id=66715 Reviewed by Alexey Proskuryakov. * UIProcess/API/mac/WKView.mm: (-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (93543 => 93544) --- trunk/Source/WebKit2/ChangeLog 2011-08-22 21:35:23 UTC (rev 93543) +++ trunk/Source/WebKit2/ChangeLog 2011-08-22 21:38:41 UTC (rev 93544) @@ -1,5 +1,15 @@ 2011-08-22 Anders Carlsson +Use -[NSApplication updateWindows] to update the current input context +https://bugs.webkit.org/show_bug.cgi?id=66715 + +Reviewed by Alexey Proskuryakov. + +* UIProcess/API/mac/WKView.mm: +(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]): + +2011-08-22 Anders Carlsson + The UI process should keep track of whether a plug-in has focus or not https://bugs.webkit.org/show_bug.cgi?id=66712 Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (93543 => 93544) --- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-08-22 21:35:23 UTC (rev 93543) +++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-08-22 21:38:41 UTC (rev 93544) @@ -2316,7 +2316,7 @@ } // This will force the current input context to be updated to its correct value. -[NSTextInputContext currentInputContext]; +[NSApp updateWindows]; } - (void)_setPageHasCustomRepresentation:(BOOL)pageHasCustomRepresentation ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93545] trunk/Tools
Title: [93545] trunk/Tools
Revision 93545
Author dglaz...@chromium.org
Date 2011-08-22 14:45:39 -0700 (Mon, 22 Aug 2011)
Log Message
[Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
https://bugs.webkit.org/show_bug.cgi?id=66705
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (93544 => 93545)
--- trunk/Tools/ChangeLog 2011-08-22 21:38:41 UTC (rev 93544)
+++ trunk/Tools/ChangeLog 2011-08-22 21:45:39 UTC (rev 93545)
@@ -1,3 +1,13 @@
+2011-08-22 Dimitri Glazkov
+
+[Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
+https://bugs.webkit.org/show_bug.cgi?id=66705
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
+* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
+
2011-08-22 James Robinson
[chromium] Update builder names for chromium gpu bots due to CG switchover
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (93544 => 93545)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2011-08-22 21:38:41 UTC (rev 93544)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2011-08-22 21:45:39 UTC (rev 93545)
@@ -68,7 +68,9 @@
('lucid', 'x86'),
('lucid', 'x86_64'))
-ALL_GRAPHICS_TYPES = ('cpu', 'gpu', 'cg')
+ALL_GRAPHICS_TYPES = ('cpu', 'gpu')
+CORE_GRAPHICS_VERSIONS = ('leopard', 'snowleopard')
+CORE_GRAPHICS_TYPES = ('cpu-cg', 'gpu-cg')
ALL_BASELINE_VARIANTS = [
'chromium-cg-mac-snowleopard', 'chromium-cg-mac-leopard',
@@ -291,11 +293,10 @@
for version, architecture in self.ALL_SYSTEMS:
for build_type in self.ALL_BUILD_TYPES:
for graphics_type in self.ALL_GRAPHICS_TYPES:
-test_configurations.append(TestConfiguration(
-version=version,
-architecture=architecture,
-build_type=build_type,
-graphics_type=graphics_type))
+test_configurations.append(TestConfiguration(version, architecture, build_type, graphics_type))
+if version in self.CORE_GRAPHICS_VERSIONS:
+for graphics_type in self.CORE_GRAPHICS_TYPES:
+test_configurations.append(TestConfiguration(version, architecture, build_type, graphics_type))
return test_configurations
try_builder_names = frozenset([
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py (93544 => 93545)
--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py 2011-08-22 21:38:41 UTC (rev 93544)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py 2011-08-22 21:45:39 UTC (rev 93545)
@@ -92,11 +92,9 @@
self.assertEquals(extrapolator.extrapolate_test_configurations("Webkit Win"), set([TestConfiguration(version='xp', architecture='x86', build_type='release', graphics_type='cpu')]))
self.assertEquals(extrapolator.extrapolate_test_configurations("Webkit Vista"), set([
TestConfiguration(version='vista', architecture='x86', build_type='debug', graphics_type='cpu'),
-TestConfiguration(version='vista', architecture='x86', build_type='debug', graphics_type='cg'),
TestConfiguration(version='vista', architecture='x86', build_type='debug', graphics_type='gpu'),
TestConfiguration(version='vista', architecture='x86', build_type='release', graphics_type='gpu'),
-TestConfiguration(version='vista', architecture='x86', build_type='release', graphics_type='cpu'),
-TestConfiguration(version='vista', architecture='x86', build_type='release', graphics_type='cg')]))
+TestConfiguration(version='vista', architecture='x86', build_type='release', graphics_type='cpu')]))
self.assertRaises(KeyError, extrapolator.extrapolate_test_configurations, "Potato")
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93546] trunk/Source/WebKit2
Title: [93546] trunk/Source/WebKit2
Revision 93546
Author msab...@apple.com
Date 2011-08-22 14:46:58 -0700 (Mon, 22 Aug 2011)
Log Message
REGRESSION (r92231): Apple campus proposal PDF doesn't display in Safari
https://bugs.webkit.org/show_bug.cgi?id=66464
Changed ArgumentEncoder to use system malloc instead of fastMalloc.
FastMalloc uses madvise(MADV_FREE_REUSABLE) which is incompatible with
mach message Out Of Line (OOL) messages that use MACH_MSG_VIRTUAL_COPY.
The system malloc has no such limitation.
Changed sendOutgoingMessage to use MACH_MSG_VIRTUAL_COPY again as it
doesn't have size limitations that MACH_MSG_PHYSICAL_COPY.
Reviewed by Anders Carlsson.
* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp
trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (93545 => 93546)
--- trunk/Source/WebKit2/ChangeLog 2011-08-22 21:45:39 UTC (rev 93545)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-22 21:46:58 UTC (rev 93546)
@@ -1,3 +1,23 @@
+2011-08-21 Michael Saboff
+
+REGRESSION (r92231): Apple campus proposal PDF doesn't display in Safari
+https://bugs.webkit.org/show_bug.cgi?id=66464
+
+Changed ArgumentEncoder to use system malloc instead of fastMalloc.
+FastMalloc uses madvise(MADV_FREE_REUSABLE) which is incompatible with
+mach message Out Of Line (OOL) messages that use MACH_MSG_VIRTUAL_COPY.
+The system malloc has no such limitation.
+Changed sendOutgoingMessage to use MACH_MSG_VIRTUAL_COPY again as it
+doesn't have size limitations that MACH_MSG_PHYSICAL_COPY.
+
+Reviewed by Anders Carlsson.
+
+* Platform/CoreIPC/ArgumentEncoder.cpp:
+(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
+(CoreIPC::ArgumentEncoder::grow):
+* Platform/CoreIPC/mac/ConnectionMac.cpp:
+(CoreIPC::Connection::sendOutgoingMessage):
+
2011-08-22 Anders Carlsson
Use -[NSApplication updateWindows] to update the current input context
Modified: trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp (93545 => 93546)
--- trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp 2011-08-22 21:45:39 UTC (rev 93545)
+++ trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp 2011-08-22 21:46:58 UTC (rev 93546)
@@ -50,7 +50,7 @@
ArgumentEncoder::~ArgumentEncoder()
{
if (m_buffer)
-fastFree(m_buffer);
+free(m_buffer);
#if !USE(UNIX_DOMAIN_SOCKETS)
// FIXME: We need to dispose of the attachments in cases of failure.
#else
@@ -70,10 +70,13 @@
if (alignedSize + size > m_bufferCapacity) {
size_t newCapacity = std::max(alignedSize + size, std::max(static_cast(32), m_bufferCapacity + m_bufferCapacity / 4 + 1));
+// Use system malloc / realloc instead of fastMalloc due to
+// fastMalloc using MADV_FREE_REUSABLE doesn't work with
+// mach messages with OOL message and MACH_MSG_VIRTUAL_COPY.
if (!m_buffer)
-m_buffer = static_cast(fastMalloc(newCapacity));
+m_buffer = static_cast(malloc(newCapacity));
else
-m_buffer = static_cast(fastRealloc(m_buffer, newCapacity));
+m_buffer = static_cast(realloc(m_buffer, newCapacity));
// FIXME: What should we do if allocating memory fails?
Modified: trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp (93545 => 93546)
--- trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp 2011-08-22 21:45:39 UTC (rev 93545)
+++ trunk/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp 2011-08-22 21:46:58 UTC (rev 93546)
@@ -155,7 +155,7 @@
if (messageSize > sizeof(buffer)) {
messageBodyIsOOL = true;
-attachments.append(Attachment(arguments->buffer(), arguments->bufferSize(), MACH_MSG_PHYSICAL_COPY, false));
+attachments.append(Attachment(arguments->buffer(), arguments->bufferSize(), MACH_MSG_VIRTUAL_COPY, false));
numberOfOOLMemoryDescriptors++;
messageSize = machMessageSize(0, numberOfPortDescriptors, numberOfOOLMemoryDescriptors);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93547] trunk
Title: [93547] trunk
Revision 93547
Author t...@chromium.org
Date 2011-08-22 14:49:06 -0700 (Mon, 22 Aug 2011)
Log Message
handle child margin values when flexing
https://bugs.webkit.org/show_bug.cgi?id=65887
Reviewed by David Hyatt.
Source/WebCore:
Test: css3/flexbox/002.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredSize): If the margin is
auto, treat it as flex(1 0 0).
* rendering/RenderObject.cpp:
(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated): Added.
LayoutTests:
* css3/flexbox/002-expected.txt: Added.
* css3/flexbox/002.html: Added.
* css3/flexbox/resources/flexbox.js:
(checkHorizontalBoxen):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/resources/flexbox.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderObject.h
Added Paths
trunk/LayoutTests/css3/flexbox/002-expected.txt
trunk/LayoutTests/css3/flexbox/002.html
Diff
Modified: trunk/LayoutTests/ChangeLog (93546 => 93547)
--- trunk/LayoutTests/ChangeLog 2011-08-22 21:46:58 UTC (rev 93546)
+++ trunk/LayoutTests/ChangeLog 2011-08-22 21:49:06 UTC (rev 93547)
@@ -1,3 +1,15 @@
+2011-08-22 Tony Chang
+
+handle child margin values when flexing
+https://bugs.webkit.org/show_bug.cgi?id=65887
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/002-expected.txt: Added.
+* css3/flexbox/002.html: Added.
+* css3/flexbox/resources/flexbox.js:
+(checkHorizontalBoxen):
+
2011-08-22 Peter Kasting
[chromium] Disable compositing tests for Leopard.
Added: trunk/LayoutTests/css3/flexbox/002-expected.txt (0 => 93547)
--- trunk/LayoutTests/css3/flexbox/002-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/flexbox/002-expected.txt 2011-08-22 21:49:06 UTC (rev 93547)
@@ -0,0 +1,11 @@
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+
Property changes on: trunk/LayoutTests/css3/flexbox/002-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/css3/flexbox/002.html (0 => 93547)
--- trunk/LayoutTests/css3/flexbox/002.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/002.html 2011-08-22 21:49:06 UTC (rev 93547)
@@ -0,0 +1,92 @@
+
+
+
+body {
+margin: 0;
+}
+.horizontal-box {
+width: 600px;
+display: -webkit-flexbox;
+background-color: #aaa;
+position: relative;
+}
+.horizontal-box div {
+height: 20px;
+border: 0;
+}
+
+.horizontal-box :nth-child(1) {
+background-color: blue;
+}
+.horizontal-box :nth-child(2) {
+background-color: green;
+}
+.horizontal-box :nth-child(3) {
+background-color: red;
+}
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
[webkit-changes] [93548] trunk/Source/WebKit2
Title: [93548] trunk/Source/WebKit2
Revision 93548
Author ander...@apple.com
Date 2011-08-22 14:56:22 -0700 (Mon, 22 Aug 2011)
Log Message
Update the text input context when the plug-in focus changes and not when the complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66716
Reviewed by Darin Adler.
* UIProcess/API/mac/WKView.mm:
(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (93547 => 93548)
--- trunk/Source/WebKit2/ChangeLog 2011-08-22 21:49:06 UTC (rev 93547)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-22 21:56:22 UTC (rev 93548)
@@ -1,5 +1,16 @@
-2011-08-21 Michael Saboff
+2011-08-22 Anders Carlsson
+Update the text input context when the plug-in focus changes and not when the complex text input state changes
+https://bugs.webkit.org/show_bug.cgi?id=66716
+
+Reviewed by Darin Adler.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
+(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
+
+2011-08-22 Michael Saboff
+
REGRESSION (r92231): Apple campus proposal PDF doesn't display in Safari
https://bugs.webkit.org/show_bug.cgi?id=66464
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (93547 => 93548)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-08-22 21:49:06 UTC (rev 93547)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-08-22 21:56:22 UTC (rev 93548)
@@ -2287,15 +2287,9 @@
- (void)_pluginFocusOrWindowFocusChanged:(BOOL)pluginHasFocusAndWindowHasFocus pluginComplexTextInputIdentifier:(uint64_t)pluginComplexTextInputIdentifier
{
-// FIXME: Implement.
-}
-
-- (void)_setPluginComplexTextInputState:(WebKit::PluginComplexTextInputState)pluginComplexTextInputState pluginComplexTextInputIdentifier:(uint64_t)pluginComplexTextInputIdentifier
-{
BOOL inputSourceChanged = _data->_pluginComplexTextInputIdentifier;
-BOOL complexTextInputEnabled = (pluginComplexTextInputState == PluginComplexTextInputEnabledLegacy);
-if (complexTextInputEnabled) {
+if (pluginHasFocusAndWindowHasFocus) {
// Check if we're already allowing text input for this plug-in.
if (pluginComplexTextInputIdentifier == _data->_pluginComplexTextInputIdentifier)
return;
@@ -2303,7 +2297,7 @@
_data->_pluginComplexTextInputIdentifier = pluginComplexTextInputIdentifier;
} else {
-// Check if we got a request to disable complex text input for a plug-in that is not the current plug-in.
+// Check if we got a request to unfocus a plug-in that isn't focused.
if (pluginComplexTextInputIdentifier != _data->_pluginComplexTextInputIdentifier)
return;
@@ -2319,6 +2313,16 @@
[NSApp updateWindows];
}
+- (void)_setPluginComplexTextInputState:(WebKit::PluginComplexTextInputState)pluginComplexTextInputState pluginComplexTextInputIdentifier:(uint64_t)pluginComplexTextInputIdentifier
+{
+if (pluginComplexTextInputIdentifier != _data->_pluginComplexTextInputIdentifier) {
+// We're asked to update the state for a plug-in that doesn't have focus.
+return;
+}
+
+// FIXME: Actually update the state here when using the new Cocoa text input model.
+}
+
- (void)_setPageHasCustomRepresentation:(BOOL)pageHasCustomRepresentation
{
_data->_pdfViewController = nullptr;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93549] trunk/LayoutTests
Title: [93549] trunk/LayoutTests Revision 93549 Author rn...@webkit.org Date 2011-08-22 15:01:17 -0700 (Mon, 22 Aug 2011) Log Message Add editing/selection/caret-at-bidi-boundary.html back to the Qt's skipped list because r93529 didn't fix it. The failure is still tracked by the bug 66514. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (93548 => 93549) --- trunk/LayoutTests/ChangeLog 2011-08-22 21:56:22 UTC (rev 93548) +++ trunk/LayoutTests/ChangeLog 2011-08-22 22:01:17 UTC (rev 93549) @@ -1,3 +1,10 @@ +2011-08-22 Ryosuke Niwa + +Add editing/selection/caret-at-bidi-boundary.html back to the Qt's skipped list +because r93529 didn't fix it. The failure is still tracked by the bug 66514. + +* platform/qt/Skipped: + 2011-08-22 Tony Chang handle child margin values when flexing Modified: trunk/LayoutTests/platform/qt/Skipped (93548 => 93549) --- trunk/LayoutTests/platform/qt/Skipped 2011-08-22 21:56:22 UTC (rev 93548) +++ trunk/LayoutTests/platform/qt/Skipped 2011-08-22 22:01:17 UTC (rev 93549) @@ -2381,3 +2381,7 @@ # [Qt] fast/parser/innerhtml-with-prefixed-elements.xhtml has incorrect results # https://bugs.webkit.org/show_bug.cgi?id=66626 fast/parser/innerhtml-with-prefixed-elements.xhtml + +# [Qt] editing/selection/caret-at-bidi-boundary.html fails +# https://bugs.webkit.org/show_bug.cgi?id=66514 +editing/selection/caret-at-bidi-boundary.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93550] trunk/Source/WebKit2
Title: [93550] trunk/Source/WebKit2
Revision 93550
Author ander...@apple.com
Date 2011-08-22 15:08:33 -0700 (Mon, 22 Aug 2011)
Log Message
Move code from PageClientImpl::doneWithKeyEvent to WKView
https://bugs.webkit.org/show_bug.cgi?id=66722
Reviewed by Darin Adler.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::doneWithKeyEvent):
* UIProcess/API/mac/WKView.mm:
(-[WKView _doneWithKeyEvent:WebKit::eventWasHandled:]):
* UIProcess/API/mac/WKViewInternal.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (93549 => 93550)
--- trunk/Source/WebKit2/ChangeLog 2011-08-22 22:01:17 UTC (rev 93549)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-22 22:08:33 UTC (rev 93550)
@@ -1,5 +1,18 @@
2011-08-22 Anders Carlsson
+Move code from PageClientImpl::doneWithKeyEvent to WKView
+https://bugs.webkit.org/show_bug.cgi?id=66722
+
+Reviewed by Darin Adler.
+
+* UIProcess/API/mac/PageClientImpl.mm:
+(WebKit::PageClientImpl::doneWithKeyEvent):
+* UIProcess/API/mac/WKView.mm:
+(-[WKView _doneWithKeyEvent:WebKit::eventWasHandled:]):
+* UIProcess/API/mac/WKViewInternal.h:
+
+2011-08-22 Anders Carlsson
+
Update the text input context when the plug-in focus changes and not when the complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66716
Modified: trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm (93549 => 93550)
--- trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2011-08-22 22:01:17 UTC (rev 93549)
+++ trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm 2011-08-22 22:08:33 UTC (rev 93550)
@@ -298,15 +298,9 @@
return enclosingIntRect(tempRect);
}
-void PageClientImpl::doneWithKeyEvent(const NativeWebKeyboardEvent& event, bool wasEventHandled)
+void PageClientImpl::doneWithKeyEvent(const NativeWebKeyboardEvent& event, bool eventWasHandled)
{
-NSEvent* nativeEvent = event.nativeEvent();
-if ([nativeEvent type] != NSKeyDown)
-return;
-if (wasEventHandled)
-[NSCursor setHiddenUntilMouseMoves:YES];
-else
-[m_wkView _resendKeyDownEvent:nativeEvent];
+[m_wkView _doneWithKeyEvent:event eventWasHandled:eventWasHandled];
}
PassRefPtr PageClientImpl::createPopupMenuProxy(WebPageProxy* page)
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (93549 => 93550)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-08-22 22:01:17 UTC (rev 93549)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2011-08-22 22:08:33 UTC (rev 93550)
@@ -2057,15 +2057,24 @@
}
}
-- (void)_resendKeyDownEvent:(NSEvent *)event
+- (void)_doneWithKeyEvent:(const WebKit::NativeWebKeyboardEvent&)event eventWasHandled:(BOOL)eventWasHandled
{
+NSEvent* nativeEvent = event.nativeEvent();
+if ([nativeEvent type] != NSKeyDown)
+return;
+
+if (eventWasHandled) {
+[NSCursor setHiddenUntilMouseMoves:YES];
+return;
+}
+
// resending the event may destroy this WKView
RetainPtr protector(self);
ASSERT(!_data->_keyDownEventBeingResent);
-_data->_keyDownEventBeingResent = event;
-[NSApp _setCurrentEvent:event];
-[NSApp sendEvent:event];
+_data->_keyDownEventBeingResent = nativeEvent;
+[NSApp _setCurrentEvent:nativeEvent];
+[NSApp sendEvent:nativeEvent];
_data->_keyDownEventBeingResent = nullptr;
}
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h (93549 => 93550)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h 2011-08-22 22:01:17 UTC (rev 93549)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h 2011-08-22 22:08:33 UTC (rev 93550)
@@ -41,6 +41,7 @@
class DrawingAreaProxy;
class FindIndicator;
class LayerTreeContext;
+class NativeWebKeyboardEvent;
struct EditorState;
}
@@ -56,7 +57,7 @@
- (void)_setCursor:(NSCursor *)cursor;
- (void)_setUserInterfaceItemState:(NSString *)commandName enabled:(BOOL)isEnabled state:(int)newState;
- (BOOL)_interpretKeyEvent:(NSEvent *)theEvent savingCommandsTo:(Vector&)commands;
-- (void)_resendKeyDownEvent:(NSEvent *)event;
+- (void)_doneWithKeyEvent:(const WebKit::NativeWebKeyboardEvent&)event eventWasHandled:(BOOL)eventWasHandled;
- (bool)_executeSavedCommandBySelector:(SEL)selector;
- (NSRect)_convertToDeviceSpace:(NSRect)rect;
- (NSRect)_convertToUserSpace:(NSRect)rect;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93551] trunk
Title: [93551] trunk
Revision 93551
Author t...@chromium.org
Date 2011-08-22 15:20:17 -0700 (Mon, 22 Aug 2011)
Log Message
Add CSS parsing of -webkit-flex-pack
https://bugs.webkit.org/show_bug.cgi?id=66701
Reviewed by Eric Seidel.
Source/WebCore:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::flexPack):
(WebCore::InheritedFlags::setFlexPack):
(WebCore::InheritedFlags::initialFlexPack):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:
LayoutTests:
* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/script-tests/css-properties.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/css-properties-expected.txt
trunk/LayoutTests/css3/flexbox/script-tests/css-properties.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSPropertyNames.in
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Source/WebCore/rendering/style/StyleFlexibleBoxData.cpp
trunk/Source/WebCore/rendering/style/StyleFlexibleBoxData.h
Diff
Modified: trunk/LayoutTests/ChangeLog (93550 => 93551)
--- trunk/LayoutTests/ChangeLog 2011-08-22 22:08:33 UTC (rev 93550)
+++ trunk/LayoutTests/ChangeLog 2011-08-22 22:20:17 UTC (rev 93551)
@@ -1,3 +1,13 @@
+2011-08-22 Tony Chang
+
+Add CSS parsing of -webkit-flex-pack
+https://bugs.webkit.org/show_bug.cgi?id=66701
+
+Reviewed by Eric Seidel.
+
+* css3/flexbox/css-properties-expected.txt:
+* css3/flexbox/script-tests/css-properties.js:
+
2011-08-22 Ryosuke Niwa
Add editing/selection/caret-at-bidi-boundary.html back to the Qt's skipped list
Modified: trunk/LayoutTests/css3/flexbox/css-properties-expected.txt (93550 => 93551)
--- trunk/LayoutTests/css3/flexbox/css-properties-expected.txt 2011-08-22 22:08:33 UTC (rev 93550)
+++ trunk/LayoutTests/css3/flexbox/css-properties-expected.txt 2011-08-22 22:20:17 UTC (rev 93551)
@@ -3,11 +3,11 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS div.style.display is "-webkit-flexbox"
-PASS div.style.display is "inline"
-PASS div.style.display is "-webkit-inline-flexbox"
-PASS div.style.display is "-webkit-inline-flexbox"
-PASS div.style.display is "block"
+PASS flexbox.style.display is "-webkit-flexbox"
+PASS flexbox.style.display is "inline"
+PASS flexbox.style.display is "-webkit-inline-flexbox"
+PASS flexbox.style.display is "-webkit-inline-flexbox"
+PASS flexbox.style.display is "block"
PASS flexitem.style.webkitFlexOrder is ""
PASS flexitem.style.webkitFlexOrder is "2"
PASS flexitem.style.webkitFlexOrder is "-1"
@@ -15,6 +15,19 @@
PASS flexitem.style.webkitFlexOrder is "0"
PASS flexitem.style.webkitFlexOrder is "0"
PASS flexitem.style.webkitFlexOrder is ""
+PASS flexbox.style.webkitFlexPack is ""
+PASS window.getComputedStyle(flexbox, null).webkitFlexPack is "start"
+PASS flexbox.style.webkitFlexPack is ""
+PASS flexbox.style.webkitFlexPack is "start"
+PASS window.getComputedStyle(flexbox, null).webkitFlexPack is "start"
+PASS flexbox.style.webkitFlexPack is "end"
+PASS window.getComputedStyle(flexbox, null).webkitFlexPack is "end"
+PASS flexbox.style.webkitFlexPack is "center"
+PASS window.getComputedStyle(flexbox, null).webkitFlexPack is "center"
+PASS flexbox.style.webkitFlexPack is "justify"
+PASS window.getComputedStyle(flexbox, null).webkitFlexPack is "justify"
+PASS flexbox.style.webkitFlexPack is ""
+PASS window.getComputedStyle(flexbox, null).webkitFlexPack is "start"
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/css3/flexbox/script-tests/css-properties.js (93550 => 93551)
--- trunk/LayoutTests/css3/flexbox/script-tests/css-properties.js 2011-08-22 22:08:33 UTC (rev 93550)
+++ trunk/LayoutTests/css3/flexbox/script-tests/css-properties.js 2011-08-22 22:20:17 UTC (rev 93551)
@@ -1,22 +1,23 @@
description('Tests being able to set the display to -webkit-flexbox and -webkit-inline-flexbox.');
-var div = document.getElementById("flexbox");
+var flexbox = document.getElementById("flexbox");
[webkit-changes] [93552] trunk/Tools
Title: [93552] trunk/Tools
Revision 93552
Author dglaz...@chromium.org
Date 2011-08-22 15:35:53 -0700 (Mon, 22 Aug 2011)
Log Message
Update unit test expectations after r93530.
* Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (93551 => 93552)
--- trunk/Tools/ChangeLog 2011-08-22 22:20:17 UTC (rev 93551)
+++ trunk/Tools/ChangeLog 2011-08-22 22:35:53 UTC (rev 93552)
@@ -1,5 +1,12 @@
2011-08-22 Dimitri Glazkov
+Update unit test expectations after r93530.
+
+* Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
+* Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
+
+2011-08-22 Dimitri Glazkov
+
[Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
https://bugs.webkit.org/show_bug.cgi?id=66705
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py (93551 => 93552)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py 2011-08-22 22:20:17 UTC (rev 93551)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py 2011-08-22 22:35:53 UTC (rev 93552)
@@ -119,7 +119,7 @@
self.assert_port("chromium-gpu-linux", chromium_gpu.ChromiumGpuLinuxPort)
def test_chromium_gpu_mac(self):
-self.assert_port("chromium-gpu-mac", chromium_gpu.ChromiumGpuMacPort)
+self.assert_port("chromium-gpu-cg-mac", chromium_gpu.ChromiumGpuMacPort)
def test_chromium_gpu_win(self):
self.assert_port("chromium-gpu-win", chromium_gpu.ChromiumGpuWinPort)
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py (93551 => 93552)
--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py 2011-08-22 22:20:17 UTC (rev 93551)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py 2011-08-22 22:35:53 UTC (rev 93552)
@@ -58,8 +58,8 @@
Retrieving results for chromium-cg-mac-snowleopard from Webkit Mac10.6 (CG).
userscripts/another-test.html
userscripts/images.svg
-Retrieving results for chromium-gpu-mac-leopard from Webkit Mac10.5 - GPU.
-Retrieving results for chromium-gpu-mac-snowleopard from Webkit Mac10.6 - GPU.
+Retrieving results for chromium-gpu-cg-mac-leopard from Webkit Mac10.5 (CG) - GPU.
+Retrieving results for chromium-gpu-cg-mac-snowleopard from Webkit Mac10.6 (CG) - GPU.
Retrieving results for chromium-gpu-win-win7 from Webkit Win7 - GPU.
Retrieving results for chromium-gpu-win-xp from Webkit Win - GPU.
Retrieving results for chromium-linux-x86 from Webkit Linux 32.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93553] trunk/Source/WebKit/chromium
Title: [93553] trunk/Source/WebKit/chromium
Revision 93553
Author ad...@chromium.org
Date 2011-08-22 15:44:31 -0700 (Mon, 22 Aug 2011)
Log Message
[chromium] Remove deprecated and unused bits of WebIDB* headers
https://bugs.webkit.org/show_bug.cgi?id=66711
Reviewed by Tony Chang.
The Chromium side of this patch was submitted as
http://crrev.com/97687.
* public/WebIDBCallbacks.h:
* public/WebIDBCursor.h:
(WebKit::WebIDBCursor::primaryKey):
(WebKit::WebIDBCursor::value):
(WebKit::WebIDBCursor::deleteFunction):
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::transaction):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h
trunk/Source/WebKit/chromium/public/WebIDBCursor.h
trunk/Source/WebKit/chromium/public/WebIDBDatabase.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (93552 => 93553)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-22 22:35:53 UTC (rev 93552)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-22 22:44:31 UTC (rev 93553)
@@ -1,3 +1,21 @@
+2011-08-22 Adam Klein
+
+[chromium] Remove deprecated and unused bits of WebIDB* headers
+https://bugs.webkit.org/show_bug.cgi?id=66711
+
+Reviewed by Tony Chang.
+
+The Chromium side of this patch was submitted as
+http://crrev.com/97687.
+
+* public/WebIDBCallbacks.h:
+* public/WebIDBCursor.h:
+(WebKit::WebIDBCursor::primaryKey):
+(WebKit::WebIDBCursor::value):
+(WebKit::WebIDBCursor::deleteFunction):
+* public/WebIDBDatabase.h:
+(WebKit::WebIDBDatabase::transaction):
+
2011-08-22 Dimitri Glazkov
Remove third_party/leveldb, because it's no longer used and doesn't exist downstream.
Modified: trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h (93552 => 93553)
--- trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h 2011-08-22 22:35:53 UTC (rev 93552)
+++ trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h 2011-08-22 22:44:31 UTC (rev 93553)
@@ -49,8 +49,6 @@
virtual void onSuccess(WebIDBCursor*) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(WebIDBDatabase*) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(const WebIDBKey&) { WEBKIT_ASSERT_NOT_REACHED(); }
-// FIXME: remove after Webkit roll.
-virtual void onSuccess(WebIDBIndex*) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(WebIDBTransaction*) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onSuccess(const WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void onBlocked() { WEBKIT_ASSERT_NOT_REACHED(); }
Modified: trunk/Source/WebKit/chromium/public/WebIDBCursor.h (93552 => 93553)
--- trunk/Source/WebKit/chromium/public/WebIDBCursor.h 2011-08-22 22:35:53 UTC (rev 93552)
+++ trunk/Source/WebKit/chromium/public/WebIDBCursor.h 2011-08-22 22:44:31 UTC (rev 93553)
@@ -55,29 +55,15 @@
WEBKIT_ASSERT_NOT_REACHED();
return WebIDBKey::createInvalid();
}
-// FIXME: Remove the following 2 methods and uncomment third after roll.
virtual WebSerializedScriptValue value() const
{
-WebSerializedScriptValue serializedScriptValue;
-WebIDBKey key;
-value(serializedScriptValue, key);
-return serializedScriptValue;
+WEBKIT_ASSERT_NOT_REACHED();
+return WebSerializedScriptValue();
}
-virtual void value(WebSerializedScriptValue& serializedScriptValue, WebIDBKey& key) const
-{
-serializedScriptValue = value();
-}
-// virtual WebSerializedScriptValue value() const
-// {
-// WEBKIT_ASSERT_NOT_REACHED();
-// return WebSerializedScriptValue();
-// }
virtual void update(const WebSerializedScriptValue&, WebIDBCallbacks*, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
virtual void continueFunction(const WebIDBKey&, WebIDBCallbacks*, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
-// FIXME: Remove after WK roll.
-virtual void remove(WebIDBCallbacks* callbacks, WebExceptionCode& ec) { deleteFunction(callbacks, ec); }
-virtual void deleteFunction(WebIDBCallbacks* callbacks, WebExceptionCode& ec) { remove(callbacks, ec); }
+virtual void deleteFunction(WebIDBCallbacks* callbacks, WebExceptionCode& ec) { WEBKIT_ASSERT_NOT_REACHED(); }
protected:
WebIDBCursor() { }
Modified: trunk/Source/WebKit/chromium/public/WebIDBDatabase.h (93552 => 93553)
--- trunk/Source/WebKit/chromium/public/WebIDBDatabase.h 2011-08-22 22:35:53 UTC (rev 93552)
+++ trunk/Source/WebKit/chromium/public/WebIDBDatabase.h 2011-08-22 22:44:31 UTC (rev 93553)
@@ -68,13 +68,9 @@
// Transfers ownership of the WebIDBTransaction to the caller.
virtual WebIDBTransaction* transaction(const WebDOMStringList& names, unsigned short mode, WebExceptionCode& ec)
{
-return transaction(names, mode, 0, ec);
+WEBKIT_ASSERT_NOT_REACHED();
+return 0;
}
-// FIXME: R
[webkit-changes] [93554] trunk/LayoutTests
Title: [93554] trunk/LayoutTests Revision 93554 Author t...@chromium.org Date 2011-08-22 16:08:36 -0700 (Mon, 22 Aug 2011) Log Message Move chromium-mac/plugins/keyboard-events-expected.txt to chromium-cg-mac/plugins/keyboard-events-expected.txt since the results for chromium-mac are currently in chromium-cg-mac. This result was added in r93519 and put in the wrong place. * platform/chromium-cg-mac/plugins/keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt. * platform/chromium-mac/plugins: Removed. * platform/chromium-mac/plugins/keyboard-events-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-cg-mac/plugins/keyboard-events-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-mac/plugins/ Diff Modified: trunk/LayoutTests/ChangeLog (93553 => 93554) --- trunk/LayoutTests/ChangeLog 2011-08-22 22:44:31 UTC (rev 93553) +++ trunk/LayoutTests/ChangeLog 2011-08-22 23:08:36 UTC (rev 93554) @@ -1,5 +1,16 @@ 2011-08-22 Tony Chang +Move chromium-mac/plugins/keyboard-events-expected.txt to +chromium-cg-mac/plugins/keyboard-events-expected.txt since the results +for chromium-mac are currently in chromium-cg-mac. This result was +added in r93519 and put in the wrong place. + +* platform/chromium-cg-mac/plugins/keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt. +* platform/chromium-mac/plugins: Removed. +* platform/chromium-mac/plugins/keyboard-events-expected.txt: Removed. + +2011-08-22 Tony Chang + Add CSS parsing of -webkit-flex-pack https://bugs.webkit.org/show_bug.cgi?id=66701 Copied: trunk/LayoutTests/platform/chromium-cg-mac/plugins/keyboard-events-expected.txt (from rev 93553, trunk/LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt) (0 => 93554) --- trunk/LayoutTests/platform/chromium-cg-mac/plugins/keyboard-events-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-cg-mac/plugins/keyboard-events-expected.txt 2011-08-22 23:08:36 UTC (rev 93554) @@ -0,0 +1,11 @@ +CONSOLE MESSAGE: line 18: PLUGIN: getFocusEvent +CONSOLE MESSAGE: line 18: PLUGIN: mouseDown at (12, 12) +CONSOLE MESSAGE: line 19: PLUGIN: mouseUp at (12, 12) +CONSOLE MESSAGE: line 22: PLUGIN: keyDown 'a' +CONSOLE MESSAGE: line 22: PLUGIN: keyUp 'a' +CONSOLE MESSAGE: line 23: PLUGIN: keyDown 'b' +CONSOLE MESSAGE: line 23: PLUGIN: keyUp 'b' +CONSOLE MESSAGE: line 24: PLUGIN: keyDown 'c' +CONSOLE MESSAGE: line 24: PLUGIN: keyUp 'c' + +This test checks if a plug-in can receive keyboard events sent from eventSender. This is a test for Bug 34936. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93555] trunk/Source/WebKit2
Title: [93555] trunk/Source/WebKit2
Revision 93555
Author oli...@apple.com
Date 2011-08-22 16:08:37 -0700 (Mon, 22 Aug 2011)
Log Message
Delay GC triggered NP object destruction to the next runloop cycle
https://bugs.webkit.org/show_bug.cgi?id=66717
Reviewed by Anders Carlsson.
Delay destruction of plugin objects caused by GC until the next
runloop cycle so that they can execute JS in their finalizers.
We do this using a zero delay timer coupled with a queue of
objects to be finalised.
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::releaseObject):
* WebProcess/Plugins/Netscape/JSNPObject.h:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::invalidate):
(WebKit::NPRuntimeObjectMap::invalidateQueuedObjects):
(WebKit::NPRuntimeObjectMap::addToInvalidationQueue):
(WebKit::NPRuntimeObjectMap::finalize):
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
* WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
(WebKit::trySafeReleaseNPObject):
* WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeUtilities.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (93554 => 93555)
--- trunk/Source/WebKit2/ChangeLog 2011-08-22 23:08:36 UTC (rev 93554)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-22 23:08:37 UTC (rev 93555)
@@ -1,3 +1,29 @@
+2011-08-22 Oliver Hunt
+
+Delay GC triggered NP object destruction to the next runloop cycle
+https://bugs.webkit.org/show_bug.cgi?id=66717
+
+Reviewed by Anders Carlsson.
+
+Delay destruction of plugin objects caused by GC until the next
+runloop cycle so that they can execute JS in their finalizers.
+We do this using a zero delay timer coupled with a queue of
+objects to be finalised.
+
+* WebProcess/Plugins/Netscape/JSNPObject.cpp:
+(WebKit::JSNPObject::releaseObject):
+* WebProcess/Plugins/Netscape/JSNPObject.h:
+* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
+(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
+(WebKit::NPRuntimeObjectMap::invalidate):
+(WebKit::NPRuntimeObjectMap::invalidateQueuedObjects):
+(WebKit::NPRuntimeObjectMap::addToInvalidationQueue):
+(WebKit::NPRuntimeObjectMap::finalize):
+* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
+* WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
+(WebKit::trySafeReleaseNPObject):
+* WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
+
2011-08-22 Anders Carlsson
Move code from PageClientImpl::doneWithKeyEvent to WKView
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp (93554 => 93555)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp 2011-08-22 23:08:36 UTC (rev 93554)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp 2011-08-22 23:08:37 UTC (rev 93555)
@@ -77,6 +77,16 @@
m_npObject = 0;
}
+NPObject* JSNPObject::leakNPObject()
+{
+ASSERT(m_npObject);
+ASSERT_GC_OBJECT_INHERITS(this, &s_info);
+
+NPObject* object = m_npObject;
+m_npObject = 0;
+return object;
+}
+
JSValue JSNPObject::callMethod(ExecState* exec, NPIdentifier methodName)
{
ASSERT_GC_OBJECT_INHERITS(this, &s_info);
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h (93554 => 93555)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h 2011-08-22 23:08:36 UTC (rev 93554)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h 2011-08-22 23:08:37 UTC (rev 93555)
@@ -50,6 +50,9 @@
void invalidate();
+// Used to invalidate an NPObject asynchronously.
+NPObject* leakNPObject();
+
JSC::JSValue callMethod(JSC::ExecState*, NPIdentifier methodName);
JSC::JSValue callObject(JSC::ExecState*);
JSC::JSValue callConstructor(JSC::ExecState*);
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp (93554 => 93555)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp 2011-08-22 23:08:36 UTC (rev 93554)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp 2011-08-22 23:08:37 UTC (rev 93555)
@@ -30,6 +30,7 @@
#include "NPJSObject.h"
#include "NPRuntimeUtilities.h"
#include "PluginView.h"
+#include "WebProcess.h"
#include <_javascript_Core/Error.h>
#include <_javascript_Core/JSLock.h>
#include <_javascript_Core/SourceCode.h>
@@ -45,6 +46,7 @@
NPRuntimeObjectMap::NPRuntimeObjectMap(PluginView*
[webkit-changes] [93556] trunk
Title: [93556] trunk
Revision 93556
Author pkast...@chromium.org
Date 2011-08-22 16:15:05 -0700 (Mon, 22 Aug 2011)
Log Message
Unreviewed, rolling out r93538.
http://trac.webkit.org/changeset/93538
https://bugs.webkit.org/show_bug.cgi?id=66143
Broke Leopard, SnowLeopard, and Chromium Mac bots
Source/WebCore:
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::logicalRightOffsetForLine):
* rendering/RenderBlock.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
LayoutTests:
* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
* fast/regions/webkit-flow-floats-inside-regions-bounds.html: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/LayoutState.cpp
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderFlowThread.h
trunk/Source/WebCore/rendering/RenderRegion.cpp
trunk/Source/WebCore/rendering/RenderRegion.h
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
Removed Paths
trunk/LayoutTests/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt
trunk/LayoutTests/fast/regions/webkit-flow-floats-inside-regions-bounds.html
trunk/LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt
trunk/LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt
trunk/LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html
trunk/LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds.html
Diff
Modified: trunk/LayoutTests/ChangeLog (93555 => 93556)
--- trunk/LayoutTests/ChangeLog 2011-08-22 23:08:37 UTC (rev 93555)
+++ trunk/LayoutTests/ChangeLog 2011-08-22 23:15:05 UTC (rev 93556)
@@ -1,3 +1,18 @@
+2011-08-22 Peter Kasting
+
+Unreviewed, rolling out r93538.
+http://trac.webkit.org/changeset/93538
+https://bugs.webkit.org/show_bug.cgi?id=66143
+
+Broke Leopard, SnowLeopard, and Chromium Mac bots
+
+* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
+* fast/regions/webkit-flow-floats-inside-regions-bounds.html: Removed.
+* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
+* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Removed.
+* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Removed.
+* fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Removed.
+
2011-08-22 Tony Chang
Move chromium-mac/plugins/keyboard-events-expected.txt to
Deleted: trunk/LayoutTests/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt (93555 => 93556)
--- trunk/LayoutTests/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt 2011-08-22 23:08:37 UTC (rev 93555)
+++ trunk/LayoutTests/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt 2011-08-22 23:15:05 UTC (rev 93556)
@@ -1,52 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x422
- RenderBlock {HTML} at (0,0) size 800x422
-RenderBody {BODY} at (8,8) size 784x406
- RenderBlock {DIV} at (0,0) size 784x406
-RenderRegion {DIV} at (0,0) size 202x102 [border: (1px solid #00)]
-RenderRegion {DIV} at (0,102) size 302x182 [border: (1px solid #00)]
-RenderRegion {DIV} at (0,284) size 122x122 [border: (1px solid #00)]
-Flow Threads
- Thread with flow-name 'flow1'
-layer at (0,0) size 300x400
- RenderFlowThread at (0,0) size 300x400
-RenderBlock {DIV} at (0,0) size 300x474
- RenderBlock {DIV} at (5,5) size 290x464 [border: (1px solid #FF)]
-RenderBlock {DIV} at (11,11) size 268x442 [border: (1px solid #008000)]
- RenderBlock {P} at (1,17) size 266x36
-RenderText {#text} at (0,0) size 166x36
- text run at (0,0) width 166: "This line of text should"
- text run at (0,18) width 155: "not get out of the region."
-
[webkit-changes] [93557] trunk/Source/WebCore
Title: [93557] trunk/Source/WebCore
Revision 93557
Author macpher...@chromium.org
Date 2011-08-22 16:24:18 -0700 (Mon, 22 Aug 2011)
Log Message
Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty.
https://bugs.webkit.org/show_bug.cgi?id=66648
Reviewed by Dan Bernstein.
No new tests / no functionality changed.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from EBackfaceVisibility.
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
Support cast from EBackfaceVisibility.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (93556 => 93557)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 23:15:05 UTC (rev 93556)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 23:24:18 UTC (rev 93557)
@@ -1,3 +1,21 @@
+2011-08-22 Luke Macpherson
+
+Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty.
+https://bugs.webkit.org/show_bug.cgi?id=66648
+
+Reviewed by Dan Bernstein.
+
+No new tests / no functionality changed.
+
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+Support cast from EBackfaceVisibility.
+(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
+Support cast from EBackfaceVisibility.
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.
+
2011-08-22 Peter Kasting
Unreviewed, rolling out r93538.
Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (93556 => 93557)
--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2011-08-22 23:15:05 UTC (rev 93556)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2011-08-22 23:24:18 UTC (rev 93557)
@@ -457,6 +457,34 @@
return ControlPart(m_value.ident - CSSValueCheckbox + 1);
}
+template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EBackfaceVisibility e)
+: m_type(CSS_IDENT)
+, m_hasCachedCSSText(false)
+{
+switch (e) {
+case BackfaceVisibilityVisible:
+m_value.ident = CSSValueVisible;
+break;
+case BackfaceVisibilityHidden:
+m_value.ident = CSSValueHidden;
+break;
+}
+}
+
+template<> inline CSSPrimitiveValue::operator EBackfaceVisibility() const
+{
+switch (m_value.ident) {
+case CSSValueVisible:
+return BackfaceVisibilityVisible;
+case CSSValueHidden:
+return BackfaceVisibilityHidden;
+default:
+ASSERT_NOT_REACHED();
+return BackfaceVisibilityHidden;
+}
+}
+
+
template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EFillAttachment e)
: m_type(CSS_IDENT)
, m_hasCachedCSSText(false)
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (93556 => 93557)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-08-22 23:15:05 UTC (rev 93556)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-08-22 23:24:18 UTC (rev 93557)
@@ -4483,9 +4483,7 @@
case CSSPropertyUnicodeRange: // Only used in @font-face rules.
return;
case CSSPropertyWebkitBackfaceVisibility:
-HANDLE_INHERIT_AND_INITIAL(backfaceVisibility, BackfaceVisibility)
-if (primitiveValue)
-m_style->setBackfaceVisibility((primitiveValue->getIdent() == CSSValueVisible) ? BackfaceVisibilityVisible : BackfaceVisibilityHidden);
+HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(backfaceVisibility, BackfaceVisibility)
return;
case CSSPropertyWebkitBoxDirection:
HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(boxDirection, BoxDirection)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93558] trunk/Source/WebCore
Title: [93558] trunk/Source/WebCore
Revision 93558
Author le...@chromium.org
Date 2011-08-22 16:30:10 -0700 (Mon, 22 Aug 2011)
Log Message
Fix usage of PassRefPtr in postMessage and structured clone code.
https://bugs.webkit.org/show_bug.cgi?id=66725
Reviewed by Darin Adler.
No new functionality exposed so no new tests.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::postMessage): Changed PassRefPtr to RefPtr and added release when handed off.
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent): Ditto.
* bindings/js/JSMessagePortCustom.h:
(WebCore::handlePostMessage): Ditto.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create): Ditto.
* workers/SharedWorkerContext.cpp:
(WebCore::createConnectEvent): Added release() when a RefPtr is returned.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp
trunk/Source/WebCore/bindings/js/JSMessagePortCustom.h
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/workers/SharedWorkerContext.cpp
Property Changed
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/Source/WebCore/ChangeLog (93557 => 93558)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 23:24:18 UTC (rev 93557)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 23:30:10 UTC (rev 93558)
@@ -1,3 +1,23 @@
+2011-08-22 David Levin
+
+Fix usage of PassRefPtr in postMessage and structured clone code.
+https://bugs.webkit.org/show_bug.cgi?id=66725
+
+Reviewed by Darin Adler.
+
+No new functionality exposed so no new tests.
+
+* bindings/js/JSDOMWindowCustom.cpp:
+(WebCore::JSDOMWindow::postMessage): Changed PassRefPtr to RefPtr and added release when handed off.
+* bindings/js/JSMessageEventCustom.cpp:
+(WebCore::JSMessageEvent::initMessageEvent): Ditto.
+* bindings/js/JSMessagePortCustom.h:
+(WebCore::handlePostMessage): Ditto.
+* bindings/js/SerializedScriptValue.cpp:
+(WebCore::SerializedScriptValue::create): Ditto.
+* workers/SharedWorkerContext.cpp:
+(WebCore::createConnectEvent): Added release() when a RefPtr is returned.
+
2011-08-22 Luke Macpherson
Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty.
Property changes on: trunk/Source/WebCore/ChangeLog
___
Deleted: svn:executable
Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (93557 => 93558)
--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2011-08-22 23:24:18 UTC (rev 93557)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2011-08-22 23:30:10 UTC (rev 93558)
@@ -699,7 +699,7 @@
JSValue JSDOMWindow::postMessage(ExecState* exec)
{
-PassRefPtr message = SerializedScriptValue::create(exec, exec->argument(0));
+RefPtr message = SerializedScriptValue::create(exec, exec->argument(0));
if (exec->hadException())
return jsUndefined();
@@ -715,7 +715,7 @@
return jsUndefined();
ExceptionCode ec = 0;
-impl()->postMessage(message, &messagePorts, targetOrigin, activeDOMWindow(exec), ec);
+impl()->postMessage(message.release(), &messagePorts, targetOrigin, activeDOMWindow(exec), ec);
setDOMException(exec, ec);
return jsUndefined();
Modified: trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp (93557 => 93558)
--- trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp 2011-08-22 23:24:18 UTC (rev 93557)
+++ trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp 2011-08-22 23:30:10 UTC (rev 93558)
@@ -59,7 +59,7 @@
const UString& typeArg = exec->argument(0).toString(exec);
bool canBubbleArg = exec->argument(1).toBoolean(exec);
bool cancelableArg = exec->argument(2).toBoolean(exec);
-PassRefPtr dataArg = SerializedScriptValue::create(exec, exec->argument(3));
+RefPtr dataArg = SerializedScriptValue::create(exec, exec->argument(3));
if (exec->hadException())
return jsUndefined();
const UString& originArg = exec->argument(4).toString(exec);
@@ -74,7 +74,7 @@
}
MessageEvent* event = static_cast(this->impl());
-event->initMessageEvent(ustringToAtomicString(typeArg), canBubbleArg, cancelableArg, dataArg, ustringToString(originArg), ustringToString(lastEventIdArg), sourceArg, messagePorts.release());
+event->initMessageEvent(ustringToAtomicString(typeArg), canBubbleArg, cancelableArg, dataArg.release(), ustringToString(originArg), ustringToString(lastEventIdArg), sourceArg, messagePorts.release());
return jsUndefined();
}
Modified: trunk/Source/WebCore/bindings/js/JSMessagePortCustom.h (93557 => 93558)
--- trunk/Source/WebCore/bindings/js/JSMessagePortCustom.h 2011-08-22 23:24:18 UTC (rev 93557)
+++ trunk/Source/WebCore/bindings
[webkit-changes] [93559] trunk/Source/WebCore
Title: [93559] trunk/Source/WebCore Revision 93559 Author e...@webkit.org Date 2011-08-22 16:34:31 -0700 (Mon, 22 Aug 2011) Log Message Attempt to clean up bidiNext usage https://bugs.webkit.org/show_bug.cgi?id=66721 Reviewed by Ryosuke Niwa. bidiNext and bidiFirst are horribly confusing. Even worse is that bidiNext takes a bunch of mutually exclusive options. It appears that there is a "return me every inline, even if its empty" mode which is only used for simplified inline layout in RenderBlock.cpp. To support that mode, there is a endOfInline pointer which keeps track of if we just returned at the end of an inline to so we don't get stuck in and empty inline (unable to distinguish the start from the finish). The actual bidi/line-layout code uses bidiNext/bidiFirst in a "skip empty inlines" mode. (Since empty inlines do not participate in the Unicode Bidi Algorithm.) This change renames bidiNext to bidiNextShared (still a horrible name) and moves all callers to explicitly calling bidiNextSkippingEmptyInlines or bidiNextIncludingEmptyInlines. It becomes obvious which code uses which. In reviewing this code be aware that the previous bidiNext default was to "skip empty inlines" (skipInlines = true). Thus any caller who didn't pass true/false should now be calling bidiNextSkippingEmptyInlines instead. No functional change, thus no tests. * rendering/InlineIterator.h: (WebCore::bidiNextShared): (WebCore::bidiNextSkippingEmptyInlines): (WebCore::bidiNextIncludingEmptyInlines): (WebCore::bidiFirstSkippingEmptyInlines): (WebCore::bidiFirstIncludingEmptyInlines): (WebCore::InlineWalker::InlineWalker): (WebCore::InlineWalker::advance): (WebCore::InlineIterator::increment): (WebCore::InlineBidiResolver::appendRun): * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::determineStartPosition): (WebCore::shouldSkipWhitespaceAfterStartObject): (WebCore::RenderBlock::LineBreaker::nextLineBreak): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/InlineIterator.h trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (93558 => 93559) --- trunk/Source/WebCore/ChangeLog 2011-08-22 23:30:10 UTC (rev 93558) +++ trunk/Source/WebCore/ChangeLog 2011-08-22 23:34:31 UTC (rev 93559) @@ -1,3 +1,45 @@ +2011-08-22 Eric Seidel + +Attempt to clean up bidiNext usage +https://bugs.webkit.org/show_bug.cgi?id=66721 + +Reviewed by Ryosuke Niwa. + +bidiNext and bidiFirst are horribly confusing. +Even worse is that bidiNext takes a bunch of mutually exclusive options. +It appears that there is a "return me every inline, even if its empty" +mode which is only used for simplified inline layout in RenderBlock.cpp. +To support that mode, there is a endOfInline pointer which keeps track +of if we just returned at the end of an inline to so we don't get stuck in +and empty inline (unable to distinguish the start from the finish). + +The actual bidi/line-layout code uses bidiNext/bidiFirst in a "skip empty inlines" +mode. (Since empty inlines do not participate in the Unicode Bidi Algorithm.) + +This change renames bidiNext to bidiNextShared (still a horrible name) and moves +all callers to explicitly calling bidiNextSkippingEmptyInlines or bidiNextIncludingEmptyInlines. +It becomes obvious which code uses which. + +In reviewing this code be aware that the previous bidiNext default was to "skip empty inlines" (skipInlines = true). +Thus any caller who didn't pass true/false should now be calling bidiNextSkippingEmptyInlines instead. + +No functional change, thus no tests. + +* rendering/InlineIterator.h: +(WebCore::bidiNextShared): +(WebCore::bidiNextSkippingEmptyInlines): +(WebCore::bidiNextIncludingEmptyInlines): +(WebCore::bidiFirstSkippingEmptyInlines): +(WebCore::bidiFirstIncludingEmptyInlines): +(WebCore::InlineWalker::InlineWalker): +(WebCore::InlineWalker::advance): +(WebCore::InlineIterator::increment): +(WebCore::InlineBidiResolver::appendRun): +* rendering/RenderBlockLineLayout.cpp: +(WebCore::RenderBlock::determineStartPosition): +(WebCore::shouldSkipWhitespaceAfterStartObject): +(WebCore::RenderBlock::LineBreaker::nextLineBreak): + 2011-08-22 David Levin Fix usage of PassRefPtr in postMessage and structured clone code. Modified: trunk/Source/WebCore/rendering/InlineIterator.h (93558 => 93559) --- trunk/Source/WebCore/rendering/InlineIterator.h 2011-08-22 23:30:10 UTC (rev 93558) +++ trunk/Source/WebCore/rendering/InlineIterator.h 2011-08-22 23:34:31 UTC (rev 93559) @@ -139,10 +139,16 @@ return object->isText() || object->isFloating() || object->isPositioned() || object->isReplaced(); } +// This enum is only used for bidiNextShared() +enum EmptyInli
[webkit-changes] [93560] trunk/Source/JavaScriptCore
Title: [93560] trunk/Source/_javascript_Core Revision 93560 Author fpi...@apple.com Date 2011-08-22 16:41:20 -0700 (Mon, 22 Aug 2011) Log Message Sampling counter support is in the bytecode directory https://bugs.webkit.org/show_bug.cgi?id=66724 Reviewed by Darin Adler. Moved SamplingCounter to a separate header in runtime/. * GNUmakefile.list.am: * _javascript_Core.pro: * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj: * _javascript_Core.xcodeproj/project.pbxproj: * bytecode/SamplingTool.cpp: * bytecode/SamplingTool.h: * runtime/SamplingCounter.cpp: Added. (JSC::AbstractSamplingCounter::dump): * runtime/SamplingCounter.h: Added. (JSC::AbstractSamplingCounter::count): (JSC::AbstractSamplingCounter::addressOfCounter): (JSC::AbstractSamplingCounter::init): (JSC::SamplingCounter::SamplingCounter): (JSC::GlobalSamplingCounter::name): (JSC::DeletableSamplingCounter::DeletableSamplingCounter): (JSC::DeletableSamplingCounter::~DeletableSamplingCounter): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/_javascript_Core/_javascript_Core.pro trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/bytecode/SamplingTool.cpp trunk/Source/_javascript_Core/bytecode/SamplingTool.h Added Paths trunk/Source/_javascript_Core/runtime/SamplingCounter.cpp trunk/Source/_javascript_Core/runtime/SamplingCounter.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (93559 => 93560) --- trunk/Source/_javascript_Core/ChangeLog 2011-08-22 23:34:31 UTC (rev 93559) +++ trunk/Source/_javascript_Core/ChangeLog 2011-08-22 23:41:20 UTC (rev 93560) @@ -1,3 +1,29 @@ +2011-08-22 Filip Pizlo + +Sampling counter support is in the bytecode directory +https://bugs.webkit.org/show_bug.cgi?id=66724 + +Reviewed by Darin Adler. + +Moved SamplingCounter to a separate header in runtime/. + +* GNUmakefile.list.am: +* _javascript_Core.pro: +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj: +* _javascript_Core.xcodeproj/project.pbxproj: +* bytecode/SamplingTool.cpp: +* bytecode/SamplingTool.h: +* runtime/SamplingCounter.cpp: Added. +(JSC::AbstractSamplingCounter::dump): +* runtime/SamplingCounter.h: Added. +(JSC::AbstractSamplingCounter::count): +(JSC::AbstractSamplingCounter::addressOfCounter): +(JSC::AbstractSamplingCounter::init): +(JSC::SamplingCounter::SamplingCounter): +(JSC::GlobalSamplingCounter::name): +(JSC::DeletableSamplingCounter::DeletableSamplingCounter): +(JSC::DeletableSamplingCounter::~DeletableSamplingCounter): + 2011-08-21 Martin Robinson Fix 'make dist' for WebKitGTK+. Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (93559 => 93560) --- trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-08-22 23:34:31 UTC (rev 93559) +++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-08-22 23:41:20 UTC (rev 93560) @@ -406,6 +406,8 @@ Source/_javascript_Core/runtime/RegExpPrototype.h \ Source/_javascript_Core/runtime/RopeImpl.cpp \ Source/_javascript_Core/runtime/RopeImpl.h \ + Source/_javascript_Core/runtime/SamplingCounter.cpp \ + Source/_javascript_Core/runtime/SamplingCounter.h \ Source/_javascript_Core/runtime/ScopeChain.cpp \ Source/_javascript_Core/runtime/ScopeChain.h \ Source/_javascript_Core/runtime/ScopeChainMark.h \ Modified: trunk/Source/_javascript_Core/_javascript_Core.pro (93559 => 93560) --- trunk/Source/_javascript_Core/_javascript_Core.pro 2011-08-22 23:34:31 UTC (rev 93559) +++ trunk/Source/_javascript_Core/_javascript_Core.pro 2011-08-22 23:41:20 UTC (rev 93560) @@ -183,6 +183,7 @@ runtime/RegExpPrototype.cpp \ runtime/RegExpCache.cpp \ runtime/RopeImpl.cpp \ +runtime/SamplingCounter.cpp \ runtime/ScopeChain.cpp \ runtime/SmallStrings.cpp \ runtime/StrictEvalActivation.cpp \ Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj (93559 => 93560) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj 2011-08-22 23:34:31 UTC (rev 93559) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj 2011-08-22 23:41:20 UTC (rev 93560) @@ -1113,6 +1113,14 @@ RelativePath="..\..\runtime\ScopeChainMark.h" > + + + + RelativePath="..\..\runtime\SmallStrings.cpp" > Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (93559 => 93560) --- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2011-08-22 23:34:31 U
[webkit-changes] [93561] trunk
Title: [93561] trunk
Revision 93561
Author aba...@webkit.org
Date 2011-08-22 16:52:37 -0700 (Mon, 22 Aug 2011)
Log Message
HTMLSourceTracker crashes when network packets break poorly
https://bugs.webkit.org/show_bug.cgi?id=66728
Reviewed by Darin Adler.
Source/WebCore:
If there is a network packet boundary in the middle of an attribute
that begins with the letters "on", then the HTMLSourceTracker will get
confused and try to extract too many characters from future input. If
the future input is small enough, that will walk off the end of the
input and crash.
Test: http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html
* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken):
LayoutTests:
Test that we don't crash when we get a bad network packet boundary.
* http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt: Added.
* http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html: Added.
* http/tests/security/xssAuditor/resources/tag-with-pause.php: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLSourceTracker.cpp
Added Paths
trunk/LayoutTests/http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt
trunk/LayoutTests/http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html
trunk/LayoutTests/http/tests/security/xssAuditor/resources/tag-with-pause.php
Diff
Modified: trunk/LayoutTests/ChangeLog (93560 => 93561)
--- trunk/LayoutTests/ChangeLog 2011-08-22 23:41:20 UTC (rev 93560)
+++ trunk/LayoutTests/ChangeLog 2011-08-22 23:52:37 UTC (rev 93561)
@@ -1,3 +1,16 @@
+2011-08-22 Adam Barth
+
+HTMLSourceTracker crashes when network packets break poorly
+https://bugs.webkit.org/show_bug.cgi?id=66728
+
+Reviewed by Darin Adler.
+
+Test that we don't crash when we get a bad network packet boundary.
+
+* http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt: Added.
+* http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html: Added.
+* http/tests/security/xssAuditor/resources/tag-with-pause.php: Added.
+
2011-08-22 Peter Kasting
Unreviewed, rolling out r93538.
Added: trunk/LayoutTests/http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt (0 => 93561)
--- trunk/LayoutTests/http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt 2011-08-22 23:52:37 UTC (rev 93561)
@@ -0,0 +1,2 @@
+This test passes if it doesn't crash.
+
Added: trunk/LayoutTests/http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html (0 => 93561)
--- trunk/LayoutTests/http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html (rev 0)
+++ trunk/LayoutTests/http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html 2011-08-22 23:52:37 UTC (rev 93561)
@@ -0,0 +1,8 @@
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.setXSSAuditorEnabled(true);
+}
+
+This test passes if it doesn't crash.
+
Added: trunk/LayoutTests/http/tests/security/xssAuditor/resources/tag-with-pause.php (0 => 93561)
--- trunk/LayoutTests/http/tests/security/xssAuditor/resources/tag-with-pause.php (rev 0)
+++ trunk/LayoutTests/http/tests/security/xssAuditor/resources/tag-with-pause.php 2011-08-22 23:52:37 UTC (rev 93561)
@@ -0,0 +1,18 @@
+
+
+
+";
+?>
+Done.
Modified: trunk/Source/WebCore/ChangeLog (93560 => 93561)
--- trunk/Source/WebCore/ChangeLog 2011-08-22 23:41:20 UTC (rev 93560)
+++ trunk/Source/WebCore/ChangeLog 2011-08-22 23:52:37 UTC (rev 93561)
@@ -1,3 +1,21 @@
+2011-08-22 Adam Barth
+
+HTMLSourceTracker crashes when network packets break poorly
+https://bugs.webkit.org/show_bug.cgi?id=66728
+
+Reviewed by Darin Adler.
+
+If there is a network packet boundary in the middle of an attribute
+that begins with the letters "on", then the HTMLSourceTracker will get
+confused and try to extract too many characters from future input. If
+the future input is small enough, that will walk off the end of the
+input and crash.
+
+Test: http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html
+
+* html/parser/HTMLSourceTracker.cpp:
+(WebCore::HTMLSourceTracker::sourceForToken):
+
2011-08-22 Eric Seidel
Attempt to clean up bidiNext usage
Modified: trunk/Source/WebCore/html/parser/HTMLSourceTracker.cpp (93560 => 93561)
--- trunk/Source/WebCore/html/parser/HTMLSourceTracker.cpp 2011-08-22 23:41:20 UTC (rev 93560)
+++ trunk/Source/WebCore/html/parser/HTMLSourceTracker.cpp 2011-08-22 23:52:37 UTC (rev 93561)
@@ -60,6 +60,7 @@
Strin
[webkit-changes] [93562] trunk/Tools
Title: [93562] trunk/Tools Revision 93562 Author dglaz...@chromium.org Date 2011-08-22 16:53:19 -0700 (Mon, 22 Aug 2011) Log Message webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file. https://bugs.webkit.org/show_bug.cgi?id=66727 Reviewed by Adam Barth. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter, in which case the serializer treats all expectations as unparsed. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py Diff Modified: trunk/Tools/ChangeLog (93561 => 93562) --- trunk/Tools/ChangeLog 2011-08-22 23:52:37 UTC (rev 93561) +++ trunk/Tools/ChangeLog 2011-08-22 23:53:19 UTC (rev 93562) @@ -1,5 +1,16 @@ 2011-08-22 Dimitri Glazkov +webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file. +https://bugs.webkit.org/show_bug.cgi?id=66727 + +Reviewed by Adam Barth. + +* Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter, +in which case the serializer treats all expectations as unparsed. +* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests. + +2011-08-22 Dimitri Glazkov + Update unit test expectations after r93530. * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (93561 => 93562) --- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2011-08-22 23:52:37 UTC (rev 93561) +++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2011-08-22 23:53:19 UTC (rev 93562) @@ -121,7 +121,7 @@ class TestExpectationSerializer(object): """Provides means of serializing TestExpectationLine instances.""" -def __init__(self, test_configuration_converter): +def __init__(self, test_configuration_converter=None): self._test_configuration_converter = test_configuration_converter self._parsed_expectation_to_string = dict([[parsed_expectation, expectation_string] for expectation_string, parsed_expectation in TestExpectations.EXPECTATIONS.items()]) @@ -132,7 +132,7 @@ if expectation_line.name is None: return '' if expectation_line.comment is None else "//%s" % expectation_line.comment -if expectation_line.parsed_bug_modifiers: +if self._test_configuration_converter and expectation_line.parsed_bug_modifiers: specifiers_list = self._test_configuration_converter.to_specifiers_list(expectation_line.matching_configurations) result = [] for specifiers in specifiers_list: @@ -151,6 +151,7 @@ return ' '.join(result) def _parsed_modifier_string(self, expectation_line, specifiers): +assert(self._test_configuration_converter) result = [] if expectation_line.parsed_bug_modifiers: result.extend(sorted(expectation_line.parsed_bug_modifiers)) @@ -166,7 +167,7 @@ return result @classmethod -def list_to_string(cls, expectation_lines, test_configuration_converter, reconstitute_only_these=None): +def list_to_string(cls, expectation_lines, test_configuration_converter=None, reconstitute_only_these=None): serializer = cls(test_configuration_converter) def serialize(expectation_line): @@ -930,12 +931,12 @@ def has_warnings(self): return self._has_warnings -def remove_rebaselined_tests(self, tests): +def remove_rebaselined_tests(self, except_these_tests): """Returns a copy of the expectations with the tests removed.""" def without_rebaseline_modifier(expectation): -return not (not expectation.is_malformed() and expectation.name in tests and "rebaseline" in expectation.modifiers) +return not (not expectation.is_malformed() and expectation.name in except_these_tests and "rebaseline" in expectation.modifiers) -return TestExpectationSerializer.list_to_string(filter(without_rebaseline_modifier, self._expectations), self._test_configuration_converter) +return TestExpectationSerializer.list_to_string(filter(without_rebaseline_modifier, self._expectations)) def _add_expectations(self, expectation_list, overrides_allowed): for expectation_line in expectation_list: Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py (93561 => 93562) --- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py 2011-08-22 23:52:37 UTC (
[webkit-changes] [93563] trunk/Tools
Title: [93563] trunk/Tools Revision 93563 Author e...@webkit.org Date 2011-08-22 17:05:10 -0700 (Mon, 22 Aug 2011) Log Message Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot. I won't have ssh access to the bot again for a couple days, so attempting to fix by changing this script. If this doesn't work we'll just live with the it hung for now. Unreviewed. * EWSTools/start-queue.sh: Modified Paths trunk/Tools/ChangeLog trunk/Tools/EWSTools/start-queue.sh Diff Modified: trunk/Tools/ChangeLog (93562 => 93563) --- trunk/Tools/ChangeLog 2011-08-22 23:53:19 UTC (rev 93562) +++ trunk/Tools/ChangeLog 2011-08-23 00:05:10 UTC (rev 93563) @@ -1,3 +1,14 @@ +2011-08-22 Eric Seidel + +Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot. +I won't have ssh access to the bot again for a couple days, so +attempting to fix by changing this script. If this doesn't +work we'll just live with the it hung for now. + +Unreviewed. + +* EWSTools/start-queue.sh: + 2011-08-22 Dimitri Glazkov webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file. Modified: trunk/Tools/EWSTools/start-queue.sh (93562 => 93563) --- trunk/Tools/EWSTools/start-queue.sh 2011-08-22 23:53:19 UTC (rev 93562) +++ trunk/Tools/EWSTools/start-queue.sh 2011-08-23 00:05:10 UTC (rev 93563) @@ -64,6 +64,10 @@ git fetch git svn rebase + # Hack to fix cr-jail-1 (cr-mac-ews). gclient seems to be failing to update third_party/leveldatabase. + # FIXME: This can be removed at any point in the future. + svn cleanup Source/WebKit/chromium/third_party/leveldatabase + # test-webkitpy has code to remove orphaned .pyc files, so we # run it before running webkit-patch to avoid stale .pyc files # preventing webkit-patch from launching. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93564] trunk/Source
Title: [93564] trunk/Source
Revision 93564
Author nd...@chromium.org
Date 2011-08-22 17:14:13 -0700 (Mon, 22 Aug 2011)
Log Message
Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily
https://bugs.webkit.org/show_bug.cgi?id=66708
Reviewed by Kenneth Russell.
Source/WebCore:
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::texImage2DResourceSafe):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/gtk/GraphicsContext3DGtk.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::isResourceSafe):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
Source/WebKit/chromium:
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::isResourceSafe):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::isResourceSafe):
* src/GraphicsContext3DInternal.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h
trunk/Source/WebCore/platform/graphics/gtk/GraphicsContext3DGtk.cpp
trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp
trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp
trunk/Source/WebKit/chromium/src/GraphicsContext3DInternal.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (93563 => 93564)
--- trunk/Source/WebCore/ChangeLog 2011-08-23 00:05:10 UTC (rev 93563)
+++ trunk/Source/WebCore/ChangeLog 2011-08-23 00:14:13 UTC (rev 93564)
@@ -1,3 +1,22 @@
+2011-08-22 Nat Duca
+
+Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily
+https://bugs.webkit.org/show_bug.cgi?id=66708
+
+Reviewed by Kenneth Russell.
+
+* platform/graphics/GraphicsContext3D.cpp:
+(WebCore::GraphicsContext3D::texImage2DResourceSafe):
+* platform/graphics/GraphicsContext3D.h:
+* platform/graphics/gtk/GraphicsContext3DGtk.cpp:
+(WebCore::GraphicsContext3D::GraphicsContext3D):
+* platform/graphics/mac/GraphicsContext3DMac.mm:
+(WebCore::GraphicsContext3D::GraphicsContext3D):
+* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
+(WebCore::GraphicsContext3D::isResourceSafe):
+* platform/graphics/qt/GraphicsContext3DQt.cpp:
+(WebCore::GraphicsContext3D::GraphicsContext3D):
+
2011-08-22 Adam Barth
HTMLSourceTracker crashes when network packets break poorly
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp (93563 => 93564)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp 2011-08-23 00:05:10 UTC (rev 93563)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp 2011-08-23 00:14:13 UTC (rev 93564)
@@ -66,7 +66,7 @@
{
ASSERT(unpackAlignment == 1 || unpackAlignment == 2 || unpackAlignment == 4 || unpackAlignment == 8);
OwnArrayPtr zero;
-if (!m_isResourceSafe && width > 0 && height > 0) {
+if (!isResourceSafe() && width > 0 && height > 0) {
unsigned int size;
GC3Denum error = computeImageSizeInBytes(format, type, width, height, unpackAlignment, &size, 0);
if (error != GraphicsContext3D::NO_ERROR) {
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h (93563 => 93564)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h 2011-08-23 00:05:10 UTC (rev 93563)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h 2011-08-23 00:14:13 UTC (rev 93564)
@@ -905,7 +905,7 @@
#endif
int m_currentWidth, m_currentHeight;
-bool m_isResourceSafe;
+bool isResourceSafe();
#if PLATFORM(MAC)
CGLContextObj m_contextObj;
Modified: trunk/Source/WebCore/platform/graphics/gtk/GraphicsContext3DGtk.cpp (93563 => 93564)
--- trunk/Source/WebCore/platform/graphics/gtk/GraphicsContext3DGtk.cpp 2011-08-23 00:05:10 UTC (rev 93563)
+++ trunk/Source/WebCore/platform/graphics/gtk/GraphicsContext3DGtk.cpp 2011-08-23 00:14:13 UTC (rev 93564)
@@ -55,7 +55,6 @@
GraphicsContext3D::GraphicsContext3D(GraphicsContext3D::Attributes attributes, HostWindow*, bool)
: m_currentWidth(0)
, m_currentHeight(0)
-, m_isResourceSafe(false)
, m_attrs(attributes)
, m_texture(0)
, m_fbo(0)
Modified: trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm (93563 => 93564)
--- trunk/Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm 2011-08-23 00:05:10 UTC (rev 93563)
+++ trunk/Source/WebCore/platform/graphics/mac
[webkit-changes] [93565] trunk
Title: [93565] trunk Revision 93565 Author commit-qu...@webkit.org Date 2011-08-22 17:24:30 -0700 (Mon, 22 Aug 2011) Log Message Patch by Alice Boxhall on 2011-08-22 Reviewed by Chris Fleizach. aria-labelledby should be used in preference to aria-labeledby https://bugs.webkit.org/show_bug.cgi?id=62351 Source/WebCore: Test: accessibility/aria-labelledby-overrides-aria-labeledby.html * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::ariaLabelledByElements): Renamed from ariaLabeledByElements. (WebCore::AccessibilityRenderObject::ariaLabelledByAttribute): Renamed from ariaLabeledByAttribute, and re-ordered to prefer the standard spelling. (WebCore::AccessibilityRenderObject::title): (WebCore::AccessibilityRenderObject::hasTextAlternative): * accessibility/AccessibilityRenderObject.h: LayoutTests: * accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Added. * accessibility/aria-labelledby-overrides-aria-labeledby.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h Added Paths trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby.html Diff Modified: trunk/LayoutTests/ChangeLog (93564 => 93565) --- trunk/LayoutTests/ChangeLog 2011-08-23 00:14:13 UTC (rev 93564) +++ trunk/LayoutTests/ChangeLog 2011-08-23 00:24:30 UTC (rev 93565) @@ -1,3 +1,13 @@ +2011-08-22 Alice Boxhall + +Reviewed by Chris Fleizach. + +aria-labelledby should be used in preference to aria-labeledby +https://bugs.webkit.org/show_bug.cgi?id=62351 + +* accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Added. +* accessibility/aria-labelledby-overrides-aria-labeledby.html: Added. + 2011-08-22 Adam Barth HTMLSourceTracker crashes when network packets break poorly Added: trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt (0 => 93565) --- trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt 2011-08-23 00:24:30 UTC (rev 93565) @@ -0,0 +1,12 @@ +Alpha Beta Gamma Delta Epsilon +This tests that if aria-labelledby is used, then non-standard aria-labeledby attributes are ignored. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS obj.title is "AXTitle: Gamma" +PASS obj.title is "AXTitle: Epsilon" +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby.html (0 => 93565) --- trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby.html (rev 0) +++ trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby.html 2011-08-23 00:24:30 UTC (rev 93565) @@ -0,0 +1,54 @@ + + + + +var successfullyParsed = false; + + + + + + +Gamma +Delta +Epsilon + + ++ +