[webkit-changes] [94053] trunk/Source/WebCore
Title: [94053] trunk/Source/WebCore Revision 94053 Author rn...@webkit.org Date 2011-08-29 23:40:07 -0700 (Mon, 29 Aug 2011) Log Message Touch Internals.cpp in an attempt to fix GTK+ build. * testing/Internals.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/testing/Internals.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94052 => 94053) --- trunk/Source/WebCore/ChangeLog 2011-08-30 06:37:56 UTC (rev 94052) +++ trunk/Source/WebCore/ChangeLog 2011-08-30 06:40:07 UTC (rev 94053) @@ -1,5 +1,11 @@ 2011-08-29 Ryosuke Niwa +Touch Internals.cpp in an attempt to fix GTK+ build. + +* testing/Internals.cpp: + +2011-08-29 Ryosuke Niwa + Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement https://bugs.webkit.org/show_bug.cgi?id=67152 Modified: trunk/Source/WebCore/testing/Internals.cpp (94052 => 94053) --- trunk/Source/WebCore/testing/Internals.cpp 2011-08-30 06:37:56 UTC (rev 94052) +++ trunk/Source/WebCore/testing/Internals.cpp 2011-08-30 06:40:07 UTC (rev 94053) @@ -283,4 +283,3 @@ } } - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94052] trunk/LayoutTests
Title: [94052] trunk/LayoutTests Revision 94052 Author commit-qu...@webkit.org Date 2011-08-29 23:37:56 -0700 (Mon, 29 Aug 2011) Log Message Fix two layout tests which fails on Qt port with latest pywebsocket. https://bugs.webkit.org/show_bug.cgi?id=66929 Patch by Takashi Toyoshima on 2011-08-29 Reviewed by Kent Tamura. hanging-handshake_wsh.py read socket to hang in opening handshake. Then client initiated closing handshakes or abnormal closures caused exception or resulted in http error response on hybi-10 compliant new pywebsocket. Because tests finished at closure, it depends on timing whether tests detects the error response. Actually, two tests failed on Qt port by chance. Essentially, hangings is unnecessary because open event must be queued and WebSocket's readyState could not be changed to OPEN until the next event loop is executed. That's why we can use echo_wsh.py instead of hanging-handshake_wsh.py safely. close-unref-websocket tests call close() before GC. These tests expect GC cause close event. But close() itself also queues close event. These close() are redandant. If GC doesn't cause close event, these tests can pass by close event that close() queues. This change also remove these redandant close() calls. * http/tests/websocket/tests/hixie76/close-before-open.html: Use echo_wsh.py instead of hanging-handshake_wsh.py. * http/tests/websocket/tests/hixie76/close-unref-websocket-expected.txt: * http/tests/websocket/tests/hixie76/close-unref-websocket.html: Used echo_wsh.py, remove ws.close() and fix expectation. * http/tests/websocket/tests/hixie76/hanging-handshake_wsh.py: Removed. * http/tests/websocket/tests/hybi/close-before-open.html: Use echo_wsh.py instead of hanging-handshake_wsh.py. * http/tests/websocket/tests/hybi/close-unref-websocket-expected.txt: * http/tests/websocket/tests/hybi/close-unref-websocket.html: Used echo_wsh.py, remove ws.close() and fix expectation. * http/tests/websocket/tests/hybi/hanging-handshake_wsh.py: Removed. * http/tests/websocket/tests/hybi/close-code-and-reason.html: * http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js: Use echo_wsh.py instead of hanging-handshake_wsh.py. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/websocket/tests/hixie76/close-before-open.html trunk/LayoutTests/http/tests/websocket/tests/hixie76/close-unref-websocket-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hixie76/close-unref-websocket.html trunk/LayoutTests/http/tests/websocket/tests/hybi/close-before-open.html trunk/LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html trunk/LayoutTests/http/tests/websocket/tests/hybi/close-unref-websocket-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/close-unref-websocket.html trunk/LayoutTests/http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js Removed Paths trunk/LayoutTests/http/tests/websocket/tests/hixie76/hanging-handshake_wsh.py trunk/LayoutTests/http/tests/websocket/tests/hybi/hanging-handshake_wsh.py Diff Modified: trunk/LayoutTests/ChangeLog (94051 => 94052) --- trunk/LayoutTests/ChangeLog 2011-08-30 06:29:16 UTC (rev 94051) +++ trunk/LayoutTests/ChangeLog 2011-08-30 06:37:56 UTC (rev 94052) @@ -1,3 +1,43 @@ +2011-08-29 Takashi Toyoshima + +Fix two layout tests which fails on Qt port with latest pywebsocket. +https://bugs.webkit.org/show_bug.cgi?id=66929 + +Reviewed by Kent Tamura. + +hanging-handshake_wsh.py read socket to hang in opening handshake. +Then client initiated closing handshakes or abnormal closures caused +exception or resulted in http error response on hybi-10 compliant new +pywebsocket. Because tests finished at closure, it depends on timing +whether tests detects the error response. Actually, two tests failed on +Qt port by chance. +Essentially, hangings is unnecessary because open event must be queued +and WebSocket's readyState could not be changed to OPEN until the next +event loop is executed. That's why we can use echo_wsh.py instead of +hanging-handshake_wsh.py safely. + +close-unref-websocket tests call close() before GC. These tests expect +GC cause close event. But close() itself also queues close event. +These close() are redandant. If GC doesn't cause close event, these +tests can pass by close event that close() queues. This change also +remove these redandant close() calls. + +* http/tests/websocket/tests/hixie76/close-before-open.html: +Use echo_wsh.py instead of hanging-handshake_wsh.py. +* http/tests/websocket/tests/hixie76/close-unref-websocket-expected.txt: +* http/tests/websocket/tests/hixie76/close-unref-websocket.html: +Used echo_wsh.py, remove ws.close() and fix expectation. +* http/tests/websocket/tests/hixie76/hanging-handshake_wsh.py: Removed. +* htt
[webkit-changes] [94051] trunk/Source/WebKit2
Title: [94051] trunk/Source/WebKit2 Revision 94051 Author rn...@webkit.org Date 2011-08-29 23:29:16 -0700 (Mon, 29 Aug 2011) Log Message Another Windows build fix after r94047. * win/WebKit2.def: * win/WebKit2CFLite.def: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2.def trunk/Source/WebKit2/win/WebKit2CFLite.def Diff Modified: trunk/Source/WebKit2/ChangeLog (94050 => 94051) --- trunk/Source/WebKit2/ChangeLog 2011-08-30 06:19:34 UTC (rev 94050) +++ trunk/Source/WebKit2/ChangeLog 2011-08-30 06:29:16 UTC (rev 94051) @@ -1,5 +1,12 @@ 2011-08-29 Ryosuke Niwa +Another Windows build fix after r94047. + +* win/WebKit2.def: +* win/WebKit2CFLite.def: + +2011-08-29 Ryosuke Niwa + Export more symbols for r94038. * win/WebKit2.def: Modified: trunk/Source/WebKit2/win/WebKit2.def (94050 => 94051) --- trunk/Source/WebKit2/win/WebKit2.def 2011-08-30 06:19:34 UTC (rev 94050) +++ trunk/Source/WebKit2/win/WebKit2.def 2011-08-30 06:29:16 UTC (rev 94051) @@ -157,8 +157,7 @@ ?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z ?inputTag@HTMLNames@WebCore@@3VQualifiedName@2@B ?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@UStringHash@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z -?lastChangeWasUserEdit@HTMLTextAreaElement@WebCore@@QBE_NXZ -?lastChangeWasUserEdit@HTMLInputElement@WebCore@@QBE_NXZ +?lastChangeWasUserEdit@HTMLTextFormControlElement@WebCore@@QBE_NXZ ?markersFor@DocumentMarkerController@WebCore@@QAE?AV?$Vector@PAVDocumentMarker@WebCore@@$0A@@WTF@@PAVNode@2@@Z ?memoryCache@WebCore@@YAPAVMemoryCache@1@XZ ?page@Document@WebCore@@QBEPAVPage@2@XZ Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (94050 => 94051) --- trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-08-30 06:19:34 UTC (rev 94050) +++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-08-30 06:29:16 UTC (rev 94051) @@ -151,8 +151,7 @@ ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVClientRect@1@@Z ?updateLayoutIgnorePendingStylesheets@Document@WebCore@@QAEXXZ ?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@UStringHash@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z -?lastChangeWasUserEdit@HTMLTextAreaElement@WebCore@@QBE_NXZ -?lastChangeWasUserEdit@HTMLInputElement@WebCore@@QBE_NXZ +?lastChangeWasUserEdit@HTMLTextFormControlElement@WebCore@@QBE_NXZ ?markersFor@DocumentMarkerController@WebCore@@QAE?AV?$Vector@PAVDocumentMarker@WebCore@@$0A@@WTF@@PAVNode@2@@Z ?memoryCache@WebCore@@YAPAVMemoryCache@1@XZ ?page@Document@WebCore@@QBEPAVPage@2@XZ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94050] trunk
Title: [94050] trunk Revision 94050 Author rn...@webkit.org Date 2011-08-29 23:19:34 -0700 (Mon, 29 Aug 2011) Log Message Build fix attempt after r94038. * Source/autotools/symbols.filter: Modified Paths trunk/ChangeLog trunk/Source/autotools/symbols.filter Diff Modified: trunk/ChangeLog (94049 => 94050) --- trunk/ChangeLog 2011-08-30 06:07:29 UTC (rev 94049) +++ trunk/ChangeLog 2011-08-30 06:19:34 UTC (rev 94050) @@ -1,3 +1,9 @@ +2011-08-29 Ryosuke Niwa + +Build fix attempt after r94038. + +* Source/autotools/symbols.filter: + 2011-08-26 Varun Jain WebViewImpl::selectionRange should return range in the right order. Modified: trunk/Source/autotools/symbols.filter (94049 => 94050) --- trunk/Source/autotools/symbols.filter 2011-08-30 06:07:29 UTC (rev 94049) +++ trunk/Source/autotools/symbols.filter 2011-08-30 06:19:34 UTC (rev 94050) @@ -31,6 +31,8 @@ _ZN7WebCore5Range6createEN3WTF10PassRefPtrINS_8DocumentEEENS2_INS_4NodeEEEiS6_i; _ZN7WebCore5RangeD1Ev; _ZN7WebCore8Document36updateLayoutIgnorePendingStylesheetsEv; +_ZN7WebCore9HTMLNames8inputTagE; +_ZN7WebCore9HTMLNames11textareaTagE; _ZN7WebCore10JSDocument3putEPN3JSC9ExecStateERKNS1_10IdentifierENS1_7JSValueERNS1_15PutPropertySlotE; _ZN7WebCore10JSDocument6s_infoE; _ZN7WebCore10toDocumentEN3JSC7JSValueE; @@ -53,6 +55,7 @@ _ZN7WebCore21getCachedDOMStructureEPNS_17JSDOMGlobalObjectEPKN3JSC9ClassInfoE; _ZN7WebCore22externalRepresentationEPNS_7ElementEj; _ZN7WebCore24DocumentMarkerController10markersForEPNS_4NodeE; +_ZN7WebCore26HTMLTextFormControlElement27setLastChangeWasNotUserEditEv; _ZN7WebCore6JSNode13visitChildrenERN3JSC11SlotVisitorE; _ZN7WebCore6JSNode3putEPN3JSC9ExecStateERKNS1_10IdentifierENS1_7JSValueERNS1_15PutPropertySlotE; _ZN7WebCore6JSNode6s_infoE; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94049] trunk/Source/WebKit/win
Title: [94049] trunk/Source/WebKit/win Revision 94049 Author rn...@webkit.org Date 2011-08-29 23:07:29 -0700 (Mon, 29 Aug 2011) Log Message Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement https://bugs.webkit.org/show_bug.cgi?id=67152 Reviewed by Darin Adler. Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl to HTMLTextFormControlElement. * DOMHTMLClasses.cpp: (DOMHTMLInputElement::isUserEdited): (DOMHTMLTextAreaElement::isUserEdited): Modified Paths trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/DOMHTMLClasses.cpp Diff Modified: trunk/Source/WebKit/win/ChangeLog (94048 => 94049) --- trunk/Source/WebKit/win/ChangeLog 2011-08-30 05:55:54 UTC (rev 94048) +++ trunk/Source/WebKit/win/ChangeLog 2011-08-30 06:07:29 UTC (rev 94049) @@ -1,3 +1,17 @@ +2011-08-29 Ryosuke Niwa + +Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement +https://bugs.webkit.org/show_bug.cgi?id=67152 + +Reviewed by Darin Adler. + +Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl +to HTMLTextFormControlElement. + +* DOMHTMLClasses.cpp: +(DOMHTMLInputElement::isUserEdited): +(DOMHTMLTextAreaElement::isUserEdited): + 2011-08-29 Sheriff Bot Unreviewed, rolling out r93987, r93992, r93995, r93998, and Modified: trunk/Source/WebKit/win/DOMHTMLClasses.cpp (94048 => 94049) --- trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2011-08-30 05:55:54 UTC (rev 94048) +++ trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2011-08-30 06:07:29 UTC (rev 94049) @@ -1381,12 +1381,11 @@ return E_POINTER; *result = FALSE; -ASSERT(m_element); +ASSERT(m_element && m_element->hasTagName(inputTag)); BOOL textField = FALSE; if (FAILED(isTextField(&textField)) || !textField) return S_OK; -RenderObject* renderer = m_element->renderer(); -if (renderer && toRenderTextControl(renderer)->lastChangeWasUserEdit()) +if (static_cast(m_element)->lastChangeWasUserEdit()) *result = TRUE; return S_OK; } @@ -1581,9 +1580,8 @@ return E_POINTER; *result = FALSE; -ASSERT(m_element); -RenderObject* renderer = m_element->renderer(); -if (renderer && toRenderTextControl(renderer)->lastChangeWasUserEdit()) +ASSERT(m_element && m_element->hasTagName(textareaTag)); +if (static_cast(m_element)->lastChangeWasUserEdit()) *result = TRUE; return S_OK; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94048] trunk/LayoutTests
Title: [94048] trunk/LayoutTests Revision 94048 Author le...@chromium.org Date 2011-08-29 22:55:54 -0700 (Mon, 29 Aug 2011) Log Message [chromium] Add exception due to missing results for r94037. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94047 => 94048) --- trunk/LayoutTests/ChangeLog 2011-08-30 05:51:19 UTC (rev 94047) +++ trunk/LayoutTests/ChangeLog 2011-08-30 05:55:54 UTC (rev 94048) @@ -16,6 +16,12 @@ 2011-08-29 David Levin +[chromium] Add exception due to missing results for r94037. + +* platform/chromium/test_expectations.txt: + +2011-08-29 David Levin + [chromium] Minor update for test that is timing out. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94047 => 94048) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-30 05:51:19 UTC (rev 94047) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-30 05:55:54 UTC (rev 94048) @@ -3684,3 +3684,6 @@ // Failing after r93988. BUGWK67144 GPU WIN LINUX : fast/canvas/setWidthResetAfterForcedRender.html = IMAGE +// Newly added tests likely just need baselines added. +BUG_LEVIN : fast/multicol/inherit-column-values.html = MISSING +BUG_LEVIN : fast/multicol/initial-column-values.html = MISSING ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94047] trunk/Source/WebCore
Title: [94047] trunk/Source/WebCore Revision 94047 Author rn...@webkit.org Date 2011-08-29 22:51:19 -0700 (Mon, 29 Aug 2011) Log Message Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement https://bugs.webkit.org/show_bug.cgi?id=67152 Reviewed by Darin Adler. Moved setInnerTextValue from RenderTextControl to HTMLTextFormControlElement. Also moved m_lastChangeWasUserEdit from RenderTextControl to HTMLTextFormControlElement and related inline functions from RenderTextControl to HTMLTextFormControlElement. Because m_lastChangeWasUserEdit is no longer reset when RenderTextControl is recreated, added explicit calls to setLastChangeWasNotUserEdit in setValue functions of HTMLInputElement and HTMLTextAreaElement. This patch also fixes the bug that lastChangeWasUserEdit() incorrectly returns false when input or textarea don't have renderer (e.g. invisible). Unfortunately, there is no way to test this behavioral change from layout tests. * WebCore.exp.in: Exports lastChangeWasUserEdit in HTMLTextFormControlElement instead of that of HTMLInputElement and HTMLTextAreaElement. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): Explicitly calls setLastChangeWasNotUserEdit. * html/HTMLInputElement.h: * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValueCommon): Ditto. * html/HTMLTextAreaElement.h: * html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): (WebCore::HTMLTextFormControlElement::subtreeHasChanged): Sets m_lastChangeWasUserEdit true as it used to do via respondToChangeByUser. (WebCore::HTMLTextFormControlElement::lastChangeWasUserEdit): Moved from HTMLInputElement and HTMLTextAreaElement. (WebCore::HTMLTextFormControlElement::setInnerTextValue): Moved from RenderTextControl. * html/HTMLTextFormControlElement.h: (WebCore::HTMLTextFormControlElement::setLastChangeWasNotUserEdit): Added. * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): No longer initializes m_lastChangeWasUserEdit. * rendering/RenderTextControl.h: * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement): Calls setInnerTextValue. * rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::updateFromElement): Ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLInputElement.h trunk/Source/WebCore/html/HTMLTextAreaElement.cpp trunk/Source/WebCore/html/HTMLTextAreaElement.h trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp trunk/Source/WebCore/html/HTMLTextFormControlElement.h trunk/Source/WebCore/rendering/RenderTextControl.cpp trunk/Source/WebCore/rendering/RenderTextControl.h trunk/Source/WebCore/rendering/RenderTextControlMultiLine.cpp trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94046 => 94047) --- trunk/Source/WebCore/ChangeLog 2011-08-30 05:27:45 UTC (rev 94046) +++ trunk/Source/WebCore/ChangeLog 2011-08-30 05:51:19 UTC (rev 94047) @@ -1,3 +1,48 @@ +2011-08-29 Ryosuke Niwa + +Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement +https://bugs.webkit.org/show_bug.cgi?id=67152 + +Reviewed by Darin Adler. + +Moved setInnerTextValue from RenderTextControl to HTMLTextFormControlElement. + +Also moved m_lastChangeWasUserEdit from RenderTextControl to HTMLTextFormControlElement +and related inline functions from RenderTextControl to HTMLTextFormControlElement. +Because m_lastChangeWasUserEdit is no longer reset when RenderTextControl is recreated, +added explicit calls to setLastChangeWasNotUserEdit in setValue functions of HTMLInputElement +and HTMLTextAreaElement. + +This patch also fixes the bug that lastChangeWasUserEdit() incorrectly returns false +when input or textarea don't have renderer (e.g. invisible). + +Unfortunately, there is no way to test this behavioral change from layout tests. + +* WebCore.exp.in: Exports lastChangeWasUserEdit in HTMLTextFormControlElement instead of +that of HTMLInputElement and HTMLTextAreaElement. +* html/HTMLInputElement.cpp: +(WebCore::HTMLInputElement::setValue): Explicitly calls setLastChangeWasNotUserEdit. +* html/HTMLInputElement.h: +* html/HTMLTextAreaElement.cpp: +(WebCore::HTMLTextAreaElement::setValueCommon): Ditto. +* html/HTMLTextAreaElement.h: +* html/HTMLTextFormControlElement.cpp: +(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): +(WebCore::HTMLTextFormControlElement::subtreeHasChanged): Sets m_lastChangeWasUserEdit true +as it used to do via respondToChangeByUser. +(WebCore::HTMLTextFormControlElement::lastChangeWasUserEdit): Moved from HTMLInpu
[webkit-changes] [94046] trunk/LayoutTests
Title: [94046] trunk/LayoutTests Revision 94046 Author morr...@google.com Date 2011-08-29 22:27:45 -0700 (Mon, 29 Aug 2011) Log Message Unreviewed marking skip. * platform/win/Skipped: Skipped editing/spelling/spelling-insert-html.html Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (94045 => 94046) --- trunk/LayoutTests/ChangeLog 2011-08-30 05:22:37 UTC (rev 94045) +++ trunk/LayoutTests/ChangeLog 2011-08-30 05:27:45 UTC (rev 94046) @@ -1,3 +1,9 @@ +2011-08-29 MORITA Hajime + +Unreviewed marking skip. + +* platform/win/Skipped: Skipped editing/spelling/spelling-insert-html.html + 2011-08-25 Kent Tamura REGRESSION(r88115): Disabling a file upload control causes an endless busyloop. Modified: trunk/LayoutTests/platform/win/Skipped (94045 => 94046) --- trunk/LayoutTests/platform/win/Skipped 2011-08-30 05:22:37 UTC (rev 94045) +++ trunk/LayoutTests/platform/win/Skipped 2011-08-30 05:27:45 UTC (rev 94046) @@ -1398,3 +1398,6 @@ # editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added # https://bugs.webkit.org/show_bug.cgi?id=66551 editing/selection/caret-at-bidi-boundary.html + +# Need DRT change: https://bugs.webkit.org/show_bug.cgi?id=66620 +editing/spelling/spelling-insert-html.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94045] trunk
Title: [94045] trunk
Revision 94045
Author tk...@chromium.org
Date 2011-08-29 22:22:37 -0700 (Mon, 29 Aug 2011)
Log Message
REGRESSION(r88115): Disabling a file upload control causes an endless busyloop.
https://bugs.webkit.org/show_bug.cgi?id=66659
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/forms/file/disabling-file-busy-loop.html
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement):
Don't call setDisabled() if the disabled status is not changed.
setDisabled() causes styleRecalc(), and
HTMLFormControlElement::styleRecalc() causes
updateFromElement(). updateFromElement() should not call
setDisabled() again.
LayoutTests:
* fast/forms/file/disabling-file-busy-loop-expected.txt: Added.
* fast/forms/file/disabling-file-busy-loop.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp
Added Paths
trunk/LayoutTests/fast/forms/file/
trunk/LayoutTests/fast/forms/file/disabling-file-busy-loop-expected.txt
trunk/LayoutTests/fast/forms/file/disabling-file-busy-loop.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94044 => 94045)
--- trunk/LayoutTests/ChangeLog 2011-08-30 05:01:47 UTC (rev 94044)
+++ trunk/LayoutTests/ChangeLog 2011-08-30 05:22:37 UTC (rev 94045)
@@ -1,3 +1,13 @@
+2011-08-25 Kent Tamura
+
+REGRESSION(r88115): Disabling a file upload control causes an endless busyloop.
+https://bugs.webkit.org/show_bug.cgi?id=66659
+
+Reviewed by Darin Adler.
+
+* fast/forms/file/disabling-file-busy-loop-expected.txt: Added.
+* fast/forms/file/disabling-file-busy-loop.html: Added.
+
2011-08-29 David Levin
[chromium] Minor update for test that is timing out.
Added: trunk/LayoutTests/fast/forms/file/disabling-file-busy-loop-expected.txt (0 => 94045)
--- trunk/LayoutTests/fast/forms/file/disabling-file-busy-loop-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/file/disabling-file-busy-loop-expected.txt 2011-08-30 05:22:37 UTC (rev 94045)
@@ -0,0 +1,2 @@
+
+PASS if this text is visible.
Property changes on: trunk/LayoutTests/fast/forms/file/disabling-file-busy-loop-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/forms/file/disabling-file-busy-loop.html (0 => 94045)
--- trunk/LayoutTests/fast/forms/file/disabling-file-busy-loop.html (rev 0)
+++ trunk/LayoutTests/fast/forms/file/disabling-file-busy-loop.html 2011-08-30 05:22:37 UTC (rev 94045)
@@ -0,0 +1,18 @@
+
+
+
+
+.foo[disabled] {}
+
+
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+document.getElementById('fileUpload').disabled = true;
+document.getElementById('console').innerText = 'PASS if this text is visible.';
+
+
+
Property changes on: trunk/LayoutTests/fast/forms/file/disabling-file-busy-loop.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (94044 => 94045)
--- trunk/Source/WebCore/ChangeLog 2011-08-30 05:01:47 UTC (rev 94044)
+++ trunk/Source/WebCore/ChangeLog 2011-08-30 05:22:37 UTC (rev 94045)
@@ -1,3 +1,20 @@
+2011-08-25 Kent Tamura
+
+REGRESSION(r88115): Disabling a file upload control causes an endless busyloop.
+https://bugs.webkit.org/show_bug.cgi?id=66659
+
+Reviewed by Darin Adler.
+
+Test: fast/forms/file/disabling-file-busy-loop.html
+
+* rendering/RenderFileUploadControl.cpp:
+(WebCore::RenderFileUploadControl::updateFromElement):
+Don't call setDisabled() if the disabled status is not changed.
+setDisabled() causes styleRecalc(), and
+HTMLFormControlElement::styleRecalc() causes
+updateFromElement(). updateFromElement() should not call
+setDisabled() again.
+
2011-08-29 Daniel Bates
Add HAVE(VASPRINTF) macro to test for vasprintf() support
Modified: trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp (94044 => 94045)
--- trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp 2011-08-30 05:01:47 UTC (rev 94044)
+++ trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp 2011-08-30 05:22:37 UTC (rev 94045)
@@ -63,8 +63,15 @@
HTMLInputElement* input = static_cast(node());
ASSERT(input->isFileUpload());
-if (HTMLInputElement* button = uploadButton())
-button->setDisabled(!theme()->isEnabled(this));
+if (HTMLInputElement* button = uploadButton()) {
+bool newDisabled = !theme()->isEnabled(this);
+// We should avoid to call HTMLFormControlElement::setDisabled() as
+// possible because setAttribute() in setDisabled() can cause style
+// recalculation, and HTMLFormControlElement::recalcStyle() calls
+// updateFromElement() eventually.
+if (button->disabled() != newDisabled)
+
[webkit-changes] [94044] trunk/Source
Title: [94044] trunk/Source Revision 94044 Author dba...@webkit.org Date 2011-08-29 22:01:47 -0700 (Mon, 29 Aug 2011) Log Message Add HAVE(VASPRINTF) macro to test for vasprintf() support https://bugs.webkit.org/show_bug.cgi?id=67156 Reviewed by Darin Adler. Source/_javascript_Core: Encapsulate testing of vasprintf() support in a HAVE macro instead of hardcoding the list of supported/unsupported compilers at the call site. * wtf/Platform.h: Source/WebCore: * xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::error): Modified to use HAVE(VASPRINTF). Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (94043 => 94044) --- trunk/Source/_javascript_Core/ChangeLog 2011-08-30 04:57:51 UTC (rev 94043) +++ trunk/Source/_javascript_Core/ChangeLog 2011-08-30 05:01:47 UTC (rev 94044) @@ -1,3 +1,16 @@ +2011-08-29 Daniel Bates + +Add HAVE(VASPRINTF) macro to test for vasprintf() support +https://bugs.webkit.org/show_bug.cgi?id=67156 + +Reviewed by Darin Adler. + +Encapsulate testing of vasprintf() support in a HAVE macro +instead of hardcoding the list of supported/unsupported +compilers at the call site. + +* wtf/Platform.h: + 2011-08-29 Mark Hahnenberg Unzip initialization lists and constructors in JSCell hierarchy (3/7) Modified: trunk/Source/_javascript_Core/wtf/Platform.h (94043 => 94044) --- trunk/Source/_javascript_Core/wtf/Platform.h 2011-08-30 04:57:51 UTC (rev 94043) +++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-08-30 05:01:47 UTC (rev 94044) @@ -681,6 +681,12 @@ #define HAVE_SIGNAL_H 1 #endif +#if !defined(HAVE_VASPRINTF) +#if !COMPILER(MSVC) && !COMPILER(RVCT) && !COMPILER(MINGW) +#define HAVE_VASPRINTF 1 +#endif +#endif + #if !defined(HAVE_STRNSTR) #if OS(DARWIN) || OS(FREEBSD) #define HAVE_STRNSTR 1 Modified: trunk/Source/WebCore/ChangeLog (94043 => 94044) --- trunk/Source/WebCore/ChangeLog 2011-08-30 04:57:51 UTC (rev 94043) +++ trunk/Source/WebCore/ChangeLog 2011-08-30 05:01:47 UTC (rev 94044) @@ -1,3 +1,13 @@ +2011-08-29 Daniel Bates + +Add HAVE(VASPRINTF) macro to test for vasprintf() support +https://bugs.webkit.org/show_bug.cgi?id=67156 + +Reviewed by Darin Adler. + +* xml/parser/XMLDocumentParserLibxml2.cpp: +(WebCore::XMLDocumentParser::error): Modified to use HAVE(VASPRINTF). + 2011-08-29 Yuta Kitamura WebSocket: Receive binary message as Blob Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp (94043 => 94044) --- trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2011-08-30 04:57:51 UTC (rev 94043) +++ trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2011-08-30 05:01:47 UTC (rev 94044) @@ -938,13 +938,13 @@ if (isStopped()) return; -#if COMPILER(MSVC) || COMPILER(RVCT) || COMPILER(MINGW) -char m[1024]; -vsnprintf(m, sizeof(m) - 1, message, args); -#else +#if HAVE(VASPRINTF) char* m; if (vasprintf(&m, message, args) == -1) return; +#else +char m[1024]; +vsnprintf(m, sizeof(m) - 1, message, args); #endif if (m_parserPaused) @@ -952,7 +952,7 @@ else handleError(type, m, lineNumber(), columnNumber()); -#if !COMPILER(MSVC) && !COMPILER(RVCT) && !COMPILER(MINGW) +#if HAVE(VASPRINTF) free(m); #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94043] trunk/LayoutTests
Title: [94043] trunk/LayoutTests Revision 94043 Author le...@chromium.org Date 2011-08-29 21:57:51 -0700 (Mon, 29 Aug 2011) Log Message [chromium] Minor update for test that is timing out. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94042 => 94043) --- trunk/LayoutTests/ChangeLog 2011-08-30 04:51:28 UTC (rev 94042) +++ trunk/LayoutTests/ChangeLog 2011-08-30 04:57:51 UTC (rev 94043) @@ -1,5 +1,11 @@ 2011-08-29 David Levin +[chromium] Minor update for test that is timing out. + +* platform/chromium/test_expectations.txt: + +2011-08-29 David Levin + [chromium] Misc test expectations updates. * platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt: Copied from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94042 => 94043) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-30 04:51:28 UTC (rev 94042) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-30 04:57:51 UTC (rev 94043) @@ -3676,7 +3676,7 @@ BUGWK63878 : fast/dom/dom-constructors.html = TEXT // Failing after r93978 and r93983. -BUGWK67153 LINUX : inspector/styles/styles-computed-trace.html = TEXT +BUGWK67153 LINUX : inspector/styles/styles-computed-trace.html = TEXT TIMEOUT // Failing after r93982. BUG_LEVIN MAC : canvas/philip/tests/2d.path.stroke.prune.arc.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94042] trunk/LayoutTests
Title: [94042] trunk/LayoutTests Revision 94042 Author le...@chromium.org Date 2011-08-29 21:51:28 -0700 (Mon, 29 Aug 2011) Log Message [chromium] Misc test expectations updates. * platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt: Copied from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt. * platform/chromium/fast/files/create-blob-url-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt. Added due to it being different from normal OSX result. * platform/chromium/test_expectations.txt: Changes due to expectation update for media-document-audio-repaint.html leading to only an image mismatch and a test that is a slow on OS X as well as Linux and Windows. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium/fast/files/ trunk/LayoutTests/platform/chromium/fast/files/create-blob-url-crash-expected.txt trunk/LayoutTests/platform/chromium-mac/fast/files/ trunk/LayoutTests/platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt Removed Paths trunk/LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94041 => 94042) --- trunk/LayoutTests/ChangeLog 2011-08-30 03:38:50 UTC (rev 94041) +++ trunk/LayoutTests/ChangeLog 2011-08-30 04:51:28 UTC (rev 94042) @@ -1,3 +1,14 @@ +2011-08-29 David Levin + +[chromium] Misc test expectations updates. + +* platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt: Copied from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt. +* platform/chromium/fast/files/create-blob-url-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt. + Added due to it being different from normal OSX result. +* platform/chromium/test_expectations.txt: Changes due to expectation + update for media-document-audio-repaint.html leading to only an image mismatch + and a test that is a slow on OS X as well as Linux and Windows. + 2011-08-29 Yuta Kitamura WebSocket: Receive binary message as Blob Copied: trunk/LayoutTests/platform/chromium/fast/files/create-blob-url-crash-expected.txt (from rev 94041, trunk/LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt) (0 => 94042) --- trunk/LayoutTests/platform/chromium/fast/files/create-blob-url-crash-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/files/create-blob-url-crash-expected.txt 2011-08-30 04:51:28 UTC (rev 94042) @@ -0,0 +1,4 @@ +Test that createObjectURL with no argument should throw an exception. +PASS: Type error +DONE + Property changes: trunk/LayoutTests/platform/chromium/fast/files/create-blob-url-crash-expected.txt Added: svn:eol-style Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94041 => 94042) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-30 03:38:50 UTC (rev 94041) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-30 04:51:28 UTC (rev 94042) @@ -11,7 +11,7 @@ BUGCR24182 SLOW LINUX MAC DEBUG : fast/forms/form-associated-element-crash3.html = PASS BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/forms/select-set-length-with-mutation-remove.html = PASS BUGCR24182 SLOW LINUX WIN : fast/js/regexp-overflow.html = PASS -BUGCR24182 SLOW LINUX WIN DEBUG : fast/js/toString-and-valueOf-override.html = PASS +BUGCR24182 SLOW DEBUG : fast/js/toString-and-valueOf-override.html = PASS BUGCR24182 SLOW DEBUG : html5lib/webkit-resumer.html = PASS BUGCR24182 SLOW WIN DEBUG : http/tests/inspector/resource-tree/resource-tree-errors-reload.html = PASS BUGCR24182 SLOW WIN RELEASE : http/tests/loading/onload-vs-immediate-refresh.pl = PASS @@ -2596,7 +2596,7 @@ BUGWK67116 GPU DEBUG : compositing/layer-creation/overflow-scroll-overlap.html = PASS TEXT // This test needs completely new baselines. -BUGCR75354 BUGWK55718 : media/media-document-audio-repaint.html = IMAGE+TEXT +BUGCR75354 BUGWK55718 : media/media-document-audio-repaint.html = IMAGE+TEXT IMAGE BUGWK55968 MAC GPU : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE+TEXT BUGWK55968 WIN DEBUG GPU : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE Copied: trunk/LayoutTests/platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt (from rev 94041, trunk/LayoutTests/platform/qt/fast/files/create-blob-url-crash-expected.txt) (0 => 94042) --- trunk/LayoutTests/platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-mac/fast/files/create-blob-url-crash-expected.txt 2011-08-30 04:51:28 UTC (rev 94042) @@ -0,0 +1,4 @@ +Test that createObjectURL with no argument should throw an exception. +PASS: Not enough arguments +DONE + Dele
[webkit-changes] [94040] trunk/Source/WebKit2
Title: [94040] trunk/Source/WebKit2 Revision 94040 Author rn...@webkit.org Date 2011-08-29 19:29:25 -0700 (Mon, 29 Aug 2011) Log Message Export more symbols for r94038. * win/WebKit2.def: * win/WebKit2CFLite.def: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2.def trunk/Source/WebKit2/win/WebKit2CFLite.def Diff Modified: trunk/Source/WebKit2/ChangeLog (94039 => 94040) --- trunk/Source/WebKit2/ChangeLog 2011-08-30 02:19:19 UTC (rev 94039) +++ trunk/Source/WebKit2/ChangeLog 2011-08-30 02:29:25 UTC (rev 94040) @@ -1,5 +1,12 @@ 2011-08-29 Ryosuke Niwa +Export more symbols for r94038. + +* win/WebKit2.def: +* win/WebKit2CFLite.def: + +2011-08-29 Ryosuke Niwa + Windows build fix for r94038. * win/WebKit2.def: Modified: trunk/Source/WebKit2/win/WebKit2.def (94039 => 94040) --- trunk/Source/WebKit2/win/WebKit2.def 2011-08-30 02:19:19 UTC (rev 94039) +++ trunk/Source/WebKit2/win/WebKit2.def 2011-08-30 02:29:25 UTC (rev 94040) @@ -155,6 +155,7 @@ ?getCachedDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PBUClassInfo@3@@Z ?getElementById@TreeScope@WebCore@@QBEPAVElement@2@ABVAtomicString@WTF@@@Z ?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z +?inputTag@HTMLNames@WebCore@@3VQualifiedName@2@B ?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@UStringHash@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z ?lastChangeWasUserEdit@HTMLTextAreaElement@WebCore@@QBE_NXZ ?lastChangeWasUserEdit@HTMLInputElement@WebCore@@QBE_NXZ @@ -167,6 +168,7 @@ ?setResourcesDataSizeLimitsFromInternals@InspectorController@WebCore@@QAEXHH@Z ?settings@Document@WebCore@@QBEPAVSettings@2@XZ ?shadowRoot@Element@WebCore@@QBEPAVShadowRoot@2@XZ +?textareaTag@HTMLNames@WebCore@@3VQualifiedName@2@B ?toDocument@WebCore@@YAPAVDocument@1@VJSValue@JSC@@@Z ?toElement@WebCore@@YAPAVElement@1@VJSValue@JSC@@@Z ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVClientRect@1@@Z Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (94039 => 94040) --- trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-08-30 02:19:19 UTC (rev 94039) +++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-08-30 02:29:25 UTC (rev 94040) @@ -147,6 +147,7 @@ ?getCachedDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PBUClassInfo@3@@Z ?getElementById@TreeScope@WebCore@@QBEPAVElement@2@ABVAtomicString@WTF@@@Z ?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z +?inputTag@HTMLNames@WebCore@@3VQualifiedName@2@B ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVClientRect@1@@Z ?updateLayoutIgnorePendingStylesheets@Document@WebCore@@QAEXXZ ?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@UStringHash@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z @@ -161,6 +162,7 @@ ?setResourcesDataSizeLimitsFromInternals@InspectorController@WebCore@@QAEXHH@Z ?settings@Document@WebCore@@QBEPAVSettings@2@XZ ?shadowRoot@Element@WebCore@@QBEPAVShadowRoot@2@XZ +?textareaTag@HTMLNames@WebCore@@3VQualifiedName@2@B ?toDocument@WebCore@@YAPAVDocument@1@VJSValue@JSC@@@Z ?toElement@WebCore@@YAPAVElement@1@VJSValue@JSC@@@Z ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94039] trunk/Source/WebKit2
Title: [94039] trunk/Source/WebKit2 Revision 94039 Author rn...@webkit.org Date 2011-08-29 19:19:19 -0700 (Mon, 29 Aug 2011) Log Message Windows build fix for r94038. * win/WebKit2.def: * win/WebKit2CFLite.def: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2.def trunk/Source/WebKit2/win/WebKit2CFLite.def Diff Modified: trunk/Source/WebKit2/ChangeLog (94038 => 94039) --- trunk/Source/WebKit2/ChangeLog 2011-08-30 02:03:52 UTC (rev 94038) +++ trunk/Source/WebKit2/ChangeLog 2011-08-30 02:19:19 UTC (rev 94039) @@ -1,3 +1,10 @@ +2011-08-29 Ryosuke Niwa + +Windows build fix for r94038. + +* win/WebKit2.def: +* win/WebKit2CFLite.def: + 2011-08-29 Gopal Raghavan Modified: trunk/Source/WebKit2/win/WebKit2.def (94038 => 94039) --- trunk/Source/WebKit2/win/WebKit2.def 2011-08-30 02:03:52 UTC (rev 94038) +++ trunk/Source/WebKit2/win/WebKit2.def 2011-08-30 02:19:19 UTC (rev 94039) @@ -156,6 +156,8 @@ ?getElementById@TreeScope@WebCore@@QBEPAVElement@2@ABVAtomicString@WTF@@@Z ?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z ?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@UStringHash@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z +?lastChangeWasUserEdit@HTMLTextAreaElement@WebCore@@QBE_NXZ +?lastChangeWasUserEdit@HTMLInputElement@WebCore@@QBE_NXZ ?markersFor@DocumentMarkerController@WebCore@@QAE?AV?$Vector@PAVDocumentMarker@WebCore@@$0A@@WTF@@PAVNode@2@@Z ?memoryCache@WebCore@@YAPAVMemoryCache@1@XZ ?page@Document@WebCore@@QBEPAVPage@2@XZ Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (94038 => 94039) --- trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-08-30 02:03:52 UTC (rev 94038) +++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2011-08-30 02:19:19 UTC (rev 94039) @@ -150,6 +150,8 @@ ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVClientRect@1@@Z ?updateLayoutIgnorePendingStylesheets@Document@WebCore@@QAEXXZ ?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@UStringHash@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z +?lastChangeWasUserEdit@HTMLTextAreaElement@WebCore@@QBE_NXZ +?lastChangeWasUserEdit@HTMLInputElement@WebCore@@QBE_NXZ ?markersFor@DocumentMarkerController@WebCore@@QAE?AV?$Vector@PAVDocumentMarker@WebCore@@$0A@@WTF@@PAVNode@2@@Z ?memoryCache@WebCore@@YAPAVMemoryCache@1@XZ ?page@Document@WebCore@@QBEPAVPage@2@XZ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94038] trunk
Title: [94038] trunk
Revision 94038
Author rn...@webkit.org
Date 2011-08-29 19:03:52 -0700 (Mon, 29 Aug 2011)
Log Message
Add a test for lastChangeWasUserEdit in HTMLInputElement and HTMLTextAreaElement
https://bugs.webkit.org/show_bug.cgi?id=67173
Reviewed by Darin Adler.
Source/WebCore:
Exposed HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
via internals.wasLastChangeUserEdit(Element*, ExceptionCode&). The first argument must be
an input element or a textarea element lastChangeWasUserEdit is called upon.
Test: fast/forms/textfield-lastchange-was-useredit.html
* testing/Internals.cpp:
(WebCore::Internals::wasLastChangeUserEdit):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests:
Added some basic test for HTMLInputElement::lastChangeWasUserEdit and
HTMLTextAreaElement::lastChangeWasUserEdit.
* fast/forms/textfield-lastchange-was-useredit-expected.txt: Added.
* fast/forms/textfield-lastchange-was-useredit.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Added Paths
trunk/LayoutTests/fast/forms/textfield-lastchange-was-useredit-expected.txt
trunk/LayoutTests/fast/forms/textfield-lastchange-was-useredit.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94037 => 94038)
--- trunk/LayoutTests/ChangeLog 2011-08-30 01:49:10 UTC (rev 94037)
+++ trunk/LayoutTests/ChangeLog 2011-08-30 02:03:52 UTC (rev 94038)
@@ -1,3 +1,16 @@
+2011-08-29 Ryosuke Niwa
+
+Add a test for lastChangeWasUserEdit in HTMLInputElement and HTMLTextAreaElement
+https://bugs.webkit.org/show_bug.cgi?id=67173
+
+Reviewed by Darin Adler.
+
+Added some basic test for HTMLInputElement::lastChangeWasUserEdit and
+HTMLTextAreaElement::lastChangeWasUserEdit.
+
+* fast/forms/textfield-lastchange-was-useredit-expected.txt: Added.
+* fast/forms/textfield-lastchange-was-useredit.html: Added.
+
2011-08-29 Kenji Imasaki
[Chromium] Added new rebaselines for media/media-document-audio-repaint.
Added: trunk/LayoutTests/fast/forms/textfield-lastchange-was-useredit-expected.txt (0 => 94038)
--- trunk/LayoutTests/fast/forms/textfield-lastchange-was-useredit-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/textfield-lastchange-was-useredit-expected.txt 2011-08-30 02:03:52 UTC (rev 94038)
@@ -0,0 +1,28 @@
+This test ensures WebKit returns correct values for HTMLInputElement.lastChangeWasUserEdit and HTMLTextAreaElement.lastChangeWasUserEdit, which are exposed via WebKit API.
+
+input
+PASS internals.wasLastChangeUserEdit(textField) is false
+PASS textField.value = "hello"; internals.wasLastChangeUserEdit(textField) is false
+PASS document.execCommand("InsertText", false, " world"); internals.wasLastChangeUserEdit(textField) is true
+PASS textField.style.display = "none"; internals.wasLastChangeUserEdit(textField) is true
+PASS textField.value = "WebKit"; internals.wasLastChangeUserEdit(textField) is false
+PASS textField.style.display = null; internals.wasLastChangeUserEdit(textField) is false
+PASS document.execCommand("SelectAll", false, null); internals.wasLastChangeUserEdit(textField) is false
+PASS document.execCommand("Delete", false, null); internals.wasLastChangeUserEdit(textField) is true
+
+textarea
+PASS internals.wasLastChangeUserEdit(textField) is false
+PASS textField.value = "hello"; internals.wasLastChangeUserEdit(textField) is false
+PASS document.execCommand("InsertText", false, " world"); internals.wasLastChangeUserEdit(textField) is true
+PASS textField.style.display = "none"; internals.wasLastChangeUserEdit(textField) is true
+PASS textField.value = "WebKit"; internals.wasLastChangeUserEdit(textField) is false
+PASS textField.style.display = null; internals.wasLastChangeUserEdit(textField) is false
+PASS document.execCommand("SelectAll", false, null); internals.wasLastChangeUserEdit(textField) is false
+PASS document.execCommand("Delete", false, null); internals.wasLastChangeUserEdit(textField) is true
+FAIL textField.textContent = "hello\nworld"; internals.wasLastChangeUserEdit(textField) should be false. Was true.
+PASS document.execCommand("InsertText", false, "\nWebKit rocks"); internals.wasLastChangeUserEdit(textField) is true
+FAIL textField.innerText = " WebKit "; internals.wasLastChangeUserEdit(textField) should be false. Was true.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/textfield-lastchange-was-useredit.html (0 => 94038)
--- trunk/LayoutTests/fast/forms/textfield-lastchange-was-useredit.html (rev 0)
+++ trunk/LayoutTests/fast/forms/textfield-lastchange-was-useredit.html 2011-08-30 02:03:52 UTC (rev 94038)
@@ -0,0 +1,61 @@
+
+
+
+
+
+This test ensures WebKit returns correct values for HTMLInputElement.lastChangeWasUserEd
[webkit-changes] [94037] trunk
Title: [94037] trunk
Revision 94037
Author macpher...@chromium.org
Date 2011-08-29 18:49:10 -0700 (Mon, 29 Aug 2011)
Log Message
Implement CSSPropertyWebkitColumns in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=67106
Reviewed by Darin Adler.
Tests:
LayoutTests/fast/multicol/inherit-column-values.html
LayoutTests/fast/multicol/initial-column-values.html
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize handler for CSSPropertyWebkitColumns.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Remove existing implementation for CSSPropertyWebkitColumns.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Added Paths
trunk/LayoutTests/fast/multicol/inherit-column-values-expected.txt
trunk/LayoutTests/fast/multicol/inherit-column-values.html
trunk/LayoutTests/fast/multicol/initial-column-values-expected.txt
trunk/LayoutTests/fast/multicol/initial-column-values.html
Diff
Added: trunk/LayoutTests/fast/multicol/inherit-column-values-expected.txt (0 => 94037)
--- trunk/LayoutTests/fast/multicol/inherit-column-values-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/multicol/inherit-column-values-expected.txt 2011-08-30 01:49:10 UTC (rev 94037)
@@ -0,0 +1,152 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+layer at (8,8) size 784x464
+ RenderBlock {DIV} at (0,0) size 784x464 [border: (1px solid #00)]
+layer at (9,9) size 383x290
+ RenderBlock {DIV} at (1,1) size 383x290 [border: (1px solid #00)]
+RenderText {#text} at (1,1) size 180x558
+ text run at (1,1) width 132: "Vestibulum a sapien."
+ text run at (1,19) width 129: "Phasellus ante lacus,"
+ text run at (1,37) width 144: "vehicula non, cursus a,"
+ text run at (1,55) width 114: "tempor ut, magna."
+ text run at (1,73) width 169: "Suspendisse potenti. Fusce"
+ text run at (1,91) width 126: "aliquet, odio viverra"
+ text run at (1,109) width 176: "vulputate dictum, enim odio"
+ text run at (1,127) width 169: "luctus purus, ut scelerisque"
+ text run at (1,145) width 169: "quam nulla non est. Donec"
+ text run at (1,163) width 153: "eros lacus, egestas vitae,"
+ text run at (1,181) width 157: "lacinia quis, tempor quis,"
+ text run at (1,199) width 180: "pede. Morbi orci erat, iaculis"
+ text run at (1,217) width 174: "id, ornare ac, elementum at,"
+ text run at (1,235) width 162: "sem. Nunc ornare sodales"
+ text run at (1,253) width 129: "nisi. Morbi interdum"
+ text run at (1,271) width 164: "commodo nisl. Fusce eget"
+ text run at (1,289) width 179: "eros non nisi ornare facilisis."
+ text run at (1,307) width 130: "Sed placerat, est non"
+ text run at (1,325) width 174: "posuere posuere, purus sem"
+ text run at (1,343) width 163: "dignissim libero, a viverra"
+ text run at (1,361) width 170: "tellus dolor vel lorem. Cras"
+ text run at (1,379) width 136: "augue. Etiam ultricies"
+ text run at (1,397) width 165: "consequat odio. Mauris ac"
+ text run at (1,415) width 178: "libero. Etiam posuere, libero"
+ text run at (1,433) width 174: "vitae euismod gravida, urna"
+ text run at (1,451) width 155: "elit imperdiet magna, vel"
+ text run at (1,469) width 171: "cursus elit felis non mauris."
+ text run at (1,487) width 157: "Donec orci erat, porta id,"
+ text run at (1,505) width 133: "dignissim ut, posuere"
+ text run at (1,523) width 155: "dictum, leo. Suspendisse"
+ text run at (1,541) width 157: "scelerisque egestas nulla."
+layer at (9,299) size 383x290
+ RenderBlock {DIV} at (1,291) size 383x290 [border: (1px solid #00)]
+RenderText {#text} at (1,1) size 180x558
+ text run at (1,1) width 132: "Vestibulum a sapien."
+ text run at (1,19) width 129: "Phasellus ante lacus,"
+ text run at (1,37) width 144: "vehicula non, cursus a,"
+ text run at (1,55) width 114: "tempor ut, magna."
+ text run at (1,73) width 169: "Suspendisse potenti. Fusce"
+ text run at (1,91) width 126: "aliquet, odio viverra"
+ text run at (1,109) width 176: "vulputate dictum, enim odio"
+ text run at (1,127) width 169: "luctus purus, ut scelerisque"
+ text run at (1,145) width 169: "quam nulla non est. Donec"
+ text run at (1,163) width 153: "eros lacus, egestas vitae,"
+ text run at (1,181) width 157: "lacinia quis, tempor quis,"
+ text run at (1,199) width 180: "pede. Morbi orci erat, iaculis"
+ text run at (1,217) width 174: "id, ornare ac, elementum at,"
+ text run at (1,235) width 162: "sem. Nunc ornare sodales"
+ text run at (1,253) width 129: "nisi. Morbi interdum"
+ tex
[webkit-changes] [94036] trunk/Tools
Title: [94036] trunk/Tools
Revision 94036
Author commit-qu...@webkit.org
Date 2011-08-29 18:43:57 -0700 (Mon, 29 Aug 2011)
Log Message
sheriffbot "usage" help statements are wrong
https://bugs.webkit.org/show_bug.cgi?id=67170
Patch by Tom Zakrajsek on 2011-08-29
Reviewed by Adam Barth.
* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py
trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (94035 => 94036)
--- trunk/Tools/ChangeLog 2011-08-30 01:43:46 UTC (rev 94035)
+++ trunk/Tools/ChangeLog 2011-08-30 01:43:57 UTC (rev 94036)
@@ -1,3 +1,14 @@
+2011-08-29 Tom Zakrajsek
+
+sheriffbot "usage" help statements are wrong
+https://bugs.webkit.org/show_bug.cgi?id=67170
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/tool/bot/irc_command.py:
+* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
+* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
+
2011-08-29 Adam Barth
Add support for chomium-mac (non-CoreGraphics) baselines
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (94035 => 94036)
--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-08-30 01:43:46 UTC (rev 94035)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-08-30 01:43:57 UTC (rev 94036)
@@ -109,7 +109,7 @@
if (not svn_revision_list or not rollout_reason):
# return is equivalent to an irc().post(), but makes for easier unit testing.
-return "%s: Usage: SVN_REVISION [SVN_REVISIONS] REASON" % nick
+return "%s: Usage: rollout SVN_REVISION [SVN_REVISIONS] REASON" % nick
self._update_working_copy(tool)
@@ -174,7 +174,7 @@
class Whois(IRCCommand):
def execute(self, nick, args, tool, sheriff):
if len(args) != 1:
-return "%s: Usage: BUGZILLA_EMAIL" % nick
+return "%s: Usage: whois BUGZILLA_EMAIL" % nick
email = args[0]
# FIXME: We should get the ContributorList off the tool somewhere.
committer = CommitterList().contributor_by_email(email)
@@ -200,7 +200,7 @@
class CreateBug(IRCCommand):
def execute(self, nick, args, tool, sheriff):
if not args:
-return "%s: Usage: BUG_TITLE" % nick
+return "%s: Usage: create-bug BUG_TITLE" % nick
bug_title = " ".join(args)
bug_description = "%s\nRequested by %s on %s." % (bug_title, nick, config_irc.channel)
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py (94035 => 94036)
--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py 2011-08-30 01:43:46 UTC (rev 94035)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py 2011-08-30 01:43:57 UTC (rev 94036)
@@ -41,9 +41,9 @@
def test_whois(self):
whois = Whois()
-self.assertEquals("tom: Usage: BUGZILLA_EMAIL",
+self.assertEquals("tom: Usage: whois BUGZILLA_EMAIL",
whois.execute("tom", [], None, None))
-self.assertEquals("tom: Usage: BUGZILLA_EMAIL",
+self.assertEquals("tom: Usage: whois BUGZILLA_EMAIL",
whois.execute("tom", ["Adam", "Barth"], None, None))
self.assertEquals("tom: Sorry, I don't know unkn...@example.com. Maybe you could introduce me?",
whois.execute("tom", ["unkn...@example.com"], None, None))
@@ -54,7 +54,7 @@
def test_create_bug(self):
create_bug = CreateBug()
-self.assertEquals("tom: Usage: BUG_TITLE",
+self.assertEquals("tom: Usage: create-bug BUG_TITLE",
create_bug.execute("tom", [], None, None))
example_args = ["sherrif-bot", "should", "have", "a", "create-bug", "command"]
@@ -93,7 +93,7 @@
self.assertEquals((None, None), rollout._parse_args(["--bar", "1234"]))
# Invalid arguments result in the USAGE message.
-self.assertEquals("tom: Usage: SVN_REVISION [SVN_REVISIONS] REASON",
+self.assertEquals("tom: Usage: rollout SVN_REVISION [SVN_REVISIONS] REASON",
rollout.execute("tom", [], None, None))
# FIXME: We need a better way to test IRCCommands which call tool.irc().post()
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py (94035 => 94036)
--- trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py 2011-08-30 01:43:46 UTC (rev 94035)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py 2011-08-30 01:43:57 UTC (rev 94036)
@@ -118,12 +118,12 @@
OutputCapture().assert_outputs(self, run, args=["rollout r21654 21655 r21656 This r21654 patch broke the world"], expected_stderr=expect
[webkit-changes] [94035] trunk/Source
Title: [94035] trunk/Source Revision 94035 Author commit-qu...@webkit.org Date 2011-08-29 18:43:46 -0700 (Mon, 29 Aug 2011) Log Message Unzip initialization lists and constructors in JSCell hierarchy (3/7) https://bugs.webkit.org/show_bug.cgi?id=67064 Patch by Mark Hahnenberg on 2011-08-29 Reviewed by Darin Adler. Source/_javascript_Core: Completed the third level of the refactoring to add finishCreation() methods to all classes within the JSCell hierarchy with non-trivial constructor bodies. This primarily consists of pushing the calls to finishCreation() down into the constructors of the subclasses of the second level of the hierarchy as well as pulling the finishCreation() calls out into the class's corresponding create() method if it has one. Doing both simultaneously allows us to maintain the invariant that the finishCreation() method chain is called exactly once during the creation of an object, since calling it any other number of times (0, 2, or more) will cause an assertion failure. * debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::finishCreation): * debugger/DebuggerActivation.h: (JSC::DebuggerActivation::create): * runtime/Arguments.h: (JSC::Arguments::create): (JSC::Arguments::createNoParameters): (JSC::Arguments::Arguments): (JSC::Arguments::finishCreation): * runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance): * runtime/ErrorInstance.h: (JSC::ErrorInstance::finishCreation): * runtime/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::InterruptedExecutionError): (JSC::TerminatedExecutionError::TerminatedExecutionError): * runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): (JSC::ProgramExecutable::ProgramExecutable): (JSC::FunctionExecutable::FunctionExecutable): Moved the assignment of m_firstLine and m_lastLine into the FunctionExecutable::finishCreation() method in Executable.h * runtime/Executable.h: (JSC::ScriptExecutable::ScriptExecutable): (JSC::EvalExecutable::create): (JSC::ProgramExecutable::create): (JSC::FunctionExecutable::create): (JSC::FunctionExecutable::finishCreation): * runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::finishCreation): * runtime/JSArray.h: * runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray): * runtime/JSByteArray.h: (JSC::JSByteArray::finishCreation): * runtime/JSNotAnObject.h: (JSC::JSNotAnObject::JSNotAnObject): * runtime/JSObject.h: (JSC::JSNonFinalObject::JSNonFinalObject): * runtime/JSObjectWithGlobalObject.cpp: (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject): (JSC::JSObjectWithGlobalObject::finishCreation): * runtime/JSObjectWithGlobalObject.h: * runtime/JSVariableObject.h: (JSC::JSVariableObject::JSVariableObject): (JSC::JSVariableObject::finishCreation): * runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject): * runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype): (JSC::ObjectPrototype::finishCreation): * runtime/ObjectPrototype.h: * runtime/StrictEvalActivation.cpp: (JSC::StrictEvalActivation::StrictEvalActivation): Source/_javascript_Glue: Completed the third level of the refactoring to add finishCreation() methods to all classes within the JSCell hierarchy with non-trivial constructor bodies. This primarily consists of pushing the calls to finishCreation() down into the constructors of the subclasses of the second level of the hierarchy as well as pulling the finishCreation() calls out into the class's corresponding create() method if it has one. Doing both simultaneously allows us to maintain the invariant that the finishCreation() method chain is called exactly once during the creation of an object, since calling it any other number of times (0, 2, or more) will cause an assertion failure. * UserObjectImp.cpp: (UserObjectImp::UserObjectImp): Source/WebCore: No new tests. Completed the third level of the refactoring to add finishCreation() methods to all classes within the JSCell hierarchy with non-trivial constructor bodies. This primarily consists of pushing the calls to finishCreation() down into the constructors of the subclasses of the second level of the hierarchy as well as pulling the finishCreation() calls out into the class's corresponding create() method if it has one. Doing both simultaneously allows us to maintain the invariant that the finishCreation() method chain is called exactly once during the creation of an object, since calling it any other number of times (0, 2, or more) will cause an assertion failure. * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::finishCreation): * bindings/js/JSDOMWindowShell.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/debugger/DebuggerActivation.cpp trunk/Source/_javascript_Core/debugger/DebuggerActivation.h trunk/Source/_javascript_Core/runtime/Arguments.h trunk/Source/_javascript_Core/runtime/ErrorInstance.cpp trunk/Source/_j
[webkit-changes] [94034] trunk/Source/WebKit/efl
Title: [94034] trunk/Source/WebKit/efl
Revision 94034
Author commit-qu...@webkit.org
Date 2011-08-29 18:29:59 -0700 (Mon, 29 Aug 2011)
Log Message
[EFL] Add missing API documentation.
https://bugs.webkit.org/show_bug.cgi?id=66927
Patch by Grzegorz Czajkowski on 2011-08-29
Reviewed by Kent Tamura.
Adds missing documentation for ewk_context_menu_item_checked_get/set.
Moves API documentation from cpp to the headers.
Adds brief and file commands for ewk_js.h.
* ewk/ewk_contextmenu.h:
* ewk/ewk_cookies.cpp:
* ewk/ewk_cookies.h:
* ewk/ewk_frame.cpp:
* ewk/ewk_frame.h:
* ewk/ewk_js.h:
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_contextmenu.h
trunk/Source/WebKit/efl/ewk/ewk_cookies.cpp
trunk/Source/WebKit/efl/ewk/ewk_cookies.h
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
trunk/Source/WebKit/efl/ewk/ewk_frame.h
trunk/Source/WebKit/efl/ewk/ewk_js.h
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (94033 => 94034)
--- trunk/Source/WebKit/efl/ChangeLog 2011-08-29 23:47:23 UTC (rev 94033)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-08-30 01:29:59 UTC (rev 94034)
@@ -1,3 +1,21 @@
+2011-08-29 Grzegorz Czajkowski
+
+[EFL] Add missing API documentation.
+https://bugs.webkit.org/show_bug.cgi?id=66927
+
+Reviewed by Kent Tamura.
+
+Adds missing documentation for ewk_context_menu_item_checked_get/set.
+Moves API documentation from cpp to the headers.
+Adds brief and file commands for ewk_js.h.
+
+* ewk/ewk_contextmenu.h:
+* ewk/ewk_cookies.cpp:
+* ewk/ewk_cookies.h:
+* ewk/ewk_frame.cpp:
+* ewk/ewk_frame.h:
+* ewk/ewk_js.h:
+
2011-08-29 Ryuan Choi
REGRESSION(r93637) Build break because header file is missing.
Modified: trunk/Source/WebKit/efl/ewk/ewk_contextmenu.h (94033 => 94034)
--- trunk/Source/WebKit/efl/ewk/ewk_contextmenu.h 2011-08-29 23:47:23 UTC (rev 94033)
+++ trunk/Source/WebKit/efl/ewk/ewk_contextmenu.h 2011-08-30 01:29:59 UTC (rev 94034)
@@ -192,7 +192,7 @@
* @param action specifies a action of the item
* @param submenu specifies a submenu of the item
* @param title specifies a title of the item
- * @param checked
+ * @param checked @c EINA_TRUE if the item should be toggled or @c EINA_FALSE if not
* @param enabled @c EINA_TRUE to enable the item or @c EINA_FALSE to disable
* @return the pointer to the new item on success or @c 0 on failure
*
@@ -282,7 +282,21 @@
*/
EAPI const char *ewk_context_menu_item_title_set(Ewk_Context_Menu_Item *o, const char *title);
+/**
+ * Queries if the item is toggled.
+ *
+ * @param o the item to query if the item is toggled
+ * @return @c EINA_TRUE if the item is toggled or @c EINA_FALSE if not or on failure
+ */
EAPI Eina_Bool ewk_context_menu_item_checked_get(Ewk_Context_Menu_Item *o);
+
+/**
+ * Sets if the item should be toggled.
+ *
+ * @param o the item to be toggled
+ * @param checked @c EINA_TRUE if the item should be toggled or @c EINA_FALSE if not
+ * @return @c EINA_TRUE on success or @c EINA_FALSE on failure
+ */
EAPI Eina_Bool ewk_context_menu_item_checked_set(Ewk_Context_Menu_Item *o, Eina_Bool checked);
/**
Modified: trunk/Source/WebKit/efl/ewk/ewk_cookies.cpp (94033 => 94034)
--- trunk/Source/WebKit/efl/ewk/ewk_cookies.cpp 2011-08-29 23:47:23 UTC (rev 94033)
+++ trunk/Source/WebKit/efl/ewk/ewk_cookies.cpp 2011-08-30 01:29:59 UTC (rev 94034)
@@ -165,12 +165,6 @@
#endif
}
-/**
- * Gets the acceptance policy used in the current cookie jar.
- *
- * @return the current acceptance policy
- * @see Ewk_Cookie_Policy
- */
Ewk_Cookie_Policy ewk_cookies_policy_get(void)
{
Ewk_Cookie_Policy ewk_policy = EWK_COOKIE_JAR_ACCEPT_ALWAYS;
Modified: trunk/Source/WebKit/efl/ewk/ewk_cookies.h (94033 => 94034)
--- trunk/Source/WebKit/efl/ewk/ewk_cookies.h 2011-08-29 23:47:23 UTC (rev 94033)
+++ trunk/Source/WebKit/efl/ewk/ewk_cookies.h 2011-08-30 01:29:59 UTC (rev 94034)
@@ -122,6 +122,13 @@
* @see Ewk_Cookie_Policy
*/
EAPI void ewk_cookies_policy_set(Ewk_Cookie_Policy p);
+
+/**
+ * Gets the acceptance policy used in the current cookie jar.
+ *
+ * @return the current acceptance policy
+ * @see Ewk_Cookie_Policy
+ */
EAPI Ewk_Cookie_Policy ewk_cookies_policy_get(void);
#ifdef __cplusplus
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (94033 => 94034)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-08-29 23:47:23 UTC (rev 94033)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-08-30 01:29:59 UTC (rev 94034)
@@ -494,14 +494,6 @@
return EINA_TRUE;
}
-/**
- * Sets whether matches marked with ewk_frame_text_matches_mark() should be highlighted.
- *
- * @param o frame object where to set if matches are highlighted or not
- * @param highlight @c EINA_TRUE if matches are highlighted, @c EINA_FALSE if not
- *
- * @return @c EINA_TRUE on success, @c EINA_FALSE on failure
- */
Eina_Bool ewk_fra
[webkit-changes] [94033] trunk/Source/WebKit2
Title: [94033] trunk/Source/WebKit2
Revision 94033
Author commit-qu...@webkit.org
Date 2011-08-29 16:47:23 -0700 (Mon, 29 Aug 2011)
Log Message
[Qt] QTouchWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67159
Patch by Gopal Raghavan on 2011-08-29
Reviewed by Noam Rosenthal.
Added qml test case to check url property of QTouchWebView. Since url is a readonly property, we make sure that it's set after load() is called.
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml
Diff
Modified: trunk/Source/WebKit2/ChangeLog (94032 => 94033)
--- trunk/Source/WebKit2/ChangeLog 2011-08-29 23:42:22 UTC (rev 94032)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-29 23:47:23 UTC (rev 94033)
@@ -1,5 +1,17 @@
2011-08-29 Gopal Raghavan
+
+[Qt] QTouchWebView url property test missing
+https://bugs.webkit.org/show_bug.cgi?id=67159
+
+Reviewed by Noam Rosenthal.
+
+Added qml test case to check url property of QTouchWebView. Since url is a readonly property, we make sure that it's set after load() is called.
+
+* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
+
+2011-08-29 Gopal Raghavan
+
[Qt] QDesktopWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67155
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml (94032 => 94033)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml 2011-08-29 23:42:22 UTC (rev 94032)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml 2011-08-29 23:47:23 UTC (rev 94033)
@@ -20,5 +20,14 @@
spy.wait()
compare(webView.page.title, "Test page 1")
}
+
+function test_url() {
+compare(spy.count, 1)
+var testUrl = Qt.resolvedUrl("../common/test1.html")
+webView.page.load(testUrl)
+spy.wait()
+compare(webView.page.url, testUrl)
+}
+
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94032] branches/chromium/835
Title: [94032] branches/chromium/835
Revision 94032
Author cev...@google.com
Date 2011-08-29 16:42:22 -0700 (Mon, 29 Aug 2011)
Log Message
Merge 94001
BUG=91911
Review URL: http://codereview.chromium.org/7795013
Modified Paths
branches/chromium/835/Source/WebCore/rendering/RenderBox.cpp
Added Paths
branches/chromium/835/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash-expected.txt
branches/chromium/835/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash.html
Diff
Copied: branches/chromium/835/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash-expected.txt (from rev 94001, trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash-expected.txt) (0 => 94032)
--- branches/chromium/835/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash-expected.txt (rev 0)
+++ branches/chromium/835/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash-expected.txt 2011-08-29 23:42:22 UTC (rev 94032)
@@ -0,0 +1 @@
+PASS
Copied: branches/chromium/835/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash.html (from rev 94001, trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash.html) (0 => 94032)
--- branches/chromium/835/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash.html (rev 0)
+++ branches/chromium/835/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash.html 2011-08-29 23:42:22 UTC (rev 94032)
@@ -0,0 +1,24 @@
+
+
+body { direction: rtl; padding-left: 100%; }
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function runTest() {
+document.body.innerHTML = "PASS";
+
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+setTimeout("runTest()", 0);
+
+0
+
+A
+
+
\ No newline at end of file
Modified: branches/chromium/835/Source/WebCore/rendering/RenderBox.cpp (94031 => 94032)
--- branches/chromium/835/Source/WebCore/rendering/RenderBox.cpp 2011-08-29 23:39:51 UTC (rev 94031)
+++ branches/chromium/835/Source/WebCore/rendering/RenderBox.cpp 2011-08-29 23:42:22 UTC (rev 94032)
@@ -1365,6 +1365,8 @@
box->destroy(renderArena());
} else if (isReplaced()) {
setLocation(roundedIntPoint(FloatPoint(box->x(), box->y(;
+if (m_inlineBoxWrapper)
+deleteLineBoxWrapper();
m_inlineBoxWrapper = box;
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94031] trunk/Tools
Title: [94031] trunk/Tools
Revision 94031
Author aba...@webkit.org
Date 2011-08-29 16:39:51 -0700 (Mon, 29 Aug 2011)
Log Message
Add support for chomium-mac (non-CoreGraphics) baselines
https://bugs.webkit.org/show_bug.cgi?id=67163
Reviewed by Eric Seidel.
This patch teaches the non-CG chromium-mac bots to look at non-CG
baselines. However, the patch still leaves CG as the default set of
baselines.
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
* Scripts/webkitpy/common/config/build.py:
* Scripts/webkitpy/common/config/build_unittest.py:
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py
trunk/Tools/Scripts/webkitpy/common/config/build.py
trunk/Tools/Scripts/webkitpy/common/config/build_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py
trunk/Tools/Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py
trunk/Tools/Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (94030 => 94031)
--- trunk/Tools/ChangeLog 2011-08-29 23:37:25 UTC (rev 94030)
+++ trunk/Tools/ChangeLog 2011-08-29 23:39:51 UTC (rev 94031)
@@ -1,3 +1,26 @@
+2011-08-29 Adam Barth
+
+Add support for chomium-mac (non-CoreGraphics) baselines
+https://bugs.webkit.org/show_bug.cgi?id=67163
+
+Reviewed by Eric Seidel.
+
+This patch teaches the non-CG chromium-mac bots to look at non-CG
+baselines. However, the patch still leaves CG as the default set of
+baselines.
+
+* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
+* Scripts/webkitpy/common/config/build.py:
+* Scripts/webkitpy/common/config/build_unittest.py:
+* Scripts/webkitpy/layout_tests/port/builders.py:
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
+* Scripts/webkitpy/layout_tests/port/factory.py:
+* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
+* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
+* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
+* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
+
2011-08-29 Shawn Singh
Small fix in chromium port of new-run-webkit-tests.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py (94030 => 94031)
--- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py 2011-08-29 23:37:25 UTC (rev 94030)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py 2011-08-29 23:39:51 UTC (rev 94031)
@@ -123,6 +123,7 @@
'LayoutTests/platform/chromium-win': '23a30302a6910f8a48b1007fa36f3e3158341834',
'LayoutTests': '9c876f8c3e4cc2aef9519a6c1174eb3432591127',
'LayoutTests/platform/chromium-cg-mac': '23a30302a6910f8a48b1007fa36f3e3158341834',
+'LayoutTests/platform/chromium-mac': '23a30302a6910f8a48b1007fa36f3e3158341834',
}, {
'LayoutTests/platform/chromium': '23a30302a6910f8a48b1007fa36f3e3158341834',
'LayoutTests': '9c876f8c3e4cc2aef9519a6c1174eb3432591127',
Modified: trunk/Tools/Scripts/webkitpy/common/config/build.py (94030 => 94031)
--- trunk/Tools/Scripts/webkitpy/common/config/build.py 2011-08-29 23:37:25 UTC (rev 94030)
+++ trunk/Tools/Scripts/webkitpy/common/config/build.py 2011-08-29 23:39:51 UTC (rev 94031)
@@ -61,15 +61,15 @@
("Source/WebCore/image-decoders", ["chromium"]),
("LayoutTests/platform/mac", ["mac", "win"]),
("cairo", ["gtk", "wincairo"]),
-("cf", ["chromium-cg-mac", "mac", "qt", "win"]),
+("cf", ["chromium-mac", "chromium-cg-mac", "mac", "qt", "win"]),
("chromium", ["chromium"]),
-("cocoa", ["chromium-cg-mac", "mac"]),
+("cocoa", ["chromium-mac", "chromium-cg-mac", "mac"]),
("curl", ["gtk", "wincairo"]),
("gobject", ["gtk"]),
("gpu", ["chromium", "mac"]),
("gstreamer", ["gtk"]),
("gtk", ["gtk"]),
-("mac", ["chromium-cg-mac", "ma
[webkit-changes] [94030] trunk/Websites/webkit.org
Title: [94030] trunk/Websites/webkit.org Revision 94030 Author jon...@apple.com Date 2011-08-29 16:37:25 -0700 (Mon, 29 Aug 2011) Log Message Updating forms survey with non-standard wrap for textarea and more data-list driven text fields. * projects/forms/survey.html: Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/projects/forms/survey.html Diff Modified: trunk/Websites/webkit.org/ChangeLog (94029 => 94030) --- trunk/Websites/webkit.org/ChangeLog 2011-08-29 23:35:40 UTC (rev 94029) +++ trunk/Websites/webkit.org/ChangeLog 2011-08-29 23:37:25 UTC (rev 94030) @@ -1,3 +1,9 @@ +2011-08-29 Jon Lee + +Updating forms survey with non-standard wrap for textarea and more data-list driven text fields. + +* projects/forms/survey.html: + 2011-08-17 Jon Lee Updating the forms survey to include various element sizes. Modified: trunk/Websites/webkit.org/projects/forms/survey.html (94029 => 94030) --- trunk/Websites/webkit.org/projects/forms/survey.html 2011-08-29 23:35:40 UTC (rev 94029) +++ trunk/Websites/webkit.org/projects/forms/survey.html 2011-08-29 23:37:25 UTC (rev 94030) @@ -273,17 +273,34 @@ - + + + + + + + + + + + + + + + + + + @@ -294,9 +311,11 @@ - + ++ multiple + @@ -996,7 +1015,8 @@ + wrap="soft" -+ wrap="hard" + cols ++ wrap="hard" + cols ++ wrap="off" [NOT STANDARD] @@ -1007,6 +1027,10 @@ Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam porta, velit at consequat rutrum, lorem lacus fringilla nulla, a consequat purus dui ut ipsum. + +Lorem ipsum dolor sit amet, consectetur adipiscing elit. +Nam porta, velit at consequat rutrum, lorem lacus fringilla nulla, a consequat purus dui ut ipsum. + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94029] branches/chromium/835/Source/WebCore/webaudio
Title: [94029] branches/chromium/835/Source/WebCore/webaudio
Revision 94029
Author cev...@google.com
Date 2011-08-29 16:35:40 -0700 (Mon, 29 Aug 2011)
Log Message
Merge 94002
BUG=93978
Review URL: http://codereview.chromium.org/7793016
Modified Paths
branches/chromium/835/Source/WebCore/webaudio/RealtimeAnalyser.cpp
branches/chromium/835/Source/WebCore/webaudio/RealtimeAnalyser.h
Diff
Modified: branches/chromium/835/Source/WebCore/webaudio/RealtimeAnalyser.cpp (94028 => 94029)
--- branches/chromium/835/Source/WebCore/webaudio/RealtimeAnalyser.cpp 2011-08-29 23:21:22 UTC (rev 94028)
+++ branches/chromium/835/Source/WebCore/webaudio/RealtimeAnalyser.cpp 2011-08-29 23:35:40 UTC (rev 94029)
@@ -49,6 +49,8 @@
const double RealtimeAnalyser::DefaultMaxDecibels = -30.0;
const unsigned RealtimeAnalyser::DefaultFFTSize = 2048;
+// All FFT implementations are expected to handle power-of-two sizes MinFFTSize <= size <= MaxFFTSize.
+const unsigned RealtimeAnalyser::MinFFTSize = 128;
const unsigned RealtimeAnalyser::MaxFFTSize = 2048;
const unsigned RealtimeAnalyser::InputBufferSize = RealtimeAnalyser::MaxFFTSize * 2;
@@ -82,15 +84,16 @@
// Only allow powers of two.
unsigned log2size = static_cast(log2(size));
bool isPOT(1UL << log2size == size);
-
-if (!isPOT || size > MaxFFTSize) {
+
+if (!isPOT || size > MaxFFTSize || size < MinFFTSize) {
// FIXME: It would be good to also set an exception.
return;
}
if (m_fftSize != size) {
-m_analysisFrame = adoptPtr(new FFTFrame(m_fftSize));
-m_magnitudeBuffer.allocate(size);
+m_analysisFrame = adoptPtr(new FFTFrame(size));
+// m_magnitudeBuffer has size = fftSize / 2 because it contains floats reduced from complex values in m_analysisFrame.
+m_magnitudeBuffer.allocate(size / 2);
m_fftSize = size;
}
}
@@ -165,8 +168,6 @@
// Do the analysis.
m_analysisFrame->doFFT(tempP);
-size_t n = DefaultFFTSize / 2;
-
float* realP = m_analysisFrame->realData();
float* imagP = m_analysisFrame->imagData();
@@ -183,7 +184,8 @@
// Convert the analysis data from complex to magnitude and average with the previous result.
float* destination = magnitudeBuffer().data();
-for (unsigned i = 0; i < n; ++i) {
+size_t n = magnitudeBuffer().size();
+for (size_t i = 0; i < n; ++i) {
Complex c(realP[i], imagP[i]);
double scalarMagnitude = abs(c) * MagnitudeScale;
destination[i] = float(k * destination[i] + (1.0 - k) * scalarMagnitude);
Modified: branches/chromium/835/Source/WebCore/webaudio/RealtimeAnalyser.h (94028 => 94029)
--- branches/chromium/835/Source/WebCore/webaudio/RealtimeAnalyser.h 2011-08-29 23:21:22 UTC (rev 94028)
+++ branches/chromium/835/Source/WebCore/webaudio/RealtimeAnalyser.h 2011-08-29 23:35:40 UTC (rev 94029)
@@ -70,6 +70,7 @@
static const double DefaultMaxDecibels;
static const unsigned DefaultFFTSize;
+static const unsigned MinFFTSize;
static const unsigned MaxFFTSize;
static const unsigned InputBufferSize;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94027] trunk/Source/WebKit2
Title: [94027] trunk/Source/WebKit2
Revision 94027
Author commit-qu...@webkit.org
Date 2011-08-29 16:19:43 -0700 (Mon, 29 Aug 2011)
Log Message
[Qt] QDesktopWebView url property test missing
https://bugs.webkit.org/show_bug.cgi?id=67155
Patch by Gopal Raghavan on 2011-08-29
Reviewed by Noam Rosenthal.
Added qml test case to check url property. Since url is a readonly property, we make sure that it's set after load() is called.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml
Diff
Modified: trunk/Source/WebKit2/ChangeLog (94026 => 94027)
--- trunk/Source/WebKit2/ChangeLog 2011-08-29 22:54:06 UTC (rev 94026)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-29 23:19:43 UTC (rev 94027)
@@ -1,3 +1,14 @@
+2011-08-29 Gopal Raghavan
+
+[Qt] QDesktopWebView url property test missing
+https://bugs.webkit.org/show_bug.cgi?id=67155
+
+Reviewed by Noam Rosenthal.
+
+Added qml test case to check url property. Since url is a readonly property, we make sure that it's set after load() is called.
+
+* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
+
2011-08-29 Sheriff Bot
Unreviewed, rolling out r93987, r93992, r93995, r93998, and
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml (94026 => 94027)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml 2011-08-29 22:54:06 UTC (rev 94026)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml 2011-08-29 23:19:43 UTC (rev 94027)
@@ -20,5 +20,13 @@
spy.wait()
compare(webView.title, "Test page 1")
}
+
+function test_url() {
+compare(spy.count, 1)
+var testUrl = Qt.resolvedUrl("../common/test1.html")
+webView.load(testUrl)
+spy.wait()
+compare(webView.url, testUrl)
+}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94026] trunk/Source/WebCore
Title: [94026] trunk/Source/WebCore
Revision 94026
Author commit-qu...@webkit.org
Date 2011-08-29 15:54:06 -0700 (Mon, 29 Aug 2011)
Log Message
Speed up texImage from BGRA
https://bugs.webkit.org/show_bug.cgi?id=66884
Patch by John Bauman on 2011-08-29
Reviewed by Kenneth Russell.
BGRA input is common coming from skia, so optimize BGRA->RGBA
conversion and also avoid the pointless RGBA to RGBA conversion.
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::doUnpackingAndPacking):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94025 => 94026)
--- trunk/Source/WebCore/ChangeLog 2011-08-29 22:53:05 UTC (rev 94025)
+++ trunk/Source/WebCore/ChangeLog 2011-08-29 22:54:06 UTC (rev 94026)
@@ -1,3 +1,16 @@
+2011-08-29 John Bauman
+
+Speed up texImage from BGRA
+https://bugs.webkit.org/show_bug.cgi?id=66884
+
+Reviewed by Kenneth Russell.
+
+BGRA input is common coming from skia, so optimize BGRA->RGBA
+conversion and also avoid the pointless RGBA to RGBA conversion.
+
+* platform/graphics/GraphicsContext3D.cpp:
+(WebCore::doUnpackingAndPacking):
+
2011-08-29 Matthew Delaney
[CG] ImageBufferCG should handle IOSurface allocation failure gracefully
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp (94025 => 94026)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp 2011-08-29 22:53:05 UTC (rev 94025)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp 2011-08-29 22:54:06 UTC (rev 94026)
@@ -474,13 +474,19 @@
void unpackOneRowOfBGRA8ToRGBA8(const uint8_t* source, uint8_t* destination, unsigned int pixelsPerRow)
{
+const uint32_t* source32 = reinterpret_cast(source);
+uint32_t* destination32 = reinterpret_cast(destination);
for (unsigned int i = 0; i < pixelsPerRow; ++i) {
-destination[0] = source[2];
-destination[1] = source[1];
-destination[2] = source[0];
-destination[3] = source[3];
-source += 4;
-destination += 4;
+uint32_t bgra = source32[i];
+#if CPU(BIG_ENDIAN)
+uint32_t brMask = 0xff00ff00;
+uint32_t gaMask = 0x00ff00ff;
+#else
+uint32_t brMask = 0x00ff00ff;
+uint32_t gaMask = 0xff00ff00;
+#endif
+uint32_t rgba = (((bgra >> 16) | (bgra << 16)) & brMask) | (bgra & gaMask);
+destination32[i] = rgba;
}
}
@@ -871,19 +877,6 @@
}
}
-// This is only used when the source format is different than SourceFormatRGBA8.
-void packOneRowOfRGBA8ToRGBA8(const uint8_t* source, uint8_t* destination, unsigned int pixelsPerRow)
-{
-for (unsigned int i = 0; i < pixelsPerRow; ++i) {
-destination[0] = source[0];
-destination[1] = source[1];
-destination[2] = source[2];
-destination[3] = source[3];
-source += 4;
-destination += 4;
-}
-}
-
void packOneRowOfRGBA8ToRGBA8Premultiply(const uint8_t* source, uint8_t* destination, unsigned int pixelsPerRow)
{
for (unsigned int i = 0; i < pixelsPerRow; ++i) {
@@ -1150,14 +1143,25 @@
void (*rowPackingFunc)(const IntermediateType*, DestType*, unsigned int),
unsigned int destinationElementsPerPixel)
{
-OwnArrayPtr temporaryRGBAData = adoptArrayPtr(new IntermediateType[width * 4]);
-const SourceType* endPointer = sourceData + height * sourceElementsPerRow;
-unsigned int destinationElementsPerRow = width * destinationElementsPerPixel;
-while (sourceData < endPointer) {
-rowUnpackingFunc(sourceData, temporaryRGBAData.get(), width);
-rowPackingFunc(temporaryRGBAData.get(), destinationData, width);
-sourceData += sourceElementsPerRow;
-destinationData += destinationElementsPerRow;
+if (!rowPackingFunc) {
+// The row packing is trivial, so don't bother with a temporary buffer.
+const SourceType* endPointer = sourceData + height * sourceElementsPerRow;
+unsigned int destinationElementsPerRow = width * destinationElementsPerPixel;
+while (sourceData < endPointer) {
+rowUnpackingFunc(sourceData, reinterpret_cast(destinationData), width);
+sourceData += sourceElementsPerRow;
+destinationData += destinationElementsPerRow;
+}
+} else {
+OwnArrayPtr temporaryRGBAData = adoptArrayPtr(new IntermediateType[width * 4]);
+const SourceType* endPointer = sourceData + height * sourceElementsPerRow;
+unsigned int destinationElementsPerRow = width * destinationElementsPerPixel;
+while (sourceData < endPointer) {
+rowUnpackingFunc(sourceData, temporaryRGBAData.get(), width);
+rowPackingFunc(temporaryRGBAData.get(), destinationData, width);
+sourceData += sourceElementsPerRow;
+destinationData += de
[webkit-changes] [94025] trunk/LayoutTests
Title: [94025] trunk/LayoutTests Revision 94025 Author wei...@apple.com Date 2011-08-29 15:53:05 -0700 (Mon, 29 Aug 2011) Log Message Fix path to style sheet in fast/events/constructors/event-constructors.html. Reviewed by Gavin Barraclough. * fast/events/constructors/event-constructors.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/events/constructors/event-constructors.html Diff Modified: trunk/LayoutTests/ChangeLog (94024 => 94025) --- trunk/LayoutTests/ChangeLog 2011-08-29 22:52:36 UTC (rev 94024) +++ trunk/LayoutTests/ChangeLog 2011-08-29 22:53:05 UTC (rev 94025) @@ -1,5 +1,13 @@ 2011-08-29 Sam Weinig +Fix path to style sheet in fast/events/constructors/event-constructors.html. + +Reviewed by Gavin Barraclough. + +* fast/events/constructors/event-constructors.html: + +2011-08-29 Sam Weinig + Update results for fast/files/create-blob-url-crash.html to match exception text. Modified: trunk/LayoutTests/fast/events/constructors/event-constructors.html (94024 => 94025) --- trunk/LayoutTests/fast/events/constructors/event-constructors.html 2011-08-29 22:52:36 UTC (rev 94024) +++ trunk/LayoutTests/fast/events/constructors/event-constructors.html 2011-08-29 22:53:05 UTC (rev 94025) @@ -1,7 +1,7 @@ -+
[webkit-changes] [94024] trunk/Source/WebCore
Title: [94024] trunk/Source/WebCore
Revision 94024
Author mdela...@apple.com
Date 2011-08-29 15:52:36 -0700 (Mon, 29 Aug 2011)
Log Message
[CG] ImageBufferCG should handle IOSurface allocation failure gracefully
https://bugs.webkit.org/show_bug.cgi?id=67099
Reviewed by Simon Fraser.
No new tests. Testing the "fallback to old path" behavior is not easily testable.
* platform/graphics/cg/ImageBufferCG.cpp: Rearranged backing store creation to fall back to
old path if IOSurface creation path fails.
(WebCore::ImageBuffer::ImageBuffer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94023 => 94024)
--- trunk/Source/WebCore/ChangeLog 2011-08-29 22:51:21 UTC (rev 94023)
+++ trunk/Source/WebCore/ChangeLog 2011-08-29 22:52:36 UTC (rev 94024)
@@ -1,3 +1,16 @@
+2011-08-29 Matthew Delaney
+
+[CG] ImageBufferCG should handle IOSurface allocation failure gracefully
+https://bugs.webkit.org/show_bug.cgi?id=67099
+
+Reviewed by Simon Fraser.
+
+No new tests. Testing the "fallback to old path" behavior is not easily testable.
+
+* platform/graphics/cg/ImageBufferCG.cpp: Rearranged backing store creation to fall back to
+ old path if IOSurface creation path fails.
+(WebCore::ImageBuffer::ImageBuffer):
+
2011-08-29 Cary Clark
Only enable font smoothing as requested (Skia on Mac)
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp (94023 => 94024)
--- trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp 2011-08-29 22:51:21 UTC (rev 94023)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp 2011-08-29 22:52:36 UTC (rev 94024)
@@ -137,6 +137,15 @@
}
RetainPtr cgContext;
+if (m_accelerateRendering) {
+#if USE(IOSURFACE_CANVAS_BACKING_STORE)
+m_data.m_surface = createIOSurface(size);
+cgContext.adoptCF(wkIOSurfaceContextCreate(m_data.m_surface.get(), size.width(), size.height(), m_data.m_colorSpace));
+#endif
+if (!cgContext)
+m_accelerateRendering = false; // If allocation fails, fall back to non-accelerated path.
+}
+
if (!m_accelerateRendering) {
if (!tryFastCalloc(size.height(), bytesPerRow).getValue(m_data.m_data))
return;
@@ -146,13 +155,6 @@
cgContext.adoptCF(CGBitmapContextCreate(m_data.m_data, size.width(), size.height(), 8, bytesPerRow, m_data.m_colorSpace, m_data.m_bitmapInfo));
// Create a live image that wraps the data.
m_data.m_dataProvider.adoptCF(CGDataProviderCreateWithData(0, m_data.m_data, dataSize, releaseImageData));
-} else {
-#if USE(IOSURFACE_CANVAS_BACKING_STORE)
-m_data.m_surface = createIOSurface(size);
-cgContext.adoptCF(wkIOSurfaceContextCreate(m_data.m_surface.get(), size.width(), size.height(), m_data.m_colorSpace));
-#else
-m_accelerateRendering = false; // Force to false on older platforms
-#endif
}
if (!cgContext)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94023] trunk/LayoutTests
Title: [94023] trunk/LayoutTests Revision 94023 Author wei...@apple.com Date 2011-08-29 15:51:21 -0700 (Mon, 29 Aug 2011) Log Message Update results for fast/files/create-blob-url-crash.html to match exception text. * fast/files/create-blob-url-crash-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94022 => 94023) --- trunk/LayoutTests/ChangeLog 2011-08-29 22:43:38 UTC (rev 94022) +++ trunk/LayoutTests/ChangeLog 2011-08-29 22:51:21 UTC (rev 94023) @@ -1,3 +1,10 @@ +2011-08-29 Sam Weinig + +Update results for fast/files/create-blob-url-crash.html to match +exception text. + +* fast/files/create-blob-url-crash-expected.txt: + 2011-08-29 David Levin Fix test_expectation.txt typo. Modified: trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt (94022 => 94023) --- trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt 2011-08-29 22:43:38 UTC (rev 94022) +++ trunk/LayoutTests/fast/files/create-blob-url-crash-expected.txt 2011-08-29 22:51:21 UTC (rev 94023) @@ -1,4 +1,4 @@ Test that createObjectURL with no argument should throw an exception. -PASS: Type error +PASS: Not enough arguments DONE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94022] branches/safari-534.51-branch/Source/WebCore
Title: [94022] branches/safari-534.51-branch/Source/WebCore Revision 94022 Author lforsch...@apple.com Date 2011-08-29 15:43:38 -0700 (Mon, 29 Aug 2011) Log Message Merge r93793. Modified Paths branches/safari-534.51-branch/Source/WebCore/ChangeLog branches/safari-534.51-branch/Source/WebCore/loader/ImageLoader.cpp Diff Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (94021 => 94022) --- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-08-29 22:41:45 UTC (rev 94021) +++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-08-29 22:43:38 UTC (rev 94022) @@ -1,5 +1,22 @@ 2011-08-29 Lucas Forschler +Merged 93793 + +2011-08-25 Sam Weinig + +JSHTMLImageElement (and associated Node) is abandoned when image load is canceled via beforeload + +https://bugs.webkit.org/show_bug.cgi?id=66906 + +Reviewed by Darin Adler. + +* loader/ImageLoader.cpp: +(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent): +Very similar fix to the one in r93717 except this patches the case where the image load was +canceled via beforeload. + +2011-08-29 Lucas Forschler + Merged 93717 2011-08-24 Sam Weinig Modified: branches/safari-534.51-branch/Source/WebCore/loader/ImageLoader.cpp (94021 => 94022) --- branches/safari-534.51-branch/Source/WebCore/loader/ImageLoader.cpp 2011-08-29 22:41:45 UTC (rev 94021) +++ branches/safari-534.51-branch/Source/WebCore/loader/ImageLoader.cpp 2011-08-29 22:43:38 UTC (rev 94022) @@ -288,7 +288,9 @@ m_image->removeClient(this); m_image = 0; } + loadEventSender().cancelEvent(this); +m_firedLoad = true; if (m_element->hasTagName(HTMLNames::objectTag)) static_cast(m_element)->renderFallbackContent(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94021] branches/safari-534.51-branch/Source/WebCore
Title: [94021] branches/safari-534.51-branch/Source/WebCore
Revision 94021
Author lforsch...@apple.com
Date 2011-08-29 15:41:45 -0700 (Mon, 29 Aug 2011)
Log Message
Merge r93717.
Modified Paths
branches/safari-534.51-branch/Source/WebCore/ChangeLog
branches/safari-534.51-branch/Source/WebCore/loader/ImageLoader.cpp
Diff
Modified: branches/safari-534.51-branch/Source/WebCore/ChangeLog (94020 => 94021)
--- branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-08-29 22:30:22 UTC (rev 94020)
+++ branches/safari-534.51-branch/Source/WebCore/ChangeLog 2011-08-29 22:41:45 UTC (rev 94021)
@@ -1,3 +1,26 @@
+2011-08-29 Lucas Forschler
+
+Merged 93717
+
+2011-08-24 Sam Weinig
+
+JSHTMLImageElement (and associated Node) is abandoned when image load is canceled
+
+https://bugs.webkit.org/show_bug.cgi?id=66864
+
+Reviewed by Anders Carlsson.
+
+In the JSC bindings, we use HTMLImageElement::hasPendingActivity() (which in turn calls
+HTMLImageLoader::haveFiredLoadEvent()) to reason about the liveness of JSHTMLImageElements.
+In the case that an image load is canceled, the haveFiredLoadEvent never true, so the
+JSHTMLImageElement is kept alive forever (and since it references the global object, it
+keeps the entire graph alive as well).
+
+* loader/ImageLoader.cpp:
+(WebCore::ImageLoader::notifyFinished):
+Set m_firedLoad to true in the case of a canceled load, to reset the state back to
+its initial values.
+
2011-08-24 Mark Rowe
Merge r93376.
Modified: branches/safari-534.51-branch/Source/WebCore/loader/ImageLoader.cpp (94020 => 94021)
--- branches/safari-534.51-branch/Source/WebCore/loader/ImageLoader.cpp 2011-08-29 22:30:22 UTC (rev 94020)
+++ branches/safari-534.51-branch/Source/WebCore/loader/ImageLoader.cpp 2011-08-29 22:41:45 UTC (rev 94021)
@@ -225,8 +225,10 @@
if (m_firedLoad)
return;
-if (resource->wasCanceled())
+if (resource->wasCanceled()) {
+m_firedLoad = true;
return;
+}
loadEventSender().dispatchEventSoon(this);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94020] releases/WebKitGTK/webkit-1.4
Title: [94020] releases/WebKitGTK/webkit-1.4 Revision 94020 Author mrobin...@webkit.org Date 2011-08-29 15:30:22 -0700 (Mon, 29 Aug 2011) Log Message 2011-08-29 Martin Robinson Update NEWS and library versioning for the 1.4.3 release. Reviewed by Gustavo Noronha. * configure.ac: Update library version. 2011-08-29 Martin Robinson Update NEWS and library versioning for the 1.4.3 release. Reviewed by Gustavo Noronha. * NEWS: Update the news. Modified Paths releases/WebKitGTK/webkit-1.4/ChangeLog releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/NEWS releases/WebKitGTK/webkit-1.4/configure.ac Diff Modified: releases/WebKitGTK/webkit-1.4/ChangeLog (94019 => 94020) --- releases/WebKitGTK/webkit-1.4/ChangeLog 2011-08-29 21:57:09 UTC (rev 94019) +++ releases/WebKitGTK/webkit-1.4/ChangeLog 2011-08-29 22:30:22 UTC (rev 94020) @@ -1,3 +1,11 @@ +2011-08-29 Martin Robinson + +Update NEWS and library versioning for the 1.4.3 release. + +Reviewed by Gustavo Noronha. + +* configure.ac: Update library version. + 2011-06-30 Martin Robinson Reviewed by Xan Lopez. Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog (94019 => 94020) --- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog 2011-08-29 21:57:09 UTC (rev 94019) +++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog 2011-08-29 22:30:22 UTC (rev 94020) @@ -1,3 +1,11 @@ +2011-08-29 Martin Robinson + +Update NEWS and library versioning for the 1.4.3 release. + +Reviewed by Gustavo Noronha. + +* NEWS: Update the news. + 2011-08-29 Xan Lopez Unreviewed build fix. Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/NEWS (94019 => 94020) --- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/NEWS 2011-08-29 21:57:09 UTC (rev 94019) +++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/NEWS 2011-08-29 22:30:22 UTC (rev 94020) @@ -1,4 +1,20 @@ = +WebKitGTK+ 1.4.3 += + +This is a maintenance release which includes several noteworthy fixes: + +- Backport the main frame scrollbar fixes from trunk. This should remove most of the + scrollbar-related crashes. +- Fix an issue which caused Flash to crash when used via nspluginwrapper. +- Work-around an issue with user-agent sniffing in Google Calendar. + +Buf fixes since 1.4.2: + Bug 59821 - [GTK] Untangle GtkAdjustments from WebCore + Bug 63862 - r90148 did not apply to X11 platforms in WebKit1 + Bug 63994 - [GTK] Google Calendar thinks we're mobile + += WebKitGTK+ 1.4.2 = Modified: releases/WebKitGTK/webkit-1.4/configure.ac (94019 => 94020) --- releases/WebKitGTK/webkit-1.4/configure.ac 2011-08-29 21:57:09 UTC (rev 94019) +++ releases/WebKitGTK/webkit-1.4/configure.ac 2011-08-29 22:30:22 UTC (rev 94020) @@ -2,7 +2,7 @@ m4_define([webkit_major_version], [1]) m4_define([webkit_minor_version], [4]) -m4_define([webkit_micro_version], [2]) +m4_define([webkit_micro_version], [3]) # This is the version we'll be using as part of our User-Agent string # e.g., AppleWebKit/$(webkit_user_agent_version) ... @@ -35,7 +35,7 @@ dnl # Libtool library version, not to confuse with API version dnl # see http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html -LIBWEBKITGTK_VERSION=7:2:7 +LIBWEBKITGTK_VERSION=7:3:7 AC_SUBST([LIBWEBKITGTK_VERSION]) AM_INIT_AUTOMAKE([foreign subdir-objects tar-ustar]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94019] trunk/Source/WebCore
Title: [94019] trunk/Source/WebCore Revision 94019 Author carycl...@google.com Date 2011-08-29 14:57:09 -0700 (Mon, 29 Aug 2011) Log Message Only enable font smoothing as requested (Skia on Mac) https://bugs.webkit.org/show_bug.cgi?id=67143 This adjusts LayoutTest pixel output to more closely match other platforms. Reviewed by Kenneth Russell. No new tests. This platform is not yet enabled. * platform/graphics/skia/FontSkia.cpp: (WebCore::setupPaint): LCD text was always enabled to test the code path. With this change, it is only enabled when instructed by the font state. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94018 => 94019) --- trunk/Source/WebCore/ChangeLog 2011-08-29 21:47:48 UTC (rev 94018) +++ trunk/Source/WebCore/ChangeLog 2011-08-29 21:57:09 UTC (rev 94019) @@ -1,3 +1,20 @@ +2011-08-29 Cary Clark + +Only enable font smoothing as requested (Skia on Mac) +https://bugs.webkit.org/show_bug.cgi?id=67143 + +This adjusts LayoutTest pixel output to more closely +match other platforms. + +Reviewed by Kenneth Russell. + +No new tests. This platform is not yet enabled. + +* platform/graphics/skia/FontSkia.cpp: +(WebCore::setupPaint): +LCD text was always enabled to test the code path. With this change, +it is only enabled when instructed by the font state. + 2011-08-29 Julien Chaffraix Assertion failure in RenderLayer::computeRepaintRects when scrolling Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (94018 => 94019) --- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-08-29 21:47:48 UTC (rev 94018) +++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-08-29 21:57:09 UTC (rev 94019) @@ -87,7 +87,7 @@ paint->setFakeBoldText(platformData.m_syntheticBold); paint->setTextSkewX(platformData.m_syntheticOblique ? -SK_Scalar1 / 4 : 0); paint->setAutohinted(false); // freetype specific -paint->setLCDRenderText(true); // font->fontDescription().fontSmoothing() == SubpixelAntialiased); +paint->setLCDRenderText(font->fontDescription().fontSmoothing() == SubpixelAntialiased); } // TODO: This needs to be split into helper functions to better scope the ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94018] trunk/LayoutTests
Title: [94018] trunk/LayoutTests Revision 94018 Author le...@chromium.org Date 2011-08-29 14:47:48 -0700 (Mon, 29 Aug 2011) Log Message Fix test_expectation.txt typo. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94017 => 94018) --- trunk/LayoutTests/ChangeLog 2011-08-29 21:36:56 UTC (rev 94017) +++ trunk/LayoutTests/ChangeLog 2011-08-29 21:47:48 UTC (rev 94018) @@ -1,3 +1,9 @@ +2011-08-29 David Levin + +Fix test_expectation.txt typo. + +* platform/chromium/test_expectations.txt: + 2011-08-29 Julien Chaffraix Assertion failure in RenderLayer::computeRepaintRects when scrolling Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94017 => 94018) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-29 21:36:56 UTC (rev 94017) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-29 21:47:48 UTC (rev 94018) @@ -3676,7 +3676,7 @@ BUGWK63878 : fast/dom/dom-constructors.html = TEXT // Failing after r93978 and r93983. -BUG67153 LINUX : inspector/styles/styles-computed-trace.html = TEXT +BUGWK67153 LINUX : inspector/styles/styles-computed-trace.html = TEXT // Failing after r93982. BUG_LEVIN MAC : canvas/philip/tests/2d.path.stroke.prune.arc.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94017] trunk/LayoutTests
Title: [94017] trunk/LayoutTests
Revision 94017
Author le...@chromium.org
Date 2011-08-29 14:36:56 -0700 (Mon, 29 Aug 2011)
Log Message
Update test expections due to r94006 and r93978.
* platform/chromium/test_expectations.txt: Add failing test due to r93978.
* platform/mac/css2.1/t0602-c13-inheritance-00-e-expected.txt: Change to use of dfn tag and
behavior change in r94006.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/mac/css2.1/t0602-c13-inheritance-00-e-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (94016 => 94017)
--- trunk/LayoutTests/ChangeLog 2011-08-29 21:32:06 UTC (rev 94016)
+++ trunk/LayoutTests/ChangeLog 2011-08-29 21:36:56 UTC (rev 94017)
@@ -88,6 +88,14 @@
2011-08-29 David Levin
+Update test expections due to r94006 and r93978.
+
+* platform/chromium/test_expectations.txt: Add failing test due to r93978.
+* platform/mac/css2.1/t0602-c13-inheritance-00-e-expected.txt: Change to use of dfn tag and
+ behavior change in r94006.
+
+2011-08-29 David Levin
+
Temporary suppression for new test added in r93982.
* platform/chromium/test_expectations.txt:
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94016 => 94017)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-29 21:32:06 UTC (rev 94016)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-29 21:36:56 UTC (rev 94017)
@@ -3675,8 +3675,12 @@
// Started to fail on all bots after r93951.
BUGWK63878 : fast/dom/dom-constructors.html = TEXT
+// Failing after r93978 and r93983.
+BUG67153 LINUX : inspector/styles/styles-computed-trace.html = TEXT
+
// Failing after r93982.
BUG_LEVIN MAC : canvas/philip/tests/2d.path.stroke.prune.arc.html = TEXT
// Failing after r93988.
BUGWK67144 GPU WIN LINUX : fast/canvas/setWidthResetAfterForcedRender.html = IMAGE
+
Modified: trunk/LayoutTests/platform/mac/css2.1/t0602-c13-inheritance-00-e-expected.txt (94016 => 94017)
--- trunk/LayoutTests/platform/mac/css2.1/t0602-c13-inheritance-00-e-expected.txt 2011-08-29 21:32:06 UTC (rev 94016)
+++ trunk/LayoutTests/platform/mac/css2.1/t0602-c13-inheritance-00-e-expected.txt 2011-08-29 21:36:56 UTC (rev 94017)
@@ -27,7 +27,7 @@
RenderBlock {P} at (0,102) size 784x18
RenderText {#text} at (0,0) size 43x18
text run at (0,0) width 43: "PASS "
-RenderInline {DFN} at (0,0) size 36x18 [color=#FF]
- RenderText {#text} at (43,0) size 36x18
-text run at (43,0) width 36: "FAIL"
+RenderInline {DFN} at (0,0) size 34x18 [color=#FF]
+ RenderText {#text} at (43,0) size 34x18
+text run at (43,0) width 34: "FAIL"
RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94015] releases/WebKitGTK/webkit-1.4/Source/WebCore
Title: [94015] releases/WebKitGTK/webkit-1.4/Source/WebCore
Revision 94015
Author mrobin...@webkit.org
Date 2011-08-29 14:12:17 -0700 (Mon, 29 Aug 2011)
Log Message
Merging r90368
Modified Paths
releases/WebKitGTK/webkit-1.4/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.4/Source/WebCore/plugins/npapi.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.4/Source/WebCore/ChangeLog (94014 => 94015)
--- releases/WebKitGTK/webkit-1.4/Source/WebCore/ChangeLog 2011-08-29 20:59:23 UTC (rev 94014)
+++ releases/WebKitGTK/webkit-1.4/Source/WebCore/ChangeLog 2011-08-29 21:12:17 UTC (rev 94015)
@@ -1,5 +1,20 @@
2011-08-29 Martin Robinson
+Reviewed by Andreas Kling.
+
+[GTK] r90148 did not apply to X11 platforms in WebKit1
+https://bugs.webkit.org/show_bug.cgi?id=63862
+
+Correct the guard for an X11 specific piece of code. TARGET(X11) not
+defined for the GTK+ port.
+
+No new tests. This is covered by an existing test.
+
+* plugins/npapi.cpp: Correct the X11 guard.
+(NPN_InvalidateRect):
+
+2011-08-29 Martin Robinson
+
Reviewed by Gustavo Noronha Silva.
[GTK] Untangle GtkAdjustments from WebCore
Modified: releases/WebKitGTK/webkit-1.4/Source/WebCore/plugins/npapi.cpp (94014 => 94015)
--- releases/WebKitGTK/webkit-1.4/Source/WebCore/plugins/npapi.cpp 2011-08-29 20:59:23 UTC (rev 94014)
+++ releases/WebKitGTK/webkit-1.4/Source/WebCore/plugins/npapi.cpp 2011-08-29 21:12:17 UTC (rev 94015)
@@ -122,7 +122,7 @@
void NPN_InvalidateRect(NPP instance, NPRect* invalidRect)
{
PluginView* view = pluginViewForInstance(instance);
-#if defined(TARGET_X11)
+#if defined(XP_UNIX)
// NSPluginWrapper, a plugin wrapper binary that allows running 32-bit plugins
// on 64-bit architectures typically used in X11, will sometimes give us a null NPP here.
if (!view)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94014] releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk
Title: [94014] releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk
Revision 94014
Author mrobin...@webkit.org
Date 2011-08-29 13:59:23 -0700 (Mon, 29 Aug 2011)
Log Message
Merging r86118
Modified Paths
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkitwebview.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog (94013 => 94014)
--- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog 2011-08-29 20:58:31 UTC (rev 94013)
+++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog 2011-08-29 20:59:23 UTC (rev 94014)
@@ -1,5 +1,14 @@
2011-08-29 Xan Lopez
+Unreviewed build fix.
+
+Fix build, for real.
+
+* webkit/webkitwebview.cpp:
+(getHorizontalAdjustment):
+
+2011-08-29 Xan Lopez
+
Unreviewed build fix..
Fix GTK+3.x build.
Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkitwebview.cpp (94013 => 94014)
--- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkitwebview.cpp 2011-08-29 20:58:31 UTC (rev 94013)
+++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkitwebview.cpp 2011-08-29 20:59:23 UTC (rev 94014)
@@ -482,7 +482,7 @@
{
Page* page = core(webView);
if (page)
-return static_cast(page->chrome()->client())->adjustmentWatcher()->horizontalAdjustment();
+return static_cast(page->chrome()->client())->adjustmentWatcher()->horizontalAdjustment();
return 0;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94013] releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk
Title: [94013] releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk
Revision 94013
Author mrobin...@webkit.org
Date 2011-08-29 13:58:31 -0700 (Mon, 29 Aug 2011)
Log Message
Merging r86116
Modified Paths
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkitwebview.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog (94012 => 94013)
--- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog 2011-08-29 20:56:57 UTC (rev 94012)
+++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog 2011-08-29 20:58:31 UTC (rev 94013)
@@ -1,3 +1,14 @@
+2011-08-29 Xan Lopez
+
+Unreviewed build fix..
+
+Fix GTK+3.x build.
+
+* webkit/webkitwebview.cpp:
+(getHorizontalAdjustment): the adjustment is in
+adjustmentWatcher() now.
+(getVerticalAdjustment): ditto.
+
2011-08-29 Martin Robinson
Reviewed by Gustavo Noronha Silva.
Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkitwebview.cpp (94012 => 94013)
--- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkitwebview.cpp 2011-08-29 20:56:57 UTC (rev 94012)
+++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkitwebview.cpp 2011-08-29 20:58:31 UTC (rev 94013)
@@ -482,7 +482,7 @@
{
Page* page = core(webView);
if (page)
-return static_cast(page->chrome()->client())->horizontalAdjustment();
+return static_cast(page->chrome()->client())->adjustmentWatcher()->horizontalAdjustment();
return 0;
}
@@ -490,7 +490,7 @@
{
Page* page = core(webView);
if (page)
-return static_cast(page->chrome()->client())->verticalAdjustment();
+return static_cast(page->chrome()->client())->adjustmentWatcher()->verticalAdjustment();
return 0;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94011] trunk/Source/WebCore
Title: [94011] trunk/Source/WebCore Revision 94011 Author commit-qu...@webkit.org Date 2011-08-29 13:47:06 -0700 (Mon, 29 Aug 2011) Log Message Implement WebVTT Cue Text Parsing rules and DOM construction https://bugs.webkit.org/show_bug.cgi?id=64132 Patch by Anna Cavender on 2011-08-29 Reviewed by Adam Barth. Tests in media/track, particularly track-webvtt-tc[022 - 028]*. * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.pro: * WebCore.xcodeproj/project.pbxproj: * html/TextTrackCue.cpp: * html/TextTrackCue.h: * platform/track/CueParser.cpp: * platform/track/CueParser.h: * platform/track/WebVTTParser.cpp: * platform/track/WebVTTParser.h: * platform/track/WebVTTToken.h: Added. * platform/track/WebVTTTokenizer.cpp: Added. * platform/track/WebVTTTokenizer.h: Added. Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.pro trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/html/TextTrackCue.cpp trunk/Source/WebCore/html/TextTrackCue.h trunk/Source/WebCore/platform/track/CueParser.cpp trunk/Source/WebCore/platform/track/CueParser.h trunk/Source/WebCore/platform/track/WebVTTParser.cpp trunk/Source/WebCore/platform/track/WebVTTParser.h Added Paths trunk/Source/WebCore/platform/track/WebVTTToken.h trunk/Source/WebCore/platform/track/WebVTTTokenizer.cpp trunk/Source/WebCore/platform/track/WebVTTTokenizer.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (94010 => 94011) --- trunk/Source/WebCore/CMakeLists.txt 2011-08-29 20:32:32 UTC (rev 94010) +++ trunk/Source/WebCore/CMakeLists.txt 2011-08-29 20:47:06 UTC (rev 94011) @@ -2039,6 +2039,7 @@ loader/CueLoader.cpp platform/track/CueParser.cpp platform/track/WebVTTParser.cpp +platform/track/WebVTTTokenizer.cpp ) ENDIF() Modified: trunk/Source/WebCore/ChangeLog (94010 => 94011) --- trunk/Source/WebCore/ChangeLog 2011-08-29 20:32:32 UTC (rev 94010) +++ trunk/Source/WebCore/ChangeLog 2011-08-29 20:47:06 UTC (rev 94011) @@ -1,3 +1,27 @@ +2011-08-29 Anna Cavender + +Implement WebVTT Cue Text Parsing rules and DOM construction +https://bugs.webkit.org/show_bug.cgi?id=64132 + +Reviewed by Adam Barth. + +Tests in media/track, particularly track-webvtt-tc[022 - 028]*. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* WebCore.gypi: +* WebCore.pro: +* WebCore.xcodeproj/project.pbxproj: +* html/TextTrackCue.cpp: +* html/TextTrackCue.h: +* platform/track/CueParser.cpp: +* platform/track/CueParser.h: +* platform/track/WebVTTParser.cpp: +* platform/track/WebVTTParser.h: +* platform/track/WebVTTToken.h: Added. +* platform/track/WebVTTTokenizer.cpp: Added. +* platform/track/WebVTTTokenizer.h: Added. + 2011-08-29 Patrick Gansterer Add parsing support for extended attributes on IDL constants Modified: trunk/Source/WebCore/GNUmakefile.list.am (94010 => 94011) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-08-29 20:32:32 UTC (rev 94010) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-08-29 20:47:06 UTC (rev 94011) @@ -2875,6 +2875,9 @@ Source/WebCore/platform/track/CueParserPrivate.h \ Source/WebCore/platform/track/WebVTTParser.cpp \ Source/WebCore/platform/track/WebVTTParser.h \ + Source/WebCore/platform/track/WebVTTToken.h \ + Source/WebCore/platform/track/WebVTTTokenizer.h \ + Source/WebCore/platform/track/WebVTTTokenizer.cpp \ Source/WebCore/platform/TreeShared.h \ Source/WebCore/platform/URLString.h \ Source/WebCore/platform/UUID.cpp \ Modified: trunk/Source/WebCore/WebCore.gypi (94010 => 94011) --- trunk/Source/WebCore/WebCore.gypi 2011-08-29 20:32:32 UTC (rev 94010) +++ trunk/Source/WebCore/WebCore.gypi 2011-08-29 20:47:06 UTC (rev 94011) @@ -4394,6 +4394,9 @@ 'platform/track/CueParserPrivate.h', 'platform/track/WebVTTParser.cpp', 'platform/track/WebVTTParser.h', +'platform/track/WebVTTToken.h', +'platform/track/WebVTTTokenizer.cpp', +'platform/track/WebVTTTokenizer.h', 'platform/win/BString.cpp', 'platform/win/BString.h', 'platform/win/BitmapInfo.cpp', Modified: trunk/Source/WebCore/WebCore.pro (94010 => 94011) --- trunk/Source/WebCore/WebCore.pro 2011-08-29 20:32:32 UTC (rev 94010) +++ trunk/Source/WebCore/WebCore.pro 2011-08-29 20:47:06 UTC (rev 94011) @@ -2121,6 +2121,8 @@ platform/track/CueParser.h \ platform/track/CueParserPrivate.h \ platform/track/WebVTTParser.h \ +platform/track/WebVTTToken.h \ +platform/track/WebVTTTokenizer.h \ platform/Widget.h \ platform/PlatformStrategies.h \ platform/LocalizedStrings.h \ Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (94010 => 94011) --- t
[webkit-changes] [94010] trunk/Source/WebCore
Title: [94010] trunk/Source/WebCore
Revision 94010
Author par...@webkit.org
Date 2011-08-29 13:32:32 -0700 (Mon, 29 Aug 2011)
Log Message
Add parsing support for extended attributes on IDL constants
https://bugs.webkit.org/show_bug.cgi?id=65046
Reviewed by Brent Fulgham.
With support for extended attributes on constants we can
replace some preprocessor lines from the IDL files with
the corresponding [Conditional=XXX] later.
Using the preprocessor causes much pain on native windows.
CodeGenerator support will be added in separate patches.
* bindings/scripts/IDLParser.pm:
* bindings/scripts/IDLStructure.pm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/IDLParser.pm
trunk/Source/WebCore/bindings/scripts/IDLStructure.pm
Diff
Modified: trunk/Source/WebCore/ChangeLog (94009 => 94010)
--- trunk/Source/WebCore/ChangeLog 2011-08-29 20:18:46 UTC (rev 94009)
+++ trunk/Source/WebCore/ChangeLog 2011-08-29 20:32:32 UTC (rev 94010)
@@ -1,3 +1,20 @@
+2011-08-29 Patrick Gansterer
+
+Add parsing support for extended attributes on IDL constants
+https://bugs.webkit.org/show_bug.cgi?id=65046
+
+Reviewed by Brent Fulgham.
+
+With support for extended attributes on constants we can
+replace some preprocessor lines from the IDL files with
+the corresponding [Conditional=XXX] later.
+Using the preprocessor causes much pain on native windows.
+
+CodeGenerator support will be added in separate patches.
+
+* bindings/scripts/IDLParser.pm:
+* bindings/scripts/IDLStructure.pm:
+
2011-08-29 Ryosuke Niwa
Cleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setFormControlValueMatchesRenderer
Modified: trunk/Source/WebCore/bindings/scripts/IDLParser.pm (94009 => 94010)
--- trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2011-08-29 20:18:46 UTC (rev 94009)
+++ trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2011-08-29 20:32:32 UTC (rev 94010)
@@ -330,14 +330,16 @@
push(@$arrayRef, $newDataNode);
} elsif ($line =~ /^\s*const/) {
$line =~ /$IDLStructure::constantSelector/;
-my $constType = (defined($1) ? $1 : die("Parsing error!\nSource:\n$line\n)"));
-my $constName = (defined($2) ? $2 : die("Parsing error!\nSource:\n$line\n)"));
-my $constValue = (defined($3) ? $3 : die("Parsing error!\nSource:\n$line\n)"));
+my $constExtendedAttributes = (defined($1) ? $1 : " "); chop($constExtendedAttributes);
+my $constType = (defined($2) ? $2 : die("Parsing error!\nSource:\n$line\n)"));
+my $constName = (defined($3) ? $3 : die("Parsing error!\nSource:\n$line\n)"));
+my $constValue = (defined($4) ? $4 : die("Parsing error!\nSource:\n$line\n)"));
my $newDataNode = new domConstant();
$newDataNode->name($constName);
$newDataNode->type($constType);
$newDataNode->value($constValue);
+$newDataNode->extendedAttributes(parseExtendedAttributes($constExtendedAttributes));
my $arrayRef = $dataNode->constants;
push(@$arrayRef, $newDataNode);
Modified: trunk/Source/WebCore/bindings/scripts/IDLStructure.pm (94009 => 94010)
--- trunk/Source/WebCore/bindings/scripts/IDLStructure.pm 2011-08-29 20:18:46 UTC (rev 94009)
+++ trunk/Source/WebCore/bindings/scripts/IDLStructure.pm 2011-08-29 20:32:32 UTC (rev 94010)
@@ -70,6 +70,7 @@
name => '$', # DOM Constant identifier
type => '$', # Type of data
value => '$', # Constant value
+extendedAttributes => '$', # Extended attributes
});
# Helpers
@@ -93,7 +94,7 @@
# Regular _expression_ based IDL 'syntactical tokenizer' used in the IDLParser
our $moduleSelector = 'module\s*(' . $idlId . '*)\s*{';
our $moduleNSSelector = 'module\s*(' . $idlId . '*)\s*\[ns\s*(' . $idlIdNs . '*)\s*(' . $idlIdNs . '*)\]\s*;';
-our $constantSelector = 'const\s*' . $supportedTypes . '\s*(' . $idlType . '*)\s*=\s*(' . $constValue . ')';
+our $constantSelector = 'const\s*(' . $extendedAttributeSyntax . ' )?' . $supportedTypes . '\s*(' . $idlType . '*)\s*=\s*(' . $constValue . ')';
our $raisesSelector = 'raises\s*\((' . $idlIdNsList . '*)\s*\)';
our $getterRaisesSelector = '\bgetter\s+raises\s*\((' . $idlIdNsList . '*)\s*\)';
our $setterRaisesSelector = '\bsetter\s+raises\s*\((' . $idlIdNsList . '*)\s*\)';
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94009] trunk/Source/WebCore
Title: [94009] trunk/Source/WebCore
Revision 94009
Author rn...@webkit.org
Date 2011-08-29 13:18:46 -0700 (Mon, 29 Aug 2011)
Log Message
Cleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setFormControlValueMatchesRenderer
https://bugs.webkit.org/show_bug.cgi?id=67141
Reviewed by Eric Seidel.
No new tests since this is a refactoring.
* dom/Element.h: Removed formControlValueMatchesRenderer and setFormControlValueMatchesRenderer.
* html/HTMLInputElement.cpp: Removed notifyFormStateChanged.
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateValue): Calls notifyFormStateChanged; modifies m_wasModifiedByUser.
(WebCore::HTMLTextAreaElement::setValueCommon): Calls notifyFormStateChanged; also renamed value to newValue
to avoid the conflict with value().
* html/HTMLTextAreaElement.h: Made m_wasModifiedByUser mutable.
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::notifyFormStateChanged): Extracted from notifyFormStateChanged in
HTMLInputElement.cpp and HTMLTextAreaElement.cpp.
* html/HTMLTextFormControlElement.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::setInnerTextValue): Calls setFormControlValueMatchesRenderer.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/HTMLTextAreaElement.cpp
trunk/Source/WebCore/html/HTMLTextAreaElement.h
trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp
trunk/Source/WebCore/html/HTMLTextFormControlElement.h
trunk/Source/WebCore/rendering/RenderTextControl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94008 => 94009)
--- trunk/Source/WebCore/ChangeLog 2011-08-29 20:16:50 UTC (rev 94008)
+++ trunk/Source/WebCore/ChangeLog 2011-08-29 20:18:46 UTC (rev 94009)
@@ -1,3 +1,27 @@
+2011-08-29 Ryosuke Niwa
+
+Cleanup: notifyFormStateChanged, formControlValueMatchesRenderer, and setFormControlValueMatchesRenderer
+https://bugs.webkit.org/show_bug.cgi?id=67141
+
+Reviewed by Eric Seidel.
+
+No new tests since this is a refactoring.
+
+* dom/Element.h: Removed formControlValueMatchesRenderer and setFormControlValueMatchesRenderer.
+* html/HTMLInputElement.cpp: Removed notifyFormStateChanged.
+* html/HTMLInputElement.h:
+* html/HTMLTextAreaElement.cpp:
+(WebCore::HTMLTextAreaElement::updateValue): Calls notifyFormStateChanged; modifies m_wasModifiedByUser.
+(WebCore::HTMLTextAreaElement::setValueCommon): Calls notifyFormStateChanged; also renamed value to newValue
+to avoid the conflict with value().
+* html/HTMLTextAreaElement.h: Made m_wasModifiedByUser mutable.
+* html/HTMLTextFormControlElement.cpp:
+(WebCore::HTMLTextFormControlElement::notifyFormStateChanged): Extracted from notifyFormStateChanged in
+HTMLInputElement.cpp and HTMLTextAreaElement.cpp.
+* html/HTMLTextFormControlElement.h:
+* rendering/RenderTextControl.cpp:
+(WebCore::RenderTextControl::setInnerTextValue): Calls setFormControlValueMatchesRenderer.
+
2011-08-29 Sheriff Bot
Unreviewed, rolling out r93987, r93992, r93995, r93998, and
Modified: trunk/Source/WebCore/dom/Element.h (94008 => 94009)
--- trunk/Source/WebCore/dom/Element.h 2011-08-29 20:16:50 UTC (rev 94008)
+++ trunk/Source/WebCore/dom/Element.h 2011-08-29 20:18:46 UTC (rev 94009)
@@ -337,9 +337,6 @@
virtual bool canContainRangeEndPoint() const { return true; }
-virtual bool formControlValueMatchesRenderer() const { return false; }
-virtual void setFormControlValueMatchesRenderer(bool) { }
-
virtual const AtomicString& formControlName() const { return nullAtom; }
virtual const AtomicString& formControlType() const { return nullAtom; }
Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (94008 => 94009)
--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2011-08-29 20:16:50 UTC (rev 94008)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2011-08-29 20:18:46 UTC (rev 94009)
@@ -29,10 +29,7 @@
#include "HTMLInputElement.h"
#include "AXObjectCache.h"
-#include "Attribute.h"
#include "BeforeTextInsertedEvent.h"
-#include "Chrome.h"
-#include "ChromeClient.h"
#include "CSSPropertyNames.h"
#include "Document.h"
#include "EventNames.h"
@@ -45,14 +42,11 @@
#include "HTMLNames.h"
#include "HTMLOptionElement.h"
#include "HTMLParserIdioms.h"
-#include "Icon.h"
#include "InputType.h"
#include "KeyboardEvent.h"
#include "LocalizedStrings.h"
#include "MouseEvent.h"
#include "NumberInputType.h"
-#include "Page.h"
-#include "PlatformMouseEvent.h"
#include "RenderTextControlSingleLine.h"
#include "RenderTheme.h"
#include "RuntimeEnabledFeatures.h"
@@ -1909,16 +1903,6 @@
return document()->checkedRadioButtons();
}
-void HTMLInputElement::notifyFormStateChanged()
-{
-
[webkit-changes] [94008] trunk/Tools
Title: [94008] trunk/Tools Revision 94008 Author commit-qu...@webkit.org Date 2011-08-29 13:16:50 -0700 (Mon, 29 Aug 2011) Log Message Small fix in chromium port of new-run-webkit-tests. https://bugs.webkit.org/show_bug.cgi?id=67078 Patch by Shawn Singh on 2011-08-29 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/port/chromium.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py Diff Modified: trunk/Tools/ChangeLog (94007 => 94008) --- trunk/Tools/ChangeLog 2011-08-29 20:09:45 UTC (rev 94007) +++ trunk/Tools/ChangeLog 2011-08-29 20:16:50 UTC (rev 94008) @@ -1,3 +1,12 @@ +2011-08-29 Shawn Singh + +Small fix in chromium port of new-run-webkit-tests. +https://bugs.webkit.org/show_bug.cgi?id=67078 + +Reviewed by Dirk Pranke. + +* Scripts/webkitpy/layout_tests/port/chromium.py: + 2011-08-29 Sheriff Bot Unreviewed, rolling out r93987, r93992, r93995, r93998, and Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (94007 => 94008) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2011-08-29 20:09:45 UTC (rev 94007) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2011-08-29 20:16:50 UTC (rev 94008) @@ -210,7 +210,7 @@ raise finally: if exit_code == 1: -result = self._filesystem.read_binary_file(diff_filename) +result = self._filesystem.read_binary_file(native_diff_filename) self._filesystem.rmtree(str(tempdir)) return result ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94006] trunk
Title: [94006] trunk
Revision 94006
Author commit-qu...@webkit.org
Date 2011-08-29 13:06:52 -0700 (Mon, 29 Aug 2011)
Log Message
As per HTML specification, default font style of dfn tag should be italic.
https://bugs.webkit.org/show_bug.cgi?id=56670
Patch by Nayan Kumar K on 2011-08-29
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/css/dfn-default-font-style.html
* css/html.css:
(i, cite, em, var, address, dfn):
LayoutTests:
* fast/css/dfn-default-font-style-expected.txt: Added.
* fast/css/dfn-default-font-style.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css
Added Paths
trunk/LayoutTests/fast/css/dfn-default-font-style-expected.txt
trunk/LayoutTests/fast/css/dfn-default-font-style.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94005 => 94006)
--- trunk/LayoutTests/ChangeLog 2011-08-29 20:03:33 UTC (rev 94005)
+++ trunk/LayoutTests/ChangeLog 2011-08-29 20:06:52 UTC (rev 94006)
@@ -1,3 +1,13 @@
+2011-08-29 Nayan Kumar K
+
+As per HTML specification, default font style of dfn tag should be italic.
+https://bugs.webkit.org/show_bug.cgi?id=56670
+
+Reviewed by Adam Barth.
+
+* fast/css/dfn-default-font-style-expected.txt: Added.
+* fast/css/dfn-default-font-style.html: Added.
+
2011-08-29 Chris Palmer
Fix failures when FFT array size is changed.
Added: trunk/LayoutTests/fast/css/dfn-default-font-style-expected.txt (0 => 94006)
--- trunk/LayoutTests/fast/css/dfn-default-font-style-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/dfn-default-font-style-expected.txt 2011-08-29 20:06:52 UTC (rev 94006)
@@ -0,0 +1,2 @@
+This test ensures that whatever written within dfn tag is italicized.
+For example the dfn should be italicized. PASS
Added: trunk/LayoutTests/fast/css/dfn-default-font-style.html (0 => 94006)
--- trunk/LayoutTests/fast/css/dfn-default-font-style.html (rev 0)
+++ trunk/LayoutTests/fast/css/dfn-default-font-style.html 2011-08-29 20:06:52 UTC (rev 94006)
@@ -0,0 +1,24 @@
+
+
+
+This test ensures that whatever written within dfn tag is italicized.
+For example the dfn should be italicized.
+
+
+var dfnfont = document.defaultView.getComputedStyle(document.getElementById('dfntag'), "").getPropertyValue("font-style");
+var testresult;
+
+if (dfnfont == 'italic')
+testresult = 'PASS';
+else
+testresult = 'FAIL';
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+}
+
+document.writeln(testresult);
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (94005 => 94006)
--- trunk/Source/WebCore/ChangeLog 2011-08-29 20:03:33 UTC (rev 94005)
+++ trunk/Source/WebCore/ChangeLog 2011-08-29 20:06:52 UTC (rev 94006)
@@ -1,3 +1,15 @@
+2011-08-29 Nayan Kumar K
+
+As per HTML specification, default font style of dfn tag should be italic.
+https://bugs.webkit.org/show_bug.cgi?id=56670
+
+Reviewed by Adam Barth.
+
+Test: fast/css/dfn-default-font-style.html
+
+* css/html.css:
+(i, cite, em, var, address, dfn):
+
2011-08-29 Patrick Gansterer
Consider Conditional attribute in CodeGeneratorJS' JSValueToNative and NativeToJSValue function
Modified: trunk/Source/WebCore/css/html.css (94005 => 94006)
--- trunk/Source/WebCore/css/html.css 2011-08-29 20:03:33 UTC (rev 94005)
+++ trunk/Source/WebCore/css/html.css 2011-08-29 20:06:52 UTC (rev 94006)
@@ -848,7 +848,7 @@
font-weight: bolder
}
-i, cite, em, var, address {
+i, cite, em, var, address, dfn {
font-style: italic
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94005] trunk/Source/WebCore
Title: [94005] trunk/Source/WebCore
Revision 94005
Author par...@webkit.org
Date 2011-08-29 13:03:33 -0700 (Mon, 29 Aug 2011)
Log Message
Consider Conditional attribute in CodeGeneratorJS' JSValueToNative and NativeToJSValue function
https://bugs.webkit.org/show_bug.cgi?id=65040
Reviewed by Brent Fulgham.
JSValueToNative and NativeToJSValue add additional include statements
to the implementation and need to handle the Conditional attribute from
the IDL file. The Conditional attribute adds appropriate #if ENABLE()
lines for the preprocessor around the include statements to remove
some unneeded build dependencies.
* bindings/scripts/CodeGeneratorJS.pm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Diff
Modified: trunk/Source/WebCore/ChangeLog (94004 => 94005)
--- trunk/Source/WebCore/ChangeLog 2011-08-29 19:35:08 UTC (rev 94004)
+++ trunk/Source/WebCore/ChangeLog 2011-08-29 20:03:33 UTC (rev 94005)
@@ -1,3 +1,18 @@
+2011-08-29 Patrick Gansterer
+
+Consider Conditional attribute in CodeGeneratorJS' JSValueToNative and NativeToJSValue function
+https://bugs.webkit.org/show_bug.cgi?id=65040
+
+Reviewed by Brent Fulgham.
+
+JSValueToNative and NativeToJSValue add additional include statements
+to the implementation and need to handle the Conditional attribute from
+the IDL file. The Conditional attribute adds appropriate #if ENABLE()
+lines for the preprocessor around the include statements to remove
+some unneeded build dependencies.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+
2011-08-29 Nate Chapin
Plumb ResourceLoaderOptions out to CachedResourceLoader::requestResource().
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (94004 => 94005)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-08-29 19:35:08 UTC (rev 94004)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-08-29 20:03:33 UTC (rev 94005)
@@ -312,6 +312,28 @@
}
}
+sub AddToImplIncludes
+{
+my $header = shift;
+my $conditional = shift;
+
+if (not $conditional) {
+$implIncludes{$header} = 1;
+} elsif (not exists($implIncludes{$header})) {
+$implIncludes{$header} = $conditional;
+} else {
+my $oldValue = $implIncludes{$header};
+if ($oldValue ne 1) {
+my %newValue = ();
+$newValue{$conditional} = 1;
+foreach my $condition (split(/\|/, $oldValue)) {
+$newValue{$condition} = 1;
+}
+$implIncludes{$header} = join("|", sort keys %newValue);
+}
+}
+}
+
sub IsScriptProfileType
{
my $type = shift;
@@ -1785,23 +1807,7 @@
my $constructorType = $attribute->signature->type;
$constructorType =~ s/Constructor$//;
if ($constructorType ne "DOMObject") {
-my $header = "JS" . $constructorType . ".h";
-my $conditional = $attribute->signature->extendedAttributes->{"Conditional"};
-if (not $conditional) {
-$implIncludes{$header} = 1;
-} elsif (not exists($implIncludes{$header})) {
-$implIncludes{$header} = $conditional;
-} else {
-my $oldValue = $implIncludes{$header};
-if ($oldValue ne 1) {
-my %newValue = ();
-$newValue{$conditional} = 1;
-foreach my $condition (split(/\|/, $oldValue)) {
-$newValue{$condition} = 1;
-}
-$implIncludes{$header} = join("|", sort keys %newValue);
-}
-}
+AddToImplIncludes("JS" . $constructorType . ".h", $attribute->signature->extendedAttributes->{"Conditional"});
}
push(@implContent, "// Shadowing a built-in constructor\n");
if ($interfaceName eq "DOMWindow" && $className eq "JSblah") {
@@ -2630,6 +2636,7 @@
my $signature = shift;
my $value = shift;
+my $conditional = $signature->extendedAttributes->{"Conditional"};
my $type = $codeGenerator->StripModule($signature->type);
return "$value.toBoolean(exec)" if $type eq "boolean";
@@ -2653,32 +2660,32 @@
}
if ($type eq "NodeFilter") {
-$implIncludes{"JS$type.h"} = 1;
+AddToImplIncludes("JS$type.h", $conditional);
return "to$type(exec->globalData(), $value)";
[webkit-changes] [94004] trunk/Source/WebKit/chromium
Title: [94004] trunk/Source/WebKit/chromium
Revision 94004
Author commit-qu...@webkit.org
Date 2011-08-29 12:35:08 -0700 (Mon, 29 Aug 2011)
Log Message
[Chromium] Add ability to do static SerializedScriptValue deserialization
https://bugs.webkit.org/show_bug.cgi?id=66877
Patch by Greg Billock on 2011-08-29
Reviewed by Darin Fisher.
* public/WebSerializedScriptValue.h:
* src/WebSerializedScriptValue.cpp:
(WebKit::WebSerializedScriptValue::deserialize):
(WebKit::WebSerializedScriptValue::serialize):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSerializedScriptValue.h
trunk/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (94003 => 94004)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-29 19:26:46 UTC (rev 94003)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-29 19:35:08 UTC (rev 94004)
@@ -1,3 +1,15 @@
+2011-08-29 Greg Billock
+
+[Chromium] Add ability to do static SerializedScriptValue deserialization
+https://bugs.webkit.org/show_bug.cgi?id=66877
+
+Reviewed by Darin Fisher.
+
+* public/WebSerializedScriptValue.h:
+* src/WebSerializedScriptValue.cpp:
+(WebKit::WebSerializedScriptValue::deserialize):
+(WebKit::WebSerializedScriptValue::serialize):
+
2011-08-27 Peter Beverloo
Teach the update and build scripts how to handle dependencies
Modified: trunk/Source/WebKit/chromium/public/WebSerializedScriptValue.h (94003 => 94004)
--- trunk/Source/WebKit/chromium/public/WebSerializedScriptValue.h 2011-08-29 19:26:46 UTC (rev 94003)
+++ trunk/Source/WebKit/chromium/public/WebSerializedScriptValue.h 2011-08-29 19:35:08 UTC (rev 94004)
@@ -36,9 +36,17 @@
namespace WebCore { class SerializedScriptValue; }
+#if WEBKIT_USING_V8
+namespace v8 {
+class Value;
+template class Handle;
+}
+#endif
+
namespace WebKit {
class WebString;
+
class WebSerializedScriptValue {
public:
~WebSerializedScriptValue() { reset(); }
@@ -53,6 +61,10 @@
WEBKIT_EXPORT static WebSerializedScriptValue fromString(const WebString&);
+#if WEBKIT_USING_V8
+WEBKIT_EXPORT static WebSerializedScriptValue serialize(v8::Handle);
+#endif
+
// Create a WebSerializedScriptValue that represents a serialization error.
WEBKIT_EXPORT static WebSerializedScriptValue createInvalid();
@@ -64,6 +76,11 @@
// Returns a string representation of the WebSerializedScriptValue.
WEBKIT_EXPORT WebString toString() const;
+#if WEBKIT_USING_V8
+// Convert the serialized value to a parsed v8 value.
+WEBKIT_EXPORT v8::Handle deserialize();
+#endif
+
#if WEBKIT_IMPLEMENTATION
WebSerializedScriptValue(const WTF::PassRefPtr&);
WebSerializedScriptValue& operator=(const WTF::PassRefPtr&);
Modified: trunk/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp (94003 => 94004)
--- trunk/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp 2011-08-29 19:26:46 UTC (rev 94003)
+++ trunk/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp 2011-08-29 19:35:08 UTC (rev 94004)
@@ -43,6 +43,17 @@
return SerializedScriptValue::createFromWire(s);
}
+#if WEBKIT_USING_V8
+WebSerializedScriptValue WebSerializedScriptValue::serialize(v8::Handle value)
+{
+bool didThrow;
+WebSerializedScriptValue v = SerializedScriptValue::create(value, didThrow);
+if (didThrow)
+ return createInvalid();
+return v;
+}
+#endif
+
WebSerializedScriptValue WebSerializedScriptValue::createInvalid()
{
return SerializedScriptValue::create();
@@ -63,6 +74,13 @@
return m_private->toWireString();
}
+#if WEBKIT_USING_V8
+v8::Handle WebSerializedScriptValue::deserialize()
+{
+return m_private->deserialize();
+}
+#endif
+
WebSerializedScriptValue::WebSerializedScriptValue(const PassRefPtr& value)
: m_private(value)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94003] trunk/Source/WebCore
Title: [94003] trunk/Source/WebCore
Revision 94003
Author jap...@chromium.org
Date 2011-08-29 12:26:46 -0700 (Mon, 29 Aug 2011)
Log Message
Plumb ResourceLoaderOptions out to CachedResourceLoader::requestResource().
This will be needed in order for DocumentThreadableLoader to become a CachedResourceClient.
https://bugs.webkit.org/show_bug.cgi?id=66018
Reviewed by Antti Koivisto.
No new tests, refactor only.
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::load):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::load):
(WebCore::CachedResource::setResourceLoaderOptions):
(WebCore::CachedResource::sendResourceLoadCallbacks):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::load):
* loader/cache/CachedResourceRequest.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp
trunk/Source/WebCore/loader/cache/CachedResourceRequest.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (94002 => 94003)
--- trunk/Source/WebCore/ChangeLog 2011-08-29 19:23:00 UTC (rev 94002)
+++ trunk/Source/WebCore/ChangeLog 2011-08-29 19:26:46 UTC (rev 94003)
@@ -1,3 +1,31 @@
+2011-08-29 Nate Chapin
+
+Plumb ResourceLoaderOptions out to CachedResourceLoader::requestResource().
+This will be needed in order for DocumentThreadableLoader to become a CachedResourceClient.
+https://bugs.webkit.org/show_bug.cgi?id=66018
+
+Reviewed by Antti Koivisto.
+
+No new tests, refactor only.
+
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::load):
+* loader/cache/CachedResource.cpp:
+(WebCore::CachedResource::CachedResource):
+(WebCore::CachedResource::load):
+* loader/cache/CachedResource.h:
+ (WebCore::CachedResource::load):
+(WebCore::CachedResource::setResourceLoaderOptions):
+(WebCore::CachedResource::sendResourceLoadCallbacks):
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
+(WebCore::CachedResourceLoader::requestResource):
+(WebCore::CachedResourceLoader::loadResource):
+* loader/cache/CachedResourceLoader.h:
+* loader/cache/CachedResourceRequest.cpp:
+(WebCore::CachedResourceRequest::load):
+* loader/cache/CachedResourceRequest.h:
+
2011-08-29 Chris Palmer
Fix failures when FFT size is changed.
Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (94002 => 94003)
--- trunk/Source/WebCore/loader/cache/CachedImage.cpp 2011-08-29 19:23:00 UTC (rev 94002)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp 2011-08-29 19:26:46 UTC (rev 94003)
@@ -84,7 +84,7 @@
void CachedImage::load(CachedResourceLoader* cachedResourceLoader)
{
if (!cachedResourceLoader || cachedResourceLoader->autoLoadImages())
-CachedResource::load(cachedResourceLoader, true, DoSecurityCheck, true);
+CachedResource::load(cachedResourceLoader, true, DoSecurityCheck);
else
setLoading(false);
}
Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (94002 => 94003)
--- trunk/Source/WebCore/loader/cache/CachedResource.cpp 2011-08-29 19:23:00 UTC (rev 94002)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp 2011-08-29 19:26:46 UTC (rev 94003)
@@ -92,11 +92,11 @@
, m_preloadResult(PreloadNotReferenced)
, m_inLiveDecodedResourcesList(false)
, m_requestedFromNetworkingLayer(false)
-, m_sendResourceLoadCallbacks(true)
, m_inCache(false)
, m_loading(false)
, m_type(type)
, m_status(Pending)
+, m_options(SendCallbacks, SniffContent, BufferData, AllowStoredCredentials)
#ifndef NDEBUG
, m_deleted(false)
, m_lruIndex(0)
@@ -131,11 +131,10 @@
m_owningCachedResourceLoader->removeCachedResource(this);
}
-void CachedResource::load(CachedResourceLoader* cachedResourceLoader, bool incremental, SecurityCheckPolicy securityCheck, bool sendResourceLoadCallbacks)
+void CachedResource::load(CachedResourceLoader* cachedResourceLoader, bool incremental, SecurityCheckPolicy securityCheck)
{
-m_sendResourceLoadCallbacks = sendResourceLoadCallbacks;
m_loading = true;
-m_request = CachedResourceRequest::load(cachedResourceLoader, this, incremental, securityCheck, sendResourceLoadCallbacks);
+
[webkit-changes] [94002] trunk
Title: [94002] trunk
Revision 94002
Author commit-qu...@webkit.org
Date 2011-08-29 12:23:00 -0700 (Mon, 29 Aug 2011)
Log Message
Source/WebCore: Fix failures when FFT size is changed.
https://bugs.webkit.org/show_bug.cgi?id=66916
Patch by Chris Palmer on 2011-08-29
Reviewed by Kenneth Russell.
Test: webaudio/fft-sizing.html
* webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::setFftSize): Assert size sanity.
(WebCore::RealtimeAnalyser::doFFTAnalysis): Iterate the correct number of times over magnitudeBuffer.
* webaudio/RealtimeAnalyser.h: Put member fields in the correct order (Min before Max).
LayoutTests: Fix failures when FFT array size is changed.
https://bugs.webkit.org/show_bug.cgi?id=66916
Patch by Chris Palmer on 2011-08-29
Reviewed by Kenneth Russell.
* webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.
* webaudio/realtimeanalyser-fft-sizing.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/RealtimeAnalyser.cpp
trunk/Source/WebCore/webaudio/RealtimeAnalyser.h
Added Paths
trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt
trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94001 => 94002)
--- trunk/LayoutTests/ChangeLog 2011-08-29 19:19:52 UTC (rev 94001)
+++ trunk/LayoutTests/ChangeLog 2011-08-29 19:23:00 UTC (rev 94002)
@@ -1,3 +1,13 @@
+2011-08-29 Chris Palmer
+
+Fix failures when FFT array size is changed.
+https://bugs.webkit.org/show_bug.cgi?id=66916
+
+Reviewed by Kenneth Russell.
+
+* webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.
+* webaudio/realtimeanalyser-fft-sizing.html: Added.
+
2011-08-29 Abhishek Arya
Crash in InlineBox::deleteLine due to accessing removed
Added: trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt (0 => 94002)
--- trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt (rev 0)
+++ trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing-expected.txt 2011-08-29 19:23:00 UTC (rev 94002)
@@ -0,0 +1,9 @@
+Test that re-sizing the FFT arrays does not fail.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS webkitAudioContext survived multiple invalid FFT array resizings.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing.html (0 => 94002)
--- trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing.html (rev 0)
+++ trunk/LayoutTests/webaudio/realtimeanalyser-fft-sizing.html 2011-08-29 19:23:00 UTC (rev 94002)
@@ -0,0 +1,46 @@
+
+
+
+
+
+
+
+
+
+
+
+description("Test that re-sizing the FFT arrays does not fail.");
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+var doTest = function(fftSize) {
+var c = new webkitAudioContext(1, 1000, 44100);
+var a = c.createAnalyser();
+a.fftSize = fftSize;
+// This arbitrary size does not affect the correctness of the test.
+var arr = new Float32Array(100);
+a.getFloatFrequencyData(arr);
+}
+
+doTest(-1);
+doTest(0);
+doTest(1);
+for (var i = 2; i <= 0x2; i *= 2) {
+doTest(i);
+doTest(i + 1);
+}
+
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+testPassed("webkitAudioContext survived multiple invalid FFT array resizings.");
+successfullyParsed = true;
+
+
+
[webkit-changes] [94001] trunk
Title: [94001] trunk
Revision 94001
Author infe...@chromium.org
Date 2011-08-29 12:19:52 -0700 (Mon, 29 Aug 2011)
Log Message
Crash in InlineBox::deleteLine due to accessing removed
renderer.
https://bugs.webkit.org/show_bug.cgi?id=66015
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/block/line-layout/inline-box-wrapper-crash.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox): Make sure that the
previous inline box wrapper is destroyed properly, before
setting a new one.
LayoutTests:
* fast/block/line-layout/inline-box-wrapper-crash-expected.txt: Added.
* fast/block/line-layout/inline-box-wrapper-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
Added Paths
trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash-expected.txt
trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94000 => 94001)
--- trunk/LayoutTests/ChangeLog 2011-08-29 19:19:02 UTC (rev 94000)
+++ trunk/LayoutTests/ChangeLog 2011-08-29 19:19:52 UTC (rev 94001)
@@ -1,3 +1,14 @@
+2011-08-29 Abhishek Arya
+
+Crash in InlineBox::deleteLine due to accessing removed
+renderer.
+https://bugs.webkit.org/show_bug.cgi?id=66015
+
+Reviewed by Simon Fraser.
+
+* fast/block/line-layout/inline-box-wrapper-crash-expected.txt: Added.
+* fast/block/line-layout/inline-box-wrapper-crash.html: Added.
+
2011-08-29 Chris Marrin
Fixing LayoutTests broken by http://trac.webkit.org/changeset/93980
Added: trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash-expected.txt (0 => 94001)
--- trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash-expected.txt 2011-08-29 19:19:52 UTC (rev 94001)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash.html (0 => 94001)
--- trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash.html (rev 0)
+++ trunk/LayoutTests/fast/block/line-layout/inline-box-wrapper-crash.html 2011-08-29 19:19:52 UTC (rev 94001)
@@ -0,0 +1,24 @@
+
+
+body { direction: rtl; padding-left: 100%; }
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function runTest() {
+document.body.innerHTML = "PASS";
+
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+setTimeout("runTest()", 0);
+
+0
+
+A
+
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (94000 => 94001)
--- trunk/Source/WebCore/ChangeLog 2011-08-29 19:19:02 UTC (rev 94000)
+++ trunk/Source/WebCore/ChangeLog 2011-08-29 19:19:52 UTC (rev 94001)
@@ -1,3 +1,18 @@
+2011-08-29 Abhishek Arya
+
+Crash in InlineBox::deleteLine due to accessing removed
+renderer.
+https://bugs.webkit.org/show_bug.cgi?id=66015
+
+Reviewed by Simon Fraser.
+
+Test: fast/block/line-layout/inline-box-wrapper-crash.html
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::positionLineBox): Make sure that the
+previous inline box wrapper is destroyed properly, before
+setting a new one.
+
2011-08-29 Alexey Proskuryakov
Lion build fix.
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (94000 => 94001)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2011-08-29 19:19:02 UTC (rev 94000)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2011-08-29 19:19:52 UTC (rev 94001)
@@ -1377,6 +1377,8 @@
box->destroy(renderArena());
} else if (isReplaced()) {
setLocation(roundedLayoutPoint(FloatPoint(box->x(), box->y(;
+if (m_inlineBoxWrapper)
+deleteLineBoxWrapper();
m_inlineBoxWrapper = box;
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94000] trunk
Title: [94000] trunk
Revision 94000
Author mrobin...@webkit.org
Date 2011-08-29 12:19:02 -0700 (Mon, 29 Aug 2011)
Log Message
Reviewed by Xan Lopez.
[GTK] Build WebKit2 unconditionally
https://bugs.webkit.org/show_bug.cgi?id=62749
Build WebKit2 by default. This will make the bots build it and catch
build errors when they occur.
* GNUmakefile.am: Enable WebKit2 by default, but remove references to the WebKit2
PC file, which should not be shipped until WebKit2 is actually shipped officially.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/configure.ac
Diff
Modified: trunk/Source/WebKit2/ChangeLog (93999 => 94000)
--- trunk/Source/WebKit2/ChangeLog 2011-08-29 19:07:27 UTC (rev 93999)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-29 19:19:02 UTC (rev 94000)
@@ -1,3 +1,16 @@
+2011-08-26 Martin Robinson
+
+Reviewed by Xan Lopez.
+
+[GTK] Build WebKit2 unconditionally
+https://bugs.webkit.org/show_bug.cgi?id=62749
+
+Build WebKit2 by default. This will make the bots build it and catch
+build errors when they occur.
+
+* GNUmakefile.am: Enable WebKit2 by default, but remove references to the WebKit2
+PC file, which should not be shipped until WebKit2 is actually shipped officially.
+
2011-08-29 Alexey Proskuryakov
Windows build fix.
Modified: trunk/Source/WebKit2/GNUmakefile.am (93999 => 94000)
--- trunk/Source/WebKit2/GNUmakefile.am 2011-08-29 19:07:27 UTC (rev 93999)
+++ trunk/Source/WebKit2/GNUmakefile.am 2011-08-29 19:19:02 UTC (rev 94000)
@@ -908,8 +908,6 @@
$(UNICODE_LIBS) \
$(XT_LIBS)
-pkgconfig_DATA += Source/WebKit2/webkit2gtk-@WEBKITGTK_API_VERSION@.pc
-
# WebKit2 specific variables
forwarding_headers := $(GENSOURCES_WEBKIT2)/include
generate-webkit2-forwarding-headers: $(WebKit2)/Scripts/generate-forwarding-headers.pl $(libWebKit2_la_SOURCES)
@@ -957,9 +955,6 @@
$(BUILT_SOURCES) \
$(top_builddir)/Programs/WebKitWebProcess
-DISTCLEANFILES += \
- $(top_builddir)/WebKit2/webkit2gtk-@WEBKITGTK_API_VERSION@.pc
-
# WebKitWebProcess
libexec_PROGRAMS += \
Programs/WebKitWebProcess
Modified: trunk/configure.ac (93999 => 94000)
--- trunk/configure.ac 2011-08-29 19:07:27 UTC (rev 93999)
+++ trunk/configure.ac 2011-08-29 19:19:02 UTC (rev 94000)
@@ -1095,9 +1095,8 @@
# WebKit2
AC_MSG_CHECKING([whether to build Webkit2])
AC_ARG_ENABLE(webkit2,
-AC_HELP_STRING([--enable-webkit2],
-[build webkit2 [default=no]]),
-[], [enable_webkit2="no"])
+AC_HELP_STRING([--enable-webkit2], [build webkit2 [default=yes]]),
+[], [enable_webkit2="yes"])
AC_MSG_RESULT([$enable_webkit2])
if test "$enable_webkit2" = "yes"; then
if test "$GTK_API_VERSION" = "2.0"; then
@@ -1108,24 +1107,22 @@
# Plugin Process
AC_MSG_CHECKING([whether to build plugin process for WebKit2])
AC_ARG_ENABLE(plugin_process,
-AC_HELP_STRING([--enable-plugin-process],
- [build plugin process for WebKit2 [default=yes]]),
+AC_HELP_STRING([--enable-plugin-process], [build plugin process for WebKit2 [default=yes]]),
[], [enable_plugin_process="yes"])
-# Build the plugin process only when building webkit2.
+AC_MSG_RESULT([$enable_plugin_process])
+
+# Build the plugin process only when building Webkit2.
if test "$enable_webkit2" = "no"; then
enable_plugin_process=no
fi
-# Make sure we have gtk+ 2.x to build the plugin process
+# Make sure we have GTK+ 2.x to build the plugin process.
if test "$enable_plugin_process" = "yes"; then
PKG_CHECK_MODULES(GTK2, gtk+-2.0 >= $GTK2_REQUIRED_VERSION gail >= $GAIL2_REQUIRED_VERSION)
fi
-
AC_SUBST(GTK2_CFLAGS)
AC_SUBST(GTK2_LIBS)
-AC_MSG_RESULT([$enable_plugin_process])
-
GTK_DOC_CHECK([1.10])
# OS conditionals
@@ -1242,14 +1239,6 @@
,[WEBKITGTK_API_VERSION=$WEBKITGTK_API_VERSION,WEBKITGTK_PC_NAME=$WEBKITGTK_PC_NAME]
)
-if test "$enable_webkit2" = "yes"; then
-AC_CONFIG_FILES([
-Source/WebKit2/webkit2gtk-${WEBKITGTK_API_VERSION}.pc:Source/WebKit2/webkit2gtk.pc.in
-]
-,[WEBKITGTK_API_VERSION=$WEBKITGTK_API_VERSION,WEBKITGTK_PC_NAME=$WEBKITGTK_PC_NAME]
-)
-fi
-
AC_OUTPUT
echo "
@@ -1320,14 +1309,14 @@
Animation API: $enable_animation_api
Touch Icon Loading support : $enable_touch_icon_loading
Register Protocol Handler support: $enable_register_protocol_handler
+ WebKit2 support : $enable_webkit2
+ WebKit2 plugin process : $enable_plugin_process
GTK+ configuration:
GTK+ version : $with_gtk
GDK target : $with_target
Hildon UI extensions : $with_hildon
Introspection support
[webkit-changes] [93999] trunk/Source
Title: [93999] trunk/Source
Revision 93999
Author a...@apple.com
Date 2011-08-29 12:07:27 -0700 (Mon, 29 Aug 2011)
Log Message
Windows build fix.
WebKit/win:
* WebView.cpp:
(updateSharedSettingsFromPreferencesIfNeeded):
Updated for new function name and signature: currentCFHTTPCookieStorage().
WebKit2:
* WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
Updated for new function name and signature: currentCFHTTPCookieStorage().
Modified Paths
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebView.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (93998 => 93999)
--- trunk/Source/WebKit/win/ChangeLog 2011-08-29 18:59:15 UTC (rev 93998)
+++ trunk/Source/WebKit/win/ChangeLog 2011-08-29 19:07:27 UTC (rev 93999)
@@ -1,3 +1,11 @@
+2011-08-29 Alexey Proskuryakov
+
+Windows build fix.
+
+* WebView.cpp:
+(updateSharedSettingsFromPreferencesIfNeeded):
+Updated for new function name and signature: currentCFHTTPCookieStorage().
+
2011-08-26 Alexey Proskuryakov
DumpRenderTree should begin each test with an empty cookie store
Modified: trunk/Source/WebKit/win/WebView.cpp (93998 => 93999)
--- trunk/Source/WebKit/win/WebView.cpp 2011-08-29 18:59:15 UTC (rev 93998)
+++ trunk/Source/WebKit/win/WebView.cpp 2011-08-29 19:07:27 UTC (rev 93999)
@@ -4910,8 +4910,8 @@
#if USE(CFNETWORK)
// Set cookie storage accept policy
-if (CFHTTPCookieStorageRef cookieStorage = currentCookieStorage())
-CFHTTPCookieStorageSetCookieAcceptPolicy(cookieStorage, acceptPolicy);
+if (RetainPtr cookieStorage = currentCFHTTPCookieStorage())
+CFHTTPCookieStorageSetCookieAcceptPolicy(cookieStorage.get(), acceptPolicy);
#endif
return S_OK;
Modified: trunk/Source/WebKit2/ChangeLog (93998 => 93999)
--- trunk/Source/WebKit2/ChangeLog 2011-08-29 18:59:15 UTC (rev 93998)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-29 19:07:27 UTC (rev 93999)
@@ -1,3 +1,12 @@
+2011-08-29 Alexey Proskuryakov
+
+Windows build fix.
+
+* WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
+(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
+(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
+Updated for new function name and signature: currentCFHTTPCookieStorage().
+
2011-08-26 Alexey Proskuryakov
DumpRenderTree should begin each test with an empty cookie store
Modified: trunk/Source/WebKit2/WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp (93998 => 93999)
--- trunk/Source/WebKit2/WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp 2011-08-29 18:59:15 UTC (rev 93998)
+++ trunk/Source/WebKit2/WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp 2011-08-29 19:07:27 UTC (rev 93999)
@@ -36,15 +36,16 @@
{
CFHTTPCookieStorageSetCookieAcceptPolicy(WebCore::defaultCookieStorage(), policy);
-CFHTTPCookieStorageRef privateBrowsingCookieStorage = WebCore::privateBrowsingCookieStorage().get();
+RetainPtr cookieStorage = WebCore::currentCFHTTPCookieStorage();
if (!privateBrowsingCookieStorage)
return;
-CFHTTPCookieStorageSetCookieAcceptPolicy(privateBrowsingCookieStorage, policy);
+CFHTTPCookieStorageSetCookieAcceptPolicy(cookieStorage.get(), policy);
}
HTTPCookieAcceptPolicy WebCookieManager::platformGetHTTPCookieAcceptPolicy()
{
-return CFHTTPCookieStorageGetCookieAcceptPolicy(WebCore::currentCookieStorage());
+RetainPtr cookieStorage = WebCore::currentCFHTTPCookieStorage();
+return CFHTTPCookieStorageGetCookieAcceptPolicy(cookieStorage.get());
}
} // namespace WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93998] trunk/Source/WebCore
Title: [93998] trunk/Source/WebCore Revision 93998 Author a...@apple.com Date 2011-08-29 11:59:15 -0700 (Mon, 29 Aug 2011) Log Message Lion build fix. * WebCore.exp.in: We have different definitions of CFURLStorageSessionRef on different versions of Mac OS X, and need separate exports. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in Diff Modified: trunk/Source/WebCore/ChangeLog (93997 => 93998) --- trunk/Source/WebCore/ChangeLog 2011-08-29 18:54:44 UTC (rev 93997) +++ trunk/Source/WebCore/ChangeLog 2011-08-29 18:59:15 UTC (rev 93998) @@ -1,3 +1,10 @@ +2011-08-29 Alexey Proskuryakov + +Lion build fix. + +* WebCore.exp.in: We have different definitions of CFURLStorageSessionRef on different versions +of Mac OS X, and need separate exports. + 2011-08-29 Tony Chang Implement -webkit-flex-pack for horizontal flexboxen Modified: trunk/Source/WebCore/WebCore.exp.in (93997 => 93998) --- trunk/Source/WebCore/WebCore.exp.in 2011-08-29 18:54:44 UTC (rev 93997) +++ trunk/Source/WebCore/WebCore.exp.in 2011-08-29 18:59:15 UTC (rev 93998) @@ -362,7 +362,6 @@ __ZN7WebCore14FrameSelection9selectAllEv __ZN7WebCore14FrameSelectionC1EPNS_5FrameE __ZN7WebCore14ResourceHandle20forceContentSniffingEv -__ZN7WebCore14ResourceHandle24setDefaultStorageSessionEP21__CFURLStorageSession __ZN7WebCore14ResourceHandle26synchronousLoadRunLoopModeEv __ZN7WebCore14ResourceHandle35createPrivateBrowsingStorageSessionEPK10__CFString __ZN7WebCore14ResourceLoader14cancelledErrorEv @@ -1912,6 +1911,12 @@ __ZN7WebCore14ResourceHandle12releaseProxyEv #endif +#if USE(CFURLSTORAGESESSIONS) && (defined(BUILDING_ON_SNOW_LEOPARD) || defined(BUILDING_ON_LEOPARD)) +__ZN7WebCore14ResourceHandle24setDefaultStorageSessionEP21__CFURLStorageSession +#else +__ZN7WebCore14ResourceHandle24setDefaultStorageSessionEPK21__CFURLStorageSession +#endif + #if ENABLE(INPUT_COLOR) __ZN7WebCore12ColorChooser7chooserEv __ZNK7WebCore12ColorChooser13colorSelectedERKNS_5ColorE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93996] trunk
Title: [93996] trunk
Revision 93996
Author t...@chromium.org
Date 2011-08-29 11:53:54 -0700 (Mon, 29 Aug 2011)
Log Message
Implement -webkit-flex-pack for horizontal flexboxen
https://bugs.webkit.org/show_bug.cgi?id=66898
Reviewed by Ojan Vafai.
Source/WebCore:
Test: css3/flexbox/004.html
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::hasPackingSpace):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmHorizontal):
LayoutTests:
* css3/flexbox/004-expected.txt: Added.
* css3/flexbox/004.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
Added Paths
trunk/LayoutTests/css3/flexbox/004-expected.txt
trunk/LayoutTests/css3/flexbox/004.html
Diff
Modified: trunk/LayoutTests/ChangeLog (93995 => 93996)
--- trunk/LayoutTests/ChangeLog 2011-08-29 18:46:30 UTC (rev 93995)
+++ trunk/LayoutTests/ChangeLog 2011-08-29 18:53:54 UTC (rev 93996)
@@ -1,3 +1,13 @@
+2011-08-29 Tony Chang
+
+Implement -webkit-flex-pack for horizontal flexboxen
+https://bugs.webkit.org/show_bug.cgi?id=66898
+
+Reviewed by Ojan Vafai.
+
+* css3/flexbox/004-expected.txt: Added.
+* css3/flexbox/004.html: Added.
+
2011-08-29 Sam Weinig
Update tests after landing Event constructors.
Added: trunk/LayoutTests/css3/flexbox/004-expected.txt (0 => 93996)
--- trunk/LayoutTests/css3/flexbox/004-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/flexbox/004-expected.txt 2011-08-29 18:53:54 UTC (rev 93996)
@@ -0,0 +1,8 @@
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
+
Property changes on: trunk/LayoutTests/css3/flexbox/004-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/css3/flexbox/004.html (0 => 93996)
--- trunk/LayoutTests/css3/flexbox/004.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/004.html 2011-08-29 18:53:54 UTC (rev 93996)
@@ -0,0 +1,78 @@
+
+
+
+body {
+margin: 0;
+}
+.horizontal-box {
+width: 600px;
+display: -webkit-flexbox;
+background-color: #aaa;
+position: relative;
+}
+.horizontal-box div {
+height: 20px;
+border: 0;
+}
+
+.horizontal-box :nth-child(1) {
+background-color: blue;
+}
+.horizontal-box :nth-child(2) {
+background-color: green;
+}
+.horizontal-box :nth-child(3) {
+background-color: red;
+}
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
[webkit-changes] [93994] trunk/LayoutTests
Title: [93994] trunk/LayoutTests
Revision 93994
Author wei...@apple.com
Date 2011-08-29 11:46:28 -0700 (Mon, 29 Aug 2011)
Log Message
Update tests after landing Event constructors.
Reviewed by Anders Carlsson.
* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt
trunk/LayoutTests/fast/dom/dom-constructors-expected.txt
trunk/LayoutTests/fast/dom/dom-constructors.html
Diff
Modified: trunk/LayoutTests/ChangeLog (93993 => 93994)
--- trunk/LayoutTests/ChangeLog 2011-08-29 18:45:22 UTC (rev 93993)
+++ trunk/LayoutTests/ChangeLog 2011-08-29 18:46:28 UTC (rev 93994)
@@ -1,3 +1,13 @@
+2011-08-29 Sam Weinig
+
+Update tests after landing Event constructors.
+
+Reviewed by Anders Carlsson.
+
+* fast/dom/constructed-objects-prototypes-expected.txt:
+* fast/dom/dom-constructors-expected.txt:
+* fast/dom/dom-constructors.html:
+
2011-08-29 Stephen White
Unreviewed gardening.
Modified: trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt (93993 => 93994)
--- trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2011-08-29 18:45:22 UTC (rev 93993)
+++ trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2011-08-29 18:46:28 UTC (rev 93994)
@@ -7,6 +7,8 @@
PASS (new inner.Audio()).constructor.isInner is true
PASS (new inner.DOMParser()).isInner is true
PASS (new inner.DOMParser()).constructor.isInner is true
+PASS (new inner.Event()).isInner is true
+PASS (new inner.Event()).constructor.isInner is true
PASS (new inner.FormData()).isInner is true
PASS (new inner.FormData()).constructor.isInner is true
PASS (new inner.Image()).isInner is true
Modified: trunk/LayoutTests/fast/dom/dom-constructors-expected.txt (93993 => 93994)
--- trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2011-08-29 18:45:22 UTC (rev 93993)
+++ trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2011-08-29 18:46:28 UTC (rev 93994)
@@ -93,7 +93,6 @@
PASS TryAllocate('CSSValue') is 'exception'
PASS TryAllocate('CSSValueList') is 'exception'
PASS TryAllocate('DOMImplementation') is 'exception'
-PASS TryAllocate('Event') is 'exception'
PASS TryAllocate('HTMLCollection') is 'exception'
PASS TryAllocate('KeyboardEvent') is 'exception'
PASS TryAllocate('MediaList') is 'exception'
Modified: trunk/LayoutTests/fast/dom/dom-constructors.html (93993 => 93994)
--- trunk/LayoutTests/fast/dom/dom-constructors.html 2011-08-29 18:45:22 UTC (rev 93993)
+++ trunk/LayoutTests/fast/dom/dom-constructors.html 2011-08-29 18:46:28 UTC (rev 93994)
@@ -44,7 +44,7 @@
'CSSImportRule', 'CSSMediaRule', 'CSSPageRule',
'CSSPrimitiveValue', 'CSSRule', 'CSSRuleList',
'CSSStyleDeclaration', 'CSSStyleRule', 'CSSStyleSheet',
-'CSSValue', 'CSSValueList', 'DOMImplementation', 'Event',
+'CSSValue', 'CSSValueList', 'DOMImplementation',
'HTMLCollection', 'KeyboardEvent', 'MediaList', 'MimeType',
'MimeTypeArray', 'MouseEvent', 'MutationEvent', 'NamedNodeMap',
'NodeFilter', 'NodeList', 'OverflowEvent', 'Plugin',
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93995] trunk/Source/WebCore
Title: [93995] trunk/Source/WebCore
Revision 93995
Author a...@apple.com
Date 2011-08-29 11:46:30 -0700 (Mon, 29 Aug 2011)
Log Message
Windows build fix.
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
Updated for new function name and signature: currentCFHTTPCookieStorage().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (93994 => 93995)
--- trunk/Source/WebCore/ChangeLog 2011-08-29 18:46:28 UTC (rev 93994)
+++ trunk/Source/WebCore/ChangeLog 2011-08-29 18:46:30 UTC (rev 93995)
@@ -1,5 +1,21 @@
2011-08-29 Alexey Proskuryakov
+Windows build fix.
+
+* platform/network/cf/CookieJarCFNet.cpp:
+(WebCore::setCookies):
+(WebCore::cookies):
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::cookiesEnabled):
+(WebCore::getRawCookies):
+(WebCore::deleteCookie):
+(WebCore::getHostnamesWithCookies):
+(WebCore::deleteCookiesForHostname):
+(WebCore::deleteAllCookies):
+Updated for new function name and signature: currentCFHTTPCookieStorage().
+
+2011-08-29 Alexey Proskuryakov
+
Mac build fix.
* platform/network/cf/CookieStorageCFNet.cpp: Move Windows specific includes into PLATFORM(WIN).
Modified: trunk/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp (93994 => 93995)
--- trunk/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2011-08-29 18:46:28 UTC (rev 93994)
+++ trunk/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2011-08-29 18:46:30 UTC (rev 93995)
@@ -127,7 +127,7 @@
if (value.isEmpty())
return;
-CFHTTPCookieStorageRef cookieStorage = currentCookieStorage();
+RetainPtr cookieStorage = currentCFHTTPCookieStorage();
if (!cookieStorage)
return;
@@ -146,33 +146,33 @@
RetainPtr cookiesCF(AdoptCF, CFHTTPCookieCreateWithResponseHeaderFields(kCFAllocatorDefault,
headerFieldsCF.get(), urlCF.get()));
-CFHTTPCookieStorageSetCookies(cookieStorage, filterCookies(cookiesCF.get()).get(), urlCF.get(), firstPartyForCookiesCF.get());
+CFHTTPCookieStorageSetCookies(cookieStorage.get(), filterCookies(cookiesCF.get()).get(), urlCF.get(), firstPartyForCookiesCF.get());
}
String cookies(const Document* /*document*/, const KURL& url)
{
-CFHTTPCookieStorageRef cookieStorage = currentCookieStorage();
+RetainPtr cookieStorage = currentCFHTTPCookieStorage();
if (!cookieStorage)
return String();
RetainPtr urlCF(AdoptCF, url.createCFURL());
bool secure = url.protocolIs("https");
-RetainPtr cookiesCF(AdoptCF, CFHTTPCookieStorageCopyCookiesForURL(cookieStorage, urlCF.get(), secure));
+RetainPtr cookiesCF(AdoptCF, CFHTTPCookieStorageCopyCookiesForURL(cookieStorage.get(), urlCF.get(), secure));
RetainPtr headerCF(AdoptCF, CFHTTPCookieCopyRequestHeaderFields(kCFAllocatorDefault, filterCookies(cookiesCF.get()).get()));
return (CFStringRef)CFDictionaryGetValue(headerCF.get(), s_cookieCF);
}
String cookieRequestHeaderFieldValue(const Document* /*document*/, const KURL& url)
{
-CFHTTPCookieStorageRef cookieStorage = currentCookieStorage();
+RetainPtr cookieStorage = currentCFHTTPCookieStorage();
if (!cookieStorage)
return String();
RetainPtr urlCF(AdoptCF, url.createCFURL());
bool secure = url.protocolIs("https");
-RetainPtr cookiesCF(AdoptCF, CFHTTPCookieStorageCopyCookiesForURL(cookieStorage, urlCF.get(), secure));
+RetainPtr cookiesCF(AdoptCF, CFHTTPCookieStorageCopyCookiesForURL(cookieStorage.get(), urlCF.get(), secure));
RetainPtr headerCF(AdoptCF, CFHTTPCookieCopyRequestHeaderFields(kCFAllocatorDefault, cookiesCF.get()));
return (CFStringRef)CFDictionaryGetValue(headerCF.get(), s_cookieCF);
}
@@ -180,22 +180,22 @@
bool cookiesEnabled(const Document* /*document*/)
{
CFHTTPCookieStorageAcceptPolicy policy = CFHTTPCookieStorageAcceptPolicyOnlyFromMainDocumentDomain;
-if (CFHTTPCookieStorageRef cookieStorage = currentCookieStorage())
-policy = CFHTTPCookieStorageGetCookieAcceptPolicy(cookieStorage);
+if (RetainPtr cookieStorage = currentCFHTTPCookieStorage())
+policy = CFHTTPCookieStorageGetCookieAcceptPolicy(cookieStorage.get());
return policy == CFHTTPCookieStorageAcceptPolicyOnlyFromMainDocumentDomain || policy == CFHTTPCookieStorageAcceptPolicyAlways;
}
bool getRawCookies(const Document*, const KURL& url, Vector& rawCookies)
{
rawCookies.clear();
-CFHTTPCookieStorageRef cookieStorage = currentCookieStora
[webkit-changes] [93993] trunk/LayoutTests
Title: [93993] trunk/LayoutTests Revision 93993 Author senorbla...@chromium.org Date 2011-08-29 11:45:22 -0700 (Mon, 29 Aug 2011) Log Message Unreviewed gardening. Mark test fast/canvas/setWidthResetAfterForcedRender.html as failing after r93988. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (93992 => 93993) --- trunk/LayoutTests/ChangeLog 2011-08-29 18:34:21 UTC (rev 93992) +++ trunk/LayoutTests/ChangeLog 2011-08-29 18:45:22 UTC (rev 93993) @@ -1,3 +1,12 @@ +2011-08-29 Stephen White + +Unreviewed gardening. + +Mark test fast/canvas/setWidthResetAfterForcedRender.html as failing +after r93988. + +* platform/chromium/test_expectations.txt: + 2011-08-29 David Levin Temporary suppression for new test added in r93982. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93992 => 93993) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-29 18:34:21 UTC (rev 93992) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-29 18:45:22 UTC (rev 93993) @@ -3677,3 +3677,6 @@ // Failing after r93982. BUG_LEVIN MAC : canvas/philip/tests/2d.path.stroke.prune.arc.html = TEXT + +// Failing after r93988. +BUGWK67144 GPU WIN LINUX : fast/canvas/setWidthResetAfterForcedRender.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93992] trunk/Source/WebCore
Title: [93992] trunk/Source/WebCore Revision 93992 Author a...@apple.com Date 2011-08-29 11:34:21 -0700 (Mon, 29 Aug 2011) Log Message Mac build fix. * platform/network/cf/CookieStorageCFNet.cpp: Move Windows specific includes into PLATFORM(WIN). Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (93991 => 93992) --- trunk/Source/WebCore/ChangeLog 2011-08-29 18:31:27 UTC (rev 93991) +++ trunk/Source/WebCore/ChangeLog 2011-08-29 18:34:21 UTC (rev 93992) @@ -1,3 +1,9 @@ +2011-08-29 Alexey Proskuryakov + +Mac build fix. + +* platform/network/cf/CookieStorageCFNet.cpp: Move Windows specific includes into PLATFORM(WIN). + 2011-08-29 Andreas Kling Viewing a post on reddit.com wastes a lot of memory on event listeners. Modified: trunk/Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp (93991 => 93992) --- trunk/Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp 2011-08-29 18:31:27 UTC (rev 93991) +++ trunk/Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp 2011-08-29 18:34:21 UTC (rev 93992) @@ -30,14 +30,14 @@ #if USE(CFNETWORK) || USE(CFURLSTORAGESESSIONS) -#include "LoaderRunLoopCF.h" #include "ResourceHandle.h" -#include #include #if PLATFORM(MAC) #include "WebCoreSystemInterface.h" #elif PLATFORM(WIN) +#include "LoaderRunLoopCF.h" +#include #include #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93991] trunk/Source/JavaScriptCore
Title: [93991] trunk/Source/_javascript_Core
Revision 93991
Author andreas.kl...@nokia.com
Date 2011-08-29 11:31:27 -0700 (Mon, 29 Aug 2011)
Log Message
Unreviewed build fix after r93990.
* wtf/HashTable.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/HashTable.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (93990 => 93991)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-29 18:24:18 UTC (rev 93990)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-29 18:31:27 UTC (rev 93991)
@@ -1,5 +1,11 @@
2011-08-29 Andreas Kling
+Unreviewed build fix after r93990.
+
+* wtf/HashTable.h:
+
+2011-08-29 Andreas Kling
+
Viewing a post on reddit.com wastes a lot of memory on event listeners.
https://bugs.webkit.org/show_bug.cgi?id=67133
Modified: trunk/Source/_javascript_Core/wtf/HashTable.h (93990 => 93991)
--- trunk/Source/_javascript_Core/wtf/HashTable.h 2011-08-29 18:24:18 UTC (rev 93990)
+++ trunk/Source/_javascript_Core/wtf/HashTable.h 2011-08-29 18:31:27 UTC (rev 93991)
@@ -396,7 +396,7 @@
const_iterator makeKnownGoodConstIterator(ValueType* pos) const { return const_iterator(this, pos, m_table + m_tableSize, HashItemKnownGood); }
#if !ASSERT_DISABLED
-void checkTableConsistenmcyExceptSize() const;
+void checkTableConsistencyExceptSize() const;
#else
static void checkTableConsistencyExceptSize() { }
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93990] trunk/Source
Title: [93990] trunk/Source
Revision 93990
Author andreas.kl...@nokia.com
Date 2011-08-29 11:24:18 -0700 (Mon, 29 Aug 2011)
Log Message
Viewing a post on reddit.com wastes a lot of memory on event listeners.
https://bugs.webkit.org/show_bug.cgi?id=67133
Reviewed by Darin Adler.
Source/_javascript_Core:
Add a minimum table size to the HashTraits, instead of having it hard coded.
The default value remains at 64, but can now be specialized.
* runtime/StructureTransitionTable.h:
* wtf/HashTable.h:
(WTF::HashTable::shouldShrink):
(WTFexpand):
(WTFcheckTableConsistencyExceptSize):
* wtf/HashTraits.h:
Source/WebCore:
Specialize the HashMap used to store registered listeners on an EventTarget
to have a minimum size of 32 (rather than the default 64.)
It's very rare for pages to register listeners for so many different events
and this cuts memory consumption in half for the common case.
As an example, for a typical post on the reddit.com front page,
this reduces memory used by ~700kB on 64-bit.
* dom/EventTarget.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/StructureTransitionTable.h
trunk/Source/_javascript_Core/wtf/HashTable.h
trunk/Source/_javascript_Core/wtf/HashTraits.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventTarget.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (93989 => 93990)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-29 18:22:44 UTC (rev 93989)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-29 18:24:18 UTC (rev 93990)
@@ -1,3 +1,20 @@
+2011-08-29 Andreas Kling
+
+Viewing a post on reddit.com wastes a lot of memory on event listeners.
+https://bugs.webkit.org/show_bug.cgi?id=67133
+
+Reviewed by Darin Adler.
+
+Add a minimum table size to the HashTraits, instead of having it hard coded.
+The default value remains at 64, but can now be specialized.
+
+* runtime/StructureTransitionTable.h:
+* wtf/HashTable.h:
+(WTF::HashTable::shouldShrink):
+(WTFexpand):
+(WTFcheckTableConsistencyExceptSize):
+* wtf/HashTraits.h:
+
2011-08-28 Jonathan Liu
Fix build error when compiling with MinGW-w64 by disabling JIT
Modified: trunk/Source/_javascript_Core/runtime/StructureTransitionTable.h (93989 => 93990)
--- trunk/Source/_javascript_Core/runtime/StructureTransitionTable.h 2011-08-29 18:22:44 UTC (rev 93989)
+++ trunk/Source/_javascript_Core/runtime/StructureTransitionTable.h 2011-08-29 18:24:18 UTC (rev 93990)
@@ -65,6 +65,8 @@
static const bool needsDestruction = FirstTraits::needsDestruction || SecondTraits::needsDestruction;
+static const int minimumTableSize = FirstTraits::minimumTableSize;
+
static void constructDeletedValue(TraitType& slot) { FirstTraits::constructDeletedValue(slot.first); }
static bool isDeletedValue(const TraitType& value) { return FirstTraits::isDeletedValue(value.first); }
};
Modified: trunk/Source/_javascript_Core/wtf/HashTable.h (93989 => 93990)
--- trunk/Source/_javascript_Core/wtf/HashTable.h 2011-08-29 18:22:44 UTC (rev 93989)
+++ trunk/Source/_javascript_Core/wtf/HashTable.h 2011-08-29 18:24:18 UTC (rev 93990)
@@ -377,7 +377,7 @@
bool shouldExpand() const { return (m_keyCount + m_deletedCount) * m_maxLoad >= m_tableSize; }
bool mustRehashInPlace() const { return m_keyCount * m_minLoad < m_tableSize * 2; }
-bool shouldShrink() const { return m_keyCount * m_minLoad < m_tableSize && m_tableSize > m_minTableSize; }
+bool shouldShrink() const { return m_keyCount * m_minLoad < m_tableSize && m_tableSize > KeyTraits::minimumTableSize; }
void expand();
void shrink() { rehash(m_tableSize / 2); }
@@ -396,7 +396,7 @@
const_iterator makeKnownGoodConstIterator(ValueType* pos) const { return const_iterator(this, pos, m_table + m_tableSize, HashItemKnownGood); }
#if !ASSERT_DISABLED
-void checkTableConsistencyExceptSize() const;
+void checkTableConsistenmcyExceptSize() const;
#else
static void checkTableConsistencyExceptSize() { }
#endif
@@ -407,7 +407,6 @@
static void invalidateIterators() { }
#endif
-static const int m_minTableSize = 64;
static const int m_maxLoad = 2;
static const int m_minLoad = 6;
@@ -901,7 +900,7 @@
{
int newSize;
if (m_tableSize == 0)
-newSize = m_minTableSize;
+newSize = KeyTraits::minimumTableSize;
else if (mustRehashInPlace())
newSize = m_tableSize;
else
@@ -1039,7 +1038,7 @@
ASSERT(count == m_keyCount);
ASSERT(deletedCount == m_deletedCount);
-ASSERT(m_tableSize >= m_minTableSize);
+ASSERT(m_tableSize >= KeyTraits::minimumTableSize);
ASSERT(m_tableSizeMask);
ASSERT(m_tableSize == m_tableSizeMask + 1);
}
Modified: trunk
[webkit-changes] [93989] trunk/LayoutTests
Title: [93989] trunk/LayoutTests Revision 93989 Author le...@chromium.org Date 2011-08-29 11:22:44 -0700 (Mon, 29 Aug 2011) Log Message Temporary suppression for new test added in r93982. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (93988 => 93989) --- trunk/LayoutTests/ChangeLog 2011-08-29 18:16:32 UTC (rev 93988) +++ trunk/LayoutTests/ChangeLog 2011-08-29 18:22:44 UTC (rev 93989) @@ -1,3 +1,9 @@ +2011-08-29 David Levin + +Temporary suppression for new test added in r93982. + +* platform/chromium/test_expectations.txt: + 2011-08-22 David Levin postMessage raises INVALID_STATE_ERR instead of DATA_CLONE_ERR in many cases. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (93988 => 93989) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-29 18:16:32 UTC (rev 93988) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-29 18:22:44 UTC (rev 93989) @@ -3674,3 +3674,6 @@ // Started to fail on all bots after r93951. BUGWK63878 : fast/dom/dom-constructors.html = TEXT + +// Failing after r93982. +BUG_LEVIN MAC : canvas/philip/tests/2d.path.stroke.prune.arc.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93988] trunk/Source/WebCore
Title: [93988] trunk/Source/WebCore Revision 93988 Author senorbla...@chromium.org Date 2011-08-29 11:16:32 -0700 (Mon, 29 Aug 2011) Log Message Skia's accelerated canvas 2D implementation should use GrTexture, not DrawingBuffer https://bugs.webkit.org/show_bug.cgi?id=67050 Reviewed by Kenneth Russell. Covered by existing tests. * platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::create): (WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium): (WebCore::Canvas2DLayerChromium::drawsContent): Construct Canvas2DLayerChromium with a GraphicsContext3D, not a DrawingBuffer. (WebCore::Canvas2DLayerChromium::updateCompositorResources): Flush the GrContext and GraphicsContext3D on compositor update. * platform/graphics/chromium/Canvas2DLayerChromium.h: * platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::CanvasLayerChromium): * platform/graphics/chromium/CanvasLayerChromium.h: Put textureId() back on the base class (CanvasLayerChromium) and de-virtualize it. (WebCore::CanvasLayerChromium::textureId): (WebCore::CanvasLayerChromium::setTextureId): Move m_textureId from WebGLLayerChromium, since canvas2D now uses it too. Provide getters and setters. * platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): Remove all Canvas2D-related calls from DrawingBuffer. (WebCore::DrawingBuffer::publishToPlatformLayer): Remove GrContext::flush call, since it's now handled by the platform layer. (WebCore::DrawingBuffer::platformLayer): Return NULL for now (WebGL may rescussitate this later). * platform/graphics/chromium/GraphicsLayerChromium.cpp: Remove a useless #include. * platform/graphics/chromium/ImageBufferDataSkia.h: Add ownership of the Canvas2DLayerChromium. * platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::WebGLLayerChromium): * platform/graphics/chromium/WebGLLayerChromium.h: Remove all texture ID stuff (now on base class). * platform/graphics/gpu/DrawingBuffer.h: Remove Canvas2DLayerChromium and all Ganesh datatypes from DrawingBuffer, since it's no longer used by canvas2D. * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer): On accelerated ImageBuffer creation, create a GrTexture instead of a DrawingBuffer. If all is cool, create and set the SkGpuDevice here, and create a Canvas2DLayerChromium platform layer. (WebCore::ImageBuffer::platformLayer): * platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setGraphicsContext3D): * platform/graphics/skia/PlatformContextSkia.h: Remove all GrContext creation and DrawingBuffer "scraping" from PlatformContextSkia::setGraphicsContext3D(). This is handled in the ImageBuffer constructor instead. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/ImageBufferDataSkia.h trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.h trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.h trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h Diff Modified: trunk/Source/WebCore/ChangeLog (93987 => 93988) --- trunk/Source/WebCore/ChangeLog 2011-08-29 18:15:38 UTC (rev 93987) +++ trunk/Source/WebCore/ChangeLog 2011-08-29 18:16:32 UTC (rev 93988) @@ -1,3 +1,62 @@ +2011-08-29 Stephen White + +Skia's accelerated canvas 2D implementation should use GrTexture, not DrawingBuffer +https://bugs.webkit.org/show_bug.cgi?id=67050 + +Reviewed by Kenneth Russell. + +Covered by existing tests. + +* platform/graphics/chromium/Canvas2DLayerChromium.cpp: +(WebCore::Canvas2DLayerChromium::create): +(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium): +(WebCore::Canvas2DLayerChromium::drawsContent): +Construct Canvas2DLayerChromium with a GraphicsContext3D, not a +DrawingBuffer. +(WebCore::Canvas2DLayerChromium::updateCompositorResources): +Flush the GrContext and GraphicsContext3D on compositor update. +* platform/graphics/chromium/Canvas2DLayerChromium.h: +* platform/graphics/chromium/CanvasLayerChromium.cpp: +(WebCore::CanvasLayerChromium::CanvasLayerChromium): +* platform/graphics/chromium/CanvasLayerChromium.h: +
[webkit-changes] [93986] trunk
Title: [93986] trunk
Revision 93986
Author le...@chromium.org
Date 2011-08-29 10:57:55 -0700 (Mon, 29 Aug 2011)
Log Message
postMessage raises INVALID_STATE_ERR instead of DATA_CLONE_ERR in many cases.
https://bugs.webkit.org/show_bug.cgi?id=66713
Reviewed by Dmitry Titov.
Source/WebCore:
See http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#posting-messages for postMessage
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::getMessagePortArray):
* dom/MessagePort.cpp:
(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::disentanglePorts):
LayoutTests:
* fast/events/message-port-clone-expected.txt: Output changed from INVALID_STATE_ERR to DATA_CLONE_ERR.
* fast/events/message-port-multi-expected.txt: Ditto.
* fast/workers/worker-context-multi-port-expected.txt: Ditto.
* fast/workers/worker-multi-port-expected.txt: Ditto.
* platform/chromium-win/fast/events/message-port-multi-expected.txt: Ditto.
* platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt: Ditto.
* platform/chromium-win/fast/workers/worker-multi-port-expected.txt: Ditto.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/message-port-clone-expected.txt
trunk/LayoutTests/fast/events/message-port-multi-expected.txt
trunk/LayoutTests/fast/workers/worker-context-multi-port-expected.txt
trunk/LayoutTests/fast/workers/worker-multi-port-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/events/message-port-multi-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/workers/worker-multi-port-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSMessagePortCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp
trunk/Source/WebCore/dom/MessagePort.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (93985 => 93986)
--- trunk/LayoutTests/ChangeLog 2011-08-29 17:37:48 UTC (rev 93985)
+++ trunk/LayoutTests/ChangeLog 2011-08-29 17:57:55 UTC (rev 93986)
@@ -1,3 +1,18 @@
+2011-08-22 David Levin
+
+postMessage raises INVALID_STATE_ERR instead of DATA_CLONE_ERR in many cases.
+https://bugs.webkit.org/show_bug.cgi?id=66713
+
+Reviewed by Dmitry Titov.
+
+* fast/events/message-port-clone-expected.txt: Output changed from INVALID_STATE_ERR to DATA_CLONE_ERR.
+* fast/events/message-port-multi-expected.txt: Ditto.
+* fast/workers/worker-context-multi-port-expected.txt: Ditto.
+* fast/workers/worker-multi-port-expected.txt: Ditto.
+* platform/chromium-win/fast/events/message-port-multi-expected.txt: Ditto.
+* platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt: Ditto.
+* platform/chromium-win/fast/workers/worker-multi-port-expected.txt: Ditto.
+
2011-08-29 Julien Chaffraix
Assertion failure in WebCore::RenderFlow::rightmostPosition
Modified: trunk/LayoutTests/fast/events/message-port-clone-expected.txt (93985 => 93986)
--- trunk/LayoutTests/fast/events/message-port-clone-expected.txt 2011-08-29 17:37:48 UTC (rev 93985)
+++ trunk/LayoutTests/fast/events/message-port-clone-expected.txt 2011-08-29 17:57:55 UTC (rev 93986)
@@ -2,8 +2,8 @@
Should be a series of SUCCESS messages, followed with DONE.
-SUCCESS: Posting port to itself: Error: INVALID_STATE_ERR: DOM Exception 11
-SUCCESS: Posting entangled port: Error: INVALID_STATE_ERR: DOM Exception 11
+SUCCESS: Posting port to itself: Error: DATA_CLONE_ERR: DOM Exception 25
+SUCCESS: Posting entangled port: Error: DATA_CLONE_ERR: DOM Exception 25
SUCCESS: Posting cloned port.
SUCCESS: Posted messages to cloned port.
SUCCESS: Cloned both endpoints of a channel.
Modified: trunk/LayoutTests/fast/events/message-port-multi-expected.txt (93985 => 93986)
--- trunk/LayoutTests/fast/events/message-port-multi-expected.txt 2011-08-29 17:37:48 UTC (rev 93985)
+++ trunk/LayoutTests/fast/events/message-port-multi-expected.txt 2011-08-29 17:57:55 UTC (rev 93986)
@@ -3,13 +3,13 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS channel.port1.postMessage("same port", [channel.port1]) threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
-PASS channel.port1.postMessage("entangled port", [channel.port2]) threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
-PASS channel.port1.postMessage("null port", [channel3.port1, null, channel3.port2]) threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
+PASS channel.port1.postMessage("same port", [channel.port1]) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
+PASS channel.port1.postMessage("entangled port", [channel.port2]) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
+PASS channel.port1.postMessage("null port", [channel3.port1, null, channel3.port2]) threw exception Error:
[webkit-changes] [93981] trunk/Source/WebKit2
Title: [93981] trunk/Source/WebKit2
Revision 93981
Author cmar...@apple.com
Date 2011-08-29 10:12:55 -0700 (Mon, 29 Aug 2011)
Log Message
2011-08-29 Chris Marrin
Fixed a build problem caused by http://trac.webkit.org/changeset/93980
Unreviewed.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (93980 => 93981)
--- trunk/Source/WebKit2/ChangeLog 2011-08-29 16:38:56 UTC (rev 93980)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-29 17:12:55 UTC (rev 93981)
@@ -1,3 +1,11 @@
+2011-08-29 Chris Marrin
+
+Fixed a build problem caused by http://trac.webkit.org/changeset/93980
+
+Unreviewed.
+
+* WebProcess/WebCoreSupport/WebChromeClient.cpp:
+
2011-08-23 Chris Marrin
[mac] requestAnimationFrame support for mac port
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (93980 => 93981)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2011-08-29 16:38:56 UTC (rev 93980)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp 2011-08-29 17:12:55 UTC (rev 93981)
@@ -654,10 +654,12 @@
m_page->send(Messages::WebPageProxy::SetCursorHiddenUntilMouseMoves(hiddenUntilMouseMoves));
}
+#if ENABLE(REQUEST_ANIMATION_FRAME)
void WebChromeClient::scheduleAnimation()
{
m_page->scheduleAnimation();
}
+#endif
void WebChromeClient::formStateDidChange(const Node*)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93983] trunk/LayoutTests
Title: [93983] trunk/LayoutTests
Revision 93983
Author podivi...@chromium.org
Date 2011-08-29 10:30:38 -0700 (Mon, 29 Aug 2011)
Log Message
2011-08-29 Pavel Podivilov
Unreviewed, rebaseline inspector/styles/styles-computed-trace.html in chromium.
* platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-win/inspector/styles/
trunk/LayoutTests/platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (93982 => 93983)
--- trunk/LayoutTests/ChangeLog 2011-08-29 17:14:57 UTC (rev 93982)
+++ trunk/LayoutTests/ChangeLog 2011-08-29 17:30:38 UTC (rev 93983)
@@ -1,3 +1,9 @@
+2011-08-29 Pavel Podivilov
+
+Unreviewed, rebaseline inspector/styles/styles-computed-trace.html in chromium.
+
+* platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt: Added.
+
2011-08-29 Tom Zakrajsek
canvas arc() missing line to start of arc if swing is zero
Added: trunk/LayoutTests/platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt (0 => 93983)
--- trunk/LayoutTests/platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-win/inspector/styles/styles-computed-trace-expected.txt 2011-08-29 17:30:38 UTC (rev 93983)
@@ -0,0 +1,140 @@
+Tests that computed styles expand and allow tracing to style rules.
+
+ Computed style for ID1
+[expanded] ()
+background-attachment: scroll;
+#id1 - initial styles-computed-trace.html:23
+background-clip: border-box;
+#id1 - initial styles-computed-trace.html:23
+background-color: gray;
+#id1 - gray styles-computed-trace.html:23
+/-- overloaded --/ #id1 - black styles-computed-trace.html:18
+/-- overloaded --/ #id1 - green styles-computed-trace.html:13
+background-image: none;
+#id1 - initial styles-computed-trace.html:23
+background-origin: padding-box;
+#id1 - initial styles-computed-trace.html:23
+display: block;
+div - block user agent stylesheet
+font-family: Courier;
+#id1 - Courier styles-computed-trace.html:18
+/-- overloaded --/ #id1 - Times styles-computed-trace.html:13
+/-- overloaded --/ body - Arial styles-computed-trace.html:4
+text-decoration: underline;
+div - underline styles-computed-trace.html:9
+
+[expanded] element.style { ()
+
+
+ Computed style for ID2
+[expanded] ()
+background-color: blue;
+#id2 - blue styles-computed-trace.html:27
+display: block;
+div - block user agent stylesheet
+font-family: Courier;
+#id2 - Courier styles-computed-trace.html:27
+/-- overloaded --/ #id1 - Courier styles-computed-trace.html:18
+/-- overloaded --/ #id1 - Times styles-computed-trace.html:13
+/-- overloaded --/ body - Arial styles-computed-trace.html:4
+text-decoration: underline;
+/-- overloaded --/ #id2 - invalidvalue styles-computed-trace.html:27
+div - underline styles-computed-trace.html:9
+
+[expanded] element.style { ()
+
+
+ Computed style for ID3
+[expanded] ()
+-webkit-appearance: button;
+button - button user agent stylesheet
+-webkit-box-align: center;
+input[type="button"], input[type="submit"], input[type="reset"], input[type="file"] ::-webkit-file-upload-button, button - center user agent stylesheet
+background-color: silver;
+input[type="button"], input[type="submit"], input[type="reset"], input[type="file"] ::-webkit-file-upload-button, button - buttonface user agent stylesheet
+border-bottom-color: silver;
+input[type="button"], input[type="submit"], input[type="reset"], input[type="file"] ::-webkit-file-upload-button, button - buttonface user agent stylesheet
+border-bottom-style: outset;
+input[type="button"], input[type="submit"], input[type="reset"], input[type="file"] ::-webkit-file-upload-button, button - outset user agent stylesheet
+border-bottom-width: 2px;
+input[type="button"], input[type="submit"], input[type="reset"], input[type="file"] ::-webkit-file-upload-button, button - 2px user agent stylesheet
+border-left-color: silver;
+input[type="button"], input[type="submit"], input[type="reset"], input[type="file"] ::-webkit-file-upload-button, button - buttonface user agent stylesheet
+border-left-style: outset;
+input[type="button"], input[type="submit"], input[type="reset"], input[type="file"] ::-webkit-file-upload-button, button - outset user agent stylesheet
+border-left-width: 2px;
+input[type="button"], input[type="submit"], input[type="reset"], input[type="file"] ::-webkit-file-upload-button, button - 2px user agent stylesheet
+border-right-color: silver;
+input[type="button"], input[type="submit"], input[type="reset"], input[type="file"] ::-webkit-file-upload-button, button - buttonface user agent stylesheet
+border-right-style: outset;
+
[webkit-changes] [93984] trunk/LayoutTests
Title: [93984] trunk/LayoutTests
Revision 93984
Author jchaffr...@webkit.org
Date 2011-08-29 10:31:52 -0700 (Mon, 29 Aug 2011)
Log Message
Assertion failure in WebCore::RenderFlow::rightmostPosition
https://bugs.webkit.org/show_bug.cgi?id=12085
Reviewed by Alexey Proskuryakov.
The bug got solved. Landed the test to avoid regressing.
* fast/css/assert-marquee-not-last-element-expected.txt: Added.
* fast/css/assert-marquee-not-last-element.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/css/assert-marquee-not-last-element-expected.txt
trunk/LayoutTests/fast/css/assert-marquee-not-last-element.html
Diff
Modified: trunk/LayoutTests/ChangeLog (93983 => 93984)
--- trunk/LayoutTests/ChangeLog 2011-08-29 17:30:38 UTC (rev 93983)
+++ trunk/LayoutTests/ChangeLog 2011-08-29 17:31:52 UTC (rev 93984)
@@ -1,3 +1,15 @@
+2011-08-29 Julien Chaffraix
+
+Assertion failure in WebCore::RenderFlow::rightmostPosition
+https://bugs.webkit.org/show_bug.cgi?id=12085
+
+Reviewed by Alexey Proskuryakov.
+
+The bug got solved. Landed the test to avoid regressing.
+
+* fast/css/assert-marquee-not-last-element-expected.txt: Added.
+* fast/css/assert-marquee-not-last-element.html: Added.
+
2011-08-29 Pavel Podivilov
Unreviewed, rebaseline inspector/styles/styles-computed-trace.html in chromium.
Added: trunk/LayoutTests/fast/css/assert-marquee-not-last-element-expected.txt (0 => 93984)
--- trunk/LayoutTests/fast/css/assert-marquee-not-last-element-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/assert-marquee-not-last-element-expected.txt 2011-08-29 17:31:52 UTC (rev 93984)
@@ -0,0 +1,4 @@
+Bug 12085: Assertion failure in WebCore::RenderFlow::rightmostPosition
+
+marquee
+If this test does not ASSERT, it has PASSED
Added: trunk/LayoutTests/fast/css/assert-marquee-not-last-element.html (0 => 93984)
--- trunk/LayoutTests/fast/css/assert-marquee-not-last-element.html (rev 0)
+++ trunk/LayoutTests/fast/css/assert-marquee-not-last-element.html 2011-08-29 17:31:52 UTC (rev 93984)
@@ -0,0 +1,17 @@
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
+marquee { display: run-in; }
+
+
+
+Bug
+marquee
+
+If this test does not ASSERT, it has PASSED
+
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93985] branches/chromium/835
Title: [93985] branches/chromium/835
Revision 93985
Author cev...@google.com
Date 2011-08-29 10:37:48 -0700 (Mon, 29 Aug 2011)
Log Message
Merge 93802
BUG=91973
Review URL: http://codereview.chromium.org/7797001
Modified Paths
branches/chromium/835/Source/WebCore/rendering/RenderTextControl.cpp
Added Paths
branches/chromium/835/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion-expected.txt
branches/chromium/835/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion.html
Diff
Copied: branches/chromium/835/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion-expected.txt (from rev 93802, trunk/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion-expected.txt) (0 => 93985)
--- branches/chromium/835/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion-expected.txt (rev 0)
+++ branches/chromium/835/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion-expected.txt 2011-08-29 17:37:48 UTC (rev 93985)
@@ -0,0 +1,4 @@
+PASS if not crashed.
+
+>
+00AA00A000A0A0A00AA0A00AA00AAA0A0AA00A00A000A0AA000AA0
Copied: branches/chromium/835/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion.html (from rev 93802, trunk/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion.html) (0 => 93985)
--- branches/chromium/835/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion.html (rev 0)
+++ branches/chromium/835/LayoutTests/fast/forms/textarea-placeholder-relayout-assertion.html 2011-08-29 17:37:48 UTC (rev 93985)
@@ -0,0 +1,19 @@
+
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+layoutTestController.dumpAsText();
+}
+
+function removeTextArea() {
+var child = document.getElementById('test');
+child.parentNode.removeChild(child);
+if (window.layoutTestController) {
+setTimeout("layoutTestController.notifyDone();", 0);
+}
+}
+
+setTimeout(removeTextArea, 0);
+
+PASS if not crashed.
+>A0AA0A000
+00AA00A000A0A0A00AA0A00AA00AAA0A0AA00A00A000A0AA000AA0A0AA000AAA0AA000
Modified: branches/chromium/835/Source/WebCore/rendering/RenderTextControl.cpp (93984 => 93985)
--- branches/chromium/835/Source/WebCore/rendering/RenderTextControl.cpp 2011-08-29 17:31:52 UTC (rev 93984)
+++ branches/chromium/835/Source/WebCore/rendering/RenderTextControl.cpp 2011-08-29 17:37:48 UTC (rev 93985)
@@ -430,8 +430,12 @@
RenderObject* placeholderRenderer = placeholder ? placeholder->renderer() : 0;
if (!placeholderRenderer)
return 0;
-if (relayoutChildren)
-placeholderRenderer->setNeedsLayout(true);
+if (relayoutChildren) {
+// The markParents arguments should be false because this function is
+// called from layout() of the parent and the placeholder layout doesn't
+// affect the parent layout.
+placeholderRenderer->setChildNeedsLayout(true, false);
+}
return placeholderRenderer;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [93982] trunk
Title: [93982] trunk Revision 93982 Author commit-qu...@webkit.org Date 2011-08-29 10:14:57 -0700 (Mon, 29 Aug 2011) Log Message canvas arc() missing line to start of arc if swing is zero https://bugs.webkit.org/show_bug.cgi?id=55696 Source/WebCore: Patch by Tom Zakrajsek on 2011-08-29 Reviewed by Andreas Kling. Test: fast/canvas/canvas-arc-zero-lineto.html * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arc): LayoutTests: LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html misinterprets pruning requirement https://bugs.webkit.org/show_bug.cgi?id=66832 Patch by Tom Zakrajsek on 2011-08-29 Reviewed by Andreas Kling. Update to 2d.path.stroke.prune.arc.html was reviewed by Philip Taylor and will be part of the next update to http://philip.html5.org/tests/canvas/suite/tests/2d.path.stroke.prune.arc.html * canvas/philip/tests/2d.path.stroke.prune.arc.html: * fast/canvas/canvas-arc-zero-lineto-expected.txt: Added. * fast/canvas/canvas-arc-zero-lineto.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp Added Paths trunk/LayoutTests/fast/canvas/canvas-arc-zero-lineto-expected.txt trunk/LayoutTests/fast/canvas/canvas-arc-zero-lineto.html Diff Modified: trunk/LayoutTests/ChangeLog (93981 => 93982) --- trunk/LayoutTests/ChangeLog 2011-08-29 17:12:55 UTC (rev 93981) +++ trunk/LayoutTests/ChangeLog 2011-08-29 17:14:57 UTC (rev 93982) @@ -1,3 +1,20 @@ +2011-08-29 Tom Zakrajsek + +canvas arc() missing line to start of arc if swing is zero +https://bugs.webkit.org/show_bug.cgi?id=55696 + +LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html misinterprets pruning requirement +https://bugs.webkit.org/show_bug.cgi?id=66832 + +Reviewed by Andreas Kling. + +Update to 2d.path.stroke.prune.arc.html was reviewed by Philip Taylor and will be part of the +next update to http://philip.html5.org/tests/canvas/suite/tests/2d.path.stroke.prune.arc.html + +* canvas/philip/tests/2d.path.stroke.prune.arc.html: +* fast/canvas/canvas-arc-zero-lineto-expected.txt: Added. +* fast/canvas/canvas-arc-zero-lineto.html: Added. + 2011-08-23 Chris Marrin [mac] requestAnimationFrame support for mac port Modified: trunk/LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html (93981 => 93982) --- trunk/LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html 2011-08-29 17:12:55 UTC (rev 93981) +++ trunk/LayoutTests/canvas/philip/tests/2d.path.stroke.prune.arc.html 2011-08-29 17:14:57 UTC (rev 93982) @@ -26,7 +26,7 @@ ctx.stroke(); ctx.beginPath(); -ctx.moveTo(50, 25); +ctx.moveTo(60, 25); ctx.arc(50, 25, 10, 0, 0, false); ctx.stroke(); Added: trunk/LayoutTests/fast/canvas/canvas-arc-zero-lineto-expected.txt (0 => 93982) --- trunk/LayoutTests/fast/canvas/canvas-arc-zero-lineto-expected.txt (rev 0) +++ trunk/LayoutTests/fast/canvas/canvas-arc-zero-lineto-expected.txt 2011-08-29 17:14:57 UTC (rev 93982) @@ -0,0 +1,13 @@ +Bug 55696: Series of tests to ensure zero-length arc extends current subpath + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS Pixel (50,20) is black. +PASS Pixel (50,40) is black. +PASS Pixel (50,60) is black. +PASS Pixel (50,80) is black. +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/canvas/canvas-arc-zero-lineto.html (0 => 93982) --- trunk/LayoutTests/fast/canvas/canvas-arc-zero-lineto.html (rev 0) +++ trunk/LayoutTests/fast/canvas/canvas-arc-zero-lineto.html 2011-08-29 17:14:57 UTC (rev 93982) @@ -0,0 +1,58 @@ + + + + + + + + +