[webkit-changes] [98322] trunk/LayoutTests

[mrobinson]

Title: [98322] trunk/LayoutTests








Revision 98322
Author mrobin...@webkit.org
Date 2011-10-24 23:51:35 -0700 (Mon, 24 Oct 2011)


Log Message
REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=70481

Update test results to reflect that the plugin clipping rectangle
is now correct.

* platform/gtk/Skipped: Unskip the test.
* platform/gtk/plugins/resize-from-plugin-expected.txt: Update results.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/gtk/plugins/resize-from-plugin-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (98321 => 98322)

--- trunk/LayoutTests/ChangeLog	2011-10-25 05:43:15 UTC (rev 98321)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 06:51:35 UTC (rev 98322)
@@ -1,3 +1,14 @@
+2011-10-24  Martin Robinson  mrobin...@igalia.com
+
+REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK
+https://bugs.webkit.org/show_bug.cgi?id=70481
+
+Update test results to reflect that the plugin clipping rectangle
+is now correct.
+
+* platform/gtk/Skipped: Unskip the test.
+* platform/gtk/plugins/resize-from-plugin-expected.txt: Update results.
+
 2011-10-24  Julien Chaffraix  jchaffr...@webkit.org
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/gtk/Skipped (98321 => 98322)

--- trunk/LayoutTests/platform/gtk/Skipped	2011-10-25 05:43:15 UTC (rev 98321)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-10-25 06:51:35 UTC (rev 98322)
@@ -1644,9 +1644,6 @@
 # Microdata DOM API is not yet enabled.
 fast/dom/MicroData
 
-# https://bugs.webkit.org/show_bug.cgi?id=70481
-plugins/resize-from-plugin.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=70485
 fast/events/drag-selects-image.html
 


Modified: trunk/LayoutTests/platform/gtk/plugins/resize-from-plugin-expected.txt (98321 => 98322)

--- trunk/LayoutTests/platform/gtk/plugins/resize-from-plugin-expected.txt	2011-10-25 05:43:15 UTC (rev 98321)
+++ trunk/LayoutTests/platform/gtk/plugins/resize-from-plugin-expected.txt	2011-10-25 06:51:35 UTC (rev 98322)
@@ -7,6 +7,6 @@
 
 Test for NPP_SetWindow calls sent while a plug-in resizes itself.
 
-x: 0, y: 0, width: 200, height: 200, clipRect: (0, 0, 0, 0)
+x: 0, y: 0, width: 200, height: 200, clipRect: (0, 0, 200, 142)
 Height and width should equal 200, and the plug-in size should not change on scroll.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98323] trunk/LayoutTests

[ossy]

Title: [98323] trunk/LayoutTests








Revision 98323
Author o...@webkit.org
Date 2011-10-24 23:59:32 -0700 (Mon, 24 Oct 2011)


Log Message
[Qt] Unreviewed gardening, add missing result after r98309.

Patch by Oliver Varga voli...@inf.u-szeged.hu on 2011-10-24

* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
* platform/qt/svg/filters/feColorMatrix-default-type-expected.png: Added.
* platform/qt/svg/filters/feColorMatrix-default-type-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png
trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt
trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.png
trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (98322 => 98323)

--- trunk/LayoutTests/ChangeLog	2011-10-25 06:51:35 UTC (rev 98322)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 06:59:32 UTC (rev 98323)
@@ -1,3 +1,12 @@
+2011-10-24  Oliver Varga  voli...@inf.u-szeged.hu
+
+[Qt] Unreviewed gardening, add missing result after r98309.
+
+* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
+* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
+* platform/qt/svg/filters/feColorMatrix-default-type-expected.png: Added.
+* platform/qt/svg/filters/feColorMatrix-default-type-expected.txt: Added.
+
 2011-10-24  Martin Robinson  mrobin...@igalia.com
 
 REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK


Added: trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt (0 => 98323)

--- trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt	2011-10-25 06:59:32 UTC (rev 98323)
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x171
+  RenderBlock {HTML} at (0,0) size 800x171
+RenderBody {BODY} at (8,8) size 784x155
+  RenderPartObject {IFRAME} at (0,0) size 784x150
+layer at (0,0) size 784x150
+  RenderView at (0,0) size 784x150
+layer at (0,0) size 784x121
+  RenderBlock {HTML} at (0,0) size 784x121
+RenderBody {BODY} at (8,8) size 768x105
+  RenderSVGRoot {svg} at (8,8) size 100x100
+RenderSVGPath {circle} at (8,8) size 100x100 [fill={[type=SOLID] [color=#FF]}] [cx=50.00] [cy=50.00] [r=50.00]
+  RenderText {#text} at (0,0) size 0x0


Added: trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.txt (0 => 98323)

--- trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.txt	2011-10-25 06:59:32 UTC (rev 98323)
@@ -0,0 +1,15 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderSVGRoot {svg} at (0,0) size 230x111
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+  RenderSVGResourceFilter {filter} [id=filt] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feColorMatrix type=MATRIX values=0.00 0.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 1.00 0.00]
+  [SourceGraphic]
+  RenderSVGResourceFilter {filter} [id=filt2] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feColorMatrix type=MATRIX values=0.00 0.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 1.00 0.00]
+  [SourceGraphic]
+RenderSVGPath {rect} at (0,0) size 111x111 [fill={[type=SOLID] [color=#FF]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]
+  [filter=filt] RenderSVGResourceFilter {filter} at (-10,-10) size 120x120
+RenderSVGPath {rect} at (110,0) size 120x111 [fill={[type=SOLID] [color=#FF]}] [x=120.00] [y=0.00] [width=100.00] [height=100.00]
+  [filter=filt2] 

[webkit-changes] [98325] trunk/Source/WebKit2

[commit-queue]

Title: [98325] trunk/Source/WebKit2








Revision 98325
Author commit-qu...@webkit.org
Date 2011-10-25 01:19:54 -0700 (Tue, 25 Oct 2011)


Log Message
[WK2]Critical warning while building WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=70591

Patch by Vamshikrishna Yellenki vam...@motorola.com on 2011-10-25
Reviewed by Martin Robinson.

* WebProcess/WebPage/WebPage.cpp: Included DataObjectGtk.h to avoid warnings for GTK

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98324 => 98325)

--- trunk/Source/WebKit2/ChangeLog	2011-10-25 07:06:07 UTC (rev 98324)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-25 08:19:54 UTC (rev 98325)
@@ -1,3 +1,12 @@
+2011-10-25  Vamshikrishna Yellenki  vam...@motorola.com
+
+[WK2]Critical warning while building WebKit2 GTK+
+https://bugs.webkit.org/show_bug.cgi?id=70591
+
+Reviewed by Martin Robinson.
+
+* WebProcess/WebPage/WebPage.cpp: Included DataObjectGtk.h to avoid warnings for GTK
+
 2011-10-24  Sam Weinig  s...@webkit.org
 
 Simplify url accessors on WKBrowsingContextController


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (98324 => 98325)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2011-10-25 07:06:07 UTC (rev 98324)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2011-10-25 08:19:54 UTC (rev 98325)
@@ -128,6 +128,10 @@
 #include QMimeData
 #endif
 
+#if PLATFORM(GTK)
+#include DataObjectGtk.h
+#endif
+
 #ifndef NDEBUG
 #include wtf/RefCountedLeakCounter.h
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98326] trunk

[pfeldman]

Title: [98326] trunk








Revision 98326
Author pfeld...@chromium.org
Date 2011-10-25 01:24:14 -0700 (Tue, 25 Oct 2011)


Log Message
Web Inspector: print expired message count before remaining messages.
https://bugs.webkit.org/show_bug.cgi?id=70736

Reviewed by Yury Semikhatsky.

* inspector/Inspector-0.1.json:
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::restore):
* inspector/InspectorConsoleAgent.h:
* inspector/front-end/ConsoleModel.js:

Modified Paths

trunk/LayoutTests/inspector/protocol/console-agent-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector-0.1.json
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp
trunk/Source/WebCore/inspector/InspectorConsoleAgent.h
trunk/Source/WebCore/inspector/front-end/ConsoleModel.js




Diff

Modified: trunk/LayoutTests/inspector/protocol/console-agent-expected.txt (98325 => 98326)

--- trunk/LayoutTests/inspector/protocol/console-agent-expected.txt	2011-10-25 08:19:54 UTC (rev 98325)
+++ trunk/LayoutTests/inspector/protocol/console-agent-expected.txt	2011-10-25 08:24:14 UTC (rev 98326)
@@ -30,7 +30,6 @@
 response:
 {
 result : {
-expiredMessagesCount : 0
 }
 id : number
 }


Modified: trunk/Source/WebCore/ChangeLog (98325 => 98326)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 08:19:54 UTC (rev 98325)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 08:24:14 UTC (rev 98326)
@@ -1,3 +1,18 @@
+2011-10-24  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: print expired message count before remaining messages.
+https://bugs.webkit.org/show_bug.cgi?id=70736
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/Inspector-0.1.json:
+* inspector/Inspector.json:
+* inspector/InspectorConsoleAgent.cpp:
+(WebCore::InspectorConsoleAgent::enable):
+(WebCore::InspectorConsoleAgent::restore):
+* inspector/InspectorConsoleAgent.h:
+* inspector/front-end/ConsoleModel.js:
+
 2011-10-25  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r98309.


Modified: trunk/Source/WebCore/inspector/Inspector-0.1.json (98325 => 98326)

--- trunk/Source/WebCore/inspector/Inspector-0.1.json	2011-10-25 08:19:54 UTC (rev 98325)
+++ trunk/Source/WebCore/inspector/Inspector-0.1.json	2011-10-25 08:24:14 UTC (rev 98326)
@@ -351,12 +351,12 @@
 description: Console message.,
 properties: [
 { name: source, type: string, enum: [html, wml, xml, _javascript_, network, console-api, other], description: Message source. },
-{ name: type, type: string, enum: [log, dir, dirxml, trace, startGroup, startGroupCollapsed, endGroup, assert], description: Console message type. },
 { name: level, type: string, enum: [tip, log, warning, error, debug], description: Message severity. },
-{ name: line, type: integer, description: Line number in the resource that generated this message. },
-{ name: url, type: string, description: URL of the message origin. },
-{ name: repeatCount, type: integer, description: Repeat count for repeated messages. },
 { name: text, type: string, description: Message text. },
+{ name: type, type: string, optional: true, enum: [log, dir, dirxml, trace, startGroup, startGroupCollapsed, endGroup, assert], description: Console message type. },
+{ name: url, type: string, optional: true, description: URL of the message origin. },
+{ name: line, type: integer, optional: true, description: Line number in the resource that generated this message. },
+{ name: repeatCount, type: integer, optional: true, description: Repeat count for repeated messages. },
 { name: networkRequestId, $ref: Network.RequestId, optional: true, description: Identifier of the network request associated with this message. },
 { name: parameters, type: array, items: { $ref: Runtime.RemoteObject }, optional: true, description: Message parameters in case of the formatted message. },
 { name: stackTrace, $ref: StackTrace, optional: true, description: _javascript_ stack trace for assertions and error messages. }
@@ -384,7 +384,7 @@
 {
 name: enable,
 returns: [
-{ name: expiredMessagesCount, type: integer, description: Number of messages dropped due to message threashold overflow. }
+{ name: expiredMessagesCount, type: integer,  optional: true, description: Number of messages dropped due to message threashold overflow. }
 ],
 description: Enables console domain, sends the messages collected so far to the client by 

[webkit-changes] [98327] trunk/Source/WebKit2

[carlosgc]

Title: [98327] trunk/Source/WebKit2








Revision 98327
Author carlo...@webkit.org
Date 2011-10-25 01:37:35 -0700 (Tue, 25 Oct 2011)


Log Message
[GTK] Add go_to_back_forward_list_item() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69825

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
(webkitBackForwardListItemGetWKItem):
* UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_go_to_back_forward_list_item):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/TestBackForwardList.cpp:
(testBackForwardListNavigation):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListPrivate.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98326 => 98327)

--- trunk/Source/WebKit2/ChangeLog	2011-10-25 08:24:14 UTC (rev 98326)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-25 08:37:35 UTC (rev 98327)
@@ -1,3 +1,19 @@
+2011-10-25  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Add go_to_back_forward_list_item() to WebKit2 GTK+ API
+https://bugs.webkit.org/show_bug.cgi?id=69825
+
+Reviewed by Martin Robinson.
+
+* UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
+(webkitBackForwardListItemGetWKItem):
+* UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkit_web_view_go_to_back_forward_list_item):
+* UIProcess/API/gtk/WebKitWebView.h:
+* UIProcess/API/gtk/tests/TestBackForwardList.cpp:
+(testBackForwardListNavigation):
+
 2011-10-25  Vamshikrishna Yellenki  vam...@motorola.com
 
 [WK2]Critical warning while building WebKit2 GTK+


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp (98326 => 98327)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp	2011-10-25 08:24:14 UTC (rev 98326)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp	2011-10-25 08:37:35 UTC (rev 98327)
@@ -93,6 +93,11 @@
 return listItem;
 }
 
+WKBackForwardListItemRef webkitBackForwardListItemGetWKItem(WebKitBackForwardListItem* listItem)
+{
+return listItem-priv-wkListItem.get();
+}
+
 /**
  * webkit_back_forward_list_item_get_uri:
  * @back_forward_list_item: a #WebKitBackForwardListItem


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListPrivate.h (98326 => 98327)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListPrivate.h	2011-10-25 08:24:14 UTC (rev 98326)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListPrivate.h	2011-10-25 08:37:35 UTC (rev 98327)
@@ -32,6 +32,7 @@
 
 WebKitBackForwardList* webkitBackForwardListCreate(WKBackForwardListRef);
 WebKitBackForwardListItem* webkitBackForwardListItemGetOrCreate(WKBackForwardListItemRef);
+WKBackForwardListItemRef webkitBackForwardListItemGetWKItem(WebKitBackForwardListItem*);
 void webkitBackForwardListChanged(WebKitBackForwardList*, WKBackForwardListItemRef wkAddedItem, WKArrayRef wkRemovedItems);
 
 #endif // WebKitBackForwardListPrivate_h


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (98326 => 98327)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2011-10-25 08:24:14 UTC (rev 98326)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2011-10-25 08:37:35 UTC (rev 98327)
@@ -482,3 +482,21 @@
 
 return webView-priv-backForwardList.get();
 }
+
+/**
+ * webkit_web_view_go_to_back_forward_list_item:
+ * @web_view: a #WebKitWebView
+ * @list_item: a #WebKitBackForwardListItem
+ *
+ * Loads the specific history item @list_item.
+ * You can monitor the status of the load operation using the
+ * #WebKitWebLoaderClient of @web_view. See webkit_web_view_get_loader_client().
+ */
+void webkit_web_view_go_to_back_forward_list_item(WebKitWebView* webView, WebKitBackForwardListItem* listItem)
+{
+g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
+g_return_if_fail(WEBKIT_IS_BACK_FORWARD_LIST_ITEM(listItem));
+
+WKPageGoToBackForwardListItem(toAPI(webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(webView))),
+  webkitBackForwardListItemGetWKItem(listItem));
+}


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h (98326 => 98327)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h	2011-10-25 08:24:14 UTC (rev 98326)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h	2011-10-25 08:37:35 UTC (rev 98327)
@@ -66,69 +66,72 @@
 };
 
 WEBKIT_API GType
-webkit_web_view_get_type(void);
+webkit_web_view_get_type (void);
 
 WEBKIT_API GtkWidget *
-webkit_web_view_new (void);

[webkit-changes] [98328] trunk

[caseq]

Title: [98328] trunk








Revision 98328
Author ca...@chromium.org
Date 2011-10-25 02:25:37 -0700 (Tue, 25 Oct 2011)


Log Message
Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload
https://bugs.webkit.org/show_bug.cgi?id=70600

Reviewed by Pavel Feldman.

- change webInspector.inspectedPage.reload() to accept multiple options in an object
- add an ability to inject a script upon a page reload
- return script id in addScriptToEvaluateOnLoad()
- provide removeScriptToEvaluateOnLoad()
- store scripts to evaluate on load in inspector state cookie

Source/WebCore:

Test: inspector/extensions/extensions-reload.html

* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameNavigated):
* inspector/InspectorPageAgent.h:
* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.InspectedWindow.prototype.reload):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation.callback):
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation):

LayoutTests:

* inspector/extensions/extensions-reload-expected.txt: Added.
* inspector/extensions/extensions-reload.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js
trunk/Source/WebCore/inspector/front-end/ExtensionServer.js
trunk/Source/WebCore/inspector/front-end/WorkersSidebarPane.js


Added Paths

trunk/LayoutTests/inspector/extensions/extensions-reload-expected.txt
trunk/LayoutTests/inspector/extensions/extensions-reload.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98327 => 98328)

--- trunk/LayoutTests/ChangeLog	2011-10-25 08:37:35 UTC (rev 98327)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 09:25:37 UTC (rev 98328)
@@ -1,3 +1,13 @@
+2011-10-21  Andrey Kosyakov  ca...@chromium.org
+
+Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload
+https://bugs.webkit.org/show_bug.cgi?id=70600
+
+Reviewed by Pavel Feldman.
+
+* inspector/extensions/extensions-reload-expected.txt: Added.
+* inspector/extensions/extensions-reload.html: Added.
+
 2011-10-25  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r98309.


Added: trunk/LayoutTests/inspector/extensions/extensions-reload-expected.txt (0 => 98328)

--- trunk/LayoutTests/inspector/extensions/extensions-reload-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/extensions/extensions-reload-expected.txt	2011-10-25 09:25:37 UTC (rev 98328)
@@ -0,0 +1,11 @@
+Tests that webInspector.inspectedWindow.reload() successfully injects user's code upon reload
+
+Started extension.
+Running tests...
+RUNNING TEST: extension_testReloadInjectsCode
+Page reloaded.
+Page reloaded.
+With injected code: foo = 42
+Without injected code: foo = undefined
+All tests done.
+
Property changes on: trunk/LayoutTests/inspector/extensions/extensions-reload-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/inspector/extensions/extensions-reload.html (0 => 98328)

--- trunk/LayoutTests/inspector/extensions/extensions-reload.html	(rev 0)
+++ trunk/LayoutTests/inspector/extensions/extensions-reload.html	2011-10-25 09:25:37 UTC (rev 98328)
@@ -0,0 +1,40 @@
+html
+head
+script src=""
+script src=""
+script type=text/_javascript_
+
+window.bar = foo =  + window.foo;
+
+function extension_testReloadInjectsCode(nextTest)
+{
+var valueWithInjectedCode;
+
+function onPageWithInjectedCodeLoaded()
+{
+webInspector.inspectedWindow.eval(window.bar, function(value) {
+valueWithInjectedCode = value;
+evaluateOnFrontend(InspectorTest.runWhenPageLoads(reply), onPageWithoutInjectedCodeLoaded);
+webInspector.inspectedWindow.reload();
+});
+}
+function onPageWithoutInjectedCodeLoaded()
+{
+webInspector.inspectedWindow.eval(window.bar, function(value) {
+output(With injected code:  + valueWithInjectedCode);
+output(Without injected code:  + value);
+nextTest();
+});
+}
+evaluateOnFrontend(InspectorTest.runWhenPageLoads(reply), onPageWithInjectedCodeLoaded);
+webInspector.inspectedWindow.reload({
+

[webkit-changes] [98329] trunk/LayoutTests

[ossy]

Title: [98329] trunk/LayoutTests








Revision 98329
Author o...@webkit.org
Date 2011-10-25 02:35:48 -0700 (Tue, 25 Oct 2011)


Log Message
[Qt] Removing test from Skipped list. Test passes: html5lib/runner.html
https://bugs.webkit.org/show_bug.cgi?id=53030

Patch by Zoltan Arvai zar...@inf.u-szeged.hu on 2011-10-25
Reviewed by Simon Hausmann.

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (98328 => 98329)

--- trunk/LayoutTests/ChangeLog	2011-10-25 09:25:37 UTC (rev 98328)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 09:35:48 UTC (rev 98329)
@@ -1,3 +1,12 @@
+2011-10-25  Zoltan Arvai  zar...@inf.u-szeged.hu
+
+[Qt] Removing test from Skipped list. Test passes: html5lib/runner.html
+https://bugs.webkit.org/show_bug.cgi?id=53030
+
+Reviewed by Simon Hausmann.
+
+* platform/qt/Skipped:
+
 2011-10-21  Andrey Kosyakov  ca...@chromium.org
 
 Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload


Modified: trunk/LayoutTests/platform/qt/Skipped (98328 => 98329)

--- trunk/LayoutTests/platform/qt/Skipped	2011-10-25 09:25:37 UTC (rev 98328)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-10-25 09:35:48 UTC (rev 98329)
@@ -1861,9 +1861,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=53843
 media/video-frame-accurate-seek.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=53030
-html5lib/runner.html 
-
 # [Qt]  fast/notifications/notifications-document-close-crash.html fails after r77738
 # https://bugs.webkit.org/show_bug.cgi?id=53868
 fast/notifications/notifications-document-close-crash.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98330] trunk/LayoutTests

[ossy]

Title: [98330] trunk/LayoutTests








Revision 98330
Author o...@webkit.org
Date 2011-10-25 02:39:35 -0700 (Tue, 25 Oct 2011)


Log Message
[Qt] Remove from Skipped list. Test passes: fast/transforms/scrollIntoView-transformed.html
https://bugs.webkit.org/show_bug.cgi?id=58559

Patch by Zoltan Arvai zar...@inf.u-szeged.hu on 2011-10-25
Reviewed by Simon Hausmann.

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (98329 => 98330)

--- trunk/LayoutTests/ChangeLog	2011-10-25 09:35:48 UTC (rev 98329)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 09:39:35 UTC (rev 98330)
@@ -1,5 +1,14 @@
 2011-10-25  Zoltan Arvai  zar...@inf.u-szeged.hu
 
+[Qt] Remove from Skipped list. Test passes: fast/transforms/scrollIntoView-transformed.html
+https://bugs.webkit.org/show_bug.cgi?id=58559
+
+Reviewed by Simon Hausmann.
+
+* platform/qt/Skipped:
+
+2011-10-25  Zoltan Arvai  zar...@inf.u-szeged.hu
+
 [Qt] Removing test from Skipped list. Test passes: html5lib/runner.html
 https://bugs.webkit.org/show_bug.cgi?id=53030
 


Modified: trunk/LayoutTests/platform/qt/Skipped (98329 => 98330)

--- trunk/LayoutTests/platform/qt/Skipped	2011-10-25 09:35:48 UTC (rev 98329)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-10-25 09:39:35 UTC (rev 98330)
@@ -2067,10 +2067,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=58313
 inspector/styles/styles-disable-then-enable.html
 
-# [Qt] fast/transforms/scrollIntoView-transformed.html fails
-# https://bugs.webkit.org/show_bug.cgi?id=58559
-fast/transforms/scrollIntoView-transformed.html
-
 # Stuff Kling broke while happy-hacking DRT (r84010, r84012)
 fast/css/font-face-repeated-url.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98331] trunk/Source/WebCore

[nduca]

Title: [98331] trunk/Source/WebCore








Revision 98331
Author nd...@chromium.org
Date 2011-10-25 02:54:27 -0700 (Tue, 25 Oct 2011)


Log Message
[chromium] Route Console::time and Console::timeEnd to trace_event
https://bugs.webkit.org/show_bug.cgi?id=70620

Reviewed by Pavel Feldman.

* page/Console.cpp:
(WebCore::Console::time):
(WebCore::Console::timeEnd):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Console.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (98330 => 98331)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 09:39:35 UTC (rev 98330)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 09:54:27 UTC (rev 98331)
@@ -1,3 +1,14 @@
+2011-10-21  Nat Duca  nd...@chromium.org
+
+[chromium] Route Console::time and Console::timeEnd to trace_event
+https://bugs.webkit.org/show_bug.cgi?id=70620
+
+Reviewed by Pavel Feldman.
+
+* page/Console.cpp:
+(WebCore::Console::time):
+(WebCore::Console::timeEnd):
+
 2011-10-21  Andrey Kosyakov  ca...@chromium.org
 
 Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload


Modified: trunk/Source/WebCore/page/Console.cpp (98330 => 98331)

--- trunk/Source/WebCore/page/Console.cpp	2011-10-25 09:39:35 UTC (rev 98330)
+++ trunk/Source/WebCore/page/Console.cpp	2011-10-25 09:54:27 UTC (rev 98331)
@@ -49,6 +49,10 @@
 #include wtf/UnusedParam.h
 #include wtf/text/CString.h
 
+#if PLATFORM(CHROMIUM)
+#include TraceEvent.h
+#endif
+
 namespace WebCore {
 
 Console::Console(Frame* frame)
@@ -304,10 +308,18 @@
 void Console::time(const String title)
 {
 InspectorInstrumentation::startConsoleTiming(page(), title);
+#if PLATFORM(CHROMIUM)
+if (PlatformSupport::isTraceEventEnabled())
+PlatformSupport::traceEventBegin(title.utf8().data(), 0, 0);
+#endif
 }
 
 void Console::timeEnd(const String title, PassRefPtrScriptArguments, PassRefPtrScriptCallStack callStack)
 {
+#if PLATFORM(CHROMIUM)
+if (PlatformSupport::isTraceEventEnabled())
+PlatformSupport::traceEventEnd(title.utf8().data(), 0, 0);
+#endif
 InspectorInstrumentation::stopConsoleTiming(page(), title, callStack);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98332] trunk/Source/WebKit2

[commit-queue]

Title: [98332] trunk/Source/WebKit2








Revision 98332
Author commit-qu...@webkit.org
Date 2011-10-25 04:01:51 -0700 (Tue, 25 Oct 2011)


Log Message
[Qt][WK2] Remove redundant setPageIsVisible() API
https://bugs.webkit.org/show_bug.cgi?id=70520

Use DrawingAreaProxy::visibilityDidChange() instead of DrawingAreaProxy::setPageIsVisible()
Remove DrawingAreaProxy::setPageIsVisible(), not used anymore.
This change disables the ability of suspending and resuming painting for TiledDrawingAreaProxy.
However, TiledDrawingAreaProxy is about to be deprecated by using DrawingAreaProxyImpl
as the UI process drawing area proxy for tiled based rendering.

Patch by Zalan Bujtas zbuj...@gmail.com on 2011-10-25
Reviewed by Simon Hausmann.

* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage):
(QTouchWebPagePrivate::setPage):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebView::QTouchWebView):
(QTouchWebView::touchEvent):
(QTouchWebView::onVisibleChanged):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
* UIProcess/qt/QtWebPageProxy.cpp:
* UIProcess/qt/QtWebPageProxy.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h
trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.h
trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h
trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h
trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp
trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98331 => 98332)

--- trunk/Source/WebKit2/ChangeLog	2011-10-25 09:54:27 UTC (rev 98331)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-25 11:01:51 UTC (rev 98332)
@@ -1,3 +1,37 @@
+2011-10-25  Zalan Bujtas  zbuj...@gmail.com
+
+[Qt][WK2] Remove redundant setPageIsVisible() API
+https://bugs.webkit.org/show_bug.cgi?id=70520
+
+Use DrawingAreaProxy::visibilityDidChange() instead of DrawingAreaProxy::setPageIsVisible()
+Remove DrawingAreaProxy::setPageIsVisible(), not used anymore.
+This change disables the ability of suspending and resuming painting for TiledDrawingAreaProxy.
+However, TiledDrawingAreaProxy is about to be deprecated by using DrawingAreaProxyImpl
+as the UI process drawing area proxy for tiled based rendering.
+
+Reviewed by Simon Hausmann.
+
+* UIProcess/API/qt/qtouchwebpage.cpp:
+(QTouchWebPage::QTouchWebPage):
+(QTouchWebPagePrivate::setPage):
+* UIProcess/API/qt/qtouchwebpage.h:
+* UIProcess/API/qt/qtouchwebview.cpp:
+(QTouchWebView::QTouchWebView):
+(QTouchWebView::touchEvent):
+(QTouchWebView::onVisibleChanged):
+* UIProcess/API/qt/qtouchwebview.h:
+* UIProcess/DrawingAreaProxy.h:
+* UIProcess/DrawingAreaProxyImpl.cpp:
+* UIProcess/DrawingAreaProxyImpl.h:
+* UIProcess/TiledDrawingAreaProxy.cpp:
+(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
+(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):
+* UIProcess/TiledDrawingAreaProxy.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::viewStateDidChange):
+* UIProcess/qt/QtWebPageProxy.cpp:
+* UIProcess/qt/QtWebPageProxy.h:
+
 2011-10-25  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Add go_to_back_forward_list_item() to WebKit2 GTK+ API


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp (98331 => 98332)

--- trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp	2011-10-25 09:54:27 UTC (rev 98331)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp	2011-10-25 11:01:51 UTC (rev 98332)
@@ -38,7 +38,6 @@
 // We do the transform from the top left so the viewport can assume the position 0, 0
 // is always where rendering starts.
 setTransformOrigin(TopLeft);
-connect(this, SIGNAL(visibleChanged()), SLOT(onVisibleChanged()));
 }
 
 QTouchWebPage::~QTouchWebPage()
@@ -161,9 +160,4 @@
 this-page = page;
 }
 
-void QTouchWebPage::onVisibleChanged()
-{
-d-page-setPageIsVisible(isVisible());
-}
-
 #include moc_qtouchwebpage.cpp


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h (98331 => 98332)

--- 

[webkit-changes] [98333] trunk/Source/WebCore

[caseq]

Title: [98333] trunk/Source/WebCore








Revision 98333
Author ca...@chromium.org
Date 2011-10-25 05:59:07 -0700 (Tue, 25 Oct 2011)


Log Message
Web Inspector: JS exception in _javascript_SourceFrame.onShowPopover/showObjectPopover()
https://bugs.webkit.org/show_bug.cgi?id=70812

Reviewed by Pavel Feldman.

Check if highlighted element is present while displaying object popover.

* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype.onShowPopover.showObjectPopover):
(WebInspector._javascript_SourceFrame.prototype.onShowPopover):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (98332 => 98333)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 11:01:51 UTC (rev 98332)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 12:59:07 UTC (rev 98333)
@@ -1,3 +1,16 @@
+2011-10-25  Andrey Kosyakov  ca...@chromium.org
+
+Web Inspector: JS exception in _javascript_SourceFrame.onShowPopover/showObjectPopover()
+https://bugs.webkit.org/show_bug.cgi?id=70812
+
+Reviewed by Pavel Feldman.
+
+Check if highlighted element is present while displaying object popover.
+
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame.prototype.onShowPopover.showObjectPopover):
+(WebInspector._javascript_SourceFrame.prototype.onShowPopover):
+
 2011-10-21  Nat Duca  nd...@chromium.org
 
 [chromium] Route Console::time and Console::timeEnd to trace_event


Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (98332 => 98333)

--- trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js	2011-10-25 11:01:51 UTC (rev 98332)
+++ trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js	2011-10-25 12:59:07 UTC (rev 98333)
@@ -77,7 +77,9 @@
 return;
 }
 showCallback(WebInspector.RemoteObject.fromPayload(result), wasThrown);
-this._highlightElement.addStyleClass(source-frame-eval-_expression_);
+// Popover may have been removed by showCallback().
+if (this._highlightElement)
+this._highlightElement.addStyleClass(source-frame-eval-_expression_);
 }
 
 var selectedCallFrame = this._model.selectedCallFrame;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98334] branches/chromium/912/Source/WebCore/English.lproj/localizedStrings .js

[vsevik]

Title: [98334] branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js








Revision 98334
Author vse...@chromium.org
Date 2011-10-25 06:00:22 -0700 (Tue, 25 Oct 2011)


Log Message


Modified Paths

branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js




Diff

Modified: branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98335] branches/chromium/912/Source/WebCore/English.lproj/localizedStrings .js

[vsevik]

Title: [98335] branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js








Revision 98335
Author vse...@chromium.org
Date 2011-10-25 06:09:52 -0700 (Tue, 25 Oct 2011)


Log Message
Revert 98334 - 

TBR=vse...@chromium.org
Review URL: http://codereview.chromium.org/8375054

Modified Paths

branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js




Diff

Modified: branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98336] branches/chromium/912/Source/WebCore

[vsevik]

Title: [98336] branches/chromium/912/Source/WebCore








Revision 98336
Author vse...@chromium.org
Date 2011-10-25 06:17:32 -0700 (Tue, 25 Oct 2011)


Log Message
Merge 98105 - Web Inspector: Advanced search is working very slowly and does not show searching progress.
https://bugs.webkit.org/show_bug.cgi?id=70611

Search implementation changed so that we do not start searching in the next file unless
the previous one was already searched. This allows to interrupt search.
Not all search matches are added on UI by default now, only first 20 for each file.
Search progress information and search stop button were added to drawer status bar.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController.prototype._onSearchResult):
(WebInspector.AdvancedSearchController.prototype._onSearchFinished):
(WebInspector.AdvancedSearchController.prototype.startSearch):
(WebInspector.AdvancedSearchController.prototype.resetSearch):
(WebInspector.AdvancedSearchController.prototype.stopSearch):
(WebInspector.SearchView):
(WebInspector.SearchView.prototype.get statusBarItems):
(WebInspector.SearchView.prototype.get counterElement):
(WebInspector.SearchView.prototype.set resultsPane):
(WebInspector.SearchView.prototype.searchStarted):
(WebInspector.SearchView.prototype._updateSearchResultsMessage):
(WebInspector.SearchView.prototype._updateSearchProgress):
(WebInspector.SearchView.prototype.resetResults):
(WebInspector.SearchView.prototype._resetCounters):
(WebInspector.SearchView.prototype.nothingFound):
(WebInspector.SearchView.prototype.addSearchResult):
(WebInspector.SearchView.prototype.searchFinished):
(WebInspector.SearchView.prototype._searchStopButtonPressed):
(WebInspector.SearchResultsPane):
(WebInspector.FileBasedSearchResultsPane):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._fileTreeElementExpanded):
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
(WebInspector.FileBasedSearchResultsPane.prototype._appendShowMoreMatchesElement):
(WebInspector.FileBasedSearchResultsPane.prototype._showMoreMatchesElementSelected):
(WebInspector.FileBasedSearchResultsPane.prototype._addFileTreeElement):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.hide):
* inspector/front-end/Images/statusbarButtonGlyphs.png:
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype.performSearch.filterOutContentScripts):
(WebInspector.ScriptsSearchScope.prototype.performSearch.continueSearch):
(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
(WebInspector.ScriptsSearchScope.prototype.performSearch):
(WebInspector.ScriptsSearchScope.prototype.stopSearch):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._registerShortcuts):
* inspector/front-end/inspector.css:
(#drawer-status-bar .search-status-bar-item):
(#drawer-status-bar .search-status-bar-message):
(#drawer-status-bar .search-status-bar-progress):
(#drawer-status-bar .search-status-bar-stop-button-item):
(#drawer-status-bar .search-status-bar-stop-button .glyph):
(#drawer-status-bar .search-results-status-bar-message):
(.search-view .search-results):
(#search-results-pane-file-based .search-results-outline-disclosure):
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .search-result:hover):
(#search-results-pane-file-based .show-more-matches):
(#search-results-pane-file-based .show-more-matches:hover):
(#search-results-pane-file-based .search-match:hover):
* inspector/front-end/utilities.js:
():

BUG=101337
TBR=vse...@chromium.org
Review URL: http://codereview.chromium.org/8381041

Modified Paths

branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js
branches/chromium/912/Source/WebCore/inspector/ContentSearchUtils.cpp
branches/chromium/912/Source/WebCore/inspector/front-end/AdvancedSearchController.js
branches/chromium/912/Source/WebCore/inspector/front-end/Drawer.js
branches/chromium/912/Source/WebCore/inspector/front-end/Images/statusbarButtonGlyphs.png
branches/chromium/912/Source/WebCore/inspector/front-end/ScriptsSearchScope.js
branches/chromium/912/Source/WebCore/inspector/front-end/TimelinePanel.js
branches/chromium/912/Source/WebCore/inspector/front-end/inspector.css
branches/chromium/912/Source/WebCore/inspector/front-end/utilities.js




Diff

Modified: branches/chromium/912/Source/WebCore/English.lproj/localizedStrings.js

(Binary files differ)


Modified: branches/chromium/912/Source/WebCore/inspector/ContentSearchUtils.cpp (98335 => 98336)

--- 

[webkit-changes] [98337] trunk/Source/WebKit2

[commit-queue]

Title: [98337] trunk/Source/WebKit2








Revision 98337
Author commit-qu...@webkit.org
Date 2011-10-25 06:38:28 -0700 (Tue, 25 Oct 2011)


Log Message
[Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
https://bugs.webkit.org/show_bug.cgi?id=70693

This change allows us to use the template based features of the meta type system
such as using the WebView classes as types for QVariant.

Patch by Zeno Albisser zeno.albis...@nokia.com on 2011-10-25
Reviewed by Simon Hausmann.

* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebview.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h
trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98336 => 98337)

--- trunk/Source/WebKit2/ChangeLog	2011-10-25 13:17:32 UTC (rev 98336)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-25 13:38:28 UTC (rev 98337)
@@ -1,3 +1,16 @@
+2011-10-25  Zeno Albisser  zeno.albis...@nokia.com
+
+[Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
+https://bugs.webkit.org/show_bug.cgi?id=70693
+
+This change allows us to use the template based features of the meta type system
+such as using the WebView classes as types for QVariant.
+
+Reviewed by Simon Hausmann.
+
+* UIProcess/API/qt/qdesktopwebview.h:
+* UIProcess/API/qt/qtouchwebview.h:
+
 2011-10-25  Zalan Bujtas  zbuj...@gmail.com
 
 [Qt][WK2] Remove redundant setPageIsVisible() API


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h (98336 => 98337)

--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h	2011-10-25 13:17:32 UTC (rev 98336)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h	2011-10-25 13:38:28 UTC (rev 98337)
@@ -131,6 +131,7 @@
 QDesktopWebViewPrivate *d;
 };
 
+QML_DECLARE_TYPE(QDesktopWebView)
 Q_DECLARE_METATYPE(QDesktopWebView::NavigationPolicy)
 
 #endif /* qdesktopwebview_h */


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.h (98336 => 98337)

--- trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.h	2011-10-25 13:17:32 UTC (rev 98336)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.h	2011-10-25 13:38:28 UTC (rev 98337)
@@ -59,4 +59,6 @@
 QTouchWebViewPrivate *d;
 };
 
+QML_DECLARE_TYPE(QTouchWebView)
+
 #endif /* qtouchwebview_h */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98338] trunk/LayoutTests

[ossy]

Title: [98338] trunk/LayoutTests








Revision 98338
Author o...@webkit.org
Date 2011-10-25 06:45:47 -0700 (Tue, 25 Oct 2011)


Log Message
inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

* platform/qt/Skipped: Skip one more test because of this bug: inspector/evaluate-in-page.html.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (98337 => 98338)

--- trunk/LayoutTests/ChangeLog	2011-10-25 13:38:28 UTC (rev 98337)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 13:45:47 UTC (rev 98338)
@@ -1,3 +1,10 @@
+2011-10-25  Csaba Osztrogonác  o...@webkit.org
+
+inspector/cookie-parser.html is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=62662
+
+* platform/qt/Skipped: Skip one more test because of this bug: inspector/evaluate-in-page.html.
+
 2011-10-25  Zoltan Arvai  zar...@inf.u-szeged.hu
 
 [Qt] Remove from Skipped list. Test passes: fast/transforms/scrollIntoView-transformed.html


Modified: trunk/LayoutTests/platform/qt/Skipped (98337 => 98338)

--- trunk/LayoutTests/platform/qt/Skipped	2011-10-25 13:38:28 UTC (rev 98337)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-10-25 13:45:47 UTC (rev 98338)
@@ -2441,6 +2441,7 @@
 # https://bugs.webkit.org/show_bug.cgi?id=62662
 inspector/cookie-parser.html
 inspector/cookie-resource-match.html
+inspector/evaluate-in-page.html
 
 # [Qt] Assertion fail in CSSPrimitiveValue ctor
 # https://bugs.webkit.org/show_bug.cgi?id=69933






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98339] trunk

[vsevik]

Title: [98339] trunk








Revision 98339
Author vse...@chromium.org
Date 2011-10-25 06:49:24 -0700 (Tue, 25 Oct 2011)


Log Message
Web Inspector: Resources panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66050

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/resources-search-match-index.html

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):
(WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):
(WebInspector.ResourcesSearchController):
(WebInspector.ResourcesSearchController.prototype.nextSearchResult):
(WebInspector.ResourcesSearchController.prototype.previousSearchResult):
(WebInspector.ResourcesSearchController.prototype._searchResult):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.next):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.previous):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.matchIndex):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._elementSearchMatchesCount):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
* inspector/front-end/treeoutline.js:

LayoutTests:

* http/tests/inspector/search/resources-search-match-index-expected.txt: Added.
* http/tests/inspector/search/resources-search-match-index.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
trunk/Source/WebCore/inspector/front-end/treeoutline.js


Added Paths

trunk/LayoutTests/http/tests/inspector/search/resources-search-match-index-expected.txt
trunk/LayoutTests/http/tests/inspector/search/resources-search-match-index.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98338 => 98339)

--- trunk/LayoutTests/ChangeLog	2011-10-25 13:45:47 UTC (rev 98338)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 13:49:24 UTC (rev 98339)
@@ -1,3 +1,13 @@
+2011-10-25  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Resources panel: display the current search match index in the toolbar.
+https://bugs.webkit.org/show_bug.cgi?id=66050
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/search/resources-search-match-index-expected.txt: Added.
+* http/tests/inspector/search/resources-search-match-index.html: Added.
+
 2011-10-25  Csaba Osztrogonác  o...@webkit.org
 
 inspector/cookie-parser.html is a flaky crash


Added: trunk/LayoutTests/http/tests/inspector/search/resources-search-match-index-expected.txt (0 => 98339)

--- trunk/LayoutTests/http/tests/inspector/search/resources-search-match-index-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/search/resources-search-match-index-expected.txt	2011-10-25 13:49:24 UTC (rev 98339)
@@ -0,0 +1,120 @@
+Tests search match index calculation in resources panel.
+
+Bug 66050
+
+Running: test1
+Running test for matches counts: [1]
+Element index: 1, index: 0, match index: 1.
+Element index: 1, index: 0, match index: 1.
+Element index: 1, index: 0, match index: 1.
+Element index: 1, index: 0, match index: 1.
+Element index: 1, index: 0, match index: 1.
+Element index: 1, index: 0, match index: 1.
+
+
+Running: test2
+Running test for matches counts: [1,2,3]
+Element index: 1, index: 0, match index: 1.
+Element index: 2, index: 0, match index: 2.
+Element index: 2, index: 1, match index: 3.
+Element index: 3, index: 0, match index: 4.
+Element index: 3, index: 1, match index: 5.
+Element index: 3, index: 2, match index: 6.
+Element index: 1, index: 0, match index: 1.
+Element index: 3, index: 2, match index: 6.
+Element index: 3, index: 1, match index: 5.
+Element index: 3, index: 0, match index: 4.
+Element index: 2, index: 1, match index: 3.
+Element index: 2, index: 0, match index: 2.
+Element index: 1, index: 0, match index: 1.
+Element index: 3, index: 2, match index: 6.
+Element index: 1, index: 0, match index: 1.
+Element index: 3, index: 2, match index: 6.
+
+
+Running: test3
+Running test for matches counts: [1,0,2,0,3]
+Element index: 1, index: 0, match index: 1.
+Element index: 3, index: 0, match index: 2.
+Element index: 3, index: 1, match index: 3.
+Element index: 5, index: 0, match index: 4.
+Element index: 5, index: 1, match index: 5.
+Element index: 5, index: 2, match index: 6.
+Element index: 1, index: 0, match index: 1.
+Element index: 5, index: 2, match index: 6.
+Element index: 5, index: 1, match index: 5.
+Element index: 5, index: 0, match index: 4.
+Element index: 3, index: 1, match index: 3.
+Element index: 3, index: 0, match index: 2.
+Element index: 1, index: 0, match index: 1.
+Element index: 5, index: 

[webkit-changes] [98340] trunk/Tools

[eric]

Title: [98340] trunk/Tools








Revision 98340
Author e...@webkit.org
Date 2011-10-25 06:49:33 -0700 (Tue, 25 Oct 2011)


Log Message
WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
https://bugs.webkit.org/show_bug.cgi?id=64471

Reviewed by Adam Roben.

Speculative fix.

* Scripts/webkitpy/layout_tests/port/win.py:
* Scripts/webkitpy/layout_tests/port/win_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (98339 => 98340)

--- trunk/Tools/ChangeLog	2011-10-25 13:49:24 UTC (rev 98339)
+++ trunk/Tools/ChangeLog	2011-10-25 13:49:33 UTC (rev 98340)
@@ -1,3 +1,15 @@
+2011-10-25  Eric Seidel  e...@webkit.org
+
+WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
+https://bugs.webkit.org/show_bug.cgi?id=64471
+
+Reviewed by Adam Roben.
+
+Speculative fix.
+
+* Scripts/webkitpy/layout_tests/port/win.py:
+* Scripts/webkitpy/layout_tests/port/win_unittest.py:
+
 2011-10-24  Mikhail Naganov  mnaga...@chromium.org
 
 Fix bug summary when rolling Chromium DEPS to LKGR.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py (98339 => 98340)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py	2011-10-25 13:49:24 UTC (rev 98339)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py	2011-10-25 13:49:33 UTC (rev 98340)
@@ -72,6 +72,20 @@
 ApplePort.__init__(self, **kwargs)
 self._operating_system = 'win'
 
+def compare_text(self, expected_text, actual_text):
+# Sanity was restored in WK2, so we don't need this hack there.
+if self.get_option('webkit_test_runner'):
+return ApplePort.compare_text(self, expected_text, actual_text)
+
+# This is a hack (which dates back to ORWT).
+# Windows does not have an EDITING DELEGATE, so we strip any EDITING DELEGATE
+# messages to make more of the tests pass.
+# It's possible more of the ports might want this and this could move down into WebKitPort.
+delegate_regexp = re.compile(^EDITING DELEGATE: .*?\n, re.MULTILINE)
+expected_text = delegate_regexp.sub(, expected_text)
+actual_text = delegate_regexp.sub(, actual_text)
+return expected_text != actual_text
+
 def baseline_search_path(self):
 try:
 fallback_index = self.VERSION_FALLBACK_ORDER.index(self._port_name_with_version())


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py (98339 => 98340)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py	2011-10-25 13:49:24 UTC (rev 98339)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py	2011-10-25 13:49:33 UTC (rev 98340)
@@ -94,3 +94,14 @@
 self._assert_version('win-xp', 'xp')
 self._assert_version('win-vista', 'vista')
 self._assert_version('win-7sp0', '7sp0')
+
+def test_compare_text(self):
+expected = EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification\nfoo\nEDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification\n
+port = self.make_port()
+self.assertFalse(port.compare_text(expected, foo\n))
+self.assertTrue(port.compare_text(expected, foo))
+self.assertTrue(port.compare_text(expected, bar))
+
+# This hack doesn't exist in WK2.
+port._options = MockOptions(webkit_test_runner=True)
+self.assertTrue(port.compare_text(expected, foo\n))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98341] trunk/Source/WebCore

[apavlov]

Title: [98341] trunk/Source/WebCore








Revision 98341
Author apav...@chromium.org
Date 2011-10-25 06:57:54 -0700 (Tue, 25 Oct 2011)


Log Message
Web Inspector: [Chromium] Audits panel context menu for links not working properly
https://bugs.webkit.org/show_bug.cgi?id=70813

Reviewed by Pavel Feldman.

* inspector/front-end/AuditResultView.js:
(WebInspector.AuditResultView):
(WebInspector.AuditResultView.prototype._contextMenuEventFired):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/AuditResultView.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (98340 => 98341)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 13:49:33 UTC (rev 98340)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 13:57:54 UTC (rev 98341)
@@ -1,3 +1,14 @@
+2011-10-25  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: [Chromium] Audits panel context menu for links not working properly
+https://bugs.webkit.org/show_bug.cgi?id=70813
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/AuditResultView.js:
+(WebInspector.AuditResultView):
+(WebInspector.AuditResultView.prototype._contextMenuEventFired):
+
 2011-10-25  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Resources panel: display the current search match index in the toolbar.


Modified: trunk/Source/WebCore/inspector/front-end/AuditResultView.js (98340 => 98341)

--- trunk/Source/WebCore/inspector/front-end/AuditResultView.js	2011-10-25 13:49:33 UTC (rev 98340)
+++ trunk/Source/WebCore/inspector/front-end/AuditResultView.js	2011-10-25 13:57:54 UTC (rev 98341)
@@ -43,8 +43,19 @@
 categoryResults.sort(categorySorter);
 for (var i = 0; i  categoryResults.length; ++i)
 this.element.appendChild(new WebInspector.AuditCategoryResultPane(categoryResults[i]).element);
+
+this.element.addEventListener(contextmenu, this._contextMenuEventFired.bind(this), true);
 }
 
+WebInspector.AuditResultView.prototype = {
+_contextMenuEventFired: function(event)
+{
+var contextMenu = new WebInspector.ContextMenu();
+if (WebInspector.populateHrefContextMenu(contextMenu, null, event))
+contextMenu.show(event);
+}
+}
+
 WebInspector.AuditResultView.prototype.__proto__ = WebInspector.View.prototype;
 
 /**






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98342] trunk

[commit-queue]

Title: [98342] trunk








Revision 98342
Author commit-qu...@webkit.org
Date 2011-10-25 07:04:45 -0700 (Tue, 25 Oct 2011)


Log Message
Double number step=.5 should be considered valid in input type=number step=.5
https://bugs.webkit.org/show_bug.cgi?id=70320

Patch by Sachin Puranik sachin.pura...@motorola.com on 2011-10-25
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/input-step-as-double.html

* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType): Changed the function to consider
step as valid even if it starts with .

LayoutTests:

* fast/forms/ValidityState-typeMismatch-number-expected.txt: Change in result of layout test.
* fast/forms/input-step-as-double-expected.txt: Added, expected output for new test case.
* fast/forms/input-step-as-double.html: Added, testcase to make sure that all ports
consider .5 as a valid double value for step attribute of input element.
* fast/forms/input-valueasnumber-number-expected.txt: Change in result of layout test.
* fast/forms/range/input-valueasnumber-range-expected.txt: Change in result of layout test.
* fast/forms/range/input-valueasnumber-range.html: Consider .2 as valid real number now.
* fast/forms/script-tests/ValidityState-typeMismatch-number.js: Consider
.2 as valid real number now.
* fast/forms/script-tests/input-valueasnumber-number.js: Consider .2 as valid real number now.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/ValidityState-typeMismatch-number-expected.txt
trunk/LayoutTests/fast/forms/input-valueasnumber-number-expected.txt
trunk/LayoutTests/fast/forms/range/input-valueasnumber-range-expected.txt
trunk/LayoutTests/fast/forms/range/input-valueasnumber-range.html
trunk/LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-number.js
trunk/LayoutTests/fast/forms/script-tests/input-valueasnumber-number.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp


Added Paths

trunk/LayoutTests/fast/forms/input-step-as-double-expected.txt
trunk/LayoutTests/fast/forms/input-step-as-double.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98341 => 98342)

--- trunk/LayoutTests/ChangeLog	2011-10-25 13:57:54 UTC (rev 98341)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 14:04:45 UTC (rev 98342)
@@ -1,3 +1,21 @@
+2011-10-25  Sachin Puranik  sachin.pura...@motorola.com
+
+Double number step=.5 should be considered valid in input type=number step=.5
+https://bugs.webkit.org/show_bug.cgi?id=70320
+
+Reviewed by Kent Tamura.
+
+* fast/forms/ValidityState-typeMismatch-number-expected.txt: Change in result of layout test.
+* fast/forms/input-step-as-double-expected.txt: Added, expected output for new test case.
+* fast/forms/input-step-as-double.html: Added, testcase to make sure that all ports 
+consider .5 as a valid double value for step attribute of input element.
+* fast/forms/input-valueasnumber-number-expected.txt: Change in result of layout test.
+* fast/forms/range/input-valueasnumber-range-expected.txt: Change in result of layout test.
+* fast/forms/range/input-valueasnumber-range.html: Consider .2 as valid real number now.
+* fast/forms/script-tests/ValidityState-typeMismatch-number.js: Consider
+.2 as valid real number now.
+* fast/forms/script-tests/input-valueasnumber-number.js: Consider .2 as valid real number now.
+
 2011-10-25  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Resources panel: display the current search match index in the toolbar.


Modified: trunk/LayoutTests/fast/forms/ValidityState-typeMismatch-number-expected.txt (98341 => 98342)

--- trunk/LayoutTests/fast/forms/ValidityState-typeMismatch-number-expected.txt	2011-10-25 13:57:54 UTC (rev 98341)
+++ trunk/LayoutTests/fast/forms/ValidityState-typeMismatch-number-expected.txt	2011-10-25 14:04:45 UTC (rev 98342)
@@ -6,6 +6,8 @@
 PASS 0 is a valid number.
 PASS 10 is a valid number.
 PASS 01 is a valid number.
+PASS 0.2 is a valid number.
+PASS .2 is a valid number.
 PASS -0 is a valid number.
 PASS -1.2 is a valid number.
 PASS 1.2E10 is a valid number.
@@ -19,7 +21,6 @@
 PASS  10 was sanitized to .
 PASS 10  was sanitized to .
 PASS 1,2 was sanitized to .
-PASS .2 was sanitized to .
 PASS 1E was sanitized to .
 PASS NaN was sanitized to .
 PASS nan was sanitized to .


Added: trunk/LayoutTests/fast/forms/input-step-as-double-expected.txt (0 => 98342)

--- trunk/LayoutTests/fast/forms/input-step-as-double-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/input-step-as-double-expected.txt	2011-10-25 14:04:45 UTC (rev 98342)
@@ -0,0 +1,10 @@
+Test for a capturing spec change to consider .2 as valid real number for step
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS numberInput.value is 0.5
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: 

[webkit-changes] [98343] trunk

[podivilov]

Title: [98343] trunk








Revision 98343
Author podivi...@chromium.org
Date 2011-10-25 07:22:44 -0700 (Tue, 25 Oct 2011)


Log Message
Web Inspector: keep old source mapping when new one could not be loaded.
https://bugs.webkit.org/show_bug.cgi?id=70729

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):

LayoutTests:

* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js




Diff

Modified: trunk/LayoutTests/ChangeLog (98342 => 98343)

--- trunk/LayoutTests/ChangeLog	2011-10-25 14:04:45 UTC (rev 98342)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 14:22:44 UTC (rev 98343)
@@ -1,3 +1,13 @@
+2011-10-24  Pavel Podivilov  podivi...@chromium.org
+
+Web Inspector: keep old source mapping when new one could not be loaded.
+https://bugs.webkit.org/show_bug.cgi?id=70729
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/raw-source-code-expected.txt:
+* inspector/debugger/raw-source-code.html:
+
 2011-10-25  Sachin Puranik  sachin.pura...@motorola.com
 
 Double number step=.5 should be considered valid in input type=number step=.5


Modified: trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt (98342 => 98343)

--- trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt	2011-10-25 14:04:45 UTC (rev 98342)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt	2011-10-25 14:22:44 UTC (rev 98343)
@@ -15,3 +15,5 @@
 
 Running: testCompilerSourceMapping
 
+Running: testCompilerSourceMappingCouldNotBeLoaded
+


Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (98342 => 98343)

--- trunk/LayoutTests/inspector/debugger/raw-source-code.html	2011-10-25 14:04:45 UTC (rev 98342)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html	2011-10-25 14:22:44 UTC (rev 98343)
@@ -400,6 +400,25 @@
 InspectorTest.assertEquals(content of source2.js, content);
 next();
 }
+},
+
+function testCompilerSourceMappingCouldNotBeLoaded(next)
+{
+var compilerSourceMappingProviderMock = { loadSourceMapping: function(callback) { callback(null); } };
+
+var script = createScriptMock(compiled.js, 0, 0, true, script source);
+var rawSourceCode = createRawSourceCode(script, null);
+var uiSourceCodeList;
+
+waitForSourceMappingEvent(rawSourceCode, checkMapping);
+rawSourceCode.setCompilerSourceMappingProvider(compilerSourceMappingProviderMock);
+
+function checkMapping()
+{
+InspectorTest.assertTrue(false, Should not be reached.);
+}
+
+next();
 }
 ]);
 };


Modified: trunk/Source/WebCore/ChangeLog (98342 => 98343)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 14:04:45 UTC (rev 98342)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 14:22:44 UTC (rev 98343)
@@ -1,3 +1,15 @@
+2011-10-24  Pavel Podivilov  podivi...@chromium.org
+
+Web Inspector: keep old source mapping when new one could not be loaded.
+https://bugs.webkit.org/show_bug.cgi?id=70729
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/RawSourceCode.js:
+(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
+(WebInspector.RawSourceCode.prototype._updateSourceMapping):
+(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):
+
 2011-10-25  Sachin Puranik  sachin.pura...@motorola.com
 
 Double number step=.5 should be considered valid in input type=number step=.5


Modified: trunk/Source/WebCore/inspector/front-end/RawSourceCode.js (98342 => 98343)

--- trunk/Source/WebCore/inspector/front-end/RawSourceCode.js	2011-10-25 14:04:45 UTC (rev 98342)
+++ trunk/Source/WebCore/inspector/front-end/RawSourceCode.js	2011-10-25 14:22:44 UTC (rev 98343)
@@ -159,6 +159,8 @@
 function didCreateSourceMapping(sourceMapping)
 {
 this._updatingSourceMapping = false;
+if (!sourceMapping)
+return;
 if (!this._updateNeeded)
 this._saveSourceMapping(sourceMapping);
 else
@@ -187,6 +189,11 @@
  */
 function didLoadSourceMapping(compilerSourceMapping)
 {
+if (!compilerSourceMapping) {
+delete this._compilerSourceMappingProvider;
+

[webkit-changes] [98344] trunk

[jschuh]

Title: [98344] trunk








Revision 98344
Author jsc...@chromium.org
Date 2011-10-25 07:24:59 -0700 (Tue, 25 Oct 2011)


Log Message
Check for empty string in parseArcFlag
https://bugs.webkit.org/show_bug.cgi?id=70763

Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/path-invalid.html

* svg/SVGParserUtilities.cpp:
(WebCore::parseArcFlag):

LayoutTests:

* svg/path-arc-invalid-expected.txt: Added.
* svg/path-arc-invalid.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGParserUtilities.cpp


Added Paths

trunk/LayoutTests/svg/path-arc-invalid-expected.txt
trunk/LayoutTests/svg/path-arc-invalid.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98343 => 98344)

--- trunk/LayoutTests/ChangeLog	2011-10-25 14:22:44 UTC (rev 98343)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 14:24:59 UTC (rev 98344)
@@ -1,3 +1,13 @@
+2011-10-25  Justin Schuh  jsc...@chromium.org
+
+Check for empty string in parseArcFlag
+https://bugs.webkit.org/show_bug.cgi?id=70763
+
+Reviewed by Dirk Schulze.
+
+* svg/path-arc-invalid-expected.txt: Added.
+* svg/path-arc-invalid.html: Added.
+
 2011-10-24  Pavel Podivilov  podivi...@chromium.org
 
 Web Inspector: keep old source mapping when new one could not be loaded.


Added: trunk/LayoutTests/svg/path-arc-invalid-expected.txt (0 => 98344)

--- trunk/LayoutTests/svg/path-arc-invalid-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/path-arc-invalid-expected.txt	2011-10-25 14:24:59 UTC (rev 98344)
@@ -0,0 +1,2 @@
+CONSOLE MESSAGE: line 6: Error: Problem parsing d=M0 0 A0 0 0 0 0 0 0 0 0 0
+If this text is visible the malformed SVG path is handled correctly.


Added: trunk/LayoutTests/svg/path-arc-invalid.html (0 => 98344)

--- trunk/LayoutTests/svg/path-arc-invalid.html	(rev 0)
+++ trunk/LayoutTests/svg/path-arc-invalid.html	2011-10-25 14:24:59 UTC (rev 98344)
@@ -0,0 +1,8 @@
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+svg
+path d=M0 0 A0 0 0 0 0 0 0 0 0 0/
+/svg
+If this text is visible the malformed SVG path is handled correctly.


Modified: trunk/Source/WebCore/ChangeLog (98343 => 98344)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 14:22:44 UTC (rev 98343)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 14:24:59 UTC (rev 98344)
@@ -1,3 +1,15 @@
+2011-10-25  Justin Schuh  jsc...@chromium.org
+
+Check for empty string in parseArcFlag
+https://bugs.webkit.org/show_bug.cgi?id=70763
+
+Reviewed by Dirk Schulze.
+
+Test: svg/path-invalid.html
+
+* svg/SVGParserUtilities.cpp:
+(WebCore::parseArcFlag):
+
 2011-10-24  Pavel Podivilov  podivi...@chromium.org
 
 Web Inspector: keep old source mapping when new one could not be loaded.


Modified: trunk/Source/WebCore/svg/SVGParserUtilities.cpp (98343 => 98344)

--- trunk/Source/WebCore/svg/SVGParserUtilities.cpp	2011-10-25 14:22:44 UTC (rev 98343)
+++ trunk/Source/WebCore/svg/SVGParserUtilities.cpp	2011-10-25 14:24:59 UTC (rev 98344)
@@ -158,6 +158,8 @@
 // and might not have any whitespace/comma after it
 bool parseArcFlag(const UChar* ptr, const UChar* end, bool flag)
 {
+if (ptr = end)
+return false;
 const UChar flagChar = *ptr++;
 if (flagChar == '0')
 flag = false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98345] trunk

[podivilov]

Title: [98345] trunk








Revision 98345
Author podivi...@chromium.org
Date 2011-10-25 07:26:59 -0700 (Tue, 25 Oct 2011)


Log Message
Web Inspector: fix empty line handling in source maps.
https://bugs.webkit.org/show_bug.cgi?id=70726

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

* inspector/debugger/compiler-source-mapping-expected.txt:
* inspector/debugger/compiler-source-mapping.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt
trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js




Diff

Modified: trunk/LayoutTests/ChangeLog (98344 => 98345)

--- trunk/LayoutTests/ChangeLog	2011-10-25 14:24:59 UTC (rev 98344)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 14:26:59 UTC (rev 98345)
@@ -1,3 +1,13 @@
+2011-10-24  Pavel Podivilov  podivi...@chromium.org
+
+Web Inspector: fix empty line handling in source maps.
+https://bugs.webkit.org/show_bug.cgi?id=70726
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/compiler-source-mapping-expected.txt:
+* inspector/debugger/compiler-source-mapping.html:
+
 2011-10-25  Justin Schuh  jsc...@chromium.org
 
 Check for empty string in parseArcFlag


Modified: trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt (98344 => 98345)

--- trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt	2011-10-25 14:24:59 UTC (rev 98344)
+++ trunk/LayoutTests/inspector/debugger/compiler-source-mapping-expected.txt	2011-10-25 14:26:59 UTC (rev 98345)
@@ -5,3 +5,5 @@
 
 Running: testNoMappingEntry
 
+Running: testEmptyLine
+


Modified: trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html (98344 => 98345)

--- trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html	2011-10-25 14:24:59 UTC (rev 98344)
+++ trunk/LayoutTests/inspector/debugger/compiler-source-mapping.html	2011-10-25 14:26:59 UTC (rev 98345)
@@ -73,6 +73,18 @@
 checkMapping(0, 0, example.js, 0, 0, mapping);
 checkMapping(0, 2, example.js, 0, 2, mapping);
 next();
+},
+
+function testEmptyLine(next)
+{
+var mappingPayload = {
+mappings:;;;CACA,
+sources:[example.js]
+};
+var mapping = new WebInspector.ClosureCompilerSourceMapping(mappingPayload);
+checkMapping(0, 0, example.js, 0, 0, mapping);
+checkReverseMapping(3, 1, example.js, 1, mapping);
+next();
 }
 ]);
 };


Modified: trunk/Source/WebCore/ChangeLog (98344 => 98345)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 14:24:59 UTC (rev 98344)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 14:26:59 UTC (rev 98345)
@@ -1,3 +1,13 @@
+2011-10-24  Pavel Podivilov  podivi...@chromium.org
+
+Web Inspector: fix empty line handling in source maps.
+https://bugs.webkit.org/show_bug.cgi?id=70726
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/CompilerSourceMapping.js:
+(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
+
 2011-10-25  Justin Schuh  jsc...@chromium.org
 
 Check for empty string in parseArcFlag


Modified: trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js (98344 => 98345)

--- trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js	2011-10-25 14:24:59 UTC (rev 98344)
+++ trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js	2011-10-25 14:26:59 UTC (rev 98345)
@@ -151,7 +151,19 @@
 var sourceURL = this._sources[0];
 var reverseMappings = this._reverseMappingsBySourceURL[sourceURL];
 
-do {
+while (true) {
+if (stringCharIterator.peek() === ,)
+stringCharIterator.next();
+else {
+while (stringCharIterator.peek() === ;) {
+lineNumber += 1;
+columnNumber = 0;
+stringCharIterator.next();
+}
+if (!stringCharIterator.hasNext())
+break;
+}
+
 columnNumber += this._decodeVLQ(stringCharIterator);
 if (!this._isSeparator(stringCharIterator.peek())) {
 var sourceIndexDelta = this._decodeVLQ(stringCharIterator);
@@ -169,12 +181,7 @@
 if (!reverseMappings[sourceLineNumber])
 reverseMappings[sourceLineNumber] = [lineNumber, columnNumber];
 }
-
-if (stringCharIterator.next() === ;) {
-lineNumber += 1;
-columnNumber = 0;
-}
-} while(stringCharIterator.hasNext());
+}
 },
 
 _isSeparator: 

[webkit-changes] [98346] trunk

[vsevik]

Title: [98346] trunk








Revision 98346
Author vse...@chromium.org
Date 2011-10-25 08:06:00 -0700 (Tue, 25 Oct 2011)


Log Message
Web Inspector: Debugger fails when there is an invalid watch _expression_.
https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

* inspector/debugger/error-in-watch-expressions.html:
* inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
* inspector/debugger/watch-expressions-panel-switch.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/error-in-watch-expressions.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js


Added Paths

trunk/LayoutTests/inspector/debugger/watch-expressions-panel-switch-expected.txt
trunk/LayoutTests/inspector/debugger/watch-expressions-panel-switch.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98345 => 98346)

--- trunk/LayoutTests/ChangeLog	2011-10-25 14:26:59 UTC (rev 98345)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 15:06:00 UTC (rev 98346)
@@ -1,3 +1,14 @@
+2011-10-25  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Debugger fails when there is an invalid watch _expression_.
+https://bugs.webkit.org/show_bug.cgi?id=70718
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/error-in-watch-expressions.html:
+* inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
+* inspector/debugger/watch-expressions-panel-switch.html: Added.
+
 2011-10-24  Pavel Podivilov  podivi...@chromium.org
 
 Web Inspector: fix empty line handling in source maps.


Modified: trunk/LayoutTests/inspector/debugger/error-in-watch-expressions.html (98345 => 98346)

--- trunk/LayoutTests/inspector/debugger/error-in-watch-expressions.html	2011-10-25 14:26:59 UTC (rev 98345)
+++ trunk/LayoutTests/inspector/debugger/error-in-watch-expressions.html	2011-10-25 15:06:00 UTC (rev 98346)
@@ -7,15 +7,24 @@
 
 var test = function()
 {
+// We need to initialize scripts panel so that watch expressions section is created.
+WebInspector.showPanel(scripts);
+
 var watchExpressionsSection = WebInspector.panels.scripts.sidebarPanes.watchExpressions.section;
-watchExpressionsSection.addExpression();
-watchExpressionsSection.watchExpressions[0] = #$%;
+watchExpressionsSection.watchExpressions = [];
+watchExpressionsSection.watchExpressions.push(#$%);
 watchExpressionsSection.update();
+
 InspectorTest.runAfterPendingDispatches(step1);
 
 function step1()
 {
 InspectorTest.addResult(watchExpressionsSection.element.innerHTML.indexOf(watch-expressions-error-level) !== -1 ? SUCCESS : FAILED);
+
+// Clear watch expressions after execution.
+watchExpressionsSection.watchExpressions = [];
+watchExpressionsSection.update();
+
 InspectorTest.completeTest();
 }
 }


Added: trunk/LayoutTests/inspector/debugger/watch-expressions-panel-switch-expected.txt (0 => 98346)

--- trunk/LayoutTests/inspector/debugger/watch-expressions-panel-switch-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/watch-expressions-panel-switch-expected.txt	2011-10-25 15:06:00 UTC (rev 98346)
@@ -0,0 +1,11 @@
+Tests debugger does not fail when stopped while a panel other than scripts was opened. Both valid and invalid expressions are added to watch expressions.
+
+Bug 70718
+Script source was shown.
+Set timer for test function.
+Watch expressions updated.
+[expanded]  
+window.document: HTMLDocument
+windowa.document: ReferenceError: windowa is not defined
+Debugger was disabled.
+


Added: trunk/LayoutTests/inspector/debugger/watch-expressions-panel-switch.html (0 => 98346)

--- trunk/LayoutTests/inspector/debugger/watch-expressions-panel-switch.html	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/watch-expressions-panel-switch.html	2011-10-25 15:06:00 UTC (rev 98346)
@@ -0,0 +1,65 @@
+html
+head
+script src=""
+script src=""
+script src=""
+script
+function testFunction()
+{
+var x = Math.sqrt(10);
+return x;
+}
+
+var test = function()
+{
+InspectorTest.setQuiet(true);
+
+// We need to initialize scripts panel so that watch expressions section is created.
+WebInspector.showPanel(scripts);
+
+var watchExpressionsSection = WebInspector.panels.scripts.sidebarPanes.watchExpressions.section;
+watchExpressionsSection.watchExpressions = [];
+watchExpressionsSection.watchExpressions.push(window.document);
+watchExpressionsSection.watchExpressions.push(windowa.document);
+watchExpressionsSection.update();
+
+var testName = WebInspector.mainResource.url;
+testName = testName.substring(testName.lastIndexOf('/') + 1);
+

[webkit-changes] [98347] trunk/Source

[thakis]

Title: [98347] trunk/Source








Revision 98347
Author tha...@chromium.org
Date 2011-10-25 08:21:15 -0700 (Tue, 25 Oct 2011)


Log Message
Source/WebCore: [chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium: [chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70753

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.


* WebKit.gypi:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (98346 => 98347)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 15:06:00 UTC (rev 98346)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 15:21:15 UTC (rev 98347)
@@ -1,3 +1,15 @@
+2011-10-25  Nico Weber  tha...@chromium.org
+
+[chromium/mac] Fix an ODR violation.
+https://bugs.webkit.org/show_bug.cgi?id=70753
+
+Reviewed by Anders Carlsson.
+
+Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
+Remove the unused one.
+
+* WebCore.gyp/WebCore.gyp:
+
 2011-10-25  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Debugger fails when there is an invalid watch _expression_.


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (98346 => 98347)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-10-25 15:06:00 UTC (rev 98346)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-10-25 15:21:15 UTC (rev 98347)
@@ -1465,7 +1465,7 @@
 
 # Cherry-pick some files that can't be included by broader regexps.
 # Some of these are used instead of Chromium platform files, see
-# the specific exclusions in the sources! list below.
+# the specific exclusions in the exclude list below.
 ['include', 'rendering/RenderThemeMac\\.mm$'],
 ['include', 'platform/graphics/mac/ColorMac\\.mm$'],
 ['include', 'platform/graphics/mac/ComplexTextControllerCoreText\\.mm$'],
@@ -1505,6 +1505,10 @@
 ['exclude', 'platform/graphics/cg/ImageSourceCG\\.cpp$'],
 ['exclude', 'platform/graphics/cg/PDFDocumentImage\\.cpp$'],
 
+# Mac uses only ScrollAnimatorMac.
+['exclude', 'platform/ScrollAnimatorNone\\.cpp$'],
+['exclude', 'platform/ScrollAnimatorNone\\.h$'],
+
 ['include', '/chrome/junk\\.txt$'],
   ],
 },{ # OS!=mac
@@ -1518,7 +1522,7 @@
   'sources/': [
 # Cherry-pick some files that can't be included by broader regexps.
 # Some of these are used instead of Chromium platform files, see
-# the specific exclusions in the sources! list below.
+# the specific exclusions in the exclude list below.
 ['include', 'platform/graphics/mac/GraphicsContextMac\\.mm$'],
 
 # Chromium Mac does not use skia.


Modified: trunk/Source/WebKit/chromium/ChangeLog (98346 => 98347)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 15:06:00 UTC (rev 98346)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 15:21:15 UTC (rev 98347)
@@ -1,3 +1,14 @@
+2011-10-25  Nico Weber  tha...@chromium.org
+
+[chromium] Try to fix mac build after r98294
+https://bugs.webkit.org/show_bug.cgi?id=70753
+
+Remove test for ScrollAnimatorNone on mac.
+
+Unreviewed, build fix.
+
+* WebKit.gypi:
+
 2011-10-24  Geoffrey Garen  gga...@apple.com
 
 Removed SharedUChar and tightened language around its previous uses


Modified: trunk/Source/WebKit/chromium/WebKit.gypi (98346 => 98347)

--- trunk/Source/WebKit/chromium/WebKit.gypi	2011-10-25 15:06:00 UTC (rev 98346)
+++ trunk/Source/WebKit/chromium/WebKit.gypi	2011-10-25 15:21:15 UTC (rev 98347)
@@ -75,7 +75,6 @@
 'tests/PODArenaTest.cpp',
 'tests/PODIntervalTreeTest.cpp',
 'tests/PODRedBlackTreeTest.cpp',
-'tests/ScrollAnimatorNoneTest.cpp',
 'tests/TilingDataTest.cpp',
 'tests/TreeSynchronizerTest.cpp',
 'tests/TreeTestHelpers.cpp',
@@ -99,6 +98,12 @@
 'tests/WebPageSerializerTest.cpp',
 ],
 }],
+['OS!=mac', {
+'webkit_unittest_files': [
+# Mac uses ScrollAnimatorMac instead of ScrollAnimatorNone.
+'tests/ScrollAnimatorNoneTest.cpp',
+],
+}],
 ['toolkit_uses_gtk == 1', {
 'webkit_unittest_files': [
 # FIXME: Port DragImageTest to Mac.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [98348] trunk

[yurys]

Title: [98348] trunk








Revision 98348
Author yu...@chromium.org
Date 2011-10-25 08:35:50 -0700 (Tue, 25 Oct 2011)


Log Message
Web Inspector: redesign workers sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=70815

Source/WebCore:

Changed workers sidebar pane design.

Now there is a link to worker inspector for each dedicated worker created
by inspected page. The sidebar display a link to a page with list of all
shared workers if there one is supported by the WebKit port. Also there
is a checkbox that allows pause all new workers on first statements.

Reviewed by Pavel Feldman.

* inspector/front-end/Settings.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
(WebInspector.WorkerListSidebarPane.prototype._workersCleared):
(WebInspector.WorkerListSidebarPane.prototype._addWorker):
(WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink.link.onclick):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink):
* inspector/front-end/elementsPanel.css:
* inspector/front-end/inspectorCommon.css:
(.sidebar-separator):
(.sidebar-label):
* inspector/front-end/scriptsPanel.css:
(.dedicated-worker-item):
(#shared-workers-list):
(#pause-workers-checkbox  input):

Source/WebKit/chromium:

Reviewed by Pavel Feldman.

* src/js/DevTools.js: Expose link to shared workers inspection page to WebCore.
():

LayoutTests:

Update tests in accord with change of class name from
styles-sidebar-pane to sidebar-pane.

Reviewed by Pavel Feldman.

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/elements-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
trunk/Source/WebCore/inspector/front-end/WorkerManager.js
trunk/Source/WebCore/inspector/front-end/WorkersSidebarPane.js
trunk/Source/WebCore/inspector/front-end/elementsPanel.css
trunk/Source/WebCore/inspector/front-end/inspectorCommon.css
trunk/Source/WebCore/inspector/front-end/scriptsPanel.css
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/DevTools.js




Diff

Modified: trunk/LayoutTests/ChangeLog (98347 => 98348)

--- trunk/LayoutTests/ChangeLog	2011-10-25 15:21:15 UTC (rev 98347)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 15:35:50 UTC (rev 98348)
@@ -1,3 +1,16 @@
+2011-10-25  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: redesign workers sidebar pane
+https://bugs.webkit.org/show_bug.cgi?id=70815
+
+Update tests in accord with change of class name from
+styles-sidebar-pane to sidebar-pane.
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/elements-test.js:
+(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):
+
 2011-10-25  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Debugger fails when there is an invalid watch _expression_.


Modified: trunk/LayoutTests/http/tests/inspector/elements-test.js (98347 => 98348)

--- trunk/LayoutTests/http/tests/inspector/elements-test.js	2011-10-25 15:21:15 UTC (rev 98347)
+++ trunk/LayoutTests/http/tests/inspector/elements-test.js	2011-10-25 15:35:50 UTC (rev 98348)
@@ -122,7 +122,7 @@
 continue;
 if (section.rule  excludeMatched)
 continue;
-if (section.element.previousSibling  section.element.previousSibling.className === styles-sidebar-separator)
+if (section.element.previousSibling  section.element.previousSibling.className === sidebar-separator)
 InspectorTest.addResult(  + section.element.previousSibling.textContent +  );
 InspectorTest.addResult((section.expanded ? [expanded]  : [collapsed] ) + section.titleElement.textContent +  ( + section.subtitleAsTextForTest + ));
 section.expand();


Modified: trunk/Source/WebCore/ChangeLog (98347 => 98348)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 15:21:15 UTC (rev 98347)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 15:35:50 UTC (rev 98348)
@@ -1,3 +1,41 @@
+2011-10-25  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: redesign workers sidebar pane
+https://bugs.webkit.org/show_bug.cgi?id=70815
+
+Changed workers sidebar pane design.
+
+Now there is a link 

[webkit-changes] [98350] trunk

[mitz]

Title: [98350] trunk








Revision 98350
Author m...@apple.com
Date 2011-10-25 09:39:23 -0700 (Tue, 25 Oct 2011)


Log Message
rdar://problem/10337033 DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none

Reviewed by Adam Roben.

Source/WebCore: 

Test: added to TestWebKitAPI/Tests/mac/DOMRangeOfString.mm

* page/Page.cpp:
(WebCore::Page::rangeOfString): This function was incorrectly adding the StartInSelection option to
the initial search.

Tools: 

* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/mac/DOMRangeOfString.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (98349 => 98350)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 16:26:15 UTC (rev 98349)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 16:39:23 UTC (rev 98350)
@@ -1,3 +1,15 @@
+2011-10-25  Dan Bernstein  m...@apple.com
+
+rdar://problem/10337033 DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
+
+Reviewed by Adam Roben.
+
+Test: added to TestWebKitAPI/Tests/mac/DOMRangeOfString.mm
+
+* page/Page.cpp:
+(WebCore::Page::rangeOfString): This function was incorrectly adding the StartInSelection option to
+the initial search.
+
 2011-10-25  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: redesign workers sidebar pane


Modified: trunk/Source/WebCore/page/Page.cpp (98349 => 98350)

--- trunk/Source/WebCore/page/Page.cpp	2011-10-25 16:26:15 UTC (rev 98349)
+++ trunk/Source/WebCore/page/Page.cpp	2011-10-25 16:39:23 UTC (rev 98350)
@@ -522,7 +522,7 @@
 Frame* frame = referenceRange ? referenceRange-ownerDocument()-frame() : mainFrame();
 Frame* startFrame = frame;
 do {
-if (RefPtrRange resultRange = frame-editor()-rangeOfString(target, frame == startFrame ? referenceRange : 0, (options  ~WrapAround) | StartInSelection))
+if (RefPtrRange resultRange = frame-editor()-rangeOfString(target, frame == startFrame ? referenceRange : 0, options  ~WrapAround))
 return resultRange.release();
 
 frame = incrementFrame(frame, !(options  Backwards), shouldWrap);


Modified: trunk/Tools/ChangeLog (98349 => 98350)

--- trunk/Tools/ChangeLog	2011-10-25 16:26:15 UTC (rev 98349)
+++ trunk/Tools/ChangeLog	2011-10-25 16:39:23 UTC (rev 98350)
@@ -1,3 +1,12 @@
+2011-10-25  Dan Bernstein  m...@apple.com
+
+rdar://problem/10337033 DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
+
+Reviewed by Adam Roben.
+
+* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
+(TestWebKitAPI::TEST):
+
 2011-10-25  Eric Seidel  e...@webkit.org
 
 WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped


Modified: trunk/Tools/TestWebKitAPI/Tests/mac/DOMRangeOfString.mm (98349 => 98350)

--- trunk/Tools/TestWebKitAPI/Tests/mac/DOMRangeOfString.mm	2011-10-25 16:26:15 UTC (rev 98349)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/DOMRangeOfString.mm	2011-10-25 16:39:23 UTC (rev 98350)
@@ -68,6 +68,12 @@
 resultRange = [webView.get() DOMRangeOfString:@stack relativeTo:needleRange options:WebFindOptionsBackwards];
 EXPECT_EQ(nil, resultRange);
 
+resultRange = [webView.get() DOMRangeOfString:@n relativeTo:needleRange options:0];
+EXPECT_EQ(36, resultRange.startOffset);
+
+resultRange = [webView.get() DOMRangeOfString:@n relativeTo:needleRange options:WebFindOptionsStartInSelection];
+EXPECT_EQ(28, resultRange.startOffset);
+
 RetainPtrWebView otherWebView(AdoptNS, [[WebView alloc] initWithFrame:NSZeroRect frameName:nil groupName:nil]);
 DOMRange *foreignRange = [[[otherWebView.get() mainFrame] DOMDocument] createRange];
 resultRange = [webView.get() DOMRangeOfString:@needle relativeTo:foreignRange options:0];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98351] trunk/Tools

[commit-queue]

Title: [98351] trunk/Tools








Revision 98351
Author commit-qu...@webkit.org
Date 2011-10-25 09:40:29 -0700 (Tue, 25 Oct 2011)


Log Message
[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
https://bugs.webkit.org/show_bug.cgi?id=70603

Patch by Vamshikrishna Yellenki vam...@motorola.com on 2011-10-25
Reviewed by Gustavo Noronha Silva.

* MiniBrowser/gtk/BrowserWindow.c:
(focus):
(unFocus):
(browserWindowUIClientInit):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c




Diff

Modified: trunk/Tools/ChangeLog (98350 => 98351)

--- trunk/Tools/ChangeLog	2011-10-25 16:39:23 UTC (rev 98350)
+++ trunk/Tools/ChangeLog	2011-10-25 16:40:29 UTC (rev 98351)
@@ -1,3 +1,15 @@
+2011-10-25  Vamshikrishna Yellenki  vam...@motorola.com
+
+[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
+https://bugs.webkit.org/show_bug.cgi?id=70603
+
+Reviewed by Gustavo Noronha Silva.
+
+* MiniBrowser/gtk/BrowserWindow.c:
+(focus):
+(unFocus):
+(browserWindowUIClientInit):
+
 2011-10-25  Dan Bernstein  m...@apple.com
 
 rdar://problem/10337033 DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none


Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (98350 => 98351)

--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2011-10-25 16:39:23 UTC (rev 98350)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2011-10-25 16:40:29 UTC (rev 98351)
@@ -563,6 +563,19 @@
 return dialog;
 }
 
+static void focus(WKPageRef page, const void *clientInfo)
+{
+BrowserWindow *window = BROWSER_WINDOW(clientInfo);
+gtk_widget_grab_focus(GTK_WIDGET(window-webView));
+} 
+
+static void unfocus(WKPageRef page, const void *clientInfo)
+{
+BrowserWindow *window = BROWSER_WINDOW(clientInfo);
+if (gtk_widget_is_toplevel(GTK_WIDGET(window)))
+gtk_window_set_focus(GTK_WINDOW(window), NULL);
+} 
+
 static void runJavaScriptAlert(WKPageRef page, WKStringRef message, WKFrameRef frame, const void *clientInfo)
 {
 GtkWidget *dialog = createMessageDialog(GTK_WINDOW(clientInfo), GTK_MESSAGE_WARNING, GTK_BUTTONS_CLOSE, GTK_RESPONSE_CLOSE, message, frame);
@@ -621,8 +634,8 @@
 showPage,
 closePage,
 0,  /* takeFocus */
-0,  /* focus */
-0,  /* unfocus */
+focus,
+unfocus,
 runJavaScriptAlert,
 runJavaScriptConfirm,
 runJavaScriptPrompt,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98352] trunk/Source/WebKit/gtk

[commit-queue]

Title: [98352] trunk/Source/WebKit/gtk








Revision 98352
Author commit-qu...@webkit.org
Date 2011-10-25 09:52:50 -0700 (Tue, 25 Oct 2011)


Log Message
[GTK] GtkAdjustment watcher updates adjustments too lazily
https://bugs.webkit.org/show_bug.cgi?id=70180

Patch by Martin Robinson mrobin...@igalia.com on 2011-10-25
Reviewed by Gustavo Noronha Silva.

Increase the priority of the GtkAdjustments update in GtkAdjustmentWatcher. This
means that adjustments will more quickly represent the state of the WebKitWebView
when it scrolls. This fixes out-of-sync scrollbars and some visual artifacts.

* WebCoreSupport/GtkAdjustmentWatcher.cpp:
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): Use a timeout
with the default priority.

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (98351 => 98352)

--- trunk/Source/WebKit/gtk/ChangeLog	2011-10-25 16:40:29 UTC (rev 98351)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-10-25 16:52:50 UTC (rev 98352)
@@ -1,3 +1,18 @@
+2011-10-25  Martin Robinson  mrobin...@igalia.com
+
+[GTK] GtkAdjustment watcher updates adjustments too lazily
+https://bugs.webkit.org/show_bug.cgi?id=70180
+
+Reviewed by Gustavo Noronha Silva.
+
+Increase the priority of the GtkAdjustments update in GtkAdjustmentWatcher. This
+means that adjustments will more quickly represent the state of the WebKitWebView
+when it scrolls. This fixes out-of-sync scrollbars and some visual artifacts.
+
+* WebCoreSupport/GtkAdjustmentWatcher.cpp:
+(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): Use a timeout
+with the default priority.
+
 2011-10-24  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Remove g_thread_init() calls


Modified: trunk/Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp (98351 => 98352)

--- trunk/Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp	2011-10-25 16:40:29 UTC (rev 98351)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/GtkAdjustmentWatcher.cpp	2011-10-25 16:52:50 UTC (rev 98352)
@@ -83,9 +83,8 @@
 // The fact that this method was called means that we need to update the scrollbars, but at the
 // time of invocation they are not updated to reflect the scroll yet. We set a short timeout
 // here, which means that they will be updated as soon as WebKit returns to the main loop.
-m_updateAdjustmentCallbackId = g_timeout_add_full(G_PRIORITY_HIGH_IDLE + 10, 0,
-  reinterpret_castGSourceFunc(updateAdjustmentCallback), 
-  const_castvoid*(static_castconst void*(this)), 0);
+m_updateAdjustmentCallbackId = g_timeout_add(0, reinterpret_castGSourceFunc(updateAdjustmentCallback),
+ const_castvoid*(static_castconst void*(this)));
 }
 
 static void adjustmentValueChangedCallback(GtkAdjustment* adjustment, GtkAdjustmentWatcher* watcher)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98353] trunk

[commit-queue]

Title: [98353] trunk








Revision 98353
Author commit-qu...@webkit.org
Date 2011-10-25 09:53:52 -0700 (Tue, 25 Oct 2011)


Log Message
Source/WebCore: Microdata: itemtype attribute should be space-separated list to allow multiple types.
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha a...@motorola.com on 2011-10-25
Reviewed by Ryosuke Niwa.

Tests: fast/dom/MicroData/getitems-multiple-itemtypes.html
   fast/dom/MicroData/itemtype-add-remove-tokens.html
   fast/dom/MicroData/itemtype-attribute-test.html

* dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::nodeMatches):
* html/DOMSettableTokenList.h:
(WebCore::DOMSettableTokenList::tokens):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::setItemValueText):
(WebCore::HTMLElement::itemType):
(WebCore::HTMLElement::setItemType):
* html/HTMLElement.h:
* html/HTMLElement.idl:

LayoutTests: Microdata: itemtype attribute should be space-separated list to allow multiple types
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha a...@motorola.com on 2011-10-25
Reviewed by Ryosuke Niwa.

* fast/dom/MicroData/006.html:
* fast/dom/MicroData/007.html:
* fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Added.
* fast/dom/MicroData/getitems-multiple-itemtypes.html: Added.
* fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Added.
* fast/dom/MicroData/itemtype-add-remove-tokens.html: Added.
* fast/dom/MicroData/itemtype-attribute-test-expected.txt: Added.
* fast/dom/MicroData/itemtype-attribute-test.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/MicroData/006.html
trunk/LayoutTests/fast/dom/MicroData/007.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MicroDataItemList.cpp
trunk/Source/WebCore/html/DOMSettableTokenList.h
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/html/HTMLElement.h
trunk/Source/WebCore/html/HTMLElement.idl


Added Paths

trunk/LayoutTests/fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt
trunk/LayoutTests/fast/dom/MicroData/getitems-multiple-itemtypes.html
trunk/LayoutTests/fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt
trunk/LayoutTests/fast/dom/MicroData/itemtype-add-remove-tokens.html
trunk/LayoutTests/fast/dom/MicroData/itemtype-attribute-test-expected.txt
trunk/LayoutTests/fast/dom/MicroData/itemtype-attribute-test.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98352 => 98353)

--- trunk/LayoutTests/ChangeLog	2011-10-25 16:52:50 UTC (rev 98352)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 16:53:52 UTC (rev 98353)
@@ -1,3 +1,19 @@
+2011-10-25  Arko Saha  a...@motorola.com
+
+Microdata: itemtype attribute should be space-separated list to allow multiple types
+https://bugs.webkit.org/show_bug.cgi?id=70501
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/MicroData/006.html:
+* fast/dom/MicroData/007.html:
+* fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Added.
+* fast/dom/MicroData/getitems-multiple-itemtypes.html: Added.
+* fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Added.
+* fast/dom/MicroData/itemtype-add-remove-tokens.html: Added.
+* fast/dom/MicroData/itemtype-attribute-test-expected.txt: Added.
+* fast/dom/MicroData/itemtype-attribute-test.html: Added.
+
 2011-10-25  Cary Clark  carycl...@google.com
 
 Unreviewed gardening: fourth chunk of baselines for Chromium-Skia


Modified: trunk/LayoutTests/fast/dom/MicroData/006.html (98352 => 98353)

--- trunk/LayoutTests/fast/dom/MicroData/006.html	2011-10-25 16:52:50 UTC (rev 98352)
+++ trunk/LayoutTests/fast/dom/MicroData/006.html	2011-10-25 16:53:52 UTC (rev 98353)
@@ -7,9 +7,9 @@
 pThis tests that document.getItems must locate items when parameters are separated by spaces.
 brThis test also ensure that document.getItems must ignore duplicated tokens.
 /p
-div itemscope itemtype=http://example.com/foo/div
-div itemscope itemtype=http://example.com/bar
-div itemscope itemtype=data:text/plain/div
+div itemscope itemtype=http://example.com/foo http://example.com/bar data:text/plain/div
+div itemscope itemtype=http://example.com/bar http://example.com/foo
+div itemscope itemtype=data:text/plain http://example.com/foo/div
 /div
 div id=console/div
 script


Modified: trunk/LayoutTests/fast/dom/MicroData/007.html (98352 => 98353)

--- trunk/LayoutTests/fast/dom/MicroData/007.html	2011-10-25 16:52:50 UTC (rev 98352)
+++ trunk/LayoutTests/fast/dom/MicroData/007.html	2011-10-25 16:53:52 UTC (rev 98353)
@@ -14,7 +14,7 @@
 div itemscope id=five/div
 div id=console/div
 script
-var nodeList = document.getItems('http://example.com/bar data:text/plain, http://example.com/foo');
+var nodeList = document.getItems();
 
 shouldBe(nodeList[0].id, 'one');
 shouldBe(nodeList[1].id, 'two');


Added: trunk/LayoutTests/fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt (0 => 98353)

--- 

[webkit-changes] [98354] trunk/Tools

[annacc]

Title: [98354] trunk/Tools








Revision 98354
Author ann...@chromium.org
Date 2011-10-25 10:04:05 -0700 (Tue, 25 Oct 2011)


Log Message
Enable running of track layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70803

Reviewed by Adam Barth.

Make DumpRenderTree/TestShell always run with track enabled
(equivalent of --enable-video-track).

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp




Diff

Modified: trunk/Tools/ChangeLog (98353 => 98354)

--- trunk/Tools/ChangeLog	2011-10-25 16:53:52 UTC (rev 98353)
+++ trunk/Tools/ChangeLog	2011-10-25 17:04:05 UTC (rev 98354)
@@ -1,3 +1,16 @@
+2011-10-25  Anna Cavender  ann...@chromium.org
+
+Enable running of track layout tests for Chromium
+https://bugs.webkit.org/show_bug.cgi?id=70803
+
+Reviewed by Adam Barth.
+
+Make DumpRenderTree/TestShell always run with track enabled
+(equivalent of --enable-video-track).
+
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::TestShell):
+
 2011-10-25  Vamshikrishna Yellenki  vam...@motorola.com
 
 [WK2]Main window never gets focus using TAB key in WebKit2 GTK+.


Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (98353 => 98354)

--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2011-10-25 16:53:52 UTC (rev 98353)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2011-10-25 17:04:05 UTC (rev 98354)
@@ -121,6 +121,7 @@
 WebRuntimeFeatures::enableJavaScriptI18NAPI(true);
 WebRuntimeFeatures::enableMediaStream(true);
 WebRuntimeFeatures::enableWebAudio(true); 
+WebRuntimeFeatures::enableVideoTrack(true);
 
 m_webPermissions = adoptPtr(new WebPermissions(this));
 m_accessibilityController = adoptPtr(new AccessibilityController(this));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98356] trunk/Source/WebKit/chromium

[nduca]

Title: [98356] trunk/Source/WebKit/chromium








Revision 98356
Author nd...@chromium.org
Date 2011-10-25 10:18:38 -0700 (Tue, 25 Oct 2011)


Log Message
Unreviewed. Rolled DEPS.

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (98355 => 98356)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 17:17:46 UTC (rev 98355)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 17:18:38 UTC (rev 98356)
@@ -1,3 +1,9 @@
+2011-10-25  Nat Duca  nd...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
 2011-10-25  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: redesign workers sidebar pane


Modified: trunk/Source/WebKit/chromium/DEPS (98355 => 98356)

--- trunk/Source/WebKit/chromium/DEPS	2011-10-25 17:17:46 UTC (rev 98355)
+++ trunk/Source/WebKit/chromium/DEPS	2011-10-25 17:18:38 UTC (rev 98356)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '106896'
+  'chromium_rev': '107113'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98357] trunk/Source/WebKit/chromium

[commit-queue]

Title: [98357] trunk/Source/WebKit/chromium








Revision 98357
Author commit-qu...@webkit.org
Date 2011-10-25 10:22:37 -0700 (Tue, 25 Oct 2011)


Log Message
Re-enable touch tests (from 66577)
https://bugs.webkit.org/show_bug.cgi?id=70351

Patch by Gene Girard gir...@chromium.org on 2011-10-25
Reviewed by Adam Barth.

* tests/InnerGestureRecognizerTest.cpp:
(TEST_F):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (98356 => 98357)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 17:18:38 UTC (rev 98356)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 17:22:37 UTC (rev 98357)
@@ -1,3 +1,13 @@
+2011-10-25  Gene Girard  gir...@chromium.org
+
+Re-enable touch tests (from 66577)
+https://bugs.webkit.org/show_bug.cgi?id=70351
+
+Reviewed by Adam Barth.
+
+* tests/InnerGestureRecognizerTest.cpp:
+(TEST_F):
+
 2011-10-25  Nat Duca  nd...@chromium.org
 
 Unreviewed. Rolled DEPS.


Modified: trunk/Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp (98356 => 98357)

--- trunk/Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp	2011-10-25 17:18:38 UTC (rev 98356)
+++ trunk/Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp	2011-10-25 17:22:37 UTC (rev 98357)
@@ -344,13 +344,7 @@
 ASSERT_EQ(GestureRecognizerChromium::NoGesture, gm.state());
 }
 
-#if OS(MAC_OS_X)
-#define MAYBE_doubleTapGestureIncompleteTest DISABLED_doubleTapGestureIncompleteTest
-#else
-#define MAYBE_doubleTapGestureIncompleteTest doubleTapGestureIncompleteTest
-#endif
-
-TEST_F(GestureRecognizerTest, MAYBE_doubleTapGestureIncompleteTest)
+TEST_F(GestureRecognizerTest, doubleTapGestureIncompleteTest)
 {
 InspectableGestureRecognizerChromium gm;
 SimulateAndTestFirstClick(gm);
@@ -379,13 +373,7 @@
 ASSERT_EQ(GestureRecognizerChromium::NoGesture, gm.state());
 }
 
-#if OS(MAC_OS_X)
-#define MAYBE_doubleTapGestureIncompleteDueToSecondClickPositionTest DISABLED_doubleTapGestureIncompleteDueToSecondClickPositionTest
-#else
-#define MAYBE_doubleTapGestureIncompleteDueToSecondClickPositionTest doubleTapGestureIncompleteDueToSecondClickPositionTest
-#endif
-
-TEST_F(GestureRecognizerTest, MAYBE_doubleTapGestureIncompleteDueToSecondClickPositionTest)
+TEST_F(GestureRecognizerTest, doubleTapGestureIncompleteDueToSecondClickPositionTest)
 {
 InspectableGestureRecognizerChromium gm;
 SimulateAndTestFirstClick(gm);
@@ -435,13 +423,7 @@
 ASSERT_EQ(GestureRecognizerChromium::NoGesture, gm.state());
 }
 
-#if OS(MAC_OS_X)
-#define MAYBE_tapDownWithTapGestureTest DISABLED_tapDownWithTapGestureTest
-#else
-#define MAYBE_tapDownWithTapGestureTest tapDownWithTapGestureTest
-#endif
-
-TEST_F(GestureRecognizerTest, MAYBE_tapDownWithTapGestureTest)
+TEST_F(GestureRecognizerTest, tapDownWithTapGestureTest)
 {
 InspectableGestureRecognizerChromium gm;
 ASSERT_EQ(GestureRecognizerChromium::NoGesture, gm.state());
@@ -467,13 +449,8 @@
 ASSERT_EQ(GestureRecognizerChromium::NoGesture, gm.state());
 }
 
-#if OS(WINDOWS) || OS(MAC_OS_X)
-#define MAYBE_noDoubleTapGestureBecauseOfInterTouchIntervalTest DISABLED_noDoubleTapGestureBecauseOfInterTouchIntervalTest
-#else
-#define MAYBE_noDoubleTapGestureBecauseOfInterTouchIntervalTest noDoubleTapGestureBecauseOfInterTouchIntervalTest
-#endif
 
-TEST_F(GestureRecognizerTest, MAYBE_noDoubleTapGestureBecauseOfInterTouchIntervalTest)
+TEST_F(GestureRecognizerTest, noDoubleTapGestureBecauseOfInterTouchIntervalTest)
 {
 InspectableGestureRecognizerChromium gm;
 SimulateAndTestFirstClick(gm);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98358] trunk/Source/WebCore

[rniwa]

Title: [98358] trunk/Source/WebCore








Revision 98358
Author rn...@webkit.org
Date 2011-10-25 10:22:50 -0700 (Tue, 25 Oct 2011)


Log Message
Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=70755

Reviewed by Chang Shu.

Merged endOfLine with logicalEndOfLine, and startOfLine with logicalStartOfLine
to reduce the code duplication.

* editing/visible_units.cpp:
(WebCore::startPositionForLine):
(WebCore::startOfLine):
(WebCore::logicalStartOfLine):
(WebCore::endPositionForLine):
(WebCore::inSameLogicalLine):
(WebCore::endOfLine):
(WebCore::logicalEndOfLine):
* editing/visible_units.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/visible_units.cpp
trunk/Source/WebCore/editing/visible_units.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (98357 => 98358)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 17:22:37 UTC (rev 98357)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 17:22:50 UTC (rev 98358)
@@ -1,3 +1,23 @@
+2011-10-24  Ryosuke Niwa  rn...@webkit.org
+
+Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
+https://bugs.webkit.org/show_bug.cgi?id=70755
+
+Reviewed by Chang Shu.
+
+Merged endOfLine with logicalEndOfLine, and startOfLine with logicalStartOfLine
+to reduce the code duplication.
+
+* editing/visible_units.cpp:
+(WebCore::startPositionForLine):
+(WebCore::startOfLine):
+(WebCore::logicalStartOfLine):
+(WebCore::endPositionForLine):
+(WebCore::inSameLogicalLine):
+(WebCore::endOfLine):
+(WebCore::logicalEndOfLine):
+* editing/visible_units.h:
+
 2011-10-25  Arko Saha  a...@motorola.com
 
 Microdata: itemtype attribute should be space-separated list to allow multiple types.


Modified: trunk/Source/WebCore/editing/visible_units.cpp (98357 => 98358)

--- trunk/Source/WebCore/editing/visible_units.cpp	2011-10-25 17:22:37 UTC (rev 98357)
+++ trunk/Source/WebCore/editing/visible_units.cpp	2011-10-25 17:22:50 UTC (rev 98358)
@@ -327,8 +327,10 @@
 
 return c;
 }
+
 
-static VisiblePosition startPositionForLine(const VisiblePosition c)
+enum LineEndpointComputationMode { UseLogicalOrdering, UseInlineBoxOrdering };
+static VisiblePosition startPositionForLine(const VisiblePosition c, LineEndpointComputationMode mode)
 {
 if (c.isNull())
 return VisiblePosition();
@@ -343,41 +345,67 @@
 
 return VisiblePosition();
 }
-
-// Generated content (e.g. list markers and CSS :before and :after
-// pseudoelements) have no corresponding DOM element, and so cannot be
-// represented by a VisiblePosition.  Use whatever follows instead.
-InlineBox *startBox = rootBox-firstLeafChild();
-Node *startNode;
-while (1) {
-if (!startBox)
-return VisiblePosition();
 
-RenderObject *startRenderer = startBox-renderer();
-if (!startRenderer)
+Node* startNode;
+InlineBox* startBox;
+if (mode == UseLogicalOrdering) {
+startNode = rootBox-getLogicalStartBoxWithNode(startBox);
+if (!startNode)
 return VisiblePosition();
+} else {
+// Generated content (e.g. list markers and CSS :before and :after pseudoelements) have no corresponding DOM element,
+// and so cannot be represented by a VisiblePosition. Use whatever follows instead.
+startBox = rootBox-firstLeafChild();
+while (true) {
+if (!startBox)
+return VisiblePosition();
 
-startNode = startRenderer-node();
-if (startNode)
-break;
-
-startBox = startBox-nextLeafChild();
+RenderObject* startRenderer = startBox-renderer();
+if (!startRenderer)
+return VisiblePosition();
+
+startNode = startRenderer-node();
+if (startNode)
+break;
+
+startBox = startBox-nextLeafChild();
+}
 }
-
-VisiblePosition visPos = startNode-isTextNode() ? VisiblePosition(Position(static_castText*(startNode), static_castInlineTextBox*(startBox)-start()), DOWNSTREAM)
- : VisiblePosition(positionBeforeNode(startNode), DOWNSTREAM);
-return positionAvoidingFirstPositionInTable(visPos);
+
+if (startNode-isTextNode())
+return positionAvoidingFirstPositionInTable(Position(static_castText*(startNode), toInlineTextBox(startBox)-start()));
+return positionAvoidingFirstPositionInTable(positionBeforeNode(startNode));
 }
 
-VisiblePosition startOfLine(const VisiblePosition c)
+static VisiblePosition startOfLine(const VisiblePosition c, LineEndpointComputationMode mode)
 {
-VisiblePosition visPos = startPositionForLine(c);
+// TODO: this is the current behavior that might need to be fixed.
+// Please refer to 

[webkit-changes] [98359] trunk

[jer . noble]

Title: [98359] trunk








Revision 98359
Author jer.no...@apple.com
Date 2011-10-25 10:42:18 -0700 (Tue, 25 Oct 2011)


Log Message
compositing/video tests time out on Lion
https://bugs.webkit.org/show_bug.cgi?id=70448

Reviewed by Simon Fraser.

Source/WebCore:

AVFoundation will not begin loading or decoding media until a consumer for that media is present.
For video-only media, this means that an AVPlayerLayer must be created and attached to the
AVPlayer before the load state will ever reach canPlayThrough. Once the metadata for a media
is loaded, create a AVPlayerLayer if the media has a video track.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

LayoutTests:

* compositing/video/video-poster.html: Seek, instead of play, to trigger
creation of a layer
* http/tests/media/video-load-twice.html: Use waitForEventOnce so that
canPlayThrough listener is triggered only once.
* media/video-test.js: Add a new function, waitForEventOnce.
(waitForEventOnce):
(waitForEvent._eventCallback):
(waitForEvent):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/video/video-poster-expected.txt
trunk/LayoutTests/compositing/video/video-poster.html
trunk/LayoutTests/http/tests/media/video-load-twice.html
trunk/LayoutTests/media/video-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (98358 => 98359)

--- trunk/LayoutTests/ChangeLog	2011-10-25 17:22:50 UTC (rev 98358)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 17:42:18 UTC (rev 98359)
@@ -1,3 +1,19 @@
+2011-10-24  Jer Noble  jer.no...@apple.com
+
+compositing/video tests time out on Lion
+https://bugs.webkit.org/show_bug.cgi?id=70448
+
+Reviewed by Simon Fraser.
+
+* compositing/video/video-poster.html: Seek, instead of play, to trigger
+creation of a layer
+* http/tests/media/video-load-twice.html: Use waitForEventOnce so that
+canPlayThrough listener is triggered only once.
+* media/video-test.js: Add a new function, waitForEventOnce.
+(waitForEventOnce):
+(waitForEvent._eventCallback):
+(waitForEvent):
+
 2011-10-25  Cary Clark  carycl...@google.com
 
 Unreviewed gardening: fifth chunk of baselines for Chromium-Skia


Modified: trunk/LayoutTests/compositing/video/video-poster-expected.txt (98358 => 98359)

--- trunk/LayoutTests/compositing/video/video-poster-expected.txt	2011-10-25 17:22:50 UTC (rev 98358)
+++ trunk/LayoutTests/compositing/video/video-poster-expected.txt	2011-10-25 17:42:18 UTC (rev 98359)
@@ -7,7 +7,7 @@
 Displaying poster 
   PASS: wants layers = false, has layers = false
 
-Playing movie 
+Displaying movie 
   PASS: wants layers = true, has layers = true
 
 


Modified: trunk/LayoutTests/compositing/video/video-poster.html (98358 => 98359)

--- trunk/LayoutTests/compositing/video/video-poster.html	2011-10-25 17:22:50 UTC (rev 98358)
+++ trunk/LayoutTests/compositing/video/video-poster.html	2011-10-25 17:42:18 UTC (rev 98359)
@@ -37,10 +37,10 @@
 break;
 case canplaythrough:
 checkLayers(Displaying poster, false);
-video.play();
+video.currentTime = 0.5;
 break;
-case playing:
-checkLayers(Playing movie, true);
+case seeked:
+checkLayers(Displaying movie, true);
 if (window.layoutTestController)
 layoutTestController.notifyDone();
 break;
@@ -56,7 +56,7 @@
 /head
 body
 
-video _oncanplaythrough_=layerTest() _onplaying_=layerTest()/video
+video _oncanplaythrough_=layerTest() _onseeked_=layerTest()/video
 
 pA lt;videogt; should not have a layer until playback begins.br
 This test can not be run manually, it requires layoutTestController.layerTreeAsText./p


Modified: trunk/LayoutTests/http/tests/media/video-load-twice.html (98358 => 98359)

--- trunk/LayoutTests/http/tests/media/video-load-twice.html	2011-10-25 17:22:50 UTC (rev 98358)
+++ trunk/LayoutTests/http/tests/media/video-load-twice.html	2011-10-25 17:42:18 UTC (rev 98359)
@@ -17,13 +17,13 @@
 function firstCanPlayThrough() {
 document.body.removeChild(video);
 createVideo();
-waitForEvent('canplaythrough', endTest);
+waitForEventOnce('canplaythrough', endTest);
 run(video.src = ""
 }
 
 function init() {
 createVideo();
-waitForEvent('canplaythrough', firstCanPlayThrough);
+waitForEventOnce('canplaythrough', firstCanPlayThrough);
 run(video.src = ""
 }
 /script


Modified: trunk/LayoutTests/media/video-test.js (98358 => 

[webkit-changes] [98360] trunk/Source/WebCore

[enne]

Title: [98360] trunk/Source/WebCore








Revision 98360
Author e...@google.com
Date 2011-10-25 10:44:31 -0700 (Tue, 25 Oct 2011)


Log Message
[chromium] Batch up texture uploads so that they can be updated incrementally
https://bugs.webkit.org/show_bug.cgi?id=70454

Reviewed by James Robinson.

Because texture uploads can sometimes take more than a frame to
complete, collect all the uploads that need to occur in a
CCTextureUpdater so that we can easily incrementally upload some of
them, interleaving input and drawing so that the compositor thread
continues to appear responsive during a commit.

This change doesn't actually interleave the commits, it just pushes
the infrastructure for doing so up to the CCProxy level so that a
future scheduler can make this decision.

VideoLayerChromium is the only layer type to not use this system. It
needs to be converted to use a texture updater first and it is less of
a priority than the tiled layers.

* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCTextureUpdater.cpp: Added.
(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::~CCTextureUpdater):
(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):
* platform/graphics/chromium/cc/CCTextureUpdater.h: Added.
(WebCore::CCTextureUpdater::allocator):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnImplThread):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp


Added Paths

trunk/Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCTextureUpdater.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (98359 => 98360)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 17:42:18 UTC (rev 98359)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 17:44:31 UTC (rev 98360)
@@ -1,3 +1,60 @@
+2011-10-25  Adrienne Walker  e...@google.com
+
+[chromium] Batch up texture uploads so that they can be updated incrementally
+https://bugs.webkit.org/show_bug.cgi?id=70454
+
+Reviewed by James Robinson.
+
+Because texture uploads can sometimes take more than a frame to
+complete, collect all the uploads that need to occur in a
+CCTextureUpdater so that we can easily incrementally upload some of
+them, interleaving input and drawing so that the compositor thread
+continues to appear responsive during a commit.
+
+This change doesn't actually interleave the commits, it just pushes
+the infrastructure for doing so up to the CCProxy level so that a
+future scheduler can make this decision.
+
+VideoLayerChromium is the only layer type 

[webkit-changes] [98361] trunk

[simon . fraser]

Title: [98361] trunk








Revision 98361
Author simon.fra...@apple.com
Date 2011-10-25 10:54:11 -0700 (Tue, 25 Oct 2011)


Log Message
REGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
https://bugs.webkit.org/show_bug.cgi?id=62797

Source/WebCore:

Reviewed by Chris Marrin.

When hit testing through transformed layers, RenderLayer would simply use
the composited bounds of the layer as the localHitTestRect for hit testing sublayers.
However, this broke hit testing on pages that have a composited, non-transformed layer
which falls outside the bounds of its parent, composited-transformed layer, like Google
Maps.

Fix by mapping the hitTestRect through transforms. However this is tricky, because
mapping a rect into the coordinate system of a layer can result in invalid rectangles
when point projection results in a negative w component. Fix TransformationMatrix::projectPoint()
to detect this case and replace X and Y with large values, and add boundsOfProjectedQuad(), which
maps rectangles with possibly-infinite location or bounds into rects which are representable
in an IntRect.

Tests: transforms/3d/hit-testing/composited-hit-test.html
   transforms/3d/hit-testing/rotated-hit-test-with-child.html
   transforms/3d/hit-testing/rotated-hit-test2.html

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::projectPoint):
(WebCore::TransformationMatrix::projectQuad):
(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::boundsOfProjectedQuad):
* platform/graphics/transforms/TransformationMatrix.h:
* rendering/HitTestingTransformState.cpp:
(WebCore::HitTestingTransformState::boundsOfMappedQuad):
* rendering/HitTestingTransformState.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):

LayoutTests:

Reviewed by Chris Marrin.

New tests for hit testing through various configurations of 3D transforms.

* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png: Removed.
* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.txt: Removed.
* transforms/3d/hit-testing/composited-hit-test-expected.txt: Added.
* transforms/3d/hit-testing/composited-hit-test.html: Added.
* transforms/3d/hit-testing/resources/hit-test-utils.js: Added.
* transforms/3d/hit-testing/rotated-hit-test-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test-with-child-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test-with-child.html: Added.
* transforms/3d/hit-testing/rotated-hit-test.html:
* transforms/3d/hit-testing/rotated-hit-test2-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test2.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/transforms/3d/hit-testing/rotated-hit-test.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp
trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h
trunk/Source/WebCore/rendering/HitTestingTransformState.cpp
trunk/Source/WebCore/rendering/HitTestingTransformState.h
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/transforms/3d/hit-testing/composited-hit-test-expected.txt
trunk/LayoutTests/transforms/3d/hit-testing/composited-hit-test.html
trunk/LayoutTests/transforms/3d/hit-testing/resources/
trunk/LayoutTests/transforms/3d/hit-testing/resources/hit-test-utils.js
trunk/LayoutTests/transforms/3d/hit-testing/rotated-hit-test-expected.txt
trunk/LayoutTests/transforms/3d/hit-testing/rotated-hit-test-with-child-expected.txt
trunk/LayoutTests/transforms/3d/hit-testing/rotated-hit-test-with-child.html
trunk/LayoutTests/transforms/3d/hit-testing/rotated-hit-test2-expected.txt
trunk/LayoutTests/transforms/3d/hit-testing/rotated-hit-test2.html


Removed Paths

trunk/LayoutTests/platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png
trunk/LayoutTests/platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (98360 => 98361)

--- trunk/LayoutTests/ChangeLog	2011-10-25 17:44:31 UTC (rev 98360)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 17:54:11 UTC (rev 98361)
@@ -1,3 +1,24 @@
+2011-10-25  Simon Fraser  simon.fra...@apple.com
+
+REGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
+https://bugs.webkit.org/show_bug.cgi?id=62797
+
+Reviewed by Chris Marrin.
+
+New tests for hit testing through various configurations of 3D transforms.
+
+* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png: Removed.
+* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.txt: Removed.
+* transforms/3d/hit-testing/composited-hit-test-expected.txt: Added.
+* transforms/3d/hit-testing/composited-hit-test.html: Added.
+* transforms/3d/hit-testing/resources/hit-test-utils.js: Added.
+* 

[webkit-changes] [98362] trunk/Source/WebKit2

[sullivan]

Title: [98362] trunk/Source/WebKit2








Revision 98362
Author sulli...@apple.com
Date 2011-10-25 10:54:35 -0700 (Tue, 25 Oct 2011)


Log Message
Open with item missing from PDF context menu in some cases
https://bugs.webkit.org/show_bug.cgi?id=70828
rdar://problem/10034302

Reviewed by Anders Carlsson.

* UIProcess/API/mac/PDFViewController.mm:
(insertOpenWithDefaultPDFMenuItem):
New helper function, extracted from -menuForEvent:. Identical to original code except
that it inserts the item at a specified index, rather than always at the end.
(-[WKPDFView menuForEvent:]):
Now keeps track of whether the Open With item has been inserted while iterating through
the PDFKit-supplied menu items looking for a Copy item. If a Copy item is not found,
inserts the Open With item at the top of the context menu.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/PDFViewController.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98361 => 98362)

--- trunk/Source/WebKit2/ChangeLog	2011-10-25 17:54:11 UTC (rev 98361)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-25 17:54:35 UTC (rev 98362)
@@ -1,3 +1,20 @@
+2011-10-25  John Sullivan  sulli...@apple.com
+
+Open with item missing from PDF context menu in some cases
+https://bugs.webkit.org/show_bug.cgi?id=70828
+rdar://problem/10034302
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/mac/PDFViewController.mm:
+(insertOpenWithDefaultPDFMenuItem):
+New helper function, extracted from -menuForEvent:. Identical to original code except
+that it inserts the item at a specified index, rather than always at the end.
+(-[WKPDFView menuForEvent:]):
+Now keeps track of whether the Open With item has been inserted while iterating through
+the PDFKit-supplied menu items looking for a Copy item. If a Copy item is not found,
+inserts the Open With item at the top of the context menu.
+
 2011-10-25  Zeno Albisser  zeno.albis...@nokia.com
 
 [Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.


Modified: trunk/Source/WebKit2/UIProcess/API/mac/PDFViewController.mm (98361 => 98362)

--- trunk/Source/WebKit2/UIProcess/API/mac/PDFViewController.mm	2011-10-25 17:54:11 UTC (rev 98361)
+++ trunk/Source/WebKit2/UIProcess/API/mac/PDFViewController.mm	2011-10-25 17:54:35 UTC (rev 98362)
@@ -297,38 +297,56 @@
 return [super hitTest:point];
 }
 
+static void insertOpenWithDefaultPDFMenuItem(NSMenu *menu, NSUInteger index)
+{
+// Add in an Open with default PDF viewer item
+NSString *appName = nil;
+NSImage *appIcon = nil;
+
+_applicationInfoForMIMEType(@application/pdf, appName, appIcon);
+if (!appName)
+appName = WEB_UI_STRING(Finder, Default application name for Open With context menu);
+
+// To match the PDFKit style, we'll add Open with Preview even when there's no document yet to view, and
+// disable it using validateUserInterfaceItem.
+NSString *title = [NSString stringWithFormat:WEB_UI_STRING(Open with %@, context menu item for PDF), appName];
+
+NSMenuItem *item = [[NSMenuItem alloc] initWithTitle:title action:@selector(_openWithFinder:) keyEquivalent:@];
+if (appIcon)
+[item setImage:appIcon];
+[menu insertItem:item atIndex:index];
+[item release];
+}
+
 - (NSMenu *)menuForEvent:(NSEvent *)theEvent
 {
 NSMenu *menu = [[NSMenu alloc] initWithTitle:@];
 
+bool insertedOpenWithItem = false;
+
 NSEnumerator *menuItemEnumerator = [[[_pdfView menuForEvent:theEvent] itemArray] objectEnumerator];
 while (NSMenuItem *item = [menuItemEnumerator nextObject]) {
 NSMenuItem *itemCopy = [item copy];
 [menu addItem:itemCopy];
 [itemCopy release];
 
+if (insertedOpenWithItem)
+continue;
+
+// If a Copy item is present, place the Open With item just after it, with an intervening separator.
 if ([item action] != @selector(copy:))
 continue;
-
-// Add in an Open with default PDF viewer item
-NSString *appName = nil;
-NSImage *appIcon = nil;
-
-_applicationInfoForMIMEType(@application/pdf, appName, appIcon);
-if (!appName)
-appName = WEB_UI_STRING(Finder, Default application name for Open With context menu);
-
-// To match the PDFKit style, we'll add Open with Preview even when there's no document yet to view, and
-// disable it using validateUserInterfaceItem.
-NSString *title = [NSString stringWithFormat:WEB_UI_STRING(Open with %@, context menu item for PDF), appName];
-
-item = [[NSMenuItem alloc] initWithTitle:title action:@selector(_openWithFinder:) keyEquivalent:@];
-if (appIcon)
-[item setImage:appIcon];
+
 [menu addItem:[NSMenuItem separatorItem]];
-[menu addItem:item];
-[item release];
+

[webkit-changes] [98363] trunk/LayoutTests

[jchaffraix]

Title: [98363] trunk/LayoutTests








Revision 98363
Author jchaffr...@webkit.org
Date 2011-10-25 11:06:51 -0700 (Tue, 25 Oct 2011)


Log Message
Unreviewed gardening.

Partial rebaselining of fast/css/focus-ring-multiline-writingmode-vertical.html as it looks like it progressed
on some platforms.

* platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
* platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (98362 => 98363)

--- trunk/LayoutTests/ChangeLog	2011-10-25 17:54:35 UTC (rev 98362)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 18:06:51 UTC (rev 98363)
@@ -1,3 +1,18 @@
+2011-10-25  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
+Partial rebaselining of fast/css/focus-ring-multiline-writingmode-vertical.html as it looks like it progressed
+on some platforms.
+
+* platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
+* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
+* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
+* platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
+* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
+* platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
+* platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
+
 2011-10-25  Simon Fraser  simon.fra...@apple.com
 
 REGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups


Deleted: trunk/LayoutTests/platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt (98362 => 98363)

--- trunk/LayoutTests/platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt	2011-10-25 17:54:35 UTC (rev 98362)
+++ trunk/LayoutTests/platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt	2011-10-25 18:06:51 UTC (rev 98363)
@@ -1,18 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x0
-  RenderBlock {DIV} at (0,0) size 160x160
-RenderText {#text} at (0,0) size 108x160
-  text run at (0,0) width 121: Assuming the port-
-  text run at (18,0) width 132: specific theme draws
-  text run at (18,132) width 4:  
-  text run at (36,0) width 124: focus rings, this test
-  text run at (36,124) width 4:  
-  text run at (54,0) width 159: draws focus rings around
-  text run at (54,159) width 1:  
-  text run at (72,0) width 151: editable multiline text in
-  text run at (72,151) width 4:  
-  text run at (90,0) width 138: vertical writing mode.
-caret: position 1 of child 0 {#text} of child 1 {DIV} of body


Deleted: trunk/LayoutTests/platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt (98362 => 98363)

--- 

[webkit-changes] [98364] trunk/LayoutTests

[jchaffraix]

Title: [98364] trunk/LayoutTests








Revision 98364
Author jchaffr...@webkit.org
Date 2011-10-25 11:10:38 -0700 (Tue, 25 Oct 2011)


Log Message
Unreviewed gardening.

The old rebaseline looked wrong and did not match the other baselines. This is now corrected.

* platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (98363 => 98364)

--- trunk/LayoutTests/ChangeLog	2011-10-25 18:06:51 UTC (rev 98363)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 18:10:38 UTC (rev 98364)
@@ -2,6 +2,14 @@
 
 Unreviewed gardening.
 
+The old rebaseline looked wrong and did not match the other baselines. This is now corrected.
+
+* platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
+
+2011-10-25  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
 Partial rebaselining of fast/css/focus-ring-multiline-writingmode-vertical.html as it looks like it progressed
 on some platforms.
 


Deleted: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98365] trunk/Source/JavaScriptCore

[oliver]

Title: [98365] trunk/Source/_javascript_Core








Revision 98365
Author oli...@apple.com
Date 2011-10-25 11:17:37 -0700 (Tue, 25 Oct 2011)


Log Message
Need to support marking of multiple nested codeblocks when compiling
https://bugs.webkit.org/show_bug.cgi?id=70832

Reviewed by Gavin Barraclough.

When inlining a function we end up with multiple codeblocks being
compiled at the same time, so we need to support a list of live
codeblocks.

* heap/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (98364 => 98365)

--- trunk/Source/_javascript_Core/ChangeLog	2011-10-25 18:10:38 UTC (rev 98364)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-10-25 18:17:37 UTC (rev 98365)
@@ -1,3 +1,22 @@
+2011-10-25  Oliver Hunt  oli...@apple.com
+
+Need to support marking of multiple nested codeblocks when compiling
+https://bugs.webkit.org/show_bug.cgi?id=70832
+
+Reviewed by Gavin Barraclough.
+
+When inlining a function we end up with multiple codeblocks being
+compiled at the same time, so we need to support a list of live
+codeblocks.
+
+* heap/Heap.cpp:
+(JSC::Heap::markRoots):
+* runtime/JSGlobalData.cpp:
+(JSC::JSGlobalData::JSGlobalData):
+* runtime/JSGlobalData.h:
+(JSC::JSGlobalData::startedCompiling):
+(JSC::JSGlobalData::finishedCompiling):
+
 2011-10-24  Yuqiang Xian  yuqiang.x...@intel.com
 
 DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger


Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (98364 => 98365)

--- trunk/Source/_javascript_Core/heap/Heap.cpp	2011-10-25 18:10:38 UTC (rev 98364)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp	2011-10-25 18:17:37 UTC (rev 98365)
@@ -601,9 +601,10 @@
 }
 #endif
 
-if (CodeBlock* codeBlock = m_globalData-codeBlockBeingCompiled) {
+if (m_globalData-codeBlocksBeingCompiled.size()) {
 GCPHASE(VisitActiveCodeBlock);
-codeBlock-visitAggregate(visitor);
+for (size_t i = 0; i  m_globalData-codeBlocksBeingCompiled.size(); i++)
+m_globalData-codeBlocksBeingCompiled[i]-visitAggregate(visitor);
 }
 
 {


Modified: trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp (98364 => 98365)

--- trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp	2011-10-25 18:10:38 UTC (rev 98364)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp	2011-10-25 18:17:37 UTC (rev 98365)
@@ -179,7 +179,6 @@
 , identifierTable(globalDataType == Default ? wtfThreadData().currentIdentifierTable() : createIdentifierTable())
 , propertyNames(new CommonIdentifiers(this))
 , emptyList(new MarkedArgumentBuffer)
-, codeBlockBeingCompiled(0)
 #if ENABLE(ASSEMBLER)
 , executableAllocator(*this)
 #endif


Modified: trunk/Source/_javascript_Core/runtime/JSGlobalData.h (98364 => 98365)

--- trunk/Source/_javascript_Core/runtime/JSGlobalData.h	2011-10-25 18:10:38 UTC (rev 98364)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalData.h	2011-10-25 18:17:37 UTC (rev 98365)
@@ -188,17 +188,16 @@
 SmallStrings smallStrings;
 NumericStrings numericStrings;
 DateInstanceCache dateInstanceCache;
-CodeBlock* codeBlockBeingCompiled;
+VectorCodeBlock* codeBlocksBeingCompiled;
 void startedCompiling(CodeBlock* codeBlock)
 {
-ASSERT(!codeBlockBeingCompiled);
-codeBlockBeingCompiled = codeBlock;
+codeBlocksBeingCompiled.append(codeBlock);
 }
 
 void finishedCompiling(CodeBlock* codeBlock)
 {
-ASSERT_UNUSED(codeBlock, codeBlock == codeBlockBeingCompiled);
-codeBlockBeingCompiled = 0;
+ASSERT_UNUSED(codeBlock, codeBlock == codeBlocksBeingCompiled.last());
+codeBlocksBeingCompiled.removeLast();
 }
 
 #if ENABLE(ASSEMBLER)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98366] trunk/LayoutTests

[zherczeg]

Title: [98366] trunk/LayoutTests








Revision 98366
Author zherc...@webkit.org
Date 2011-10-25 11:24:04 -0700 (Tue, 25 Oct 2011)


Log Message
Add new uri tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=70807

Reviewed by Darin Adler.

Test more cases!

* fast/css/uri-token-parsing-expected.txt:
* fast/css/uri-token-parsing.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/uri-token-parsing-expected.txt
trunk/LayoutTests/fast/css/uri-token-parsing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98365 => 98366)

--- trunk/LayoutTests/ChangeLog	2011-10-25 18:17:37 UTC (rev 98365)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 18:24:04 UTC (rev 98366)
@@ -1,3 +1,15 @@
+2011-10-25  Zoltan Herczeg  zherc...@webkit.org
+
+Add new uri tokenizer tests
+https://bugs.webkit.org/show_bug.cgi?id=70807
+
+Reviewed by Darin Adler.
+
+Test more cases!
+
+* fast/css/uri-token-parsing-expected.txt:
+* fast/css/uri-token-parsing.html:
+
 2011-10-25  Julien Chaffraix  jchaffr...@webkit.org
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/fast/css/uri-token-parsing-expected.txt (98365 => 98366)

--- trunk/LayoutTests/fast/css/uri-token-parsing-expected.txt	2011-10-25 18:17:37 UTC (rev 98365)
+++ trunk/LayoutTests/fast/css/uri-token-parsing-expected.txt	2011-10-25 18:24:04 UTC (rev 98366)
@@ -24,6 +24,9 @@
 #t { -webkit-mask-image: url('url(t)'); }
 #u { -webkit-border-image: url('url(u)') 1 2 3 4 fill stretch round; }
 #v { -webkit-mask-box-image: url('url(v)') 1 2 3 4 fill stretch round; }
+#w { content: url(ww); }
+#x { content: url(x%20xx); }
+#y { content: url(y%20yy); }
 Expected result:
 
 #a { content: url(c); }
@@ -46,4 +49,7 @@
 #t { -webkit-mask-image: url('url(t)'); }
 #u { -webkit-border-image: url('url(u)') 1 2 3 4 fill stretch round; }
 #v { -webkit-mask-box-image: url('url(v)') 1 2 3 4 fill stretch round; }
+#w { content: url(ww); }
+#x { content: url(x%20xx); }
+#y { content: url(y%20yy); }
 


Modified: trunk/LayoutTests/fast/css/uri-token-parsing.html (98365 => 98366)

--- trunk/LayoutTests/fast/css/uri-token-parsing.html	2011-10-25 18:17:37 UTC (rev 98365)
+++ trunk/LayoutTests/fast/css/uri-token-parsing.html	2011-10-25 18:24:04 UTC (rev 98366)
@@ -20,6 +20,10 @@
 #t { -webkit-mask-image: url(url(t)); }
 #u { -webkit-border-image: url(url(u)) 1 2 3 4 fill stretch round; }
 #v { -webkit-mask-box-image: url(url(v)) 1 2 3 4 fill stretch round; }
+#w { content: url(w\0d\
+w); /* URL string contains twice newline */ }
+#x { content: url( x x	x ); } /* URL string contains space and tab */
+#y { content: url( y\20y\9y ); } /* URL string contains space and tab */
 /style
 
 script
@@ -94,6 +98,9 @@
 #t { -webkit-mask-image: url('url(t)'); }
 #u { -webkit-border-image: url('url(u)') 1 2 3 4 fill stretch round; }
 #v { -webkit-mask-box-image: url('url(v)') 1 2 3 4 fill stretch round; }
+#w { content: url(ww); }
+#x { content: url(x%20xx); }
+#y { content: url(y%20yy); }
 /pre
 
 script






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98367] trunk/Source

[mhahnenberg]

Title: [98367] trunk/Source








Revision 98367
Author mhahnenb...@apple.com
Date 2011-10-25 11:51:49 -0700 (Tue, 25 Oct 2011)


Log Message
Add getOwnPropertySlot to MethodTable
https://bugs.webkit.org/show_bug.cgi?id=69807

Reviewed by Oliver Hunt.

Source/_javascript_Core: 

* _javascript_Core.exp:
* runtime/ClassInfo.h: Added both versions of getOwnPropertySlot to the MethodTable.
* runtime/JSCell.h: Changed getOwnPropertySlot to be protected so other classes can 
reference it in their MethodTables.

Source/WebCore: 

No new tests.

* bridge/runtime_method.h: Changed getOwnPropertySlot to be protected so 
subclasses can reference it in their MethodTables.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/runtime/ClassInfo.h
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bridge/runtime_method.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (98366 => 98367)

--- trunk/Source/_javascript_Core/ChangeLog	2011-10-25 18:24:04 UTC (rev 98366)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-10-25 18:51:49 UTC (rev 98367)
@@ -1,3 +1,15 @@
+2011-10-25  Mark Hahnenberg  mhahnenb...@apple.com
+
+Add getOwnPropertySlot to MethodTable
+https://bugs.webkit.org/show_bug.cgi?id=69807
+
+Reviewed by Oliver Hunt.
+
+* _javascript_Core.exp:
+* runtime/ClassInfo.h: Added both versions of getOwnPropertySlot to the MethodTable.
+* runtime/JSCell.h: Changed getOwnPropertySlot to be protected so other classes can 
+reference it in their MethodTables.
+
 2011-10-25  Oliver Hunt  oli...@apple.com
 
 Need to support marking of multiple nested codeblocks when compiling


Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (98366 => 98367)

--- trunk/Source/_javascript_Core/_javascript_Core.exp	2011-10-25 18:24:04 UTC (rev 98366)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp	2011-10-25 18:51:49 UTC (rev 98367)
@@ -117,6 +117,8 @@
 __ZN3JSC10throwErrorEPNS_9ExecStateEPNS_8JSObjectE
 __ZN3JSC11JSByteArray10putByIndexEPNS_6JSCellEPNS_9ExecStateEjNS_7JSValueE
 __ZN3JSC11JSByteArray15createStructureERNS_12JSGlobalDataEPNS_14JSGlobalObjectENS_7JSValueEPKNS_9ClassInfoE
+__ZN3JSC11JSByteArray18getOwnPropertySlotEPNS_6JSCellEPNS_9ExecStateERKNS_10IdentifierERNS_12PropertySlotE
+__ZN3JSC11JSByteArray25getOwnPropertySlotByIndexEPNS_6JSCellEPNS_9ExecStateEjRNS_12PropertySlotE
 __ZN3JSC11JSByteArray3putEPNS_6JSCellEPNS_9ExecStateERKNS_10IdentifierENS_7JSValueERNS_15PutPropertySlotE
 __ZN3JSC11JSByteArray6s_infoE
 __ZN3JSC11JSByteArrayC1EPNS_9ExecStateEPNS_9StructureEPN3WTF9ByteArrayE


Modified: trunk/Source/_javascript_Core/runtime/ClassInfo.h (98366 => 98367)

--- trunk/Source/_javascript_Core/runtime/ClassInfo.h	2011-10-25 18:24:04 UTC (rev 98366)
+++ trunk/Source/_javascript_Core/runtime/ClassInfo.h	2011-10-25 18:51:49 UTC (rev 98367)
@@ -52,6 +52,12 @@
 
 typedef bool (*DeletePropertyByIndexFunctionPtr)(JSCell*, ExecState*, unsigned);
 DeletePropertyByIndexFunctionPtr deletePropertyByIndex;
+
+typedef bool (*GetOwnPropertySlotFunctionPtr)(JSCell*, ExecState*, const Identifier, PropertySlot);
+GetOwnPropertySlotFunctionPtr getOwnPropertySlot;
+
+typedef bool (*GetOwnPropertySlotByIndexFunctionPtr)(JSCell*, ExecState*, unsigned, PropertySlot);
+GetOwnPropertySlotByIndexFunctionPtr getOwnPropertySlotByIndex;
 };
 
 #define CREATE_METHOD_TABLE(ClassName) { \
@@ -62,6 +68,8 @@
 ClassName::putByIndex, \
 ClassName::deleteProperty, \
 ClassName::deletePropertyByIndex, \
+ClassName::getOwnPropertySlot, \
+ClassName::getOwnPropertySlotByIndex, \
 }, \
 sizeof(ClassName)
 


Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (98366 => 98367)

--- trunk/Source/_javascript_Core/runtime/JSCell.h	2011-10-25 18:24:04 UTC (rev 98366)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h	2011-10-25 18:51:49 UTC (rev 98367)
@@ -132,13 +132,13 @@
 void finishCreation(JSGlobalData);
 void finishCreation(JSGlobalData, Structure*, CreatingEarlyCellTag);
 
-private:
 // Base implementation; for non-object classes implements getPropertySlot.
 virtual bool getOwnPropertySlotVirtual(ExecState*, const Identifier propertyName, PropertySlot);
 static bool getOwnPropertySlot(JSCell*, ExecState*, const Identifier propertyName, PropertySlot);
 virtual bool getOwnPropertySlotVirtual(ExecState*, unsigned propertyName, PropertySlot);
 static bool getOwnPropertySlotByIndex(JSCell*, ExecState*, unsigned propertyName, PropertySlot);
 
+private:
 WriteBarrierStructure m_structure;
 };
 


Modified: trunk/Source/WebCore/ChangeLog (98366 => 98367)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 18:24:04 UTC (rev 98366)
+++ trunk/Source/WebCore/ChangeLog	

[webkit-changes] [98368] trunk/Source/JavaScriptCore

[commit-queue]

Title: [98368] trunk/Source/_javascript_Core








Revision 98368
Author commit-qu...@webkit.org
Date 2011-10-25 11:59:42 -0700 (Tue, 25 Oct 2011)


Log Message
Add missing DFG file entries to the make lists for GTK and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=70806

Patch by Yuqiang Xian yuqiang.x...@intel.com on 2011-10-25
Reviewed by Darin Adler.

* GNUmakefile.list.am:
* _javascript_Core.pro:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am
trunk/Source/_javascript_Core/_javascript_Core.pro




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (98367 => 98368)

--- trunk/Source/_javascript_Core/ChangeLog	2011-10-25 18:51:49 UTC (rev 98367)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-10-25 18:59:42 UTC (rev 98368)
@@ -1,3 +1,13 @@
+2011-10-25  Yuqiang Xian  yuqiang.x...@intel.com
+
+Add missing DFG file entries to the make lists for GTK and Qt ports
+https://bugs.webkit.org/show_bug.cgi?id=70806
+
+Reviewed by Darin Adler.
+
+* GNUmakefile.list.am:
+* _javascript_Core.pro:
+
 2011-10-25  Mark Hahnenberg  mhahnenb...@apple.com
 
 Add getOwnPropertySlot to MethodTable


Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (98367 => 98368)

--- trunk/Source/_javascript_Core/GNUmakefile.list.am	2011-10-25 18:51:49 UTC (rev 98367)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am	2011-10-25 18:59:42 UTC (rev 98368)
@@ -121,10 +121,14 @@
 	Source/_javascript_Core/dfg/DFGGraph.cpp \
 	Source/_javascript_Core/dfg/DFGGraph.h \
 	Source/_javascript_Core/dfg/DFGIntrinsic.h \
+	Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp \
+	Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp \
 	Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp \
 	Source/_javascript_Core/dfg/DFGJITCodeGenerator.h \
+	Source/_javascript_Core/dfg/DFGJITCompiler32_64.cpp \
 	Source/_javascript_Core/dfg/DFGJITCompiler.cpp \
 	Source/_javascript_Core/dfg/DFGJITCompiler.h \
+	Source/_javascript_Core/dfg/DFGJITCompilerInlineMethods.h \
 	Source/_javascript_Core/dfg/DFGNode.h \
 	Source/_javascript_Core/dfg/DFGOperands.h \
 	Source/_javascript_Core/dfg/DFGOperations.cpp \
@@ -137,6 +141,8 @@
 	Source/_javascript_Core/dfg/DFGRepatch.cpp \
 	Source/_javascript_Core/dfg/DFGRepatch.h \
 	Source/_javascript_Core/dfg/DFGScoreBoard.h \
+	Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp \
+	Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp \
 	Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp \
 	Source/_javascript_Core/dfg/DFGSpeculativeJIT.h \
 	Source/_javascript_Core/dfg/DFGStructureSet.h \


Modified: trunk/Source/_javascript_Core/_javascript_Core.pro (98367 => 98368)

--- trunk/Source/_javascript_Core/_javascript_Core.pro	2011-10-25 18:51:49 UTC (rev 98367)
+++ trunk/Source/_javascript_Core/_javascript_Core.pro	2011-10-25 18:59:42 UTC (rev 98368)
@@ -77,12 +77,23 @@
 debugger/DebuggerActivation.cpp \
 debugger/DebuggerCallFrame.cpp \
 debugger/Debugger.cpp \
+dfg/DFGAbstractState.cpp \
 dfg/DFGByteCodeParser.cpp \
+dfg/DFGCapabilities.cpp \
+dfg/DFGDriver.cpp \
 dfg/DFGGraph.cpp \
 dfg/DFGJITCodeGenerator.cpp \
+dfg/DFGJITCodeGenerator32_64.cpp \
+dfg/DFGJITCodeGenerator64.cpp \
 dfg/DFGJITCompiler.cpp \
+dfg/DFGJITCompiler32_64.cpp \
 dfg/DFGOperations.cpp \
+dfg/DFGOSREntry.cpp \
+dfg/DFGPropagator.cpp \
+dfg/DFGRepatch.cpp \
 dfg/DFGSpeculativeJIT.cpp \
+dfg/DFGSpeculativeJIT32_64.cpp \
+dfg/DFGSpeculativeJIT64.cpp \
 interpreter/CallFrame.cpp \
 interpreter/Interpreter.cpp \
 interpreter/RegisterFile.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98369] trunk/Source/WebKit2

[andersca]

Title: [98369] trunk/Source/WebKit2








Revision 98369
Author ander...@apple.com
Date 2011-10-25 12:01:51 -0700 (Tue, 25 Oct 2011)


Log Message
PDF SUBFRAMES: Incomplete repaint after pinch to zoom
https://bugs.webkit.org/show_bug.cgi?id=70821
rdar://problem/10312733

Reviewed by Simon Fraser.

Add a new pure virtual member function, Plugin::wantsWindowRelativeCoordinates.
If a plug-in subclass returns true, we'll keep giving the plug-in coordinates that
are relative to the containing window. If a plug-in subclass returns false, we'll give it
coordinates in a much more sane coordinate system, with the origin at the top left corner of the plug-in.

Change BuiltinPDFView to return false so that it'll work correctly with pinch to zoom.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Make wantsWindowRelativeCoordinates return true.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::paint):
Remove translation since the graphics context is already set up in the right way.

(WebKit::BuiltInPDFView::paintContent):
No need to offset by the plug-in view location anymore.

(WebKit::BuiltInPDFView::paintControls):
Account for the scrollbars being children of the parent scroll view here.

(WebKit::BuiltInPDFView::wantsWindowRelativeCoordinates):
Return false.

(WebKit::BuiltInPDFView::convertFromContainingViewToScrollbar):
Implement this so that scrollbar hit testing works correctly.

* WebProcess/Plugins/Plugin.h:
Add wantsWindowRelativeCoordinates.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return true for now.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::renderer):
Add simple getter.

(WebKit::PluginView::paint):
Handle the case when the plug-in doesn't want window relative coordinates.

(WebKit::PluginView::transformsAffectFrameRect):
Return true here.

(WebKit::PluginView::viewGeometryDidChange):
No need to adjust the bounds to account for the scale factor now, since the frame rect will always be the
same regardless of the transform.

(WebKit::PluginView::clipRectInWindowCoordinates):
Ditto.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98368 => 98369)

--- trunk/Source/WebKit2/ChangeLog	2011-10-25 18:59:42 UTC (rev 98368)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-25 19:01:51 UTC (rev 98369)
@@ -1,3 +1,62 @@
+2011-10-25  Anders Carlsson  ander...@apple.com
+
+PDF SUBFRAMES: Incomplete repaint after pinch to zoom
+https://bugs.webkit.org/show_bug.cgi?id=70821
+rdar://problem/10312733
+
+Reviewed by Simon Fraser.
+
+Add a new pure virtual member function, Plugin::wantsWindowRelativeCoordinates.
+If a plug-in subclass returns true, we'll keep giving the plug-in coordinates that
+are relative to the containing window. If a plug-in subclass returns false, we'll give it
+coordinates in a much more sane coordinate system, with the origin at the top left corner of the plug-in.
+
+Change BuiltinPDFView to return false so that it'll work correctly with pinch to zoom.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
+Make wantsWindowRelativeCoordinates return true.
+
+* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
+(WebKit::BuiltInPDFView::paint):
+Remove translation since the graphics context is already set up in the right way.
+
+(WebKit::BuiltInPDFView::paintContent):
+No need to offset by the plug-in view location anymore.
+
+(WebKit::BuiltInPDFView::paintControls):
+Account for the scrollbars being children of the parent scroll view here.
+
+(WebKit::BuiltInPDFView::wantsWindowRelativeCoordinates):
+Return false.
+
+(WebKit::BuiltInPDFView::convertFromContainingViewToScrollbar):
+Implement this so that scrollbar hit testing works correctly.
+
+* WebProcess/Plugins/Plugin.h:
+Add wantsWindowRelativeCoordinates.
+
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
+Return true for now.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::renderer):
+Add simple getter.
+
+(WebKit::PluginView::paint):
+Handle the case when the 

[webkit-changes] [98370] branches/chromium/912

[leviw]

Title: [98370] branches/chromium/912








Revision 98370
Author le...@chromium.org
Date 2011-10-25 12:05:59 -0700 (Tue, 25 Oct 2011)


Log Message
Merge 98263 - svg fails to use explicit width and height inside html inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823

Reviewed by Nikolas Zimmermann.

Source/WebCore: 

Checking that embedded SVG is in an SVG document before negotiating size
with the host document.

Test: svg/as-object/svg-embedded-in-html-in-iframe.html

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests: 

Fixing a bug where SVG negotiated size when embedded in html inside an iframe.

* platform/chromium/test_expectations.txt: Will update with results on other platforms.
* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
* svg/as-object/svg-embedded-in-html-in-iframe.html: Added.


TBR=le...@chromium.org
Review URL: http://codereview.chromium.org/8390012

Modified Paths

branches/chromium/912/LayoutTests/platform/chromium/test_expectations.txt
branches/chromium/912/Source/WebCore/rendering/svg/RenderSVGRoot.cpp


Added Paths

branches/chromium/912/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png
branches/chromium/912/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt
branches/chromium/912/LayoutTests/svg/as-object/svg-embedded-in-html-in-iframe.html




Diff

Modified: branches/chromium/912/LayoutTests/platform/chromium/test_expectations.txt (98369 => 98370)

--- branches/chromium/912/LayoutTests/platform/chromium/test_expectations.txt	2011-10-25 19:01:51 UTC (rev 98369)
+++ branches/chromium/912/LayoutTests/platform/chromium/test_expectations.txt	2011-10-25 19:05:59 UTC (rev 98370)
@@ -3844,3 +3844,31 @@
 BUGDPRANKE : svg/custom/js-late-gradient-creation.svg = IMAGE PASS
 BUGDPRANKE : svg/custom/js-late-pattern-creation.svg = IMAGE PASS
 
+// Failing since ~r97700.
+BUGWK70298 WIN LINUX SNOWLEOPARD : fast/selectors/unqualified-hover-strict.html = IMAGE+TEXT PASS
+BUGWK70298 LEOPARD : fast/selectors/unqualified-hover-strict.html = IMAGE
+
+// Failing since ~r97504.
+BUGWK70382 LEOPARD CPU-CG : fast/dom/blur-contenteditable.html = IMAGE
+BUGWK70383 LEOPARD CPU-CG : editing/pasteboard/4944770-1.html = IMAGE
+
+BUGWK70386 SNOWLEOPARD DEBUG : storage/domstorage/events/documentURI.html = PASS CRASH
+
+BUGCR101024 MAC CPU : fast/events/reveal-link-when-focused.html = IMAGE
+
+BUGWK70640 SNOWLEOPARD : fast/multicol/vertical-lr/rules-with-border-before.html = PASS TEXT
+BUGWK70640 SNOWLEOPARD : fast/multicol/vertical-rl/rules-with-border-before.html = PASS TEXT
+
+BUGWK70641 SNOWLEOPARD : fast/frames/sandboxed-iframe-scripting.html = PASS CRASH
+BUGWK67031 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH
+
+// r98183 removed test exceptions too aggressively. Add some back.
+
+BUGWK70704 SNOWLEOPARD : fast/css/focus-ring-multiline-writingmode-vertical.html = IMAGE PASS
+BUGWK70704 SNOWLEOPARD : fast/ruby/base-shorter-than-text.html = IMAGE+TEXT PASS
+BUGWK70704 SNOWLEOPARD : fast/writing-mode/fallback-orientation.html = TEXT
+BUGWK70704 SNOWLEOPARD : fast/backgrounds/background-leakage-transforms.html = TEXT
+
+// Will rebaseline
+BUGLEVIW : svg/as-object/svg-embedded-in-html-in-iframe.html = FAIL
+


Copied: branches/chromium/912/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png (from rev 98263, trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png)

(Binary files differ)


Copied: branches/chromium/912/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt (from rev 98263, trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt) (0 => 98370)

--- branches/chromium/912/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt	(rev 0)
+++ branches/chromium/912/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt	2011-10-25 19:05:59 UTC (rev 98370)
@@ -0,0 +1,15 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x170
+  RenderBlock {HTML} at (0,0) size 800x170
+RenderBody {BODY} at (8,8) size 784x154
+  RenderPartObject {IFRAME} at (0,0) size 784x150
+layer at (0,0) size 784x150
+  RenderView at (0,0) size 784x150
+layer at (0,0) size 784x120
+  RenderBlock {HTML} at (0,0) size 784x120
+RenderBody {BODY} at (8,8) size 768x104
+  RenderSVGRoot {svg} at (8,8) size 100x100
+RenderSVGPath {circle} at (8,8) size 100x100 [fill={[type=SOLID] [color=#FF]}] [cx=50.00] [cy=50.00] [r=50.00]
+   

[webkit-changes] [98371] branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp

[leviw]

Title: [98371] branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp








Revision 98371
Author le...@chromium.org
Date 2011-10-25 12:10:33 -0700 (Tue, 25 Oct 2011)


Log Message
Fixing false assertion and correcting unrounded values for adjusting height and offset for floats.

Modified Paths

branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp (98370 => 98371)

--- branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp	2011-10-25 19:05:59 UTC (rev 98370)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp	2011-10-25 19:10:33 UTC (rev 98371)
@@ -3575,18 +3575,18 @@
 const FloatingObject* r = interval.data();
 if (r-type() == FloatTypeValue  interval.low() = m_value  m_value  interval.high()) {
 // All the objects returned from the tree should be already placed.
-ASSERT(r-isPlaced()  m_renderer-logicalTopForFloat(r) = m_value  m_renderer-logicalBottomForFloat(r)  m_value);
+ASSERT(r-isPlaced()  m_renderer-logicalTopForFloat(r).round() = m_value  m_renderer-logicalBottomForFloat(r).round()  m_value);
 
 if (FloatTypeValue == FloatingObject::FloatLeft 
- m_renderer-logicalRightForFloat(r)  m_offset) {
-m_offset = m_renderer-logicalRightForFloat(r);
+ m_renderer-logicalRightForFloat(r).round()  m_offset) {
+m_offset = m_renderer-logicalRightForFloat(r).round();
 if (m_heightRemaining)
 *m_heightRemaining = m_renderer-logicalBottomForFloat(r) - m_value;
 }
 
 if (FloatTypeValue == FloatingObject::FloatRight
- m_renderer-logicalLeftForFloat(r)  m_offset) {
-m_offset = m_renderer-logicalLeftForFloat(r);
+ m_renderer-logicalLeftForFloat(r).round()  m_offset) {
+m_offset = m_renderer-logicalLeftForFloat(r).round();
 if (m_heightRemaining)
 *m_heightRemaining = m_renderer-logicalBottomForFloat(r) - m_value;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98372] trunk

[fsamuel]

Title: [98372] trunk








Revision 98372
Author fsam...@chromium.org
Date 2011-10-25 12:10:58 -0700 (Tue, 25 Oct 2011)


Log Message
Crash in WebCore::RenderTableSection::addChild due to assert failure
https://bugs.webkit.org/show_bug.cgi?id=70678

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-anonymous-cell-bug.html
   fast/table/table-anonymous-row-bug.html
   fast/table/table-anonymous-section-bug.html

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):

LayoutTests:

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

* fast/table/table-anonymous-cell-bug-expected.txt: Added.
* fast/table/table-anonymous-cell-bug.html: Added.
* fast/table/table-anonymous-row-bug-expected.txt: Added.
* fast/table/table-anonymous-row-bug.html: Added.
* fast/table/table-anonymous-section-bug-expected.txt: Added.
* fast/table/table-anonymous-section-bug.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/RenderTableRow.cpp
trunk/Source/WebCore/rendering/RenderTableSection.cpp


Added Paths

trunk/LayoutTests/fast/table/table-anonymous-cell-bug-expected.txt
trunk/LayoutTests/fast/table/table-anonymous-cell-bug.html
trunk/LayoutTests/fast/table/table-anonymous-row-bug-expected.txt
trunk/LayoutTests/fast/table/table-anonymous-row-bug.html
trunk/LayoutTests/fast/table/table-anonymous-section-bug-expected.txt
trunk/LayoutTests/fast/table/table-anonymous-section-bug.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98371 => 98372)

--- trunk/LayoutTests/ChangeLog	2011-10-25 19:10:33 UTC (rev 98371)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 19:10:58 UTC (rev 98372)
@@ -1,3 +1,21 @@
+2011-10-25  Fady Samuel  fsam...@chromium.org
+
+Crash in WebCore::RenderTableSection::addChild due to assert failure
+https://bugs.webkit.org/show_bug.cgi?id=70678
+
+Reviewed by David Hyatt.
+
+If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous, 
+we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
+assert.
+
+* fast/table/table-anonymous-cell-bug-expected.txt: Added.
+* fast/table/table-anonymous-cell-bug.html: Added.
+* fast/table/table-anonymous-row-bug-expected.txt: Added.
+* fast/table/table-anonymous-row-bug.html: Added.
+* fast/table/table-anonymous-section-bug-expected.txt: Added.
+* fast/table/table-anonymous-section-bug.html: Added.
+
 2011-10-25  Zoltan Herczeg  zherc...@webkit.org
 
 Add new uri tokenizer tests


Added: trunk/LayoutTests/fast/table/table-anonymous-cell-bug-expected.txt (0 => 98372)

--- trunk/LayoutTests/fast/table/table-anonymous-cell-bug-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/table/table-anonymous-cell-bug-expected.txt	2011-10-25 19:10:58 UTC (rev 98372)
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x66
+  RenderBlock {HTML} at (0,0) size 800x66
+RenderBody {BODY} at (8,8) size 784x50
+  RenderTable {DIV} at (0,0) size 260x50
+RenderTableSection {DIV} at (0,0) size 260x50
+  RenderTableRow {DIV} at (0,0) size 260x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell (anonymous) at (50,0) size 160x16 [r=0 c=1 rs=1 cs=1]
+  RenderInline {SPAN} at (0,0) size 160x16
+RenderText {#text} at (0,0) size 160x16
+  text run at (0,0) width 160: Some text.
+RenderTableCell {DIV} at (210,0) size 50x0 [bgcolor=#FF] [r=0 c=2 rs=1 cs=1]


Added: trunk/LayoutTests/fast/table/table-anonymous-cell-bug.html (0 => 98372)

--- trunk/LayoutTests/fast/table/table-anonymous-cell-bug.html	(rev 0)
+++ trunk/LayoutTests/fast/table/table-anonymous-cell-bug.html	2011-10-25 19:10:58 UTC (rev 98372)
@@ -0,0 +1,40 @@
+!DOCTYPE html
+html
+body style=font-family: ahem; -webkit-font-smoothing: none;
+style
+div.table { display: table; }
+div.section { display: table-row-group; }
+div.cell { display: table-cell; width: 50px; height: 50px; background-color: blue; }
+div.row { display: table-row; }
+/style
+
+div class=table id=table-1
+  div class=section id=tbody-1
+div class=row id=row-1
+  div class=cell id=cell-1/div
+  div class=cell id=cell-2/div
+  

[webkit-changes] [98373] trunk/Source/WebCore

[tony]

Title: [98373] trunk/Source/WebCore








Revision 98373
Author t...@chromium.org
Date 2011-10-25 12:26:04 -0700 (Tue, 25 Oct 2011)


Log Message
avoid unnecessary layouts of flex items during the flex pass
https://bugs.webkit.org/show_bug.cgi?id=70557

Reviewed by Ojan Vafai.

If the preferred size of a flex item is provided, we don't need to
layout the flex item when computing the preferred size.  This allows
us to only call layout on each flex item once in the common case.

No new tests, covered by existing tests.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthLengthForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
* rendering/RenderFlexibleBox.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (98372 => 98373)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 19:10:58 UTC (rev 98372)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 19:26:04 UTC (rev 98373)
@@ -1,3 +1,23 @@
+2011-10-25  Tony Chang  t...@chromium.org
+
+avoid unnecessary layouts of flex items during the flex pass
+https://bugs.webkit.org/show_bug.cgi?id=70557
+
+Reviewed by Ojan Vafai.
+
+If the preferred size of a flex item is provided, we don't need to
+layout the flex item when computing the preferred size.  This allows
+us to only call layout on each flex item once in the common case.
+
+No new tests, covered by existing tests.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::flowAwareLogicalWidthLengthForChild):
+(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
+(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
+(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
+* rendering/RenderFlexibleBox.h:
+
 2011-10-25  Fady Samuel  fsam...@chromium.org
 
 Crash in WebCore::RenderTableSection::addChild due to assert failure


Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (98372 => 98373)

--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2011-10-25 19:10:58 UTC (rev 98372)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2011-10-25 19:26:04 UTC (rev 98373)
@@ -228,6 +228,11 @@
 return style()-isLeftToRightDirection();
 }
 
+Length RenderFlexibleBox::flowAwareLogicalWidthLengthForChild(RenderBox* child) const
+{
+return isHorizontalFlow() ? child-style()-width() : child-style()-height();
+}
+
 bool RenderFlexibleBox::isFlowAwareLogicalHeightAuto() const
 {
 Length height = isHorizontalFlow() ? style()-height() : style()-width();
@@ -493,12 +498,12 @@
 
 LayoutUnit RenderFlexibleBox::preferredLogicalContentWidthForFlexItem(RenderBox* child) const
 {
-Length width = isHorizontalFlow() ? child-style()-width() : child-style()-height();
-if (width.isAuto()) {
+Length logicalWidthLength = flowAwareLogicalWidthLengthForChild(child);
+if (logicalWidthLength.isAuto()) {
 LayoutUnit logicalWidth = hasOrthogonalFlow(child) ? child-logicalHeight() : child-maxPreferredLogicalWidth();
 return logicalWidth - logicalBorderAndPaddingWidthForChild(child) - logicalScrollbarHeightForChild(child);
 }
-return isHorizontalFlow() ? child-contentWidth() : child-contentHeight();
+return logicalWidthLength.calcMinValue(flowAwareContentLogicalWidth());
 }
 
 void RenderFlexibleBox::layoutInlineDirection(bool relayoutChildren)
@@ -554,20 +559,24 @@
 
 LayoutUnit flexboxAvailableLogicalWidth = flowAwareContentLogicalWidth();
 for (RenderBox* child = iterator.first(); child; child = iterator.next()) {
-// We always have to lay out flexible objects again, since the flex distribution
-// may have changed, and we need to reallocate space.
-child-clearOverrideSize();
-if (!relayoutChildren)
-child-setChildNeedsLayout(true);
-child-layoutIfNeeded();
+if (flowAwareLogicalWidthLengthForChild(child).isAuto()) {
+child-clearOverrideSize();
+if (!relayoutChildren)
+child-setChildNeedsLayout(true);
+child-layoutIfNeeded();
+}
 
-// We can't just use marginStartForChild, et. al. because auto needs to be treated as 0.
+// We set the margins because we want to make sure 'auto' has a margin
+// of 0 and because if we're not auto sizing, we don't do a layout that
+// computes the start/end margins.
 if (isHorizontalFlow()) {
-preferredLogicalWidth += child-style()-marginLeft().calcMinValue(flexboxAvailableLogicalWidth);
-preferredLogicalWidth += 

[webkit-changes] [98374] trunk/Source/WebCore

[cevans]

Title: [98374] trunk/Source/WebCore








Revision 98374
Author cev...@google.com
Date 2011-10-25 12:28:15 -0700 (Tue, 25 Oct 2011)


Log Message
Manage the CSS property array length correctly
https://bugs.webkit.org/show_bug.cgi?id=70783

Reviewed by Adam Barth.

* css/CSSParser.cpp:
(WebCore::CSSParser::addProperty): don't allow max length to get out of sync with the buffer.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (98373 => 98374)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 19:26:04 UTC (rev 98373)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 19:28:15 UTC (rev 98374)
@@ -1,3 +1,13 @@
+2011-10-25  Chris Evans  cev...@google.com
+
+Manage the CSS property array length correctly
+https://bugs.webkit.org/show_bug.cgi?id=70783
+
+Reviewed by Adam Barth.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::addProperty): don't allow max length to get out of sync with the buffer.
+
 2011-10-25  Tony Chang  t...@chromium.org
 
 avoid unnecessary layouts of flex items during the flex pass


Modified: trunk/Source/WebCore/css/CSSParser.cpp (98373 => 98374)

--- trunk/Source/WebCore/css/CSSParser.cpp	2011-10-25 19:26:04 UTC (rev 98373)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2011-10-25 19:28:15 UTC (rev 98374)
@@ -613,9 +613,9 @@
 {
 OwnPtrCSSProperty prop(adoptPtr(new CSSProperty(propId, value, important, m_currentShorthand, m_implicitShorthand)));
 if (m_numParsedProperties = m_maxParsedProperties) {
+if (m_numParsedProperties  (UINT_MAX / sizeof(CSSProperty*)) - 32)
+CRASH();  // Avoid inconsistencies with rollbackLastProperties.
 m_maxParsedProperties += 32;
-if (m_maxParsedProperties  UINT_MAX / sizeof(CSSProperty*))
-return;
 m_parsedProperties = static_castCSSProperty**(fastRealloc(m_parsedProperties,
 m_maxParsedProperties * sizeof(CSSProperty*)));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98375] trunk/LayoutTests

[jchaffraix]

Title: [98375] trunk/LayoutTests








Revision 98375
Author jchaffr...@webkit.org
Date 2011-10-25 12:31:35 -0700 (Tue, 25 Oct 2011)


Log Message
Unreviewed gardening.

* platform/chromium/test_expectations.txt: Marking a test as timing
out.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (98374 => 98375)

--- trunk/LayoutTests/ChangeLog	2011-10-25 19:28:15 UTC (rev 98374)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 19:31:35 UTC (rev 98375)
@@ -1,3 +1,10 @@
+2011-10-25  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
+* platform/chromium/test_expectations.txt: Marking a test as timing
+out.
+
 2011-10-25  Fady Samuel  fsam...@chromium.org
 
 Crash in WebCore::RenderTableSection::addChild due to assert failure


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98374 => 98375)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-25 19:28:15 UTC (rev 98374)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-25 19:31:35 UTC (rev 98375)
@@ -3808,3 +3808,5 @@
 BUGWK67031 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH
 
 BUGWK70749 SNOWLEOPARD CPU GPU : fast/ruby/base-shorter-than-text.html = IMAGE+TEXT PASS
+
+BUGWK70837 GPU : compositing/video/video-poster.html = PASS TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98376] trunk/Source/WebKit/efl

[commit-queue]

Title: [98376] trunk/Source/WebKit/efl








Revision 98376
Author commit-qu...@webkit.org
Date 2011-10-25 12:32:31 -0700 (Tue, 25 Oct 2011)


Log Message
[EFL] Add necessary information for callback instropection
https://bugs.webkit.org/show_bug.cgi?id=70735

Patch by Ivan Briano i...@profusion.mobi on 2011-10-25
Reviewed by Antonio Gomes.

Provide the information about smart callbacks emitted by the ewk_view
object, so that these can be easily forwarded by other objects or used
by bindings in other languages without having to keep track of all of
them manually.

* ewk/ewk_view.cpp:
(ewk_view_base_smart_set):

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (98375 => 98376)

--- trunk/Source/WebKit/efl/ChangeLog	2011-10-25 19:31:35 UTC (rev 98375)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-10-25 19:32:31 UTC (rev 98376)
@@ -1,3 +1,18 @@
+2011-10-25  Ivan Briano  i...@profusion.mobi
+
+[EFL] Add necessary information for callback instropection
+https://bugs.webkit.org/show_bug.cgi?id=70735
+
+Reviewed by Antonio Gomes.
+
+Provide the information about smart callbacks emitted by the ewk_view
+object, so that these can be easily forwarded by other objects or used
+by bindings in other languages without having to keep track of all of
+them manually.
+
+* ewk/ewk_view.cpp:
+(ewk_view_base_smart_set):
+
 2011-10-24  Ivan Briano  i...@profusion.mobi
 
 [EFL] Build fix. Rename all instances of a variable when it gets changed


Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (98375 => 98376)

--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-10-25 19:31:35 UTC (rev 98375)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-10-25 19:32:31 UTC (rev 98376)
@@ -82,6 +82,43 @@
 static const size_t EWK_VIEW_SCROLLS_SIZE_STEP = 2;
 static const size_t EWK_VIEW_SCROLLS_SIZE_MAX_FREE = 32;
 
+static const Evas_Smart_Cb_Description _ewk_view_callback_names[] = {
+{ download,request, p },
+{ editorclient,contents,changed,  },
+{ editorclient,selection,changed,  },
+{ frame,created, p },
+{ icon,received,  },
+{ inputmethod,changed, b },
+{ js,windowobject,clear,  },
+{ link,hover,in, p },
+{ link,hover,out,  },
+{ load,document,finished, p },
+{ load,error, p },
+{ load,finished, p },
+{ load,newwindow,show,  },
+{ load,progress, d },
+{ load,provisional,  },
+{ load,started,  },
+{ menubar,visible,get, b },
+{ menubar,visible,set, b },
+{ popup,created, p },
+{ popup,willdelete, p },
+{ ready,  },
+{ scrollbars,visible,get, b },
+{ scrollbars,visible,set, b },
+{ statusbar,text,set, s },
+{ statusbar,visible,get, b },
+{ statusbar,visible,set, b },
+{ title,changed, s },
+{ toolbars,visible,get, b },
+{ toolbars,visible,set, b },
+{ tooltip,text,set, s },
+{ uri,changed, s },
+{ view,resized,  },
+{ zoom,animated,end,  },
+{ 0, 0 }
+};
+
 /**
  * @brief Private data that is used internally by EFL WebKit
  * and should never be modified from outside.
@@ -1093,6 +1130,7 @@
 api-sc.show = _ewk_view_smart_show;
 api-sc.hide = _ewk_view_smart_hide;
 api-sc.data = "" /* used by type checking */
+api-sc.callbacks = _ewk_view_callback_names;
 
 api-contents_resize = _ewk_view_smart_contents_resize;
 api-zoom_set = _ewk_view_smart_zoom_set;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98377] trunk/Tools

[dbates]

Title: [98377] trunk/Tools








Revision 98377
Author dba...@webkit.org
Date 2011-10-25 12:37:13 -0700 (Tue, 25 Oct 2011)


Log Message
build-webkit --clean should only clean build directory for CMake-based ports
https://bugs.webkit.org/show_bug.cgi?id=70834

Reviewed by Antonio Gomes.

Currently build-webkit --clean both cleans the build directory and builds WebKit for
CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
as per its description in the usage message of build-webkit.

* Scripts/webkitdirs.pm:
(buildCMakeProjectOrExit):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (98376 => 98377)

--- trunk/Tools/ChangeLog	2011-10-25 19:32:31 UTC (rev 98376)
+++ trunk/Tools/ChangeLog	2011-10-25 19:37:13 UTC (rev 98377)
@@ -1,3 +1,17 @@
+2011-10-25  Daniel Bates  dba...@rim.com
+
+build-webkit --clean should only clean build directory for CMake-based ports
+https://bugs.webkit.org/show_bug.cgi?id=70834
+
+Reviewed by Antonio Gomes.
+
+Currently build-webkit --clean both cleans the build directory and builds WebKit for
+CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
+as per its description in the usage message of build-webkit.
+
+* Scripts/webkitdirs.pm:
+(buildCMakeProjectOrExit):
+
 2011-10-25  Anna Cavender  ann...@chromium.org
 
 Enable running of track layout tests for Chromium


Modified: trunk/Tools/Scripts/webkitdirs.pm (98376 => 98377)

--- trunk/Tools/Scripts/webkitdirs.pm	2011-10-25 19:32:31 UTC (rev 98376)
+++ trunk/Tools/Scripts/webkitdirs.pm	2011-10-25 19:37:13 UTC (rev 98377)
@@ -1664,10 +1664,9 @@
 {
 my ($clean, $port, $prefixPath, $makeArgs, @cmakeArgs) = @_;
 my $returnCode;
-if ($clean) {
-$returnCode = exitStatus(cleanCMakeGeneratedProject());
-exit($returnCode) if $returnCode;
-}
+
+exit(exitStatus(cleanCMakeGeneratedProject())) if $clean;
+
 $returnCode = exitStatus(generateBuildSystemFromCMakeProject($port, $prefixPath, @cmakeArgs));
 exit($returnCode) if $returnCode;
 $returnCode = exitStatus(buildCMakeGeneratedProject($makeArgs));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98378] trunk/Source/WebKit/efl

[commit-queue]

Title: [98378] trunk/Source/WebKit/efl








Revision 98378
Author commit-qu...@webkit.org
Date 2011-10-25 12:45:27 -0700 (Tue, 25 Oct 2011)


Log Message
[EFL] Add function to get geometry of focused element
https://bugs.webkit.org/show_bug.cgi?id=70728

Patch by Ivan Briano i...@profusion.mobi on 2011-10-25
Reviewed by Antonio Gomes.

Added function to ewk_frame to get the geometry of the focused
element within the frame object.

* ewk/ewk_frame.cpp:
(ewk_frame_focused_element_geometry_get): Retrieves the geometry of
the focused element within the given frame object.
* ewk/ewk_frame.h:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
trunk/Source/WebKit/efl/ewk/ewk_frame.h




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (98377 => 98378)

--- trunk/Source/WebKit/efl/ChangeLog	2011-10-25 19:37:13 UTC (rev 98377)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-10-25 19:45:27 UTC (rev 98378)
@@ -1,5 +1,20 @@
 2011-10-25  Ivan Briano  i...@profusion.mobi
 
+[EFL] Add function to get geometry of focused element
+https://bugs.webkit.org/show_bug.cgi?id=70728
+
+Reviewed by Antonio Gomes.
+
+Added function to ewk_frame to get the geometry of the focused
+element within the frame object.
+
+* ewk/ewk_frame.cpp:
+(ewk_frame_focused_element_geometry_get): Retrieves the geometry of
+the focused element within the given frame object.
+* ewk/ewk_frame.h:
+
+2011-10-25  Ivan Briano  i...@profusion.mobi
+
 [EFL] Add necessary information for callback instropection
 https://bugs.webkit.org/show_bug.cgi?id=70735
 


Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (98377 => 98378)

--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-10-25 19:37:13 UTC (rev 98377)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-10-25 19:45:27 UTC (rev 98378)
@@ -826,6 +826,27 @@
 return EINA_FALSE;
 }
 
+Eina_Bool ewk_frame_focused_element_geometry_get(const Evas_Object *ewkFrame, int *x, int *y, int *w, int *h)
+{
+EWK_FRAME_SD_GET_OR_RETURN(ewkFrame, smartData, EINA_FALSE);
+WebCore::Document* document = smartData-frame-document();
+if (!document)
+return EINA_FALSE;
+WebCore::Node* focusedNode = document-focusedNode();
+if (!focusedNode)
+return EINA_FALSE;
+WebCore::IntRect nodeRect = focusedNode-getRect();
+if (x)
+*x = nodeRect.x();
+if (y)
+*y = nodeRect.y();
+if (w)
+*w = nodeRect.width();
+if (h)
+*h = nodeRect.height();
+return EINA_TRUE;
+}
+
 Eina_Bool ewk_frame_feed_mouse_wheel(Evas_Object* ewkFrame, const Evas_Event_Mouse_Wheel* wheelEvent)
 {
 EWK_FRAME_SD_GET_OR_RETURN(ewkFrame, smartData, EINA_FALSE);


Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.h (98377 => 98378)

--- trunk/Source/WebKit/efl/ewk/ewk_frame.h	2011-10-25 19:37:13 UTC (rev 98377)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.h	2011-10-25 19:45:27 UTC (rev 98378)
@@ -701,6 +701,21 @@
 EAPI Eina_Boolewk_frame_feed_focus_out(Evas_Object *o);
 
 /**
+ * Gets the geometry, relative to the frame, of the focused element in the
+ * document.
+ *
+ * @param o frame object containing the focused element
+ * @param x pointer where to store the X value of the geometry, may be @c 0
+ * @param x pointer where to store the Y value of the geometry, may be @c 0
+ * @param x pointer where to store width of the geometry, may be @c 0
+ * @param x pointer where to store height of the geometry, may be @c 0
+ *
+ * @return @c EINA_TRUE if the frame contains the currently focused element and
+ * its geometry was correctly fetched, @c EINA_FALSE in any other case
+ */
+EAPI Eina_Bool ewk_frame_focused_element_geometry_get(const Evas_Object *o, int *x, int *y, int *w, int *h);
+
+/**
  * Feeds the mouse wheel event to the frame.
  *
  * @param o frame object to feed the mouse wheel event






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98379] trunk

[abarth]

Title: [98379] trunk








Revision 98379
Author aba...@webkit.org
Date 2011-10-25 12:48:28 -0700 (Tue, 25 Oct 2011)


Log Message
Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816

Patch by Pavel Podivilov podivi...@chromium.org on 2011-10-25
Reviewed by Adam Barth.

Optional parameters in the middle are prohibited by WebIDL spec.

Source/WebCore:

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):
* html/canvas/CanvasRenderingContext2D.idl:
* page/DOMWindow.idl:

LayoutTests:

* fast/canvas/canvas-putImageData-expected.txt:
* fast/canvas/canvas-putImageData.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt
trunk/LayoutTests/fast/canvas/canvas-putImageData.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl
trunk/Source/WebCore/page/DOMWindow.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (98378 => 98379)

--- trunk/LayoutTests/ChangeLog	2011-10-25 19:45:27 UTC (rev 98378)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 19:48:28 UTC (rev 98379)
@@ -1,3 +1,15 @@
+2011-10-25  Pavel Podivilov  podivi...@chromium.org
+
+Get rid of optional parameters in the middle in IDLs.
+https://bugs.webkit.org/show_bug.cgi?id=70816
+
+Reviewed by Adam Barth.
+
+Optional parameters in the middle are prohibited by WebIDL spec.
+
+* fast/canvas/canvas-putImageData-expected.txt:
+* fast/canvas/canvas-putImageData.js:
+
 2011-10-25  Julien Chaffraix  jchaffr...@webkit.org
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt (98378 => 98379)

--- trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt	2011-10-25 19:45:27 UTC (rev 98378)
+++ trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt	2011-10-25 19:48:28 UTC (rev 98379)
@@ -144,7 +144,7 @@
 PASS getPixel(9,9) is [0,128,0,255]
 PASS getPixel(1,1) is [0,128,0,255]
 PASS getPixel(9,9) is [0,128,0,255]
-PASS context.putImageData({}, 0, 0) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
+PASS context.putImageData({}, 0, 0) threw exception TypeError: Type error.
 PASS context.putImageData(buffer, NaN, 0, 0, 0, 0, 0) threw exception Error: NOT_SUPPORTED_ERR: DOM Exception 9.
 PASS context.putImageData(buffer, 0, NaN, 0, 0, 0, 0) threw exception Error: NOT_SUPPORTED_ERR: DOM Exception 9.
 PASS context.putImageData(buffer, 0, 0, NaN, 0, 0, 0) threw exception Error: NOT_SUPPORTED_ERR: DOM Exception 9.


Modified: trunk/LayoutTests/fast/canvas/canvas-putImageData.js (98378 => 98379)

--- trunk/LayoutTests/fast/canvas/canvas-putImageData.js	2011-10-25 19:45:27 UTC (rev 98378)
+++ trunk/LayoutTests/fast/canvas/canvas-putImageData.js	2011-10-25 19:48:28 UTC (rev 98379)
@@ -201,7 +201,7 @@
 pixelShouldBe(9, 9, [0, 128,0,255]);
 
 
-shouldThrow(context.putImageData({}, 0, 0), 'Error: TYPE_MISMATCH_ERR: DOM Exception 17');
+shouldThrow(context.putImageData({}, 0, 0), 'TypeError: Type error');
 shouldThrow(context.putImageData(buffer, NaN, 0, 0, 0, 0, 0), 'Error: NOT_SUPPORTED_ERR: DOM Exception 9');
 shouldThrow(context.putImageData(buffer, 0, NaN, 0, 0, 0, 0), 'Error: NOT_SUPPORTED_ERR: DOM Exception 9');
 shouldThrow(context.putImageData(buffer, 0, 0, NaN, 0, 0, 0), 'Error: NOT_SUPPORTED_ERR: DOM Exception 9');


Modified: trunk/Source/WebCore/ChangeLog (98378 => 98379)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 19:45:27 UTC (rev 98378)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 19:48:28 UTC (rev 98379)
@@ -1,3 +1,22 @@
+2011-10-25  Pavel Podivilov  podivi...@chromium.org
+
+Get rid of optional parameters in the middle in IDLs.
+https://bugs.webkit.org/show_bug.cgi?id=70816
+
+Reviewed by Adam Barth.
+
+Optional parameters in the middle are prohibited by WebIDL spec.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+(GenerateImplementation):
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateHeader):
+(GenerateArgumentsCountCheck):
+(GenerateImplementation):
+* html/canvas/CanvasRenderingContext2D.idl:
+* page/DOMWindow.idl:
+
 2011-10-25  Chris Evans  cev...@google.com
 
 Manage the CSS property array length correctly


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (98378 => 98379)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-10-25 19:45:27 UTC (rev 98378)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-10-25 19:48:28 UTC (rev 98379)
@@ -910,10 +910,10 @@
 if ($numCustomFunctions  0) {
 push(@headerContent, \n// Custom functions\n);

[webkit-changes] [98381] trunk/Source/WebKit/chromium

[commit-queue]

Title: [98381] trunk/Source/WebKit/chromium








Revision 98381
Author commit-qu...@webkit.org
Date 2011-10-25 13:01:34 -0700 (Tue, 25 Oct 2011)


Log Message
Make it possible to create and dispatch a message event through chromium API

Removed messageChannels parameter, since it's hard to get right and I don't need it. Changed message_data-messageData. Reordered includes.

https://bugs.webkit.org/show_bug.cgi?id=69962

Patch by Dave Michael dmich...@chromium.org on 2011-10-25
Reviewed by David Levin.

* WebKit.gyp:
* public/WebDOMEvent.h:
* public/WebDOMMessageEvent.h: Added.
* public/WebDocument.h:
* public/WebNode.h:
* src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::hasPendingActivity):
* src/WebDOMEvent.cpp:
(WebKit::WebDOMEvent::operator WTF::PassRefPtrWebCore::Event):
* src/WebDOMMessageEvent.cpp: Added.
(WebKit::WebDOMMessageEvent::initMessageEvent):
* src/WebDocument.cpp:
(WebKit::WebDocument::createEvent):
* src/WebNode.cpp:
(WebKit::WebNode::dispatchEvent):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/WebDOMEvent.h
trunk/Source/WebKit/chromium/public/WebDocument.h
trunk/Source/WebKit/chromium/public/WebNode.h
trunk/Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp
trunk/Source/WebKit/chromium/src/WebDOMEvent.cpp
trunk/Source/WebKit/chromium/src/WebDocument.cpp
trunk/Source/WebKit/chromium/src/WebNode.cpp


Added Paths

trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h
trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (98380 => 98381)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 19:50:25 UTC (rev 98380)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 20:01:34 UTC (rev 98381)
@@ -1,3 +1,29 @@
+2011-10-25  Dave Michael  dmich...@chromium.org
+
+Make it possible to create and dispatch a message event through chromium API
+
+Removed messageChannels parameter, since it's hard to get right and I don't need it. Changed message_data-messageData. Reordered includes.
+
+https://bugs.webkit.org/show_bug.cgi?id=69962
+
+Reviewed by David Levin.
+
+* WebKit.gyp:
+* public/WebDOMEvent.h:
+* public/WebDOMMessageEvent.h: Added.
+* public/WebDocument.h:
+* public/WebNode.h:
+* src/PlatformMessagePortChannel.cpp:
+(WebCore::PlatformMessagePortChannel::hasPendingActivity):
+* src/WebDOMEvent.cpp:
+(WebKit::WebDOMEvent::operator WTF::PassRefPtrWebCore::Event):
+* src/WebDOMMessageEvent.cpp: Added.
+(WebKit::WebDOMMessageEvent::initMessageEvent):
+* src/WebDocument.cpp:
+(WebKit::WebDocument::createEvent):
+* src/WebNode.cpp:
+(WebKit::WebNode::dispatchEvent):
+
 2011-10-25  Gene Girard  gir...@chromium.org
 
 Re-enable touch tests (from 66577)


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (98380 => 98381)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2011-10-25 19:50:25 UTC (rev 98380)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2011-10-25 20:01:34 UTC (rev 98381)
@@ -140,6 +140,7 @@
 'public/WebCursorInfo.h',
 'public/WebDOMEvent.h',
 'public/WebDOMEventListener.h',
+'public/WebDOMMessageEvent.h',
 'public/WebDOMMouseEvent.h',
 'public/WebDOMMutationEvent.h',
 'public/WebDOMStringList.h',
@@ -462,6 +463,7 @@
 'src/WebDOMEventListener.cpp',
 'src/WebDOMEventListenerPrivate.cpp',
 'src/WebDOMEventListenerPrivate.h',
+'src/WebDOMMessageEvent.cpp',
 'src/WebDOMMouseEvent.cpp',
 'src/WebDOMMutationEvent.cpp',
 'src/WebDOMStringList.cpp',


Modified: trunk/Source/WebKit/chromium/public/WebDOMEvent.h (98380 => 98381)

--- trunk/Source/WebKit/chromium/public/WebDOMEvent.h	2011-10-25 19:50:25 UTC (rev 98380)
+++ trunk/Source/WebKit/chromium/public/WebDOMEvent.h	2011-10-25 20:01:34 UTC (rev 98381)
@@ -95,6 +95,7 @@
 
 #if WEBKIT_IMPLEMENTATION
 WebDOMEvent(const WTF::PassRefPtrWebCore::Event);
+operator WTF::PassRefPtrWebCore::Event() const;
 #endif
 
 templatetypename T T to()


Added: trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h (0 => 98381)

--- trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h	(rev 0)
+++ trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h	2011-10-25 20:01:34 UTC (rev 98381)
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * 

[webkit-changes] [98383] trunk/Source/JavaScriptCore

[mhahnenberg]

Title: [98383] trunk/Source/_javascript_Core








Revision 98383
Author mhahnenb...@apple.com
Date 2011-10-25 13:23:56 -0700 (Tue, 25 Oct 2011)


Log Message
Fixing Windows build after r98367

Unreviewed build fix

* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (98382 => 98383)

--- trunk/Source/_javascript_Core/ChangeLog	2011-10-25 20:22:58 UTC (rev 98382)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-10-25 20:23:56 UTC (rev 98383)
@@ -1,3 +1,11 @@
+2011-10-25  Mark Hahnenberg  mhahnenb...@apple.com
+
+Fixing Windows build after r98367
+
+Unreviewed build fix
+
+* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
+
 2011-10-25  Yuqiang Xian  yuqiang.x...@intel.com
 
 Add missing DFG file entries to the make lists for GTK and Qt ports


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (98382 => 98383)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-10-25 20:22:58 UTC (rev 98382)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-10-25 20:23:56 UTC (rev 98383)
@@ -202,10 +202,13 @@
 ?getOwnPropertyNames@JSObject@JSC@@UAEXPAVExecState@2@AAVPropertyNameArray@2@W4EnumerationMode@2@@Z
 ?getOwnPropertyNames@JSVariableObject@JSC@@UAEXPAVExecState@2@AAVPropertyNameArray@2@W4EnumerationMode@2@@Z
 ?getOwnPropertyNames@StringObject@JSC@@UAEXPAVExecState@2@AAVPropertyNameArray@2@W4EnumerationMode@2@@Z
+?getOwnPropertySlot@JSByteArray@JSC@@SA_NPAVJSCell@2@PAVExecState@2@ABVIdentifier@2@AAVPropertySlot@2@@Z
 ?getOwnPropertySlot@JSGlobalObject@JSC@@SA_NPAVJSCell@2@PAVExecState@2@ABVIdentifier@2@AAVPropertySlot@2@@Z
 ?getOwnPropertySlotByIndex@JSArray@JSC@@SA_NPAVJSCell@2@PAVExecState@2@IAAVPropertySlot@2@@Z
-?getOwnPropertySlotVirtual@JSCell@JSC@@EAE_NPAVExecState@2@ABVIdentifier@2@AAVPropertySlot@2@@Z
-?getOwnPropertySlotVirtual@JSCell@JSC@@EAE_NPAVExecState@2@IAAVPropertySlot@2@@Z
+?getOwnPropertySlotByIndex@JSByteArray@JSC@@SA_NPAVJSCell@2@PAVExecState@2@IAAVPropertySlot@2@@Z
+?getOwnPropertySlotByIndex@JSObject@JSC@@SA_NPAVJSCell@2@PAVExecState@2@IAAVPropertySlot@2@@Z
+?getOwnPropertySlotVirtual@JSCell@JSC@@MAE_NPAVExecState@2@ABVIdentifier@2@AAVPropertySlot@2@@Z
+?getOwnPropertySlotVirtual@JSCell@JSC@@MAE_NPAVExecState@2@IAAVPropertySlot@2@@Z
 ?getOwnPropertySlotVirtual@JSGlobalObject@JSC@@UAE_NPAVExecState@2@ABVIdentifier@2@AAVPropertySlot@2@@Z
 ?getOwnPropertySlotVirtual@JSObject@JSC@@UAE_NPAVExecState@2@IAAVPropertySlot@2@@Z
 ?getPropertyDescriptor@JSObject@JSC@@QAE_NPAVExecState@2@ABVIdentifier@2@AAVPropertyDescriptor@2@@Z






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98384] trunk/Source/WebKit/chromium

[commit-queue]

Title: [98384] trunk/Source/WebKit/chromium








Revision 98384
Author commit-qu...@webkit.org
Date 2011-10-25 13:30:24 -0700 (Tue, 25 Oct 2011)


Log Message
[chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
https://bugs.webkit.org/show_bug.cgi?id=70818

Patch by Michal Mocny mmo...@google.com on 2011-10-25
Reviewed by Kenneth Russell.

* public/WebGraphicsContext3D.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (98383 => 98384)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 20:23:56 UTC (rev 98383)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 20:30:24 UTC (rev 98384)
@@ -1,3 +1,12 @@
+2011-10-25  Michal Mocny  mmo...@google.com
+
+[chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
+https://bugs.webkit.org/show_bug.cgi?id=70818
+
+Reviewed by Kenneth Russell.
+
+* public/WebGraphicsContext3D.h:
+
 2011-10-25  Dave Michael  dmich...@chromium.org
 
 Make it possible to create and dispatch a message event through chromium API


Modified: trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h (98383 => 98384)

--- trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h	2011-10-25 20:23:56 UTC (rev 98383)
+++ trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h	2011-10-25 20:30:24 UTC (rev 98384)
@@ -141,7 +141,7 @@
 virtual void reshape(int width, int height) = 0;
 
 // GL_CHROMIUM_setVisibility - Changes the visibility of the backbuffer
-virtual void setVisibilityCHROMIUM(bool visible) { }
+virtual void setVisibilityCHROMIUM(bool visible) = 0;
 
 // Query whether it is built on top of compliant GLES2 implementation.
 virtual bool isGLES2Compliant() = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98385] trunk/Source/WebCore

[podivilov]

Title: [98385] trunk/Source/WebCore








Revision 98385
Author podivi...@chromium.org
Date 2011-10-25 13:36:54 -0700 (Tue, 25 Oct 2011)


Log Message
Fix several minor problems in idls.
https://bugs.webkit.org/show_bug.cgi?id=70811

Reviewed by Adam Barth.

This patch does not have any effect on generated bindings.

* dom/DataTransferItems.idl:
* page/History.idl:
* storage/IDBIndex.idl:
* xml/XMLHttpRequest.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DataTransferItems.idl
trunk/Source/WebCore/page/History.idl
trunk/Source/WebCore/storage/IDBIndex.idl
trunk/Source/WebCore/xml/XMLHttpRequest.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (98384 => 98385)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 20:30:24 UTC (rev 98384)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 20:36:54 UTC (rev 98385)
@@ -1,3 +1,17 @@
+2011-10-25  Pavel Podivilov  podivi...@chromium.org
+
+Fix several minor problems in idls.
+https://bugs.webkit.org/show_bug.cgi?id=70811
+
+Reviewed by Adam Barth.
+
+This patch does not have any effect on generated bindings.
+
+* dom/DataTransferItems.idl:
+* page/History.idl:
+* storage/IDBIndex.idl:
+* xml/XMLHttpRequest.idl:
+
 2011-10-25  Nate Chapin  jap...@chromium.org
 
 Make DocumentThreadableLoader a CachedResourceClient.


Modified: trunk/Source/WebCore/dom/DataTransferItems.idl (98384 => 98385)

--- trunk/Source/WebCore/dom/DataTransferItems.idl	2011-10-25 20:30:24 UTC (rev 98384)
+++ trunk/Source/WebCore/dom/DataTransferItems.idl	2011-10-25 20:36:54 UTC (rev 98385)
@@ -38,7 +38,7 @@
 #endif
 ] DataTransferItems {
 readonly attribute long length;
-DataTransferItem item(in [Optional=CallWithDefaultValue] unsigned long index) getter;
+DataTransferItem item(in [Optional=CallWithDefaultValue] unsigned long index);
 
 void clear();
 void add(in [Optional=CallWithDefaultValue] DOMString data, 


Modified: trunk/Source/WebCore/page/History.idl (98384 => 98385)

--- trunk/Source/WebCore/page/History.idl	2011-10-25 20:30:24 UTC (rev 98384)
+++ trunk/Source/WebCore/page/History.idl	2011-10-25 20:36:54 UTC (rev 98385)
@@ -42,9 +42,9 @@
 [DoNotCheckDomainSecurity, CallWith=ScriptExecutionContext] void forward();
 [DoNotCheckDomainSecurity, CallWith=ScriptExecutionContext] void go(in [Optional=CallWithDefaultValue] long distance);
 
-[Custom, EnabledAtRuntime] void pushState(in any data, in DOMString title, in optional DOMString url)
+[Custom, EnabledAtRuntime] void pushState(in any data, in DOMString title, in [Optional] DOMString url)
 raises(DOMException);
-[Custom, EnabledAtRuntime] void replaceState(in any data, in DOMString title, in optional DOMString url)
+[Custom, EnabledAtRuntime] void replaceState(in any data, in DOMString title, in [Optional] DOMString url)
 raises(DOMException);
 };
 


Modified: trunk/Source/WebCore/storage/IDBIndex.idl (98384 => 98385)

--- trunk/Source/WebCore/storage/IDBIndex.idl	2011-10-25 20:30:24 UTC (rev 98384)
+++ trunk/Source/WebCore/storage/IDBIndex.idl	2011-10-25 20:36:54 UTC (rev 98385)
@@ -35,7 +35,7 @@
 
 [CallWith=ScriptExecutionContext] IDBRequest openCursor(in [Optional] IDBKeyRange range, in [Optional] unsigned short direction)
 raises (IDBDatabaseException);
-[CallWith=ScriptExecutionContext] IDBRequest openKeyCursor(in [Optional] IDBKeyRange range, in [Optional] unsigned short direction))
+[CallWith=ScriptExecutionContext] IDBRequest openKeyCursor(in [Optional] IDBKeyRange range, in [Optional] unsigned short direction)
 raises (IDBDatabaseException);
 [CallWith=ScriptExecutionContext] IDBRequest get(in IDBKey key)
 raises (IDBDatabaseException);


Modified: trunk/Source/WebCore/xml/XMLHttpRequest.idl (98384 => 98385)

--- trunk/Source/WebCore/xml/XMLHttpRequest.idl	2011-10-25 20:30:24 UTC (rev 98384)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.idl	2011-10-25 20:36:54 UTC (rev 98385)
@@ -64,10 +64,8 @@
 
 attribute boolean withCredentials
 setter raises(DOMException);
-// void open(in DOMString method, in DOMString url);
-// void open(in DOMString method, in DOMString url, in boolean async);
-// void open(in DOMString method, in DOMString url, in boolean async, in DOMString user);
-[Custom] void open(in DOMString method, in DOMString url, in boolean async, in DOMString user, in DOMString password)
+
+[Custom] void open(in DOMString method, in DOMString url, in [Optional] boolean async, in [Optional] DOMString user, in [Optional] DOMString password)
 raises(DOMException);
 
 void setRequestHeader(in DOMString header, in DOMString value)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [98386] trunk/Source/WebKit2

[weinig]

Title: [98386] trunk/Source/WebKit2








Revision 98386
Author wei...@apple.com
Date 2011-10-25 13:38:25 -0700 (Tue, 25 Oct 2011)


Log Message
Make loadFileURL:restrictToFilesWithin: work, albeit, without the correct
restrictions for now.

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98385 => 98386)

--- trunk/Source/WebKit2/ChangeLog	2011-10-25 20:36:54 UTC (rev 98385)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-25 20:38:25 UTC (rev 98386)
@@ -1,3 +1,13 @@
+2011-10-25  Sam Weinig  s...@webkit.org
+
+Make loadFileURL:restrictToFilesWithin: work, albeit, without the correct
+restrictions for now.
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/mac/WKBrowsingContextController.mm:
+(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):
+
 2011-10-25  Anders Carlsson  ander...@apple.com
 
 PDF SUBFRAMES: Incomplete repaint after pinch to zoom


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm (98385 => 98386)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm	2011-10-25 20:36:54 UTC (rev 98385)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm	2011-10-25 20:38:25 UTC (rev 98386)
@@ -99,7 +99,13 @@
 
 - (void)loadFileURL:(NSURL *)URL restrictToFilesWithin:(NSURL *)allowedDirectory
 {
-/* FIXME: Implement. */
+if (![URL isFileURL])
+return;
+
+/* FIXME: Implement restrictions. */
+
+WKRetainPtrWKURLRef wkURL = adoptWK(WKURLCreateWithCFURL((CFURLRef)URL));
+WKPageLoadURL(self.pageRef, wkURL.get());
 }
 
 - (void)stopLoading






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98387] trunk/Tools

[commit-queue]

Title: [98387] trunk/Tools








Revision 98387
Author commit-qu...@webkit.org
Date 2011-10-25 13:42:19 -0700 (Tue, 25 Oct 2011)


Log Message
[EFL] DRT: Force layout when sending events.
https://bugs.webkit.org/show_bug.cgi?id=70357

Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-10-25
Reviewed by Antonio Gomes.

Some tests such as editing/input/page-up-down-scrolls.html rely on the
scrollbars being properly set up during the onload events.
Document::implicitClose(), however, dispatches the onload events before
calling FrameView::layout(), so these tests usually fail.

We now do the same as the GTK+ and Chromium ports and manually force the
layout when dispatching events.

* DumpRenderTree/efl/EventSender.cpp:
(sendMouseEvent):
(keyDownCallback):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/EventSender.cpp




Diff

Modified: trunk/Tools/ChangeLog (98386 => 98387)

--- trunk/Tools/ChangeLog	2011-10-25 20:38:25 UTC (rev 98386)
+++ trunk/Tools/ChangeLog	2011-10-25 20:42:19 UTC (rev 98387)
@@ -1,3 +1,22 @@
+2011-10-25  Raphael Kubo da Costa  k...@profusion.mobi
+
+[EFL] DRT: Force layout when sending events.
+https://bugs.webkit.org/show_bug.cgi?id=70357
+
+Reviewed by Antonio Gomes.
+
+Some tests such as editing/input/page-up-down-scrolls.html rely on the
+scrollbars being properly set up during the onload events.
+Document::implicitClose(), however, dispatches the onload events before
+calling FrameView::layout(), so these tests usually fail.
+
+We now do the same as the GTK+ and Chromium ports and manually force the
+layout when dispatching events.
+
+* DumpRenderTree/efl/EventSender.cpp:
+(sendMouseEvent):
+(keyDownCallback):
+
 2011-10-25  Daniel Bates  dba...@rim.com
 
 build-webkit --clean should only clean build directory for CMake-based ports


Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (98386 => 98387)

--- trunk/Tools/DumpRenderTree/efl/EventSender.cpp	2011-10-25 20:38:25 UTC (rev 98386)
+++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp	2011-10-25 20:42:19 UTC (rev 98387)
@@ -129,6 +129,8 @@
 {
 unsigned timeStamp = 0;
 
+DumpRenderTreeSupportEfl::layoutFrame(browser-mainFrame());
+
 setEvasModifiers(evas, modifiers);
 if (event  EvasMouseEventMove)
 evas_event_feed_mouse_move(evas, gLastMousePositionX, gLastMousePositionY, timeStamp++, 0);
@@ -423,6 +425,7 @@
 if (!keyName)
 keyName = cCharacter.data();
 
+DumpRenderTreeSupportEfl::layoutFrame(browser-mainFrame());
 evas_event_feed_key_down(evas, keyName, keyName, keyName, 0, 0, 0);
 evas_event_feed_key_up(evas, keyName, keyName, keyName, 0, 1, 0);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98389] trunk/Source/WebCore

[andersca]

Title: [98389] trunk/Source/WebCore








Revision 98389
Author ander...@apple.com
Date 2011-10-25 13:46:14 -0700 (Tue, 25 Oct 2011)


Log Message
REGRESSION(97821): HistoryController::itemsAreClones crashes a lot
https://bugs.webkit.org/show_bug.cgi?id=70827
rdar://problem/10342925

Reviewed by Adam Barth.

Check that m_currentItem is non-null before passing it to itemsAreClones. While I wasn't
able to make a test case that would reproduce this crash, we do check m_currentItem for null
everywhere else, and the crash log indicates that this would fix the crash.

* loader/HistoryController.cpp:
(WebCore::HistoryController::recursiveUpdateForCommit):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/HistoryController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (98388 => 98389)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 20:44:03 UTC (rev 98388)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 20:46:14 UTC (rev 98389)
@@ -1,3 +1,18 @@
+2011-10-25  Anders Carlsson  ander...@apple.com
+
+REGRESSION(97821): HistoryController::itemsAreClones crashes a lot
+https://bugs.webkit.org/show_bug.cgi?id=70827
+rdar://problem/10342925
+
+Reviewed by Adam Barth.
+
+Check that m_currentItem is non-null before passing it to itemsAreClones. While I wasn't
+able to make a test case that would reproduce this crash, we do check m_currentItem for null
+everywhere else, and the crash log indicates that this would fix the crash.
+
+* loader/HistoryController.cpp:
+(WebCore::HistoryController::recursiveUpdateForCommit):
+
 2011-10-25  Adam Barth  aba...@webkit.org
 
 EventTarget.h shouldn't need to know about every feature and ifdef


Modified: trunk/Source/WebCore/loader/HistoryController.cpp (98388 => 98389)

--- trunk/Source/WebCore/loader/HistoryController.cpp	2011-10-25 20:44:03 UTC (rev 98388)
+++ trunk/Source/WebCore/loader/HistoryController.cpp	2011-10-25 20:46:14 UTC (rev 98389)
@@ -472,7 +472,7 @@
 // For each frame that already had the content the item requested (based on
 // (a matching URL and frame tree snapshot), just restore the scroll position.
 // Save form state (works from currentItem, since m_frameLoadComplete is true)
-if (itemsAreClones(m_currentItem.get(), m_provisionalItem.get())) {
+if (m_currentItem  itemsAreClones(m_currentItem.get(), m_provisionalItem.get())) {
 ASSERT(m_frameLoadComplete);
 saveDocumentState();
 saveScrollPositionAndViewStateToItem(m_currentItem.get());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98390] trunk/Tools

[abarth]

Title: [98390] trunk/Tools








Revision 98390
Author aba...@webkit.org
Date 2011-10-25 13:54:27 -0700 (Tue, 25 Oct 2011)


Log Message
Add a --make option to update-webkit to engage the Makefile-based build system
https://bugs.webkit.org/show_bug.cgi?id=70847

Reviewed by Dimitri Glazkov.

I can never remember what crazy environment variables I'm supposed to
set to tell GYP what to do.

* Scripts/update-webkit:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/update-webkit




Diff

Modified: trunk/Tools/ChangeLog (98389 => 98390)

--- trunk/Tools/ChangeLog	2011-10-25 20:46:14 UTC (rev 98389)
+++ trunk/Tools/ChangeLog	2011-10-25 20:54:27 UTC (rev 98390)
@@ -1,3 +1,15 @@
+2011-10-25  Adam Barth  aba...@webkit.org
+
+Add a --make option to update-webkit to engage the Makefile-based build system
+https://bugs.webkit.org/show_bug.cgi?id=70847
+
+Reviewed by Dimitri Glazkov.
+
+I can never remember what crazy environment variables I'm supposed to
+set to tell GYP what to do.
+
+* Scripts/update-webkit:
+
 2011-10-25  Raphael Kubo da Costa  k...@profusion.mobi
 
 [EFL] DRT: Force layout when sending events.


Modified: trunk/Tools/Scripts/update-webkit (98389 => 98390)

--- trunk/Tools/Scripts/update-webkit	2011-10-25 20:46:14 UTC (rev 98389)
+++ trunk/Tools/Scripts/update-webkit	2011-10-25 20:54:27 UTC (rev 98390)
@@ -47,6 +47,7 @@
 my $quiet = '';
 my $showHelp;
 my $useGYP = 0;
+my $useMake = 0;
 
 determineIsChromium();
 determineIsChromiumAndroid();
@@ -59,12 +60,14 @@
 'h|help'  = \$showHelp,
 'q|quiet' = \$quiet,
 'gyp' = \$useGYP,
+'make' = \$useMake,
 ); 
 
 if (!$getOptionsResult || $showHelp) {
 print STDERR __END__;
 Usage: @{[ basename($0) ]} [options]
   --chromium  also update dependencies of the chromium port
+  --make  generate the Makefile-based build system (Chromium only)
   --chromium-android  also update dependencies of the chromium port for Android
   -h|--help   show the help message
   -q|--quiet  pass -q to svn update for quiet updates
@@ -74,6 +77,10 @@
 exit 1;
 }
 
+if ($useMake) {
+$ENV{GYP_GENERATORS} = make;
+}
+
 my $startTime = time();
 
 my @svnOptions = ();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98392] trunk/Source/WebCore

[commit-queue]

Title: [98392] trunk/Source/WebCore








Revision 98392
Author commit-qu...@webkit.org
Date 2011-10-25 13:59:15 -0700 (Tue, 25 Oct 2011)


Log Message
LayerRendererChromium::setVisible called needlessly without a visibility change
https://bugs.webkit.org/show_bug.cgi?id=70766

Patch by Michal Mocny mmo...@google.com on 2011-10-25
Reviewed by Kenneth Russell.

Check that visibility has actually changed before calling LayerRendererChromium::setVisible

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (98391 => 98392)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 20:56:06 UTC (rev 98391)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 20:59:15 UTC (rev 98392)
@@ -1,3 +1,17 @@
+2011-10-25  Michal Mocny  mmo...@google.com
+
+LayerRendererChromium::setVisible called needlessly without a visibility change
+https://bugs.webkit.org/show_bug.cgi?id=70766
+
+Reviewed by Kenneth Russell.
+
+Check that visibility has actually changed before calling LayerRendererChromium::setVisible
+
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
+(WebCore::CCLayerTreeHostImpl::setVisible):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+
 2011-10-25  Anders Carlsson  ander...@apple.com
 
 REGRESSION(97821): HistoryController::itemsAreClones crashes a lot


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (98391 => 98392)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp	2011-10-25 20:56:06 UTC (rev 98391)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp	2011-10-25 20:59:15 UTC (rev 98392)
@@ -48,6 +48,7 @@
 , m_sourceFrameNumber(-1)
 , m_frameNumber(0)
 , m_settings(settings)
+, m_visible(true)
 {
 ASSERT(CCProxy::isImplThread());
 }
@@ -128,6 +129,10 @@
 
 void CCLayerTreeHostImpl::setVisible(bool visible)
 {
+if (m_visible == visible)
+return;
+m_visible = visible;
+
 if (m_layerRenderer)
 m_layerRenderer-setVisible(visible);
 }


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h (98391 => 98392)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h	2011-10-25 20:56:06 UTC (rev 98391)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h	2011-10-25 20:59:15 UTC (rev 98392)
@@ -109,6 +109,7 @@
 RefPtrCCLayerImpl m_rootLayerImpl;
 CCSettings m_settings;
 IntSize m_viewportSize;
+bool m_visible;
 };
 
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98393] trunk/Source

[commit-queue]

Title: [98393] trunk/Source








Revision 98393
Author commit-qu...@webkit.org
Date 2011-10-25 14:10:12 -0700 (Tue, 25 Oct 2011)


Log Message
Fix teardown in Web*LayerImpl, and add tests for Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70431

Patch by Antoine Labour pi...@chromium.org on 2011-10-25
Reviewed by James Robinson.

* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
* src/WebExternalTextureLayerImpl.cpp:
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::~WebLayerImpl):

Modified Paths

trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebLayerImpl.cpp
trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp


Added Paths

trunk/Source/WebKit/chromium/tests/WebLayerTest.cpp




Diff

Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h (98392 => 98393)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h	2011-10-25 20:59:15 UTC (rev 98392)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h	2011-10-25 21:10:12 UTC (rev 98393)
@@ -96,13 +96,13 @@
 const IntSize bounds() const { return m_bounds; }
 virtual IntSize contentBounds() const { return bounds(); }
 
-void setMasksToBounds(bool masksToBounds) { m_masksToBounds = masksToBounds; }
+void setMasksToBounds(bool masksToBounds) { m_masksToBounds = masksToBounds; setNeedsCommit(); }
 bool masksToBounds() const { return m_masksToBounds; }
 
 void setName(const String);
 const String name() const { return m_name; }
 
-void setMaskLayer(LayerChromium* maskLayer) { m_maskLayer = maskLayer; }
+void setMaskLayer(LayerChromium* maskLayer) { m_maskLayer = maskLayer; setNeedsCommit(); }
 LayerChromium* maskLayer() const { return m_maskLayer.get(); }
 
 void setNeedsDisplay(const FloatRect dirtyRect);


Modified: trunk/Source/WebKit/chromium/ChangeLog (98392 => 98393)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 20:59:15 UTC (rev 98392)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-10-25 21:10:12 UTC (rev 98393)
@@ -1,3 +1,17 @@
+2011-10-25  Antoine Labour  pi...@chromium.org
+
+Fix teardown in Web*LayerImpl, and add tests for Web*Layer
+https://bugs.webkit.org/show_bug.cgi?id=70431
+
+Reviewed by James Robinson.
+
+* src/WebContentLayerImpl.cpp:
+(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
+* src/WebExternalTextureLayerImpl.cpp:
+(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
+* src/WebLayerImpl.cpp:
+(WebKit::WebLayerImpl::~WebLayerImpl):
+
 2011-10-25  Adam Barth  aba...@webkit.org
 
 EventTarget.h shouldn't need to know about every feature and ifdef


Modified: trunk/Source/WebKit/chromium/WebKit.gypi (98392 => 98393)

--- trunk/Source/WebKit/chromium/WebKit.gypi	2011-10-25 20:59:15 UTC (rev 98392)
+++ trunk/Source/WebKit/chromium/WebKit.gypi	2011-10-25 21:10:12 UTC (rev 98393)
@@ -81,6 +81,7 @@
 'tests/TreeTestHelpers.h',
 'tests/WebCompositorImplTest.cpp',
 'tests/WebFrameTest.cpp',
+'tests/WebLayerTest.cpp',
 'tests/WebURLRequestTest.cpp',
 'tests/WebViewTest.cpp',
 ],


Modified: trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp (98392 => 98393)

--- trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp	2011-10-25 20:59:15 UTC (rev 98392)
+++ trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp	2011-10-25 21:10:12 UTC (rev 98393)
@@ -54,11 +54,13 @@
 
 WebContentLayerImpl::~WebContentLayerImpl()
 {
+setDelegate(0);
 }
 
 void WebContentLayerImpl::setDrawsContent(bool drawsContent)
 {
 m_drawsContent = drawsContent;
+setNeedsCommit();
 }
 
 bool WebContentLayerImpl::drawsContent() const


Modified: trunk/Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp (98392 => 98393)

--- trunk/Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp	2011-10-25 20:59:15 UTC (rev 98392)
+++ trunk/Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp	2011-10-25 21:10:12 UTC (rev 98393)
@@ -48,6 +48,7 @@
 
 WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl()
 {
+setDelegate(0);
 }
 
 bool WebExternalTextureLayerImpl::drawsContent() const


Modified: trunk/Source/WebKit/chromium/src/WebLayerImpl.cpp (98392 => 98393)

--- trunk/Source/WebKit/chromium/src/WebLayerImpl.cpp	2011-10-25 20:59:15 UTC (rev 98392)
+++ trunk/Source/WebKit/chromium/src/WebLayerImpl.cpp	2011-10-25 21:10:12 UTC (rev 98393)
@@ -43,6 +43,7 @@
 
 WebLayerImpl::~WebLayerImpl()
 {
+setDelegate(0);
 }
 
 bool WebLayerImpl::drawsContent() const


Modified: 

[webkit-changes] [98394] trunk/Source/WebKit2

[andersca]

Title: [98394] trunk/Source/WebKit2








Revision 98394
Author ander...@apple.com
Date 2011-10-25 14:11:00 -0700 (Tue, 25 Oct 2011)


Log Message
Assertion failure when zooming a PDF in an iframe
https://bugs.webkit.org/show_bug.cgi?id=70849

Reviewed by Alexey Proskuryakov.

If the plug-in doesn't want window relative coordinates, we shouldn't give the plug-in window relative coordinates.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98393 => 98394)

--- trunk/Source/WebKit2/ChangeLog	2011-10-25 21:10:12 UTC (rev 98393)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-25 21:11:00 UTC (rev 98394)
@@ -1,3 +1,15 @@
+2011-10-25  Anders Carlsson  ander...@apple.com
+
+Assertion failure when zooming a PDF in an iframe
+https://bugs.webkit.org/show_bug.cgi?id=70849
+
+Reviewed by Alexey Proskuryakov.
+
+If the plug-in doesn't want window relative coordinates, we shouldn't give the plug-in window relative coordinates.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::viewGeometryDidChange):
+
 2011-10-25  Sam Weinig  s...@webkit.org
 
 Make loadFileURL:restrictToFilesWithin: work, albeit, without the correct


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (98393 => 98394)

--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp	2011-10-25 21:10:12 UTC (rev 98393)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp	2011-10-25 21:11:00 UTC (rev 98394)
@@ -708,10 +708,17 @@
 if (!m_isInitialized || !m_plugin || !parent())
 return;
 
-// Get the frame rect in window coordinates.
-// FIXME: Figure out what we should pass here when m_plugin-wantsWindowRelativeCoordinates() returns false.
-IntRect frameRectInWindowCoordinates = parent()-contentsToWindow(frameRect());
-m_plugin-geometryDidChange(frameRectInWindowCoordinates, clipRectInWindowCoordinates());
+IntRect rect;
+
+if (m_plugin-wantsWindowRelativeCoordinates()) {
+// Get the frame rect in window coordinates.
+rect = parent()-contentsToWindow(frameRect());
+} else {
+// FIXME: The plug-in shouldn't know its location relative to its parent frame.
+rect = frameRect();
+}
+
+m_plugin-geometryDidChange(rect, clipRectInWindowCoordinates());
 }
 
 void PluginView::viewVisibilityDidChange()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98395] trunk/Tools

[ap]

Title: [98395] trunk/Tools








Revision 98395
Author a...@apple.com
Date 2011-10-25 14:16:39 -0700 (Tue, 25 Oct 2011)


Log Message
make-script-test-wrappers should not look outside fast/js
https://bugs.webkit.org/show_bug.cgi?id=66357

Reviewed by Maciej Stachowiak.

* Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
fast/js.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/make-script-test-wrappers




Diff

Modified: trunk/Tools/ChangeLog (98394 => 98395)

--- trunk/Tools/ChangeLog	2011-10-25 21:11:00 UTC (rev 98394)
+++ trunk/Tools/ChangeLog	2011-10-25 21:16:39 UTC (rev 98395)
@@ -1,3 +1,13 @@
+2011-10-25  Alexey Proskuryakov  a...@apple.com
+
+make-script-test-wrappers should not look outside fast/js
+https://bugs.webkit.org/show_bug.cgi?id=66357
+
+Reviewed by Maciej Stachowiak.
+
+* Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
+fast/js.
+
 2011-10-25  Adam Barth  aba...@webkit.org
 
 Add a --make option to update-webkit to engage the Makefile-based build system


Modified: trunk/Tools/Scripts/make-script-test-wrappers (98394 => 98395)

--- trunk/Tools/Scripts/make-script-test-wrappers	2011-10-25 21:11:00 UTC (rev 98394)
+++ trunk/Tools/Scripts/make-script-test-wrappers	2011-10-25 21:16:39 UTC (rev 98395)
@@ -48,7 +48,7 @@
 );
 
 if (!$result || $showHelp) {
-print STDERR basename($0) .  [-h|--help] [path ...]\n;
+print STDERR basename($0) .  [-h|--help]\n;
 exit 1;
 }
 
@@ -124,18 +124,13 @@
 }
 
 sub findTemplateFiles(@) {
-my @args = @_;
 my @templateFiles;
 
-push @args, LayoutTests if scalar(@args) == 0;
-
-my @paths = map { -f $_ ? dirname($_) : $_ } @args;
-
 my $fileFilter = sub {
 push @templateFiles, $File::Find::name if $_ eq TEMPLATE.html;
 };
 
-find({ preprocess = \directoryFilter, wanted = $fileFilter }, @paths);
+find({ preprocess = \directoryFilter, wanted = $fileFilter }, LayoutTests/fast/js);
 
 return @templateFiles;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98396] branches/subpixellayout/Source/WebCore/platform

[eae]

Title: [98396] branches/subpixellayout/Source/WebCore/platform








Revision 98396
Author e...@chromium.org
Date 2011-10-25 14:25:34 -0700 (Tue, 25 Oct 2011)


Log Message
Fix scrollbars for chromium/linux

Modified Paths

branches/subpixellayout/Source/WebCore/platform/ScrollbarThemeComposite.h
branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp
branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromium.h
branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp
branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromiumLinux.h




Diff

Modified: branches/subpixellayout/Source/WebCore/platform/ScrollbarThemeComposite.h (98395 => 98396)

--- branches/subpixellayout/Source/WebCore/platform/ScrollbarThemeComposite.h	2011-10-25 21:16:39 UTC (rev 98395)
+++ branches/subpixellayout/Source/WebCore/platform/ScrollbarThemeComposite.h	2011-10-25 21:25:34 UTC (rev 98396)
@@ -26,14 +26,14 @@
 #ifndef ScrollbarThemeComposite_h
 #define ScrollbarThemeComposite_h
 
-#include LayoutTypes.h
+#include FixedRect.h
 #include ScrollbarTheme.h
 
 namespace WebCore {
 
 class ScrollbarThemeComposite : public ScrollbarTheme {
 public:
-virtual bool paint(Scrollbar*, GraphicsContext* context, const LayoutRect damageRect);
+virtual bool paint(Scrollbar*, GraphicsContext* context, const FixedRect damageRect);
 
 virtual ScrollbarPart hitTest(Scrollbar*, const PlatformMouseEvent);
 
@@ -44,29 +44,29 @@
 virtual int trackPosition(Scrollbar*);
 virtual int trackLength(Scrollbar*);
 
-virtual void paintScrollCorner(ScrollView*, GraphicsContext*, const LayoutRect cornerRect);
-virtual void paintOverhangAreas(ScrollView*, GraphicsContext*, const LayoutRect horizontalOverhangArea, const LayoutRect verticalOverhangArea, const LayoutRect dirtyRect);
+virtual void paintScrollCorner(ScrollView*, GraphicsContext*, const FixedRect cornerRect);
+virtual void paintOverhangAreas(ScrollView*, GraphicsContext*, const FixedRect horizontalOverhangArea, const FixedRect verticalOverhangArea, const FixedRect dirtyRect);
 
 protected:
 virtual bool hasButtons(Scrollbar*) = 0;
 virtual bool hasThumb(Scrollbar*) = 0;
 
-virtual LayoutRect backButtonRect(Scrollbar*, ScrollbarPart, bool painting = false) = 0;
-virtual LayoutRect forwardButtonRect(Scrollbar*, ScrollbarPart, bool painting = false) = 0;
-virtual LayoutRect trackRect(Scrollbar*, bool painting = false) = 0;
+virtual FixedRect backButtonRect(Scrollbar*, ScrollbarPart, bool painting = false) = 0;
+virtual FixedRect forwardButtonRect(Scrollbar*, ScrollbarPart, bool painting = false) = 0;
+virtual FixedRect trackRect(Scrollbar*, bool painting = false) = 0;
 
-virtual void splitTrack(Scrollbar*, const LayoutRect track, LayoutRect startTrack, LayoutRect thumb, LayoutRect endTrack);
+virtual void splitTrack(Scrollbar*, const FixedRect track, FixedRect startTrack, FixedRect thumb, FixedRect endTrack);
 
 virtual LayoutUnit minimumThumbLength(Scrollbar*);
 
 virtual void paintScrollbarBackground(GraphicsContext*, Scrollbar*) {}
-virtual void paintTrackBackground(GraphicsContext*, Scrollbar*, const LayoutRect) {}
-virtual void paintTrackPiece(GraphicsContext*, Scrollbar*, const LayoutRect, ScrollbarPart) {}
-virtual void paintButton(GraphicsContext*, Scrollbar*, const LayoutRect, ScrollbarPart) {}
-virtual void paintThumb(GraphicsContext*, Scrollbar*, const LayoutRect) {}
-virtual void paintTickmarks(GraphicsContext*, Scrollbar*, const LayoutRect) {}
+virtual void paintTrackBackground(GraphicsContext*, Scrollbar*, const FixedRect) {}
+virtual void paintTrackPiece(GraphicsContext*, Scrollbar*, const FixedRect, ScrollbarPart) {}
+virtual void paintButton(GraphicsContext*, Scrollbar*, const FixedRect, ScrollbarPart) {}
+virtual void paintThumb(GraphicsContext*, Scrollbar*, const FixedRect) {}
+virtual void paintTickmarks(GraphicsContext*, Scrollbar*, const FixedRect) {}
 
-virtual LayoutRect constrainTrackRectToTrackPieces(Scrollbar*, const LayoutRect rect) { return rect; }
+virtual FixedRect constrainTrackRectToTrackPieces(Scrollbar*, const FixedRect rect) { return rect; }
 };
 
 }


Modified: branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp (98395 => 98396)

--- branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp	2011-10-25 21:16:39 UTC (rev 98395)
+++ branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp	2011-10-25 21:25:34 UTC (rev 98396)
@@ -92,14 +92,14 @@
 return FixedRect(scrollbar-x(), scrollbar-y() + bs.height(), thickness, scrollbar-height() - 2 * bs.height());
 }
 
-void ScrollbarThemeChromium::paintTrackBackground(GraphicsContext* context, Scrollbar* scrollbar, const IntRect rect)
+void ScrollbarThemeChromium::paintTrackBackground(GraphicsContext* context, 

[webkit-changes] [98397] trunk/LayoutTests

[jchaffraix]

Title: [98397] trunk/LayoutTests








Revision 98397
Author jchaffr...@webkit.org
Date 2011-10-25 14:44:05 -0700 (Tue, 25 Oct 2011)


Log Message
More unreviewed gardening.

* platform/chromium/test_expectations.txt: Mark another test
as crashing. Moved 2 tests together as they hit the same ASSERT
on the bots.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (98396 => 98397)

--- trunk/LayoutTests/ChangeLog	2011-10-25 21:25:34 UTC (rev 98396)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 21:44:05 UTC (rev 98397)
@@ -1,3 +1,11 @@
+2011-10-25  Julien Chaffraix  jchaffr...@webkit.org
+
+More unreviewed gardening.
+
+* platform/chromium/test_expectations.txt: Mark another test
+as crashing. Moved 2 tests together as they hit the same ASSERT
+on the bots.
+
 2011-10-25  Leandro Pereira  lean...@profusion.mobi
 
 [EFL] Unreviewed. Add CSS1 pixel baselines.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98396 => 98397)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-25 21:25:34 UTC (rev 98396)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-25 21:44:05 UTC (rev 98397)
@@ -3805,8 +3805,11 @@
 BUGWK70640 SNOWLEOPARD : fast/multicol/vertical-rl/rules-with-border-before.html = PASS TEXT
 
 BUGWK70641 SNOWLEOPARD : fast/frames/sandboxed-iframe-scripting.html = PASS CRASH
-BUGWK67031 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH
 
 BUGWK70749 SNOWLEOPARD CPU GPU : fast/ruby/base-shorter-than-text.html = IMAGE+TEXT PASS
 
 BUGWK70837 GPU : compositing/video/video-poster.html = PASS TIMEOUT
+
+// Intermittent ASSERT seen on the bot.
+BUGWK67031 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH
+BUGWK67031 SNOWLEOPARD DEBUG : fast/dom/Element/id-in-frame.html = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98398] trunk/Source/JavaScriptCore

[fpizlo]

Title: [98398] trunk/Source/_javascript_Core








Revision 98398
Author fpi...@apple.com
Date 2011-10-25 14:56:31 -0700 (Tue, 25 Oct 2011)


Log Message
Tiered compilation may introduce dangling pointers in constant buffers
https://bugs.webkit.org/show_bug.cgi?id=70854

Reviewed by Oliver Hunt.

Tiered compilation now copies constant buffers, which fixes the regression in
https://bugs.webkit.org/show_bug.cgi?id=70246. No new tests because this
regression relies on a subtle interleaving of optimized compilation and garbage
collection, and cannot be reproduced in a simple test.

This also adds some new debug support, which was used to fix this bug and is
likely to be useful in the future.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::usesOpcode):
* bytecode/CodeBlock.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (98397 => 98398)

--- trunk/Source/_javascript_Core/ChangeLog	2011-10-25 21:44:05 UTC (rev 98397)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-10-25 21:56:31 UTC (rev 98398)
@@ -1,3 +1,25 @@
+2011-10-25  Filip Pizlo  fpi...@apple.com
+
+Tiered compilation may introduce dangling pointers in constant buffers
+https://bugs.webkit.org/show_bug.cgi?id=70854
+
+Reviewed by Oliver Hunt.
+
+Tiered compilation now copies constant buffers, which fixes the regression in
+https://bugs.webkit.org/show_bug.cgi?id=70246. No new tests because this
+regression relies on a subtle interleaving of optimized compilation and garbage
+collection, and cannot be reproduced in a simple test.
+
+This also adds some new debug support, which was used to fix this bug and is
+likely to be useful in the future.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::copyDataFrom):
+(JSC::CodeBlock::usesOpcode):
+* bytecode/CodeBlock.h:
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::dump):
+
 2011-10-25  Mark Hahnenberg  mhahnenb...@apple.com
 
 Fixing Windows build after r98367


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (98397 => 98398)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-10-25 21:44:05 UTC (rev 98397)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-10-25 21:56:31 UTC (rev 98398)
@@ -1828,6 +1828,8 @@
 replaceExistingEntries(m_constantRegisters, alternative-m_constantRegisters);
 replaceExistingEntries(m_functionDecls, alternative-m_functionDecls);
 replaceExistingEntries(m_functionExprs, alternative-m_functionExprs);
+if (!!m_rareData  !!alternative-m_rareData)
+replaceExistingEntries(m_rareData-m_constantBuffers, alternative-m_rareData-m_constantBuffers);
 }
 
 void CodeBlock::copyDataFromAlternative()
@@ -2002,4 +2004,31 @@
 }
 #endif
 
+#ifndef NDEBUG
+bool CodeBlock::usesOpcode(OpcodeID opcodeID)
+{
+Interpreter* interpreter = globalData()-interpreter;
+Instruction* instructionsBegin = instructions().begin();
+unsigned instructionCount = instructions().size();
+
+for (unsigned bytecodeOffset = 0; bytecodeOffset  instructionCount; ) {
+switch (interpreter-getOpcodeID(instructionsBegin[bytecodeOffset].u.opcode)) {
+#define DEFINE_OP(curOpcode, length)\
+case curOpcode: \
+if (curOpcode == opcodeID)  \
+return true;\
+bytecodeOffset += length;   \
+break;
+FOR_EACH_OPCODE_ID(DEFINE_OP)
+#undef DEFINE_OP
+default:
+ASSERT_NOT_REACHED();
+break;
+}
+}
+
+return false;
+}
+#endif
+
 } // namespace JSC


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (98397 => 98398)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2011-10-25 21:44:05 UTC (rev 98397)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2011-10-25 21:56:31 UTC (rev 98398)
@@ -390,6 +390,10 @@
 VectorInstruction instructions() { return m_instructions; }
 void discardBytecode() { m_instructions.clear(); }
 
+#ifndef NDEBUG
+bool usesOpcode(OpcodeID);
+#endif
+
 unsigned instructionCount() { return m_instructionCount; }
 void setInstructionCount(unsigned instructionCount) { m_instructionCount = instructionCount; }
 


Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (98397 => 98398)

--- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp	2011-10-25 21:44:05 UTC (rev 98397)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp	2011-10-25 21:56:31 UTC (rev 98398)
@@ -222,6 +222,18 @@
 printf(%sr%u(%s), hasPrinted ? ,  : , operand, 

[webkit-changes] [98399] trunk

[weinig]

Title: [98399] trunk








Revision 98399
Author wei...@apple.com
Date 2011-10-25 15:35:52 -0700 (Tue, 25 Oct 2011)


Log Message
Flesh out WKBrowsingContextLoadDelegate a bit
https://bugs.webkit.org/show_bug.cgi?id=70846

Source/WebKit2: 

Add didReceiveServerRedirectForProvisionalLoad, didFailProvisionalLoad
and didFailLoad.

Reviewed by Anders Carlsson.

Test: WKBrowsingContextLoadDelegateTest

* UIProcess/API/mac/WKBrowsingContextController.mm:
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(setUpPageLoaderClient):
* UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:

Tools: 

Reviewed by Anders Carlsson.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2ObjC: Added.
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
(WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
(WKBrowsingContextLoadDelegateTest::SetUp):
(WKBrowsingContextLoadDelegateTest::TearDown):
(-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
(TEST_F):
Add basic testing for WKBrowsingContextLoadDelegate.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/
trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98398 => 98399)

--- trunk/Source/WebKit2/ChangeLog	2011-10-25 21:56:31 UTC (rev 98398)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-25 22:35:52 UTC (rev 98399)
@@ -1,3 +1,22 @@
+2011-10-25  Sam Weinig  s...@webkit.org
+
+Flesh out WKBrowsingContextLoadDelegate a bit
+https://bugs.webkit.org/show_bug.cgi?id=70846
+
+Add didReceiveServerRedirectForProvisionalLoad, didFailProvisionalLoad
+and didFailLoad.
+
+Reviewed by Anders Carlsson.
+
+Test: WKBrowsingContextLoadDelegateTest
+
+* UIProcess/API/mac/WKBrowsingContextController.mm:
+(didReceiveServerRedirectForProvisionalLoadForFrame):
+(didFailProvisionalLoadWithErrorForFrame):
+(didFailLoadWithErrorForFrame):
+(setUpPageLoaderClient):
+* UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:
+
 2011-10-25  Anders Carlsson  ander...@apple.com
 
 Assertion failure when zooming a PDF in an iframe


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm (98398 => 98399)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm	2011-10-25 21:56:31 UTC (rev 98398)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm	2011-10-25 22:35:52 UTC (rev 98399)
@@ -27,6 +27,7 @@
 #import WKBrowsingContextController.h
 #import WKBrowsingContextControllerInternal.h
 
+#import WKErrorCF.h
 #import WKFrame.h
 #import WKPage.h
 #import WKRetainPtr.h
@@ -34,6 +35,7 @@
 #import WKURLCF.h
 #import WKURLRequest.h
 #import WKURLRequestNS.h
+#import wtf/RetainPtr.h
 
 #import WKBrowsingContextLoadDelegate.h
 
@@ -203,16 +205,40 @@
 return;
 
 WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
-[browsingContext.loadDelegate browsingContextControllerDidStartProvisionalLoad:browsingContext];
+if ([browsingContext.loadDelegate respondsToSelector:@selector(browsingContextControllerDidStartProvisionalLoad:)])
+[browsingContext.loadDelegate browsingContextControllerDidStartProvisionalLoad:browsingContext];
 }
 
+static void didReceiveServerRedirectForProvisionalLoadForFrame(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void* clientInfo)
+{
+if (!WKFrameIsMainFrame(frame))
+return;
+
+WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
+if ([browsingContext.loadDelegate respondsToSelector:@selector(browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:)])
+[browsingContext.loadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:browsingContext];
+}
+
+static void didFailProvisionalLoadWithErrorForFrame(WKPageRef page, WKFrameRef frame, WKErrorRef error, WKTypeRef userData, const void* clientInfo)
+{
+if (!WKFrameIsMainFrame(frame))
+return;
+
+WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
+if ([browsingContext.loadDelegate respondsToSelector:@selector(browsingContextControllerDidFailProvisionalLoad:withError:)]) {
+RetainPtrCFErrorRef cfError(AdoptCF, WKErrorCopyCFError(kCFAllocatorDefault, error));
+[browsingContext.loadDelegate browsingContextControllerDidFailProvisionalLoad:browsingContext 

[webkit-changes] [98400] trunk/Source/WebCore

[mitz]

Title: [98400] trunk/Source/WebCore








Revision 98400
Author m...@apple.com
Date 2011-10-25 15:45:48 -0700 (Tue, 25 Oct 2011)


Log Message
Caret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks
https://bugs.webkit.org/show_bug.cgi?id=70851

Reviewed by Dave Hyatt.

* manual-tests/caret-in-columns-flipped.html: Added.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForColumns): Removed flipped-blocks writing mode considerations
from this function, since not all callers were expecting it to account for flippedness. This makes
it similar to adjustRectForColumns() in not adjusting for flippedness.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer): In the columns case, account for flipped-blocks modes
by first mapping the point and the offset to non-flipped, non-columns space, then adjusting for
columns, then flipping.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/Source/WebCore/manual-tests/caret-in-columns-flipped.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (98399 => 98400)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 22:35:52 UTC (rev 98399)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 22:45:48 UTC (rev 98400)
@@ -1,3 +1,20 @@
+2011-10-25  Dan Bernstein  m...@apple.com
+
+Caret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks
+https://bugs.webkit.org/show_bug.cgi?id=70851
+
+Reviewed by Dave Hyatt.
+
+* manual-tests/caret-in-columns-flipped.html: Added.
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::adjustForColumns): Removed flipped-blocks writing mode considerations
+from this function, since not all callers were expecting it to account for flippedness. This makes
+it similar to adjustRectForColumns() in not adjusting for flippedness.
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::offsetFromContainer): In the columns case, account for flipped-blocks modes
+by first mapping the point and the offset to non-flipped, non-columns space, then adjusting for
+columns, then flipping.
+
 2011-10-25  Michal Mocny  mmo...@google.com
 
 LayerRendererChromium::setVisible called needlessly without a visibility change


Added: trunk/Source/WebCore/manual-tests/caret-in-columns-flipped.html (0 => 98400)

--- trunk/Source/WebCore/manual-tests/caret-in-columns-flipped.html	(rev 0)
+++ trunk/Source/WebCore/manual-tests/caret-in-columns-flipped.html	2011-10-25 22:45:48 UTC (rev 98400)
@@ -0,0 +1,25 @@
+p
+(Read from bottom to top)
+/p
+div id=target style=
+margin: 100px;
+-webkit-columns: 3;
+width: 300px;
+height: 100px;
+-webkit-user-modify: read-write;
+-webkit-writing-mode: horizontal-bt;
+outline: none;
+
+br
+br
+br
+br
+br
+br
+The blinking insertion point should be here rarr;
+/div
+script
+var target = document.getElementById(target);
+target.focus();
+getSelection().modify(move, forward, documentboundary);
+/script


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (98399 => 98400)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2011-10-25 22:35:52 UTC (rev 98399)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2011-10-25 22:45:48 UTC (rev 98400)
@@ -4757,10 +4757,7 @@
 if (!isHorizontalWritingMode())
 sliceRect = sliceRect.transposedRect();
 
-// If we have a flipped blocks writing mode, then convert the column so that it's coming from the after edge (either top or left edge).
-adjustStartEdgeForWritingModeIncludingColumns(sliceRect);
-
-LayoutUnit logicalOffset = style()-isFlippedBlocksWritingMode() ? (colCount - 1 - i) * colLogicalHeight : i * colLogicalHeight;
+LayoutUnit logicalOffset = i * colLogicalHeight;
 
 // Now we're in the same coordinate space as the point.  See if it is inside the rectangle.
 if (isHorizontalWritingMode()) {


Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (98399 => 98400)

--- trunk/Source/WebCore/rendering/RenderBox.cpp	2011-10-25 22:35:52 UTC (rev 98399)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp	2011-10-25 22:45:48 UTC (rev 98400)
@@ -1422,15 +1422,15 @@
 offset += relativePositionOffset();
 
 if (!isInline() || isReplaced()) {
-if (style()-position() != AbsolutePosition  style()-position() != FixedPosition) {
-if (o-hasColumns()) {
-LayoutRect columnRect(frameRect());
-toRenderBlock(o)-adjustStartEdgeForWritingModeIncludingColumns(columnRect);
-offset += LayoutSize(columnRect.location().x(), columnRect.location().y());
-columnRect.moveBy(point);
-o-adjustForColumns(offset, columnRect.location());
-} else
-   

[webkit-changes] [98401] branches/subpixellayout/Source

[leviw]

Title: [98401] branches/subpixellayout/Source








Revision 98401
Author le...@chromium.org
Date 2011-10-25 15:51:34 -0700 (Tue, 25 Oct 2011)


Log Message
Mac build fixes and adding pixelSnapped convenience methods for accessors that needed them.

Modified Paths

branches/subpixellayout/Source/WebCore/rendering/InlineFlowBox.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h
branches/subpixellayout/Source/WebCore/rendering/RenderBlockLineLayout.cpp
branches/subpixellayout/Source/WebKit/mac/WebView/WebView.mm
branches/subpixellayout/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
branches/subpixellayout/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
branches/subpixellayout/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/rendering/InlineFlowBox.cpp (98400 => 98401)

--- branches/subpixellayout/Source/WebCore/rendering/InlineFlowBox.cpp	2011-10-25 22:45:48 UTC (rev 98400)
+++ branches/subpixellayout/Source/WebCore/rendering/InlineFlowBox.cpp	2011-10-25 22:51:34 UTC (rev 98401)
@@ -576,12 +576,12 @@
 void InlineFlowBox::placeBoxesInBlockDirection(LayoutUnit top, LayoutUnit maxHeight, LayoutUnit maxAscent, bool strictMode, LayoutUnit lineTop, LayoutUnit lineBottom, bool setLineTop,
LayoutUnit lineTopIncludingMargins, LayoutUnit lineBottomIncludingMargins, bool hasAnnotationsBefore, bool hasAnnotationsAfter, FontBaseline baselineType)
 {
-// We need to use an integer top for positioning inline boxes because we can't round in painting in the inline box tree
-int roundedTop = top.round();
+// We need to snap the top to pixel bounds for positioning inline boxes because we can't round in painting in the inline box tree
+LayoutUnit pixelSnappedTop = top.round();
 bool isRootBox = isRootInlineBox();
 if (isRootBox) {
 const FontMetrics fontMetrics = renderer()-style(m_firstLine)-fontMetrics();
-setLogicalTop(roundedTop + maxAscent - fontMetrics.ascent(baselineType));
+setLogicalTop(pixelSnappedTop + maxAscent - fontMetrics.ascent(baselineType));
 }
 
 LayoutUnit adjustmentForChildrenWithSameLineHeightAndBaseline = 0;
@@ -603,15 +603,15 @@
 InlineFlowBox* inlineFlowBox = curr-isInlineFlowBox() ? toInlineFlowBox(curr) : 0;
 bool childAffectsTopBottomPos = true;
 if (curr-verticalAlign() == TOP)
-curr-setLogicalTop(roundedTop);
+curr-setLogicalTop(pixelSnappedTop);
 else if (curr-verticalAlign() == BOTTOM)
-curr-setLogicalTop(roundedTop + maxHeight - curr-lineHeight());
+curr-setLogicalTop(pixelSnappedTop + maxHeight - curr-lineHeight());
 else {
 if (!strictMode  inlineFlowBox  !inlineFlowBox-hasTextChildren()  !curr-boxModelObject()-hasInlineDirectionBordersOrPadding()
  !(inlineFlowBox-descendantsHaveSameLineHeightAndBaseline()  inlineFlowBox-hasTextDescendants()))
 childAffectsTopBottomPos = false;
 LayoutUnit posAdjust = maxAscent - curr-baselinePosition(baselineType);
-curr-setLogicalTop(curr-logicalTop() + roundedTop + posAdjust);
+curr-setLogicalTop(curr-logicalTop() + pixelSnappedTop + posAdjust);
 }
 
 LayoutUnit newLogicalTop = curr-logicalTop();
@@ -683,7 +683,7 @@
 // Adjust boxes to use their real box y/height and not the logical height (as dictated by
 // line-height).
 if (inlineFlowBox)
-inlineFlowBox-placeBoxesInBlockDirection(roundedTop, maxHeight, maxAscent, strictMode, lineTop, lineBottom, setLineTop,
+inlineFlowBox-placeBoxesInBlockDirection(pixelSnappedTop, maxHeight, maxAscent, strictMode, lineTop, lineBottom, setLineTop,
   lineTopIncludingMargins, lineBottomIncludingMargins, hasAnnotationsBefore, hasAnnotationsAfter, baselineType);
 }
 


Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp (98400 => 98401)

--- branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp	2011-10-25 22:45:48 UTC (rev 98400)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp	2011-10-25 22:51:34 UTC (rev 98401)
@@ -3570,18 +3570,18 @@
 const FloatingObject* r = interval.data();
 if (r-type() == FloatTypeValue  interval.low() = m_value  m_value  interval.high()) {
 // All the objects returned from the tree should be already placed.
-ASSERT(r-isPlaced()  m_renderer-logicalTopForFloat(r).round() = m_value  m_renderer-logicalBottomForFloat(r).round()  m_value);
+ASSERT(r-isPlaced()  m_renderer-pixelSnappedLogicalTopForFloat(r) = m_value  m_renderer-pixelSnappedLogicalBottomForFloat(r)  m_value);
 
 if (FloatTypeValue == FloatingObject::FloatLeft 
- 

[webkit-changes] [98402] trunk/Source/WebCore

[adamk]

Title: [98402] trunk/Source/WebCore








Revision 98402
Author ad...@chromium.org
Date 2011-10-25 15:55:50 -0700 (Tue, 25 Oct 2011)


Log Message
Forward declare MutationObserverEntry as a struct to fix clang build
https://bugs.webkit.org/show_bug.cgi?id=70853

Reviewed by Ryosuke Niwa.

Node.h forward declared MutationObserverEntry as a class, and clang
complains if the two declarations don't match.

* dom/Node.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (98401 => 98402)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 22:51:34 UTC (rev 98401)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 22:55:50 UTC (rev 98402)
@@ -1,3 +1,15 @@
+2011-10-25  Adam Klein  ad...@chromium.org
+
+Forward declare MutationObserverEntry as a struct to fix clang build
+https://bugs.webkit.org/show_bug.cgi?id=70853
+
+Reviewed by Ryosuke Niwa.
+
+Node.h forward declared MutationObserverEntry as a class, and clang
+complains if the two declarations don't match.
+
+* dom/Node.h:
+
 2011-10-25  Dan Bernstein  m...@apple.com
 
 Caret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks


Modified: trunk/Source/WebCore/dom/Node.h (98401 => 98402)

--- trunk/Source/WebCore/dom/Node.h	2011-10-25 22:51:34 UTC (rev 98401)
+++ trunk/Source/WebCore/dom/Node.h	2011-10-25 22:55:50 UTC (rev 98402)
@@ -59,7 +59,6 @@
 class HTMLInputElement;
 class IntRect;
 class KeyboardEvent;
-class MutationObserverEntry;
 class NSResolver;
 class NamedNodeMap;
 class NameNodeList;
@@ -82,6 +81,8 @@
 class TagNodeList;
 class TreeScope;
 
+struct MutationObserverEntry;
+
 typedef int ExceptionCode;
 
 const int nodeStyleChangeShift = 25;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98403] trunk

[andersca]

Title: [98403] trunk








Revision 98403
Author ander...@apple.com
Date 2011-10-25 16:00:37 -0700 (Tue, 25 Oct 2011)


Log Message
Source/WebCore: Plug-ins have to use _javascript_ to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225

Reviewed by Darin Adler.

Test: platform/mac-wk2/plugins/contents-scale-factor.html

Add NPNVcontentsScaleFactor, as per https://wiki.mozilla.org/NPAPI:ContentsScaleFactor.

* plugins/npapi.h:

Source/WebKit2: Plug-ins have to use _javascript_ to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
rdar://problem/10048258

Reviewed by Darin Adler.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_contentsScaleFactor.

* PluginProcess/PluginControllerProxy.h:
Add contentsScaleFactor member function and m_contentsScaleFactor member variable.

* PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):
* PluginProcess/PluginCreationParameters.h:
Add contentsScaleFactor to the creation parameters.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::contentsScaleFactor):
Return the cached m_contentsScaleFactor.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Handle getting the scale factor by calling NetscapePlugin::contentsScaleFactor.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::contentsScaleFactor):
Ask the plug-in controller for the contents scale factor.

* WebProcess/Plugins/PluginController.h:
Add contentsScaleFactor pure virtual member function.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
Set contentsScaleFactor in the creation parameters.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::contentsScaleFactor):
Get the device scale factor from the page.

* WebProcess/Plugins/PluginView.h:
Add contentsScaleFactor().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):
Bail if the scale factor didn't change.

Tools: Plug-ins have to use _javascript_ to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
rdar://problem/10048258

Reviewed by Darin Adler.

Add a plug-in test for getting the contents scale factor.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::contentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::ScriptableObject::pluginTest):
(ContentsScaleFactor::NPP_GetValue):

LayoutTests: Plug-ins have to use _javascript_ to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
rdar://problem/10048258

Reviewed by Darin Adler.

Add tests.

* platform/mac-wk2/plugins/contents-scale-factor-expected.txt: Added.
* platform/mac-wk2/plugins/contents-scale-factor.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/npapi.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h
trunk/Source/WebKit2/PluginProcess/PluginCreationParameters.cpp
trunk/Source/WebKit2/PluginProcess/PluginCreationParameters.h
trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/PluginController.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj


Added Paths

trunk/LayoutTests/platform/mac-wk2/plugins/contents-scale-factor-expected.txt
trunk/LayoutTests/platform/mac-wk2/plugins/contents-scale-factor.html
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (98402 => 98403)

--- trunk/LayoutTests/ChangeLog	2011-10-25 22:55:50 UTC (rev 98402)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 23:00:37 UTC (rev 98403)
@@ -1,3 +1,16 @@
+2011-10-25  Anders Carlsson  ander...@apple.com
+
+Plug-ins have to use _javascript_ to find out the current device scale factor
+https://bugs.webkit.org/show_bug.cgi?id=67225
+rdar://problem/10048258
+
+Reviewed by 

[webkit-changes] [98404] trunk/LayoutTests

[jchaffraix]

Title: [98404] trunk/LayoutTests








Revision 98404
Author jchaffr...@webkit.org
Date 2011-10-25 16:02:53 -0700 (Tue, 25 Oct 2011)


Log Message
More gardening.

* platform/chromium/test_expectations.txt: Missed some cases where
video-porter.html times out. Also added zoom-animator-scale-test2.html
that has been timing out for several days.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (98403 => 98404)

--- trunk/LayoutTests/ChangeLog	2011-10-25 23:00:37 UTC (rev 98403)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 23:02:53 UTC (rev 98404)
@@ -1,3 +1,11 @@
+2011-10-25  Julien Chaffraix  jchaffr...@webkit.org
+
+More gardening.
+
+* platform/chromium/test_expectations.txt: Missed some cases where
+video-porter.html times out. Also added zoom-animator-scale-test2.html
+that has been timing out for several days.
+
 2011-10-25  Anders Carlsson  ander...@apple.com
 
 Plug-ins have to use _javascript_ to find out the current device scale factor


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98403 => 98404)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-25 23:00:37 UTC (rev 98403)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-25 23:02:53 UTC (rev 98404)
@@ -2642,7 +2642,7 @@
 
 // Take new baselines from the bots when 68035 lands.
 BUGWK69624 SLOW WIN GPU : platform/chromium/compositing/zoom-animator-scale-test2.html = IMAGE+TEXT
-BUGWK70046 LEOPARD : platform/chromium/compositing/zoom-animator-scale-test2.html = MISSING
+BUGWK70046 LEOPARD : platform/chromium/compositing/zoom-animator-scale-test2.html = MISSING TIMEOUT
 BUGWK70046 SNOWLEOPARD : platform/chromium/compositing/zoom-animator-scale-test2.html = PASS TIMEOUT
 
 BUGCR72223 : media/video-frame-accurate-seek.html = PASS IMAGE
@@ -3809,6 +3809,7 @@
 BUGWK70749 SNOWLEOPARD CPU GPU : fast/ruby/base-shorter-than-text.html = IMAGE+TEXT PASS
 
 BUGWK70837 GPU : compositing/video/video-poster.html = PASS TIMEOUT
+BUGWK70837 SNOWLEOPARD CPU : compositing/video/video-poster.html = PASS TIMEOUT
 
 // Intermittent ASSERT seen on the bot.
 BUGWK67031 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98405] trunk/Source/JavaScriptCore

[barraclough]

Title: [98405] trunk/Source/_javascript_Core








Revision 98405
Author barraclo...@apple.com
Date 2011-10-25 16:06:13 -0700 (Tue, 25 Oct 2011)


Log Message
Separate out function linking  exception check data structures.
https://bugs.webkit.org/show_bug.cgi?id=70858

Reviewed by Oliver Hunt.

This will make it easier to refactor the callOperation methods to spilt the value
representation specific handling from the cpu/calling-convention implementation.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::appendCallWithExceptionCheck):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::CallLinkRecord::CallLinkRecord):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h
trunk/Source/_javascript_Core/dfg/DFGJITCompiler32_64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (98404 => 98405)

--- trunk/Source/_javascript_Core/ChangeLog	2011-10-25 23:02:53 UTC (rev 98404)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-10-25 23:06:13 UTC (rev 98405)
@@ -1,3 +1,34 @@
+2011-10-25  Gavin Barraclough  barraclo...@apple.com
+
+Separate out function linking  exception check data structures.
+https://bugs.webkit.org/show_bug.cgi?id=70858
+
+Reviewed by Oliver Hunt.
+
+This will make it easier to refactor the callOperation methods to spilt the value
+representation specific handling from the cpu/calling-convention implementation.
+
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::appendCallWithExceptionCheck):
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::emitCall):
+* dfg/DFGJITCodeGenerator64.cpp:
+(JSC::DFG::JITCodeGenerator::emitCall):
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::compileBody):
+(JSC::DFG::JITCompiler::link):
+* dfg/DFGJITCompiler.h:
+(JSC::DFG::CallLinkRecord::CallLinkRecord):
+(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
+(JSC::DFG::JITCompiler::JITCompiler):
+(JSC::DFG::JITCompiler::notifyCall):
+(JSC::DFG::JITCompiler::appendCall):
+(JSC::DFG::JITCompiler::addExceptionCheck):
+(JSC::DFG::JITCompiler::addFastExceptionCheck):
+* dfg/DFGJITCompiler32_64.cpp:
+(JSC::DFG::JITCompiler::compileBody):
+(JSC::DFG::JITCompiler::link):
+
 2011-10-25  Filip Pizlo  fpi...@apple.com
 
 Tiered compilation may introduce dangling pointers in constant buffers


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (98404 => 98405)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h	2011-10-25 23:02:53 UTC (rev 98404)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h	2011-10-25 23:06:13 UTC (rev 98405)
@@ -1550,7 +1550,7 @@
 
 JITCompiler::Call appendCallWithExceptionCheck(const FunctionPtr function)
 {
-return m_jit.appendCallWithExceptionCheck(function, at(m_compileIndex).codeOrigin);
+return m_jit.addExceptionCheck(m_jit.appendCall(function), at(m_compileIndex).codeOrigin);
 }
 JITCompiler::Call appendCallWithExceptionCheckSetResult(const FunctionPtr function, GPRReg result)
 {


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp (98404 => 98405)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp	2011-10-25 23:02:53 UTC (rev 98404)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp	2011-10-25 23:06:13 UTC (rev 98405)
@@ -1365,7 +1365,7 @@
 
 m_jit.addPtr(Imm32(m_jit.codeBlock()-m_numCalleeRegisters * sizeof(Register)), GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
 m_jit.poke(GPRInfo::argumentGPR0);
-JITCompiler::Call slowCall = m_jit.appendCallWithFastExceptionCheck(slowCallFunction, at(m_compileIndex).codeOrigin);
+JITCompiler::Call slowCall = m_jit.addFastExceptionCheck(m_jit.appendCall(slowCallFunction), at(m_compileIndex).codeOrigin);
 m_jit.move(Imm32(numPassedArgs), GPRInfo::regT1);
 m_jit.addPtr(Imm32(m_jit.codeBlock()-m_numCalleeRegisters * sizeof(Register)), GPRInfo::callFrameRegister);
 m_jit.notifyCall(m_jit.call(GPRInfo::returnValueGPR), 

[webkit-changes] [98406] trunk/Source

[bdakin]

Title: [98406] trunk/Source








Revision 98406
Author bda...@apple.com
Date 2011-10-25 16:10:12 -0700 (Tue, 25 Oct 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=70852
Setting up a HiDPI base-level GraphicsContext should be more straightforward for 
WebKit2

Reviewed by Dan Bernstein.

Source/WebCore: 

This patch removes the old cg-only GraphicsContext::setBaseCTM() api, and adds 
platform-independent GraphicsContext::applyDeviceScaleFactor().
* WebCore.exp.in:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):

Since this patch removes GraphicsContext::setBaseCTM(), this code has been 
reverted to do what it used to do before that was added; it just calls into 
WebCoreSystemInterface directly.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):

Source/WebKit2: 

When we need a base-level HiDPI GraphicsContext, call into new GraphicsContext api 
GraphicsContext::applyDeviceScaleFactor() rather than manually scaling and 
adjusting the base CTM.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageCG.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (98405 => 98406)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 23:06:13 UTC (rev 98405)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 23:10:12 UTC (rev 98406)
@@ -1,3 +1,27 @@
+2011-10-25  Beth Dakin  bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=70852
+Setting up a HiDPI base-level GraphicsContext should be more straightforward for 
+WebKit2
+
+Reviewed by Dan Bernstein.
+
+This patch removes the old cg-only GraphicsContext::setBaseCTM() api, and adds 
+platform-independent GraphicsContext::applyDeviceScaleFactor().
+* WebCore.exp.in:
+* platform/graphics/GraphicsContext.cpp:
+(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
+(WebCore::GraphicsContext::applyDeviceScaleFactor):
+* platform/graphics/GraphicsContext.h:
+* platform/graphics/cg/GraphicsContextCG.cpp:
+(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
+
+Since this patch removes GraphicsContext::setBaseCTM(), this code has been 
+reverted to do what it used to do before that was added; it just calls into 
+WebCoreSystemInterface directly.
+* platform/graphics/cg/ImageCG.cpp:
+(WebCore::Image::drawPattern):
+
 2011-10-25  Anders Carlsson  ander...@apple.com
 
 Plug-ins have to use _javascript_ to find out the current device scale factor


Modified: trunk/Source/WebCore/WebCore.exp.in (98405 => 98406)

--- trunk/Source/WebCore/WebCore.exp.in	2011-10-25 23:06:13 UTC (rev 98405)
+++ trunk/Source/WebCore/WebCore.exp.in	2011-10-25 23:10:12 UTC (rev 98406)
@@ -428,6 +428,7 @@
 __ZN7WebCore15GraphicsContext20setShouldSmoothFontsEb
 __ZN7WebCore15GraphicsContext20endTransparencyLayerEv
 __ZN7WebCore15GraphicsContext21setCompositeOperationENS_17CompositeOperatorE
+__ZN7WebCore15GraphicsContext22applyDeviceScaleFactorEf
 __ZN7WebCore15GraphicsContext22beginTransparencyLayerEf
 __ZN7WebCore15GraphicsContext28setImageInterpolationQualityENS_20InterpolationQualityE
 __ZN7WebCore15GraphicsContext4clipERKNS_4PathE
@@ -1218,7 +1219,6 @@
 __ZNK7WebCore14SecurityOrigin18databaseIdentifierEv
 __ZNK7WebCore14SecurityOrigin5equalEPKS0_
 __ZNK7WebCore15FocusController18focusedOrMainFrameEv
-__ZN7WebCore15GraphicsContext10setBaseCTMERKNS_15AffineTransformE
 __ZNK7WebCore15GraphicsContext15platformContextEv
 __ZNK7WebCore15GraphicsContext16paintingDisabledEv
 __ZNK7WebCore15GraphicsContext20updatingControlTintsEv


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (98405 => 98406)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp	2011-10-25 23:06:13 UTC (rev 98405)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp	2011-10-25 23:10:12 UTC (rev 98406)
@@ -764,4 +764,16 @@
 return buffer.release();
 }
 
+#if !USE(CG)
+void GraphicsContext::platformApplyDeviceScaleFactor()
+{
 }
+#endif
+
+void GraphicsContext::applyDeviceScaleFactor(float deviceScaleFactor)
+{
+scale(FloatSize(deviceScaleFactor, 

[webkit-changes] [98408] trunk

[rniwa]

Title: [98408] trunk








Revision 98408
Author rn...@webkit.org
Date 2011-10-25 16:17:59 -0700 (Tue, 25 Oct 2011)


Log Message
Moving to the start of line should not place the caret outside of the table
https://bugs.webkit.org/show_bug.cgi?id=70757

Reviewed by Chang Shu.

Source/WebCore:

The bug was caused by positionAvoidingFirstPositionInTable. Get rid of the function.

Test: editing/selection/table-lineboundary.html

* editing/visible_units.cpp:
(WebCore::startPositionForLine):

LayoutTests:

Added a test to move the caret to lineboundaries in the first and the last table cell.
The caret should remain inside a table cell.

* editing/selection/table-lineboundary-expected.txt: Added.
* editing/selection/table-lineboundary.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/visible_units.cpp


Added Paths

trunk/LayoutTests/editing/selection/table-lineboundary-expected.txt
trunk/LayoutTests/editing/selection/table-lineboundary.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98407 => 98408)

--- trunk/LayoutTests/ChangeLog	2011-10-25 23:10:43 UTC (rev 98407)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 23:17:59 UTC (rev 98408)
@@ -1,3 +1,16 @@
+2011-10-25  Ryosuke Niwa  rn...@webkit.org
+
+Moving to the start of line should not place the caret outside of the table
+https://bugs.webkit.org/show_bug.cgi?id=70757
+
+Reviewed by Chang Shu.
+
+Added a test to move the caret to lineboundaries in the first and the last table cell.
+The caret should remain inside a table cell.
+
+* editing/selection/table-lineboundary-expected.txt: Added.
+* editing/selection/table-lineboundary.html: Added.
+
 2011-10-25  Erik Arvidsson  a...@chromium.org
 
 JS Test Harness: Make successfullyParsed optional


Added: trunk/LayoutTests/editing/selection/table-lineboundary-expected.txt (0 => 98408)

--- trunk/LayoutTests/editing/selection/table-lineboundary-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/table-lineboundary-expected.txt	2011-10-25 23:17:59 UTC (rev 98408)
@@ -0,0 +1,3 @@
+This tests moving to line boundaries in the first or the last table cell, and types h and d respectively. You should see hello and world in the first and the second table cell respectively.
+
+PASS


Added: trunk/LayoutTests/editing/selection/table-lineboundary.html (0 => 98408)

--- trunk/LayoutTests/editing/selection/table-lineboundary.html	(rev 0)
+++ trunk/LayoutTests/editing/selection/table-lineboundary.html	2011-10-25 23:17:59 UTC (rev 98408)
@@ -0,0 +1,32 @@
+!DOCTYPE html
+html
+head
+style type=text/css
+table, td { border: solid 2px red; border-collapse: collapse; }
+/style
+/head
+body
+p id=descriptionThis tests moving to line boundaries in the first or the last table cell, and types h and d respectively.
+You should see hello and world in the first and the second table cell respectively./p
+div id=container contentEditable=trueatabletrtd id=targetello/tdtdworl/td/tr/tableb/div
+script
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var target = document.getElementById('target');
+getSelection().collapse(target.firstChild, 2);
+getSelection().modify('Move', 'Backward', 'LineBoundary');
+document.execCommand('InsertText', false, 'h');
+
+getSelection().collapse(target.nextSibling.firstChild, 2);
+getSelection().modify('Move', 'Forward', 'LineBoundary');
+document.execCommand('InsertText', false, 'd');
+
+document.writeln(target.parentNode.textContent == 'helloworld' ? 'PASS' : 'FAIL');
+if (window.layoutTestController)
+document.getElementById('container').style.display = 'none';
+
+/script
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (98407 => 98408)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 23:10:43 UTC (rev 98407)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 23:17:59 UTC (rev 98408)
@@ -1,3 +1,17 @@
+2011-10-25  Ryosuke Niwa  rn...@webkit.org
+
+Moving to the start of line should not place the caret outside of the table
+https://bugs.webkit.org/show_bug.cgi?id=70757
+
+Reviewed by Chang Shu.
+
+The bug was caused by positionAvoidingFirstPositionInTable. Get rid of the function.
+
+Test: editing/selection/table-lineboundary.html
+
+* editing/visible_units.cpp:
+(WebCore::startPositionForLine):
+
 2011-10-25  Beth Dakin  bda...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=70852


Modified: trunk/Source/WebCore/editing/visible_units.cpp (98407 => 98408)

--- trunk/Source/WebCore/editing/visible_units.cpp	2011-10-25 23:10:43 UTC (rev 98407)
+++ trunk/Source/WebCore/editing/visible_units.cpp	2011-10-25 23:17:59 UTC (rev 98408)
@@ -318,17 +318,6 @@
 
 // -
 
-static VisiblePosition positionAvoidingFirstPositionInTable(const VisiblePosition c)
-{
-// return table offset 0 instead of the first VisiblePosition 

[webkit-changes] [98409] trunk/Tools

[weinig]

Title: [98409] trunk/Tools








Revision 98409
Author wei...@apple.com
Date 2011-10-25 16:19:00 -0700 (Tue, 25 Oct 2011)


Log Message
Add WKBrowsingContextLoadDelegateTest test for a failed load
https://bugs.webkit.org/show_bug.cgi?id=70859

Reviewed by Anders Carlsson.

* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
(TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).
 
(-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
Test that we are getting the correct NSError code and domain.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm




Diff

Modified: trunk/Tools/ChangeLog (98408 => 98409)

--- trunk/Tools/ChangeLog	2011-10-25 23:17:59 UTC (rev 98408)
+++ trunk/Tools/ChangeLog	2011-10-25 23:19:00 UTC (rev 98409)
@@ -1,3 +1,16 @@
+2011-10-25  Sam Weinig  s...@webkit.org
+
+Add WKBrowsingContextLoadDelegateTest test for a failed load
+https://bugs.webkit.org/show_bug.cgi?id=70859
+
+Reviewed by Anders Carlsson.
+
+* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
+(TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).
+ 
+(-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
+Test that we are getting the correct NSError code and domain.
+
 2011-10-25  Erik Arvidsson  a...@chromium.org
 
 JS Test Harness: Make successfullyParsed optional


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm (98408 => 98409)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm	2011-10-25 23:17:59 UTC (rev 98408)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm	2011-10-25 23:19:00 UTC (rev 98409)
@@ -63,6 +63,7 @@
 }
 };
 
+
 static bool simpleLoadDone;
 
 @interface SimpleLoadDelegate : NSObject WKBrowsingContextLoadDelegate
@@ -85,17 +86,53 @@
 TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoad)
 {
 // Add the load delegate.
-SimpleLoadDelegate *simpleLoadDelegate = [[SimpleLoadDelegate alloc] init];
-view.browsingContextController.loadDelegate = simpleLoadDelegate;
+SimpleLoadDelegate *loadDelegate = [[SimpleLoadDelegate alloc] init];
+view.browsingContextController.loadDelegate = loadDelegate;
 
 // Load the file.
 NSURL *nsURL = [[NSBundle mainBundle] URLForResource:@simple withExtension:@html];
 [view.browsingContextController loadFileURL:nsURL restrictToFilesWithin:nil];
 
-// Wait for the load.
+// Wait for the load to finish.
 TestWebKitAPI::Util::run(simpleLoadDone);
 
 // Tear down the delegate.
 view.browsingContextController.loadDelegate = nil;
-[simpleLoadDelegate release];
+[loadDelegate release];
 }
+
+
+static bool simpleLoadFailDone;
+
+@interface SimpleLoadFailDelegate : NSObject WKBrowsingContextLoadDelegate
+@end
+
+@implementation SimpleLoadFailDelegate
+
+- (void)browsingContextControllerDidFailProvisionalLoad:(WKBrowsingContextController *)sender withError:(NSError *)error
+{
+EXPECT_EQ(-1100, error.code);
+EXPECT_WK_STREQ(NSURLErrorDomain, error.domain);
+
+simpleLoadFailDone = true;
+}
+
+@end
+
+TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail)
+{
+// Add the load delegate.
+SimpleLoadFailDelegate *loadDelegate = [[SimpleLoadFailDelegate alloc] init];
+view.browsingContextController.loadDelegate = loadDelegate;
+
+// Load a non-existent file.
+NSURL *nsURL = [NSURL URLWithString:@file:///does-not-exist.html];
+[view.browsingContextController loadFileURL:nsURL restrictToFilesWithin:nil];
+
+// Wait for the load to fail.
+TestWebKitAPI::Util::run(simpleLoadFailDone);
+
+// Tear down the delegate.
+view.browsingContextController.loadDelegate = nil;
+[loadDelegate release];
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98410] trunk/Source/WebCore

[abarth]

Title: [98410] trunk/Source/WebCore








Revision 98410
Author aba...@webkit.org
Date 2011-10-25 16:39:28 -0700 (Tue, 25 Oct 2011)


Log Message
Attempt to fix the Windows build.  Windows mashes all these files into
one, which doesn't respect the compilation unit rules of C++.

* bindings/js/JSEventCustom.cpp:
* bindings/js/JSEventTarget.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSEventCustom.cpp
trunk/Source/WebCore/bindings/js/JSEventTarget.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (98409 => 98410)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 23:19:00 UTC (rev 98409)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 23:39:28 UTC (rev 98410)
@@ -1,3 +1,11 @@
+2011-10-25  Adam Barth  aba...@webkit.org
+
+Attempt to fix the Windows build.  Windows mashes all these files into
+one, which doesn't respect the compilation unit rules of C++.
+
+* bindings/js/JSEventCustom.cpp:
+* bindings/js/JSEventTarget.cpp:
+
 2011-10-25  Ryosuke Niwa  rn...@webkit.org
 
 Moving to the start of line should not place the caret outside of the table


Modified: trunk/Source/WebCore/bindings/js/JSEventCustom.cpp (98409 => 98410)

--- trunk/Source/WebCore/bindings/js/JSEventCustom.cpp	2011-10-25 23:19:00 UTC (rev 98409)
+++ trunk/Source/WebCore/bindings/js/JSEventCustom.cpp	2011-10-25 23:39:28 UTC (rev 98410)
@@ -69,4 +69,6 @@
 return CREATE_DOM_WRAPPER(exec, globalObject, Event, event);
 }
 
+#undef TRY_TO_WRAP_WITH_INTERFACE
+
 } // namespace WebCore


Modified: trunk/Source/WebCore/bindings/js/JSEventTarget.cpp (98409 => 98410)

--- trunk/Source/WebCore/bindings/js/JSEventTarget.cpp	2011-10-25 23:19:00 UTC (rev 98409)
+++ trunk/Source/WebCore/bindings/js/JSEventTarget.cpp	2011-10-25 23:39:28 UTC (rev 98410)
@@ -134,6 +134,8 @@
 return jsNull();
 }
 
+#undef TRY_TO_WRAP_WITH_INTERFACE
+
 EventTarget* toEventTarget(JSC::JSValue value)
 {
 #define CONVERT_TO_EVENT_TARGET(type) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98411] trunk/LayoutTests

[fsamuel]

Title: [98411] trunk/LayoutTests








Revision 98411
Author fsam...@chromium.org
Date 2011-10-25 16:42:57 -0700 (Tue, 25 Oct 2011)


Log Message
Made Table tests for Bug 70678 Platform Independent
https://bugs.webkit.org/show_bug.cgi?id=70850

Reviewed by Adam Barth.

* fast/table/table-anonymous-cell-bug-expected.png: Added.
* fast/table/table-anonymous-cell-bug-expected.txt:
* fast/table/table-anonymous-cell-bug.html:
* fast/table/table-anonymous-row-bug-expected.png: Added.
* fast/table/table-anonymous-row-bug-expected.txt:
* fast/table/table-anonymous-row-bug.html:
* fast/table/table-anonymous-section-bug-expected.png: Added.
* fast/table/table-anonymous-section-bug-expected.txt:
* fast/table/table-anonymous-section-bug.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/table/table-anonymous-cell-bug-expected.txt
trunk/LayoutTests/fast/table/table-anonymous-cell-bug.html
trunk/LayoutTests/fast/table/table-anonymous-row-bug-expected.txt
trunk/LayoutTests/fast/table/table-anonymous-row-bug.html
trunk/LayoutTests/fast/table/table-anonymous-section-bug-expected.txt
trunk/LayoutTests/fast/table/table-anonymous-section-bug.html


Added Paths

trunk/LayoutTests/fast/table/table-anonymous-cell-bug-expected.png
trunk/LayoutTests/fast/table/table-anonymous-row-bug-expected.png
trunk/LayoutTests/fast/table/table-anonymous-section-bug-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (98410 => 98411)

--- trunk/LayoutTests/ChangeLog	2011-10-25 23:39:28 UTC (rev 98410)
+++ trunk/LayoutTests/ChangeLog	2011-10-25 23:42:57 UTC (rev 98411)
@@ -1,3 +1,20 @@
+2011-10-25  Fady Samuel  fsam...@chromium.org
+
+Made Table tests for Bug 70678 Platform Independent
+https://bugs.webkit.org/show_bug.cgi?id=70850
+
+Reviewed by Adam Barth.
+
+* fast/table/table-anonymous-cell-bug-expected.png: Added.
+* fast/table/table-anonymous-cell-bug-expected.txt:
+* fast/table/table-anonymous-cell-bug.html:
+* fast/table/table-anonymous-row-bug-expected.png: Added.
+* fast/table/table-anonymous-row-bug-expected.txt:
+* fast/table/table-anonymous-row-bug.html:
+* fast/table/table-anonymous-section-bug-expected.png: Added.
+* fast/table/table-anonymous-section-bug-expected.txt:
+* fast/table/table-anonymous-section-bug.html:
+
 2011-10-25  Ryosuke Niwa  rn...@webkit.org
 
 Moving to the start of line should not place the caret outside of the table


Added: trunk/LayoutTests/fast/table/table-anonymous-cell-bug-expected.png (0 => 98411)

--- trunk/LayoutTests/fast/table/table-anonymous-cell-bug-expected.png	(rev 0)
+++ trunk/LayoutTests/fast/table/table-anonymous-cell-bug-expected.png	2011-10-25 23:42:57 UTC (rev 98411)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksumd37fe22733502592644e27d7ba443312\x8B\x93
+\xC7IDATx\x9C\xED\xDC1
+\xC30E\xC1(\xE4\xE0\xBE\xF9\xFA\x86˘\x99V\xCD/[h\xCD\xCC\x80\xCEw\xF7\x80\xB7X1\x81X1\x81X1\x81\xFB]=\xACu猿\x8F\x9Cu\xF1/1\x9C
\xC0..X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X1\x81X\xB153\xBB7\xBC\x8A

[webkit-changes] [98412] trunk

[abarth]

Title: [98412] trunk








Revision 98412
Author aba...@webkit.org
Date 2011-10-25 16:43:33 -0700 (Tue, 25 Oct 2011)


Log Message
EventTargetFactory.in is not sorted
https://bugs.webkit.org/show_bug.cgi?id=70855

Reviewed by Eric Seidel.

PerformanceTests:

Add a microbenchmark for wrapping event target.

* Bindings: Added.
* Bindings/event-target-wrapper.html: Added.
* Parser/resources/runner.js:
(runLoop):
- Let the user of the harness get a callback when the test is done.

Source/WebCore:

This patch sorts the file.  I was not able to measure a performance
difference using the microbenchmark included with this patch.

* dom/EventTargetFactory.in:

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Parser/resources/runner.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventTargetFactory.in


Added Paths

trunk/PerformanceTests/Bindings/
trunk/PerformanceTests/Bindings/event-target-wrapper.html




Diff

Added: trunk/PerformanceTests/Bindings/event-target-wrapper.html (0 => 98412)

--- trunk/PerformanceTests/Bindings/event-target-wrapper.html	(rev 0)
+++ trunk/PerformanceTests/Bindings/event-target-wrapper.html	2011-10-25 23:43:33 UTC (rev 98412)
@@ -0,0 +1,40 @@
+!DOCTYPE html
+body
+pre id=log/pre
+script src=""
+a href="" here to start/a
+script
+var link = document.getElementsByTagName('a')[0];
+var evt = null;
+var kIteratonsPerTest = 100;
+
+link.addEventListener('click', function(event) {
+link.textContent = '';
+window.evt = event;
+event.preventDefault();
+
+start(20, function() {
+var e = window.evt;
+for (var x = 0; x  kIteratonsPerTest; x++) {
+e.target;
+}
+}, 10, function() {
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+});
+
+return false;
+}, false);
+
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+layoutTestController.dumpAsText();
+}
+
+if (window.eventSender) {
+eventSender.mouseMoveTo(link.offsetLeft + 5, link.offsetTop + 5);
+eventSender.mouseDown();
+eventSender.mouseUp();
+}
+/script
+/body


Modified: trunk/PerformanceTests/ChangeLog (98411 => 98412)

--- trunk/PerformanceTests/ChangeLog	2011-10-25 23:42:57 UTC (rev 98411)
+++ trunk/PerformanceTests/ChangeLog	2011-10-25 23:43:33 UTC (rev 98412)
@@ -1,3 +1,18 @@
+2011-10-25  Adam Barth  aba...@webkit.org
+
+EventTargetFactory.in is not sorted
+https://bugs.webkit.org/show_bug.cgi?id=70855
+
+Reviewed by Eric Seidel.
+
+Add a microbenchmark for wrapping event target.
+
+* Bindings: Added.
+* Bindings/event-target-wrapper.html: Added.
+* Parser/resources/runner.js:
+(runLoop):
+- Let the user of the harness get a callback when the test is done.
+
 2011-10-04  Eric Seidel  e...@webkit.org
 
 Update html5-full-render.html to load the HTML5 spec incrementally, closer to how the browser would


Modified: trunk/PerformanceTests/Parser/resources/runner.js (98411 => 98412)

--- trunk/PerformanceTests/Parser/resources/runner.js	2011-10-25 23:42:57 UTC (rev 98411)
+++ trunk/PerformanceTests/Parser/resources/runner.js	2011-10-25 23:43:33 UTC (rev 98412)
@@ -73,6 +73,7 @@
 window.setTimeout(run, 0);
 } else {
 logStatistics(times);
+window.doneFunction();
 }
 }
 
@@ -91,10 +92,11 @@
 runLoop()
 }
 
-function start(runCount, runFunction, loopsPerRun) {
+function start(runCount, runFunction, loopsPerRun, doneFunction) {
 window.runCount = runCount;
 window.runFunction = runFunction;
 window.loopsPerRun = loopsPerRun || 10;
+window.doneFunction = doneFunction || function() {};
 
 log(Running  + runCount +  times);
 runLoop();


Modified: trunk/Source/WebCore/ChangeLog (98411 => 98412)

--- trunk/Source/WebCore/ChangeLog	2011-10-25 23:42:57 UTC (rev 98411)
+++ trunk/Source/WebCore/ChangeLog	2011-10-25 23:43:33 UTC (rev 98412)
@@ -1,5 +1,17 @@
 2011-10-25  Adam Barth  aba...@webkit.org
 
+EventTargetFactory.in is not sorted
+https://bugs.webkit.org/show_bug.cgi?id=70855
+
+Reviewed by Eric Seidel.
+
+This patch sorts the file.  I was not able to measure a performance
+difference using the microbenchmark included with this patch.
+
+* dom/EventTargetFactory.in:
+
+2011-10-25  Adam Barth  aba...@webkit.org
+
 Attempt to fix the Windows build.  Windows mashes all these files into
 one, which doesn't respect the compilation unit rules of C++.
 


Modified: trunk/Source/WebCore/dom/EventTargetFactory.in (98411 => 98412)

--- trunk/Source/WebCore/dom/EventTargetFactory.in	2011-10-25 23:42:57 UTC (rev 98411)
+++ trunk/Source/WebCore/dom/EventTargetFactory.in	2011-10-25 23:43:33 UTC (rev 98412)
@@ -1,27 +1,27 @@
 namespace=EventTarget
 
+AudioContext conditional=WEB_AUDIO
+DedicatedWorkerContext conditional=WORKERS

[webkit-changes] [98413] trunk

[andersca]

Title: [98413] trunk








Revision 98413
Author ander...@apple.com
Date 2011-10-25 17:30:39 -0700 (Tue, 25 Oct 2011)


Log Message
Plug-ins have no way to find out when the device scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=67226

Reviewed by Sam Weinig.

Source/WebKit2:

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):
* PluginProcess/PluginControllerProxy.h:
This now takes the contentsScaleFactor and calls contentsScaleFactorChanged on its plug-in
if the scale factor changes.

* PluginProcess/PluginControllerProxy.messages.in:
GeometryDidChange now takes a contents scale factor parameter.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::contentsScaleFactorChanged):
Implement contentsScaleFactorChanged and call NPP_SetValue with the new scale factor.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::contentsScaleFactorChanged):
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
Add stub.

* WebProcess/Plugins/Plugin.h:
Add pure virtual contentsScaleFactorChanged member function.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Add geometryDidChange overload that doesn't take any parameters. Make it send over the
new scale factor to the plug-in process.

(WebKit::PluginProxy::contentsScaleFactorChanged):
Call geometryDidChange.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setDeviceScaleFactor):
Call Plugin::contentsScaleFactorChanged.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):
Call setDeviceScaleFactor on all registered plug-ins.

Tools:

Keep a cached copy of the contents scale and update it when it changes.

* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::cachedContentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::NPP_New):
(ContentsScaleFactor::NPP_SetValue):

LayoutTests:

Update test to check that the scale factor is updated correctly.

* platform/mac-wk2/plugins/contents-scale-factor.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/plugins/contents-scale-factor.html
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.messages.in
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (98412 => 98413)

--- trunk/LayoutTests/ChangeLog	2011-10-25 23:43:33 UTC (rev 98412)
+++ trunk/LayoutTests/ChangeLog	2011-10-26 00:30:39 UTC (rev 98413)
@@ -1,3 +1,14 @@
+2011-10-25  Anders Carlsson  ander...@apple.com
+
+Plug-ins have no way to find out when the device scale factor changes
+https://bugs.webkit.org/show_bug.cgi?id=67226
+
+Reviewed by Sam Weinig.
+
+Update test to check that the scale factor is updated correctly.
+
+* platform/mac-wk2/plugins/contents-scale-factor.html:
+
 2011-10-25  Fady Samuel  fsam...@chromium.org
 
 Made Table tests for Bug 70678 Platform Independent


Modified: trunk/LayoutTests/platform/mac-wk2/plugins/contents-scale-factor.html (98412 => 98413)

--- trunk/LayoutTests/platform/mac-wk2/plugins/contents-scale-factor.html	2011-10-25 23:43:33 UTC (rev 98412)
+++ trunk/LayoutTests/platform/mac-wk2/plugins/contents-scale-factor.html	2011-10-26 00:30:39 UTC (rev 98413)
@@ -28,14 +28,18 @@
 document.body.appendChild(plugin1);
 
 shouldBe(plugin1.contentsScaleFactor, 1.0);
+shouldBe(plugin1.cachedContentsScaleFactor, 1.0);
 
 // Now change the backing scale factor.
 layoutTestController.setBackingScaleFactor(2, function() {
+shouldBe(plugin1.contentsScaleFactor, 2.0);
+shouldBe(plugin1.cachedContentsScaleFactor, 2.0);
 
 plugin2 = createTestPlugin('contents-scale-factor');
 document.body.appendChild(plugin2);
 
 shouldBe(plugin2.contentsScaleFactor, 2.0);
+shouldBe(plugin2.cachedContentsScaleFactor, 2.0);
 
 layoutTestController.notifyDone();
 });


Modified: 

[webkit-changes] [98414] trunk

[andersca]

Title: [98414] trunk








Revision 98414
Author ander...@apple.com
Date 2011-10-25 17:34:58 -0700 (Tue, 25 Oct 2011)


Log Message
Add radar.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Tools/ChangeLog




Diff

Modified: trunk/LayoutTests/ChangeLog (98413 => 98414)

--- trunk/LayoutTests/ChangeLog	2011-10-26 00:30:39 UTC (rev 98413)
+++ trunk/LayoutTests/ChangeLog	2011-10-26 00:34:58 UTC (rev 98414)
@@ -2,6 +2,7 @@
 
 Plug-ins have no way to find out when the device scale factor changes
 https://bugs.webkit.org/show_bug.cgi?id=67226
+rdar://problem/10048276
 
 Reviewed by Sam Weinig.
 


Modified: trunk/Source/WebKit2/ChangeLog (98413 => 98414)

--- trunk/Source/WebKit2/ChangeLog	2011-10-26 00:30:39 UTC (rev 98413)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-26 00:34:58 UTC (rev 98414)
@@ -2,6 +2,7 @@
 
 Plug-ins have no way to find out when the device scale factor changes
 https://bugs.webkit.org/show_bug.cgi?id=67226
+rdar://problem/10048276
 
 Reviewed by Sam Weinig.
 


Modified: trunk/Tools/ChangeLog (98413 => 98414)

--- trunk/Tools/ChangeLog	2011-10-26 00:30:39 UTC (rev 98413)
+++ trunk/Tools/ChangeLog	2011-10-26 00:34:58 UTC (rev 98414)
@@ -2,6 +2,7 @@
 
 Plug-ins have no way to find out when the device scale factor changes
 https://bugs.webkit.org/show_bug.cgi?id=67226
+rdar://problem/10048276
 
 Reviewed by Sam Weinig.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98416] trunk/Source/WebKit2

[andersca]

Title: [98416] trunk/Source/WebKit2








Revision 98416
Author ander...@apple.com
Date 2011-10-25 18:00:14 -0700 (Tue, 25 Oct 2011)


Log Message
CG plug-ins are always given a context with a scale factor of 1, even when the device scale factor is something else
https://bugs.webkit.org/show_bug.cgi?id=67227
rdar://problem/10048319

Reviewed by Sam Weinig.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Apply the scale factor when painting.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
Apply the scale factor when painting.

(WebKit::PluginProxy::geometryDidChange):
Make sure to apply the contents scale factor to the backing store size.

(WebKit::PluginProxy::update):
Apply the scale factor (when painting).

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98415 => 98416)

--- trunk/Source/WebKit2/ChangeLog	2011-10-26 00:56:55 UTC (rev 98415)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-26 01:00:14 UTC (rev 98416)
@@ -1,3 +1,25 @@
+2011-10-25  Anders Carlsson  ander...@apple.com
+
+CG plug-ins are always given a context with a scale factor of 1, even when the device scale factor is something else
+https://bugs.webkit.org/show_bug.cgi?id=67227
+rdar://problem/10048319
+
+Reviewed by Sam Weinig.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::paint):
+Apply the scale factor when painting.
+
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::paint):
+Apply the scale factor when painting.
+
+(WebKit::PluginProxy::geometryDidChange):
+Make sure to apply the contents scale factor to the backing store size.
+
+(WebKit::PluginProxy::update):
+Apply the scale factor (when painting).
+
 2011-10-25  Mark Hahnenberg  mhahnenb...@apple.com
 
 Remove putVirtual


Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (98415 => 98416)

--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2011-10-26 00:56:55 UTC (rev 98415)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2011-10-26 01:00:14 UTC (rev 98416)
@@ -163,6 +163,10 @@
 // Create a graphics context.
 OwnPtrGraphicsContext graphicsContext = m_backingStore-createGraphicsContext();
 
+// FIXME: We should really call applyDeviceScaleFactor instead of scale, but that ends up calling into WKSI
+// which we currently don't have initiated in the plug-in process.
+graphicsContext-scale(FloatSize(m_contentsScaleFactor, m_contentsScaleFactor));
+
 graphicsContext-translate(-m_frameRect.x(), -m_frameRect.y());
 
 if (m_plugin-isTransparent())


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (98415 => 98416)

--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp	2011-10-26 00:56:55 UTC (rev 98415)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp	2011-10-26 01:00:14 UTC (rev 98416)
@@ -135,14 +135,17 @@
 if (!needsBackingStore() || !m_backingStore)
 return;
 
+float contentsScaleFactor = controller()-contentsScaleFactor();
+
 if (!m_pluginBackingStoreContainsValidData) {
 m_connection-connection()-sendSync(Messages::PluginControllerProxy::PaintEntirePlugin(), Messages::PluginControllerProxy::PaintEntirePlugin::Reply(), m_pluginInstanceID);
 
 // Blit the plug-in backing store into our own backing store.
 OwnPtrWebCore::GraphicsContext graphicsContext = m_backingStore-createGraphicsContext();
+graphicsContext-applyDeviceScaleFactor(contentsScaleFactor);
 graphicsContext-setCompositeOperation(CompositeCopy);
 
-m_pluginBackingStore-paint(*graphicsContext, IntPoint(), IntRect(0, 0, m_frameRect.width(), m_frameRect.height()));
+m_pluginBackingStore-paint(*graphicsContext, contentsScaleFactor, IntPoint(), IntRect(0, 0, m_frameRect.width(), m_frameRect.height()));
 
 m_pluginBackingStoreContainsValidData = true;
 }
@@ -150,7 +153,7 @@
 IntRect dirtyRectInPluginCoordinates = dirtyRect;
 dirtyRectInPluginCoordinates.move(-m_frameRect.x(), -m_frameRect.y());
 
-m_backingStore-paint(*graphicsContext, dirtyRect.location(), dirtyRectInPluginCoordinates);
+m_backingStore-paint(*graphicsContext, contentsScaleFactor, dirtyRect.location(), dirtyRectInPluginCoordinates);
 
 if (m_waitingForPaintInResponseToUpdate) {
 m_waitingForPaintInResponseToUpdate = false;
@@ -188,12 +191,15 @@
 }
 
 bool didUpdateBackingStore = false;
+IntSize backingStoreSize = m_frameRect.size();
+backingStoreSize.scale(contentsScaleFactor);
+
 if (!m_backingStore) {
-m_backingStore = ShareableBitmap::create(m_frameRect.size(), ShareableBitmap::SupportsAlpha);
+m_backingStore = 

[webkit-changes] [98417] trunk/LayoutTests

[arv]

Title: [98417] trunk/LayoutTests








Revision 98417
Author a...@chromium.org
Date 2011-10-25 18:01:46 -0700 (Tue, 25 Oct 2011)


Log Message
[Chromium] Fix expectation.

unreviewed.

* platform/chromium/fast/js/kde/garbage-n-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/fast/js/kde/garbage-n-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (98416 => 98417)

--- trunk/LayoutTests/ChangeLog	2011-10-26 01:00:14 UTC (rev 98416)
+++ trunk/LayoutTests/ChangeLog	2011-10-26 01:01:46 UTC (rev 98417)
@@ -1,3 +1,11 @@
+2011-10-25  Erik Arvidsson  a...@chromium.org
+
+[Chromium] Fix expectation.
+
+unreviewed.
+
+* platform/chromium/fast/js/kde/garbage-n-expected.txt:
+
 2011-10-25  Anders Carlsson  ander...@apple.com
 
 Plug-ins have no way to find out when the device scale factor changes


Modified: trunk/LayoutTests/platform/chromium/fast/js/kde/garbage-n-expected.txt (98416 => 98417)

--- trunk/LayoutTests/platform/chromium/fast/js/kde/garbage-n-expected.txt	2011-10-26 01:00:14 UTC (rev 98416)
+++ trunk/LayoutTests/platform/chromium/fast/js/kde/garbage-n-expected.txt	2011-10-26 01:01:46 UTC (rev 98417)
@@ -4,7 +4,7 @@
 On success, you will see a series of PASS messages, followed by TEST COMPLETE.
 
 
-PASS Got expected syntax error
+PASS Got expected error: 'SyntaxError'
 PASS successfullyParsed is true
 
 TEST COMPLETE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98418] trunk/Source/WebKit2

[bfulgham]

Title: [98418] trunk/Source/WebKit2








Revision 98418
Author bfulg...@webkit.org
Date 2011-10-25 18:13:52 -0700 (Tue, 25 Oct 2011)


Log Message
[WinCairo] Unreviewed build fix after r97587.

* win/WebKit2CFLite.def:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2CFLite.def




Diff

Modified: trunk/Source/WebKit2/ChangeLog (98417 => 98418)

--- trunk/Source/WebKit2/ChangeLog	2011-10-26 01:01:46 UTC (rev 98417)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-26 01:13:52 UTC (rev 98418)
@@ -1,3 +1,9 @@
+2011-10-25  Brent Fulgham  bfulg...@webkit.org
+
+[WinCairo] Unreviewed build fix after r97587.
+
+* win/WebKit2CFLite.def:
+
 2011-10-25  Anders Carlsson  ander...@apple.com
 
 CG plug-ins are always given a context with a scale factor of 1, even when the device scale factor is something else


Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (98417 => 98418)

--- trunk/Source/WebKit2/win/WebKit2CFLite.def	2011-10-26 01:01:46 UTC (rev 98417)
+++ trunk/Source/WebKit2/win/WebKit2CFLite.def	2011-10-26 01:13:52 UTC (rev 98418)
@@ -128,13 +128,14 @@
 ?createThread@WTF@@YAIP6APAXPAX@Z0@Z
 
 ; Re-exports from WebCore for test harnesses
+??0NodeRenderingContext@WebCore@@QAE@PAVNode@1@@Z
+??1NodeRenderingContext@WebCore@@QAE@XZ
+??1Range@WebCore@@QAE@XZ
+?toNode@WebCore@@YAPAVNode@1@VJSValue@JSC@@@Z
 ??0ClientRect@WebCore@@AAE@ABVIntRect@1@@Z
 ??0ClientRect@WebCore@@AAE@XZ
-??0NodeRenderingContext@WebCore@@QAE@PAVNode@1@@Z
 ??0String@WTF@@QAE@PBD@Z
 ??0String@WTF@@QAE@PB_W@Z
-??1NodeRenderingContext@WebCore@@QAE@XZ
-??1Range@WebCore@@QAE@XZ
 ?absoluteBoundingBoxRect@RenderObject@WebCore@@QBE?AVIntRect@2@_N@Z
 ?absoluteBoundingBoxRectIgnoringTransforms@RenderObject@WebCore@@QBE?AVIntRect@2@XZ
 ?add@AtomicString@WTF@@CA?AV?$PassRefPtr@VStringImpl@WTF@@@2@PBD@Z
@@ -148,16 +149,16 @@
 ?externalRepresentation@WebCore@@YA?AVString@WTF@@PAVElement@1@I@Z
 ?getCachedDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PBUClassInfo@3@@Z
 ?getElementById@TreeScope@WebCore@@QBEPAVElement@2@ABVAtomicString@WTF@@@Z
+?getLocationAndLengthFromRange@TextIterator@WebCore@@SA_NPAVElement@2@PBVRange@2@AAI2@Z
 ?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z
-?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVClientRect@1@@Z
-?updateLayoutIgnorePendingStylesheets@Document@WebCore@@QAEXXZ
 ?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@UStringHash@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z
 ?lastChangeWasUserEdit@HTMLTextFormControlElement@WebCore@@QBE_NXZ
 ?markersFor@DocumentMarkerController@WebCore@@QAE?AV?$Vector@PAVDocumentMarker@WebCore@@$0A@@WTF@@PAVNode@2@@Z
 ?page@Document@WebCore@@QBEPAVPage@2@XZ
 ?paintControlTints@FrameView@WebCore@@AAEXXZ
+?rangeFromLocationAndLength@TextIterator@WebCore@@SA?AV?$PassRefPtr@VRange@WebCore@@@WTF@@PAVElement@2@HH_N@Z
+?removeShadowRoot@Element@WebCore@@QAEXXZ
 ?scrollElementToRect@FrameView@WebCore@@QAEXPAVElement@2@ABVIntRect@2@@Z
-?removeShadowRoot@Element@WebCore@@QAEXXZ
 ?setDOMException@WebCore@@YAXPAVExecState@JSC@@H@Z
 ?setResourcesDataSizeLimitsFromInternals@InspectorController@WebCore@@QAEXHH@Z
 ?setScrollbarsSuppressed@ScrollView@WebCore@@QAEX_N0@Z
@@ -168,8 +169,10 @@
 ?suggestedValue@HTMLInputElement@WebCore@@QBEABVString@WTF@@XZ
 ?toDocument@WebCore@@YAPAVDocument@1@VJSValue@JSC@@@Z
 ?toElement@WebCore@@YAPAVElement@1@VJSValue@JSC@@@Z
+?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVClientRect@1@@Z
 ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z
 ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVRange@1@@Z
-?toNode@WebCore@@YAPAVNode@1@VJSValue@JSC@@@Z
+?toRange@WebCore@@YAPAVRange@1@VJSValue@JSC@@@Z
+?updateLayoutIgnorePendingStylesheets@Document@WebCore@@QAEXXZ
 ?view@Document@WebCore@@QBEPAVFrameView@2@XZ
 ?virtualFunctionToPreventWeakVtable@JSDOMWrapper@WebCore@@MAEXXZ






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98420] trunk/LayoutTests

[jchaffraix]

Title: [98420] trunk/LayoutTests








Revision 98420
Author jchaffr...@webkit.org
Date 2011-10-25 18:38:31 -0700 (Tue, 25 Oct 2011)


Log Message
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
fast/forms/form-associated-element-crash3.html has
been timing out very regularly on linux debug.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (98419 => 98420)

--- trunk/LayoutTests/ChangeLog	2011-10-26 01:15:22 UTC (rev 98419)
+++ trunk/LayoutTests/ChangeLog	2011-10-26 01:38:31 UTC (rev 98420)
@@ -1,3 +1,11 @@
+2011-10-25  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
+* platform/chromium/test_expectations.txt:
+fast/forms/form-associated-element-crash3.html has
+been timing out very regularly on linux debug.
+
 2011-10-25  Erik Arvidsson  a...@chromium.org
 
 [Chromium] Fix expectation.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98419 => 98420)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-26 01:15:22 UTC (rev 98419)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-26 01:38:31 UTC (rev 98420)
@@ -8,7 +8,7 @@
 
 BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/css/large-list-of-rules-crash.html = PASS
 BUGCR24182 SLOW LINUX MAC DEBUG : fast/dom/Window/window-postmessage-clone-really-deep-array.html = PASS
-BUGCR24182 SLOW LINUX MAC DEBUG : fast/forms/form-associated-element-crash3.html = PASS
+BUGCR24182 SLOW MAC DEBUG : fast/forms/form-associated-element-crash3.html = PASS
 BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/forms/select-set-length-with-mutation-remove.html = PASS
 BUGCR24182 SLOW : fast/js/regexp-overflow.html = PASS
 BUGCR24182 SLOW DEBUG : fast/js/toString-and-valueOf-override.html = PASS
@@ -3814,3 +3814,5 @@
 // Intermittent ASSERT seen on the bot.
 BUGWK67031 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH
 BUGWK67031 SNOWLEOPARD DEBUG : fast/dom/Element/id-in-frame.html = PASS CRASH
+
+BUGWK70866 LINUX DEBUG : fast/forms/form-associated-element-crash3.html = TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98421] trunk

[cfleizach]

Title: [98421] trunk








Revision 98421
Author cfleiz...@apple.com
Date 2011-10-25 18:45:40 -0700 (Tue, 25 Oct 2011)


Log Message
AX: WebKit does not expose HTML label for slider elements
https://bugs.webkit.org/show_bug.cgi?id=70856

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/slider-allows-title-ui-element.html

* accessibility/AccessibilitySlider.h:
(WebCore::AccessibilitySlider::isControl):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

* platform/mac/accessibility/slider-allows-title-ui-element-expected.txt: Added.
* platform/mac/accessibility/slider-allows-title-ui-element.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilitySlider.h
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm


Added Paths

trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element-expected.txt
trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98420 => 98421)

--- trunk/LayoutTests/ChangeLog	2011-10-26 01:38:31 UTC (rev 98420)
+++ trunk/LayoutTests/ChangeLog	2011-10-26 01:45:40 UTC (rev 98421)
@@ -1,3 +1,13 @@
+2011-10-25  Chris Fleizach  cfleiz...@apple.com
+
+AX: WebKit does not expose HTML label for slider elements
+https://bugs.webkit.org/show_bug.cgi?id=70856
+
+Reviewed by Darin Adler.
+
+* platform/mac/accessibility/slider-allows-title-ui-element-expected.txt: Added.
+* platform/mac/accessibility/slider-allows-title-ui-element.html: Added.
+
 2011-10-25  Julien Chaffraix  jchaffr...@webkit.org
 
 Unreviewed gardening.


Added: trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element-expected.txt (0 => 98421)

--- trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element-expected.txt	2011-10-26 01:45:40 UTC (rev 98421)
@@ -0,0 +1,13 @@
+Color: 
+This tests that sliders are allowed to have title UI elements.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS slider.titleUIElement().isEqual(title) is true
+PASS title.role is 'AXRole: AXGroup'
+PASS title.childAtIndex(0).role is 'AXRole: AXStaticText'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element.html (0 => 98421)

--- trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element.html	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element.html	2011-10-26 01:45:40 UTC (rev 98421)
@@ -0,0 +1,40 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script
+var successfullyParsed = false;
+/script
+script src=""
+/head
+body id=body
+
+label for="" tabindex=0 id=titleColor:/label
+input id=slider type=range min=0 value=0 max=6
+
+p id=description/p
+div id=console/div
+
+script
+
+description(This tests that sliders are allowed to have title UI elements.);
+
+if (window.accessibilityController) {
+
+document.getElementById(slider).focus();
+var slider = accessibilityController.focusedElement;
+
+document.getElementById(title).focus();
+var title = accessibilityController.rootElement.childAtIndex(0).childAtIndex(0).childAtIndex(0);
+
+shouldBeTrue(slider.titleUIElement().isEqual(title));
+shouldBe(title.role, 'AXRole: AXGroup');
+shouldBe(title.childAtIndex(0).role, 'AXRole: AXStaticText');
+}
+
+successfullyParsed = true;
+/script
+
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (98420 => 98421)

--- trunk/Source/WebCore/ChangeLog	2011-10-26 01:38:31 UTC (rev 98420)
+++ trunk/Source/WebCore/ChangeLog	2011-10-26 01:45:40 UTC (rev 98421)
@@ -1,3 +1,17 @@
+2011-10-25  Chris Fleizach  cfleiz...@apple.com
+
+AX: WebKit does not expose HTML label for slider elements
+https://bugs.webkit.org/show_bug.cgi?id=70856
+
+Reviewed by Darin Adler.
+
+Test: platform/mac/accessibility/slider-allows-title-ui-element.html
+
+* accessibility/AccessibilitySlider.h:
+(WebCore::AccessibilitySlider::isControl):
+* accessibility/mac/WebAccessibilityObjectWrapper.mm:
+(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
+
 2011-10-25  Mark Hahnenberg  mhahnenb...@apple.com
 
 Remove putVirtual


Modified: trunk/Source/WebCore/accessibility/AccessibilitySlider.h (98420 => 98421)

--- trunk/Source/WebCore/accessibility/AccessibilitySlider.h	2011-10-26 01:38:31 UTC (rev 98420)
+++ trunk/Source/WebCore/accessibility/AccessibilitySlider.h	2011-10-26 01:45:40 UTC (rev 

[webkit-changes] [98423] trunk/Source/WebCore

[mhahnenberg]

Title: [98423] trunk/Source/WebCore








Revision 98423
Author mhahnenb...@apple.com
Date 2011-10-25 18:59:37 -0700 (Tue, 25 Oct 2011)


Log Message
Resetting baseline for test bindings

Unreviewed preemptive build fix

No new tests.

* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (98422 => 98423)

--- trunk/Source/WebCore/ChangeLog	2011-10-26 01:49:00 UTC (rev 98422)
+++ trunk/Source/WebCore/ChangeLog	2011-10-26 01:59:37 UTC (rev 98423)
@@ -1,5 +1,16 @@
 2011-10-25  Mark Hahnenberg  mhahnenb...@apple.com
 
+Resetting baseline for test bindings
+
+Unreviewed preemptive build fix
+
+No new tests.
+
+* bindings/scripts/test/JS/JSTestObj.cpp:
+* bindings/scripts/test/JS/JSTestObj.h:
+
+2011-10-25  Mark Hahnenberg  mhahnenb...@apple.com
+
 Remove deletePropertyVirtual
 https://bugs.webkit.org/show_bug.cgi?id=70738
 


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (98422 => 98423)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2011-10-26 01:49:00 UTC (rev 98422)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2011-10-26 01:59:37 UTC (rev 98423)
@@ -753,11 +753,6 @@
 return JSTestObj::getConstructor(exec, domObject-globalObject());
 }
 
-void JSTestObj::putVirtual(ExecState* exec, const Identifier propertyName, JSValue value, PutPropertySlot slot)
-{
-put(this, exec, propertyName, value, slot);
-}
-
 void JSTestObj::put(JSCell* cell, ExecState* exec, const Identifier propertyName, JSValue value, PutPropertySlot slot)
 {
 JSTestObj* thisObject = static_castJSTestObj*(cell);


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h (98422 => 98423)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	2011-10-26 01:49:00 UTC (rev 98422)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	2011-10-26 01:59:37 UTC (rev 98423)
@@ -43,7 +43,6 @@
 virtual bool getOwnPropertySlotVirtual(JSC::ExecState*, const JSC::Identifier propertyName, JSC::PropertySlot);
 static bool getOwnPropertySlot(JSC::JSCell*, JSC::ExecState*, const JSC::Identifier propertyName, JSC::PropertySlot);
 virtual bool getOwnPropertyDescriptor(JSC::ExecState*, const JSC::Identifier propertyName, JSC::PropertyDescriptor);
-virtual void putVirtual(JSC::ExecState*, const JSC::Identifier propertyName, JSC::JSValue, JSC::PutPropertySlot);
 static void put(JSC::JSCell*, JSC::ExecState*, const JSC::Identifier propertyName, JSC::JSValue, JSC::PutPropertySlot);
 static const JSC::ClassInfo s_info;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98424] trunk/Source/WebKit/efl

[commit-queue]

Title: [98424] trunk/Source/WebKit/efl








Revision 98424
Author commit-qu...@webkit.org
Date 2011-10-25 19:11:33 -0700 (Tue, 25 Oct 2011)


Log Message
Fix occurrence of unpainted tiles while scrolling and zooming.
https://bugs.webkit.org/show_bug.cgi?id=70711

Patch by KwangHyuk Kim hyuki@samsung.com on 2011-10-25
Reviewed by Adam Barth.

Cast one of operatees to float type when ewk_tiled_backing_store calculate tiles list on viewport.
For the proper calculation to generate a float number, at least one of operatees must be a float type.
But, currently both two operatees to calculate the number of tiles on viewport routine aren't float type,
so it generates smaller result than expected result when it is using ceil API.
As a result, it can lose a line of tiles which should be displayed in viewport area while scrolling and zooming.

* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_recalc_renderers):
(ewk_tiled_backing_store_zoom_weak_set):

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (98423 => 98424)

--- trunk/Source/WebKit/efl/ChangeLog	2011-10-26 01:59:37 UTC (rev 98423)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-10-26 02:11:33 UTC (rev 98424)
@@ -1,5 +1,22 @@
 2011-10-25  KwangHyuk Kim  hyuki@samsung.com
 
+Fix occurrence of unpainted tiles while scrolling and zooming.
+https://bugs.webkit.org/show_bug.cgi?id=70711
+
+Reviewed by Adam Barth.
+
+Cast one of operatees to float type when ewk_tiled_backing_store calculate tiles list on viewport.
+For the proper calculation to generate a float number, at least one of operatees must be a float type.
+But, currently both two operatees to calculate the number of tiles on viewport routine aren't float type,
+so it generates smaller result than expected result when it is using ceil API.
+As a result, it can lose a line of tiles which should be displayed in viewport area while scrolling and zooming.
+
+* ewk/ewk_tiled_backing_store.cpp:
+(_ewk_tiled_backing_store_recalc_renderers):
+(ewk_tiled_backing_store_zoom_weak_set):
+
+2011-10-25  KwangHyuk Kim  hyuki@samsung.com
+
 [EFL] Move assignment of some variables out of loop for ewk_tiled_backing_store.
 https://bugs.webkit.org/show_bug.cgi?id=67588
 


Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp (98423 => 98424)

--- trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp	2011-10-26 01:59:37 UTC (rev 98423)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp	2011-10-26 02:11:33 UTC (rev 98424)
@@ -812,8 +812,8 @@
 long columns, rows, oldRows, oldCols;
 INF(ewkTile%p, new size: %dx%d, priv-self, width, height);
 
-columns = 1 + static_castint(ceil(static_castfloat(width / tileWidth)));
-rows = 1 + static_castint(ceil(static_castfloat(height / tileHeight)));
+columns = 1 + static_castint(ceil(width / static_castfloat(tileWidth)));
+rows = 1 + static_castint(ceil(height / static_castfloat(tileHeight)));
 
 INF(ewkTile%p new grid size cols: %ld, rows: %ld, was %ld, %ld,
 priv-self, columns, rows, priv-view.cols, priv-view.rows);
@@ -1596,8 +1596,8 @@
 
 evas_object_resize(priv-contentsClipper, modelWidth, modelHeight);
 
-int vrows = static_castint(ceil(static_castfloat(priv-view.height / tileHeight)) + 1);
-int vcols = static_castint(ceil(static_castfloat(priv-view.width / tileWidth)) + 1);
+int vrows = static_castint(ceil(priv-view.height /static_castfloat(tileHeight)) + 1);
+int vcols = static_castint(ceil(priv-view.width / static_castfloat(tileWidth)) + 1);
 Evas_Coord newX = currentX + (priv-view.offset.cur.x - currentX) * scale;
 Evas_Coord newY = currentY + (priv-view.offset.cur.y - currentY) * scale;
 Evas_Coord baseX = newX % tileWidth;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98425] trunk/LayoutTests

[arv]

Title: [98425] trunk/LayoutTests








Revision 98425
Author a...@chromium.org
Date 2011-10-25 19:12:22 -0700 (Tue, 25 Oct 2011)


Log Message
Fix ad hoc test.

unreviewed.

* fast/canvas/webgl/gl-teximage.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/webgl/gl-teximage.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98424 => 98425)

--- trunk/LayoutTests/ChangeLog	2011-10-26 02:11:33 UTC (rev 98424)
+++ trunk/LayoutTests/ChangeLog	2011-10-26 02:12:22 UTC (rev 98425)
@@ -1,3 +1,11 @@
+2011-10-25  Erik Arvidsson  a...@chromium.org
+
+Fix ad hoc test.
+
+unreviewed.
+
+* fast/canvas/webgl/gl-teximage.html:
+
 2011-10-25  Chris Fleizach  cfleiz...@apple.com
 
 AX: WebKit does not expose HTML label for slider elements


Modified: trunk/LayoutTests/fast/canvas/webgl/gl-teximage.html (98424 => 98425)

--- trunk/LayoutTests/fast/canvas/webgl/gl-teximage.html	2011-10-26 02:11:33 UTC (rev 98424)
+++ trunk/LayoutTests/fast/canvas/webgl/gl-teximage.html	2011-10-26 02:12:22 UTC (rev 98425)
@@ -4,6 +4,7 @@
 head
 titleWebGL texImage2D conformance test./title
 script src=""
+script src=""
 script src="" /script
 script src="" /script
 /head
@@ -393,11 +394,9 @@
   checkPixelRange(buf, middle, center, [ 255, 0, 0, 255 ], 10);
 
   debug();
-  shouldBeTrue(successfullyParsed);
-  debug('br /span class=passTEST COMPLETE/span');
-  if (window.layoutTestController)
-layoutTestController.notifyDone();
+  isSuccessfullyParsed();
 }
+
 /script
 /body
 /html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98426] trunk/Source/WebCore

[abarth]

Title: [98426] trunk/Source/WebCore








Revision 98426
Author aba...@webkit.org
Date 2011-10-25 19:14:53 -0700 (Tue, 25 Oct 2011)


Log Message
V8DOMWrapper.cpp has unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=70863

Reviewed by Eric Seidel.

* bindings/v8/V8DOMWrapper.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (98425 => 98426)

--- trunk/Source/WebCore/ChangeLog	2011-10-26 02:12:22 UTC (rev 98425)
+++ trunk/Source/WebCore/ChangeLog	2011-10-26 02:14:53 UTC (rev 98426)
@@ -1,3 +1,12 @@
+2011-10-25  Adam Barth  aba...@webkit.org
+
+V8DOMWrapper.cpp has unneeded header includes
+https://bugs.webkit.org/show_bug.cgi?id=70863
+
+Reviewed by Eric Seidel.
+
+* bindings/v8/V8DOMWrapper.cpp:
+
 2011-10-25  Mark Hahnenberg  mhahnenb...@apple.com
 
 Resetting baseline for test bindings


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp (98425 => 98426)

--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp	2011-10-26 02:12:22 UTC (rev 98425)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp	2011-10-26 02:14:53 UTC (rev 98426)
@@ -38,61 +38,27 @@
 #include EventTargetHeaders.h
 #include EventTargetInterfaces.h
 #include FrameLoaderClient.h
-#include Notification.h
 #include V8AbstractEventListener.h
 #include V8Binding.h
 #include V8Collection.h
-#include V8DOMApplicationCache.h
 #include V8DOMMap.h
-#include V8DOMWindow.h
-#include V8DedicatedWorkerContext.h
 #include V8EventListener.h
 #include V8EventListenerList.h
-#include V8EventSource.h
-#include V8FileReader.h
-#include V8FileWriter.h
 #include V8HTMLCollection.h
 #include V8HTMLDocument.h
 #include V8HiddenPropertyName.h
-#include V8IDBDatabase.h
-#include V8IDBRequest.h
-#include V8IDBTransaction.h
 #include V8IsolatedContext.h
-#include V8LocalMediaStream.h
 #include V8Location.h
-#include V8MediaStream.h
-#include V8MessageChannel.h
 #include V8NamedNodeMap.h
-#include V8Node.h
 #include V8NodeFilterCondition.h
 #include V8NodeList.h
-#include V8Notification.h
-#include V8PeerConnection.h
 #include V8Proxy.h
-#include V8SharedWorker.h
-#include V8SharedWorkerContext.h
 #include V8StyleSheet.h
-#include V8WebSocket.h
-#include V8Worker.h
-#include V8WorkerContext.h
 #include V8WorkerContextEventListener.h
-#include V8XMLHttpRequest.h
 #include WebGLContextAttributes.h
 #include WebGLUniformLocation.h
 #include WorkerContextExecutionProxy.h
 #include WrapperTypeInfo.h
-
-#if ENABLE(SVG)
-#include SVGElementInstance.h
-#include SVGPathSeg.h
-#include V8SVGElementInstance.h
-#endif
-
-#if ENABLE(WEB_AUDIO)
-#include V8AudioContext.h
-#include V8JavaScriptAudioNode.h
-#endif
-
 #include algorithm
 #include utility
 #include v8-debug.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98427] trunk/Source/WebCore

[abarth]

Title: [98427] trunk/Source/WebCore








Revision 98427
Author aba...@webkit.org
Date 2011-10-25 20:06:58 -0700 (Tue, 25 Oct 2011)


Log Message
JSEventTarget.cpp has a bunch of unnessary includes
https://bugs.webkit.org/show_bug.cgi?id=70865

Reviewed by Eric Seidel.

In the process of removing these includes, I noticed we had a bunch of
non-autogenerated code in this file, which I've now autogenerated.

* bindings/js/JSEventTarget.cpp:
(WebCore::toEventTarget):
- One subtly here is the outter static_cast, which is caused by an
  inheritance infelicity in _javascript_AudioNode, which I've noted
  with a FIXME.  In any case, the extra static_cast shouldn't cause
  any trouble.
* webaudio/_javascript_AudioNode.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSEventTarget.cpp
trunk/Source/WebCore/webaudio/_javascript_AudioNode.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (98426 => 98427)

--- trunk/Source/WebCore/ChangeLog	2011-10-26 02:14:53 UTC (rev 98426)
+++ trunk/Source/WebCore/ChangeLog	2011-10-26 03:06:58 UTC (rev 98427)
@@ -1,5 +1,23 @@
 2011-10-25  Adam Barth  aba...@webkit.org
 
+JSEventTarget.cpp has a bunch of unnessary includes
+https://bugs.webkit.org/show_bug.cgi?id=70865
+
+Reviewed by Eric Seidel.
+
+In the process of removing these includes, I noticed we had a bunch of
+non-autogenerated code in this file, which I've now autogenerated.
+
+* bindings/js/JSEventTarget.cpp:
+(WebCore::toEventTarget):
+- One subtly here is the outter static_cast, which is caused by an
+  inheritance infelicity in _javascript_AudioNode, which I've noted
+  with a FIXME.  In any case, the extra static_cast shouldn't cause
+  any trouble.
+* webaudio/_javascript_AudioNode.h:
+
+2011-10-25  Adam Barth  aba...@webkit.org
+
 V8DOMWrapper.cpp has unneeded header includes
 https://bugs.webkit.org/show_bug.cgi?id=70863
 


Modified: trunk/Source/WebCore/bindings/js/JSEventTarget.cpp (98426 => 98427)

--- trunk/Source/WebCore/bindings/js/JSEventTarget.cpp	2011-10-26 02:14:53 UTC (rev 98426)
+++ trunk/Source/WebCore/bindings/js/JSEventTarget.cpp	2011-10-26 03:06:58 UTC (rev 98427)
@@ -26,83 +26,11 @@
 #include config.h
 #include JSEventTarget.h
 
-#include DOMWindow.h
-#include Document.h
 #include EventTargetHeaders.h
 #include EventTargetInterfaces.h
-#include JSDOMWindow.h
 #include JSDOMWindowShell.h
 #include JSEventListener.h
-#include JSMessagePort.h
-#include JSNode.h
-#if ENABLE(SHARED_WORKERS)
 
-#include JSSharedWorker.h
-#include JSSharedWorkerContext.h
-#endif
-
-#include JSXMLHttpRequest.h
-#include JSXMLHttpRequestUpload.h
-#include MessagePort.h
-
-#if ENABLE(SHARED_WORKERS)
-#include SharedWorker.h
-#include SharedWorkerContext.h
-#endif
-
-#include XMLHttpRequest.h
-#include XMLHttpRequestUpload.h
-
-#include EventSource.h
-#include JSEventSource.h
-
-#include DOMApplicationCache.h
-#include JSDOMApplicationCache.h
-
-#if ENABLE(SVG)
-#include SVGElementInstance.h
-#include JSSVGElementInstance.h
-#endif
-
-#if ENABLE(WORKERS)
-#include DedicatedWorkerContext.h
-#include JSDedicatedWorkerContext.h
-#include JSWorker.h
-#include Worker.h
-#endif
-
-#if ENABLE(NOTIFICATIONS)
-#include JSNotification.h
-#include Notification.h
-#endif
-
-#if ENABLE(INDEXED_DATABASE)
-#include IDBRequest.h
-#include JSIDBRequest.h
-#endif
-
-#if ENABLE(WEB_AUDIO)
-#include AudioContext.h
-#include JSAudioContext.h
-#include JSJavaScriptAudioNode.h
-#include _javascript_AudioNode.h
-#endif
-
-#if ENABLE(WEB_SOCKETS)
-#include JSWebSocket.h
-#include WebSocket.h
-#endif
-
-#if ENABLE(BLOB)
-#include JSFileReader.h
-#include FileReader.h
-#endif
-
-#if ENABLE(MEDIA_STREAM)
-#include LocalMediaStream.h
-#include MediaStream.h
-#endif
-
 using namespace JSC;
 
 namespace WebCore {
@@ -136,46 +64,19 @@
 
 #undef TRY_TO_WRAP_WITH_INTERFACE
 
+#define TRY_TO_UNWRAP_WITH_INTERFACE(interfaceName) \
+if (value.inherits(JS##interfaceName::s_info)) \
+return static_castinterfaceName*(static_castJS##interfaceName*(asObject(value))-impl());
+
 EventTarget* toEventTarget(JSC::JSValue value)
 {
-#define CONVERT_TO_EVENT_TARGET(type) \
-if (value.inherits(JS##type::s_info)) \
-return static_castJS##type*(asObject(value))-impl();
-
-CONVERT_TO_EVENT_TARGET(Node)
-CONVERT_TO_EVENT_TARGET(XMLHttpRequest)
-CONVERT_TO_EVENT_TARGET(XMLHttpRequestUpload)
-CONVERT_TO_EVENT_TARGET(MessagePort)
-
 if (value.inherits(JSDOMWindowShell::s_info))
 return static_castJSDOMWindowShell*(asObject(value))-impl();
 
-CONVERT_TO_EVENT_TARGET(EventSource)
-CONVERT_TO_EVENT_TARGET(DOMApplicationCache)
-
-#if ENABLE(SVG)
-CONVERT_TO_EVENT_TARGET(SVGElementInstance)
-#endif
-
-#if ENABLE(WORKERS)
-CONVERT_TO_EVENT_TARGET(Worker)
-CONVERT_TO_EVENT_TARGET(DedicatedWorkerContext)
-#endif
-
-#if 

[webkit-changes] [98428] trunk

[xji]

Title: [98428] trunk








Revision 98428
Author x...@chromium.org
Date 2011-10-25 21:57:39 -0700 (Tue, 25 Oct 2011)


Log Message
--webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Reviewed by Ryosuke Niwa.

Source/WebCore: 

Get next or previous root inline box (which is not in the same
render object as the current root inline box) by traversing DOM node.

Test: editing/selection/move-by-word-visually-inline-block-positioned-element.html

* editing/visible_units.cpp:
(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):
(WebCore::leftInlineBox):
(WebCore::rightInlineBox):

LayoutTests: 

* editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt: Added.
* editing/selection/move-by-word-visually-inline-block-positioned-element.html: Added.
* editing/selection/move-by-word-visually-multi-line-expected.txt:
* editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
* editing/selection/move-by-word-visually-single-space-one-element.html:
* platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/selection/move-by-word-visually-multi-line-expected.txt
trunk/LayoutTests/editing/selection/move-by-word-visually-single-space-one-element-expected.txt
trunk/LayoutTests/editing/selection/move-by-word-visually-single-space-one-element.html
trunk/LayoutTests/platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/visible_units.cpp


Added Paths

trunk/LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt
trunk/LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element.html




Diff

Modified: trunk/LayoutTests/ChangeLog (98427 => 98428)

--- trunk/LayoutTests/ChangeLog	2011-10-26 03:06:58 UTC (rev 98427)
+++ trunk/LayoutTests/ChangeLog	2011-10-26 04:57:39 UTC (rev 98428)
@@ -1,3 +1,17 @@
+2011-10-25  Xiaomei Ji  x...@chromium.org
+
+--webkit-visual-word does not work in multi-line
+https://bugs.webkit.org/show_bug.cgi?id=61344
+
+Reviewed by Ryosuke Niwa.
+
+* editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt: Added.
+* editing/selection/move-by-word-visually-inline-block-positioned-element.html: Added.
+* editing/selection/move-by-word-visually-multi-line-expected.txt:
+* editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
+* editing/selection/move-by-word-visually-single-space-one-element.html:
+* platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:
+
 2011-10-25  Erik Arvidsson  a...@chromium.org
 
 Fix ad hoc test.


Added: trunk/LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt (0 => 98428)

--- trunk/LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt	2011-10-26 04:57:39 UTC (rev 98428)
@@ -0,0 +1,38 @@
+
+ Move By Word 
+Test 1, LTR:
+Move right by one word
+begin start[0, 6, 11], abc def[0, 4, 7], end ing[0, 4, 7], this is float[0, 5, 8, 13], this is fixed[5, 8, 13], this is relative[0, 5, 8, 16], this is absolute[0, 5, 8, 16]
+Move left by one word
+this is absolute[16, 8, 5, 0], this is relative[8, 5, 0], this is fixed[8, 5], this is float[8, 5, 0], end ing[4, 0], abc def[4, 0], begin start[6, 0]
+Test 2, LTR:
+Move right by one word
+abc def[0, 4, 7], end ing[0, 4, 7], this is float[0, 5, 8, 13], this is fixed[5, 8, 13], this is relative[0, 5, 8, 16], this is absolute[0, 5, 8, 16]
+Move left by one word
+this is absolute[16, 8, 5, 0], this is relative[8, 5, 0], this is fixed[8, 5], this is float[8, 5, 0], end ing[4, 0], abc def[4, 0], begin start[6, 0]
+Test 3, LTR:
+Move right by one word
+end ing[0, 4, 7], this is float[0, 5, 8, 13], this is fixed[5, 8, 13], this is relative[0, 5, 8, 16], this is absolute[0, 5, 8, 16]
+Move left by one word
+this is absolute[16, 8, 5, 0], this is relative[8, 5, 0], this is fixed[8, 5], this is float[8, 5, 0], end ing[4, 0], abc def[4, 0], begin start[6, 0]
+Test 4, LTR:
+Move right by one word
+this is float[0, 5, 8, 13], this is fixed[5, 8, 13], this is relative[0, 5, 8, 16], this is absolute[0, 5, 8, 16]
+Move left by one word
+this is absolute[16, 8, 5, 0], this is relative[8, 5, 0], this is fixed[8, 5], this is float[8, 5, 0], end ing[4, 0], abc def[4, 0], begin start[6, 0]
+Test 5, LTR:
+Move right by one word
+this is fixed[0, 5, 8, 13], this is relative[0, 5, 8, 16], this is absolute[0, 5, 8, 16]
+Move left by one word
+this is absolute[16, 8, 5, 0], this is relative[8, 5, 0], this is fixed[8, 5], this is float[8, 5, 0], 

[webkit-changes] [98429] trunk/Source

[nduca]

Title: [98429] trunk/Source








Revision 98429
Author nd...@chromium.org
Date 2011-10-25 22:02:41 -0700 (Tue, 25 Oct 2011)


Log Message
[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
https://bugs.webkit.org/show_bug.cgi?id=70838

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::layerRendererContext):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::hasThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* public/WebLayerTreeView.h:
* src/WebCompositorImpl.cpp:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebLayerTreeView.h
trunk/Source/WebKit/chromium/src/WebCompositorImpl.cpp
trunk/Source/WebKit/chromium/src/WebLayerTreeView.cpp
trunk/Source/WebKit/chromium/src/WebLayerTreeViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (98428 => 98429)

--- trunk/Source/WebCore/ChangeLog	2011-10-26 04:57:39 UTC (rev 98428)
+++ trunk/Source/WebCore/ChangeLog	2011-10-26 05:02:41 UTC (rev 98429)
@@ -1,3 +1,29 @@
+2011-10-25  Nat Duca  nd...@chromium.org
+
+[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
+https://bugs.webkit.org/show_bug.cgi?id=70838
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::initialize):
+* platform/graphics/chromium/WebGLLayerChromium.cpp:
+(WebCore::WebGLLayerChromium::layerRendererContext):
+* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
+(WebCore::CCHeadsUpDisplay::enabled):
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::initialize):
+(WebCore::CCLayerTreeHost::context):
+(WebCore::CCLayerTreeHost::setNeedsAnimate):
+(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
+(WebCore::CCLayerTreeHost::setNeedsRedraw):
+(WebCore::CCLayerTreeHost::composite):
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+(WebCore::CCSettings::CCSettings):
+* platform/graphics/chromium/cc/CCThreadProxy.cpp:
+(WebCore::CCThreadProxy::hasThread):
+* platform/graphics/chromium/cc/CCThreadProxy.h:
+
 2011-10-25  Xiaomei Ji  x...@chromium.org
 
 --webkit-visual-word does not work in multi-line


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (98428 => 98429)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2011-10-26 04:57:39 UTC (rev 98428)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2011-10-26 05:02:41 UTC (rev 98429)
@@ -190,7 +190,7 @@
 extensions-ensureEnabled(GL_CHROMIUM_map_sub);
 
 // Use the swapBuffers callback only with the threaded proxy.
-if (settings().enableCompositorThread)
+if (CCThreadProxy::hasThread())
 m_capabilities.usingSwapCompleteCallback = extensions-supports(GL_CHROMIUM_swapbuffers_complete_callback);
 if (m_capabilities.usingSwapCompleteCallback) {
 extensions-ensureEnabled(GL_CHROMIUM_swapbuffers_complete_callback);


Modified: trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp (98428 => 98429)

--- trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp	2011-10-26 04:57:39 UTC (rev 

[webkit-changes] [98430] trunk/LayoutTests

[xji]

Title: [98430] trunk/LayoutTests








Revision 98430
Author x...@chromium.org
Date 2011-10-25 22:17:48 -0700 (Tue, 25 Oct 2011)


Log Message
Disable editing/selection/move-by-word-visually-inline-block-positioned-element.html in QT after r98428.

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (98429 => 98430)

--- trunk/LayoutTests/ChangeLog	2011-10-26 05:02:41 UTC (rev 98429)
+++ trunk/LayoutTests/ChangeLog	2011-10-26 05:17:48 UTC (rev 98430)
@@ -1,5 +1,11 @@
 2011-10-25  Xiaomei Ji  x...@chromium.org
 
+Disable editing/selection/move-by-word-visually-inline-block-positioned-element.html in QT after r98428.
+
+* platform/qt/Skipped:
+
+2011-10-25  Xiaomei Ji  x...@chromium.org
+
 --webkit-visual-word does not work in multi-line
 https://bugs.webkit.org/show_bug.cgi?id=61344
 


Modified: trunk/LayoutTests/platform/qt/Skipped (98429 => 98430)

--- trunk/LayoutTests/platform/qt/Skipped	2011-10-26 05:02:41 UTC (rev 98429)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-10-26 05:17:48 UTC (rev 98430)
@@ -2096,6 +2096,7 @@
 editing/selection/move-by-word-visually-null-box.html
 editing/selection/move-by-word-visually-single-space-inline-element.html
 editing/selection/move-by-word-visually-single-space-one-element.html
+editing/selection/move-by-word-visually-inline-block-positioned-element.html
 
 # [Qt] New tests introduced in r84742 fail
 # https://bugs.webkit.org/show_bug.cgi?id=59334






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes