[webkit-changes] [99660] trunk/LayoutTests
Title: [99660] trunk/LayoutTests Revision 99660 Author yu...@chromium.org Date 2011-11-09 00:00:41 -0800 (Wed, 09 Nov 2011) Log Message [Chromium] Unreviewed, update test expectation of listbox-clip.html. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99659 => 99660) --- trunk/LayoutTests/ChangeLog 2011-11-09 07:58:49 UTC (rev 99659) +++ trunk/LayoutTests/ChangeLog 2011-11-09 08:00:41 UTC (rev 99660) @@ -1,5 +1,11 @@ 2011-11-08 Yuta Kitamura yu...@chromium.org +[Chromium] Unreviewed, update test expectation of listbox-clip.html. + +* platform/chromium/test_expectations.txt: + +2011-11-08 Yuta Kitamura yu...@chromium.org + [Chromium] Unreviewed, land correct expectations for Kusa-Makura-background-canvas.html. The background color of this test should be white, not transparent. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99659 => 99660) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 07:58:49 UTC (rev 99659) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 08:00:41 UTC (rev 99660) @@ -1969,7 +1969,7 @@ BUGCR42875 SKIP WONTFIX : sputnik = TEXT // Need rebaseline -BUGWK70765 WIN : fast/forms/listbox-clip.html = TEXT +BUGWK70765 WIN : fast/forms/listbox-clip.html = IMAGE+TEXT BUGWK38705 : http/tests/security/sandbox-inherit-to-initial-document-2.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99661] trunk/Source/WebKit/chromium
Title: [99661] trunk/Source/WebKit/chromium
Revision 99661
Author jcive...@chromium.org
Date 2011-11-09 00:06:11 -0800 (Wed, 09 Nov 2011)
Log Message
Fixes and reenables the WebPageSerializer tests.
https://bugs.webkit.org/show_bug.cgi?id=71874
Reviewed by Adam Barth.
* WebKit.gypi:
* tests/WebPageNewSerializerTest.cpp:
(WebKit::TestWebFrameClient::~TestWebFrameClient):
(WebKit::WebPageNewSerializeTest::SetUp):
(WebKit::WebPageNewSerializeTest::resourceVectorContains):
(WebKit::TEST_F):
* tests/WebPageSerializerTest.cpp:
(WebKit::WebPageSerializerTest::WebPageSerializerTest):
(WebKit::WebPageSerializerTest::webVectorContains):
(WebKit::TEST_F):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
trunk/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp
trunk/Source/WebKit/chromium/tests/WebPageSerializerTest.cpp
Added Paths
trunk/Source/WebKit/chromium/tests/data/pageserializer/blue_background.png
trunk/Source/WebKit/chromium/tests/data/pageserializer/green_background.png
trunk/Source/WebKit/chromium/tests/data/pageserializer/ol-dot.png
trunk/Source/WebKit/chromium/tests/data/pageserializer/orange_background.png
trunk/Source/WebKit/chromium/tests/data/pageserializer/purple_background.png
trunk/Source/WebKit/chromium/tests/data/pageserializer/red_background.png
trunk/Source/WebKit/chromium/tests/data/pageserializer/ul-dot.png
trunk/Source/WebKit/chromium/tests/data/pageserializer/yellow_background.png
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (99660 => 99661)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-09 08:00:41 UTC (rev 99660)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-09 08:06:11 UTC (rev 99661)
@@ -1,3 +1,21 @@
+2011-11-08 Jay Civelli jcive...@chromium.org
+
+Fixes and reenables the WebPageSerializer tests.
+https://bugs.webkit.org/show_bug.cgi?id=71874
+
+Reviewed by Adam Barth.
+
+* WebKit.gypi:
+* tests/WebPageNewSerializerTest.cpp:
+(WebKit::TestWebFrameClient::~TestWebFrameClient):
+(WebKit::WebPageNewSerializeTest::SetUp):
+(WebKit::WebPageNewSerializeTest::resourceVectorContains):
+(WebKit::TEST_F):
+* tests/WebPageSerializerTest.cpp:
+(WebKit::WebPageSerializerTest::WebPageSerializerTest):
+(WebKit::WebPageSerializerTest::webVectorContains):
+(WebKit::TEST_F):
+
2011-11-07 Adam Barth aba...@webkit.org
Move static policy state from SecurityOrigin.cpp to SecurityPolicy.cpp
Modified: trunk/Source/WebKit/chromium/WebKit.gypi (99660 => 99661)
--- trunk/Source/WebKit/chromium/WebKit.gypi 2011-11-09 08:00:41 UTC (rev 99660)
+++ trunk/Source/WebKit/chromium/WebKit.gypi 2011-11-09 08:06:11 UTC (rev 99661)
@@ -88,6 +88,8 @@
'tests/WebCompositorImplTest.cpp',
'tests/WebFrameTest.cpp',
'tests/WebLayerTest.cpp',
+'tests/WebPageNewSerializerTest.cpp',
+'tests/WebPageSerializerTest.cpp',
'tests/WebURLRequestTest.cpp',
'tests/WebViewTest.cpp',
],
Modified: trunk/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp (99660 => 99661)
--- trunk/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp 2011-11-09 08:00:41 UTC (rev 99660)
+++ trunk/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp 2011-11-09 08:06:11 UTC (rev 99661)
@@ -51,9 +51,7 @@
class TestWebFrameClient : public WebFrameClient {
public:
-TestWebFrameClient() : m_scriptEnabled(false) { }
-virtual bool allowScript(WebFrame*, bool /* enabledPerSettings */) { return m_scriptEnabled; }
-bool m_scriptEnabled;
+virtual ~TestWebFrameClient() { }
};
class WebPageNewSerializeTest : public testing::Test {
@@ -72,10 +70,11 @@
// Create and initialize the WebView.
m_webView = WebView::create(0);
-// We want the images to load.
+// We want the images to load and _javascript_ to be on.
WebSettings* settings = m_webView-settings();
settings-setImagesEnabled(true);
settings-setLoadsImagesAutomatically(true);
+settings-setJavaScriptEnabled(true);
m_webView-initializeMainFrame(m_webFrameClient);
}
@@ -112,22 +111,12 @@
webkit_support::ServeAsynchronousMockedRequests();
}
-void enableJS()
-{
-m_webFrameClient.m_scriptEnabled = true;
-}
-
-void runOnLoad()
-{
-m_webView-mainFrame()-executeScript(WebScriptSource(WebString::fromUTF8(onLoad(;
-}
-
const WebString htmlMimeType() const { return m_htmlMimeType; }
const WebString xhtmlMimeType() const { return m_xhtmlMimeType; }
const WebString cssMimeType() const { return m_cssMimeType; }
const WebString pngMimeType() const { return m_pngMimeType; }
-
-static bool resourceVectorContains(const WebVectorWebPageSerializer::Resource resources, char* url, char* mimeType)
+
+static bool
[webkit-changes] [99662] trunk/Source/WebCore
Title: [99662] trunk/Source/WebCore Revision 99662 Author hausm...@webkit.org Date 2011-11-09 00:19:23 -0800 (Wed, 09 Nov 2011) Log Message Prospective build fix for Windows: Include MainThread.h for ASSERT(isMainThread()) to compile. * page/SecurityPolicy.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/SecurityPolicy.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (99661 => 99662) --- trunk/Source/WebCore/ChangeLog 2011-11-09 08:06:11 UTC (rev 99661) +++ trunk/Source/WebCore/ChangeLog 2011-11-09 08:19:23 UTC (rev 99662) @@ -1,3 +1,10 @@ +2011-11-09 Simon Hausmann simon.hausm...@nokia.com + +Prospective build fix for Windows: Include MainThread.h for ASSERT(isMainThread()) +to compile. + +* page/SecurityPolicy.cpp: + 2011-11-07 Adam Barth aba...@webkit.org Move static policy state from SecurityOrigin.cpp to SecurityPolicy.cpp Modified: trunk/Source/WebCore/page/SecurityPolicy.cpp (99661 => 99662) --- trunk/Source/WebCore/page/SecurityPolicy.cpp 2011-11-09 08:06:11 UTC (rev 99661) +++ trunk/Source/WebCore/page/SecurityPolicy.cpp 2011-11-09 08:19:23 UTC (rev 99662) @@ -30,6 +30,7 @@ #include SecurityPolicy.h #include KURL.h +#include MainThread.h #include OriginAccessEntry.h #include SecurityOrigin.h #include wtf/text/StringHash.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99663] trunk/Source/WebCore
Title: [99663] trunk/Source/WebCore Revision 99663 Author hausm...@webkit.org Date 2011-11-09 00:29:27 -0800 (Wed, 09 Nov 2011) Log Message Mac Build fix part 2: Oops, use the correct wtf/ prefix for the WTF include. * page/SecurityPolicy.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/SecurityPolicy.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (99662 => 99663) --- trunk/Source/WebCore/ChangeLog 2011-11-09 08:19:23 UTC (rev 99662) +++ trunk/Source/WebCore/ChangeLog 2011-11-09 08:29:27 UTC (rev 99663) @@ -1,5 +1,11 @@ 2011-11-09 Simon Hausmann simon.hausm...@nokia.com +Mac Build fix part 2: Oops, use the correct wtf/ prefix for the WTF include. + +* page/SecurityPolicy.cpp: + +2011-11-09 Simon Hausmann simon.hausm...@nokia.com + Prospective build fix for Windows: Include MainThread.h for ASSERT(isMainThread()) to compile. Modified: trunk/Source/WebCore/page/SecurityPolicy.cpp (99662 => 99663) --- trunk/Source/WebCore/page/SecurityPolicy.cpp 2011-11-09 08:19:23 UTC (rev 99662) +++ trunk/Source/WebCore/page/SecurityPolicy.cpp 2011-11-09 08:29:27 UTC (rev 99663) @@ -30,7 +30,7 @@ #include SecurityPolicy.h #include KURL.h -#include MainThread.h +#include wtf/MainThread.h #include OriginAccessEntry.h #include SecurityOrigin.h #include wtf/text/StringHash.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99664] trunk/Source
Title: [99664] trunk/Source Revision 99664 Author hausm...@webkit.org Date 2011-11-09 00:42:44 -0800 (Wed, 09 Nov 2011) Log Message [Qt] Replace use of QApplication with QGuiApplication https://bugs.webkit.org/show_bug.cgi?id=71794 Reviewed by Andreas Kling. Source/_javascript_Core: Add compat headers for use when building with Qt 4: QGuiApplication is typedef'ed to QApplication. * wtf/qt/compat/QGuiApplication: Added. * wtf/qt/compat/qguiapplication.h: Added. Source/WebCore: * Target.pri: Add compat include dir when compiling with Qt 4. * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: (FullScreenVideoWindow::closeEvent): Replace use of QApplication with QGuiApplication. (FullScreenVideoWindow::hideCursor): Ditto. (FullScreenVideoWindow::showCursor): Ditto. * platform/graphics/qt/TileQt.cpp: Remove unnecessary inclusion of QApplication. * platform/qt/ClipboardQt.cpp: Replace use of QApplication with QGuiApplication. (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::writePlainText): * platform/qt/PasteboardQt.cpp: Ditto. (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): Source/WebKit/qt: * WebCoreSupport/QtWebComboBox.cpp: (WebCore::QtWebComboBox::showPopupAtCursorPosition): Replace use of QApplication with QCoreApplication. Source/WebKit2: * Platform/CoreIPC/unix/ConnectionUnix.cpp: Remove unnecessary QApplication inclusion. * Platform/qt/RunLoopQt.cpp: Replace QApplication include with QCoreApplication. * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Ditto. * UIProcess/Launcher/qt/ThreadLauncherQt.cpp: Remove unnecessary QApplication inclusion. * UIProcess/qt/QtWebPageProxy.cpp: (QtWebPageProxy::handleMousePressEvent): Replace QApplication usage with QStyleHints. (QtWebPageProxy::handleMouseDoubleClickEvent): Ditto. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Target.pri trunk/Source/WebCore/platform/graphics/gstreamer/PlatformVideoWindowQt.cpp trunk/Source/WebCore/platform/graphics/qt/TileQt.cpp trunk/Source/WebCore/platform/qt/ClipboardQt.cpp trunk/Source/WebCore/platform/qt/PasteboardQt.cpp trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/WebCoreSupport/QtWebComboBox.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp trunk/Source/WebKit2/Platform/qt/RunLoopQt.cpp trunk/Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp trunk/Source/WebKit2/UIProcess/Launcher/qt/ThreadLauncherQt.cpp trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp Added Paths trunk/Source/_javascript_Core/wtf/qt/compat/ trunk/Source/_javascript_Core/wtf/qt/compat/QGuiApplication trunk/Source/_javascript_Core/wtf/qt/compat/qguiapplication.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (99663 => 99664) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 08:29:27 UTC (rev 99663) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 08:42:44 UTC (rev 99664) @@ -1,3 +1,16 @@ +2011-11-08 Simon Hausmann simon.hausm...@nokia.com + +[Qt] Replace use of QApplication with QGuiApplication +https://bugs.webkit.org/show_bug.cgi?id=71794 + +Reviewed by Andreas Kling. + +Add compat headers for use when building with Qt 4: QGuiApplication +is typedef'ed to QApplication. + +* wtf/qt/compat/QGuiApplication: Added. +* wtf/qt/compat/qguiapplication.h: Added. + 2011-11-08 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r99647. Added: trunk/Source/_javascript_Core/wtf/qt/compat/QGuiApplication (0 => 99664) --- trunk/Source/_javascript_Core/wtf/qt/compat/QGuiApplication (rev 0) +++ trunk/Source/_javascript_Core/wtf/qt/compat/QGuiApplication 2011-11-09 08:42:44 UTC (rev 99664) @@ -0,0 +1 @@ +#include qguiapplication.h Added: trunk/Source/_javascript_Core/wtf/qt/compat/qguiapplication.h (0 => 99664) --- trunk/Source/_javascript_Core/wtf/qt/compat/qguiapplication.h (rev 0) +++ trunk/Source/_javascript_Core/wtf/qt/compat/qguiapplication.h 2011-11-09 08:42:44 UTC (rev 99664) @@ -0,0 +1,27 @@ +/* +Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies) + +This library is free software; you can redistribute it and/or +modify it under the terms of the GNU Library General Public +License as published by the Free Software Foundation; either +version 2 of the License, or (at your option) any later version. + +This library is distributed in the hope that it will be useful, +but
[webkit-changes] [99667] trunk
Title: [99667] trunk
Revision 99667
Author commit-qu...@webkit.org
Date 2011-11-09 00:56:36 -0800 (Wed, 09 Nov 2011)
Log Message
Select multiple options with mouse drag in Select element.
https://bugs.webkit.org/show_bug.cgi?id=71128
Patch by Rakesh KN rakesh...@motorola.com on 2011-11-09
Reviewed by Ryosuke Niwa.
Multiple selection of option elements in select element with an mouse drag.
Other browsers(IE, Firefox, Opera) support this feature.
Source/WebCore:
Test: fast/forms/select-multiple-elements-with-mouse-drag.html
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
Allow auto scroll to be fired if current node(option) under mouse does not have renderer
but its container node(select) can autoscroll and has renderer for specific case of ListBox
LayoutTests:
* fast/forms/select-multiple-elements-with-mouse-drag-expected.txt: Added.
* fast/forms/select-multiple-elements-with-mouse-drag.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
Added Paths
trunk/LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag-expected.txt
trunk/LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99666 => 99667)
--- trunk/LayoutTests/ChangeLog 2011-11-09 08:52:43 UTC (rev 99666)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 08:56:36 UTC (rev 99667)
@@ -1,3 +1,16 @@
+2011-11-09 Rakesh KN rakesh...@motorola.com
+
+Select multiple options with mouse drag in Select element.
+https://bugs.webkit.org/show_bug.cgi?id=71128
+
+Reviewed by Ryosuke Niwa.
+
+Multiple selection of option elements in select element with an mouse drag.
+Other browsers(IE, Firefox, Opera) support this feature.
+
+* fast/forms/select-multiple-elements-with-mouse-drag-expected.txt: Added.
+* fast/forms/select-multiple-elements-with-mouse-drag.html: Added.
+
2011-11-08 Yuta Kitamura yu...@chromium.org
[Chromium] Unreviewed, update test expectation of listbox-clip.html.
Added: trunk/LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag-expected.txt (0 => 99667)
--- trunk/LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag-expected.txt 2011-11-09 08:56:36 UTC (rev 99667)
@@ -0,0 +1,11 @@
+Select multiple option with mouse drag
+
+
+PASS document.getElementById(selectId).options[0].selected is true
+PASS document.getElementById(selectId).options[1].selected is true
+PASS document.getElementById(selectId).options[2].selected is true
+PASS document.getElementById(selectId).options[3].selected is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag.html (0 => 99667)
--- trunk/LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag.html (rev 0)
+++ trunk/LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag.html 2011-11-09 08:56:36 UTC (rev 99667)
@@ -0,0 +1,58 @@
+!DOCTYPE html
+html
+head
+meta charset=utf-8
+script src=""
+script
+window.jsTestIsAsync = true;
+
+function test() {
+if (window.eventSender) {
+var selectObject = document.getElementById(selectId);
+
+var optionHeight = selectObject.offsetHeight / selectObject.size;
+var x = selectObject.offsetLeft + selectObject.offsetWidth / 2;
+var y = selectObject.offsetTop + optionHeight / 2;
+
+eventSender.dragMode = false;
+eventSender.mouseMoveTo(x, y);
+eventSender.mouseDown();
+eventSender.mouseMoveTo(x, y + (optionHeight * 3));
+
+setTimeout(testSelection, 100);
+} else {
+debug(Test manually if options are getting selected by dragging on the select element.);
+}
+}
+
+function testSelection()
+{
+eventSender.mouseUp();
+
+for (var i = 0; i 4; i++) {
+shouldBeTrue(document.getElementById(\selectId\).options[ + i + ].selected);
+}
+
+finishJSTest();
+}
+successfullyParsed = true;
+/script
+title/title
+/head
+body _onload_=test()
+pSelect multiple option with mouse drag/p
+
+select multiple=multiple size=4 id=selectId
+option value=P1P1/option
+option value=P2P2/option
+option value=P3P3/option
+option value=P4P4/option
+option value=P5P5/option
+option value=P6P6/option
+option value=P7P7/option
+/select
+
+div id=console/div
+script src=""
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (99666 => 99667)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 08:52:43 UTC (rev 99666)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 08:56:36 UTC (rev 99667)
@@ -1,3 +1,20 @@
+2011-11-09 Rakesh KN rakesh...@motorola.com
+
+Select multiple options with mouse drag in Select element.
+
[webkit-changes] [99665] trunk/Source/WebCore
Title: [99665] trunk/Source/WebCore
Revision 99665
Author mr...@apple.com
Date 2011-11-09 00:51:00 -0800 (Wed, 09 Nov 2011)
Log Message
Fix the build.
* WebCore.exp.in: Export the right symbol names.
* WebCore.xcodeproj/project.pbxproj: Make the header file available outside of WebCore.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (99664 => 99665)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 08:42:44 UTC (rev 99664)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 08:51:00 UTC (rev 99665)
@@ -1,3 +1,10 @@
+2011-11-09 Mark Rowe mr...@apple.com
+
+Fix the build.
+
+* WebCore.exp.in: Export the right symbol names.
+* WebCore.xcodeproj/project.pbxproj: Make the header file available outside of WebCore.
+
2011-11-08 Simon Hausmann simon.hausm...@nokia.com
[Qt] Replace use of QApplication with QGuiApplication
Modified: trunk/Source/WebCore/WebCore.exp.in (99664 => 99665)
--- trunk/Source/WebCore/WebCore.exp.in 2011-11-09 08:42:44 UTC (rev 99664)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-11-09 08:51:00 UTC (rev 99665)
@@ -391,8 +391,8 @@
__ZN7WebCore14SecurityPolicy18setLocalLoadPolicyENS0_15LocalLoadPolicyE
__ZN7WebCore14SecurityPolicy18shouldHideReferrerERKNS_4KURLERKN3WTF6StringE
__ZN7WebCore14SecurityPolicy27resetOriginAccessWhitelistsEv
-__ZN7WebCore14SecurityPolicy29addOriginAccessWhitelistEntryERKS0_RKN3WTF6StringES6_b
-__ZN7WebCore14SecurityPolicy32removeOriginAccessWhitelistEntryERKS0_RKN3WTF6StringES6_b
+__ZN7WebCore14SecurityPolicy29addOriginAccessWhitelistEntryERKNS_14SecurityOriginERKN3WTF6StringES7_b
+__ZN7WebCore14SecurityPolicy32removeOriginAccessWhitelistEntryERKNS_14SecurityOriginERKN3WTF6StringES7_b
__ZN7WebCore14StorageTracker7originsERN3WTF6VectorINS1_6RefPtrINS_14SecurityOriginEEELm0EEE
__ZN7WebCore14StorageTracker7trackerEv
__ZN7WebCore14StorageTracker9setClientEPNS_20StorageTrackerClientE
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (99664 => 99665)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-11-09 08:42:44 UTC (rev 99664)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-11-09 08:51:00 UTC (rev 99665)
@@ -3216,7 +3216,7 @@
973E325610883B7C005BC493 /* ResourceLoadNotifier.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 973E325410883B7C005BC493 /* ResourceLoadNotifier.cpp */; };
973E325710883B7C005BC493 /* ResourceLoadNotifier.h in Headers */ = {isa = PBXBuildFile; fileRef = 973E325510883B7C005BC493 /* ResourceLoadNotifier.h */; settings = {ATTRIBUTES = (Private, ); }; };
974D2DA4146A535D00D51F8B /* SecurityPolicy.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 974D2DA2146A535D00D51F8B /* SecurityPolicy.cpp */; };
- 974D2DA5146A535D00D51F8B /* SecurityPolicy.h in Headers */ = {isa = PBXBuildFile; fileRef = 974D2DA3146A535D00D51F8B /* SecurityPolicy.h */; };
+ 974D2DA5146A535D00D51F8B /* SecurityPolicy.h in Headers */ = {isa = PBXBuildFile; fileRef = 974D2DA3146A535D00D51F8B /* SecurityPolicy.h */; settings = {ATTRIBUTES = (Private, ); }; };
9752D38D1413104B003305BD /* JSHTMLSpanElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9752D38B1413104B003305BD /* JSHTMLSpanElement.cpp */; };
9752D38E1413104B003305BD /* JSHTMLSpanElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 9752D38C1413104B003305BD /* JSHTMLSpanElement.h */; };
975CA28A130365F800E99AD9 /* Crypto.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 975CA287130365F800E99AD9 /* Crypto.cpp */; };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99666] trunk
Title: [99666] trunk
Revision 99666
Author hausm...@webkit.org
Date 2011-11-09 00:52:43 -0800 (Wed, 09 Nov 2011)
Log Message
[Qt] Build system cleanup
https://bugs.webkit.org/show_bug.cgi?id=71815
Reviewed by Kenneth Rohde Christiansen.
Source/_javascript_Core:
* wtf/wtf.pri: Moved the glib dependency to _javascript_core.prf.
Source/WebCore:
* Target.pri: Removed CodeGenHSL.cpp from the angle build. In the angle build the back-end has to
be either GLSL or HSL, it can't be both. Make a choice for GLSL as that's what it seems to be used for
at the moment.
Source/WebKit2:
* Target.pri: Removed duplicated sources that are compiled also into QtWebKit.so through api.pri.
* UIProcess/qt/WebGeolocationProviderQt.cpp: Include the moc file here, as it should only be compiled
if geolocation is enabled.
* UIProcess/qt/WebGeolocationProviderQt.h: Provide ENABLE(GEOLOCATION) guards around class definition.
Tools:
* WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
static library.
* qmake/mkspecs/features/_javascript_core.prf: The wtf sources pull in a glib dependency
(ownPtr functions for glib types). Propagate that to everyone using _javascript_core.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/wtf.pri
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/qt/WebGeolocationProviderQt.cpp
trunk/Source/WebKit2/UIProcess/qt/WebGeolocationProviderQt.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Target.pri
trunk/Tools/qmake/mkspecs/features/_javascript_core.prf
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99665 => 99666)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 08:51:00 UTC (rev 99665)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 08:52:43 UTC (rev 99666)
@@ -1,3 +1,12 @@
+2011-11-09 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Build system cleanup
+https://bugs.webkit.org/show_bug.cgi?id=71815
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* wtf/wtf.pri: Moved the glib dependency to _javascript_core.prf.
+
2011-11-08 Simon Hausmann simon.hausm...@nokia.com
[Qt] Replace use of QApplication with QGuiApplication
Modified: trunk/Source/_javascript_Core/wtf/wtf.pri (99665 => 99666)
--- trunk/Source/_javascript_Core/wtf/wtf.pri 2011-11-09 08:51:00 UTC (rev 99665)
+++ trunk/Source/_javascript_Core/wtf/wtf.pri 2011-11-09 08:52:43 UTC (rev 99666)
@@ -189,14 +189,5 @@
wtf/unicode/icu/CollatorICU.cpp \
wtf/unicode/UTF8.cpp
-linux-*:!contains(DEFINES, USE_QTMULTIMEDIA=1) {
-!contains(QT_CONFIG, no-pkg-config):system(pkg-config --exists glib-2.0 gio-2.0 gstreamer-0.10): {
-DEFINES += ENABLE_GLIB_SUPPORT=1
-PKGCONFIG += glib-2.0 gio-2.0
-
-HEADERS += wtf/gobject/GOwnPtr.h
-}
-}
-
unix: SOURCES += wtf/OSAllocatorPosix.cpp
win*|wince*: SOURCES += wtf/OSAllocatorWin.cpp
Modified: trunk/Source/WebCore/ChangeLog (99665 => 99666)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 08:51:00 UTC (rev 99665)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 08:52:43 UTC (rev 99666)
@@ -1,3 +1,14 @@
+2011-11-09 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Build system cleanup
+https://bugs.webkit.org/show_bug.cgi?id=71815
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* Target.pri: Removed CodeGenHSL.cpp from the angle build. In the angle build the back-end has to
+be either GLSL or HSL, it can't be both. Make a choice for GLSL as that's what it seems to be used for
+at the moment.
+
2011-11-09 Mark Rowe mr...@apple.com
Fix the build.
Modified: trunk/Source/WebCore/Target.pri (99665 => 99666)
--- trunk/Source/WebCore/Target.pri 2011-11-09 08:51:00 UTC (rev 99665)
+++ trunk/Source/WebCore/Target.pri 2011-11-09 08:52:43 UTC (rev 99666)
@@ -3741,7 +3741,6 @@
ANGLE_SOURCES += \
$$ANGLE_DIR/src/compiler/CodeGenGLSL.cpp \
-$$ANGLE_DIR/src/compiler/CodeGenHLSL.cpp \
$$ANGLE_DIR/src/compiler/Compiler.cpp \
$$ANGLE_DIR/src/compiler/debug.cpp \
$$ANGLE_DIR/src/compiler/ForLoopUnroll.cpp \
Modified: trunk/Source/WebKit2/ChangeLog (99665 => 99666)
--- trunk/Source/WebKit2/ChangeLog 2011-11-09 08:51:00 UTC (rev 99665)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-09 08:52:43 UTC (rev 99666)
@@ -1,3 +1,15 @@
+2011-11-09 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Build system cleanup
+https://bugs.webkit.org/show_bug.cgi?id=71815
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* Target.pri: Removed duplicated sources that are compiled also into QtWebKit.so through api.pri.
+* UIProcess/qt/WebGeolocationProviderQt.cpp: Include the moc file here, as it should only be compiled
+if geolocation is enabled.
+*
[webkit-changes] [99668] trunk/LayoutTests
Title: [99668] trunk/LayoutTests Revision 99668 Author yu...@chromium.org Date 2011-11-09 01:14:10 -0800 (Wed, 09 Nov 2011) Log Message [Chromium] Rebaseline tests added in r99613. Check in correct baselines for the Mac Skia bots. * platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed. * platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed. * platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-lr-expected.png: Removed. * platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-rl-expected.png: Removed. * platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed. * platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed. * platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-lr-expected.png: Removed. * platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-rl-expected.png: Removed. * platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed. * platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed. * platform/chromium-win-vista/fast/multicol/pagination-h-vertical-lr-expected.png: Removed. * platform/chromium-win-vista/fast/multicol/pagination-h-vertical-rl-expected.png: Removed. * platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed. * platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed. * platform/chromium-win-vista/fast/multicol/pagination-v-vertical-lr-expected.png: Removed. * platform/chromium-win-vista/fast/multicol/pagination-v-vertical-rl-expected.png: Removed. * platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-bt-expected.png: Removed. * platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-tb-expected.png: Removed. * platform/chromium-win-xp/fast/multicol/pagination-h-vertical-lr-expected.png: Removed. * platform/chromium-win-xp/fast/multicol/pagination-h-vertical-rl-expected.png: Removed. * platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-bt-expected.png: Removed. * platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-tb-expected.png: Removed. * platform/chromium-win-xp/fast/multicol/pagination-v-vertical-lr-expected.png: Removed. * platform/chromium-win-xp/fast/multicol/pagination-v-vertical-rl-expected.png: Removed. * platform/chromium/fast/multicol/pagination-h-horizontal-bt-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png. * platform/chromium/fast/multicol/pagination-h-horizontal-tb-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png. * platform/chromium/fast/multicol/pagination-h-vertical-lr-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png. * platform/chromium/fast/multicol/pagination-h-vertical-rl-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png. * platform/chromium/fast/multicol/pagination-v-horizontal-bt-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png. * platform/chromium/fast/multicol/pagination-v-horizontal-tb-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png. * platform/chromium/fast/multicol/pagination-v-vertical-lr-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png. * platform/chromium/fast/multicol/pagination-v-vertical-rl-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium/fast/multicol/pagination-h-horizontal-bt-expected.png trunk/LayoutTests/platform/chromium/fast/multicol/pagination-h-horizontal-tb-expected.png trunk/LayoutTests/platform/chromium/fast/multicol/pagination-h-vertical-lr-expected.png trunk/LayoutTests/platform/chromium/fast/multicol/pagination-h-vertical-rl-expected.png trunk/LayoutTests/platform/chromium/fast/multicol/pagination-v-horizontal-bt-expected.png trunk/LayoutTests/platform/chromium/fast/multicol/pagination-v-horizontal-tb-expected.png trunk/LayoutTests/platform/chromium/fast/multicol/pagination-v-vertical-lr-expected.png trunk/LayoutTests/platform/chromium/fast/multicol/pagination-v-vertical-rl-expected.png Removed Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png
[webkit-changes] [99669] trunk/Source/WebCore
Title: [99669] trunk/Source/WebCore
Revision 99669
Author zimmerm...@webkit.org
Date 2011-11-09 01:15:48 -0800 (Wed, 09 Nov 2011)
Log Message
2011-11-09 Nikolas Zimmermann nzimmerm...@rim.com
svg failures after r99561
https://bugs.webkit.org/show_bug.cgi?id=71830
Reviewed by Antti Koivisto.
Fix regressions in svg/zoom/page/relative-sized-document-scrollbars.svg and svg/zoom/page/zoom-svg-as-relative-image.html.
Fix merging problem in r99561, bug 71780. It moved several methods from SVGLength to SVGLengthContext, and unfortunately
the SVGLength changes part of r98852, bug 47156, got reverted again, making these two tests fail.
* svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::determineViewport):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGLengthContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99668 => 99669)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 09:14:10 UTC (rev 99668)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 09:15:48 UTC (rev 99669)
@@ -1,3 +1,17 @@
+2011-11-09 Nikolas Zimmermann nzimmerm...@rim.com
+
+svg failures after r99561
+https://bugs.webkit.org/show_bug.cgi?id=71830
+
+Reviewed by Antti Koivisto.
+
+Fix regressions in svg/zoom/page/relative-sized-document-scrollbars.svg and svg/zoom/page/zoom-svg-as-relative-image.html.
+Fix merging problem in r99561, bug 71780. It moved several methods from SVGLength to SVGLengthContext, and unfortunately
+the SVGLength changes part of r98852, bug 47156, got reverted again, making these two tests fail.
+
+* svg/SVGLengthContext.cpp:
+(WebCore::SVGLengthContext::determineViewport):
+
2011-11-09 Rakesh KN rakesh...@motorola.com
Select multiple options with mouse drag in Select element.
Modified: trunk/Source/WebCore/svg/SVGLengthContext.cpp (99668 => 99669)
--- trunk/Source/WebCore/svg/SVGLengthContext.cpp 2011-11-09 09:14:10 UTC (rev 99668)
+++ trunk/Source/WebCore/svg/SVGLengthContext.cpp 2011-11-09 09:15:48 UTC (rev 99669)
@@ -282,6 +282,7 @@
if (!frame)
return false;
+// SVGs embedded through object resolve percentage values against the owner renderer in the host document.
if (RenderPart* ownerRenderer = frame-ownerRenderer()) {
width = ownerRenderer-width();
height = ownerRenderer-height();
@@ -293,8 +294,14 @@
if (!view)
return false;
+// Always resolve percentages against the unscaled viewport, as agreed across browsers.
+float zoom = view-style()-effectiveZoom();
width = view-viewWidth();
height = view-viewHeight();
+if (zoom != 1) {
+width /= zoom;
+height /= zoom;
+}
return true;
}
@@ -302,12 +309,13 @@
SVGElement* viewportElement = m_context-viewportElement();
if (viewportElement viewportElement-isSVG()) {
const SVGSVGElement* svg = static_castconst SVGSVGElement*(viewportElement);
-if (svg-hasAttribute(SVGNames::viewBoxAttr)) {
-width = svg-viewBox().width();
-height = svg-viewBox().height();
-} else {
+FloatRect viewBox = svg-currentViewBoxRect();
+if (viewBox.isEmpty()) {
width = svg-width().value(svg);
height = svg-height().value(svg);
+} else {
+width = viewBox.width();
+height = viewBox.height();
}
return true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99670] trunk/LayoutTests
Title: [99670] trunk/LayoutTests Revision 99670 Author yu...@chromium.org Date 2011-11-09 01:25:30 -0800 (Wed, 09 Nov 2011) Log Message [Chromium] Unreviewed, update test expectation for listbox-clip.html on Mac. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99669 => 99670) --- trunk/LayoutTests/ChangeLog 2011-11-09 09:15:48 UTC (rev 99669) +++ trunk/LayoutTests/ChangeLog 2011-11-09 09:25:30 UTC (rev 99670) @@ -1,5 +1,11 @@ 2011-11-09 Yuta Kitamura yu...@chromium.org +[Chromium] Unreviewed, update test expectation for listbox-clip.html on Mac. + +* platform/chromium/test_expectations.txt: + +2011-11-09 Yuta Kitamura yu...@chromium.org + [Chromium] Rebaseline tests added in r99613. Check in correct baselines for the Mac Skia bots. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99669 => 99670) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 09:15:48 UTC (rev 99669) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 09:25:30 UTC (rev 99670) @@ -1372,9 +1372,10 @@ BUGCR23477 MAC : fast/dynamic/containing-block-change.html = IMAGE // Unexpected gray -BUGCR23476 MAC : fast/forms/listbox-clip.html = IMAGE BUGCR23476 MAC : fast/frames/inline-object-inside-frameset.html = IMAGE BUGCR23476 MAC : fast/text/font-initial.html = IMAGE +// Expectation changed at r99653 (IMAGE - IMAGE+TEXT). +BUGCR23476 BUGWK70765 MAC : fast/forms/listbox-clip.html = IMAGE+TEXT // Disagreeing XML parsing error messages BUGCR88911 LEOPARD : fast/parser/xhtml-alternate-entities.xml = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99671] trunk/LayoutTests
Title: [99671] trunk/LayoutTests
Revision 99671
Author rga...@webkit.org
Date 2011-11-09 01:42:03 -0800 (Wed, 09 Nov 2011)
Log Message
[Qt] Unreviewed. Update fast/forms/listbox-clip.html expected.
* platform/qt/fast/forms/listbox-clip-expected.png:
* platform/qt/fast/forms/listbox-clip-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.png
trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (99670 => 99671)
--- trunk/LayoutTests/ChangeLog 2011-11-09 09:25:30 UTC (rev 99670)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 09:42:03 UTC (rev 99671)
@@ -1,3 +1,10 @@
+2011-11-09 Gabor Rapcsanyi rga...@webkit.org
+
+[Qt] Unreviewed. Update fast/forms/listbox-clip.html expected.
+
+* platform/qt/fast/forms/listbox-clip-expected.png:
+* platform/qt/fast/forms/listbox-clip-expected.txt:
+
2011-11-09 Yuta Kitamura yu...@chromium.org
[Chromium] Unreviewed, update test expectation for listbox-clip.html on Mac.
Modified: trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.txt (99670 => 99671)
--- trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.txt 2011-11-09 09:25:30 UTC (rev 99670)
+++ trunk/LayoutTests/platform/qt/fast/forms/listbox-clip-expected.txt 2011-11-09 09:42:03 UTC (rev 99671)
@@ -3,6 +3,6 @@
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
- RenderListBox {SELECT} at (0,2) size 100x106 [bgcolor=#FF] [border: (1px inset #808080)]
+ RenderListBox {SELECT} at (0,2) size 100x85 [bgcolor=#FF] [border: (1px inset #808080)]
RenderText {#text} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99672] trunk/LayoutTests
Title: [99672] trunk/LayoutTests Revision 99672 Author yu...@chromium.org Date 2011-11-09 01:50:01 -0800 (Wed, 09 Nov 2011) Log Message [Chromium] Unreviewed, mark select-clientheight-large-size.html as TIMEOUT. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99671 => 99672) --- trunk/LayoutTests/ChangeLog 2011-11-09 09:42:03 UTC (rev 99671) +++ trunk/LayoutTests/ChangeLog 2011-11-09 09:50:01 UTC (rev 99672) @@ -1,3 +1,9 @@ +2011-11-09 Yuta Kitamura yu...@chromium.org + +[Chromium] Unreviewed, mark select-clientheight-large-size.html as TIMEOUT. + +* platform/chromium/test_expectations.txt: + 2011-11-09 Gabor Rapcsanyi rga...@webkit.org [Qt] Unreviewed. Update fast/forms/listbox-clip.html expected. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99671 => 99672) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 09:42:03 UTC (rev 99671) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 09:50:01 UTC (rev 99672) @@ -3953,3 +3953,5 @@ BUGRICOW : http/tests/security/xss-eval.html = TEXT BUGXJI : fast/dom/rtl-scroll-to-leftmost-and-resize.html = IMAGE+TEXT MISSING + +BUGWK71880 DEBUG : fast/forms/select-clientheight-large-size.html = TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99673] trunk/Source/WebCore
Title: [99673] trunk/Source/WebCore
Revision 99673
Author hara...@chromium.org
Date 2011-11-09 01:56:44 -0800 (Wed, 09 Nov 2011)
Log Message
Make [CanBeConstructed] IDL redundant
https://bugs.webkit.org/show_bug.cgi?id=71871
Reviewed by Adam Barth.
As the first step to remove [CanBeConstructed] IDL completely,
we need to make [CanBeConstructed] IDL redundant.
This patch replaces '[CanBeConstructed]' in CodeGeneratorV8.pm
with '[CanBeConstructed] or [Constructor] or [CustomConstructor] or [V8CustomConstructor]',
and replaces '[CanBeConstructed]' in CodeGeneratorJS.pm
with '[CanBeConstructed] or [Constructor] or [CustomConstructor] or [JSCustomConstructor]'
An example:
before: '[CanBeConstructed] and ![V8CustomConstructor]'
after: '([CanBeConstructed] or [Constructor] or [CustomConstructor] or [V8CustomConstructor]) and ![V8CustomConstructor]' == '([CanBeConstructed] or [Constructor] or [CustomConstructor]) and ![V8CustomConstructor]'
Tests: bindings/scripts/test/TestObj.idl
* bindings/scripts/CodeGeneratorJS.pm: Modified as I described above.
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Updated a run-bindings-tests result.
(WebCore::JSTestObjConstructor::constructJSTestObj):
(WebCore::JSTestObjConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestObj.h: Ditto.
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::V8TestObj::constructorCallback):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99672 => 99673)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 09:50:01 UTC (rev 99672)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 09:56:44 UTC (rev 99673)
@@ -1,3 +1,34 @@
+2011-11-09 Kentaro Hara hara...@chromium.org
+
+Make [CanBeConstructed] IDL redundant
+https://bugs.webkit.org/show_bug.cgi?id=71871
+
+Reviewed by Adam Barth.
+
+As the first step to remove [CanBeConstructed] IDL completely,
+we need to make [CanBeConstructed] IDL redundant.
+This patch replaces '[CanBeConstructed]' in CodeGeneratorV8.pm
+with '[CanBeConstructed] or [Constructor] or [CustomConstructor] or [V8CustomConstructor]',
+and replaces '[CanBeConstructed]' in CodeGeneratorJS.pm
+with '[CanBeConstructed] or [Constructor] or [CustomConstructor] or [JSCustomConstructor]'
+
+An example:
+before: '[CanBeConstructed] and ![V8CustomConstructor]'
+after: '([CanBeConstructed] or [Constructor] or [CustomConstructor] or [V8CustomConstructor]) and ![V8CustomConstructor]' == '([CanBeConstructed] or [Constructor] or [CustomConstructor]) and ![V8CustomConstructor]'
+
+Tests: bindings/scripts/test/TestObj.idl
+
+* bindings/scripts/CodeGeneratorJS.pm: Modified as I described above.
+(GenerateConstructorDeclaration):
+(GenerateConstructorDefinition):
+* bindings/scripts/CodeGeneratorV8.pm: Ditto.
+* bindings/scripts/test/JS/JSTestObj.cpp: Updated a run-bindings-tests result.
+(WebCore::JSTestObjConstructor::constructJSTestObj):
+(WebCore::JSTestObjConstructor::getConstructData):
+* bindings/scripts/test/JS/JSTestObj.h: Ditto.
+* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
+(WebCore::V8TestObj::constructorCallback):
+
2011-11-09 Nikolas Zimmermann nzimmerm...@rim.com
svg failures after r99561
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (99672 => 99673)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-09 09:50:01 UTC (rev 99672)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-09 09:56:44 UTC (rev 99673)
@@ -3188,7 +3188,7 @@
my $dataNode = shift;
my $constructorClassName = ${className}Constructor;
-my $canConstruct = $dataNode-extendedAttributes-{CanBeConstructed};
+my $canConstruct = $dataNode-extendedAttributes-{CanBeConstructed} || $dataNode-extendedAttributes-{Constructor} || $dataNode-extendedAttributes-{JSCustomConstructor} || $dataNode-extendedAttributes-{CustomConstructor};
my $callWith = $dataNode-extendedAttributes-{CallWith};
push(@$outputArray, class ${constructorClassName} : public DOMConstructorObject {\n);
@@ -3266,7 +3266,7 @@
push(@$outputArray, return getStaticValueDescriptor${constructorClassName}, JSDOMWrapper(exec, ${constructorClassName}Table, this, propertyName, descriptor);\n);
push(@$outputArray, }\n\n);
-if ($dataNode-extendedAttributes-{CanBeConstructed}) {
+if ($dataNode-extendedAttributes-{CanBeConstructed} ||
[webkit-changes] [99674] trunk/LayoutTests
Title: [99674] trunk/LayoutTests Revision 99674 Author yu...@chromium.org Date 2011-11-09 02:11:53 -0800 (Wed, 09 Nov 2011) Log Message [Chromium] Unreviewed, remove incorrect pixel image for relative-sized-document-scrollbars.svg. * platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Removed Paths trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (99673 => 99674) --- trunk/LayoutTests/ChangeLog 2011-11-09 09:56:44 UTC (rev 99673) +++ trunk/LayoutTests/ChangeLog 2011-11-09 10:11:53 UTC (rev 99674) @@ -1,5 +1,12 @@ 2011-11-09 Yuta Kitamura yu...@chromium.org +[Chromium] Unreviewed, remove incorrect pixel image for relative-sized-document-scrollbars.svg. + +* platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed. +* platform/chromium/test_expectations.txt: + +2011-11-09 Yuta Kitamura yu...@chromium.org + [Chromium] Unreviewed, mark select-clientheight-large-size.html as TIMEOUT. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99673 => 99674) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 09:56:44 UTC (rev 99673) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 10:11:53 UTC (rev 99674) @@ -3291,9 +3291,6 @@ BUGWK66320 SNOWLEOPARD RELEASE : svg/wicd/test-rightsizing-a.xhtml = PASS IMAGE+TEXT BUGWK66320 DEBUG : svg/wicd/test-rightsizing-a.xhtml = PASS IMAGE IMAGE+TEXT -// After r87526, these all have extra scrollbars where the platform/mac expectations do not. -BUGWK61664 LINUX : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE+TEXT - BUGABARTH LINUX : svg/text/scaling-font-with-geometric-precision.html = PASS IMAGE BUGCR84157 WIN GPU : fast/canvas/canvas-currentColor.html = TEXT Deleted: trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99686] trunk/Source/WebCore
Title: [99686] trunk/Source/WebCore
Revision 99686
Author vse...@chromium.org
Date 2011-11-09 03:58:02 -0800 (Wed, 09 Nov 2011)
Log Message
Web Inspector: ResourcesPanel should support adding subtitle to any BaseStorageTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=71848
Reviewed by Pavel Feldman.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.BaseStorageTreeElement.prototype.onattach):
(WebInspector.BaseStorageTreeElement.prototype.get displayName):
(WebInspector.BaseStorageTreeElement.prototype._updateDisplayName):
(WebInspector.BaseStorageTreeElement.prototype._updateTitle):
(WebInspector.BaseStorageTreeElement.prototype._updateSubtitle):
(WebInspector.BaseStorageTreeElement.prototype.set titleText):
(WebInspector.BaseStorageTreeElement.prototype.get subtitleText):
(WebInspector.BaseStorageTreeElement.prototype.set subtitleText):
(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.FrameTreeElement.prototype.get itemURL):
(WebInspector.FrameTreeElement.prototype.onselect):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99685 => 99686)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 11:56:05 UTC (rev 99685)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 11:58:02 UTC (rev 99686)
@@ -1,3 +1,23 @@
+2011-11-09 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: ResourcesPanel should support adding subtitle to any BaseStorageTreeElement.
+https://bugs.webkit.org/show_bug.cgi?id=71848
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ResourcesPanel.js:
+(WebInspector.BaseStorageTreeElement.prototype.onattach):
+(WebInspector.BaseStorageTreeElement.prototype.get displayName):
+(WebInspector.BaseStorageTreeElement.prototype._updateDisplayName):
+(WebInspector.BaseStorageTreeElement.prototype._updateTitle):
+(WebInspector.BaseStorageTreeElement.prototype._updateSubtitle):
+(WebInspector.BaseStorageTreeElement.prototype.set titleText):
+(WebInspector.BaseStorageTreeElement.prototype.get subtitleText):
+(WebInspector.BaseStorageTreeElement.prototype.set subtitleText):
+(WebInspector.FrameTreeElement.prototype.frameNavigated):
+(WebInspector.FrameTreeElement.prototype.get itemURL):
+(WebInspector.FrameTreeElement.prototype.onselect):
+
2011-11-08 Pavel Feldman pfeld...@google.com
Web Inspector: crash upon InspectorValue serialization that has 0 value / array entry.
Modified: trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js (99685 => 99686)
--- trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2011-11-09 11:56:05 UTC (rev 99685)
+++ trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2011-11-09 11:58:02 UTC (rev 99686)
@@ -866,10 +866,55 @@
this.titleElement = document.createElement(div);
this.titleElement.className = base-storage-tree-element-title;
-this.titleElement.textContent = this._titleText;
+this._titleTextNode = document.createTextNode();
+this.titleElement.appendChild(this._titleTextNode);
+this._updateTitle();
+this._updateSubtitle();
this.listItemElement.appendChild(this.titleElement);
},
+get displayName()
+{
+return this._displayName;
+},
+
+_updateDisplayName: function()
+{
+this._displayName = this._titleText || ;
+if (this._subtitleText)
+this._displayName += ( + this._subtitleText + );
+},
+
+_updateTitle: function()
+{
+this._updateDisplayName();
+
+if (!this.titleElement)
+return;
+
+this._titleTextNode.textContent = this._titleText || ;
+},
+
+_updateSubtitle: function()
+{
+this._updateDisplayName();
+
+if (!this.titleElement)
+return;
+
+if (this._subtitleText) {
+if (!this._subtitleElement) {
+this._subtitleElement = document.createElement(span);
+this._subtitleElement.className = base-storage-tree-element-subtitle;
+this.titleElement.appendChild(this._subtitleElement);
+}
+this._subtitleElement.textContent = ( + this._subtitleText + );
+} else if (this._subtitleElement) {
+this.titleElement.removeChild(this._subtitleElement);
+delete this._subtitleElement;
+}
+},
+
onselect: function()
{
var itemURL = this.itemURL;
@@ -891,10 +936,20 @@
set titleText(titleText)
{
this._titleText = titleText;
-if (this.titleElement)
-this.titleElement.textContent = this._titleText;
+this._updateTitle();
},
+get subtitleText()
+{
+return this._subtitleText;
+},
+
+set subtitleText(subtitleText)
+{
+
[webkit-changes] [99687] trunk/LayoutTests
Title: [99687] trunk/LayoutTests Revision 99687 Author l...@webkit.org Date 2011-11-09 04:42:13 -0800 (Wed, 09 Nov 2011) Log Message [WK2] nrwt pixeltests crash while test https://bugs.webkit.org/show_bug.cgi?id=71688 Patch by Roland Takacs takacs.rol...@stud.u-szeged.hu on 2011-11-09 Reviewed by Zoltan Herczeg. * platform/qt-5.0/Skipped: 'editing/pasteboard/data-transfer-items-image-png.html' is skipped, because it caused an nrwt pixel test crash. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-5.0/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99686 => 99687) --- trunk/LayoutTests/ChangeLog 2011-11-09 11:58:02 UTC (rev 99686) +++ trunk/LayoutTests/ChangeLog 2011-11-09 12:42:13 UTC (rev 99687) @@ -1,3 +1,13 @@ +2011-11-09 Roland Takacs takacs.rol...@stud.u-szeged.hu + +[WK2] nrwt pixeltests crash while test +https://bugs.webkit.org/show_bug.cgi?id=71688 + +Reviewed by Zoltan Herczeg. + +* platform/qt-5.0/Skipped: +'editing/pasteboard/data-transfer-items-image-png.html' is skipped, because it caused an nrwt pixel test crash. + 2011-11-08 Pavel Feldman pfeld...@google.com Web Inspector: crash upon InspectorValue serialization that has 0 value / array entry. Modified: trunk/LayoutTests/platform/qt-5.0/Skipped (99686 => 99687) --- trunk/LayoutTests/platform/qt-5.0/Skipped 2011-11-09 11:58:02 UTC (rev 99686) +++ trunk/LayoutTests/platform/qt-5.0/Skipped 2011-11-09 12:42:13 UTC (rev 99687) @@ -6964,3 +6964,7 @@ # [Qt] fast/multicol/flipped-blocks-hit-test.html fails with Qt5 # https://bugs.webkit.org/show_bug.cgi?id=71118 fast/multicol/flipped-blocks-hit-test.html + +# nrwt pixel test crash +# https://bugs.webkit.org/show_bug.cgi?id=71688 +editing/pasteboard/data-transfer-items-image-png.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99688] trunk/Source/WebKit/efl
Title: [99688] trunk/Source/WebKit/efl
Revision 99688
Author commit-qu...@webkit.org
Date 2011-11-09 05:01:45 -0800 (Wed, 09 Nov 2011)
Log Message
[EFL] Removed unused variable
https://bugs.webkit.org/show_bug.cgi?id=71877
Patch by Tomasz Morawski t.moraw...@samsung.com on 2011-11-09
Reviewed by Andreas Kling.
Removed unused rect variable declaration and renamed rect1 variable to rect.
* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_smart_calculate):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (99687 => 99688)
--- trunk/Source/WebKit/efl/ChangeLog 2011-11-09 12:42:13 UTC (rev 99687)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-11-09 13:01:45 UTC (rev 99688)
@@ -1,3 +1,15 @@
+2011-11-09 Tomasz Morawski t.moraw...@samsung.com
+
+[EFL] Removed unused variable
+https://bugs.webkit.org/show_bug.cgi?id=71877
+
+Reviewed by Andreas Kling.
+
+Removed unused rect variable declaration and renamed rect1 variable to rect.
+
+* ewk/ewk_tiled_backing_store.cpp:
+(_ewk_tiled_backing_store_smart_calculate):
+
2011-11-07 Gyuyoung Kim gyuyoung@samsung.com
[EFL] Need to replace api's object parameter with proper name.
Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp (99687 => 99688)
--- trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp 2011-11-09 12:42:13 UTC (rev 99687)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp 2011-11-09 13:01:45 UTC (rev 99688)
@@ -1340,11 +1340,6 @@
}
if (!priv-render.suspend priv-changed.model) {
-Eina_Rectangle rect;
-rect.x = 0;
-rect.y = 0;
-rect.w = priv-model.width;
-rect.h = priv-model.height;
_ewk_tiled_backing_store_fill_renderers(priv);
ewk_tile_matrix_resize(priv-model.matrix,
priv-model.current.columns,
@@ -1355,9 +1350,9 @@
/* Make sure we do not miss any important repaint by
* repainting the whole viewport */
-const Eina_Rectangle rect1 =
+const Eina_Rectangle rect =
{ 0, 0, priv-model.width, priv-model.height };
-ewk_tile_matrix_update(priv-model.matrix, rect1,
+ewk_tile_matrix_update(priv-model.matrix, rect,
priv-view.tile.zoom);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99689] trunk/Source/WebCore
Title: [99689] trunk/Source/WebCore Revision 99689 Author vse...@chromium.org Date 2011-11-09 05:02:03 -0800 (Wed, 09 Nov 2011) Log Message Web Inspector: Extract ApplicationCacheModel from ApplicationCacheItemsView. https://bugs.webkit.org/show_bug.cgi?id=71850 Reviewed by Pavel Feldman. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/compile-front-end.sh: * inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype._update): * inspector/front-end/ApplicationCacheModel.js: Added. (WebInspector.ApplicationCacheModel): (WebInspector.ApplicationCacheModel.prototype.getApplicationCachesAsync): (WebInspector.ApplicationCacheDispatcher): (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus): (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.wasShown): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._populateResourceTree): (WebInspector.ResourcesPanel.prototype.showApplicationCache): (WebInspector.ResourcesPanel.prototype._initializeApplicationCacheModel): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/compile-front-end.sh trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js trunk/Source/WebCore/inspector/front-end/WebKit.qrc trunk/Source/WebCore/inspector/front-end/inspector.html Added Paths trunk/Source/WebCore/inspector/front-end/ApplicationCacheModel.js Diff Modified: trunk/Source/WebCore/ChangeLog (99688 => 99689) --- trunk/Source/WebCore/ChangeLog 2011-11-09 13:01:45 UTC (rev 99688) +++ trunk/Source/WebCore/ChangeLog 2011-11-09 13:02:03 UTC (rev 99689) @@ -1,5 +1,33 @@ 2011-11-09 Vsevolod Vlasov vse...@chromium.org +Web Inspector: Extract ApplicationCacheModel from ApplicationCacheItemsView. +https://bugs.webkit.org/show_bug.cgi?id=71850 + +Reviewed by Pavel Feldman. + +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* inspector/compile-front-end.sh: +* inspector/front-end/ApplicationCacheItemsView.js: +(WebInspector.ApplicationCacheItemsView): +(WebInspector.ApplicationCacheItemsView.prototype._update): +* inspector/front-end/ApplicationCacheModel.js: Added. +(WebInspector.ApplicationCacheModel): +(WebInspector.ApplicationCacheModel.prototype.getApplicationCachesAsync): +(WebInspector.ApplicationCacheDispatcher): +(WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus): +(WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState): +* inspector/front-end/ResourcesPanel.js: +(WebInspector.ResourcesPanel.prototype.wasShown): +(WebInspector.ResourcesPanel.prototype.reset): +(WebInspector.ResourcesPanel.prototype._populateResourceTree): +(WebInspector.ResourcesPanel.prototype.showApplicationCache): +(WebInspector.ResourcesPanel.prototype._initializeApplicationCacheModel): +* inspector/front-end/WebKit.qrc: +* inspector/front-end/inspector.html: + +2011-11-09 Vsevolod Vlasov vse...@chromium.org + Web Inspector: ResourcesPanel should support adding subtitle to any BaseStorageTreeElement. https://bugs.webkit.org/show_bug.cgi?id=71848 Modified: trunk/Source/WebCore/WebCore.gypi (99688 => 99689) --- trunk/Source/WebCore/WebCore.gypi 2011-11-09 13:01:45 UTC (rev 99688) +++ trunk/Source/WebCore/WebCore.gypi 2011-11-09 13:02:03 UTC (rev 99689) @@ -6274,6 +6274,7 @@ 'inspector/front-end/inspector.html', 'inspector/front-end/AdvancedSearchController.js', 'inspector/front-end/ApplicationCacheItemsView.js', +'inspector/front-end/ApplicationCacheModel.js', 'inspector/front-end/AuditCategories.js', 'inspector/front-end/AuditFormatters.js', 'inspector/front-end/AuditLauncherView.js', Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (99688 => 99689) --- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2011-11-09 13:01:45 UTC (rev 99688) +++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2011-11-09 13:02:03 UTC (rev 99689) @@ -68573,6 +68573,10 @@ /File File + RelativePath=..\inspector\front-end\ApplicationCacheModel.js + +/File +File RelativePath=..\inspector\front-end\AuditCategories.js /File Modified: trunk/Source/WebCore/inspector/compile-front-end.sh (99688 => 99689) --- trunk/Source/WebCore/inspector/compile-front-end.sh 2011-11-09 13:01:45 UTC (rev 99688) +++
[webkit-changes] [99690] trunk/Tools
Title: [99690] trunk/Tools
Revision 99690
Author ves...@webkit.org
Date 2011-11-09 05:03:58 -0800 (Wed, 09 Nov 2011)
Log Message
[Qt] Detect presence of QtUiTools and enable it only when available
The disable_uitools option was a workaround for missing detection.
Reviewed by Simon Hausmann.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/QtTestBrowser/QtTestBrowser.pro
trunk/Tools/qmake/mkspecs/features/default_post.prf
trunk/Tools/qmake/mkspecs/features/default_pre.prf
Diff
Modified: trunk/Tools/ChangeLog (99689 => 99690)
--- trunk/Tools/ChangeLog 2011-11-09 13:02:03 UTC (rev 99689)
+++ trunk/Tools/ChangeLog 2011-11-09 13:03:58 UTC (rev 99690)
@@ -1,5 +1,17 @@
2011-11-09 Tor Arne Vestbø tor.arne.ves...@nokia.com
+[Qt] Detect presence of QtUiTools and enable it only when available
+
+The disable_uitools option was a workaround for missing detection.
+
+Reviewed by Simon Hausmann.
+
+* QtTestBrowser/QtTestBrowser.pro:
+* qmake/mkspecs/features/default_post.prf:
+* qmake/mkspecs/features/default_pre.prf:
+
+2011-11-09 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
[Qt] Don't override config for the build_pass of debug_and_release
Qmake will parse the profile once for each configuration (debug and
Modified: trunk/Tools/QtTestBrowser/QtTestBrowser.pro (99689 => 99690)
--- trunk/Tools/QtTestBrowser/QtTestBrowser.pro 2011-11-09 13:02:03 UTC (rev 99689)
+++ trunk/Tools/QtTestBrowser/QtTestBrowser.pro 2011-11-09 13:03:58 UTC (rev 99690)
@@ -30,13 +30,18 @@
fpstimer.h \
cookiejar.h
-greaterThan(QT_MAJOR_VERSION, 4):isEmpty(QT.uitools.name) {
-message(QtUiTools library not found. QWidget plugin loading will be disabled)
-DEFINES += QT_NO_UITOOLS
+haveQt(5) {
+!isEmpty(QT.uitools.name): CONFIG += uitools
} else {
-CONFIG += uitools
+libraryName = $$fromfile($$[QT_INSTALL_LIBS]/libQtUiTools.prl, QMAKE_PRL_TARGET)
+!isEmpty(libraryName):exists($$[QT_INSTALL_LIBS]/$$libraryName): CONFIG += uitools
}
+!CONFIG(uitools) {
+message(QtUiTools library not found. QWidget plugin loading will be disabled)
+DEFINES *= QT_NO_UITOOLS
+}
+
load(webcore)
CONFIG += qtwebkit
Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (99689 => 99690)
--- trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-09 13:02:03 UTC (rev 99689)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-09 13:03:58 UTC (rev 99690)
@@ -63,11 +63,6 @@
contains(_javascript_CORE_JIT, yes): DEFINES+=ENABLE_JIT=1
contains(_javascript_CORE_JIT, no): DEFINES+=ENABLE_JIT=0
-disable_uitools {
-DEFINES *= QT_NO_UITOOLS
-CONFIG -= uitools
-}
-
# Template configurations
contains(TEMPLATE, derived) {
# A (mostly) no-op template
Modified: trunk/Tools/qmake/mkspecs/features/default_pre.prf (99689 => 99690)
--- trunk/Tools/qmake/mkspecs/features/default_pre.prf 2011-11-09 13:02:03 UTC (rev 99689)
+++ trunk/Tools/qmake/mkspecs/features/default_pre.prf 2011-11-09 13:03:58 UTC (rev 99690)
@@ -103,5 +103,3 @@
# Set some defaults for specific platforms
CONFIG += include_webinspector
-
-*sh4*: CONFIG += disable_uitools
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99691] trunk
Title: [99691] trunk
Revision 99691
Author ph...@webkit.org
Date 2011-11-09 05:14:34 -0800 (Wed, 09 Nov 2011)
Log Message
[GTK][DRT] window internals object is not reset after each test
https://bugs.webkit.org/show_bug.cgi?id=71890
Reviewed by Xan Lopez.
Source/WebKit/gtk:
DRTSupport infrastructure to reset the Internals object, like in Qt.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::resetInternalsObject):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
Tools:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest): reset the Internals object after each test.
Modified Paths
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (99690 => 99691)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-11-09 13:03:58 UTC (rev 99690)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-11-09 13:14:34 UTC (rev 99691)
@@ -1,3 +1,16 @@
+2011-11-09 Philippe Normand pnorm...@igalia.com
+
+[GTK][DRT] window internals object is not reset after each test
+https://bugs.webkit.org/show_bug.cgi?id=71890
+
+Reviewed by Xan Lopez.
+
+DRTSupport infrastructure to reset the Internals object, like in Qt.
+
+* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+(DumpRenderTreeSupportGtk::resetInternalsObject):
+* WebCoreSupport/DumpRenderTreeSupportGtk.h:
+
2011-11-07 Adam Barth aba...@webkit.org
Move static policy state from SecurityOrigin.cpp to SecurityPolicy.cpp
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (99690 => 99691)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2011-11-09 13:03:58 UTC (rev 99690)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2011-11-09 13:14:34 UTC (rev 99691)
@@ -59,6 +59,7 @@
#include SecurityPolicy.h
#include Settings.h
#include TextIterator.h
+#include WebCoreTestSupport.h
#include WebKitDOMRangePrivate.h
#include WorkerThread.h
#include webkitglobalsprivate.h
@@ -890,3 +891,18 @@
return 0;
#endif
}
+
+void DumpRenderTreeSupportGtk::resetInternalsObject(WebKitWebFrame* frame)
+{
+Frame* coreFrame = core(frame);
+if (!coreFrame)
+return;
+
+JSLock lock(SilenceAssertionsOnly);
+
+JSGlobalContextRef globalContext = webkit_web_frame_get_global_context(frame);
+ExecState* exec = toJS(globalContext);
+
+JSContextRef context = toRef(exec);
+WebCoreTestSupport::resetInternalsObject(context);
+}
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (99690 => 99691)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h 2011-11-09 13:03:58 UTC (rev 99690)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h 2011-11-09 13:14:34 UTC (rev 99691)
@@ -126,6 +126,8 @@
static void setMockGeolocationError(WebKitWebView*, int errorCode, const gchar* errorMessage);
static int numberOfPendingGeolocationPermissionRequests(WebKitWebView*);
+static void resetInternalsObject(WebKitWebFrame*);
+
private:
static bool s_drtRun;
static bool s_linksIncludedInTabChain;
Modified: trunk/Tools/ChangeLog (99690 => 99691)
--- trunk/Tools/ChangeLog 2011-11-09 13:03:58 UTC (rev 99690)
+++ trunk/Tools/ChangeLog 2011-11-09 13:14:34 UTC (rev 99691)
@@ -1,3 +1,13 @@
+2011-11-09 Philippe Normand pnorm...@igalia.com
+
+[GTK][DRT] window internals object is not reset after each test
+https://bugs.webkit.org/show_bug.cgi?id=71890
+
+Reviewed by Xan Lopez.
+
+* DumpRenderTree/gtk/DumpRenderTree.cpp:
+(runTest): reset the Internals object after each test.
+
2011-11-09 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Detect presence of QtUiTools and enable it only when available
Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (99690 => 99691)
--- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2011-11-09 13:03:58 UTC (rev 99690)
+++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp 2011-11-09 13:14:34 UTC (rev 99691)
@@ -723,6 +723,8 @@
webViewList = 0;
}
+DumpRenderTreeSupportGtk::resetInternalsObject(mainFrame);
+
// A blank load seems to be necessary to reset state after certain tests.
webkit_web_view_open(webView, about:blank);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99692] trunk/Source/WebCore
Title: [99692] trunk/Source/WebCore
Revision 99692
Author yu...@chromium.org
Date 2011-11-09 05:19:43 -0800 (Wed, 09 Nov 2011)
Log Message
Web Inspector: exception in remote front-end load handler due to undefined reference to workerManager
https://bugs.webkit.org/show_bug.cgi?id=71889
Move calls to WorkerManager load handlers into doLoadedDone method which is
called in case of remote front-end too.
Reviewed by Pavel Feldman.
* inspector/front-end/inspector.js:
(WebInspector.loaded):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99691 => 99692)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 13:14:34 UTC (rev 99691)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 13:19:43 UTC (rev 99692)
@@ -1,3 +1,16 @@
+2011-11-09 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: exception in remote front-end load handler due to undefined reference to workerManager
+https://bugs.webkit.org/show_bug.cgi?id=71889
+
+Move calls to WorkerManager load handlers into doLoadedDone method which is
+called in case of remote front-end too.
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/inspector.js:
+(WebInspector.loaded):
+
2011-11-09 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Extract ApplicationCacheModel from ApplicationCacheItemsView.
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (99691 => 99692)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2011-11-09 13:14:34 UTC (rev 99691)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2011-11-09 13:19:43 UTC (rev 99692)
@@ -306,13 +306,12 @@
}
return;
}
-WebInspector.WorkerManager.loaded();
WebInspector.doLoadedDone();
-WebInspector.WorkerManager.loadCompleted();
}
WebInspector.doLoadedDone = function()
{
+WebInspector.WorkerManager.loaded();
InspectorFrontendHost.loaded();
WebInspector.installPortStyles();
@@ -387,6 +386,7 @@
WebInspector.showPanel(WebInspector.settings.lastActivePanel.get());
WebInspector.CSSCompletions.requestCSSNameCompletions();
+WebInspector.WorkerManager.loadCompleted();
}
WebInspector.addPanel = function(panel)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99693] trunk/Source/JavaScriptCore
Title: [99693] trunk/Source/_javascript_Core Revision 99693 Author o...@webkit.org Date 2011-11-09 05:31:59 -0800 (Wed, 09 Nov 2011) Log Message Enable the DFG JIT on x86-64 Linux platforms https://bugs.webkit.org/show_bug.cgi?id=71373 Enable DFG JIT by default on X86 Linux and Mac platforms https://bugs.webkit.org/show_bug.cgi?id=71686 Buildfix for stricter compilers: -Werror=unused-but-set-variable Reviewed by Zoltan Herczeg. * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compilePutByValForByteArray): * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (99692 => 99693) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 13:19:43 UTC (rev 99692) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 13:31:59 UTC (rev 99693) @@ -1,3 +1,22 @@ +2011-11-09 Csaba Osztrogonác o...@webkit.org + +Enable the DFG JIT on x86-64 Linux platforms +https://bugs.webkit.org/show_bug.cgi?id=71373 + +Enable DFG JIT by default on X86 Linux and Mac platforms +https://bugs.webkit.org/show_bug.cgi?id=71686 + +Buildfix for stricter compilers: -Werror=unused-but-set-variable + +Reviewed by Zoltan Herczeg. + +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray): +* dfg/DFGSpeculativeJIT32_64.cpp: +(JSC::DFG::SpeculativeJIT::compile): +* dfg/DFGSpeculativeJIT64.cpp: +(JSC::DFG::SpeculativeJIT::compile): + 2011-11-09 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r99678. Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (99692 => 99693) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-11-09 13:19:43 UTC (rev 99692) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-11-09 13:31:59 UTC (rev 99693) @@ -731,7 +731,7 @@ GPRReg scratchReg = scratch.gpr(); m_jit.move(valueOp.gpr(), scratchReg); MacroAssembler::Jump inBounds = m_jit.branch32(MacroAssembler::BelowOrEqual, scratchReg, TrustedImm32(0xff)); -MacroAssembler::Jump tooBig = m_jit.branch32(MacroAssembler::GreaterThan, scratchReg, TrustedImm32(0xff)); +m_jit.branch32(MacroAssembler::GreaterThan, scratchReg, TrustedImm32(0xff)); m_jit.xorPtr(scratchReg, scratchReg); MacroAssembler::Jump clamped = m_jit.jump(); m_jit.move(TrustedImm32(255), scratchReg); @@ -749,7 +749,7 @@ value.adopt(result); valueGPR = gpr; } -ASSERT(valueGPR != property); +ASSERT_UNUSED(valueGPR, valueGPR != property); ASSERT(valueGPR != base); GPRTemporary storage(this); GPRReg storageReg = storage.gpr(); Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (99692 => 99693) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-11-09 13:19:43 UTC (rev 99692) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-11-09 13:31:59 UTC (rev 99693) @@ -1505,7 +1505,7 @@ // Code to handle put beyond array bounds. silentSpillAllRegisters(scratchReg); -JITCompiler::Call functionCall = callOperation(operationPutByValBeyondArrayBounds, baseReg, propertyReg, valueTagReg, valuePayloadReg); +callOperation(operationPutByValBeyondArrayBounds, baseReg, propertyReg, valueTagReg, valuePayloadReg); silentFillAllRegisters(scratchReg); JITCompiler::Jump wasBeyondArrayBounds = m_jit.jump(); @@ -2493,7 +2493,7 @@ structuresNotMatch.link(m_jit); silentSpillAllRegisters(resultTagGPR, resultPayloadGPR); -JITCompiler::Call functionCall = callOperation(operationResolveGlobal, resultTagGPR, resultPayloadGPR, resolveInfoGPR, m_jit.codeBlock()-identifier(data.identifierNumber)); +callOperation(operationResolveGlobal, resultTagGPR, resultPayloadGPR, resolveInfoGPR, m_jit.codeBlock()-identifier(data.identifierNumber)); silentFillAllRegisters(resultTagGPR, resultPayloadGPR); wasFast.link(m_jit); Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (99692 => 99693) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2011-11-09 13:19:43 UTC (rev 99692) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2011-11-09 13:31:59 UTC (rev 99693) @@ -1549,7 +1549,7 @@ // Code to handle put beyond array bounds. silentSpillAllRegisters(scratchReg); -JITCompiler::Call functionCall = callOperation(operationPutByValBeyondArrayBounds, baseReg, propertyReg, valueReg); +
[webkit-changes] [99694] trunk/Source/WebKit2
Title: [99694] trunk/Source/WebKit2
Revision 99694
Author hausm...@webkit.org
Date 2011-11-09 05:41:31 -0800 (Wed, 09 Nov 2011)
Log Message
[Qt] Fix geolocation enabled build.
Reviewed by Tor Arne Vestbø.
* Target.pri: Add QT += location to get the right module includes.
* UIProcess/qt/WebGeolocationProviderQt.cpp: Include the moc file with the right name (GeoLocation - Geolocation)
* UIProcess/qt/WebGeolocationProviderQt.h: Removed the ENABLE(GEOLOCATION) guards, otherwise moc doesn't generate
code, because it can't interpret the ENABLE() macro.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/qt/WebGeolocationProviderQt.cpp
trunk/Source/WebKit2/UIProcess/qt/WebGeolocationProviderQt.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99693 => 99694)
--- trunk/Source/WebKit2/ChangeLog 2011-11-09 13:31:59 UTC (rev 99693)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-09 13:41:31 UTC (rev 99694)
@@ -1,5 +1,16 @@
2011-11-09 Simon Hausmann simon.hausm...@nokia.com
+[Qt] Fix geolocation enabled build.
+
+Reviewed by Tor Arne Vestbø.
+
+* Target.pri: Add QT += location to get the right module includes.
+* UIProcess/qt/WebGeolocationProviderQt.cpp: Include the moc file with the right name (GeoLocation - Geolocation)
+* UIProcess/qt/WebGeolocationProviderQt.h: Removed the ENABLE(GEOLOCATION) guards, otherwise moc doesn't generate
+code, because it can't interpret the ENABLE() macro.
+
+2011-11-09 Simon Hausmann simon.hausm...@nokia.com
+
[Qt] Build system cleanup
https://bugs.webkit.org/show_bug.cgi?id=71815
Modified: trunk/Source/WebKit2/Target.pri (99693 => 99694)
--- trunk/Source/WebKit2/Target.pri 2011-11-09 13:31:59 UTC (rev 99693)
+++ trunk/Source/WebKit2/Target.pri 2011-11-09 13:41:31 UTC (rev 99694)
@@ -612,3 +612,5 @@
SOURCES += \
Shared/qt/NativeWebTouchEventQt.cpp
}
+
+contains(DEFINES, ENABLE_GEOLOCATION=1): QT += location
Modified: trunk/Source/WebKit2/UIProcess/qt/WebGeolocationProviderQt.cpp (99693 => 99694)
--- trunk/Source/WebKit2/UIProcess/qt/WebGeolocationProviderQt.cpp 2011-11-09 13:31:59 UTC (rev 99693)
+++ trunk/Source/WebKit2/UIProcess/qt/WebGeolocationProviderQt.cpp 2011-11-09 13:41:31 UTC (rev 99694)
@@ -114,6 +114,6 @@
m_source-stopUpdates();
}
-#include moc_WebGeoLocationProviderQt.cpp
+#include moc_WebGeolocationProviderQt.cpp
#endif // ENABLE(GEOLOCATION)
Modified: trunk/Source/WebKit2/UIProcess/qt/WebGeolocationProviderQt.h (99693 => 99694)
--- trunk/Source/WebKit2/UIProcess/qt/WebGeolocationProviderQt.h 2011-11-09 13:31:59 UTC (rev 99693)
+++ trunk/Source/WebKit2/UIProcess/qt/WebGeolocationProviderQt.h 2011-11-09 13:41:31 UTC (rev 99694)
@@ -29,8 +29,6 @@
class QGeoPositionInfoSource;
class QGeoPositionInfo;
-#if ENABLE(GEOLOCATION)
-
class WebGeolocationProviderQt : public QObject {
Q_OBJECT
public:
@@ -55,6 +53,4 @@
mutable QGeoPositionInfoSource* m_source;
};
-#endif
-
#endif /* WebGeolocationProviderQt_h */
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99696] trunk/Source/JavaScriptCore
Title: [99696] trunk/Source/_javascript_Core Revision 99696 Author o...@webkit.org Date 2011-11-09 05:55:41 -0800 (Wed, 09 Nov 2011) Log Message Enable the DFG JIT on X86-64 Linux platforms https://bugs.webkit.org/show_bug.cgi?id=71373 Patch by Andy Wingo wi...@igalia.com on 2011-11-09 Reviewed by Csaba Osztrogonác. * wtf/Platform.h (ENABLE_DFG_JIT): Enable the DFG JIT on the x86-64 GNU/Linux platform. * CMakeListsEfl.txt: Add JSValue64 implementations to EFL build. Modified Paths trunk/Source/_javascript_Core/CMakeListsEfl.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/Platform.h Diff Modified: trunk/Source/_javascript_Core/CMakeListsEfl.txt (99695 => 99696) --- trunk/Source/_javascript_Core/CMakeListsEfl.txt 2011-11-09 13:55:13 UTC (rev 99695) +++ trunk/Source/_javascript_Core/CMakeListsEfl.txt 2011-11-09 13:55:41 UTC (rev 99696) @@ -29,13 +29,16 @@ dfg/DFGDriver.cpp dfg/DFGGraph.cpp dfg/DFGJITCodeGenerator.cpp +dfg/DFGJITCodeGenerator64.cpp dfg/DFGJITCodeGenerator32_64.cpp dfg/DFGJITCompiler.cpp dfg/DFGOperations.cpp dfg/DFGOSREntry.cpp +dfg/DFGOSRExitCompiler64.cpp dfg/DFGOSRExitCompiler32_64.cpp dfg/DFGPropagator.cpp dfg/DFGRepatch.cpp dfg/DFGSpeculativeJIT.cpp +dfg/DFGSpeculativeJIT64.cpp dfg/DFGSpeculativeJIT32_64.cpp ) Modified: trunk/Source/_javascript_Core/ChangeLog (99695 => 99696) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 13:55:13 UTC (rev 99695) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 13:55:41 UTC (rev 99696) @@ -1,3 +1,14 @@ +2011-11-09 Andy Wingo wi...@igalia.com + +Enable the DFG JIT on X86-64 Linux platforms +https://bugs.webkit.org/show_bug.cgi?id=71373 + +Reviewed by Csaba Osztrogonác. + +* wtf/Platform.h (ENABLE_DFG_JIT): Enable the DFG JIT on the +x86-64 GNU/Linux platform. +* CMakeListsEfl.txt: Add JSValue64 implementations to EFL build. + 2011-11-09 Csaba Osztrogonác o...@webkit.org Enable the DFG JIT on x86-64 Linux platforms Modified: trunk/Source/_javascript_Core/wtf/Platform.h (99695 => 99696) --- trunk/Source/_javascript_Core/wtf/Platform.h 2011-11-09 13:55:13 UTC (rev 99695) +++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-11-09 13:55:41 UTC (rev 99696) @@ -882,16 +882,13 @@ #define ENABLE_JIT 1 #endif -/* Currently for JSVALUE64, only tested on PLATFORM(MAC) */ -#if !defined(ENABLE_DFG_JIT) ENABLE(JIT) USE(JSVALUE64) PLATFORM(MAC) +/* Enable the DFG JIT on X86 and X86_64. Only tested on Mac and GNU/Linux. */ +#if !defined(ENABLE_DFG_JIT) ENABLE(JIT) \ + (CPU(X86) || CPU(X86_64)) \ + (PLATFORM(MAC) || OS(LINUX)) #define ENABLE_DFG_JIT 1 #endif -/* Currently DFG for X86 are only tested on Linux OS and Mac Platform */ -#if !defined(ENABLE_DFG_JIT) ENABLE(JIT) CPU(X86) (PLATFORM(MAC) || OS(LINUX)) -#define ENABLE_DFG_JIT 1 -#endif - /* Profiling of types and values used by JIT code. DFG_JIT depends on it, but you can enable it manually with DFG turned off if you want to use it as a standalone profiler. In that case, you probably want to also enable VERBOSE_VALUE_PROFILE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99697] trunk/LayoutTests
Title: [99697] trunk/LayoutTests
Revision 99697
Author o...@webkit.org
Date 2011-11-09 05:58:18 -0800 (Wed, 09 Nov 2011)
Log Message
[Qt] Some passing tests removed from Skipped list
https://bugs.webkit.org/show_bug.cgi?id=45598
https://bugs.webkit.org/show_bug.cgi?id=32961
http://bugreports.qt.nokia.com/browse/QTBUG-15566
Patch by Zoltan Arvai zar...@inf.u-szeged.hu on 2011-11-09
Reviewed by Csaba Osztrogonác.
* platform/qt/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
Diff
Modified: trunk/LayoutTests/ChangeLog (99696 => 99697)
--- trunk/LayoutTests/ChangeLog 2011-11-09 13:55:41 UTC (rev 99696)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 13:58:18 UTC (rev 99697)
@@ -1,3 +1,14 @@
+2011-11-09 Zoltan Arvai zar...@inf.u-szeged.hu
+
+[Qt] Some passing tests removed from Skipped list
+https://bugs.webkit.org/show_bug.cgi?id=45598
+https://bugs.webkit.org/show_bug.cgi?id=32961
+http://bugreports.qt.nokia.com/browse/QTBUG-15566
+
+Reviewed by Csaba Osztrogonác.
+
+* platform/qt/Skipped:
+
2011-11-09 Alexandru Chiculita ach...@adobe.com
[Part 1] Parse the custom() function in -webkit-filter
Modified: trunk/LayoutTests/platform/qt/Skipped (99696 => 99697)
--- trunk/LayoutTests/platform/qt/Skipped 2011-11-09 13:55:41 UTC (rev 99696)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-11-09 13:58:18 UTC (rev 99697)
@@ -373,11 +373,6 @@
# This needs more attention!
http/tests/misc/acid3.html
-# Page reload does not send any cache control headers.
-# https://bugs.webkit.org/show_bug.cgi?id=45598
-# Fixed in Qt 4.8
-http/tests/misc/refresh-headers.php
-
# Benign pixel differences except for:
# +selection start: position 0 of child 5 {IMG} of body
# +selection end: position 1 of child 5 {IMG} of body
@@ -388,9 +383,6 @@
# We should find out what dumpAsText() is doing wrong
http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW.html
-# - FAIL: Subframe did not finish loading.
-http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html
-
# Disabled HTTP subdirs for now, needs investigation.
http/tests/media
@@ -405,11 +397,6 @@
# Failing xmlhttprequest tests #
# === #
-# DRT sideeffect - this test make http/tests/xmlhttprequest/null-auth.php fail:
-# https://bugs.webkit.org/show_bug.cgi?id=32961
-# Passes against Qt trunk (4e2d549e8b2e34c5bd4c77a4a6eba99ed0912168) but not 4.7.2
-http/tests/xmlhttprequest/basic-auth-default.html
-
# Skip xmlhttprequest tests - NETWORK_ERR: XMLHttpRequest Exception 101: A network error occured in synchronous requests.
http/tests/xmlhttprequest/logout.html
http/tests/xmlhttprequest/methods-async.html
@@ -421,12 +408,6 @@
http/tests/xmlhttprequest/re-login-async.html
http/tests/xmlhttprequest/re-login.html
-# DRT sideeffect - this test make http/tests/xmlhttprequest/null-auth.php fail:
-# https://bugs.webkit.org/show_bug.cgi?id=32961
-# Passes against Qt trunk (4e2d549e8b2e34c5bd4c77a4a6eba99ed0912168) but not 4.7.2
-http/tests/xmlhttprequest/failed-auth.html
-
-
# Still fail with Qt 4.7.1
http/tests/xmlhttprequest/cache-override.html
http/tests/xmlhttprequest/cross-origin-authorization.html
@@ -450,9 +431,6 @@
editing/inserting/5994480-2.html
editing/inserting/typing-at-end-of-line.html
-# http://bugreports.qt.nokia.com/browse/QTBUG-15566
-http/tests/xmlhttprequest/basic-auth-nouser.html
-
# === #
# Failing pasteboard tests. #
# === #
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99698] trunk/LayoutTests
Title: [99698] trunk/LayoutTests Revision 99698 Author kbal...@webkit.org Date 2011-11-09 05:59:39 -0800 (Wed, 09 Nov 2011) Log Message WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks https://bugs.webkit.org/show_bug.cgi?id=42331 Unreviewed. Skip dependent test. * platform/wk2/Skipped: Skip http/tests/security/xssAuditor/script-tag-with-callbacks-actual.txt Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99697 => 99698) --- trunk/LayoutTests/ChangeLog 2011-11-09 13:58:18 UTC (rev 99697) +++ trunk/LayoutTests/ChangeLog 2011-11-09 13:59:39 UTC (rev 99698) @@ -1,3 +1,12 @@ +2011-11-09 Balazs Kelemen kbal...@webkit.org + +WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks +https://bugs.webkit.org/show_bug.cgi?id=42331 + +Unreviewed. Skip dependent test. + +* platform/wk2/Skipped: Skip http/tests/security/xssAuditor/script-tag-with-callbacks-actual.txt + 2011-11-09 Zoltan Arvai zar...@inf.u-szeged.hu [Qt] Some passing tests removed from Skipped list Modified: trunk/LayoutTests/platform/wk2/Skipped (99697 => 99698) --- trunk/LayoutTests/platform/wk2/Skipped 2011-11-09 13:58:18 UTC (rev 99697) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-11-09 13:59:39 UTC (rev 99698) @@ -389,6 +389,7 @@ webarchive/loading/_javascript_-url-iframe-crash.html webarchive/loading/mainresource-null-mimetype-crash.html webarchive/loading/missing-data.html +http/tests/security/xssAuditor/script-tag-with-callbacks.html # WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks # https://bugs.webkit.org/show_bug.cgi?id=42332 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99699] trunk
Title: [99699] trunk
Revision 99699
Author commit-qu...@webkit.org
Date 2011-11-09 06:00:52 -0800 (Wed, 09 Nov 2011)
Log Message
[Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt
https://bugs.webkit.org/show_bug.cgi?id=71554
Patch by Deepak Sherveghar bpw...@motorola.com on 2011-11-09
Reviewed by Simon Hausmann.
Source/WebKit/qt:
We should check the error domain when checking the error code in shouldFallBack()
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::shouldFallBack): added error domain check
LayoutTests:
Un-skip the 4 failing layout test, we now check the error domain along with the error code in shouldFallBack()
* platform/qt/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (99698 => 99699)
--- trunk/LayoutTests/ChangeLog 2011-11-09 13:59:39 UTC (rev 99698)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 14:00:52 UTC (rev 99699)
@@ -1,3 +1,14 @@
+2011-11-09 Deepak Sherveghar bpw...@motorola.com
+
+[Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt
+https://bugs.webkit.org/show_bug.cgi?id=71554
+
+Reviewed by Simon Hausmann.
+
+Un-skip the 4 failing layout test, we now check the error domain along with the error code in shouldFallBack()
+
+* platform/qt/Skipped:
+
2011-11-09 Balazs Kelemen kbal...@webkit.org
WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
Modified: trunk/LayoutTests/platform/qt/Skipped (99698 => 99699)
--- trunk/LayoutTests/platform/qt/Skipped 2011-11-09 13:59:39 UTC (rev 99698)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-11-09 14:00:52 UTC (rev 99699)
@@ -2454,13 +2454,6 @@
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
fast/backgrounds/size/contain-and-cover-zoomed.html
-# new bug revealed by r99071
-# https://bugs.webkit.org/show_bug.cgi?id=62108
-fast/overflow/overflow-height-float-not-removed-crash.html
-fast/overflow/overflow-height-float-not-removed-crash3.html
-fast/css/acid2-pixel.html
-fast/css/acid2.html
-
# REGRESSION(r99195)
# https://bugs.webkit.org/show_bug.cgi?id=70609
fast/viewport/viewport-83.html
Modified: trunk/Source/WebKit/qt/ChangeLog (99698 => 99699)
--- trunk/Source/WebKit/qt/ChangeLog 2011-11-09 13:59:39 UTC (rev 99698)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-11-09 14:00:52 UTC (rev 99699)
@@ -1,3 +1,15 @@
+2011-11-09 Deepak Sherveghar bpw...@motorola.com
+
+[Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt
+https://bugs.webkit.org/show_bug.cgi?id=71554
+
+Reviewed by Simon Hausmann.
+
+We should check the error domain when checking the error code in shouldFallBack()
+
+* WebCoreSupport/FrameLoaderClientQt.cpp:
+(WebCore::FrameLoaderClientQt::shouldFallBack): added error domain check
+
2011-11-08 Simon Hausmann simon.hausm...@nokia.com
[Qt] Replace use of QApplication with QGuiApplication
Modified: trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp (99698 => 99699)
--- trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp 2011-11-09 13:59:39 UTC (rev 99698)
+++ trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp 2011-11-09 14:00:52 UTC (rev 99699)
@@ -986,7 +986,20 @@
bool FrameLoaderClientQt::shouldFallBack(const WebCore::ResourceError error)
{
-return !(error.isCancellation() || (error.errorCode() == WebKitErrorFrameLoadInterruptedByPolicyChange) || (error.errorCode() == WebKitErrorPluginWillHandleLoad));
+DEFINE_STATIC_LOCAL(const ResourceError, cancelledError, (this-cancelledError(ResourceRequest(;
+DEFINE_STATIC_LOCAL(const ResourceError, pluginWillHandleLoadError, (this-pluginWillHandleLoadError(ResourceResponse(;
+DEFINE_STATIC_LOCAL(const ResourceError, errorInterruptedForPolicyChange, (this-interruptedForPolicyChangeError(ResourceRequest(;
+
+if (error.errorCode() == cancelledError.errorCode() error.domain() == cancelledError.domain())
+return false;
+
+if (error.errorCode() == errorInterruptedForPolicyChange.errorCode() error.domain() == errorInterruptedForPolicyChange.domain())
+return false;
+
+if (error.errorCode() == pluginWillHandleLoadError.errorCode() error.domain() == pluginWillHandleLoadError.domain())
+return false;
+
+return true;
}
WTF::PassRefPtrWebCore::DocumentLoader FrameLoaderClientQt::createDocumentLoader(const WebCore::ResourceRequest request, const SubstituteData substituteData)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [99700] trunk/Source/JavaScriptCore
Title: [99700] trunk/Source/_javascript_Core Revision 99700 Author rga...@webkit.org Date 2011-11-09 06:07:24 -0800 (Wed, 09 Nov 2011) Log Message Buildfix for 32bit debug mode. Reviewed by Csaba Osztrogonác. * dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::dump): * dfg/DFGGraph.cpp: (JSC::DFG::Graph::dump): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp trunk/Source/_javascript_Core/dfg/DFGGraph.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (99699 => 99700) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 14:00:52 UTC (rev 99699) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 14:07:24 UTC (rev 99700) @@ -1,3 +1,14 @@ +2011-11-09 Gabor Rapcsanyi rga...@webkit.org + +Buildfix for 32bit debug mode. + +Reviewed by Csaba Osztrogonác. + +* dfg/DFGAbstractState.cpp: +(JSC::DFG::AbstractState::dump): +* dfg/DFGGraph.cpp: +(JSC::DFG::Graph::dump): + 2011-11-09 Andy Wingo wi...@igalia.com Enable the DFG JIT on X86-64 Linux platforms Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (99699 => 99700) --- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2011-11-09 14:00:52 UTC (rev 99699) +++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2011-11-09 14:07:24 UTC (rev 99700) @@ -800,7 +800,7 @@ first = false; else fprintf(out, ); -fprintf(out, @%lu:, i + m_block-begin); +fprintf(out, @%lu:, static_castunsigned long(i + m_block-begin)); m_nodes[i].dump(out); } } Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (99699 => 99700) --- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2011-11-09 14:00:52 UTC (rev 99699) +++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2011-11-09 14:07:24 UTC (rev 99700) @@ -209,7 +209,7 @@ else printf(%sid%u, hasPrinted ? , : , storageAccessData.identifierNumber); -printf(, %lu, storageAccessData.offset); +printf(, %lu, static_castunsigned long(storageAccessData.offset)); hasPrinted = true; } ASSERT(node.hasVariableAccessData() == node.hasLocal()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99701] trunk
Title: [99701] trunk
Revision 99701
Author hausm...@webkit.org
Date 2011-11-09 06:40:04 -0800 (Wed, 09 Nov 2011)
Log Message
Source/WebKit/qt: [Qt] Enable exports and constructor functions in static libs
Reviewed by Tor Arne Vestbø.
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
initialization.
Source/WebKit2: [Qt] Enable exports and constructor functions in static libs
Reviewed by Tor Arne Vestbø.
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize): Remove unnecessary manual Qt resource
initialization.
Tools: [Qt] Enable exports and constructor functions in static libs
Reviewed by Tor Arne Vestbø.
* qmake/mkspecs/features/functions.prf: Use --whole-archive and their
mac/win32-msvc equivalents when linking static libraries into a shared
library or executable.
Modified Paths
trunk/Source/WebKit/qt/Api/qwebpage.cpp
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/functions.prf
Diff
Modified: trunk/Source/WebKit/qt/Api/qwebpage.cpp (99700 => 99701)
--- trunk/Source/WebKit/qt/Api/qwebpage.cpp 2011-11-09 14:07:24 UTC (rev 99700)
+++ trunk/Source/WebKit/qt/Api/qwebpage.cpp 2011-11-09 14:40:04 UTC (rev 99701)
@@ -292,17 +292,6 @@
return result;
}
-static void initResources()
-{
-static bool initialized = false;
-if (initialized)
-return;
-Q_INIT_RESOURCE(WebKit);
-Q_INIT_RESOURCE(WebCore);
-Q_INIT_RESOURCE(InspectorBackendStub);
-initialized = true;
-}
-
QWebPagePrivate::QWebPagePrivate(QWebPage *qq)
: q(qq)
, page(0)
@@ -327,7 +316,6 @@
, inspectorIsInternalOnly(false)
, m_lastDropAction(Qt::IgnoreAction)
{
-initResources();
WebCore::InitializeLoggingChannelsIfNecessary();
ScriptController::initializeThreading();
WTF::initializeMainThread();
Modified: trunk/Source/WebKit/qt/ChangeLog (99700 => 99701)
--- trunk/Source/WebKit/qt/ChangeLog 2011-11-09 14:07:24 UTC (rev 99700)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-11-09 14:40:04 UTC (rev 99701)
@@ -1,3 +1,13 @@
+2011-11-09 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Enable exports and constructor functions in static libs
+
+Reviewed by Tor Arne Vestbø.
+
+* Api/qwebpage.cpp:
+(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
+initialization.
+
2011-11-09 Deepak Sherveghar bpw...@motorola.com
[Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt
Modified: trunk/Source/WebKit2/ChangeLog (99700 => 99701)
--- trunk/Source/WebKit2/ChangeLog 2011-11-09 14:07:24 UTC (rev 99700)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-09 14:40:04 UTC (rev 99701)
@@ -1,5 +1,15 @@
2011-11-09 Simon Hausmann simon.hausm...@nokia.com
+[Qt] Enable exports and constructor functions in static libs
+
+Reviewed by Tor Arne Vestbø.
+
+* WebProcess/WebPage/qt/WebPageQt.cpp:
+(WebKit::WebPage::platformInitialize): Remove unnecessary manual Qt resource
+initialization.
+
+2011-11-09 Simon Hausmann simon.hausm...@nokia.com
+
[Qt] Fix geolocation enabled build.
Reviewed by Tor Arne Vestbø.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp (99700 => 99701)
--- trunk/Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp 2011-11-09 14:07:24 UTC (rev 99700)
+++ trunk/Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp 2011-11-09 14:40:04 UTC (rev 99701)
@@ -78,17 +78,6 @@
#define VK_OEM_PERIOD 0xBE
#endif
-static void initResources()
-{
-static bool initialized = false;
-if (initialized)
-return;
-Q_INIT_RESOURCE(WebKit);
-Q_INIT_RESOURCE(WebCore);
-Q_INIT_RESOURCE(InspectorBackendStub);
-initialized = true;
-}
-
using namespace WebCore;
namespace WebKit {
@@ -99,8 +88,6 @@
// If accelerated compositing is enabled, we want to be in force-compositing mode, so that we don't switch between composited/non-composited state.
settings-setForceCompositingMode(true);
-
-initResources();
}
void WebPage::platformPreferencesDidChange(const WebPreferencesStore)
Modified: trunk/Tools/ChangeLog (99700 => 99701)
--- trunk/Tools/ChangeLog 2011-11-09 14:07:24 UTC (rev 99700)
+++ trunk/Tools/ChangeLog 2011-11-09 14:40:04 UTC (rev 99701)
@@ -1,3 +1,13 @@
+2011-11-09 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Enable exports and constructor functions in static libs
+
+Reviewed by Tor Arne Vestbø.
+
+* qmake/mkspecs/features/functions.prf: Use --whole-archive and their
+mac/win32-msvc equivalents when linking static libraries into a shared
+library or executable.
+
2011-11-09 Philippe Normand pnorm...@igalia.com
[GTK][DRT] window internals object is not reset after
[webkit-changes] [99702] trunk/LayoutTests
Title: [99702] trunk/LayoutTests Revision 99702 Author kbal...@webkit.org Date 2011-11-09 06:40:58 -0800 (Wed, 09 Nov 2011) Log Message [WK2] http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html fails https://bugs.webkit.org/show_bug.cgi?id=71896 Unreviewed gardening. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (99701 => 99702) --- trunk/LayoutTests/ChangeLog 2011-11-09 14:40:04 UTC (rev 99701) +++ trunk/LayoutTests/ChangeLog 2011-11-09 14:40:58 UTC (rev 99702) @@ -1,3 +1,12 @@ +2011-11-09 Balazs Kelemen kbal...@webkit.org + +[WK2] http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html fails +https://bugs.webkit.org/show_bug.cgi?id=71896 + +Unreviewed gardening. + +* platform/wk2/Skipped: + 2011-11-09 Deepak Sherveghar bpw...@motorola.com [Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt Modified: trunk/LayoutTests/platform/wk2/Skipped (99701 => 99702) --- trunk/LayoutTests/platform/wk2/Skipped 2011-11-09 14:40:04 UTC (rev 99701) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-11-09 14:40:58 UTC (rev 99702) @@ -835,6 +835,10 @@ # https://bugs.webkit.org/show_bug.cgi?id=59192 http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html +# [WK2] failures in http/tests/security/contentSecurityPolicy +# https://bugs.webkit.org/show_bug.cgi?id=71896 +http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html + # WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled # https://bugs.webkit.org/show_bug.cgi?id=63458 fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99716] trunk/Source/WebCore
Title: [99716] trunk/Source/WebCore
Revision 99716
Author pfeld...@chromium.org
Date 2011-11-09 07:35:11 -0800 (Wed, 09 Nov 2011)
Log Message
2011-11-09 Pavel Feldman pfeld...@google.com
Not reviewed: annotate inspector front-end _javascript_ so that it compiled again.
* inspector/front-end/ShortcutsScreen.js:
* inspector/front-end/WorkerManager.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ShortcutsScreen.js
trunk/Source/WebCore/inspector/front-end/WorkerManager.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99715 => 99716)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 15:31:05 UTC (rev 99715)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 15:35:11 UTC (rev 99716)
@@ -1,3 +1,10 @@
+2011-11-09 Pavel Feldman pfeld...@google.com
+
+Not reviewed: annotate inspector front-end _javascript_ so that it compiled again.
+
+* inspector/front-end/ShortcutsScreen.js:
+* inspector/front-end/WorkerManager.js:
+
2011-11-09 Andreas Kling kl...@webkit.org
Unreviewed build fix after r99711. (Signed/unsigned compare.)
Modified: trunk/Source/WebCore/inspector/front-end/ShortcutsScreen.js (99715 => 99716)
--- trunk/Source/WebCore/inspector/front-end/ShortcutsScreen.js 2011-11-09 15:31:05 UTC (rev 99715)
+++ trunk/Source/WebCore/inspector/front-end/ShortcutsScreen.js 2011-11-09 15:35:11 UTC (rev 99716)
@@ -30,6 +30,7 @@
/**
* @constructor
+ * @extends {WebInspector.HelpScreen}
*/
WebInspector.ShortcutsScreen = function()
{
Modified: trunk/Source/WebCore/inspector/front-end/WorkerManager.js (99715 => 99716)
--- trunk/Source/WebCore/inspector/front-end/WorkerManager.js 2011-11-09 15:31:05 UTC (rev 99715)
+++ trunk/Source/WebCore/inspector/front-end/WorkerManager.js 2011-11-09 15:35:11 UTC (rev 99716)
@@ -244,6 +244,10 @@
}
}
+/**
+ * @constructor
+ * @extends {WebInspector.HelpScreen}
+ */
WebInspector.WorkerTerminatedScreen = function()
{
WebInspector.HelpScreen.call(this, WebInspector.UIString(Inspected worker terminated));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99717] trunk
Title: [99717] trunk
Revision 99717
Author ca...@chromium.org
Date 2011-11-09 07:40:50 -0800 (Wed, 09 Nov 2011)
Log Message
Web Inspector: [refactoring] remove a bunch of methods from _javascript_SourceFrameDelegate
https://bugs.webkit.org/show_bug.cgi?id=71826
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame):
(WebInspector._javascript_SourceFrame.prototype.requestContent):
(WebInspector._javascript_SourceFrame.prototype.canEditSource):
(WebInspector._javascript_SourceFrame.prototype.editContent):
(WebInspector._javascript_SourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector._javascript_SourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector._javascript_SourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector._javascript_SourceFrame.prototype.didEditContent):
(WebInspector._javascript_SourceFrame.prototype._onMouseDown):
* inspector/front-end/ScriptsPanel.js:
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/debugger-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (99716 => 99717)
--- trunk/LayoutTests/ChangeLog 2011-11-09 15:35:11 UTC (rev 99716)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 15:40:50 UTC (rev 99717)
@@ -1,3 +1,13 @@
+2011-11-09 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: [refactoring] remove a bunch of methods from _javascript_SourceFrameDelegate
+https://bugs.webkit.org/show_bug.cgi?id=71826
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/debugger-test.js:
+(initialize_DebuggerTest):
+
2011-11-09 Alexander Pavlov apav...@chromium.org
Web Inspector: Provisionally change StylesSidebarPane section DOM layout to allow media queries
Modified: trunk/LayoutTests/http/tests/inspector/debugger-test.js (99716 => 99717)
--- trunk/LayoutTests/http/tests/inspector/debugger-test.js 2011-11-09 15:35:11 UTC (rev 99716)
+++ trunk/LayoutTests/http/tests/inspector/debugger-test.js 2011-11-09 15:40:50 UTC (rev 99717)
@@ -180,7 +180,7 @@
InspectorTest.removeBreakpoint = function(sourceFrame, lineNumber)
{
-sourceFrame._delegate.removeBreakpoint(lineNumber);
+sourceFrame._model.removeBreakpoint(sourceFrame._uiSourceCode, lineNumber);
};
Modified: trunk/Source/WebCore/ChangeLog (99716 => 99717)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 15:35:11 UTC (rev 99716)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 15:40:50 UTC (rev 99717)
@@ -1,3 +1,22 @@
+2011-11-09 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: [refactoring] remove a bunch of methods from _javascript_SourceFrameDelegate
+https://bugs.webkit.org/show_bug.cgi?id=71826
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame):
+(WebInspector._javascript_SourceFrame.prototype.requestContent):
+(WebInspector._javascript_SourceFrame.prototype.canEditSource):
+(WebInspector._javascript_SourceFrame.prototype.editContent):
+(WebInspector._javascript_SourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
+(WebInspector._javascript_SourceFrame.prototype.populateLineGutterContextMenu.else):
+(WebInspector._javascript_SourceFrame.prototype.populateLineGutterContextMenu):
+(WebInspector._javascript_SourceFrame.prototype.didEditContent):
+(WebInspector._javascript_SourceFrame.prototype._onMouseDown):
+* inspector/front-end/ScriptsPanel.js:
+
2011-11-09 Pavel Feldman pfeld...@google.com
Not reviewed: annotate inspector front-end _javascript_ so that it compiled again.
Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (99716 => 99717)
--- trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2011-11-09 15:35:11 UTC (rev 99716)
+++ trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2011-11-09 15:40:50 UTC (rev 99717)
@@ -48,6 +48,7 @@
this.addEventListener(WebInspector.SourceFrame.Events.Loaded, this._onTextViewerContentLoaded, this);
this._model = model;
+this._uiSourceCode = uiSourceCode;
this._popoverObjectGroup = popover;
this._breakpoints = {};
}
@@ -63,12 +64,12 @@
// SourceFrame overrides
requestContent: function(callback)
{
-this._delegate.requestContent(callback);
+this._uiSourceCode.requestContent(callback);
},
canEditSource: function()
{
-return this._delegate.canEditScriptSource();
+return
[webkit-changes] [99718] trunk/Source/WebCore
Title: [99718] trunk/Source/WebCore Revision 99718 Author hausm...@webkit.org Date 2011-11-09 07:46:49 -0800 (Wed, 09 Nov 2011) Log Message [Qt] Unreviewed, adding missing files to the build. * Target.pri: Add ContentTypeParser.cpp/h Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Target.pri Diff Modified: trunk/Source/WebCore/ChangeLog (99717 => 99718) --- trunk/Source/WebCore/ChangeLog 2011-11-09 15:40:50 UTC (rev 99717) +++ trunk/Source/WebCore/ChangeLog 2011-11-09 15:46:49 UTC (rev 99718) @@ -1,3 +1,9 @@ +2011-11-09 Simon Hausmann simon.hausm...@nokia.com + +[Qt] Unreviewed, adding missing files to the build. + +* Target.pri: Add ContentTypeParser.cpp/h + 2011-11-09 Andrey Kosyakov ca...@chromium.org Web Inspector: [refactoring] remove a bunch of methods from _javascript_SourceFrameDelegate Modified: trunk/Source/WebCore/Target.pri (99717 => 99718) --- trunk/Source/WebCore/Target.pri 2011-11-09 15:40:50 UTC (rev 99717) +++ trunk/Source/WebCore/Target.pri 2011-11-09 15:46:49 UTC (rev 99718) @@ -1107,6 +1107,7 @@ platform/network/BlobResourceHandle.cpp \ platform/network/Credential.cpp \ platform/network/CredentialStorage.cpp \ +platform/network/ContentTypeParser.cpp \ platform/network/FormData.cpp \ platform/network/FormDataBuilder.cpp \ platform/network/HTTPHeaderMap.cpp \ @@ -2184,6 +2185,7 @@ platform/network/CookieStorage.h \ platform/network/Credential.h \ platform/network/CredentialStorage.h \ +platform/network/ContentTypeParser.h \ platform/network/FormDataBuilder.h \ platform/network/FormData.h \ platform/network/HTTPHeaderMap.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99719] trunk/Tools
Title: [99719] trunk/Tools
Revision 99719
Author ves...@webkit.org
Date 2011-11-09 07:52:02 -0800 (Wed, 09 Nov 2011)
Log Message
[Qt] Disable use of QtUiTools if the library/module is not found
We rely on the lookup order of prf files to inject our own uitools.prf
that will verify that QtUiTools is in fact present before allowing the
CONFIG += uitools to have any effect.
Reviewed by Simon Hausmann.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro
trunk/Tools/QtTestBrowser/QtTestBrowser.pro
Added Paths
trunk/Tools/qmake/mkspecs/features/uitools.prf
Diff
Modified: trunk/Tools/ChangeLog (99718 => 99719)
--- trunk/Tools/ChangeLog 2011-11-09 15:46:49 UTC (rev 99718)
+++ trunk/Tools/ChangeLog 2011-11-09 15:52:02 UTC (rev 99719)
@@ -1,3 +1,17 @@
+2011-11-09 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Disable use of QtUiTools if the library/module is not found
+
+We rely on the lookup order of prf files to inject our own uitools.prf
+that will verify that QtUiTools is in fact present before allowing the
+CONFIG += uitools to have any effect.
+
+Reviewed by Simon Hausmann.
+
+* DumpRenderTree/qt/DumpRenderTree.pro:
+* QtTestBrowser/QtTestBrowser.pro:
+* qmake/mkspecs/features/uitools.prf: Added.
+
2011-11-09 Simon Hausmann simon.hausm...@nokia.com
Unreviewed, rolling out r99701.
Modified: trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro (99718 => 99719)
--- trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro 2011-11-09 15:46:49 UTC (rev 99718)
+++ trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro 2011-11-09 15:52:02 UTC (rev 99719)
@@ -9,12 +9,7 @@
TARGET = DumpRenderTree
DESTDIR = $$ROOT_BUILD_DIR/bin
-haveQt(5):isEmpty(QT.uitools.name) {
-message(QtUiTools library not found. QWidget plugin loading will be disabled)
-DEFINES += QT_NO_UITOOLS
-} else {
-CONFIG += uitools
-}
+CONFIG += uitools
load(_javascript_core)
load(webcore)
Modified: trunk/Tools/QtTestBrowser/QtTestBrowser.pro (99718 => 99719)
--- trunk/Tools/QtTestBrowser/QtTestBrowser.pro 2011-11-09 15:46:49 UTC (rev 99718)
+++ trunk/Tools/QtTestBrowser/QtTestBrowser.pro 2011-11-09 15:52:02 UTC (rev 99719)
@@ -30,17 +30,8 @@
fpstimer.h \
cookiejar.h
-haveQt(5) {
-!isEmpty(QT.uitools.name): CONFIG += uitools
-} else {
-libraryName = $$fromfile($$[QT_INSTALL_LIBS]/libQtUiTools.prl, QMAKE_PRL_TARGET)
-!isEmpty(libraryName):exists($$[QT_INSTALL_LIBS]/$$libraryName): CONFIG += uitools
-}
-!CONFIG(uitools) {
-message(QtUiTools library not found. QWidget plugin loading will be disabled)
-DEFINES *= QT_NO_UITOOLS
-}
+CONFIG += uitools
load(webcore)
Added: trunk/Tools/qmake/mkspecs/features/uitools.prf (0 => 99719)
--- trunk/Tools/qmake/mkspecs/features/uitools.prf (rev 0)
+++ trunk/Tools/qmake/mkspecs/features/uitools.prf 2011-11-09 15:52:02 UTC (rev 99719)
@@ -0,0 +1,23 @@
+# ---
+# This file ensures that QtUiTools is available before including the
+# feature.
+#
+# See 'Tools/qmake/README' for an overview of the build system
+# ---
+
+# Disable by default
+CONFIG -= uitools
+
+haveQt(5) {
+!isEmpty(QT.uitools.name): CONFIG += uitools
+} else {
+# 4.x
+libraryName = $$fromfile($$[QT_INSTALL_LIBS]/libQtUiTools.prl, QMAKE_PRL_TARGET)
+!isEmpty(libraryName):exists($$[QT_INSTALL_LIBS]/$$libraryName): CONFIG += uitools
+}
+
+CONFIG(uitools):load(uitools)
+else {
+!build_pass: message(QtUiTools library not found. QWidget plugin loading will be disabled)
+DEFINES *= QT_NO_UITOOLS
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99720] trunk/Tools
Title: [99720] trunk/Tools
Revision 99720
Author hausm...@webkit.org
Date 2011-11-09 07:58:33 -0800 (Wed, 09 Nov 2011)
Log Message
Unreviewed, rolling out r99707.
http://trac.webkit.org/changeset/99707
Re-enable until we can disable it together with tests in one
shot.
* qmake/mkspecs/features/features.prf:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/features.prf
Diff
Modified: trunk/Tools/ChangeLog (99719 => 99720)
--- trunk/Tools/ChangeLog 2011-11-09 15:52:02 UTC (rev 99719)
+++ trunk/Tools/ChangeLog 2011-11-09 15:58:33 UTC (rev 99720)
@@ -1,3 +1,13 @@
+2011-11-09 Simon Hausmann simon.hausm...@nokia.com
+
+Unreviewed, rolling out r99707.
+http://trac.webkit.org/changeset/99707
+
+Re-enable until we can disable it together with tests in one
+shot.
+
+* qmake/mkspecs/features/features.prf:
+
2011-11-09 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Disable use of QtUiTools if the library/module is not found
Modified: trunk/Tools/qmake/mkspecs/features/features.prf (99719 => 99720)
--- trunk/Tools/qmake/mkspecs/features/features.prf 2011-11-09 15:52:02 UTC (rev 99719)
+++ trunk/Tools/qmake/mkspecs/features/features.prf 2011-11-09 15:58:33 UTC (rev 99720)
@@ -110,7 +110,10 @@
!contains(DEFINES, ENABLE_WEB_TIMING=.): DEFINES += ENABLE_WEB_TIMING=1
# XSLT support with QtXmlPatterns
-!contains(DEFINES, ENABLE_XSLT=.):DEFINES += ENABLE_XSLT=0
+!contains(DEFINES, ENABLE_XSLT=.) {
+contains(QT_CONFIG, xmlpatterns):DEFINES += ENABLE_XSLT=1
+else:DEFINES += ENABLE_XSLT=0
+}
# This is experimental and only works on Linux so far.
contains(DEFINES, WTF_USE_LIBXML2=1) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99706] trunk/Source/WebCore
Title: [99706] trunk/Source/WebCore
Revision 99706
Author andreas.kl...@nokia.com
Date 2011-11-09 07:00:26 -0800 (Wed, 09 Nov 2011)
Log Message
CSS: Remove redudant WTF_MAKE_FAST_ALLOCATED macros.
http://webkit.org/b/71897
Reviewed by Antti Koivisto.
Everything that inherits from RefCountedT is already fast-allocated,
so we don't need this in subclasses.
* css/CSSImageValue.h:
* css/CSSImportRule.h:
* css/WebKitCSSShaderValue.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSImageValue.h
trunk/Source/WebCore/css/CSSImportRule.h
trunk/Source/WebCore/css/WebKitCSSShaderValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99705 => 99706)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 14:58:20 UTC (rev 99705)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 15:00:26 UTC (rev 99706)
@@ -1,3 +1,17 @@
+2011-11-09 Andreas Kling kl...@webkit.org
+
+CSS: Remove redudant WTF_MAKE_FAST_ALLOCATED macros.
+http://webkit.org/b/71897
+
+Reviewed by Antti Koivisto.
+
+Everything that inherits from RefCountedT is already fast-allocated,
+so we don't need this in subclasses.
+
+* css/CSSImageValue.h:
+* css/CSSImportRule.h:
+* css/WebKitCSSShaderValue.h:
+
2011-11-09 Igor Oliveira igor.olive...@openbossa.org
[TextureMapper] Clean up TextureMapperAnimation constructor
Modified: trunk/Source/WebCore/css/CSSImageValue.h (99705 => 99706)
--- trunk/Source/WebCore/css/CSSImageValue.h 2011-11-09 14:58:20 UTC (rev 99705)
+++ trunk/Source/WebCore/css/CSSImageValue.h 2011-11-09 15:00:26 UTC (rev 99706)
@@ -31,7 +31,6 @@
class StyleImage;
class CSSImageValue : public CSSPrimitiveValue {
-WTF_MAKE_FAST_ALLOCATED;
public:
static PassRefPtrCSSImageValue create() { return adoptRef(new CSSImageValue); }
static PassRefPtrCSSImageValue create(const String url) { return adoptRef(new CSSImageValue(url)); }
Modified: trunk/Source/WebCore/css/CSSImportRule.h (99705 => 99706)
--- trunk/Source/WebCore/css/CSSImportRule.h 2011-11-09 14:58:20 UTC (rev 99705)
+++ trunk/Source/WebCore/css/CSSImportRule.h 2011-11-09 15:00:26 UTC (rev 99706)
@@ -34,7 +34,6 @@
class MediaList;
class CSSImportRule : public CSSRule {
-WTF_MAKE_FAST_ALLOCATED;
public:
static PassRefPtrCSSImportRule create(CSSStyleSheet* parent, const String href, PassRefPtrMediaList media)
{
Modified: trunk/Source/WebCore/css/WebKitCSSShaderValue.h (99705 => 99706)
--- trunk/Source/WebCore/css/WebKitCSSShaderValue.h 2011-11-09 14:58:20 UTC (rev 99705)
+++ trunk/Source/WebCore/css/WebKitCSSShaderValue.h 2011-11-09 15:00:26 UTC (rev 99706)
@@ -37,10 +37,9 @@
namespace WebCore {
class WebKitCSSShaderValue : public CSSPrimitiveValue {
-WTF_MAKE_FAST_ALLOCATED;
public:
static PassRefPtrWebKitCSSShaderValue create(const String url) { return adoptRef(new WebKitCSSShaderValue(url)); }
-
+
private:
WebKitCSSShaderValue(const String url)
: CSSPrimitiveValue(WebKitCSSShaderClass, url, CSS_URI)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99721] trunk/LayoutTests
Title: [99721] trunk/LayoutTests
Revision 99721
Author kbal...@webkit.org
Date 2011-11-09 08:12:20 -0800 (Wed, 09 Nov 2011)
Log Message
[Qt] Unreviewed gardening.
Add platform results for Qt5.
* platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt
trunk/LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (99720 => 99721)
--- trunk/LayoutTests/ChangeLog 2011-11-09 15:58:33 UTC (rev 99720)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 16:12:20 UTC (rev 99721)
@@ -1,3 +1,12 @@
+2011-11-09 Balazs Kelemen kbal...@webkit.org
+
+[Qt] Unreviewed gardening.
+
+Add platform results for Qt5.
+
+* platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
+* platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt: Added.
+
2011-11-09 Andrey Kosyakov ca...@chromium.org
Web Inspector: [refactoring] remove a bunch of methods from _javascript_SourceFrameDelegate
Added: trunk/LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt (0 => 99721)
--- trunk/LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt 2011-11-09 16:12:20 UTC (rev 99721)
@@ -0,0 +1,11 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x19
+RenderText {#text} at (0,0) size 454x19
+ text run at (0,0) width 454: Images should redraw correctly when SVG animation runs
+ RenderBlock (anonymous) at (0,35) size 784x500
+RenderImage {IMG} at (10,10) size 480x480
+RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt (0 => 99721)
--- trunk/LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt (rev 0)
+++ trunk/LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt 2011-11-09 16:12:20 UTC (rev 99721)
@@ -0,0 +1,13 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x19
+RenderText {#text} at (0,0) size 454x19
+ text run at (0,0) width 454: Images should redraw correctly when SVG animation runs
+ RenderBlock (anonymous) at (0,35) size 784x548
+RenderImage {IMG} at (10,10) size 354x254 [border: (2px solid #00)]
+RenderBR {BR} at (374,274) size 0x0
+RenderImage {IMG} at (10,284) size 354x254 [border: (2px solid #00)]
+RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99722] trunk/Source/WebCore
Title: [99722] trunk/Source/WebCore
Revision 99722
Author andreas.kl...@nokia.com
Date 2011-11-09 08:19:29 -0800 (Wed, 09 Nov 2011)
Log Message
StyleSheet: Devirtualize styleSheetChanged().
http://webkit.org/b/71913
Reviewed by Antti Koivisto.
Since this mechanism is only used by CSSStyleSheet, move it there.
Out-of-lined StyleSheet::setDisabled() so we can do a type check
before invoking it from there.
* css/CSSStyleSheet.h:
* css/StyleSheet.cpp:
(WebCore::StyleSheet::setDisabled):
* css/StyleSheet.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSheet.h
trunk/Source/WebCore/css/StyleSheet.cpp
trunk/Source/WebCore/css/StyleSheet.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99721 => 99722)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 16:12:20 UTC (rev 99721)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 16:19:29 UTC (rev 99722)
@@ -1,3 +1,19 @@
+2011-11-09 Andreas Kling kl...@webkit.org
+
+StyleSheet: Devirtualize styleSheetChanged().
+http://webkit.org/b/71913
+
+Reviewed by Antti Koivisto.
+
+Since this mechanism is only used by CSSStyleSheet, move it there.
+Out-of-lined StyleSheet::setDisabled() so we can do a type check
+before invoking it from there.
+
+* css/CSSStyleSheet.h:
+* css/StyleSheet.cpp:
+(WebCore::StyleSheet::setDisabled):
+* css/StyleSheet.h:
+
2011-11-09 Simon Hausmann simon.hausm...@nokia.com
[Qt] Unreviewed, adding missing files to the build.
Modified: trunk/Source/WebCore/css/CSSStyleSheet.h (99721 => 99722)
--- trunk/Source/WebCore/css/CSSStyleSheet.h 2011-11-09 16:12:20 UTC (rev 99721)
+++ trunk/Source/WebCore/css/CSSStyleSheet.h 2011-11-09 16:19:29 UTC (rev 99722)
@@ -84,7 +84,7 @@
void addNamespace(CSSParser*, const AtomicString prefix, const AtomicString uri);
const AtomicString determineNamespace(const AtomicString prefix);
-virtual void styleSheetChanged();
+void styleSheetChanged();
virtual bool parseString(const String, bool strict = true);
Modified: trunk/Source/WebCore/css/StyleSheet.cpp (99721 => 99722)
--- trunk/Source/WebCore/css/StyleSheet.cpp 2011-11-09 16:12:20 UTC (rev 99721)
+++ trunk/Source/WebCore/css/StyleSheet.cpp 2011-11-09 16:19:29 UTC (rev 99722)
@@ -91,4 +91,11 @@
return KURL(baseURL(), url);
}
+void StyleSheet::setDisabled(bool disabled)
+{
+ m_disabled = disabled;
+ if (isCSSStyleSheet())
+ static_castCSSStyleSheet*(this)-styleSheetChanged();
}
+
+}
Modified: trunk/Source/WebCore/css/StyleSheet.h (99721 => 99722)
--- trunk/Source/WebCore/css/StyleSheet.h 2011-11-09 16:12:20 UTC (rev 99721)
+++ trunk/Source/WebCore/css/StyleSheet.h 2011-11-09 16:19:29 UTC (rev 99722)
@@ -38,7 +38,7 @@
virtual ~StyleSheet();
bool disabled() const { return m_disabled; }
-void setDisabled(bool disabled) { m_disabled = disabled; styleSheetChanged(); }
+void setDisabled(bool);
Node* ownerNode() const { return m_parentNode; }
void clearOwnerNode() { m_parentNode = 0; }
@@ -63,7 +63,6 @@
virtual String type() const = 0;
virtual bool isLoading() = 0;
-virtual void styleSheetChanged() { }
virtual KURL completeURL(const String url) const;
virtual bool parseString(const String, bool strict = true) = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99726] trunk/Source/WebKit/chromium
Title: [99726] trunk/Source/WebKit/chromium
Revision 99726
Author commit-qu...@webkit.org
Date 2011-11-09 09:07:42 -0800 (Wed, 09 Nov 2011)
Log Message
Adding missing implementation of WebMediaStreamDescriptor::label().
[Chromium] Missing WebMediaStreamDescriptor::label() implementation
https://bugs.webkit.org/show_bug.cgi?id=71657
Patch by Henrik Grunell grun...@chromium.org on 2011-11-09
Reviewed by Adam Barth.
* src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::label):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (99725 => 99726)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-09 17:01:49 UTC (rev 99725)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-09 17:07:42 UTC (rev 99726)
@@ -1,3 +1,15 @@
+2011-11-09 Henrik Grunell grun...@chromium.org
+
+Adding missing implementation of WebMediaStreamDescriptor::label().
+
+[Chromium] Missing WebMediaStreamDescriptor::label() implementation
+https://bugs.webkit.org/show_bug.cgi?id=71657
+
+Reviewed by Adam Barth.
+
+* src/WebMediaStreamDescriptor.cpp:
+(WebKit::WebMediaStreamDescriptor::label):
+
2011-11-09 Alexei Svitkine asvitk...@chromium.org
Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
Modified: trunk/Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp (99725 => 99726)
--- trunk/Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp 2011-11-09 17:01:49 UTC (rev 99725)
+++ trunk/Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp 2011-11-09 17:07:42 UTC (rev 99726)
@@ -48,6 +48,11 @@
m_private.reset();
}
+WebString WebMediaStreamDescriptor::label() const
+{
+return m_private-label();
+}
+
WebMediaStreamDescriptor WebMediaStreamDescriptor::operator=(const PassRefPtrWebCore::MediaStreamDescriptor mediaStreamDescriptor)
{
m_private = mediaStreamDescriptor;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99727] trunk
Title: [99727] trunk Revision 99727 Author ph...@webkit.org Date 2011-11-09 09:32:22 -0800 (Wed, 09 Nov 2011) Log Message Unreviewed, attempt to fix GTK 32-bits Release build after r99691. * Source/autotools/symbols.filter: Add the missing symbol for resetInternalsObject. Modified Paths trunk/ChangeLog trunk/Source/autotools/symbols.filter Diff Modified: trunk/ChangeLog (99726 => 99727) --- trunk/ChangeLog 2011-11-09 17:07:42 UTC (rev 99726) +++ trunk/ChangeLog 2011-11-09 17:32:22 UTC (rev 99727) @@ -1,3 +1,9 @@ +2011-11-09 Philippe Normand pnorm...@igalia.com + +Unreviewed, attempt to fix GTK 32-bits Release build after r99691. + +* Source/autotools/symbols.filter: Add the missing symbol for resetInternalsObject. + 2011-11-09 Tor Arne Vestbø tor.arne.ves...@nokia.com [Qt] Only copy framework headers once when debug_and_release is enabled Modified: trunk/Source/autotools/symbols.filter (99726 => 99727) --- trunk/Source/autotools/symbols.filter 2011-11-09 17:07:42 UTC (rev 99726) +++ trunk/Source/autotools/symbols.filter 2011-11-09 17:32:22 UTC (rev 99727) @@ -81,6 +81,7 @@ _ZN7WebCore10ScrollView23setScrollbarsSuppressedEbb; _ZN7WebCore9FrameView17paintControlTintsEv; _ZN7WebCore9FrameView19scrollElementToRectEPNS_7ElementERKNS_7IntRectE; +_ZN18WebCoreTestSupport20resetInternalsObjectEPK15OpaqueJSContext; local: _Z*; cti*; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99728] trunk/Source/WebKit/efl
Title: [99728] trunk/Source/WebKit/efl
Revision 99728
Author commit-qu...@webkit.org
Date 2011-11-09 09:32:47 -0800 (Wed, 09 Nov 2011)
Log Message
[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=71891
Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-11-09
Reviewed by Antonio Gomes.
This is C++ code, there is no need to cast the new objects to their
parents when creating them.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (99727 => 99728)
--- trunk/Source/WebKit/efl/ChangeLog 2011-11-09 17:32:22 UTC (rev 99727)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-11-09 17:32:47 UTC (rev 99728)
@@ -1,3 +1,16 @@
+2011-11-09 Raphael Kubo da Costa k...@profusion.mobi
+
+[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
+https://bugs.webkit.org/show_bug.cgi?id=71891
+
+Reviewed by Antonio Gomes.
+
+This is C++ code, there is no need to cast the new objects to their
+parents when creating them.
+
+* ewk/ewk_view.cpp:
+(_ewk_view_priv_new):
+
2011-11-09 Tomasz Morawski t.moraw...@samsung.com
[EFL] Removed unused variable
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (99727 => 99728)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-11-09 17:32:22 UTC (rev 99727)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-11-09 17:32:47 UTC (rev 99728)
@@ -603,13 +603,13 @@
}
WebCore::Page::PageClients pageClients;
-pageClients.chromeClient = static_castWebCore::ChromeClient*(new WebCore::ChromeClientEfl(smartData-self));
-pageClients.editorClient = static_castWebCore::EditorClient*(new WebCore::EditorClientEfl(smartData-self));
-pageClients.dragClient = static_castWebCore::DragClient*(new WebCore::DragClientEfl);
-pageClients.inspectorClient = static_castWebCore::InspectorClient*(new WebCore::InspectorClientEfl);
+pageClients.chromeClient = new WebCore::ChromeClientEfl(smartData-self);
+pageClients.editorClient = new WebCore::EditorClientEfl(smartData-self);
+pageClients.dragClient = new WebCore::DragClientEfl;
+pageClients.inspectorClient = new WebCore::InspectorClientEfl;
#if ENABLE(DEVICE_ORIENTATION)
-pageClients.deviceMotionClient = static_castWebCore::DeviceMotionClient*(new WebCore::DeviceMotionClientEfl);
-pageClients.deviceOrientationClient = static_castWebCore::DeviceOrientationClient*(new WebCore::DeviceOrientationClientEfl);
+pageClients.deviceMotionClient = new WebCore::DeviceMotionClientEfl;
+pageClients.deviceOrientationClient = new WebCore::DeviceOrientationClientEfl;
#endif
priv-page = new WebCore::Page(pageClients);
if (!priv-page) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99730] trunk/Source/WebCore
Title: [99730] trunk/Source/WebCore
Revision 99730
Author andreas.kl...@nokia.com
Date 2011-11-09 10:01:04 -0800 (Wed, 09 Nov 2011)
Log Message
Shrink StyleSheet on 64-bit.
http://webkit.org/b/71923
Reviewed by Darin Adler.
Move m_disabled to the top so it folds into the padding at
the end of RefCounted on 64-bit, shrinking StyleSheet by 8 bytes.
* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
* css/StyleSheet.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleSheet.cpp
trunk/Source/WebCore/css/StyleSheet.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99729 => 99730)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 17:40:35 UTC (rev 99729)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 18:01:04 UTC (rev 99730)
@@ -1,5 +1,19 @@
2011-11-09 Andreas Kling kl...@webkit.org
+Shrink StyleSheet on 64-bit.
+http://webkit.org/b/71923
+
+Reviewed by Darin Adler.
+
+Move m_disabled to the top so it folds into the padding at
+the end of RefCounted on 64-bit, shrinking StyleSheet by 8 bytes.
+
+* css/StyleSheet.cpp:
+(WebCore::StyleSheet::StyleSheet):
+* css/StyleSheet.h:
+
+2011-11-09 Andreas Kling kl...@webkit.org
+
StyleSheet: Devirtualize styleSheetChanged().
http://webkit.org/b/71913
Modified: trunk/Source/WebCore/css/StyleSheet.cpp (99729 => 99730)
--- trunk/Source/WebCore/css/StyleSheet.cpp 2011-11-09 17:40:35 UTC (rev 99729)
+++ trunk/Source/WebCore/css/StyleSheet.cpp 2011-11-09 18:01:04 UTC (rev 99730)
@@ -29,20 +29,20 @@
namespace WebCore {
StyleSheet::StyleSheet(Node* parentNode, const String originalURL, const KURL finalURL)
-: m_parentRule(0)
+: m_disabled(false)
+, m_parentRule(0)
, m_parentNode(parentNode)
, m_originalURL(originalURL)
, m_finalURL(finalURL)
-, m_disabled(false)
{
}
StyleSheet::StyleSheet(CSSRule* parentRule, const String originalURL, const KURL finalURL)
-: m_parentRule(parentRule)
+: m_disabled(false)
+, m_parentRule(parentRule)
, m_parentNode(0)
, m_originalURL(originalURL)
, m_finalURL(finalURL)
-, m_disabled(false)
{
}
Modified: trunk/Source/WebCore/css/StyleSheet.h (99729 => 99730)
--- trunk/Source/WebCore/css/StyleSheet.h 2011-11-09 17:40:35 UTC (rev 99729)
+++ trunk/Source/WebCore/css/StyleSheet.h 2011-11-09 18:01:04 UTC (rev 99730)
@@ -77,13 +77,13 @@
StyleSheet(CSSRule* parentRule, const String href, const KURL finalURL);
private:
+bool m_disabled;
CSSRule* m_parentRule;
Node* m_parentNode;
String m_originalURL;
KURL m_finalURL;
String m_strTitle;
RefPtrMediaList m_media;
-bool m_disabled;
};
} // namespace
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99731] trunk
Title: [99731] trunk
Revision 99731
Author commit-qu...@webkit.org
Date 2011-11-09 10:02:50 -0800 (Wed, 09 Nov 2011)
Log Message
SVG foreignObject wrong container
https://bugs.webkit.org/show_bug.cgi?id=64780
Patch by Ken Buchanan ke...@chromium.org on 2011-11-09
Reviewed by Simon Fraser.
Source/WebCore:
Resubmitting a patch originally by scot...@chromium.org.
In determining where to add to m_positionedObjects during a repaint,
containingBlock is used, which adds the absolute positioned object to
the containing foreignObject. But, when the contained object is
dirtied, container() was used to dirty up the tree, which skipped over
the foreignObject causing the wrong parent to needsLayout(). This fix
makes container() and containingBlock() handle svg foreignObject's in
the same way.
This patch will cause svg/overflow/overflow-on-foreignObject.svg to
require rebaselined results on qt and gtk ports.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::container):
LayoutTests:
Added layout test for 64780 fix, rebaselined a test that it broke.
This will cause gtk and qt ports to also need rebaseline.
* platform/mac/svg/overflow/overflow-on-foreignObject-expected.png: Rebaseline
* platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
* svg/foreignObject/absolute-position-foreign-object-child-crash.html: Added
* svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt: Added
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.png
trunk/LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Added Paths
trunk/LayoutTests/svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt
trunk/LayoutTests/svg/foreignObject/absolute-position-foreign-object-child-crash.html
Property Changed
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (99730 => 99731)
--- trunk/LayoutTests/ChangeLog 2011-11-09 18:01:04 UTC (rev 99730)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 18:02:50 UTC (rev 99731)
@@ -1,3 +1,18 @@
+2011-11-09 Ken Buchanan ke...@chromium.org
+
+SVG foreignObject wrong container
+https://bugs.webkit.org/show_bug.cgi?id=64780
+
+Reviewed by Simon Fraser.
+
+Added layout test for 64780 fix, rebaselined a test that it broke.
+This will cause gtk and qt ports to also need rebaseline.
+
+* platform/mac/svg/overflow/overflow-on-foreignObject-expected.png: Rebaseline
+* platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
+* svg/foreignObject/absolute-position-foreign-object-child-crash.html: Added
+* svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt: Added
+
2011-11-09 Pavel Feldman pfeld...@google.com
Not reviewed: make new inspector test pass on Qt.
Property changes on: trunk/LayoutTests/ChangeLog
___
Added: svn:executable
Modified: trunk/LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt (99730 => 99731)
--- trunk/LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt 2011-11-09 18:01:04 UTC (rev 99730)
+++ trunk/LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt 2011-11-09 18:02:50 UTC (rev 99731)
@@ -3,5 +3,5 @@
layer at (0,0) size 500x500
RenderSVGRoot {svg} at (200,200) size 300x300
RenderSVGForeignObject {foreignObject} at (100,100) size 300x300
-layer at (100,100) size 6006x6006 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
- RenderBlock (positioned) {html:div} at (100,100) size 6006x6006 [bgcolor=#008000] [border: (3px solid #00)]
+layer at (0,0) size 6006x6006 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
+ RenderBlock (positioned) {html:div} at (0,0) size 6006x6006 [bgcolor=#008000] [border: (3px solid #00)]
Added: trunk/LayoutTests/svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt (0 => 99731)
--- trunk/LayoutTests/svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt 2011-11-09 18:02:50 UTC (rev 99731)
@@ -0,0 +1 @@
+PASS
Property changes on: trunk/LayoutTests/svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt
___
Added: svn:executable
Added:
[webkit-changes] [99732] trunk/Source/WebCore
Title: [99732] trunk/Source/WebCore Revision 99732 Author hara...@chromium.org Date 2011-11-09 10:07:12 -0800 (Wed, 09 Nov 2011) Log Message Remove redundant [CanBeConstructed] IDLs https://bugs.webkit.org/show_bug.cgi?id=71868 Reviewed by Adam Barth. If a class has [Constructor] or [CustomConstructor], then [CanBeConstructed] is not necessary. This patch just removes [CanBeConstructed] from all the classes that already have [Constructor] or [CustomConstructor]. No tests. No change in behavior. * bindings/scripts/CodeGeneratorV8.pm: Corrected typo. This correction is required for this patch. * bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-bindings-tests result. (WebCore::ConfigureV8TestObjTemplate): * css/WebKitCSSMatrix.idl: * dom/BeforeLoadEvent.idl: * dom/CustomEvent.idl: * dom/ErrorEvent.idl: * dom/Event.idl: * dom/HashChangeEvent.idl: * dom/MessageChannel.idl: * dom/MessageEvent.idl: * dom/OverflowEvent.idl: * dom/PageTransitionEvent.idl: * dom/PopStateEvent.idl: * dom/ProgressEvent.idl: * dom/WebKitAnimationEvent.idl: * dom/WebKitMutationObserver.idl: * dom/WebKitTransitionEvent.idl: * fileapi/FileReader.idl: * html/DOMFormData.idl: * html/TextTrackCue.idl: * html/canvas/ArrayBuffer.idl: * html/canvas/DataView.idl: * html/canvas/Float32Array.idl: * html/canvas/Float64Array.idl: * html/canvas/Int16Array.idl: * html/canvas/Int32Array.idl: * html/canvas/Int8Array.idl: * html/canvas/Uint16Array.idl: * html/canvas/Uint32Array.idl: * html/canvas/Uint8Array.idl: * html/track/TrackEvent.idl: * mediastream/PeerConnection.idl: * page/EventSource.idl: * page/WebKitPoint.idl: * webaudio/AudioContext.idl: * websockets/CloseEvent.idl: * websockets/WebSocket.idl: * workers/SharedWorker.idl: * workers/Worker.idl: * xml/XMLHttpRequest.idl: * xml/XSLTProcessor.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp trunk/Source/WebCore/css/WebKitCSSMatrix.idl trunk/Source/WebCore/dom/BeforeLoadEvent.idl trunk/Source/WebCore/dom/CustomEvent.idl trunk/Source/WebCore/dom/ErrorEvent.idl trunk/Source/WebCore/dom/Event.idl trunk/Source/WebCore/dom/HashChangeEvent.idl trunk/Source/WebCore/dom/MessageChannel.idl trunk/Source/WebCore/dom/MessageEvent.idl trunk/Source/WebCore/dom/OverflowEvent.idl trunk/Source/WebCore/dom/PageTransitionEvent.idl trunk/Source/WebCore/dom/PopStateEvent.idl trunk/Source/WebCore/dom/ProgressEvent.idl trunk/Source/WebCore/dom/WebKitAnimationEvent.idl trunk/Source/WebCore/dom/WebKitMutationObserver.idl trunk/Source/WebCore/dom/WebKitTransitionEvent.idl trunk/Source/WebCore/fileapi/FileReader.idl trunk/Source/WebCore/html/DOMFormData.idl trunk/Source/WebCore/html/TextTrackCue.idl trunk/Source/WebCore/html/canvas/ArrayBuffer.idl trunk/Source/WebCore/html/canvas/DataView.idl trunk/Source/WebCore/html/canvas/Float32Array.idl trunk/Source/WebCore/html/canvas/Float64Array.idl trunk/Source/WebCore/html/canvas/Int16Array.idl trunk/Source/WebCore/html/canvas/Int32Array.idl trunk/Source/WebCore/html/canvas/Int8Array.idl trunk/Source/WebCore/html/canvas/Uint16Array.idl trunk/Source/WebCore/html/canvas/Uint32Array.idl trunk/Source/WebCore/html/canvas/Uint8Array.idl trunk/Source/WebCore/html/track/TrackEvent.idl trunk/Source/WebCore/mediastream/PeerConnection.idl trunk/Source/WebCore/page/EventSource.idl trunk/Source/WebCore/page/WebKitPoint.idl trunk/Source/WebCore/webaudio/AudioContext.idl trunk/Source/WebCore/websockets/CloseEvent.idl trunk/Source/WebCore/websockets/WebSocket.idl trunk/Source/WebCore/workers/SharedWorker.idl trunk/Source/WebCore/workers/Worker.idl trunk/Source/WebCore/xml/XMLHttpRequest.idl trunk/Source/WebCore/xml/XSLTProcessor.idl Diff Modified: trunk/Source/WebCore/ChangeLog (99731 => 99732) --- trunk/Source/WebCore/ChangeLog 2011-11-09 18:02:50 UTC (rev 99731) +++ trunk/Source/WebCore/ChangeLog 2011-11-09 18:07:12 UTC (rev 99732) @@ -1,3 +1,60 @@ +2011-11-09 Kentaro Hara hara...@chromium.org + +Remove redundant [CanBeConstructed] IDLs +https://bugs.webkit.org/show_bug.cgi?id=71868 + +Reviewed by Adam Barth. + +If a class has [Constructor] or [CustomConstructor], +then [CanBeConstructed] is not necessary. +This patch just removes [CanBeConstructed] from all the classes +that already have [Constructor] or [CustomConstructor]. + +No tests. No change in behavior. + +* bindings/scripts/CodeGeneratorV8.pm: Corrected typo. This correction is required for this patch. +* bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-bindings-tests result. +(WebCore::ConfigureV8TestObjTemplate): +* css/WebKitCSSMatrix.idl: +* dom/BeforeLoadEvent.idl: +* dom/CustomEvent.idl: +* dom/ErrorEvent.idl: +* dom/Event.idl: +* dom/HashChangeEvent.idl: +* dom/MessageChannel.idl: +* dom/MessageEvent.idl: +*
[webkit-changes] [99733] trunk/Source/JavaScriptCore
Title: [99733] trunk/Source/_javascript_Core
Revision 99733
Author da...@apple.com
Date 2011-11-09 10:11:47 -0800 (Wed, 09 Nov 2011)
Log Message
Add code path in HashTable for emptyValueIsZero that does not require copying the empty value
https://bugs.webkit.org/show_bug.cgi?id=71875
Reviewed by Anders Carlsson.
This is a step along the path of making OwnPtr work as HashMap value types.
* wtf/Alignment.h: Moved the AlignedBufferChar and AlignedBuffer types from Vector.h here.
Also fixed include style. To include other WTF headers inside WTF, we use includes.
I did not change the code to fix style checker complaints.
* wtf/HashTable.h: Added includes as needed and fixed include style.
(WTF::doubleHash): Removed the uneeeded and inappropriate static in this function, which
gave it internal linkage for no good reason.
(WTF::HashTable::checkKey): Made this use AlignedBuffer for the deleted value check to avoid
construction/destruction problems instead of doing the trick where we construct and destroy
an empty value twice. It's cleaner and simpler and avoids copying the empty value.
(WTF::HashTable::initializeBucket): Specialized initializeBucket to use memset when the
empty value is zero rather than copying an empty value.
* wtf/Vector.h: Moved the AlignedBufferChar and AlignedBuffer types into Alignment.h.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Alignment.h
trunk/Source/_javascript_Core/wtf/HashTable.h
trunk/Source/_javascript_Core/wtf/Vector.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (99732 => 99733)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 18:07:12 UTC (rev 99732)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 18:11:47 UTC (rev 99733)
@@ -1,3 +1,27 @@
+2011-11-08 Darin Adler da...@apple.com
+
+Add code path in HashTable for emptyValueIsZero that does not require copying the empty value
+https://bugs.webkit.org/show_bug.cgi?id=71875
+
+Reviewed by Anders Carlsson.
+
+This is a step along the path of making OwnPtr work as HashMap value types.
+
+* wtf/Alignment.h: Moved the AlignedBufferChar and AlignedBuffer types from Vector.h here.
+Also fixed include style. To include other WTF headers inside WTF, we use includes.
+I did not change the code to fix style checker complaints.
+
+* wtf/HashTable.h: Added includes as needed and fixed include style.
+(WTF::doubleHash): Removed the uneeeded and inappropriate static in this function, which
+gave it internal linkage for no good reason.
+(WTF::HashTable::checkKey): Made this use AlignedBuffer for the deleted value check to avoid
+construction/destruction problems instead of doing the trick where we construct and destroy
+an empty value twice. It's cleaner and simpler and avoids copying the empty value.
+(WTF::HashTable::initializeBucket): Specialized initializeBucket to use memset when the
+empty value is zero rather than copying an empty value.
+
+* wtf/Vector.h: Moved the AlignedBufferChar and AlignedBuffer types into Alignment.h.
+
2011-11-09 Gabor Rapcsanyi rga...@webkit.org
Buildfix for 32bit debug mode.
Modified: trunk/Source/_javascript_Core/wtf/Alignment.h (99732 => 99733)
--- trunk/Source/_javascript_Core/wtf/Alignment.h 2011-11-09 18:07:12 UTC (rev 99732)
+++ trunk/Source/_javascript_Core/wtf/Alignment.h 2011-11-09 18:11:47 UTC (rev 99733)
@@ -21,8 +21,11 @@
#ifndef WTF_Alignment_h
#define WTF_Alignment_h
-#include wtf/Platform.h
+#include Platform.h
+#include algorithm
+namespace WTF {
+
#if COMPILER(GCC) || COMPILER(MINGW) || COMPILER(RVCT) || COMPILER(WINSCW) || COMPILER(GCCE)
#define WTF_ALIGN_OF(type) __alignof__(type)
#define WTF_ALIGNED(variable_type, variable, n) variable_type variable __attribute__((__aligned__(n)))
@@ -33,4 +36,28 @@
#error WTF_ALIGN macros need alignment control.
#endif
+#if COMPILER(GCC) !COMPILER(INTEL) (((__GNUC__ * 100) + __GNUC_MINOR__) = 303)
+typedef char __attribute__((__may_alias__)) AlignedBufferChar;
+#else
+typedef char AlignedBufferChar;
+#endif
+
+templatesize_t size, size_t alignment struct AlignedBuffer;
+templatesize_t size struct AlignedBuffersize, 1 { AlignedBufferChar buffer[size]; };
+templatesize_t size struct AlignedBuffersize, 2 { WTF_ALIGNED(AlignedBufferChar, buffer[size], 2); };
+templatesize_t size struct AlignedBuffersize, 4 { WTF_ALIGNED(AlignedBufferChar, buffer[size], 4); };
+templatesize_t size struct AlignedBuffersize, 8 { WTF_ALIGNED(AlignedBufferChar, buffer[size], 8); };
+templatesize_t size struct AlignedBuffersize, 16 { WTF_ALIGNED(AlignedBufferChar, buffer[size], 16); };
+templatesize_t size struct AlignedBuffersize, 32 { WTF_ALIGNED(AlignedBufferChar, buffer[size], 32); };
+templatesize_t size struct AlignedBuffersize, 64 { WTF_ALIGNED(AlignedBufferChar,
[webkit-changes] [99734] trunk/Source/WebCore
Title: [99734] trunk/Source/WebCore
Revision 99734
Author andreas.kl...@nokia.com
Date 2011-11-09 10:14:09 -0800 (Wed, 09 Nov 2011)
Log Message
Shrink HTMLCollection.
http://webkit.org/b/71928
Reviewed by Darin Adler.
Rearrange the members of HTMLCollection, effectively shrinking
it by 16 bytes on 64-bit. This reduces memory consumption
by 531 kB when loading the full HTML5 spec.
On 32-bit it shrinks by 8 bytes, saving 265 kB.
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
* html/HTMLCollection.h:
(WebCore::HTMLCollection::type):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCollection.cpp
trunk/Source/WebCore/html/HTMLCollection.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99733 => 99734)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 18:11:47 UTC (rev 99733)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 18:14:09 UTC (rev 99734)
@@ -1,3 +1,21 @@
+2011-11-09 Andreas Kling kl...@webkit.org
+
+Shrink HTMLCollection.
+http://webkit.org/b/71928
+
+Reviewed by Darin Adler.
+
+Rearrange the members of HTMLCollection, effectively shrinking
+it by 16 bytes on 64-bit. This reduces memory consumption
+by 531 kB when loading the full HTML5 spec.
+
+On 32-bit it shrinks by 8 bytes, saving 265 kB.
+
+* html/HTMLCollection.cpp:
+(WebCore::HTMLCollection::HTMLCollection):
+* html/HTMLCollection.h:
+(WebCore::HTMLCollection::type):
+
2011-11-09 Kentaro Hara hara...@chromium.org
Remove redundant [CanBeConstructed] IDLs
Modified: trunk/Source/WebCore/html/HTMLCollection.cpp (99733 => 99734)
--- trunk/Source/WebCore/html/HTMLCollection.cpp 2011-11-09 18:11:47 UTC (rev 99733)
+++ trunk/Source/WebCore/html/HTMLCollection.cpp 2011-11-09 18:14:09 UTC (rev 99734)
@@ -38,19 +38,19 @@
HTMLCollection::HTMLCollection(PassRefPtrNode base, CollectionType type)
: m_idsDone(false)
+, m_ownsInfo(false)
+, m_type(type)
, m_base(base)
-, m_type(type)
, m_info(m_base-isDocumentNode() ? static_castDocument*(m_base.get())-collectionInfo(type) : 0)
-, m_ownsInfo(false)
{
}
HTMLCollection::HTMLCollection(PassRefPtrNode base, CollectionType type, CollectionCache* info)
: m_idsDone(false)
+, m_ownsInfo(false)
+, m_type(type)
, m_base(base)
-, m_type(type)
, m_info(info)
-, m_ownsInfo(false)
{
}
Modified: trunk/Source/WebCore/html/HTMLCollection.h (99733 => 99734)
--- trunk/Source/WebCore/html/HTMLCollection.h 2011-11-09 18:11:47 UTC (rev 99733)
+++ trunk/Source/WebCore/html/HTMLCollection.h 2011-11-09 18:14:09 UTC (rev 99734)
@@ -57,7 +57,7 @@
PassRefPtrNodeList tags(const String);
Node* base() const { return m_base.get(); }
-CollectionType type() const { return m_type; }
+CollectionType type() const { return static_castCollectionType(m_type); }
protected:
HTMLCollection(PassRefPtrNode base, CollectionType, CollectionCache*);
@@ -66,7 +66,7 @@
CollectionCache* info() const { return m_info; }
void resetCollectionInfo() const;
-mutable bool m_idsDone; // for nextNamedItem()
+mutable bool m_idsDone : 1; // for nextNamedItem()
private:
virtual Element* itemAfter(Element*) const;
@@ -74,12 +74,12 @@
virtual void updateNameCache() const;
bool checkForNameMatch(Element*, bool checkName, const AtomicString name) const;
+mutable bool m_ownsInfo : 1;
+unsigned m_type : 5; // CollectionType
RefPtrNode m_base;
-CollectionType m_type;
mutable CollectionCache* m_info;
-mutable bool m_ownsInfo;
};
} // namespace
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99735] trunk/Source/WebKit2
Title: [99735] trunk/Source/WebKit2
Revision 99735
Author ach...@adobe.com
Date 2011-11-09 10:41:14 -0800 (Wed, 09 Nov 2011)
Log Message
Fixing build on MacOSX SL after 71838
https://bugs.webkit.org/show_bug.cgi?id=71912
Reviewed by Anders Carlsson.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99734 => 99735)
--- trunk/Source/WebKit2/ChangeLog 2011-11-09 18:14:09 UTC (rev 99734)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-09 18:41:14 UTC (rev 99735)
@@ -1,3 +1,13 @@
+2011-11-09 Alexandru Chiculita ach...@adobe.com
+
+Fixing build on MacOSX SL after 71838
+https://bugs.webkit.org/show_bug.cgi?id=71912
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
+
2011-11-09 Kenneth Rohde Christiansen kenn...@webkit.org
[WebKit2] Prepare viewport meta handling for desktop usage
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (99734 => 99735)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2011-11-09 18:14:09 UTC (rev 99734)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2011-11-09 18:41:14 UTC (rev 99735)
@@ -51,7 +51,7 @@
{
m_rootLayer = [CALayer layer];
-m_rootLayer.get().frame = m_webPage-bounds();
+m_rootLayer.get().frame = (CGRect)m_webPage-bounds();
m_rootLayer.get().opaque = YES;
// Give the root layer a background color so it's visible on screen.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99736] trunk/LayoutTests
Title: [99736] trunk/LayoutTests
Revision 99736
Author x...@chromium.org
Date 2011-11-09 10:44:25 -0800 (Wed, 09 Nov 2011)
Log Message
Rebaseline after r99616.
* platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Added Paths
trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
trunk/LayoutTests/platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png
trunk/LayoutTests/platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png
trunk/LayoutTests/platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (99735 => 99736)
--- trunk/LayoutTests/ChangeLog 2011-11-09 18:41:14 UTC (rev 99735)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 18:44:25 UTC (rev 99736)
@@ -1,3 +1,13 @@
+2011-11-09 Xiaomei Ji x...@chromium.org
+
+Rebaseline after r99616.
+
+* platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
+* platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
+* platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
+* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
2011-11-09 Ken Buchanan ke...@chromium.org
SVG foreignObject wrong container
Added: trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt (0 => 99736)
--- trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt 2011-11-09 18:44:25 UTC (rev 99736)
@@ -0,0 +1,8 @@
+layer at (0,0) size 329x4018
+ RenderView at (0,0) size 329x573
+layer at (0,0) size 329x4018
+ RenderBlock {HTML} at (0,0) size 329x4018
+RenderBody {BODY} at (8,8) size 313x4002
+ RenderBlock {DIV} at (-689,0) size 1002x4002 [border: (1px solid #FF)]
+RenderText {#text} at (-491,1) size 1492x18
+ text run at (-491,1) width 1492: BEGINEND
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99735 => 99736)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 18:41:14 UTC (rev 99735)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 18:44:25 UTC (rev 99736)
@@ -3949,6 +3949,6 @@
BUGRICOW : fast/js/toString-recursion.html = TEXT
BUGRICOW : http/tests/security/xss-eval.html = TEXT
-BUGXJI : fast/dom/rtl-scroll-to-leftmost-and-resize.html = IMAGE+TEXT MISSING
+BUGWK70395 MAC : fast/dom/rtl-scroll-to-leftmost-and-resize.html = IMAGE+TEXT
BUGWK71880 DEBUG : fast/forms/select-clientheight-large-size.html = TIMEOUT
Added: trunk/LayoutTests/platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt (0 => 99736)
--- trunk/LayoutTests/platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt 2011-11-09 18:44:25 UTC (rev 99736)
@@ -0,0 +1,8 @@
+layer at (0,0) size 329x4018
+ RenderView at (0,0) size 329x573
+layer at (0,0) size 329x4018
+ RenderBlock {HTML} at (0,0) size 329x4018
+RenderBody {BODY} at (8,8) size 313x4002
+ RenderBlock {DIV} at (-689,0) size 1002x4002 [border: (1px solid #FF)]
+RenderText {#text} at (-486,1) size 1487x19
+ text run at (-486,1) width 1487:
[webkit-changes] [99737] trunk/LayoutTests
Title: [99737] trunk/LayoutTests
Revision 99737
Author ph...@webkit.org
Date 2011-11-09 10:46:15 -0800 (Wed, 09 Nov 2011)
Log Message
Unreviewed, GTK new baselines for 2 svg tests and skip a crashing
test that needs investigation.
* platform/gtk/Skipped:
* platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
Added Paths
trunk/LayoutTests/platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt
trunk/LayoutTests/platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (99736 => 99737)
--- trunk/LayoutTests/ChangeLog 2011-11-09 18:44:25 UTC (rev 99736)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 18:46:15 UTC (rev 99737)
@@ -1,3 +1,12 @@
+2011-11-09 Philippe Normand pnorm...@igalia.com
+
+Unreviewed, GTK new baselines for 2 svg tests and skip a crashing
+test that needs investigation.
+
+* platform/gtk/Skipped:
+* platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
+* platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
+
2011-11-09 Xiaomei Ji x...@chromium.org
Rebaseline after r99616.
Modified: trunk/LayoutTests/platform/gtk/Skipped (99736 => 99737)
--- trunk/LayoutTests/platform/gtk/Skipped 2011-11-09 18:44:25 UTC (rev 99736)
+++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-09 18:46:15 UTC (rev 99737)
@@ -159,6 +159,9 @@
fast/css/webkit-mask-crash-fieldset-legend.html
fast/css/webkit-mask-crash-table.html
+# https://bugs.webkit.org/show_bug.cgi?id=71932
+svg/as-image/svg-image-change-content-size.xhtml
+
###
# EXPECTED FAILURES
###
Added: trunk/LayoutTests/platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt (0 => 99737)
--- trunk/LayoutTests/platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt 2011-11-09 18:46:15 UTC (rev 99737)
@@ -0,0 +1,11 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x19
+RenderText {#text} at (0,0) size 371x19
+ text run at (0,0) width 371: Images should redraw correctly when SVG animation runs
+ RenderBlock (anonymous) at (0,35) size 784x500
+RenderImage {IMG} at (10,10) size 480x480
+RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt (0 => 99737)
--- trunk/LayoutTests/platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt 2011-11-09 18:46:15 UTC (rev 99737)
@@ -0,0 +1,13 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x19
+RenderText {#text} at (0,0) size 371x19
+ text run at (0,0) width 371: Images should redraw correctly when SVG animation runs
+ RenderBlock (anonymous) at (0,35) size 784x548
+RenderImage {IMG} at (10,10) size 354x254 [border: (2px solid #00)]
+RenderBR {BR} at (374,274) size 0x0
+RenderImage {IMG} at (10,284) size 354x254 [border: (2px solid #00)]
+RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99738] branches/chromium/912/Source/WebCore/bindings/v8
Title: [99738] branches/chromium/912/Source/WebCore/bindings/v8
Revision 99738
Author jap...@chromium.org
Date 2011-11-09 10:57:21 -0800 (Wed, 09 Nov 2011)
Log Message
Merge 99311 - [V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
https://bugs.webkit.org/show_bug.cgi?id=71569
Reviewed by Adam Barth.
No new tests, this has only been successfully triggered
using ppapi flash.
* bindings/v8/V8Helpers.cpp:
(WebCore::toV8Context):
* bindings/v8/npruntime.cpp:
TBR=jap...@chromium.org
Review URL: http://codereview.chromium.org/8511019
Modified Paths
branches/chromium/912/Source/WebCore/bindings/v8/V8Helpers.cpp
branches/chromium/912/Source/WebCore/bindings/v8/npruntime.cpp
Diff
Modified: branches/chromium/912/Source/WebCore/bindings/v8/V8Helpers.cpp (99737 => 99738)
--- branches/chromium/912/Source/WebCore/bindings/v8/V8Helpers.cpp 2011-11-09 18:46:15 UTC (rev 99737)
+++ branches/chromium/912/Source/WebCore/bindings/v8/V8Helpers.cpp 2011-11-09 18:57:21 UTC (rev 99738)
@@ -32,6 +32,7 @@
#include V8Helpers.h
#include DOMWindow.h
+#include Frame.h
#include NPV8Object.h
#include V8Proxy.h
@@ -40,6 +41,9 @@
v8::Localv8::Context toV8Context(NPP npp, NPObject* npObject)
{
V8NPObject* object = reinterpret_castV8NPObject*(npObject);
+DOMWindow* domWindow = object-rootObject;
+if (!domWindow || domWindow != domWindow-frame()-domWindow())
+return v8::Localv8::Context();
return V8Proxy::mainWorldContext(object-rootObject-frame());
}
Modified: branches/chromium/912/Source/WebCore/bindings/v8/npruntime.cpp (99737 => 99738)
--- branches/chromium/912/Source/WebCore/bindings/v8/npruntime.cpp 2011-11-09 18:46:15 UTC (rev 99737)
+++ branches/chromium/912/Source/WebCore/bindings/v8/npruntime.cpp 2011-11-09 18:57:21 UTC (rev 99738)
@@ -418,6 +418,13 @@
set-remove(sub_object);
liveObjectMap.remove(sub_object);
+// Script objects hold a refernce to their DOMWindow*, which is going away if
+// we're unregistering the associated owner NPObject. Clear it out.
+if (sub_object-_class == npScriptObjectClass) {
+V8NPObject* v8npObject = reinterpret_castV8NPObject*(sub_object);
+v8npObject-rootObject = 0;
+}
+
// Remove the JS references to the object.
forgetV8ObjectForNPObject(sub_object);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99739] trunk/LayoutTests
Title: [99739] trunk/LayoutTests Revision 99739 Author o...@chromium.org Date 2011-11-09 11:03:20 -0800 (Wed, 09 Nov 2011) Log Message Remove failures fixed with r99630. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (99738 => 99739) --- trunk/LayoutTests/ChangeLog 2011-11-09 18:57:21 UTC (rev 99738) +++ trunk/LayoutTests/ChangeLog 2011-11-09 19:03:20 UTC (rev 99739) @@ -1,3 +1,9 @@ +2011-11-09 Ojan Vafai o...@chromium.org + +Remove failures fixed with r99630. + +* platform/chromium/test_expectations.txt: + 2011-11-09 Philippe Normand pnorm...@igalia.com Unreviewed, GTK new baselines for 2 svg tests and skip a crashing Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (99738 => 99739) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 18:57:21 UTC (rev 99738) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-09 19:03:20 UTC (rev 99739) @@ -3934,12 +3934,6 @@ BUGWK71830 : svg/zoom/page/zoom-svg-as-relative-image.html = IMAGE BUGWK71830 WIN MAC : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE+TEXT -BUGWK71863 : fast/block/positioning/vertical-rl/001.html = IMAGE -BUGWK71863 : fast/multicol/vertical-rl/float-avoidance.html = IMAGE -BUGWK71863 : fast/multicol/vertical-rl/float-paginate-complex.html = IMAGE -BUGWK71863 : fast/multicol/vertical-rl/column-break-with-balancing.html = IMAGE -BUGWK71863 : fast/multicol/vertical-rl/column-rules.html = IMAGE - BUG_OJAN : storage/indexeddb/key-type-array.html = TIMEOUT CRASH BUGRICOW : fast/js/array-functions-non-arrays.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99740] trunk
Title: [99740] trunk
Revision 99740
Author cfleiz...@apple.com
Date 2011-11-09 11:08:03 -0800 (Wed, 09 Nov 2011)
Log Message
AX: crash when accessing selectedTab in a tab list
https://bugs.webkit.org/show_bug.cgi?id=70938
Reviewed by Beth Dakin.
Source/WebCore:
There were a few methods accessing m_children directly without first validating that those elements
needed to be updated (because the layout changed). Changing those to call children() ensures
that they will have the correct children.
Test: platform/mac/accessibility/selected-tab-crash.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isChecked):
(WebCore::AccessibilityRenderObject::selectedRadioButton):
(WebCore::AccessibilityRenderObject::selectedTabItem):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):
Tools:
Add the ability to retrieve an element through an arbitrary attribute.
* DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementAttributeValueCallback):
(AccessibilityUIElement::uiElementAttributeValue):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementAttributeValue):
LayoutTests:
* platform/mac/accessibility/selected-tab-crash-expected.txt: Added.
* platform/mac/accessibility/selected-tab-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp
trunk/Tools/DumpRenderTree/AccessibilityUIElement.h
trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
Added Paths
trunk/LayoutTests/platform/mac/accessibility/selected-tab-crash-expected.txt
trunk/LayoutTests/platform/mac/accessibility/selected-tab-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99739 => 99740)
--- trunk/LayoutTests/ChangeLog 2011-11-09 19:03:20 UTC (rev 99739)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 19:08:03 UTC (rev 99740)
@@ -1,3 +1,13 @@
+2011-11-09 Chris Fleizach cfleiz...@apple.com
+
+AX: crash when accessing selectedTab in a tab list
+https://bugs.webkit.org/show_bug.cgi?id=70938
+
+Reviewed by Beth Dakin.
+
+* platform/mac/accessibility/selected-tab-crash-expected.txt: Added.
+* platform/mac/accessibility/selected-tab-crash.html: Added.
+
2011-11-09 Ojan Vafai o...@chromium.org
Remove failures fixed with r99630.
Added: trunk/LayoutTests/platform/mac/accessibility/selected-tab-crash-expected.txt (0 => 99740)
--- trunk/LayoutTests/platform/mac/accessibility/selected-tab-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/selected-tab-crash-expected.txt 2011-11-09 19:08:03 UTC (rev 99740)
@@ -0,0 +1,11 @@
+tab 2
+tab 3
+This tests that if a tablists children are updated, we will not crash accessing an old object.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/mac/accessibility/selected-tab-crash.html (0 => 99740)
--- trunk/LayoutTests/platform/mac/accessibility/selected-tab-crash.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/selected-tab-crash.html 2011-11-09 19:08:03 UTC (rev 99740)
@@ -0,0 +1,48 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script
+var successfullyParsed = false;
+/script
+script src=""
+/head
+body id=body
+
+div role=tablist tabindex=0 id=tablist
+div role=tab aria-checked=true id=selectedtabtab 1/div
+div role=tabtab 2/div
+div role=tabtab 3/div
+/div
+
+p id=description/p
+div id=console/div
+
+script
+
+description(This tests that if a tablists children are updated, we will not crash accessing an old object.);
+
+if (window.accessibilityController) {
+
+document.getElementById(tablist).focus();
+var tablist = accessibilityController.focusedElement;
+
+// Iterate all the children so we have a cache of them.
+tablist.attributesOfChildren();
+
+// Retrieve and verify we have the right selected child.
+var selectedTab = tablist.uiElementAttributeValue(AXValue);
+
+// Delete the selected child.
+document.getElementById(tablist).removeChild(document.getElementById(selectedtab));
+
+// Retrieve the tab. We should not crash here!
+var selectedTab = tablist.uiElementAttributeValue(AXValue);
+}
+
+successfullyParsed = true;
+/script
+
+script src=""
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (99739 => 99740)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 19:03:20 UTC (rev 99739)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 19:08:03 UTC (rev 99740)
@@ -1,3 +1,23 @@
+2011-11-09 Chris Fleizach
[webkit-changes] [99741] trunk/Tools
Title: [99741] trunk/Tools
Revision 99741
Author jchaffr...@webkit.org
Date 2011-11-09 11:28:12 -0800 (Wed, 09 Nov 2011)
Log Message
Unreviewed build fix.
* DumpRenderTree/AccessibilityUIElement.cpp:
(AccessibilityUIElement::makeJSAccessibilityUIElement):
A bad merge added this check that is making the bots sad.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp
Diff
Modified: trunk/Tools/ChangeLog (99740 => 99741)
--- trunk/Tools/ChangeLog 2011-11-09 19:08:03 UTC (rev 99740)
+++ trunk/Tools/ChangeLog 2011-11-09 19:28:12 UTC (rev 99741)
@@ -1,3 +1,11 @@
+2011-11-09 Julien Chaffraix jchaffr...@webkit.org
+
+Unreviewed build fix.
+
+* DumpRenderTree/AccessibilityUIElement.cpp:
+(AccessibilityUIElement::makeJSAccessibilityUIElement):
+A bad merge added this check that is making the bots sad.
+
2011-11-09 Chris Fleizach cfleiz...@apple.com
AX: crash when accessing selectedTab in a tab list
Modified: trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp (99740 => 99741)
--- trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp 2011-11-09 19:08:03 UTC (rev 99740)
+++ trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp 2011-11-09 19:28:12 UTC (rev 99741)
@@ -943,9 +943,6 @@
JSObjectRef AccessibilityUIElement::makeJSAccessibilityUIElement(JSContextRef context, const AccessibilityUIElement element)
{
-if (!element)
-return 0;
-
return JSObjectMake(context, AccessibilityUIElement::getJSClass(), new AccessibilityUIElement(element));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99742] trunk
Title: [99742] trunk Revision 99742 Author commit-qu...@webkit.org Date 2011-11-09 11:35:28 -0800 (Wed, 09 Nov 2011) Log Message Microdata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element::getURLAttribute(). https://bugs.webkit.org/show_bug.cgi?id=71510 Patch by Arko Saha a...@motorola.com on 2011-11-09 Reviewed by Darin Adler. Source/WebCore: Override isURLAttribute() for HTMLElement and return true if attribute is itemidAttr. All the classes derived from HTMLElement overrides this function should return true if attribute is itemidAttr. Removed HTMLIFrameElement::isURLAttribute() method as HTMLFrameElementBase already takes care of it. Test: fast/dom/MicroData/itemid-attribute-test-001.html * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isURLAttribute): * html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::isURLAttribute): * html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::isURLAttribute): * html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::isURLAttribute): * html/HTMLElement.cpp: (WebCore::HTMLElement::isURLAttribute): * html/HTMLElement.h: * html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::isURLAttribute): * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::isURLAttribute): * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAttribute): * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::isURLAttribute): * html/HTMLIFrameElement.cpp: * html/HTMLIFrameElement.h: * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::isURLAttribute): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isURLAttribute): * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::isURLAttribute): * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isURLAttribute): * html/HTMLModElement.cpp: (WebCore::HTMLModElement::isURLAttribute): * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isURLAttribute): * html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::isURLAttribute): * html/HTMLQuoteElement.cpp: (WebCore::HTMLQuoteElement::isURLAttribute): * html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::isURLAttribute): * html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::isURLAttribute): * html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::isURLAttribute): * html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::isURLAttribute): * html/HTMLTrackElement.cpp: (WebCore::HTMLTrackElement::isURLAttribute): LayoutTests: * fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Added. * fast/dom/MicroData/itemid-attribute-test-001.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLAnchorElement.cpp trunk/Source/WebCore/html/HTMLBaseElement.cpp trunk/Source/WebCore/html/HTMLBodyElement.cpp trunk/Source/WebCore/html/HTMLButtonElement.cpp trunk/Source/WebCore/html/HTMLElement.cpp trunk/Source/WebCore/html/HTMLElement.h trunk/Source/WebCore/html/HTMLEmbedElement.cpp trunk/Source/WebCore/html/HTMLFormElement.cpp trunk/Source/WebCore/html/HTMLFrameElementBase.cpp trunk/Source/WebCore/html/HTMLHtmlElement.cpp trunk/Source/WebCore/html/HTMLIFrameElement.cpp trunk/Source/WebCore/html/HTMLIFrameElement.h trunk/Source/WebCore/html/HTMLImageElement.cpp trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLLinkElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLModElement.cpp trunk/Source/WebCore/html/HTMLObjectElement.cpp trunk/Source/WebCore/html/HTMLParamElement.cpp trunk/Source/WebCore/html/HTMLQuoteElement.cpp trunk/Source/WebCore/html/HTMLScriptElement.cpp trunk/Source/WebCore/html/HTMLSourceElement.cpp trunk/Source/WebCore/html/HTMLTableCellElement.cpp trunk/Source/WebCore/html/HTMLTableElement.cpp trunk/Source/WebCore/html/HTMLTrackElement.cpp Added Paths trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test-001-expected.txt trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test-001.html Diff Modified: trunk/LayoutTests/ChangeLog (99741 => 99742) --- trunk/LayoutTests/ChangeLog 2011-11-09 19:28:12 UTC (rev 99741) +++ trunk/LayoutTests/ChangeLog 2011-11-09 19:35:28 UTC (rev 99742) @@ -1,3 +1,13 @@ +2011-11-09 Arko Saha a...@motorola.com + +Microdata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element::getURLAttribute(). +https://bugs.webkit.org/show_bug.cgi?id=71510 + +Reviewed by Darin Adler. + +* fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Added. +* fast/dom/MicroData/itemid-attribute-test-001.html: Added. + 2011-11-09 Chris Fleizach cfleiz...@apple.com AX: crash when accessing selectedTab in a tab list Added: trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test-001-expected.txt (0 => 99742) --- trunk/LayoutTests/fast/dom/MicroData/itemid-attribute-test-001-expected.txt (rev 0) +++
[webkit-changes] [99743] trunk/Tools
Title: [99743] trunk/Tools Revision 99743 Author bda...@apple.com Date 2011-11-09 11:45:08 -0800 (Wed, 09 Nov 2011) Log Message Speculative build fix. * DumpRenderTree/AccessibilityUIElement.h: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/AccessibilityUIElement.h Diff Modified: trunk/Tools/ChangeLog (99742 => 99743) --- trunk/Tools/ChangeLog 2011-11-09 19:35:28 UTC (rev 99742) +++ trunk/Tools/ChangeLog 2011-11-09 19:45:08 UTC (rev 99743) @@ -1,3 +1,9 @@ +2011-11-09 Beth Dakin bda...@apple.com + +Speculative build fix. + +* DumpRenderTree/AccessibilityUIElement.h: + 2011-11-09 Julien Chaffraix jchaffr...@webkit.org Unreviewed build fix. Modified: trunk/Tools/DumpRenderTree/AccessibilityUIElement.h (99742 => 99743) --- trunk/Tools/DumpRenderTree/AccessibilityUIElement.h 2011-11-09 19:35:28 UTC (rev 99742) +++ trunk/Tools/DumpRenderTree/AccessibilityUIElement.h 2011-11-09 19:45:08 UTC (rev 99743) @@ -105,7 +105,7 @@ // Attributes - platform-independent implementations JSStringRef stringAttributeValue(JSStringRef attribute); double numberAttributeValue(JSStringRef attribute); -AccessibilityUIElement uiElementAttributeValue(JSStringRef attribute); +AccessibilityUIElement uiElementAttributeValue(JSStringRef attribute) const; bool boolAttributeValue(JSStringRef attribute); bool isAttributeSupported(JSStringRef attribute); bool isAttributeSettable(JSStringRef attribute); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99744] trunk
Title: [99744] trunk
Revision 99744
Author jchaffr...@webkit.org
Date 2011-11-09 11:57:16 -0800 (Wed, 09 Nov 2011)
Log Message
Crash in RenderTableSection::splitColumn
https://bugs.webkit.org/show_bug.cgi?id=70171
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/table/crash-splitColumn-2.html
fast/table/crash-splitColumn-3.html
fast/table/crash-splitColumn.html
The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.
This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.
(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.
(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().
LayoutTests:
Added a couple of tests where different sections get their
m_needsCellRecalc set independently.
* fast/table/crash-splitColumn-2-expected.txt: Added.
* fast/table/crash-splitColumn-2.html: Added.
* fast/table/crash-splitColumn-3-expected.txt: Added.
* fast/table/crash-splitColumn-3.html: Added.
* fast/table/crash-splitColumn-expected.txt: Added.
* fast/table/crash-splitColumn.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/RenderTableSection.cpp
Added Paths
trunk/LayoutTests/fast/table/crash-splitColumn-2-expected.txt
trunk/LayoutTests/fast/table/crash-splitColumn-2.html
trunk/LayoutTests/fast/table/crash-splitColumn-3-expected.txt
trunk/LayoutTests/fast/table/crash-splitColumn-3.html
trunk/LayoutTests/fast/table/crash-splitColumn-expected.txt
trunk/LayoutTests/fast/table/crash-splitColumn.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99743 => 99744)
--- trunk/LayoutTests/ChangeLog 2011-11-09 19:45:08 UTC (rev 99743)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 19:57:16 UTC (rev 99744)
@@ -1,3 +1,20 @@
+2011-11-09 Julien Chaffraix jchaffr...@webkit.org
+
+Crash in RenderTableSection::splitColumn
+https://bugs.webkit.org/show_bug.cgi?id=70171
+
+Reviewed by David Hyatt.
+
+Added a couple of tests where different sections get their
+m_needsCellRecalc set independently.
+
+* fast/table/crash-splitColumn-2-expected.txt: Added.
+* fast/table/crash-splitColumn-2.html: Added.
+* fast/table/crash-splitColumn-3-expected.txt: Added.
+* fast/table/crash-splitColumn-3.html: Added.
+* fast/table/crash-splitColumn-expected.txt: Added.
+* fast/table/crash-splitColumn.html: Added.
+
2011-11-09 Arko Saha a...@motorola.com
Microdata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element::getURLAttribute().
Added: trunk/LayoutTests/fast/table/crash-splitColumn-2-expected.txt (0 => 99744)
--- trunk/LayoutTests/fast/table/crash-splitColumn-2-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/table/crash-splitColumn-2-expected.txt 2011-11-09 19:57:16 UTC (rev 99744)
@@ -0,0 +1,6 @@
+Bug 70171: Crash in RenderTableSection::splitColumn
+
+This test PASSES if it does not CRASH or ASSERT.
+
+
+
Property changes on: trunk/LayoutTests/fast/table/crash-splitColumn-2-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/table/crash-splitColumn-2.html (0 => 99744)
--- trunk/LayoutTests/fast/table/crash-splitColumn-2.html (rev 0)
+++ trunk/LayoutTests/fast/table/crash-splitColumn-2.html 2011-11-09 19:57:16 UTC (rev 99744)
@@ -0,0 +1,64 @@
+!DOCTYPE html
+html
+head
+style
+.c7 { display: table-row-group; }
+.c7:nth-last-of-type(-n+6) { float: none; }
+.c21:nth-child(2n) { position: static; float: left; }
+.c26 { border-style: ridge; content: counter(section);/style
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function crash()
+{
+var img = document.createElement('img');
+img.appendChild(select);
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+function insertNodes() {
+document.documentElement.appendChild(document.createElement('a'));
+
[webkit-changes] [99745] trunk/Source/JavaScriptCore
Title: [99745] trunk/Source/_javascript_Core Revision 99745 Author barraclo...@apple.com Date 2011-11-09 12:01:24 -0800 (Wed, 09 Nov 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=71873 Reviewed by Geoff Garen. Incrementally re-landing these changes, trying to determine what went wrong. (The whole patch failed tests on the build bot but worked locally. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::supportsFloatingPointTruncate): (JSC::MacroAssemblerARM::supportsFloatingPointSqrt): (JSC::MacroAssemblerARM::supportsFloatingPointAbs): * assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPoint): (JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate): (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): (JSC::MacroAssemblerARMv7::supportsFloatingPointAbs): * assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::supportsFloatingPoint): (JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt): (JSC::MacroAssemblerMIPS::supportsFloatingPointAbs): * assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::supportsFloatingPoint): (JSC::MacroAssemblerSH4::supportsFloatingPointTruncate): (JSC::MacroAssemblerSH4::supportsFloatingPointSqrt): (JSC::MacroAssemblerSH4::supportsFloatingPointAbs): * assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsFloatingPoint): (JSC::MacroAssemblerX86::supportsFloatingPointTruncate): (JSC::MacroAssemblerX86::supportsFloatingPointSqrt): (JSC::MacroAssemblerX86::supportsFloatingPointAbs): * assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsFloatingPoint): (JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate): (JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt): (JSC::MacroAssemblerX86_64::supportsFloatingPointAbs): * jit/ThunkGenerators.cpp: (JSC::absThunkGenerator): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (99744 => 99745) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-09 19:57:16 UTC (rev 99744) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-09 20:01:24 UTC (rev 99745) @@ -1,3 +1,45 @@ +2011-11-09 Gavin Barraclough barraclo...@apple.com + +https://bugs.webkit.org/show_bug.cgi?id=71873 + +Reviewed by Geoff Garen. + +Incrementally re-landing these changes, trying to determine what went wrong. +(The whole patch failed tests on the build bot but worked locally. + +* assembler/MacroAssemblerARM.h: +(JSC::MacroAssemblerARM::supportsFloatingPoint): +(JSC::MacroAssemblerARM::supportsFloatingPointTruncate): +(JSC::MacroAssemblerARM::supportsFloatingPointSqrt): +(JSC::MacroAssemblerARM::supportsFloatingPointAbs): +* assembler/MacroAssemblerARMv7.h: +(JSC::MacroAssemblerARMv7::supportsFloatingPoint): +(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate): +(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): +(JSC::MacroAssemblerARMv7::supportsFloatingPointAbs): +* assembler/MacroAssemblerMIPS.h: +(JSC::MacroAssemblerMIPS::supportsFloatingPoint): +(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate): +(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt): +(JSC::MacroAssemblerMIPS::supportsFloatingPointAbs): +* assembler/MacroAssemblerSH4.h: +(JSC::MacroAssemblerSH4::supportsFloatingPoint): +(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate): +(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt): +(JSC::MacroAssemblerSH4::supportsFloatingPointAbs): +* assembler/MacroAssemblerX86.h: +(JSC::MacroAssemblerX86::supportsFloatingPoint): +(JSC::MacroAssemblerX86::supportsFloatingPointTruncate): +(JSC::MacroAssemblerX86::supportsFloatingPointSqrt): +(JSC::MacroAssemblerX86::supportsFloatingPointAbs): +* assembler/MacroAssemblerX86_64.h: +(JSC::MacroAssemblerX86_64::supportsFloatingPoint): +(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate): +(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt): +(JSC::MacroAssemblerX86_64::supportsFloatingPointAbs): +* jit/ThunkGenerators.cpp: +(JSC::absThunkGenerator): + 2011-11-08 Darin Adler da...@apple.com Add code path in HashTable for emptyValueIsZero that does not require copying the empty value Modified:
[webkit-changes] [99746] trunk/Tools
Title: [99746] trunk/Tools
Revision 99746
Author bda...@apple.com
Date 2011-11-09 12:04:02 -0800 (Wed, 09 Nov 2011)
Log Message
Build fix.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementAttributeValue):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
Diff
Modified: trunk/Tools/ChangeLog (99745 => 99746)
--- trunk/Tools/ChangeLog 2011-11-09 20:01:24 UTC (rev 99745)
+++ trunk/Tools/ChangeLog 2011-11-09 20:04:02 UTC (rev 99746)
@@ -1,5 +1,12 @@
2011-11-09 Beth Dakin bda...@apple.com
+Build fix.
+
+* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
+(AccessibilityUIElement::uiElementAttributeValue):
+
+2011-11-09 Beth Dakin bda...@apple.com
+
Speculative build fix.
* DumpRenderTree/AccessibilityUIElement.h:
Modified: trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm (99745 => 99746)
--- trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2011-11-09 20:01:24 UTC (rev 99745)
+++ trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2011-11-09 20:04:02 UTC (rev 99746)
@@ -480,7 +480,7 @@
return 0;
}
-AccessibilityUIElement AccessibilityUIElement::uiElementAttributeValue(JSStringRef attribute)
+AccessibilityUIElement AccessibilityUIElement::uiElementAttributeValue(JSStringRef attribute) const
{
BEGIN_AX_OBJC_EXCEPTIONS
id uiElement = [m_element accessibilityAttributeValue:[NSString stringWithJSStringRef:attribute]];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99747] trunk/Source/WebCore
Title: [99747] trunk/Source/WebCore
Revision 99747
Author hara...@chromium.org
Date 2011-11-09 12:05:40 -0800 (Wed, 09 Nov 2011)
Log Message
Generate the HTMLOptionElement constructor using [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71925
Reviewed by Adam Barth.
This patch removes a custom constructor of HTMLOptionElement,
and generates it using [NamedConstructor] IDL.
Tests: fast/js/custom-constructors.html
fast/forms/option-index.html
fast/forms/add-and-remove-option.html
fast/dom/dom-add-optionelement.html
* Target.pri: Removed V8HTMLOptionElementConstructor.{h,cpp}
* WebCore.gypi: Ditto.
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Removed.
* bindings/v8/custom/V8HTMLOptionElementConstructor.h: Removed.
* html/HTMLOptionElement.idl: Added [NamedConstructor] IDL.
* page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/html/HTMLOptionElement.idl
trunk/Source/WebCore/page/DOMWindow.idl
Removed Paths
trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionElementConstructor.cpp
trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionElementConstructor.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (99746 => 99747)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 20:04:02 UTC (rev 99746)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 20:05:40 UTC (rev 99747)
@@ -1,3 +1,25 @@
+2011-11-09 Kentaro Hara hara...@chromium.org
+
+Generate the HTMLOptionElement constructor using [NamedConstructor] IDL
+https://bugs.webkit.org/show_bug.cgi?id=71925
+
+Reviewed by Adam Barth.
+
+This patch removes a custom constructor of HTMLOptionElement,
+and generates it using [NamedConstructor] IDL.
+
+Tests: fast/js/custom-constructors.html
+ fast/forms/option-index.html
+ fast/forms/add-and-remove-option.html
+ fast/dom/dom-add-optionelement.html
+
+* Target.pri: Removed V8HTMLOptionElementConstructor.{h,cpp}
+* WebCore.gypi: Ditto.
+* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Removed.
+* bindings/v8/custom/V8HTMLOptionElementConstructor.h: Removed.
+* html/HTMLOptionElement.idl: Added [NamedConstructor] IDL.
+* page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.
+
2011-11-09 Julien Chaffraix jchaffr...@webkit.org
Crash in RenderTableSection::splitColumn
Modified: trunk/Source/WebCore/Target.pri (99746 => 99747)
--- trunk/Source/WebCore/Target.pri 2011-11-09 20:04:02 UTC (rev 99746)
+++ trunk/Source/WebCore/Target.pri 2011-11-09 20:05:40 UTC (rev 99747)
@@ -198,7 +198,6 @@
bindings/v8/custom/V8HTMLImageElementConstructor.cpp \
bindings/v8/custom/V8HTMLInputElementCustom.cpp \
bindings/v8/custom/V8HTMLLinkElementCustom.cpp \
-bindings/v8/custom/V8HTMLOptionElementConstructor.cpp \
bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp \
bindings/v8/custom/V8HTMLOutputElementCustom.cpp \
bindings/v8/custom/V8HTMLPlugInElementCustom.cpp \
@@ -1352,7 +1351,6 @@
bindings/v8/custom/V8CustomXPathNSResolver.h \
bindings/v8/custom/V8HTMLAudioElementConstructor.h \
bindings/v8/custom/V8HTMLImageElementConstructor.h \
-bindings/v8/custom/V8HTMLOptionElementConstructor.h \
bindings/v8/custom/V8HTMLSelectElementCustom.h \
bindings/v8/custom/V8MessagePortCustom.h \
bindings/v8/custom/V8NamedNodesCollection.h \
Modified: trunk/Source/WebCore/WebCore.gypi (99746 => 99747)
--- trunk/Source/WebCore/WebCore.gypi 2011-11-09 20:04:02 UTC (rev 99746)
+++ trunk/Source/WebCore/WebCore.gypi 2011-11-09 20:05:40 UTC (rev 99747)
@@ -2200,8 +2200,6 @@
'bindings/v8/custom/V8HTMLImageElementConstructor.h',
'bindings/v8/custom/V8HTMLInputElementCustom.cpp',
'bindings/v8/custom/V8HTMLLinkElementCustom.cpp',
-'bindings/v8/custom/V8HTMLOptionElementConstructor.cpp',
-'bindings/v8/custom/V8HTMLOptionElementConstructor.h',
'bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp',
'bindings/v8/custom/V8HTMLOutputElementCustom.cpp',
'bindings/v8/custom/V8HTMLPlugInElementCustom.cpp',
Deleted: trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionElementConstructor.cpp (99746 => 99747)
--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionElementConstructor.cpp 2011-11-09 20:04:02 UTC (rev 99746)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionElementConstructor.cpp 2011-11-09 20:05:40 UTC (rev 99747)
@@ -1,110 +0,0 @@
-/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of
[webkit-changes] [99748] trunk
Title: [99748] trunk
Revision 99748
Author ph...@webkit.org
Date 2011-11-09 12:10:58 -0800 (Wed, 09 Nov 2011)
Log Message
[GTK][DRT] window internals object is not reset after each test
https://bugs.webkit.org/show_bug.cgi?id=71890
Reviewed by Martin Robinson.
.:
* Source/autotools/symbols.filter: Revert un-needed symbol.
Source/WebKit/gtk:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Remove problematic
calls to WebCoreSupport which belongs to libWebCoreInternals, not libwebkitgtk.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
Tools:
Call WebCoreTestSupport::resetInternalsObject without going
through DumpRenderTreeSupport.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):
Modified Paths
trunk/ChangeLog
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp
trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h
trunk/Source/autotools/symbols.filter
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp
Diff
Modified: trunk/ChangeLog (99747 => 99748)
--- trunk/ChangeLog 2011-11-09 20:05:40 UTC (rev 99747)
+++ trunk/ChangeLog 2011-11-09 20:10:58 UTC (rev 99748)
@@ -1,5 +1,14 @@
2011-11-09 Philippe Normand pnorm...@igalia.com
+[GTK][DRT] window internals object is not reset after each test
+https://bugs.webkit.org/show_bug.cgi?id=71890
+
+Reviewed by Martin Robinson.
+
+* Source/autotools/symbols.filter: Revert un-needed symbol.
+
+2011-11-09 Philippe Normand pnorm...@igalia.com
+
Unreviewed, attempt to fix GTK 32-bits Release build after r99691.
* Source/autotools/symbols.filter: Add the missing symbol for resetInternalsObject.
Modified: trunk/Source/WebKit/gtk/ChangeLog (99747 => 99748)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-11-09 20:05:40 UTC (rev 99747)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-11-09 20:10:58 UTC (rev 99748)
@@ -3,6 +3,17 @@
[GTK][DRT] window internals object is not reset after each test
https://bugs.webkit.org/show_bug.cgi?id=71890
+Reviewed by Martin Robinson.
+
+* WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Remove problematic
+calls to WebCoreSupport which belongs to libWebCoreInternals, not libwebkitgtk.
+* WebCoreSupport/DumpRenderTreeSupportGtk.h:
+
+2011-11-09 Philippe Normand pnorm...@igalia.com
+
+[GTK][DRT] window internals object is not reset after each test
+https://bugs.webkit.org/show_bug.cgi?id=71890
+
Reviewed by Xan Lopez.
DRTSupport infrastructure to reset the Internals object, like in Qt.
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (99747 => 99748)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2011-11-09 20:05:40 UTC (rev 99747)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2011-11-09 20:10:58 UTC (rev 99748)
@@ -59,7 +59,6 @@
#include SecurityPolicy.h
#include Settings.h
#include TextIterator.h
-#include WebCoreTestSupport.h
#include WebKitDOMRangePrivate.h
#include WorkerThread.h
#include webkitglobalsprivate.h
@@ -891,18 +890,3 @@
return 0;
#endif
}
-
-void DumpRenderTreeSupportGtk::resetInternalsObject(WebKitWebFrame* frame)
-{
-Frame* coreFrame = core(frame);
-if (!coreFrame)
-return;
-
-JSLock lock(SilenceAssertionsOnly);
-
-JSGlobalContextRef globalContext = webkit_web_frame_get_global_context(frame);
-ExecState* exec = toJS(globalContext);
-
-JSContextRef context = toRef(exec);
-WebCoreTestSupport::resetInternalsObject(context);
-}
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (99747 => 99748)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h 2011-11-09 20:05:40 UTC (rev 99747)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h 2011-11-09 20:10:58 UTC (rev 99748)
@@ -126,8 +126,6 @@
static void setMockGeolocationError(WebKitWebView*, int errorCode, const gchar* errorMessage);
static int numberOfPendingGeolocationPermissionRequests(WebKitWebView*);
-static void resetInternalsObject(WebKitWebFrame*);
-
private:
static bool s_drtRun;
static bool s_linksIncludedInTabChain;
Modified: trunk/Source/autotools/symbols.filter (99747 => 99748)
--- trunk/Source/autotools/symbols.filter 2011-11-09 20:05:40 UTC (rev 99747)
+++ trunk/Source/autotools/symbols.filter 2011-11-09 20:10:58 UTC (rev 99748)
@@ -81,7 +81,6 @@
_ZN7WebCore10ScrollView23setScrollbarsSuppressedEbb;
_ZN7WebCore9FrameView17paintControlTintsEv;
_ZN7WebCore9FrameView19scrollElementToRectEPNS_7ElementERKNS_7IntRectE;
-_ZN18WebCoreTestSupport20resetInternalsObjectEPK15OpaqueJSContext;
local:
_Z*;
cti*;
Modified: trunk/Tools/ChangeLog (99747 => 99748)
--- trunk/Tools/ChangeLog 2011-11-09 20:05:40 UTC (rev 99747)
+++ trunk/Tools/ChangeLog 2011-11-09 20:10:58 UTC (rev 99748)
@@ -1,3 +1,16 @@
+2011-11-09 Philippe
[webkit-changes] [99753] trunk/LayoutTests
Title: [99753] trunk/LayoutTests
Revision 99753
Author x...@chromium.org
Date 2011-11-09 12:49:01 -0800 (Wed, 09 Nov 2011)
Log Message
Rebaseline after r99616 and r99736.
Delete platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
so that cr-mac failed for text too.
* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (99752 => 99753)
--- trunk/LayoutTests/ChangeLog 2011-11-09 20:35:23 UTC (rev 99752)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 20:49:01 UTC (rev 99753)
@@ -1,3 +1,11 @@
+2011-11-09 Xiaomei Ji x...@chromium.org
+
+Rebaseline after r99616 and r99736.
+Delete platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
+so that cr-mac failed for text too.
+
+* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.
+
2011-11-09 Julien Chaffraix jchaffr...@webkit.org
REGRESSION (r93614): Content remains despite parent element being scrolled off page using _javascript_.
Deleted: trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt (99752 => 99753)
--- trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt 2011-11-09 20:35:23 UTC (rev 99752)
+++ trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt 2011-11-09 20:49:01 UTC (rev 99753)
@@ -1,8 +0,0 @@
-layer at (0,0) size 329x4018
- RenderView at (0,0) size 329x573
-layer at (0,0) size 329x4018
- RenderBlock {HTML} at (0,0) size 329x4018
-RenderBody {BODY} at (8,8) size 313x4002
- RenderBlock {DIV} at (-689,0) size 1002x4002 [border: (1px solid #FF)]
-RenderText {#text} at (-491,1) size 1492x18
- text run at (-491,1) width 1492: BEGINEND
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99755] trunk/Source/WebCore
Title: [99755] trunk/Source/WebCore
Revision 99755
Author ander...@apple.com
Date 2011-11-09 13:18:44 -0800 (Wed, 09 Nov 2011)
Log Message
Use contentsToRootView/rootViewToContents when converting between frame coordinate systems
https://bugs.webkit.org/show_bug.cgi?id=71947
Reviewed by Sam Weinig.
This gets rid of a few calls to contentsToWindow and windowToContents.
* inspector/DOMNodeHighlighter.cpp:
* page/DragController.cpp:
(WebCore::DragController::startDrag):
(WebCore::DragController::doSystemDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/page/EventHandler.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99754 => 99755)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 21:09:37 UTC (rev 99754)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 21:18:44 UTC (rev 99755)
@@ -1,3 +1,19 @@
+2011-11-09 Anders Carlsson ander...@apple.com
+
+Use contentsToRootView/rootViewToContents when converting between frame coordinate systems
+https://bugs.webkit.org/show_bug.cgi?id=71947
+
+Reviewed by Sam Weinig.
+
+This gets rid of a few calls to contentsToWindow and windowToContents.
+
+* inspector/DOMNodeHighlighter.cpp:
+* page/DragController.cpp:
+(WebCore::DragController::startDrag):
+(WebCore::DragController::doSystemDrag):
+* page/EventHandler.cpp:
+(WebCore::EventHandler::hitTestResultAtPoint):
+
2011-11-09 Mark Hahnenberg mhahnenb...@apple.com
De-virtualize JSObject::getOwnPropertyDescriptor
Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (99754 => 99755)
--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2011-11-09 21:09:37 UTC (rev 99754)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2011-11-09 21:18:44 UTC (rev 99755)
@@ -144,7 +144,7 @@
inline LayoutSize frameToMainFrameOffset(Frame* frame)
{
-LayoutPoint mainFramePoint = frame-page()-mainFrame()-view()-windowToContents(frame-view()-contentsToWindow(LayoutPoint()));
+LayoutPoint mainFramePoint = frame-page()-mainFrame()-view()-rootViewToContents(frame-view()-contentsToRootView(LayoutPoint()));
return toLayoutSize(mainFramePoint);
}
Modified: trunk/Source/WebCore/page/DragController.cpp (99754 => 99755)
--- trunk/Source/WebCore/page/DragController.cpp 2011-11-09 21:09:37 UTC (rev 99754)
+++ trunk/Source/WebCore/page/DragController.cpp 2011-11-09 21:18:44 UTC (rev 99755)
@@ -782,7 +782,7 @@
if (!dragImage) {
IntRect imageRect = hitTestResult.imageRect();
-imageRect.setLocation(m_page-mainFrame()-view()-windowToContents(src-view()-contentsToWindow(imageRect.location(;
+imageRect.setLocation(m_page-mainFrame()-view()-rootViewToContents(src-view()-contentsToRootView(imageRect.location(;
doImageDrag(element, dragOrigin, hitTestResult.imageRect(), clipboard, src, m_dragOffset);
} else
// DHTML defined drag image
@@ -874,8 +874,8 @@
// Protect this frame and view, as a load may occur mid drag and attempt to unload this frame
RefPtrFrame frameProtector = m_page-mainFrame();
RefPtrFrameView viewProtector = frameProtector-view();
-m_client-startDrag(image, viewProtector-windowToContents(frame-view()-contentsToWindow(dragLoc)),
-viewProtector-windowToContents(frame-view()-contentsToWindow(eventPos)), clipboard, frameProtector.get(), forLink);
+m_client-startDrag(image, viewProtector-rootViewToContents(frame-view()-contentsToRootView(dragLoc)),
+viewProtector-rootViewToContents(frame-view()-contentsToRootView(eventPos)), clipboard, frameProtector.get(), forLink);
cleanupAfterSystemDrag();
}
Modified: trunk/Source/WebCore/page/EventHandler.cpp (99754 => 99755)
--- trunk/Source/WebCore/page/EventHandler.cpp 2011-11-09 21:09:37 UTC (rev 99754)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2011-11-09 21:18:44 UTC (rev 99755)
@@ -975,8 +975,7 @@
FrameView* resultView = resultFrame-view();
FrameView* mainView = mainFrame-view();
if (resultView mainView) {
-LayoutPoint windowPoint = resultView-contentsToWindow(result.point());
-LayoutPoint mainFramePoint = mainView-windowToContents(windowPoint);
+LayoutPoint mainFramePoint = mainView-rootViewToContents(resultView-contentsToRootView(result.point()));
result = mainFrame-eventHandler()-hitTestResultAtPoint(mainFramePoint, allowShadowContent, ignoreClipping, testScrollbars, hitType, padding);
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99756] trunk
Title: [99756] trunk
Revision 99756
Author commit-qu...@webkit.org
Date 2011-11-09 13:25:05 -0800 (Wed, 09 Nov 2011)
Log Message
Source/WebCore: Indentation error in RenderObject::container
https://bugs.webkit.org/show_bug.cgi?id=64780
Patch by Ken Buchanan ke...@chromium.org on 2011-11-09
Reviewed by Eric Seidel.
A conditional block was indented too far; correcting.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::container):
LayoutTests: Rebaselining gtk and qt results for foreign object overflow
https://bugs.webkit.org/show_bug.cgi?id=64780
Patch by Ken Buchanan ke...@chromium.org on 2011-11-09
Reviewed by Eric Seidel.
Fix for 64780 changed results for one layoutTest. This is the rebaseline for gtk and qt platforms.
* platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
* platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt
trunk/LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Property Changed
trunk/LayoutTests/platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt
trunk/LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (99755 => 99756)
--- trunk/LayoutTests/ChangeLog 2011-11-09 21:18:44 UTC (rev 99755)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 21:25:05 UTC (rev 99756)
@@ -1,3 +1,15 @@
+2011-11-09 Ken Buchanan ke...@chromium.org
+
+Rebaselining gtk and qt results for foreign object overflow
+https://bugs.webkit.org/show_bug.cgi?id=64780
+
+Reviewed by Eric Seidel.
+
+Fix for 64780 changed results for one layoutTest. This is the rebaseline for gtk and qt platforms.
+
+* platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
+* platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
+
2011-11-09 Xiaomei Ji x...@chromium.org
Rebaseline after r99616 and r99736.
Modified: trunk/LayoutTests/platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt (99755 => 99756)
--- trunk/LayoutTests/platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt 2011-11-09 21:18:44 UTC (rev 99755)
+++ trunk/LayoutTests/platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt 2011-11-09 21:25:05 UTC (rev 99756)
@@ -3,5 +3,5 @@
layer at (0,0) size 500x500
RenderSVGRoot {svg} at (200,200) size 300x300
RenderSVGForeignObject {foreignObject} at (100,100) size 300x300
-layer at (100,100) size 6006x6006 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
- RenderBlock (positioned) {html:div} at (100,100) size 6006x6006 [bgcolor=#008000] [border: (3px solid #00)]
+layer at (0,0) size 6006x6006 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
+ RenderBlock (positioned) {html:div} at (0,0) size 6006x6006 [bgcolor=#008000] [border: (3px solid #00)]
Property changes on: trunk/LayoutTests/platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt
___
Added: svn:executable
Modified: trunk/LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt (99755 => 99756)
--- trunk/LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt 2011-11-09 21:18:44 UTC (rev 99755)
+++ trunk/LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt 2011-11-09 21:25:05 UTC (rev 99756)
@@ -3,5 +3,5 @@
layer at (0,0) size 500x500
RenderSVGRoot {svg} at (200,200) size 300x300
RenderSVGForeignObject {foreignObject} at (100,100) size 300x300
-layer at (100,100) size 6006x6006 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
- RenderBlock (positioned) {html:div} at (100,100) size 6006x6006 [bgcolor=#008000] [border: (3px solid #00)]
+layer at (0,0) size 6006x6006 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600 outlineClip at (0,0) size 800x600
+ RenderBlock (positioned) {html:div} at (0,0) size 6006x6006 [bgcolor=#008000] [border: (3px solid #00)]
Property changes on: trunk/LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt
___
Added: svn:executable
Modified: trunk/Source/WebCore/ChangeLog (99755 => 99756)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 21:18:44 UTC (rev 99755)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 21:25:05 UTC (rev 99756)
@@ -1,3 +1,15 @@
+2011-11-09 Ken Buchanan ke...@chromium.org
+
+Indentation error in RenderObject::container
+https://bugs.webkit.org/show_bug.cgi?id=64780
+
+Reviewed by
[webkit-changes] [99757] trunk/LayoutTests
Title: [99757] trunk/LayoutTests Revision 99757 Author an...@apple.com Date 2011-11-09 13:59:15 -0800 (Wed, 09 Nov 2011) Log Message Update test description. Not reviewed. * svg/dom/rgb-color-parser-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/svg/dom/rgb-color-parser-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (99756 => 99757) --- trunk/LayoutTests/ChangeLog 2011-11-09 21:25:05 UTC (rev 99756) +++ trunk/LayoutTests/ChangeLog 2011-11-09 21:59:15 UTC (rev 99757) @@ -1,3 +1,11 @@ +2011-11-09 Antti Koivisto an...@apple.com + +Update test description. + +Not reviewed. + +* svg/dom/rgb-color-parser-expected.txt: + 2011-11-09 Ken Buchanan ke...@chromium.org Rebaselining gtk and qt results for foreign object overflow Modified: trunk/LayoutTests/svg/dom/rgb-color-parser-expected.txt (99756 => 99757) --- trunk/LayoutTests/svg/dom/rgb-color-parser-expected.txt 2011-11-09 21:25:05 UTC (rev 99756) +++ trunk/LayoutTests/svg/dom/rgb-color-parser-expected.txt 2011-11-09 21:59:15 UTC (rev 99757) @@ -1,4 +1,4 @@ -This test fuzzes the length list parser with semi-random attribute values and dumps the results of any values that parse successfully. +This test fuzzes the color parser with semi-random attribute values and dumps the results of any values that parse successfully. On success, you will see a series of PASS messages, followed by TEST COMPLETE. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99758] branches/chromium/912
Title: [99758] branches/chromium/912
Revision 99758
Author vange...@chromium.org
Date 2011-11-09 14:09:39 -0800 (Wed, 09 Nov 2011)
Log Message
Merge 99485 - Source/WebCore: Create a separate setting for compositing of for scrollable [i]frames
that forceCompositingMode can be used without turning frames into composited layers.
https://bugs.webkit.org/show_bug.cgi?id=71714
Reviewed by James Robinson.
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setAcceleratedCompositingForScrollableFramesEnabled):
(WebCore::Settings::acceleratedCompositingForScrollableFramesEnabled):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
* testing/Internals.cpp:
(WebCore::Internals::setEnableCompositingForScrollableFrames):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests: [chromium] Make compositing for scrollable [i]frames a setting separate from
forceCompositingMode.
https://bugs.webkit.org/show_bug.cgi?id=71714
Adjust the force-compositing-mode layout tests to explicitly set the new flag.
Reviewed by James Robinson.
* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
* platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
* platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
TBR=vange...@chromium.org
Review URL: http://codereview.chromium.org/8506028
Modified Paths
branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html
branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html
branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html
branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html
branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html
branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html
branches/chromium/912/Source/WebCore/page/Settings.cpp
branches/chromium/912/Source/WebCore/page/Settings.h
branches/chromium/912/Source/WebCore/rendering/RenderLayerCompositor.cpp
branches/chromium/912/Source/WebCore/testing/Internals.cpp
branches/chromium/912/Source/WebCore/testing/Internals.h
branches/chromium/912/Source/WebCore/testing/Internals.idl
Diff
Modified: branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html (99757 => 99758)
--- branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html 2011-11-09 21:59:15 UTC (rev 99757)
+++ branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html 2011-11-09 22:09:39 UTC (rev 99758)
@@ -1,8 +1,10 @@
html
head
script
- if (window.internals)
+ if (window.internals) {
window.internals.setForceCompositingMode(document, true);
+window.internals.setEnableCompositingForScrollableFrames(document, true);
+ }
function doTest() {
if (window.layoutTestController) {
document.getElementById(layertree).innerText = layoutTestController.layerTreeAsText();
Modified: branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html (99757 => 99758)
--- branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html 2011-11-09 21:59:15 UTC (rev 99757)
+++ branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html 2011-11-09 22:09:39 UTC (rev 99758)
@@ -15,8 +15,10 @@
}
}
window.addEventListener(load, doTest, false);
-if (window.internals)
+if (window.internals) {
internals.setForceCompositingMode(document, true);
+ internals.setEnableCompositingForScrollableFrames(document, true);
+}
/script
/head
body
Modified: branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html (99757 => 99758)
--- branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html 2011-11-09 21:59:15 UTC (rev 99757)
+++ branches/chromium/912/LayoutTests/platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html 2011-11-09 22:09:39 UTC (rev 99758)
@@ -7,8 +7,10 @@
}
[webkit-changes] [99759] trunk/LayoutTests
Title: [99759] trunk/LayoutTests
Revision 99759
Author o...@chromium.org
Date 2011-11-09 14:16:50 -0800 (Wed, 09 Nov 2011)
Log Message
[Chromium] Layout Test fast/forms/select-clientheight-large-size.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=71880
Reviewed by Tony Chang.
Makes the test run ~10x faster by making the second select element only have 16
option elements. As best I can tell, that covers all the edge cases from r99653.
Also, cleaned up the test to make it a more normal js test:
-Gave it a doctype so it's in standards-mode.
-Moved the description to a description call.
-Generated both select element in script instead of just one of them.
* fast/forms/select-clientheight-large-size-expected.txt:
* fast/forms/select-clientheight-large-size.html:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/select-clientheight-large-size-expected.txt
trunk/LayoutTests/fast/forms/select-clientheight-large-size.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (99758 => 99759)
--- trunk/LayoutTests/ChangeLog 2011-11-09 22:09:39 UTC (rev 99758)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 22:16:50 UTC (rev 99759)
@@ -1,3 +1,22 @@
+2011-11-09 Ojan Vafai o...@chromium.org
+
+[Chromium] Layout Test fast/forms/select-clientheight-large-size.html is timing out
+https://bugs.webkit.org/show_bug.cgi?id=71880
+
+Reviewed by Tony Chang.
+
+Makes the test run ~10x faster by making the second select element only have 16
+option elements. As best I can tell, that covers all the edge cases from r99653.
+
+Also, cleaned up the test to make it a more normal js test:
+-Gave it a doctype so it's in standards-mode.
+-Moved the description to a description call.
+-Generated both select element in script instead of just one of them.
+
+* fast/forms/select-clientheight-large-size-expected.txt:
+* fast/forms/select-clientheight-large-size.html:
+* platform/chromium/test_expectations.txt:
+
2011-11-09 Antti Koivisto an...@apple.com
Update test description.
Modified: trunk/LayoutTests/fast/forms/select-clientheight-large-size-expected.txt (99758 => 99759)
--- trunk/LayoutTests/fast/forms/select-clientheight-large-size-expected.txt 2011-11-09 22:09:39 UTC (rev 99758)
+++ trunk/LayoutTests/fast/forms/select-clientheight-large-size-expected.txt 2011-11-09 22:16:50 UTC (rev 99759)
@@ -1,14 +1,15 @@
-HTMLSelectElement multiple attribute test when no size is specified
+Tests that select elements cap their size to the size attribute and to 4 when no size is specified.
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
PASS clientHeight('select2') is clientHeight('select1')
PASS getElemById('select2').setAttribute('size', '4'); clientHeight('select2') == clientHeight('select1') is true
PASS getElemById('select2').setAttribute('size', '5'); clientHeight('select2') clientHeight('select1') is true
PASS getElemById('select2').setAttribute('size', '8'); clientHeight('select2') == multipleOfElement('select1', 2) is true
PASS getElemById('select2').setAttribute('size', '12'); clientHeight('select2') == multipleOfElement('select1', 3) is true
PASS getElemById('select2').setAttribute('size', '16'); clientHeight('select2') == multipleOfElement('select1', 4) is true
-PASS getElemById('select2').setAttribute('size', '400'); clientHeight('select2') == multipleOfElement('select1', 100) is true
-PASS getElemById('select2').setAttribute('size', '4000'); clientHeight('select2') == multipleOfElement('select1', 1000) is true
PASS successfullyParsed is true
TEST COMPLETE
-
+
Modified: trunk/LayoutTests/fast/forms/select-clientheight-large-size.html (99758 => 99759)
--- trunk/LayoutTests/fast/forms/select-clientheight-large-size.html 2011-11-09 22:09:39 UTC (rev 99758)
+++ trunk/LayoutTests/fast/forms/select-clientheight-large-size.html 2011-11-09 22:16:50 UTC (rev 99759)
@@ -1,57 +1,32 @@
-html
-head
+!DOCTYPE html
script src=""
-/head
-body
-pHTMLSelectElement multiple attribute test when no size is specified/p
-div id=console/div
-
-select multiple id=select1
-option value=00/option
-option value=11/option
-option value=22/option
-option value=33/option
-option value=44/option
-option value=55/option
-option value=66/option
-option value=77/option
-option value=88/option
-option value=99/option
-/select
-
-select multiple id=select2 /select
-
+div id=output/div
script
+description(Tests that select elements cap their size to the size attribute and to 4 when no size is specified.);
-function AddItem(Text,Value) {
-var opt = document.createElement(option);
-document.getElementById(select2).options.add(opt);
-
-opt.text = Text;
-opt.value = Value;
-
-}
-
[webkit-changes] [99760] trunk/LayoutTests
Title: [99760] trunk/LayoutTests Revision 99760 Author jchaffr...@webkit.org Date 2011-11-09 14:20:08 -0800 (Wed, 09 Nov 2011) Log Message Unreviewed rebaseline after r99752. * platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added. * platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed. * platform/chromium-win/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added. * platform/chromium-win/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added. * platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png: Added. * platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added. * platform/chromium-win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added. * platform/chromium-win/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added. * platform/chromium-win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png trunk/LayoutTests/platform/chromium-win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png Removed Paths trunk/LayoutTests/platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (99759 => 99760) --- trunk/LayoutTests/ChangeLog 2011-11-09 22:16:50 UTC (rev 99759) +++ trunk/LayoutTests/ChangeLog 2011-11-09 22:20:08 UTC (rev 99760) @@ -1,3 +1,24 @@ +2011-11-09 Julien Chaffraix jchaffr...@webkit.org + +Unreviewed rebaseline after r99752. + +* platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added. +*
[webkit-changes] [99762] trunk
Title: [99762] trunk
Revision 99762
Author commit-qu...@webkit.org
Date 2011-11-09 14:43:05 -0800 (Wed, 09 Nov 2011)
Log Message
Implement dumpProgressFinishedCallback() for Mac layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=66772
Patch by Benjamin Poulain bpoul...@apple.com on 2011-11-09
Reviewed by Simon Fraser.
Tools:
When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
postProgressFinishedNotification on FrameLoaderClient::postProgressFinishedNotification().
On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
in the FrameLoadDelegate and print the output in response to the notification.
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate init]):
(-[FrameLoadDelegate dealloc]):
(-[FrameLoadDelegate webViewProgressFinishedNotification:]):
LayoutTests:
Unskip the skipped test.
* platform/mac/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
Diff
Modified: trunk/LayoutTests/ChangeLog (99761 => 99762)
--- trunk/LayoutTests/ChangeLog 2011-11-09 22:29:29 UTC (rev 99761)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 22:43:05 UTC (rev 99762)
@@ -1,3 +1,14 @@
+2011-11-09 Benjamin Poulain bpoul...@apple.com
+
+Implement dumpProgressFinishedCallback() for Mac layoutTestController
+https://bugs.webkit.org/show_bug.cgi?id=66772
+
+Reviewed by Simon Fraser.
+
+Unskip the skipped test.
+
+* platform/mac/Skipped:
+
2011-11-09 Alexei Svitkine asvitk...@chromium.org
Chromium: Fix bad rubber-band overhang shadows being drawn in the presence of custom scrollbar css.
Modified: trunk/LayoutTests/platform/mac/Skipped (99761 => 99762)
--- trunk/LayoutTests/platform/mac/Skipped 2011-11-09 22:29:29 UTC (rev 99761)
+++ trunk/LayoutTests/platform/mac/Skipped 2011-11-09 22:43:05 UTC (rev 99762)
@@ -453,9 +453,6 @@
# Makes subsequent test crash
fast/loader/document-destruction-within-unload.html
-# https://bugs.webkit.org/show_bug.cgi?id=66772
-http/tests/loading/progress-finished-callback.html
-
# https://bugs.webkit.org/show_bug.cgi?id=67716
media/media-controls-invalid-url.html
Modified: trunk/Tools/ChangeLog (99761 => 99762)
--- trunk/Tools/ChangeLog 2011-11-09 22:29:29 UTC (rev 99761)
+++ trunk/Tools/ChangeLog 2011-11-09 22:43:05 UTC (rev 99762)
@@ -1,3 +1,21 @@
+2011-11-09 Benjamin Poulain bpoul...@apple.com
+
+Implement dumpProgressFinishedCallback() for Mac layoutTestController
+https://bugs.webkit.org/show_bug.cgi?id=66772
+
+Reviewed by Simon Fraser.
+
+When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
+postProgressFinishedNotification on FrameLoaderClient::postProgressFinishedNotification().
+
+On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
+in the FrameLoadDelegate and print the output in response to the notification.
+
+* DumpRenderTree/mac/FrameLoadDelegate.mm:
+(-[FrameLoadDelegate init]):
+(-[FrameLoadDelegate dealloc]):
+(-[FrameLoadDelegate webViewProgressFinishedNotification:]):
+
2011-11-09 Philippe Normand pnorm...@igalia.com
[GTK][DRT] window internals object is not reset after each test
Modified: trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm (99761 => 99762)
--- trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm 2011-11-09 22:29:29 UTC (rev 99761)
+++ trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm 2011-11-09 22:43:05 UTC (rev 99762)
@@ -33,6 +33,7 @@
#import AccessibilityController.h
#import AppleScriptController.h
#import EventSendingController.h
+#import Foundation/NSNotification.h
#import GCController.h
#import LayoutTestController.h
#import NavigationController.h
@@ -106,12 +107,14 @@
if ((self = [super init])) {
gcController = new GCController;
accessibilityController = new AccessibilityController;
+[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(webViewProgressFinishedNotification:) name:WebViewProgressFinishedNotification object:nil];
}
return self;
}
- (void)dealloc
{
+[[NSNotificationCenter defaultCenter] removeObserver:self];
delete gcController;
delete accessibilityController;
[super dealloc];
@@ -411,4 +414,10 @@
printf (didDetectXSS\n);
}
+- (void)webViewProgressFinishedNotification:(NSNotification *)notification
+{
+if (!done gLayoutTestController-dumpProgressFinishedCallback())
+printf (postProgressFinishedNotification\n);
+}
+
@end
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99764] trunk/Source/WebCore
Title: [99764] trunk/Source/WebCore
Revision 99764
Author hara...@chromium.org
Date 2011-11-09 14:58:30 -0800 (Wed, 09 Nov 2011)
Log Message
Replace [CanBeConstructed] IDL with [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71927
Reviewed by Adam Barth.
With respect to the IDL files that have [CanBeConstructed]
but do not have [Constructor] nor [CustomConstructor],
[CanBeConstructed] is now equivalent to [Constructor].
Thus, this patch replaces [CanBeConstructed] with [Constructor].
No tests. No change in behavior.
* fileapi/FileReaderSync.idl: As I described above.
* fileapi/WebKitBlobBuilder.idl: Ditto.
* fileapi/WebKitFlags.idl: Ditto.
* xml/DOMParser.idl: Ditto.
* xml/XMLSerializer.idl: Ditto.
* xml/XPathEvaluator.idl: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/FileReaderSync.idl
trunk/Source/WebCore/fileapi/WebKitBlobBuilder.idl
trunk/Source/WebCore/fileapi/WebKitFlags.idl
trunk/Source/WebCore/xml/DOMParser.idl
trunk/Source/WebCore/xml/XMLSerializer.idl
trunk/Source/WebCore/xml/XPathEvaluator.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (99763 => 99764)
--- trunk/Source/WebCore/ChangeLog 2011-11-09 22:53:03 UTC (rev 99763)
+++ trunk/Source/WebCore/ChangeLog 2011-11-09 22:58:30 UTC (rev 99764)
@@ -1,3 +1,24 @@
+2011-11-09 Kentaro Hara hara...@chromium.org
+
+Replace [CanBeConstructed] IDL with [Constructor] IDL
+https://bugs.webkit.org/show_bug.cgi?id=71927
+
+Reviewed by Adam Barth.
+
+With respect to the IDL files that have [CanBeConstructed]
+but do not have [Constructor] nor [CustomConstructor],
+[CanBeConstructed] is now equivalent to [Constructor].
+Thus, this patch replaces [CanBeConstructed] with [Constructor].
+
+No tests. No change in behavior.
+
+* fileapi/FileReaderSync.idl: As I described above.
+* fileapi/WebKitBlobBuilder.idl: Ditto.
+* fileapi/WebKitFlags.idl: Ditto.
+* xml/DOMParser.idl: Ditto.
+* xml/XMLSerializer.idl: Ditto.
+* xml/XPathEvaluator.idl: Ditto.
+
2011-11-09 Noel Gordon noel.gor...@gmail.com
[chromium] Separate image encoding from dataURL construction
Modified: trunk/Source/WebCore/fileapi/FileReaderSync.idl (99763 => 99764)
--- trunk/Source/WebCore/fileapi/FileReaderSync.idl 2011-11-09 22:53:03 UTC (rev 99763)
+++ trunk/Source/WebCore/fileapi/FileReaderSync.idl 2011-11-09 22:58:30 UTC (rev 99764)
@@ -31,7 +31,7 @@
module html {
interface [
Conditional=BLOB,
-CanBeConstructed,
+Constructor,
NoStaticTables
] FileReaderSync {
[CallWith=ScriptExecutionContext] ArrayBuffer readAsArrayBuffer(in Blob blob)
Modified: trunk/Source/WebCore/fileapi/WebKitBlobBuilder.idl (99763 => 99764)
--- trunk/Source/WebCore/fileapi/WebKitBlobBuilder.idl 2011-11-09 22:53:03 UTC (rev 99763)
+++ trunk/Source/WebCore/fileapi/WebKitBlobBuilder.idl 2011-11-09 22:58:30 UTC (rev 99764)
@@ -30,7 +30,7 @@
module html {
interface [
-CanBeConstructed,
+Constructor,
GenerateNativeConverter,
NoStaticTables
] WebKitBlobBuilder {
Modified: trunk/Source/WebCore/fileapi/WebKitFlags.idl (99763 => 99764)
--- trunk/Source/WebCore/fileapi/WebKitFlags.idl 2011-11-09 22:53:03 UTC (rev 99763)
+++ trunk/Source/WebCore/fileapi/WebKitFlags.idl 2011-11-09 22:58:30 UTC (rev 99764)
@@ -31,7 +31,7 @@
module storage {
interface [
Conditional=FILE_SYSTEM,
-CanBeConstructed,
+Constructor,
NoStaticTables
] WebKitFlags {
attribute boolean create;
Modified: trunk/Source/WebCore/xml/DOMParser.idl (99763 => 99764)
--- trunk/Source/WebCore/xml/DOMParser.idl 2011-11-09 22:53:03 UTC (rev 99763)
+++ trunk/Source/WebCore/xml/DOMParser.idl 2011-11-09 22:58:30 UTC (rev 99764)
@@ -19,7 +19,7 @@
module xpath {
interface [
-CanBeConstructed
+Constructor
] DOMParser {
Document parseFromString(in [Optional=CallWithDefaultValue] DOMString str,
in [Optional=CallWithDefaultValue] DOMString contentType);
Modified: trunk/Source/WebCore/xml/XMLSerializer.idl (99763 => 99764)
--- trunk/Source/WebCore/xml/XMLSerializer.idl 2011-11-09 22:53:03 UTC (rev 99763)
+++ trunk/Source/WebCore/xml/XMLSerializer.idl 2011-11-09 22:58:30 UTC (rev 99764)
@@ -21,7 +21,7 @@
module xpath {
interface [
-CanBeConstructed
+Constructor
] XMLSerializer {
DOMString serializeToString(in [Optional=CallWithDefaultValue] Node node)
raises(DOMException);
Modified: trunk/Source/WebCore/xml/XPathEvaluator.idl (99763 => 99764)
--- trunk/Source/WebCore/xml/XPathEvaluator.idl 2011-11-09 22:53:03 UTC (rev 99763)
+++ trunk/Source/WebCore/xml/XPathEvaluator.idl 2011-11-09 22:58:30 UTC (rev 99764)
@@ -19,7 +19,7 @@
module xpath {
interface [
-CanBeConstructed,
+Constructor
[webkit-changes] [99770] trunk
Title: [99770] trunk
Revision 99770
Author dmazz...@google.com
Date 2011-11-09 15:28:12 -0800 (Wed, 09 Nov 2011)
Log Message
Source/WebKit/chromium: Fix crash by handling case when AccessibilityObject::lineForPosition
returns -1.
https://bugs.webkit.org/show_bug.cgi?id=71561
Adds layout test: platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html
Reviewed by Dimitri Glazkov.
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::lineBreaks):
Tools: [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
https://bugs.webkit.org/show_bug.cgi?id=71561
Reviewed by Dimitri Glazkov.
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::insertionPointLineNumberGetterCallback):
LayoutTests: [Chromium] Add new test for crash in WebAccessibilityObject::lineBreaks
https://bugs.webkit.org/show_bug.cgi?id=71561
Reviewed by Dimitri Glazkov.
* platform/chromium/accessibility/insertion-point-line-number-on-password-crashes-expected.txt: Added.
* platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/AccessibilityUIElement.cpp
Added Paths
trunk/LayoutTests/platform/chromium/accessibility/insertion-point-line-number-on-password-crashes-expected.txt
trunk/LayoutTests/platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html
Diff
Modified: trunk/LayoutTests/ChangeLog (99769 => 99770)
--- trunk/LayoutTests/ChangeLog 2011-11-09 23:27:51 UTC (rev 99769)
+++ trunk/LayoutTests/ChangeLog 2011-11-09 23:28:12 UTC (rev 99770)
@@ -1,3 +1,13 @@
+2011-11-09 Dominic Mazzoni dmazz...@google.com
+
+[Chromium] Add new test for crash in WebAccessibilityObject::lineBreaks
+https://bugs.webkit.org/show_bug.cgi?id=71561
+
+Reviewed by Dimitri Glazkov.
+
+* platform/chromium/accessibility/insertion-point-line-number-on-password-crashes-expected.txt: Added.
+* platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html: Added.
+
2011-11-09 Benjamin Poulain bpoul...@apple.com
Implement dumpProgressFinishedCallback() for Mac layoutTestController
Added: trunk/LayoutTests/platform/chromium/accessibility/insertion-point-line-number-on-password-crashes-expected.txt (0 => 99770)
--- trunk/LayoutTests/platform/chromium/accessibility/insertion-point-line-number-on-password-crashes-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/accessibility/insertion-point-line-number-on-password-crashes-expected.txt 2011-11-09 23:28:12 UTC (rev 99770)
@@ -0,0 +1,2 @@
+Line number for password element: 0
+
Added: trunk/LayoutTests/platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html (0 => 99770)
--- trunk/LayoutTests/platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html (rev 0)
+++ trunk/LayoutTests/platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html 2011-11-09 23:28:12 UTC (rev 99770)
@@ -0,0 +1,25 @@
+html
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+body
+
+div id=result/div
+
+input type=password id=password
+
+script
+if (window.accessibilityController) {
+var result = document.getElementById(result);
+
+var password = document.getElementById(password);
+password.focus();
+
+// Make sure this doesn't crash.
+lineNumber = accessibilityController.focusedElement.insertionPointLineNumber;
+result.innerText += Line number for password element: + lineNumber + \n;
+}
+/script
+/body
+/html
Modified: trunk/Source/WebKit/chromium/ChangeLog (99769 => 99770)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-09 23:27:51 UTC (rev 99769)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-09 23:28:12 UTC (rev 99770)
@@ -1,3 +1,16 @@
+2011-11-09 Dominic Mazzoni dmazz...@google.com
+
+Fix crash by handling case when AccessibilityObject::lineForPosition
+returns -1.
+https://bugs.webkit.org/show_bug.cgi?id=71561
+
+Adds layout test: platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html
+
+Reviewed by Dimitri Glazkov.
+
+* src/WebAccessibilityObject.cpp:
+(WebKit::WebAccessibilityObject::lineBreaks):
+
2011-11-09 Jay Civelli jcive...@chromium.org
Fix MHTML generation to use the QuotedPrintable encoding for text resources.
Modified: trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp (99769 => 99770)
--- trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp 2011-11-09 23:27:51 UTC (rev
[webkit-changes] [99803] trunk/Source/WebCore
Title: [99803] trunk/Source/WebCore
Revision 99803
Author mrobin...@webkit.org
Date 2011-11-09 19:10:09 -0800 (Wed, 09 Nov 2011)
Log Message
[Cairo] Avoid clipping when painting more often
https://bugs.webkit.org/show_bug.cgi?id=71179
Reviewed by Xan Lopez.
No new tests. These changes are covered by existing tests.
* platform/graphics/Gradient.h: Add a Cairo-specific method
that gets the platform gradient with a particular alpha value.
* platform/graphics/cairo/GradientCairo.cpp: Now cache the alpha
value of the last created platform gradient.
(WebCore::Gradient::platformGradient): If the cached platform gradient
has a different alpha value than the one requested, destroy it and start
over.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow): Adjust the source to avoid calling
cairo_clip/cairo_paint_with_alpha and just do a fill.
(WebCore::shadowAndFillCurrentCairoPath): No need to clip here. Just
call cairo_fill.
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::drawPatternToCairoContext): If we have a = 1 alpha value
we can simply fill and avoid calling cairo_clip here.
(WebCore::prepareCairoContextSource): Remove TODO about recreating the
gradient. No longer need to reduce the gradient source.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Gradient.h
trunk/Source/WebCore/platform/graphics/cairo/GradientCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99802 => 99803)
--- trunk/Source/WebCore/ChangeLog 2011-11-10 03:00:43 UTC (rev 99802)
+++ trunk/Source/WebCore/ChangeLog 2011-11-10 03:10:09 UTC (rev 99803)
@@ -1,3 +1,30 @@
+2011-11-09 Martin Robinson mrobin...@igalia.com
+
+[Cairo] Avoid clipping when painting more often
+https://bugs.webkit.org/show_bug.cgi?id=71179
+
+Reviewed by Xan Lopez.
+
+No new tests. These changes are covered by existing tests.
+
+* platform/graphics/Gradient.h: Add a Cairo-specific method
+that gets the platform gradient with a particular alpha value.
+* platform/graphics/cairo/GradientCairo.cpp: Now cache the alpha
+value of the last created platform gradient.
+(WebCore::Gradient::platformGradient): If the cached platform gradient
+has a different alpha value than the one requested, destroy it and start
+over.
+* platform/graphics/cairo/GraphicsContextCairo.cpp:
+(WebCore::drawPathShadow): Adjust the source to avoid calling
+cairo_clip/cairo_paint_with_alpha and just do a fill.
+(WebCore::shadowAndFillCurrentCairoPath): No need to clip here. Just
+call cairo_fill.
+* platform/graphics/cairo/PlatformContextCairo.cpp:
+(WebCore::drawPatternToCairoContext): If we have a = 1 alpha value
+we can simply fill and avoid calling cairo_clip here.
+(WebCore::prepareCairoContextSource): Remove TODO about recreating the
+gradient. No longer need to reduce the gradient source.
+
2011-11-09 Alexey Proskuryakov a...@apple.com
rdar://problem/10423024 WebProcess doesn't use AuthBrokerAgent for proxy credentials
Modified: trunk/Source/WebCore/platform/graphics/Gradient.h (99802 => 99803)
--- trunk/Source/WebCore/platform/graphics/Gradient.h 2011-11-10 03:00:43 UTC (rev 99802)
+++ trunk/Source/WebCore/platform/graphics/Gradient.h 2011-11-10 03:10:09 UTC (rev 99803)
@@ -138,6 +138,8 @@
#if USE(CG)
void paint(CGContextRef);
void paint(GraphicsContext*);
+#elif USE(CAIRO)
+PlatformGradient platformGradient(float globalAlpha);
#endif
private:
@@ -163,6 +165,11 @@
AffineTransform m_gradientSpaceTransformation;
PlatformGradient m_gradient;
+
+#if USE(CAIRO)
+float m_platformGradientAlpha;
+#endif
+
};
} //namespace
Modified: trunk/Source/WebCore/platform/graphics/cairo/GradientCairo.cpp (99802 => 99803)
--- trunk/Source/WebCore/platform/graphics/cairo/GradientCairo.cpp 2011-11-10 03:00:43 UTC (rev 99802)
+++ trunk/Source/WebCore/platform/graphics/cairo/GradientCairo.cpp 2011-11-10 03:10:09 UTC (rev 99803)
@@ -44,9 +44,17 @@
cairo_pattern_t* Gradient::platformGradient()
{
-if (m_gradient)
+return platformGradient(1);
+}
+
+cairo_pattern_t* Gradient::platformGradient(float globalAlpha)
+{
+if (m_gradient m_platformGradientAlpha == globalAlpha)
return m_gradient;
+platformDestroy();
+m_platformGradientAlpha = globalAlpha;
+
if (m_radial)
m_gradient = cairo_pattern_create_radial(m_p0.x(), m_p0.y(), m_r0, m_p1.x(), m_p1.y(), m_r1);
else
@@ -54,7 +62,9 @@
VectorColorStop::iterator stopIterator = m_stops.begin();
while (stopIterator != m_stops.end()) {
-cairo_pattern_add_color_stop_rgba(m_gradient, stopIterator-stop, stopIterator-red,
[webkit-changes] [99806] trunk/Source/WebCore
Title: [99806] trunk/Source/WebCore
Revision 99806
Author kev...@webkit.org
Date 2011-11-09 20:21:31 -0800 (Wed, 09 Nov 2011)
Log Message
[wx] Unreviewed build fix. Update how we hash the font after changes to the StringHasher APIs.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/wx/FontPlatformDataWx.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99805 => 99806)
--- trunk/Source/WebCore/ChangeLog 2011-11-10 04:17:53 UTC (rev 99805)
+++ trunk/Source/WebCore/ChangeLog 2011-11-10 04:21:31 UTC (rev 99806)
@@ -1,5 +1,13 @@
2011-11-09 Kevin Ollivier kev...@theolliviers.com
+[wx] Unreviewed build fix. Update how we hash the font after
+changes to the StringHasher APIs.
+
+* platform/graphics/wx/FontPlatformDataWx.cpp:
+(WebCore::FontPlatformData::computeHash):
+
+2011-11-09 Kevin Ollivier kev...@theolliviers.com
+
[wx] Unreviewed build fix. Remove from WebDOMEventTarget
bindings methods that have been removed from EventTarget.
Modified: trunk/Source/WebCore/platform/graphics/wx/FontPlatformDataWx.cpp (99805 => 99806)
--- trunk/Source/WebCore/platform/graphics/wx/FontPlatformDataWx.cpp 2011-11-10 04:17:53 UTC (rev 99805)
+++ trunk/Source/WebCore/platform/graphics/wx/FontPlatformDataWx.cpp 2011-11-10 04:21:31 UTC (rev 99806)
@@ -122,13 +122,14 @@
// make a hash that is unique for this font, but not globally unique - that is,
// a font whose properties are equal should generate the same hash
+const char* fontName = thisFont-GetFaceName().utf8_str();
uintptr_t hashCodes[6] = {
thisFont-GetPointSize(),
thisFont-GetFamily(),
thisFont-GetStyle(),
thisFont-GetWeight(),
-thisFont-GetUnderlined(),
-StringHasher::computeHash(thisFont-GetFaceName().utf8_str().data())
+thisFont-GetUnderlined(),
+(uintptr_t)thisFont
};
return StringHasher::hashMemorysizeof(hashCodes)(hashCodes);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99807] trunk/Source/WebCore
Title: [99807] trunk/Source/WebCore
Revision 99807
Author kev...@webkit.org
Date 2011-11-09 20:28:58 -0800 (Wed, 09 Nov 2011)
Log Message
[wx] Unreviewed build fix. Don't run fontDataForCombiningCharacterSequence on wx as we don't support it yet.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (99806 => 99807)
--- trunk/Source/WebCore/ChangeLog 2011-11-10 04:21:31 UTC (rev 99806)
+++ trunk/Source/WebCore/ChangeLog 2011-11-10 04:28:58 UTC (rev 99807)
@@ -1,5 +1,14 @@
2011-11-09 Kevin Ollivier kev...@theolliviers.com
+[wx] Unreviewed build fix. Don't run
+fontDataForCombiningCharacterSequence on wx as we don't
+support it yet.
+
+* platform/graphics/mac/ComplexTextController.cpp:
+(WebCore::ComplexTextController::collectComplexTextRuns):
+
+2011-11-09 Kevin Ollivier kev...@theolliviers.com
+
[wx] Unreviewed build fix. Update how we hash the font after
changes to the StringHasher APIs.
Modified: trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp (99806 => 99807)
--- trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp 2011-11-10 04:21:31 UTC (rev 99806)
+++ trunk/Source/WebCore/platform/graphics/mac/ComplexTextController.cpp 2011-11-10 04:28:58 UTC (rev 99807)
@@ -250,6 +250,7 @@
}
nextIsMissingGlyph = false;
+#if !PLATFORM(WX)
nextFontData = m_font.fontDataForCombiningCharacterSequence(sequenceStart, curr - sequenceStart, nextIsSmallCaps ? SmallCapsVariant : NormalVariant);
if (!nextFontData) {
if (markCount)
@@ -257,6 +258,7 @@
else
nextIsMissingGlyph = true;
}
+#endif
while (curr end) {
fontData = nextFontData;
@@ -277,6 +279,7 @@
}
nextIsMissingGlyph = false;
+#if !PLATFORM(WX)
nextFontData = m_font.fontDataForCombiningCharacterSequence(cp + index, curr - cp - index, nextIsSmallCaps ? SmallCapsVariant : NormalVariant);
if (!nextFontData) {
if (markCount)
@@ -284,6 +287,7 @@
else
nextIsMissingGlyph = true;
}
+#endif
if (nextFontData != fontData || nextIsMissingGlyph != isMissingGlyph) {
int itemStart = static_castint(indexOfFontTransition);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [99814] trunk
Title: [99814] trunk
Revision 99814
Author commit-qu...@webkit.org
Date 2011-11-09 22:10:59 -0800 (Wed, 09 Nov 2011)
Log Message
Internals.markerRangeForNode should be able to take markers by specifying a marker type.
https://bugs.webkit.org/show_bug.cgi?id=71792
Patch by Shinya Kawanaka shin...@google.com on 2011-11-09
Reviewed by Hajime Morita.
.:
* Source/autotools/symbols.filter: Exposed necessary symbols.
Source/WebCore:
Test: editing/spelling/markers.html
* WebCore.exp.in:
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::markersFor):
Takes marker types to get only necessary markers.
* dom/DocumentMarkerController.h:
* testing/Internals.cpp:
(WebCore::markerTypesFrom): Added.
(WebCore::Internals::markerCountForNode):
Takes marker types to get only necessary markers.
(WebCore::Internals::markerRangeForNode): ditto.
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def: Exposed necessary references.
* win/WebKit2CFLite.def: ditto.
LayoutTests:
* editing/spelling/markers.html: Added.
* editing/spelling/spelling-insert-html.html: Fixed function usage.
* platform/chromium/test_expectations.txt: Skipped chromium test.
* platform/gtk/Skipped: Skipped gtk test.
* platform/qt/Skipped: Skipped qt test.
* platform/win/Skipped: Skeipped win test.
Modified Paths
trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/spelling/spelling-insert-html.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/dom/DocumentMarkerController.cpp
trunk/Source/WebCore/dom/DocumentMarkerController.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def
trunk/Source/WebKit2/win/WebKit2CFLite.def
trunk/Source/autotools/symbols.filter
Added Paths
trunk/LayoutTests/editing/spelling/markers.html
Diff
Modified: trunk/ChangeLog (99813 => 99814)
--- trunk/ChangeLog 2011-11-10 05:45:25 UTC (rev 99813)
+++ trunk/ChangeLog 2011-11-10 06:10:59 UTC (rev 99814)
@@ -1,3 +1,12 @@
+2011-11-09 Shinya Kawanaka shin...@google.com
+
+Internals.markerRangeForNode should be able to take markers by specifying a marker type.
+https://bugs.webkit.org/show_bug.cgi?id=71792
+
+Reviewed by Hajime Morita.
+
+* Source/autotools/symbols.filter: Exposed necessary symbols.
+
2011-11-09 Kevin Ollivier kev...@theolliviers.com
[wx] Unreviewed build fix. Update project files.
Modified: trunk/LayoutTests/ChangeLog (99813 => 99814)
--- trunk/LayoutTests/ChangeLog 2011-11-10 05:45:25 UTC (rev 99813)
+++ trunk/LayoutTests/ChangeLog 2011-11-10 06:10:59 UTC (rev 99814)
@@ -1,3 +1,17 @@
+2011-11-09 Shinya Kawanaka shin...@google.com
+
+Internals.markerRangeForNode should be able to take markers by specifying a marker type.
+https://bugs.webkit.org/show_bug.cgi?id=71792
+
+Reviewed by Hajime Morita.
+
+* editing/spelling/markers.html: Added.
+* editing/spelling/spelling-insert-html.html: Fixed function usage.
+* platform/chromium/test_expectations.txt: Skipped chromium test.
+* platform/gtk/Skipped: Skipped gtk test.
+* platform/qt/Skipped: Skipped qt test.
+* platform/win/Skipped: Skeipped win test.
+
2011-11-09 Andrew Scherkus scher...@chromium.org
More media rebaselines due to r98596.
Added: trunk/LayoutTests/editing/spelling/markers.html (0 => 99814)
--- trunk/LayoutTests/editing/spelling/markers.html (rev 0)
+++ trunk/LayoutTests/editing/spelling/markers.html 2011-11-10 06:10:59 UTC (rev 99814)
@@ -0,0 +1,83 @@
+!DOCTYPE html
+html
+head
+style
+.editing {
+border: 2px solid red;
+padding: 12px;
+font-size: 24px;
+}
+/style
+script src="" language=_javascript_ type=text/_javascript_ /script
+script src=""
+/head
+body
+pre id=description/pre
+pre id=console/pre
+div id=container
+/div
+
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function createEditableElement(id, parent) {
+var e = document.createElement('div');
+e.setAttribute(contentEditable, true);
+e.className = 'editing';
+e.id = id;
+
+parent.appendChild(e);
+return e;
+}
+
+function typeText(elem, text) {
+elem.focus();
+for (var i = 0; i text.length; ++i) {
+typeCharacterCommand(text[i]);
+}
+}
+
+var container = document.getElementById('container');
+var range;
+
+debug(Grammar Error Only);
+var id = 'id1'
+var e = createEditableElement(id, container);
+typeText(e, 'I have a issue.');
+if (window.internals) {
+shouldBe('internals.markerCountForNode(e.firstChild, spelling)', '0');
+
[webkit-changes] [99819] trunk/Source/WebCore
Title: [99819] trunk/Source/WebCore
Revision 99819
Author pfeld...@chromium.org
Date 2011-11-09 23:59:18 -0800 (Wed, 09 Nov 2011)
Log Message
Web Inspector: console does not work after switching panel while editing.
https://bugs.webkit.org/show_bug.cgi?id=71918
Reviewed by Yury Semikhatsky.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (99818 => 99819)
--- trunk/Source/WebCore/ChangeLog 2011-11-10 07:39:50 UTC (rev 99818)
+++ trunk/Source/WebCore/ChangeLog 2011-11-10 07:59:18 UTC (rev 99819)
@@ -1,3 +1,14 @@
+2011-11-09 Pavel Feldman pfeld...@google.com
+
+Web Inspector: console does not work after switching panel while editing.
+https://bugs.webkit.org/show_bug.cgi?id=71918
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/SourceFrame.js:
+(WebInspector.SourceFrame.prototype.wasShown):
+(WebInspector.SourceFrame.prototype.willHide):
+
2011-11-09 Rakesh KN rakesh...@motorola.com
Need support for dirname attribute
Modified: trunk/Source/WebCore/inspector/front-end/SourceFrame.js (99818 => 99819)
--- trunk/Source/WebCore/inspector/front-end/SourceFrame.js 2011-11-10 07:39:50 UTC (rev 99818)
+++ trunk/Source/WebCore/inspector/front-end/SourceFrame.js 2011-11-10 07:59:18 UTC (rev 99819)
@@ -83,6 +83,8 @@
{
this._ensureContentLoaded();
this._textViewer.show(this.element);
+if (this._wasHiddenWhileEditing)
+this.setReadOnly(false);
},
willHide: function()
@@ -92,7 +94,9 @@
this._textViewer.freeCachedElements();
this._clearLineHighlight();
-this._textViewer.readOnly = true;
+if (!this._textViewer.readOnly)
+this._wasHiddenWhileEditing = true;
+this.setReadOnly(true);
},
get statusBarItems()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
