[webkit-changes] [100415] trunk/LayoutTests

[jamesr]

Title: [100415] trunk/LayoutTests








Revision 100415
Author jam...@google.com
Date 2011-11-15 23:48:19 -0800 (Tue, 15 Nov 2011)


Log Message
[chromium] Update chromium mac compositing baselines
https://bugs.webkit.org/show_bug.cgi?id=72402

* platform/chromium-cg-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
* platform/chromium-cg-mac/animations/3d/matrix-transform-type-animation-expected.png: Removed.
* platform/chromium-cg-mac/animations/3d/state-at-end-event-transform-expected.png: Removed.
* platform/chromium-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png.
* platform/chromium-win/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Removed.
* platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
* platform/chromium-win/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
* platform/chromium/animations/3d/replace-filling-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/replace-filling-transform-expected.png.
* platform/chromium/animations/3d/state-at-end-event-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png.
* platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png.
* platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt.
* platform/chromium/platform/chromium/compositing/layout-width-change-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png.
* platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png.
* platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt.
* platform/chromium/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium/animations/3d/
trunk/LayoutTests/platform/chromium/animations/3d/replace-filling-transform-expected.png
trunk/LayoutTests/platform/chromium/animations/3d/state-at-end-event-transform-expected.png
trunk/LayoutTests/platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png
trunk/LayoutTests/platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.txt
trunk/LayoutTests/platform/chromium/platform/chromium/compositing/layout-width-change-expected.png
trunk/LayoutTests/platform/chromium/platform/chromium/compositing/plugins/
trunk/LayoutTests/platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.png
trunk/LayoutTests/platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt
trunk/LayoutTests/platform/chromium/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/animations/
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/animations/3d/
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/platform/
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/platform/chromium/
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/pl

[webkit-changes] [100414] trunk/Source/WebKit2

[carlosgc]

Title: [100414] trunk/Source/WebKit2








Revision 100414
Author carlo...@webkit.org
Date 2011-11-15 23:47:46 -0800 (Tue, 15 Nov 2011)


Log Message
[GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72380

Reviewed by Martin Robinson.

It adds an initial implementation of WebKitNetworkRequest
class that only contains a URI for now.

* GNUmakefile.am:
* UIProcess/API/gtk/WebKitNetworkRequest.cpp: Added.
(webkitNetworkRequestFinalize):
(webkitNetworkRequestGetProperty):
(webkitNetworkRequestSetProperty):
(webkit_network_request_class_init):
(webkit_network_request_init):
(webkit_network_request_new):
(webkit_network_request_get_uri):
* UIProcess/API/gtk/WebKitNetworkRequest.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_request): Use WKPageLoadURLRequest() to load
the given WebKitNetworkRequest.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(testLoadRequest):
(beforeAll):
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::loadRequest):
* UIProcess/API/gtk/tests/WebViewTest.h:
* UIProcess/API/gtk/webkit2.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h
trunk/Source/WebKit2/UIProcess/API/gtk/webkit2.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (100413 => 100414)

--- trunk/Source/WebKit2/ChangeLog	2011-11-16 07:24:21 UTC (rev 100413)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-16 07:47:46 UTC (rev 100414)
@@ -1,3 +1,36 @@
+2011-11-15  Carlos Garcia Campos  
+
+[GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API
+https://bugs.webkit.org/show_bug.cgi?id=72380
+
+Reviewed by Martin Robinson.
+
+It adds an initial implementation of WebKitNetworkRequest
+class that only contains a URI for now.
+
+* GNUmakefile.am:
+* UIProcess/API/gtk/WebKitNetworkRequest.cpp: Added.
+(webkitNetworkRequestFinalize):
+(webkitNetworkRequestGetProperty):
+(webkitNetworkRequestSetProperty):
+(webkit_network_request_class_init):
+(webkit_network_request_init):
+(webkit_network_request_new):
+(webkit_network_request_get_uri):
+* UIProcess/API/gtk/WebKitNetworkRequest.h: Added.
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkit_web_view_load_request): Use WKPageLoadURLRequest() to load
+the given WebKitNetworkRequest.
+* UIProcess/API/gtk/WebKitWebView.h:
+* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
+* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
+(testLoadRequest):
+(beforeAll):
+* UIProcess/API/gtk/tests/WebViewTest.cpp:
+(WebViewTest::loadRequest):
+* UIProcess/API/gtk/tests/WebViewTest.h:
+* UIProcess/API/gtk/webkit2.h:
+
 2011-11-15  Andy Estes  
 
 Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation


Modified: trunk/Source/WebKit2/GNUmakefile.am (100413 => 100414)

--- trunk/Source/WebKit2/GNUmakefile.am	2011-11-16 07:24:21 UTC (rev 100413)
+++ trunk/Source/WebKit2/GNUmakefile.am	2011-11-16 07:47:46 UTC (rev 100414)
@@ -79,6 +79,7 @@
 	$(WebKit2)/UIProcess/API/gtk/WebKitBackForwardListItem.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitDefines.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitError.h \
+	$(WebKit2)/UIProcess/API/gtk/WebKitNetworkRequest.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitWebContext.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitWebLoaderClient.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitSettings.h \
@@ -501,6 +502,8 @@
 	Source/WebKit2/UIProcess/API/gtk/WebKitDefines.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitError.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitError.cpp \
+	Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.cpp \
+	Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp \
 	Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h \


Added: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.cpp (0 => 100414)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.cpp	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitNetworkRequest.cpp	2011-11-16 

[webkit-changes] [100413] trunk

[sergio]

Title: [100413] trunk








Revision 100413
Author ser...@webkit.org
Date 2011-11-15 23:24:21 -0800 (Tue, 15 Nov 2011)


Log Message
[WK2] [GTK] fast/css/webkit-mask-crash-fieldset-legend.html asserts WebKitWebProcess
https://bugs.webkit.org/show_bug.cgi?id=69510

Reviewed by Simon Fraser.

Source/WebCore:

End the current transparency layer before early returning from
paintMask() when there is a maskBoxImage which is still being
loaded. This will balance the previous call to
beginTransparencyLayer().

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintMask):

LayoutTests:

Unskipped tests that are now passing.

* platform/gtk/Skipped:
* platform/gtk-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/gtk-wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineFlowBox.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (100412 => 100413)

--- trunk/LayoutTests/ChangeLog	2011-11-16 07:23:17 UTC (rev 100412)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 07:24:21 UTC (rev 100413)
@@ -1,3 +1,15 @@
+2011-11-15  Sergio Villar Senin  
+
+[WK2] [GTK] fast/css/webkit-mask-crash-fieldset-legend.html asserts WebKitWebProcess
+https://bugs.webkit.org/show_bug.cgi?id=69510
+
+Reviewed by Simon Fraser.
+
+Unskipped tests that are now passing.
+
+* platform/gtk/Skipped:
+* platform/gtk-wk2/Skipped:
+
 2011-11-15  James Robinson  
 
 [chromium] Land specific expectations for compositing tests


Modified: trunk/LayoutTests/platform/gtk/Skipped (100412 => 100413)

--- trunk/LayoutTests/platform/gtk/Skipped	2011-11-16 07:23:17 UTC (rev 100412)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-11-16 07:24:21 UTC (rev 100413)
@@ -155,10 +155,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=69001
 plugins/js-from-destroy.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=71454
-fast/css/webkit-mask-crash-fieldset-legend.html
-fast/css/webkit-mask-crash-table.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=72245
 fast/images/size-failure.html
 


Modified: trunk/LayoutTests/platform/gtk-wk2/Skipped (100412 => 100413)

--- trunk/LayoutTests/platform/gtk-wk2/Skipped	2011-11-16 07:23:17 UTC (rev 100412)
+++ trunk/LayoutTests/platform/gtk-wk2/Skipped	2011-11-16 07:24:21 UTC (rev 100413)
@@ -79,10 +79,6 @@
 # TESTS CRASHING
 ###
 
-# [WK2] [GTK] fast/css/webkit-mask-crash-fieldset-legend.html asserts WebKitWebProcess
-# https://bugs.webkit.org/show_bug.cgi?id=69510
-fast/css/webkit-mask-crash-fieldset-legend.html
-
 # [WK2] [GTK] plugins/destroy-during-npp-new.html segfaults WebKitWebProcess
 # https://bugs.webkit.org/show_bug.cgi?id=69512
 plugins/destroy-during-npp-new.html


Modified: trunk/Source/WebCore/ChangeLog (100412 => 100413)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 07:23:17 UTC (rev 100412)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 07:24:21 UTC (rev 100413)
@@ -1,3 +1,18 @@
+2011-11-15  Sergio Villar Senin  
+
+[WK2] [GTK] fast/css/webkit-mask-crash-fieldset-legend.html asserts WebKitWebProcess
+https://bugs.webkit.org/show_bug.cgi?id=69510
+
+Reviewed by Simon Fraser.
+
+End the current transparency layer before early returning from
+paintMask() when there is a maskBoxImage which is still being
+loaded. This will balance the previous call to
+beginTransparencyLayer().
+
+* rendering/InlineFlowBox.cpp:
+(WebCore::InlineFlowBox::paintMask):
+
 2011-11-15  Darin Adler  
 
 Incorrect type checks in RenderTheme media code


Modified: trunk/Source/WebCore/rendering/InlineFlowBox.cpp (100412 => 100413)

--- trunk/Source/WebCore/rendering/InlineFlowBox.cpp	2011-11-16 07:23:17 UTC (rev 100412)
+++ trunk/Source/WebCore/rendering/InlineFlowBox.cpp	2011-11-16 07:24:21 UTC (rev 100413)
@@ -1281,8 +1281,11 @@
 paintFillLayers(paintInfo, Color(), renderer()->style()->maskLayers(), paintRect, compositeOp);
 
 bool hasBoxImage = maskBoxImage && maskBoxImage->canRender(renderer(), renderer()->style()->effectiveZoom());
-if (!hasBoxImage || !maskBoxImage->isLoaded())
+if (!hasBoxImage || !maskBoxImage->isLoaded()) {
+if (pushTransparencyLayer)
+paintInfo.context->endTransparencyLayer();
 return; // Don't paint anything while we wait for the image to load.
+}
 
 // The simple case is where we are the only box for this object.  In those
 // cases only a single call to draw is required.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100412] trunk/Source/JavaScriptCore

[ossy]

Title: [100412] trunk/Source/_javascript_Core








Revision 100412
Author o...@webkit.org
Date 2011-11-15 23:23:17 -0800 (Tue, 15 Nov 2011)


Log Message
Unreviewed, rolling out r100375 and r100385.
http://trac.webkit.org/changeset/100375
http://trac.webkit.org/changeset/100385
https://bugs.webkit.org/show_bug.cgi?id=72465

They broke 32 bit builds on Qt (Requested by ossy on #webkit).

Patch by Sheriff Bot  on 2011-11-15

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArgList.cpp:
(JSC::ArgList::getSlice):
* runtime/ArgList.h:
(JSC::ArgList::ArgList):
* runtime/JSArray.cpp:
* runtime/JSArray.h:
* runtime/JSGlobalObject.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/runtime/ArgList.cpp
trunk/Source/_javascript_Core/runtime/ArgList.h
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/_javascript_Core/runtime/JSArray.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (100411 => 100412)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-16 07:19:24 UTC (rev 100411)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-16 07:23:17 UTC (rev 100412)
@@ -1,3 +1,23 @@
+2011-11-15  Sheriff Bot  
+
+Unreviewed, rolling out r100375 and r100385.
+http://trac.webkit.org/changeset/100375
+http://trac.webkit.org/changeset/100385
+https://bugs.webkit.org/show_bug.cgi?id=72465
+
+They broke 32 bit builds on Qt (Requested by ossy on #webkit).
+
+* dfg/DFGOperations.cpp:
+* jit/JITStubs.cpp:
+(JSC::DEFINE_STUB_FUNCTION):
+* runtime/ArgList.cpp:
+(JSC::ArgList::getSlice):
+* runtime/ArgList.h:
+(JSC::ArgList::ArgList):
+* runtime/JSArray.cpp:
+* runtime/JSArray.h:
+* runtime/JSGlobalObject.h:
+
 2011-11-15  George Staikos  
 
 Remove the guard page from the addressable stack region on QNX.


Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (100411 => 100412)

--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2011-11-16 07:19:24 UTC (rev 100411)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2011-11-16 07:23:17 UTC (rev 100412)
@@ -773,12 +773,14 @@
 
 EncodedJSValue DFG_OPERATION operationNewArray(ExecState* exec, void* start, size_t size)
 {
-return JSValue::encode(constructArray(exec, static_cast(start), size));
+ArgList argList(static_cast(start), size);
+return JSValue::encode(constructArray(exec, argList));
 }
 
 EncodedJSValue DFG_OPERATION operationNewArrayBuffer(ExecState* exec, size_t start, size_t size)
 {
-return constructArray(exec, exec->codeBlock()->constantBuffer(start), size);
+ArgList argList(exec->codeBlock()->constantBuffer(start), size);
+return JSValue::encode(constructArray(exec, argList));
 }
 
 EncodedJSValue DFG_OPERATION operationNewRegexp(ExecState* exec, void* regexpPtr)


Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (100411 => 100412)

--- trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-11-16 07:19:24 UTC (rev 100411)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-11-16 07:23:17 UTC (rev 100412)
@@ -2432,14 +2432,16 @@
 {
 STUB_INIT_STACK_FRAME(stackFrame);
 
-return constructArray(stackFrame.callFrame, reinterpret_cast(&stackFrame.callFrame->registers()[stackFrame.args[0].int32()]), stackFrame.args[1].int32());
+ArgList argList(&stackFrame.callFrame->registers()[stackFrame.args[0].int32()], stackFrame.args[1].int32());
+return constructArray(stackFrame.callFrame, argList);
 }
 
 DEFINE_STUB_FUNCTION(JSObject*, op_new_array_buffer)
 {
 STUB_INIT_STACK_FRAME(stackFrame);
 
-return constructArray(stackFrame.callFrame, stackFrame.callFrame->codeBlock()->constantBuffer(stackFrame.args[0].int32()), stackFrame.args[1].int32());
+ArgList argList(stackFrame.callFrame->codeBlock()->constantBuffer(stackFrame.args[0].int32()), stackFrame.args[1].int32());
+return constructArray(stackFrame.callFrame, argList);
 }
 
 DEFINE_STUB_FUNCTION(EncodedJSValue, op_resolve)


Modified: trunk/Source/_javascript_Core/runtime/ArgList.cpp (100411 => 100412)

--- trunk/Source/_javascript_Core/runtime/ArgList.cpp	2011-11-16 07:19:24 UTC (rev 100411)
+++ trunk/Source/_javascript_Core/runtime/ArgList.cpp	2011-11-16 07:23:17 UTC (rev 100412)
@@ -33,12 +33,10 @@
 void ArgList::getSlice(int startIndex, ArgList& result) const
 {
 if (startIndex <= 0 || static_cast(startIndex) >= m_argCount) {
-result = ArgList();
+result = ArgList(m_args, 0);
 return;
 }
-
-result.m_args = m_args + startIndex;
-result.m_argCount =  m_argCount - startIndex;
+result = ArgList(m_args + startIndex, m_argCount - startIndex);
 }
 
 void MarkedArgumentBuffer::markLists(HeapRootVisitor& heapRootVisitor, ListSet& markSet)

[webkit-changes] [100411] trunk/LayoutTests

[jamesr]

Title: [100411] trunk/LayoutTests








Revision 100411
Author jam...@google.com
Date 2011-11-15 23:19:24 -0800 (Tue, 15 Nov 2011)


Log Message
[chromium] Land specific expectations for compositing tests
https://bugs.webkit.org/show_bug.cgi?id=72402

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100410 => 100411)

--- trunk/LayoutTests/ChangeLog	2011-11-16 07:09:24 UTC (rev 100410)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 07:19:24 UTC (rev 100411)
@@ -1,5 +1,12 @@
 2011-11-15  James Robinson  
 
+[chromium] Land specific expectations for compositing tests
+https://bugs.webkit.org/show_bug.cgi?id=72402
+
+* platform/chromium/test_expectations.txt:
+
+2011-11-15  James Robinson  
+
 [chromium] Remove expected PASS expectations for compositing tests.
 
 This will result in a temporary spike in the number of unexpected


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100410 => 100411)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 07:09:24 UTC (rev 100410)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 07:19:24 UTC (rev 100411)
@@ -255,10 +255,61 @@
 // this test will always fail.
 WONTFIX SKIP LINUX WIN : fast/events/option-tab.html = FAIL
 
-BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : compositing = TIMEOUT FAIL
-BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : platform/chromium/compositing = TIMEOUT FAIL
-BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : animations/3d = TIMEOUT FAIL
+// win+linux failures, probably aren't applicable to this config
+BUGWK72402 WIN LINUX : compositing/video-page-visibility.html = FAIL
+BUGWK72402 WIN LINUX : compositing/geometry/clipped-video-controller.html = FAIL
+BUGWK72402 WIN LINUX : compositing/geometry/video-fixed-scrolling.html = FAIL
+BUGWK72402 WIN LINUX : compositing/geometry/video-opacity-overlay.html = FAIL
+BUGWK72402 WIN LINUX : compositing/layer-creation/spanOverlapsCanvas.html = FAIL
 
+// win+linux failures, either real bugs or need rebaselines
+BUGWK72402 WIN LINUX : compositing/framesets/resources/composited-subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-clipping-ancestor.html = FAIL
+BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-fixed-positioned.html = FAIL
+BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-overflow-root.html = FAIL
+BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-positioned-transition.html = FAIL
+BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-positioned.html = FAIL
+BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-transformed-overflow.html = FAIL
+BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-transformed.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/composited-red.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/composited-subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/enter-compositing-subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/fixed-position-subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/green-red-subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/has-composited-iframe-child.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/intermediate-frame.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/large-composited-subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/leave-compositing-subframe-click.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/leave-compositing-subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/nested-subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/page-cache-helper.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/page-cache-iframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/red-green-subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/repaint-after-losing-scrollbars-iframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/iframes/resources/subsubframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/layer-creation/scroll-partial-update.html = FAIL
+BUGWK72402 WIN LINUX : compositing/layers-inside-overflow-scroll.html = FAIL
+BUGWK72402 WIN LINUX : compositing/objects/resources/composited-subframe.html = FAIL
+BUGWK72402 WIN LINUX : compositing/overflow/overflow-compositing-descendant.html = FAIL
+BUGWK72402 WIN LINUX : compositing/overflow/scroll-ancestor-update.html = FAIL
+BUGWK72402 WIN LINUX : compositing/self-painting-layers.html = FAIL
+BUGWK72402 WIN LINUX : platform/chromium/compositing/force-compositing-mode/resources/subframe-b

[webkit-changes] [100410] trunk/Source/WebKit/qt

[commit-queue]

Title: [100410] trunk/Source/WebKit/qt








Revision 100410
Author commit-qu...@webkit.org
Date 2011-11-15 23:09:24 -0800 (Tue, 15 Nov 2011)


Log Message
[TexMap][Qt] Start PageClientQ[Graphics]Widget::syncTimer only when the syncTimer
is inactive.
https://bugs.webkit.org/show_bug.cgi?id=70407

Make sure we only activate the synchronization timer in
PageClientQWidget/PageClientQGraphicsWidget if it's not already active,
otherwise syncLayers may be called redundantly.

Patch by Huang Dongsung  on 2011-11-15
Reviewed by Noam Rosenthal.

* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::markForSync):
(WebCore::PageClientQWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::markForSync):
* WebCoreSupport/PageClientQt.h:
(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):

Modified Paths

trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.h




Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (100409 => 100410)

--- trunk/Source/WebKit/qt/ChangeLog	2011-11-16 06:46:48 UTC (rev 100409)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-11-16 07:09:24 UTC (rev 100410)
@@ -1,3 +1,23 @@
+2011-11-15  Huang Dongsung  
+
+[TexMap][Qt] Start PageClientQ[Graphics]Widget::syncTimer only when the syncTimer
+is inactive.
+https://bugs.webkit.org/show_bug.cgi?id=70407
+
+Make sure we only activate the synchronization timer in
+PageClientQWidget/PageClientQGraphicsWidget if it's not already active,
+otherwise syncLayers may be called redundantly.
+
+Reviewed by Noam Rosenthal.
+
+* WebCoreSupport/PageClientQt.cpp:
+(WebCore::PageClientQWidget::markForSync):
+(WebCore::PageClientQWidget::syncLayers):
+(WebCore::PageClientQGraphicsWidget::syncLayers):
+(WebCore::PageClientQGraphicsWidget::markForSync):
+* WebCoreSupport/PageClientQt.h:
+(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
+
 2011-11-15  Jochen Eisinger  
 
 Rename ReferrerPolicy to clarify its meaning


Modified: trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp (100409 => 100410)

--- trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp	2011-11-16 06:46:48 UTC (rev 100409)
+++ trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.cpp	2011-11-16 07:09:24 UTC (rev 100410)
@@ -85,6 +85,8 @@
 
 void PageClientQWidget::markForSync(bool scheduleSync)
 {
+if (syncTimer.isActive())
+return;
 syncTimer.startOneShot(0);
 }
 
@@ -95,7 +97,7 @@
 QWebFramePrivate::core(page->mainFrame())->view()->syncCompositingStateIncludingSubframes();
 if (!textureMapperNodeClient)
 return;
-if (textureMapperNodeClient->rootNode()->descendantsOrSelfHaveRunningAnimations())
+if (textureMapperNodeClient->rootNode()->descendantsOrSelfHaveRunningAnimations() && !syncTimer.isActive())
 syncTimer.startOneShot(1.0 / 60.0);
 update(view->rect());
 }
@@ -251,12 +253,9 @@
 if (!textureMapperNodeClient)
 return;
 
-if (textureMapperNodeClient->rootNode()->descendantsOrSelfHaveRunningAnimations())
+if (textureMapperNodeClient->rootNode()->descendantsOrSelfHaveRunningAnimations() && !syncTimer.isActive())
 syncTimer.startOneShot(1.0 / 60.0);
 update(view->boundingRect().toAlignedRect());
-if (!shouldSync)
-return;
-shouldSync = false;
 #endif
 }
 
@@ -298,7 +297,8 @@
 
 void PageClientQGraphicsWidget::markForSync(bool scheduleSync)
 {
-shouldSync = true;
+if (syncTimer.isActive())
+return;
 syncTimer.startOneShot(0);
 }
 


Modified: trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.h (100409 => 100410)

--- trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.h	2011-11-16 06:46:48 UTC (rev 100409)
+++ trunk/Source/WebKit/qt/WebCoreSupport/PageClientQt.h	2011-11-16 07:09:24 UTC (rev 100410)
@@ -161,7 +161,6 @@
 , viewResizesToContents(false)
 #if USE(ACCELERATED_COMPOSITING)
 , syncTimer(this, &PageClientQGraphicsWidget::syncLayersTimeout)
-, shouldSync(false)
 #endif
 , overlay(0)
 {
@@ -230,10 +229,6 @@
 #endif
 // we have to flush quite often, so we use a meta-method instead of QTimer::singleShot for putting the event in the queue
 Timer syncTimer;
-
-// we need to sync the layers if we get a special call from the WebCore
-// compositor telling us to do so. We'll get that call from ChromeClientQt
-bool shouldSync;
 #endif
 // the overlay gets instantiated when the root layer is attached, and get deleted when it's detached
 QGraphicsItemOverlay* overlay;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100409] trunk/Tools

[darin]

Title: [100409] trunk/Tools








Revision 100409
Author da...@apple.com
Date 2011-11-15 22:46:48 -0800 (Tue, 15 Nov 2011)


Log Message
DRT's uiElementAttributeValueCallback function is leaky
https://bugs.webkit.org/show_bug.cgi?id=72453

Reviewed by Dan Bernstein.

* DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp




Diff

Modified: trunk/Tools/ChangeLog (100408 => 100409)

--- trunk/Tools/ChangeLog	2011-11-16 06:46:27 UTC (rev 100408)
+++ trunk/Tools/ChangeLog	2011-11-16 06:46:48 UTC (rev 100409)
@@ -1,3 +1,13 @@
+2011-11-15  Darin Adler  
+
+DRT's uiElementAttributeValueCallback function is leaky
+https://bugs.webkit.org/show_bug.cgi?id=72453
+
+Reviewed by Dan Bernstein.
+
+* DumpRenderTree/AccessibilityUIElement.cpp:
+(uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
+
 2011-11-14  Ryosuke Niwa  
 
 Implement edit-distance based reviewer recognition algorithm


Modified: trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp (100408 => 100409)

--- trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp	2011-11-16 06:46:27 UTC (rev 100408)
+++ trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp	2011-11-16 06:46:48 UTC (rev 100409)
@@ -376,11 +376,11 @@
 
 static JSValueRef uiElementAttributeValueCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
 {
-JSStringRef attribute = 0;
+JSRetainPtr attribute;
 if (argumentCount == 1)
-attribute = JSValueToStringCopy(context, arguments[0], exception);
+attribute.adopt(JSValueToStringCopy(context, arguments[0], exception));
 
-return AccessibilityUIElement::makeJSAccessibilityUIElement(context, toAXElement(thisObject)->uiElementAttributeValue(attribute));
+return AccessibilityUIElement::makeJSAccessibilityUIElement(context, toAXElement(thisObject)->uiElementAttributeValue(attribute.get()));
 }
 
 static JSValueRef numberAttributeValueCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100408] trunk/Source/WebCore

[darin]

Title: [100408] trunk/Source/WebCore








Revision 100408
Author da...@apple.com
Date 2011-11-15 22:46:27 -0800 (Tue, 15 Nov 2011)


Log Message
Incorrect type checks in RenderTheme media code
https://bugs.webkit.org/show_bug.cgi?id=72184

Reviewed by Eric Carlson.

No tests added. Ideally this patch should be revised to add tests!

* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::create): Use mediaControlElementType.
(WebCore::AccessibilityMediaControl::controlType): Ditto.
(WebCore::AccessibilityMediaTimeline::valueDescription): Use early return
rather than an assertion to check type of input element.

* html/shadow/MediaControlElements.cpp:
(WebCore::mediaControlElementType): Added. A type-safe way to get the
media control element type after checking isMediaControlElement but with
no other assumptions.
* html/shadow/MediaControlElements.h: Added mediaControlElementType.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaPlayButton): Use mediaControlElementType.
(WebCore::RenderThemeEfl::paintMediaSeekBackButton): Use mediaControlElementType.
(WebCore::RenderThemeEfl::paintMediaSeekForwardButton): Use mediaControlElementType.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaPlayButton): Check isMediaControlElement and
use mediaControlElementType.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaMuteButton): Ditto. Also remove uneeded
redundant null check.
(WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityMediaControls.cpp
trunk/Source/WebCore/html/shadow/MediaControlElements.cpp
trunk/Source/WebCore/html/shadow/MediaControlElements.h
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp
trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp
trunk/Source/WebCore/rendering/RenderThemeMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (100407 => 100408)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 06:41:17 UTC (rev 100407)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 06:46:27 UTC (rev 100408)
@@ -1,3 +1,37 @@
+2011-11-15  Darin Adler  
+
+Incorrect type checks in RenderTheme media code
+https://bugs.webkit.org/show_bug.cgi?id=72184
+
+Reviewed by Eric Carlson.
+
+No tests added. Ideally this patch should be revised to add tests!
+
+* accessibility/AccessibilityMediaControls.cpp:
+(WebCore::AccessibilityMediaControl::create): Use mediaControlElementType.
+(WebCore::AccessibilityMediaControl::controlType): Ditto.
+(WebCore::AccessibilityMediaTimeline::valueDescription): Use early return
+rather than an assertion to check type of input element.
+
+* html/shadow/MediaControlElements.cpp:
+(WebCore::mediaControlElementType): Added. A type-safe way to get the
+media control element type after checking isMediaControlElement but with
+no other assumptions.
+* html/shadow/MediaControlElements.h: Added mediaControlElementType.
+
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::paintMediaPlayButton): Use mediaControlElementType.
+(WebCore::RenderThemeEfl::paintMediaSeekBackButton): Use mediaControlElementType.
+(WebCore::RenderThemeEfl::paintMediaSeekForwardButton): Use mediaControlElementType.
+* platform/gtk/RenderThemeGtk.cpp:
+(WebCore::RenderThemeGtk::paintMediaPlayButton): Check isMediaControlElement and
+use mediaControlElementType.
+* rendering/RenderThemeMac.mm:
+(WebCore::RenderThemeMac::paintMediaMuteButton): Ditto. Also remove uneeded
+redundant null check.
+(WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
+(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton): Ditto.
+
 2011-11-15  Jeff Timanus  
 
 [chromium] During tear down, prevent the WebGLLayerChromium instance from attempting to stop a timer for a NULL context.


Modified: trunk/Source/WebCore/accessibility/AccessibilityMediaControls.cpp (100407 => 100408)

--- trunk/Source/WebCore/accessibility/AccessibilityMediaControls.cpp	2011-11-16 06:41:17 UTC (rev 100407)
+++ trunk/Source/WebCore/accessibility/AccessibilityMediaControls.cpp	2011-11-16 06:46:27 UTC (rev 100408)
@@ -53,17 +53,9 @@
 
 PassRefPtr AccessibilityMediaControl::create(RenderObject* renderer)
 {
-ASSERT(renderer->node() && renderer->node()->isMediaControlElement());
+ASSERT(renderer->node());
 
-Node* node = renderer->node();
-MediaControlElementType controlType;
-
-if (node->hasTagName(inputTag))
-controlType = static_cast(node)->displayType();
-else
-controlType = static_cast(node)->displayType();
-
-switch (controlType) {
+switch (mediaControlElementType(renderer->node())) {
 case MediaSlider:
 return Acc

[webkit-changes] [100407] trunk/Tools

[rniwa]

Title: [100407] trunk/Tools








Revision 100407
Author rn...@webkit.org
Date 2011-11-15 22:41:17 -0800 (Tue, 15 Nov 2011)


Log Message
Implement edit-distance based reviewer recognition algorithm
https://bugs.webkit.org/show_bug.cgi?id=72351

Reviewed by Eric Seidel.

Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
"build fix" to a reviewer's name (e.g. with with edit distance 9).

This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
the edit distance is implemented in edit_distance.py.

Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.

* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/committers_unittest.py:
* Scripts/webkitpy/common/editdistance.py: Added.
* Scripts/webkitpy/common/editdistance_unittest.py: Added.
* Scripts/webkitpy/tool/steps/validatereviewer.py:
* Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py
trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py
trunk/Tools/Scripts/webkitpy/common/config/committers.py
trunk/Tools/Scripts/webkitpy/common/config/committers_unittest.py
trunk/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py


Added Paths

trunk/Tools/Scripts/webkitpy/common/editdistance.py
trunk/Tools/Scripts/webkitpy/common/editdistance_unittest.py


Removed Paths

trunk/Tools/Scripts/webkitpy/tool/steps/validatereviewer_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (100406 => 100407)

--- trunk/Tools/ChangeLog	2011-11-16 06:21:01 UTC (rev 100406)
+++ trunk/Tools/ChangeLog	2011-11-16 06:41:17 UTC (rev 100407)
@@ -1,3 +1,30 @@
+2011-11-14  Ryosuke Niwa  
+
+Implement edit-distance based reviewer recognition algorithm
+https://bugs.webkit.org/show_bug.cgi?id=72351
+
+Reviewed by Eric Seidel.
+
+Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
+its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
+Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
+"build fix" to a reviewer's name (e.g. with with edit distance 9).
+
+This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
+the edit distance is implemented in edit_distance.py.
+
+Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
+on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
+
+* Scripts/webkitpy/common/checkout/changelog.py:
+* Scripts/webkitpy/common/checkout/changelog_unittest.py:
+* Scripts/webkitpy/common/config/committers.py:
+* Scripts/webkitpy/common/config/committers_unittest.py:
+* Scripts/webkitpy/common/editdistance.py: Added.
+* Scripts/webkitpy/common/editdistance_unittest.py: Added.
+* Scripts/webkitpy/tool/steps/validatereviewer.py:
+* Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
+
 2011-11-15  Tony Chang  
 
 Skip a failing webkitpy test on cygwin.


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py (100406 => 100407)

--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py	2011-11-16 06:21:01 UTC (rev 100406)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py	2011-11-16 06:41:17 UTC (rev 100407)
@@ -146,6 +146,13 @@
 
 return reviewer_text, reviewer_list
 
+def _fuzz_match_reviewers(self, reviewers_text_list):
+if not reviewers_text_list:
+return []
+list_of_reviewers = [self._committer_list.contributors_by_fuzzy_match(reviewer)[0] for reviewer in reviewers_text_list]
+# Flatten lists and get rid of any reviewers with more than one candidate.
+return [reviewers[0] for reviewers in list_of_reviewers if len(reviewers) == 1]
+
 def _parse_entry(self):
 match = re.match(self.date_line_regexp, self._contents, re.MULTILINE)
 if not match:
@@ -155,8 +162,8 @@
 self._author_name = match.group("name") if match else None
 self._author_email = match.group("email") if match else None
 
-self._reviewer_text, self._reviewer_list = ChangeLogEntry._parse_reviewer_text(self._contents)
-self._reviewer = self

[webkit-changes] [100406] trunk/Source/JavaScriptCore

[staikos]

Title: [100406] trunk/Source/_javascript_Core








Revision 100406
Author stai...@webkit.org
Date 2011-11-15 22:21:01 -0800 (Tue, 15 Nov 2011)


Log Message
Remove the guard page from the addressable stack region on QNX.
https://bugs.webkit.org/show_bug.cgi?id=72455

Reviewed by Daniel Bates.

* wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/StackBounds.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (100405 => 100406)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-16 06:06:21 UTC (rev 100405)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-16 06:21:01 UTC (rev 100406)
@@ -1,3 +1,13 @@
+2011-11-15  George Staikos  
+
+Remove the guard page from the addressable stack region on QNX.
+https://bugs.webkit.org/show_bug.cgi?id=72455
+
+Reviewed by Daniel Bates.
+
+* wtf/StackBounds.cpp:
+(WTF::StackBounds::initialize):
+
 2011-11-15  Michael Saboff  
 
 Towards 8 bit Strings - Update utf8() and ascii() methods for 8 bit strings


Modified: trunk/Source/_javascript_Core/wtf/StackBounds.cpp (100405 => 100406)

--- trunk/Source/_javascript_Core/wtf/StackBounds.cpp	2011-11-16 06:06:21 UTC (rev 100405)
+++ trunk/Source/_javascript_Core/wtf/StackBounds.cpp	2011-11-16 06:21:01 UTC (rev 100406)
@@ -103,7 +103,7 @@
 stackSize = threadInfo.stksize;
 ASSERT(stackBase);
 
-m_bound = stackBase;
+m_bound = static_cast(stackBase) + 0x1000; // 4kb guard page
 m_origin = static_cast(stackBase) + stackSize;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100405] trunk/Source/JavaScriptCore

[msaboff]

Title: [100405] trunk/Source/_javascript_Core








Revision 100405
Author msab...@apple.com
Date 2011-11-15 22:06:21 -0800 (Tue, 15 Nov 2011)


Log Message
Towards 8 bit Strings - Update utf8() and ascii() methods for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=72323

Added 8 bit optimized paths for String and UString ascii() and utf8() methods.

Added String::characters8(), characters16() and is8Bit() helper methods.

Added an new Unicode::convertLatin1ToUTF8() method that works on
LChar (8 bit) strings that is a stripped down version of convertUTF16ToUTF8().

Reviewed by Geoff Garen.

* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
* runtime/UString.cpp:
(JSC::UString::utf8):
* wtf/text/WTFString.cpp:
(WTF::String::ascii):
(WTF::String::utf8):
* wtf/text/WTFString.h:
(WTF::String::characters8):
(WTF::String::characters16):
(WTF::String::is8Bit):
(WTF::LChar):
(WTF::UChar):
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::convertLatin1ToUTF8):
* wtf/unicode/UTF8.h:
* wtf/unicode/Unicode.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/runtime/UString.cpp
trunk/Source/_javascript_Core/wtf/text/WTFString.cpp
trunk/Source/_javascript_Core/wtf/text/WTFString.h
trunk/Source/_javascript_Core/wtf/unicode/UTF8.cpp
trunk/Source/_javascript_Core/wtf/unicode/UTF8.h
trunk/Source/_javascript_Core/wtf/unicode/Unicode.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (100404 => 100405)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-16 05:46:55 UTC (rev 100404)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-16 06:06:21 UTC (rev 100405)
@@ -1,3 +1,34 @@
+2011-11-15  Michael Saboff  
+
+Towards 8 bit Strings - Update utf8() and ascii() methods for 8 bit strings
+https://bugs.webkit.org/show_bug.cgi?id=72323
+
+Added 8 bit optimized paths for String and UString ascii() and utf8() methods.
+
+Added String::characters8(), characters16() and is8Bit() helper methods.
+
+Added an new Unicode::convertLatin1ToUTF8() method that works on
+LChar (8 bit) strings that is a stripped down version of convertUTF16ToUTF8().
+
+Reviewed by Geoff Garen.
+
+* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
+* runtime/UString.cpp:
+(JSC::UString::utf8):
+* wtf/text/WTFString.cpp:
+(WTF::String::ascii):
+(WTF::String::utf8):
+* wtf/text/WTFString.h:
+(WTF::String::characters8):
+(WTF::String::characters16):
+(WTF::String::is8Bit):
+(WTF::LChar):
+(WTF::UChar):
+* wtf/unicode/UTF8.cpp:
+(WTF::Unicode::convertLatin1ToUTF8):
+* wtf/unicode/UTF8.h:
+* wtf/unicode/Unicode.h:
+
 2011-11-15  Darin Adler  
 
 REGRESSION (r98887): ParserArena and Keywords leaking


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (100404 => 100405)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-11-16 05:46:55 UTC (rev 100404)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-11-16 06:06:21 UTC (rev 100405)
@@ -99,6 +99,7 @@
 ?constructEmptyArray@JSC@@YAPAVJSArray@1@PAVExecState@1@@Z
 ?constructEmptyObject@JSC@@YAPAVJSObject@1@PAVExecState@1@@Z
 ?constructFunctionSkippingEvalEnabledCheck@JSC@@YAPAVJSObject@1@PAVExecState@1@PAVJSGlobalObject@1@ABVArgList@1@ABVIdentifier@1@ABVUString@1@ABVTextPosition@WTF@@@Z
+?convertLatin1ToUTF8@Unicode@WTF@@YA?AW4ConversionResult@12@PAPBEPBEPAPADPAD@Z
 ?convertUTF16ToUTF8@Unicode@WTF@@YA?AW4ConversionResult@12@PAPB_WPB_WPAPADPAD_N@Z
 ?convertUTF8ToUTF16@Unicode@WTF@@YA?AW4ConversionResult@12@PAPBDPBDPAPA_WPA_W_N@Z
 ?create@ByteArray@WTF@@SA?AV?$PassRefPtr@VByteArray@WTF@@@2@I@Z


Modified: trunk/Source/_javascript_Core/runtime/UString.cpp (100404 => 100405)

--- trunk/Source/_javascript_Core/runtime/UString.cpp	2011-11-16 05:46:55 UTC (rev 100404)
+++ trunk/Source/_javascript_Core/runtime/UString.cpp	2011-11-16 06:06:21 UTC (rev 100405)
@@ -399,8 +399,8 @@
 {
 unsigned length = this->length();
 
-if (is8Bit())
-return CString(reinterpret_cast(characters8()), length);
+if (!length)
+return CString("", 0);
 
 // Allocate a buffer big enough to hold all the characters
 // (an individual UTF-16 UChar can only expand to 3 UTF-8 bytes).
@@ -415,30 +415,38 @@
 if (length > numeric_limits::max() / 3)
 return CString();
 
-const UChar* characters = this->characters16();
 Vector bufferVector(length * 3);
-
 char* buffer = bufferVector.data();
-ConversionResult result = convertUTF16ToUTF8(&characters, characters + length, &buffer, buffer + bufferVector.size(), strict);
-ASSERT(result != targetExhausted); // (length * 3) s

[webkit-changes] [100404] trunk/LayoutTests

[jamesr]

Title: [100404] trunk/LayoutTests








Revision 100404
Author jam...@google.com
Date 2011-11-15 21:46:55 -0800 (Tue, 15 Nov 2011)


Log Message
[chromium] Remove expected PASS expectations for compositing tests.

This will result in a temporary spike in the number of unexpected
PASSes reported by the bots, but will allow me to add specific
expectations for all the compositing tests instead of the current
blanket PASS FAIL line.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100403 => 100404)

--- trunk/LayoutTests/ChangeLog	2011-11-16 05:40:22 UTC (rev 100403)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 05:46:55 UTC (rev 100404)
@@ -1,5 +1,16 @@
 2011-11-15  James Robinson  
 
+[chromium] Remove expected PASS expectations for compositing tests.
+
+This will result in a temporary spike in the number of unexpected
+PASSes reported by the bots, but will allow me to add specific
+expectations for all the compositing tests instead of the current
+blanket PASS FAIL line.
+
+* platform/chromium/test_expectations.txt:
+
+2011-11-15  James Robinson  
+
 [chromium] Remove failing expectations from various JS tests that now pass.
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100403 => 100404)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 05:40:22 UTC (rev 100403)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 05:46:55 UTC (rev 100404)
@@ -255,9 +255,9 @@
 // this test will always fail.
 WONTFIX SKIP LINUX WIN : fast/events/option-tab.html = FAIL
 
-BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : compositing = PASS TIMEOUT FAIL
-BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : platform/chromium/compositing = PASS TIMEOUT FAIL
-BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : animations/3d = PASS TIMEOUT FAIL
+BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : compositing = TIMEOUT FAIL
+BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : platform/chromium/compositing = TIMEOUT FAIL
+BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : animations/3d = TIMEOUT FAIL
 
 // We don't ship compositing on Leopard.
 WONTFIX SKIP LEOPARD : compositing = PASS TIMEOUT FAIL






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100403] trunk/LayoutTests

[jamesr]

Title: [100403] trunk/LayoutTests








Revision 100403
Author jam...@google.com
Date 2011-11-15 21:40:22 -0800 (Tue, 15 Nov 2011)


Log Message
[chromium] Remove failing expectations from various JS tests that now pass.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100402 => 100403)

--- trunk/LayoutTests/ChangeLog	2011-11-16 05:33:23 UTC (rev 100402)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 05:40:22 UTC (rev 100403)
@@ -1,3 +1,9 @@
+2011-11-15  James Robinson  
+
+[chromium] Remove failing expectations from various JS tests that now pass.
+
+* platform/chromium/test_expectations.txt:
+
 2011-11-15  Anna Cavender  
 
 Make sure both the video and the track are ready to be tested before testing.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100402 => 100403)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 05:33:23 UTC (rev 100402)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 05:40:22 UTC (rev 100403)
@@ -2127,26 +2127,6 @@
 
 BUGCR48668 MAC : svg/W3C-SVG-1.1/struct-use-01-t.svg = FAIL
 
-// These ietestcenter tests still don't pass. Careful before removing these
-// that the baselines aren't incorrect
-// (like in: https://bugs.webkit.org/show_bug.cgi?id=42215)
-BUGCR48737 : ietestcenter/_javascript_/15.2.3.3-4-178.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.2.3.3-4-179.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.2.3.3-4-180.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.5.4.20-4-10.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.5.4.20-4-18.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.5.4.20-4-34.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.10.6.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.10.7.1-1.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.10.7.2-1.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.10.7.3-1.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.10.7.4-1.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.10.7.5-1.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.2.3.3-4-212.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.2.3.3-4-213.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.2.3.3-4-214.html = TEXT
-BUGCR48737 : ietestcenter/_javascript_/15.2.3.3-4-215.html = TEXT
-
 BUGCR49029 : fast/js/object-literal-syntax.html = TEXT
 
 BUGCR48859 WIN : fast/inline/continuation-outlines-with-layers-2.html = IMAGE+TEXT
@@ -2815,9 +2795,6 @@
 BUGCR75561 LINUX WIN : fast/writing-mode/text-orientation-basic.html = IMAGE+TEXT
 BUGCR75561 LEOPARD : fast/writing-mode/text-orientation-basic.html = IMAGE IMAGE+TEXT
 
-// introduced by brarraclough in WK r80621
-BUGCR75562 : fast/js/array-proto-func-length-getter-except.html = TEXT
-
 BUGWK56060 LINUX : fast/images/favicon-as-image.html = IMAGE+TEXT
 
 BUGCR75632 LINUX : svg/W3C-SVG-1.1/text-text-03-b.svg = PASS CRASH
@@ -3057,9 +3034,6 @@
 
 BUGCR80301 LEOPARD : fast/canvas/canvas-largedraws.html = TIMEOUT
 
-// roll up from r84685:r84721??
-BUGWK84665 : fast/dom/dataset-gc.html = TEXT
-
 BUGWK60115 LINUX WIN : fast/multicol/shadow-breaking.html = IMAGE
 BUGWK60115 LEOPARD : fast/text/shadow-translucent-fill.html = IMAGE
 BUGWK60115 MAC CPU-CG : fast/transforms/shadows.html = PASS IMAGE
@@ -3366,8 +3340,6 @@
 // V8 now follows spec on toisostring, test needs to be fixed.
 BUGCR88936 : fast/js/date-toisostring.html = TEXT
 
-BUGCR89242 : fast/js/eval-keyword-vs-function.html = TEXT
-
 BUGCR89331 WIN7 : plugins/mouse-click-plugin-clears-selection.html = PASS MISSING
 
 BUGWK70630 SNOWLEOPARD : fast/js/call-base-resolution.html = PASS TEXT CRASH
@@ -3633,8 +3605,6 @@
 BUGWK68270 MAC DEBUG : fast/css/only-child-pseudo-class.html = IMAGE IMAGE+TEXT TEXT
 BUGWK68270 MAC DEBUG : fast/css/only-of-type-pseudo-class.html = IMAGE IMAGE+TEXT TEXT
 
-BUGWK68445 : fast/js/string-split-conformance.html = FAIL
-
 // Tests that have become flaky (causing regressions, but only sometimes)
 BUG_EPOGER SNOWLEOPARD CPU-CG CPU DEBUG : fast/js/try-catch-crash.html = PASS TIMEOUT
 
@@ -3787,10 +3757,6 @@
 
 BUGWK71074 MAC : fast/table/border-collapsing/border-collapsing-head-foot.html = IMAGE+TEXT
 
-BUGWK71127 : fast/js/kde/RegExp.html = TEXT
-BUGWK71127 : fast/js/exception-sequencing-binops2.html = TEXT
-BUGWK71127 : fast/js/array-prototype-properties.html = TEXT
-
 BUGWK71181 : fast/forms/input-step-as-double.html = PASS TEXT
 BUGWK71209 LINUX MAC : compositing/visibility/visibility-image-layers.html = IMAGE
 
@@ -3856,7 +3822,6 @@
 BUGRICOW : fast/js/eval-cross-window.html = TEXT
 BUGRICOW : fast/js/regexp-caching.html = TEXT
 BUGRICOW : fast/js/toString-overrides.html = TEXT
-BUGRICOW : fast/js/toString-recursion.html = TEXT
 BUGRICOW : http/tests/security/xss-eval.html = TEXT
 
 BUGWK72052 MAC DEBUG CPU-CG GPU-CG : fa

[webkit-changes] [100402] trunk/LayoutTests

[annacc]

Title: [100402] trunk/LayoutTests








Revision 100402
Author ann...@chromium.org
Date 2011-11-15 21:33:23 -0800 (Tue, 15 Nov 2011)


Log Message
Make sure both the video and the track are ready to be tested before testing.
https://bugs.webkit.org/show_bug.cgi?id=72269

Reviewed by Eric Carlson.

* media/track/track-cues-cuechange.html:
* media/track/track-cues-enter-exit.html:
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/track-cues-cuechange.html
trunk/LayoutTests/media/track/track-cues-enter-exit.html
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100401 => 100402)

--- trunk/LayoutTests/ChangeLog	2011-11-16 05:12:33 UTC (rev 100401)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 05:33:23 UTC (rev 100402)
@@ -1,3 +1,14 @@
+2011-11-15  Anna Cavender  
+
+Make sure both the video and the track are ready to be tested before testing.
+https://bugs.webkit.org/show_bug.cgi?id=72269
+
+Reviewed by Eric Carlson.
+
+* media/track/track-cues-cuechange.html:
+* media/track/track-cues-enter-exit.html:
+* platform/chromium/test_expectations.txt:
+
 2011-11-15  Tony Chang  
 
 [chromium] fix overlapping expectations


Modified: trunk/LayoutTests/media/track/track-cues-cuechange.html (100401 => 100402)

--- trunk/LayoutTests/media/track/track-cues-cuechange.html	2011-11-16 05:12:33 UTC (rev 100401)
+++ trunk/LayoutTests/media/track/track-cues-cuechange.html	2011-11-16 05:33:23 UTC (rev 100402)
@@ -9,7 +9,7 @@
 
 Tests that TextTrack's cues are indexed and updated in order during video playback. Test uses the cuechange event.
 
-
+
 
 

[webkit-changes] [100401] trunk/Source/WebCore

[commit-queue]

Title: [100401] trunk/Source/WebCore








Revision 100401
Author commit-qu...@webkit.org
Date 2011-11-15 21:12:33 -0800 (Tue, 15 Nov 2011)


Log Message
[chromium] During tear down, prevent the WebGLLayerChromium instance from attempting to stop a timer for a NULL context.
https://bugs.webkit.org/show_bug.cgi?id=72423

Patch by Jeff Timanus  on 2011-11-15
Reviewed by Kenneth Russell.

* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setDrawingBuffer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (100400 => 100401)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 05:10:42 UTC (rev 100400)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 05:12:33 UTC (rev 100401)
@@ -1,3 +1,13 @@
+2011-11-15  Jeff Timanus  
+
+[chromium] During tear down, prevent the WebGLLayerChromium instance from attempting to stop a timer for a NULL context.
+https://bugs.webkit.org/show_bug.cgi?id=72423
+
+Reviewed by Kenneth Russell.
+
+* platform/graphics/chromium/WebGLLayerChromium.cpp:
+(WebCore::WebGLLayerChromium::setDrawingBuffer):
+
 2011-11-15  Mark Hahnenberg  
 
 Rebaseline generated WebCore bindings


Modified: trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp (100400 => 100401)

--- trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp	2011-11-16 05:10:42 UTC (rev 100400)
+++ trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp	2011-11-16 05:12:33 UTC (rev 100401)
@@ -51,6 +51,7 @@
 : CanvasLayerChromium(delegate)
 , m_textureChanged(true)
 , m_textureUpdated(false)
+, m_drawingBuffer(0)
 {
 }
 
@@ -125,11 +126,16 @@
 void WebGLLayerChromium::setDrawingBuffer(DrawingBuffer* drawingBuffer)
 {
 bool drawingBufferChanged = (m_drawingBuffer != drawingBuffer);
-m_drawingBuffer = drawingBuffer;
 
-if (layerTreeHost() && drawingBufferChanged)
-layerTreeHost()->stopRateLimiter(context());
+// The GraphicsContext3D used by the layer is the context associated with
+// the drawing buffer. If the drawing buffer is changing, make sure
+// to stop the rate limiter on the old context, not the new context from the
+// new drawing buffer.
+GraphicsContext3D* context3D = context();
+if (layerTreeHost() && drawingBufferChanged && context3D)
+layerTreeHost()->stopRateLimiter(context3D);
 
+m_drawingBuffer = drawingBuffer;
 if (!m_drawingBuffer)
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100400] trunk/Source/WebCore

[mhahnenberg]

Title: [100400] trunk/Source/WebCore








Revision 100400
Author mhahnenb...@apple.com
Date 2011-11-15 21:10:42 -0800 (Tue, 15 Nov 2011)


Log Message
Rebaseline generated WebCore bindings

Unreviewed build fix

No new tests.

* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::isObservable):
(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventConstructorOwner::finalize):
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceOwner::finalize):
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterface::clearImpl):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::isObservable):
(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorOwner::finalize):
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::clearImpl):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::isObservable):
(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestObjOwner::finalize):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::isObservable):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (100399 => 100400)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 04:47:12 UTC (rev 100399)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 05:10:42 UTC (rev 100400)
@@ -1,3 +1,52 @@
+2011-11-15  Mark Hahnenberg  
+
+Rebaseline generated WebCore bindings
+
+Unreviewed build fix
+
+No new tests.
+
+* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+(WebCore::isObservable):
+(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
+(WebCore::JSTestEventConstructorOwner::finalize):
+* bindings/scripts/test/JS/JSTestEventConstructor.h:
+(WebCore::JSTestEventConstructor::clearImpl):
+(WebCore::wrapperOwner):
+(WebCore::wrapperContext):
+* bindings/scripts/test/JS/JSTestInterface.cpp:
+(WebCore::JSTestInterfaceOwner::finalize):
+* bindings/scripts/test/JS/JSTestInterface.h:
+(WebCore::JSTestInterface::clearImpl):
+* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
+(WebCore::isObservable):
+(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
+(WebCore::JSTestMediaQueryListListenerOwner::finalize):
+* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
+(WebCore::JSTestMediaQueryListListener::clearImpl):
+(WebCore::wrapperOwner):
+(WebCore::wrapperContext):
+* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
+(WebCore::JSTestNamedConstructorOwner::finalize):
+* bindings/scripts/test/JS/JSTestNamedConstructor.h:
+(WebCore::JSTestNamedConstructor::clearImpl):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::isObservable):
+(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
+(WebCore::JSTestObjOwner::finalize):
+* bindings/scripts/test/JS/JSTestObj.h:
+(WebCore::JSTestObj::clearImpl):
+(WebCore::wrapperOwner):
+(WebCore::wrapperConte

[webkit-changes] [100399] trunk/Source/WebCore

[commit-queue]

Title: [100399] trunk/Source/WebCore








Revision 100399
Author commit-qu...@webkit.org
Date 2011-11-15 20:47:12 -0800 (Tue, 15 Nov 2011)


Log Message
Patch removing duplicated code in the setup of the DrawingBuffer used
to host the back-buffer for WebGL contents.
https://bugs.webkit.org/show_bug.cgi?id=72327

Patch by Jeff Timanus  on 2011-11-15
Reviewed by Kenneth Russell.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (100398 => 100399)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 04:29:17 UTC (rev 100398)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 04:47:12 UTC (rev 100399)
@@ -1,3 +1,16 @@
+2011-11-15  Jeff Timanus  
+
+Patch removing duplicated code in the setup of the DrawingBuffer used
+to host the back-buffer for WebGL contents.
+https://bugs.webkit.org/show_bug.cgi?id=72327
+
+Reviewed by Kenneth Russell.
+
+* html/canvas/WebGLRenderingContext.cpp:
+(WebCore::WebGLRenderingContext::copyTexImage2D):
+(WebCore::WebGLRenderingContext::copyTexSubImage2D):
+(WebCore::WebGLRenderingContext::readPixels):
+
 2011-11-15  Mark Hahnenberg  
 
 JS DOM wrappers depend on destructor to deref impl RefPtrs


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (100398 => 100399)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp	2011-11-16 04:29:17 UTC (rev 100398)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp	2011-11-16 04:47:12 UTC (rev 100399)
@@ -82,6 +82,29 @@
 
 namespace {
 
+class ScopedDrawingBufferBinder {
+public:
+ScopedDrawingBufferBinder(DrawingBuffer* drawingBuffer, WebGLFramebuffer* framebufferBinding)
+: m_drawingBuffer(drawingBuffer)
+, m_framebufferBinding(framebufferBinding)
+{
+// Commit DrawingBuffer if needed (e.g., for multisampling)
+if (!m_framebufferBinding && m_drawingBuffer)
+m_drawingBuffer->commit();
+}
+
+~ScopedDrawingBufferBinder()
+{
+// Restore DrawingBuffer if needed
+if (!m_framebufferBinding && m_drawingBuffer)
+m_drawingBuffer->bind();
+}
+
+private:
+DrawingBuffer* m_drawingBuffer;
+WebGLFramebuffer* m_framebufferBinding;
+};
+
 Platform3DObject objectOrZero(WebGLObject* object)
 {
 return object ? object->object() : 0;
@@ -1164,20 +1187,10 @@
 }
 clearIfComposited();
 if (isResourceSafe()) {
-// Commit DrawingBuffer if needed (e.g., for multisampling)
-if (!m_framebufferBinding && m_drawingBuffer)
-m_drawingBuffer->commit();
-
+ScopedDrawingBufferBinder binder(m_drawingBuffer.get(), m_framebufferBinding.get());
 m_context->copyTexImage2D(target, level, internalformat, x, y, width, height, border);
-
-// Restore DrawingBuffer if needed
-if (!m_framebufferBinding && m_drawingBuffer)
-m_drawingBuffer->bind();
 } else {
-// Commit DrawingBuffer if needed (e.g., for multisampling)
-if (!m_framebufferBinding && m_drawingBuffer)
-m_drawingBuffer->commit();
-
+ScopedDrawingBufferBinder binder(m_drawingBuffer.get(), m_framebufferBinding.get());
 GC3Dint clippedX, clippedY;
 GC3Dsizei clippedWidth, clippedHeight;
 if (clip2D(x, y, width, height, getBoundFramebufferWidth(), getBoundFramebufferHeight(), &clippedX, &clippedY, &clippedWidth, &clippedHeight)) {
@@ -1189,10 +1202,6 @@
 }
 } else
 m_context->copyTexImage2D(target, level, internalformat, x, y, width, height, border);
-
-// Restore DrawingBuffer if needed
-if (!m_framebufferBinding && m_drawingBuffer)
-m_drawingBuffer->bind();
 }
 // FIXME: if the framebuffer is not complete, none of the below should be executed.
 tex->setLevelInfo(target, level, internalformat, width, height, GraphicsContext3D::UNSIGNED_BYTE);
@@ -1223,17 +1232,10 @@
 return;
 }
 clearIfComposited();
-if (isResourceSafe())
-// Commit DrawingBuffer if needed (e.g., for multisampling)
-if (!m_framebufferBinding && m_drawingBuffer)
-m_drawingBuffer->commit();
-
+if (isResourceSafe()) {
+ScopedDrawingBufferBinder binder(m_drawingBuffer.get(), m_framebufferBinding.get());
 m_context->copyTexSubImage2D(target, level, xoffset, yoffset, x, y, width, height);
-
-// Restore DrawingBuffer if needed
-if (!m_framebufferBinding && m_drawingBuffer)
-m_drawingBuffer->bind();
-else {
+} else {
 GC3Dint clippedX, clippedY;
   

[webkit-changes] [100398] trunk/Source/WebCore

[mhahnenberg]

Title: [100398] trunk/Source/WebCore








Revision 100398
Author mhahnenb...@apple.com
Date 2011-11-15 20:29:17 -0800 (Tue, 15 Nov 2011)


Log Message
JS DOM wrappers depend on destructor to deref impl RefPtrs
https://bugs.webkit.org/show_bug.cgi?id=72341

Reviewed by Sam Weinig.

No new tests.

Added clearing of impl RefPtrs to JS DOM wrapper nodes and removed the default
wrapperOwner function in favor of generating all WeakHandleOwners and wrapperOwner functions.

* bindings/js/JSCSSValueCustom.cpp:
(WebCore::JSCSSValueOwner::finalize):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::finalize):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (100397 => 100398)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 04:28:41 UTC (rev 100397)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 04:29:17 UTC (rev 100398)
@@ -1,3 +1,24 @@
+2011-11-15  Mark Hahnenberg  
+
+JS DOM wrappers depend on destructor to deref impl RefPtrs
+https://bugs.webkit.org/show_bug.cgi?id=72341
+
+Reviewed by Sam Weinig.
+
+No new tests.
+
+Added clearing of impl RefPtrs to JS DOM wrapper nodes and removed the default 
+wrapperOwner function in favor of generating all WeakHandleOwners and wrapperOwner functions.
+
+* bindings/js/JSCSSValueCustom.cpp:
+(WebCore::JSCSSValueOwner::finalize):
+* bindings/js/JSDOMBinding.h:
+* bindings/js/JSNodeCustom.cpp:
+(WebCore::JSNodeOwner::finalize):
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+(GenerateImplementation):
+
 2011-11-15  Joseph Pecoraro  
 
 Web Inspector: Share Highlight Code for Drawing Outlined Quad


Modified: trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp (100397 => 100398)

--- trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp	2011-11-16 04:28:41 UTC (rev 100397)
+++ trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp	2011-11-16 04:29:17 UTC (rev 100398)
@@ -68,6 +68,7 @@
 DOMWrapperWorld* world = static_cast(context);
 world->m_cssValueRoots.remove(jsCSSValue->impl());
 uncacheWrapper(world, jsCSSValue->impl(), jsCSSValue);
+jsCSSValue->clearImpl();
 }
 
 JSValue toJS(ExecState* exec, JSDOMGlobalObject* globalObject, CSSValue* value)


Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (100397 => 100398)

--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h	2011-11-16 04:28:41 UTC (rev 100397)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h	2011-11-16 04:29:17 UTC (rev 100398)
@@ -125,10 +125,6 @@
 inline bool setInlineCachedWrapper(DOMWrapperWorld*, void*, JSDOMWrapper*) { return false; }
 inline bool clearInlineCachedWrapper(DOMWrapperWorld*, void*, JSDOMWrapper*) { return false; }
 
-// Overload these functions to provide a custom WeakHandleOwner.
-inline JSC::WeakHandleOwner* wrapperOwner(DOMWrapperWorld* world, void*) { return world->defaultWrapperOwner(); }
-inline void* wrapperContext(DOMWrapperWorld*, void* domObject) { return domObject; }
-
 template  inline JSDOMWrapper* getCachedWrapper(DOMWrapperWorld* world, DOMClass* domObject)
 {
 if (JSDOMWrapper* wrapper = getInlineCachedWrapper(world, domObject))


Modified: trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp (100397 => 100398)

--- trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp	2011-11-16 04:28:41 UTC (rev 100397)
+++ trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp	2011-11-16 04:29:17 UTC (rev 100398)
@@ -141,6 +141,7 @@
 JSNode* jsNode = static_cast(handle.get().asCell());
 DOMWrapperWorld* world = static_cast(context);
 uncacheWrapper(world, jsNode->impl(), jsNode);
+jsNode->clearImpl();
 }
 
 JSValue JSNode::insertBefore(ExecState* exec)


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (100397 => 100398)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-11-16 04:28:41 UTC (rev 100397)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-11-16 04:29:17 UTC (rev 100398)
@@ -924,7 +924,8 @@
 }
 
 if (!$hasParent) {
-push(@headerContent, "$implType* impl() const { return m_impl.get(); }\n\n");
+push(@headerContent, "$implType* impl() const { return m_impl.get(); }\n");
+push(@headerContent, "void clearImpl() { m_impl.clear(); }\n\n");
 push(@headerContent, "private:\n");
 push(@headerContent, "RefPtr<$implType> m_impl;\n");
 } elsif ($dataNode->extendedAttributes->{"GenerateNativeConverter"}) {
@@ -989,19 +990,20 @@
 push(@headerContent, "}\n\n");
 }
 
-if ($dataNode->extendedAttributes-

[webkit-changes] [100397] trunk/Tools

[tony]

Title: [100397] trunk/Tools








Revision 100397
Author t...@chromium.org
Date 2011-11-15 20:28:41 -0800 (Tue, 15 Nov 2011)


Log Message
Skip a failing webkitpy test on cygwin.

* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (100396 => 100397)

--- trunk/Tools/ChangeLog	2011-11-16 04:17:00 UTC (rev 100396)
+++ trunk/Tools/ChangeLog	2011-11-16 04:28:41 UTC (rev 100397)
@@ -1,3 +1,9 @@
+2011-11-15  Tony Chang  
+
+Skip a failing webkitpy test on cygwin.
+
+* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+
 2011-11-15  Sam Weinig  
 
 TestWebKitAPI should not put its resources in the root products directory


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py (100396 => 100397)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py	2011-11-16 04:17:00 UTC (rev 100396)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py	2011-11-16 04:28:41 UTC (rev 100397)
@@ -27,6 +27,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import StringIO
+import sys
 import time
 import unittest
 
@@ -137,7 +138,9 @@
 start_time = time.time()
 driver1.stop()
 driver2.stop()
-self.assertTrue(time.time() - start_time < 20)
+# FIXME: This test is timing out it cygwin. Disable until we get a chance to debug.
+if sys.platform != 'cygwin':
+self.assertTrue(time.time() - start_time < 20)
 
 
 class ChromiumPortTest(port_testcase.PortTestCase):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100396] trunk/LayoutTests

[tony]

Title: [100396] trunk/LayoutTests








Revision 100396
Author t...@chromium.org
Date 2011-11-15 20:17:00 -0800 (Tue, 15 Nov 2011)


Log Message
[chromium] fix overlapping expectations
https://bugs.webkit.org/show_bug.cgi?id=72458

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100395 => 100396)

--- trunk/LayoutTests/ChangeLog	2011-11-16 03:54:12 UTC (rev 100395)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 04:17:00 UTC (rev 100396)
@@ -1,3 +1,10 @@
+2011-11-15  Tony Chang  
+
+[chromium] fix overlapping expectations
+https://bugs.webkit.org/show_bug.cgi?id=72458
+
+* platform/chromium/test_expectations.txt:
+
 2011-11-15  Peter Kasting  
 
 Mark a test as flakily failing.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100395 => 100396)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 03:54:12 UTC (rev 100395)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 04:17:00 UTC (rev 100396)
@@ -255,9 +255,9 @@
 // this test will always fail.
 WONTFIX SKIP LINUX WIN : fast/events/option-tab.html = FAIL
 
-BUGWK72402 CPU CPU-CG : compositing = PASS TIMEOUT FAIL
-BUGWK72402 CPU CPU-CG : platform/chromium/compositing = PASS TIMEOUT FAIL
-BUGWK72402 CPU CPU-CG : animations/3d = PASS TIMEOUT FAIL
+BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : compositing = PASS TIMEOUT FAIL
+BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : platform/chromium/compositing = PASS TIMEOUT FAIL
+BUGWK72402 CPU CPU-CG WIN LINUX SNOWLEOPARD : animations/3d = PASS TIMEOUT FAIL
 
 // We don't ship compositing on Leopard.
 WONTFIX SKIP LEOPARD : compositing = PASS TIMEOUT FAIL
@@ -3491,7 +3491,7 @@
 
 BUGWK66888 DEBUG : svg/animations/svginteger-animation-1.html = PASS TEXT
 
-BUGWK66900 LINUX SNOWLEOPARD DEBUG : fast/writing-mode/japanese-rl-text-with-broken-font.html = PASS IMAGE+TEXT
+BUGWK66900 LINUX DEBUG : fast/writing-mode/japanese-rl-text-with-broken-font.html = PASS IMAGE+TEXT
 
 BUGWK66908 WIN LINUX GPU DEBUG : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = PASS TEXT
 BUGWK66908 LEOPARD GPU : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = PASS TEXT
@@ -3820,7 +3820,7 @@
 BUGENNE : compositing/geometry/horizontal-scroll-composited.html = FAIL
 BUGENNE : compositing/geometry/vertical-scroll-composited.html = FAIL
 BUGENNE : compositing/overflow/fixed-position-ancestor-clip.html = FAIL
-BUG72182 : compositing/scaling/tiled-layer-recursion.html = FAIL CRASH
+BUGWK72182 : compositing/scaling/tiled-layer-recursion.html = FAIL CRASH
 
 // This test sometimes exceeds 60-second time limit (for SLOW tests) on
 // win/linux debug. Since setting both SLOW and TIMEOUT is not allowed,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100395] trunk/Source/WebCore

[commit-queue]

Title: [100395] trunk/Source/WebCore








Revision 100395
Author commit-qu...@webkit.org
Date 2011-11-15 19:54:12 -0800 (Tue, 15 Nov 2011)


Log Message
Web Inspector: Share Highlight Code for Drawing Outlined Quad
https://bugs.webkit.org/show_bug.cgi?id=72451

Patch by Joseph Pecoraro  on 2011-11-15
Reviewed by Timothy Hatcher.

* inspector/DOMNodeHighlighter.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (100394 => 100395)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 03:18:14 UTC (rev 100394)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 03:54:12 UTC (rev 100395)
@@ -1,3 +1,12 @@
+2011-11-15  Joseph Pecoraro  
+
+Web Inspector: Share Highlight Code for Drawing Outlined Quad
+https://bugs.webkit.org/show_bug.cgi?id=72451
+
+Reviewed by Timothy Hatcher.
+
+* inspector/DOMNodeHighlighter.cpp:
+
 2011-11-15  Sheriff Bot  
 
 Unreviewed, rolling out r100308.


Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (100394 => 100395)

--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp	2011-11-16 03:18:14 UTC (rev 100394)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp	2011-11-16 03:54:12 UTC (rev 100395)
@@ -462,26 +462,8 @@
 FloatRect overlayRect = view->visibleContentRect();
 context.translate(-overlayRect.x(), -overlayRect.y());
 
-static const int outlineThickness = 2;
-
-Path quadPath = quadToPath(FloatRect(*(highlightData->rect)));
-
-// Clip out the quad, then draw with a 2px stroke to get a pixel
-// of outline (because inflating a quad is hard)
-{
-context.save();
-context.clipOut(quadPath);
-
-context.setStrokeThickness(outlineThickness);
-context.setStrokeColor(highlightData->contentOutline, ColorSpaceDeviceRGB);
-context.strokePath(quadPath);
-
-context.restore();
-}
-
-// Now do the fill
-context.setFillColor(highlightData->content, ColorSpaceDeviceRGB);
-context.fillPath(quadPath);
+FloatRect highlightRect(*(highlightData->rect));
+drawOutlinedQuad(context, highlightRect, highlightData->content, highlightData->contentOutline);
 }
 
 } // anonymous namespace






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100387] trunk/Source

[pkasting]

Title: [100387] trunk/Source








Revision 100387
Author pkast...@chromium.org
Date 2011-11-15 18:13:12 -0800 (Tue, 15 Nov 2011)


Log Message
Unreviewed, rolling out r100340.
http://trac.webkit.org/changeset/100340
https://bugs.webkit.org/show_bug.cgi?id=72448

Caused assertion failure in Win dbg canary. (Requested by
pkasting on #webkit).

Patch by Sheriff Bot  on 2011-11-15

Source/WebCore: 

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium: 

* tests/CCLayerTreeHostImplTest.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (100386 => 100387)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 02:03:54 UTC (rev 100386)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 02:13:12 UTC (rev 100387)
@@ -1,3 +1,18 @@
+2011-11-15  Sheriff Bot  
+
+Unreviewed, rolling out r100340.
+http://trac.webkit.org/changeset/100340
+https://bugs.webkit.org/show_bug.cgi?id=72448
+
+Caused assertion failure in Win dbg canary. (Requested by
+pkasting on #webkit).
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::LayerRendererChromium):
+(WebCore::LayerRendererChromium::viewportChanged):
+(WebCore::LayerRendererChromium::drawLayersInternal):
+* platform/graphics/chromium/LayerRendererChromium.h:
+
 2011-11-15  Julien Chaffraix  
 
 Switch table indexing to unsigned


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (100386 => 100387)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2011-11-16 02:03:54 UTC (rev 100386)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2011-11-16 02:13:12 UTC (rev 100387)
@@ -174,7 +174,6 @@
 , m_context(context)
 , m_defaultRenderSurface(0)
 , m_sharedGeometryQuad(FloatRect(-0.5f, -0.5f, 1.0f, 1.0f))
-, m_isViewportChanged(false)
 {
 }
 
@@ -276,7 +275,8 @@
 
 void LayerRendererChromium::viewportChanged()
 {
-m_isViewportChanged = true;
+if (m_context)
+m_context->reshape(std::max(1, viewportWidth()), std::max(1, viewportHeight()));
 
 // Reset the current render surface to force an update of the viewport and
 // projection matrix next time useRenderSurface is called.
@@ -352,14 +352,6 @@
 return;
 
 TRACE_EVENT("LayerRendererChromium::drawLayers", this, 0);
-if (m_isViewportChanged) {
-// Only reshape when we know we are going to draw. Otherwise, the reshape
-// can leave the window at the wrong size if we never draw and the proper
-// viewport size is never set.
-m_isViewportChanged = false;
-m_context->reshape(viewportWidth(), viewportHeight());
-}
-
 CCLayerImpl* rootDrawLayer = rootLayer();
 makeContextCurrent();
 


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h (100386 => 100387)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h	2011-11-16 02:03:54 UTC (rev 100386)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h	2011-11-16 02:13:12 UTC (rev 100387)
@@ -231,8 +231,6 @@
 CCLayerSorter m_layerSorter;
 
 FloatQuad m_sharedGeometryQuad;
-
-bool m_isViewportChanged;
 };
 
 // Setting DEBUG_GL_CALLS to 1 will call glGetError() after almost every GL


Modified: trunk/Source/WebKit/chromium/ChangeLog (100386 => 100387)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-11-16 02:03:54 UTC (rev 100386)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-11-16 02:13:12 UTC (rev 100387)
@@ -1,3 +1,14 @@
+2011-11-15  Sheriff Bot  
+
+Unreviewed, rolling out r100340.
+http://trac.webkit.org/changeset/100340
+https://bugs.webkit.org/show_bug.cgi?id=72448
+
+Caused assertion failure in Win dbg canary. (Requested by
+pkasting on #webkit).
+
+* tests/CCLayerTreeHostImplTest.cpp:
+
 2011-11-15  Nat Duca  
 
 [chromium] Fuse MainThread and CCThread


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (100386 => 100387)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp	2011-11-16 02:03:54 UTC (rev 100386)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp	2011-11-16 02:13:12 UTC (rev 100387)
@@ -292,45 +292,5 @@
 EXPECT_TRUE(layer2->drawn());
 }
 
-class ReshapeTrackerContext: public MockWebGraphicsContext3D {
-public:
-ReshapeTrackerConte

[webkit-changes] [100394] trunk/Source/WebCore

[commit-queue]

Title: [100394] trunk/Source/WebCore








Revision 100394
Author commit-qu...@webkit.org
Date 2011-11-15 19:18:14 -0800 (Tue, 15 Nov 2011)


Log Message
Unreviewed, rolling out r100308.
http://trac.webkit.org/changeset/100308
https://bugs.webkit.org/show_bug.cgi?id=72450

Introduces WebGL conformance test regressions. (Requested by
twiz on #webkit).

Patch by Sheriff Bot  on 2011-11-15

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (100393 => 100394)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 03:06:10 UTC (rev 100393)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 03:18:14 UTC (rev 100394)
@@ -1,3 +1,17 @@
+2011-11-15  Sheriff Bot  
+
+Unreviewed, rolling out r100308.
+http://trac.webkit.org/changeset/100308
+https://bugs.webkit.org/show_bug.cgi?id=72450
+
+Introduces WebGL conformance test regressions. (Requested by
+twiz on #webkit).
+
+* html/canvas/WebGLRenderingContext.cpp:
+(WebCore::WebGLRenderingContext::copyTexImage2D):
+(WebCore::WebGLRenderingContext::copyTexSubImage2D):
+(WebCore::WebGLRenderingContext::readPixels):
+
 2011-11-15  James Robinson  
 
 Rollout http://trac.webkit.org/changeset/99813, caused some crashes in


Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (100393 => 100394)

--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp	2011-11-16 03:06:10 UTC (rev 100393)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp	2011-11-16 03:18:14 UTC (rev 100394)
@@ -82,29 +82,6 @@
 
 namespace {
 
-class ScopedDrawingBufferBinder {
-public:
-ScopedDrawingBufferBinder(DrawingBuffer* drawingBuffer, WebGLFramebuffer* framebufferBinding)
-: m_drawingBuffer(drawingBuffer)
-, m_framebufferBinding(framebufferBinding)
-{
-// Commit DrawingBuffer if needed (e.g., for multisampling)
-if (!m_framebufferBinding && m_drawingBuffer)
-m_drawingBuffer->commit();
-}
-
-~ScopedDrawingBufferBinder()
-{
-// Restore DrawingBuffer if needed
-if (!m_framebufferBinding && m_drawingBuffer)
-m_drawingBuffer->bind();
-}
-
-private:
-DrawingBuffer* m_drawingBuffer;
-WebGLFramebuffer* m_framebufferBinding;
-};
-
 Platform3DObject objectOrZero(WebGLObject* object)
 {
 return object ? object->object() : 0;
@@ -1187,10 +1164,20 @@
 }
 clearIfComposited();
 if (isResourceSafe()) {
-ScopedDrawingBufferBinder(m_drawingBuffer.get(), m_framebufferBinding.get());
+// Commit DrawingBuffer if needed (e.g., for multisampling)
+if (!m_framebufferBinding && m_drawingBuffer)
+m_drawingBuffer->commit();
+
 m_context->copyTexImage2D(target, level, internalformat, x, y, width, height, border);
+
+// Restore DrawingBuffer if needed
+if (!m_framebufferBinding && m_drawingBuffer)
+m_drawingBuffer->bind();
 } else {
-ScopedDrawingBufferBinder(m_drawingBuffer.get(), m_framebufferBinding.get());
+// Commit DrawingBuffer if needed (e.g., for multisampling)
+if (!m_framebufferBinding && m_drawingBuffer)
+m_drawingBuffer->commit();
+
 GC3Dint clippedX, clippedY;
 GC3Dsizei clippedWidth, clippedHeight;
 if (clip2D(x, y, width, height, getBoundFramebufferWidth(), getBoundFramebufferHeight(), &clippedX, &clippedY, &clippedWidth, &clippedHeight)) {
@@ -1202,6 +1189,10 @@
 }
 } else
 m_context->copyTexImage2D(target, level, internalformat, x, y, width, height, border);
+
+// Restore DrawingBuffer if needed
+if (!m_framebufferBinding && m_drawingBuffer)
+m_drawingBuffer->bind();
 }
 // FIXME: if the framebuffer is not complete, none of the below should be executed.
 tex->setLevelInfo(target, level, internalformat, width, height, GraphicsContext3D::UNSIGNED_BYTE);
@@ -1232,10 +1223,17 @@
 return;
 }
 clearIfComposited();
-if (isResourceSafe()) {
-ScopedDrawingBufferBinder(m_drawingBuffer.get(), m_framebufferBinding.get());
+if (isResourceSafe())
+// Commit DrawingBuffer if needed (e.g., for multisampling)
+if (!m_framebufferBinding && m_drawingBuffer)
+m_drawingBuffer->commit();
+
 m_context->copyTexSubImage2D(target, level, xoffset, yoffset, x, y, width, height);
-} else {
+
+// Restore DrawingBuffer if needed
+if (!m_framebufferBinding && m_drawingBuffer)
+m_drawingBuffer->bind();
+else {
 GC3Dint clippedX, c

[webkit-changes] [100393] trunk/LayoutTests

[pkasting]

Title: [100393] trunk/LayoutTests








Revision 100393
Author pkast...@chromium.org
Date 2011-11-15 19:06:10 -0800 (Tue, 15 Nov 2011)


Log Message
Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=66908

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100392 => 100393)

--- trunk/LayoutTests/ChangeLog	2011-11-16 03:01:06 UTC (rev 100392)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 03:06:10 UTC (rev 100393)
@@ -1,3 +1,12 @@
+2011-11-15  Peter Kasting  
+
+Mark a test as flakily failing.
+https://bugs.webkit.org/show_bug.cgi?id=66908
+
+Unreviewed, gardening.
+
+* platform/chromium/test_expectations.txt:
+
 2011-11-15  James Robinson  
 
 [chromium] Fix overlapping expectations on chromium mac


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100392 => 100393)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 03:01:06 UTC (rev 100392)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 03:06:10 UTC (rev 100393)
@@ -3494,6 +3494,7 @@
 BUGWK66900 LINUX SNOWLEOPARD DEBUG : fast/writing-mode/japanese-rl-text-with-broken-font.html = PASS IMAGE+TEXT
 
 BUGWK66908 WIN LINUX GPU DEBUG : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = PASS TEXT
+BUGWK66908 LEOPARD GPU : canvas/philip/tests/2d.text.draw.fontface.notinpage.html = PASS TEXT
 BUGWK66908 : fast/css/font-face-woff.html = PASS IMAGE+TEXT
 BUGWK66908 : svg/custom/svg-fonts-fallback.xhtml = PASS IMAGE+TEXT IMAGE
 BUGWK66908 WIN SNOWLEOPARD : fast/css/font-face-multiple-faces.html = PASS IMAGE+TEXT
@@ -3819,7 +3820,7 @@
 BUGENNE : compositing/geometry/horizontal-scroll-composited.html = FAIL
 BUGENNE : compositing/geometry/vertical-scroll-composited.html = FAIL
 BUGENNE : compositing/overflow/fixed-position-ancestor-clip.html = FAIL
-BUGENNE : compositing/scaling/tiled-layer-recursion.html = FAIL CRASH
+BUG72182 : compositing/scaling/tiled-layer-recursion.html = FAIL CRASH
 
 // This test sometimes exceeds 60-second time limit (for SLOW tests) on
 // win/linux debug. Since setting both SLOW and TIMEOUT is not allowed,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100391] trunk/Source/JavaScriptCore

[darin]

Title: [100391] trunk/Source/_javascript_Core








Revision 100391
Author da...@apple.com
Date 2011-11-15 18:53:09 -0800 (Tue, 15 Nov 2011)


Log Message
REGRESSION (r98887): ParserArena and Keywords leaking
https://bugs.webkit.org/show_bug.cgi?id=72428

Reviewed by Sam Weinig.

* parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr
need to be able to destroy it.

* parser/Parser.cpp:
(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.

* runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Lexer.h
trunk/Source/_javascript_Core/parser/Parser.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (100390 => 100391)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-16 02:51:42 UTC (rev 100390)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-16 02:53:09 UTC (rev 100391)
@@ -1,3 +1,21 @@
+2011-11-15  Darin Adler  
+
+REGRESSION (r98887): ParserArena and Keywords leaking
+https://bugs.webkit.org/show_bug.cgi?id=72428
+
+Reviewed by Sam Weinig.
+
+* parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr
+need to be able to destroy it.
+
+* parser/Parser.cpp:
+(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.
+
+* runtime/JSGlobalData.cpp:
+(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.
+
+* runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.
+
 2011-11-15  Geoffrey Garen  
 
 Removed another use of ArgList that baked in the assumption that arguments


Modified: trunk/Source/_javascript_Core/parser/Lexer.h (100390 => 100391)

--- trunk/Source/_javascript_Core/parser/Lexer.h	2011-11-16 02:51:42 UTC (rev 100390)
+++ trunk/Source/_javascript_Core/parser/Lexer.h	2011-11-16 02:53:09 UTC (rev 100391)
@@ -47,16 +47,16 @@
 return m_keywordTable.entry(m_globalData, ident);
 }
 
+~Keywords()
+{
+m_keywordTable.deleteTable();
+}
+
 private:
 friend class JSGlobalData;
 
 Keywords(JSGlobalData*);
 
-~Keywords()
-{
-m_keywordTable.deleteTable();
-}
-
 JSGlobalData* m_globalData;
 const HashTable m_keywordTable;
 };


Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (100390 => 100391)

--- trunk/Source/_javascript_Core/parser/Parser.cpp	2011-11-16 02:51:42 UTC (rev 100390)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp	2011-11-16 02:53:09 UTC (rev 100391)
@@ -59,7 +59,7 @@
 , m_sourceElements(0)
 {
 m_lexer = adoptPtr(new LexerType(globalData));
-m_arena = m_globalData->parserArena;
+m_arena = m_globalData->parserArena.get();
 m_lexer->setCode(source, m_arena);
 
 m_functionCache = source.provider()->cache();


Modified: trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp (100390 => 100391)

--- trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp	2011-11-16 02:51:42 UTC (rev 100390)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp	2011-11-16 02:53:09 UTC (rev 100391)
@@ -50,15 +50,17 @@
 #include "Lookup.h"
 #include "Nodes.h"
 #include "ParserArena.h"
-#if ENABLE(REGEXP_TRACING)
-#include "RegExp.h"
-#endif
 #include "RegExpCache.h"
 #include "RegExpObject.h"
 #include "StrictEvalActivation.h"
 #include "StrongInlines.h"
 #include 
 #include 
+
+#if ENABLE(REGEXP_TRACING)
+#include "RegExp.h"
+#endif
+
 #if PLATFORM(MAC)
 #include 
 #endif
@@ -182,8 +184,8 @@
 #if ENABLE(ASSEMBLER)
 , executableAllocator(*this)
 #endif
-, parserArena(new ParserArena)
-, keywords(new Keywords(this))
+, parserArena(adoptPtr(new ParserArena))
+, keywords(adoptPtr(new Keywords(this)))
 , interpreter(0)
 , heap(this, heapSize)
 #if ENABLE(DFG_JIT)


Modified: trunk/Source/_javascript_Core/runtime/JSGlobalData.h (100390 => 100391)

--- trunk/Source/_javascript_Core/runtime/JSGlobalData.h	2011-11-16 02:51:42 UTC (rev 100390)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalData.h	2011-11-16 02:53:09 UTC (rev 100391)
@@ -219,8 +219,8 @@
 : wtfThreadData().stack();
 }
 
-ParserArena* parserArena;
-Keywords* keywords;
+OwnPtr parserArena;
+OwnPtr keywords;
 Interpreter* interpreter;
 #if ENABLE(JIT)
 OwnPtr jitStubs;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100390] trunk/LayoutTests

[jamesr]

Title: [100390] trunk/LayoutTests








Revision 100390
Author jam...@google.com
Date 2011-11-15 18:51:42 -0800 (Tue, 15 Nov 2011)


Log Message
[chromium] Fix overlapping expectations on chromium mac

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100389 => 100390)

--- trunk/LayoutTests/ChangeLog	2011-11-16 02:49:07 UTC (rev 100389)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 02:51:42 UTC (rev 100390)
@@ -1,3 +1,9 @@
+2011-11-15  James Robinson  
+
+[chromium] Fix overlapping expectations on chromium mac
+
+* platform/chromium/test_expectations.txt:
+
 2011-11-15  Julien Chaffraix  
 
 Add the needed plumbing to parse display: -webkit-inline-grid


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100389 => 100390)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 02:49:07 UTC (rev 100389)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 02:51:42 UTC (rev 100390)
@@ -1359,7 +1359,6 @@
 BUGCR23473 MAC : fast/repaint/4776765.html = IMAGE
 BUGCR23473 MAC : fast/repaint/background-generated.html = IMAGE
 BUGCR23473 MAC : fast/repaint/backgroundSizeRepaint.html = IMAGE
-BUGCR23473 MAC : fast/repaint/block-selection-gap-in-composited-layer.html = IMAGE
 BUGCR23473 MAC : fast/repaint/block-selection-gap-in-table-cell.html = IMAGE
 BUGCR23473 MAC : fast/repaint/body-background-image.html = IMAGE
 BUGCR23473 MAC : fast/repaint/border-fit-lines.html = IMAGE
@@ -2740,9 +2739,6 @@
 BUGWK54322 SNOWLEOPARD : fast/css/transform-default-parameter.html = IMAGE
 BUGWK54322 SNOWLEOPARD : fast/dom/blur-contenteditable.html = IMAGE
 BUGWK54322 SNOWLEOPARD : fast/images/favicon-as-image.html = IMAGE+TEXT
-BUGWK54322 SNOWLEOPARD : fast/media/mq-transform-02.html = IMAGE+TEXT
-BUGWK54322 SNOWLEOPARD : fast/media/mq-transform-03.html = IMAGE+TEXT
-BUGWK54322 SNOWLEOPARD : fast/replaced/width100percent-textarea.html = IMAGE
 BUGWK54322 SNOWLEOPARD : fast/text/international/pop-up-button-text-alignment-and-direction.html = IMAGE
 BUGWK54322 SNOWLEOPARD : fast/text/international/text-combine-image-test.html = IMAGE
 BUGWK54322 SNOWLEOPARD : fonts/monospace.html = IMAGE
@@ -3878,7 +3874,7 @@
 
 // Will need baselines updated to take compositing into account when that is enabled by default.
 // See bug for details
-BUGWK72402 : fast/media/mq-transform-03.html = PASS FAIL
+BUGWK72402 WIN LINUX : fast/media/mq-transform-03.html = PASS FAIL
 BUGWK72402 : transitions/default-timing-function.html = PASS FAIL
 BUGWK72402 : animations/missing-values-first-keyframe.html = PASS FAIL
 BUGWK72402 : fast/repaint/block-selection-gap-in-composited-layer.html = PASS FAIL
@@ -3939,4 +3935,4 @@
 
 BUGWK72269 : media/track/track-cues-cuechange.html = TEXT PASS
 
-BUGWK72447 : inspector/extensions/extensions-events.html = TEXT PASS
\ No newline at end of file
+BUGWK72447 : inspector/extensions/extensions-events.html = TEXT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100389] trunk

[jchaffraix]

Title: [100389] trunk








Revision 100389
Author jchaffr...@webkit.org
Date 2011-11-15 18:49:07 -0800 (Tue, 15 Nov 2011)


Log Message
Add the needed plumbing to parse display: -webkit-inline-grid
https://bugs.webkit.org/show_bug.cgi?id=72438

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added the needed constants and plugged everything together.
Again we treat display: -webkit-inline-grid like display: none
for the moment.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/style/RenderStyleConstants.h:

LayoutTests:

Integrated testing for display: -webkit-inline-grid into the existing test.

* fast/css-grid-layout/display-grid-set-get-expected.txt:
* fast/css-grid-layout/display-grid-set-get.html:
* fast/css-grid-layout/resources/display-grid-set-get.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt
trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get.html
trunk/LayoutTests/fast/css-grid-layout/resources/display-grid-set-get.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h




Diff

Modified: trunk/LayoutTests/ChangeLog (100388 => 100389)

--- trunk/LayoutTests/ChangeLog	2011-11-16 02:38:47 UTC (rev 100388)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 02:49:07 UTC (rev 100389)
@@ -1,3 +1,16 @@
+2011-11-15  Julien Chaffraix  
+
+Add the needed plumbing to parse display: -webkit-inline-grid
+https://bugs.webkit.org/show_bug.cgi?id=72438
+
+Reviewed by Tony Chang.
+
+Integrated testing for display: -webkit-inline-grid into the existing test.
+
+* fast/css-grid-layout/display-grid-set-get-expected.txt:
+* fast/css-grid-layout/display-grid-set-get.html:
+* fast/css-grid-layout/resources/display-grid-set-get.js:
+
 2011-11-15  Peter Kasting  
 
 Maybe the reason we're fiddling with line endings is that this file


Modified: trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt (100388 => 100389)

--- trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt	2011-11-16 02:38:47 UTC (rev 100388)
+++ trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt	2011-11-16 02:49:07 UTC (rev 100389)
@@ -1,14 +1,17 @@
-Test that setting and getting display: grid works as expected
+Test that setting and getting display: grid and inline-grid works as expected
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
 Test getting |display| set through CSS
 PASS getComputedStyle(gridElement, '').getPropertyValue('display') is '-webkit-grid'
+PASS getComputedStyle(inlineGridElement, '').getPropertyValue('display') is '-webkit-inline-grid'
 
 Test getting and setting display through JS
 PASS getComputedStyle(element, '').getPropertyValue('display') is 'block'
 PASS getComputedStyle(element, '').getPropertyValue('display') is '-webkit-grid'
+PASS getComputedStyle(element, '').getPropertyValue('display') is 'block'
+PASS getComputedStyle(element, '').getPropertyValue('display') is '-webkit-inline-grid'
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get.html (100388 => 100389)

--- trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get.html	2011-11-16 02:38:47 UTC (rev 100388)
+++ trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get.html	2011-11-16 02:49:07 UTC (rev 100389)
@@ -3,11 +3,13 @@
 
 
 .grid { display: -webkit-grid; }
+.inlineGrid { display: -webkit-inline-grid; }
 
 

[webkit-changes] [100388] trunk/Source/WebCore

[wjmaclean]

Title: [100388] trunk/Source/WebCore








Revision 100388
Author wjmacl...@chromium.org
Date 2011-11-15 18:38:47 -0800 (Tue, 15 Nov 2011)


Log Message
[chromium] Move setVisibleRect() calls into calculateDrawTransformAndVisibility()
https://bugs.webkit.org/show_bug.cgi?id=72162

Reviewed by Kenneth Russell.

Refactoring of existing functionality, so uses existing tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::walkLayersAndCalculateVisibleLayerRects):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (100387 => 100388)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 02:13:12 UTC (rev 100387)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 02:38:47 UTC (rev 100388)
@@ -1,3 +1,22 @@
+2011-11-15  W. James MacLean  
+
+[chromium] Move setVisibleRect() calls into calculateDrawTransformAndVisibility()
+https://bugs.webkit.org/show_bug.cgi?id=72162
+
+Reviewed by Kenneth Russell.
+
+Refactoring of existing functionality, so uses existing tests.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::drawLayer):
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::paintContentsIfDirty):
+(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
+(WebCore::CCLayerTreeHost::paintLayerContents):
+* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
+(WebCore::walkLayersAndCalculateVisibleLayerRects):
+(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):
+
 2011-11-15  Sheriff Bot  
 
 Unreviewed, rolling out r100340.


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (100387 => 100388)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2011-11-16 02:13:12 UTC (rev 100387)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2011-11-16 02:38:47 UTC (rev 100388)
@@ -578,10 +578,7 @@
 return;
 }
 
-IntRect visibleLayerRect = CCLayerTreeHostCommon::calculateVisibleLayerRect(layer);
-layer->setVisibleLayerRect(visibleLayerRect);
-
-if (visibleLayerRect.isEmpty())
+if (layer->visibleLayerRect().isEmpty())
 return;
 
 if (layer->usesLayerClipping())


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (100387 => 100388)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2011-11-16 02:13:12 UTC (rev 100387)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2011-11-16 02:38:47 UTC (rev 100388)
@@ -334,12 +334,10 @@
 paintLayerContents(m_updateList);
 }
 
-static void paintContentsIfDirty(LayerChromium* layer, const IntRect& visibleLayerRect)
+static void paintContentsIfDirty(LayerChromium* layer)
 {
-if (layer->drawsContent()) {
-layer->setVisibleLayerRect(visibleLayerRect);
+if (layer->drawsContent())
 layer->paintContentsIfDirty();
-}
 }
 
 void CCLayerTreeHost::paintMaskAndReplicaForRenderSurface(LayerChromium* renderSurfaceLayer)
@@ -350,20 +348,20 @@
 
 if (renderSurfaceLayer->maskLayer()) {
 renderSurfaceLayer->maskLayer()->setLayerTreeHost(this);
-paintContentsIfDirty(renderSurfaceLayer->maskLayer(), IntRect(IntPoint(), renderSurfaceLayer->contentBounds()));
+renderSurfaceLayer->maskLayer()->setVisibleLayerRect(IntRect(IntPoint(), renderSurfaceLayer->contentBounds()));
+paintContentsIfDirty(renderSurfaceLayer->maskLayer());
 }
 
 LayerChromium* replicaLayer = renderSurfaceLayer->replicaLayer();
 if (replicaLayer) {
 
-IntRect visibleLayerRect = CCLayerTreeHostCommon::calculateVisibleLayerRect(renderSurfaceLayer);
-
 replicaLayer->setLayerTreeHost(this);
-paintContentsIfDirty(replicaLayer, visibleLayerRect);
+paintContentsIfDirty(replicaLayer);
 
 if (replicaLayer->maskLayer()) {
 replicaLayer->maskLayer()->setLayerTreeHost(this);
-paintContentsIfDirty(replicaLayer->maskLayer(), IntRect(IntPoint(), replicaLayer->maskLayer()->contentBounds()));
+replicaLayer->maskLayer()->setVisibleLayerRect(IntRect(IntPoint(), replicaLayer->maskLayer()->contentBounds()));
+paintContentsIfDirty(replicaLayer->maskLayer()

[webkit-changes] [100385] trunk/Source/JavaScriptCore

[ggaren]

Title: [100385] trunk/Source/_javascript_Core








Revision 100385
Author gga...@apple.com
Date 2011-11-15 17:53:29 -0800 (Tue, 15 Nov 2011)


Log Message
Removed another use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
working through ArgList.

* runtime/ArgList.h: Removed!

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/runtime/ArgList.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (100384 => 100385)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-16 01:52:24 UTC (rev 100384)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-16 01:53:29 UTC (rev 100385)
@@ -1,5 +1,19 @@
 2011-11-15  Geoffrey Garen  
 
+Removed another use of ArgList that baked in the assumption that arguments
+are forward in the regiter file.
+
+Reviewed by Sam Weinig.
+
+* dfg/DFGOperations.cpp:
+* jit/JITStubs.cpp:
+(JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
+working through ArgList.
+
+* runtime/ArgList.h: Removed!
+
+2011-11-15  Geoffrey Garen  
+
 Removed a use of ArgList that baked in the assumption that arguments
 are forward in the regiter file.
 


Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (100384 => 100385)

--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2011-11-16 01:52:24 UTC (rev 100384)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2011-11-16 01:53:29 UTC (rev 100385)
@@ -773,8 +773,7 @@
 
 EncodedJSValue DFG_OPERATION operationNewArray(ExecState* exec, void* start, size_t size)
 {
-ArgList argList(static_cast(start), size);
-return JSValue::encode(constructArray(exec, argList));
+return JSValue::encode(constructArray(exec, static_cast(start), size));
 }
 
 EncodedJSValue DFG_OPERATION operationNewArrayBuffer(ExecState* exec, size_t start, size_t size)


Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (100384 => 100385)

--- trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-11-16 01:52:24 UTC (rev 100384)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-11-16 01:53:29 UTC (rev 100385)
@@ -2432,8 +2432,7 @@
 {
 STUB_INIT_STACK_FRAME(stackFrame);
 
-ArgList argList(&stackFrame.callFrame->registers()[stackFrame.args[0].int32()], stackFrame.args[1].int32());
-return constructArray(stackFrame.callFrame, argList);
+return constructArray(stackFrame.callFrame, reinterpret_cast(&stackFrame.callFrame->registers()[stackFrame.args[0].int32()]), stackFrame.args[1].int32());
 }
 
 DEFINE_STUB_FUNCTION(JSObject*, op_new_array_buffer)


Modified: trunk/Source/_javascript_Core/runtime/ArgList.h (100384 => 100385)

--- trunk/Source/_javascript_Core/runtime/ArgList.h	2011-11-16 01:52:24 UTC (rev 100384)
+++ trunk/Source/_javascript_Core/runtime/ArgList.h	2011-11-16 01:53:29 UTC (rev 100385)
@@ -191,13 +191,6 @@
 {
 }
 
-ArgList(Register* args, int argCount)
-: m_args(reinterpret_cast(args))
-, m_argCount(argCount)
-{
-ASSERT(argCount >= 0);
-}
-
 ArgList(const MarkedArgumentBuffer& args)
 : m_args(reinterpret_cast(const_cast(args.begin(
 , m_argCount(args.size())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100384] trunk/Source

[aestes]

Title: [100384] trunk/Source








Revision 100384
Author aes...@apple.com
Date 2011-11-15 17:52:24 -0800 (Tue, 15 Nov 2011)


Log Message
Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
https://bugs.webkit.org/show_bug.cgi?id=72106

Reviewed by Anders Carlsson.

Source/WebCore:

Add a class that encapsulates the logic of scheduling, enabling and
invalidating a run loop observer that fires before Core Animation's
commit observer. Clients can subclass LayerFlushSchedulerClient and
implement flushLayers(), which will be called by the observer.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ca/LayerFlushScheduler.cpp: Added.
(WebCore::LayerFlushScheduler::suspend): Suspend scheduling by
invalidating the run loop observer. Keep a count of calls to suspend()
in m_suspendCount.
(WebCore::LayerFlushScheduler::resume): Decrement m_suspendCount.
Install the run loop observer when it reaches 0.
* platform/graphics/ca/LayerFlushSchedulerClient.h: Added.
(WebCore::LayerFlushSchedulerClient::~LayerFlushSchedulerClient):
* platform/graphics/ca/LayerFlushScheduler.h: Added.
* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp: Added.
(LayerFlushScheduler::LayerFlushScheduler):
(LayerFlushScheduler::~LayerFlushScheduler):
(LayerFlushScheduler::runLoopObserverCallback): Call flushLayers() on
the LayerFlushSchedulerClient.
(LayerFlushScheduler::schedule): Install the run loop observer.
(LayerFlushScheduler::invalidate): Remove the run loop
observer if it is installed.

Source/WebKit/mac:

Remove code that schedules layer flushes and use LayerFlushScheduler instead.

* WebView/WebView.mm:
(-[WebView _close]): Invalidate the run loop observer and destroy the
LayerFlushController.
(LayerFlushController::flushLayers): Perform the work that
layerSyncRunLoopObserverCallBack used to do.
(-[WebView _scheduleCompositingLayerSync]): If layerFlushController has
yet to be created, create it, then schedule a layer flush.
* WebView/WebViewData.h:
(LayerFlushController::create): Create a LayerFlushController that
implements the LayerFlushSchedulerClient interface and contains a
LayerFlushScheduler with itself as the client.
* WebView/WebViewData.mm:
(LayerFlushController::scheduleLayerFlush):
(LayerFlushController::invalidateObserver):
(LayerFlushController::LayerFlushController):

Source/WebKit2:

Remove code that schedules layer flushes and use LayerFlushScheduler instead.

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h: Replace
m_flushPendingLayerChangesRunLoopObserver with m_layerFlushScheduler
and implement the LayerFlushSchedulerClient interface.
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::LayerTreeHostCAMac): Instantiate
m_layerFlushScheduler with the LayerTreeHost as the client.
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac):
(WebKit::LayerTreeHostCAMac::scheduleLayerFlush): Call LayerFlushScheduler::schedule().
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled): Call
LayerFlushScheduler::suspend() or LayerFlushScheduler::resume().
(WebKit::LayerTreeHostCAMac::invalidate): Call LayerFlushScheduler::invalidate().
(WebKit::LayerTreeHostCAMac::flushLayers): Do the work that
flushPendingLayerChangesRunLoopObserverCallback() used to do.
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush): Call LayerFlushScheduler::invalidate().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/mac/WebView/WebViewData.h
trunk/Source/WebKit/mac/WebView/WebViewData.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h
trunk/Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm


Added Paths

trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp
trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h
trunk/Source/WebCore/platform/graphics/ca/LayerFlushSchedulerClient.h
trunk/Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (100383 => 100384)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 01:51:17 UTC (rev 100383)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 01:52:24 UTC (rev 100384)
@@ -1,3 +1,35 @@
+2011-11-15  Andy Estes  
+
+Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
+https://bugs.webkit.org/show_bug.cgi?id=72106
+
+Reviewed by Anders Carlsson.
+
+Add a class that encapsulates the logic of scheduling, enabling and
+invalidating a run loop observer that fires before Core Animation's
+commit observer. Clients can subclass LayerFlushSchedulerClient and
+implement flushLayers(), which will be called by the observer.
+
+* WebCore.exp.in:
+* WebCore.xcodeproj/

[webkit-changes] [100383] trunk/LayoutTests

[pkasting]

Title: [100383] trunk/LayoutTests








Revision 100383
Author pkast...@chromium.org
Date 2011-11-15 17:51:17 -0800 (Tue, 15 Nov 2011)


Log Message
Maybe the reason we're fiddling with line endings is that this file
didn't set svn:eol-style.  Set it.

Unreviewed, gardening.

* fast/dom/Orientation/create-event-orientationchange-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog


Property Changed

trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100382 => 100383)

--- trunk/LayoutTests/ChangeLog	2011-11-16 01:47:18 UTC (rev 100382)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 01:51:17 UTC (rev 100383)
@@ -1,5 +1,14 @@
 2011-11-15  Peter Kasting  
 
+Maybe the reason we're fiddling with line endings is that this file
+didn't set svn:eol-style.  Set it.
+
+Unreviewed, gardening.
+
+* fast/dom/Orientation/create-event-orientationchange-expected.txt:
+
+2011-11-15  Peter Kasting  
+
 Mark a test as flakily failing.
 https://bugs.webkit.org/show_bug.cgi?id=72447
 


Property changes: trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt



Added: svn:eol-style




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100382] trunk/LayoutTests

[pkasting]

Title: [100382] trunk/LayoutTests








Revision 100382
Author pkast...@chromium.org
Date 2011-11-15 17:47:18 -0800 (Tue, 15 Nov 2011)


Log Message
Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=72447

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100381 => 100382)

--- trunk/LayoutTests/ChangeLog	2011-11-16 01:43:12 UTC (rev 100381)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 01:47:18 UTC (rev 100382)
@@ -1,3 +1,12 @@
+2011-11-15  Peter Kasting  
+
+Mark a test as flakily failing.
+https://bugs.webkit.org/show_bug.cgi?id=72447
+
+Unreviewed, gardening.
+
+* platform/chromium/test_expectations.txt:
+
 2011-11-15  Dmitry Lomov  
 
 Unreviewed; skipping fast/dom/Window/window-postmessage-arrays.html


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100381 => 100382)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 01:43:12 UTC (rev 100381)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 01:47:18 UTC (rev 100382)
@@ -3937,4 +3937,6 @@
 
 BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS
 
-BUGWK72269 : media/track/track-cues-cuechange.html = PASS TEXT
\ No newline at end of file
+BUGWK72269 : media/track/track-cues-cuechange.html = TEXT PASS
+
+BUGWK72447 : inspector/extensions/extensions-events.html = TEXT PASS
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100381] trunk/LayoutTests

[dslomov]

Title: [100381] trunk/LayoutTests








Revision 100381
Author dslo...@google.com
Date 2011-11-15 17:43:12 -0800 (Tue, 15 Nov 2011)


Log Message
Unreviewed; skipping fast/dom/Window/window-postmessage-arrays.html
until https://bugs.webkit.org/show_bug.cgi?id=72435 is fixed.

* platform/mac/Skipped:
* platform/win/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/win/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (100380 => 100381)

--- trunk/LayoutTests/ChangeLog	2011-11-16 01:41:33 UTC (rev 100380)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 01:43:12 UTC (rev 100381)
@@ -1,3 +1,11 @@
+2011-11-15  Dmitry Lomov  
+
+Unreviewed; skipping fast/dom/Window/window-postmessage-arrays.html
+until https://bugs.webkit.org/show_bug.cgi?id=72435 is fixed.
+
+* platform/mac/Skipped:
+* platform/win/Skipped:
+
 2011-11-15  Erik Arvidsson  
 
 Rebaseline after r100289


Modified: trunk/LayoutTests/platform/mac/Skipped (100380 => 100381)

--- trunk/LayoutTests/platform/mac/Skipped	2011-11-16 01:41:33 UTC (rev 100380)
+++ trunk/LayoutTests/platform/mac/Skipped	2011-11-16 01:43:12 UTC (rev 100381)
@@ -480,3 +480,8 @@
 
 # DRT doesn't support overridePreference("WebKit*FontMap"...)
 fast/text/international/locale-sensitive-fonts.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=72435
+fast/dom/Window/window-postmessage-arrays.html
+
+


Modified: trunk/LayoutTests/platform/win/Skipped (100380 => 100381)

--- trunk/LayoutTests/platform/win/Skipped	2011-11-16 01:41:33 UTC (rev 100380)
+++ trunk/LayoutTests/platform/win/Skipped	2011-11-16 01:43:12 UTC (rev 100381)
@@ -1450,3 +1450,8 @@
 
 # DRT doesn't support overridePreference("WebKit*FontMap"...)
 fast/text/international/locale-sensitive-fonts.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=72435
+fast/dom/Window/window-postmessage-arrays.html
+
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100380] trunk/Tools

[weinig]

Title: [100380] trunk/Tools








Revision 100380
Author wei...@apple.com
Date 2011-11-15 17:41:33 -0800 (Tue, 15 Nov 2011)


Log Message
TestWebKitAPI should not put its resources in the root products directory
https://bugs.webkit.org/show_bug.cgi?id=72446

Reviewed by Anders Carlsson.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Change the copy resources phase to place the resources in a TestWebKitAPI.resources
directory.

* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
(TEST_F):
* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
(TestWebKitAPI::DeviceScaleFactorOnBack::url):
* TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
(TestWebKitAPI::DynamicDeviceScaleFactor::url):
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::createURLForResource):
Update calls to retrieve files from the bundle to look in the newly
created subdirectory.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm
trunk/Tools/TestWebKitAPI/Tests/mac/DOMRangeOfString.mm
trunk/Tools/TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm
trunk/Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm
trunk/Tools/TestWebKitAPI/mac/PlatformUtilitiesMac.mm




Diff

Modified: trunk/Tools/ChangeLog (100379 => 100380)

--- trunk/Tools/ChangeLog	2011-11-16 01:36:17 UTC (rev 100379)
+++ trunk/Tools/ChangeLog	2011-11-16 01:41:33 UTC (rev 100380)
@@ -1,3 +1,27 @@
+2011-11-15  Sam Weinig  
+
+TestWebKitAPI should not put its resources in the root products directory
+https://bugs.webkit.org/show_bug.cgi?id=72446
+
+Reviewed by Anders Carlsson.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+Change the copy resources phase to place the resources in a TestWebKitAPI.resources
+directory.
+
+* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
+(TEST_F):
+* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
+(TestWebKitAPI::DeviceScaleFactorOnBack::url):
+* TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
+(TestWebKitAPI::DynamicDeviceScaleFactor::url):
+* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
+(TestWebKitAPI::Util::createURLForResource):
+Update calls to retrieve files from the bundle to look in the newly
+created subdirectory.
+
 2011-11-15  Tony Chang  
 
 Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.


Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (100379 => 100380)

--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2011-11-16 01:36:17 UTC (rev 100379)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2011-11-16 01:41:33 UTC (rev 100380)
@@ -122,7 +122,7 @@
 		BCB9F4FB112384C000A137E0 /* Copy Resources */ = {
 			isa = PBXCopyFilesBuildPhase;
 			buildActionMask = 2147483647;
-			dstPath = "";
+			dstPath = TestWebKitAPI.resources;
 			dstSubfolderSpec = 7;
 			files = (
 33DC8912141955FE00747EF7 /* simple-iframe.html in Copy Resources */,


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm (100379 => 100380)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm	2011-11-16 01:36:17 UTC (rev 100379)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm	2011-11-16 01:41:33 UTC (rev 100380)
@@ -90,7 +90,7 @@
 view.browsingContextController.loadDelegate = loadDelegate;
 
 // Load the file.
-NSURL *nsURL = [[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html"];
+NSURL *nsURL = [[NSBundle mainBundle] URLForResource:@"simple" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"];
 [view.browsingContextController loadFileURL:nsURL restrictToFilesWithin:nil];
 
 // Wait for the load to finish.


Modified: trunk/Tools/TestWebKitAPI/Tests/mac/DOMRangeOfString.mm (100379 => 100380)

--- trunk/Tools/TestWebKitAPI/Tests/mac/DOMRangeOfString.mm	2011-11-16 01:36:17 UTC (rev 100379)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/DOMRangeOfString.mm	2011-11-16 01:41:33 UTC (rev 100380)
@@ -52,7 +52,7 @@
 RetainPtr frameLoadDelegate(AdoptNS, [DOMRangeOfStringFrameLoadDelegate new]);
 
 webView.get().frameLoadDelegate = frameLoadDelegate.get();
-[[webView.get() mainFrame] loadRequest:[NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"DOMRangeOfString" withExtension:@"html"]]];
+[[webView.get() mainFrame] loadRequest:[NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"DOMRangeOfString" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]]];
 
 

[webkit-changes] [100379] trunk/LayoutTests

[arv]

Title: [100379] trunk/LayoutTests








Revision 100379
Author a...@chromium.org
Date 2011-11-15 17:36:17 -0800 (Tue, 15 Nov 2011)


Log Message
Rebaseline after r100289

Unreviewed.

* fast/dom/Orientation/create-event-orientationchange-expected.txt: Fix line endings

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100378 => 100379)

--- trunk/LayoutTests/ChangeLog	2011-11-16 01:35:14 UTC (rev 100378)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 01:36:17 UTC (rev 100379)
@@ -1,3 +1,11 @@
+2011-11-15  Erik Arvidsson  
+
+Rebaseline after r100289
+
+Unreviewed.
+
+* fast/dom/Orientation/create-event-orientationchange-expected.txt: Fix line endings
+
 2011-11-15  Adam Klein  
 
 [v8] Use throwError instead of compiling and running script in handleMaxRecursionDepthExceeded


Modified: trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt (100378 => 100379)

--- trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt	2011-11-16 01:35:14 UTC (rev 100378)
+++ trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt	2011-11-16 01:36:17 UTC (rev 100379)
@@ -1,9 +1,9 @@
-Tests that document.createEvent() works with orientationChange
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-FAIL... orientationChange event doesn't appear to be enabled or implemented.
+Tests that document.createEvent() works with orientationChange
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+FAIL... orientationChange event doesn't appear to be enabled or implemented.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100378] trunk/Source/WebKit2

[weinig]

Title: [100378] trunk/Source/WebKit2








Revision 100378
Author wei...@apple.com
Date 2011-11-15 17:35:14 -0800 (Tue, 15 Nov 2011)


Log Message
Add a connection client to the WKContext, to notify when new connections to the WebProcess are established
https://bugs.webkit.org/show_bug.cgi?id=72433

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKContext.cpp:
(WKContextSetConnectionClient):
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::initializeConnectionClient):
* UIProcess/WebContext.h:
Add connection client API.

* UIProcess/WebContextConnectionClient.cpp: Added.
(WebKit::WebContextConnectionClient::didCreateConnection):
* UIProcess/WebContextConnectionClient.h: Added.
Add basic implementation of the client. It is currently never triggered.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h


Added Paths

trunk/Source/WebKit2/UIProcess/WebContextConnectionClient.cpp
trunk/Source/WebKit2/UIProcess/WebContextConnectionClient.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (100377 => 100378)

--- trunk/Source/WebKit2/ChangeLog	2011-11-16 01:29:22 UTC (rev 100377)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-16 01:35:14 UTC (rev 100378)
@@ -1,3 +1,23 @@
+2011-11-15  Sam Weinig  
+
+Add a connection client to the WKContext, to notify when new connections to the WebProcess are established
+https://bugs.webkit.org/show_bug.cgi?id=72433
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/C/WKContext.cpp:
+(WKContextSetConnectionClient):
+* UIProcess/API/C/WKContext.h:
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::initializeConnectionClient):
+* UIProcess/WebContext.h:
+Add connection client API.
+
+* UIProcess/WebContextConnectionClient.cpp: Added.
+(WebKit::WebContextConnectionClient::didCreateConnection):
+* UIProcess/WebContextConnectionClient.h: Added.
+Add basic implementation of the client. It is currently never triggered.
+
 2011-11-15  Jongseok Yang  
 
 [SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (100377 => 100378)

--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp	2011-11-16 01:29:22 UTC (rev 100377)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp	2011-11-16 01:35:14 UTC (rev 100378)
@@ -86,6 +86,11 @@
 toImpl(contextRef)->initializeDownloadClient(wkClient);
 }
 
+void WKContextSetConnectionClient(WKContextRef contextRef, const WKContextConnectionClient* wkClient)
+{
+toImpl(contextRef)->initializeConnectionClient(wkClient);
+}
+
 WKDownloadRef WKContextDownloadURLRequest(WKContextRef contextRef, const WKURLRequestRef requestRef)
 {
 return toAPI(toImpl(contextRef)->download(0, toImpl(requestRef)->resourceRequest()));


Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (100377 => 100378)

--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h	2011-11-16 01:29:22 UTC (rev 100377)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h	2011-11-16 01:35:14 UTC (rev 100378)
@@ -105,6 +105,18 @@
 
 enum { kWKContextDownloadClientCurrentVersion = 0 };
 
+// Connection Client
+typedef void (*WKContextDidCreateConnection)(WKContextRef context, WKConnectionRef connection, const void* clientInfo);
+
+struct WKContextConnectionClient {
+int version;
+const void *clientInfo;
+WKContextDidCreateConnectiondidCreateConnection;
+};
+typedef struct WKContextConnectionClient WKContextConnectionClient;
+
+enum { kWKContextConnectionClientCurrentVersion = 0 };
+
 WK_EXPORT WKTypeID WKContextGetTypeID();
 
 WK_EXPORT WKContextRef WKContextCreate();
@@ -114,6 +126,7 @@
 WK_EXPORT void WKContextSetInjectedBundleClient(WKContextRef context, const WKContextInjectedBundleClient* client);
 WK_EXPORT void WKContextSetHistoryClient(WKContextRef context, const WKContextHistoryClient* client);
 WK_EXPORT void WKContextSetDownloadClient(WKContextRef context, const WKContextDownloadClient* client);
+WK_EXPORT void WKContextSetConnectionClient(WKContextRef context, const WKContextConnectionClient* client);
 
 WK_EXPORT WKDownloadRef WKContextDownloadURLRequest(WKContextRef context, const WKURLRequestRef request);
 


Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (100377 => 100378)

--- trunk/Source/WebKit2/UIProcess/WebContext.cpp	2011-11-16 01:29:22 UTC (rev 100377)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp	2011-11-16 01:35:14 UTC (rev 100378)
@@ -202,6 +202,11 @@
 m_injectedBundleClient.initialize(client);
 }
 
+void WebContext::initializeConnectionClient(const WKContextConnectionClient* cl

[webkit-changes] [100377] trunk/Tools

[tony]

Title: [100377] trunk/Tools








Revision 100377
Author t...@chromium.org
Date 2011-11-15 17:29:22 -0800 (Tue, 15 Nov 2011)


Log Message
Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py




Diff

Modified: trunk/Tools/ChangeLog (100376 => 100377)

--- trunk/Tools/ChangeLog	2011-11-16 01:27:52 UTC (rev 100376)
+++ trunk/Tools/ChangeLog	2011-11-16 01:29:22 UTC (rev 100377)
@@ -1,5 +1,11 @@
 2011-11-15  Tony Chang  
 
+Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
+
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+
+2011-11-15  Tony Chang  
+
 Unreviewed, fix test-webkitpy tests.  Move the check for image results
 earlier.
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (100376 => 100377)

--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	2011-11-16 01:27:52 UTC (rev 100376)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	2011-11-16 01:29:22 UTC (rev 100377)
@@ -186,8 +186,8 @@
 class MainTest(unittest.TestCase):
 def test_accelerated_compositing(self):
 # This just tests that we recognize the command line args
-self.assertTrue(passing_run(['--accelerated-compositing']))
-self.assertTrue(passing_run(['--no-accelerated-compositing']))
+self.assertTrue(passing_run(['--accelerated-video']))
+self.assertTrue(passing_run(['--no-accelerated-video']))
 
 def test_accelerated_2d_canvas(self):
 # This just tests that we recognize the command line args






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100376] trunk

[adamk]

Title: [100376] trunk








Revision 100376
Author ad...@chromium.org
Date 2011-11-15 17:27:52 -0800 (Tue, 15 Nov 2011)


Log Message
[v8] Use throwError instead of compiling and running script in handleMaxRecursionDepthExceeded
https://bugs.webkit.org/show_bug.cgi?id=72432

Reviewed by Adam Barth.

Source/WebCore:

* bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):

LayoutTests:

Updated test that depends on the error message. The new message is a
strict improvement, as it includes the line number at which the
too-deep call was triggered. Also, we only expect a single error
message; it's not clear why the previous version generated a dup.

Also consolidate expectations, as the test does not differ per platform.

* platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
* platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
* platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
* platform/chromium/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp


Added Paths

trunk/LayoutTests/platform/chromium/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100375 => 100376)

--- trunk/LayoutTests/ChangeLog	2011-11-16 01:25:17 UTC (rev 100375)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 01:27:52 UTC (rev 100376)
@@ -1,3 +1,22 @@
+2011-11-15  Adam Klein  
+
+[v8] Use throwError instead of compiling and running script in handleMaxRecursionDepthExceeded
+https://bugs.webkit.org/show_bug.cgi?id=72432
+
+Reviewed by Adam Barth.
+
+Updated test that depends on the error message. The new message is a
+strict improvement, as it includes the line number at which the
+too-deep call was triggered. Also, we only expect a single error
+message; it's not clear why the previous version generated a dup.
+
+Also consolidate expectations, as the test does not differ per platform.
+
+* platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
+* platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
+* platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
+* platform/chromium/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
+
 2011-11-15  Erik Arvidsson  
 
 JS Test Harness: Remove need to load external css file to reduce flakiness


Added: trunk/LayoutTests/platform/chromium/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt (0 => 100376)

--- trunk/LayoutTests/platform/chromium/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt	2011-11-16 01:27:52 UTC (rev 100376)
@@ -0,0 +1,4 @@
+CONSOLE MESSAGE: line 18: Uncaught RangeError: Maximum call stack size exceeded.
+This tests that having infinite recursion in XMLHttpRequest event handler does not crash. 
+PASS
+


Deleted: trunk/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt (100375 => 100376)

--- trunk/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt	2011-11-16 01:25:17 UTC (rev 100375)
+++ trunk/LayoutTests/platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt	2011-11-16 01:27:52 UTC (rev 100376)
@@ -1,5 +0,0 @@
-CONSOLE MESSAGE: line 1: Uncaught RangeError: Maximum call stack size exceeded.
-CONSOLE MESSAGE: line 1: Uncaught RangeError: Maximum call stack size exceeded.
-This tests that having infinite recursion in XMLHttpRequest event handler does not crash. 
-PASS
-


Deleted: trunk/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt (100375 => 100376)

--- trunk/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt	2011-11-16 01:25:17 UTC (rev 100375)
+++ trunk/LayoutTests/platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt	2011-11-16 01:27:52 UTC (rev 100376)
@@ -1,5 +0,0 @@
-CONSOLE MESSAGE: line 1: Uncaught RangeError: Maximum call stac

[webkit-changes] [100375] trunk/Source/JavaScriptCore

[ggaren]

Title: [100375] trunk/Source/_javascript_Core








Revision 100375
Author gga...@apple.com
Date 2011-11-15 17:25:17 -0800 (Tue, 15 Nov 2011)


Log Message
Removed a use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION): Use new API.

* runtime/ArgList.cpp:
(JSC::ArgList::getSlice): No need to provide an arbitrary constructor --
getSlice can do the right thing by using its rights to private data.

* runtime/ArgList.h: Removed constructor that took a forward-contiguous
set of arguments.

* runtime/JSArray.cpp:
(JSC::JSArray::finishCreation):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSGlobalObject.h:
(JSC::constructArray): Added explicit support for creating an array from
a pre-allocated set of values, so we could stop relying on the ArgList
API we want to remove.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/runtime/ArgList.cpp
trunk/Source/_javascript_Core/runtime/ArgList.h
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/_javascript_Core/runtime/JSArray.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (100374 => 100375)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-16 01:23:19 UTC (rev 100374)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-16 01:25:17 UTC (rev 100375)
@@ -1,3 +1,30 @@
+2011-11-15  Geoffrey Garen  
+
+Removed a use of ArgList that baked in the assumption that arguments
+are forward in the regiter file.
+
+Reviewed by Sam Weinig.
+
+* dfg/DFGOperations.cpp:
+* jit/JITStubs.cpp:
+(JSC::DEFINE_STUB_FUNCTION): Use new API.
+
+* runtime/ArgList.cpp:
+(JSC::ArgList::getSlice): No need to provide an arbitrary constructor --
+getSlice can do the right thing by using its rights to private data.
+
+* runtime/ArgList.h: Removed constructor that took a forward-contiguous
+set of arguments.
+
+* runtime/JSArray.cpp:
+(JSC::JSArray::finishCreation):
+* runtime/JSArray.h:
+(JSC::JSArray::create):
+* runtime/JSGlobalObject.h:
+(JSC::constructArray): Added explicit support for creating an array from
+a pre-allocated set of values, so we could stop relying on the ArgList
+API we want to remove.
+
 2011-11-15  Filip Pizlo  
 
 Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)


Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (100374 => 100375)

--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2011-11-16 01:23:19 UTC (rev 100374)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2011-11-16 01:25:17 UTC (rev 100375)
@@ -779,8 +779,7 @@
 
 EncodedJSValue DFG_OPERATION operationNewArrayBuffer(ExecState* exec, size_t start, size_t size)
 {
-ArgList argList(exec->codeBlock()->constantBuffer(start), size);
-return JSValue::encode(constructArray(exec, argList));
+return constructArray(exec, exec->codeBlock()->constantBuffer(start), size);
 }
 
 EncodedJSValue DFG_OPERATION operationNewRegexp(ExecState* exec, void* regexpPtr)


Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (100374 => 100375)

--- trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-11-16 01:23:19 UTC (rev 100374)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-11-16 01:25:17 UTC (rev 100375)
@@ -2440,8 +2440,7 @@
 {
 STUB_INIT_STACK_FRAME(stackFrame);
 
-ArgList argList(stackFrame.callFrame->codeBlock()->constantBuffer(stackFrame.args[0].int32()), stackFrame.args[1].int32());
-return constructArray(stackFrame.callFrame, argList);
+return constructArray(stackFrame.callFrame, stackFrame.callFrame->codeBlock()->constantBuffer(stackFrame.args[0].int32()), stackFrame.args[1].int32());
 }
 
 DEFINE_STUB_FUNCTION(EncodedJSValue, op_resolve)


Modified: trunk/Source/_javascript_Core/runtime/ArgList.cpp (100374 => 100375)

--- trunk/Source/_javascript_Core/runtime/ArgList.cpp	2011-11-16 01:23:19 UTC (rev 100374)
+++ trunk/Source/_javascript_Core/runtime/ArgList.cpp	2011-11-16 01:25:17 UTC (rev 100375)
@@ -33,10 +33,12 @@
 void ArgList::getSlice(int startIndex, ArgList& result) const
 {
 if (startIndex <= 0 || static_cast(startIndex) >= m_argCount) {
-result = ArgList(m_args, 0);
+result = ArgList();
 return;
 }
-result = ArgList(m_args + startIndex, m_argCount - startIndex);
+
+result.m_args = m_args + startIndex;
+result.m_argCount =  m_argCount - startIndex;
 }
 
 void MarkedArgumentBuffer::markLists(HeapRootVisitor& heapRootVisitor, ListSet& markSet)


Modified: trunk/Source/_javascript_Core/runtime/ArgList.h (100374 => 100375)

--- trunk/Source/

[webkit-changes] [100374] trunk/Tools

[tony]

Title: [100374] trunk/Tools








Revision 100374
Author t...@chromium.org
Date 2011-11-15 17:23:19 -0800 (Tue, 15 Nov 2011)


Log Message
Unreviewed, fix test-webkitpy tests.  Move the check for image results
earlier.

* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (100373 => 100374)

--- trunk/Tools/ChangeLog	2011-11-16 01:06:13 UTC (rev 100373)
+++ trunk/Tools/ChangeLog	2011-11-16 01:23:19 UTC (rev 100374)
@@ -1,3 +1,11 @@
+2011-11-15  Tony Chang  
+
+Unreviewed, fix test-webkitpy tests.  Move the check for image results
+earlier.
+
+* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+
 2011-11-15  James Robinson  
 
 [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py (100373 => 100374)

--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py	2011-11-16 01:06:13 UTC (rev 100373)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py	2011-11-16 01:23:19 UTC (rev 100374)
@@ -70,8 +70,9 @@
 elif isinstance(failure, test_failures.FailureReftestMismatch):
 writer.write_image_files(driver_output.image, expected_driver_output.image)
 # FIXME: This work should be done earlier in the pipeline (e.g., when we compare images for non-ref tests).
-image_diff = port.diff_image(driver_output.image, expected_driver_output.image)[0]
-if image_diff:
+# FIXME: We should always have 2 images here.
+if driver_output.image and expected_driver_output.image:
+image_diff = port.diff_image(driver_output.image, expected_driver_output.image)[0]
 writer.write_image_diff_files(image_diff)
 writer.copy_file(failure.reference_filename)
 elif isinstance(failure, test_failures.FailureReftestMismatchDidNotOccur):


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (100373 => 100374)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2011-11-16 01:06:13 UTC (rev 100373)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2011-11-16 01:23:19 UTC (rev 100374)
@@ -163,7 +163,7 @@
 if not actual_contents or not expected_contents:
 # FIXME: It's not clear what we should return in this case.
 # Maybe we should throw an exception?
-return (None, 0)
+return (True, 0)
 
 process = self._start_image_diff_process(expected_contents, actual_contents)
 return self._read_image_diff(process)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100373] trunk/Source/WebCore

[scheib]

Title: [100373] trunk/Source/WebCore








Revision 100373
Author sch...@chromium.org
Date 2011-11-15 17:06:13 -0800 (Tue, 15 Nov 2011)


Log Message
Pointer Lock: Refactoring: PointerLock.idl: Dropping webkit prefix
https://bugs.webkit.org/show_bug.cgi?id=72431

Reviewed by Adam Barth.

* page/PointerLock.cpp:
(WebCore::PointerLock::lock):
(WebCore::PointerLock::unlock):
(WebCore::PointerLock::isLocked):
* page/PointerLock.h:
* page/PointerLock.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PointerLock.cpp
trunk/Source/WebCore/page/PointerLock.h
trunk/Source/WebCore/page/PointerLock.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (100372 => 100373)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 01:03:36 UTC (rev 100372)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 01:06:13 UTC (rev 100373)
@@ -1,3 +1,17 @@
+2011-11-15  Vincent Scheib  
+
+Pointer Lock: Refactoring: PointerLock.idl: Dropping webkit prefix
+https://bugs.webkit.org/show_bug.cgi?id=72431
+
+Reviewed by Adam Barth.
+
+* page/PointerLock.cpp:
+(WebCore::PointerLock::lock):
+(WebCore::PointerLock::unlock):
+(WebCore::PointerLock::isLocked):
+* page/PointerLock.h:
+* page/PointerLock.idl:
+
 2011-11-15  Nat Duca  
 
 [chromium] Fuse MainThread and CCThread


Modified: trunk/Source/WebCore/page/PointerLock.cpp (100372 => 100373)

--- trunk/Source/WebCore/page/PointerLock.cpp	2011-11-16 01:03:36 UTC (rev 100372)
+++ trunk/Source/WebCore/page/PointerLock.cpp	2011-11-16 01:06:13 UTC (rev 100373)
@@ -37,17 +37,17 @@
 {
 }
 
-void PointerLock::webkitLock(Element* target, PassRefPtr successCallback, PassRefPtr failureCallback)
+void PointerLock::lock(Element* target, PassRefPtr successCallback, PassRefPtr failureCallback)
 {
 // FIXME: Implement
 }
 
-void PointerLock::webkitUnlock()
+void PointerLock::unlock()
 {
 // FIXME: Implement
 }
 
-bool PointerLock::webkitIsLocked()
+bool PointerLock::isLocked()
 {
 // FIXME: Implement
 return false;


Modified: trunk/Source/WebCore/page/PointerLock.h (100372 => 100373)

--- trunk/Source/WebCore/page/PointerLock.h	2011-11-16 01:03:36 UTC (rev 100372)
+++ trunk/Source/WebCore/page/PointerLock.h	2011-11-16 01:06:13 UTC (rev 100373)
@@ -41,9 +41,9 @@
 
 ~PointerLock();
 
-void webkitLock(Element* target, PassRefPtr successCallback, PassRefPtr failureCallback);
-void webkitUnlock();
-bool webkitIsLocked();
+void lock(Element* target, PassRefPtr successCallback, PassRefPtr failureCallback);
+void unlock();
+bool isLocked();
 
 private:
 PointerLock();


Modified: trunk/Source/WebCore/page/PointerLock.idl (100372 => 100373)

--- trunk/Source/WebCore/page/PointerLock.idl	2011-11-16 01:03:36 UTC (rev 100372)
+++ trunk/Source/WebCore/page/PointerLock.idl	2011-11-16 01:06:13 UTC (rev 100373)
@@ -28,9 +28,9 @@
 Conditional=POINTER_LOCK,
 OmitConstructor
 ] PointerLock {
-void webkitLock(in Element target, in [Callback, Optional] VoidCallback successCallback, in [Callback, Optional] VoidCallback failureCallback);
-void webkitUnlock();
-boolean webkitIsLocked();
+void lock(in Element target, in [Callback, Optional] VoidCallback successCallback, in [Callback, Optional] VoidCallback failureCallback);
+void unlock();
+boolean isLocked();
 };
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100372] branches/subpixellayout/Source/WebCore/rendering

[leviw]

Title: [100372] branches/subpixellayout/Source/WebCore/rendering








Revision 100372
Author le...@chromium.org
Date 2011-11-15 17:03:36 -0800 (Tue, 15 Nov 2011)


Log Message
Converting table row height calculations back to ints and avoiding enclosingIntRect when outputting test expectations for table parts.

Modified Paths

branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderTable.h
branches/subpixellayout/Source/WebCore/rendering/RenderTableSection.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderTableSection.h
branches/subpixellayout/Source/WebCore/rendering/RenderTreeAsText.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp (100371 => 100372)

--- branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp	2011-11-16 01:03:33 UTC (rev 100371)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp	2011-11-16 01:03:36 UTC (rev 100372)
@@ -318,7 +318,7 @@
 
 setCellLogicalWidths();
 
-LayoutUnit totalSectionLogicalHeight = 0;
+int totalSectionLogicalHeight = 0;
 LayoutUnit oldTableLogicalTop = m_caption ? m_caption->logicalHeight() + m_caption->marginBefore() + m_caption->marginAfter() : LayoutUnit(0);
 
 bool collapsing = collapseBorders();
@@ -356,8 +356,8 @@
 }
 }
 
-LayoutUnit borderAndPaddingBefore = borderBefore() + (collapsing ? LayoutUnit(0) : paddingBefore());
-LayoutUnit borderAndPaddingAfter = borderAfter() + (collapsing ? LayoutUnit(0) : paddingAfter());
+LayoutUnit borderAndPaddingBefore = borderBefore() + (collapsing ? LayoutUnit() : paddingBefore());
+LayoutUnit borderAndPaddingAfter = borderAfter() + (collapsing ? LayoutUnit() : paddingAfter());
 
 setLogicalHeight(logicalHeight() + borderAndPaddingBefore);
 
@@ -365,7 +365,7 @@
 computeLogicalHeight();
 
 Length logicalHeightLength = style()->logicalHeight();
-LayoutUnit computedLogicalHeight = 0;
+LayoutUnit computedLogicalHeight;
 if (logicalHeightLength.isFixed()) {
 // HTML tables size as though CSS height includes border/padding, CSS tables do not.
 LayoutUnit borders = node() && node()->hasTagName(tableTag) ? (borderAndPaddingBefore + borderAndPaddingAfter) : LayoutUnit(0);
@@ -374,10 +374,12 @@
 computedLogicalHeight = computePercentageLogicalHeight(logicalHeightLength);
 computedLogicalHeight = max(0, computedLogicalHeight);
 
+int pixelSnappedLogicalHeight = (logicalTop() + computedLogicalHeight).round() - logicalTop().round();
+
 for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {
 if (child->isTableSection())
 // FIXME: Distribute extra height between all table body sections instead of giving it all to the first one.
-toRenderTableSection(child)->layoutRows(child == m_firstBody ? max(0, computedLogicalHeight - totalSectionLogicalHeight) : LayoutUnit(0));
+toRenderTableSection(child)->layoutRows(child == m_firstBody ? max(0, pixelSnappedLogicalHeight - totalSectionLogicalHeight) : 0);
 }
 
 if (!m_firstBody && computedLogicalHeight > totalSectionLogicalHeight && !document()->inQuirksMode()) {


Modified: branches/subpixellayout/Source/WebCore/rendering/RenderTable.h (100371 => 100372)

--- branches/subpixellayout/Source/WebCore/rendering/RenderTable.h	2011-11-16 01:03:33 UTC (rev 100371)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderTable.h	2011-11-16 01:03:36 UTC (rev 100372)
@@ -44,7 +44,7 @@
 explicit RenderTable(Node*);
 virtual ~RenderTable();
 
-LayoutUnit getColumnPos(int col) const { return m_columnPos[col]; }
+int getColumnPos(int col) const { return m_columnPos[col]; }
 
 int hBorderSpacing() const { return m_hSpacing; }
 int vBorderSpacing() const { return m_vSpacing; }
@@ -135,7 +135,7 @@
 };
 
 Vector& columns() { return m_columns; }
-Vector& columnPositions() { return m_columnPos; }
+Vector& columnPositions() { return m_columnPos; }
 RenderTableSection* header() const { return m_head; }
 RenderTableSection* footer() const { return m_foot; }
 RenderTableSection* firstBody() const { return m_firstBody; }
@@ -250,7 +250,7 @@
 void recalcSections() const;
 void adjustLogicalHeightForCaption();
 
-mutable Vector m_columnPos;
+mutable Vector m_columnPos;
 mutable Vector m_columns;
 
 mutable RenderBlock* m_caption;


Modified: branches/subpixellayout/Source/WebCore/rendering/RenderTableSection.cpp (100371 => 100372)

--- branches/subpixellayout/Source/WebCore/rendering/RenderTableSection.cpp	2011-11-16 01:03:33 UTC (rev 100371)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderTableSection.cpp	2011-11-16 01:03:36 UTC (rev 100372)
@@ -264,7 +264,7 @@
 
 void RenderTableSection::setCellLogicalWidths()
 {
-Vector& columnPos = table()->columnPositions();
+Vector& columnPos = table()->columnPositi

[webkit-changes] [100369] trunk/LayoutTests

[arv]

Title: [100369] trunk/LayoutTests








Revision 100369
Author a...@chromium.org
Date 2011-11-15 16:45:48 -0800 (Tue, 15 Nov 2011)


Log Message
JS Test Harness: Remove need to load external css file to reduce flakiness
https://bugs.webkit.org/show_bug.cgi?id=72295

Reviewed by Ojan Vafai.

Before this patch we pulled in the external CSS file using a link tag. Since this was created dynamically
it might not be loaded and applied when we dump the text for the test. Since the CSS contains white-space
pre-wrap the output was therefore different depending on this race condition. By changing this to use a
style element with the CSS inline there is no longer a race condition.

* css3/font-feature-settings-parsing.html: Change the order of script and stylesheets so that the injected style element does not affect the test.
* fast/css/counters/counter-cssText.html: Ditto.
* fast/css/counters/getCounterValue.html: Ditto.
* fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml: Ditto.
* traversal/script-tests/exception-forwarding.js: Ditto.
* fast/dom/script-tests/domListEnumeration.js: Update the tests to use the right style elements.
* fast/js/resources/js-test-pre.js: Insert a style element with the css instead of a link element pointing to an external css file.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/font-feature-settings-parsing.html
trunk/LayoutTests/fast/css/counters/counter-cssText.html
trunk/LayoutTests/fast/css/counters/getCounterValue.html
trunk/LayoutTests/fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml
trunk/LayoutTests/fast/dom/script-tests/domListEnumeration.js
trunk/LayoutTests/fast/js/resources/js-test-pre.js
trunk/LayoutTests/traversal/script-tests/exception-forwarding.js




Diff

Modified: trunk/LayoutTests/ChangeLog (100368 => 100369)

--- trunk/LayoutTests/ChangeLog	2011-11-16 00:43:50 UTC (rev 100368)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 00:45:48 UTC (rev 100369)
@@ -1,3 +1,23 @@
+2011-11-15  Erik Arvidsson  
+
+JS Test Harness: Remove need to load external css file to reduce flakiness
+https://bugs.webkit.org/show_bug.cgi?id=72295
+
+Reviewed by Ojan Vafai.
+
+Before this patch we pulled in the external CSS file using a link tag. Since this was created dynamically
+it might not be loaded and applied when we dump the text for the test. Since the CSS contains white-space
+pre-wrap the output was therefore different depending on this race condition. By changing this to use a
+style element with the CSS inline there is no longer a race condition.
+
+* css3/font-feature-settings-parsing.html: Change the order of script and stylesheets so that the injected style element does not affect the test.
+* fast/css/counters/counter-cssText.html: Ditto.
+* fast/css/counters/getCounterValue.html: Ditto.
+* fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml: Ditto.
+* traversal/script-tests/exception-forwarding.js: Ditto.
+* fast/dom/script-tests/domListEnumeration.js: Update the tests to use the right style elements.
+* fast/js/resources/js-test-pre.js: Insert a style element with the css instead of a link element pointing to an external css file.
+
 2011-11-15  Peter Kasting  
 
 Mark a test as flakily failing.


Modified: trunk/LayoutTests/css3/font-feature-settings-parsing.html (100368 => 100369)

--- trunk/LayoutTests/css3/font-feature-settings-parsing.html	2011-11-16 00:43:50 UTC (rev 100368)
+++ trunk/LayoutTests/css3/font-feature-settings-parsing.html	2011-11-16 00:45:48 UTC (rev 100369)
@@ -1,6 +1,5 @@
 
 
-

[webkit-changes] [100368] trunk/Tools

[jamesr]

Title: [100368] trunk/Tools








Revision 100368
Author jam...@google.com
Date 2011-11-15 16:43:50 -0800 (Tue, 15 Nov 2011)


Log Message
[chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
https://bugs.webkit.org/show_bug.cgi?id=72444

Reviewed by Adam Barth.

* DumpRenderTree/chromium/DumpRenderTree.cpp:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp




Diff

Modified: trunk/Tools/ChangeLog (100367 => 100368)

--- trunk/Tools/ChangeLog	2011-11-16 00:40:27 UTC (rev 100367)
+++ trunk/Tools/ChangeLog	2011-11-16 00:43:50 UTC (rev 100368)
@@ -1,3 +1,12 @@
+2011-11-15  James Robinson  
+
+[chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
+https://bugs.webkit.org/show_bug.cgi?id=72444
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/DumpRenderTree.cpp:
+
 2011-11-15  Tony Chang  
 
 Unreviewed, better fix for ref tests failures on SL Intel bot.


Modified: trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp (100367 => 100368)

--- trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp	2011-11-16 00:40:27 UTC (rev 100367)
+++ trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp	2011-11-16 00:43:50 UTC (rev 100368)
@@ -53,12 +53,12 @@
 static const char optionCheckLayoutTestSystemDeps[] = "--check-layout-test-sys-deps";
 
 static const char optionHardwareAcceleratedGL[] = "--enable-hardware-gpu";
-static const char optionEnableAcceleratedCompositingForVideo[] = "--enable-compositing-for-video";
 static const char optionEnableThreadedCompositing[] = "--enable-threaded-compositing";
 static const char optionForceCompositingMode[] = "--force-compositing-mode";
 static const char optionEnableAccelerated2DCanvas[] = "--enable-accelerated-2d-canvas";
 static const char optionEnableLegacyAccelerated2DCanvas[] = "--enable-legacy-accelerated-2d-canvas";
 static const char optionEnableAcceleratedDrawing[] = "--enable-accelerated-drawing";
+static const char optionEnableAcceleratedCompositingForVideo[] = "--enable-accelerated-video";
 static const char optionEnableCompositeToTexture[] = "--enable-composite-to-texture";
 static const char optionUseGraphicsContext3DImplementation[] = "--use-graphics-context-3d-implementation=";
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100367] trunk/LayoutTests

[pkasting]

Title: [100367] trunk/LayoutTests








Revision 100367
Author pkast...@chromium.org
Date 2011-11-15 16:40:27 -0800 (Tue, 15 Nov 2011)


Log Message
Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=72269

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100366 => 100367)

--- trunk/LayoutTests/ChangeLog	2011-11-16 00:34:00 UTC (rev 100366)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 00:40:27 UTC (rev 100367)
@@ -1,3 +1,12 @@
+2011-11-15  Peter Kasting  
+
+Mark a test as flakily failing.
+https://bugs.webkit.org/show_bug.cgi?id=72269
+
+Unreviewed, gardening.
+
+* platform/chromium/test_expectations.txt:
+
 2011-10-28  Ojan Vafai  
 
 implement flex-align for flex-flow: column


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100366 => 100367)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 00:34:00 UTC (rev 100366)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 00:40:27 UTC (rev 100367)
@@ -3936,3 +3936,5 @@
 BUGWK72376 WIN : fast/forms/file/input-file-label.html = TEXT PASS
 
 BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS
+
+BUGWK72269 : media/track/track-cues-cuechange.html = PASS TEXT
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100366] trunk/Source/WebCore

[scheib]

Title: [100366] trunk/Source/WebCore








Revision 100366
Author sch...@chromium.org
Date 2011-11-15 16:34:00 -0800 (Tue, 15 Nov 2011)


Log Message
Pointer Lock: Refactor: MouseEvent.idl movementX/Y
https://bugs.webkit.org/show_bug.cgi?id=72427

- [Conditional...] vs #if defined
- Runtime enabled
- .movementX/Y prefixed with 'webkit'

Reviewed by Adam Barth.

No new tests.

* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitMovementXEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMovementYEnabled):
* dom/MouseEvent.idl:
* dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::webkitMovementX):
(WebCore::MouseRelatedEvent::webkitMovementY):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
trunk/Source/WebCore/dom/MouseEvent.idl
trunk/Source/WebCore/dom/MouseRelatedEvent.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (100365 => 100366)

--- trunk/Source/WebCore/ChangeLog	2011-11-16 00:29:12 UTC (rev 100365)
+++ trunk/Source/WebCore/ChangeLog	2011-11-16 00:34:00 UTC (rev 100366)
@@ -1,3 +1,24 @@
+2011-11-15  Vincent Scheib  
+
+Pointer Lock: Refactor: MouseEvent.idl movementX/Y
+https://bugs.webkit.org/show_bug.cgi?id=72427
+
+- [Conditional...] vs #if defined
+- Runtime enabled
+- .movementX/Y prefixed with 'webkit'
+
+Reviewed by Adam Barth.
+
+No new tests.
+
+* bindings/generic/RuntimeEnabledFeatures.h:
+(WebCore::RuntimeEnabledFeatures::webkitMovementXEnabled):
+(WebCore::RuntimeEnabledFeatures::webkitMovementYEnabled):
+* dom/MouseEvent.idl:
+* dom/MouseRelatedEvent.h:
+(WebCore::MouseRelatedEvent::webkitMovementX):
+(WebCore::MouseRelatedEvent::webkitMovementY):
+
 2011-10-28  Ojan Vafai  
 
 implement flex-align for flex-flow: column


Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (100365 => 100366)

--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	2011-11-16 00:29:12 UTC (rev 100365)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	2011-11-16 00:34:00 UTC (rev 100366)
@@ -84,6 +84,8 @@
 static bool webkitPointerLockEnabled() { return isPointerLockEnabled; }
 static void setWebkitPointerLockEnabled(bool isEnabled) { isPointerLockEnabled = isEnabled; }
 static bool webkitPointerEnabled() { return isPointerLockEnabled; }
+static bool webkitMovementXEnabled() { return isPointerLockEnabled; }
+static bool webkitMovementYEnabled() { return isPointerLockEnabled; }
 #endif
 
 #if ENABLE(VIDEO)


Modified: trunk/Source/WebCore/dom/MouseEvent.idl (100365 => 100366)

--- trunk/Source/WebCore/dom/MouseEvent.idl	2011-11-16 00:29:12 UTC (rev 100365)
+++ trunk/Source/WebCore/dom/MouseEvent.idl	2011-11-16 00:34:00 UTC (rev 100366)
@@ -25,10 +25,8 @@
 readonly attribute long screenY;
 readonly attribute long clientX;
 readonly attribute long clientY;
-#if defined(ENABLE_POINTER_LOCK) && ENABLE_POINTER_LOCK
-readonly attribute long movementX;
-readonly attribute long movementY;
-#endif
+readonly attribute [Conditional=POINTER_LOCK, EnabledAtRuntime] long webkitMovementX;
+readonly attribute [Conditional=POINTER_LOCK, EnabledAtRuntime] long webkitMovementY;
 readonly attribute boolean  ctrlKey;
 readonly attribute boolean  shiftKey;
 readonly attribute boolean  altKey;


Modified: trunk/Source/WebCore/dom/MouseRelatedEvent.h (100365 => 100366)

--- trunk/Source/WebCore/dom/MouseRelatedEvent.h	2011-11-16 00:29:12 UTC (rev 100365)
+++ trunk/Source/WebCore/dom/MouseRelatedEvent.h	2011-11-16 00:34:00 UTC (rev 100366)
@@ -40,8 +40,8 @@
 int clientX() const { return m_clientLocation.x(); }
 int clientY() const { return m_clientLocation.y(); }
 #if ENABLE(POINTER_LOCK)
-int movementX() const { return m_movementDelta.x(); }
-int movementY() const { return m_movementDelta.y(); }
+int webkitMovementX() const { return m_movementDelta.x(); }
+int webkitMovementY() const { return m_movementDelta.y(); }
 #endif
 const LayoutPoint& clientLocation() const { return m_clientLocation; }
 int layerX();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100365] trunk

[ojan]

Title: [100365] trunk








Revision 100365
Author o...@chromium.org
Date 2011-11-15 16:29:12 -0800 (Tue, 15 Nov 2011)


Log Message
implement flex-align for flex-flow: column
https://bugs.webkit.org/show_bug.cgi?id=70754

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flex-align-column.html
   css3/flexbox/line-wrapping.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
When flexitems are column, they should size to the intrinsic width unless flex-flow is stretch.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
This was just using the wrong, non-flow-aware method.

LayoutTests:

* css3/flexbox/flex-align-column-expected.txt: Added.
* css3/flexbox/flex-align-column.html: Added.
Tests the basic flex-align cases with column.

* css3/flexbox/line-wrapping-expected.txt: Added.
* css3/flexbox/line-wrapping.html: Added.
This tests that wrapping inside flexitems uses the correct width.
Notably, auto-sizing properly falls back on the initial containing block.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp


Added Paths

trunk/LayoutTests/css3/flexbox/flex-align-column-expected.txt
trunk/LayoutTests/css3/flexbox/flex-align-column.html
trunk/LayoutTests/css3/flexbox/line-wrapping-expected.txt
trunk/LayoutTests/css3/flexbox/line-wrapping.html




Diff

Modified: trunk/LayoutTests/ChangeLog (100364 => 100365)

--- trunk/LayoutTests/ChangeLog	2011-11-16 00:27:08 UTC (rev 100364)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 00:29:12 UTC (rev 100365)
@@ -1,3 +1,19 @@
+2011-10-28  Ojan Vafai  
+
+implement flex-align for flex-flow: column
+https://bugs.webkit.org/show_bug.cgi?id=70754
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/flex-align-column-expected.txt: Added.
+* css3/flexbox/flex-align-column.html: Added.
+Tests the basic flex-align cases with column.
+
+* css3/flexbox/line-wrapping-expected.txt: Added.
+* css3/flexbox/line-wrapping.html: Added.
+This tests that wrapping inside flexitems uses the correct width.
+Notably, auto-sizing properly falls back on the initial containing block.
+
 2011-11-15  Peter Kasting  
 
 Mark another test as flakily crashing.
@@ -350,6 +366,18 @@
 * css3/flexbox/flex-item-child-overflow-expected.html: Added.
 * css3/flexbox/flex-item-child-overflow.html: Added.
 
+2011-10-28  Ojan Vafai  
+
+Overflow and relayout are broken in the new flexboxes
+https://bugs.webkit.org/show_bug.cgi?id=71161
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/auto-height-dynamic-expected.txt: Added.
+* css3/flexbox/auto-height-dynamic.html: Added.
+* css3/flexbox/flex-item-child-overflow-expected.html: Added.
+* css3/flexbox/flex-item-child-overflow.html: Added.
+
 2011-11-15  Peter Kasting  
 
 Fix expectations after r100276.


Added: trunk/LayoutTests/css3/flexbox/flex-align-column-expected.txt (0 => 100365)

--- trunk/LayoutTests/css3/flexbox/flex-align-column-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/flex-align-column-expected.txt	2011-11-16 00:29:12 UTC (rev 100365)
@@ -0,0 +1,2 @@
+PASS
+PASS
Property changes on: trunk/LayoutTests/css3/flexbox/flex-align-column-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/css3/flexbox/flex-align-column.html (0 => 100365)

--- trunk/LayoutTests/css3/flexbox/flex-align-column.html	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/flex-align-column.html	2011-11-16 00:29:12 UTC (rev 100365)
@@ -0,0 +1,66 @@
+
+
+
+body {
+margin: 0;
+}
+.flexbox {
+width: 600px;
+height: 240px;
+display: -webkit-flexbox;
+background-color: #aaa;
+position: relative;
+-webkit-flex-flow: column;
+}
+.vertical {
+-webkit-writing-mode: vertical-lr;
+}
+.flexbox :nth-child(1) {
+background-color: blue;
+}
+.flexbox :nth-child(2) {
+background-color: green;
+}
+.flexbox :nth-child(3) {
+background-color: red;
+}
+.flexbox :nth-child(4) {
+background-color: yellow;
+}
+.flexbox :nth-child(5) {
+background-color: purple;
+}
+.flexbox :nth-child(6) {
+background-color: orange;
+}
+.flexbox :nth-child(7) {
+background-color: lime;
+}
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
+
+

+

+

+
[webkit-changes] [100364] trunk/LayoutTests


2011-11-15

Thread
pkasting

Title: [100364] trunk/LayoutTests








Revision 100364
Author pkast...@chromium.org
Date 2011-11-15 16:27:08 -0800 (Tue, 15 Nov 2011)


Log Message
Mark another test as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=59552

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100363 => 100364)

--- trunk/LayoutTests/ChangeLog	2011-11-16 00:26:30 UTC (rev 100363)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 00:27:08 UTC (rev 100364)
@@ -1,5 +1,14 @@
 2011-11-15  Peter Kasting  
 
+Mark another test as flakily crashing.
+https://bugs.webkit.org/show_bug.cgi?id=59552
+
+Unreviewed, gardening.
+
+* platform/chromium/test_expectations.txt:
+
+2011-11-15  Peter Kasting  
+
 r100331 did not seem to commit precisely the right expectation.
 https://bugs.webkit.org/show_bug.cgi?id=72391
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100363 => 100364)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 00:26:30 UTC (rev 100363)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 00:27:08 UTC (rev 100364)
@@ -3840,6 +3840,7 @@
 BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/content-opacity-2.html = PASS CRASH
 BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/iframe-double-scale-contents.html = PASS CRASH
 BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/set-parent-src-synchronously.html = PASS CRASH
+BUGWK59552 SNOWLEOPARD DEBUG : fast/loader/opaque-base-url.html = PASS CRASH
 BUGWK59552 SNOWLEOPARD DEBUG : fast/parser/close-while-stopping.html = PASS CRASH
 BUGWK59552 SNOWLEOPARD DEBUG : http/tests/security/cross-frame-access-custom.html = PASS CRASH
 BUGWK59552 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100362] trunk/Source/WebKit2


2011-11-15

Thread
commit-queue

Title: [100362] trunk/Source/WebKit2








Revision 100362
Author commit-qu...@webkit.org
Date 2011-11-15 16:26:15 -0800 (Tue, 15 Nov 2011)


Log Message
[SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2
https://bugs.webkit.org/show_bug.cgi?id=72235

Patch by Jongseok Yang  on 2011-11-15
Reviewed by Gustavo Noronha Silva.

Add WebCookieManagerSoup.cpp and implement functions for the cookie accept policy.
It's required when using the soup network backend.
Remove WebCookieManagerEfl.cpp and WebCookieManagerGtk.cpp because GTK port and
EFL port use soup network backend without a network backend of their own.

* GNUmakefile.am:
* WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Removed.
* WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Removed.
* WebProcess/Cookies/soup/WebCookieManagerSoup.cpp: Added.
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am


Added Paths

trunk/Source/WebKit2/WebProcess/Cookies/soup/
trunk/Source/WebKit2/WebProcess/Cookies/soup/WebCookieManagerSoup.cpp


Removed Paths

trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp
trunk/Source/WebKit2/WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (100361 => 100362)

--- trunk/Source/WebKit2/ChangeLog	2011-11-16 00:24:40 UTC (rev 100361)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-16 00:26:15 UTC (rev 100362)
@@ -1,3 +1,22 @@
+2011-11-15  Jongseok Yang  
+
+[SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2
+https://bugs.webkit.org/show_bug.cgi?id=72235
+
+Reviewed by Gustavo Noronha Silva.
+
+Add WebCookieManagerSoup.cpp and implement functions for the cookie accept policy.
+It's required when using the soup network backend.
+Remove WebCookieManagerEfl.cpp and WebCookieManagerGtk.cpp because GTK port and
+EFL port use soup network backend without a network backend of their own.
+
+* GNUmakefile.am:
+* WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Removed.
+* WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Removed.
+* WebProcess/Cookies/soup/WebCookieManagerSoup.cpp: Added.
+(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
+(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
+
 2011-11-15  Jochen Eisinger  
 
 Rename ReferrerPolicy to clarify its meaning


Modified: trunk/Source/WebKit2/GNUmakefile.am (100361 => 100362)

--- trunk/Source/WebKit2/GNUmakefile.am	2011-11-16 00:24:40 UTC (rev 100361)
+++ trunk/Source/WebKit2/GNUmakefile.am	2011-11-16 00:26:15 UTC (rev 100362)
@@ -669,7 +669,7 @@
 	Source/WebKit2/WebProcess/Authentication/AuthenticationManager.h \
 	Source/WebKit2/WebProcess/Cookies/WebCookieManager.h \
 	Source/WebKit2/WebProcess/Cookies/WebCookieManager.cpp \
-	Source/WebKit2/WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp \
+	Source/WebKit2/WebProcess/Cookies/soup/WebCookieManagerSoup.cpp \
 	Source/WebKit2/WebProcess/Downloads/Download.cpp \
 	Source/WebKit2/WebProcess/Downloads/Download.h \
 	Source/WebKit2/WebProcess/Downloads/DownloadAuthenticationClient.h \


Deleted: trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp (100361 => 100362)

--- trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp	2011-11-16 00:24:40 UTC (rev 100361)
+++ trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp	2011-11-16 00:26:15 UTC (rev 100362)
@@ -1,44 +0,0 @@
-/*
- * Copyright (C) 2011 Samsung Electronics.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config



[webkit-changes] [100363] trunk/Source/JavaScriptCore


2011-11-15

Thread
fpizlo

Title: [100363] trunk/Source/_javascript_Core








Revision 100363
Author fpi...@apple.com
Date 2011-11-15 16:26:30 -0800 (Tue, 15 Nov 2011)


Log Message
Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Geoff Garen.

We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling
an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion()
instead of CodeBlock::alternative().

No performance effect.

No tests because all of our heuristics work very hard to make sure that this never happens in
the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation)
is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still
because the whole point of jettisoning is to bring the probability of future OSR exits to as
close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR
exit after a jettison to be the first of its kind; our whole design tries to ensure that
CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning
is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR
compilation. So this is a truly evil case, and any test for it would be quite fragile.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h
trunk/Source/_javascript_Core/dfg/DFGDriver.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (100362 => 100363)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-16 00:26:15 UTC (rev 100362)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-16 00:26:30 UTC (rev 100363)
@@ -1,3 +1,40 @@
+2011-11-15  Filip Pizlo  
+
+Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
+https://bugs.webkit.org/show_bug.cgi?id=72292
+
+Reviewed by Geoff Garen.
+
+We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling
+an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion()
+instead of CodeBlock::alternative().
+
+No performance effect.
+
+No tests because all of our heuristics work very hard to make sure that this never happens in
+the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation)
+is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still
+because the whole point of jettisoning is to bring the probability of future OSR exits to as
+close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR
+exit after a jettison to be the first of its kind; our whole design tries to ensure that
+CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning
+is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR
+compilation. So this is a truly evil case, and any test for it would be quite fragile.
+
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::specializationKind):
+(JSC::CodeBlock::largeFailCountThreshold):
+(JSC::CodeBlock::largeFailCountThresholdForLoop):
+* dfg/DFGAssemblyHelpers.h:
+(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
+(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
+(JSC::DFG::AssemblyHelpers::baselineCodeBlock):
+* dfg/DFGDriver.cpp:
+(JSC::DFG::compile):
+* dfg/DFGOSRExitCompiler.cpp:
+* dfg/DFGOSRExitCompiler64.cpp:
+(JSC::DFG::OSRExitCompiler::compileExit):
+
 2011-11-15  Geoffrey Garen  
 
 Use MarkedArgumentBuffer to avoid making assumptions about argument order


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (100362 => 100363)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2011-11-16 00:26:15 UTC (rev 100362)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2011-11-16 00:26:30 UTC (rev 100363)
@@ -267,7 +267,14 @@
 CodeBlock* alt



[webkit-changes] [100361] trunk/LayoutTests


2011-11-15

Thread
pkasting

Title: [100361] trunk/LayoutTests








Revision 100361
Author pkast...@chromium.org
Date 2011-11-15 16:24:40 -0800 (Tue, 15 Nov 2011)


Log Message
r100331 did not seem to commit precisely the right expectation.
https://bugs.webkit.org/show_bug.cgi?id=72391

Unreviewed, gardening.

* fast/dom/Orientation/create-event-orientationchange-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100360 => 100361)

--- trunk/LayoutTests/ChangeLog	2011-11-16 00:23:44 UTC (rev 100360)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 00:24:40 UTC (rev 100361)
@@ -1,3 +1,12 @@
+2011-11-15  Peter Kasting  
+
+r100331 did not seem to commit precisely the right expectation.
+https://bugs.webkit.org/show_bug.cgi?id=72391
+
+Unreviewed, gardening.
+
+* fast/dom/Orientation/create-event-orientationchange-expected.txt:
+
 2011-11-15  James Robinson  
 
 [chromium] Unreviewed expectations update for compositing tests


Modified: trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt (100360 => 100361)

--- trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt	2011-11-16 00:23:44 UTC (rev 100360)
+++ trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt	2011-11-16 00:24:40 UTC (rev 100361)
@@ -6,4 +6,4 @@
 PASS successfullyParsed is true
 
 TEST COMPLETE
-FAIL... orientationChange event doesn't appear to be enabled or implemented.
\ No newline at end of file
+FAIL... orientationChange event doesn't appear to be enabled or implemented.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100359] trunk/LayoutTests


2011-11-15

Thread
tony

Title: [100359] trunk/LayoutTests








Revision 100359
Author t...@chromium.org
Date 2011-11-15 16:20:03 -0800 (Tue, 15 Nov 2011)


Log Message
Skip editing/pasteboard/data-transfer-items-image-png.html, a ref test, on platforms that
don't currently support DataTransferItems.

* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/win/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/win/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (100358 => 100359)

--- trunk/LayoutTests/ChangeLog	2011-11-16 00:17:03 UTC (rev 100358)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 00:20:03 UTC (rev 100359)
@@ -1,3 +1,12 @@
+2011-11-15  Tony Chang  
+
+Skip editing/pasteboard/data-transfer-items-image-png.html, a ref test, on platforms that
+don't currently support DataTransferItems.
+
+* platform/gtk/Skipped:
+* platform/mac/Skipped:
+* platform/win/Skipped:
+
 2011-11-15  Peter Kasting  
 
 Mark a test as flakily crashing.


Modified: trunk/LayoutTests/platform/gtk/Skipped (100358 => 100359)

--- trunk/LayoutTests/platform/gtk/Skipped	2011-11-16 00:17:03 UTC (rev 100358)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-11-16 00:20:03 UTC (rev 100359)
@@ -296,6 +296,7 @@
 
 # DataTransferItems is not yet implemented.
 editing/pasteboard/data-transfer-items.html
+editing/pasteboard/data-transfer-items-image-png.html
 
 # Needs grammar checking.
 editing/spelling/markers.html


Modified: trunk/LayoutTests/platform/mac/Skipped (100358 => 100359)

--- trunk/LayoutTests/platform/mac/Skipped	2011-11-16 00:17:03 UTC (rev 100358)
+++ trunk/LayoutTests/platform/mac/Skipped	2011-11-16 00:20:03 UTC (rev 100359)
@@ -337,6 +337,7 @@
 
 # DataTransferItems is not yet implemented.
 editing/pasteboard/data-transfer-items.html
+editing/pasteboard/data-transfer-items-image-png.html
 
 # Need to implement WebGeolocationRequest::cancelPermissionRequest on mac.
 # https://bugs.webkit.org/show_bug.cgi?id=55944


Modified: trunk/LayoutTests/platform/win/Skipped (100358 => 100359)

--- trunk/LayoutTests/platform/win/Skipped	2011-11-16 00:17:03 UTC (rev 100358)
+++ trunk/LayoutTests/platform/win/Skipped	2011-11-16 00:20:03 UTC (rev 100359)
@@ -1271,6 +1271,7 @@
 
 # DataTransferItems is not yet implemented.
 editing/pasteboard/data-transfer-items.html
+editing/pasteboard/data-transfer-items-image-png.html
 
 # Needs expectation update
 fast/dom/HTMLMeterElement/meter-element.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100358] trunk/LayoutTests


2011-11-15

Thread
pkasting

Title: [100358] trunk/LayoutTests








Revision 100358
Author pkast...@chromium.org
Date 2011-11-15 16:17:03 -0800 (Tue, 15 Nov 2011)


Log Message
Mark a test as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=72436

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100357 => 100358)

--- trunk/LayoutTests/ChangeLog	2011-11-16 00:09:51 UTC (rev 100357)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 00:17:03 UTC (rev 100358)
@@ -1,3 +1,12 @@
+2011-11-15  Peter Kasting  
+
+Mark a test as flakily crashing.
+https://bugs.webkit.org/show_bug.cgi?id=72436
+
+Unreviewed, gardening.
+
+* platform/chromium/test_expectations.txt:
+
 2011-11-15  Ojan Vafai  
 
 Chromium baselines after http://trac.webkit.org/changeset/100324.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100357 => 100358)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 00:09:51 UTC (rev 100357)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 00:17:03 UTC (rev 100358)
@@ -1232,7 +1232,8 @@
 BUGCR10361 WIN : http/tests/misc/single-character-pi-stylesheet.xhtml = FAIL
 
 // Windows is missing the green box. Started to pass in roll to WebKit r50313
-BUGCR8729 WIN : http/tests/multipart/invalid-image-data.html = IMAGE+TEXT
+BUGCR8729 WIN RELEASE : http/tests/multipart/invalid-image-data.html = IMAGE+TEXT
+BUGWK72436 WIN DEBUG : http/tests/multipart/invalid-image-data.html = CRASH
 
 // -
 // MAC PORT TESTS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100356] trunk/Tools


2011-11-15

Thread
tony

Title: [100356] trunk/Tools








Revision 100356
Author t...@chromium.org
Date 2011-11-15 16:04:20 -0800 (Tue, 15 Nov 2011)


Log Message
Unreviewed, better fix for ref tests failures on SL Intel bot.
Revert the previous change and return None if pixel results from
either the test page or the expected page is missing.

* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (100355 => 100356)

--- trunk/Tools/ChangeLog	2011-11-16 00:02:33 UTC (rev 100355)
+++ trunk/Tools/ChangeLog	2011-11-16 00:04:20 UTC (rev 100356)
@@ -1,3 +1,12 @@
+2011-11-15  Tony Chang  
+
+Unreviewed, better fix for ref tests failures on SL Intel bot.
+Revert the previous change and return None if pixel results from
+either the test page or the expected page is missing.
+
+* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+
 2011-11-15  James Robinson  
 
 [chromium] Merge chromium-gpu layout test configurations into non-gpu versions


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py (100355 => 100356)

--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py	2011-11-16 00:02:33 UTC (rev 100355)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py	2011-11-16 00:04:20 UTC (rev 100356)
@@ -58,9 +58,7 @@
 writer.write_image_files(driver_output.image, expected_driver_output.image)
 elif isinstance(failure, test_failures.FailureImageHashMismatch):
 writer.write_image_files(driver_output.image, expected_driver_output.image)
-# FIXME: Why is image_diff a bool on SL bot?  Maybe ImageDiff isn't found?
-if driver_output.image_diff:
-writer.write_image_diff_files(str(driver_output.image_diff))
+writer.write_image_diff_files(driver_output.image_diff)
 elif isinstance(failure, (test_failures.FailureAudioMismatch,
   test_failures.FailureMissingAudio)):
 writer.write_audio_files(driver_output.audio, expected_driver_output.audio)


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (100355 => 100356)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2011-11-16 00:02:33 UTC (rev 100355)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2011-11-16 00:04:20 UTC (rev 100356)
@@ -163,7 +163,7 @@
 if not actual_contents or not expected_contents:
 # FIXME: It's not clear what we should return in this case.
 # Maybe we should throw an exception?
-return (True, 0)
+return (None, 0)
 
 process = self._start_image_diff_process(expected_contents, actual_contents)
 return self._read_image_diff(process)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100355] trunk


2011-11-15

Thread
jamesr

Title: [100355] trunk








Revision 100355
Author jam...@google.com
Date 2011-11-15 16:02:33 -0800 (Tue, 15 Nov 2011)


Log Message
[chromium] Merge chromium-gpu layout test configurations into non-gpu versions
https://bugs.webkit.org/show_bug.cgi?id=72402

Reviewed by Dirk Pranke.

Tools:

Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
the normal compositing triggers since we currently run the compositing tests in only one configuration - with
compositing enabled.

Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
patch should not impact any tests.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setAcceleratedCompositingForVideoEnabled):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

LayoutTests:

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.h
trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp
trunk/Tools/DumpRenderTree/chromium/WebPreferences.h
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py




Diff

Modified: trunk/LayoutTests/ChangeLog (100354 => 100355)

--- trunk/LayoutTests/ChangeLog	2011-11-15 23:54:51 UTC (rev 100354)
+++ trunk/LayoutTests/ChangeLog	2011-11-16 00:02:33 UTC (rev 100355)
@@ -1,3 +1,12 @@
+2011-11-15  James Robinson  
+
+[chromium] Merge chromium-gpu layout test configurations into non-gpu versions
+https://bugs.webkit.org/show_bug.cgi?id=72402
+
+Reviewed by Dirk Pranke.
+
+* platform/chromium/test_expectations.txt:
+
 2011-11-15  Peter Kasting  
 
 Mark a test as flakily failing.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100354 => 100355)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-15 23:54:51 UTC (rev 100354)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-16 00:02:33 UTC (rev 100355)
@@ -2732,7 +2732,7 @@
 
 BUGWK53868 : fast/notifications/notifications-document-close-crash.html = PASS TEXT
 
-BUGWK54051 MAC : plugins/invalidate_rect.html = TEXT
+BUGWK54051 MAC : compositing/plugins/invalidate_rect.html = TEXT
 BUGWK54051 MAC : plugins/windowless_plugin_paint_test.html = TIMEOUT
 
 // Snow Leopard-only failures (generally just need updated pixel results)
@@ -3878,6 +3878,16 @@
 
 BUG_SENORBLANCO GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT
 
+// Will need baselines updated to take compositing into account when that is enabled by default.
+// See bug for details
+BUGWK72402 : fast/media/mq-transform-03.html = PASS FAIL
+BUGWK72402 : transitions/default-timing-function.html = PASS FAIL
+BUGWK72402 : animations/missing-values-first-keyframe.html = PASS FAIL
+BUGWK72402 : fast/repaint/block-selection-gap-in-composited-layer.html = PASS FAIL
+BUGWK72402 : fast/media/mq-transform-02.html = PASS FAIL
+BUGWK72402 : animations/opacity-transform-animation.html = PASS FAIL
+BUGWK72402 : animations/missing-values-last-keyframe.html = PASS FAIL
+
 // Need to rebaseline on win and mac.
 BUG_TONY MAC : css3/flexbox/repaint.html = PASS FAIL
 BUG_TONY MAC : css3/flexbox/repaint-rtl-column.html = PASS FAIL
@@ -3927,4 +3937,4 @@
 
 BUGWK72376 WIN : fast/forms/file/input-file-label.html = TEXT PASS
 
-BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS
\ No newline at end of file
+BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS


Modified: trunk/Tools/ChangeLog (100354 => 100355)

--- trunk/Tools/ChangeLog	2011-11-15 23:54:51 UTC (rev 100354)
+++ trunk/Tools/ChangeLog	2011-11-16 00:02:33 UTC (rev 100355)
@@ -1,3 +1,35 @@
+2011-11-15  James Robinson  
+
+[chromium] Merge chromium-gpu layout test configurations into non-gpu versions
+https://bugs.webkit.org/show_bug.cgi?id=72402
+
+Reviewed 



[webkit-changes] [100354] trunk/LayoutTests


2011-11-15

Thread
pkasting

Title: [100354] trunk/LayoutTests








Revision 100354
Author pkast...@chromium.org
Date 2011-11-15 15:54:51 -0800 (Tue, 15 Nov 2011)


Log Message
Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=72434

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100353 => 100354)

--- trunk/LayoutTests/ChangeLog	2011-11-15 23:52:28 UTC (rev 100353)
+++ trunk/LayoutTests/ChangeLog	2011-11-15 23:54:51 UTC (rev 100354)
@@ -1,3 +1,12 @@
+2011-11-15  Peter Kasting  
+
+Mark a test as flakily failing.
+https://bugs.webkit.org/show_bug.cgi?id=72434
+
+Unreviewed, gardening.
+
+* platform/chromium/test_expectations.txt:
+
 2011-11-15  Tony Chang  
 
 Skip failing ref tests on Qt.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100353 => 100354)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-15 23:52:28 UTC (rev 100353)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-15 23:54:51 UTC (rev 100354)
@@ -3926,3 +3926,5 @@
 BUGWK59771 WIN : http/tests/inspector/resource-tree/resource-tree-frame-add.html = TIMEOUT PASS
 
 BUGWK72376 WIN : fast/forms/file/input-file-label.html = TEXT PASS
+
+BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100353] trunk/Source


2011-11-15

Thread
jochen

Title: [100353] trunk/Source








Revision 100353
Author joc...@chromium.org
Date 2011-11-15 15:52:28 -0800 (Tue, 15 Nov 2011)


Log Message
Rename ReferrerPolicy to clarify its meaning
https://bugs.webkit.org/show_bug.cgi?id=72420

Reviewed by Nate Chapin.

Source/WebCore:

On the one hand, even if the ReferrerPolicy was set to SendReferrer, the
referrer wasn't necessarily send. On the other hand, I want to use the
name ReferrerPolicy when implementing the meta referrer tag.

No change in behavior expected so no test.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
(WebCore::handleLinkClick):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::loadFrameRequest):
* loader/FrameLoader.h:
* loader/FrameLoaderTypes.h:
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):
* page/ContextMenuController.cpp:
(WebCore::openNewWindow):
(WebCore::ContextMenuController::contextMenuItemSelected):
* WebCore.exp.in: updated.

Source/WebKit/chromium:

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::loadFrameRequest):

Source/WebKit/mac:

* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(openNewWindow):
(QWebPage::triggerAction):

Source/WebKit/win:

* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::linkClicked):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/html/HTMLAnchorElement.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.h
trunk/Source/WebCore/loader/FrameLoaderTypes.h
trunk/Source/WebCore/loader/NavigationScheduler.cpp
trunk/Source/WebCore/page/ContextMenuController.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPDFView.mm
trunk/Source/WebKit/qt/Api/qwebpage.cpp
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (100352 => 100353)

--- trunk/Source/WebCore/ChangeLog	2011-11-15 23:50:57 UTC (rev 100352)
+++ trunk/Source/WebCore/ChangeLog	2011-11-15 23:52:28 UTC (rev 100353)
@@ -1,3 +1,33 @@
+2011-11-15  Jochen Eisinger  
+
+Rename ReferrerPolicy to clarify its meaning
+https://bugs.webkit.org/show_bug.cgi?id=72420
+
+Reviewed by Nate Chapin.
+
+On the one hand, even if the ReferrerPolicy was set to SendReferrer, the
+referrer wasn't necessarily send. On the other hand, I want to use the
+name ReferrerPolicy when implementing the meta referrer tag.
+
+No change in behavior expected so no test.
+
+* html/HTMLAnchorElement.cpp:
+(WebCore::HTMLAnchorElement::handleClick):
+(WebCore::handleLinkClick):
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::changeLocation):
+(WebCore::FrameLoader::urlSelected):
+(WebCore::FrameLoader::loadFrameRequest):
+* loader/FrameLoader.h:
+* loader/FrameLoaderTypes.h:
+* loader/NavigationScheduler.cpp:
+(WebCore::ScheduledHistoryNavigation::fire):
+(WebCore::ScheduledFormSubmission::fire):
+* page/ContextMenuController.cpp:
+(WebCore::openNewWindow):
+(WebCore::ContextMenuController::contextMenuItemSelected):
+* WebCore.exp.in: updated.
+
 2011-11-15  Adam Klein  
 
 Factor out V8Proxy's max recursion depth handling code


Modified: trunk/Source/WebCore/WebCore.exp.in (100352 => 100353)

--- trunk/Source/WebCore/WebCore.exp.in	2011-11-15 23:50:57 UTC (rev 100352)
+++ trunk/Source/WebCore/WebCore.exp.in	2011-11-15 23:52:28 UTC (rev 100353)
@@ -164,12 +164,12 @@
 __ZN7WebCore11FileChooserD1Ev
 __ZN7WebCore11FrameLoader11loadArchiveEN3WTF10PassRefPtrINS_7ArchiveEEE
 __ZN7WebCore11FrameLoader11shouldCloseEv
-__ZN7WebCore11FrameLoader11urlSelectedERKNS_4KURLERKN3WTF6StringENS4_10PassRefPtrINS_5EventEEEbbNS_14ReferrerPolicyE
+__ZN7WebCore11FrameLoader11urlSelectedERKNS_4KURLERKN3WTF6StringENS4_10PassRefPtrINS_5EventEEEbbNS_18ShouldSendReferrerE
 __ZN7WebCore11FrameLoader12shouldReloadERKNS_4KURLES3_
 __ZN7WebCore11FrameLoader14detachChildrenEv
 __ZN7WebCore11FrameLoader14stopAllLoadersENS_26ClearProvisionalItemPolicyE
 __ZN7WebCore11FrameLoader16detachFromParentEv
-__ZN7WebCore11FrameLoader16loadFrameRequestERKNS_16FrameLoadRequestEbbN3WTF10PassRefPt



[webkit-changes] [100352] trunk/Tools


2011-11-15

Thread
tony

Title: [100352] trunk/Tools








Revision 100352
Author t...@chromium.org
Date 2011-11-15 15:50:57 -0800 (Tue, 15 Nov 2011)


Log Message
Unreviewed, try to fix ref tests failures on SL Intel bot.
It looks like ImageDiff isn't returning an image diff.

* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py




Diff

Modified: trunk/Tools/ChangeLog (100351 => 100352)

--- trunk/Tools/ChangeLog	2011-11-15 23:46:55 UTC (rev 100351)
+++ trunk/Tools/ChangeLog	2011-11-15 23:50:57 UTC (rev 100352)
@@ -1,5 +1,12 @@
 2011-11-15  Tony Chang  
 
+Unreviewed, try to fix ref tests failures on SL Intel bot.
+It looks like ImageDiff isn't returning an image diff.
+
+* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
+
+2011-11-15  Tony Chang  
+
 Unreviewed fix of ref-tests on GTK+.
 If a driver is never started, _xvfb_process is never set.
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py (100351 => 100352)

--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py	2011-11-15 23:46:55 UTC (rev 100351)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py	2011-11-15 23:50:57 UTC (rev 100352)
@@ -58,7 +58,9 @@
 writer.write_image_files(driver_output.image, expected_driver_output.image)
 elif isinstance(failure, test_failures.FailureImageHashMismatch):
 writer.write_image_files(driver_output.image, expected_driver_output.image)
-writer.write_image_diff_files(driver_output.image_diff)
+# FIXME: Why is image_diff a bool on SL bot?  Maybe ImageDiff isn't found?
+if driver_output.image_diff:
+writer.write_image_diff_files(str(driver_output.image_diff))
 elif isinstance(failure, (test_failures.FailureAudioMismatch,
   test_failures.FailureMissingAudio)):
 writer.write_audio_files(driver_output.audio, expected_driver_output.audio)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100350] trunk/Tools


2011-11-15

Thread
tony

Title: [100350] trunk/Tools








Revision 100350
Author t...@chromium.org
Date 2011-11-15 15:41:53 -0800 (Tue, 15 Nov 2011)


Log Message
Unreviewed fix of ref-tests on GTK+.
If a driver is never started, _xvfb_process is never set.

* Scripts/webkitpy/layout_tests/port/gtk.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py




Diff

Modified: trunk/Tools/ChangeLog (100349 => 100350)

--- trunk/Tools/ChangeLog	2011-11-15 23:40:57 UTC (rev 100349)
+++ trunk/Tools/ChangeLog	2011-11-15 23:41:53 UTC (rev 100350)
@@ -1,3 +1,10 @@
+2011-11-15  Tony Chang  
+
+Unreviewed fix of ref-tests on GTK+.
+If a driver is never started, _xvfb_process is never set.
+
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+
 2011-11-14  Tony Chang  
 
 [NRWT] Reftests should run even when pixel tests are disabled.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (100349 => 100350)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2011-11-15 23:40:57 UTC (rev 100349)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2011-11-15 23:41:53 UTC (rev 100350)
@@ -57,9 +57,10 @@
 
 def stop(self):
 WebKitDriver.stop(self)
-# FIXME: This should use Executive.kill_process
-os.kill(self._xvfb_process.pid, signal.SIGTERM)
-self._xvfb_process.wait()
+if getattr(self, '_xvfb_process', None):
+# FIXME: This should use Executive.kill_process
+os.kill(self._xvfb_process.pid, signal.SIGTERM)
+self._xvfb_process.wait()
 
 
 class GtkPort(WebKitPort):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100349] trunk/Websites/bugs.webkit.org


2011-11-15

Thread
tony

Title: [100349] trunk/Websites/bugs.webkit.org








Revision 100349
Author t...@chromium.org
Date 2011-11-15 15:40:57 -0800 (Tue, 15 Nov 2011)


Log Message
set a max-width on the codereview overall comments textarea
https://bugs.webkit.org/show_bug.cgi?id=72415

Reviewed by Ojan Vafai.

Otherwise, when resizing the textarea you can end up making wider, but
are no longer able to click the resize gripper to make it smaller
(it's under another div).

* PrettyPatch/PrettyPatch.rb:

Modified Paths

trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb




Diff

Modified: trunk/Websites/bugs.webkit.org/ChangeLog (100348 => 100349)

--- trunk/Websites/bugs.webkit.org/ChangeLog	2011-11-15 23:36:52 UTC (rev 100348)
+++ trunk/Websites/bugs.webkit.org/ChangeLog	2011-11-15 23:40:57 UTC (rev 100349)
@@ -1,3 +1,16 @@
+2011-11-15  Tony Chang  
+
+set a max-width on the codereview overall comments textarea
+https://bugs.webkit.org/show_bug.cgi?id=72415
+
+Reviewed by Ojan Vafai.
+
+Otherwise, when resizing the textarea you can end up making wider, but
+are no longer able to click the resize gripper to make it smaller
+(it's under another div).
+
+* PrettyPatch/PrettyPatch.rb:
+
 2011-10-13  Adam Barth  
 
 Would be nice if the review-tool offered to show the corresponding header


Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (100348 => 100349)

--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb	2011-11-15 23:36:52 UTC (rev 100348)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb	2011-11-15 23:40:57 UTC (rev 100349)
@@ -272,6 +272,7 @@
 
 .overallComments textarea {
   height: 2em;
+  max-width: 100%;
 }
 
 .comment textarea, .overallComments textarea {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100348]	branches/safari-534.53-branch/Source/WebCore/ChangeLog


2011-11-15

Thread
lforschler

Title: [100348] branches/safari-534.53-branch/Source/WebCore/ChangeLog








Revision 100348
Author lforsch...@apple.com
Date 2011-11-15 15:36:52 -0800 (Tue, 15 Nov 2011)


Log Message
rollout unneeded merge of 91147.

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100347 => 100348)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 23:34:04 UTC (rev 100347)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 23:36:52 UTC (rev 100348)
@@ -1,16 +1,5 @@
 2011-11-15  Lucas Forschler  
 
-Merge 91147
-
-2011-07-15  Simon Fraser  
-
-Fix the build.
-
-* platform/mac/ScrollbarThemeMac.mm:
-(WebCore::ScrollbarThemeMac::updateEnabledState):
-
-2011-11-15  Lucas Forschler  
-
 Merge 91140
 
 2011-07-15  Simon Fraser  






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100347] trunk/Source/WebCore


2011-11-15

Thread
adamk

Title: [100347] trunk/Source/WebCore








Revision 100347
Author ad...@chromium.org
Date 2011-11-15 15:34:04 -0800 (Tue, 15 Nov 2011)


Log Message
Factor out V8Proxy's max recursion depth handling code
https://bugs.webkit.org/show_bug.cgi?id=72422

Reviewed by Nate Chapin.

Previously, V8Proxy used slightly different code to handle stack limit
violations depending on whether they occured in runScript or
callFunction. As described in http://webkit.org/b/72063, I intend to
expand the usage of m_recursion when calling into script. This patch
is intended to unify the existing handling code, making it easier to
move elsewhere without causing unintended side-effects.

No tests changed, as the only change in behavior is the string passed
to RangeError in the runScript case, and it's not mentioned anywhere
in the LayoutTests.

* bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::runScript): Use callFunction's factored-out code.
(WebCore::V8Proxy::callFunction): Simplify and factor out code into handleMaxRecursionDepthExceeded.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (100346 => 100347)

--- trunk/Source/WebCore/ChangeLog	2011-11-15 23:29:19 UTC (rev 100346)
+++ trunk/Source/WebCore/ChangeLog	2011-11-15 23:34:04 UTC (rev 100347)
@@ -1,3 +1,26 @@
+2011-11-15  Adam Klein  
+
+Factor out V8Proxy's max recursion depth handling code
+https://bugs.webkit.org/show_bug.cgi?id=72422
+
+Reviewed by Nate Chapin.
+
+Previously, V8Proxy used slightly different code to handle stack limit
+violations depending on whether they occured in runScript or
+callFunction. As described in http://webkit.org/b/72063, I intend to
+expand the usage of m_recursion when calling into script. This patch
+is intended to unify the existing handling code, making it easier to
+move elsewhere without causing unintended side-effects.
+
+No tests changed, as the only change in behavior is the string passed
+to RangeError in the runScript case, and it's not mentioned anywhere
+in the LayoutTests.
+
+* bindings/v8/V8Proxy.cpp:
+(WebCore::handleMaxRecursionDepthExceeded):
+(WebCore::V8Proxy::runScript): Use callFunction's factored-out code.
+(WebCore::V8Proxy::callFunction): Simplify and factor out code into handleMaxRecursionDepthExceeded.
+
 2011-11-15  Jessie Berlin  
 
 NSURLRequest leak beneath ResourceRequest::setStorageSession seen on Leaks bot.


Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.cpp (100346 => 100347)

--- trunk/Source/WebCore/bindings/v8/V8Proxy.cpp	2011-11-15 23:29:19 UTC (rev 100346)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.cpp	2011-11-15 23:34:04 UTC (rev 100347)
@@ -175,6 +175,14 @@
 CRASH();
 }
 
+static v8::Local handleMaxRecursionDepthExceeded()
+{
+v8::Local code = v8::String::New("throw new RangeError('Maximum call stack size exceeded.')");
+v8::Local script = v8::Script::Compile(code);
+script->Run();
+return v8::Local();
+}
+
 V8Proxy::V8Proxy(Frame* frame)
 : m_frame(frame)
 , m_windowShell(V8DOMWindowShell::create(frame))
@@ -384,21 +392,12 @@
 return notHandledByInterceptor();
 
 V8GCController::checkMemoryUsage();
-// Compute the source string and prevent against infinite recursion.
-if (m_recursion >= kMaxRecursionDepth) {
-v8::Local code = v8ExternalString("throw RangeError('Recursion too deep')");
-// FIXME: Ideally, we should be able to re-use the origin of the
-// script passed to us as the argument instead of using an empty string
-// and 0 baseLine.
-script = compileScript(code, "", TextPosition::minimumPosition());
-}
+if (m_recursion >= kMaxRecursionDepth)
+return handleMaxRecursionDepthExceeded();
 
 if (handleOutOfMemory())
 ASSERT(script.IsEmpty());
 
-if (script.IsEmpty())
-return notHandledByInterceptor();
-
 // Save the previous value of the inlineCode flag and update the flag for
 // the duration of the script invocation.
 bool previousInlineCode = inlineCode();
@@ -445,22 +444,14 @@
 {
 V8GCController::checkMemoryUsage();
 
+if (m_recursion >= kMaxRecursionDepth)
+return handleMaxRecursionDepthExceeded();
+
 // Keep Frame (and therefore ScriptController and V8Proxy) alive.
 RefPtr protect(frame());
 
 v8::Local result;
 {
-if (m_recursion >= kMaxRecursionDepth) {
-v8::Local code = v8::String::New("throw new RangeError('Maximum call stack size exceeded.')");
-if (code.IsEmpty())
-return result;
-v8::Local script = v8::Script::Compile(code);
-if (script.IsEmpty())
-return result;
-script->Run();
-return result;
-}
-
 m_recursio



[webkit-changes] [100346] trunk/LayoutTests


2011-11-15

Thread
tony

Title: [100346] trunk/LayoutTests








Revision 100346
Author t...@chromium.org
Date 2011-11-15 15:29:19 -0800 (Tue, 15 Nov 2011)


Log Message
Skip failing ref tests on Qt.

* platform/qt/Skipped: editing/pasteboard/data-transfer-items-image-png.html and
fast/forms/file/file-input-reset.html are failing. See bugs.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (100345 => 100346)

--- trunk/LayoutTests/ChangeLog	2011-11-15 23:27:10 UTC (rev 100345)
+++ trunk/LayoutTests/ChangeLog	2011-11-15 23:29:19 UTC (rev 100346)
@@ -1,3 +1,10 @@
+2011-11-15  Tony Chang  
+
+Skip failing ref tests on Qt.
+
+* platform/qt/Skipped: editing/pasteboard/data-transfer-items-image-png.html and
+fast/forms/file/file-input-reset.html are failing. See bugs.
+
 2011-11-15  Peter Kasting  
 
 Mark another test as flakily crashing.


Modified: trunk/LayoutTests/platform/qt/Skipped (100345 => 100346)

--- trunk/LayoutTests/platform/qt/Skipped	2011-11-15 23:27:10 UTC (rev 100345)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-11-15 23:29:19 UTC (rev 100346)
@@ -2474,3 +2474,11 @@
 # https://bugs.webkit.org/show_bug.cgi?id=72364
 http/tests/security/cross-frame-access-enumeration.html
 http/tests/security/postMessage/invalid-origin-throws-exception.html
+
+# [Qt] editing/pasteboard/data-transfer-items-image-png.html is failing due to DataTransferItems for image/png not being implemented
+# https://bugs.webkit.org/show_bug.cgi?id=72430
+editing/pasteboard/data-transfer-items-image-png.html
+
+# [Qt] fast/forms/file/file-input-reset.html failing on Qt
+# https://bugs.webkit.org/show_bug.cgi?id=72429
+fast/forms/file/file-input-reset.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100345] trunk/Source/WebKit2


2011-11-15

Thread
weinig

Title: [100345] trunk/Source/WebKit2








Revision 100345
Author wei...@apple.com
Date 2011-11-15 15:27:10 -0800 (Tue, 15 Nov 2011)


Log Message
Fix windows build.

* win/WebKit2Generated.make:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2Generated.make




Diff

Modified: trunk/Source/WebKit2/ChangeLog (100344 => 100345)

--- trunk/Source/WebKit2/ChangeLog	2011-11-15 23:23:32 UTC (rev 100344)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-15 23:27:10 UTC (rev 100345)
@@ -1,5 +1,11 @@
 2011-11-15  Sam Weinig  
 
+Fix windows build.
+
+* win/WebKit2Generated.make:
+
+2011-11-15  Sam Weinig  
+
 Add WebKit2 API object to represent a connection
 https://bugs.webkit.org/show_bug.cgi?id=72421
 


Modified: trunk/Source/WebKit2/win/WebKit2Generated.make (100344 => 100345)

--- trunk/Source/WebKit2/win/WebKit2Generated.make	2011-11-15 23:23:32 UTC (rev 100344)
+++ trunk/Source/WebKit2/win/WebKit2Generated.make	2011-11-15 23:27:10 UTC (rev 100345)
@@ -18,6 +18,7 @@
 xcopy /y /d "..\Shared\API\c\win\WKCertificateInfoWin.h" "%ConfigurationBuildDir%\include\WebKit2"
 xcopy /y /d "..\Shared\API\c\WKArray.h" "%ConfigurationBuildDir%\include\WebKit2"
 xcopy /y /d "..\Shared\API\c\WKBase.h" "%ConfigurationBuildDir%\include\WebKit2"
+xcopy /y /d "..\Shared\API\c\WKConnectionRef.h" "%ConfigurationBuildDir%\include\WebKit2"
 xcopy /y /d "..\Shared\API\c\WKCertificateInfo.h" "%ConfigurationBuildDir%\include\WebKit2"
 xcopy /y /d "..\Shared\API\C\WKContextMenuItem.h" "%ConfigurationBuildDir%\include\WebKit2"
 xcopy /y /d "..\Shared\API\C\WKContextMenuItemTypes.h" "%ConfigurationBuildDir%\include\WebKit2"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100344] trunk/LayoutTests


2011-11-15

Thread
pkasting

Title: [100344] trunk/LayoutTests








Revision 100344
Author pkast...@chromium.org
Date 2011-11-15 15:23:32 -0800 (Tue, 15 Nov 2011)


Log Message
Mark another test as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=59552

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100343 => 100344)

--- trunk/LayoutTests/ChangeLog	2011-11-15 23:21:53 UTC (rev 100343)
+++ trunk/LayoutTests/ChangeLog	2011-11-15 23:23:32 UTC (rev 100344)
@@ -1,3 +1,12 @@
+2011-11-15  Peter Kasting  
+
+Mark another test as flakily crashing.
+https://bugs.webkit.org/show_bug.cgi?id=59552
+
+Unreviewed, gardening.
+
+* platform/chromium/test_expectations.txt:
+
 2011-11-15  Julien Chaffraix  
 
 Add the needed plumbing to parse display: -webkit-grid


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100343 => 100344)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-15 23:21:53 UTC (rev 100343)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-15 23:23:32 UTC (rev 100344)
@@ -3838,12 +3838,14 @@
 BUGWK71653 : platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html = PASS TIMEOUT
 
 // Intermittent assertion failures on snowleopard bots.
-BUGWK59552 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH
 BUGWK59552 SNOWLEOPARD DEBUG : fast/dom/Element/id-in-frame.html = PASS CRASH
+BUGWK59552 SNOWLEOPARD DEBUG : fast/dom/image-object.html = PASS CRASH
 BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/content-opacity-2.html = PASS CRASH
-BUGWK59552 SNOWLEOPARD DEBUG : fast/parser/close-while-stopping.html = PASS CRASH
 BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/iframe-double-scale-contents.html = PASS CRASH
 BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/set-parent-src-synchronously.html = PASS CRASH
+BUGWK59552 SNOWLEOPARD DEBUG : fast/parser/close-while-stopping.html = PASS CRASH
+BUGWK59552 SNOWLEOPARD DEBUG : http/tests/security/cross-frame-access-custom.html = PASS CRASH
+BUGWK59552 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH
 
 // Introduced due to BUGWK53512, fails under Skia right now
 BUGWK65939 : svg/custom/getBBox-path.svg = TEXT
@@ -3885,8 +3887,6 @@
 BUGV8_1821 WIN LINUX : http/tests/inspector-enabled/dedicated-workers-list.html = PASS CRASH
 BUGWK72133 SKIP MAC : http/tests/inspector-enabled/dedicated-workers-list.html = PASS CRASH TIMEOUT
 
-BUGWK59552 MAC DEBUG : http/tests/security/cross-frame-access-custom.html = PASS CRASH
-
 // use Skia to draw vertical text directly instead of text-on-path
 BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-backward-br.html = IMAGE
 BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-forward-br.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100343] trunk/Source/WebCore


2011-11-15

Thread
jberlin

Title: [100343] trunk/Source/WebCore








Revision 100343
Author jber...@webkit.org
Date 2011-11-15 15:21:53 -0800 (Tue, 15 Nov 2011)


Log Message
NSURLRequest leak beneath ResourceRequest::setStorageSession seen on Leaks bot.
https://bugs.webkit.org/show_bug.cgi?id=72419

Reviewed by Adam Roben.

Adopt the copied NSURLRequest.

* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::setStorageSession):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (100342 => 100343)

--- trunk/Source/WebCore/ChangeLog	2011-11-15 23:09:54 UTC (rev 100342)
+++ trunk/Source/WebCore/ChangeLog	2011-11-15 23:21:53 UTC (rev 100343)
@@ -1,3 +1,15 @@
+2011-11-15  Jessie Berlin  
+
+NSURLRequest leak beneath ResourceRequest::setStorageSession seen on Leaks bot.
+https://bugs.webkit.org/show_bug.cgi?id=72419
+
+Reviewed by Adam Roben.
+
+Adopt the copied NSURLRequest.
+
+* platform/network/mac/ResourceRequestMac.mm:
+(WebCore::ResourceRequest::setStorageSession):
+
 2011-11-15  John Bates  
 
 Page/layer flashes after GPU-accelerated CSS transition


Modified: trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm (100342 => 100343)

--- trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm	2011-11-15 23:09:54 UTC (rev 100342)
+++ trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm	2011-11-15 23:21:53 UTC (rev 100343)
@@ -186,7 +186,7 @@
 
 void ResourceRequest::setStorageSession(CFURLStorageSessionRef storageSession)
 {
-m_nsRequest = wkCopyRequestWithStorageSession(storageSession, m_nsRequest.get());
+m_nsRequest.adoptNS(wkCopyRequestWithStorageSession(storageSession, m_nsRequest.get()));
 }
 
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100342]	branches/safari-534.53-branch/Source/WebCore/ChangeLog


2011-11-15

Thread
lforschler

Title: [100342] branches/safari-534.53-branch/Source/WebCore/ChangeLog








Revision 100342
Author lforsch...@apple.com
Date 2011-11-15 15:09:54 -0800 (Tue, 15 Nov 2011)


Log Message
Merged r91147.

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100341 => 100342)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 23:08:28 UTC (rev 100341)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 23:09:54 UTC (rev 100342)
@@ -1,5 +1,16 @@
 2011-11-15  Lucas Forschler  
 
+Merge 91147
+
+2011-07-15  Simon Fraser  
+
+Fix the build.
+
+* platform/mac/ScrollbarThemeMac.mm:
+(WebCore::ScrollbarThemeMac::updateEnabledState):
+
+2011-11-15  Lucas Forschler  
+
 Merge 91140
 
 2011-07-15  Simon Fraser  






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100341]	branches/safari-534.53-branch/Source/WebKit/win


2011-11-15

Thread
lforschler

Title: [100341] branches/safari-534.53-branch/Source/WebKit/win








Revision 100341
Author lforsch...@apple.com
Date 2011-11-15 15:08:28 -0800 (Tue, 15 Nov 2011)


Log Message
Merged r91145.

Modified Paths

branches/safari-534.53-branch/Source/WebKit/win/ChangeLog
branches/safari-534.53-branch/Source/WebKit/win/WebView.h




Diff

Modified: branches/safari-534.53-branch/Source/WebKit/win/ChangeLog (100340 => 100341)

--- branches/safari-534.53-branch/Source/WebKit/win/ChangeLog	2011-11-15 23:07:48 UTC (rev 100340)
+++ branches/safari-534.53-branch/Source/WebKit/win/ChangeLog	2011-11-15 23:08:28 UTC (rev 100341)
@@ -1,3 +1,15 @@
+2011-11-15  Lucas Forschler  
+
+Merge 91145
+
+2011-07-15  Simon Fraser  
+
+Fix Windows build.
+
+* WebView.h:
+(WebView::backingScaleFactor):
+(WebView::pageScaleFactor):
+
 2011-08-11  Lucas Forschler  
 
 Merged 91097


Modified: branches/safari-534.53-branch/Source/WebKit/win/WebView.h (100340 => 100341)

--- branches/safari-534.53-branch/Source/WebKit/win/WebView.h	2011-11-15 23:07:48 UTC (rev 100340)
+++ branches/safari-534.53-branch/Source/WebKit/win/WebView.h	2011-11-15 23:08:28 UTC (rev 100341)
@@ -992,6 +992,8 @@
 virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time);
 virtual void notifySyncRequired(const WebCore::GraphicsLayer*);
 virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
+virtual float backingScaleFactor() const { return 1; }
+virtual float pageScaleFactor() const { return 1; }
 virtual bool showDebugBorders() const;
 virtual bool showRepaintCounter() const;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100340] trunk/Source


2011-11-15

Thread
commit-queue

Title: [100340] trunk/Source








Revision 100340
Author commit-qu...@webkit.org
Date 2011-11-15 15:07:48 -0800 (Tue, 15 Nov 2011)


Log Message
Page/layer flashes after GPU-accelerated CSS transition
https://bugs.webkit.org/show_bug.cgi?id=72343

LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.

Patch by John Bates  on 2011-11-15
Reviewed by James Robinson.

New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (100339 => 100340)

--- trunk/Source/WebCore/ChangeLog	2011-11-15 23:07:28 UTC (rev 100339)
+++ trunk/Source/WebCore/ChangeLog	2011-11-15 23:07:48 UTC (rev 100340)
@@ -1,3 +1,25 @@
+2011-11-15  John Bates  
+
+Page/layer flashes after GPU-accelerated CSS transition
+https://bugs.webkit.org/show_bug.cgi?id=72343
+
+LayerRendererChromium was resizing the window to 1x1 at initialization.
+In some cases, there is no drawLayers before switching back to
+software rendering. This left the window resized to 1x1 and the
+following software paints would therefore not be visible. This change
+moves the reshape call into drawLayers so that it will only be called
+if rendering will occur.
+
+Reviewed by James Robinson.
+
+New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::viewportChanged):
+(WebCore::LayerRendererChromium::doViewportChanged):
+(WebCore::LayerRendererChromium::drawLayersInternal):
+* platform/graphics/chromium/LayerRendererChromium.h:
+
 2011-11-15  Julien Chaffraix  
 
 Add the needed plumbing to parse display: -webkit-grid


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (100339 => 100340)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2011-11-15 23:07:28 UTC (rev 100339)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2011-11-15 23:07:48 UTC (rev 100340)
@@ -175,6 +175,7 @@
 , m_context(context)
 , m_defaultRenderSurface(0)
 , m_sharedGeometryQuad(FloatRect(-0.5f, -0.5f, 1.0f, 1.0f))
+, m_isViewportChanged(false)
 {
 }
 
@@ -276,8 +277,7 @@
 
 void LayerRendererChromium::viewportChanged()
 {
-if (m_context)
-m_context->reshape(std::max(1, viewportWidth()), std::max(1, viewportHeight()));
+m_isViewportChanged = true;
 
 // Reset the current render surface to force an update of the viewport and
 // projection matrix next time useRenderSurface is called.
@@ -353,6 +353,14 @@
 return;
 
 TRACE_EVENT("LayerRendererChromium::drawLayers", this, 0);
+if (m_isViewportChanged) {
+// Only reshape when we know we are going to draw. Otherwise, the reshape
+// can leave the window at the wrong size if we never draw and the proper
+// viewport size is never set.
+m_isViewportChanged = false;
+m_context->reshape(viewportWidth(), viewportHeight());
+}
+
 CCLayerImpl* rootDrawLayer = rootLayer();
 makeContextCurrent();
 


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h (100339 => 100340)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h	2011-11-15 23:07:28 UTC (rev 100339)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h	2011-11-15 23:07:48 UTC (rev 100340)
@@ -231,6 +231,8 @@
 CCLayerSorter m_layerSorter;
 
 FloatQuad m_sharedGeometryQuad;
+
+bool m_isViewportChanged;
 };
 
 // Setting DEBUG_GL_CALLS to 1 will call glGetError() after almost every GL


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (100339 => 100340)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp	2011-11-15 23:07:28 UTC (rev 100339)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp	2011-11-15 23:07:48 UTC (rev 100340)
@@ -292,5 +292,45 @@
 EXPECT_TRUE(layer2->drawn());
 }
 
+class ReshapeTrackerContext: public MockWebGraphicsContext3D {
+public:
+ReshapeTracke



[webkit-changes] [100339]	branches/safari-534.53-branch/Source/WebCore


2011-11-15

Thread
lforschler

Title: [100339] branches/safari-534.53-branch/Source/WebCore








Revision 100339
Author lforsch...@apple.com
Date 2011-11-15 15:07:28 -0800 (Tue, 15 Nov 2011)


Log Message
Merged r91140.

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayerClient.h




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100338 => 100339)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 23:05:28 UTC (rev 100338)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 23:07:28 UTC (rev 100339)
@@ -1,5 +1,16 @@
 2011-11-15  Lucas Forschler  
 
+Merge 91140
+
+2011-07-15  Simon Fraser  
+
+Another Windows build fix; make this method non-pure virtual.
+
+* platform/graphics/GraphicsLayerClient.h:
+(WebCore::GraphicsLayerClient::didCommitChangesForLayer):
+
+2011-11-15  Lucas Forschler  
+
 Merge 91138
 
 2011-07-15  Simon Fraser  


Modified: branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayerClient.h (100338 => 100339)

--- branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayerClient.h	2011-11-15 23:05:28 UTC (rev 100338)
+++ branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayerClient.h	2011-11-15 23:07:28 UTC (rev 100339)
@@ -62,7 +62,7 @@
 virtual void notifySyncRequired(const GraphicsLayer*) = 0;
 
 virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const IntRect& inClip) = 0;
-virtual void didCommitChangesForLayer(const GraphicsLayer*) const = 0;
+virtual void didCommitChangesForLayer(const GraphicsLayer*) const { }
 
 // Multiplier for backing store size, related to high DPI.
 virtual float backingScaleFactor() const = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100338] trunk


2011-11-15

Thread
jchaffraix

Title: [100338] trunk








Revision 100338
Author jchaffr...@webkit.org
Date 2011-11-15 15:05:28 -0800 (Tue, 15 Nov 2011)


Log Message
Add the needed plumbing to parse display: -webkit-grid
https://bugs.webkit.org/show_bug.cgi?id=72331

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added parsing support for display: -webkit-grid. From a rendering perspective,
the value is equivalent to display: none until we properly implement it.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyleConstants.h:
Added the new CSS value and plumbed the parsing and style application of
the new value.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EDisplay):
Added an ASSERT here as I bumped into some non-trivial issues due to bug 72296.
-wap-marquee was offsetting the new value and was wrongly casted by the CSSPrimitiveValueMapping
logic outside the EDisplay range which would lead to crashes.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
Fixed the indentation to follow our coding rules.

LayoutTests:

* fast/css-grid-layout/display-grid-set-get-expected.txt: Added.
* fast/css-grid-layout/display-grid-set-get.html: Added.
* fast/css-grid-layout/resources/display-grid-set-get.js: Added.
Test that setting the display to -webkit-grid (from JS or CSS) works
and we get the right value back.

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
SKIP the css-grid-layout tests on all platforms for now.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/efl/Skipped
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h


Added Paths

trunk/LayoutTests/fast/css-grid-layout/
trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt
trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get.html
trunk/LayoutTests/fast/css-grid-layout/resources/
trunk/LayoutTests/fast/css-grid-layout/resources/display-grid-set-get.js




Diff

Modified: trunk/LayoutTests/ChangeLog (100337 => 100338)

--- trunk/LayoutTests/ChangeLog	2011-11-15 23:01:13 UTC (rev 100337)
+++ trunk/LayoutTests/ChangeLog	2011-11-15 23:05:28 UTC (rev 100338)
@@ -1,3 +1,25 @@
+2011-11-15  Julien Chaffraix  
+
+Add the needed plumbing to parse display: -webkit-grid
+https://bugs.webkit.org/show_bug.cgi?id=72331
+
+Reviewed by Tony Chang.
+
+* fast/css-grid-layout/display-grid-set-get-expected.txt: Added.
+* fast/css-grid-layout/display-grid-set-get.html: Added.
+* fast/css-grid-layout/resources/display-grid-set-get.js: Added.
+Test that setting the display to -webkit-grid (from JS or CSS) works
+and we get the right value back.
+
+* platform/chromium/test_expectations.txt:
+* platform/efl/Skipped:
+* platform/gtk/Skipped:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+* platform/wincairo/Skipped:
+SKIP the css-grid-layout tests on all platforms for now.
+
 2011-11-15  James Robinson  
 
 https://bugs.webkit.org/show_bug.cgi?id=72402


Added: trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt (0 => 100338)

--- trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt	2011-11-15 23:05:28 UTC (rev 100338)
@@ -0,0 +1,15 @@
+Test that setting and getting display: grid works as expected
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Test getting |display| set through CSS
+PASS getComputedStyle(gridElement, '').getPropertyValue('display') is '-webkit-grid'
+
+Test getting and setting display through JS
+PASS getComputedStyle(element, '').getPropertyValue('display') is 'block'
+PASS getComputedStyle(element, '').getPropertyValue('display') is '-webkit-grid'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get.



[webkit-changes] [100336] trunk/Source/WebKit2


2011-11-15

Thread
weinig

Title: [100336] trunk/Source/WebKit2








Revision 100336
Author wei...@apple.com
Date 2011-11-15 15:01:06 -0800 (Tue, 15 Nov 2011)


Log Message
Add WebKit2 API object to represent a connection
https://bugs.webkit.org/show_bug.cgi?id=72421

Reviewed by Anders Carlsson.

* GNUmakefile.am:
* Target.pri:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.

* Shared/API/c/WKBase.h:
Add type.

* Shared/API/c/WKConnectionRef.cpp: Added.
(WKConnectionGetTypeID):
(WKConnectionSetConnectionClient):
(WKConnectionPostMessage):
* Shared/API/c/WKConnectionRef.h: Added.
Expose interface. Currently no support for synchronous messages.

* Shared/API/c/WKSharedAPICast.h:
Define relationship between WebConnection <-> WKConnectionRef.

* Shared/APIObject.h:
Add API type.

* Shared/WebConnection.cpp: Added.
(WebKit::WebConnection::~WebConnection):
(WebKit::WebConnection::initializeConnectionClient):
* Shared/WebConnection.h: Added.
(WebKit::WebConnection::type):
Sketch out the connection object. It is currently abstract
to allow different implementations for the UI and WebProcess sides
while retaining the same interface.

* Shared/WebConnectionClient.cpp: Added.
(WebKit::WebConnectionClient::didReceiveMessage):
(WebKit::WebConnectionClient::didClose):
* Shared/WebConnectionClient.h: Added.
Add simple client.

* UIProcess/API/C/WebKit2.h:
Add new file.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/Shared/API/c/WKBase.h
trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h
trunk/Source/WebKit2/Shared/APIObject.h
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/API/C/WebKit2.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/win/WebKit2.vcproj


Added Paths

trunk/Source/WebKit2/Shared/API/c/WKConnectionRef.cpp
trunk/Source/WebKit2/Shared/API/c/WKConnectionRef.h
trunk/Source/WebKit2/Shared/WebConnection.cpp
trunk/Source/WebKit2/Shared/WebConnection.h
trunk/Source/WebKit2/Shared/WebConnectionClient.cpp
trunk/Source/WebKit2/Shared/WebConnectionClient.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (100335 => 100336)

--- trunk/Source/WebKit2/ChangeLog	2011-11-15 23:00:44 UTC (rev 100335)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-15 23:01:06 UTC (rev 100336)
@@ -1,3 +1,50 @@
+2011-11-15  Sam Weinig  
+
+Add WebKit2 API object to represent a connection
+https://bugs.webkit.org/show_bug.cgi?id=72421
+
+Reviewed by Anders Carlsson.
+
+* GNUmakefile.am:
+* Target.pri:
+* WebKit2.xcodeproj/project.pbxproj:
+* win/WebKit2.vcproj:
+Add new files.
+
+* Shared/API/c/WKBase.h:
+Add type.
+
+* Shared/API/c/WKConnectionRef.cpp: Added.
+(WKConnectionGetTypeID):
+(WKConnectionSetConnectionClient):
+(WKConnectionPostMessage):
+* Shared/API/c/WKConnectionRef.h: Added.
+Expose interface. Currently no support for synchronous messages.
+
+* Shared/API/c/WKSharedAPICast.h:
+Define relationship between WebConnection <-> WKConnectionRef.
+
+* Shared/APIObject.h:
+Add API type.
+
+* Shared/WebConnection.cpp: Added.
+(WebKit::WebConnection::~WebConnection):
+(WebKit::WebConnection::initializeConnectionClient):
+* Shared/WebConnection.h: Added.
+(WebKit::WebConnection::type):
+Sketch out the connection object. It is currently abstract
+to allow different implementations for the UI and WebProcess sides
+while retaining the same interface.
+
+* Shared/WebConnectionClient.cpp: Added.
+(WebKit::WebConnectionClient::didReceiveMessage):
+(WebKit::WebConnectionClient::didClose):
+* Shared/WebConnectionClient.h: Added.
+Add simple client.
+
+* UIProcess/API/C/WebKit2.h:
+Add new file.
+
 2011-11-15  Chris Fleizach2  
 
 AX: WKAccessibilityWebObjectPage should not call super in accessibilityAttributeValue:


Modified: trunk/Source/WebKit2/GNUmakefile.am (100335 => 100336)

--- trunk/Source/WebKit2/GNUmakefile.am	2011-11-15 23:00:44 UTC (rev 100335)
+++ trunk/Source/WebKit2/GNUmakefile.am	2011-11-15 23:01:06 UTC (rev 100336)
@@ -4,6 +4,7 @@
 	$(WebKit2)/Shared/API/c/WKArray.h \
 	$(WebKit2)/Shared/API/c/WKBase.h \
 	$(WebKit2)/Shared/API/c/WKCertificateInfo.h \
+	$(WebKit2)/Shared/API/c/WKConnectionRef.h \
 	$(WebKit2)/Shared/API/c/WKContextMenuItem.h \
 	$(WebKit2)/Shared/API/c/WKContextMenuItemTypes.h \
 	$(WebKit2)/Shared/API/c/WKData.h \
@@ -240,6 +241,8 @@
 	Source/WebKit2/Shared/API/c/WKBase.h \
 	Source/WebKit2/Shared/API/c/WKCertificateInfo.cpp \
 	Source/WebKit2/Shared/API/c/WKCertificateInfo.h \
+	Source/WebKit2/Shared/API/c/WKConnectionRef.cpp \
+	Source/WebKit2/Shared/API/c/WKConnectionRef.h \
 	Source/WebKit2/Shared/API/c/WKContextMenuItem.cpp \
 	Source/WebKit2/Shared/API/c/WKContextMenuItem.h \
 	Source/WebKit2/Shared/API/c/WKContextMenuItem



[webkit-changes] [100335]	branches/safari-534.53-branch/Source/WebCore


2011-11-15

Thread
lforschler

Title: [100335] branches/safari-534.53-branch/Source/WebCore








Revision 100335
Author lforsch...@apple.com
Date 2011-11-15 15:00:44 -0800 (Tue, 15 Nov 2011)


Log Message
Merged r91138.

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100334 => 100335)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 22:59:04 UTC (rev 100334)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 23:00:44 UTC (rev 100335)
@@ -1,5 +1,17 @@
 2011-11-15  Lucas Forschler  
 
+Merge 91138
+
+2011-07-15  Simon Fraser  
+
+Fix Windows build.
+
+* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
+(WebCore::MediaPlayerPrivate::backingScaleFactor):
+(WebCore::MediaPlayerPrivate::pageScaleFactor):
+
+2011-11-15  Lucas Forschler  
+
 Merge 91137
 
 2011-07-15  Simon Fraser  


Modified: branches/safari-534.53-branch/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h (100334 => 100335)

--- branches/safari-534.53-branch/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h	2011-11-15 22:59:04 UTC (rev 100334)
+++ branches/safari-534.53-branch/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h	2011-11-15 23:00:44 UTC (rev 100335)
@@ -69,6 +69,8 @@
 virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const IntRect& inClip);
 virtual void notifyAnimationStarted(const GraphicsLayer*, double time) { }
 virtual void notifySyncRequired(const GraphicsLayer*) { }
+virtual float backingScaleFactor() const { return 1; }
+virtual float pageScaleFactor() const { return 1; }
 virtual bool showDebugBorders() const { return false; }
 virtual bool showRepaintCounter() const { return false; }
 #endif 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100334] branches/safari-534.53-branch/Source


2011-11-15

Thread
lforschler

Title: [100334] branches/safari-534.53-branch/Source








Revision 100334
Author lforsch...@apple.com
Date 2011-11-15 14:59:04 -0800 (Tue, 15 Nov 2011)


Log Message
Merged r91137.

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp
branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayer.cpp
branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayer.h
branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayerClient.h
branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.cpp
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.h
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.h
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerCompositor.h
branches/safari-534.53-branch/Source/WebKit/chromium/ChangeLog
branches/safari-534.53-branch/Source/WebKit2/ChangeLog
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.cpp
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.h




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100333 => 100334)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 22:53:52 UTC (rev 100333)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 22:59:04 UTC (rev 100334)
@@ -1,5 +1,90 @@
 2011-11-15  Lucas Forschler  
 
+Merge 91137
+
+2011-07-15  Simon Fraser  
+
+Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
+https://bugs.webkit.org/show_bug.cgi?id=64643
+
+Reviewed by Darin Adler.
+
+RenderLayerBacking would set the contentsScale on GraphicsLayers
+on creation, and update it when the pageScaleFactor changed. However,
+RenderLayerBacking doesn't really know what contentsScale is best
+for a layer, so instead, have GraphicsLayers call back through the
+GraphicsLayerClient to get the two relevant scale factors, and do
+their own computation of contentsScale.
+
+No testable behavior changes.
+
+* page/Frame.cpp:
+(WebCore::Frame::pageScaleFactorChanged): No need to pass the scale.
+
+* platform/graphics/GraphicsLayer.cpp:
+(WebCore::GraphicsLayer::notePageScaleFactorChangedIncludingDescendants):
+Recurse through the GraphicsLayer tree, calling pageScaleFactorChanged() on 
+each layer.
+
+* platform/graphics/GraphicsLayer.h:
+(WebCore::GraphicsLayer::pageScaleFactorChanged):
+Remove contentsScale/setContentsScale
+
+* platform/graphics/GraphicsLayerClient.h:
+Add methods to fetch the backingScaleFactor() and pageScaleFactor().
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::GraphicsLayerCA): m_uncommittedChanges
+defaults to ContentsScaleChanged so we update contentsScale on
+the first flush.
+
+(WebCore::GraphicsLayerCA::setContentsToBackgroundColor):
+This was the wrong time to call updateContentsRect() and setupContentsLayer();
+those should be done at commit time, so moved to updateLayerBackgroundColor().
+(WebCore::GraphicsLayerCA::recursiveCommitChanges): Note whether we
+have any changes, and call didCommitChangesForLayer() on the client.
+(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Code moved to here.
+(WebCore::clampedContentsScaleForScale): No longer has any hysteresis
+on the scale, and now just clamps.
+(WebCore::GraphicsLayerCA::updateContentsScale): Fetch the scales
+from the client, and multiply them, then clamp.
+(WebCore::GraphicsLayerCA::requiresTiledLayer): This now takes
+contentsScale into account when deciding to use tiled layer,
+so that zooming in will cause layers to start tiling.
+(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Don't call
+setContentsScale(), but rather updateContentsScale().
+(WebCore::GraphicsLayerCA::pageScaleFactorChanged): Set the bits
+for properties that depend on the scale.
+(WebCore::GraphicsLayerCA::noteChangesForScaleSensitiveProperties):
+Note that contentsScale needs to be updated. At some point we might also
+need to dirty other properties.
+* platform/graphics/ca/Grap



[webkit-changes] [100332]	branches/safari-534.53-branch/Source/WebCore


2011-11-15

Thread
lforschler

Title: [100332] branches/safari-534.53-branch/Source/WebCore








Revision 100332
Author lforsch...@apple.com
Date 2011-11-15 14:52:03 -0800 (Tue, 15 Nov 2011)


Log Message
Merged r90954.

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.h




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100331 => 100332)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 22:48:54 UTC (rev 100331)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-11-15 22:52:03 UTC (rev 100332)
@@ -1,5 +1,35 @@
 2011-11-15  Lucas Forschler  
 
+Merge 90954
+
+2011-07-13  Simon Fraser  
+
+Factor some GraphicsLayer creation code in RenderLayerBacking
+https://bugs.webkit.org/show_bug.cgi?id=64487
+
+Reviewed by Sam Weinig.
+
+Move the GraphicsLayer::create() calls into once place so that we
+don't have lots of #ifndef NDEBUG in various places, and can share
+more code in future.
+
+No behavior change, so no new tests.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::RenderLayerBacking):
+(WebCore::RenderLayerBacking::~RenderLayerBacking):
+(WebCore::RenderLayerBacking::createGraphicsLayer):
+(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
+(WebCore::RenderLayerBacking::destroyGraphicsLayers):
+(WebCore::RenderLayerBacking::updateLayerTransform):
+(WebCore::RenderLayerBacking::updateClippingLayers):
+(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
+(WebCore::RenderLayerBacking::updateForegroundLayer):
+(WebCore::RenderLayerBacking::updateMaskLayer):
+* rendering/RenderLayerBacking.h:
+
+2011-11-15  Lucas Forschler  
+
 Merge 90925
 
 2011-07-12  Simon Fraser  


Modified: branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp (100331 => 100332)

--- branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp	2011-11-15 22:48:54 UTC (rev 100331)
+++ branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp	2011-11-15 22:52:03 UTC (rev 100332)
@@ -85,7 +85,7 @@
 : m_owningLayer(layer)
 , m_artificiallyInflatedBounds(false)
 {
-createGraphicsLayer();
+createPrimaryGraphicsLayer();
 }
 
 RenderLayerBacking::~RenderLayerBacking()
@@ -94,29 +94,36 @@
 updateOverflowControlsLayers(false, false, false);
 updateForegroundLayer(false);
 updateMaskLayer(false);
-destroyGraphicsLayer();
+destroyGraphicsLayers();
 }
 
-void RenderLayerBacking::createGraphicsLayer()
+PassOwnPtr RenderLayerBacking::createGraphicsLayer(const String& name)
 {
-m_graphicsLayer = GraphicsLayer::create(this);
-
+OwnPtr graphicsLayer = GraphicsLayer::create(this);
 #ifndef NDEBUG
-m_graphicsLayer->setName(nameForLayer());
+graphicsLayer->setName(name);
 #endif
+return graphicsLayer.release();
+}
 
-#if USE(ACCELERATED_COMPOSITING)
+void RenderLayerBacking::createPrimaryGraphicsLayer()
+{
+String layerName;
+#ifndef NDEBUG
+layerName = nameForLayer();
+#endif
+m_graphicsLayer = createGraphicsLayer(layerName);
+
 ASSERT(renderer());
 ASSERT(renderer()->document());
 ASSERT(renderer()->document()->frame());
 m_graphicsLayer->setContentsScale(pageScaleFactor() * backingScaleFactor());
-#endif
 
 updateLayerOpacity(renderer()->style());
 updateLayerTransform(renderer()->style());
 }
 
-void RenderLayerBacking::destroyGraphicsLayer()
+void RenderLayerBacking::destroyGraphicsLayers()
 {
 if (m_graphicsLayer)
 m_graphicsLayer->removeFromParent();
@@ -543,10 +550,7 @@
 
 if (needsAncestorClip) {
 if (!m_ancestorClippingLayer) {
-m_ancestorClippingLayer = GraphicsLayer::create(this);
-#ifndef NDEBUG
-m_ancestorClippingLayer->setName("Ancestor clipping Layer");
-#endif
+m_ancestorClippingLayer = createGraphicsLayer("Ancestor clipping Layer");
 m_ancestorClippingLayer->setMasksToBounds(true);
 layersChanged = true;
 }
@@ -558,10 +562,7 @@
 
 if (needsDescendantClip) {
 if (!m_clippingLayer) {
-m_clippingLayer = GraphicsLayer::create(this);
-#ifndef NDEBUG
-m_clippingLayer->setName("Child clipping Layer");
-#endif
+m_clippingLayer = createGraphicsLayer("Child clipping Layer");
 m_clippingLayer->setMasksToBounds(true);
 layersChanged = true;
 }
@@ -606,10 +607,7 @@
 bool layersChanged = false;
 if (needsHorizontalScrollbarLayer) {
 if (!m_layerForHorizontalScrollbar) {
-m_layerForHorizontalScrollbar = GraphicsLayer::



[webkit-changes] [100331] trunk/LayoutTests


2011-11-15

Thread
pkasting

Title: [100331] trunk/LayoutTests








Revision 100331
Author pkast...@chromium.org
Date 2011-11-15 14:48:54 -0800 (Tue, 15 Nov 2011)


Log Message
Fix expectations after r100289.
https://bugs.webkit.org/show_bug.cgi?id=72391

fast/dom/Orientation/create-event-orientationchange.html was updated but
the expected text was not.

Unreviewed, gardening.

* fast/dom/Orientation/create-event-orientationchange-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100330 => 100331)

--- trunk/LayoutTests/ChangeLog	2011-11-15 22:46:20 UTC (rev 100330)
+++ trunk/LayoutTests/ChangeLog	2011-11-15 22:48:54 UTC (rev 100331)
@@ -1,3 +1,15 @@
+2011-11-15  Peter Kasting  
+
+Fix expectations after r100289.
+https://bugs.webkit.org/show_bug.cgi?id=72391
+
+fast/dom/Orientation/create-event-orientationchange.html was updated but
+the expected text was not.
+
+Unreviewed, gardening.
+
+* fast/dom/Orientation/create-event-orientationchange-expected.txt:
+
 2011-11-15  Ojan Vafai  
 
 Pixel result accidentally left out of http://trac.webkit.org/changeset/100324.


Modified: trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt (100330 => 100331)

--- trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt	2011-11-15 22:46:20 UTC (rev 100330)
+++ trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt	2011-11-15 22:48:54 UTC (rev 100331)
@@ -1,16 +1,9 @@
-Tests that document.createEvent() works with orientationChange
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-
-FAIL... orientationChange event doesn't appear to be enabled or implemented.
-
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
-
-
-
+Tests that document.createEvent() works with orientationChange
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+FAIL... orientationChange event doesn't appear to be enabled or implemented.
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100328] trunk/Source/WebCore


2011-11-15

Thread
scheib

Title: [100328] trunk/Source/WebCore








Revision 100328
Author sch...@chromium.org
Date 2011-11-15 14:38:53 -0800 (Tue, 15 Nov 2011)


Log Message
Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
https://bugs.webkit.org/show_bug.cgi?id=72315

Reviewed by Dimitri Glazkov.

* WebCore.gypi:
* page/Navigator.cpp:
(WebCore::Navigator::webkitPointer):
* page/Navigator.h:
* page/Navigator.idl:
* page/PointerLock.cpp: Renamed from Source/WebCore/page/MouseLockable.cpp.
(WebCore::PointerLock::PointerLock):
(WebCore::PointerLock::~PointerLock):
(WebCore::PointerLock::webkitLock):
(WebCore::PointerLock::webkitUnlock):
(WebCore::PointerLock::webkitIsLocked):
* page/PointerLock.h: Renamed from Source/WebCore/page/MouseLockable.h.
(WebCore::PointerLock::create):
* page/PointerLock.idl: Renamed from Source/WebCore/page/MouseLockable.idl.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/page/Navigator.cpp
trunk/Source/WebCore/page/Navigator.h
trunk/Source/WebCore/page/Navigator.idl


Added Paths

trunk/Source/WebCore/page/PointerLock.cpp
trunk/Source/WebCore/page/PointerLock.h
trunk/Source/WebCore/page/PointerLock.idl


Removed Paths

trunk/Source/WebCore/page/MouseLockable.cpp
trunk/Source/WebCore/page/MouseLockable.h
trunk/Source/WebCore/page/MouseLockable.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (100327 => 100328)

--- trunk/Source/WebCore/ChangeLog	2011-11-15 22:36:12 UTC (rev 100327)
+++ trunk/Source/WebCore/ChangeLog	2011-11-15 22:38:53 UTC (rev 100328)
@@ -1,3 +1,25 @@
+2011-11-15  Vincent Scheib  
+
+Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock
+https://bugs.webkit.org/show_bug.cgi?id=72315
+
+Reviewed by Dimitri Glazkov.
+
+* WebCore.gypi:
+* page/Navigator.cpp:
+(WebCore::Navigator::webkitPointer):
+* page/Navigator.h:
+* page/Navigator.idl:
+* page/PointerLock.cpp: Renamed from Source/WebCore/page/MouseLockable.cpp.
+(WebCore::PointerLock::PointerLock):
+(WebCore::PointerLock::~PointerLock):
+(WebCore::PointerLock::webkitLock):
+(WebCore::PointerLock::webkitUnlock):
+(WebCore::PointerLock::webkitIsLocked):
+* page/PointerLock.h: Renamed from Source/WebCore/page/MouseLockable.h.
+(WebCore::PointerLock::create):
+* page/PointerLock.idl: Renamed from Source/WebCore/page/MouseLockable.idl.
+
 2011-10-28  Ojan Vafai  
 
 Overflow and relayout are broken in the new flexboxes


Modified: trunk/Source/WebCore/WebCore.gypi (100327 => 100328)

--- trunk/Source/WebCore/WebCore.gypi	2011-11-15 22:36:12 UTC (rev 100327)
+++ trunk/Source/WebCore/WebCore.gypi	2011-11-15 22:38:53 UTC (rev 100328)
@@ -1403,7 +1403,6 @@
 'page/History.idl',
 'page/Location.idl',
 'page/MemoryInfo.idl',
-'page/MouseLockable.idl',
 'page/Navigator.idl',
 'page/NavigatorUserMediaError.idl',
 'page/NavigatorUserMediaErrorCallback.idl',
@@ -1411,6 +1410,7 @@
 'page/Performance.idl',
 'page/PerformanceNavigation.idl',
 'page/PerformanceTiming.idl',
+'page/PointerLock.idl',
 'page/PositionCallback.idl',
 'page/PositionError.idl',
 'page/PositionErrorCallback.idl',
@@ -2956,8 +2956,6 @@
 'page/MemoryInfo.cpp',
 'page/MouseEventWithHitTestResults.cpp',
 'page/MouseEventWithHitTestResults.h',
-'page/MouseLockable.cpp',
-'page/MouseLockable.h',
 'page/Navigator.cpp',
 'page/Navigator.h',
 'page/NavigatorBase.cpp',
@@ -2979,6 +2977,8 @@
 'page/PerformanceNavigation.h',
 'page/PerformanceTiming.cpp',
 'page/PerformanceTiming.h',
+'page/PointerLock.cpp',
+'page/PointerLock.h',
 'page/PrintContext.cpp',
 'page/Screen.cpp',
 'page/Screen.h',


Deleted: trunk/Source/WebCore/page/MouseLockable.cpp (100327 => 100328)

--- trunk/Source/WebCore/page/MouseLockable.cpp	2011-11-15 22:36:12 UTC (rev 100327)
+++ trunk/Source/WebCore/page/MouseLockable.cpp	2011-11-15 22:38:53 UTC (rev 100328)
@@ -1,58 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1.  Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2.  Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' 



[webkit-changes] [100326] trunk/Tools


2011-11-15

Thread
tony

Title: [100326] trunk/Tools








Revision 100326
Author t...@chromium.org
Date 2011-11-15 14:30:19 -0800 (Tue, 15 Nov 2011)


Log Message
[NRWT] Reftests should run even when pixel tests are disabled.
https://bugs.webkit.org/show_bug.cgi?id=60605

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
Also add an assert to make sure we get image hashes back when running ref tests.
* Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
* Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
of starting a pixel driver if needed.  It handles the logic of sending the test
to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/dryrun.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py




Diff

Modified: trunk/Tools/ChangeLog (100325 => 100326)

--- trunk/Tools/ChangeLog	2011-11-15 22:29:20 UTC (rev 100325)
+++ trunk/Tools/ChangeLog	2011-11-15 22:30:19 UTC (rev 100326)
@@ -1,3 +1,24 @@
+2011-11-14  Tony Chang  
+
+[NRWT] Reftests should run even when pixel tests are disabled.
+https://bugs.webkit.org/show_bug.cgi?id=60605
+
+Reviewed by Dirk Pranke.
+
+* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
+Also add an assert to make sure we get image hashes back when running ref tests.
+* Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
+* Scripts/webkitpy/layout_tests/port/base_unittest.py:
+* Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
+* Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
+of starting a pixel driver if needed.  It handles the logic of sending the test
+to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
+* Scripts/webkitpy/layout_tests/port/dryrun.py:
+* Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
+
 2011-11-15  David Kilzer  
 
 Don't use File::Slurp for run-leaks unit tests


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (100325 => 100326)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2011-11-15 22:29:20 UTC (rev 100325)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	2011-11-15 22:30:19 UTC (rev 100326)
@@ -113,21 +113,17 @@
 image_hash = None
 if self._should_fetch_expected_checksum():
 image_hash = self._port.expected_checksum(self._test_name)
-return DriverInput(self._test_name, self._timeout, image_hash)
+return DriverInput(self._test_name, self._timeout, image_hash, self._is_reftest)
 
 def run(self):
-if self._options.new_baseline or self._options.reset_results:
-if self._is_reftest:
-# Returns a dummy TestResult. We don't have to rebase for reftests.
-return TestResult(self._test_name)
-else:
-return self._run_rebaseline()
 if self._is_reftest:
-if self._port.get_option('pixel_tests'):
-return self._run_reftest()
-result = TestResult(self._test_name)
-result.type = test_expectations.SKIP
-return result
+if self._po



[webkit-changes] [100325] trunk/LayoutTests


2011-11-15

Thread
pkasting

Title: [100325] trunk/LayoutTests








Revision 100325
Author pkast...@chromium.org
Date 2011-11-15 14:29:20 -0800 (Tue, 15 Nov 2011)


Log Message
Fix expectations after r100283.
https://bugs.webkit.org/show_bug.cgi?id=72137

We don't have a LION modifier, and I'm not sure why one test was only
skipped for SNOWLEOPARD RELEASE as it fails on Debug also.

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (100324 => 100325)

--- trunk/LayoutTests/ChangeLog	2011-11-15 22:25:24 UTC (rev 100324)
+++ trunk/LayoutTests/ChangeLog	2011-11-15 22:29:20 UTC (rev 100325)
@@ -1,3 +1,15 @@
+2011-11-15  Peter Kasting  
+
+Fix expectations after r100283.
+https://bugs.webkit.org/show_bug.cgi?id=72137
+
+I'm not sure why one test was only skipped for SNOWLEOPARD RELEASE as it
+fails on Debug also.
+
+Unreviewed, gardening.
+
+* platform/chromium/test_expectations.txt:
+
 2011-10-28  Ojan Vafai  
 
 Overflow and relayout are broken in the new flexboxes


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100324 => 100325)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-15 22:25:24 UTC (rev 100324)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-15 22:29:20 UTC (rev 100325)
@@ -3905,8 +3905,7 @@
 BUG_CARYCLARK MAC CPU : fast/writing-mode/broken-ideographic-font.html = IMAGE
 BUG_CARYCLARK MAC CPU : fast/writing-mode/fallback-orientation.html = IMAGE
 BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-lr-text.html = IMAGE
-BUG_CARYCLARK LION CPU : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE
-BUG_CARYCLARK SNOWLEOPARD CPU RELEASE : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE
+BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE
 BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-rl-text.html = IMAGE
 BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-ruby-vertical-lr.html = IMAGE
 BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-ruby-vertical-rl.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes





[webkit-changes] [100324] trunk


2011-11-15

Thread
ojan

Title: [100324] trunk








Revision 100324
Author o...@chromium.org
Date 2011-11-15 14:25:24 -0800 (Tue, 15 Nov 2011)


Log Message
Overflow and relayout are broken in the new flexboxes
https://bugs.webkit.org/show_bug.cgi?id=71161

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/auto-height-dynamic.html
   css3/flexbox/flex-item-child-overflow-expected.html
   css3/flexbox/flex-item-child-overflow.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
-Always set the logical height to 0 to start with to ensure we don't
use the height from the previous layout when we are computing the
intrinsic size of the flexbox.
-Call computeOverflow after computeLogicalHeight so that flex-item's children's
overflow is properly rendered.

(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
-Now that we setLogicalHeight in layoutBlock, we no longer need to do it here.
-Refactor flipping code. The behavior is the same, but the variable names are just
more correct.

LayoutTests:

* css3/flexbox/auto-height-dynamic-expected.txt: Added.
* css3/flexbox/auto-height-dynamic.html: Added.
* css3/flexbox/flex-item-child-overflow-expected.html: Added.
* css3/flexbox/flex-item-child-overflow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp


Added Paths

trunk/LayoutTests/css3/flexbox/auto-height-dynamic-expected.txt
trunk/LayoutTests/css3/flexbox/auto-height-dynamic.html
trunk/LayoutTests/css3/flexbox/flex-item-child-overflow-expected.html
trunk/LayoutTests/css3/flexbox/flex-item-child-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (100323 => 100324)

--- trunk/LayoutTests/ChangeLog	2011-11-15 22:23:59 UTC (rev 100323)
+++ trunk/LayoutTests/ChangeLog	2011-11-15 22:25:24 UTC (rev 100324)
@@ -1,3 +1,15 @@
+2011-10-28  Ojan Vafai  
+
+Overflow and relayout are broken in the new flexboxes
+https://bugs.webkit.org/show_bug.cgi?id=71161
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/auto-height-dynamic-expected.txt: Added.
+* css3/flexbox/auto-height-dynamic.html: Added.
+* css3/flexbox/flex-item-child-overflow-expected.html: Added.
+* css3/flexbox/flex-item-child-overflow.html: Added.
+
 2011-11-15  Peter Kasting  
 
 Fix expectations after r100276.


Added: trunk/LayoutTests/css3/flexbox/auto-height-dynamic-expected.txt (0 => 100324)

--- trunk/LayoutTests/css3/flexbox/auto-height-dynamic-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/auto-height-dynamic-expected.txt	2011-11-15 22:25:24 UTC (rev 100324)
@@ -0,0 +1,2 @@
+PASS
+PASS
Property changes on: trunk/LayoutTests/css3/flexbox/auto-height-dynamic-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/css3/flexbox/auto-height-dynamic.html (0 => 100324)

--- trunk/LayoutTests/css3/flexbox/auto-height-dynamic.html	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/auto-height-dynamic.html	2011-11-15 22:25:24 UTC (rev 100324)
@@ -0,0 +1,38 @@
+
+
+
+.flexbox {
+width: 600px;
+display: -webkit-flexbox;
+background-color: #aaa;
+position: relative;
+-webkit-flex-flow: column;
+}
+.flexbox :nth-child(1) {
+background-color: blue;
+}
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
+
+

+

+
+
+

+

+
+
+