[webkit-changes] [100246] trunk
Title: [100246] trunk
Revision 100246
Author pfeld...@chromium.org
Date 2011-11-15 00:08:59 -0800 (Tue, 15 Nov 2011)
Log Message
Web Inspector: Command line $x fails for 3 of 4 types of XPath query
https://bugs.webkit.org/show_bug.cgi?id=72276
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: inspector/console/console-xpath.html
* inspector/InjectedScriptSource.js:
(.):
LayoutTests:
* inspector/console/console-xpath-expected.txt: Added.
* inspector/console/console-xpath.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScriptSource.js
Added Paths
trunk/LayoutTests/inspector/console/console-xpath-expected.txt
trunk/LayoutTests/inspector/console/console-xpath.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100245 => 100246)
--- trunk/LayoutTests/ChangeLog 2011-11-15 07:10:06 UTC (rev 100245)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 08:08:59 UTC (rev 100246)
@@ -1,3 +1,13 @@
+2011-11-14 Pavel Feldman pfeld...@google.com
+
+Web Inspector: Command line $x fails for 3 of 4 types of XPath query
+https://bugs.webkit.org/show_bug.cgi?id=72276
+
+Reviewed by Timothy Hatcher.
+
+* inspector/console/console-xpath-expected.txt: Added.
+* inspector/console/console-xpath.html: Added.
+
2011-11-14 Peter Kasting pkast...@google.com
r100237 moved some pixel baselines into platform/chromium without also
Added: trunk/LayoutTests/inspector/console/console-xpath-expected.txt (0 => 100246)
--- trunk/LayoutTests/inspector/console/console-xpath-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/console/console-xpath-expected.txt 2011-11-15 08:08:59 UTC (rev 100246)
@@ -0,0 +1,13 @@
+CONSOLE MESSAGE: line 1: complete
+Tests $x for iterator and non-iterator types.
+
+$x('42')
+$x('name(/html)')
+$x('not(42)')
+$x('/html/body/p').length
+42
+html
+false
+1
+complete
+
Property changes on: trunk/LayoutTests/inspector/console/console-xpath-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/console/console-xpath.html (0 => 100246)
--- trunk/LayoutTests/inspector/console/console-xpath.html (rev 0)
+++ trunk/LayoutTests/inspector/console/console-xpath.html 2011-11-15 08:08:59 UTC (rev 100246)
@@ -0,0 +1,35 @@
+html
+head
+script src=""
+script src=""
+script
+
+function test()
+{
+InspectorTest.addConsoleSniffer(addMessageSniffer, true);
+
+InspectorTest.evaluateInConsole($x('42')); // number
+InspectorTest.evaluateInConsole($x('name(/html)')); // string
+InspectorTest.evaluateInConsole($x('not(42)')); // boolean
+InspectorTest.evaluateInConsole($x('/html/body/p').length); // node iterator
+InspectorTest.evaluateInPage(console.log('complete')); // node iterator
+
+function addMessageSniffer(message)
+{
+if (message.toString().indexOf(complete) !== -1) {
+InspectorTest.dumpConsoleMessages();
+InspectorTest.completeTest();
+}
+}
+}
+
+/script
+/head
+
+body _onload_=runTest()
+p
+Tests $x for iterator and non-iterator types.
+/p
+
+/body
+/html
Property changes on: trunk/LayoutTests/inspector/console/console-xpath.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (100245 => 100246)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 07:10:06 UTC (rev 100245)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 08:08:59 UTC (rev 100246)
@@ -1,3 +1,15 @@
+2011-11-14 Pavel Feldman pfeld...@google.com
+
+Web Inspector: Command line $x fails for 3 of 4 types of XPath query
+https://bugs.webkit.org/show_bug.cgi?id=72276
+
+Reviewed by Timothy Hatcher.
+
+Test: inspector/console/console-xpath.html
+
+* inspector/InjectedScriptSource.js:
+(.):
+
2011-11-14 Ryosuke Niwa rn...@webkit.org
Fix the change log entry for r59190.
Modified: trunk/Source/WebCore/inspector/InjectedScriptSource.js (100245 => 100246)
--- trunk/Source/WebCore/inspector/InjectedScriptSource.js 2011-11-15 07:10:06 UTC (rev 100245)
+++ trunk/Source/WebCore/inspector/InjectedScriptSource.js 2011-11-15 08:08:59 UTC (rev 100246)
@@ -592,16 +592,22 @@
$x: function(xpath, context)
{
-var nodes = [];
-try {
-var doc = (context context.ownerDocument) || inspectedWindow.document;
-var results = doc.evaluate(xpath, context || doc, null, XPathResult.ANY_TYPE, null);
+var doc = (context context.ownerDocument) || inspectedWindow.document;
+var result = doc.evaluate(xpath, context || doc, null, XPathResult.ANY_TYPE, null);
+switch (result.resultType) {
+case XPathResult.NUMBER_TYPE:
+return result.numberValue;
+case XPathResult.STRING_TYPE:
+return
[webkit-changes] [100247] trunk
Title: [100247] trunk
Revision 100247
Author tk...@chromium.org
Date 2011-11-15 00:36:56 -0800 (Tue, 15 Nov 2011)
Log Message
[V8] Fix incorrect handling of _javascript_ properties in DOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=53578
Reviewed by Adam Barth.
Source/WebCore:
Follows a JSC behavior change by r96893.
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyGetter):
Propagate to the _javascript_ object if the DOMStringMap object
doesn't have the requested item.
(WebCore::V8DOMStringMap::namedPropertyDeleter): ditto.
(WebCore::V8DOMStringMap::namedPropertySetter):
Try to set a property to only a DOMStringMap object.
LayoutTests:
* platform/chromium/test_expectations.txt:
Remove failure expectations of fast/dom/dataset.html and
fast/dom/dataset-xhtml.xhtml.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (100246 => 100247)
--- trunk/LayoutTests/ChangeLog 2011-11-15 08:08:59 UTC (rev 100246)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 08:36:56 UTC (rev 100247)
@@ -1,3 +1,14 @@
+2011-11-15 Kent Tamura tk...@chromium.org
+
+[V8] Fix incorrect handling of _javascript_ properties in DOMStringMap
+https://bugs.webkit.org/show_bug.cgi?id=53578
+
+Reviewed by Adam Barth.
+
+* platform/chromium/test_expectations.txt:
+Remove failure expectations of fast/dom/dataset.html and
+fast/dom/dataset-xhtml.xhtml.
+
2011-11-14 Pavel Feldman pfeld...@google.com
Web Inspector: Command line $x fails for 3 of 4 types of XPath query
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100246 => 100247)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 08:08:59 UTC (rev 100246)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 08:36:56 UTC (rev 100247)
@@ -3673,10 +3673,6 @@
BUGWK68982 : svg/custom/oversized-pattern-scale.svg = IMAGE PASS
BUGWK68982 : svg/custom/transformed-pattern-clamp-svg-root.svg = IMAGE PASS
-// Need to follow a JSC binding change. See webkit.org/b/53752.
-BUGWK53578 : fast/dom/dataset.html = TEXT
-BUGWK53578 : fast/dom/dataset-xhtml.xhtml = TEXT
-
BUGWK69060 WIN LINUX : fast/repaint/selection-clear.html = IMAGE+TEXT
BUGWK69062 WIN GPU : compositing/shadows/shadow-drawing.html = IMAGE
Modified: trunk/Source/WebCore/ChangeLog (100246 => 100247)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 08:08:59 UTC (rev 100246)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 08:36:56 UTC (rev 100247)
@@ -1,3 +1,20 @@
+2011-11-15 Kent Tamura tk...@chromium.org
+
+[V8] Fix incorrect handling of _javascript_ properties in DOMStringMap
+https://bugs.webkit.org/show_bug.cgi?id=53578
+
+Reviewed by Adam Barth.
+
+Follows a JSC behavior change by r96893.
+
+* bindings/v8/custom/V8DOMStringMapCustom.cpp:
+(WebCore::V8DOMStringMap::namedPropertyGetter):
+Propagate to the _javascript_ object if the DOMStringMap object
+doesn't have the requested item.
+(WebCore::V8DOMStringMap::namedPropertyDeleter): ditto.
+(WebCore::V8DOMStringMap::namedPropertySetter):
+Try to set a property to only a DOMStringMap object.
+
2011-11-14 Pavel Feldman pfeld...@google.com
Web Inspector: Command line $x fails for 3 of 4 types of XPath query
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp (100246 => 100247)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp 2011-11-15 08:08:59 UTC (rev 100246)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp 2011-11-15 08:36:56 UTC (rev 100247)
@@ -49,7 +49,10 @@
v8::Handlev8::Value V8DOMStringMap::namedPropertyGetter(v8::Localv8::String name, const v8::AccessorInfo info)
{
INC_STATS(DOM.DOMStringMap.NamedPropertyGetter);
-return v8StringOrUndefined(V8DOMStringMap::toNative(info.Holder())-item(toWebCoreString(name)));
+String value = V8DOMStringMap::toNative(info.Holder())-item(toWebCoreString(name));
+if (value.isNull())
+return notHandledByInterceptor();
+return v8StringOrUndefined(value);
}
v8::Handlev8::Array V8DOMStringMap::namedPropertyEnumerator(const v8::AccessorInfo info)
@@ -66,28 +69,14 @@
v8::Handlev8::Boolean V8DOMStringMap::namedPropertyDeleter(v8::Localv8::String name, const v8::AccessorInfo info)
{
INC_STATS(DOM.DOMStringMap.NamedPropertyDeleter);
-
-if (!info.Holder()-GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
-return v8::False();
-if (info.Holder()-HasRealNamedCallbackProperty(name))
-return v8::False();
-
ExceptionCode ec = 0;
V8DOMStringMap::toNative(info.Holder())-deleteItem(toWebCoreString(name), ec);
-if (ec)
-throwError(ec);
-
[webkit-changes] [100248] trunk/Source/WebKit2
Title: [100248] trunk/Source/WebKit2 Revision 100248 Author ma...@webkit.org Date 2011-11-15 01:05:33 -0800 (Tue, 15 Nov 2011) Log Message [GTK][WEBKIT2] Add enable-caret-browsing property to WebKitSettings https://bugs.webkit.org/show_bug.cgi?id=72267 Reviewed by Martin Robinson. Allow getting and setting the 'enable-caret-browsing' property through WebKitSettings. * UIProcess/API/gtk/WebKitSettings.cpp: (webKitSettingsSetProperty): Added property setter. (webKitSettingsGetProperty): Added propery getter. (webkit_settings_class_init): Install property. (webkit_settings_get_enable_caret_browsing): Added. (webkit_settings_set_enable_caret_browsing): Added. * UIProcess/API/gtk/WebKitSettings.h: Expose new public APIs. * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new sections for gtk-doc generation. * UIProcess/API/gtk/tests/TestWebKitSettings.cpp: (testWebKitSettings): Added new API test. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (100247 => 100248) --- trunk/Source/WebKit2/ChangeLog 2011-11-15 08:36:56 UTC (rev 100247) +++ trunk/Source/WebKit2/ChangeLog 2011-11-15 09:05:33 UTC (rev 100248) @@ -1,3 +1,24 @@ +2011-11-15 Mario Sanchez Prada msanc...@igalia.com + +[GTK][WEBKIT2] Add enable-caret-browsing property to WebKitSettings +https://bugs.webkit.org/show_bug.cgi?id=72267 + +Reviewed by Martin Robinson. + +Allow getting and setting the 'enable-caret-browsing' property +through WebKitSettings. + +* UIProcess/API/gtk/WebKitSettings.cpp: +(webKitSettingsSetProperty): Added property setter. +(webKitSettingsGetProperty): Added propery getter. +(webkit_settings_class_init): Install property. +(webkit_settings_get_enable_caret_browsing): Added. +(webkit_settings_set_enable_caret_browsing): Added. +* UIProcess/API/gtk/WebKitSettings.h: Expose new public APIs. +* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new sections for gtk-doc generation. +* UIProcess/API/gtk/tests/TestWebKitSettings.cpp: +(testWebKitSettings): Added new API test. + 2011-11-14 Julien Chaffraix jchaffr...@webkit.org Add --css-grid-layout to build-webkit and the build systems Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (100247 => 100248) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2011-11-15 08:36:56 UTC (rev 100247) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2011-11-15 09:05:33 UTC (rev 100248) @@ -97,6 +97,7 @@ PROP_DEFAULT_MONOSPACE_FONT_SIZE, PROP_MINIMUM_FONT_SIZE, PROP_DEFAULT_CHARSET, +PROP_ENABLE_CARET_BROWSING, }; static void webKitSettingsSetProperty(GObject* object, guint propId, const GValue* value, GParamSpec* paramSpec) @@ -173,6 +174,9 @@ case PROP_DEFAULT_CHARSET: webkit_settings_set_default_charset(settings, g_value_get_string(value)); break; +case PROP_ENABLE_CARET_BROWSING: +webkit_settings_set_enable_caret_browsing(settings, g_value_get_boolean(value)); +break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propId, paramSpec); break; @@ -253,6 +257,9 @@ case PROP_DEFAULT_CHARSET: g_value_set_string(value, webkit_settings_get_default_charset(settings)); break; +case PROP_ENABLE_CARET_BROWSING: +g_value_set_boolean(value, webkit_settings_get_enable_caret_browsing(settings)); +break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propId, paramSpec); break; @@ -603,6 +610,18 @@ iso-8859-1, readWriteConstructParamFlags)); +/** + * WebKitSettings:enable-caret-browsing: + * + * Whether to enable accessibility enhanced keyboard navigation. + */ +g_object_class_install_property(gObjectClass, +PROP_ENABLE_CARET_BROWSING, +g_param_spec_boolean(enable-caret-browsing, + _(Enable Caret Browsing), + _(Whether to enable accessibility enhanced keyboard navigation), + FALSE, + readWriteConstructParamFlags)); g_type_class_add_private(klass, sizeof(WebKitSettingsPrivate)); } @@ -1511,3 +1530,38 @@ g_object_notify(G_OBJECT(settings), default-charset); } + +/** + * webkit_settings_get_enable_caret_browsing: + *
[webkit-changes] [100249] trunk/LayoutTests
Title: [100249] trunk/LayoutTests Revision 100249 Author r...@webkit.org Date 2011-11-15 01:13:59 -0800 (Tue, 15 Nov 2011) Log Message [Qt] Two tests are skipped after r100182 and r100239. Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100248 => 100249) --- trunk/LayoutTests/ChangeLog 2011-11-15 09:05:33 UTC (rev 100248) +++ trunk/LayoutTests/ChangeLog 2011-11-15 09:13:59 UTC (rev 100249) @@ -1,3 +1,11 @@ +2011-11-15 Renata Hodovan r...@webkit.org + +[Qt] Two tests are skipped after r100182 and r100239. + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-11-15 Kent Tamura tk...@chromium.org [V8] Fix incorrect handling of _javascript_ properties in DOMStringMap Modified: trunk/LayoutTests/platform/qt/Skipped (100248 => 100249) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-15 09:05:33 UTC (rev 100248) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-15 09:13:59 UTC (rev 100249) @@ -2511,3 +2511,11 @@ # https://bugs.webkit.org/show_bug.cgi?id=72274 inspector/timeline inspector/user-metrics.html + +# [Qt] fast/dom/Window/window-postmessage-arrays.html fails after r100239 +# https://bugs.webkit.org/show_bug.cgi?id=72363 +fast/dom/Window/window-postmessage-arrays.html + +# [Qt] http/tests/security/postMessage/invalid-origin-throws-exception.html fails after r100182 +# https://bugs.webkit.org/show_bug.cgi?id=72364 +http/tests/security/postMessage/invalid-origin-throws-exception.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100250] trunk/LayoutTests
Title: [100250] trunk/LayoutTests
Revision 100250
Author r...@webkit.org
Date 2011-11-15 01:24:01 -0800 (Tue, 15 Nov 2011)
Log Message
[Qt] Platform-specific result for r100157.
Unreviewed, gardening.
Patch by Czene Tamás tcz...@inf.u-szeged.hu on 2011-11-15
* platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Added.
* platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png
trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100249 => 100250)
--- trunk/LayoutTests/ChangeLog 2011-11-15 09:13:59 UTC (rev 100249)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 09:24:01 UTC (rev 100250)
@@ -1,3 +1,12 @@
+2011-11-15 Czene Tamás tcz...@inf.u-szeged.hu
+
+[Qt] Platform-specific result for r100157.
+
+Unreviewed, gardening.
+
+* platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png: Added.
+* platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
+
2011-11-15 Renata Hodovan r...@webkit.org
[Qt] Two tests are skipped after r100182 and r100239.
Added: trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt (0 => 100250)
--- trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/svg/foreignObject/multiple-foreign-objects-expected.txt 2011-11-15 09:24:01 UTC (rev 100250)
@@ -0,0 +1,13 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (0,0) size 800x600
+ RenderSVGRoot {svg} at (0,0) size 400x100
+RenderSVGForeignObject {foreignObject} at (0,0) size 100x100
+ RenderBlock {DIV} at (0,0) size 100x100 [bgcolor=#008000]
+RenderText {#text} at (0,0) size 4x21
+ text run at (0,0) width 4:
+RenderSVGForeignObject {foreignObject} at (150,0) size 100x100
+ RenderBlock {DIV} at (0,0) size 100x100 [bgcolor=#008000]
+ RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100251] trunk
Title: [100251] trunk
Revision 100251
Author apav...@chromium.org
Date 2011-11-15 01:32:16 -0800 (Tue, 15 Nov 2011)
Log Message
Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names
https://bugs.webkit.org/show_bug.cgi?id=72261
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/styles/svg-style.xhtml
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::inlineStyleSheetText):
LayoutTests:
* inspector/styles/svg-style-expected.txt: Added.
* inspector/styles/svg-style.xhtml: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp
Added Paths
trunk/LayoutTests/inspector/styles/svg-style-expected.txt
trunk/LayoutTests/inspector/styles/svg-style.xhtml
Diff
Modified: trunk/LayoutTests/ChangeLog (100250 => 100251)
--- trunk/LayoutTests/ChangeLog 2011-11-15 09:24:01 UTC (rev 100250)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 09:32:16 UTC (rev 100251)
@@ -1,3 +1,13 @@
+2011-11-14 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names
+https://bugs.webkit.org/show_bug.cgi?id=72261
+
+Reviewed by Pavel Feldman.
+
+* inspector/styles/svg-style-expected.txt: Added.
+* inspector/styles/svg-style.xhtml: Added.
+
2011-11-15 Czene Tamás tcz...@inf.u-szeged.hu
[Qt] Platform-specific result for r100157.
Added: trunk/LayoutTests/inspector/styles/svg-style-expected.txt (0 => 100251)
--- trunk/LayoutTests/inspector/styles/svg-style-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/styles/svg-style-expected.txt 2011-11-15 09:32:16 UTC (rev 100251)
@@ -0,0 +1,14 @@
+Tests that svg:style does not crash when the related element is inspected.
+
+ Main style:
+[expanded]
+element.style { ()
+
+ Matched CSS Rules
+[expanded]
+media=all (svg-style.xhtml)
+rect { (svg-style.xhtml:30)
+fill: red;
+
+
+
Property changes on: trunk/LayoutTests/inspector/styles/svg-style-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/styles/svg-style.xhtml (0 => 100251)
--- trunk/LayoutTests/inspector/styles/svg-style.xhtml (rev 0)
+++ trunk/LayoutTests/inspector/styles/svg-style.xhtml 2011-11-15 09:32:16 UTC (rev 100251)
@@ -0,0 +1,36 @@
+html xmlns=http://www.w3.org/1999/xhtml
+head
+
+script src=""
+script src=""
+script
+
+function test()
+{
+InspectorTest.selectNodeAndWaitForStyles(main, step1);
+
+function step1()
+{
+InspectorTest.addResult(Main style:);
+InspectorTest.dumpSelectedElementStyles(true, false, true);
+InspectorTest.completeTest();
+}
+}
+/script
+/head
+
+body _onload_=runTest()
+p
+Tests that svg:style does not crash when the related element is inspected.
+/p
+
+svg:svg xmlns:svg=http://www.w3.org/2000/svg version=1.1
+ svg:defs
+ svg:style type=text/css
+ rect {fill: red}
+ /svg:style
+ /svg:defs
+ svg:rect id=main width=100 height=100/
+/svg:svg
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (100250 => 100251)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 09:24:01 UTC (rev 100250)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 09:32:16 UTC (rev 100251)
@@ -1,3 +1,15 @@
+2011-11-14 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names
+https://bugs.webkit.org/show_bug.cgi?id=72261
+
+Reviewed by Pavel Feldman.
+
+Test: inspector/styles/svg-style.xhtml
+
+* inspector/InspectorStyleSheet.cpp:
+(WebCore::InspectorStyleSheet::inlineStyleSheetText):
+
2011-11-15 Kent Tamura tk...@chromium.org
[V8] Fix incorrect handling of _javascript_ properties in DOMStringMap
Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (100250 => 100251)
--- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2011-11-15 09:24:01 UTC (rev 100250)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2011-11-15 09:32:16 UTC (rev 100251)
@@ -39,11 +39,13 @@
#include Document.h
#include Element.h
#include HTMLHeadElement.h
+#include HTMLNames.h
#include HTMLParserIdioms.h
#include InspectorCSSAgent.h
#include InspectorPageAgent.h
#include InspectorValues.h
#include Node.h
+#include SVGNames.h
#include StyleSheetList.h
#include WebKitCSSKeyframesRule.h
@@ -1102,7 +1104,12 @@
if (!ownerNode || ownerNode-nodeType() != Node::ELEMENT_NODE)
return false;
Element* ownerElement = static_castElement*(ownerNode);
-if (ownerElement-tagName().lower() != style)
+
+if (!ownerElement-hasTagName(HTMLNames::styleTag)
+#if ENABLE(SVG)
+ !ownerElement-hasTagName(SVGNames::styleTag)
+#endif
+)
return false;
*result = ownerElement-innerText();
[webkit-changes] [100253] trunk/Tools
Title: [100253] trunk/Tools
Revision 100253
Author hausm...@webkit.org
Date 2011-11-15 01:37:30 -0800 (Tue, 15 Nov 2011)
Log Message
[Qt] Unreviewed --minimal build fix.
* Scripts/build-webkit: Add to DEFINES+= from @options only if there is
a define. The coverage option doesn't have one, causing DEFINES+= =0
to make moc's preprocessor abort.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
Diff
Modified: trunk/Tools/ChangeLog (100252 => 100253)
--- trunk/Tools/ChangeLog 2011-11-15 09:36:36 UTC (rev 100252)
+++ trunk/Tools/ChangeLog 2011-11-15 09:37:30 UTC (rev 100253)
@@ -1,3 +1,11 @@
+2011-11-15 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Unreviewed --minimal build fix.
+
+* Scripts/build-webkit: Add to DEFINES+= from @options only if there is
+a define. The coverage option doesn't have one, causing DEFINES+= =0
+to make moc's preprocessor abort.
+
2011-11-14 Raphael Kubo da Costa k...@profusion.mobi
build-webkit: Accept --cmakearg to pass additional arguments to CMake.
Modified: trunk/Tools/Scripts/build-webkit (100252 => 100253)
--- trunk/Tools/Scripts/build-webkit 2011-11-15 09:36:36 UTC (rev 100252)
+++ trunk/Tools/Scripts/build-webkit 2011-11-15 09:37:30 UTC (rev 100253)
@@ -562,7 +562,7 @@
@options = (@ARGV, @options);
foreach (@features) {
-push @options, DEFINES+=$_-{define}=${$_-{value}} if ${$_-{value}} != $_-{default};
+push @options, DEFINES+=$_-{define}=${$_-{value}} if $_-{define} ${$_-{value}} != $_-{default};
}
if ($minimal) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100254] trunk/LayoutTests
Title: [100254] trunk/LayoutTests Revision 100254 Author r...@webkit.org Date 2011-11-15 01:47:36 -0800 (Tue, 15 Nov 2011) Log Message Unviewed gardening after r100159. Patch by Oliver Varga voli...@inf.u-szeged.hu on 2011-11-15 * platform/qt/fast/dom/Window/window-properties-expected.png: * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-property-descriptors-expected.png: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt/fast/dom/prototype-inheritance-2-expected.png: * platform/qt/fast/dom/prototype-inheritance-2-expected.txt: * platform/qt/fast/js/global-constructors-expected.png: * platform/qt/fast/js/global-constructors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.png trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.png trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.png trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100253 => 100254) --- trunk/LayoutTests/ChangeLog 2011-11-15 09:37:30 UTC (rev 100253) +++ trunk/LayoutTests/ChangeLog 2011-11-15 09:47:36 UTC (rev 100254) @@ -1,3 +1,16 @@ +2011-11-15 Oliver Varga voli...@inf.u-szeged.hu + +Unviewed gardening after r100159. + +* platform/qt/fast/dom/Window/window-properties-expected.png: +* platform/qt/fast/dom/Window/window-properties-expected.txt: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/qt/fast/dom/prototype-inheritance-2-expected.png: +* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: +* platform/qt/fast/js/global-constructors-expected.png: +* platform/qt/fast/js/global-constructors-expected.txt: + 2011-11-14 Alexander Pavlov apav...@chromium.org Web Inspector: [Crash] Crash when inspecting namespaced SVG styled via element names Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (100253 => 100254) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-15 09:37:30 UTC (rev 100253) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-15 09:47:36 UTC (rev 100254) @@ -1247,6 +1247,13 @@ window.Math.sin [function] window.Math.sqrt [function] window.Math.tan [function] +window.MediaController [object MediaControllerConstructor] +window.MediaController.prototype [object MediaControllerPrototype] +window.MediaController.prototype.addEventListener [function] +window.MediaController.prototype.dispatchEvent [function] +window.MediaController.prototype.pause [function] +window.MediaController.prototype.play [function] +window.MediaController.prototype.removeEventListener [function] window.MediaError [object MediaErrorConstructor] window.MediaError.MEDIA_ERR_ABORTED [number] window.MediaError.MEDIA_ERR_DECODE [number] @@ -2458,7 +2465,6 @@ window.onmousewheel [null] window.onoffline [null] window.ononline [null] -window.onorientationchange [null] window.onpagehide [null] window.onpageshow [null] window.onpause [null] @@ -2492,7 +2498,6 @@ window.onwebkittransitionend [null] window.open [function] window.openDatabase [function] -window.orientation [number] window.outerHeight [number] window.outerWidth [number] window.pageXOffset [number] Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt (100253 => 100254) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-11-15 09:37:30 UTC (rev 100253) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-11-15 09:47:36 UTC (rev 100254) @@ -43,8 +43,6 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'DOMStringMap') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'DOMTokenList') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'Date') is 'object' -PASS typeof Object.getOwnPropertyDescriptor(window, 'DeviceMotionEvent') is 'object' -PASS typeof Object.getOwnPropertyDescriptor(window, 'DeviceOrientationEvent') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window,
[webkit-changes] [100256] trunk
Title: [100256] trunk Revision 100256 Author hausm...@webkit.org Date 2011-11-15 02:34:20 -0800 (Tue, 15 Nov 2011) Log Message [Qt] REGRESSION(100123): It made inspector tests crash https://bugs.webkit.org/show_bug.cgi?id=72274 Reviewed by Tor Arne Vestbø. Source/WebCore: * platform/qt/RenderThemeQStyle.h: Remove uninitialized and duplicated m_page member that should really come from RenderThemeQt. LayoutTests: * platform/qt/Skipped: Unskip passing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/qt/RenderThemeQStyle.h Diff Modified: trunk/LayoutTests/ChangeLog (100255 => 100256) --- trunk/LayoutTests/ChangeLog 2011-11-15 09:56:38 UTC (rev 100255) +++ trunk/LayoutTests/ChangeLog 2011-11-15 10:34:20 UTC (rev 100256) @@ -1,3 +1,12 @@ +2011-11-15 Simon Hausmann simon.hausm...@nokia.com + +[Qt] REGRESSION(100123): It made inspector tests crash +https://bugs.webkit.org/show_bug.cgi?id=72274 + +Reviewed by Tor Arne Vestbø. + +* platform/qt/Skipped: Unskip passing tests. + 2011-11-15 Oliver Varga voli...@inf.u-szeged.hu Unviewed gardening after r100159. Modified: trunk/LayoutTests/platform/qt/Skipped (100255 => 100256) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-15 09:56:38 UTC (rev 100255) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-15 10:34:20 UTC (rev 100256) @@ -2507,11 +2507,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=72252 http/tests/misc/xslt-bad-import.html -# [Qt] REGRESSION(100123): It made inspector tests crash -# https://bugs.webkit.org/show_bug.cgi?id=72274 -inspector/timeline -inspector/user-metrics.html - # [Qt] fast/dom/Window/window-postmessage-arrays.html fails after r100239 # https://bugs.webkit.org/show_bug.cgi?id=72363 fast/dom/Window/window-postmessage-arrays.html Modified: trunk/Source/WebCore/ChangeLog (100255 => 100256) --- trunk/Source/WebCore/ChangeLog 2011-11-15 09:56:38 UTC (rev 100255) +++ trunk/Source/WebCore/ChangeLog 2011-11-15 10:34:20 UTC (rev 100256) @@ -1,3 +1,13 @@ +2011-11-15 Simon Hausmann simon.hausm...@nokia.com + +[Qt] REGRESSION(100123): It made inspector tests crash +https://bugs.webkit.org/show_bug.cgi?id=72274 + +Reviewed by Tor Arne Vestbø. + +* platform/qt/RenderThemeQStyle.h: Remove uninitialized and duplicated +m_page member that should really come from RenderThemeQt. + 2011-11-15 Gyuyoung Kim gyuyoung@samsung.com Unreviewed. Fix build breaks when EFL port is built. Modified: trunk/Source/WebCore/platform/qt/RenderThemeQStyle.h (100255 => 100256) --- trunk/Source/WebCore/platform/qt/RenderThemeQStyle.h 2011-11-15 09:56:38 UTC (rev 100255) +++ trunk/Source/WebCore/platform/qt/RenderThemeQStyle.h 2011-11-15 10:34:20 UTC (rev 100256) @@ -108,8 +108,6 @@ QStyle* fallbackStyle() const; -Page* m_page; - #ifdef Q_OS_MAC int m_buttonFontPixelSize; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100257] trunk/LayoutTests
Title: [100257] trunk/LayoutTests Revision 100257 Author to...@chromium.org Date 2011-11-15 02:37:07 -0800 (Tue, 15 Nov 2011) Log Message media/track/track-webvtt-tc003-newlines.html is flaky https://bugs.webkit.org/show_bug.cgi?id=72369 * platform/chromium/test_expectations.txt: Marked test flaky. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100256 => 100257) --- trunk/LayoutTests/ChangeLog 2011-11-15 10:34:20 UTC (rev 100256) +++ trunk/LayoutTests/ChangeLog 2011-11-15 10:37:07 UTC (rev 100257) @@ -1,3 +1,10 @@ +2011-11-15 Tony Gentilcore to...@chromium.org + +media/track/track-webvtt-tc003-newlines.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=72369 + +* platform/chromium/test_expectations.txt: Marked test flaky. + 2011-11-15 Simon Hausmann simon.hausm...@nokia.com [Qt] REGRESSION(100123): It made inspector tests crash Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100256 => 100257) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 10:34:20 UTC (rev 100256) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 10:37:07 UTC (rev 100257) @@ -3870,5 +3870,6 @@ BUGWK72272 WIN : security/crypto-random-values-types.html = TEXT PASS BUGWK72279 : media/track/track-webvtt-tc004-magic-header.html = TIMEOUT PASS +BUGWK72369 : media/track/track-webvtt-tc003-newlines.html = TEXT PASS BUGWK59771 WIN : http/tests/inspector/resource-tree/resource-tree-frame-add.html = TIMEOUT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100258] trunk/Source
Title: [100258] trunk/Source
Revision 100258
Author hc...@chromium.org
Date 2011-11-15 02:52:27 -0800 (Tue, 15 Nov 2011)
Log Message
[chromium] scroll deltas are cleared during commit to the main thread
https://bugs.webkit.org/show_bug.cgi?id=71916
Reviewed by James Robinson.
Source/WebCore:
Patch is covered by unit test.
Add a member m_sentScrollDelta to CCLayerImpl to keep track of the scroll delta being
sent to the main thread during commit. This gives a simpler approach to keep tracking of a
layer's scroll delta in impl thread.
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::sentScrollDelta):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::sentScrollDelta):
(WebCore::CCLayerImpl::setSentScrollDelta):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
Source/WebKit/chromium:
Modify test to verify sentScrollDeltas() values of CCLayerImpl during commit.
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100257 => 100258)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 10:37:07 UTC (rev 100257)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 10:52:27 UTC (rev 100258)
@@ -1,3 +1,25 @@
+2011-11-15 Alpha Lam hc...@chromium.org
+
+[chromium] scroll deltas are cleared during commit to the main thread
+https://bugs.webkit.org/show_bug.cgi?id=71916
+
+Reviewed by James Robinson.
+
+Patch is covered by unit test.
+
+Add a member m_sentScrollDelta to CCLayerImpl to keep track of the scroll delta being
+sent to the main thread during commit. This gives a simpler approach to keep tracking of a
+layer's scroll delta in impl thread.
+
+* platform/graphics/chromium/LayerChromium.h:
+(WebCore::LayerChromium::sentScrollDelta):
+* platform/graphics/chromium/cc/CCLayerImpl.h:
+(WebCore::CCLayerImpl::sentScrollDelta):
+(WebCore::CCLayerImpl::setSentScrollDelta):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+
2011-11-15 Simon Hausmann simon.hausm...@nokia.com
[Qt] REGRESSION(100123): It made inspector tests crash
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp (100257 => 100258)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2011-11-15 10:37:07 UTC (rev 100257)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2011-11-15 10:52:27 UTC (rev 100258)
@@ -301,6 +301,7 @@
layer-setSublayerTransform(m_sublayerTransform);
layer-setTransform(m_transform);
layer-setUpdateRect(m_updateRect);
+layer-setSentScrollDelta(IntSize());
if (maskLayer())
maskLayer()-pushPropertiesTo(layer-maskLayer());
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h (100257 => 100258)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h 2011-11-15 10:37:07 UTC (rev 100257)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h 2011-11-15 10:52:27 UTC (rev 100258)
@@ -163,6 +163,9 @@
float scaleDelta() const { return m_scaleDelta; }
void setScaleDelta(float);
+const IntSize sentScrollDelta() const { return m_sentScrollDelta; }
+void setSentScrollDelta(const IntSize sentScrollDelta) { m_sentScrollDelta = sentScrollDelta; }
+
void scrollBy(const IntSize scroll);
bool scrollable() const { return m_scrollable; }
@@ -248,6 +251,7 @@
bool m_drawsContent;
IntSize m_scrollDelta;
+IntSize m_sentScrollDelta;
IntSize m_maxScrollPosition;
float m_scaleDelta;
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (100257 => 100258)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2011-11-15 10:37:07 UTC (rev 100257)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2011-11-15 10:52:27 UTC (rev 100258)
@@ -342,6 +342,7 @@
m_scrollLayerImpl-setScrollPosition(m_scrollLayerImpl-scrollPosition() + m_scrollLayerImpl-scrollDelta());
m_scrollLayerImpl-setPosition(m_scrollLayerImpl-position() - m_scrollLayerImpl-scrollDelta());
+m_scrollLayerImpl-setSentScrollDelta(m_scrollLayerImpl-scrollDelta());
m_scrollLayerImpl-setScrollDelta(IntSize());
return scrollInfo.release();
Modified:
[webkit-changes] [100259] trunk/LayoutTests
Title: [100259] trunk/LayoutTests Revision 100259 Author o...@webkit.org Date 2011-11-15 02:59:07 -0800 (Tue, 15 Nov 2011) Log Message [Qt] Unviewed fix after r100254, because committed results was incorrect. * platform/qt/fast/dom/Window/window-properties-expected.png: * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-property-descriptors-expected.png: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt/fast/dom/constructed-objects-prototypes-expected.png: Added. * platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added. * platform/qt/fast/js/global-constructors-expected.png: * platform/qt/fast/js/global-constructors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.png trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.png trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt Added Paths trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.png trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100258 => 100259) --- trunk/LayoutTests/ChangeLog 2011-11-15 10:52:27 UTC (rev 100258) +++ trunk/LayoutTests/ChangeLog 2011-11-15 10:59:07 UTC (rev 100259) @@ -1,3 +1,16 @@ +2011-11-15 Csaba Osztrogonác o...@webkit.org + +[Qt] Unviewed fix after r100254, because committed results was incorrect. + +* platform/qt/fast/dom/Window/window-properties-expected.png: +* platform/qt/fast/dom/Window/window-properties-expected.txt: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/qt/fast/dom/constructed-objects-prototypes-expected.png: Added. +* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added. +* platform/qt/fast/js/global-constructors-expected.png: +* platform/qt/fast/js/global-constructors-expected.txt: + 2011-11-15 Tony Gentilcore to...@chromium.org media/track/track-webvtt-tc003-newlines.html is flaky Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (100258 => 100259) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-15 10:52:27 UTC (rev 100258) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-11-15 10:59:07 UTC (rev 100259) @@ -2465,6 +2465,7 @@ window.onmousewheel [null] window.onoffline [null] window.ononline [null] +window.onorientationchange [null] window.onpagehide [null] window.onpageshow [null] window.onpause [null] @@ -2498,6 +2499,7 @@ window.onwebkittransitionend [null] window.open [function] window.openDatabase [function] +window.orientation [number] window.outerHeight [number] window.outerWidth [number] window.pageXOffset [number] Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt (100258 => 100259) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-11-15 10:52:27 UTC (rev 100258) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-11-15 10:59:07 UTC (rev 100259) @@ -43,6 +43,8 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'DOMStringMap') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'DOMTokenList') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'Date') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'DeviceMotionEvent') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'DeviceOrientationEvent') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'Document') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'DocumentFragment') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'DocumentType') is 'object' @@ -388,6 +390,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'onclick') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'oncontextmenu') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'ondblclick') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'ondevicemotion') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'ondrag') is
[webkit-changes] [100261] trunk/Source/WebKit/efl
Title: [100261] trunk/Source/WebKit/efl
Revision 100261
Author commit-qu...@webkit.org
Date 2011-11-15 03:03:40 -0800 (Tue, 15 Nov 2011)
Log Message
[EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFETY_ON_FALSE_RETURN_VAL.
https://bugs.webkit.org/show_bug.cgi?id=70091
Patch by Grzegorz Czajkowski g.czajkow...@samsung.com on 2011-11-15
Reviewed by Filip Pizlo.
Replaces EINA_SAFETY_ON_FALSE_RETURN_VAL by EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks in compliance
with WebKit-EFL functions.
* ewk/ewk_frame.cpp:
(ewk_frame_contents_set):
(ewk_frame_contents_alternate_set):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (100260 => 100261)
--- trunk/Source/WebKit/efl/ChangeLog 2011-11-15 11:01:35 UTC (rev 100260)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-11-15 11:03:40 UTC (rev 100261)
@@ -1,3 +1,17 @@
+2011-11-15 Grzegorz Czajkowski g.czajkow...@samsung.com
+
+[EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFETY_ON_FALSE_RETURN_VAL.
+https://bugs.webkit.org/show_bug.cgi?id=70091
+
+Reviewed by Filip Pizlo.
+
+Replaces EINA_SAFETY_ON_FALSE_RETURN_VAL by EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks in compliance
+with WebKit-EFL functions.
+
+* ewk/ewk_frame.cpp:
+(ewk_frame_contents_set):
+(ewk_frame_contents_alternate_set):
+
2011-11-14 Jongseok Yang js45.y...@samsung.com
[EFL] Update ewk_frame_script_execute to return the result for _javascript_
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (100260 => 100261)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-11-15 11:01:35 UTC (rev 100260)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-11-15 11:03:40 UTC (rev 100261)
@@ -399,7 +399,7 @@
Eina_Bool ewk_frame_contents_set(Evas_Object* ewkFrame, const char* contents, size_t contentsSize, const char* mimeType, const char* encoding, const char* baseUri)
{
EWK_FRAME_SD_GET_OR_RETURN(ewkFrame, smartData, false);
-EINA_SAFETY_ON_FALSE_RETURN_VAL(smartData-frame, false);
+EINA_SAFETY_ON_NULL_RETURN_VAL(smartData-frame, false);
EINA_SAFETY_ON_NULL_RETURN_VAL(contents, false);
return _ewk_frame_contents_set_internal
(smartData, contents, contentsSize, mimeType, encoding, baseUri, 0);
@@ -408,7 +408,7 @@
Eina_Bool ewk_frame_contents_alternate_set(Evas_Object* ewkFrame, const char* contents, size_t contentsSize, const char* mimeType, const char* encoding, const char* baseUri, const char* unreachableUri)
{
EWK_FRAME_SD_GET_OR_RETURN(ewkFrame, smartData, false);
-EINA_SAFETY_ON_FALSE_RETURN_VAL(smartData-frame, false);
+EINA_SAFETY_ON_NULL_RETURN_VAL(smartData-frame, false);
EINA_SAFETY_ON_NULL_RETURN_VAL(contents, false);
EINA_SAFETY_ON_NULL_RETURN_VAL(unreachableUri, false);
return _ewk_frame_contents_set_internal
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100262] trunk
Title: [100262] trunk Revision 100262 Author commit-qu...@webkit.org Date 2011-11-15 03:14:49 -0800 (Tue, 15 Nov 2011) Log Message Unreviewed, rolling out r100213. http://trac.webkit.org/changeset/100213 https://bugs.webkit.org/show_bug.cgi?id=72371 Breaks test_shell_tests (Requested by tonyg-cr on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-15 Source/WebCore: * page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): * platform/SchemeRegistry.cpp: (WebCore::schemesWithUniqueOrigins): LayoutTests: * fast/filesystem/async-operations-expected.txt: * fast/filesystem/not-enough-arguments-expected.txt: * fast/filesystem/read-directory-expected.txt: * fast/filesystem/simple-persistent-expected.txt: * fast/filesystem/simple-readonly-expected.txt: * fast/filesystem/simple-temporary-expected.txt: * fast/frames/resources/sandboxed-iframe-storage-disallowed.html: * fast/frames/sandboxed-iframe-attribute-parsing.html: * fast/frames/sandboxed-iframe-forms-dynamic.html: * fast/frames/sandboxed-iframe-forms.html: * fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html: * fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html: * fast/frames/sandboxed-iframe-navigation-top-by-name.html: * fast/frames/sandboxed-iframe-navigation-top.html: * media/video-controls-no-scripting.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/filesystem/async-operations-expected.txt trunk/LayoutTests/fast/filesystem/not-enough-arguments-expected.txt trunk/LayoutTests/fast/filesystem/read-directory-expected.txt trunk/LayoutTests/fast/filesystem/simple-persistent-expected.txt trunk/LayoutTests/fast/filesystem/simple-readonly-expected.txt trunk/LayoutTests/fast/filesystem/simple-temporary-expected.txt trunk/LayoutTests/fast/frames/resources/sandboxed-iframe-storage-disallowed.html trunk/LayoutTests/fast/frames/sandboxed-iframe-attribute-parsing.html trunk/LayoutTests/fast/frames/sandboxed-iframe-forms-dynamic.html trunk/LayoutTests/fast/frames/sandboxed-iframe-forms.html trunk/LayoutTests/fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html trunk/LayoutTests/fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html trunk/LayoutTests/fast/frames/sandboxed-iframe-navigation-top-by-name.html trunk/LayoutTests/fast/frames/sandboxed-iframe-navigation-top.html trunk/LayoutTests/media/video-controls-no-scripting.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/SecurityOrigin.cpp trunk/Source/WebCore/platform/SchemeRegistry.cpp Diff Modified: trunk/LayoutTests/ChangeLog (100261 => 100262) --- trunk/LayoutTests/ChangeLog 2011-11-15 11:03:40 UTC (rev 100261) +++ trunk/LayoutTests/ChangeLog 2011-11-15 11:14:49 UTC (rev 100262) @@ -1,3 +1,27 @@ +2011-11-15 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r100213. +http://trac.webkit.org/changeset/100213 +https://bugs.webkit.org/show_bug.cgi?id=72371 + +Breaks test_shell_tests (Requested by tonyg-cr on #webkit). + +* fast/filesystem/async-operations-expected.txt: +* fast/filesystem/not-enough-arguments-expected.txt: +* fast/filesystem/read-directory-expected.txt: +* fast/filesystem/simple-persistent-expected.txt: +* fast/filesystem/simple-readonly-expected.txt: +* fast/filesystem/simple-temporary-expected.txt: +* fast/frames/resources/sandboxed-iframe-storage-disallowed.html: +* fast/frames/sandboxed-iframe-attribute-parsing.html: +* fast/frames/sandboxed-iframe-forms-dynamic.html: +* fast/frames/sandboxed-iframe-forms.html: +* fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html: +* fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html: +* fast/frames/sandboxed-iframe-navigation-top-by-name.html: +* fast/frames/sandboxed-iframe-navigation-top.html: +* media/video-controls-no-scripting.html: + 2011-11-15 Csaba Osztrogonác o...@webkit.org [Qt] Unviewed fix after r100254, because committed results was incorrect. Modified: trunk/LayoutTests/fast/filesystem/async-operations-expected.txt (100261 => 100262) --- trunk/LayoutTests/fast/filesystem/async-operations-expected.txt 2011-11-15 11:03:40 UTC (rev 100261) +++ trunk/LayoutTests/fast/filesystem/async-operations-expected.txt 2011-11-15 11:14:49 UTC (rev 100262) @@ -4,7 +4,7 @@ requested FileSystem. -Got FileSystem:__0:Temporary +Got FileSystem:file__0:Temporary Starting async test stage 1. Starting async test stage 2. Verifying the FileSystem status. Modified: trunk/LayoutTests/fast/filesystem/not-enough-arguments-expected.txt (100261 => 100262) --- trunk/LayoutTests/fast/filesystem/not-enough-arguments-expected.txt 2011-11-15 11:03:40 UTC (rev 100261) +++ trunk/LayoutTests/fast/filesystem/not-enough-arguments-expected.txt 2011-11-15 11:14:49 UTC (rev 100262) @@ -3,7 +3,7 @@ On success, you will see
[webkit-changes] [100263] trunk/LayoutTests
Title: [100263] trunk/LayoutTests Revision 100263 Author to...@chromium.org Date 2011-11-15 03:24:26 -0800 (Tue, 15 Nov 2011) Log Message [chromium] perf/document-contains.html is flaky on win https://bugs.webkit.org/show_bug.cgi?id=72372 * platform/chromium/test_expectations.txt: Marking flaky on WIN. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100262 => 100263) --- trunk/LayoutTests/ChangeLog 2011-11-15 11:14:49 UTC (rev 100262) +++ trunk/LayoutTests/ChangeLog 2011-11-15 11:24:26 UTC (rev 100263) @@ -1,3 +1,10 @@ +2011-11-15 Tony Gentilcore to...@chromium.org + +[chromium] perf/document-contains.html is flaky on win +https://bugs.webkit.org/show_bug.cgi?id=72372 + +* platform/chromium/test_expectations.txt: Marking flaky on WIN. + 2011-11-15 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r100213. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100262 => 100263) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 11:14:49 UTC (rev 100262) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 11:24:26 UTC (rev 100263) @@ -2174,7 +2174,8 @@ BUGWK44199 RELEASE SLOW : perf/array-nested-loop.html = PASS TEXT BUGWK44199 RELEASE SLOW : perf/class-list-remove.html = PASS TEXT -BUGWK71652 RELEASE SLOW : perf/document-contains.html = PASS +BUGWK71652 MAC LINUX RELEASE SLOW : perf/document-contains.html = PASS +BUGWK72372 WIN RELEASE SLOW : perf/document-contains.html = PASS TEXT BUGWK67921 RELEASE SLOW : perf/show-hide-table-rows.html = PASS BUGWK44199 RELEASE : perf/clone-with-focus.html = PASS TEXT BUGWK44199 RELEASE : perf/typing-at-end-of-line.html = PASS TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100265] trunk/Tools
Title: [100265] trunk/Tools Revision 100265 Author hausm...@webkit.org Date 2011-11-15 03:33:33 -0800 (Tue, 15 Nov 2011) Log Message [Qt] Unreviewed prospective --minimal build fix. * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0 and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro Diff Modified: trunk/Tools/ChangeLog (100264 => 100265) --- trunk/Tools/ChangeLog 2011-11-15 11:30:46 UTC (rev 100264) +++ trunk/Tools/ChangeLog 2011-11-15 11:33:33 UTC (rev 100265) @@ -1,5 +1,12 @@ 2011-11-15 Simon Hausmann simon.hausm...@nokia.com +[Qt] Unreviewed prospective --minimal build fix. + +* DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0 +and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time. + +2011-11-15 Simon Hausmann simon.hausm...@nokia.com + [Qt] Unreviewed --minimal build fix. * Scripts/build-webkit: Add to DEFINES+= from @options only if there is Modified: trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro (100264 => 100265) --- trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro 2011-11-15 11:30:46 UTC (rev 100264) +++ trunk/Tools/DumpRenderTree/qt/DumpRenderTree.pro 2011-11-15 11:33:33 UTC (rev 100265) @@ -53,6 +53,7 @@ LIBS += $$WCECOMPAT/lib/wcecompat.lib } +DEFINES -= USE_SYSTEM_MALLOC=0 DEFINES += USE_SYSTEM_MALLOC=1 RESOURCES = DumpRenderTree.qrc ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100266] trunk
Title: [100266] trunk
Revision 100266
Author hausm...@webkit.org
Date 2011-11-15 04:02:19 -0800 (Tue, 15 Nov 2011)
Log Message
[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
Reviewed by Tor Arne Vestbø.
.:
* Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
Source/_javascript_Core:
* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
Source/WebCore:
* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
Tools:
* qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
magic here where we handle all TEMPLATE = lib .pro files.
Modified Paths
trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Target.pri
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/api.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf
Diff
Modified: trunk/ChangeLog (100265 => 100266)
--- trunk/ChangeLog 2011-11-15 11:33:33 UTC (rev 100265)
+++ trunk/ChangeLog 2011-11-15 12:02:19 UTC (rev 100266)
@@ -1,3 +1,11 @@
+2011-11-15 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
+
+Reviewed by Tor Arne Vestbø.
+
+* Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
+
2011-11-14 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
Modified: trunk/Source/_javascript_Core/ChangeLog (100265 => 100266)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-15 11:33:33 UTC (rev 100265)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-15 12:02:19 UTC (rev 100266)
@@ -1,3 +1,11 @@
+2011-11-15 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
+
+Reviewed by Tor Arne Vestbø.
+
+* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
+
2011-11-15 Yuqiang Xian yuqiang.x...@intel.com
Remove DFGJITCompilerInlineMethods
Modified: trunk/Source/_javascript_Core/Target.pri (100265 => 100266)
--- trunk/Source/_javascript_Core/Target.pri 2011-11-15 11:33:33 UTC (rev 100265)
+++ trunk/Source/_javascript_Core/Target.pri 2011-11-15 12:02:19 UTC (rev 100266)
@@ -20,9 +20,6 @@
QT += core
QT -= gui
-contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
-unix:contains(QT_CONFIG, reduce_relocations):CONFIG += bsymbolic_functions
-
*-g++*:QMAKE_CXXFLAGS_RELEASE -= -O2
*-g++*:QMAKE_CXXFLAGS_RELEASE += -O3
Modified: trunk/Source/WebCore/ChangeLog (100265 => 100266)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 11:33:33 UTC (rev 100265)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 12:02:19 UTC (rev 100266)
@@ -1,3 +1,11 @@
+2011-11-15 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
+
+Reviewed by Tor Arne Vestbø.
+
+* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
+
2011-11-15 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r100213.
Modified: trunk/Source/WebCore/Target.pri (100265 => 100266)
--- trunk/Source/WebCore/Target.pri 2011-11-15 11:33:33 UTC (rev 100265)
+++ trunk/Source/WebCore/Target.pri 2011-11-15 12:02:19 UTC (rev 100266)
@@ -18,8 +18,6 @@
DEFINES += QT_MAKEDLL
-contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
-
haveQt(5) {
# Add a QtScript dependency for the time being, in order to pull in the include
# path for QtScript when it's built as a standalone module
Modified: trunk/Source/api.pri (100265 => 100266)
--- trunk/Source/api.pri 2011-11-15 11:33:33 UTC (rev 100265)
+++ trunk/Source/api.pri 2011-11-15 12:02:19 UTC (rev 100266)
@@ -35,11 +35,6 @@
contains(DEFINES, ENABLE_WEBGL=1)|contains(CONFIG, texmap): LIBS += $$QMAKE_LIBS_OPENGL
}
-CONFIG(release) {
-contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
-unix:contains(QT_CONFIG, reduce_relocations):CONFIG += bsymbolic_functions
-}
-
!static: DEFINES += QT_MAKEDLL
SOURCES += \
Modified: trunk/Tools/ChangeLog (100265 => 100266)
--- trunk/Tools/ChangeLog 2011-11-15 11:33:33 UTC (rev 100265)
+++ trunk/Tools/ChangeLog 2011-11-15 12:02:19 UTC (rev 100266)
@@ -1,5 +1,14 @@
2011-11-15 Simon Hausmann simon.hausm...@nokia.com
+[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
+
+Reviewed by Tor Arne Vestbø.
+
+* qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
+magic here where we handle all TEMPLATE = lib .pro files.
+
[webkit-changes] [100267] trunk/LayoutTests
Title: [100267] trunk/LayoutTests Revision 100267 Author to...@chromium.org Date 2011-11-15 04:35:12 -0800 (Tue, 15 Nov 2011) Log Message [chromium] fast/forms/file/input-file-label.html is flaky on win https://bugs.webkit.org/show_bug.cgi?id=72376 * platform/chromium/test_expectations.txt: Mark test flaky on win. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100266 => 100267) --- trunk/LayoutTests/ChangeLog 2011-11-15 12:02:19 UTC (rev 100266) +++ trunk/LayoutTests/ChangeLog 2011-11-15 12:35:12 UTC (rev 100267) @@ -1,3 +1,10 @@ +2011-11-15 Tony Gentilcore to...@chromium.org + +[chromium] fast/forms/file/input-file-label.html is flaky on win +https://bugs.webkit.org/show_bug.cgi?id=72376 + +* platform/chromium/test_expectations.txt: Mark test flaky on win. + 2011-11-15 Noel Gordon noel.gor...@gmail.com Rebaseline gray-scale-jpeg-with-color-profile.html Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100266 => 100267) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 12:02:19 UTC (rev 100266) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 12:35:12 UTC (rev 100267) @@ -3873,3 +3873,5 @@ BUGWK72369 : media/track/track-webvtt-tc003-newlines.html = TEXT PASS BUGWK59771 WIN : http/tests/inspector/resource-tree/resource-tree-frame-add.html = TIMEOUT PASS + +BUGWK72376 WIN : fast/forms/file/input-file-label.html = TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100268] trunk/LayoutTests
Title: [100268] trunk/LayoutTests Revision 100268 Author o...@webkit.org Date 2011-11-15 05:02:24 -0800 (Tue, 15 Nov 2011) Log Message REGRESSION(r100182): It broke 2 http/tests/security tests https://bugs.webkit.org/show_bug.cgi?id=72364 * platform/qt/Skipped: Skip failing tests until fix. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100267 => 100268) --- trunk/LayoutTests/ChangeLog 2011-11-15 12:35:12 UTC (rev 100267) +++ trunk/LayoutTests/ChangeLog 2011-11-15 13:02:24 UTC (rev 100268) @@ -1,3 +1,10 @@ +2011-11-15 Csaba Osztrogonác o...@webkit.org + +REGRESSION(r100182): It broke 2 http/tests/security tests +https://bugs.webkit.org/show_bug.cgi?id=72364 + +* platform/qt/Skipped: Skip failing tests until fix. + 2011-11-15 Tony Gentilcore to...@chromium.org [chromium] fast/forms/file/input-file-label.html is flaky on win Modified: trunk/LayoutTests/platform/qt/Skipped (100267 => 100268) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-15 12:35:12 UTC (rev 100267) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-15 13:02:24 UTC (rev 100268) @@ -2511,6 +2511,7 @@ # https://bugs.webkit.org/show_bug.cgi?id=72363 fast/dom/Window/window-postmessage-arrays.html -# [Qt] http/tests/security/postMessage/invalid-origin-throws-exception.html fails after r100182 +# REGRESSION(r100182): It broke 2 http/tests/security tests # https://bugs.webkit.org/show_bug.cgi?id=72364 +http/tests/security/cross-frame-access-enumeration.html http/tests/security/postMessage/invalid-origin-throws-exception.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100269] trunk/Source
Title: [100269] trunk/Source
Revision 100269
Author pfeld...@chromium.org
Date 2011-11-15 05:38:23 -0800 (Tue, 15 Nov 2011)
Log Message
Web Inspector: move generic code from DevTools.js into the WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72377
This includes support for themed toolbar, remote debugging routines,
removes a couple of obsolete overrides from the DevTools.js
Reviewed by Yury Semikhatsky.
Source/WebCore:
* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/Resource.js:
* inspector/front-end/Settings.js:
* inspector/front-end/UIUtils.js:
(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):
* inspector/front-end/inspector.js:
Source/WebKit/chromium:
* src/js/DevTools.js:
(WebInspector.setInspectedTabId):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
trunk/Source/WebCore/inspector/front-end/Resource.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/UIUtils.js
trunk/Source/WebCore/inspector/front-end/inspector.js
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/DevTools.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (100268 => 100269)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 13:02:24 UTC (rev 100268)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 13:38:23 UTC (rev 100269)
@@ -1,3 +1,24 @@
+2011-11-15 Pavel Feldman pfeld...@google.com
+
+Web Inspector: move generic code from DevTools.js into the WebCore.
+https://bugs.webkit.org/show_bug.cgi?id=72377
+
+This includes support for themed toolbar, remote debugging routines,
+removes a couple of obsolete overrides from the DevTools.js
+
+Reviewed by Yury Semikhatsky.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/InspectorFrontendHostStub.js:
+(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
+* inspector/front-end/ProfilesPanel.js:
+* inspector/front-end/Resource.js:
+* inspector/front-end/Settings.js:
+* inspector/front-end/UIUtils.js:
+(WebInspector.setToolbarColors):
+(WebInspector.resetToolbarColors):
+* inspector/front-end/inspector.js:
+
2011-11-15 Simon Hausmann simon.hausm...@nokia.com
[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js (100268 => 100269)
--- trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js 2011-11-15 13:02:24 UTC (rev 100268)
+++ trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js 2011-11-15 13:38:23 UTC (rev 100269)
@@ -110,6 +110,7 @@
inspectedURLChanged: function(url)
{
+document.title = WebInspector.UIString(Preferences.applicationTitle, url);
},
copyText: function()
Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (100268 => 100269)
--- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2011-11-15 13:02:24 UTC (rev 100268)
+++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2011-11-15 13:38:23 UTC (rev 100269)
@@ -119,6 +119,8 @@
this.enableToggleButton = new WebInspector.StatusBarButton(, enable-toggle-status-bar-item);
this.enableToggleButton.addEventListener(click, this._toggleProfiling.bind(this), false);
+if (Preferences.profilerAlwaysEnabled)
+this.enableToggleButton.element.addStyleClass(hidden);
this.clearResultsButton = new WebInspector.StatusBarButton(WebInspector.UIString(Clear all profiles.), clear-status-bar-item);
this.clearResultsButton.addEventListener(click, this._clearProfiles.bind(this), false);
Modified: trunk/Source/WebCore/inspector/front-end/Resource.js (100268 => 100269)
--- trunk/Source/WebCore/inspector/front-end/Resource.js 2011-11-15 13:02:24 UTC (rev 100268)
+++ trunk/Source/WebCore/inspector/front-end/Resource.js 2011-11-15 13:38:23 UTC (rev 100269)
@@ -44,6 +44,7 @@
image/bmp: {2: true},
image/svg+xml: {2: true},
image/vnd.microsoft.icon:{2: true},
+image/webp: {2: true},
image/x-icon:{2: true},
image/x-xbitmap: {2: true},
font/ttf:{3: true},
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (100268 => 100269)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2011-11-15 13:02:24 UTC (rev 100268)
+++
[webkit-changes] [100270] trunk/Source/WebCore
Title: [100270] trunk/Source/WebCore
Revision 100270
Author commit-qu...@webkit.org
Date 2011-11-15 05:43:36 -0800 (Tue, 15 Nov 2011)
Log Message
[Qt] Clean up the remaining duplicate code after the RenderThemeQt refactoring.
https://bugs.webkit.org/show_bug.cgi?id=72262
Patch by Pierre Rossi pierre.ro...@gmail.com on 2011-11-15
Reviewed by Antonio Gomes.
No new tests needed, this is purely cosmetic.
* platform/qt/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
* platform/qt/RenderThemeQStyle.h:
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustMenuListButtonStyle): remove the call to resetBorderRadius()
since the mobile theme actually didn't do this.
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/RenderThemeQStyle.cpp
trunk/Source/WebCore/platform/qt/RenderThemeQStyle.h
trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp
trunk/Source/WebCore/platform/qt/RenderThemeQtMobile.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100269 => 100270)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 13:38:23 UTC (rev 100269)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 13:43:36 UTC (rev 100270)
@@ -1,3 +1,21 @@
+2011-11-15 Pierre Rossi pierre.ro...@gmail.com
+
+[Qt] Clean up the remaining duplicate code after the RenderThemeQt refactoring.
+https://bugs.webkit.org/show_bug.cgi?id=72262
+
+Reviewed by Antonio Gomes.
+
+No new tests needed, this is purely cosmetic.
+
+* platform/qt/RenderThemeQStyle.cpp:
+(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
+* platform/qt/RenderThemeQStyle.h:
+* platform/qt/RenderThemeQt.cpp:
+(WebCore::RenderThemeQt::adjustMenuListButtonStyle): remove the call to resetBorderRadius()
+since the mobile theme actually didn't do this.
+* platform/qt/RenderThemeQtMobile.cpp:
+(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
+
2011-11-15 Pavel Feldman pfeld...@google.com
Web Inspector: move generic code from DevTools.js into the WebCore.
Modified: trunk/Source/WebCore/platform/qt/RenderThemeQStyle.cpp (100269 => 100270)
--- trunk/Source/WebCore/platform/qt/RenderThemeQStyle.cpp 2011-11-15 13:38:23 UTC (rev 100269)
+++ trunk/Source/WebCore/platform/qt/RenderThemeQStyle.cpp 2011-11-15 13:43:36 UTC (rev 100270)
@@ -382,19 +382,6 @@
return false;
}
-void RenderThemeQStyle::adjustTextFieldStyle(CSSStyleSelector*, RenderStyle* style, Element*) const
-{
-// Resetting the style like this leads to differences like:
-// - RenderTextControl {INPUT} at (2,2) size 168x25 [bgcolor=#FF] border: (2px inset #00)]
-// + RenderTextControl {INPUT} at (2,2) size 166x26
-// in layout tests when a CSS style is applied that doesn't affect background color, border or
-// padding. Just worth keeping in mind!
-style-setBackgroundColor(Color::transparent);
-style-resetBorder();
-style-resetPadding();
-computeSizeBasedOnStyle(style);
-}
-
bool RenderThemeQStyle::paintTextField(RenderObject* o, const PaintInfo i, const IntRect r)
{
StylePainterQStyle p(this, i);
@@ -477,22 +464,13 @@
return false;
}
-void RenderThemeQStyle::adjustMenuListButtonStyle(CSSStyleSelector*, RenderStyle* style, Element*) const
+void RenderThemeQStyle::adjustMenuListButtonStyle(CSSStyleSelector* selector, RenderStyle* style, Element* e) const
{
// WORKAROUND because html.css specifies -webkit-border-radius for select so we override it here
// see also http://bugs.webkit.org/show_bug.cgi?id=18399
style-resetBorderRadius();
-// Height is locked to auto.
-style-setHeight(Length(Auto));
-
-// White-space is locked to pre
-style-setWhiteSpace(PRE);
-
-computeSizeBasedOnStyle(style);
-
-// Add in the padding that we'd like to use.
-setPopupPadding(style);
+RenderThemeQt::adjustMenuListButtonStyle(selector, style, e);
}
bool RenderThemeQStyle::paintMenuListButton(RenderObject* o, const PaintInfo i,
@@ -640,20 +618,6 @@
return paintTextField(o, pi, r);
}
-void RenderThemeQStyle::adjustSearchFieldStyle(CSSStyleSelector* selector, RenderStyle* style,
- Element* e) const
-{
-// Resetting the style like this leads to differences like:
-// - RenderTextControl {INPUT} at (2,2) size 168x25 [bgcolor=#FF] border: (2px inset #00)]
-// + RenderTextControl {INPUT} at (2,2) size 166x26
-// in layout tests when a CSS style is applied that doesn't affect background color, border or
-// padding. Just worth keeping in mind!
-style-setBackgroundColor(Color::transparent);
-style-resetBorder();
-style-resetPadding();
-computeSizeBasedOnStyle(style);
-}
-
void RenderThemeQStyle::adjustSearchFieldDecorationStyle(CSSStyleSelector* selector, RenderStyle*
[webkit-changes] [100271] trunk/LayoutTests
Title: [100271] trunk/LayoutTests Revision 100271 Author ph...@webkit.org Date 2011-11-15 05:48:11 -0800 (Tue, 15 Nov 2011) Log Message Unreviewed, skipping some new GTK test failures. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100270 => 100271) --- trunk/LayoutTests/ChangeLog 2011-11-15 13:43:36 UTC (rev 100270) +++ trunk/LayoutTests/ChangeLog 2011-11-15 13:48:11 UTC (rev 100271) @@ -1,3 +1,9 @@ +2011-11-15 Philippe Normand pnorm...@igalia.com + +Unreviewed, skipping some new GTK test failures. + +* platform/gtk/Skipped: + 2011-11-15 Csaba Osztrogonác o...@webkit.org REGRESSION(r100182): It broke 2 http/tests/security tests Modified: trunk/LayoutTests/platform/gtk/Skipped (100270 => 100271) --- trunk/LayoutTests/platform/gtk/Skipped 2011-11-15 13:43:36 UTC (rev 100270) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-15 13:48:11 UTC (rev 100271) @@ -1612,4 +1612,13 @@ fast/dom/Window/window-property-descriptors.html fast/dom/Window/window-properties.html fast/dom/prototype-inheritance-2.html -fast/dom/constructed-objects-prototypes.html \ No newline at end of file +fast/dom/constructed-objects-prototypes.html + +# fast/dom/Window/window-postmessage-arrays.html fails on JSC platforms +# https://bugs.webkit.org/show_bug.cgi?id=72363 +fast/dom/Window/window-postmessage-arrays.html + +# REGRESSION(r100182): It broke 2 http/tests/security tests +# https://bugs.webkit.org/show_bug.cgi?id=72364 +http/tests/security/cross-frame-access-enumeration.html +http/tests/security/postMessage/invalid-origin-throws-exception.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100272] trunk/LayoutTests
Title: [100272] trunk/LayoutTests Revision 100272 Author ph...@webkit.org Date 2011-11-15 06:06:38 -0800 (Tue, 15 Nov 2011) Log Message REGRESSION (r100158-r100162): 5 fast tests failing on GTK Linux 64-bit Debug https://bugs.webkit.org/show_bug.cgi?id=72297 Unreviewed, GTK rebaseline after r100159. * platform/gtk/Skipped: * platform/gtk/fast/dom/Window/window-properties-expected.txt: * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: * platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Added. * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: * platform/gtk/fast/js/global-constructors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt Added Paths trunk/LayoutTests/platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100271 => 100272) --- trunk/LayoutTests/ChangeLog 2011-11-15 13:48:11 UTC (rev 100271) +++ trunk/LayoutTests/ChangeLog 2011-11-15 14:06:38 UTC (rev 100272) @@ -1,5 +1,19 @@ 2011-11-15 Philippe Normand pnorm...@igalia.com +REGRESSION (r100158-r100162): 5 fast tests failing on GTK Linux 64-bit Debug +https://bugs.webkit.org/show_bug.cgi?id=72297 + +Unreviewed, GTK rebaseline after r100159. + +* platform/gtk/Skipped: +* platform/gtk/fast/dom/Window/window-properties-expected.txt: +* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Added. +* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: +* platform/gtk/fast/js/global-constructors-expected.txt: + +2011-11-15 Philippe Normand pnorm...@igalia.com + Unreviewed, skipping some new GTK test failures. * platform/gtk/Skipped: Modified: trunk/LayoutTests/platform/gtk/Skipped (100271 => 100272) --- trunk/LayoutTests/platform/gtk/Skipped 2011-11-15 13:48:11 UTC (rev 100271) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-15 14:06:38 UTC (rev 100272) @@ -1606,14 +1606,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=72248 editing/spelling/spelling-unified-emulation.html -# REGRESSION (r100158-r100162): 5 fast tests failing on GTK Linux 64-bit Debug -# https://bugs.webkit.org/show_bug.cgi?id=72297 -fast/js/global-constructors.html -fast/dom/Window/window-property-descriptors.html -fast/dom/Window/window-properties.html -fast/dom/prototype-inheritance-2.html -fast/dom/constructed-objects-prototypes.html - # fast/dom/Window/window-postmessage-arrays.html fails on JSC platforms # https://bugs.webkit.org/show_bug.cgi?id=72363 fast/dom/Window/window-postmessage-arrays.html Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt (100271 => 100272) --- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-11-15 13:48:11 UTC (rev 100271) +++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-11-15 14:06:38 UTC (rev 100272) @@ -1251,6 +1251,13 @@ window.Math.sin [function] window.Math.sqrt [function] window.Math.tan [function] +window.MediaController [object MediaControllerConstructor] +window.MediaController.prototype [object MediaControllerPrototype] +window.MediaController.prototype.addEventListener [function] +window.MediaController.prototype.dispatchEvent [function] +window.MediaController.prototype.pause [function] +window.MediaController.prototype.play [function] +window.MediaController.prototype.removeEventListener [function] window.MediaError [object MediaErrorConstructor] window.MediaError.MEDIA_ERR_ABORTED [number] window.MediaError.MEDIA_ERR_DECODE [number] @@ -2423,6 +2430,7 @@ window.localStorage [printed above as window.Storage.prototype] window.location [object Location] window.location.assign [function] +window.location.getParameter [function] window.location.hash [string] window.location.host [string] window.location.hostname [string] Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt (100271 => 100272) --- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt 2011-11-15 13:48:11 UTC (rev 100271) +++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt 2011-11-15 14:06:38 UTC (rev 100272) @@ -135,6 +135,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'JSON') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'KeyboardEvent') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'Math') is 'object' +PASS
[webkit-changes] [100273] trunk
Title: [100273] trunk Revision 100273 Author apav...@chromium.org Date 2011-11-15 06:12:43 -0800 (Tue, 15 Nov 2011) Log Message font property does not show up as shorthand in inspector https://bugs.webkit.org/show_bug.cgi?id=15598 Reviewed by Nikolas Zimmermann. Source/WebCore: The font CSS property is turned into a real shorthand, as its longhands used to float around in the resulting style declaration without any reference to their underlying font property. Test: fast/css/font-shorthand.html * css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Extracted the font value building into fontValue(). (WebCore::CSSMutableStyleDeclaration::appendFontLonghandValueIfExplicit): Added (WebCore::CSSMutableStyleDeclaration::fontValue): Build the font value from longhands. * css/CSSMutableStyleDeclaration.h: * css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Added optional implicit parameter. (WebCore::CSSParser::parseFont): Build respective longhands instead of the shorthand font property. * css/CSSParser.h: Added optional implicit parameter to addProperty(). * css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap): Added font shorthand map entry. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyPropertyToStyle): Separated the property application from the instance setup. (WebCore::CSSStyleSelector::applyPropertyToCurrentStyle): Added. * css/CSSStyleSelector.h: Made updateFont() public. * css/FontValue.cpp: (WebCore::FontValue::customCssText): Made use of StringBuilder. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont): Apply font longhands rather than the (non-existent) font property. * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._markUsedProperties): Removed a workaround for font not being a shorthand. * page/animation/AnimationBase.cpp: (WebCore::addShorthandProperties): Removed a workaround for font not being a shorthand. LayoutTests: * fast/css/font-shorthand-expected.txt: Added. * fast/css/font-shorthand.html: Added. * fast/inspector-support/style-expected.txt: * fast/inspector-support/style.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/inspector-support/style-expected.txt trunk/LayoutTests/fast/inspector-support/style.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp trunk/Source/WebCore/css/CSSMutableStyleDeclaration.h trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSParser.h trunk/Source/WebCore/css/CSSPropertyLonghand.cpp trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/css/CSSStyleSelector.h trunk/Source/WebCore/css/FontValue.cpp trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js trunk/Source/WebCore/page/animation/AnimationBase.cpp Added Paths trunk/LayoutTests/fast/css/font-shorthand-expected.txt trunk/LayoutTests/fast/css/font-shorthand.html Diff Modified: trunk/LayoutTests/ChangeLog (100272 => 100273) --- trunk/LayoutTests/ChangeLog 2011-11-15 14:06:38 UTC (rev 100272) +++ trunk/LayoutTests/ChangeLog 2011-11-15 14:12:43 UTC (rev 100273) @@ -1,3 +1,15 @@ +2011-11-15 Alexander Pavlov apav...@chromium.org + +font property does not show up as shorthand in inspector +https://bugs.webkit.org/show_bug.cgi?id=15598 + +Reviewed by Nikolas Zimmermann. + +* fast/css/font-shorthand-expected.txt: Added. +* fast/css/font-shorthand.html: Added. +* fast/inspector-support/style-expected.txt: +* fast/inspector-support/style.html: + 2011-11-15 Philippe Normand pnorm...@igalia.com REGRESSION (r100158-r100162): 5 fast tests failing on GTK Linux 64-bit Debug Added: trunk/LayoutTests/fast/css/font-shorthand-expected.txt (0 => 100273) --- trunk/LayoutTests/fast/css/font-shorthand-expected.txt (rev 0) +++ trunk/LayoutTests/fast/css/font-shorthand-expected.txt 2011-11-15 14:12:43 UTC (rev 100273) @@ -0,0 +1,80 @@ +Test +Font for '12px monospace': +font-family: monospace (original property was font) +font-size: 12px (original property was font) +font-style: normal (original property was font and property was implicitly set.) +font-variant: normal (original property was font and property was implicitly set.) +font-weight: normal (original property was font and property was implicitly set.) +line-height: normal (original property was font and property was implicitly set.) + +Font for '12px/24px serif': +font-family: serif (original property was font) +font-size: 12px (original property was font) +font-style: normal (original property was font and property was implicitly set.) +font-variant: normal (original property was font and property was implicitly set.) +font-weight: normal (original property was font and property was implicitly set.) +line-height: 24px (original property was font) + +Font
[webkit-changes] [100274] trunk/Source
Title: [100274] trunk/Source
Revision 100274
Author commit-qu...@webkit.org
Date 2011-11-15 06:30:36 -0800 (Tue, 15 Nov 2011)
Log Message
Unreviewed, rolling out r100269.
http://trac.webkit.org/changeset/100269
https://bugs.webkit.org/show_bug.cgi?id=72383
Broke dozens of tests due to exception in loadingFinished
(Requested by tonyg-cr on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-15
Source/WebCore:
* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/Resource.js:
* inspector/front-end/Settings.js:
* inspector/front-end/UIUtils.js:
* inspector/front-end/inspector.js:
Source/WebKit/chromium:
* src/js/DevTools.js:
():
(devtools.domContentLoaded):
(WebInspector.UIString):
(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
trunk/Source/WebCore/inspector/front-end/Resource.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/UIUtils.js
trunk/Source/WebCore/inspector/front-end/inspector.js
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/DevTools.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (100273 => 100274)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 14:12:43 UTC (rev 100273)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 14:30:36 UTC (rev 100274)
@@ -1,3 +1,21 @@
+2011-11-15 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r100269.
+http://trac.webkit.org/changeset/100269
+https://bugs.webkit.org/show_bug.cgi?id=72383
+
+Broke dozens of tests due to exception in loadingFinished
+(Requested by tonyg-cr on #webkit).
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/InspectorFrontendHostStub.js:
+(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
+* inspector/front-end/ProfilesPanel.js:
+* inspector/front-end/Resource.js:
+* inspector/front-end/Settings.js:
+* inspector/front-end/UIUtils.js:
+* inspector/front-end/inspector.js:
+
2011-11-15 Alexander Pavlov apav...@chromium.org
font property does not show up as shorthand in inspector
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js (100273 => 100274)
--- trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js 2011-11-15 14:12:43 UTC (rev 100273)
+++ trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js 2011-11-15 14:30:36 UTC (rev 100274)
@@ -110,7 +110,6 @@
inspectedURLChanged: function(url)
{
-document.title = WebInspector.UIString(Preferences.applicationTitle, url);
},
copyText: function()
Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (100273 => 100274)
--- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2011-11-15 14:12:43 UTC (rev 100273)
+++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2011-11-15 14:30:36 UTC (rev 100274)
@@ -119,8 +119,6 @@
this.enableToggleButton = new WebInspector.StatusBarButton(, enable-toggle-status-bar-item);
this.enableToggleButton.addEventListener(click, this._toggleProfiling.bind(this), false);
-if (Preferences.profilerAlwaysEnabled)
-this.enableToggleButton.element.addStyleClass(hidden);
this.clearResultsButton = new WebInspector.StatusBarButton(WebInspector.UIString(Clear all profiles.), clear-status-bar-item);
this.clearResultsButton.addEventListener(click, this._clearProfiles.bind(this), false);
Modified: trunk/Source/WebCore/inspector/front-end/Resource.js (100273 => 100274)
--- trunk/Source/WebCore/inspector/front-end/Resource.js 2011-11-15 14:12:43 UTC (rev 100273)
+++ trunk/Source/WebCore/inspector/front-end/Resource.js 2011-11-15 14:30:36 UTC (rev 100274)
@@ -44,7 +44,6 @@
image/bmp: {2: true},
image/svg+xml: {2: true},
image/vnd.microsoft.icon:{2: true},
-image/webp: {2: true},
image/x-icon:{2: true},
image/x-xbitmap: {2: true},
font/ttf:{3: true},
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (100273 => 100274)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2011-11-15 14:12:43 UTC (rev 100273)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js 2011-11-15 14:30:36 UTC (rev 100274)
@@ -58,8 +58,7 @@
[webkit-changes] [100275] trunk/LayoutTests
Title: [100275] trunk/LayoutTests Revision 100275 Author to...@chromium.org Date 2011-11-15 06:43:39 -0800 (Tue, 15 Nov 2011) Log Message media-blocked-by-willsendrequest.html is flaky https://bugs.webkit.org/show_bug.cgi?id=72381 * platform/chromium/test_expectations.txt: Mark test as flaky. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100274 => 100275) --- trunk/LayoutTests/ChangeLog 2011-11-15 14:30:36 UTC (rev 100274) +++ trunk/LayoutTests/ChangeLog 2011-11-15 14:43:39 UTC (rev 100275) @@ -1,3 +1,10 @@ +2011-11-15 Tony Gentilcore to...@chromium.org + +media-blocked-by-willsendrequest.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=72381 + +* platform/chromium/test_expectations.txt: Mark test as flaky. + 2011-11-15 Alexander Pavlov apav...@chromium.org font property does not show up as shorthand in inspector Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100274 => 100275) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 14:30:36 UTC (rev 100274) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 14:43:39 UTC (rev 100275) @@ -3875,3 +3875,5 @@ BUGWK59771 WIN : http/tests/inspector/resource-tree/resource-tree-frame-add.html = TIMEOUT PASS BUGWK72376 WIN : fast/forms/file/input-file-label.html = TEXT PASS + +BUGWK72381 : media/media-blocked-by-willsendrequest.html = TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100276] trunk/LayoutTests
Title: [100276] trunk/LayoutTests Revision 100276 Author r...@google.com Date 2011-11-15 06:51:32 -0800 (Tue, 15 Nov 2011) Log Message [skia] mark to rebaseline aft cr104128 lands (colorfilter optimization) https://bugs.webkit.org/show_bug.cgi?id=72270 Reviewed by NOBODY. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100275 => 100276) --- trunk/LayoutTests/ChangeLog 2011-11-15 14:43:39 UTC (rev 100275) +++ trunk/LayoutTests/ChangeLog 2011-11-15 14:51:32 UTC (rev 100276) @@ -1,3 +1,12 @@ +2011-11-15 Mike Reed r...@google.com + +[skia] mark to rebaseline aft cr104128 lands (colorfilter optimization) +https://bugs.webkit.org/show_bug.cgi?id=72270 + +Reviewed by NOBODY. + +* platform/chromium/test_expectations.txt: + 2011-11-15 Tony Gentilcore to...@chromium.org media-blocked-by-willsendrequest.html is flaky Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100275 => 100276) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 14:43:39 UTC (rev 100275) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 14:51:32 UTC (rev 100276) @@ -1097,7 +1097,7 @@ BUGWK70748 CPU : svg/clip-path/clip-path-use-as-child.svg = IMAGE BUGWK70748 CPU : svg/clip-path/clip-path-userSpaceOnUse.svg = IMAGE BUGWK70748 CPU : svg/clip-path/clip-path-with-text-clipped.svg = IMAGE -BUGWK70748 CPU LEOPARD : svg/css/text-shadow-multiple.xhtml = IMAGE +BUGWK70748 CPU : svg/css/text-shadow-multiple.xhtml = IMAGE BUGWK70748 CPU : svg/custom/resource-invalidate-on-target-update.svg = IMAGE BUGWK70748 CPU : svg/custom/use-on-clip-path-with-transformation.svg = IMAGE BUGWK70748 CPU LEOPARD : svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg = IMAGE @@ -1459,12 +1459,36 @@ BUGWK39966 LINUX : fast/repaint/table-cell-collapsed-border.html = IMAGE // Thicker shadow than expected -BUGCR23471 LEOPARD : fast/text/stroking.html = IMAGE +//BUGCR23471 LEOPARD : fast/text/stroking.html = IMAGE // - // END MAC PORT TESTS // - +// Rebaseline to take advantage of skia ColorFilter optimization +BUGCR104128 CPU : fast/box-shadow/box-shadow-radius.html = IMAGE +BUGCR104128 CPU : fast/box-shadow/inset-box-shadow-radius.html = IMAGE +BUGCR104128 CPU : fast/box-shadow/shadow-buffer-partial.html = IMAGE +BUGCR104128 CPU : fast/canvas/shadow-offset-4.html = IMAGE +BUGCR104128 CPU : fast/canvas/shadow-offset-5.html = IMAGE +BUGCR104128 CPU : fast/canvas/shadow-offset-6.html = IMAGE +BUGCR104128 CPU : fast/canvas/shadow-offset-7.html = IMAGE +BUGCR104128 CPU : fast/repaint/box-shadow-h.html = IMAGE +BUGCR104128 CPU : fast/repaint/box-shadow-v.html = IMAGE +BUGCR104128 CPU : fast/repaint/moving-shadow-on-container.html = IMAGE +BUGCR104128 CPU : fast/repaint/text-shadow-horizontal.html = IMAGE +BUGCR104128 CPU : fast/repaint/text-shadow.html = IMAGE +BUGCR104128 CPU : fast/text/shadow-no-blur.html = IMAGE +BUGCR104128 CPU : fast/text/shadow-translucent-fill.html = IMAGE +BUGCR104128 CPU : fast/text/stroking-decorations.html = IMAGE +BUGCR104128 CPU : fast/text/stroking.html = IMAGE +BUGCR104128 CPU : fast/writing-mode/english-lr-text.html = IMAGE +BUGCR104128 CPU : svg/css/group-with-shadow.svg = IMAGE +BUGCR104128 CPU : svg/css/shadow-with-large-radius.svg = IMAGE +BUGCR104128 CPU : svg/css/shadow-with-negative-offset.svg = IMAGE +BUGCR104128 CPU : svg/css/stars-with-shadow.html = IMAGE +BUGCR104128 CPU : transitions/svg-text-shadow-transition.html = IMAGE + // Linux pixeltest failure: alpha=0.5 red (1,0,0) atop yellow (1,1,0) is // coming out with with a slightly-less-than-100% red channel. This test fails // because we enforce non-transparent color in Font::drawGlyphs. @@ -2283,10 +2307,6 @@ BUGWK46689 : fast/dom/HTMLElement/class-list.html = PASS TEXT // To be rebaselined when the new gdi-aa-text code finalizes -BUGCR98248 WIN : fast/text/stroking-decorations.html = IMAGE -BUGCR98248 WIN : fast/text/stroking.html = IMAGE -BUGCR98248 WIN : fast/writing-mode/english-lr-text.html = IMAGE -BUGCR98248 WIN : svg/css/group-with-shadow.svg = IMAGE BUGCR98248 WIN : svg/css/text-gradient-shadow.svg = IMAGE // Flaky since r68438:r68445 or before that. @@ -3022,7 +3042,7 @@ BUGDPRANKE : http/tests/navigation/lockedhistory-iframe.html = PASS TIMEOUT TEXT BUGDPRANKE : fast/parser/iframe-sets-parent-to-_javascript_-url.html = PASS TEXT -BUGDPRANKE : fast/repaint/moving-shadow-on-path.html = PASS TEXT +BUGDPRANKE : fast/repaint/moving-shadow-on-path.html = PASS TEXT IMAGE BUGDPRANKE WIN DEBUG : http/tests/misc/empty-file-formdata.html = PASS TIMEOUT BUGDPRANKE WIN DEBUG : http/tests/xmlhttprequest/access-control-preflight-headers-async.html = PASS
[webkit-changes] [100277] trunk/Source
Title: [100277] trunk/Source
Revision 100277
Author pfeld...@chromium.org
Date 2011-11-15 06:52:25 -0800 (Tue, 15 Nov 2011)
Log Message
Web Inspector: move generic code from DevTools.js into the WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72377
re-landing r100269.
Reviewed by Yury Semikhatsky.
Source/WebCore:
* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/Resource.js:
* inspector/front-end/Settings.js:
* inspector/front-end/UIUtils.js:
(WebInspector.setToolbarColors):
(WebInspector.resetToolbarColors):
* inspector/front-end/inspector.js:
Source/WebKit/chromium:
* src/js/DevTools.js:
(WebInspector.setInspectedTabId):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
trunk/Source/WebCore/inspector/front-end/Resource.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/UIUtils.js
trunk/Source/WebCore/inspector/front-end/inspector.js
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/DevTools.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (100276 => 100277)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 14:51:32 UTC (rev 100276)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 14:52:25 UTC (rev 100277)
@@ -1,3 +1,23 @@
+2011-11-15 Pavel Feldman pfeld...@google.com
+
+Web Inspector: move generic code from DevTools.js into the WebCore.
+https://bugs.webkit.org/show_bug.cgi?id=72377
+
+re-landing r100269.
+
+Reviewed by Yury Semikhatsky.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/InspectorFrontendHostStub.js:
+(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
+* inspector/front-end/ProfilesPanel.js:
+* inspector/front-end/Resource.js:
+* inspector/front-end/Settings.js:
+* inspector/front-end/UIUtils.js:
+(WebInspector.setToolbarColors):
+(WebInspector.resetToolbarColors):
+* inspector/front-end/inspector.js:
+
2011-11-15 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r100269.
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js (100276 => 100277)
--- trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js 2011-11-15 14:51:32 UTC (rev 100276)
+++ trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js 2011-11-15 14:52:25 UTC (rev 100277)
@@ -110,6 +110,7 @@
inspectedURLChanged: function(url)
{
+document.title = WebInspector.UIString(Preferences.applicationTitle, url);
},
copyText: function()
Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (100276 => 100277)
--- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2011-11-15 14:51:32 UTC (rev 100276)
+++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2011-11-15 14:52:25 UTC (rev 100277)
@@ -119,6 +119,8 @@
this.enableToggleButton = new WebInspector.StatusBarButton(, enable-toggle-status-bar-item);
this.enableToggleButton.addEventListener(click, this._toggleProfiling.bind(this), false);
+if (Preferences.profilerAlwaysEnabled)
+this.enableToggleButton.element.addStyleClass(hidden);
this.clearResultsButton = new WebInspector.StatusBarButton(WebInspector.UIString(Clear all profiles.), clear-status-bar-item);
this.clearResultsButton.addEventListener(click, this._clearProfiles.bind(this), false);
Modified: trunk/Source/WebCore/inspector/front-end/Resource.js (100276 => 100277)
--- trunk/Source/WebCore/inspector/front-end/Resource.js 2011-11-15 14:51:32 UTC (rev 100276)
+++ trunk/Source/WebCore/inspector/front-end/Resource.js 2011-11-15 14:52:25 UTC (rev 100277)
@@ -44,6 +44,7 @@
image/bmp: {2: true},
image/svg+xml: {2: true},
image/vnd.microsoft.icon:{2: true},
+image/webp: {2: true},
image/x-icon:{2: true},
image/x-xbitmap: {2: true},
font/ttf:{3: true},
Modified: trunk/Source/WebCore/inspector/front-end/Settings.js (100276 => 100277)
--- trunk/Source/WebCore/inspector/front-end/Settings.js 2011-11-15 14:51:32 UTC (rev 100276)
+++ trunk/Source/WebCore/inspector/front-end/Settings.js 2011-11-15 14:52:25 UTC (rev 100277)
@@ -58,7 +58,8 @@
showNetworkPanelInitiatorColumn: false,
haveExtensions: false,
sharedWorkersDebugNote: undefined,
-localizeUI: true
+localizeUI: true,
+applicationTitle: Web Inspector - %s
}
/**
[webkit-changes] [100278] trunk/LayoutTests
Title: [100278] trunk/LayoutTests Revision 100278 Author to...@chromium.org Date 2011-11-15 06:58:16 -0800 (Tue, 15 Nov 2011) Log Message Tests occasionally report missing expectations https://bugs.webkit.org/show_bug.cgi?id=72039 * platform/chromium/test_expectations.txt: Add 3 more tests which flakily report missing. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100277 => 100278) --- trunk/LayoutTests/ChangeLog 2011-11-15 14:52:25 UTC (rev 100277) +++ trunk/LayoutTests/ChangeLog 2011-11-15 14:58:16 UTC (rev 100278) @@ -1,3 +1,10 @@ +2011-11-15 Tony Gentilcore to...@chromium.org + +Tests occasionally report missing expectations +https://bugs.webkit.org/show_bug.cgi?id=72039 + +* platform/chromium/test_expectations.txt: Add 3 more tests which flakily report missing. + 2011-11-15 Mike Reed r...@google.com [skia] mark to rebaseline aft cr104128 lands (colorfilter optimization) Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100277 => 100278) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 14:52:25 UTC (rev 100277) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 14:58:16 UTC (rev 100278) @@ -3766,9 +3766,12 @@ BUGWK70837 : compositing/video/video-poster.html = PASS TIMEOUT TEXT BUGWK70866 LINUX DEBUG : fast/forms/form-associated-element-crash3.html = TIMEOUT +BUGWK72039 LINUX RELEASE : fast/forms/form-associated-element-crash.html = MISSING PASS BUGWK72039 LINUX RELEASE : fast/forms/form-associated-element-crash3.html = MISSING PASS -BUGWK72039 LINUX RELEASE : fast/forms/form-associated-element-crash.html = MISSING PASS +BUGWK72039 LINUX RELEASE : fast/forms/form-attribute-elements.html = MISSING PASS +BUGWK72039 LINUX RELEASE : fast/forms/form-attribute-elements-order.html = MISSING PASS BUGWK72039 LINUX RELEASE : fast/forms/form-attribute-elements-order2.html = MISSING PASS +BUGWK72039 LINUX RELEASE : fast/forms/form-attribute-nonexistence-form-id.html = MISSING PASS BUGWK72039 LINUX MAC DEBUG : http/tests/multipart/policy-ignore-crash.php = MISSING PASS BUGWK70971 MAC : storage/domstorage/events/basic-setattribute.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100279] trunk/LayoutTests
Title: [100279] trunk/LayoutTests Revision 100279 Author ph...@webkit.org Date 2011-11-15 07:11:36 -0800 (Tue, 15 Nov 2011) Log Message Unreviewed, marked fast/frames/flattening/frameset-flattening-simple.html as flaky on GTK. * platform/gtk/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100278 => 100279) --- trunk/LayoutTests/ChangeLog 2011-11-15 14:58:16 UTC (rev 100278) +++ trunk/LayoutTests/ChangeLog 2011-11-15 15:11:36 UTC (rev 100279) @@ -1,3 +1,10 @@ +2011-11-15 Philippe Normand pnorm...@igalia.com + +Unreviewed, marked +fast/frames/flattening/frameset-flattening-simple.html as flaky on GTK. + +* platform/gtk/test_expectations.txt: + 2011-11-15 Tony Gentilcore to...@chromium.org Tests occasionally report missing expectations Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (100278 => 100279) --- trunk/LayoutTests/platform/gtk/test_expectations.txt 2011-11-15 14:58:16 UTC (rev 100278) +++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2011-11-15 15:11:36 UTC (rev 100279) @@ -65,4 +65,6 @@ BUGWK71776 : fast/forms/password-placeholder-text-security.html = PASS TEXT BUGWK71777 : fast/lists/inlineBoxWrapperNullCheck.html = PASS TEXT +BUGWK71655 : fast/frames/flattening/frameset-flattening-simple.html = PASS TEXT + // End of Flaky tests ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100280] trunk
Title: [100280] trunk
Revision 100280
Author commit-qu...@webkit.org
Date 2011-11-15 07:38:09 -0800 (Tue, 15 Nov 2011)
Log Message
Fix SVG hit testing when padding is present
https://bugs.webkit.org/show_bug.cgi?id=37325
Patch by Philip Rogers p...@google.com on 2011-11-15
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Test: svg/hittest/svg-padding.xhtml
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
LayoutTests:
* svg/hittest/svg-padding-expected.txt: Added.
* svg/hittest/svg-padding.xhtml: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
Added Paths
trunk/LayoutTests/svg/hittest/svg-padding-expected.txt
trunk/LayoutTests/svg/hittest/svg-padding.xhtml
Diff
Modified: trunk/LayoutTests/ChangeLog (100279 => 100280)
--- trunk/LayoutTests/ChangeLog 2011-11-15 15:11:36 UTC (rev 100279)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 15:38:09 UTC (rev 100280)
@@ -1,3 +1,13 @@
+2011-11-15 Philip Rogers p...@google.com
+
+Fix SVG hit testing when padding is present
+https://bugs.webkit.org/show_bug.cgi?id=37325
+
+Reviewed by Nikolas Zimmermann.
+
+* svg/hittest/svg-padding-expected.txt: Added.
+* svg/hittest/svg-padding.xhtml: Added.
+
2011-11-15 Philippe Normand pnorm...@igalia.com
Unreviewed, marked
Added: trunk/LayoutTests/svg/hittest/svg-padding-expected.txt (0 => 100280)
--- trunk/LayoutTests/svg/hittest/svg-padding-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/hittest/svg-padding-expected.txt 2011-11-15 15:38:09 UTC (rev 100280)
@@ -0,0 +1 @@
+PASSED
Added: trunk/LayoutTests/svg/hittest/svg-padding.xhtml (0 => 100280)
--- trunk/LayoutTests/svg/hittest/svg-padding.xhtml (rev 0)
+++ trunk/LayoutTests/svg/hittest/svg-padding.xhtml 2011-11-15 15:38:09 UTC (rev 100280)
@@ -0,0 +1,34 @@
+html xmlns='http://www.w3.org/1999/xhtml'
+ head
+style
+ body {
+ margin: 0px;
+ padding: 0px;
+ border: 1px solid black;
+ }
+ #square {
+fill: blue;
+ }
+ #square:hover {
+fill: green;
+ }
+/style
+ /head
+ body
+tabletrtd
+ svg width='100px' height='100px' style='padding: 50px' xmlns='http://www.w3.org/2000/svg'
+svg
+ rect id='square' width='100' height='100' _onclick_='alert(You clicked the square! It worked!)'/
+/svg
+ /svg
+/td/tr/table
+script![CDATA[
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+}
+var hitElement = document.elementFromPoint(75, 75);
+var hitSuccess = hitElement hitElement == document.getElementById(square);
+document.body.innerHTML = hitSuccess ? PASSED : FAIL, hit + hitElement + @ 50, 50;
+]]/script
+ /body
+/html
Modified: trunk/Source/WebCore/ChangeLog (100279 => 100280)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 15:11:36 UTC (rev 100279)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 15:38:09 UTC (rev 100280)
@@ -1,3 +1,15 @@
+2011-11-15 Philip Rogers p...@google.com
+
+Fix SVG hit testing when padding is present
+https://bugs.webkit.org/show_bug.cgi?id=37325
+
+Reviewed by Nikolas Zimmermann.
+
+Test: svg/hittest/svg-padding.xhtml
+
+* rendering/svg/RenderSVGRoot.cpp:
+(WebCore::RenderSVGRoot::nodeAtPoint):
+
2011-11-15 Pavel Feldman pfeld...@google.com
Web Inspector: move generic code from DevTools.js into the WebCore.
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp (100279 => 100280)
--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2011-11-15 15:11:36 UTC (rev 100279)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2011-11-15 15:38:09 UTC (rev 100280)
@@ -434,8 +434,7 @@
LayoutPoint pointInBorderBox = pointInParent - parentOriginToBorderBox();
// Note: For now, we're ignoring hits to border and padding for svg
-LayoutPoint pointInContentBox = pointInBorderBox - borderOriginToContentBox();
-if (!contentBoxRect().contains(pointInContentBox))
+if (!contentBoxRect().contains(pointInBorderBox))
return false;
LayoutPoint localPoint = localToParentTransform().inverse().mapPoint(pointInParent);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100281] trunk/LayoutTests
Title: [100281] trunk/LayoutTests Revision 100281 Author o...@webkit.org Date 2011-11-15 07:59:33 -0800 (Tue, 15 Nov 2011) Log Message [Qt] Enable skipped but now passing tests (http/tests) https://bugs.webkit.org/show_bug.cgi?id=71911 Patch by Zoltan Arvai zar...@inf.u-szeged.hu on 2011-11-15 Reviewed by Csaba Osztrogonác. * platform/qt/Skipped: Unskip 24 tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100280 => 100281) --- trunk/LayoutTests/ChangeLog 2011-11-15 15:38:09 UTC (rev 100280) +++ trunk/LayoutTests/ChangeLog 2011-11-15 15:59:33 UTC (rev 100281) @@ -1,3 +1,12 @@ +2011-11-15 Zoltan Arvai zar...@inf.u-szeged.hu + +[Qt] Enable skipped but now passing tests (http/tests) +https://bugs.webkit.org/show_bug.cgi?id=71911 + +Reviewed by Csaba Osztrogonác. + +* platform/qt/Skipped: Unskip 24 tests. + 2011-11-15 Philip Rogers p...@google.com Fix SVG hit testing when padding is present Modified: trunk/LayoutTests/platform/qt/Skipped (100280 => 100281) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-15 15:38:09 UTC (rev 100280) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-15 15:59:33 UTC (rev 100281) @@ -260,7 +260,6 @@ http/tests/local/drag-over-remote-content.html http/tests/local/fileapi http/tests/security/drag-drop-same-unique-origin.html -http/tests/misc/drag-not-loaded-image.html # [Qt] DumpRenderTree needs a beginDragWithFiles implementation # https://bugs.webkit.org/show_bug.cgi?id=50902 @@ -336,9 +335,6 @@ fast/events/dropzone-003.html fast/events/dropzone-004.html -# caused by: http://trac.webkit.org/changeset/52192 -http/tests/misc/drag-over-iframe-invalid-source-crash.html - # Missing eventSender.beginDragWithFiles() fast/dom/Window/window-postmessage-clone-frames.html @@ -361,10 +357,6 @@ # no expected results http/tests/misc/favicon-as-image.html -# https://bugs.webkit.org/show_bug.cgi?id=34004 -# [Qt] http/tests/misc/slow-loading-mask.html timed out. -http/tests/misc/slow-loading-mask.html - # No authentication challenge handling http/tests/loading/basic-credentials-sent-automatically.html http/tests/loading/basic-auth-resend-wrong-credentials.html @@ -407,7 +399,6 @@ # Caused by the way Qt caches network connections using user@hostname as the key # See https://bugs.webkit.org/show_bug.cgi?id=37084 and http://bugreports.qt.nokia.com/browse/QTBUG-9619 # Fixed in Qt 4.8 -http/tests/xmlhttprequest/re-login-async.html http/tests/xmlhttprequest/re-login.html # Still fail with Qt 4.7.1 @@ -517,9 +508,6 @@ fast/frames/sandboxed-iframe-scripting.html fast/frames/sandboxed-iframe-storage.html http/tests/cookies/simple-cookies-max-age.html -http/tests/cookies/simple-cookies-expired.html -http/tests/xmlhttprequest/workers/close.html -http/tests/xmlhttprequest/workers/shared-worker-close.html transitions/change-values-during-transition.html @@ -538,7 +526,6 @@ inspector/styles/styles-add-blank-property.html # [Qt] New fails caused by change(s) between r79317-r79320. -http/tests/inspector/change-iframe-src.html inspector/debugger/open-close-open.html # [Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot @@ -741,11 +728,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=58396 http/tests/misc/favicon-loads-with-icon-loading-override.html -# Missing layoutTestController.setAlwaysAcceptCookies - implemented for Qt version = 4.8 -http/tests/security/cookies/third-party-cookie-blocking-main-frame.html -http/tests/security/cookies/third-party-cookie-blocking-user-action.html -http/tests/security/cookies/third-party-cookie-blocking.html - # = # # Failing SVG tests # = # @@ -1684,10 +1666,6 @@ # Support for third-party cookie blocking # https://bugs.webkit.org/show_bug.cgi?id=45455 # See also http://bugreports.qt.nokia.com/browse/QTBUG-13601 -http/tests/cookies/third-party-cookie-relaxing.html -http/tests/xmlhttprequest/cross-origin-cookie-storage.html -http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html -http/tests/plugins/third-party-cookie-accept-policy.html platform/qt/http/tests/cookies/strict-third-party-cookie-blocking.html # = # @@ -1709,9 +1687,7 @@ # Web Timing related bugs # https://bugs.webkit.org/show_bug.cgi?id=51245 fast/dom/webtiming.html -http/tests/misc/webtiming-ssl.php http/tests/misc/webtiming-origins.html -http/tests/misc/webtiming-slow-load.php # Advanced credential handling http/tests/security/401-logout/401-logout.php @@ -1866,7 +1842,6 @@ # [Qt] Two http auth tests fail with Qt 4.7.2 # https://bugs.webkit.org/show_bug.cgi?id=55767 http/tests/appcache/auth.html
[webkit-changes] [100282] trunk/LayoutTests
Title: [100282] trunk/LayoutTests
Revision 100282
Author eric.carl...@apple.com
Date 2011-11-15 08:14:39 -0800 (Tue, 15 Nov 2011)
Log Message
media-blocked-by-willsendrequest.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72381
Reviewed by Tony Gentilcore.
* media/media-blocked-by-willsendrequest.html:
Don't assume the media events will be dispatched before the window 'load' event.
* platform/chromium/test_expectations.txt:
Don't skip media/media-blocked-by-willsendrequest.html.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/media-blocked-by-willsendrequest.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100281 => 100282)
--- trunk/LayoutTests/ChangeLog 2011-11-15 15:59:33 UTC (rev 100281)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 16:14:39 UTC (rev 100282)
@@ -1,3 +1,15 @@
+2011-11-15 Eric Carlson eric.carl...@apple.com
+
+media-blocked-by-willsendrequest.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=72381
+
+Reviewed by Tony Gentilcore.
+
+* media/media-blocked-by-willsendrequest.html:
+Don't assume the media events will be dispatched before the window 'load' event.
+* platform/chromium/test_expectations.txt:
+Don't skip media/media-blocked-by-willsendrequest.html.
+
2011-11-15 Zoltan Arvai zar...@inf.u-szeged.hu
[Qt] Enable skipped but now passing tests (http/tests)
Modified: trunk/LayoutTests/media/media-blocked-by-willsendrequest.html (100281 => 100282)
--- trunk/LayoutTests/media/media-blocked-by-willsendrequest.html 2011-11-15 15:59:33 UTC (rev 100281)
+++ trunk/LayoutTests/media/media-blocked-by-willsendrequest.html 2011-11-15 16:14:39 UTC (rev 100282)
@@ -10,27 +10,42 @@
and does not block the document's 'load' event./p
script
+var events = [];
+
if (window.layoutTestController) {
layoutTestController.dumpAsText();
layoutTestController.setWillSendRequestReturnsNull(true);
} else
-consoleWrite(This test can only be run in DumpRenderTree!brbr);
+consoleWrite(bemThis test can only be run in DumpRenderTree!/em/bbrbr);
-function loaded()
+function finish()
{
+consoleWrite(EVENT(loadstart));
+consoleWrite(EVENT(error));
testExpected(video.error, null, !=);
testExpected(video.error.code, MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED);
testExpected(video.networkState, HTMLMediaElement.NETWORK_NO_SOURCE);
consoleWrite();
endTest();
};
-
-window._onload_ = loaded;
+function handleEvent(evt)
+{
+// Wait until all three events we listen for have been received before testing.
+// Media events are dispatched asynchronously so we can't assume they will fire
+// before window.onload.
+if (events.indexOf(evt.type) == -1)
+events.push(evt.type);
+if (events.length == 3)
+finish();
+}
+
findMediaElement();
-waitForEvent(loadstart);
-waitForEvent(error);
+window.addEventListener('load', handleEvent);
+video.addEventListener('loadstart', handleEvent);
+video.addEventListener('error', handleEvent);
+
testExpected(video.networkState, HTMLMediaElement.NETWORK_EMPTY);
consoleWrite();
var mediaFile = findMediaFile(video, content/test);
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100281 => 100282)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 15:59:33 UTC (rev 100281)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 16:14:39 UTC (rev 100282)
@@ -3896,5 +3896,3 @@
BUGWK59771 WIN : http/tests/inspector/resource-tree/resource-tree-frame-add.html = TIMEOUT PASS
BUGWK72376 WIN : fast/forms/file/input-file-label.html = TEXT PASS
-
-BUGWK72381 : media/media-blocked-by-willsendrequest.html = TEXT PASS
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100283] trunk
Title: [100283] trunk Revision 100283 Author carycl...@google.com Date 2011-11-15 08:17:25 -0800 (Tue, 15 Nov 2011) Log Message [chromium-mac] Enable vertical text using Skia https://bugs.webkit.org/show_bug.cgi?id=72137 Source/WebCore: Use Skia to draw vertical text. This is much faster and has higher fidelity than the old method of drawing text on a path. The graphics context passed to Skia has been rotated 90 degrees but the character advances have not, so it is necessary to unrotate the canvas, and re-rotate the positions. This generates correct output (or, at least, consistent with Chromium CG on Mac) for all vertical text tests, one of which is mentioned below. Reviewed by Stephen White. Test: fast/writing-mode/text-orientation-basic.html * platform/graphics/skia/FontSkia.cpp: (WebCore::setupPaint): (WebCore::Font::drawGlyphs): LayoutTests: Ignore vertical text tests on Skia on Mac for now. Reviewed by Stephen White. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp Diff Modified: trunk/LayoutTests/ChangeLog (100282 => 100283) --- trunk/LayoutTests/ChangeLog 2011-11-15 16:14:39 UTC (rev 100282) +++ trunk/LayoutTests/ChangeLog 2011-11-15 16:17:25 UTC (rev 100283) @@ -1,3 +1,14 @@ +2011-11-15 Cary Clark carycl...@google.com + +[chromium-mac] Enable vertical text using Skia +https://bugs.webkit.org/show_bug.cgi?id=72137 + +Ignore vertical text tests on Skia on Mac for now. + +Reviewed by Stephen White. + +* platform/chromium/test_expectations.txt: + 2011-11-15 Eric Carlson eric.carl...@apple.com media-blocked-by-willsendrequest.html is flaky Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100282 => 100283) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 16:14:39 UTC (rev 100282) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 16:17:25 UTC (rev 100283) @@ -3886,6 +3886,37 @@ BUGWK59552 MAC DEBUG : http/tests/security/cross-frame-access-custom.html = PASS CRASH +// use Skia to draw vertical text directly instead of text-on-path +BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-backward-br.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-forward-br.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-backward-br.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-backward-p.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-forward-br.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-forward-p.html = IMAGE +BUG_CARYCLARK MAC CPU : editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/dynamic/text-combine.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/repaint/japanese-rl-selection-clear.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/repaint/japanese-rl-selection-repaint-in-regions.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/repaint/japanese-rl-selection-repaint.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/repaint/repaint-across-writing-mode-boundary.html = IMAGE +BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/text/international/vertical-text-glyph-test.html = IMAGE +BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/text/justify-ideograph-vertical.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/Kusa-Makura-background-canvas.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/border-vertical-lr.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/broken-ideographic-font.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/fallback-orientation.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-lr-text.html = IMAGE +BUG_CARYCLARK LION CPU : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE +BUG_CARYCLARK SNOWLEOPARD CPU RELEASE : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-rl-text.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-ruby-vertical-lr.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-ruby-vertical-rl.html = IMAGE +BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/writing-mode/text-orientation-basic.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/vertical-align-table-baseline.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/vertical-baseline-alignment.html = IMAGE +BUG_CARYCLARK MAC CPU : fast/writing-mode/vertical-font-fallback.html = IMAGE + BUGWK72271 MAC DEBUG : fast/loader/_javascript_-url-in-embed.html = PASS CRASH BUGWK72272 WIN : security/crypto-random-values-types.html = TEXT PASS
[webkit-changes] [100284] trunk/Source
Title: [100284] trunk/Source
Revision 100284
Author carlo...@webkit.org
Date 2011-11-15 08:24:54 -0800 (Tue, 15 Nov 2011)
Log Message
[GTK] Implement download support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72258
Reviewed by Martin Robinson.
Source/WebCore:
Add common download errors to ErrorsGtk.
* platform/gtk/ErrorsGtk.cpp:
(WebCore::downloadNetworkError):
(WebCore::downloadCancelledByUserError):
(WebCore::downloadDestinationError):
* platform/gtk/ErrorsGtk.h:
Source/WebKit/gtk:
Use errors from WebCore to emit the error signals.
* webkit/webkitdownload.cpp:
(webkitDownloadEmitError): Helper function that emits the error
signal for the given ResourceError.
(webkit_download_open_stream_for_uri): Use webkitDownloadEmitError().
(webkit_download_cancel): Ditto.
(webkit_download_set_destination_uri): Ditto.
(webkit_download_received_data): Ditto.
(webkit_download_error): Ditto.
Source/WebKit2:
* WebProcess/Downloads/Download.h:
* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::downloadFailed):
(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFinishLoading):
(WebKit::DownloadClient::didFail):
(WebKit::DownloadClient::wasBlocked):
(WebKit::DownloadClient::cannotShowURL):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/ErrorsGtk.cpp
trunk/Source/WebCore/platform/gtk/ErrorsGtk.h
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Downloads/Download.h
trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100283 => 100284)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 16:17:25 UTC (rev 100283)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 16:24:54 UTC (rev 100284)
@@ -1,3 +1,18 @@
+2011-11-15 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] Implement download support in WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=72258
+
+Reviewed by Martin Robinson.
+
+Add common download errors to ErrorsGtk.
+
+* platform/gtk/ErrorsGtk.cpp:
+(WebCore::downloadNetworkError):
+(WebCore::downloadCancelledByUserError):
+(WebCore::downloadDestinationError):
+* platform/gtk/ErrorsGtk.h:
+
2011-11-15 Cary Clark carycl...@google.com
[chromium-mac] Enable vertical text using Skia
Modified: trunk/Source/WebCore/platform/gtk/ErrorsGtk.cpp (100283 => 100284)
--- trunk/Source/WebCore/platform/gtk/ErrorsGtk.cpp 2011-11-15 16:17:25 UTC (rev 100283)
+++ trunk/Source/WebCore/platform/gtk/ErrorsGtk.cpp 2011-11-15 16:24:54 UTC (rev 100284)
@@ -69,4 +69,22 @@
response.url().string(), _(Plugin will handle load));
}
+ResourceError downloadNetworkError(const ResourceError networkError)
+{
+return ResourceError(errorDomainDownload, DownloadErrorNetwork,
+ networkError.failingURL(), networkError.localizedDescription());
+}
+
+ResourceError downloadCancelledByUserError(const ResourceResponse response)
+{
+return ResourceError(errorDomainDownload, DownloadErrorCancelledByUser,
+ response.url().string(), _(User cancelled the download));
+}
+
+ResourceError downloadDestinationError(const ResourceResponse response, const String errorMessage)
+{
+return ResourceError(errorDomainDownload, DownloadErrorDestination,
+ response.url().string(), errorMessage);
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/gtk/ErrorsGtk.h (100283 => 100284)
--- trunk/Source/WebCore/platform/gtk/ErrorsGtk.h 2011-11-15 16:17:25 UTC (rev 100283)
+++ trunk/Source/WebCore/platform/gtk/ErrorsGtk.h 2011-11-15 16:24:54 UTC (rev 100284)
@@ -20,6 +20,8 @@
#ifndef ErrorsGtk_h
#define ErrorsGtk_h
+#include PlatformString.h
+
namespace WebCore {
class ResourceError;
@@ -29,6 +31,7 @@
const char* const errorDomainNetwork = WebKitNetworkError;
const char* const errorDomainPolicy = WebKitPolicyError;
const char* const errorDomainPlugin = WebKitPluginError;
+const char* const errorDomainDownload = WebKitDownloadError;
enum NetworkError {
NetworkErrorFailed = 399,
@@ -56,6 +59,12 @@
PluginErrorWillHandleLoad = 204
};
+enum DownloadError {
+DownloadErrorNetwork = 499,
+DownloadErrorCancelledByUser = 400,
+DownloadErrorDestination = 401
+};
+
ResourceError cancelledError(const ResourceRequest);
ResourceError blockedError(const ResourceRequest);
ResourceError cannotShowURLError(const ResourceRequest);
@@ -63,6 +72,9 @@
ResourceError cannotShowMIMETypeError(const ResourceResponse);
ResourceError fileDoesNotExistError(const ResourceResponse);
ResourceError
[webkit-changes] [100286] trunk/Tools
Title: [100286] trunk/Tools
Revision 100286
Author commit-qu...@webkit.org
Date 2011-11-15 08:37:58 -0800 (Tue, 15 Nov 2011)
Log Message
Handle svn 1.7 when detecting whether a directory is in an svn checkout.
https://bugs.webkit.org/show_bug.cgi?id=72349
Patch by Peter Kasting pkast...@google.com on 2011-11-15
Reviewed by Adam Roben.
* Scripts/VCSUtils.pm:
(isSVNDirectory):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/VCSUtils.pm
Diff
Modified: trunk/Tools/ChangeLog (100285 => 100286)
--- trunk/Tools/ChangeLog 2011-11-15 16:32:02 UTC (rev 100285)
+++ trunk/Tools/ChangeLog 2011-11-15 16:37:58 UTC (rev 100286)
@@ -1,3 +1,13 @@
+2011-11-15 Peter Kasting pkast...@google.com
+
+Handle svn 1.7 when detecting whether a directory is in an svn checkout.
+https://bugs.webkit.org/show_bug.cgi?id=72349
+
+Reviewed by Adam Roben.
+
+* Scripts/VCSUtils.pm:
+(isSVNDirectory):
+
2011-11-15 Simon Hausmann simon.hausm...@nokia.com
[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
Modified: trunk/Tools/Scripts/VCSUtils.pm (100285 => 100286)
--- trunk/Tools/Scripts/VCSUtils.pm 2011-11-15 16:32:02 UTC (rev 100285)
+++ trunk/Tools/Scripts/VCSUtils.pm 2011-11-15 16:37:58 UTC (rev 100286)
@@ -249,8 +249,7 @@
sub isSVNDirectory($)
{
my ($dir) = @_;
-
-return -d File::Spec-catdir($dir, .svn);
+return system(cd $dir svn info . File::Spec-devnull() . 21) == 0;
}
sub isSVN()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100287] trunk/Tools
Title: [100287] trunk/Tools
Revision 100287
Author ddkil...@apple.com
Date 2011-11-15 09:25:51 -0800 (Tue, 15 Nov 2011)
Log Message
Don't use File::Slurp for run-leaks unit tests
http://webkit.org/b/72356
Reviewed by Daniel Bates.
* Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
Extracted common package logic into RunLeaks.pm. Fixed call to
RunLeaks::parseLeaksOutput().
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
trunk/Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
trunk/Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
Added Paths
trunk/Tools/Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm
Diff
Modified: trunk/Tools/ChangeLog (100286 => 100287)
--- trunk/Tools/ChangeLog 2011-11-15 16:37:58 UTC (rev 100286)
+++ trunk/Tools/ChangeLog 2011-11-15 17:25:51 UTC (rev 100287)
@@ -1,3 +1,17 @@
+2011-11-15 David Kilzer ddkil...@apple.com
+
+Don't use File::Slurp for run-leaks unit tests
+http://webkit.org/b/72356
+
+Reviewed by Daniel Bates.
+
+* Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
+* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
+Extracted common package logic into RunLeaks.pm. Fixed call to
+RunLeaks::parseLeaksOutput().
+* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
+* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
+
2011-11-15 Peter Kasting pkast...@google.com
Handle svn 1.7 when detecting whether a directory is in an svn checkout.
Added: trunk/Tools/Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm (0 => 100287)
--- trunk/Tools/Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm (rev 0)
+++ trunk/Tools/Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm 2011-11-15 17:25:51 UTC (rev 100287)
@@ -0,0 +1,59 @@
+#!/usr/bin/perl -w
+
+# Copyright (C) 2011 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+# Imports run-leaks into a package for easy unit testing.
+
+package RunLeaks;
+
+use strict;
+use warnings;
+
+use English;
+use File::Spec;
+use FindBin;
+use lib File::Spec-catdir($FindBin::Bin, .., ..);
+use webkitdirs;
+
+use base 'Exporter' ;
+use vars qw( @EXPORT @EXPORT_OK %EXPORT_TAGS $VERSION ) ;
+
+@EXPORT = ();
+@EXPORT_OK = ();
+%EXPORT_TAGS = ();
+$VERSION = '1.0';
+
+sub readFile($);
+
+my $runLeaksPath = File::Spec-catfile(sourceDir(), Tools, Scripts, run-leaks);
+eval sub { . readFile($runLeaksPath) . };
+
+sub readFile($) {
+local $INPUT_RECORD_SEPARATOR = undef; # Read in the whole file at once.
+open FILE, , shift || die $!;
+my $contents = FILE;
+close FILE || die $!;
+return $contents;
+};
+
+1;
Modified: trunk/Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl (100286 => 100287)
--- trunk/Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl 2011-11-15 16:37:58 UTC (rev 100286)
+++ trunk/Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl 2011-11-15 17:25:51 UTC (rev 100287)
@@ -25,16 +25,13 @@
# tests run-leaks using original leaks report version 1.0
use strict;
-use diagnostics;
use warnings;
-use File::Slurp qw(read_file);
-use File::Spec;
use FindBin;
+use lib $FindBin::Bin;
+use RunLeaks;
use Test::More;
-eval package RunLeaks; sub { .
[webkit-changes] [100288] trunk/LayoutTests
Title: [100288] trunk/LayoutTests Revision 100288 Author ph...@webkit.org Date 2011-11-15 09:30:52 -0800 (Tue, 15 Nov 2011) Log Message Unreviewed, GTK rebaseline. * platform/gtk/fast/dom/Window/window-properties-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100287 => 100288) --- trunk/LayoutTests/ChangeLog 2011-11-15 17:25:51 UTC (rev 100287) +++ trunk/LayoutTests/ChangeLog 2011-11-15 17:30:52 UTC (rev 100288) @@ -1,3 +1,9 @@ +2011-11-15 Philippe Normand pnorm...@igalia.com + +Unreviewed, GTK rebaseline. + +* platform/gtk/fast/dom/Window/window-properties-expected.txt: + 2011-11-15 Philip Rogers p...@google.com Implement maxWidth for fillText and strokeText, fixing the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test. Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt (100287 => 100288) --- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-11-15 17:25:51 UTC (rev 100287) +++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2011-11-15 17:30:52 UTC (rev 100288) @@ -2430,7 +2430,6 @@ window.localStorage [printed above as window.Storage.prototype] window.location [object Location] window.location.assign [function] -window.location.getParameter [function] window.location.hash [string] window.location.host [string] window.location.hostname [string] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100291] trunk/LayoutTests
Title: [100291] trunk/LayoutTests
Revision 100291
Author commit-qu...@webkit.org
Date 2011-11-15 10:21:17 -0800 (Tue, 15 Nov 2011)
Log Message
REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796
This adds test to ensure that the bug does not reappear unnoticed.
Patch by Stephen Chenney schen...@chromium.org on 2011-11-15
Reviewed by Nikolas Zimmermann.
* svg/custom/zero-path-square-cap-rendering3-expected.png: Added.
* svg/custom/zero-path-square-cap-rendering3-expected.txt: Added.
* svg/custom/zero-path-square-cap-rendering3.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3-expected.png
trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3-expected.txt
trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (100290 => 100291)
--- trunk/LayoutTests/ChangeLog 2011-11-15 17:54:52 UTC (rev 100290)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 18:21:17 UTC (rev 100291)
@@ -1,3 +1,16 @@
+2011-11-15 Stephen Chenney schen...@chromium.org
+
+REGRESSION (r91125): Polyline tool in google docs is broken
+https://bugs.webkit.org/show_bug.cgi?id=65796
+
+This adds test to ensure that the bug does not reappear unnoticed.
+
+Reviewed by Nikolas Zimmermann.
+
+* svg/custom/zero-path-square-cap-rendering3-expected.png: Added.
+* svg/custom/zero-path-square-cap-rendering3-expected.txt: Added.
+* svg/custom/zero-path-square-cap-rendering3.svg: Added.
+
2011-11-15 Erik Arvidsson a...@chromium.org
Fix invalid markup in some tests
Added: trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3-expected.png (0 => 100291)
--- trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3-expected.png (rev 0)
+++ trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3-expected.png 2011-11-15 18:21:17 UTC (rev 100291)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum 58d068507b13af7b19d2860d6fa8k=\xAD\x8F
+\xD0IDATx\x9C\xED\xD9A
+\x83P DAh*\xA2\xA7\xA6p\xC0#\xB5Rch\xA3 \xF9 \xCC(\xD8\xE3Kv\x9E~\xD3\xE5m\x9Fm\xFF\xEE\xA3W w\xF1= \xE0j @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` Ğ\xEB{
[webkit-changes] [100292] trunk/LayoutTests
Title: [100292] trunk/LayoutTests Revision 100292 Author t...@chromium.org Date 2011-11-15 10:25:08 -0800 (Tue, 15 Nov 2011) Log Message enable new flexbox tests everywhere https://bugs.webkit.org/show_bug.cgi?id=72325 Reviewed by Ojan Vafai. * platform/chromium/test_expectations.txt: * platform/efl/Skipped: * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: * platform/wincairo/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/win/Skipped trunk/LayoutTests/platform/wincairo/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100291 => 100292) --- trunk/LayoutTests/ChangeLog 2011-11-15 18:21:17 UTC (rev 100291) +++ trunk/LayoutTests/ChangeLog 2011-11-15 18:25:08 UTC (rev 100292) @@ -1,3 +1,18 @@ +2011-11-15 Tony Chang t...@chromium.org + +enable new flexbox tests everywhere +https://bugs.webkit.org/show_bug.cgi?id=72325 + +Reviewed by Ojan Vafai. + +* platform/chromium/test_expectations.txt: +* platform/efl/Skipped: +* platform/gtk/Skipped: +* platform/mac/Skipped: +* platform/qt/Skipped: +* platform/win/Skipped: +* platform/wincairo/Skipped: + 2011-11-15 Stephen Chenney schen...@chromium.org REGRESSION (r91125): Polyline tool in google docs is broken Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100291 => 100292) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 18:21:17 UTC (rev 100291) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 18:25:08 UTC (rev 100292) @@ -3268,9 +3268,6 @@ BUGCR85293 LINUX : svg/text/foreignObject-text-clipping-bug.xml = PASS IMAGE -// New flexbox is not yet enabled. -BUGWK62048 SKIP : css3/flexbox = PASS - // CSS Regions support not yet enabled. BUGWK57312 SKIP : fast/regions = PASS BUGWK70733 SKIP : fast/regions/render-region-custom-style-mark.html = FAIL @@ -3877,6 +3874,10 @@ BUG_SENORBLANCO GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT +// Need to rebaseline on win and mac. +BUG_TONY WIN MAC : css3/flexbox/repaint.html = PASS FAIL +BUG_TONY WIN MAC : css3/flexbox/repaint-rtl-column.html = PASS FAIL + BUGWK72149 : media/track/tracklist-is-reachable.html = TEXT BUGWK72269 : media/track/track-cues-cuechange.html = PASS TEXT Modified: trunk/LayoutTests/platform/efl/Skipped (100291 => 100292) --- trunk/LayoutTests/platform/efl/Skipped 2011-11-15 18:21:17 UTC (rev 100291) +++ trunk/LayoutTests/platform/efl/Skipped 2011-11-15 18:25:08 UTC (rev 100292) @@ -1889,9 +1889,6 @@ # Tests for features under development # -# New flexbox is not yet enabled. http://webkit.org/b/62048 -css3/flexbox - # CSS Filters support not yet enabled (needs ENABLE_CSS_FILTERS). # https://bugs.webkit.org/show_bug.cgi?id=68469 css3/filters Modified: trunk/LayoutTests/platform/gtk/Skipped (100291 => 100292) --- trunk/LayoutTests/platform/gtk/Skipped 2011-11-15 18:21:17 UTC (rev 100291) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-15 18:25:08 UTC (rev 100292) @@ -343,9 +343,6 @@ http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html -# New flexbox is not yet enabled. http://webkit.org/b/62048 -css3/flexbox - # CSS Regions support not yet enabled. http://webkit.org/b/57312 fast/regions Modified: trunk/LayoutTests/platform/mac/Skipped (100291 => 100292) --- trunk/LayoutTests/platform/mac/Skipped 2011-11-15 18:21:17 UTC (rev 100291) +++ trunk/LayoutTests/platform/mac/Skipped 2011-11-15 18:25:08 UTC (rev 100292) @@ -400,9 +400,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=63169 webarchive/loading/mainresource-null-mimetype-crash.html -# New flexbox is not yet enabled. http://webkit.org/b/62048 -css3/flexbox - # JSC does not support setIsolatedWorldSecurityOrigin (http://webkit.org/b/61540) http/tests/security/isolatedWorld/cross-origin-xhr.html Modified: trunk/LayoutTests/platform/qt/Skipped (100291 => 100292) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-15 18:21:17 UTC (rev 100291) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-15 18:25:08 UTC (rev 100292) @@ -155,9 +155,6 @@ svg/custom/manually-parsed-svg-disallowed-in-dashboard.html svg/custom/svg-disallowed-in-dashboard-object.html -# New flexbox is not yet enabled. http://webkit.org/b/62048 -css3/flexbox - # CSS Regions support not yet enabled. http://webkit.org/b/57312 fast/regions Modified: trunk/LayoutTests/platform/win/Skipped (100291 => 100292) --- trunk/LayoutTests/platform/win/Skipped 2011-11-15 18:21:17 UTC (rev 100291) +++
[webkit-changes] [100293] branches/safari-534.53-branch/Source/WebCore
Title: [100293] branches/safari-534.53-branch/Source/WebCore
Revision 100293
Author lforsch...@apple.com
Date 2011-11-15 10:51:57 -0800 (Tue, 15 Nov 2011)
Log Message
Merge 100022.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100292 => 100293)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 18:25:08 UTC (rev 100292)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 18:51:57 UTC (rev 100293)
@@ -1,3 +1,25 @@
+2011-11-15 Lucas Forschler lforsch...@apple.com
+
+Merge 100022
+
+2011-11-11 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=72167
+REGRESSION: Scroll position not restored on back after scroll
+-and corresponding-
+rdar://problem/10410684
+
+Reviewed by Simon Fraser.
+
+We can't just return early if we are not on an active page.
+notifyPositionChanged() is called when a page is going into the page cache (and
+therefore when not on an active page). We should not notify AppKit that the page
+has scrolled in that case, but we still need to call
+ScrollAnimator::notifyPositionChanged();. So this patch removes the early return,
+and replaces it with a conditional around the relevant code.
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::notifyPositionChanged):
+
2011-11-08 Lucas Forschler lforsch...@apple.com
Merge 99508
Modified: branches/safari-534.53-branch/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (100292 => 100293)
--- branches/safari-534.53-branch/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-11-15 18:25:08 UTC (rev 100292)
+++ branches/safari-534.53-branch/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2011-11-15 18:51:57 UTC (rev 100293)
@@ -605,10 +605,12 @@
void ScrollAnimatorMac::notityPositionChanged()
{
-if (!scrollableArea()-isOnActivePage())
-return;
-#if USE(WK_SCROLLBAR_PAINTER)
-wkContentAreaScrolled(m_scrollbarPainterController.get());
+#if USE(SCROLLBAR_PAINTER)
+// This function is called when a page is going into the page cache, but the page
+// isn't really scrolling in that case. We should only pass the message on to the
+// ScrollbarPainterController when we're really scrolling on an active page.
+if (scrollableArea()-isOnActivePage())
+[m_scrollbarPainterController.get() contentAreaScrolled];
#endif
ScrollAnimator::notityPositionChanged();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100294] branches/safari-534.53-branch/Source
Title: [100294] branches/safari-534.53-branch/Source Revision 100294 Author lforsch...@apple.com Date 2011-11-15 10:56:07 -0800 (Tue, 15 Nov 2011) Log Message Versioning. Modified Paths branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig (100293 => 100294) --- branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-11-15 18:51:57 UTC (rev 100293) +++ branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-11-15 18:56:07 UTC (rev 100294) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (100293 => 100294) --- branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-11-15 18:51:57 UTC (rev 100293) +++ branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-11-15 18:56:07 UTC (rev 100294) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig (100293 => 100294) --- branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig 2011-11-15 18:51:57 UTC (rev 100293) +++ branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig 2011-11-15 18:56:07 UTC (rev 100294) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig (100293 => 100294) --- branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-11-15 18:51:57 UTC (rev 100293) +++ branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-11-15 18:56:07 UTC (rev 100294) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig (100293 => 100294) --- branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-11-15 18:51:57 UTC (rev 100293) +++ branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-11-15 18:56:07 UTC (rev 100294) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 53; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100295] tags/Safari-534.53.3/
Title: [100295] tags/Safari-534.53.3/ Revision 100295 Author lforsch...@apple.com Date 2011-11-15 10:58:15 -0800 (Tue, 15 Nov 2011) Log Message New tag. Added Paths tags/Safari-534.53.3/ Diff Property changes: tags/Safari-534.53.3 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100296] trunk/LayoutTests
Title: [100296] trunk/LayoutTests Revision 100296 Author ann...@chromium.org Date 2011-11-15 11:14:53 -0800 (Tue, 15 Nov 2011) Log Message Change layout tests for cuechange, enter, and exit events to check the order rather than the timing of the events (since actual timing can not be guaranteed). https://bugs.webkit.org/show_bug.cgi?id=72269 Reviewed by Tony Gentilcore. * media/track/track-cues-cuechange-expected.txt: * media/track/track-cues-cuechange.html: * media/track/track-cues-enter-exit-expected.txt: * media/track/track-cues-enter-exit.html: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/track/track-cues-cuechange-expected.txt trunk/LayoutTests/media/track/track-cues-cuechange.html trunk/LayoutTests/media/track/track-cues-enter-exit-expected.txt trunk/LayoutTests/media/track/track-cues-enter-exit.html trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100295 => 100296) --- trunk/LayoutTests/ChangeLog 2011-11-15 18:58:15 UTC (rev 100295) +++ trunk/LayoutTests/ChangeLog 2011-11-15 19:14:53 UTC (rev 100296) @@ -1,3 +1,17 @@ +2011-11-15 Anna Cavender ann...@chromium.org + +Change layout tests for cuechange, enter, and exit events to check the order +rather than the timing of the events (since actual timing can not be guaranteed). +https://bugs.webkit.org/show_bug.cgi?id=72269 + +Reviewed by Tony Gentilcore. + +* media/track/track-cues-cuechange-expected.txt: +* media/track/track-cues-cuechange.html: +* media/track/track-cues-enter-exit-expected.txt: +* media/track/track-cues-enter-exit.html: +* platform/chromium/test_expectations.txt: + 2011-11-15 Tony Chang t...@chromium.org enable new flexbox tests everywhere Modified: trunk/LayoutTests/media/track/track-cues-cuechange-expected.txt (100295 => 100296) --- trunk/LayoutTests/media/track/track-cues-cuechange-expected.txt 2011-11-15 18:58:15 UTC (rev 100295) +++ trunk/LayoutTests/media/track/track-cues-cuechange-expected.txt 2011-11-15 19:14:53 UTC (rev 100296) @@ -1,76 +1,56 @@ -Tests that TextTrack's cues are indexed and updated within 500ms during video playback. Test uses the cuechange event. +Tests that TextTrack's cues are indexed and updated in order during video playback. Test uses the cuechange event. -This test may fail occasionally since we cannot guarantee that cue events will fire within 250ms of their startTime or endTime. - EVENT(canplaythrough) EXPECTED (testTrack.track.cues.length == '3') OK RUN(video.play()) EVENT(cuechange) from TextTrack +Cue entered EXPECTED ([object TextTrackCue] == '[object TextTrackCue]') OK -Start time: -EXPECTED (video.currentTime = '1') OK -EXPECTED (video.currentTime '1.5') OK +EXPECTED (currentCue.id == '1') OK EVENT(cuechange) from track +Cue entered EXPECTED ([object TextTrackCue] == '[object TextTrackCue]') OK -Start time: -EXPECTED (video.currentTime = '1') OK -EXPECTED (video.currentTime '1.5') OK +EXPECTED (currentCue.id == '1') OK EVENT(cuechange) from TextTrack -End time: -EXPECTED (video.currentTime = '2') OK -EXPECTED (video.currentTime '2.5') OK +Cue exited EVENT(cuechange) from track -End time: -EXPECTED (video.currentTime = '2') OK -EXPECTED (video.currentTime '2.5') OK +Cue exited EVENT(cuechange) from TextTrack +Cue entered EXPECTED ([object TextTrackCue] == '[object TextTrackCue]') OK -Start time: -EXPECTED (video.currentTime = '2.5') OK -EXPECTED (video.currentTime '3') OK +EXPECTED (currentCue.id == '2') OK EVENT(cuechange) from track +Cue entered EXPECTED ([object TextTrackCue] == '[object TextTrackCue]') OK -Start time: -EXPECTED (video.currentTime = '2.5') OK -EXPECTED (video.currentTime '3') OK +EXPECTED (currentCue.id == '2') OK EVENT(cuechange) from TextTrack -End time: -EXPECTED (video.currentTime = '3.5') OK -EXPECTED (video.currentTime '4') OK +Cue exited EVENT(cuechange) from track -End time: -EXPECTED (video.currentTime = '3.5') OK -EXPECTED (video.currentTime '4') OK +Cue exited EVENT(cuechange) from TextTrack +Cue entered EXPECTED ([object TextTrackCue] == '[object TextTrackCue]') OK -Start time: -EXPECTED (video.currentTime = '4') OK -EXPECTED (video.currentTime '4.5') OK +EXPECTED (currentCue.id == '3') OK EVENT(cuechange) from track +Cue entered EXPECTED ([object TextTrackCue] == '[object TextTrackCue]') OK -Start time: -EXPECTED (video.currentTime = '4') OK -EXPECTED (video.currentTime '4.5') OK +EXPECTED (currentCue.id == '3') OK EVENT(cuechange) from TextTrack -End time: -EXPECTED (video.currentTime = '5') OK -EXPECTED (video.currentTime '5.5') OK +Cue exited EVENT(cuechange) from track -End time: -EXPECTED (video.currentTime = '5') OK -EXPECTED (video.currentTime '5.5') OK +Cue exited END OF TEST Modified: trunk/LayoutTests/media/track/track-cues-cuechange.html (100295 => 100296) ---
[webkit-changes] [100297] trunk/LayoutTests
Title: [100297] trunk/LayoutTests
Revision 100297
Author to...@chromium.org
Date 2011-11-15 11:16:17 -0800 (Tue, 15 Nov 2011)
Log Message
editing/pasteboard/drag-drop-dead-frame.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72379
Reviewed by Adam Barth.
* editing/pasteboard/drag-drop-dead-frame.html: Wait for iframe to load before running test.
* platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt: Rebaseline.
* platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
* platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
* platform/qt/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/drag-drop-dead-frame.html
trunk/LayoutTests/platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt
trunk/LayoutTests/platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt
trunk/LayoutTests/platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt
trunk/LayoutTests/platform/qt/editing/pasteboard/drag-drop-dead-frame-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100296 => 100297)
--- trunk/LayoutTests/ChangeLog 2011-11-15 19:14:53 UTC (rev 100296)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 19:16:17 UTC (rev 100297)
@@ -1,3 +1,16 @@
+2011-11-15 Tony Gentilcore to...@chromium.org
+
+editing/pasteboard/drag-drop-dead-frame.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=72379
+
+Reviewed by Adam Barth.
+
+* editing/pasteboard/drag-drop-dead-frame.html: Wait for iframe to load before running test.
+* platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt: Rebaseline.
+* platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
+* platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
+* platform/qt/editing/pasteboard/drag-drop-dead-frame-expected.txt: Speculative rebaseline based on change to chromium.
+
2011-11-15 Anna Cavender ann...@chromium.org
Change layout tests for cuechange, enter, and exit events to check the order
Modified: trunk/LayoutTests/editing/pasteboard/drag-drop-dead-frame.html (100296 => 100297)
--- trunk/LayoutTests/editing/pasteboard/drag-drop-dead-frame.html 2011-11-15 19:14:53 UTC (rev 100296)
+++ trunk/LayoutTests/editing/pasteboard/drag-drop-dead-frame.html 2011-11-15 19:16:17 UTC (rev 100297)
@@ -74,7 +74,6 @@
pCheck you don't crash when your previous drag target frame is deleted lt;rdar://problem/5049842gt;/p
divspan id=dragmehello/span/div
-iframe id=targetframe src=""
-scriptrunEditingTest();/script
+iframe id=targetframe src="" _onload_=runEditingTest()/iframe
/body
/html
Modified: trunk/LayoutTests/platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt (100296 => 100297)
--- trunk/LayoutTests/platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt 2011-11-15 19:14:53 UTC (rev 100296)
+++ trunk/LayoutTests/platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt 2011-11-15 19:16:17 UTC (rev 100297)
@@ -18,6 +18,5 @@
text run at (0,0) width 28: hello
RenderBlock (anonymous) at (0,56) size 784x0
RenderText {#text} at (0,0) size 0x0
-RenderText {#text} at (0,0) size 0x0
selection start: position 0 of child 0 {#text} of child 0 {SPAN} of child 3 {DIV} of body
selection end: position 5 of child 0 {#text} of child 0 {SPAN} of child 3 {DIV} of body
Modified: trunk/LayoutTests/platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt (100296 => 100297)
--- trunk/LayoutTests/platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt 2011-11-15 19:14:53 UTC (rev 100296)
+++ trunk/LayoutTests/platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt 2011-11-15 19:16:17 UTC (rev 100297)
@@ -13,6 +13,5 @@
text run at (0,0) width 31: hello
RenderBlock (anonymous) at (0,54) size 784x0
RenderText {#text} at (0,0) size 0x0
-RenderText {#text} at (0,0) size 0x0
selection start: position 0 of child 0 {#text} of child 0 {SPAN} of child 3 {DIV} of body
selection end: position 5 of child 0 {#text} of child 0 {SPAN} of child 3 {DIV} of body
Modified: trunk/LayoutTests/platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt (100296 => 100297)
--- trunk/LayoutTests/platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt 2011-11-15 19:14:53 UTC (rev 100296)
+++ trunk/LayoutTests/platform/mac/editing/pasteboard/drag-drop-dead-frame-expected.txt 2011-11-15 19:16:17 UTC (rev 100297)
@@ -18,6 +18,5 @@
text run at (0,0) width 31: hello
[webkit-changes] [100298] trunk/Source/WebCore
Title: [100298] trunk/Source/WebCore Revision 100298 Author ddkil...@apple.com Date 2011-11-15 11:16:34 -0800 (Tue, 15 Nov 2011) Log Message Remove useless const modifier from KURL::init http://webkit.org/b/72387 Reviewed by Darin Adler. * platform/KURL.cpp: (WebCore::KURL::init): Remove useless const. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/KURL.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (100297 => 100298) --- trunk/Source/WebCore/ChangeLog 2011-11-15 19:16:17 UTC (rev 100297) +++ trunk/Source/WebCore/ChangeLog 2011-11-15 19:16:34 UTC (rev 100298) @@ -1,3 +1,13 @@ +2011-11-15 David Kilzer ddkil...@apple.com + +Remove useless const modifier from KURL::init +http://webkit.org/b/72387 + +Reviewed by Darin Adler. + +* platform/KURL.cpp: +(WebCore::KURL::init): Remove useless const. + 2011-11-14 Anders Carlsson ander...@apple.com HostWindow invalidation functions should use root view coordinates Modified: trunk/Source/WebCore/platform/KURL.cpp (100297 => 100298) --- trunk/Source/WebCore/platform/KURL.cpp 2011-11-15 19:16:17 UTC (rev 100297) +++ trunk/Source/WebCore/platform/KURL.cpp 2011-11-15 19:16:34 UTC (rev 100298) @@ -486,7 +486,7 @@ parseBuffer.resize(bufferSize); char* bufferPos = parseBuffer.data(); -const char* bufferStart = bufferPos; +char* bufferStart = bufferPos; // first copy everything before the path from the base unsigned baseLength = base.m_string.length(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100299] trunk/LayoutTests
Title: [100299] trunk/LayoutTests
Revision 100299
Author ann...@chromium.org
Date 2011-11-15 11:29:49 -0800 (Tue, 15 Nov 2011)
Log Message
Guarantee tests run in order.
https://bugs.webkit.org/show_bug.cgi?id=72369
Reviewed by Eric Carlson.
* media/track/track-webvtt-tc003-newlines.html:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/track-webvtt-tc003-newlines.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100298 => 100299)
--- trunk/LayoutTests/ChangeLog 2011-11-15 19:16:34 UTC (rev 100298)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 19:29:49 UTC (rev 100299)
@@ -1,3 +1,13 @@
+2011-11-15 Anna Cavender ann...@chromium.org
+
+Guarantee tests run in order.
+https://bugs.webkit.org/show_bug.cgi?id=72369
+
+Reviewed by Eric Carlson.
+
+* media/track/track-webvtt-tc003-newlines.html:
+* platform/chromium/test_expectations.txt:
+
2011-11-15 Tony Gentilcore to...@chromium.org
editing/pasteboard/drag-drop-dead-frame.html is flaky
Modified: trunk/LayoutTests/media/track/track-webvtt-tc003-newlines.html (100298 => 100299)
--- trunk/LayoutTests/media/track/track-webvtt-tc003-newlines.html 2011-11-15 19:16:34 UTC (rev 100298)
+++ trunk/LayoutTests/media/track/track-webvtt-tc003-newlines.html 2011-11-15 19:29:49 UTC (rev 100299)
@@ -9,8 +9,17 @@
numberOfTrackTests = 2;
-function trackLoaded(i)
+function trackLoaded()
{
+numberOfTracksLoaded++;
+if (numberOfTracksLoaded == numberOfTrackTests) {
+testTrack(0);
+testTrack(1);
+}
+}
+
+function testTrack(i)
+{
findMediaElement();
var expected =
{
@@ -44,8 +53,8 @@
body
pTests that line terminators \r, \n, or \r\n are properly parsed, even when there is no newline at eof./p
video
-track src="" _onload_=trackLoaded(0)
-track src="" _onload_=trackLoaded(1)
+track src="" _onload_=trackLoaded()
+track src="" _onload_=trackLoaded()
/video
/body
/html
\ No newline at end of file
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100298 => 100299)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 19:16:34 UTC (rev 100298)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 19:29:49 UTC (rev 100299)
@@ -3921,7 +3921,6 @@
BUGWK72272 WIN : security/crypto-random-values-types.html = TEXT PASS
BUGWK72279 : media/track/track-webvtt-tc004-magic-header.html = TIMEOUT PASS
-BUGWK72369 : media/track/track-webvtt-tc003-newlines.html = TEXT PASS
BUGWK59771 WIN : http/tests/inspector/resource-tree/resource-tree-frame-add.html = TIMEOUT PASS
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100300] trunk/LayoutTests
Title: [100300] trunk/LayoutTests
Revision 100300
Author ann...@chromium.org
Date 2011-11-15 11:37:58 -0800 (Tue, 15 Nov 2011)
Log Message
Guarantee tests run in order.
https://bugs.webkit.org/show_bug.cgi?id=72398
Reviewed by Eric Carlson.
* media/track/track-webvtt-tc013-settings.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/track-webvtt-tc013-settings.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100299 => 100300)
--- trunk/LayoutTests/ChangeLog 2011-11-15 19:29:49 UTC (rev 100299)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 19:37:58 UTC (rev 100300)
@@ -1,6 +1,15 @@
2011-11-15 Anna Cavender ann...@chromium.org
Guarantee tests run in order.
+https://bugs.webkit.org/show_bug.cgi?id=72398
+
+Reviewed by Eric Carlson.
+
+* media/track/track-webvtt-tc013-settings.html:
+
+2011-11-15 Anna Cavender ann...@chromium.org
+
+Guarantee tests run in order.
https://bugs.webkit.org/show_bug.cgi?id=72369
Reviewed by Eric Carlson.
Modified: trunk/LayoutTests/media/track/track-webvtt-tc013-settings.html (100299 => 100300)
--- trunk/LayoutTests/media/track/track-webvtt-tc013-settings.html 2011-11-15 19:29:49 UTC (rev 100299)
+++ trunk/LayoutTests/media/track/track-webvtt-tc013-settings.html 2011-11-15 19:37:58 UTC (rev 100300)
@@ -9,8 +9,17 @@
numberOfTrackTests = 2;
-function trackLoaded(i)
+function trackLoaded()
{
+numberOfTracksLoaded++;
+if (numberOfTracksLoaded == numberOfTrackTests) {
+for (var i = 0; i = numberOfTrackTests; ++i)
+testTrack(i);
+}
+}
+
+function testTrack(i)
+{
findMediaElement();
var expected =
{
@@ -44,8 +53,8 @@
body
pTests WebVTT settings./p
video
-track src="" _onload_=trackLoaded(0)
-track src="" _onload_=trackLoaded(1)
+track src="" _onload_=trackLoaded()
+track src="" _onload_=trackLoaded()
/video
/body
/html
\ No newline at end of file
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100301] trunk/LayoutTests
Title: [100301] trunk/LayoutTests Revision 100301 Author t...@chromium.org Date 2011-11-15 11:47:59 -0800 (Tue, 15 Nov 2011) Log Message Land chromium win results for flexbox repaint tests. Still waiting on mac results. * platform/chromium-win/css3/flexbox/repaint-expected.png: Added. * platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-win/css3/flexbox/ trunk/LayoutTests/platform/chromium-win/css3/flexbox/repaint-expected.png trunk/LayoutTests/platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (100300 => 100301) --- trunk/LayoutTests/ChangeLog 2011-11-15 19:37:58 UTC (rev 100300) +++ trunk/LayoutTests/ChangeLog 2011-11-15 19:47:59 UTC (rev 100301) @@ -1,3 +1,12 @@ +2011-11-15 Tony Chang t...@chromium.org + +Land chromium win results for flexbox repaint tests. +Still waiting on mac results. + +* platform/chromium-win/css3/flexbox/repaint-expected.png: Added. +* platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png: Added. +* platform/chromium/test_expectations.txt: + 2011-11-15 Anna Cavender ann...@chromium.org Guarantee tests run in order. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100300 => 100301) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 19:37:58 UTC (rev 100300) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 19:47:59 UTC (rev 100301) @@ -3875,8 +3875,8 @@ BUG_SENORBLANCO GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT // Need to rebaseline on win and mac. -BUG_TONY WIN MAC : css3/flexbox/repaint.html = PASS FAIL -BUG_TONY WIN MAC : css3/flexbox/repaint-rtl-column.html = PASS FAIL +BUG_TONY MAC : css3/flexbox/repaint.html = PASS FAIL +BUG_TONY MAC : css3/flexbox/repaint-rtl-column.html = PASS FAIL BUGWK72149 : media/track/tracklist-is-reachable.html = TEXT Added: trunk/LayoutTests/platform/chromium-win/css3/flexbox/repaint-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/css3/flexbox/repaint-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100302] branches/subpixellayout/Source/WebCore
Title: [100302] branches/subpixellayout/Source/WebCore
Revision 100302
Author le...@chromium.org
Date 2011-11-15 11:48:46 -0800 (Tue, 15 Nov 2011)
Log Message
Fixing overloaded scrollbar painting methods on Mac
Modified Paths
branches/subpixellayout/Source/WebCore/platform/Scrollbar.cpp
branches/subpixellayout/Source/WebCore/platform/Scrollbar.h
branches/subpixellayout/Source/WebCore/platform/ScrollbarTheme.h
branches/subpixellayout/Source/WebCore/platform/ScrollbarThemeComposite.h
branches/subpixellayout/Source/WebCore/platform/mac/ScrollbarThemeMac.h
branches/subpixellayout/Source/WebCore/platform/mac/ScrollbarThemeMac.mm
branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderScrollbarTheme.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderScrollbarTheme.h
Diff
Modified: branches/subpixellayout/Source/WebCore/platform/Scrollbar.cpp (100301 => 100302)
--- branches/subpixellayout/Source/WebCore/platform/Scrollbar.cpp 2011-11-15 19:47:59 UTC (rev 100301)
+++ branches/subpixellayout/Source/WebCore/platform/Scrollbar.cpp 2011-11-15 19:48:46 UTC (rev 100302)
@@ -58,9 +58,9 @@
}
#endif
-LayoutUnit Scrollbar::maxOverlapBetweenPages()
+int Scrollbar::maxOverlapBetweenPages()
{
-static LayoutUnit maxOverlapBetweenPages = ScrollbarTheme::theme()-maxOverlapBetweenPages();
+static int maxOverlapBetweenPages = ScrollbarTheme::theme()-maxOverlapBetweenPages();
return maxOverlapBetweenPages;
}
Modified: branches/subpixellayout/Source/WebCore/platform/Scrollbar.h (100301 => 100302)
--- branches/subpixellayout/Source/WebCore/platform/Scrollbar.h 2011-11-15 19:47:59 UTC (rev 100301)
+++ branches/subpixellayout/Source/WebCore/platform/Scrollbar.h 2011-11-15 19:48:46 UTC (rev 100302)
@@ -52,7 +52,7 @@
static int pixelsPerLineStep() { return 40; }
static float minFractionToStepWhenPaging() { return 0.875f; }
-static LayoutUnit maxOverlapBetweenPages();
+static int maxOverlapBetweenPages();
void disconnectFromScrollableArea() { m_scrollableArea = 0; }
ScrollableArea* scrollableArea() const { return m_scrollableArea; }
Modified: branches/subpixellayout/Source/WebCore/platform/ScrollbarTheme.h (100301 => 100302)
--- branches/subpixellayout/Source/WebCore/platform/ScrollbarTheme.h 2011-11-15 19:47:59 UTC (rev 100301)
+++ branches/subpixellayout/Source/WebCore/platform/ScrollbarTheme.h 2011-11-15 19:48:46 UTC (rev 100302)
@@ -26,8 +26,8 @@
#ifndef ScrollbarTheme_h
#define ScrollbarTheme_h
+#include IntRect.h
#include GraphicsContext.h
-#include LayoutTypes.h
#include ScrollTypes.h
namespace WebCore {
@@ -44,7 +44,7 @@
virtual void updateEnabledState(Scrollbar*) { };
-virtual bool paint(Scrollbar*, GraphicsContext*, const LayoutRect /*damageRect*/) { return false; }
+virtual bool paint(Scrollbar*, GraphicsContext*, const IntRect /*damageRect*/) { return false; }
virtual ScrollbarPart hitTest(Scrollbar*, const PlatformMouseEvent) { return NoPart; }
virtual int scrollbarThickness(ScrollbarControlSize = RegularScrollbar) { return 0; }
@@ -79,10 +79,10 @@
virtual void invalidatePart(Scrollbar*, ScrollbarPart) {}
-virtual void paintScrollCorner(ScrollView*, GraphicsContext* context, const FixedRect cornerRect) { defaultPaintScrollCorner(context, cornerRect); }
-static void defaultPaintScrollCorner(GraphicsContext* context, const FixedRect cornerRect) { context-fillRect(enclosingIntRect(cornerRect), Color::white, ColorSpaceDeviceRGB); }
+virtual void paintScrollCorner(ScrollView*, GraphicsContext* context, const IntRect cornerRect) { defaultPaintScrollCorner(context, cornerRect); }
+static void defaultPaintScrollCorner(GraphicsContext* context, const IntRect cornerRect) { context-fillRect(cornerRect, Color::white, ColorSpaceDeviceRGB); }
-virtual void paintOverhangAreas(ScrollView*, GraphicsContext*, const FixedRect, const FixedRect, const FixedRect) { }
+virtual void paintOverhangAreas(ScrollView*, GraphicsContext*, const IntRect, const IntRect, const IntRect) { }
virtual bool shouldCenterOnThumb(Scrollbar*, const PlatformMouseEvent) { return false; }
virtual bool shouldSnapBackToDragOrigin(Scrollbar*, const PlatformMouseEvent) { return false; }
@@ -92,7 +92,7 @@
virtual int trackPosition(Scrollbar*) { return 0; } // The position of the track relative to the scrollbar.
virtual int trackLength(Scrollbar*) { return 0; } // The length of the track along the axis of the scrollbar.
-virtual LayoutUnit maxOverlapBetweenPages() { return std::numeric_limitsLayoutUnit::max(); }
+virtual int maxOverlapBetweenPages() { return std::numeric_limitsint::max(); }
virtual double initialAutoscrollTimerDelay() { return 0.25; }
virtual double autoscrollTimerDelay() { return 0.05; }
Modified: branches/subpixellayout/Source/WebCore/platform/ScrollbarThemeComposite.h (100301 => 100302)
[webkit-changes] [100303] trunk/LayoutTests
Title: [100303] trunk/LayoutTests
Revision 100303
Author ann...@chromium.org
Date 2011-11-15 11:49:09 -0800 (Tue, 15 Nov 2011)
Log Message
Make sure both the video and the track are ready to be tested before testing.
https://bugs.webkit.org/show_bug.cgi?id=72399
Reviewed by Eric Carlson.
* media/track/track-cues-seeking.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/track-cues-seeking.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100302 => 100303)
--- trunk/LayoutTests/ChangeLog 2011-11-15 19:48:46 UTC (rev 100302)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 19:49:09 UTC (rev 100303)
@@ -1,3 +1,12 @@
+2011-11-15 Anna Cavender ann...@chromium.org
+
+Make sure both the video and the track are ready to be tested before testing.
+https://bugs.webkit.org/show_bug.cgi?id=72399
+
+Reviewed by Eric Carlson.
+
+* media/track/track-cues-seeking.html:
+
2011-11-15 Tony Chang t...@chromium.org
Land chromium win results for flexbox repaint tests.
Modified: trunk/LayoutTests/media/track/track-cues-seeking.html (100302 => 100303)
--- trunk/LayoutTests/media/track/track-cues-seeking.html 2011-11-15 19:48:46 UTC (rev 100302)
+++ trunk/LayoutTests/media/track/track-cues-seeking.html 2011-11-15 19:49:09 UTC (rev 100303)
@@ -9,13 +9,27 @@
body
pTests TextTrack's activeCues are indexed and updated during video playback./p
video controls
-track id=testTrack src="" kind=subtitles
+track id=testTrack src="" kind=subtitles _onload_=loaded()
/video
script
var seekedCount = 0;
var testTrack;
+
+var trackLoaded = false;
+var videoCanPlayThrough = false;
+function attemptTests()
+{
+if (!trackLoaded || !videoCanPlayThrough)
+return;
+
+testTrack = document.getElementById(testTrack);
+testExpected(testTrack.track.cues.length, 3);
+run(video.currentTime = 0.5);
+consoleWrite();
+}
+
function seeked()
{
++seekedCount;
@@ -38,12 +52,16 @@
waitForEvent('canplaythrough',
function ()
{
-testTrack = document.getElementById(testTrack);
-testExpected(testTrack.track.cues.length, 3);
-run(video.currentTime = 0.5);
-consoleWrite();
+videoCanPlayThrough = true;
+attemptTests();
}
);
+
+function loaded()
+{
+trackLoaded = true;
+attemptTests();
+}
findMediaElement();
video.src = "" ../content/test);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100304] trunk/LayoutTests
Title: [100304] trunk/LayoutTests Revision 100304 Author o...@webkit.org Date 2011-11-15 11:54:09 -0800 (Tue, 15 Nov 2011) Log Message [Qt] Unreviewed evening gardening after r100289. * platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100303 => 100304) --- trunk/LayoutTests/ChangeLog 2011-11-15 19:49:09 UTC (rev 100303) +++ trunk/LayoutTests/ChangeLog 2011-11-15 19:54:09 UTC (rev 100304) @@ -1,3 +1,9 @@ +2011-11-15 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed evening gardening after r100289. + +* platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt: + 2011-11-15 Anna Cavender ann...@chromium.org Make sure both the video and the track are ready to be tested before testing. Modified: trunk/LayoutTests/platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt (100303 => 100304) --- trunk/LayoutTests/platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt 2011-11-15 19:49:09 UTC (rev 100303) +++ trunk/LayoutTests/platform/qt/fast/dom/Orientation/create-event-orientationchange-expected.txt 2011-11-15 19:54:09 UTC (rev 100304) @@ -3,14 +3,7 @@ On success, you will see a series of PASS messages, followed by TEST COMPLETE. - -PASS - - PASS successfullyParsed is true TEST COMPLETE - - - - +PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100305] trunk/LayoutTests
Title: [100305] trunk/LayoutTests
Revision 100305
Author rob...@webkit.org
Date 2011-11-15 11:58:35 -0800 (Tue, 15 Nov 2011)
Log Message
Mac results for r100177
Unreviewed gardening.
* platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-001-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-002-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
* platform/mac/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
* platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt:
* platform/mac/fast/table/multiple-captions-display-expected.txt:
* platform/mac/fast/table/prepend-in-anonymous-table-expected.txt:
* platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt
trunk/LayoutTests/platform/mac/fast/table/multiple-captions-display-expected.txt
trunk/LayoutTests/platform/mac/fast/table/prepend-in-anonymous-table-expected.txt
trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt
Added Paths
trunk/LayoutTests/platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt
trunk/LayoutTests/platform/mac/css2.1/20110323/table-caption-001-expected.txt
trunk/LayoutTests/platform/mac/css2.1/20110323/table-caption-002-expected.txt
trunk/LayoutTests/platform/mac/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt
trunk/LayoutTests/platform/mac/css2.1/20110323/table-caption-margins-001-expected.txt
trunk/LayoutTests/platform/mac/css2.1/20110323/table-caption-optional-001-expected.txt
trunk/LayoutTests/platform/mac/css2.1/20110323/table-caption-optional-002-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100304 => 100305)
--- trunk/LayoutTests/ChangeLog 2011-11-15 19:54:09 UTC (rev 100304)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 19:58:35 UTC (rev 100305)
@@ -1,3 +1,21 @@
+2011-11-15 Robert Hogan rob...@webkit.org
+
+Mac results for r100177
+
+Unreviewed gardening.
+
+* platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
+* platform/mac/css2.1/20110323/table-caption-001-expected.txt: Added.
+* platform/mac/css2.1/20110323/table-caption-002-expected.txt: Added.
+* platform/mac/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
+* platform/mac/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
+* platform/mac/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
+* platform/mac/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
+* platform/mac/fast/table/dynamic-caption-add-before-child-expected.txt:
+* platform/mac/fast/table/multiple-captions-display-expected.txt:
+* platform/mac/fast/table/prepend-in-anonymous-table-expected.txt:
+* platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
+
2011-11-15 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed evening gardening after r100289.
Added: trunk/LayoutTests/platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt (0 => 100305)
--- trunk/LayoutTests/platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt 2011-11-15 19:58:35 UTC (rev 100305)
@@ -0,0 +1,11 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x298
+ RenderBlock {HTML} at (0,0) size 800x298
+RenderBody {BODY} at (8,16) size 784x274
+ RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 645x18
+ text run at (0,0) width 645: Test passes if there is a blue and orange square below and there is no vertical gap between the squares.
+ RenderTable {DIV} at (0,34) size 120x240
+RenderBlock {DIV} at (0,0) size 120x120 [border: (10px solid #FF)]
+RenderBlock {DIV} at (0,120) size 120x120 [border: (10px solid #FFA500)]
Property changes on: trunk/LayoutTests/platform/mac/css2.1/20110323/border-spacing-applies-to-015-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/platform/mac/css2.1/20110323/table-caption-001-expected.txt (0 => 100305)
--- trunk/LayoutTests/platform/mac/css2.1/20110323/table-caption-001-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/css2.1/20110323/table-caption-001-expected.txt 2011-11-15 19:58:35 UTC (rev 100305)
@@ -0,0 +1,19 @@
+layer at (0,0) size
[webkit-changes] [100306] trunk/Source/WebKit/chromium
Title: [100306] trunk/Source/WebKit/chromium Revision 100306 Author commit-qu...@webkit.org Date 2011-11-15 12:05:34 -0800 (Tue, 15 Nov 2011) Log Message [Chromium] gamepad changes to the public interface of Chromium port https://bugs.webkit.org/show_bug.cgi?id=71518 Patch by Scott Graham scot...@chromium.org on 2011-11-15 Reviewed by Darin Fisher. Adds stubs for Chromium port, and defines shared memory structure to be used between browser and WebKit. Includes just the parts that touch the public interface so they can be reviewed separately. See also: https://bugs.webkit.org/show_bug.cgi?id=69451 and http://codereview.chromium.org/8345027 * WebKit.gyp: * public/WebGamepad.h: Added. (WebKit::WebGamepad::WebGamepad): * public/WebGamepads.h: Added. (WebKit::WebGamepads::WebGamepads): * public/WebKitPlatformSupport.h: (WebKit::WebKitPlatformSupport::sampleGamepads): * public/WebRuntimeFeatures.h: * src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableGamepad): (WebKit::WebRuntimeFeatures::isGamepadEnabled): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/public/WebKitPlatformSupport.h trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp Added Paths trunk/Source/WebKit/chromium/public/WebGamepad.h trunk/Source/WebKit/chromium/public/WebGamepads.h Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (100305 => 100306) --- trunk/Source/WebKit/chromium/ChangeLog 2011-11-15 19:58:35 UTC (rev 100305) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-15 20:05:34 UTC (rev 100306) @@ -1,3 +1,30 @@ +2011-11-15 Scott Graham scot...@chromium.org + +[Chromium] gamepad changes to the public interface of Chromium port +https://bugs.webkit.org/show_bug.cgi?id=71518 + +Reviewed by Darin Fisher. + +Adds stubs for Chromium port, and defines shared memory structure to +be used between browser and WebKit. + +Includes just the parts that touch the public interface so they can be +reviewed separately. See also: +https://bugs.webkit.org/show_bug.cgi?id=69451 and +http://codereview.chromium.org/8345027 + +* WebKit.gyp: +* public/WebGamepad.h: Added. +(WebKit::WebGamepad::WebGamepad): +* public/WebGamepads.h: Added. +(WebKit::WebGamepads::WebGamepads): +* public/WebKitPlatformSupport.h: +(WebKit::WebKitPlatformSupport::sampleGamepads): +* public/WebRuntimeFeatures.h: +* src/WebRuntimeFeatures.cpp: +(WebKit::WebRuntimeFeatures::enableGamepad): +(WebKit::WebRuntimeFeatures::isGamepadEnabled): + 2011-11-14 Anders Carlsson ander...@apple.com HostWindow invalidation functions should use root view coordinates Modified: trunk/Source/WebKit/chromium/WebKit.gyp (100305 => 100306) --- trunk/Source/WebKit/chromium/WebKit.gyp 2011-11-15 19:58:35 UTC (rev 100305) +++ trunk/Source/WebKit/chromium/WebKit.gyp 2011-11-15 20:05:34 UTC (rev 100306) @@ -192,6 +192,8 @@ 'public/WebFontCache.h', 'public/WebFormControlElement.h', 'public/WebFormElement.h', +'public/WebGamepad.h', +'public/WebGamepads.h', 'public/WebGeolocationClient.h', 'public/WebGeolocationClientMock.h', 'public/WebGeolocationController.h', Added: trunk/Source/WebKit/chromium/public/WebGamepad.h (0 => 100306) --- trunk/Source/WebKit/chromium/public/WebGamepad.h (rev 0) +++ trunk/Source/WebKit/chromium/public/WebGamepad.h 2011-11-15 20:05:34 UTC (rev 100306) @@ -0,0 +1,74 @@ +// Copyright (C) 2011, Google Inc. All rights reserved. +// +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are met: +// +// 1. Redistributions of source code must retain the above copyright +//notice, this list of conditions and the following disclaimer. +// 2. Redistributions in binary form must reproduce the above copyright +//notice, this list of conditions and the following disclaimer in the +//documentation and/or other materials provided with the distribution. +// +// THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND +// ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE +// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE +// ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE +// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL +// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR +// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER +// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT +// LIABILITY, OR TORT (INCLUDING
[webkit-changes] [100307] trunk
Title: [100307] trunk Revision 100307 Author commit-qu...@webkit.org Date 2011-11-15 12:13:53 -0800 (Tue, 15 Nov 2011) Log Message Source/WebCore: Event listener for active DOM object that is also DOM node can be garbage collected prematurely. https://bugs.webkit.org/show_bug.cgi?id=70421 Patch by Eugene Nalimov e...@google.com on 2011-11-15 Reviewed by Adam Barth. Problem demonstrated itself when HTMLAudioElement was changed to become active DOM object. Before that there were no DOM objects that simultaneously were nodes and active objects. DOM object could be held in one of 3 maps -- node map, active objects map, and all other objects map, and HTMLAudioElement should be in 2 maps simultaneously. When it was in the active DOM objects map only, its event listener could be garbage collected, because special code that groups listeners with wrappers could handle only wrappers for objects in the node map. If we put HTMLAudioElement into nodes map, it would not be active DOM node, and can be garbage collected prematurely itself (see https://bugs.webkit.org/show_bug.cgi?id=66878). Fix is to introduce 4th map -- active nodes map, and change the code accordingly. Test: media/audio-garbage-collect.html * bindings/scripts/CodeGeneratorV8.pm: (GenerateNamedConstructorCallback): (GetDomMapFunction): * bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::getDOMWrapperMap): (WebCore::DOMDataStore::weakNodeCallback): * bindings/v8/DOMDataStore.h: (WebCore::DOMDataStore::activeDomNodeMap): * bindings/v8/ScopedDOMDataStore.cpp: (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore): * bindings/v8/StaticDOMDataStore.cpp: (WebCore::StaticDOMDataStore::StaticDOMDataStore): * bindings/v8/StaticDOMDataStore.h: * bindings/v8/V8DOMMap.cpp: (WebCore::getActiveDOMNodeMap): (WebCore::removeAllDOMObjects): (WebCore::visitActiveDOMNodes): * bindings/v8/V8DOMMap.h: * bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setJSWrapperForDOMNode): (WebCore::V8DOMWrapper::getWrapperSlow): * bindings/v8/V8GCController.cpp: (WebCore::GCPrologueSpecialCase): (WebCore::void): (WebCore::Node): (WebCore::GCPrologueVisitor::visitDOMWrapper): (WebCore::V8GCController::gcPrologue): (WebCore::GCEpilogueHelper::GCEpilogueSpecialCase): (WebCore::GCEpilogueVisitor::visitDOMWrapper): (WebCore::V8GCController::gcEpilogue): * dom/Node.h: (WebCore::Node::isActiveNode): * html/HTMLAudioElement.h: (WebCore::HTMLAudioElement::isActiveNode): LayoutTests: Event listener for active DOM object that is also DOM node can be garbage collected prematurely. https://bugs.webkit.org/show_bug.cgi?id=70421 and https://bugs.webkit.org/show_bug.cgi?id=66878 Patch by Eugene Nalimov e...@google.com on 2011-11-15 Reviewed by Adam Barth. * media/audio-garbage-collect-expected.txt: Added. * media/audio-garbage-collect.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp trunk/Source/WebCore/bindings/v8/DOMDataStore.h trunk/Source/WebCore/bindings/v8/ScopedDOMDataStore.cpp trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.cpp trunk/Source/WebCore/bindings/v8/StaticDOMDataStore.h trunk/Source/WebCore/bindings/v8/V8DOMMap.cpp trunk/Source/WebCore/bindings/v8/V8DOMMap.h trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp trunk/Source/WebCore/bindings/v8/V8GCController.cpp trunk/Source/WebCore/dom/Node.h trunk/Source/WebCore/html/HTMLAudioElement.h Added Paths trunk/LayoutTests/media/audio-garbage-collect-expected.txt trunk/LayoutTests/media/audio-garbage-collect.html Diff Modified: trunk/LayoutTests/ChangeLog (100306 => 100307) --- trunk/LayoutTests/ChangeLog 2011-11-15 20:05:34 UTC (rev 100306) +++ trunk/LayoutTests/ChangeLog 2011-11-15 20:13:53 UTC (rev 100307) @@ -1,3 +1,13 @@ +2011-11-15 Eugene Nalimov e...@google.com + +Event listener for active DOM object that is also DOM node can be garbage collected prematurely. +https://bugs.webkit.org/show_bug.cgi?id=70421 and https://bugs.webkit.org/show_bug.cgi?id=66878 + +Reviewed by Adam Barth. + +* media/audio-garbage-collect-expected.txt: Added. +* media/audio-garbage-collect.html: Added. + 2011-11-15 Robert Hogan rob...@webkit.org Mac results for r100177 Added: trunk/LayoutTests/media/audio-garbage-collect-expected.txt (0 => 100307) --- trunk/LayoutTests/media/audio-garbage-collect-expected.txt (rev 0) +++ trunk/LayoutTests/media/audio-garbage-collect-expected.txt 2011-11-15 20:13:53 UTC (rev 100307) @@ -0,0 +1,11 @@ +Tests that we don't garbage collect playing audio object or event listener. + +According to http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html, +4.8.10.8 Playing the media resource, +Media elements must not stop playing just because all references to
[webkit-changes] [100308] trunk/Source/WebCore
Title: [100308] trunk/Source/WebCore
Revision 100308
Author commit-qu...@webkit.org
Date 2011-11-15 12:21:09 -0800 (Tue, 15 Nov 2011)
Log Message
Patch removing duplicated code in the setup of the DrawingBuffer used
to host the back-buffer for WebGL contents.
https://bugs.webkit.org/show_bug.cgi?id=72327
Patch by Jeff Timanus t...@chromium.org on 2011-11-15
Reviewed by Julien Chaffraix.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100307 => 100308)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 20:13:53 UTC (rev 100307)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 20:21:09 UTC (rev 100308)
@@ -1,3 +1,16 @@
+2011-11-15 Jeff Timanus t...@chromium.org
+
+Patch removing duplicated code in the setup of the DrawingBuffer used
+to host the back-buffer for WebGL contents.
+https://bugs.webkit.org/show_bug.cgi?id=72327
+
+Reviewed by Julien Chaffraix.
+
+* html/canvas/WebGLRenderingContext.cpp:
+(WebCore::WebGLRenderingContext::copyTexImage2D):
+(WebCore::WebGLRenderingContext::copyTexSubImage2D):
+(WebCore::WebGLRenderingContext::readPixels):
+
2011-11-15 Eugene Nalimov e...@google.com
Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (100307 => 100308)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2011-11-15 20:13:53 UTC (rev 100307)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2011-11-15 20:21:09 UTC (rev 100308)
@@ -82,6 +82,29 @@
namespace {
+class ScopedDrawingBufferBinder {
+public:
+ScopedDrawingBufferBinder(DrawingBuffer* drawingBuffer, WebGLFramebuffer* framebufferBinding)
+: m_drawingBuffer(drawingBuffer)
+, m_framebufferBinding(framebufferBinding)
+{
+// Commit DrawingBuffer if needed (e.g., for multisampling)
+if (!m_framebufferBinding m_drawingBuffer)
+m_drawingBuffer-commit();
+}
+
+~ScopedDrawingBufferBinder()
+{
+// Restore DrawingBuffer if needed
+if (!m_framebufferBinding m_drawingBuffer)
+m_drawingBuffer-bind();
+}
+
+private:
+DrawingBuffer* m_drawingBuffer;
+WebGLFramebuffer* m_framebufferBinding;
+};
+
Platform3DObject objectOrZero(WebGLObject* object)
{
return object ? object-object() : 0;
@@ -1164,20 +1187,10 @@
}
clearIfComposited();
if (isResourceSafe()) {
-// Commit DrawingBuffer if needed (e.g., for multisampling)
-if (!m_framebufferBinding m_drawingBuffer)
-m_drawingBuffer-commit();
-
+ScopedDrawingBufferBinder(m_drawingBuffer.get(), m_framebufferBinding.get());
m_context-copyTexImage2D(target, level, internalformat, x, y, width, height, border);
-
-// Restore DrawingBuffer if needed
-if (!m_framebufferBinding m_drawingBuffer)
-m_drawingBuffer-bind();
} else {
-// Commit DrawingBuffer if needed (e.g., for multisampling)
-if (!m_framebufferBinding m_drawingBuffer)
-m_drawingBuffer-commit();
-
+ScopedDrawingBufferBinder(m_drawingBuffer.get(), m_framebufferBinding.get());
GC3Dint clippedX, clippedY;
GC3Dsizei clippedWidth, clippedHeight;
if (clip2D(x, y, width, height, getBoundFramebufferWidth(), getBoundFramebufferHeight(), clippedX, clippedY, clippedWidth, clippedHeight)) {
@@ -1189,10 +1202,6 @@
}
} else
m_context-copyTexImage2D(target, level, internalformat, x, y, width, height, border);
-
-// Restore DrawingBuffer if needed
-if (!m_framebufferBinding m_drawingBuffer)
-m_drawingBuffer-bind();
}
// FIXME: if the framebuffer is not complete, none of the below should be executed.
tex-setLevelInfo(target, level, internalformat, width, height, GraphicsContext3D::UNSIGNED_BYTE);
@@ -1223,17 +1232,10 @@
return;
}
clearIfComposited();
-if (isResourceSafe())
-// Commit DrawingBuffer if needed (e.g., for multisampling)
-if (!m_framebufferBinding m_drawingBuffer)
-m_drawingBuffer-commit();
-
+if (isResourceSafe()) {
+ScopedDrawingBufferBinder(m_drawingBuffer.get(), m_framebufferBinding.get());
m_context-copyTexSubImage2D(target, level, xoffset, yoffset, x, y, width, height);
-
-// Restore DrawingBuffer if needed
-if (!m_framebufferBinding m_drawingBuffer)
-m_drawingBuffer-bind();
-else {
+} else {
[webkit-changes] [100310] trunk
Title: [100310] trunk
Revision 100310
Author barraclo...@apple.com
Date 2011-11-15 12:34:59 -0800 (Tue, 15 Nov 2011)
Log Message
Result of Error.prototype.toString not ES5 conformant
https://bugs.webkit.org/show_bug.cgi?id=70889
Reviewed by Oliver Hunt.
Source/_javascript_Core:
* runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
LayoutTests:
* fast/js/native-error-prototype-expected.txt:
* fast/js/script-tests/native-error-prototype.js:
* fast/js/script-tests/toString-recursion.js:
* fast/js/toString-recursion-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/native-error-prototype-expected.txt
trunk/LayoutTests/fast/js/script-tests/native-error-prototype.js
trunk/LayoutTests/fast/js/script-tests/toString-recursion.js
trunk/LayoutTests/fast/js/toString-recursion-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ErrorPrototype.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (100309 => 100310)
--- trunk/LayoutTests/ChangeLog 2011-11-15 20:25:41 UTC (rev 100309)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 20:34:59 UTC (rev 100310)
@@ -1,3 +1,15 @@
+2011-11-15 Gavin Barraclough barraclo...@apple.com
+
+Result of Error.prototype.toString not ES5 conformant
+https://bugs.webkit.org/show_bug.cgi?id=70889
+
+Reviewed by Oliver Hunt.
+
+* fast/js/native-error-prototype-expected.txt:
+* fast/js/script-tests/native-error-prototype.js:
+* fast/js/script-tests/toString-recursion.js:
+* fast/js/toString-recursion-expected.txt:
+
2011-11-15 Eugene Nalimov e...@google.com
Event listener for active DOM object that is also DOM node can be garbage collected prematurely.
Modified: trunk/LayoutTests/fast/js/native-error-prototype-expected.txt (100309 => 100310)
--- trunk/LayoutTests/fast/js/native-error-prototype-expected.txt 2011-11-15 20:25:41 UTC (rev 100309)
+++ trunk/LayoutTests/fast/js/native-error-prototype-expected.txt 2011-11-15 20:34:59 UTC (rev 100310)
@@ -1,10 +1,11 @@
-This is a test case for bug 55346.
+This is a test case for bug 55346 and bug 70889.
On success, you will see a series of PASS messages, followed by TEST COMPLETE.
PASS ({}).toString.call(Error.prototype) is [object Error]
PASS ({}).toString.call(RangeError.prototype) is [object Error]
+PASS err.toString() is message
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/js/script-tests/native-error-prototype.js (100309 => 100310)
--- trunk/LayoutTests/fast/js/script-tests/native-error-prototype.js 2011-11-15 20:25:41 UTC (rev 100309)
+++ trunk/LayoutTests/fast/js/script-tests/native-error-prototype.js 2011-11-15 20:34:59 UTC (rev 100310)
@@ -1,6 +1,10 @@
description(
-'This is a test case for a href="" 55346/a.'
+'This is a test case for a href="" 55346/a and a href="" 70889/a.'
);
shouldBe(({}).toString.call(Error.prototype), '[object Error]');
shouldBe(({}).toString.call(RangeError.prototype), '[object Error]');
+
+var err = new Error(message);
+err.name = ;
+shouldBe(err.toString(), 'message');
Modified: trunk/LayoutTests/fast/js/script-tests/toString-recursion.js (100309 => 100310)
--- trunk/LayoutTests/fast/js/script-tests/toString-recursion.js 2011-11-15 20:25:41 UTC (rev 100309)
+++ trunk/LayoutTests/fast/js/script-tests/toString-recursion.js 2011-11-15 20:34:59 UTC (rev 100310)
@@ -6,7 +6,7 @@
shouldBe(var array = []; array[0] = array; array + '', '');
// Error (name, message)
-shouldBe(var error = new Error; error.name = error; error.message = error; error + '', ': ');
+shouldBe(var error = new Error; error.name = error; error.message = error; error + '', '');
// RegExp (source)
shouldBe(var regexp = /a/; regexp.source = regexp; regexp + '', '/a/');
Modified: trunk/LayoutTests/fast/js/toString-recursion-expected.txt (100309 => 100310)
--- trunk/LayoutTests/fast/js/toString-recursion-expected.txt 2011-11-15 20:25:41 UTC (rev 100309)
+++ trunk/LayoutTests/fast/js/toString-recursion-expected.txt 2011-11-15 20:34:59 UTC (rev 100310)
@@ -4,7 +4,7 @@
PASS var array = []; array[0] = array; array + '' is ''
-PASS var error = new Error; error.name = error; error.message = error; error + '' is ': '
+PASS var error = new Error; error.name = error; error.message = error; error + '' is ''
PASS var regexp = /a/; regexp.source = regexp; regexp + '' is '/a/'
PASS successfullyParsed is true
Modified: trunk/Source/_javascript_Core/ChangeLog (100309 => 100310)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-15 20:25:41 UTC (rev 100309)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-15 20:34:59 UTC (rev 100310)
@@ -1,3 +1,13 @@
+2011-11-15 Gavin Barraclough barraclo...@apple.com
+
+Result of Error.prototype.toString not ES5 conformant
+https://bugs.webkit.org/show_bug.cgi?id=70889
+
+Reviewed by Oliver Hunt.
+
+* runtime/ErrorPrototype.cpp:
+
[webkit-changes] [100312] trunk/LayoutTests
Title: [100312] trunk/LayoutTests
Revision 100312
Author commit-qu...@webkit.org
Date 2011-11-15 12:43:24 -0800 (Tue, 15 Nov 2011)
Log Message
Unreviewed, rolling out r100291.
http://trac.webkit.org/changeset/100291
https://bugs.webkit.org/show_bug.cgi?id=72403
For some unexpected reason the behavior is different across
platforms, causing test failures (Requested by schenney on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-15
* svg/custom/zero-path-square-cap-rendering3-expected.png: Removed.
* svg/custom/zero-path-square-cap-rendering3-expected.txt: Removed.
* svg/custom/zero-path-square-cap-rendering3.svg: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3-expected.png
trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3-expected.txt
trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (100311 => 100312)
--- trunk/LayoutTests/ChangeLog 2011-11-15 20:40:12 UTC (rev 100311)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 20:43:24 UTC (rev 100312)
@@ -1,3 +1,17 @@
+2011-11-15 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r100291.
+http://trac.webkit.org/changeset/100291
+https://bugs.webkit.org/show_bug.cgi?id=72403
+
+For some unexpected reason the behavior is different across
+platforms, causing test failures (Requested by schenney on
+#webkit).
+
+* svg/custom/zero-path-square-cap-rendering3-expected.png: Removed.
+* svg/custom/zero-path-square-cap-rendering3-expected.txt: Removed.
+* svg/custom/zero-path-square-cap-rendering3.svg: Removed.
+
2011-11-15 Nate Chapin jap...@chromium.org
Test udpates for https://bugs.webkit.org/show_bug.cgi?id=71149.
Deleted: trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3-expected.png (100311 => 100312)
--- trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3-expected.png 2011-11-15 20:40:12 UTC (rev 100311)
+++ trunk/LayoutTests/svg/custom/zero-path-square-cap-rendering3-expected.png 2011-11-15 20:43:24 UTC (rev 100312)
@@ -1,6 +0,0 @@
-\x89PNG
-
-
-IHDR X ' )tEXtchecksum 58d068507b13af7b19d2860d6fa8k=\xAD\x8F
-\xD0IDATx\x9C\xED\xD9A
-\x83P DAh*\xA2\xA7\xA6p\xC0#\xB5Rch\xA3 \xF9 \xCC(\xD8\xE3Kv\x9E~\xD3\xE5m\x9Fm\xFF\xEE\xA3W w\xF1= \xE0j @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` Ğ\xEB{
[webkit-changes] [100313] trunk/PerformanceTests/SunSpider
Title: [100313] trunk/PerformanceTests/SunSpider
Revision 100313
Author commit-qu...@webkit.org
Date 2011-11-15 13:03:52 -0800 (Tue, 15 Nov 2011)
Log Message
Extend sunspider driver to be able to run kraken
https://bugs.webkit.org/show_bug.cgi?id=71799
Patch by Andy Wingo wi...@igalia.com on 2011-11-15
Reviewed by Filip Pizlo.
* resources/sunspider-standalone-driver.js: Try to load a -data
file. If that succeeds, we have a kraken-like test, so we time
the test using `load'. Otherwise fall back to using `run'.
Modified Paths
trunk/PerformanceTests/SunSpider/ChangeLog
trunk/PerformanceTests/SunSpider/resources/sunspider-standalone-driver.js
Diff
Modified: trunk/PerformanceTests/SunSpider/ChangeLog (100312 => 100313)
--- trunk/PerformanceTests/SunSpider/ChangeLog 2011-11-15 20:43:24 UTC (rev 100312)
+++ trunk/PerformanceTests/SunSpider/ChangeLog 2011-11-15 21:03:52 UTC (rev 100313)
@@ -1,3 +1,14 @@
+2011-11-15 Andy Wingo wi...@igalia.com
+
+Extend sunspider driver to be able to run kraken
+https://bugs.webkit.org/show_bug.cgi?id=71799
+
+Reviewed by Filip Pizlo.
+
+* resources/sunspider-standalone-driver.js: Try to load a -data
+file. If that succeeds, we have a kraken-like test, so we time
+the test using `load'. Otherwise fall back to using `run'.
+
2011-08-11 Mark Rowe mr...@apple.com
Fix sunspider-compare-results to default to the same suite version as the sunspider script.
Modified: trunk/PerformanceTests/SunSpider/resources/sunspider-standalone-driver.js (100312 => 100313)
--- trunk/PerformanceTests/SunSpider/resources/sunspider-standalone-driver.js 2011-11-15 20:43:24 UTC (rev 100312)
+++ trunk/PerformanceTests/SunSpider/resources/sunspider-standalone-driver.js 2011-11-15 21:03:52 UTC (rev 100313)
@@ -32,12 +32,28 @@
times.length = tests.length;
for (var j = 0; j tests.length; j++) {
-var testName = suitePath + / + tests[j] + .js;
-var startTime = new Date;
-if (testName.indexOf('parse-only') = 0)
+var testBase = suitePath + / + tests[j];
+var testName = testBase + .js;
+var testData = testBase + -data.js;
+
+if (testName.indexOf('parse-only') = 0) {
times[j] = checkSyntax(testName);
-else
-times[j] = run(testName);
+} else {
+// Tests may or may not have associated -data files whose loading
+// should not be timed.
+try {
+load(testData);
+// If a file does have test data, then we can't use the
+// higher-precision `run' timer, because `run' uses a fresh
+// global environment, so we fall back to `load'.
+var startTime = new Date;
+load(testName);
+times[j] = new Date() - startTime;
+} catch (e) {
+// No test data, just use `run'.
+times[j] = run(testName);
+}
+}
gc();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100314] trunk/Source/JavaScriptCore
Title: [100314] trunk/Source/_javascript_Core
Revision 100314
Author msab...@apple.com
Date 2011-11-15 13:38:35 -0800 (Tue, 15 Nov 2011)
Log Message
Towards 8 bit Strings - Initial JS String Tuning
https://bugs.webkit.org/show_bug.cgi?id=72326
Added 8 bit optimized paths for the methods below.
Reviewed by Geoffrey Garen.
* runtime/JSString.h:
(JSC::jsSubstring8):
* runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharCodeAt):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSString.h
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100313 => 100314)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-15 21:03:52 UTC (rev 100313)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-15 21:38:35 UTC (rev 100314)
@@ -1,3 +1,20 @@
+2011-11-15 Michael Saboff msab...@apple.com
+
+Towards 8 bit Strings - Initial JS String Tuning
+https://bugs.webkit.org/show_bug.cgi?id=72326
+
+Added 8 bit optimized paths for the methods below.
+
+Reviewed by Geoffrey Garen.
+
+* runtime/JSString.h:
+(JSC::jsSubstring8):
+* runtime/StringPrototype.cpp:
+(JSC::jsSpliceSubstrings):
+(JSC::jsSpliceSubstringsWithSeparators):
+(JSC::stringProtoFuncReplace):
+(JSC::stringProtoFuncCharCodeAt):
+
2011-11-15 Gavin Barraclough barraclo...@apple.com
Result of Error.prototype.toString not ES5 conformant
Modified: trunk/Source/_javascript_Core/runtime/JSString.h (100313 => 100314)
--- trunk/Source/_javascript_Core/runtime/JSString.h 2011-11-15 21:03:52 UTC (rev 100313)
+++ trunk/Source/_javascript_Core/runtime/JSString.h 2011-11-15 21:38:35 UTC (rev 100314)
@@ -363,6 +363,21 @@
return jsSubstring(globalData, s-value(exec), offset, length);
}
+inline JSString* jsSubstring8(JSGlobalData* globalData, const UString s, unsigned offset, unsigned length)
+{
+ASSERT(offset = static_castunsigned(s.length()));
+ASSERT(length = static_castunsigned(s.length()));
+ASSERT(offset + length = static_castunsigned(s.length()));
+if (!length)
+return globalData-smallStrings.emptyString(globalData);
+if (length == 1) {
+UChar c = s[offset];
+if (c = maxSingleCharacterString)
+return globalData-smallStrings.singleCharacterString(globalData, c);
+}
+return fixupVPtr(globalData, JSString::createHasOtherOwner(*globalData, StringImpl::create8(s.impl(), offset, length)));
+}
+
inline JSString* jsSubstring(JSGlobalData* globalData, const UString s, unsigned offset, unsigned length)
{
ASSERT(offset = static_castunsigned(s.length()));
@@ -399,6 +414,7 @@
inline JSString* jsEmptyString(ExecState* exec) { return jsEmptyString(exec-globalData()); }
inline JSString* jsString(ExecState* exec, const UString s) { return jsString(exec-globalData(), s); }
inline JSString* jsSingleCharacterString(ExecState* exec, UChar c) { return jsSingleCharacterString(exec-globalData(), c); }
+inline JSString* jsSubstring8(ExecState* exec, const UString s, unsigned offset, unsigned length) { return jsSubstring8(exec-globalData(), s, offset, length); }
inline JSString* jsSubstring(ExecState* exec, const UString s, unsigned offset, unsigned length) { return jsSubstring(exec-globalData(), s, offset, length); }
inline JSString* jsNontrivialString(ExecState* exec, const UString s) { return jsNontrivialString(exec-globalData(), s); }
inline JSString* jsNontrivialString(ExecState* exec, const char* s) { return jsNontrivialString(exec-globalData(), s); }
Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (100313 => 100314)
--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2011-11-15 21:03:52 UTC (rev 100313)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2011-11-15 21:38:35 UTC (rev 100314)
@@ -283,7 +283,27 @@
if (!totalLength)
return jsString(exec, );
+if (source.is8Bit()) {
+LChar* buffer;
+const LChar* sourceData = source.characters8();
+RefPtrStringImpl impl = StringImpl::tryCreateUninitialized(totalLength, buffer);
+if (!impl)
+return throwOutOfMemoryError(exec);
+
+int bufferPos = 0;
+for (int i = 0; i rangeCount; i++) {
+if (int srcLen = substringRanges[i].length) {
+StringImpl::copyChars(buffer + bufferPos, sourceData + substringRanges[i].position, srcLen);
+bufferPos += srcLen;
+}
+}
+
+return jsString(exec, impl.release());
+}
+
UChar* buffer;
+const UChar* sourceData = source.characters16();
+
RefPtrStringImpl impl =
[webkit-changes] [100315] trunk/Source/JavaScriptCore
Title: [100315] trunk/Source/_javascript_Core Revision 100315 Author fpi...@apple.com Date 2011-11-15 13:54:38 -0800 (Tue, 15 Nov 2011) Log Message DFG should distinguish between constants in the constant pool and weak constants added as artifacts of code generation https://bugs.webkit.org/show_bug.cgi?id=72367 Reviewed by Geoff Garen. Added the notion of a WeakJSConstant, which is like a JSConstant except that it can only refer to JSCell*. Currently all WeakJSConstants are also backed by constants in the constant pool, since weak references originated from machine code are not yet properly handled. Replaced CheckMethod, and MethodCheckData, with a combination of WeakJSConstant and CheckStructure. This results in improved CSE, leading to a 1% win on V8. * dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::execute): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::cellConstant): (JSC::DFG::ByteCodeParser::prepareToParseBlock): (JSC::DFG::ByteCodeParser::parseBlock): * dfg/DFGGraph.cpp: (JSC::DFG::Graph::dump): * dfg/DFGGraph.h: (JSC::DFG::Graph::getJSConstantPrediction): (JSC::DFG::Graph::valueOfJSConstant): (JSC::DFG::Graph::valueOfInt32Constant): (JSC::DFG::Graph::valueOfNumberConstant): (JSC::DFG::Graph::valueOfBooleanConstant): * dfg/DFGNode.h: (JSC::DFG::Node::isWeakConstant): (JSC::DFG::Node::hasConstant): (JSC::DFG::Node::weakConstant): (JSC::DFG::Node::valueOfJSConstant): (JSC::DFG::Node::isInt32Constant): (JSC::DFG::Node::isDoubleConstant): (JSC::DFG::Node::isNumberConstant): (JSC::DFG::Node::isBooleanConstant): (JSC::DFG::Node::hasIdentifier): * dfg/DFGPropagator.cpp: (JSC::DFG::Propagator::propagateNodePredictions): (JSC::DFG::Propagator::performNodeCSE): * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGGraph.cpp trunk/Source/_javascript_Core/dfg/DFGGraph.h trunk/Source/_javascript_Core/dfg/DFGNode.h trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (100314 => 100315) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-15 21:38:35 UTC (rev 100314) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-15 21:54:38 UTC (rev 100315) @@ -1,3 +1,51 @@ +2011-11-15 Filip Pizlo fpi...@apple.com + +DFG should distinguish between constants in the constant pool and weak +constants added as artifacts of code generation +https://bugs.webkit.org/show_bug.cgi?id=72367 + +Reviewed by Geoff Garen. + +Added the notion of a WeakJSConstant, which is like a JSConstant except that +it can only refer to JSCell*. Currently all WeakJSConstants are also backed +by constants in the constant pool, since weak references originated from +machine code are not yet properly handled. + +Replaced CheckMethod, and MethodCheckData, with a combination of WeakJSConstant +and CheckStructure. This results in improved CSE, leading to a 1% win on V8. + +* dfg/DFGAbstractState.cpp: +(JSC::DFG::AbstractState::execute): +* dfg/DFGByteCodeParser.cpp: +(JSC::DFG::ByteCodeParser::cellConstant): +(JSC::DFG::ByteCodeParser::prepareToParseBlock): +(JSC::DFG::ByteCodeParser::parseBlock): +* dfg/DFGGraph.cpp: +(JSC::DFG::Graph::dump): +* dfg/DFGGraph.h: +(JSC::DFG::Graph::getJSConstantPrediction): +(JSC::DFG::Graph::valueOfJSConstant): +(JSC::DFG::Graph::valueOfInt32Constant): +(JSC::DFG::Graph::valueOfNumberConstant): +(JSC::DFG::Graph::valueOfBooleanConstant): +* dfg/DFGNode.h: +(JSC::DFG::Node::isWeakConstant): +(JSC::DFG::Node::hasConstant): +(JSC::DFG::Node::weakConstant): +(JSC::DFG::Node::valueOfJSConstant): +(JSC::DFG::Node::isInt32Constant): +(JSC::DFG::Node::isDoubleConstant): +(JSC::DFG::Node::isNumberConstant): +(JSC::DFG::Node::isBooleanConstant): +(JSC::DFG::Node::hasIdentifier): +* dfg/DFGPropagator.cpp: +(JSC::DFG::Propagator::propagateNodePredictions): +(JSC::DFG::Propagator::performNodeCSE): +* dfg/DFGSpeculativeJIT32_64.cpp: +(JSC::DFG::SpeculativeJIT::compile): +* dfg/DFGSpeculativeJIT64.cpp: +(JSC::DFG::SpeculativeJIT::compile): + 2011-11-15 Michael Saboff msab...@apple.com Towards 8 bit Strings - Initial JS String Tuning Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (100314 => 100315) --- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
[webkit-changes] [100316] branches/subpixellayout/Source/WebCore/rendering/svg
Title: [100316] branches/subpixellayout/Source/WebCore/rendering/svg
Revision 100316
Author e...@chromium.org
Date 2011-11-15 13:54:54 -0800 (Tue, 15 Nov 2011)
Log Message
Have SVGRenderTreeAsText print pixel snapped coordinates and sizes for the root and container elements.
Modified Paths
branches/subpixellayout/Source/WebCore/rendering/svg/SVGRenderSupport.cpp
branches/subpixellayout/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/rendering/svg/SVGRenderSupport.cpp (100315 => 100316)
--- branches/subpixellayout/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2011-11-15 21:54:38 UTC (rev 100315)
+++ branches/subpixellayout/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2011-11-15 21:54:54 UTC (rev 100316)
@@ -53,7 +53,7 @@
// Pass our local paint rect to computeRectForRepaint() which will
// map to parent coords and recurse up the parent chain.
-LayoutRect repaintRect = enclosingLayoutRect(object-repaintRectInLocalCoordinates());
+LayoutRect repaintRect = enclosingIntRect(object-repaintRectInLocalCoordinates());
object-computeRectForRepaint(repaintContainer, repaintRect);
return repaintRect;
}
Modified: branches/subpixellayout/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp (100315 => 100316)
--- branches/subpixellayout/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp 2011-11-15 21:54:38 UTC (rev 100315)
+++ branches/subpixellayout/Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp 2011-11-15 21:54:54 UTC (rev 100316)
@@ -341,7 +341,7 @@
static TextStream writePositionAndStyle(TextStream ts, const RenderObject object)
{
-ts const_castRenderObject(object).absoluteClippedOverflowRect();
+ts enclosingIntRect(const_castRenderObject(object).absoluteClippedOverflowRect());
writeStyle(ts, object);
return ts;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100317] trunk/LayoutTests
Title: [100317] trunk/LayoutTests Revision 100317 Author t...@chromium.org Date 2011-11-15 14:00:35 -0800 (Tue, 15 Nov 2011) Log Message [chromium] enable regions and exclusions tests, the compile flag was removed a long time ago https://bugs.webkit.org/show_bug.cgi?id=72395 Reviewed by Ojan Vafai. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100316 => 100317) --- trunk/LayoutTests/ChangeLog 2011-11-15 21:54:54 UTC (rev 100316) +++ trunk/LayoutTests/ChangeLog 2011-11-15 22:00:35 UTC (rev 100317) @@ -1,3 +1,12 @@ +2011-11-15 Tony Chang t...@chromium.org + +[chromium] enable regions and exclusions tests, the compile flag was removed a long time ago +https://bugs.webkit.org/show_bug.cgi?id=72395 + +Reviewed by Ojan Vafai. + +* platform/chromium/test_expectations.txt: + 2011-11-15 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r100291. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100316 => 100317) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 21:54:54 UTC (rev 100316) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 22:00:35 UTC (rev 100317) @@ -3268,13 +3268,10 @@ BUGCR85293 LINUX : svg/text/foreignObject-text-clipping-bug.xml = PASS IMAGE -// CSS Regions support not yet enabled. -BUGWK57312 SKIP : fast/regions = PASS -BUGWK70733 SKIP : fast/regions/render-region-custom-style-mark.html = FAIL +// Need to evaluate and update regions and exclusions tests. +BUGWK57312 : fast/regions = PASS FAIL MISSING +BUGWK57311 : fast/exclusions = PASS FAIL MISSING -// CSS Exclusions support not yet enabled. -BUGWK57311 SKIP : fast/exclusions = PASS - // CSS Filters support not yet enabled BUGWK68469 SKIP : css3/filters = PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100318] trunk/LayoutTests
Title: [100318] trunk/LayoutTests
Revision 100318
Author commit-qu...@webkit.org
Date 2011-11-15 14:12:51 -0800 (Tue, 15 Nov 2011)
Log Message
Move plugins/invalidate_rect.html to the compositing directory since it is a compositor test
https://bugs.webkit.org/show_bug.cgi?id=72410
Patch by James Robinson jam...@chromium.org on 2011-11-15
Reviewed by Simon Fraser.
* compositing/plugins/invalidate_rect-expected.txt: Renamed from LayoutTests/plugins/invalidate_rect-expected.txt.
* compositing/plugins/invalidate_rect.html: Renamed from LayoutTests/plugins/invalidate_rect.html.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/compositing/plugins/invalidate_rect-expected.txt
trunk/LayoutTests/compositing/plugins/invalidate_rect.html
Removed Paths
trunk/LayoutTests/plugins/invalidate_rect-expected.txt
trunk/LayoutTests/plugins/invalidate_rect.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100317 => 100318)
--- trunk/LayoutTests/ChangeLog 2011-11-15 22:00:35 UTC (rev 100317)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 22:12:51 UTC (rev 100318)
@@ -1,3 +1,13 @@
+2011-11-15 James Robinson jam...@chromium.org
+
+Move plugins/invalidate_rect.html to the compositing directory since it is a compositor test
+https://bugs.webkit.org/show_bug.cgi?id=72410
+
+Reviewed by Simon Fraser.
+
+* compositing/plugins/invalidate_rect-expected.txt: Renamed from LayoutTests/plugins/invalidate_rect-expected.txt.
+* compositing/plugins/invalidate_rect.html: Renamed from LayoutTests/plugins/invalidate_rect.html.
+
2011-11-15 Tony Chang t...@chromium.org
[chromium] enable regions and exclusions tests, the compile flag was removed a long time ago
Copied: trunk/LayoutTests/compositing/plugins/invalidate_rect-expected.txt (from rev 100317, trunk/LayoutTests/plugins/invalidate_rect-expected.txt) (0 => 100318)
--- trunk/LayoutTests/compositing/plugins/invalidate_rect-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/plugins/invalidate_rect-expected.txt 2011-11-15 22:12:51 UTC (rev 100318)
@@ -0,0 +1,3 @@
+This tests that NPN_InvalidateRect works correctly.
+SUCCESS
+
Copied: trunk/LayoutTests/compositing/plugins/invalidate_rect.html (from rev 100317, trunk/LayoutTests/plugins/invalidate_rect.html) (0 => 100318)
--- trunk/LayoutTests/compositing/plugins/invalidate_rect.html (rev 0)
+++ trunk/LayoutTests/compositing/plugins/invalidate_rect.html 2011-11-15 22:12:51 UTC (rev 100318)
@@ -0,0 +1,50 @@
+!DOCTYPE html
+
+html
+head
+
+ style type=text/css
+#transform {
+ -webkit-transform: rotateZ(0deg) rotateX(0deg) rotateY(0deg);
+}
+ /style
+
+ script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var paintCount = 0;
+
+function onLoad()
+{
+ layoutTestController.display();
+ paintCount = 0;
+ document.getElementById('testPlugin').invalidateRect(0, 0, 200, 200);
+ layoutTestController.displayInvalidatedRegion();
+ if (paintCount 0)
+ document.getElementById('result').innerHTML = SUCCESS;
+}
+
+function didPaint()
+{
+ paintCount++;
+}
+ /script
+/head
+body _onload_=onLoad();
+ This tests that NPN_InvalidateRect works correctly.
+
+ div id=resultFAILURE/div
+
+ !-- force this page to be composited --
+ div id=transform
+ /div
+
+ !-- Move the plugin to the middle of the page. This ensures that invalidate() will invalidate the correct region. --
+ div style=position: absolute; left: 300px; top: 300px; height: 400px; width: 400px; padding: 1em;
+
+embed id=testPlugin type=application/x-webkit-test-netscape width=200 height=200 _onpaintevent_=didPaint() windowedPlugin=false/embed
+
+ /div
+/body
+/html
Deleted: trunk/LayoutTests/plugins/invalidate_rect-expected.txt (100317 => 100318)
--- trunk/LayoutTests/plugins/invalidate_rect-expected.txt 2011-11-15 22:00:35 UTC (rev 100317)
+++ trunk/LayoutTests/plugins/invalidate_rect-expected.txt 2011-11-15 22:12:51 UTC (rev 100318)
@@ -1,3 +0,0 @@
-This tests that NPN_InvalidateRect works correctly.
-SUCCESS
-
Deleted: trunk/LayoutTests/plugins/invalidate_rect.html (100317 => 100318)
--- trunk/LayoutTests/plugins/invalidate_rect.html 2011-11-15 22:00:35 UTC (rev 100317)
+++ trunk/LayoutTests/plugins/invalidate_rect.html 2011-11-15 22:12:51 UTC (rev 100318)
@@ -1,50 +0,0 @@
-!DOCTYPE html
-
-html
-head
-
- style type=text/css
-#transform {
- -webkit-transform: rotateZ(0deg) rotateX(0deg) rotateY(0deg);
-}
- /style
-
- script
-if (window.layoutTestController)
-layoutTestController.dumpAsText();
-
-var paintCount = 0;
-
-function onLoad()
-{
- layoutTestController.display();
- paintCount = 0;
- document.getElementById('testPlugin').invalidateRect(0, 0, 200, 200);
- layoutTestController.displayInvalidatedRegion();
- if (paintCount 0)
-
[webkit-changes] [100319] trunk/LayoutTests
Title: [100319] trunk/LayoutTests Revision 100319 Author pkast...@chromium.org Date 2011-11-15 14:17:16 -0800 (Tue, 15 Nov 2011) Log Message Fix expectations after r100276. https://bugs.webkit.org/show_bug.cgi?id=72270 Some lines were commented out to avoid expectation conflicts but this erroneously removed an expectation that some tests would fail on the Leopard (CG) bots. Unreviewed, gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100318 => 100319) --- trunk/LayoutTests/ChangeLog 2011-11-15 22:12:51 UTC (rev 100318) +++ trunk/LayoutTests/ChangeLog 2011-11-15 22:17:16 UTC (rev 100319) @@ -1,3 +1,16 @@ +2011-11-15 Peter Kasting pkast...@google.com + +Fix expectations after r100276. +https://bugs.webkit.org/show_bug.cgi?id=72270 + +Some lines were commented out to avoid expectation conflicts but this +erroneously removed an expectation that some tests would fail on the +Leopard (CG) bots. + +Unreviewed, gardening. + +* platform/chromium/test_expectations.txt: + 2011-11-15 James Robinson jam...@chromium.org Move plugins/invalidate_rect.html to the compositing directory since it is a compositor test Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100318 => 100319) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 22:12:51 UTC (rev 100318) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 22:17:16 UTC (rev 100319) @@ -1459,13 +1459,15 @@ BUGWK39966 LINUX : fast/repaint/table-cell-collapsed-border.html = IMAGE // Thicker shadow than expected -//BUGCR23471 LEOPARD : fast/text/stroking.html = IMAGE +BUGCR23471 LEOPARD : fast/text/stroking.html = IMAGE // - // END MAC PORT TESTS // - -// Rebaseline to take advantage of skia ColorFilter optimization +// Rebaseline to take advantage of skia ColorFilter optimization. +// Note that two of tests below are broken on Leopard for other reasons (search +// elsewhere within this file) and thus should not be blindly rebaselined there. BUGCR104128 CPU : fast/box-shadow/box-shadow-radius.html = IMAGE BUGCR104128 CPU : fast/box-shadow/inset-box-shadow-radius.html = IMAGE BUGCR104128 CPU : fast/box-shadow/shadow-buffer-partial.html = IMAGE @@ -1479,9 +1481,9 @@ BUGCR104128 CPU : fast/repaint/text-shadow-horizontal.html = IMAGE BUGCR104128 CPU : fast/repaint/text-shadow.html = IMAGE BUGCR104128 CPU : fast/text/shadow-no-blur.html = IMAGE -BUGCR104128 CPU : fast/text/shadow-translucent-fill.html = IMAGE +BUGCR104128 WIN LINUX SNOWLEOPARD CPU : fast/text/shadow-translucent-fill.html = IMAGE BUGCR104128 CPU : fast/text/stroking-decorations.html = IMAGE -BUGCR104128 CPU : fast/text/stroking.html = IMAGE +BUGCR104128 WIN LINUX SNOWLEOPARD CPU : fast/text/stroking.html = IMAGE BUGCR104128 CPU : fast/writing-mode/english-lr-text.html = IMAGE BUGCR104128 CPU : svg/css/group-with-shadow.svg = IMAGE BUGCR104128 CPU : svg/css/shadow-with-large-radius.svg = IMAGE @@ -3065,7 +3067,7 @@ BUGWK84665 : fast/dom/dataset-gc.html = TEXT BUGWK60115 LINUX WIN : fast/multicol/shadow-breaking.html = IMAGE -//BUGWK60115 LEOPARD : fast/text/shadow-translucent-fill.html = IMAGE +BUGWK60115 LEOPARD : fast/text/shadow-translucent-fill.html = IMAGE BUGWK60115 MAC CPU-CG : fast/transforms/shadows.html = PASS IMAGE BUGWK60115 WIN : svg/css/composite-shadow-text.svg = IMAGE BUGWK60115 WIN : svg/css/shadow-changes.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100320] trunk/Source/JavaScriptCore
Title: [100320] trunk/Source/_javascript_Core
Revision 100320
Author gga...@apple.com
Date 2011-11-15 14:19:59 -0800 (Tue, 15 Nov 2011)
Log Message
Use MarkedArgumentBuffer to avoid making assumptions about argument order
https://bugs.webkit.org/show_bug.cgi?id=72418
Reviewed by Sam Weinig.
A step toward reversing the argument order.
* runtime/JSONObject.cpp:
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::callReviver): Don't assume that ArgList wants to point
at arguments in forward order. Instead, use MarkedArgumentBuffer, which
will make the decision for us.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSONObject.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100319 => 100320)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-15 22:17:16 UTC (rev 100319)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-15 22:19:59 UTC (rev 100320)
@@ -1,3 +1,19 @@
+2011-11-15 Geoffrey Garen gga...@apple.com
+
+Use MarkedArgumentBuffer to avoid making assumptions about argument order
+https://bugs.webkit.org/show_bug.cgi?id=72418
+
+Reviewed by Sam Weinig.
+
+A step toward reversing the argument order.
+
+* runtime/JSONObject.cpp:
+(JSC::Stringifier::toJSON):
+(JSC::Stringifier::appendStringifiedValue):
+(JSC::Walker::callReviver): Don't assume that ArgList wants to point
+at arguments in forward order. Instead, use MarkedArgumentBuffer, which
+will make the decision for us.
+
2011-11-15 Filip Pizlo fpi...@apple.com
DFG should distinguish between constants in the constant pool and weak
Modified: trunk/Source/_javascript_Core/runtime/JSONObject.cpp (100319 => 100320)
--- trunk/Source/_javascript_Core/runtime/JSONObject.cpp 2011-11-15 22:17:16 UTC (rev 100319)
+++ trunk/Source/_javascript_Core/runtime/JSONObject.cpp 2011-11-15 22:19:59 UTC (rev 100320)
@@ -340,8 +340,8 @@
if (callType == CallTypeNone)
return value;
-JSValue list[] = { propertyName.value(m_exec) };
-ArgList args(list, WTF_ARRAY_LENGTH(list));
+MarkedArgumentBuffer args;
+args.append(propertyName.value(m_exec));
return call(m_exec, object, callType, callData, value, args);
}
@@ -354,8 +354,9 @@
// Call the replacer function.
if (m_replacerCallType != CallTypeNone) {
-JSValue list[] = { propertyName.value(m_exec), value };
-ArgList args(list, WTF_ARRAY_LENGTH(list));
+MarkedArgumentBuffer args;
+args.append(propertyName.value(m_exec));
+args.append(value);
value = call(m_exec, m_replacer.get(), m_replacerCallType, m_replacerCallData, holder, args);
if (m_exec-hadException())
return StringifyFailed;
@@ -621,9 +622,10 @@
private:
JSValue callReviver(JSObject* thisObj, JSValue property, JSValue unfiltered)
{
-JSValue args[] = { property, unfiltered };
-ArgList argList(args, 2);
-return call(m_exec, m_function.get(), m_callType, m_callData, thisObj, argList);
+MarkedArgumentBuffer args;
+args.append(property);
+args.append(unfiltered);
+return call(m_exec, m_function.get(), m_callType, m_callData, thisObj, args);
}
friend class Holder;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100321] branches/safari-534.53-branch/Source/WebCore
Title: [100321] branches/safari-534.53-branch/Source/WebCore
Revision 100321
Author lforsch...@apple.com
Date 2011-11-15 14:21:46 -0800 (Tue, 15 Nov 2011)
Log Message
Merged r90925. needed for 93040.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp
branches/safari-534.53-branch/Source/WebCore/page/Frame.h
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.cpp
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.h
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.h
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerCompositor.h
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100320 => 100321)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 22:19:59 UTC (rev 100320)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 22:21:46 UTC (rev 100321)
@@ -1,5 +1,34 @@
2011-11-15 Lucas Forschler lforsch...@apple.com
+Merge 90925
+
+2011-07-12 Simon Fraser simon.fra...@apple.com
+
+Rename compositing-related updateContentsScale() methods
+https://bugs.webkit.org/show_bug.cgi?id=64430
+
+Reviewed by Joseph Pecoraro.
+
+Rename updateContentsScale() to something less presumptuous; layers may choose
+to do something other than update their contents scale when the page scale factor
+changes. pageScaleFactorChanged() is a better name.
+
+* page/Frame.cpp:
+(WebCore::Frame::pageScaleFactorChanged):
+(WebCore::Frame::scalePage):
+* page/Frame.h:
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::pageScaleFactorChanged):
+* rendering/RenderLayer.h:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::pageScaleFactorChanged):
+* rendering/RenderLayerBacking.h:
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::pageScaleFactorChanged):
+* rendering/RenderLayerCompositor.h:
+
+2011-11-15 Lucas Forschler lforsch...@apple.com
+
Merge 100022
2011-11-11 Beth Dakin bda...@apple.com
Modified: branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp (100320 => 100321)
--- branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp 2011-11-15 22:19:59 UTC (rev 100320)
+++ branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp 2011-11-15 22:21:46 UTC (rev 100321)
@@ -1043,14 +1043,14 @@
}
#if USE(ACCELERATED_COMPOSITING)
-void Frame::updateContentsScale(float scale)
+void Frame::pageScaleFactorChanged(float scale)
{
for (Frame* child = tree()-firstChild(); child; child = child-tree()-nextSibling())
-child-updateContentsScale(scale);
+child-pageScaleFactorChanged(scale);
RenderView* root = contentRenderer();
if (root root-compositor())
-root-compositor()-updateContentsScale(scale);
+root-compositor()-pageScaleFactorChanged(scale);
}
#endif
@@ -1069,7 +1069,7 @@
document-recalcStyle(Node::Force);
#if USE(ACCELERATED_COMPOSITING)
-updateContentsScale(scale);
+pageScaleFactorChanged(scale);
#endif
}
Modified: branches/safari-534.53-branch/Source/WebCore/page/Frame.h (100320 => 100321)
--- branches/safari-534.53-branch/Source/WebCore/page/Frame.h 2011-11-15 22:19:59 UTC (rev 100320)
+++ branches/safari-534.53-branch/Source/WebCore/page/Frame.h 2011-11-15 22:21:46 UTC (rev 100321)
@@ -217,7 +217,7 @@
void lifeSupportTimerFired(TimerFrame*);
#if USE(ACCELERATED_COMPOSITING)
-void updateContentsScale(float);
+void pageScaleFactorChanged(float);
#endif
HashSetFrameDestructionObserver* m_destructionObservers;
Modified: branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.cpp (100320 => 100321)
--- branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.cpp 2011-11-15 22:19:59 UTC (rev 100320)
+++ branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.cpp 2011-11-15 22:21:46 UTC (rev 100321)
@@ -4180,11 +4180,11 @@
m_reflection-setStyle(newStyle.release());
}
-void RenderLayer::updateContentsScale(float scale)
+void RenderLayer::pageScaleFactorChanged(float scale)
{
#if USE(ACCELERATED_COMPOSITING)
if (m_backing)
-m_backing-updateContentsScale(scale);
+m_backing-pageScaleFactorChanged(scale);
#endif
}
Modified: branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.h (100320 => 100321)
--- branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.h 2011-11-15 22:19:59 UTC (rev 100320)
+++
[webkit-changes] [100322] branches/subpixellayout/Source/WebCore
Title: [100322] branches/subpixellayout/Source/WebCore
Revision 100322
Author le...@chromium.org
Date 2011-11-15 14:22:40 -0800 (Tue, 15 Nov 2011)
Log Message
Properly bounding CSS lengths to AppUnit's bounds. Rounding instead of truncating offset values.
Modified Paths
branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.cpp
branches/subpixellayout/Source/WebCore/platform/AppUnit.h
branches/subpixellayout/Source/WebCore/rendering/RenderBox.h
branches/subpixellayout/Source/WebCore/rendering/RenderInline.h
Diff
Modified: branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.cpp (100321 => 100322)
--- branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.cpp 2011-11-15 22:21:46 UTC (rev 100321)
+++ branches/subpixellayout/Source/WebCore/css/CSSPrimitiveValue.cpp 2011-11-15 22:22:40 UTC (rev 100322)
@@ -345,7 +345,7 @@
template Length CSSPrimitiveValue::computeLength(RenderStyle* style, RenderStyle* rootStyle, double multiplier, bool computingFontSize)
{
// FIXME: Length.h no longer expects 28 bit integers, so these bounds should be INT_MAX and INT_MIN
-return Length(roundForImpreciseConversionint, intMaxForLength, intMinForLength(computeLengthDouble(style, rootStyle, multiplier, computingFontSize)), Fixed);
+return Length(roundForImpreciseConversionint, intMaxForAppUnit, intMinForAppUnit(computeLengthDouble(style, rootStyle, multiplier, computingFontSize)), Fixed);
}
template short CSSPrimitiveValue::computeLength(RenderStyle* style, RenderStyle* rootStyle, double multiplier, bool computingFontSize)
Modified: branches/subpixellayout/Source/WebCore/platform/AppUnit.h (100321 => 100322)
--- branches/subpixellayout/Source/WebCore/platform/AppUnit.h 2011-11-15 22:21:46 UTC (rev 100321)
+++ branches/subpixellayout/Source/WebCore/platform/AppUnit.h 2011-11-15 22:22:40 UTC (rev 100322)
@@ -32,6 +32,8 @@
namespace WebCore {
static const int kFixedPointDenominator = 60;
+const int intMaxForAppUnit = INT_MAX / kFixedPointDenominator;
+const int intMinForAppUnit = -intMaxForAppUnit;
class AppUnit {
public:
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBox.h (100321 => 100322)
--- branches/subpixellayout/Source/WebCore/rendering/RenderBox.h 2011-11-15 22:21:46 UTC (rev 100321)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBox.h 2011-11-15 22:22:40 UTC (rev 100322)
@@ -51,6 +51,9 @@
LayoutUnit width() const { return m_frameRect.width(); }
LayoutUnit height() const { return m_frameRect.height(); }
+int pixelSnappedWidth() const { return pixelSnappedIntRect(m_frameRect).width(); }
+int pixelSnappedHeight() const { return pixelSnappedIntRect(m_frameRect).height(); }
+
// These represent your location relative to your container as a physical offset.
// In layout related methods you almost always want the logical location (e.g. x() and y()).
LayoutUnit top() const { return topLeftLocation().y(); }
@@ -180,8 +183,8 @@
// IE extensions. Used to calculate offsetWidth/Height. Overridden by inlines (RenderFlow)
// to return the remaining width on a given line (and the height of a single line).
-virtual int offsetWidth() const { return width(); }
-virtual int offsetHeight() const { return height(); }
+virtual int offsetWidth() const { return pixelSnappedWidth(); }
+virtual int offsetHeight() const { return pixelSnappedHeight(); }
// More IE extensions. clientWidth and clientHeight represent the interior of an object
// excluding border and scrollbar. clientLeft/Top are just the borderLeftWidth and borderTopWidth.
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderInline.h (100321 => 100322)
--- branches/subpixellayout/Source/WebCore/rendering/RenderInline.h 2011-11-15 22:21:46 UTC (rev 100321)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderInline.h 2011-11-15 22:22:40 UTC (rev 100322)
@@ -123,8 +123,8 @@
virtual int offsetLeft() const;
virtual int offsetTop() const;
-virtual int offsetWidth() const { return linesBoundingBox().width(); }
-virtual int offsetHeight() const { return linesBoundingBox().height(); }
+virtual int offsetWidth() const { return linesBoundingBox().width().ceil(); }
+virtual int offsetHeight() const { return linesBoundingBox().height().ceil(); }
virtual LayoutRect clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const;
virtual LayoutRect rectWithOutlineForRepaint(RenderBoxModelObject* repaintContainer, LayoutUnit outlineWidth) const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100323] trunk/Source/WebKit2
Title: [100323] trunk/Source/WebKit2 Revision 100323 Author cfleiz...@apple.com Date 2011-11-15 14:23:59 -0800 (Tue, 15 Nov 2011) Log Message AX: WKAccessibilityWebObjectPage should not call super in accessibilityAttributeValue: https://bugs.webkit.org/show_bug.cgi?id=72344 Reviewed by Beth Dakin. * WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: (-[WKAccessibilityWebPageObject accessibilityAttributeValue:]): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (100322 => 100323) --- trunk/Source/WebKit2/ChangeLog 2011-11-15 22:22:40 UTC (rev 100322) +++ trunk/Source/WebKit2/ChangeLog 2011-11-15 22:23:59 UTC (rev 100323) @@ -1,3 +1,13 @@ +2011-11-15 Chris Fleizach2 cfleiz...@apple.com + +AX: WKAccessibilityWebObjectPage should not call super in accessibilityAttributeValue: +https://bugs.webkit.org/show_bug.cgi?id=72344 + +Reviewed by Beth Dakin. + +* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: +(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]): + 2011-11-15 Anders Carlsson ander...@apple.com HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm (100322 => 100323) --- trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm 2011-11-15 22:22:40 UTC (rev 100322) +++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm 2011-11-15 22:23:59 UTC (rev 100323) @@ -152,7 +152,7 @@ if ([attribute isEqualToString:NSAccessibilityChildrenAttribute]) return [self accessibilityChildren]; -return [super accessibilityAttributeValue:attribute]; +return nil; } - (BOOL)accessibilityShouldUseUniqueId ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100324] trunk
Title: [100324] trunk
Revision 100324
Author o...@chromium.org
Date 2011-11-15 14:25:24 -0800 (Tue, 15 Nov 2011)
Log Message
Overflow and relayout are broken in the new flexboxes
https://bugs.webkit.org/show_bug.cgi?id=71161
Reviewed by David Hyatt.
Source/WebCore:
Tests: css3/flexbox/auto-height-dynamic.html
css3/flexbox/flex-item-child-overflow-expected.html
css3/flexbox/flex-item-child-overflow.html
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
-Always set the logical height to 0 to start with to ensure we don't
use the height from the previous layout when we are computing the
intrinsic size of the flexbox.
-Call computeOverflow after computeLogicalHeight so that flex-item's children's
overflow is properly rendered.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
-Now that we setLogicalHeight in layoutBlock, we no longer need to do it here.
-Refactor flipping code. The behavior is the same, but the variable names are just
more correct.
LayoutTests:
* css3/flexbox/auto-height-dynamic-expected.txt: Added.
* css3/flexbox/auto-height-dynamic.html: Added.
* css3/flexbox/flex-item-child-overflow-expected.html: Added.
* css3/flexbox/flex-item-child-overflow.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
Added Paths
trunk/LayoutTests/css3/flexbox/auto-height-dynamic-expected.txt
trunk/LayoutTests/css3/flexbox/auto-height-dynamic.html
trunk/LayoutTests/css3/flexbox/flex-item-child-overflow-expected.html
trunk/LayoutTests/css3/flexbox/flex-item-child-overflow.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100323 => 100324)
--- trunk/LayoutTests/ChangeLog 2011-11-15 22:23:59 UTC (rev 100323)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 22:25:24 UTC (rev 100324)
@@ -1,3 +1,15 @@
+2011-10-28 Ojan Vafai o...@chromium.org
+
+Overflow and relayout are broken in the new flexboxes
+https://bugs.webkit.org/show_bug.cgi?id=71161
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/auto-height-dynamic-expected.txt: Added.
+* css3/flexbox/auto-height-dynamic.html: Added.
+* css3/flexbox/flex-item-child-overflow-expected.html: Added.
+* css3/flexbox/flex-item-child-overflow.html: Added.
+
2011-11-15 Peter Kasting pkast...@google.com
Fix expectations after r100276.
Added: trunk/LayoutTests/css3/flexbox/auto-height-dynamic-expected.txt (0 => 100324)
--- trunk/LayoutTests/css3/flexbox/auto-height-dynamic-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/flexbox/auto-height-dynamic-expected.txt 2011-11-15 22:25:24 UTC (rev 100324)
@@ -0,0 +1,2 @@
+PASS
+PASS
Property changes on: trunk/LayoutTests/css3/flexbox/auto-height-dynamic-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/css3/flexbox/auto-height-dynamic.html (0 => 100324)
--- trunk/LayoutTests/css3/flexbox/auto-height-dynamic.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/auto-height-dynamic.html 2011-11-15 22:25:24 UTC (rev 100324)
@@ -0,0 +1,38 @@
+!DOCTYPE html
+html
+style
+.flexbox {
+width: 600px;
+display: -webkit-flexbox;
+background-color: #aaa;
+position: relative;
+-webkit-flex-flow: column;
+}
+.flexbox :nth-child(1) {
+background-color: blue;
+}
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+script src=""
+body _onload_=checkFlexBoxen()
+
+div class=flexbox data-expected-height=0
+div class=flexitem data-expected-height=0 style=height: 100px/div
+/div
+
+div class=flexbox data-expected-height=0
+div class=flexitem2 data-expected-height=0 style=height: 100px/div
+/div
+
+script
+document.querySelector('.flexitem').offsetHeight;
+document.querySelector('.flexitem2').offsetHeight;
+document.querySelector('.flexitem').style.height = -webkit-flex(1);
+document.querySelector('.flexitem2').style.height = -webkit-flex(1 auto);
+/script
+
+/body
+/html
\ No newline at end of file
Property changes on: trunk/LayoutTests/css3/flexbox/auto-height-dynamic.html
___
Added: svn:eol-style
Added: trunk/LayoutTests/css3/flexbox/flex-item-child-overflow-expected.html (0 => 100324)
--- trunk/LayoutTests/css3/flexbox/flex-item-child-overflow-expected.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/flex-item-child-overflow-expected.html 2011-11-15 22:25:24 UTC (rev 100324)
@@ -0,0 +1,7 @@
+!DOCTYPE html
+html
+body style=margin: 0
+div style=background-color: blue; width: 20px; height: 20px; position: absolute; top: 0;/div
+prePASS/pre
+/body
+/html
\ No newline at end of file
Property changes on: trunk/LayoutTests/css3/flexbox/flex-item-child-overflow-expected.html
___
[webkit-changes] [100325] trunk/LayoutTests
Title: [100325] trunk/LayoutTests Revision 100325 Author pkast...@chromium.org Date 2011-11-15 14:29:20 -0800 (Tue, 15 Nov 2011) Log Message Fix expectations after r100283. https://bugs.webkit.org/show_bug.cgi?id=72137 We don't have a LION modifier, and I'm not sure why one test was only skipped for SNOWLEOPARD RELEASE as it fails on Debug also. Unreviewed, gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100324 => 100325) --- trunk/LayoutTests/ChangeLog 2011-11-15 22:25:24 UTC (rev 100324) +++ trunk/LayoutTests/ChangeLog 2011-11-15 22:29:20 UTC (rev 100325) @@ -1,3 +1,15 @@ +2011-11-15 Peter Kasting pkast...@google.com + +Fix expectations after r100283. +https://bugs.webkit.org/show_bug.cgi?id=72137 + +I'm not sure why one test was only skipped for SNOWLEOPARD RELEASE as it +fails on Debug also. + +Unreviewed, gardening. + +* platform/chromium/test_expectations.txt: + 2011-10-28 Ojan Vafai o...@chromium.org Overflow and relayout are broken in the new flexboxes Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100324 => 100325) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 22:25:24 UTC (rev 100324) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 22:29:20 UTC (rev 100325) @@ -3905,8 +3905,7 @@ BUG_CARYCLARK MAC CPU : fast/writing-mode/broken-ideographic-font.html = IMAGE BUG_CARYCLARK MAC CPU : fast/writing-mode/fallback-orientation.html = IMAGE BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-lr-text.html = IMAGE -BUG_CARYCLARK LION CPU : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE -BUG_CARYCLARK SNOWLEOPARD CPU RELEASE : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE +BUG_CARYCLARK SNOWLEOPARD LION CPU : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-rl-text.html = IMAGE BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-ruby-vertical-lr.html = IMAGE BUG_CARYCLARK MAC CPU : fast/writing-mode/japanese-ruby-vertical-rl.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100326] trunk/Tools
Title: [100326] trunk/Tools
Revision 100326
Author t...@chromium.org
Date 2011-11-15 14:30:19 -0800 (Tue, 15 Nov 2011)
Log Message
[NRWT] Reftests should run even when pixel tests are disabled.
https://bugs.webkit.org/show_bug.cgi?id=60605
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
Also add an assert to make sure we get image hashes back when running ref tests.
* Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
* Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
of starting a pixel driver if needed. It handles the logic of sending the test
to the correct driver. Also renamed Driver.poll() to Driver.has_crashed().
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/dryrun.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
Diff
Modified: trunk/Tools/ChangeLog (100325 => 100326)
--- trunk/Tools/ChangeLog 2011-11-15 22:29:20 UTC (rev 100325)
+++ trunk/Tools/ChangeLog 2011-11-15 22:30:19 UTC (rev 100326)
@@ -1,3 +1,24 @@
+2011-11-14 Tony Chang t...@chromium.org
+
+[NRWT] Reftests should run even when pixel tests are disabled.
+https://bugs.webkit.org/show_bug.cgi?id=60605
+
+Reviewed by Dirk Pranke.
+
+* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
+Also add an assert to make sure we get image hashes back when running ref tests.
+* Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
+* Scripts/webkitpy/layout_tests/port/base_unittest.py:
+* Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
+* Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
+of starting a pixel driver if needed. It handles the logic of sending the test
+to the correct driver. Also renamed Driver.poll() to Driver.has_crashed().
+* Scripts/webkitpy/layout_tests/port/dryrun.py:
+* Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
+
2011-11-15 David Kilzer ddkil...@apple.com
Don't use File::Slurp for run-leaks unit tests
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py (100325 => 100326)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2011-11-15 22:29:20 UTC (rev 100325)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py 2011-11-15 22:30:19 UTC (rev 100326)
@@ -113,21 +113,17 @@
image_hash = None
if self._should_fetch_expected_checksum():
image_hash = self._port.expected_checksum(self._test_name)
-return DriverInput(self._test_name, self._timeout, image_hash)
+return DriverInput(self._test_name, self._timeout, image_hash, self._is_reftest)
def run(self):
-if self._options.new_baseline or self._options.reset_results:
-if self._is_reftest:
-# Returns a dummy TestResult. We don't have to rebase for reftests.
-return TestResult(self._test_name)
-else:
-return self._run_rebaseline()
if self._is_reftest:
-if self._port.get_option('pixel_tests'):
-return self._run_reftest()
-result = TestResult(self._test_name)
-result.type = test_expectations.SKIP
-
[webkit-changes] [100328] trunk/Source/WebCore
Title: [100328] trunk/Source/WebCore Revision 100328 Author sch...@chromium.org Date 2011-11-15 14:38:53 -0800 (Tue, 15 Nov 2011) Log Message Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock https://bugs.webkit.org/show_bug.cgi?id=72315 Reviewed by Dimitri Glazkov. * WebCore.gypi: * page/Navigator.cpp: (WebCore::Navigator::webkitPointer): * page/Navigator.h: * page/Navigator.idl: * page/PointerLock.cpp: Renamed from Source/WebCore/page/MouseLockable.cpp. (WebCore::PointerLock::PointerLock): (WebCore::PointerLock::~PointerLock): (WebCore::PointerLock::webkitLock): (WebCore::PointerLock::webkitUnlock): (WebCore::PointerLock::webkitIsLocked): * page/PointerLock.h: Renamed from Source/WebCore/page/MouseLockable.h. (WebCore::PointerLock::create): * page/PointerLock.idl: Renamed from Source/WebCore/page/MouseLockable.idl. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/page/Navigator.cpp trunk/Source/WebCore/page/Navigator.h trunk/Source/WebCore/page/Navigator.idl Added Paths trunk/Source/WebCore/page/PointerLock.cpp trunk/Source/WebCore/page/PointerLock.h trunk/Source/WebCore/page/PointerLock.idl Removed Paths trunk/Source/WebCore/page/MouseLockable.cpp trunk/Source/WebCore/page/MouseLockable.h trunk/Source/WebCore/page/MouseLockable.idl Diff Modified: trunk/Source/WebCore/ChangeLog (100327 => 100328) --- trunk/Source/WebCore/ChangeLog 2011-11-15 22:36:12 UTC (rev 100327) +++ trunk/Source/WebCore/ChangeLog 2011-11-15 22:38:53 UTC (rev 100328) @@ -1,3 +1,25 @@ +2011-11-15 Vincent Scheib sch...@chromium.org + +Mouse Lock: Renaming to 'Pointer Lock': MouseLockable to PointerLock +https://bugs.webkit.org/show_bug.cgi?id=72315 + +Reviewed by Dimitri Glazkov. + +* WebCore.gypi: +* page/Navigator.cpp: +(WebCore::Navigator::webkitPointer): +* page/Navigator.h: +* page/Navigator.idl: +* page/PointerLock.cpp: Renamed from Source/WebCore/page/MouseLockable.cpp. +(WebCore::PointerLock::PointerLock): +(WebCore::PointerLock::~PointerLock): +(WebCore::PointerLock::webkitLock): +(WebCore::PointerLock::webkitUnlock): +(WebCore::PointerLock::webkitIsLocked): +* page/PointerLock.h: Renamed from Source/WebCore/page/MouseLockable.h. +(WebCore::PointerLock::create): +* page/PointerLock.idl: Renamed from Source/WebCore/page/MouseLockable.idl. + 2011-10-28 Ojan Vafai o...@chromium.org Overflow and relayout are broken in the new flexboxes Modified: trunk/Source/WebCore/WebCore.gypi (100327 => 100328) --- trunk/Source/WebCore/WebCore.gypi 2011-11-15 22:36:12 UTC (rev 100327) +++ trunk/Source/WebCore/WebCore.gypi 2011-11-15 22:38:53 UTC (rev 100328) @@ -1403,7 +1403,6 @@ 'page/History.idl', 'page/Location.idl', 'page/MemoryInfo.idl', -'page/MouseLockable.idl', 'page/Navigator.idl', 'page/NavigatorUserMediaError.idl', 'page/NavigatorUserMediaErrorCallback.idl', @@ -1411,6 +1410,7 @@ 'page/Performance.idl', 'page/PerformanceNavigation.idl', 'page/PerformanceTiming.idl', +'page/PointerLock.idl', 'page/PositionCallback.idl', 'page/PositionError.idl', 'page/PositionErrorCallback.idl', @@ -2956,8 +2956,6 @@ 'page/MemoryInfo.cpp', 'page/MouseEventWithHitTestResults.cpp', 'page/MouseEventWithHitTestResults.h', -'page/MouseLockable.cpp', -'page/MouseLockable.h', 'page/Navigator.cpp', 'page/Navigator.h', 'page/NavigatorBase.cpp', @@ -2979,6 +2977,8 @@ 'page/PerformanceNavigation.h', 'page/PerformanceTiming.cpp', 'page/PerformanceTiming.h', +'page/PointerLock.cpp', +'page/PointerLock.h', 'page/PrintContext.cpp', 'page/Screen.cpp', 'page/Screen.h', Deleted: trunk/Source/WebCore/page/MouseLockable.cpp (100327 => 100328) --- trunk/Source/WebCore/page/MouseLockable.cpp 2011-11-15 22:36:12 UTC (rev 100327) +++ trunk/Source/WebCore/page/MouseLockable.cpp 2011-11-15 22:38:53 UTC (rev 100328) @@ -1,58 +0,0 @@ -/* - * Copyright (C) 2011 Google Inc. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * - * THIS SOFTWARE IS PROVIDED BY APPLE
[webkit-changes] [100331] trunk/LayoutTests
Title: [100331] trunk/LayoutTests Revision 100331 Author pkast...@chromium.org Date 2011-11-15 14:48:54 -0800 (Tue, 15 Nov 2011) Log Message Fix expectations after r100289. https://bugs.webkit.org/show_bug.cgi?id=72391 fast/dom/Orientation/create-event-orientationchange.html was updated but the expected text was not. Unreviewed, gardening. * fast/dom/Orientation/create-event-orientationchange-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100330 => 100331) --- trunk/LayoutTests/ChangeLog 2011-11-15 22:46:20 UTC (rev 100330) +++ trunk/LayoutTests/ChangeLog 2011-11-15 22:48:54 UTC (rev 100331) @@ -1,3 +1,15 @@ +2011-11-15 Peter Kasting pkast...@google.com + +Fix expectations after r100289. +https://bugs.webkit.org/show_bug.cgi?id=72391 + +fast/dom/Orientation/create-event-orientationchange.html was updated but +the expected text was not. + +Unreviewed, gardening. + +* fast/dom/Orientation/create-event-orientationchange-expected.txt: + 2011-11-15 Ojan Vafai o...@chromium.org Pixel result accidentally left out of http://trac.webkit.org/changeset/100324. Modified: trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt (100330 => 100331) --- trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt 2011-11-15 22:46:20 UTC (rev 100330) +++ trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt 2011-11-15 22:48:54 UTC (rev 100331) @@ -1,16 +1,9 @@ -Tests that document.createEvent() works with orientationChange - -On success, you will see a series of PASS messages, followed by TEST COMPLETE. - - - -FAIL... orientationChange event doesn't appear to be enabled or implemented. - - -PASS successfullyParsed is true - -TEST COMPLETE - - - - +Tests that document.createEvent() works with orientationChange + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS successfullyParsed is true + +TEST COMPLETE +FAIL... orientationChange event doesn't appear to be enabled or implemented. \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100332] branches/safari-534.53-branch/Source/WebCore
Title: [100332] branches/safari-534.53-branch/Source/WebCore
Revision 100332
Author lforsch...@apple.com
Date 2011-11-15 14:52:03 -0800 (Tue, 15 Nov 2011)
Log Message
Merged r90954.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.h
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100331 => 100332)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 22:48:54 UTC (rev 100331)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 22:52:03 UTC (rev 100332)
@@ -1,5 +1,35 @@
2011-11-15 Lucas Forschler lforsch...@apple.com
+Merge 90954
+
+2011-07-13 Simon Fraser simon.fra...@apple.com
+
+Factor some GraphicsLayer creation code in RenderLayerBacking
+https://bugs.webkit.org/show_bug.cgi?id=64487
+
+Reviewed by Sam Weinig.
+
+Move the GraphicsLayer::create() calls into once place so that we
+don't have lots of #ifndef NDEBUG in various places, and can share
+more code in future.
+
+No behavior change, so no new tests.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::RenderLayerBacking):
+(WebCore::RenderLayerBacking::~RenderLayerBacking):
+(WebCore::RenderLayerBacking::createGraphicsLayer):
+(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
+(WebCore::RenderLayerBacking::destroyGraphicsLayers):
+(WebCore::RenderLayerBacking::updateLayerTransform):
+(WebCore::RenderLayerBacking::updateClippingLayers):
+(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
+(WebCore::RenderLayerBacking::updateForegroundLayer):
+(WebCore::RenderLayerBacking::updateMaskLayer):
+* rendering/RenderLayerBacking.h:
+
+2011-11-15 Lucas Forschler lforsch...@apple.com
+
Merge 90925
2011-07-12 Simon Fraser simon.fra...@apple.com
Modified: branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp (100331 => 100332)
--- branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-11-15 22:48:54 UTC (rev 100331)
+++ branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-11-15 22:52:03 UTC (rev 100332)
@@ -85,7 +85,7 @@
: m_owningLayer(layer)
, m_artificiallyInflatedBounds(false)
{
-createGraphicsLayer();
+createPrimaryGraphicsLayer();
}
RenderLayerBacking::~RenderLayerBacking()
@@ -94,29 +94,36 @@
updateOverflowControlsLayers(false, false, false);
updateForegroundLayer(false);
updateMaskLayer(false);
-destroyGraphicsLayer();
+destroyGraphicsLayers();
}
-void RenderLayerBacking::createGraphicsLayer()
+PassOwnPtrGraphicsLayer RenderLayerBacking::createGraphicsLayer(const String name)
{
-m_graphicsLayer = GraphicsLayer::create(this);
-
+OwnPtrGraphicsLayer graphicsLayer = GraphicsLayer::create(this);
#ifndef NDEBUG
-m_graphicsLayer-setName(nameForLayer());
+graphicsLayer-setName(name);
#endif
+return graphicsLayer.release();
+}
-#if USE(ACCELERATED_COMPOSITING)
+void RenderLayerBacking::createPrimaryGraphicsLayer()
+{
+String layerName;
+#ifndef NDEBUG
+layerName = nameForLayer();
+#endif
+m_graphicsLayer = createGraphicsLayer(layerName);
+
ASSERT(renderer());
ASSERT(renderer()-document());
ASSERT(renderer()-document()-frame());
m_graphicsLayer-setContentsScale(pageScaleFactor() * backingScaleFactor());
-#endif
updateLayerOpacity(renderer()-style());
updateLayerTransform(renderer()-style());
}
-void RenderLayerBacking::destroyGraphicsLayer()
+void RenderLayerBacking::destroyGraphicsLayers()
{
if (m_graphicsLayer)
m_graphicsLayer-removeFromParent();
@@ -543,10 +550,7 @@
if (needsAncestorClip) {
if (!m_ancestorClippingLayer) {
-m_ancestorClippingLayer = GraphicsLayer::create(this);
-#ifndef NDEBUG
-m_ancestorClippingLayer-setName(Ancestor clipping Layer);
-#endif
+m_ancestorClippingLayer = createGraphicsLayer(Ancestor clipping Layer);
m_ancestorClippingLayer-setMasksToBounds(true);
layersChanged = true;
}
@@ -558,10 +562,7 @@
if (needsDescendantClip) {
if (!m_clippingLayer) {
-m_clippingLayer = GraphicsLayer::create(this);
-#ifndef NDEBUG
-m_clippingLayer-setName(Child clipping Layer);
-#endif
+m_clippingLayer = createGraphicsLayer(Child clipping Layer);
m_clippingLayer-setMasksToBounds(true);
layersChanged = true;
}
@@ -606,10 +607,7 @@
bool layersChanged = false;
if (needsHorizontalScrollbarLayer) {
if
[webkit-changes] [100334] branches/safari-534.53-branch/Source
Title: [100334] branches/safari-534.53-branch/Source Revision 100334 Author lforsch...@apple.com Date 2011-11-15 14:59:04 -0800 (Tue, 15 Nov 2011) Log Message Merged r91137. Modified Paths branches/safari-534.53-branch/Source/WebCore/ChangeLog branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayer.cpp branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayer.h branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayerClient.h branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.cpp branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.h branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.cpp branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerBacking.h branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayerCompositor.h branches/safari-534.53-branch/Source/WebKit/chromium/ChangeLog branches/safari-534.53-branch/Source/WebKit2/ChangeLog branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.cpp branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.h Diff Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100333 => 100334) --- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 22:53:52 UTC (rev 100333) +++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 22:59:04 UTC (rev 100334) @@ -1,5 +1,90 @@ 2011-11-15 Lucas Forschler lforsch...@apple.com +Merge 91137 + +2011-07-15 Simon Fraser simon.fra...@apple.com + +Have GraphicsLayer pull their contentsScale, rather than pushing it onto them +https://bugs.webkit.org/show_bug.cgi?id=64643 + +Reviewed by Darin Adler. + +RenderLayerBacking would set the contentsScale on GraphicsLayers +on creation, and update it when the pageScaleFactor changed. However, +RenderLayerBacking doesn't really know what contentsScale is best +for a layer, so instead, have GraphicsLayers call back through the +GraphicsLayerClient to get the two relevant scale factors, and do +their own computation of contentsScale. + +No testable behavior changes. + +* page/Frame.cpp: +(WebCore::Frame::pageScaleFactorChanged): No need to pass the scale. + +* platform/graphics/GraphicsLayer.cpp: +(WebCore::GraphicsLayer::notePageScaleFactorChangedIncludingDescendants): +Recurse through the GraphicsLayer tree, calling pageScaleFactorChanged() on +each layer. + +* platform/graphics/GraphicsLayer.h: +(WebCore::GraphicsLayer::pageScaleFactorChanged): +Remove contentsScale/setContentsScale + +* platform/graphics/GraphicsLayerClient.h: +Add methods to fetch the backingScaleFactor() and pageScaleFactor(). + +* platform/graphics/ca/GraphicsLayerCA.cpp: +(WebCore::GraphicsLayerCA::GraphicsLayerCA): m_uncommittedChanges +defaults to ContentsScaleChanged so we update contentsScale on +the first flush. + +(WebCore::GraphicsLayerCA::setContentsToBackgroundColor): +This was the wrong time to call updateContentsRect() and setupContentsLayer(); +those should be done at commit time, so moved to updateLayerBackgroundColor(). +(WebCore::GraphicsLayerCA::recursiveCommitChanges): Note whether we +have any changes, and call didCommitChangesForLayer() on the client. +(WebCore::GraphicsLayerCA::updateLayerBackgroundColor): Code moved to here. +(WebCore::clampedContentsScaleForScale): No longer has any hysteresis +on the scale, and now just clamps. +(WebCore::GraphicsLayerCA::updateContentsScale): Fetch the scales +from the client, and multiply them, then clamp. +(WebCore::GraphicsLayerCA::requiresTiledLayer): This now takes +contentsScale into account when deciding to use tiled layer, +so that zooming in will cause layers to start tiling. +(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Don't call +setContentsScale(), but rather updateContentsScale(). +(WebCore::GraphicsLayerCA::pageScaleFactorChanged): Set the bits +for properties that depend on the scale. +(WebCore::GraphicsLayerCA::noteChangesForScaleSensitiveProperties): +Note that contentsScale needs to be updated. At some point we might also +need to dirty other
[webkit-changes] [100335] branches/safari-534.53-branch/Source/WebCore
Title: [100335] branches/safari-534.53-branch/Source/WebCore
Revision 100335
Author lforsch...@apple.com
Date 2011-11-15 15:00:44 -0800 (Tue, 15 Nov 2011)
Log Message
Merged r91138.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100334 => 100335)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 22:59:04 UTC (rev 100334)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 23:00:44 UTC (rev 100335)
@@ -1,5 +1,17 @@
2011-11-15 Lucas Forschler lforsch...@apple.com
+Merge 91138
+
+2011-07-15 Simon Fraser simon.fra...@apple.com
+
+Fix Windows build.
+
+* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
+(WebCore::MediaPlayerPrivate::backingScaleFactor):
+(WebCore::MediaPlayerPrivate::pageScaleFactor):
+
+2011-11-15 Lucas Forschler lforsch...@apple.com
+
Merge 91137
2011-07-15 Simon Fraser simon.fra...@apple.com
Modified: branches/safari-534.53-branch/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h (100334 => 100335)
--- branches/safari-534.53-branch/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h 2011-11-15 22:59:04 UTC (rev 100334)
+++ branches/safari-534.53-branch/Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h 2011-11-15 23:00:44 UTC (rev 100335)
@@ -69,6 +69,8 @@
virtual void paintContents(const GraphicsLayer*, GraphicsContext, GraphicsLayerPaintingPhase, const IntRect inClip);
virtual void notifyAnimationStarted(const GraphicsLayer*, double time) { }
virtual void notifySyncRequired(const GraphicsLayer*) { }
+virtual float backingScaleFactor() const { return 1; }
+virtual float pageScaleFactor() const { return 1; }
virtual bool showDebugBorders() const { return false; }
virtual bool showRepaintCounter() const { return false; }
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100336] trunk/Source/WebKit2
Title: [100336] trunk/Source/WebKit2 Revision 100336 Author wei...@apple.com Date 2011-11-15 15:01:06 -0800 (Tue, 15 Nov 2011) Log Message Add WebKit2 API object to represent a connection https://bugs.webkit.org/show_bug.cgi?id=72421 Reviewed by Anders Carlsson. * GNUmakefile.am: * Target.pri: * WebKit2.xcodeproj/project.pbxproj: * win/WebKit2.vcproj: Add new files. * Shared/API/c/WKBase.h: Add type. * Shared/API/c/WKConnectionRef.cpp: Added. (WKConnectionGetTypeID): (WKConnectionSetConnectionClient): (WKConnectionPostMessage): * Shared/API/c/WKConnectionRef.h: Added. Expose interface. Currently no support for synchronous messages. * Shared/API/c/WKSharedAPICast.h: Define relationship between WebConnection - WKConnectionRef. * Shared/APIObject.h: Add API type. * Shared/WebConnection.cpp: Added. (WebKit::WebConnection::~WebConnection): (WebKit::WebConnection::initializeConnectionClient): * Shared/WebConnection.h: Added. (WebKit::WebConnection::type): Sketch out the connection object. It is currently abstract to allow different implementations for the UI and WebProcess sides while retaining the same interface. * Shared/WebConnectionClient.cpp: Added. (WebKit::WebConnectionClient::didReceiveMessage): (WebKit::WebConnectionClient::didClose): * Shared/WebConnectionClient.h: Added. Add simple client. * UIProcess/API/C/WebKit2.h: Add new file. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am trunk/Source/WebKit2/Shared/API/c/WKBase.h trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h trunk/Source/WebKit2/Shared/APIObject.h trunk/Source/WebKit2/Target.pri trunk/Source/WebKit2/UIProcess/API/C/WebKit2.h trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Source/WebKit2/win/WebKit2.vcproj Added Paths trunk/Source/WebKit2/Shared/API/c/WKConnectionRef.cpp trunk/Source/WebKit2/Shared/API/c/WKConnectionRef.h trunk/Source/WebKit2/Shared/WebConnection.cpp trunk/Source/WebKit2/Shared/WebConnection.h trunk/Source/WebKit2/Shared/WebConnectionClient.cpp trunk/Source/WebKit2/Shared/WebConnectionClient.h Diff Modified: trunk/Source/WebKit2/ChangeLog (100335 => 100336) --- trunk/Source/WebKit2/ChangeLog 2011-11-15 23:00:44 UTC (rev 100335) +++ trunk/Source/WebKit2/ChangeLog 2011-11-15 23:01:06 UTC (rev 100336) @@ -1,3 +1,50 @@ +2011-11-15 Sam Weinig s...@webkit.org + +Add WebKit2 API object to represent a connection +https://bugs.webkit.org/show_bug.cgi?id=72421 + +Reviewed by Anders Carlsson. + +* GNUmakefile.am: +* Target.pri: +* WebKit2.xcodeproj/project.pbxproj: +* win/WebKit2.vcproj: +Add new files. + +* Shared/API/c/WKBase.h: +Add type. + +* Shared/API/c/WKConnectionRef.cpp: Added. +(WKConnectionGetTypeID): +(WKConnectionSetConnectionClient): +(WKConnectionPostMessage): +* Shared/API/c/WKConnectionRef.h: Added. +Expose interface. Currently no support for synchronous messages. + +* Shared/API/c/WKSharedAPICast.h: +Define relationship between WebConnection - WKConnectionRef. + +* Shared/APIObject.h: +Add API type. + +* Shared/WebConnection.cpp: Added. +(WebKit::WebConnection::~WebConnection): +(WebKit::WebConnection::initializeConnectionClient): +* Shared/WebConnection.h: Added. +(WebKit::WebConnection::type): +Sketch out the connection object. It is currently abstract +to allow different implementations for the UI and WebProcess sides +while retaining the same interface. + +* Shared/WebConnectionClient.cpp: Added. +(WebKit::WebConnectionClient::didReceiveMessage): +(WebKit::WebConnectionClient::didClose): +* Shared/WebConnectionClient.h: Added. +Add simple client. + +* UIProcess/API/C/WebKit2.h: +Add new file. + 2011-11-15 Chris Fleizach2 cfleiz...@apple.com AX: WKAccessibilityWebObjectPage should not call super in accessibilityAttributeValue: Modified: trunk/Source/WebKit2/GNUmakefile.am (100335 => 100336) --- trunk/Source/WebKit2/GNUmakefile.am 2011-11-15 23:00:44 UTC (rev 100335) +++ trunk/Source/WebKit2/GNUmakefile.am 2011-11-15 23:01:06 UTC (rev 100336) @@ -4,6 +4,7 @@ $(WebKit2)/Shared/API/c/WKArray.h \ $(WebKit2)/Shared/API/c/WKBase.h \ $(WebKit2)/Shared/API/c/WKCertificateInfo.h \ + $(WebKit2)/Shared/API/c/WKConnectionRef.h \ $(WebKit2)/Shared/API/c/WKContextMenuItem.h \ $(WebKit2)/Shared/API/c/WKContextMenuItemTypes.h \ $(WebKit2)/Shared/API/c/WKData.h \ @@ -240,6 +241,8 @@ Source/WebKit2/Shared/API/c/WKBase.h \ Source/WebKit2/Shared/API/c/WKCertificateInfo.cpp \ Source/WebKit2/Shared/API/c/WKCertificateInfo.h \ + Source/WebKit2/Shared/API/c/WKConnectionRef.cpp \ + Source/WebKit2/Shared/API/c/WKConnectionRef.h \ Source/WebKit2/Shared/API/c/WKContextMenuItem.cpp \ Source/WebKit2/Shared/API/c/WKContextMenuItem.h \
[webkit-changes] [100338] trunk
Title: [100338] trunk
Revision 100338
Author jchaffr...@webkit.org
Date 2011-11-15 15:05:28 -0800 (Tue, 15 Nov 2011)
Log Message
Add the needed plumbing to parse display: -webkit-grid
https://bugs.webkit.org/show_bug.cgi?id=72331
Reviewed by Tony Chang.
Source/WebCore:
Test: fast/css-grid-layout/display-grid-set-get.html
Added parsing support for display: -webkit-grid. From a rendering perspective,
the value is equivalent to display: none until we properly implement it.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyleConstants.h:
Added the new CSS value and plumbed the parsing and style application of
the new value.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EDisplay):
Added an ASSERT here as I bumped into some non-trivial issues due to bug 72296.
-wap-marquee was offsetting the new value and was wrongly casted by the CSSPrimitiveValueMapping
logic outside the EDisplay range which would lead to crashes.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
Fixed the indentation to follow our coding rules.
LayoutTests:
* fast/css-grid-layout/display-grid-set-get-expected.txt: Added.
* fast/css-grid-layout/display-grid-set-get.html: Added.
* fast/css-grid-layout/resources/display-grid-set-get.js: Added.
Test that setting the display to -webkit-grid (from JS or CSS) works
and we get the right value back.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
SKIP the css-grid-layout tests on all platforms for now.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/efl/Skipped
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
Added Paths
trunk/LayoutTests/fast/css-grid-layout/
trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt
trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get.html
trunk/LayoutTests/fast/css-grid-layout/resources/
trunk/LayoutTests/fast/css-grid-layout/resources/display-grid-set-get.js
Diff
Modified: trunk/LayoutTests/ChangeLog (100337 => 100338)
--- trunk/LayoutTests/ChangeLog 2011-11-15 23:01:13 UTC (rev 100337)
+++ trunk/LayoutTests/ChangeLog 2011-11-15 23:05:28 UTC (rev 100338)
@@ -1,3 +1,25 @@
+2011-11-15 Julien Chaffraix jchaffr...@webkit.org
+
+Add the needed plumbing to parse display: -webkit-grid
+https://bugs.webkit.org/show_bug.cgi?id=72331
+
+Reviewed by Tony Chang.
+
+* fast/css-grid-layout/display-grid-set-get-expected.txt: Added.
+* fast/css-grid-layout/display-grid-set-get.html: Added.
+* fast/css-grid-layout/resources/display-grid-set-get.js: Added.
+Test that setting the display to -webkit-grid (from JS or CSS) works
+and we get the right value back.
+
+* platform/chromium/test_expectations.txt:
+* platform/efl/Skipped:
+* platform/gtk/Skipped:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+* platform/wincairo/Skipped:
+SKIP the css-grid-layout tests on all platforms for now.
+
2011-11-15 James Robinson jam...@chromium.org
https://bugs.webkit.org/show_bug.cgi?id=72402
Added: trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt (0 => 100338)
--- trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt 2011-11-15 23:05:28 UTC (rev 100338)
@@ -0,0 +1,15 @@
+Test that setting and getting display: grid works as expected
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Test getting |display| set through CSS
+PASS getComputedStyle(gridElement, '').getPropertyValue('display') is '-webkit-grid'
+
+Test getting and setting display through JS
+PASS getComputedStyle(element, '').getPropertyValue('display') is 'block'
+PASS getComputedStyle(element, '').getPropertyValue('display') is '-webkit-grid'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/fast/css-grid-layout/display-grid-set-get-expected.txt
___
Added: svn:eol-style
Added:
[webkit-changes] [100339] branches/safari-534.53-branch/Source/WebCore
Title: [100339] branches/safari-534.53-branch/Source/WebCore
Revision 100339
Author lforsch...@apple.com
Date 2011-11-15 15:07:28 -0800 (Tue, 15 Nov 2011)
Log Message
Merged r91140.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayerClient.h
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100338 => 100339)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 23:05:28 UTC (rev 100338)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 23:07:28 UTC (rev 100339)
@@ -1,5 +1,16 @@
2011-11-15 Lucas Forschler lforsch...@apple.com
+Merge 91140
+
+2011-07-15 Simon Fraser simon.fra...@apple.com
+
+Another Windows build fix; make this method non-pure virtual.
+
+* platform/graphics/GraphicsLayerClient.h:
+(WebCore::GraphicsLayerClient::didCommitChangesForLayer):
+
+2011-11-15 Lucas Forschler lforsch...@apple.com
+
Merge 91138
2011-07-15 Simon Fraser simon.fra...@apple.com
Modified: branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayerClient.h (100338 => 100339)
--- branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayerClient.h 2011-11-15 23:05:28 UTC (rev 100338)
+++ branches/safari-534.53-branch/Source/WebCore/platform/graphics/GraphicsLayerClient.h 2011-11-15 23:07:28 UTC (rev 100339)
@@ -62,7 +62,7 @@
virtual void notifySyncRequired(const GraphicsLayer*) = 0;
virtual void paintContents(const GraphicsLayer*, GraphicsContext, GraphicsLayerPaintingPhase, const IntRect inClip) = 0;
-virtual void didCommitChangesForLayer(const GraphicsLayer*) const = 0;
+virtual void didCommitChangesForLayer(const GraphicsLayer*) const { }
// Multiplier for backing store size, related to high DPI.
virtual float backingScaleFactor() const = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100340] trunk/Source
Title: [100340] trunk/Source
Revision 100340
Author commit-qu...@webkit.org
Date 2011-11-15 15:07:48 -0800 (Tue, 15 Nov 2011)
Log Message
Page/layer flashes after GPU-accelerated CSS transition
https://bugs.webkit.org/show_bug.cgi?id=72343
LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.
Patch by John Bates jba...@google.com on 2011-11-15
Reviewed by James Robinson.
New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100339 => 100340)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 23:07:28 UTC (rev 100339)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 23:07:48 UTC (rev 100340)
@@ -1,3 +1,25 @@
+2011-11-15 John Bates jba...@google.com
+
+Page/layer flashes after GPU-accelerated CSS transition
+https://bugs.webkit.org/show_bug.cgi?id=72343
+
+LayerRendererChromium was resizing the window to 1x1 at initialization.
+In some cases, there is no drawLayers before switching back to
+software rendering. This left the window resized to 1x1 and the
+following software paints would therefore not be visible. This change
+moves the reshape call into drawLayers so that it will only be called
+if rendering will occur.
+
+Reviewed by James Robinson.
+
+New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::viewportChanged):
+(WebCore::LayerRendererChromium::doViewportChanged):
+(WebCore::LayerRendererChromium::drawLayersInternal):
+* platform/graphics/chromium/LayerRendererChromium.h:
+
2011-11-15 Julien Chaffraix jchaffr...@webkit.org
Add the needed plumbing to parse display: -webkit-grid
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (100339 => 100340)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-11-15 23:07:28 UTC (rev 100339)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-11-15 23:07:48 UTC (rev 100340)
@@ -175,6 +175,7 @@
, m_context(context)
, m_defaultRenderSurface(0)
, m_sharedGeometryQuad(FloatRect(-0.5f, -0.5f, 1.0f, 1.0f))
+, m_isViewportChanged(false)
{
}
@@ -276,8 +277,7 @@
void LayerRendererChromium::viewportChanged()
{
-if (m_context)
-m_context-reshape(std::max(1, viewportWidth()), std::max(1, viewportHeight()));
+m_isViewportChanged = true;
// Reset the current render surface to force an update of the viewport and
// projection matrix next time useRenderSurface is called.
@@ -353,6 +353,14 @@
return;
TRACE_EVENT(LayerRendererChromium::drawLayers, this, 0);
+if (m_isViewportChanged) {
+// Only reshape when we know we are going to draw. Otherwise, the reshape
+// can leave the window at the wrong size if we never draw and the proper
+// viewport size is never set.
+m_isViewportChanged = false;
+m_context-reshape(viewportWidth(), viewportHeight());
+}
+
CCLayerImpl* rootDrawLayer = rootLayer();
makeContextCurrent();
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h (100339 => 100340)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h 2011-11-15 23:07:28 UTC (rev 100339)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h 2011-11-15 23:07:48 UTC (rev 100340)
@@ -231,6 +231,8 @@
CCLayerSorter m_layerSorter;
FloatQuad m_sharedGeometryQuad;
+
+bool m_isViewportChanged;
};
// Setting DEBUG_GL_CALLS to 1 will call glGetError() after almost every GL
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (100339 => 100340)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2011-11-15 23:07:28 UTC (rev 100339)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2011-11-15 23:07:48 UTC (rev 100340)
@@ -292,5 +292,45 @@
EXPECT_TRUE(layer2-drawn());
}
+class ReshapeTrackerContext: public
[webkit-changes] [100341] branches/safari-534.53-branch/Source/WebKit/win
Title: [100341] branches/safari-534.53-branch/Source/WebKit/win
Revision 100341
Author lforsch...@apple.com
Date 2011-11-15 15:08:28 -0800 (Tue, 15 Nov 2011)
Log Message
Merged r91145.
Modified Paths
branches/safari-534.53-branch/Source/WebKit/win/ChangeLog
branches/safari-534.53-branch/Source/WebKit/win/WebView.h
Diff
Modified: branches/safari-534.53-branch/Source/WebKit/win/ChangeLog (100340 => 100341)
--- branches/safari-534.53-branch/Source/WebKit/win/ChangeLog 2011-11-15 23:07:48 UTC (rev 100340)
+++ branches/safari-534.53-branch/Source/WebKit/win/ChangeLog 2011-11-15 23:08:28 UTC (rev 100341)
@@ -1,3 +1,15 @@
+2011-11-15 Lucas Forschler lforsch...@apple.com
+
+Merge 91145
+
+2011-07-15 Simon Fraser simon.fra...@apple.com
+
+Fix Windows build.
+
+* WebView.h:
+(WebView::backingScaleFactor):
+(WebView::pageScaleFactor):
+
2011-08-11 Lucas Forschler lforsch...@apple.com
Merged 91097
Modified: branches/safari-534.53-branch/Source/WebKit/win/WebView.h (100340 => 100341)
--- branches/safari-534.53-branch/Source/WebKit/win/WebView.h 2011-11-15 23:07:48 UTC (rev 100340)
+++ branches/safari-534.53-branch/Source/WebKit/win/WebView.h 2011-11-15 23:08:28 UTC (rev 100341)
@@ -992,6 +992,8 @@
virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time);
virtual void notifySyncRequired(const WebCore::GraphicsLayer*);
virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect inClip);
+virtual float backingScaleFactor() const { return 1; }
+virtual float pageScaleFactor() const { return 1; }
virtual bool showDebugBorders() const;
virtual bool showRepaintCounter() const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100342] branches/safari-534.53-branch/Source/WebCore/ChangeLog
Title: [100342] branches/safari-534.53-branch/Source/WebCore/ChangeLog Revision 100342 Author lforsch...@apple.com Date 2011-11-15 15:09:54 -0800 (Tue, 15 Nov 2011) Log Message Merged r91147. Modified Paths branches/safari-534.53-branch/Source/WebCore/ChangeLog Diff Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100341 => 100342) --- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 23:08:28 UTC (rev 100341) +++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 23:09:54 UTC (rev 100342) @@ -1,5 +1,16 @@ 2011-11-15 Lucas Forschler lforsch...@apple.com +Merge 91147 + +2011-07-15 Simon Fraser simon.fra...@apple.com + +Fix the build. + +* platform/mac/ScrollbarThemeMac.mm: +(WebCore::ScrollbarThemeMac::updateEnabledState): + +2011-11-15 Lucas Forschler lforsch...@apple.com + Merge 91140 2011-07-15 Simon Fraser simon.fra...@apple.com ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100344] trunk/LayoutTests
Title: [100344] trunk/LayoutTests Revision 100344 Author pkast...@chromium.org Date 2011-11-15 15:23:32 -0800 (Tue, 15 Nov 2011) Log Message Mark another test as flakily crashing. https://bugs.webkit.org/show_bug.cgi?id=59552 Unreviewed, gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100343 => 100344) --- trunk/LayoutTests/ChangeLog 2011-11-15 23:21:53 UTC (rev 100343) +++ trunk/LayoutTests/ChangeLog 2011-11-15 23:23:32 UTC (rev 100344) @@ -1,3 +1,12 @@ +2011-11-15 Peter Kasting pkast...@google.com + +Mark another test as flakily crashing. +https://bugs.webkit.org/show_bug.cgi?id=59552 + +Unreviewed, gardening. + +* platform/chromium/test_expectations.txt: + 2011-11-15 Julien Chaffraix jchaffr...@webkit.org Add the needed plumbing to parse display: -webkit-grid Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100343 => 100344) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 23:21:53 UTC (rev 100343) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 23:23:32 UTC (rev 100344) @@ -3838,12 +3838,14 @@ BUGWK71653 : platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html = PASS TIMEOUT // Intermittent assertion failures on snowleopard bots. -BUGWK59552 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH BUGWK59552 SNOWLEOPARD DEBUG : fast/dom/Element/id-in-frame.html = PASS CRASH +BUGWK59552 SNOWLEOPARD DEBUG : fast/dom/image-object.html = PASS CRASH BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/content-opacity-2.html = PASS CRASH -BUGWK59552 SNOWLEOPARD DEBUG : fast/parser/close-while-stopping.html = PASS CRASH BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/iframe-double-scale-contents.html = PASS CRASH BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/set-parent-src-synchronously.html = PASS CRASH +BUGWK59552 SNOWLEOPARD DEBUG : fast/parser/close-while-stopping.html = PASS CRASH +BUGWK59552 SNOWLEOPARD DEBUG : http/tests/security/cross-frame-access-custom.html = PASS CRASH +BUGWK59552 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH // Introduced due to BUGWK53512, fails under Skia right now BUGWK65939 : svg/custom/getBBox-path.svg = TEXT @@ -3885,8 +3887,6 @@ BUGV8_1821 WIN LINUX : http/tests/inspector-enabled/dedicated-workers-list.html = PASS CRASH BUGWK72133 SKIP MAC : http/tests/inspector-enabled/dedicated-workers-list.html = PASS CRASH TIMEOUT -BUGWK59552 MAC DEBUG : http/tests/security/cross-frame-access-custom.html = PASS CRASH - // use Skia to draw vertical text directly instead of text-on-path BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-backward-br.html = IMAGE BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-forward-br.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100345] trunk/Source/WebKit2
Title: [100345] trunk/Source/WebKit2 Revision 100345 Author wei...@apple.com Date 2011-11-15 15:27:10 -0800 (Tue, 15 Nov 2011) Log Message Fix windows build. * win/WebKit2Generated.make: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2Generated.make Diff Modified: trunk/Source/WebKit2/ChangeLog (100344 => 100345) --- trunk/Source/WebKit2/ChangeLog 2011-11-15 23:23:32 UTC (rev 100344) +++ trunk/Source/WebKit2/ChangeLog 2011-11-15 23:27:10 UTC (rev 100345) @@ -1,5 +1,11 @@ 2011-11-15 Sam Weinig s...@webkit.org +Fix windows build. + +* win/WebKit2Generated.make: + +2011-11-15 Sam Weinig s...@webkit.org + Add WebKit2 API object to represent a connection https://bugs.webkit.org/show_bug.cgi?id=72421 Modified: trunk/Source/WebKit2/win/WebKit2Generated.make (100344 => 100345) --- trunk/Source/WebKit2/win/WebKit2Generated.make 2011-11-15 23:23:32 UTC (rev 100344) +++ trunk/Source/WebKit2/win/WebKit2Generated.make 2011-11-15 23:27:10 UTC (rev 100345) @@ -18,6 +18,7 @@ xcopy /y /d ..\Shared\API\c\win\WKCertificateInfoWin.h %ConfigurationBuildDir%\include\WebKit2 xcopy /y /d ..\Shared\API\c\WKArray.h %ConfigurationBuildDir%\include\WebKit2 xcopy /y /d ..\Shared\API\c\WKBase.h %ConfigurationBuildDir%\include\WebKit2 +xcopy /y /d ..\Shared\API\c\WKConnectionRef.h %ConfigurationBuildDir%\include\WebKit2 xcopy /y /d ..\Shared\API\c\WKCertificateInfo.h %ConfigurationBuildDir%\include\WebKit2 xcopy /y /d ..\Shared\API\C\WKContextMenuItem.h %ConfigurationBuildDir%\include\WebKit2 xcopy /y /d ..\Shared\API\C\WKContextMenuItemTypes.h %ConfigurationBuildDir%\include\WebKit2 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100346] trunk/LayoutTests
Title: [100346] trunk/LayoutTests Revision 100346 Author t...@chromium.org Date 2011-11-15 15:29:19 -0800 (Tue, 15 Nov 2011) Log Message Skip failing ref tests on Qt. * platform/qt/Skipped: editing/pasteboard/data-transfer-items-image-png.html and fast/forms/file/file-input-reset.html are failing. See bugs. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100345 => 100346) --- trunk/LayoutTests/ChangeLog 2011-11-15 23:27:10 UTC (rev 100345) +++ trunk/LayoutTests/ChangeLog 2011-11-15 23:29:19 UTC (rev 100346) @@ -1,3 +1,10 @@ +2011-11-15 Tony Chang t...@chromium.org + +Skip failing ref tests on Qt. + +* platform/qt/Skipped: editing/pasteboard/data-transfer-items-image-png.html and +fast/forms/file/file-input-reset.html are failing. See bugs. + 2011-11-15 Peter Kasting pkast...@google.com Mark another test as flakily crashing. Modified: trunk/LayoutTests/platform/qt/Skipped (100345 => 100346) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-15 23:27:10 UTC (rev 100345) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-15 23:29:19 UTC (rev 100346) @@ -2474,3 +2474,11 @@ # https://bugs.webkit.org/show_bug.cgi?id=72364 http/tests/security/cross-frame-access-enumeration.html http/tests/security/postMessage/invalid-origin-throws-exception.html + +# [Qt] editing/pasteboard/data-transfer-items-image-png.html is failing due to DataTransferItems for image/png not being implemented +# https://bugs.webkit.org/show_bug.cgi?id=72430 +editing/pasteboard/data-transfer-items-image-png.html + +# [Qt] fast/forms/file/file-input-reset.html failing on Qt +# https://bugs.webkit.org/show_bug.cgi?id=72429 +fast/forms/file/file-input-reset.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100347] trunk/Source/WebCore
Title: [100347] trunk/Source/WebCore
Revision 100347
Author ad...@chromium.org
Date 2011-11-15 15:34:04 -0800 (Tue, 15 Nov 2011)
Log Message
Factor out V8Proxy's max recursion depth handling code
https://bugs.webkit.org/show_bug.cgi?id=72422
Reviewed by Nate Chapin.
Previously, V8Proxy used slightly different code to handle stack limit
violations depending on whether they occured in runScript or
callFunction. As described in http://webkit.org/b/72063, I intend to
expand the usage of m_recursion when calling into script. This patch
is intended to unify the existing handling code, making it easier to
move elsewhere without causing unintended side-effects.
No tests changed, as the only change in behavior is the string passed
to RangeError in the runScript case, and it's not mentioned anywhere
in the LayoutTests.
* bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::runScript): Use callFunction's factored-out code.
(WebCore::V8Proxy::callFunction): Simplify and factor out code into handleMaxRecursionDepthExceeded.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100346 => 100347)
--- trunk/Source/WebCore/ChangeLog 2011-11-15 23:29:19 UTC (rev 100346)
+++ trunk/Source/WebCore/ChangeLog 2011-11-15 23:34:04 UTC (rev 100347)
@@ -1,3 +1,26 @@
+2011-11-15 Adam Klein ad...@chromium.org
+
+Factor out V8Proxy's max recursion depth handling code
+https://bugs.webkit.org/show_bug.cgi?id=72422
+
+Reviewed by Nate Chapin.
+
+Previously, V8Proxy used slightly different code to handle stack limit
+violations depending on whether they occured in runScript or
+callFunction. As described in http://webkit.org/b/72063, I intend to
+expand the usage of m_recursion when calling into script. This patch
+is intended to unify the existing handling code, making it easier to
+move elsewhere without causing unintended side-effects.
+
+No tests changed, as the only change in behavior is the string passed
+to RangeError in the runScript case, and it's not mentioned anywhere
+in the LayoutTests.
+
+* bindings/v8/V8Proxy.cpp:
+(WebCore::handleMaxRecursionDepthExceeded):
+(WebCore::V8Proxy::runScript): Use callFunction's factored-out code.
+(WebCore::V8Proxy::callFunction): Simplify and factor out code into handleMaxRecursionDepthExceeded.
+
2011-11-15 Jessie Berlin jber...@apple.com
NSURLRequest leak beneath ResourceRequest::setStorageSession seen on Leaks bot.
Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.cpp (100346 => 100347)
--- trunk/Source/WebCore/bindings/v8/V8Proxy.cpp 2011-11-15 23:29:19 UTC (rev 100346)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.cpp 2011-11-15 23:34:04 UTC (rev 100347)
@@ -175,6 +175,14 @@
CRASH();
}
+static v8::Localv8::Value handleMaxRecursionDepthExceeded()
+{
+v8::Localv8::String code = v8::String::New(throw new RangeError('Maximum call stack size exceeded.'));
+v8::Localv8::Script script = v8::Script::Compile(code);
+script-Run();
+return v8::Localv8::Value();
+}
+
V8Proxy::V8Proxy(Frame* frame)
: m_frame(frame)
, m_windowShell(V8DOMWindowShell::create(frame))
@@ -384,21 +392,12 @@
return notHandledByInterceptor();
V8GCController::checkMemoryUsage();
-// Compute the source string and prevent against infinite recursion.
-if (m_recursion = kMaxRecursionDepth) {
-v8::Localv8::String code = v8ExternalString(throw RangeError('Recursion too deep'));
-// FIXME: Ideally, we should be able to re-use the origin of the
-// script passed to us as the argument instead of using an empty string
-// and 0 baseLine.
-script = compileScript(code, , TextPosition::minimumPosition());
-}
+if (m_recursion = kMaxRecursionDepth)
+return handleMaxRecursionDepthExceeded();
if (handleOutOfMemory())
ASSERT(script.IsEmpty());
-if (script.IsEmpty())
-return notHandledByInterceptor();
-
// Save the previous value of the inlineCode flag and update the flag for
// the duration of the script invocation.
bool previousInlineCode = inlineCode();
@@ -445,22 +444,14 @@
{
V8GCController::checkMemoryUsage();
+if (m_recursion = kMaxRecursionDepth)
+return handleMaxRecursionDepthExceeded();
+
// Keep Frame (and therefore ScriptController and V8Proxy) alive.
RefPtrFrame protect(frame());
v8::Localv8::Value result;
{
-if (m_recursion = kMaxRecursionDepth) {
-v8::Localv8::String code = v8::String::New(throw new RangeError('Maximum call stack size exceeded.'));
-if (code.IsEmpty())
-return result;
-v8::Localv8::Script script = v8::Script::Compile(code);
-if (script.IsEmpty())
-
[webkit-changes] [100348] branches/safari-534.53-branch/Source/WebCore/ChangeLog
Title: [100348] branches/safari-534.53-branch/Source/WebCore/ChangeLog Revision 100348 Author lforsch...@apple.com Date 2011-11-15 15:36:52 -0800 (Tue, 15 Nov 2011) Log Message rollout unneeded merge of 91147. Modified Paths branches/safari-534.53-branch/Source/WebCore/ChangeLog Diff Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100347 => 100348) --- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 23:34:04 UTC (rev 100347) +++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-15 23:36:52 UTC (rev 100348) @@ -1,16 +1,5 @@ 2011-11-15 Lucas Forschler lforsch...@apple.com -Merge 91147 - -2011-07-15 Simon Fraser simon.fra...@apple.com - -Fix the build. - -* platform/mac/ScrollbarThemeMac.mm: -(WebCore::ScrollbarThemeMac::updateEnabledState): - -2011-11-15 Lucas Forschler lforsch...@apple.com - Merge 91140 2011-07-15 Simon Fraser simon.fra...@apple.com ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100349] trunk/Websites/bugs.webkit.org
Title: [100349] trunk/Websites/bugs.webkit.org
Revision 100349
Author t...@chromium.org
Date 2011-11-15 15:40:57 -0800 (Tue, 15 Nov 2011)
Log Message
set a max-width on the codereview overall comments textarea
https://bugs.webkit.org/show_bug.cgi?id=72415
Reviewed by Ojan Vafai.
Otherwise, when resizing the textarea you can end up making wider, but
are no longer able to click the resize gripper to make it smaller
(it's under another div).
* PrettyPatch/PrettyPatch.rb:
Modified Paths
trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
Diff
Modified: trunk/Websites/bugs.webkit.org/ChangeLog (100348 => 100349)
--- trunk/Websites/bugs.webkit.org/ChangeLog 2011-11-15 23:36:52 UTC (rev 100348)
+++ trunk/Websites/bugs.webkit.org/ChangeLog 2011-11-15 23:40:57 UTC (rev 100349)
@@ -1,3 +1,16 @@
+2011-11-15 Tony Chang t...@chromium.org
+
+set a max-width on the codereview overall comments textarea
+https://bugs.webkit.org/show_bug.cgi?id=72415
+
+Reviewed by Ojan Vafai.
+
+Otherwise, when resizing the textarea you can end up making wider, but
+are no longer able to click the resize gripper to make it smaller
+(it's under another div).
+
+* PrettyPatch/PrettyPatch.rb:
+
2011-10-13 Adam Barth aba...@webkit.org
Would be nice if the review-tool offered to show the corresponding header
Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (100348 => 100349)
--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2011-11-15 23:36:52 UTC (rev 100348)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2011-11-15 23:40:57 UTC (rev 100349)
@@ -272,6 +272,7 @@
.overallComments textarea {
height: 2em;
+ max-width: 100%;
}
.comment textarea, .overallComments textarea {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100350] trunk/Tools
Title: [100350] trunk/Tools Revision 100350 Author t...@chromium.org Date 2011-11-15 15:41:53 -0800 (Tue, 15 Nov 2011) Log Message Unreviewed fix of ref-tests on GTK+. If a driver is never started, _xvfb_process is never set. * Scripts/webkitpy/layout_tests/port/gtk.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py Diff Modified: trunk/Tools/ChangeLog (100349 => 100350) --- trunk/Tools/ChangeLog 2011-11-15 23:40:57 UTC (rev 100349) +++ trunk/Tools/ChangeLog 2011-11-15 23:41:53 UTC (rev 100350) @@ -1,3 +1,10 @@ +2011-11-15 Tony Chang t...@chromium.org + +Unreviewed fix of ref-tests on GTK+. +If a driver is never started, _xvfb_process is never set. + +* Scripts/webkitpy/layout_tests/port/gtk.py: + 2011-11-14 Tony Chang t...@chromium.org [NRWT] Reftests should run even when pixel tests are disabled. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (100349 => 100350) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-11-15 23:40:57 UTC (rev 100349) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-11-15 23:41:53 UTC (rev 100350) @@ -57,9 +57,10 @@ def stop(self): WebKitDriver.stop(self) -# FIXME: This should use Executive.kill_process -os.kill(self._xvfb_process.pid, signal.SIGTERM) -self._xvfb_process.wait() +if getattr(self, '_xvfb_process', None): +# FIXME: This should use Executive.kill_process +os.kill(self._xvfb_process.pid, signal.SIGTERM) +self._xvfb_process.wait() class GtkPort(WebKitPort): ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100352] trunk/Tools
Title: [100352] trunk/Tools Revision 100352 Author t...@chromium.org Date 2011-11-15 15:50:57 -0800 (Tue, 15 Nov 2011) Log Message Unreviewed, try to fix ref tests failures on SL Intel bot. It looks like ImageDiff isn't returning an image diff. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py Diff Modified: trunk/Tools/ChangeLog (100351 => 100352) --- trunk/Tools/ChangeLog 2011-11-15 23:46:55 UTC (rev 100351) +++ trunk/Tools/ChangeLog 2011-11-15 23:50:57 UTC (rev 100352) @@ -1,5 +1,12 @@ 2011-11-15 Tony Chang t...@chromium.org +Unreviewed, try to fix ref tests failures on SL Intel bot. +It looks like ImageDiff isn't returning an image diff. + +* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: + +2011-11-15 Tony Chang t...@chromium.org + Unreviewed fix of ref-tests on GTK+. If a driver is never started, _xvfb_process is never set. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py (100351 => 100352) --- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 2011-11-15 23:46:55 UTC (rev 100351) +++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 2011-11-15 23:50:57 UTC (rev 100352) @@ -58,7 +58,9 @@ writer.write_image_files(driver_output.image, expected_driver_output.image) elif isinstance(failure, test_failures.FailureImageHashMismatch): writer.write_image_files(driver_output.image, expected_driver_output.image) -writer.write_image_diff_files(driver_output.image_diff) +# FIXME: Why is image_diff a bool on SL bot? Maybe ImageDiff isn't found? +if driver_output.image_diff: +writer.write_image_diff_files(str(driver_output.image_diff)) elif isinstance(failure, (test_failures.FailureAudioMismatch, test_failures.FailureMissingAudio)): writer.write_audio_files(driver_output.audio, expected_driver_output.audio) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100353] trunk/Source
Title: [100353] trunk/Source Revision 100353 Author joc...@chromium.org Date 2011-11-15 15:52:28 -0800 (Tue, 15 Nov 2011) Log Message Rename ReferrerPolicy to clarify its meaning https://bugs.webkit.org/show_bug.cgi?id=72420 Reviewed by Nate Chapin. Source/WebCore: On the one hand, even if the ReferrerPolicy was set to SendReferrer, the referrer wasn't necessarily send. On the other hand, I want to use the name ReferrerPolicy when implementing the meta referrer tag. No change in behavior expected so no test. * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick): (WebCore::handleLinkClick): * loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::loadFrameRequest): * loader/FrameLoader.h: * loader/FrameLoaderTypes.h: * loader/NavigationScheduler.cpp: (WebCore::ScheduledHistoryNavigation::fire): (WebCore::ScheduledFormSubmission::fire): * page/ContextMenuController.cpp: (WebCore::openNewWindow): (WebCore::ContextMenuController::contextMenuItemSelected): * WebCore.exp.in: updated. Source/WebKit/chromium: * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): Source/WebKit/mac: * WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Source/WebKit/qt: * Api/qwebpage.cpp: (openNewWindow): (QWebPage::triggerAction): Source/WebKit/win: * WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Source/WebKit2: * WebProcess/WebCoreSupport/WebContextMenuClient.cpp: (WebKit::WebContextMenuClient::searchWithGoogle): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::linkClicked): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/html/HTMLAnchorElement.cpp trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/loader/FrameLoader.h trunk/Source/WebCore/loader/FrameLoaderTypes.h trunk/Source/WebCore/loader/NavigationScheduler.cpp trunk/Source/WebCore/page/ContextMenuController.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebPDFView.mm trunk/Source/WebKit/qt/Api/qwebpage.cpp trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (100352 => 100353) --- trunk/Source/WebCore/ChangeLog 2011-11-15 23:50:57 UTC (rev 100352) +++ trunk/Source/WebCore/ChangeLog 2011-11-15 23:52:28 UTC (rev 100353) @@ -1,3 +1,33 @@ +2011-11-15 Jochen Eisinger joc...@chromium.org + +Rename ReferrerPolicy to clarify its meaning +https://bugs.webkit.org/show_bug.cgi?id=72420 + +Reviewed by Nate Chapin. + +On the one hand, even if the ReferrerPolicy was set to SendReferrer, the +referrer wasn't necessarily send. On the other hand, I want to use the +name ReferrerPolicy when implementing the meta referrer tag. + +No change in behavior expected so no test. + +* html/HTMLAnchorElement.cpp: +(WebCore::HTMLAnchorElement::handleClick): +(WebCore::handleLinkClick): +* loader/FrameLoader.cpp: +(WebCore::FrameLoader::changeLocation): +(WebCore::FrameLoader::urlSelected): +(WebCore::FrameLoader::loadFrameRequest): +* loader/FrameLoader.h: +* loader/FrameLoaderTypes.h: +* loader/NavigationScheduler.cpp: +(WebCore::ScheduledHistoryNavigation::fire): +(WebCore::ScheduledFormSubmission::fire): +* page/ContextMenuController.cpp: +(WebCore::openNewWindow): +(WebCore::ContextMenuController::contextMenuItemSelected): +* WebCore.exp.in: updated. + 2011-11-15 Adam Klein ad...@chromium.org Factor out V8Proxy's max recursion depth handling code Modified: trunk/Source/WebCore/WebCore.exp.in (100352 => 100353) --- trunk/Source/WebCore/WebCore.exp.in 2011-11-15 23:50:57 UTC (rev 100352) +++ trunk/Source/WebCore/WebCore.exp.in 2011-11-15 23:52:28 UTC (rev 100353) @@ -164,12 +164,12 @@ __ZN7WebCore11FileChooserD1Ev __ZN7WebCore11FrameLoader11loadArchiveEN3WTF10PassRefPtrINS_7ArchiveEEE __ZN7WebCore11FrameLoader11shouldCloseEv -__ZN7WebCore11FrameLoader11urlSelectedERKNS_4KURLERKN3WTF6StringENS4_10PassRefPtrINS_5EventEEEbbNS_14ReferrerPolicyE +__ZN7WebCore11FrameLoader11urlSelectedERKNS_4KURLERKN3WTF6StringENS4_10PassRefPtrINS_5EventEEEbbNS_18ShouldSendReferrerE __ZN7WebCore11FrameLoader12shouldReloadERKNS_4KURLES3_ __ZN7WebCore11FrameLoader14detachChildrenEv __ZN7WebCore11FrameLoader14stopAllLoadersENS_26ClearProvisionalItemPolicyE __ZN7WebCore11FrameLoader16detachFromParentEv
[webkit-changes] [100355] trunk
Title: [100355] trunk Revision 100355 Author jam...@google.com Date 2011-11-15 16:02:33 -0800 (Tue, 15 Nov 2011) Log Message [chromium] Merge chromium-gpu layout test configurations into non-gpu versions https://bugs.webkit.org/show_bug.cgi?id=72402 Reviewed by Dirk Pranke. Tools: Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for the normal compositing triggers since we currently run the compositing tests in only one configuration - with compositing enabled. Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this patch should not impact any tests. * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings): * DumpRenderTree/chromium/TestShell.h: (TestShell::setAcceleratedCompositingForVideoEnabled): * DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo): * DumpRenderTree/chromium/WebPreferences.h: * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: LayoutTests: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp trunk/Tools/DumpRenderTree/chromium/TestShell.cpp trunk/Tools/DumpRenderTree/chromium/TestShell.h trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp trunk/Tools/DumpRenderTree/chromium/WebPreferences.h trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py Diff Modified: trunk/LayoutTests/ChangeLog (100354 => 100355) --- trunk/LayoutTests/ChangeLog 2011-11-15 23:54:51 UTC (rev 100354) +++ trunk/LayoutTests/ChangeLog 2011-11-16 00:02:33 UTC (rev 100355) @@ -1,3 +1,12 @@ +2011-11-15 James Robinson jam...@chromium.org + +[chromium] Merge chromium-gpu layout test configurations into non-gpu versions +https://bugs.webkit.org/show_bug.cgi?id=72402 + +Reviewed by Dirk Pranke. + +* platform/chromium/test_expectations.txt: + 2011-11-15 Peter Kasting pkast...@google.com Mark a test as flakily failing. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100354 => 100355) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-15 23:54:51 UTC (rev 100354) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 00:02:33 UTC (rev 100355) @@ -2732,7 +2732,7 @@ BUGWK53868 : fast/notifications/notifications-document-close-crash.html = PASS TEXT -BUGWK54051 MAC : plugins/invalidate_rect.html = TEXT +BUGWK54051 MAC : compositing/plugins/invalidate_rect.html = TEXT BUGWK54051 MAC : plugins/windowless_plugin_paint_test.html = TIMEOUT // Snow Leopard-only failures (generally just need updated pixel results) @@ -3878,6 +3878,16 @@ BUG_SENORBLANCO GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT +// Will need baselines updated to take compositing into account when that is enabled by default. +// See bug for details +BUGWK72402 : fast/media/mq-transform-03.html = PASS FAIL +BUGWK72402 : transitions/default-timing-function.html = PASS FAIL +BUGWK72402 : animations/missing-values-first-keyframe.html = PASS FAIL +BUGWK72402 : fast/repaint/block-selection-gap-in-composited-layer.html = PASS FAIL +BUGWK72402 : fast/media/mq-transform-02.html = PASS FAIL +BUGWK72402 : animations/opacity-transform-animation.html = PASS FAIL +BUGWK72402 : animations/missing-values-last-keyframe.html = PASS FAIL + // Need to rebaseline on win and mac. BUG_TONY MAC : css3/flexbox/repaint.html = PASS FAIL BUG_TONY MAC : css3/flexbox/repaint-rtl-column.html = PASS FAIL @@ -3927,4 +3937,4 @@ BUGWK72376 WIN : fast/forms/file/input-file-label.html = TEXT PASS -BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS \ No newline at end of file +BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS Modified: trunk/Tools/ChangeLog (100354 => 100355) --- trunk/Tools/ChangeLog 2011-11-15 23:54:51 UTC (rev 100354) +++ trunk/Tools/ChangeLog 2011-11-16 00:02:33 UTC (rev 100355) @@ -1,3 +1,35 @@ +2011-11-15 James Robinson jam...@chromium.org + +[chromium] Merge chromium-gpu layout test configurations into non-gpu versions +
[webkit-changes] [100356] trunk/Tools
Title: [100356] trunk/Tools Revision 100356 Author t...@chromium.org Date 2011-11-15 16:04:20 -0800 (Tue, 15 Nov 2011) Log Message Unreviewed, better fix for ref tests failures on SL Intel bot. Revert the previous change and return None if pixel results from either the test page or the expected page is missing. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: * Scripts/webkitpy/layout_tests/port/webkit.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py Diff Modified: trunk/Tools/ChangeLog (100355 => 100356) --- trunk/Tools/ChangeLog 2011-11-16 00:02:33 UTC (rev 100355) +++ trunk/Tools/ChangeLog 2011-11-16 00:04:20 UTC (rev 100356) @@ -1,3 +1,12 @@ +2011-11-15 Tony Chang t...@chromium.org + +Unreviewed, better fix for ref tests failures on SL Intel bot. +Revert the previous change and return None if pixel results from +either the test page or the expected page is missing. + +* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: +* Scripts/webkitpy/layout_tests/port/webkit.py: + 2011-11-15 James Robinson jam...@chromium.org [chromium] Merge chromium-gpu layout test configurations into non-gpu versions Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py (100355 => 100356) --- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 2011-11-16 00:02:33 UTC (rev 100355) +++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py 2011-11-16 00:04:20 UTC (rev 100356) @@ -58,9 +58,7 @@ writer.write_image_files(driver_output.image, expected_driver_output.image) elif isinstance(failure, test_failures.FailureImageHashMismatch): writer.write_image_files(driver_output.image, expected_driver_output.image) -# FIXME: Why is image_diff a bool on SL bot? Maybe ImageDiff isn't found? -if driver_output.image_diff: -writer.write_image_diff_files(str(driver_output.image_diff)) +writer.write_image_diff_files(driver_output.image_diff) elif isinstance(failure, (test_failures.FailureAudioMismatch, test_failures.FailureMissingAudio)): writer.write_audio_files(driver_output.audio, expected_driver_output.audio) Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (100355 => 100356) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-11-16 00:02:33 UTC (rev 100355) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-11-16 00:04:20 UTC (rev 100356) @@ -163,7 +163,7 @@ if not actual_contents or not expected_contents: # FIXME: It's not clear what we should return in this case. # Maybe we should throw an exception? -return (True, 0) +return (None, 0) process = self._start_image_diff_process(expected_contents, actual_contents) return self._read_image_diff(process) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100358] trunk/LayoutTests
Title: [100358] trunk/LayoutTests Revision 100358 Author pkast...@chromium.org Date 2011-11-15 16:17:03 -0800 (Tue, 15 Nov 2011) Log Message Mark a test as flakily crashing. https://bugs.webkit.org/show_bug.cgi?id=72436 Unreviewed, gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100357 => 100358) --- trunk/LayoutTests/ChangeLog 2011-11-16 00:09:51 UTC (rev 100357) +++ trunk/LayoutTests/ChangeLog 2011-11-16 00:17:03 UTC (rev 100358) @@ -1,3 +1,12 @@ +2011-11-15 Peter Kasting pkast...@google.com + +Mark a test as flakily crashing. +https://bugs.webkit.org/show_bug.cgi?id=72436 + +Unreviewed, gardening. + +* platform/chromium/test_expectations.txt: + 2011-11-15 Ojan Vafai o...@chromium.org Chromium baselines after http://trac.webkit.org/changeset/100324. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100357 => 100358) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 00:09:51 UTC (rev 100357) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 00:17:03 UTC (rev 100358) @@ -1232,7 +1232,8 @@ BUGCR10361 WIN : http/tests/misc/single-character-pi-stylesheet.xhtml = FAIL // Windows is missing the green box. Started to pass in roll to WebKit r50313 -BUGCR8729 WIN : http/tests/multipart/invalid-image-data.html = IMAGE+TEXT +BUGCR8729 WIN RELEASE : http/tests/multipart/invalid-image-data.html = IMAGE+TEXT +BUGWK72436 WIN DEBUG : http/tests/multipart/invalid-image-data.html = CRASH // - // MAC PORT TESTS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100359] trunk/LayoutTests
Title: [100359] trunk/LayoutTests Revision 100359 Author t...@chromium.org Date 2011-11-15 16:20:03 -0800 (Tue, 15 Nov 2011) Log Message Skip editing/pasteboard/data-transfer-items-image-png.html, a ref test, on platforms that don't currently support DataTransferItems. * platform/gtk/Skipped: * platform/mac/Skipped: * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100358 => 100359) --- trunk/LayoutTests/ChangeLog 2011-11-16 00:17:03 UTC (rev 100358) +++ trunk/LayoutTests/ChangeLog 2011-11-16 00:20:03 UTC (rev 100359) @@ -1,3 +1,12 @@ +2011-11-15 Tony Chang t...@chromium.org + +Skip editing/pasteboard/data-transfer-items-image-png.html, a ref test, on platforms that +don't currently support DataTransferItems. + +* platform/gtk/Skipped: +* platform/mac/Skipped: +* platform/win/Skipped: + 2011-11-15 Peter Kasting pkast...@google.com Mark a test as flakily crashing. Modified: trunk/LayoutTests/platform/gtk/Skipped (100358 => 100359) --- trunk/LayoutTests/platform/gtk/Skipped 2011-11-16 00:17:03 UTC (rev 100358) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-16 00:20:03 UTC (rev 100359) @@ -296,6 +296,7 @@ # DataTransferItems is not yet implemented. editing/pasteboard/data-transfer-items.html +editing/pasteboard/data-transfer-items-image-png.html # Needs grammar checking. editing/spelling/markers.html Modified: trunk/LayoutTests/platform/mac/Skipped (100358 => 100359) --- trunk/LayoutTests/platform/mac/Skipped 2011-11-16 00:17:03 UTC (rev 100358) +++ trunk/LayoutTests/platform/mac/Skipped 2011-11-16 00:20:03 UTC (rev 100359) @@ -337,6 +337,7 @@ # DataTransferItems is not yet implemented. editing/pasteboard/data-transfer-items.html +editing/pasteboard/data-transfer-items-image-png.html # Need to implement WebGeolocationRequest::cancelPermissionRequest on mac. # https://bugs.webkit.org/show_bug.cgi?id=55944 Modified: trunk/LayoutTests/platform/win/Skipped (100358 => 100359) --- trunk/LayoutTests/platform/win/Skipped 2011-11-16 00:17:03 UTC (rev 100358) +++ trunk/LayoutTests/platform/win/Skipped 2011-11-16 00:20:03 UTC (rev 100359) @@ -1271,6 +1271,7 @@ # DataTransferItems is not yet implemented. editing/pasteboard/data-transfer-items.html +editing/pasteboard/data-transfer-items-image-png.html # Needs expectation update fast/dom/HTMLMeterElement/meter-element.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100361] trunk/LayoutTests
Title: [100361] trunk/LayoutTests Revision 100361 Author pkast...@chromium.org Date 2011-11-15 16:24:40 -0800 (Tue, 15 Nov 2011) Log Message r100331 did not seem to commit precisely the right expectation. https://bugs.webkit.org/show_bug.cgi?id=72391 Unreviewed, gardening. * fast/dom/Orientation/create-event-orientationchange-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100360 => 100361) --- trunk/LayoutTests/ChangeLog 2011-11-16 00:23:44 UTC (rev 100360) +++ trunk/LayoutTests/ChangeLog 2011-11-16 00:24:40 UTC (rev 100361) @@ -1,3 +1,12 @@ +2011-11-15 Peter Kasting pkast...@google.com + +r100331 did not seem to commit precisely the right expectation. +https://bugs.webkit.org/show_bug.cgi?id=72391 + +Unreviewed, gardening. + +* fast/dom/Orientation/create-event-orientationchange-expected.txt: + 2011-11-15 James Robinson jam...@chromium.org [chromium] Unreviewed expectations update for compositing tests Modified: trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt (100360 => 100361) --- trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt 2011-11-16 00:23:44 UTC (rev 100360) +++ trunk/LayoutTests/fast/dom/Orientation/create-event-orientationchange-expected.txt 2011-11-16 00:24:40 UTC (rev 100361) @@ -6,4 +6,4 @@ PASS successfullyParsed is true TEST COMPLETE -FAIL... orientationChange event doesn't appear to be enabled or implemented. \ No newline at end of file +FAIL... orientationChange event doesn't appear to be enabled or implemented. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100363] trunk/Source/JavaScriptCore
Title: [100363] trunk/Source/_javascript_Core Revision 100363 Author fpi...@apple.com Date 2011-11-15 16:26:30 -0800 (Tue, 15 Nov 2011) Log Message Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const, JSC::DFG::SpeculationRecovery*) https://bugs.webkit.org/show_bug.cgi?id=72292 Reviewed by Geoff Garen. We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion() instead of CodeBlock::alternative(). No performance effect. No tests because all of our heuristics work very hard to make sure that this never happens in the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation) is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still because the whole point of jettisoning is to bring the probability of future OSR exits to as close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR exit after a jettison to be the first of its kind; our whole design tries to ensure that CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR compilation. So this is a truly evil case, and any test for it would be quite fragile. * bytecode/CodeBlock.h: (JSC::CodeBlock::specializationKind): (JSC::CodeBlock::largeFailCountThreshold): (JSC::CodeBlock::largeFailCountThresholdForLoop): * dfg/DFGAssemblyHelpers.h: (JSC::DFG::AssemblyHelpers::AssemblyHelpers): (JSC::DFG::AssemblyHelpers::baselineCodeBlockFor): (JSC::DFG::AssemblyHelpers::baselineCodeBlock): * dfg/DFGDriver.cpp: (JSC::DFG::compile): * dfg/DFGOSRExitCompiler.cpp: * dfg/DFGOSRExitCompiler64.cpp: (JSC::DFG::OSRExitCompiler::compileExit): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/CodeBlock.h trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h trunk/Source/_javascript_Core/dfg/DFGDriver.cpp trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler.cpp trunk/Source/_javascript_Core/dfg/DFGOSRExitCompiler64.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (100362 => 100363) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 00:26:15 UTC (rev 100362) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-16 00:26:30 UTC (rev 100363) @@ -1,3 +1,40 @@ +2011-11-15 Filip Pizlo fpi...@apple.com + +Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const, JSC::DFG::SpeculationRecovery*) +https://bugs.webkit.org/show_bug.cgi?id=72292 + +Reviewed by Geoff Garen. + +We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling +an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion() +instead of CodeBlock::alternative(). + +No performance effect. + +No tests because all of our heuristics work very hard to make sure that this never happens in +the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation) +is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still +because the whole point of jettisoning is to bring the probability of future OSR exits to as +close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR +exit after a jettison to be the first of its kind; our whole design tries to ensure that +CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning +is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR +compilation. So this is a truly evil case, and any test for it would be quite fragile. + +* bytecode/CodeBlock.h: +(JSC::CodeBlock::specializationKind): +(JSC::CodeBlock::largeFailCountThreshold): +(JSC::CodeBlock::largeFailCountThresholdForLoop): +* dfg/DFGAssemblyHelpers.h: +(JSC::DFG::AssemblyHelpers::AssemblyHelpers): +(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor): +(JSC::DFG::AssemblyHelpers::baselineCodeBlock): +* dfg/DFGDriver.cpp: +(JSC::DFG::compile): +* dfg/DFGOSRExitCompiler.cpp: +* dfg/DFGOSRExitCompiler64.cpp: +(JSC::DFG::OSRExitCompiler::compileExit): + 2011-11-15 Geoffrey Garen gga...@apple.com Use MarkedArgumentBuffer to avoid making assumptions about argument order Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (100362 => 100363) --- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2011-11-16 00:26:15 UTC (rev 100362) +++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2011-11-16 00:26:30 UTC (rev 100363) @@ -267,7
[webkit-changes] [100362] trunk/Source/WebKit2
Title: [100362] trunk/Source/WebKit2 Revision 100362 Author commit-qu...@webkit.org Date 2011-11-15 16:26:15 -0800 (Tue, 15 Nov 2011) Log Message [SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2 https://bugs.webkit.org/show_bug.cgi?id=72235 Patch by Jongseok Yang js45.y...@samsung.com on 2011-11-15 Reviewed by Gustavo Noronha Silva. Add WebCookieManagerSoup.cpp and implement functions for the cookie accept policy. It's required when using the soup network backend. Remove WebCookieManagerEfl.cpp and WebCookieManagerGtk.cpp because GTK port and EFL port use soup network backend without a network backend of their own. * GNUmakefile.am: * WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Removed. * WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Removed. * WebProcess/Cookies/soup/WebCookieManagerSoup.cpp: Added. (WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): (WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am Added Paths trunk/Source/WebKit2/WebProcess/Cookies/soup/ trunk/Source/WebKit2/WebProcess/Cookies/soup/WebCookieManagerSoup.cpp Removed Paths trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp trunk/Source/WebKit2/WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (100361 => 100362) --- trunk/Source/WebKit2/ChangeLog 2011-11-16 00:24:40 UTC (rev 100361) +++ trunk/Source/WebKit2/ChangeLog 2011-11-16 00:26:15 UTC (rev 100362) @@ -1,3 +1,22 @@ +2011-11-15 Jongseok Yang js45.y...@samsung.com + +[SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2 +https://bugs.webkit.org/show_bug.cgi?id=72235 + +Reviewed by Gustavo Noronha Silva. + +Add WebCookieManagerSoup.cpp and implement functions for the cookie accept policy. +It's required when using the soup network backend. +Remove WebCookieManagerEfl.cpp and WebCookieManagerGtk.cpp because GTK port and +EFL port use soup network backend without a network backend of their own. + +* GNUmakefile.am: +* WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Removed. +* WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Removed. +* WebProcess/Cookies/soup/WebCookieManagerSoup.cpp: Added. +(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): +(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): + 2011-11-15 Jochen Eisinger joc...@chromium.org Rename ReferrerPolicy to clarify its meaning Modified: trunk/Source/WebKit2/GNUmakefile.am (100361 => 100362) --- trunk/Source/WebKit2/GNUmakefile.am 2011-11-16 00:24:40 UTC (rev 100361) +++ trunk/Source/WebKit2/GNUmakefile.am 2011-11-16 00:26:15 UTC (rev 100362) @@ -669,7 +669,7 @@ Source/WebKit2/WebProcess/Authentication/AuthenticationManager.h \ Source/WebKit2/WebProcess/Cookies/WebCookieManager.h \ Source/WebKit2/WebProcess/Cookies/WebCookieManager.cpp \ - Source/WebKit2/WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp \ + Source/WebKit2/WebProcess/Cookies/soup/WebCookieManagerSoup.cpp \ Source/WebKit2/WebProcess/Downloads/Download.cpp \ Source/WebKit2/WebProcess/Downloads/Download.h \ Source/WebKit2/WebProcess/Downloads/DownloadAuthenticationClient.h \ Deleted: trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp (100361 => 100362) --- trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp 2011-11-16 00:24:40 UTC (rev 100361) +++ trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp 2011-11-16 00:26:15 UTC (rev 100362) @@ -1,44 +0,0 @@ -/* - * Copyright (C) 2011 Samsung Electronics. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - *notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - *notice, this list of conditions and the following disclaimer in the - *documentation and/or other materials provided with the distribution. - * - * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' - * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, - * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR - * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS - * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR - * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF - * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS - * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN - * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) - * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
[webkit-changes] [100364] trunk/LayoutTests
Title: [100364] trunk/LayoutTests Revision 100364 Author pkast...@chromium.org Date 2011-11-15 16:27:08 -0800 (Tue, 15 Nov 2011) Log Message Mark another test as flakily crashing. https://bugs.webkit.org/show_bug.cgi?id=59552 Unreviewed, gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100363 => 100364) --- trunk/LayoutTests/ChangeLog 2011-11-16 00:26:30 UTC (rev 100363) +++ trunk/LayoutTests/ChangeLog 2011-11-16 00:27:08 UTC (rev 100364) @@ -1,5 +1,14 @@ 2011-11-15 Peter Kasting pkast...@google.com +Mark another test as flakily crashing. +https://bugs.webkit.org/show_bug.cgi?id=59552 + +Unreviewed, gardening. + +* platform/chromium/test_expectations.txt: + +2011-11-15 Peter Kasting pkast...@google.com + r100331 did not seem to commit precisely the right expectation. https://bugs.webkit.org/show_bug.cgi?id=72391 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100363 => 100364) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 00:26:30 UTC (rev 100363) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 00:27:08 UTC (rev 100364) @@ -3840,6 +3840,7 @@ BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/content-opacity-2.html = PASS CRASH BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/iframe-double-scale-contents.html = PASS CRASH BUGWK59552 SNOWLEOPARD DEBUG : fast/frames/set-parent-src-synchronously.html = PASS CRASH +BUGWK59552 SNOWLEOPARD DEBUG : fast/loader/opaque-base-url.html = PASS CRASH BUGWK59552 SNOWLEOPARD DEBUG : fast/parser/close-while-stopping.html = PASS CRASH BUGWK59552 SNOWLEOPARD DEBUG : http/tests/security/cross-frame-access-custom.html = PASS CRASH BUGWK59552 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
