[webkit-changes] [108043] trunk/Source/WebCore

[cdn]

Title: [108043] trunk/Source/WebCore








Revision 108043
Author c...@chromium.org
Date 2012-02-16 23:47:58 -0800 (Thu, 16 Feb 2012)


Log Message
Correct a misleading comment regarding string delimiters in CSS parsing.
https://bugs.webkit.org/show_bug.cgi?id=78521

Reviewed by Zoltan Herczeg.

* css/CSSParser.cpp:
(WebCore::CSSParser::lex):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (108042 => 108043)

--- trunk/Source/WebCore/ChangeLog	2012-02-17 07:44:07 UTC (rev 108042)
+++ trunk/Source/WebCore/ChangeLog	2012-02-17 07:47:58 UTC (rev 108043)
@@ -1,3 +1,13 @@
+2012-02-16  Cris Neckar  
+
+Correct a misleading comment regarding string delimiters in CSS parsing.
+https://bugs.webkit.org/show_bug.cgi?id=78521
+
+Reviewed by Zoltan Herczeg.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::lex):
+
 2012-02-16  Martin Robinson  
 
 Fix the TextureMapper build for GTK+.


Modified: trunk/Source/WebCore/css/CSSParser.cpp (108042 => 108043)

--- trunk/Source/WebCore/css/CSSParser.cpp	2012-02-17 07:44:07 UTC (rev 108042)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-02-17 07:47:58 UTC (rev 108043)
@@ -8225,8 +8225,8 @@
 UChar* result;
 bool hasEscape;
 
-// The input buffer is terminated by two \0, so
-// it is safe to read two characters ahead anytime.
+// The input buffer is terminated by a \0 character, so
+// it is safe to read one character ahead of a known non-null.
 
 #ifndef NDEBUG
 // In debug we check with an ASSERT that the length is > 0 for string types.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [108041] trunk/Source/WebCore

[mrobinson]

Title: [108041] trunk/Source/WebCore








Revision 108041
Author mrobin...@webkit.org
Date 2012-02-16 23:30:07 -0800 (Thu, 16 Feb 2012)


Log Message
Fix the TextureMapper build for GTK+.

No new tests. This is just a build fix.

* GNUmakefile.list.am: Add missing files to the build and change spaces to tabs.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (108040 => 108041)

--- trunk/Source/WebCore/ChangeLog	2012-02-17 07:26:13 UTC (rev 108040)
+++ trunk/Source/WebCore/ChangeLog	2012-02-17 07:30:07 UTC (rev 108041)
@@ -1,3 +1,11 @@
+2012-02-16  Martin Robinson  
+
+Fix the TextureMapper build for GTK+.
+
+No new tests. This is just a build fix.
+
+* GNUmakefile.list.am: Add missing files to the build and change spaces to tabs.
+
 2012-02-16  Daniel Bates  
 
 Add ENABLE(STYLE_SCOPED) around HTMLStyleElement::m_isRegisteredWithScopingNode 


Modified: trunk/Source/WebCore/GNUmakefile.list.am (108040 => 108041)

--- trunk/Source/WebCore/GNUmakefile.list.am	2012-02-17 07:26:13 UTC (rev 108040)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2012-02-17 07:30:07 UTC (rev 108041)
@@ -5749,17 +5749,17 @@
 	Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h \
 	Source/WebCore/platform/graphics/texmap/LayerTransform.cpp \
 	Source/WebCore/platform/graphics/texmap/LayerTransform.h \
-	Source/WebCore/platform/graphics/texmap/TextureMapper.cpp \
-	Source/WebCore/platform/graphics/texmap/TextureMapper.h \
 	Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp \
 	Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.h \
 	Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp \
 	Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h \
-Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp \
-Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.h \
-Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp \
-Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h \
-Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h
+	Source/WebCore/platform/graphics/texmap/TextureMapper.cpp \
+	Source/WebCore/platform/graphics/texmap/TextureMapper.h \
+	Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp \
+	Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.h \
+	Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp \
+	Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h \
+	Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h 
 webcoregtk_sources += \
 	Source/WebCore/platform/graphics/cairo/TextureMapperCairo.cpp \
 	Source/WebCore/platform/graphics/cairo/TextureMapperCairo.h
@@ -5773,16 +5773,16 @@
 	Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h \
 	Source/WebCore/platform/graphics/texmap/LayerTransform.cpp \
 	Source/WebCore/platform/graphics/texmap/LayerTransform.h \
-	Source/WebCore/platform/graphics/texmap/TextureMapper.cpp \
-	Source/WebCore/platform/graphics/texmap/TextureMapper.h \
 	Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp \
 	Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.h \
 	Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp \
 	Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h \
+	Source/WebCore/platform/graphics/texmap/TextureMapper.cpp \
+	Source/WebCore/platform/graphics/texmap/TextureMapper.h \
 	Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp \
 	Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.h \
-	Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp \
-	Source/WebCore/platform/graphics/texmap/TextureMapperNode.h \
+	Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp \
+	Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h \
 	Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h
 webcoregtk_sources += \
 	Source/WebCore/platform/graphics/gtk/WindowGLContextGLX.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [108040] trunk/Source/WebKit2

[carlosgc]

Title: [108040] trunk/Source/WebKit2








Revision 108040
Author carlo...@webkit.org
Date 2012-02-16 23:26:13 -0800 (Thu, 16 Feb 2012)


Log Message
[GTK] Make sure print operation object is alive until printing finishes in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78829

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Adopt the WebKitPrintOperation
reference so that it's released when the callback finishes.
(webkitPrintOperationRunDialogForFrame): Pass a reference of
WebKitPrintOperation to the printing callback.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (108039 => 108040)

--- trunk/Source/WebKit2/ChangeLog	2012-02-17 07:23:28 UTC (rev 108039)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-17 07:26:13 UTC (rev 108040)
@@ -1,3 +1,16 @@
+2012-02-16  Carlos Garcia Campos  
+
+[GTK] Make sure print operation object is alive until printing finishes in WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=78829
+
+Reviewed by Martin Robinson.
+
+* UIProcess/API/gtk/WebKitPrintOperation.cpp:
+(drawPagesForPrintingCompleted): Adopt the WebKitPrintOperation
+reference so that it's released when the callback finishes.
+(webkitPrintOperationRunDialogForFrame): Pass a reference of
+WebKitPrintOperation to the printing callback.
+
 2012-02-15  Geoffrey Garen  
 
 Made Weak single-owner, adding PassWeak


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp (108039 => 108040)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp	2012-02-17 07:23:28 UTC (rev 108039)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp	2012-02-17 07:26:13 UTC (rev 108040)
@@ -234,10 +234,10 @@
 
 static void drawPagesForPrintingCompleted(WKErrorRef, void* context)
 {
-WebKitPrintOperation* printOperation = WEBKIT_PRINT_OPERATION(context);
+GRefPtr printOperation = adoptGRef(WEBKIT_PRINT_OPERATION(context));
 WebPageProxy* page = webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(printOperation->priv->webView));
 page->endPrinting();
-g_signal_emit(printOperation, signals[DONE], 0, NULL);
+g_signal_emit(printOperation.get(), signals[DONE], 0, NULL);
 }
 
 void webkitPrintOperationRunDialogForFrame(WebKitPrintOperation* printOperation, GtkWindow* parent, WebFrameProxy* webFrame)
@@ -262,7 +262,7 @@
 
 PrintInfo printInfo(priv->printSettings.get(), priv->pageSetup.get());
 WebPageProxy* page = webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(priv->webView));
-page->drawPagesForPrinting(webFrame, printInfo, VoidCallback::create(printOperation, &drawPagesForPrintingCompleted));
+page->drawPagesForPrinting(webFrame, printInfo, VoidCallback::create(g_object_ref(printOperation), &drawPagesForPrintingCompleted));
 }
 
 /**






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [108039] trunk/Tools

[carlosgc]

Title: [108039] trunk/Tools








Revision 108039
Author carlo...@webkit.org
Date 2012-02-16 23:23:28 -0800 (Thu, 16 Feb 2012)


Log Message
[GTK] Make install is broken when building without --enable-gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=78828

Reviewed by Martin Robinson.

* gtk/generate-gtkdoc:
(rebase_installed_docs): Check documentation has been generated
before trying to rebase it.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/generate-gtkdoc




Diff

Modified: trunk/Tools/ChangeLog (108038 => 108039)

--- trunk/Tools/ChangeLog	2012-02-17 07:20:12 UTC (rev 108038)
+++ trunk/Tools/ChangeLog	2012-02-17 07:23:28 UTC (rev 108039)
@@ -1,3 +1,14 @@
+2012-02-16  Carlos Garcia Campos  
+
+[GTK] Make install is broken when building without --enable-gtk-doc
+https://bugs.webkit.org/show_bug.cgi?id=78828
+
+Reviewed by Martin Robinson.
+
+* gtk/generate-gtkdoc:
+(rebase_installed_docs): Check documentation has been generated
+before trying to rebase it.
+
 2012-02-16  Dirk Pranke  
 
 nrwt: simplify worker interface


Modified: trunk/Tools/gtk/generate-gtkdoc (108038 => 108039)

--- trunk/Tools/gtk/generate-gtkdoc	2012-02-17 07:20:12 UTC (rev 108038)
+++ trunk/Tools/gtk/generate-gtkdoc	2012-02-17 07:23:28 UTC (rev 108039)
@@ -139,6 +139,9 @@
 return generator.saw_warnings
 
 def rebase_installed_docs(pkg_config_path, options):
+if not os.path.isdir(options['output_dir']):
+print "Documentation was not generated"
+return
 generator = gtkdoc.PkgConfigGTKDoc(pkg_config_path, options)
 generator.rebase_installed_docs()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [108038] trunk/Source/WebCore

[dbates]

Title: [108038] trunk/Source/WebCore








Revision 108038
Author dba...@webkit.org
Date 2012-02-16 23:20:12 -0800 (Thu, 16 Feb 2012)


Log Message
Add ENABLE(STYLE_SCOPED) around HTMLStyleElement::m_isRegisteredWithScopingNode 

The instance variable HTMLStyleElement::m_isRegisteredWithScopingNode is only
referenced from within ENABLE(STYLE_SCOPED)-guarded code. We should add this
guard around its declaration.

* html/HTMLStyleElement.h:
(HTMLStyleElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLStyleElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (108037 => 108038)

--- trunk/Source/WebCore/ChangeLog	2012-02-17 07:10:12 UTC (rev 108037)
+++ trunk/Source/WebCore/ChangeLog	2012-02-17 07:20:12 UTC (rev 108038)
@@ -1,3 +1,14 @@
+2012-02-16  Daniel Bates  
+
+Add ENABLE(STYLE_SCOPED) around HTMLStyleElement::m_isRegisteredWithScopingNode 
+
+The instance variable HTMLStyleElement::m_isRegisteredWithScopingNode is only
+referenced from within ENABLE(STYLE_SCOPED)-guarded code. We should add this
+guard around its declaration.
+
+* html/HTMLStyleElement.h:
+(HTMLStyleElement):
+
 2012-02-16  Shinya Kawanaka  
 
 [v8] v8 doesn't assume to do 'new WebKitShadowRoot(host)'


Modified: trunk/Source/WebCore/html/HTMLStyleElement.h (108037 => 108038)

--- trunk/Source/WebCore/html/HTMLStyleElement.h	2012-02-17 07:10:12 UTC (rev 108037)
+++ trunk/Source/WebCore/html/HTMLStyleElement.h	2012-02-17 07:20:12 UTC (rev 108038)
@@ -74,7 +74,9 @@
 void registerWithScopingNode();
 void unregisterWithScopingNode();
 
+#if ENABLE(STYLE_SCOPED)
 bool m_isRegisteredWithScopingNode;
+#endif
 };
 
 } //namespace






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [108035] trunk

[shinyak]

Title: [108035] trunk








Revision 108035
Author shin...@chromium.org
Date 2012-02-16 22:42:02 -0800 (Thu, 16 Feb 2012)


Log Message
[v8] v8 doesn't assume to do 'new WebKitShadowRoot(host)'
https://bugs.webkit.org/show_bug.cgi?id=78875

Reviewed by Kentaro Hara.

Source/WebCore:

Since v8 does not assume that we do 'new WebkitShadowRoot(host)', a wrapper object for new WebKitShadowRoot(host)
was saved in DOMObject storage instead of DOMNode storage.

CodeGenerator should handle with DOMNode correctly to solve the problem.

Test: fast/dom/shadow/shadow-root-new.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):

LayoutTests:

Skip non-chromium ports since SHADOW_DOM flag is not enabled in their ports.

* fast/dom/shadow/shadow-root-new.html: Added.
* fast/dom/shadow/shadow-root-new-expected.txt: Added.
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm


Added Paths

trunk/LayoutTests/fast/dom/shadow/shadow-root-new-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-root-new.html




Diff

Modified: trunk/LayoutTests/ChangeLog (108034 => 108035)

--- trunk/LayoutTests/ChangeLog	2012-02-17 06:35:46 UTC (rev 108034)
+++ trunk/LayoutTests/ChangeLog	2012-02-17 06:42:02 UTC (rev 108035)
@@ -1,3 +1,22 @@
+2012-02-16  Shinya Kawanaka  
+
+[v8] v8 doesn't assume to do 'new WebKitShadowRoot(host)'
+https://bugs.webkit.org/show_bug.cgi?id=78875
+
+Reviewed by Kentaro Hara.
+
+Skip non-chromium ports since SHADOW_DOM flag is not enabled in their ports.
+
+* fast/dom/shadow/shadow-root-new.html: Added.
+* fast/dom/shadow/shadow-root-new-expected.txt: Added.
+* platform/efl/Skipped:
+* platform/gtk/Skipped:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+* platform/wincairo/Skipped:
+* platform/wk2/Skipped:
+
 2012-02-16  Ilya Tikhonovsky  
 
 Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac. 


Added: trunk/LayoutTests/fast/dom/shadow/shadow-root-new-expected.txt (0 => 108035)

--- trunk/LayoutTests/fast/dom/shadow/shadow-root-new-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-root-new-expected.txt	2012-02-17 06:42:02 UTC (rev 108035)
@@ -0,0 +1,7 @@
+This test checks the object 'new WebKitShadowRoot(host)' and internals.shadowRoot(div) are the same.
+
+PASS root1 is root2
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/shadow/shadow-root-new.html (0 => 108035)

--- trunk/LayoutTests/fast/dom/shadow/shadow-root-new.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-root-new.html	2012-02-17 06:42:02 UTC (rev 108035)
@@ -0,0 +1,30 @@
+
+
+
+
+
+
This test checks the object 'new WebKitShadowRoot(host)' and internals.shadowRoot(div) are the same.
+

+
+