[webkit-changes] [109202] trunk/LayoutTests
Title: [109202] trunk/LayoutTests Revision 109202 Author o...@webkit.org Date 2012-02-29 00:02:22 -0800 (Wed, 29 Feb 2012) Log Message [Qt] Unreviewed morning gardening, skip new failing tests. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (109201 => 109202) --- trunk/LayoutTests/ChangeLog 2012-02-29 07:31:00 UTC (rev 109201) +++ trunk/LayoutTests/ChangeLog 2012-02-29 08:02:22 UTC (rev 109202) @@ -1,3 +1,9 @@ +2012-02-28 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed morning gardening, skip new failing tests. + +* platform/qt/Skipped: + 2012-02-28 Kenichi Ishibashi ba...@chromium.org [Chromium] Unreviewed test expectations update. Modified: trunk/LayoutTests/platform/qt/Skipped (109201 => 109202) --- trunk/LayoutTests/platform/qt/Skipped 2012-02-29 07:31:00 UTC (rev 109201) +++ trunk/LayoutTests/platform/qt/Skipped 2012-02-29 08:02:22 UTC (rev 109202) @@ -159,10 +159,13 @@ fast/css/style-scoped # ENABLE(SHADOW_DOM) is disabled. +fast/dom/shadow/access-key.html fast/dom/shadow/content-element-api.html fast/dom/shadow/content-element-outside-shadow.html fast/dom/shadow/content-element-outside-shadow-style.html +fast/dom/shadow/get-element-by-id-in-shadow-root.html fast/dom/shadow/iframe-shadow.html +fast/dom/shadow/shadow-boundary-events.html fast/dom/shadow/shadow-root-js-api.html fast/dom/shadow/shadow-disable.html fast/dom/shadow/shadow-on-image.html @@ -349,7 +352,7 @@ http/tests/local/fileapi http/tests/security/drag-drop-same-unique-origin.html -# [Qt] DumpRenderTree needs a beginDragWithFiles implementation +# [Qt] DumpRenderTree needs eventSender.beginDragWithFiles() implementation # https://bugs.webkit.org/show_bug.cgi?id=50902 editing/pasteboard/dataTransfer-setData-getData.html editing/pasteboard/file-drag-to-editable.html @@ -359,6 +362,7 @@ fast/events/drag-file-crash.html fast/events/drag-to-navigate.html fast/events/prevent-drag-to-navigate.html +fast/files/file-reader-directory-crash.html fast/forms/file/file-input-change-event.html fast/forms/file/file-input-reset.html fast/forms/file/get-file-upload.html @@ -2647,3 +2651,7 @@ # [Qt] transitions/cancel-transition.html fails # https://bugs.webkit.org/show_bug.cgi?id=79564 transitions/cancel-transition.html + +# REGRESSION, r109105 made it fail +# https://bugs.webkit.org/show_bug.cgi?id=79555 +fast/events/dispatch-message-string-data.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109203] trunk/Source/WebCore
Title: [109203] trunk/Source/WebCore
Revision 109203
Author morr...@google.com
Date 2012-02-29 00:07:16 -0800 (Wed, 29 Feb 2012)
Log Message
[Refactoring] Shadow related attach paths should be in ShadowTree.
https://bugs.webkit.org/show_bug.cgi?id=79854
Reviewed by Ryosuke Niwa.
No new tests. No behavior change.
This change introduces ShadowTree::attachHost() and ShadowTree::detachHost()
and moves shadow-enabled attachment code from Element to ShadowRoot.
This also factored out small ContainerNode method to use it from ShadowTree.
Even after this change, the traveral order in ShadowTree
attachment has some unclear part. Coming changes will clarify
these. This change is aimed to be purely textural.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::attach):
(WebCore::ContainerNode::detach):
* dom/ContainerNode.h:
(ContainerNode):
(WebCore::ContainerNode::attachAsNode): Added.
(WebCore::ContainerNode::attachChildren): Added.
(WebCore::ContainerNode::attachChildrenIfNeeded): Added.
(WebCore::ContainerNode::attachChildrenLazily): Added.
(WebCore::ContainerNode::detachAsNode): Added.
(WebCore::ContainerNode::detachChildrenIfNeeded): Added.
(WebCore::ContainerNode::detachChildren): Added.
* dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::addShadowRoot):
(WebCore::ShadowTree::removeAllShadowRoots):
(WebCore::ShadowTree::detachHost):
(WebCore):
(WebCore::ShadowTree::attachHost):
(WebCore::ShadowTree::reattachHostChildrenAndShadow):
* dom/ShadowTree.h:
(ShadowTree):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/ShadowTree.cpp
trunk/Source/WebCore/dom/ShadowTree.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109202 => 109203)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 08:02:22 UTC (rev 109202)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 08:07:16 UTC (rev 109203)
@@ -1,3 +1,45 @@
+2012-02-28 MORITA Hajime morr...@google.com
+
+[Refactoring] Shadow related attach paths should be in ShadowTree.
+https://bugs.webkit.org/show_bug.cgi?id=79854
+
+Reviewed by Ryosuke Niwa.
+
+No new tests. No behavior change.
+
+This change introduces ShadowTree::attachHost() and ShadowTree::detachHost()
+and moves shadow-enabled attachment code from Element to ShadowRoot.
+This also factored out small ContainerNode method to use it from ShadowTree.
+
+Even after this change, the traveral order in ShadowTree
+attachment has some unclear part. Coming changes will clarify
+these. This change is aimed to be purely textural.
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::attach):
+(WebCore::ContainerNode::detach):
+* dom/ContainerNode.h:
+(ContainerNode):
+(WebCore::ContainerNode::attachAsNode): Added.
+(WebCore::ContainerNode::attachChildren): Added.
+(WebCore::ContainerNode::attachChildrenIfNeeded): Added.
+(WebCore::ContainerNode::attachChildrenLazily): Added.
+(WebCore::ContainerNode::detachAsNode): Added.
+(WebCore::ContainerNode::detachChildrenIfNeeded): Added.
+(WebCore::ContainerNode::detachChildren): Added.
+* dom/Element.cpp:
+(WebCore::Element::attach):
+(WebCore::Element::detach):
+* dom/ShadowTree.cpp:
+(WebCore::ShadowTree::addShadowRoot):
+(WebCore::ShadowTree::removeAllShadowRoots):
+(WebCore::ShadowTree::detachHost):
+(WebCore):
+(WebCore::ShadowTree::attachHost):
+(WebCore::ShadowTree::reattachHostChildrenAndShadow):
+* dom/ShadowTree.h:
+(ShadowTree):
+
2012-02-28 Arko Saha a...@motorola.com
Microdata: Implement HTMLPropertiesCollection collection.namedItem().
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (109202 => 109203)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2012-02-29 08:02:22 UTC (rev 109202)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2012-02-29 08:07:16 UTC (rev 109203)
@@ -766,15 +766,13 @@
void ContainerNode::attach()
{
-for (Node* child = m_firstChild; child; child = child-nextSibling())
-child-attach();
+attachChildren();
Node::attach();
}
void ContainerNode::detach()
{
-for (Node* child = m_firstChild; child; child = child-nextSibling())
-child-detach();
+detachChildren();
clearChildNeedsStyleRecalc();
Node::detach();
}
Modified: trunk/Source/WebCore/dom/ContainerNode.h (109202 => 109203)
--- trunk/Source/WebCore/dom/ContainerNode.h 2012-02-29 08:02:22 UTC (rev 109202)
+++ trunk/Source/WebCore/dom/ContainerNode.h 2012-02-29 08:07:16 UTC (rev 109203)
@@ -94,6 +94,14 @@
// node that is of the type CDATA_SECTION_NODE, TEXT_NODE or COMMENT_NODE has changed its value.
virtual void
[webkit-changes] [109204] trunk
Title: [109204] trunk Revision 109204 Author yu...@chromium.org Date 2012-02-29 00:29:38 -0800 (Wed, 29 Feb 2012) Log Message 2012-02-28 Yury Semikhatsky yu...@chromium.org Web Inspector: move DOM counter graphs out of experimental https://bugs.webkit.org/show_bug.cgi?id=79802 Enable DOM counter graphs by default. Reveal nearest record from the left hand side when there is no record containing the point where the user clicked. Reviewed by Pavel Feldman. * inspector/front-end/Settings.js: (WebInspector.ExperimentsSettings): * inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._endSplitterDragging): (WebInspector.TimelinePanel.prototype._onTimelineEventRecorded): (WebInspector.TimelinePanel.prototype.sidebarResized): (WebInspector.TimelinePanel.prototype._resetPanel): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype.revealRecordAt): 2012-02-29 Yury Semikhatsky yu...@chromium.org Web Inspector: move DOM counter graphs out of experimental https://bugs.webkit.org/show_bug.cgi?id=79802 Enable DOM counter graphs by default. Rebase timeline tests so that the records include counters field. Reviewed by Pavel Feldman. * inspector/timeline/timeline-dom-content-loaded-event-expected.txt: * inspector/timeline/timeline-event-dispatch-expected.txt: * inspector/timeline/timeline-injected-script-eval-expected.txt: * inspector/timeline/timeline-layout-expected.txt: * inspector/timeline/timeline-load-event-expected.txt: * inspector/timeline/timeline-mark-timeline-expected.txt: * inspector/timeline/timeline-network-resource-expected.txt: * inspector/timeline/timeline-parse-html-expected.txt: * inspector/timeline/timeline-recalculate-styles-expected.txt: * inspector/timeline/timeline-script-tag-1-expected.txt: * inspector/timeline/timeline-script-tag-2-expected.txt: * inspector/timeline/timeline-test.js: * inspector/timeline/timeline-time-stamp-expected.txt: * platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt: * platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt: * platform/chromium/inspector/timeline/timeline-layout-expected.txt: * platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt: * platform/chromium/inspector/timeline/timeline-network-resource-expected.txt: * platform/chromium/inspector/timeline/timeline-paint-expected.txt: * platform/chromium/inspector/timeline/timeline-parse-html-expected.txt: * platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt trunk/LayoutTests/inspector/timeline/timeline-event-dispatch-expected.txt trunk/LayoutTests/inspector/timeline/timeline-injected-script-eval-expected.txt trunk/LayoutTests/inspector/timeline/timeline-layout-expected.txt trunk/LayoutTests/inspector/timeline/timeline-load-event-expected.txt trunk/LayoutTests/inspector/timeline/timeline-mark-timeline-expected.txt trunk/LayoutTests/inspector/timeline/timeline-network-resource-expected.txt trunk/LayoutTests/inspector/timeline/timeline-parse-html-expected.txt trunk/LayoutTests/inspector/timeline/timeline-recalculate-styles-expected.txt trunk/LayoutTests/inspector/timeline/timeline-script-tag-1-expected.txt trunk/LayoutTests/inspector/timeline/timeline-script-tag-2-expected.txt trunk/LayoutTests/inspector/timeline/timeline-test.js trunk/LayoutTests/inspector/timeline/timeline-time-stamp-expected.txt trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-layout-expected.txt trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-network-resource-expected.txt trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-paint-expected.txt trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-parse-html-expected.txt trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/Settings.js trunk/Source/WebCore/inspector/front-end/TimelinePanel.js Diff Modified: trunk/LayoutTests/ChangeLog (109203 => 109204) --- trunk/LayoutTests/ChangeLog 2012-02-29 08:07:16 UTC (rev 109203) +++ trunk/LayoutTests/ChangeLog 2012-02-29 08:29:38 UTC (rev 109204) @@ -1,3 +1,35 @@ +2012-02-29 Yury
[webkit-changes] [109205] trunk/Source/WebKit/efl
Title: [109205] trunk/Source/WebKit/efl Revision 109205 Author commit-qu...@webkit.org Date 2012-02-29 00:58:22 -0800 (Wed, 29 Feb 2012) Log Message [EFL] Replace malloc/calloc/free to new/delete. https://bugs.webkit.org/show_bug.cgi?id=75848 Patch by Tomasz Morawski t.moraw...@samsung.com on 2012-02-29 Reviewed by Hajime Morita. Replaced almost all malloc/calloc/free to new/delete operator and where it was possible smart pointers were also used. Left few c memory allocation by intention to not mix c and c++ memory managment. Left malloc for Ewk_Tile object due to const fields present in Ewk_tile structure. * ewk/ewk_auth_soup.cpp: * ewk/ewk_contextmenu.cpp: (ewk_context_menu_unref): (ewk_context_menu_item_new): (ewk_context_menu_item_free): (ewk_context_menu_new): * ewk/ewk_cookies.cpp: (ewk_cookies_get_all): (ewk_cookies_cookie_free): * ewk/ewk_frame.cpp: (ewk_frame_hit_test_free): (ewk_frame_hit_test_new): * ewk/ewk_history.cpp: (ewk_history_item_new_from_core): (_ewk_history_item_free): (ewk_history_new): (ewk_history_free): * ewk/ewk_tiled_backing_store.cpp: (_Ewk_Tiled_Backing_Store_Item): (_ewk_tiled_backing_store_pre_render_request_add): (_ewk_tiled_backing_store_pre_render_request_del): (_ewk_tiled_backing_store_pre_render_request_flush): (_ewk_tiled_backing_store_pre_render_request_clear): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del): * ewk/ewk_tiled_matrix.cpp: (_ewk_tile_matrix_tile_free): (ewk_tile_matrix_new): (ewk_tile_matrix_zoom_level_set): (ewk_tile_matrix_invalidate): (ewk_tile_matrix_free): * ewk/ewk_tiled_model.cpp: (tile_account): (ewk_tile_unused_cache_new): (_ewk_tile_unused_cache_free): (ewk_tile_unused_cache_clear): (ewk_tile_unused_cache_flush): (ewk_tile_unused_cache_tile_get): (ewk_tile_unused_cache_tile_put): * ewk/ewk_tiled_private.h: * ewk/ewk_view.cpp: (_Ewk_View_Private_Data): (_ewk_view_core_frame_new): (_ewk_view_priv_new): (_ewk_view_priv_del): (ewk_view_core_page_get): (ewk_view_popup_new): (ewk_view_popup_destroy): (EWKPrivate::corePage): * ewk/ewk_window_features.cpp: (ewk_window_features_unref): (ewk_window_features_new_from_core): Modified Paths trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/ewk/ewk_auth_soup.cpp trunk/Source/WebKit/efl/ewk/ewk_contextmenu.cpp trunk/Source/WebKit/efl/ewk/ewk_cookies.cpp trunk/Source/WebKit/efl/ewk/ewk_frame.cpp trunk/Source/WebKit/efl/ewk/ewk_history.cpp trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp trunk/Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp trunk/Source/WebKit/efl/ewk/ewk_tiled_model.cpp trunk/Source/WebKit/efl/ewk/ewk_tiled_private.h trunk/Source/WebKit/efl/ewk/ewk_view.cpp trunk/Source/WebKit/efl/ewk/ewk_window_features.cpp Diff Modified: trunk/Source/WebKit/efl/ChangeLog (109204 => 109205) --- trunk/Source/WebKit/efl/ChangeLog 2012-02-29 08:29:38 UTC (rev 109204) +++ trunk/Source/WebKit/efl/ChangeLog 2012-02-29 08:58:22 UTC (rev 109205) @@ -1,3 +1,67 @@ +2012-02-29 Tomasz Morawski t.moraw...@samsung.com + +[EFL] Replace malloc/calloc/free to new/delete. +https://bugs.webkit.org/show_bug.cgi?id=75848 + +Reviewed by Hajime Morita. + +Replaced almost all malloc/calloc/free to new/delete operator and where it was possible smart pointers were also +used. Left few c memory allocation by intention to not mix c and c++ memory managment. Left malloc for Ewk_Tile +object due to const fields present in Ewk_tile structure. + +* ewk/ewk_auth_soup.cpp: +* ewk/ewk_contextmenu.cpp: +(ewk_context_menu_unref): +(ewk_context_menu_item_new): +(ewk_context_menu_item_free): +(ewk_context_menu_new): +* ewk/ewk_cookies.cpp: +(ewk_cookies_get_all): +(ewk_cookies_cookie_free): +* ewk/ewk_frame.cpp: +(ewk_frame_hit_test_free): +(ewk_frame_hit_test_new): +* ewk/ewk_history.cpp: +(ewk_history_item_new_from_core): +(_ewk_history_item_free): +(ewk_history_new): +(ewk_history_free): +* ewk/ewk_tiled_backing_store.cpp: +(_Ewk_Tiled_Backing_Store_Item): +(_ewk_tiled_backing_store_pre_render_request_add): +(_ewk_tiled_backing_store_pre_render_request_del): +(_ewk_tiled_backing_store_pre_render_request_flush): +(_ewk_tiled_backing_store_pre_render_request_clear): +(_ewk_tiled_backing_store_item_add): +(_ewk_tiled_backing_store_item_del): +* ewk/ewk_tiled_matrix.cpp: +(_ewk_tile_matrix_tile_free): +(ewk_tile_matrix_new): +(ewk_tile_matrix_zoom_level_set): +(ewk_tile_matrix_invalidate): +(ewk_tile_matrix_free): +* ewk/ewk_tiled_model.cpp: +(tile_account): +(ewk_tile_unused_cache_new): +(_ewk_tile_unused_cache_free): +(ewk_tile_unused_cache_clear): +(ewk_tile_unused_cache_flush): +(ewk_tile_unused_cache_tile_get): +
[webkit-changes] [109206] trunk/Tools
Title: [109206] trunk/Tools
Revision 109206
Author rga...@webkit.org
Date 2012-02-29 04:33:16 -0800 (Wed, 29 Feb 2012)
Log Message
[GTK] Small fix for cross compilation to not generate gtkdoc.
Rubber-stamped by Csaba Osztrogonác.
* Scripts/webkitdirs.pm:
(isCrossCompilation):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (109205 => 109206)
--- trunk/Tools/ChangeLog 2012-02-29 08:58:22 UTC (rev 109205)
+++ trunk/Tools/ChangeLog 2012-02-29 12:33:16 UTC (rev 109206)
@@ -1,3 +1,12 @@
+2012-02-29 Gabor Rapcsanyi rga...@webkit.org
+
+[GTK] Small fix for cross compilation to not generate gtkdoc.
+
+Rubber-stamped by Csaba Osztrogonác.
+
+* Scripts/webkitdirs.pm:
+(isCrossCompilation):
+
2012-02-28 Lucas Forschler lforsch...@apple.com
Fix a typo in config.json
Modified: trunk/Tools/Scripts/webkitdirs.pm (109205 => 109206)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-02-29 08:58:22 UTC (rev 109205)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-02-29 12:33:16 UTC (rev 109206)
@@ -1264,7 +1264,8 @@
sub isCrossCompilation()
{
- my $compiler = unless $ENV{'CC'};
+ my $compiler = ;
+ $compiler = $ENV{'CC'} if (defined($ENV{'CC'}));
if ($compiler =~ /gcc/) {
my $compiler_options = `$compiler -v 21`;
my @host = $compiler_options =~ m/--host=(.*?)\s/;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109207] trunk/LayoutTests
Title: [109207] trunk/LayoutTests Revision 109207 Author o...@webkit.org Date 2012-02-29 04:41:45 -0800 (Wed, 29 Feb 2012) Log Message [Qt] Unreviewed gardening, skip more failing tests. * platform/qt-5.0/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-5.0/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (109206 => 109207) --- trunk/LayoutTests/ChangeLog 2012-02-29 12:33:16 UTC (rev 109206) +++ trunk/LayoutTests/ChangeLog 2012-02-29 12:41:45 UTC (rev 109207) @@ -1,3 +1,9 @@ +2012-02-29 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed gardening, skip more failing tests. + +* platform/qt-5.0/Skipped: + 2012-02-29 Yury Semikhatsky yu...@chromium.org Web Inspector: move DOM counter graphs out of experimental Modified: trunk/LayoutTests/platform/qt-5.0/Skipped (109206 => 109207) --- trunk/LayoutTests/platform/qt-5.0/Skipped 2012-02-29 12:33:16 UTC (rev 109206) +++ trunk/LayoutTests/platform/qt-5.0/Skipped 2012-02-29 12:41:45 UTC (rev 109207) @@ -89,3 +89,13 @@ # https://bugs.webkit.org/show_bug.cgi?id=79634 editing/selection/vertical-rl-rtl-extend-line-forward-br.html editing/selection/vertical-rl-rtl-extend-line-forward-p.html + +# [Qt] New tests introduced in r109104 fails with Qt5 +# https://bugs.webkit.org/show_bug.cgi?id=79888 +fast/repaint/percent-minheight-resize.html +svg/custom/svg-percent-scale-vonly.html +svg/custom/svg-percent-scale.html + +# [Qt] fast/selectors/selection-window-inactive.html fails with Qt5 +# https://bugs.webkit.org/show_bug.cgi?id=79890 +fast/selectors/selection-window-inactive.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109210] trunk/Source/WebCore
Title: [109210] trunk/Source/WebCore
Revision 109210
Author podivi...@chromium.org
Date 2012-02-29 07:24:18 -0800 (Wed, 29 Feb 2012)
Log Message
Extended attributes list should go before 'static' and 'const' modifiers in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=79807
Reviewed by Kentaro Hara.
No new tests. Generated code isn't changed.
* bindings/scripts/IDLParser.pm:
(ParseInterface):
* bindings/scripts/IDLStructure.pm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestSupplemental.idl:
* html/DOMURL.idl:
* html/HTMLMediaElement.idl:
* html/HTMLTrackElement.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/IDLParser.pm
trunk/Source/WebCore/bindings/scripts/IDLStructure.pm
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/TestSupplemental.idl
trunk/Source/WebCore/html/DOMURL.idl
trunk/Source/WebCore/html/HTMLMediaElement.idl
trunk/Source/WebCore/html/HTMLTrackElement.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (109209 => 109210)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 15:13:34 UTC (rev 109209)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 15:24:18 UTC (rev 109210)
@@ -1,3 +1,21 @@
+2012-02-28 Pavel Podivilov podivi...@chromium.org
+
+Extended attributes list should go before 'static' and 'const' modifiers in IDLs.
+https://bugs.webkit.org/show_bug.cgi?id=79807
+
+Reviewed by Kentaro Hara.
+
+No new tests. Generated code isn't changed.
+
+* bindings/scripts/IDLParser.pm:
+(ParseInterface):
+* bindings/scripts/IDLStructure.pm:
+* bindings/scripts/test/TestObj.idl:
+* bindings/scripts/test/TestSupplemental.idl:
+* html/DOMURL.idl:
+* html/HTMLMediaElement.idl:
+* html/HTMLTrackElement.idl:
+
2012-02-28 Yury Semikhatsky yu...@chromium.org
Web Inspector: move DOM counter graphs out of experimental
Modified: trunk/Source/WebCore/bindings/scripts/IDLParser.pm (109209 => 109210)
--- trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2012-02-29 15:13:34 UTC (rev 109209)
+++ trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2012-02-29 15:24:18 UTC (rev 109210)
@@ -326,6 +326,7 @@
my @interfaceMethods = split(/;/, $interfaceData);
foreach my $line (@interfaceMethods) {
+next if $line =~ /^\s*$/;
if ($line =~ /\Wattribute\W/) {
$line =~ /$IDLStructure::interfaceAttributeSelector/;
@@ -361,11 +362,11 @@
$setterException =~ s/\s+//g;
@{$newDataNode-getterExceptions} = split(/,/, $getterException);
@{$newDataNode-setterExceptions} = split(/,/, $setterException);
-} elsif (($line !~ s/^\s*$//g) and ($line !~ /^\s*const/)) {
+} elsif ($line !~ /^\s*($IDLStructure::extendedAttributeSyntax )?const\s+/) {
$line =~ /$IDLStructure::interfaceMethodSelector/ or die Parsing error!\nSource:\n$line\n);
-my $isStatic = defined($1);
-my $methodExtendedAttributes = (defined($2) ? $2 : ); chop($methodExtendedAttributes);
+my $methodExtendedAttributes = (defined($1) ? $1 : ); chop($methodExtendedAttributes);
+my $isStatic = defined($2);
my $methodType = (defined($3) ? $3 : die(Parsing error!\nSource:\n$line\n)));
my $methodName = (defined($4) ? $4 : die(Parsing error!\nSource:\n$line\n)));
my $methodSignature = (defined($5) ? $5 : die(Parsing error!\nSource:\n$line\n)));
@@ -393,7 +394,7 @@
my $arrayRef = $dataNode-functions;
push(@$arrayRef, $newDataNode);
-} elsif ($line =~ /^\s*const/) {
+} else {
$line =~ /$IDLStructure::constantSelector/;
my $constExtendedAttributes = (defined($1) ? $1 : ); chop($constExtendedAttributes);
my $constType = (defined($2) ? $2 : die(Parsing error!\nSource:\n$line\n)));
Modified: trunk/Source/WebCore/bindings/scripts/IDLStructure.pm (109209 => 109210)
--- trunk/Source/WebCore/bindings/scripts/IDLStructure.pm 2012-02-29 15:13:34 UTC (rev 109209)
+++ trunk/Source/WebCore/bindings/scripts/IDLStructure.pm 2012-02-29 15:24:18 UTC (rev 109210)
@@ -96,7 +96,7 @@
# Regular _expression_ based IDL 'syntactical tokenizer' used in the IDLParser
our $moduleSelector = 'module\s*(' . $idlId . '*)\s*{';
our $moduleNSSelector = 'module\s*(' . $idlId . '*)\s*\[ns\s*(' . $idlIdNs . '*)\s*(' . $idlIdNs . '*)\]\s*;';
-our $constantSelector = 'const\s*(' . $extendedAttributeSyntax . ' )?' . $supportedTypes . '\s*(' . $idlType . '*)\s*=\s*(' . $constValue . ')';
+our $constantSelector = '(' . $extendedAttributeSyntax . ' )?const\s+' . $supportedTypes . '\s*(' . $idlType . '*)\s*=\s*(' . $constValue . ')';
our $raisesSelector = 'raises\s*\((' . $idlIdNsList . '*)\s*\)';
our
[webkit-changes] [109211] trunk/Source/WebCore
Title: [109211] trunk/Source/WebCore
Revision 109211
Author pfeld...@chromium.org
Date 2012-02-29 07:26:10 -0800 (Wed, 29 Feb 2012)
Log Message
Web Inspector: Ctrl R should reload page from the console panel as well.
https://bugs.webkit.org/show_bug.cgi?id=79883
Reviewed by Vsevolod Vlasov.
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (109210 => 109211)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 15:24:18 UTC (rev 109210)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 15:26:10 UTC (rev 109211)
@@ -1,3 +1,13 @@
+2012-02-29 Pavel Feldman pfeld...@google.com
+
+Web Inspector: Ctrl R should reload page from the console panel as well.
+https://bugs.webkit.org/show_bug.cgi?id=79883
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/inspector.js:
+(WebInspector.documentKeyDown):
+
2012-02-28 Pavel Podivilov podivi...@chromium.org
Extended attributes list should go before 'static' and 'const' modifiers in IDLs.
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (109210 => 109211)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2012-02-29 15:24:18 UTC (rev 109210)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2012-02-29 15:26:10 UTC (rev 109211)
@@ -709,15 +709,13 @@
}
break;
case U+0052: // R key
-if (WebInspector.isInEditMode(event))
-return;
if ((event.metaKey isMac) || (event.ctrlKey !isMac)) {
PageAgent.reload(event.shiftKey);
event.preventDefault();
}
break;
case F5:
-if (!isMac !WebInspector.isInEditMode(event)) {
+if (!isMac) {
PageAgent.reload(event.ctrlKey || event.shiftKey);
event.preventDefault();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109212] trunk
Title: [109212] trunk
Revision 109212
Author apav...@chromium.org
Date 2012-02-29 07:28:23 -0800 (Wed, 29 Feb 2012)
Log Message
Web Inspector: Clicking relative links fails when query string contains a slash
https://bugs.webkit.org/show_bug.cgi?id=79905
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* inspector/front-end/ResourceUtils.js:
(WebInspector.completeURL):
LayoutTests:
* inspector/styles/styles-url-linkify-expected.txt:
* inspector/styles/styles-url-linkify.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt
trunk/LayoutTests/inspector/styles/styles-url-linkify.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ResourceUtils.js
Diff
Modified: trunk/LayoutTests/ChangeLog (109211 => 109212)
--- trunk/LayoutTests/ChangeLog 2012-02-29 15:26:10 UTC (rev 109211)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 15:28:23 UTC (rev 109212)
@@ -1,3 +1,13 @@
+2012-02-29 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: Clicking relative links fails when query string contains a slash
+https://bugs.webkit.org/show_bug.cgi?id=79905
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/styles/styles-url-linkify-expected.txt:
+* inspector/styles/styles-url-linkify.html:
+
2012-02-29 Nikolas Zimmermann nzimmerm...@rim.com
Not reviewed. Next chunk of SL pixel test updates.
Modified: trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt (109211 => 109212)
--- trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt 2012-02-29 15:26:10 UTC (rev 109211)
+++ trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt 2012-02-29 15:28:23 UTC (rev 109212)
@@ -1,4 +1,4 @@
-Tests that URLs are linked to and completed correctly. Bugs 51663, 53171, 62643, 72373
+Tests that URLs are linked to and completed correctly. Bugs 51663, 53171, 62643, 72373, 79905
URLs completed:
@@ -11,7 +11,13 @@
http://example.com/foo/boo/moo
http://example.com/moo
http://example.com/foo?a=b
+http://example.com/foo?a=/b
+http://example.com/?a=/b
http://example.com/foo?a=b
+http://example.com/foo?a=/b
+http://example.com/foo?a=b
+http://example.com/cat.jpeg
+http://example.com/cat.jpeg
data:image/png;base64,iVBORw0KGgoNSUhEUgAAAEIAAABCAgMAAACeOuh7BGdBTUEAAK/INwWK6QlQTFRFfu+PTwF0Uk5TAEDm2GYAAACHSURBVDjLxdLbDYAgDAVQGELn0R3oEHYf2KGdUqtE46OFRCP3oyTng1xCnWsaD5JRRtCkQ2YmkBkHRXqWJBn0j0TICbrsWVoWhRShCdcGyZCtHxMaUnVPRZ9KSbmBJdsX2vJVnwqRD0Rb4rpzgIbE/AI5NTnWAMvy5l0dXrfuLh5OCe5BmmYGXhTUxlQ5xJ8ASUVORK5CYII=
_javascript_:alert('foo');
null
Modified: trunk/LayoutTests/inspector/styles/styles-url-linkify.html (109211 => 109212)
--- trunk/LayoutTests/inspector/styles/styles-url-linkify.html 2012-02-29 15:26:10 UTC (rev 109211)
+++ trunk/LayoutTests/inspector/styles/styles-url-linkify.html 2012-02-29 15:28:23 UTC (rev 109212)
@@ -23,7 +23,13 @@
completeURL(http://example.com/foo/zoo, boo/moo);
completeURL(http://example.com/foo, moo);
completeURL(http://example.com/foo, ?a=b);
+completeURL(http://example.com/foo, ?a=/b);
+completeURL(http://example.com/?c=/d#anchor, ?a=/b);
completeURL(http://example.com/foo?c=d, ?a=b);
+completeURL(http://example.com/foo?c=d#anchor, ?a=/b);
+completeURL(http://example.com/foo?c=/d/e, ?a=b);
+completeURL(http://example.com/foo?c=/d/e, cat.jpeg);
+completeURL(http://example.com/foo#anchor, cat.jpeg);
const dataURL = data:image/png;base64,iVBORw0KGgoNSUhEUgAAAEIAAABCAgMAAACeOuh7BGdBTUEAAK/INwWK6QlQTFRFfu+PTwF0Uk5TAEDm2GYAAACHSURBVDjLxdLbDYAgDAVQGELn0R3oEHYf2KGdUqtE46OFRCP3oyTng1xCnWsaD5JRRtCkQ2YmkBkHRXqWJBn0j0TICbrsWVoWhRShCdcGyZCtHxMaUnVPRZ9KSbmBJdsX2vJVnwqRD0Rb4rpzgIbE/AI5NTnWAMvy5l0dXrfuLh5OCe5BmmYGXhTUxlQ5xJ8ASUVORK5CYII=;
completeURL(https://example.com/foo, dataURL);
@@ -83,7 +89,7 @@
/head
body _onload_=runAfterIframeIsLoaded()
p
-Tests that URLs are linked to and completed correctly. Bugs a href="" a href="" a href="" a href=""
+Tests that URLs are linked to and completed correctly. Bugs a href="" a href="" a href="" a href="" a href=""
/p
div id=local/div
iframe src=""
Modified: trunk/Source/WebCore/ChangeLog (109211 => 109212)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 15:26:10 UTC (rev 109211)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 15:28:23 UTC (rev 109212)
@@ -1,3 +1,13 @@
+2012-02-29 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: Clicking relative links fails when query string contains a slash
+https://bugs.webkit.org/show_bug.cgi?id=79905
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/ResourceUtils.js:
+(WebInspector.completeURL):
+
2012-02-29 Pavel Feldman pfeld...@google.com
Web Inspector: Ctrl R should reload page from the console panel as well.
Modified:
[webkit-changes] [109214] trunk/Source/WebCore
Title: [109214] trunk/Source/WebCore Revision 109214 Author yu...@chromium.org Date 2012-02-29 07:42:10 -0800 (Wed, 29 Feb 2012) Log Message Web Inspector: enable Profiles panel for workers https://bugs.webkit.org/show_bug.cgi?id=79908 Introduced worker profiler agent. Enabled script profiling for workers. Reviewed by Pavel Feldman. * bindings/js/ScriptProfiler.cpp: (WebCore::ScriptProfiler::startForPage): (WebCore): (WebCore::ScriptProfiler::startForWorkerContext): (WebCore::ScriptProfiler::stopForPage): (WebCore::ScriptProfiler::stopForWorkerContext): * bindings/js/ScriptProfiler.h: (WebCore): (ScriptProfiler): * bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::startForPage): (WebCore): (WebCore::ScriptProfiler::startForWorkerContext): (WebCore::ScriptProfiler::stopForPage): (WebCore::ScriptProfiler::stopForWorkerContext): * bindings/v8/ScriptProfiler.h: (WebCore): (ScriptProfiler): * inspector/InspectorProfilerAgent.cpp: (WebCore): (PageProfilerAgent): (WebCore::PageProfilerAgent::PageProfilerAgent): (WebCore::PageProfilerAgent::~PageProfilerAgent): (WebCore::PageProfilerAgent::startProfiling): (WebCore::PageProfilerAgent::stopProfiling): (WebCore::InspectorProfilerAgent::create): (WorkerProfilerAgent): (WebCore::WorkerProfilerAgent::WorkerProfilerAgent): (WebCore::WorkerProfilerAgent::~WorkerProfilerAgent): (WebCore::WorkerProfilerAgent::startProfiling): (WebCore::WorkerProfilerAgent::stopProfiling): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::start): (WebCore::InspectorProfilerAgent::stop): * inspector/InspectorProfilerAgent.h: (WebCore): (InspectorProfilerAgent): * inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::WorkerInspectorController): (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend): (WebCore::WorkerInspectorController::restoreInspectorStateFromCookie): * inspector/WorkerInspectorController.h: (WebCore): (WorkerInspectorController): * inspector/front-end/ProfilesPanel.js: * inspector/front-end/inspector.js: (WebInspector._createPanels): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/ScriptProfiler.cpp trunk/Source/WebCore/bindings/js/ScriptProfiler.h trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp trunk/Source/WebCore/bindings/v8/ScriptProfiler.h trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp trunk/Source/WebCore/inspector/InspectorProfilerAgent.h trunk/Source/WebCore/inspector/WorkerInspectorController.cpp trunk/Source/WebCore/inspector/WorkerInspectorController.h trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js trunk/Source/WebCore/inspector/front-end/inspector.js Diff Modified: trunk/Source/WebCore/ChangeLog (109213 => 109214) --- trunk/Source/WebCore/ChangeLog 2012-02-29 15:36:29 UTC (rev 109213) +++ trunk/Source/WebCore/ChangeLog 2012-02-29 15:42:10 UTC (rev 109214) @@ -1,3 +1,62 @@ +2012-02-29 Yury Semikhatsky yu...@chromium.org + +Web Inspector: enable Profiles panel for workers +https://bugs.webkit.org/show_bug.cgi?id=79908 + +Introduced worker profiler agent. Enabled script profiling for +workers. + +Reviewed by Pavel Feldman. + +* bindings/js/ScriptProfiler.cpp: +(WebCore::ScriptProfiler::startForPage): +(WebCore): +(WebCore::ScriptProfiler::startForWorkerContext): +(WebCore::ScriptProfiler::stopForPage): +(WebCore::ScriptProfiler::stopForWorkerContext): +* bindings/js/ScriptProfiler.h: +(WebCore): +(ScriptProfiler): +* bindings/v8/ScriptProfiler.cpp: +(WebCore::ScriptProfiler::startForPage): +(WebCore): +(WebCore::ScriptProfiler::startForWorkerContext): +(WebCore::ScriptProfiler::stopForPage): +(WebCore::ScriptProfiler::stopForWorkerContext): +* bindings/v8/ScriptProfiler.h: +(WebCore): +(ScriptProfiler): +* inspector/InspectorProfilerAgent.cpp: +(WebCore): +(PageProfilerAgent): +(WebCore::PageProfilerAgent::PageProfilerAgent): +(WebCore::PageProfilerAgent::~PageProfilerAgent): +(WebCore::PageProfilerAgent::startProfiling): +(WebCore::PageProfilerAgent::stopProfiling): +(WebCore::InspectorProfilerAgent::create): +(WorkerProfilerAgent): +(WebCore::WorkerProfilerAgent::WorkerProfilerAgent): +(WebCore::WorkerProfilerAgent::~WorkerProfilerAgent): +(WebCore::WorkerProfilerAgent::startProfiling): +(WebCore::WorkerProfilerAgent::stopProfiling): +(WebCore::InspectorProfilerAgent::InspectorProfilerAgent): +(WebCore::InspectorProfilerAgent::start): +(WebCore::InspectorProfilerAgent::stop): +* inspector/InspectorProfilerAgent.h: +(WebCore): +(InspectorProfilerAgent): +* inspector/WorkerInspectorController.cpp: +
[webkit-changes] [109216] trunk/Source/WebCore
Title: [109216] trunk/Source/WebCore
Revision 109216
Author pfeld...@chromium.org
Date 2012-02-29 07:59:30 -0800 (Wed, 29 Feb 2012)
Log Message
Web Inspector: remove calculator's updateBoundaries in the timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=79907
Reviewed by Yury Semikhatsky.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkBaseCalculator.prototype.computeBarGraphLabels):
(WebInspector.NetworkBaseCalculator.prototype.formatTime):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphLabels):
(WebInspector.NetworkTimeCalculator.prototype.formatTime):
(WebInspector.NetworkTransferTimeCalculator.prototype.formatTime):
(WebInspector.NetworkTransferDurationCalculator.prototype.formatTime):
* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.updateDividers):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewCalculator.prototype.formatTime):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype.update):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype.get timelinePaddingLeft):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.setWindow):
(WebInspector.TimelineCalculator.prototype.setRecords):
(WebInspector.TimelineCalculator.prototype.formatTime):
(WebInspector.TimelineFitInWindowCalculator):
(WebInspector.TimelineFitInWindowCalculator.prototype.setWindow):
(WebInspector.TimelineFitInWindowCalculator.prototype.setRecords):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/TimelineGrid.js
trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (109215 => 109216)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 15:46:12 UTC (rev 109215)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 15:59:30 UTC (rev 109216)
@@ -1,3 +1,39 @@
+2012-02-29 Pavel Feldman pfeld...@google.com
+
+Web Inspector: remove calculator's updateBoundaries in the timeline panel.
+https://bugs.webkit.org/show_bug.cgi?id=79907
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkBaseCalculator.prototype.computeBarGraphLabels):
+(WebInspector.NetworkBaseCalculator.prototype.formatTime):
+(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphLabels):
+(WebInspector.NetworkTimeCalculator.prototype.formatTime):
+(WebInspector.NetworkTransferTimeCalculator.prototype.formatTime):
+(WebInspector.NetworkTransferDurationCalculator.prototype.formatTime):
+* inspector/front-end/TimelineGrid.js:
+(WebInspector.TimelineGrid.prototype.updateDividers):
+* inspector/front-end/TimelineOverviewPane.js:
+(WebInspector.TimelineOverviewCalculator.prototype.formatTime):
+(WebInspector.TimelineStartAtZeroOverview):
+(WebInspector.TimelineStartAtZeroOverview.prototype.update):
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelinePanel):
+(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
+(WebInspector.TimelinePanel.prototype._refresh):
+(WebInspector.TimelinePanel.prototype._refreshRecords):
+(WebInspector.TimelinePanel.prototype.get timelinePaddingLeft):
+(WebInspector.TimelineCalculator):
+(WebInspector.TimelineCalculator.prototype.setWindow):
+(WebInspector.TimelineCalculator.prototype.setRecords):
+(WebInspector.TimelineCalculator.prototype.formatTime):
+(WebInspector.TimelineFitInWindowCalculator):
+(WebInspector.TimelineFitInWindowCalculator.prototype.setWindow):
+(WebInspector.TimelineFitInWindowCalculator.prototype.setRecords):
+* inspector/front-end/TimelinePresentationModel.js:
+(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
+
2012-02-29 Yury Semikhatsky yu...@chromium.org
Web Inspector: enable Profiles panel for workers
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (109215 => 109216)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-02-29 15:46:12 UTC (rev 109215)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2012-02-29 15:59:30 UTC (rev 109216)
@@ -1451,7 +1451,7 @@
computeBarGraphLabels: function(item)
{
-
[webkit-changes] [109218] trunk
Title: [109218] trunk Revision 109218 Author commit-qu...@webkit.org Date 2012-02-29 08:43:31 -0800 (Wed, 29 Feb 2012) Log Message Crash in WebCore::CompositeEditCommand::insertNodeAt https://bugs.webkit.org/show_bug.cgi?id=67764 Patch by Parag Radke pa...@motorola.com on 2012-02-29 Reviewed by Ryosuke Niwa. Source/WebCore: If caret position after deletion and destination position coincides then removing the node will result in removing the destination node also. Hence crash. Test: editing/deleting/delete-block-merge-contents-025.html * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cleanupAfterDeletion): If the caret position after delete and the destination position renderes at the same place, pruning the node and making an early exit. LayoutTests: Added a test case to test deletion when caret position after deletion and destination postion renders at the same place. * editing/deleting/delete-block-merge-contents-025-expected.txt: Added. * editing/deleting/delete-block-merge-contents-025.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/CompositeEditCommand.cpp Added Paths trunk/LayoutTests/editing/deleting/delete-block-merge-contents-025-expected.txt trunk/LayoutTests/editing/deleting/delete-block-merge-contents-025.html Diff Modified: trunk/LayoutTests/ChangeLog (109217 => 109218) --- trunk/LayoutTests/ChangeLog 2012-02-29 16:08:57 UTC (rev 109217) +++ trunk/LayoutTests/ChangeLog 2012-02-29 16:43:31 UTC (rev 109218) @@ -1,3 +1,16 @@ +2012-02-29 Parag Radke pa...@motorola.com + +Crash in WebCore::CompositeEditCommand::insertNodeAt +https://bugs.webkit.org/show_bug.cgi?id=67764 + +Reviewed by Ryosuke Niwa. + +Added a test case to test deletion when caret position after deletion and +destination postion renders at the same place. + +* editing/deleting/delete-block-merge-contents-025-expected.txt: Added. +* editing/deleting/delete-block-merge-contents-025.html: Added. + 2012-02-29 Nikolas Zimmermann nzimmerm...@rim.com Not reviewed. Final set of pixel tests for Snow Leopard, svg/ passes with tolerance 0 again, Added: trunk/LayoutTests/editing/deleting/delete-block-merge-contents-025-expected.txt (0 => 109218) --- trunk/LayoutTests/editing/deleting/delete-block-merge-contents-025-expected.txt (rev 0) +++ trunk/LayoutTests/editing/deleting/delete-block-merge-contents-025-expected.txt 2012-02-29 16:43:31 UTC (rev 109218) @@ -0,0 +1,5 @@ +This is to test a usecase in which caret position after deletion and the destination position coincides. To pass this testcase it should not crash. + +000A0 + + Added: trunk/LayoutTests/editing/deleting/delete-block-merge-contents-025.html (0 => 109218) --- trunk/LayoutTests/editing/deleting/delete-block-merge-contents-025.html (rev 0) +++ trunk/LayoutTests/editing/deleting/delete-block-merge-contents-025.html 2012-02-29 16:43:31 UTC (rev 109218) @@ -0,0 +1,14 @@ +!DOCTYPE html +html +script +if (window.layoutTestController) +layoutTestController.dumpAsText(); +/script +p +This is to test a usecase in which caret position after deletion and the destination position coincides. +To pass this testcase it should not crash. +div contenteditable=true id=divhkernspan contenteditable=falsedl000A0script +var sel = window.getSelection(); +sel.setPosition(div, 20); +document.execCommand(Delete); +/script Modified: trunk/Source/WebCore/ChangeLog (109217 => 109218) --- trunk/Source/WebCore/ChangeLog 2012-02-29 16:08:57 UTC (rev 109217) +++ trunk/Source/WebCore/ChangeLog 2012-02-29 16:43:31 UTC (rev 109218) @@ -1,3 +1,20 @@ +2012-02-29 Parag Radke pa...@motorola.com + +Crash in WebCore::CompositeEditCommand::insertNodeAt +https://bugs.webkit.org/show_bug.cgi?id=67764 + +Reviewed by Ryosuke Niwa. + +If caret position after deletion and destination position coincides then +removing the node will result in removing the destination node also. Hence crash. + +Test: editing/deleting/delete-block-merge-contents-025.html + +* editing/CompositeEditCommand.cpp: +(WebCore::CompositeEditCommand::cleanupAfterDeletion): +If the caret position after delete and the destination position +renderes at the same place, pruning the node and making an early exit. + 2012-02-29 Pavel Feldman pfeld...@google.com Web Inspector: remove calculator's updateBoundaries in the timeline panel. Modified: trunk/Source/WebCore/editing/CompositeEditCommand.cpp (109217 => 109218) --- trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2012-02-29 16:08:57 UTC (rev 109217) +++ trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2012-02-29 16:43:31 UTC (rev 109218) @@ -1032,8 +1032,15 @@ // doesn't require a placeholder to prop itself open (like a bordered //
[webkit-changes] [109219] trunk/Source/WebCore
Title: [109219] trunk/Source/WebCore
Revision 109219
Author kenn...@webkit.org
Date 2012-02-29 08:51:41 -0800 (Wed, 29 Feb 2012)
Log Message
Do not iterate all tiles for resizing when the content didn't change
https://bugs.webkit.org/show_bug.cgi?id=79787
Reviewed by Simon Hausmann.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp
trunk/Source/WebCore/platform/graphics/TiledBackingStore.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109218 => 109219)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 16:43:31 UTC (rev 109218)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 16:51:41 UTC (rev 109219)
@@ -1,3 +1,13 @@
+2012-02-28 Kenneth Rohde Christiansen kenn...@webkit.org
+
+Do not iterate all tiles for resizing when the content didn't change
+https://bugs.webkit.org/show_bug.cgi?id=79787
+
+Reviewed by Simon Hausmann.
+
+* platform/graphics/TiledBackingStore.cpp:
+(WebCore::TiledBackingStore::createTiles):
+
2012-02-29 Parag Radke pa...@motorola.com
Crash in WebCore::CompositeEditCommand::insertNodeAt
Modified: trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp (109218 => 109219)
--- trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp 2012-02-29 16:43:31 UTC (rev 109218)
+++ trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp 2012-02-29 16:51:41 UTC (rev 109219)
@@ -232,22 +232,28 @@
{
if (m_contentsFrozen)
return;
-
-IntRect visibleRect = visibleContentsRect();
+
+const IntRect visibleRect = visibleContentsRect();
m_previousVisibleRect = visibleRect;
if (visibleRect.isEmpty())
return;
// Resize tiles on edges in case the contents size has changed.
-bool didResizeTiles = resizeEdgeTiles();
+bool didResizeTiles = false;
+const IntSize contentsSize = contentsRect().size();
+if (contentsSize != m_previousContentsSize) {
+m_previousContentsSize = contentsSize;
+didResizeTiles = resizeEdgeTiles();
+}
+
IntRect keepRect;
IntRect coverRect;
computeCoverAndKeepRect(visibleRect, coverRect, keepRect);
dropTilesOutsideRect(keepRect);
-
+
// Search for the tile position closest to the viewport center that does not yet contain a tile.
// Which position is considered the closest depends on the tileDistance function.
double shortestDistance = std::numeric_limitsdouble::infinity();
Modified: trunk/Source/WebCore/platform/graphics/TiledBackingStore.h (109218 => 109219)
--- trunk/Source/WebCore/platform/graphics/TiledBackingStore.h 2012-02-29 16:43:31 UTC (rev 109218)
+++ trunk/Source/WebCore/platform/graphics/TiledBackingStore.h 2012-02-29 16:51:41 UTC (rev 109219)
@@ -121,8 +121,10 @@
double m_tileCreationDelay;
float m_coverAreaMultiplier;
FloatPoint m_visibleRectTrajectoryVector;
-
+
IntRect m_previousVisibleRect;
+IntSize m_previousContentsSize;
+
float m_contentsScale;
float m_pendingScale;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109220] trunk/Source/WebCore
Title: [109220] trunk/Source/WebCore Revision 109220 Author ba...@chromium.org Date 2012-02-29 09:07:00 -0800 (Wed, 29 Feb 2012) Log Message Align InlineBox::m_expansion to a byte boundary https://bugs.webkit.org/show_bug.cgi?id=79761 Add a bit to m_expansion to align a byte boundary. This will make valgrind memcheck happy. I confirmed sizeof(InlineBox) is unchanged. Reviewed by Hajime Morita. No new tests. No behavior changes. * rendering/InlineBox.h: (InlineBox): Aligned m_expansion to a byte boundary. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/InlineBox.h Diff Modified: trunk/Source/WebCore/ChangeLog (109219 => 109220) --- trunk/Source/WebCore/ChangeLog 2012-02-29 16:51:41 UTC (rev 109219) +++ trunk/Source/WebCore/ChangeLog 2012-02-29 17:07:00 UTC (rev 109220) @@ -1,3 +1,19 @@ +2012-02-29 Kenichi Ishibashi ba...@chromium.org + +Align InlineBox::m_expansion to a byte boundary +https://bugs.webkit.org/show_bug.cgi?id=79761 + +Add a bit to m_expansion to align a byte boundary. +This will make valgrind memcheck happy. +I confirmed sizeof(InlineBox) is unchanged. + +Reviewed by Hajime Morita. + +No new tests. No behavior changes. + +* rendering/InlineBox.h: +(InlineBox): Aligned m_expansion to a byte boundary. + 2012-02-28 Kenneth Rohde Christiansen kenn...@webkit.org Do not iterate all tiles for resizing when the content didn't change Modified: trunk/Source/WebCore/rendering/InlineBox.h (109219 => 109220) --- trunk/Source/WebCore/rendering/InlineBox.h 2012-02-29 16:51:41 UTC (rev 109219) +++ trunk/Source/WebCore/rendering/InlineBox.h 2012-02-29 17:07:00 UTC (rev 109220) @@ -358,7 +358,7 @@ protected: mutable bool m_determinedIfNextOnLineExists : 1; mutable bool m_nextOnLineExists : 1; -signed m_expansion : 11; // for justified text +signed m_expansion : 12; // for justified text #ifndef NDEBUG private: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109221] trunk/Source/WebCore
Title: [109221] trunk/Source/WebCore
Revision 109221
Author ca...@chromium.org
Date 2012-02-29 09:35:22 -0800 (Wed, 29 Feb 2012)
Log Message
Web Inspector: timeline markers are not shown on the timeline panel
https://bugs.webkit.org/show_bug.cgi?id=79921
Reviewed by Pavel Feldman.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (109220 => 109221)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 17:07:00 UTC (rev 109220)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 17:35:22 UTC (rev 109221)
@@ -1,3 +1,14 @@
+2012-02-29 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: timeline markers are not shown on the timeline panel
+https://bugs.webkit.org/show_bug.cgi?id=79921
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords):
+(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
+
2012-02-29 Kenichi Ishibashi ba...@chromium.org
Align InlineBox::m_expansion to a byte boundary
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (109220 => 109221)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-02-29 17:07:00 UTC (rev 109220)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-02-29 17:35:22 UTC (rev 109221)
@@ -459,8 +459,13 @@
var formattedRecord = this._presentationModel.addRecord(record, parentRecord);
++this._allRecordsCount;
var recordTypes = WebInspector.TimelineModel.RecordType;
-if (record.type === recordTypes.MarkDOMContent || record.type === recordTypes.MarkLoad || record.type === recordTypes.TimeStamp)
-this._timeStampRecords.push(formattedRecord);
+var timeStampRecords = this._timeStampRecords;
+function addTimestampRecords(record)
+{
+if (record.type === recordTypes.MarkDOMContent || record.type === recordTypes.MarkLoad || record.type === recordTypes.TimeStamp)
+timeStampRecords.push(record);
+}
+WebInspector.TimelinePanel.forAllRecords([ formattedRecord ], addTimestampRecords);
},
sidebarResized: function(event)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109223] trunk/Source/WebCore
Title: [109223] trunk/Source/WebCore
Revision 109223
Author vse...@chromium.org
Date 2012-02-29 09:40:55 -0800 (Wed, 29 Feb 2012)
Log Message
Web Inspector: [InspectorIndexedDB] Add refresh to IndexedDB support.
https://bugs.webkit.org/show_bug.cgi?id=79695
Reviewed by Pavel Feldman.
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView):
(WebInspector.IDBDataView.prototype._refreshButtonClicked):
(WebInspector.IDBDataView.prototype.get statusBarItems):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IndexedDBTreeElement):
(WebInspector.IndexedDBTreeElement.prototype.onattach):
(WebInspector.IndexedDBTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IDBDatabaseTreeElement.prototype.onattach):
(WebInspector.IDBDatabaseTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/IndexedDBViews.js
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (109222 => 109223)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 17:37:04 UTC (rev 109222)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 17:40:55 UTC (rev 109223)
@@ -1,3 +1,22 @@
+2012-02-27 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: [InspectorIndexedDB] Add refresh to IndexedDB support.
+https://bugs.webkit.org/show_bug.cgi?id=79695
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/IndexedDBViews.js:
+(WebInspector.IDBDataView):
+(WebInspector.IDBDataView.prototype._refreshButtonClicked):
+(WebInspector.IDBDataView.prototype.get statusBarItems):
+* inspector/front-end/ResourcesPanel.js:
+(WebInspector.IndexedDBTreeElement):
+(WebInspector.IndexedDBTreeElement.prototype.onattach):
+(WebInspector.IndexedDBTreeElement.prototype._handleContextMenuEvent):
+(WebInspector.IDBDatabaseTreeElement.prototype.onattach):
+(WebInspector.IDBDatabaseTreeElement.prototype._handleContextMenuEvent):
+(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):
+
2012-02-29 Andrey Kosyakov ca...@chromium.org
Web Inspector: timeline markers are not shown on the timeline panel
Modified: trunk/Source/WebCore/inspector/front-end/IndexedDBViews.js (109222 => 109223)
--- trunk/Source/WebCore/inspector/front-end/IndexedDBViews.js 2012-02-29 17:37:04 UTC (rev 109222)
+++ trunk/Source/WebCore/inspector/front-end/IndexedDBViews.js 2012-02-29 17:40:55 UTC (rev 109223)
@@ -37,14 +37,14 @@
{
WebInspector.View.call(this);
this.registerRequiredCSS(indexedDBViews.css);
-
+
this.element.addStyleClass(fill);
this.element.addStyleClass(indexed-db-database-view);
-
+
this._headersListElement = this.element.createChild(ol, outline-disclosure);
this._headersTreeOutline = new TreeOutline(this._headersListElement);
this._headersTreeOutline.expandTreeElementsWhenArrowing = true;
-
+
this._securityOriginTreeElement = new TreeElement(, null, false);
this._securityOriginTreeElement.selectable = false;
this._headersTreeOutline.appendChild(this._securityOriginTreeElement);
@@ -105,8 +105,8 @@
{
WebInspector.View.call(this);
this.registerRequiredCSS(indexedDBViews.css);
-
-this._model = model;
+
+this._model = model;
this._databaseId = databaseId;
this._isIndex = !!index;
@@ -114,10 +114,13 @@
var editorToolbar = this._createEditorToolbar();
this.element.appendChild(editorToolbar);
-
+
this._dataGridContainer = this.element.createChild(div, fill);
this._dataGridContainer.addStyleClass(data-grid-container);
+this._refreshButton = new WebInspector.StatusBarButton(WebInspector.UIString(Refresh), refresh-storage-status-bar-item);
+this._refreshButton.addEventListener(click, this._refreshButtonClicked, this);
+
this._pageSize = 50;
this._skipCount = 0;
@@ -134,18 +137,18 @@
columns[number] = {};
columns[number].title = WebInspector.UIString(#);
columns[number].width = 50px;
-
+
var keyPath = this._isIndex ? this._index.keyPath : this._objectStore.keyPath;
columns[key] = {};
var keyColumnTitle = WebInspector.UIString(Key) + (keyPath ? ( + keyPath + ) : );
columns[key].title = keyColumnTitle;
-
+
if (this._isIndex) {
columns[primaryKey] = {};
var primaryKeyColumnTitle = WebInspector.UIString(Primary key) + (this._objectStore.keyPath ? ( + this._objectStore.keyPath + ) : );
columns[primaryKey].title = primaryKeyColumnTitle;
}
-
+
columns[value] = {};
columns[value].title = WebInspector.UIString(Value);
@@ -169,7 +172,7 @@
this._pageBackButton.appendChild(document.createElement(img));
[webkit-changes] [109224] trunk/Source/JavaScriptCore
Title: [109224] trunk/Source/_javascript_Core
Revision 109224
Author kev...@webkit.org
Date 2012-02-29 09:44:34 -0800 (Wed, 29 Feb 2012)
Log Message
Add JSCore symbol exports needed by wx port
https://bugs.webkit.org/show_bug.cgi?id=77280
Reviewed by Hajime Morita.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/ArrayBufferView.h
trunk/Source/_javascript_Core/wtf/ExportMacros.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (109223 => 109224)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-29 17:40:55 UTC (rev 109223)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-29 17:44:34 UTC (rev 109224)
@@ -1,3 +1,13 @@
+2012-02-29 Kevin Ollivier kev...@theolliviers.com
+
+Add JSCore symbol exports needed by wx port
+https://bugs.webkit.org/show_bug.cgi?id=77280
+
+Reviewed by Hajime Morita.
+
+* wtf/ArrayBufferView.h:
+* wtf/ExportMacros.h:
+
2012-02-28 Raphael Kubo da Costa k...@profusion.mobi
[CMake] Always build wtf as a static library.
Modified: trunk/Source/_javascript_Core/wtf/ArrayBufferView.h (109223 => 109224)
--- trunk/Source/_javascript_Core/wtf/ArrayBufferView.h 2012-02-29 17:40:55 UTC (rev 109223)
+++ trunk/Source/_javascript_Core/wtf/ArrayBufferView.h 2012-02-29 17:44:34 UTC (rev 109224)
@@ -36,7 +36,7 @@
namespace WTF {
-class ArrayBufferView : public RefCountedArrayBufferView {
+class WTF_EXPORT_PRIVATE_RTTI ArrayBufferView : public RefCountedArrayBufferView {
public:
virtual bool isByteArray() const { return false; }
virtual bool isUnsignedByteArray() const { return false; }
Modified: trunk/Source/_javascript_Core/wtf/ExportMacros.h (109223 => 109224)
--- trunk/Source/_javascript_Core/wtf/ExportMacros.h 2012-02-29 17:40:55 UTC (rev 109223)
+++ trunk/Source/_javascript_Core/wtf/ExportMacros.h 2012-02-29 17:44:34 UTC (rev 109224)
@@ -83,6 +83,14 @@
#define WTF_EXPORT_PRIVATE WTF_IMPORT
#endif
+// wxWebKit uses RTTI because wx itself does, so use a special macro for
+// extra exports it needs.
+#if PLATFORM(WX)
+#define WTF_EXPORT_PRIVATE_RTTI WTF_EXPORT_PRIVATE
+#else
+#define WTF_EXPORT_PRIVATE_RTTI
+#endif
+
#define WTF_EXPORT_HIDDEN WTF_HIDDEN
#define HIDDEN_INLINE WTF_EXPORT_HIDDEN inline
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109225] trunk
Title: [109225] trunk Revision 109225 Author carlo...@webkit.org Date 2012-02-29 09:51:29 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed. Fix GTK+ build. * Source/autotools/symbols.filter: Add symbol. Modified Paths trunk/ChangeLog trunk/Source/autotools/symbols.filter Diff Modified: trunk/ChangeLog (109224 => 109225) --- trunk/ChangeLog 2012-02-29 17:44:34 UTC (rev 109224) +++ trunk/ChangeLog 2012-02-29 17:51:29 UTC (rev 109225) @@ -1,3 +1,9 @@ +2012-02-29 Carlos Garcia Campos cgar...@igalia.com + +Unreviewed. Fix GTK+ build. + +* Source/autotools/symbols.filter: Add symbol. + 2012-02-28 Raphael Kubo da Costa k...@profusion.mobi [CMake] Always build wtf as a static library. Modified: trunk/Source/autotools/symbols.filter (109224 => 109225) --- trunk/Source/autotools/symbols.filter 2012-02-29 17:44:34 UTC (rev 109224) +++ trunk/Source/autotools/symbols.filter 2012-02-29 17:51:29 UTC (rev 109225) @@ -99,6 +99,7 @@ _ZN7WebCore24FrameDestructionObserver14frameDestroyedEv; _ZN7WebCore24FrameDestructionObserver14willDetachPageEv; _ZN7WebCore22RuntimeEnabledFeatures31isMultipleShadowSubtreesEnabledE; +_ZN7WebCore22RuntimeEnabledFeatures32setMultipleShadowSubtreesEnabledEb; local: _Z*; cti*; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109226] trunk
Title: [109226] trunk Revision 109226 Author carlo...@webkit.org Date 2012-02-29 09:55:03 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed. Bump WebKitGTK+ version number. * configure.ac: Bump version number to 1.9.0 now that we branched for 1.8. Modified Paths trunk/ChangeLog trunk/configure.ac Diff Modified: trunk/ChangeLog (109225 => 109226) --- trunk/ChangeLog 2012-02-29 17:51:29 UTC (rev 109225) +++ trunk/ChangeLog 2012-02-29 17:55:03 UTC (rev 109226) @@ -1,5 +1,12 @@ 2012-02-29 Carlos Garcia Campos cgar...@igalia.com +Unreviewed. Bump WebKitGTK+ version number. + +* configure.ac: Bump version number to 1.9.0 now that we branched +for 1.8. + +2012-02-29 Carlos Garcia Campos cgar...@igalia.com + Unreviewed. Fix GTK+ build. * Source/autotools/symbols.filter: Add symbol. Modified: trunk/configure.ac (109225 => 109226) --- trunk/configure.ac 2012-02-29 17:51:29 UTC (rev 109225) +++ trunk/configure.ac 2012-02-29 17:55:03 UTC (rev 109226) @@ -1,8 +1,8 @@ AC_PREREQ(2.59) m4_define([webkit_major_version], [1]) -m4_define([webkit_minor_version], [7]) -m4_define([webkit_micro_version], [5]) +m4_define([webkit_minor_version], [9]) +m4_define([webkit_micro_version], [0]) # This is the version we'll be using as part of our User-Agent string # e.g., AppleWebKit/$(webkit_user_agent_version) ... ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109227] trunk/Source/WebCore
Title: [109227] trunk/Source/WebCore
Revision 109227
Author an...@apple.com
Date 2012-02-29 10:08:27 -0800 (Wed, 29 Feb 2012)
Log Message
Applying region style should not need to access parent rules
https://bugs.webkit.org/show_bug.cgi?id=79910
Reviewed by Andreas Kling.
Currently CSSStyleSelector::applyProperties looks into parent rules to see if a rule is
part of region style. The plan is to eliminate the rule parent pointer so this needs to be refactored.
Add a bit to RuleData to indicate if the StyleRule is part of a region style.
* css/CSSStyleSelector.cpp:
(RuleData):
(WebCore::RuleData::isInRegionRule):
(RuleSet):
(WebCore::CSSStyleSelector::addMatchedProperties):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109226 => 109227)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 17:55:03 UTC (rev 109226)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 18:08:27 UTC (rev 109227)
@@ -1,3 +1,25 @@
+2012-02-29 Antti Koivisto an...@apple.com
+
+Applying region style should not need to access parent rules
+https://bugs.webkit.org/show_bug.cgi?id=79910
+
+Reviewed by Andreas Kling.
+
+Currently CSSStyleSelector::applyProperties looks into parent rules to see if a rule is
+part of region style. The plan is to eliminate the rule parent pointer so this needs to be refactored.
+
+Add a bit to RuleData to indicate if the StyleRule is part of a region style.
+
+* css/CSSStyleSelector.cpp:
+(RuleData):
+(WebCore::RuleData::isInRegionRule):
+(RuleSet):
+(WebCore::CSSStyleSelector::addMatchedProperties):
+(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+* css/CSSStyleSelector.h:
+(CSSStyleSelector):
+
2012-02-27 Vsevolod Vlasov vse...@chromium.org
Web Inspector: [InspectorIndexedDB] Add refresh to IndexedDB support.
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (109226 => 109227)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-02-29 17:55:03 UTC (rev 109226)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-02-29 18:08:27 UTC (rev 109227)
@@ -174,7 +174,7 @@
class RuleData {
public:
-RuleData(StyleRule*, CSSSelector*, unsigned position, bool canUseFastCheckSelector = true);
+RuleData(StyleRule*, CSSSelector*, unsigned position, bool canUseFastCheckSelector, bool inRegionRule);
unsigned position() const { return m_position; }
StyleRule* rule() const { return m_rule; }
@@ -186,6 +186,7 @@
bool containsUncommonAttributeSelector() const { return m_containsUncommonAttributeSelector; }
unsigned specificity() const { return m_specificity; }
unsigned linkMatchType() const { return m_linkMatchType; }
+bool isInRegionRule() const { return m_isInRegionRule; }
// Try to balance between memory usage (there can be lots of RuleData objects) and good filtering performance.
static const unsigned maximumIdentifierCount = 4;
@@ -197,12 +198,13 @@
unsigned m_specificity;
// This number was picked fairly arbitrarily. We can probably lower it if we need to.
// Some simple testing showed 100,000 RuleData's on large sites.
-unsigned m_position : 26;
+unsigned m_position : 25;
unsigned m_hasFastCheckableSelector : 1;
unsigned m_hasMultipartSelector : 1;
unsigned m_hasRightmostSelectorMatchingHTMLBasedOnRuleHash : 1;
unsigned m_containsUncommonAttributeSelector : 1;
unsigned m_linkMatchType : 2; // SelectorChecker::LinkMatchMask
+unsigned m_isInRegionRule : 1;
// Use plain array instead of a Vector to minimize memory overhead.
unsigned m_descendantSelectorIdentifierHashes[maximumIdentifierCount];
};
@@ -226,8 +228,8 @@
void addRulesFromSheet(CSSStyleSheet*, const MediaQueryEvaluator, CSSStyleSelector* = 0, const Element* = 0);
-void addStyleRule(StyleRule*, bool canUseFastCheckSelector = true);
-void addRule(StyleRule*, CSSSelector*, bool canUseFastCheckSelector = true);
+void addStyleRule(StyleRule*, bool canUseFastCheckSelector = true, bool isInRegionRule = false);
+void addRule(StyleRule*, CSSSelector*, bool canUseFastCheckSelector = true, bool isInRegionRule = false);
void addPageRule(CSSPageRule*);
void addToRuleSet(AtomicStringImpl* key, AtomRuleMap, const RuleData);
void addRegionRule(WebKitCSSRegionRule*);
@@ -751,12 +753,13 @@
ASSERT_UNUSED(loadedMathMLUserAgentSheet, loadedMathMLUserAgentSheet || defaultStyle-features().siblingRules.isEmpty());
}
-void
[webkit-changes] [109228] trunk/Source/WebKit2
Title: [109228] trunk/Source/WebKit2
Revision 109228
Author ser...@webkit.org
Date 2012-02-29 10:15:32 -0800 (Wed, 29 Feb 2012)
Log Message
DidFindString should be emitted even if FindOptionsShowOverlay is not enabled
https://bugs.webkit.org/show_bug.cgi?id=76522
Reviewed by Darin Adler.
DidFindString message should be issued always even if neither
FindOptionsShowOverlay or FindOptionsShowHighlight are
provided. The difference is that if any of those flags are present
the find operation will look for all the appearances of the text
in the web view, otherwise it will just look and report the next
occurrence.
This patch removes the temporary workaround added in r109222 to
the WebKitFindController unit tests.
* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp
trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (109227 => 109228)
--- trunk/Source/WebKit2/ChangeLog 2012-02-29 18:08:27 UTC (rev 109227)
+++ trunk/Source/WebKit2/ChangeLog 2012-02-29 18:15:32 UTC (rev 109228)
@@ -1,3 +1,24 @@
+2012-02-29 Sergio Villar Senin svil...@igalia.com
+
+DidFindString should be emitted even if FindOptionsShowOverlay is not enabled
+https://bugs.webkit.org/show_bug.cgi?id=76522
+
+Reviewed by Darin Adler.
+
+DidFindString message should be issued always even if neither
+FindOptionsShowOverlay or FindOptionsShowHighlight are
+provided. The difference is that if any of those flags are present
+the find operation will look for all the appearances of the text
+in the web view, otherwise it will just look and report the next
+occurrence.
+
+This patch removes the temporary workaround added in r109222 to
+the WebKitFindController unit tests.
+
+* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
+* WebProcess/WebPage/FindController.cpp:
+(WebKit::FindController::findString):
+
2012-01-19 Sergio Villar Senin svil...@igalia.com
[GTK] [WK2] Add Find API
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp (109227 => 109228)
--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp 2012-02-29 18:08:27 UTC (rev 109227)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp 2012-02-29 18:15:32 UTC (rev 109228)
@@ -45,12 +45,6 @@
void find(const char* searchText, guint32 findOptions, guint maxMatchCount)
{
-// Due to http://weakit.org/b/76522 we have to artificially
-// add here the show overlay option (that we do not even
-// expose in the API) to get the DidFindString messsage
-// issued. Remove this once 76522 is fixed.
-findOptions = findOptions | 1 5;
-
g_signal_connect(m_findController.get(), found-text, G_CALLBACK(foundTextCallback), this);
g_signal_connect(m_findController.get(), failed-to-find-text, G_CALLBACK(failedToFindTextCallback), this);
webkit_find_controller_search(m_findController.get(), searchText, findOptions, maxMatchCount);
Modified: trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp (109227 => 109228)
--- trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp 2012-02-29 18:08:27 UTC (rev 109227)
+++ trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp 2012-02-29 18:15:32 UTC (rev 109228)
@@ -109,24 +109,25 @@
m_webPage-send(Messages::WebPageProxy::DidFailToFindString(string));
} else {
shouldShowOverlay = options FindOptionsShowOverlay;
+bool shouldShowHighlight = options FindOptionsShowHighlight;
+unsigned matchCount = 1;
-if (shouldShowOverlay) {
-bool shouldShowHighlight = options FindOptionsShowHighlight;
+if (shouldShowOverlay || shouldShowHighlight) {
if (maxMatchCount == numeric_limitsunsigned::max())
--maxMatchCount;
-
-unsigned matchCount = m_webPage-corePage()-markAllMatchesForText(string, core(options), shouldShowHighlight, maxMatchCount + 1);
+matchCount = m_webPage-corePage()-markAllMatchesForText(string, core(options), shouldShowHighlight, maxMatchCount + 1);
+
// Check if we have more matches than allowed.
if (matchCount maxMatchCount) {
shouldShowOverlay = false;
matchCount = static_castunsigned(kWKMoreThanMaximumMatchCount);
}
-
-m_webPage-send(Messages::WebPageProxy::DidFindString(string, matchCount));
}
+m_webPage-send(Messages::WebPageProxy::DidFindString(string, matchCount));
+
if (!(options FindOptionsShowFindIndicator) || !updateFindIndicator(selectedFrame,
[webkit-changes] [109229] trunk/Source/WebKit2
Title: [109229] trunk/Source/WebKit2 Revision 109229 Author carlo...@webkit.org Date 2012-02-29 10:45:14 -0800 (Wed, 29 Feb 2012) Log Message [GTK] Add zoom-text-only setting to WebKit2 GTK+ API https://bugs.webkit.org/show_bug.cgi?id=75249 Reviewed by Gustavo Noronha Silva. To set whether zoom level of web view should affect only the text or all page contents. It's disabled by default. * UIProcess/API/gtk/WebKitSettings.cpp: (webKitSettingsSetProperty): (webKitSettingsGetProperty): (webkit_settings_class_init): Add WebKitSettings:zoom-text-only property. (webkit_settings_set_zoom_text_only): Set WebKitSettings:zoom-text-only. (webkit_settings_get_zoom_text_only): Get WebKitSettings:zoom-text-only. * UIProcess/API/gtk/WebKitSettings.h: * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols. * UIProcess/API/gtk/tests/TestWebKitSettings.cpp: (testWebKitSettings): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (109228 => 109229) --- trunk/Source/WebKit2/ChangeLog 2012-02-29 18:15:32 UTC (rev 109228) +++ trunk/Source/WebKit2/ChangeLog 2012-02-29 18:45:14 UTC (rev 109229) @@ -1,3 +1,28 @@ +2012-02-29 Carlos Garcia Campos cgar...@igalia.com + +[GTK] Add zoom-text-only setting to WebKit2 GTK+ API +https://bugs.webkit.org/show_bug.cgi?id=75249 + +Reviewed by Gustavo Noronha Silva. + +To set whether zoom level of web view should affect only the text +or all page contents. It's disabled by default. + +* UIProcess/API/gtk/WebKitSettings.cpp: +(webKitSettingsSetProperty): +(webKitSettingsGetProperty): +(webkit_settings_class_init): Add WebKitSettings:zoom-text-only +property. +(webkit_settings_set_zoom_text_only): Set +WebKitSettings:zoom-text-only. +(webkit_settings_get_zoom_text_only): Get +WebKitSettings:zoom-text-only. +* UIProcess/API/gtk/WebKitSettings.h: +* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new +symbols. +* UIProcess/API/gtk/tests/TestWebKitSettings.cpp: +(testWebKitSettings): + 2012-02-29 Sergio Villar Senin svil...@igalia.com DidFindString should be emitted even if FindOptionsShowOverlay is not enabled Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (109228 => 109229) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2012-02-29 18:15:32 UTC (rev 109228) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2012-02-29 18:45:14 UTC (rev 109229) @@ -46,6 +46,7 @@ CString fantasyFontFamily; CString pictographFontFamily; CString defaultCharset; +bool zoomTextOnly; }; /** @@ -103,7 +104,8 @@ PROP_ENABLE_FULLSCREEN, PROP_PRINT_BACKGROUNDS, PROP_ENABLE_WEBAUDIO, -PROP_ENABLE_WEBGL +PROP_ENABLE_WEBGL, +PROP_ZOOM_TEXT_ONLY }; static void webKitSettingsSetProperty(GObject* object, guint propId, const GValue* value, GParamSpec* paramSpec) @@ -210,6 +212,9 @@ case PROP_ENABLE_WEBGL: webkit_settings_set_enable_webgl(settings, g_value_get_boolean(value)); break; +case PROP_ZOOM_TEXT_ONLY: +webkit_settings_set_zoom_text_only(settings, g_value_get_boolean(value)); +break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propId, paramSpec); break; @@ -320,6 +325,9 @@ case PROP_ENABLE_WEBGL: g_value_set_boolean(value, webkit_settings_get_enable_webgl(settings)); break; +case PROP_ZOOM_TEXT_ONLY: +g_value_set_boolean(value, webkit_settings_get_zoom_text_only(settings)); +break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propId, paramSpec); break; @@ -816,6 +824,22 @@ FALSE, readWriteConstructParamFlags)); +/** + * WebKitSettings:zoom-text-only: + * + * Whether #WebKitWebView:zoom-level affects only the + * text of the page or all the contents. Other contents containing text + * like form controls will be also affected by zoom factor when + * this property is enabled. + */ +g_object_class_install_property(gObjectClass, +PROP_ZOOM_TEXT_ONLY, +g_param_spec_boolean(zoom-text-only, + _(Zoom Text Only), + _(Whether zoom level of web view changes only the text size), + FALSE, +
[webkit-changes] [109230] trunk/Source/WebKit2
Title: [109230] trunk/Source/WebKit2
Revision 109230
Author carlo...@webkit.org
Date 2012-02-29 10:51:15 -0800 (Wed, 29 Feb 2012)
Log Message
[GTK] Use text or page zoom factor in WebKitWebView depending on zoom-text-only
https://bugs.webkit.org/show_bug.cgi?id=75252
Reviewed by Gustavo Noronha Silva.
* UIProcess/API/gtk/WebKitWebView.cpp:
(zoomTextOnlyChanged): Update text/page zoom factor when
zoom-text-only setting changes.
(webkitWebViewSetSettings): Helper function to set the settings
object for the web view, initializing the settings for the page
and connecting to notify::zoom-text-only signal.
(webkitWebViewConstructed): Use webkitWebViewSetSettings().
(webkit_web_view_set_settings): Use webkitWebViewSetSettings() and
disconnect from the notify::zoom-text-only signal of the previous
settings object.
(webkit_web_view_set_zoom_level): Set text/page zoom factor
depending on WebKitSettings:zoom-text-only property.
(webkit_web_view_get_zoom_level): Get text/page zoom factor
depending on WebKitSettings:zoom-text-only property.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewZoomLevel):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (109229 => 109230)
--- trunk/Source/WebKit2/ChangeLog 2012-02-29 18:45:14 UTC (rev 109229)
+++ trunk/Source/WebKit2/ChangeLog 2012-02-29 18:51:15 UTC (rev 109230)
@@ -1,5 +1,29 @@
2012-02-29 Carlos Garcia Campos cgar...@igalia.com
+[GTK] Use text or page zoom factor in WebKitWebView depending on zoom-text-only
+https://bugs.webkit.org/show_bug.cgi?id=75252
+
+Reviewed by Gustavo Noronha Silva.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(zoomTextOnlyChanged): Update text/page zoom factor when
+zoom-text-only setting changes.
+(webkitWebViewSetSettings): Helper function to set the settings
+object for the web view, initializing the settings for the page
+and connecting to notify::zoom-text-only signal.
+(webkitWebViewConstructed): Use webkitWebViewSetSettings().
+(webkit_web_view_set_settings): Use webkitWebViewSetSettings() and
+disconnect from the notify::zoom-text-only signal of the previous
+settings object.
+(webkit_web_view_set_zoom_level): Set text/page zoom factor
+depending on WebKitSettings:zoom-text-only property.
+(webkit_web_view_get_zoom_level): Get text/page zoom factor
+depending on WebKitSettings:zoom-text-only property.
+* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
+(testWebViewZoomLevel):
+
+2012-02-29 Carlos Garcia Campos cgar...@igalia.com
+
[GTK] Add zoom-text-only setting to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=75249
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (109229 => 109230)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2012-02-29 18:45:14 UTC (rev 109229)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2012-02-29 18:51:15 UTC (rev 109230)
@@ -172,6 +172,22 @@
return TRUE;
}
+static void zoomTextOnlyChanged(WebKitSettings* settings, GParamSpec*, WebKitWebView* webView)
+{
+WKPageRef wkPage = toAPI(webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(webView)));
+gboolean zoomTextOnly = webkit_settings_get_zoom_text_only(settings);
+gdouble pageZoomLevel = zoomTextOnly ? 1 : WKPageGetTextZoomFactor(wkPage);
+gdouble textZoomLevel = zoomTextOnly ? WKPageGetPageZoomFactor(wkPage) : 1;
+WKPageSetPageAndTextZoomFactors(wkPage, pageZoomLevel, textZoomLevel);
+}
+
+static void webkitWebViewSetSettings(WebKitWebView* webView, WebKitSettings* settings, WKPageRef wkPage)
+{
+webView-priv-settings = settings;
+webkitSettingsAttachSettingsToPage(webView-priv-settings.get(), wkPage);
+g_signal_connect(settings, notify::zoom-text-only, G_CALLBACK(zoomTextOnlyChanged), webView);
+}
+
static void webkitWebViewConstructed(GObject* object)
{
if (G_OBJECT_CLASS(webkit_web_view_parent_class)-constructed)
@@ -189,8 +205,9 @@
WebPageProxy* page = webkitWebViewBaseGetPage(webViewBase);
priv-backForwardList = adoptGRef(webkitBackForwardListCreate(WKPageGetBackForwardList(toAPI(page;
-priv-settings = adoptGRef(webkit_settings_new());
-webkitSettingsAttachSettingsToPage(priv-settings.get(), toAPI(page));
+
+GRefPtrWebKitSettings settings = adoptGRef(webkit_settings_new());
+webkitWebViewSetSettings(webView, settings.get(), toAPI(page));
}
static void webkitWebViewSetProperty(GObject* object, guint propId, const GValue* value, GParamSpec* paramSpec)
@@ -1304,8 +1321,8 @@
if (webView-priv-settings == settings)
return;
-webView-priv-settings = settings;
-webkitSettingsAttachSettingsToPage(settings,
[webkit-changes] [109231] trunk
Title: [109231] trunk Revision 109231 Author jer.no...@apple.com Date 2012-02-29 10:55:12 -0800 (Wed, 29 Feb 2012) Log Message Full screen video volume slider has progress bar https://bugs.webkit.org/show_bug.cgi?id=79812 Reviewed by Eric Carlson. Source/WebCore: No new tests; strictly a platform-specific look-and-feel change. The full-screen volume slider has a media-slider appearance, which is rendering as if the volume slider has a progress. Make a concrete media-fullscreen-volume-slider appearance which has the correct look-and-feel. Add two new appearance keywords, media-fullscreen-volume-slider and thumb, and their associated types and CSS keywords: * css/CSSValueKeywords.in: * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * html/shadow/MediaControlElements.h: * platform/ThemeTypes.h: Handle the new slider and thumb types when rendering: * rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): (WebCore::RenderMediaControls::paintMediaControlsPart): * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): * rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaFullScreenVolumeSliderTrack): (WebCore::RenderTheme::paintMediaFullScreenVolumeSliderThumb): * rendering/RenderThemeMac.h: (RenderThemeMac): * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMediaSliderThumbSize): (WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack): (WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb): * rendering/RenderMediaControlsChromium.cpp: (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): * accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation): Mark the fullscreen volume slider as horizontal. * html/shadow/SliderThumbElement.cpp: (WebCore::RenderSliderThumb::updateAppearance): Give MediaFullScreenVolumeSliderParts MediaFullScreenVolumeSliderThumbParts. * css/fullscreenQuickTime.css: Change the styles for the fullscreen slider, min, and max buttons. (video:-webkit-full-screen::-webkit-media-controls-fullscreen-volume-min-button): (video:-webkit-full-screen::-webkit-media-controls-fullscreen-volume-slider): (video:-webkit-full-screen::-webkit-media-controls-fullscreen-volume-max-button): * html/shadow/MediaControlRootElement.cpp: (WebCore::MediaControlRootElement::reset): Set the value of the fullscreen volume slider when resetting. WebKitLibraries: * WebKitSystemInterface.h: * libWebKitSystemInterfaceLeopard.a: * libWebKitSystemInterfaceLion.a: * libWebKitSystemInterfaceSnowLeopard.a: * win/include/WebKitSystemInterface/WebKitSystemInterface.h: * win/lib/WebKitSystemInterface.lib: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilitySlider.cpp trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/CSSValueKeywords.in trunk/Source/WebCore/css/fullscreenQuickTime.css trunk/Source/WebCore/html/shadow/MediaControlElements.h trunk/Source/WebCore/html/shadow/MediaControlRootElement.cpp trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp trunk/Source/WebCore/platform/ThemeTypes.h trunk/Source/WebCore/rendering/RenderMediaControls.cpp trunk/Source/WebCore/rendering/RenderMediaControlsChromium.cpp trunk/Source/WebCore/rendering/RenderTheme.cpp trunk/Source/WebCore/rendering/RenderTheme.h trunk/Source/WebCore/rendering/RenderThemeMac.h trunk/Source/WebCore/rendering/RenderThemeMac.mm trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/win/include/WebKitSystemInterface/WebKitSystemInterface.h trunk/WebKitLibraries/win/lib/WebKitSystemInterface.lib Diff Modified: trunk/Source/WebCore/ChangeLog (109230 => 109231) --- trunk/Source/WebCore/ChangeLog 2012-02-29 18:51:15 UTC (rev 109230) +++ trunk/Source/WebCore/ChangeLog 2012-02-29 18:55:12 UTC (rev 109231) @@ -1,3 +1,56 @@ +2012-02-28 Jer Noble jer.no...@apple.com + +Full screen video volume slider has progress bar +https://bugs.webkit.org/show_bug.cgi?id=79812 + +Reviewed by Eric Carlson. + +No new tests; strictly a platform-specific look-and-feel change. + +The full-screen volume slider has a media-slider appearance, which is rendering as if +the volume slider has a progress. Make a concrete media-fullscreen-volume-slider appearance +which has the correct look-and-feel. + +Add two new appearance keywords, media-fullscreen-volume-slider and thumb, and their associated +types and CSS keywords: +* css/CSSValueKeywords.in: +* css/CSSPrimitiveValueMappings.h: +(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): +* html/shadow/MediaControlElements.h: +* platform/ThemeTypes.h: + +Handle the new slider and thumb types when rendering: +* rendering/RenderMediaControls.cpp: +(WebCore::RenderMediaControls::adjustMediaSliderThumbSize): +
[webkit-changes] [109232] trunk/Tools
Title: [109232] trunk/Tools
Revision 109232
Author kbal...@webkit.org
Date 2012-02-29 10:56:11 -0800 (Wed, 29 Feb 2012)
Log Message
[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=76546
Reviewed by Simon Hausmann.
Revert the workaround introduced in r107868 and reintroduce
the qml binding so we can test the code path that we are more
interested in. The reason that it did not work before is that
we don't have an active platform window which we now workaround
by propagating the resize through QWindowSystemInterface.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp
Diff
Modified: trunk/Tools/ChangeLog (109231 => 109232)
--- trunk/Tools/ChangeLog 2012-02-29 18:55:12 UTC (rev 109231)
+++ trunk/Tools/ChangeLog 2012-02-29 18:56:11 UTC (rev 109232)
@@ -1,3 +1,20 @@
+2012-02-29 Balazs Kelemen kbal...@webkit.org
+
+[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
+https://bugs.webkit.org/show_bug.cgi?id=76546
+
+Reviewed by Simon Hausmann.
+
+Revert the workaround introduced in r107868 and reintroduce
+the qml binding so we can test the code path that we are more
+interested in. The reason that it did not work before is that
+we don't have an active platform window which we now workaround
+by propagating the resize through QWindowSystemInterface.
+
+* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
+(WTR::WrapperWindow::handleStatusChanged):
+(WTR::PlatformWebView::resizeTo):
+
2012-02-29 Gabor Rapcsanyi rga...@webkit.org
[GTK] Small fix for cross compilation to not generate gtkdoc.
Modified: trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp (109231 => 109232)
--- trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp 2012-02-29 18:55:12 UTC (rev 109231)
+++ trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp 2012-02-29 18:56:11 UTC (rev 109232)
@@ -55,14 +55,10 @@
return;
setGeometry(0, 0, 800, 600);
-m_view-setX(0);
-m_view-setY(0);
-m_view-setWidth(800);
-m_view-setHeight(600);
setResizeMode(QQuickView::SizeRootObjectToView);
-
m_view-setParentItem(rootObject());
+QDeclarativeProperty::write(m_view, anchors.fill, qVariantFromValue(rootObject()));
QWindowSystemInterface::handleWindowActivated(this);
m_view-page()-setFocus(true);
@@ -91,9 +87,15 @@
void PlatformWebView::resizeTo(unsigned width, unsigned height)
{
+// If we do not have a platform window we will never get the necessary
+// resize event, so simulate it in that case to make sure the quickview is
+// resized to what the layout test expects.
+if (!m_window-handle()) {
+QRect newGeometry(m_window-x(), m_window-y(), width, height);
+QWindowSystemInterface::handleSynchronousGeometryChange(m_window, newGeometry);
+}
+
m_window-resize(width, height);
-m_view-setWidth(width);
-m_view-setHeight(height);
}
WKPageRef PlatformWebView::page()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109233] trunk/LayoutTests
Title: [109233] trunk/LayoutTests
Revision 109233
Author dslo...@google.com
Date 2012-02-29 11:08:24 -0800 (Wed, 29 Feb 2012)
Log Message
Unreviewed: updating expectations for chromium (error messages)
* platform/chromium/fast/events/message-port-multi-expected.txt: Added.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Added Paths
trunk/LayoutTests/platform/chromium/fast/events/message-port-multi-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (109232 => 109233)
--- trunk/LayoutTests/ChangeLog 2012-02-29 18:56:11 UTC (rev 109232)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 19:08:24 UTC (rev 109233)
@@ -1,3 +1,10 @@
+2012-02-29 Dmitry Lomov dslo...@google.com
+
+Unreviewed: updating expectations for chrmium (error messages)
+
+* platform/chromium/fast/events/message-port-multi-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
2012-02-29 Parag Radke pa...@motorola.com
Crash in WebCore::CompositeEditCommand::insertNodeAt
Added: trunk/LayoutTests/platform/chromium/fast/events/message-port-multi-expected.txt (0 => 109233)
--- trunk/LayoutTests/platform/chromium/fast/events/message-port-multi-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/message-port-multi-expected.txt 2012-02-29 19:08:24 UTC (rev 109233)
@@ -0,0 +1,23 @@
+This test checks the various use cases around sending multiple ports through MessagePort.postMessage
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS channel.port1.postMessage(same port, [channel.port1]) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
+PASS channel.port1.postMessage(entangled port, [channel.port2]) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
+PASS channel.port1.postMessage(null port, [channel3.port1, null, channel3.port2]) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
+PASS channel.port1.postMessage(notAPort, [channel3.port1, {}, channel3.port2]) threw exception TypeError: TransferArray argument must contain only Transferables.
+PASS channel.port1.postMessage(notAnArray, channel3.port1) threw exception TypeError: TransferArray argument has no length attribute.
+PASS channel.port1.postMessage(notASequence, [{length: 3}]) threw exception TypeError: TransferArray argument must contain only Transferables.
+PASS channel.port1.postMessage(largeSequence, largePortArray) threw exception Error: DATA_CLONE_ERR: DOM Exception 25.
+PASS event.ports is non-null and zero length when no port sent
+PASS event.ports is non-null and zero length when empty array sent
+PASS event.ports contains two ports when two ports sent
+PASS event.ports contains two ports when two ports re-sent after error
+PASS Sending host object has thrown Error: DATA_CLONE_ERR: DOM Exception 25
+PASS send-port: transferred one port
+PASS send-port-twice: transferred one port twice
+PASS send-two-ports: transferred two ports
+
+TEST COMPLETE
+
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109232 => 109233)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 18:56:11 UTC (rev 109232)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 19:08:24 UTC (rev 109233)
@@ -237,7 +237,6 @@
WONTFIX SKIP : fast/events/message-port-inactive-document.html = FAIL
WONTFIX SKIP : fast/events/message-port-no-wrapper.html = FAIL
WONTFIX SKIP : fast/events/message-port.html = FAIL
-WONTFIX SKIP : fast/events/message-port-multi.html = FAIL
WONTFIX SKIP : http/tests/security/MessagePort/event-listener-context.html = FAIL
// Chrome does not support Java LiveConnect.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109234] trunk/Source/WebKit2
Title: [109234] trunk/Source/WebKit2 Revision 109234 Author wei...@apple.com Date 2012-02-29 11:40:24 -0800 (Wed, 29 Feb 2012) Log Message When invoking Lookup while zoomed in, the highlighted word renders out of line rdar://problem/10812527 Reviewed by Simon Fraser. * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::performDictionaryLookupForRange): Make sure to scale the ascent when determining the origin for the overlay. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (109233 => 109234) --- trunk/Source/WebKit2/ChangeLog 2012-02-29 19:08:24 UTC (rev 109233) +++ trunk/Source/WebKit2/ChangeLog 2012-02-29 19:40:24 UTC (rev 109234) @@ -1,3 +1,14 @@ +2012-02-29 Sam Weinig s...@webkit.org + +When invoking Lookup while zoomed in, the highlighted word renders out of line +rdar://problem/10812527 + +Reviewed by Simon Fraser. + +* WebProcess/WebPage/mac/WebPageMac.mm: +(WebKit::WebPage::performDictionaryLookupForRange): +Make sure to scale the ascent when determining the origin for the overlay. + 2012-02-29 Carlos Garcia Campos cgar...@igalia.com [GTK] Use text or page zoom factor in WebKitWebView depending on zoom-text-only Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm (109233 => 109234) --- trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2012-02-29 19:08:24 UTC (rev 109233) +++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2012-02-29 19:40:24 UTC (rev 109234) @@ -539,7 +539,7 @@ DictionaryPopupInfo dictionaryPopupInfo; dictionaryPopupInfo.type = type; -dictionaryPopupInfo.origin = FloatPoint(rangeRect.x(), rangeRect.y() + style-fontMetrics().ascent()); +dictionaryPopupInfo.origin = FloatPoint(rangeRect.x(), rangeRect.y() + (style-fontMetrics().ascent() * pageScaleFactor())); dictionaryPopupInfo.fontInfo.fontAttributeDictionary = fontDescriptorAttributes; #if !defined(BUILDING_ON_SNOW_LEOPARD) dictionaryPopupInfo.options = (CFDictionaryRef)options; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109235] trunk/Tools
Title: [109235] trunk/Tools Revision 109235 Author dpra...@chromium.org Date 2012-02-29 11:48:43 -0800 (Wed, 29 Feb 2012) Log Message perftestsrunner can call printer.write() after printer.cleanup() https://bugs.webkit.org/show_bug.cgi?id=79872 Reviewed by Ryosuke Niwa. This patch fixes a unittest that was incorrectly calling PerfTestsRunner.run() twice (which led to a weird state in the printer object). * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: (MainTest.test_run_with_upload_json): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py Diff Modified: trunk/Tools/ChangeLog (109234 => 109235) --- trunk/Tools/ChangeLog 2012-02-29 19:40:24 UTC (rev 109234) +++ trunk/Tools/ChangeLog 2012-02-29 19:48:43 UTC (rev 109235) @@ -1,3 +1,17 @@ +2012-02-29 Dirk Pranke dpra...@chromium.org + +perftestsrunner can call printer.write() after printer.cleanup() +https://bugs.webkit.org/show_bug.cgi?id=79872 + +Reviewed by Ryosuke Niwa. + +This patch fixes a unittest that was incorrectly calling +PerfTestsRunner.run() twice (which led to a weird state in the +printer object). + +* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: +(MainTest.test_run_with_upload_json): + 2012-02-29 Balazs Kelemen kbal...@webkit.org [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (109234 => 109235) --- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2012-02-29 19:40:24 UTC (rev 109234) +++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2012-02-29 19:48:43 UTC (rev 109235) @@ -280,6 +280,10 @@ self.assertEqual(generated_json['builder-name'], 'builder1') self.assertEqual(generated_json['build-number'], 123) upload_json_returns_true = False + +runner = self.create_runner(args=['--output-json-path=/mock-checkout/output.json', +'--test-results-server', 'some.host', '--platform', 'platform1', '--builder-name', 'builder1', '--build-number', '123']) +runner._upload_json = mock_upload_json self.assertEqual(runner.run(), -3) def test_upload_json(self): ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109236] trunk
Title: [109236] trunk
Revision 109236
Author commit-qu...@webkit.org
Date 2012-02-29 11:51:11 -0800 (Wed, 29 Feb 2012)
Log Message
Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527
Patch by Greg Billock gbill...@google.com on 2012-02-29
Reviewed by Adam Barth.
Tools:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::currentIntentRequest):
LayoutTests:
* webintents/resources/web-intents-testing.js: Added.
(onSuccess):
(onFailure):
(startIntentWithCallbacks):
(simulateButtonPress):
* webintents/web-intents-failure-expected.txt: Added.
* webintents/web-intents-failure.html: Added.
* webintents/web-intents-invoke-expected.txt: Added.
* webintents/web-intents-invoke.html: Added.
* webintents/web-intents-reload.html:
* webintents/web-intents-reply-expected.txt: Added.
* webintents/web-intents-reply.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webintents/web-intents-reload.html
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h
Added Paths
trunk/LayoutTests/webintents/resources/web-intents-testing.js
trunk/LayoutTests/webintents/web-intents-failure-expected.txt
trunk/LayoutTests/webintents/web-intents-failure.html
trunk/LayoutTests/webintents/web-intents-invoke-expected.txt
trunk/LayoutTests/webintents/web-intents-invoke.html
trunk/LayoutTests/webintents/web-intents-reply-expected.txt
trunk/LayoutTests/webintents/web-intents-reply.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109235 => 109236)
--- trunk/LayoutTests/ChangeLog 2012-02-29 19:48:43 UTC (rev 109235)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 19:51:11 UTC (rev 109236)
@@ -1,3 +1,23 @@
+2012-02-29 Greg Billock gbill...@google.com
+
+Add more tests for web intents
+https://bugs.webkit.org/show_bug.cgi?id=79527
+
+Reviewed by Adam Barth.
+
+* webintents/resources/web-intents-testing.js: Added.
+(onSuccess):
+(onFailure):
+(startIntentWithCallbacks):
+(simulateButtonPress):
+* webintents/web-intents-failure-expected.txt: Added.
+* webintents/web-intents-failure.html: Added.
+* webintents/web-intents-invoke-expected.txt: Added.
+* webintents/web-intents-invoke.html: Added.
+* webintents/web-intents-reload.html:
+* webintents/web-intents-reply-expected.txt: Added.
+* webintents/web-intents-reply.html: Added.
+
2012-02-29 Dmitry Lomov dslo...@google.com
Unreviewed: updating expectations for chrmium (error messages)
Added: trunk/LayoutTests/webintents/resources/web-intents-testing.js (0 => 109236)
--- trunk/LayoutTests/webintents/resources/web-intents-testing.js (rev 0)
+++ trunk/LayoutTests/webintents/resources/web-intents-testing.js 2012-02-29 19:51:11 UTC (rev 109236)
@@ -0,0 +1,40 @@
+// Callback function to be used for a successful web intent call.
+function onSuccess(data) {
+ debug(* got reply: + data);
+
+ if (window.layoutTestController) {
+window.layoutTestController.notifyDone();
+ }
+}
+
+// Callback function to be used for a failed web intent call.
+function onFailure(data) {
+ debug(* got failure: + data);
+
+ if (window.layoutTestController) {
+window.layoutTestController.notifyDone();
+ }
+}
+
+// Launch a web intent call with callbacks.
+function startIntentWithCallbacks() {
+ navigator.startActivity(new Intent(action1, mime/type1, test), onSuccess, onFailure);
+ debug(* sent intent);
+
+ if (window.layoutTestController) {
+window.layoutTestController.waitUntilDone();
+ } else {
+alert('This test needs to run in DRT');
+ }
+}
+
+// This button press simulator sets the user gesture indicator that an intent
+// requires to start.
+function simulateButtonPress() {
+ var button = document.getElementById(button);
+ if (eventSender) {
+eventSender.mouseMoveTo(button.getBoundingClientRect().left + 2, button.getBoundingClientRect().top + 12);
+eventSender.mouseDown();
+eventSender.mouseUp();
+ }
+}
Added: trunk/LayoutTests/webintents/web-intents-failure-expected.txt (0 => 109236)
--- trunk/LayoutTests/webintents/web-intents-failure-expected.txt (rev 0)
+++ trunk/LayoutTests/webintents/web-intents-failure-expected.txt 2012-02-29 19:51:11 UTC (rev 109236)
@@ -0,0 +1,7 @@
+Received Web Intent: action="" type=mime/type1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+* sent intent
+* got failure: ERROR
+
Added: trunk/LayoutTests/webintents/web-intents-failure.html (0 => 109236)
--- trunk/LayoutTests/webintents/web-intents-failure.html (rev
[webkit-changes] [109237] trunk/Source/WebCore
Title: [109237] trunk/Source/WebCore
Revision 109237
Author bda...@apple.com
Date 2012-02-29 11:51:54 -0800 (Wed, 29 Feb 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=79868
Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin
-and corresponding-
rdar://problem/10688637
Reviewed by Anders Carlsson.
Scrollbars are currently drawn on the main thread even when scrolling happens
on the scrolling thread, so we have to call back to the main thread for the
time being to make the right drawing calls for NSEventPhaseMayBegin.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::handleWheelEventPhase):
(WebCore):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::handleWheelEventPhase):
(WebCore):
* page/scrolling/ScrollingTree.h:
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::handleWheelEventPhase):
(ScrollAnimator):
Call into AppKit on NSEventPhaseMayBegin.
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore):
(WebCore::ScrollAnimatorMac::handleWheelEventPhase):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h
trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTree.h
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeNodeMac.mm
trunk/Source/WebCore/platform/ScrollAnimator.h
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.h
trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (109236 => 109237)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 19:51:11 UTC (rev 109236)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 19:51:54 UTC (rev 109237)
@@ -1,3 +1,39 @@
+2012-02-28 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=79868
+Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin
+-and corresponding-
+rdar://problem/10688637
+
+Reviewed by Anders Carlsson.
+
+Scrollbars are currently drawn on the main thread even when scrolling happens
+on the scrolling thread, so we have to call back to the main thread for the
+time being to make the right drawing calls for NSEventPhaseMayBegin.
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::handleWheelEventPhase):
+(WebCore):
+* page/scrolling/ScrollingCoordinator.h:
+(ScrollingCoordinator):
+* page/scrolling/ScrollingTree.cpp:
+(WebCore::ScrollingTree::handleWheelEventPhase):
+(WebCore):
+* page/scrolling/ScrollingTree.h:
+* page/scrolling/mac/ScrollingTreeNodeMac.mm:
+(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
+* platform/ScrollAnimator.h:
+(WebCore::ScrollAnimator::handleWheelEventPhase):
+(ScrollAnimator):
+
+Call into AppKit on NSEventPhaseMayBegin.
+* platform/mac/ScrollAnimatorMac.h:
+(ScrollAnimatorMac):
+* platform/mac/ScrollAnimatorMac.mm:
+(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
+(WebCore):
+(WebCore::ScrollAnimatorMac::handleWheelEventPhase):
+(WebCore::ScrollAnimatorMac::handleWheelEvent):
+
2012-02-28 Jer Noble jer.no...@apple.com
Full screen video volume slider has progress bar
Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (109236 => 109237)
--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2012-02-29 19:51:11 UTC (rev 109236)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp 2012-02-29 19:51:54 UTC (rev 109237)
@@ -279,6 +279,22 @@
#endif
}
+#if PLATFORM(MAC) || (PLATFORM(CHROMIUM) OS(DARWIN))
+void ScrollingCoordinator::handleWheelEventPhase(PlatformWheelEventPhase phase)
+{
+ASSERT(isMainThread());
+
+if (!m_page)
+return;
+
+FrameView* frameView = m_page-mainFrame()-view();
+if (!frameView)
+return;
+
+frameView-scrollAnimator()-handleWheelEventPhase(phase);
+}
+#endif
+
void ScrollingCoordinator::recomputeWheelEventHandlerCount()
{
unsigned wheelEventHandlerCount = 0;
Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h (109236 => 109237)
--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h 2012-02-29 19:51:11 UTC (rev 109236)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h 2012-02-29 19:51:54 UTC (rev 109237)
@@ -28,6 +28,7 @@
#include GraphicsLayer.h
#include IntRect.h
+#include PlatformWheelEvent.h
#include ScrollTypes.h
#include Timer.h
#include wtf/Forward.h
@@
[webkit-changes] [109238] trunk
Title: [109238] trunk
Revision 109238
Author commit-qu...@webkit.org
Date 2012-02-29 11:53:49 -0800 (Wed, 29 Feb 2012)
Log Message
[BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
https://bugs.webkit.org/show_bug.cgi?id=79519
Patch by Max Feil mf...@rim.com on 2012-02-29
Reviewed by Antonio Gomes.
Source/WebCore:
A layout test already exists for OGG. We do not support OGG
video at this time, only audio.
Test: media/media-can-play-flac-audio.html
* platform/blackberry/MIMETypeRegistryBlackBerry.cpp:
(WebCore):
Source/WebKit/blackberry:
* Api/WebSettings.cpp:
(BlackBerry::WebKit::mimeTypeAssociationMap):
LayoutTests:
A layout test already exists for OGG. We do not support OGG
video at this time, only audio.
* media/media-can-play-flac-audio-expected.txt: Added.
* media/media-can-play-flac-audio.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/efl/Skipped
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/MIMETypeRegistryBlackBerry.cpp
trunk/Source/WebKit/blackberry/Api/WebSettings.cpp
trunk/Source/WebKit/blackberry/ChangeLog
Added Paths
trunk/LayoutTests/media/media-can-play-flac-audio-expected.txt
trunk/LayoutTests/media/media-can-play-flac-audio.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109237 => 109238)
--- trunk/LayoutTests/ChangeLog 2012-02-29 19:51:54 UTC (rev 109237)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 19:53:49 UTC (rev 109238)
@@ -1,3 +1,23 @@
+2012-02-29 Max Feil mf...@rim.com
+
+[BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
+https://bugs.webkit.org/show_bug.cgi?id=79519
+
+Reviewed by Antonio Gomes.
+
+A layout test already exists for OGG. We do not support OGG
+video at this time, only audio.
+
+* media/media-can-play-flac-audio-expected.txt: Added.
+* media/media-can-play-flac-audio.html: Added.
+* platform/chromium/test_expectations.txt:
+* platform/efl/Skipped:
+* platform/gtk/Skipped:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+* platform/wincairo/Skipped:
+
2012-02-29 Greg Billock gbill...@google.com
Add more tests for web intents
Added: trunk/LayoutTests/media/media-can-play-flac-audio-expected.txt (0 => 109238)
--- trunk/LayoutTests/media/media-can-play-flac-audio-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-can-play-flac-audio-expected.txt 2012-02-29 19:53:49 UTC (rev 109238)
@@ -0,0 +1,6 @@
+Test HTMLMediaElement canPlayType() method with multiple .flac MIME types.
+
+EXPECTED (audio.canPlayType('audio/flac') == 'maybe') OK
+EXPECTED (audio.canPlayType('audio/x-flac') == 'maybe') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/media-can-play-flac-audio.html (0 => 109238)
--- trunk/LayoutTests/media/media-can-play-flac-audio.html (rev 0)
+++ trunk/LayoutTests/media/media-can-play-flac-audio.html 2012-02-29 19:53:49 UTC (rev 109238)
@@ -0,0 +1,26 @@
+!doctype html
+html
+head
+script src=""
+script
+function start()
+{
+audio = document.getElementsByTagName('audio')[0];
+
+// FLAC encoded audio in a native flac container
+testExpected(audio.canPlayType('audio/flac'), maybe);
+testExpected(audio.canPlayType('audio/x-flac'), maybe);
+
+endTest();
+}
+/script
+
+/head
+body _onload_=start()
+
+audio controls /audio
+
+pTest HTMLMediaElement emcanPlayType()/em method with multiple .flac MIME types./p
+
+/body
+/html
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109237 => 109238)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 19:51:54 UTC (rev 109237)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 19:53:49 UTC (rev 109238)
@@ -485,6 +485,7 @@
WONTFIX SKIP : media/audio-mpeg4-supported.html = TIMEOUT FAIL
WONTFIX SKIP : media/media-can-play-mpeg-audio.html = TEXT
WONTFIX SKIP : media/media-can-play-mpeg4-video.html = TEXT
+WONTFIX SKIP : media/media-can-play-flac-audio.html = TEXT
WONTFIX SKIP : media/video-can-play-type.html = TIMEOUT FAIL
WONTFIX SKIP : media/video-document-types.html = TIMEOUT FAIL
WONTFIX SKIP : media/video-element-other-namespace-crash.html = TIMEOUT
Modified: trunk/LayoutTests/platform/efl/Skipped (109237 => 109238)
---
[webkit-changes] [109240] trunk
Title: [109240] trunk
Revision 109240
Author barraclo...@apple.com
Date 2012-02-29 11:59:43 -0800 (Wed, 29 Feb 2012)
Log Message
Writable attribute not set correctly when redefining an accessor to a data descriptor
https://bugs.webkit.org/show_bug.cgi?id=79931
Reviewed by Oliver Hunt.
Source/_javascript_Core:
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
- use attributesOverridingCurrent instead of attributesWithOverride.
* runtime/PropertyDescriptor.cpp:
* runtime/PropertyDescriptor.h:
- remove attributesWithOverride - attributesOverridingCurrent does the same thing.
LayoutTests:
* fast/js/Object-defineProperty-expected.txt:
* fast/js/script-tests/Object-defineProperty.js:
- Added tests.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/Object-defineProperty-expected.txt
trunk/LayoutTests/fast/js/script-tests/Object-defineProperty.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/PropertyDescriptor.cpp
trunk/Source/_javascript_Core/runtime/PropertyDescriptor.h
Diff
Modified: trunk/LayoutTests/ChangeLog (109239 => 109240)
--- trunk/LayoutTests/ChangeLog 2012-02-29 19:54:35 UTC (rev 109239)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 19:59:43 UTC (rev 109240)
@@ -1,3 +1,14 @@
+2012-02-29 Gavin Barraclough barraclo...@apple.com
+
+Writable attribute not set correctly when redefining an accessor to a data descriptor
+https://bugs.webkit.org/show_bug.cgi?id=79931
+
+Reviewed by Oliver Hunt.
+
+* fast/js/Object-defineProperty-expected.txt:
+* fast/js/script-tests/Object-defineProperty.js:
+- Added tests.
+
2012-02-29 Max Feil mf...@rim.com
[BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
Modified: trunk/LayoutTests/fast/js/Object-defineProperty-expected.txt (109239 => 109240)
--- trunk/LayoutTests/fast/js/Object-defineProperty-expected.txt 2012-02-29 19:54:35 UTC (rev 109239)
+++ trunk/LayoutTests/fast/js/Object-defineProperty-expected.txt 2012-02-29 19:59:43 UTC (rev 109240)
@@ -116,6 +116,9 @@
PASS '0' in Object.prototype is true
PASS var o = {}; o.readOnly = false; o.readOnly is true
PASS 'use strict'; var o = {}; o.readOnly = false; o.readOnly threw exception TypeError: Attempted to assign to readonly property..
+PASS Object.getOwnPropertyDescriptor(Object.defineProperty(Object.defineProperty({}, 'foo', {get: function() { return false; }, configurable: true}), 'foo', {value:false}), 'foo').writable is false
+PASS Object.getOwnPropertyDescriptor(Object.defineProperty(Object.defineProperty({}, 'foo', {get: function() { return false; }, configurable: true}), 'foo', {value:false, writable: false}), 'foo').writable is false
+PASS Object.getOwnPropertyDescriptor(Object.defineProperty(Object.defineProperty({}, 'foo', {get: function() { return false; }, configurable: true}), 'foo', {value:false, writable: true}), 'foo').writable is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/js/script-tests/Object-defineProperty.js (109239 => 109240)
--- trunk/LayoutTests/fast/js/script-tests/Object-defineProperty.js 2012-02-29 19:54:35 UTC (rev 109239)
+++ trunk/LayoutTests/fast/js/script-tests/Object-defineProperty.js 2012-02-29 19:59:43 UTC (rev 109240)
@@ -167,4 +167,7 @@
shouldThrow('use strict'; var o = {}; o.readOnly = false; o.readOnly);
delete Object.prototype.readOnly;
-
+// Check the writable attribute is set correctly when redefining an accessor as a data descriptor.
+shouldBeFalse(Object.getOwnPropertyDescriptor(Object.defineProperty(Object.defineProperty({}, 'foo', {get: function() { return false; }, configurable: true}), 'foo', {value:false}), 'foo').writable);
+shouldBeFalse(Object.getOwnPropertyDescriptor(Object.defineProperty(Object.defineProperty({}, 'foo', {get: function() { return false; }, configurable: true}), 'foo', {value:false, writable: false}), 'foo').writable);
+shouldBeTrue(Object.getOwnPropertyDescriptor(Object.defineProperty(Object.defineProperty({}, 'foo', {get: function() { return false; }, configurable: true}), 'foo', {value:false, writable: true}), 'foo').writable);
Modified: trunk/Source/_javascript_Core/ChangeLog (109239 => 109240)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-29 19:54:35 UTC (rev 109239)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-29 19:59:43 UTC (rev 109240)
@@ -1,3 +1,17 @@
+2012-02-29 Gavin Barraclough barraclo...@apple.com
+
+Writable attribute not set correctly when redefining an accessor to a data descriptor
+https://bugs.webkit.org/show_bug.cgi?id=79931
+
+Reviewed by Oliver Hunt.
+
+* runtime/JSObject.cpp:
+(JSC::JSObject::defineOwnProperty):
+- use attributesOverridingCurrent instead of attributesWithOverride.
+* runtime/PropertyDescriptor.cpp:
+* runtime/PropertyDescriptor.h:
+- remove
[webkit-changes] [109241] trunk/Source/WebKit2
Title: [109241] trunk/Source/WebKit2 Revision 109241 Author commit-qu...@webkit.org Date 2012-02-29 12:02:13 -0800 (Wed, 29 Feb 2012) Log Message [Qt][WK2] We should not add NetscapeBrowserFuncs.cpp as header https://bugs.webkit.org/show_bug.cgi?id=79847 Patch by Rafael Brandao rafael.l...@openbossa.org on 2012-02-29 Reviewed by Alexey Proskuryakov. * Target.pri: Fix typo, so we can add .h file instead. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Target.pri Diff Modified: trunk/Source/WebKit2/ChangeLog (109240 => 109241) --- trunk/Source/WebKit2/ChangeLog 2012-02-29 19:59:43 UTC (rev 109240) +++ trunk/Source/WebKit2/ChangeLog 2012-02-29 20:02:13 UTC (rev 109241) @@ -1,3 +1,12 @@ +2012-02-29 Rafael Brandao rafael.l...@openbossa.org + +[Qt][WK2] We should not add NetscapeBrowserFuncs.cpp as header +https://bugs.webkit.org/show_bug.cgi?id=79847 + +Reviewed by Alexey Proskuryakov. + +* Target.pri: Fix typo, so we can add .h file instead. + 2012-02-29 Sam Weinig s...@webkit.org When invoking Lookup while zoomed in, the highlighted word renders out of line Modified: trunk/Source/WebKit2/Target.pri (109240 => 109241) --- trunk/Source/WebKit2/Target.pri 2012-02-29 19:59:43 UTC (rev 109240) +++ trunk/Source/WebKit2/Target.pri 2012-02-29 20:02:13 UTC (rev 109241) @@ -319,7 +319,7 @@ WebProcess/Plugins/Netscape/NPJSObject.h \ WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h \ WebProcess/Plugins/Netscape/NPRuntimeUtilities.h \ -WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp \ +WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h \ WebProcess/Plugins/Netscape/NetscapePlugin.h \ WebProcess/Plugins/Netscape/NetscapePluginStream.h \ WebProcess/Plugins/Plugin.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109242] trunk/Tools
Title: [109242] trunk/Tools
Revision 109242
Author dpra...@chromium.org
Date 2012-02-29 12:04:07 -0800 (Wed, 29 Feb 2012)
Log Message
Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527
Patch by Greg Billock gbill...@google.com on 2012-02-29
Reviewed by Adam Barth.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::currentIntentRequest):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (109241 => 109242)
--- trunk/Tools/ChangeLog 2012-02-29 20:02:13 UTC (rev 109241)
+++ trunk/Tools/ChangeLog 2012-02-29 20:04:07 UTC (rev 109242)
@@ -16,6 +16,57 @@
2012-02-29 Dirk Pranke dpra...@chromium.org
+nrwt: port/Driver needs to support per-test command line args
+https://bugs.webkit.org/show_bug.cgi?id=79733
+
+Reviewed by Adam Barth.
+
+As part of removing the 'gpu' configurations and adding support
+for 'virtual test suites', the Driver classes need to support
+per-test command lines (since different tests will need to be
+run with different command line options).
+
+The per-test args are not yet used, so this change should have
+no visible effects and need no additional testing.
+
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.driver_cmd_line):
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumDriver.cmd_line):
+(ChromiumDriver._start):
+(ChromiumDriver.start):
+* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+(ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
+(ChromiumDriverTest):
+(ChromiumDriverTest.test_two_drivers):
+* Scripts/webkitpy/layout_tests/port/driver.py:
+(Driver.cmd_line):
+(DriverProxy.__init__):
+(DriverProxy.start):
+(DriverProxy.cmd_line):
+* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
+(DriverTest.test_virtual_driver_methods):
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+(GtkDriver.cmd_line):
+* Scripts/webkitpy/layout_tests/port/mock_drt.py:
+* Scripts/webkitpy/layout_tests/port/test.py:
+(TestPort._path_to_driver):
+(TestDriver.cmd_line):
+(TestDriver.start):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitDriver.cmd_line):
+(WebKitDriver._start):
+(WebKitDriver.run_test):
+(WebKitDriver.start):
+* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+(WebKitDriverTest.test_no_timeout):
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+(PerfTestsRunner._run_tests_set):
+* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+(test_run_test_pause_before_testing):
+
+2012-02-29 Dirk Pranke dpra...@chromium.org
+
perftestsrunner can call printer.write() after printer.cleanup()
https://bugs.webkit.org/show_bug.cgi?id=79872
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (109241 => 109242)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-02-29 20:02:13 UTC (rev 109241)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2012-02-29 20:04:07 UTC (rev 109242)
@@ -533,7 +533,7 @@
def driver_cmd_line(self):
Prints the DRT command line that will be used.
driver = self.create_driver(0)
-return driver.cmd_line()
+return driver.cmd_line(self.get_option('pixel_tests'), [])
def update_baseline(self, baseline_path, data):
Updates the baseline for a test.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (109241 => 109242)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-02-29 20:02:13 UTC (rev 109241)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-02-29 20:04:07 UTC (rev 109242)
@@ -398,9 +398,9 @@
if self._pixel_tests:
self._image_path = self._port._filesystem.join(self._port.results_directory(), 'png_result%s.png'
[webkit-changes] [109243] branches/subpixellayout/Source/WebCore/platform
Title: [109243] branches/subpixellayout/Source/WebCore/platform
Revision 109243
Author e...@chromium.org
Date 2012-02-29 12:20:29 -0800 (Wed, 29 Feb 2012)
Log Message
Change RenderTheme internals back to int for mac and qt ports on branch.
Modified Paths
branches/subpixellayout/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp
branches/subpixellayout/Source/WebCore/platform/mac/ScrollAnimatorMac.mm
branches/subpixellayout/Source/WebCore/platform/mac/ThemeMac.h
branches/subpixellayout/Source/WebCore/platform/mac/ThemeMac.mm
branches/subpixellayout/Source/WebCore/platform/mac/WidgetMac.mm
branches/subpixellayout/Source/WebCore/platform/qt/RenderThemeQStyle.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp (109242 => 109243)
--- branches/subpixellayout/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp 2012-02-29 20:04:07 UTC (rev 109242)
+++ branches/subpixellayout/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp 2012-02-29 20:20:29 UTC (rev 109243)
@@ -191,7 +191,7 @@
return IntRect(trackRect.x() + (trackRect.width() - m_thumbFatness) / 2, trackRect.y() + thumbPos, m_thumbFatness, thumbLength(scrollbar));
}
-bool ScrollbarThemeGtk::paint(Scrollbar* scrollbar, GraphicsContext* graphicsContext, const FractionalLayoutRect damageRect)
+bool ScrollbarThemeGtk::paint(Scrollbar* scrollbar, GraphicsContext* graphicsContext, const IntRect damageRect)
{
if (graphicsContext-paintingDisabled())
return false;
Modified: branches/subpixellayout/Source/WebCore/platform/mac/ScrollAnimatorMac.mm (109242 => 109243)
--- branches/subpixellayout/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-02-29 20:04:07 UTC (rev 109242)
+++ branches/subpixellayout/Source/WebCore/platform/mac/ScrollAnimatorMac.mm 2012-02-29 20:20:29 UTC (rev 109243)
@@ -464,7 +464,7 @@
if (part == WebCore::ThumbPart _scrollbar-orientation() == VerticalScrollbar) {
if (newAlpha == 1) {
-IntRect thumbRect = enclosingIntRect(FloatRect([scrollerPainter rectForPart:NSScrollerKnob]));
+IntRect thumbRect = IntRect([scrollerPainter rectForPart:NSScrollerKnob]);
[self scrollAnimator]-setVisibleScrollerThumbRect(thumbRect);
} else
[self scrollAnimator]-setVisibleScrollerThumbRect(IntRect());
Modified: branches/subpixellayout/Source/WebCore/platform/mac/ThemeMac.h (109242 => 109243)
--- branches/subpixellayout/Source/WebCore/platform/mac/ThemeMac.h 2012-02-29 20:04:07 UTC (rev 109242)
+++ branches/subpixellayout/Source/WebCore/platform/mac/ThemeMac.h 2012-02-29 20:20:29 UTC (rev 109243)
@@ -29,7 +29,6 @@
#include Theme.h
namespace WebCore {
-class FractionalLayoutRect;
class ThemeMac : public Theme {
public:
Modified: branches/subpixellayout/Source/WebCore/platform/mac/ThemeMac.mm (109242 => 109243)
--- branches/subpixellayout/Source/WebCore/platform/mac/ThemeMac.mm 2012-02-29 20:04:07 UTC (rev 109242)
+++ branches/subpixellayout/Source/WebCore/platform/mac/ThemeMac.mm 2012-02-29 20:20:29 UTC (rev 109243)
@@ -141,10 +141,10 @@
return sizeFromNSControlSize(controlSizeForFont(font), zoomedSize, zoomFactor, sizes);
}
-static ControlSize controlSizeFromPixelSize(const IntSize* sizes, const WebCore::FractionalLayoutSize minZoomedSize, float zoomFactor)
+static ControlSize controlSizeFromPixelSize(const IntSize* sizes, const IntSize minZoomedSize, float zoomFactor)
{
-if (minZoomedSize.width() = (sizes[NSRegularControlSize].width() * zoomFactor)
-minZoomedSize.height() = (sizes[NSRegularControlSize].height() * zoomFactor))
+if (minZoomedSize.width() = static_castint(sizes[NSRegularControlSize].width() * zoomFactor)
+minZoomedSize.height() = static_castint(sizes[NSRegularControlSize].height() * zoomFactor))
return NSRegularControlSize;
if (minZoomedSize.width() = static_castint(sizes[NSSmallControlSize].width() * zoomFactor)
minZoomedSize.height() = static_castint(sizes[NSSmallControlSize].height() * zoomFactor))
@@ -152,7 +152,7 @@
return NSMiniControlSize;
}
-static void setControlSize(NSCell* cell, const IntSize* sizes, const WebCore::FractionalLayoutSize minZoomedSize, float zoomFactor)
+static void setControlSize(NSCell* cell, const IntSize* sizes, const IntSize minZoomedSize, float zoomFactor)
{
ControlSize size = controlSizeFromPixelSize(sizes, minZoomedSize, zoomFactor);
if (size != [cell controlSize]) // Only update if we have to, since AppKit does work even if the size is the same.
@@ -211,13 +211,13 @@
return kThemeStateActive;
}
-static IntRect inflateRect(const WebCore::IntRect zoomedRect, const WebCore::IntSize zoomedSize, const int* margins, float zoomFactor)
+static IntRect inflateRect(const IntRect zoomedRect, const IntSize zoomedSize, const int* margins, float zoomFactor)
{
// Only do the inflation if the available width/height are too small. Otherwise try to
// fit the glow/check
[webkit-changes] [109244] trunk/LayoutTests
Title: [109244] trunk/LayoutTests Revision 109244 Author ad...@chromium.org Date 2012-02-29 12:33:32 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed gardening, further mark stop-animation-on-suspend.html as crashy on Windows. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109243 => 109244) --- trunk/LayoutTests/ChangeLog 2012-02-29 20:20:29 UTC (rev 109243) +++ trunk/LayoutTests/ChangeLog 2012-02-29 20:33:32 UTC (rev 109244) @@ -1,3 +1,9 @@ +2012-02-29 Adam Klein ad...@chromium.org + +Unreviewed gardening, further mark stop-animation-on-suspend.html as crashy on Windows. + +* platform/chromium/test_expectations.txt: + 2012-02-29 Gavin Barraclough barraclo...@apple.com Writable attribute not set correctly when redefining an accessor to a data descriptor Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109243 => 109244) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 20:20:29 UTC (rev 109243) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 20:33:32 UTC (rev 109244) @@ -2297,9 +2297,11 @@ WONTFIX SKIP WIN : platform/win/plugins/get-value-netscape-window.html = TEXT CRASH // Added in WK r71424 -BUGCR62138 MAC DEBUG : animations/stop-animation-on-suspend.html = CRASH TEXT PASS -BUGCR62138 MAC RELEASE : animations/stop-animation-on-suspend.html = TEXT PASS -BUGCR62138 LINUX WIN : animations/stop-animation-on-suspend.html = TEXT PASS +// We should probably just skip this test, everyone else has since +// https://bugs.webkit.org/show_bug.cgi?id=49182 +BUGCR62138 WIN MAC DEBUG : animations/stop-animation-on-suspend.html = CRASH TEXT PASS +BUGCR62138 WIN MAC RELEASE : animations/stop-animation-on-suspend.html = TEXT PASS +BUGCR62138 LINUX : animations/stop-animation-on-suspend.html = TEXT PASS BUGCR61739 DEBUG : animations/suspend-resume-animation-events.html = CRASH TEXT PASS BUGCR61739 WIN RELEASE : animations/suspend-resume-animation-events.html = TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109245] trunk
Title: [109245] trunk
Revision 109245
Author commit-qu...@webkit.org
Date 2012-02-29 12:40:10 -0800 (Wed, 29 Feb 2012)
Log Message
Crash when changing list marker locations
https://bugs.webkit.org/show_bug.cgi?id=79681
Patch by Ken Buchanan ke...@chromium.org on 2012-02-29
Reviewed by David Hyatt.
Source/WebCore:
This fixes a regression crash from r108548.
There are some conditions where removing the anonymous block
parent at that point can cause problems. One is when there is
a continuation from it, and another when it is a sibling of
lineBoxParent and it causes lineBoxParent to be deleted
incidentally. This patch delays the destruction until after
lineBoxParent has been used and makes an exception for
continuations.
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation)
LayoutTests:
This test exercises the crashing condition for bug 79681 where an
anonymous block was being removed from the render tree inappropriately.
* fast/lists/remove-listmarker-from-anonblock-with-continuation-crash-expected.txt: Added
* fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html: Added
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListItem.cpp
Added Paths
trunk/LayoutTests/fast/lists/remove-listmarker-from-anonblock-with-continuation-crash-expected.txt
trunk/LayoutTests/fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109244 => 109245)
--- trunk/LayoutTests/ChangeLog 2012-02-29 20:33:32 UTC (rev 109244)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 20:40:10 UTC (rev 109245)
@@ -1,3 +1,16 @@
+2012-02-29 Ken Buchanan ke...@chromium.org
+
+Crash when changing list marker locations
+https://bugs.webkit.org/show_bug.cgi?id=79681
+
+Reviewed by David Hyatt.
+
+This test exercises the crashing condition for bug 79681 where an
+anonymous block was being removed from the render tree inappropriately.
+
+* fast/lists/remove-listmarker-from-anonblock-with-continuation-crash-expected.txt: Added
+* fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html: Added
+
2012-02-29 Adam Klein ad...@chromium.org
Unreviewed gardening, further mark stop-animation-on-suspend.html as crashy on Windows.
Added: trunk/LayoutTests/fast/lists/remove-listmarker-from-anonblock-with-continuation-crash-expected.txt (0 => 109245)
--- trunk/LayoutTests/fast/lists/remove-listmarker-from-anonblock-with-continuation-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/lists/remove-listmarker-from-anonblock-with-continuation-crash-expected.txt 2012-02-29 20:40:10 UTC (rev 109245)
@@ -0,0 +1,3 @@
+PASS if no crash or assert in debug
+
+
Added: trunk/LayoutTests/fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html (0 => 109245)
--- trunk/LayoutTests/fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html (rev 0)
+++ trunk/LayoutTests/fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html 2012-02-29 20:40:10 UTC (rev 109245)
@@ -0,0 +1,25 @@
+style
+.listItem { display: list-item; text-decoration: none; -webkit-column-width: 10px; }
+.colSpanAll { display: block; -webkit-column-span: all; }
+.absPosition { display: inherit; position: absolute; }
+/style
+script
+theadElement = document.createElement('thead');
+theadElement.setAttribute('class', 'listItem');
+document.documentElement.appendChild(theadElement);
+
+listItemElement = document.createElement('li');
+listItemElement.appendChild(document.createTextNode('PASS if no crash or assert in debug'));
+
+theadElement.appendChild(listItemElement);
+theadElement.appendChild(document.createElement('progress'));
+theadElement.appendChild(document.createElement('hgroup'));
+
+document.documentElement.offsetHeight;
+listItemElement.setAttribute('class', 'absPosition');
+document.documentElement.offsetHeight;
+listItemElement.setAttribute('class', 'colSpanAll');
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
Modified: trunk/Source/WebCore/ChangeLog (109244 => 109245)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 20:33:32 UTC (rev 109244)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 20:40:10 UTC (rev 109245)
@@ -1,3 +1,23 @@
+2012-02-29 Ken Buchanan ke...@chromium.org
+
+Crash when changing list marker locations
+https://bugs.webkit.org/show_bug.cgi?id=79681
+
+Reviewed by David Hyatt.
+
+This fixes a regression crash from r108548.
+
+There are some conditions where removing the anonymous block
+parent at that point can cause problems. One is when there is
+a continuation from it, and another when it is a sibling of
+lineBoxParent and it causes lineBoxParent to be deleted
+incidentally. This patch delays the
[webkit-changes] [109246] trunk/Source/WebCore
Title: [109246] trunk/Source/WebCore Revision 109246 Author jchaffr...@webkit.org Date 2012-02-29 12:49:49 -0800 (Wed, 29 Feb 2012) Log Message Stop doubling maximalOutlineSize during painting https://bugs.webkit.org/show_bug.cgi?id=79724 Reviewed by Tony Chang. Refactoring only, covered by existing tests (mostly repaint ones). * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::shouldPaint): * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintCollapsedBorders): Introduce a local repaint rectangle that we inflate by the maximalOutlineSize to simplify the comparison logic. Also tried to make it clearer what's going on by tweaking the existing code. * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintObject): Remove the doubling. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderReplaced.cpp trunk/Source/WebCore/rendering/RenderTableCell.cpp trunk/Source/WebCore/rendering/RenderTableSection.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (109245 => 109246) --- trunk/Source/WebCore/ChangeLog 2012-02-29 20:40:10 UTC (rev 109245) +++ trunk/Source/WebCore/ChangeLog 2012-02-29 20:49:49 UTC (rev 109246) @@ -1,3 +1,24 @@ +2012-02-29 Julien Chaffraix jchaffr...@webkit.org + +Stop doubling maximalOutlineSize during painting +https://bugs.webkit.org/show_bug.cgi?id=79724 + +Reviewed by Tony Chang. + +Refactoring only, covered by existing tests (mostly repaint ones). + +* rendering/RenderReplaced.cpp: +(WebCore::RenderReplaced::shouldPaint): +* rendering/RenderTableCell.cpp: +(WebCore::RenderTableCell::paintCollapsedBorders): +Introduce a local repaint rectangle that we inflate by the maximalOutlineSize +to simplify the comparison logic. Also tried to make it clearer what's going on +by tweaking the existing code. + +* rendering/RenderTableSection.cpp: +(WebCore::RenderTableSection::paintObject): +Remove the doubling. + 2012-02-29 Ken Buchanan ke...@chromium.org Crash when changing list marker locations Modified: trunk/Source/WebCore/rendering/RenderReplaced.cpp (109245 => 109246) --- trunk/Source/WebCore/rendering/RenderReplaced.cpp 2012-02-29 20:40:10 UTC (rev 109245) +++ trunk/Source/WebCore/rendering/RenderReplaced.cpp 2012-02-29 20:49:49 UTC (rev 109246) @@ -196,10 +196,12 @@ bottom = max(selBottom, bottom); } -LayoutUnit os = 2 * maximalOutlineSize(paintInfo.phase); -if (adjustedPaintOffset.x() + minXVisualOverflow() = paintInfo.rect.maxX() + os || adjustedPaintOffset.x() + maxXVisualOverflow() = paintInfo.rect.x() - os) +LayoutRect localRepaintRect = paintInfo.rect; +localRepaintRect.inflate(maximalOutlineSize(paintInfo.phase)); +if (adjustedPaintOffset.x() + minXVisualOverflow() = localRepaintRect.maxX() || adjustedPaintOffset.x() + maxXVisualOverflow() = localRepaintRect.x()) return false; -if (top = paintInfo.rect.maxY() + os || bottom = paintInfo.rect.y() - os) + +if (top = localRepaintRect.maxY() || bottom = localRepaintRect.y()) return false; return true; Modified: trunk/Source/WebCore/rendering/RenderTableCell.cpp (109245 => 109246) --- trunk/Source/WebCore/rendering/RenderTableCell.cpp 2012-02-29 20:40:10 UTC (rev 109245) +++ trunk/Source/WebCore/rendering/RenderTableCell.cpp 2012-02-29 20:49:49 UTC (rev 109246) @@ -960,18 +960,20 @@ if (!paintInfo.shouldPaintWithinRoot(this) || style()-visibility() != VISIBLE) return; -LayoutPoint adjustedPaintOffset = paintOffset + location(); -LayoutUnit os = 2 * maximalOutlineSize(paintInfo.phase); -if (!(adjustedPaintOffset.y() - table()-outerBorderTop() paintInfo.rect.maxY() + os - adjustedPaintOffset.y() + height() + table()-outerBorderBottom() paintInfo.rect.y() - os)) +LayoutRect localRepaintRect = paintInfo.rect; +localRepaintRect.inflate(maximalOutlineSize(paintInfo.phase)); + +LayoutRect paintRect = LayoutRect(paintOffset + location(), size()); +if (paintRect.y() - table()-outerBorderTop() = localRepaintRect.maxY()) return; +if (paintRect.maxY() + table()-outerBorderBottom() = localRepaintRect.y()) +return; + GraphicsContext* graphicsContext = paintInfo.context; if (!table()-currentBorderValue() || graphicsContext-paintingDisabled()) return; -LayoutRect paintRect = LayoutRect(adjustedPaintOffset, size()); - RenderStyle* tableStyle = table()-style(); CollapsedBorderValue leftVal = cachedCollapsedLeftBorder(tableStyle); CollapsedBorderValue rightVal = cachedCollapsedRightBorder(tableStyle); Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (109245 => 109246) --- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-02-29 20:40:10 UTC (rev 109245) +++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2012-02-29 20:49:49 UTC
[webkit-changes] [109247] branches/subpixellayout/Source/WebCore/rendering
Title: [109247] branches/subpixellayout/Source/WebCore/rendering Revision 109247 Author le...@chromium.org Date 2012-02-29 13:03:46 -0800 (Wed, 29 Feb 2012) Log Message Fixing table border painting and moving the rounding of paint offsets to InlineTextBoxes from RenderBlock. Modified Paths branches/subpixellayout/Source/WebCore/rendering/InlineTextBox.cpp branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp branches/subpixellayout/Source/WebCore/rendering/RenderTableCell.cpp Diff Modified: branches/subpixellayout/Source/WebCore/rendering/InlineTextBox.cpp (109246 => 109247) --- branches/subpixellayout/Source/WebCore/rendering/InlineTextBox.cpp 2012-02-29 20:49:49 UTC (rev 109246) +++ branches/subpixellayout/Source/WebCore/rendering/InlineTextBox.cpp 2012-02-29 21:03:46 UTC (rev 109247) @@ -475,16 +475,16 @@ ASSERT(paintInfo.phase != PaintPhaseSelfOutline paintInfo.phase != PaintPhaseChildOutlines); +LayoutPoint adjustedPaintOffset = roundedIntPoint(paintOffset); + LayoutUnit logicalLeftSide = logicalLeftVisualOverflow(); LayoutUnit logicalRightSide = logicalRightVisualOverflow(); -LayoutUnit logicalStart = logicalLeftSide + (isHorizontal() ? paintOffset.x() : paintOffset.y()); +LayoutUnit logicalStart = logicalLeftSide + (isHorizontal() ? adjustedPaintOffset.x() : adjustedPaintOffset.y()); LayoutUnit logicalExtent = logicalRightSide - logicalLeftSide; LayoutUnit paintEnd = isHorizontal() ? paintInfo.rect.maxX() : paintInfo.rect.maxY(); LayoutUnit paintStart = isHorizontal() ? paintInfo.rect.x() : paintInfo.rect.y(); -LayoutPoint adjustedPaintOffset = paintOffset; - if (logicalStart = paintEnd || logicalStart + logicalExtent = paintStart) return; Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp (109246 => 109247) --- branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp 2012-02-29 20:49:49 UTC (rev 109246) +++ branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp 2012-02-29 21:03:46 UTC (rev 109247) @@ -2710,13 +2710,10 @@ if (document()-didLayoutWithPendingStylesheets() !isRenderView()) return; -// We don't want to hand off painting in the line box tree with the accumulated error of the render tree, as this will cause -// us to mess up painting aligned things (such as underlines in text) with both the render tree and line box tree's error. -LayoutPoint roundedPaintOffset = roundedIntPoint(paintOffset); if (childrenInline()) -m_lineBoxes.paint(this, paintInfo, roundedPaintOffset); +m_lineBoxes.paint(this, paintInfo, paintOffset); else -paintChildren(paintInfo, roundedPaintOffset); +paintChildren(paintInfo, paintOffset); } void RenderBlock::paintChildren(PaintInfo paintInfo, const LayoutPoint paintOffset) Modified: branches/subpixellayout/Source/WebCore/rendering/RenderTableCell.cpp (109246 => 109247) --- branches/subpixellayout/Source/WebCore/rendering/RenderTableCell.cpp 2012-02-29 20:49:49 UTC (rev 109246) +++ branches/subpixellayout/Source/WebCore/rendering/RenderTableCell.cpp 2012-02-29 21:03:46 UTC (rev 109247) @@ -979,10 +979,10 @@ CollapsedBorderValue bottomVal = cachedCollapsedBottomBorder(tableStyle); // Adjust our x/y/width/height so that we paint the collapsed borders at the correct location. -LayoutUnit topWidth = topVal.width(); -LayoutUnit bottomWidth = bottomVal.width(); -LayoutUnit leftWidth = leftVal.width(); -LayoutUnit rightWidth = rightVal.width(); +int topWidth = topVal.width(); +int bottomWidth = bottomVal.width(); +int leftWidth = leftVal.width(); +int rightWidth = rightVal.width(); IntRect borderRect = pixelSnappedIntRect(paintRect.x() - leftWidth / 2, paintRect.y() - topWidth / 2, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109250] trunk/LayoutTests
Title: [109250] trunk/LayoutTests Revision 109250 Author ad...@chromium.org Date 2012-02-29 13:15:27 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed gardening, mark a test as waiting for rebaselining after a skia update. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109249 => 109250) --- trunk/LayoutTests/ChangeLog 2012-02-29 21:13:16 UTC (rev 109249) +++ trunk/LayoutTests/ChangeLog 2012-02-29 21:15:27 UTC (rev 109250) @@ -1,5 +1,11 @@ 2012-02-29 Adam Klein ad...@chromium.org +Unreviewed gardening, mark a test as waiting for rebaselining after a skia update. + +* platform/chromium/test_expectations.txt: + +2012-02-29 Adam Klein ad...@chromium.org + Unreviewed gardening, remove incorrect platform-specific expectation. * platform/chromium-win/fast/events/message-port-multi-expected.txt: Removed. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109249 => 109250) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 21:13:16 UTC (rev 109249) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 21:15:27 UTC (rev 109250) @@ -4466,3 +4466,6 @@ BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-n.html = IMAGE BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-ne.html = IMAGE BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-w.html = IMAGE + +// EPOGER: To be rebaselined after skia rev. 3283 lands in webkit +BUGCR116252 LINUX : platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109251] trunk
Title: [109251] trunk
Revision 109251
Author commit-qu...@webkit.org
Date 2012-02-29 13:17:28 -0800 (Wed, 29 Feb 2012)
Log Message
ShadowRoot need innerHTML
https://bugs.webkit.org/show_bug.cgi?id=78473
Patch by Kaustubh Atrawalkar kaust...@motorola.com on 2012-02-29
Reviewed by Hajime Morita.
Source/WebCore:
Refactor code for sharing common code between HTMLElement ShadowRoot.
Implement innerHTML attribute for ShadowRoot.
Test: fast/dom/shadow/shadow-root-innerHTML.html
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
(WebCore):
(WebCore::ShadowRoot::innerHTML):
(WebCore::ShadowRoot::setInnerHTML):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/ShadowRoot.idl:
* editing/markup.cpp:
(WebCore::urlToMarkup):
(WebCore):
(WebCore::createFragmentFromSource):
(WebCore::hasOneChild):
(WebCore::hasOneTextChild):
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
* editing/markup.h:
* html/HTMLElement.cpp:
(WebCore):
LayoutTests:
Implement innerHTML attribute for ShadowRoot.
* fast/dom/shadow/shadow-root-innerHTML-expected.txt: Added.
* fast/dom/shadow/shadow-root-innerHTML.html: Added.
* platform/qt/Skipped: Added test case in Skipped as ShadowRoot is supported by Chromium only.
* platform/mac/Skipped: ditto.
* platform/win/Skipped: ditto.
* platform/wincairo/Skipped: ditto.
* platform/wk2/Skipped: ditto.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/dom/ShadowRoot.h
trunk/Source/WebCore/dom/ShadowRoot.idl
trunk/Source/WebCore/editing/markup.cpp
trunk/Source/WebCore/editing/markup.h
trunk/Source/WebCore/html/HTMLElement.cpp
Added Paths
trunk/LayoutTests/fast/dom/shadow/shadow-root-innerHTML-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-root-innerHTML.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109250 => 109251)
--- trunk/LayoutTests/ChangeLog 2012-02-29 21:15:27 UTC (rev 109250)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 21:17:28 UTC (rev 109251)
@@ -1,3 +1,20 @@
+2012-02-29 Kaustubh Atrawalkar kaust...@motorola.com
+
+ShadowRoot need innerHTML
+https://bugs.webkit.org/show_bug.cgi?id=78473
+
+Reviewed by Hajime Morita.
+
+Implement innerHTML attribute for ShadowRoot.
+
+* fast/dom/shadow/shadow-root-innerHTML-expected.txt: Added.
+* fast/dom/shadow/shadow-root-innerHTML.html: Added.
+* platform/qt/Skipped: Added test case in Skipped as ShadowRoot is supported by Chromium only.
+* platform/mac/Skipped: ditto.
+* platform/win/Skipped: ditto.
+* platform/wincairo/Skipped: ditto.
+* platform/wk2/Skipped: ditto.
+
2012-02-29 Adam Klein ad...@chromium.org
Unreviewed gardening, mark a test as waiting for rebaselining after a skia update.
Added: trunk/LayoutTests/fast/dom/shadow/shadow-root-innerHTML-expected.txt (0 => 109251)
--- trunk/LayoutTests/fast/dom/shadow/shadow-root-innerHTML-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-root-innerHTML-expected.txt 2012-02-29 21:17:28 UTC (rev 109251)
@@ -0,0 +1,18 @@
+This tests the innerHTML property of a shadow root.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+
+PASS 'innerHTML' in internals.shadowRoot is false
+PASS root.innerHTML is defined.
+PASS root.innerHTML is 'div id=div1/divdiv id=div2/div'
+PASS root.innerHTML is 'Hello'
+PASS root.innerHTML is 'p id=p3HelloWorld/p'
+PASS root.firstChild.nodeName is 'P'
+PASS root.querySelectorAll('div') is []
+PASS root.getElementById('p3').innerHTML is 'HelloWorld'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/shadow/shadow-root-innerHTML.html (0 => 109251)
--- trunk/LayoutTests/fast/dom/shadow/shadow-root-innerHTML.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-root-innerHTML.html 2012-02-29 21:17:28 UTC (rev 109251)
@@ -0,0 +1,49 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+div id=console
+/div
+script
+description(This tests the innerHTML property of a shadow root.);
+
+if (!window.internals)
+debug('This test runs on DRT only');
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+
+host = document.createElement(div);
+document.body.appendChild(host);
+root = new WebKitShadowRoot(host);
+
+var div1 = document.createElement(div);
+div1.setAttribute(id, div1);
+root.appendChild(div1);
+
+var div2 = document.createElement(div);
+div2.setAttribute(id, div2);
+root.appendChild(div2);
+
+shouldBeFalse('innerHTML' in internals.shadowRoot);
+shouldBeDefined(root.innerHTML);
+shouldBe(root.innerHTML, 'div id=\div1\/divdiv id=\div2\/div');
+
+root.innerHTML = Hello;
[webkit-changes] [109252] trunk/Source/WebCore
Title: [109252] trunk/Source/WebCore
Revision 109252
Author leo.y...@torchmobile.com.cn
Date 2012-02-29 13:25:24 -0800 (Wed, 29 Feb 2012)
Log Message
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatPoint.h
https://bugs.webkit.org/show_bug.cgi?id=79887
Reviewed by Antonio Gomes.
Add conversion convenience between WebCore::FloatPoint and BlackBerry::Platform::FloatPoint.
The porting can't be built yet, no new tests.
* platform/graphics/FloatPoint.h:
(Platform):
(FloatPoint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FloatPoint.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109251 => 109252)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 21:17:28 UTC (rev 109251)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 21:25:24 UTC (rev 109252)
@@ -1,3 +1,18 @@
+2012-02-29 Leo Yang leo.y...@torchmobile.com.cn
+
+[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatPoint.h
+https://bugs.webkit.org/show_bug.cgi?id=79887
+
+Reviewed by Antonio Gomes.
+
+Add conversion convenience between WebCore::FloatPoint and BlackBerry::Platform::FloatPoint.
+
+The porting can't be built yet, no new tests.
+
+* platform/graphics/FloatPoint.h:
+(Platform):
+(FloatPoint):
+
2012-02-29 Kaustubh Atrawalkar kaust...@motorola.com
ShadowRoot need innerHTML
Modified: trunk/Source/WebCore/platform/graphics/FloatPoint.h (109251 => 109252)
--- trunk/Source/WebCore/platform/graphics/FloatPoint.h 2012-02-29 21:17:28 UTC (rev 109251)
+++ trunk/Source/WebCore/platform/graphics/FloatPoint.h 2012-02-29 21:25:24 UTC (rev 109252)
@@ -31,6 +31,14 @@
#include IntPoint.h
#include wtf/MathExtras.h
+#if PLATFORM(BLACKBERRY)
+namespace BlackBerry {
+namespace Platform {
+class FloatPoint;
+}
+}
+#endif
+
#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
typedef struct CGPoint CGPoint;
#endif
@@ -156,6 +164,11 @@
operator QPointF() const;
#endif
+#if PLATFORM(BLACKBERRY)
+FloatPoint(const BlackBerry::Platform::FloatPoint);
+operator BlackBerry::Platform::FloatPoint() const;
+#endif
+
#if USE(SKIA)
operator SkPoint() const;
FloatPoint(const SkPoint);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109253] trunk/LayoutTests
Title: [109253] trunk/LayoutTests Revision 109253 Author ad...@chromium.org Date 2012-02-29 13:27:19 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed gardening, mark some tests as passing on GPU tests. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109252 => 109253) --- trunk/LayoutTests/ChangeLog 2012-02-29 21:25:24 UTC (rev 109252) +++ trunk/LayoutTests/ChangeLog 2012-02-29 21:27:19 UTC (rev 109253) @@ -1,3 +1,9 @@ +2012-02-29 Adam Klein ad...@chromium.org + +Unreviewed gardening, mark some tests as passing on GPU tests. + +* platform/chromium/test_expectations.txt: + 2012-02-29 Kaustubh Atrawalkar kaust...@motorola.com ShadowRoot need innerHTML Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109252 => 109253) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 21:25:24 UTC (rev 109252) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 21:27:19 UTC (rev 109253) @@ -1989,8 +1989,8 @@ BUGWK45991 LINUX WIN : canvas/philip/tests/2d.gradient.radial.outside3.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.gradient.radial.touch1.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.gradient.radial.touch3.html = TEXT -BUGWK45991 LINUX WIN : canvas/philip/tests/2d.line.width.basic.html = TEXT -BUGWK45991 LINUX WIN : canvas/philip/tests/2d.line.width.transformed.html = TEXT +BUGWK45991 LINUX WIN CPU : canvas/philip/tests/2d.line.width.basic.html = TEXT +BUGWK45991 LINUX WIN CPU : canvas/philip/tests/2d.line.width.transformed.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.path.arc.angle.3.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.path.arc.angle.5.html = TEXT BUGWK45991 LINUX WIN CPU : canvas/philip/tests/2d.path.arcTo.shape.curve1.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109254] trunk/Source/WebKit/mac
Title: [109254] trunk/Source/WebKit/mac
Revision 109254
Author enr...@apple.com
Date 2012-02-29 13:28:00 -0800 (Wed, 29 Feb 2012)
Log Message
Crash at -[WebFrame(WebInternal) _setTypingStyle:withUndoAction:]
https://bugs.webkit.org/show_bug.cgi?id=79937
rdar://problem/10942936
Reviewed by Dan Bernstein.
* WebView/WebFrame.mm:
(-[WebFrame _setTypingStyle:withUndoAction:]): Adding a null check.
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebFrame.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (109253 => 109254)
--- trunk/Source/WebKit/mac/ChangeLog 2012-02-29 21:27:19 UTC (rev 109253)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-02-29 21:28:00 UTC (rev 109254)
@@ -1,3 +1,14 @@
+2012-02-29 Enrica Casucci enr...@apple.com
+
+Crash at -[WebFrame(WebInternal) _setTypingStyle:withUndoAction:]
+https://bugs.webkit.org/show_bug.cgi?id=79937
+rdar://problem/10942936
+
+Reviewed by Dan Bernstein.
+
+* WebView/WebFrame.mm:
+(-[WebFrame _setTypingStyle:withUndoAction:]): Adding a null check.
+
2012-02-28 Simon Fraser simon.fra...@apple.com
Update WebKitSystemInterface.
Modified: trunk/Source/WebKit/mac/WebView/WebFrame.mm (109253 => 109254)
--- trunk/Source/WebKit/mac/WebView/WebFrame.mm 2012-02-29 21:27:19 UTC (rev 109253)
+++ trunk/Source/WebKit/mac/WebView/WebFrame.mm 2012-02-29 21:28:00 UTC (rev 109254)
@@ -797,7 +797,7 @@
- (void)_setTypingStyle:(DOMCSSStyleDeclaration *)style withUndoAction:(EditAction)undoAction
{
-if (!_private-coreFrame)
+if (!_private-coreFrame || !style)
return;
// FIXME: We shouldn't have to create a copy here.
_private-coreFrame-editor()-computeAndSetTypingStyle(core(style)-copy().get(), undoAction);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109255] trunk
Title: [109255] trunk Revision 109255 Author timothy_hor...@apple.com Date 2012-02-29 13:36:12 -0800 (Wed, 29 Feb 2012) Log Message Make use of CG rounded-rect primitives https://bugs.webkit.org/show_bug.cgi?id=79932 rdar://problem/9274953 Reviewed by Simon Fraser. Dispatch to potentially platform-specific rounded rectangle path construction from addPathForRoundedRect. Make use of this to call wkCGPathAddRoundedRect on Lion and above, as long as the rounded corners are all equivalent. No new tests, as this is covered by many that use rounded corners, and is only a performance improvement. * WebCore.exp.in: * platform/graphics/Path.cpp: (WebCore::Path::addRoundedRect): (WebCore): (WebCore::Path::addPathForRoundedRect): * platform/graphics/Path.h: (Path): * platform/graphics/cg/PathCG.cpp: (WebCore::Path::addPathForRoundedRect): (WebCore): * platform/mac/WebCoreSystemInterface.h: * platform/mac/WebCoreSystemInterface.mm: Add wkCGPathAddRoundedRect. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): * WebKitSystemInterface.h: * libWebKitSystemInterfaceLeopard.a: * libWebKitSystemInterfaceLion.a: * libWebKitSystemInterfaceSnowLeopard.a: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/platform/graphics/Path.cpp trunk/Source/WebCore/platform/graphics/Path.h trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/WebKitSystemInterface.h trunk/WebKitLibraries/libWebKitSystemInterfaceLeopard.a trunk/WebKitLibraries/libWebKitSystemInterfaceLion.a trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a Diff Modified: trunk/Source/WebCore/ChangeLog (109254 => 109255) --- trunk/Source/WebCore/ChangeLog 2012-02-29 21:28:00 UTC (rev 109254) +++ trunk/Source/WebCore/ChangeLog 2012-02-29 21:36:12 UTC (rev 109255) @@ -1,3 +1,32 @@ +2012-02-29 Tim Horton timothy_hor...@apple.com + +Make use of CG rounded-rect primitives +https://bugs.webkit.org/show_bug.cgi?id=79932 +rdar://problem/9274953 + +Reviewed by Simon Fraser. + +Dispatch to potentially platform-specific rounded rectangle path +construction from addPathForRoundedRect. Make use of this to call +wkCGPathAddRoundedRect on Lion and above, as long as the rounded +corners are all equivalent. + +No new tests, as this is covered by many that use rounded corners, +and is only a performance improvement. + +* WebCore.exp.in: +* platform/graphics/Path.cpp: +(WebCore::Path::addRoundedRect): +(WebCore): +(WebCore::Path::addPathForRoundedRect): +* platform/graphics/Path.h: +(Path): +* platform/graphics/cg/PathCG.cpp: +(WebCore::Path::addPathForRoundedRect): +(WebCore): +* platform/mac/WebCoreSystemInterface.h: +* platform/mac/WebCoreSystemInterface.mm: + 2012-02-29 Leo Yang leo.y...@torchmobile.com.cn [BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatPoint.h Modified: trunk/Source/WebCore/WebCore.exp.in (109254 => 109255) --- trunk/Source/WebCore/WebCore.exp.in 2012-02-29 21:28:00 UTC (rev 109254) +++ trunk/Source/WebCore/WebCore.exp.in 2012-02-29 21:36:12 UTC (rev 109255) @@ -1516,6 +1516,9 @@ #endif _wkCGContextGetShouldSmoothFonts _wkCGContextResetClip +#if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD) +_wkCGPathAddRoundedRect +#endif _wkCGPatternCreateWithImageAndTransform _wkCopyCFLocalizationPreferredName _wkCopyCFURLResponseSuggestedFilename Modified: trunk/Source/WebCore/platform/graphics/Path.cpp (109254 => 109255) --- trunk/Source/WebCore/platform/graphics/Path.cpp 2012-02-29 21:28:00 UTC (rev 109254) +++ trunk/Source/WebCore/platform/graphics/Path.cpp 2012-02-29 21:36:12 UTC (rev 109255) @@ -115,7 +115,7 @@ if (radius.height() halfSize.height()) radius.setHeight(halfSize.height()); -addBeziersForRoundedRect(rect, radius, radius, radius, radius); +addPathForRoundedRect(rect, radius, radius, radius, radius); } void Path::addRoundedRect(const FloatRect rect, const FloatSize topLeftRadius, const FloatSize topRightRadius, const FloatSize bottomLeftRadius, const FloatSize bottomRightRadius) @@ -132,8 +132,15 @@ return; } +addPathForRoundedRect(rect, topLeftRadius, topRightRadius, bottomLeftRadius, bottomRightRadius); +} + +#if !USE(CG) +void Path::addPathForRoundedRect(const FloatRect rect, const FloatSize topLeftRadius, const FloatSize
[webkit-changes] [109256] trunk/Source/WebCore
Title: [109256] trunk/Source/WebCore
Revision 109256
Author leo.y...@torchmobile.com.cn
Date 2012-02-29 13:41:33 -0800 (Wed, 29 Feb 2012)
Log Message
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatRect.h
https://bugs.webkit.org/show_bug.cgi?id=79891
Reviewed by Antonio Gomes.
Add conversion convenience between WebCore::FloatRect and BlackBerry::Platform::FloatRect.
The porting can't be built yet, no new tests.
* platform/graphics/FloatRect.h:
(Platform):
(FloatRect):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FloatRect.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109255 => 109256)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 21:36:12 UTC (rev 109255)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 21:41:33 UTC (rev 109256)
@@ -1,3 +1,18 @@
+2012-02-29 Leo Yang leo.y...@torchmobile.com.cn
+
+[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatRect.h
+https://bugs.webkit.org/show_bug.cgi?id=79891
+
+Reviewed by Antonio Gomes.
+
+Add conversion convenience between WebCore::FloatRect and BlackBerry::Platform::FloatRect.
+
+The porting can't be built yet, no new tests.
+
+* platform/graphics/FloatRect.h:
+(Platform):
+(FloatRect):
+
2012-02-29 Tim Horton timothy_hor...@apple.com
Make use of CG rounded-rect primitives
Modified: trunk/Source/WebCore/platform/graphics/FloatRect.h (109255 => 109256)
--- trunk/Source/WebCore/platform/graphics/FloatRect.h 2012-02-29 21:36:12 UTC (rev 109255)
+++ trunk/Source/WebCore/platform/graphics/FloatRect.h 2012-02-29 21:41:33 UTC (rev 109256)
@@ -52,6 +52,14 @@
class wxRect2DDouble;
#endif
+#if PLATFORM(BLACKBERRY)
+namespace BlackBerry {
+namespace Platform {
+class FloatRect;
+}
+}
+#endif
+
#if USE(SKIA)
struct SkRect;
#endif
@@ -181,6 +189,11 @@
void fitToPoints(const FloatPoint p0, const FloatPoint p1, const FloatPoint p2);
void fitToPoints(const FloatPoint p0, const FloatPoint p1, const FloatPoint p2, const FloatPoint p3);
+#if PLATFORM(BLACKBERRY)
+FloatRect(const BlackBerry::Platform::FloatRect);
+operator BlackBerry::Platform::FloatRect() const;
+#endif
+
#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
FloatRect(const CGRect);
operator CGRect() const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109257] trunk/LayoutTests
Title: [109257] trunk/LayoutTests Revision 109257 Author ad...@chromium.org Date 2012-02-29 13:49:12 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed gardening, remove a bunch of expectations for now-passing tests. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109256 => 109257) --- trunk/LayoutTests/ChangeLog 2012-02-29 21:41:33 UTC (rev 109256) +++ trunk/LayoutTests/ChangeLog 2012-02-29 21:49:12 UTC (rev 109257) @@ -1,5 +1,11 @@ 2012-02-29 Adam Klein ad...@chromium.org +Unreviewed gardening, remove a bunch of expectations for now-passing tests. + +* platform/chromium/test_expectations.txt: + +2012-02-29 Adam Klein ad...@chromium.org + Unreviewed gardening, mark some tests as passing on GPU tests. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109256 => 109257) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 21:41:33 UTC (rev 109256) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 21:49:12 UTC (rev 109257) @@ -1630,7 +1630,7 @@ BUGCR11251 LINUX WIN RELEASE : fast/forms/text-control-intrinsic-widths.html = FAIL BUGCR11251 LINUX WIN DEBUG : fast/forms/text-control-intrinsic-widths.html = FAIL BUGCR11251 LINUX WIN : svg/custom/svg-fonts-in-text-controls.html = FAIL -BUGCR11251 : fast/forms/textarea-metrics.html = FAIL +BUGCR11251 LINUX WIN : fast/forms/textarea-metrics.html = FAIL // Regresssions from WebKit Merge 43114:43242 that just need to be re-baselined. BUGCR11483 LINUX : fast/forms/input-text-double-click.html = FAIL @@ -1999,8 +1999,8 @@ BUGWK45991 LINUX WIN : canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html = TEXT BUGWK45991 LINUX WIN CPU : canvas/philip/tests/2d.shadow.enable.blur.html = TEXT -BUGWK45991 : canvas/philip/tests/2d.transformation.setTransform.skewed.html = TEXT -BUGWK45991 : canvas/philip/tests/2d.transformation.transform.skewed.html = TEXT +BUGWK45991 LINUX WIN : canvas/philip/tests/2d.transformation.setTransform.skewed.html = TEXT +BUGWK45991 LINUX WIN : canvas/philip/tests/2d.transformation.transform.skewed.html = TEXT // These SVG tests have been flaky on Win from quite some time. // Hard to pin down which roll introduced the flakiness. @@ -3549,7 +3549,7 @@ // Crashes due to an OOM error on V8. BUGCR108832 SKIP : fast/js/array-splice.html = CRASH -BUGWK75418 : css2.1/20110323/border-collapse-offset-002.htm = MISSING +BUGWK75418 WIN LINUX : css2.1/20110323/border-collapse-offset-002.htm = MISSING BUGWK75430 MAC : plugins/iframe-plugin-bgcolor.html = TEXT TIMEOUT BUGWK75468 : fast/js/kde/GlobalObject.html = TEXT @@ -3564,8 +3564,6 @@ BUGWK75716 : fullscreen/video-controls-drag.html = TEXT -BUGWK75742 MAC : fast/forms/input-disabled-color.html = IMAGE - BUGWK75786 SKIP : compositing/tiled-layers-hidpi.html = TIMEOUT BUGWK75787 MAC LINUX : fast/text/international/spaces-combined-in-vertical-text.html = TIMEOUT TEXT @@ -3597,7 +3595,6 @@ BUGWK77187 WIN GPU : fast/canvas/quadraticCurveTo.xml = IMAGE -BUGWK76511 : compositing/geometry/clipped-video-controller.html = IMAGE BUGWK76511 : compositing/geometry/video-opacity-overlay.html = IMAGE BUGWK76511 : compositing/geometry/video-fixed-scrolling.html = IMAGE BUGWK76511 : compositing/visibility/visibility-simple-video-layer.html = IMAGE @@ -4428,7 +4425,6 @@ BUGWK79642 : accessibility/aria-describedby-on-input.html = TIMEOUT BUGWK79642 : fast/loader/subresource-willSendRequest-null.html = TIMEOUT -BUGWK79642 : media/video-playbackrate.html = TIMEOUT BUGWK79702 : fast/regex/lastIndex.html = TEXT BUGWK79703 : fast/regex/overflow.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109258] trunk/Tools
Title: [109258] trunk/Tools Revision 109258 Author e...@google.com Date 2012-02-29 14:05:18 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed, add myself as a reviewer * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (109257 => 109258) --- trunk/Tools/ChangeLog 2012-02-29 21:49:12 UTC (rev 109257) +++ trunk/Tools/ChangeLog 2012-02-29 22:05:18 UTC (rev 109258) @@ -1,3 +1,9 @@ +2012-02-29 Adrienne Walker e...@google.com + +Unreviewed, add myself as a reviewer + +* Scripts/webkitpy/common/config/committers.py: + 2012-02-29 Greg Billock gbill...@google.com Add more tests for web intents Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (109257 => 109258) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-02-29 21:49:12 UTC (rev 109257) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-02-29 22:05:18 UTC (rev 109258) @@ -164,7 +164,6 @@ Committer(Adam Klein, ad...@chromium.org, aklein), Committer(Adam Langley, a...@chromium.org, agl), Committer(Ademar de Souza Reis Jr, [ademar.r...@gmail.com, ade...@webkit.org], ademar), -Committer(Adrienne Walker, [e...@google.com, e...@chromium.org], enne), Committer(Albert J. Wong, ajw...@chromium.org), Committer(Alexander Kellett, [lypa...@mac.com, a-lists...@lypanov.net, lypa...@kde.org], lypanov), Committer(Alexander Pavlov, apav...@chromium.org, apavlov), @@ -376,8 +375,9 @@ Reviewer(Adam Barth, aba...@webkit.org, abarth), Reviewer(Adam Roben, [aro...@webkit.org, aro...@apple.com], aroben), Reviewer(Adam Treat, [tr...@kde.org, tr...@webkit.org, atr...@rim.com], manyoso), +Reviewer(Adele Peterson, ad...@apple.com, adele), +Reviewer(Adrienne Walker, [e...@google.com, e...@chromium.org], enne), Reviewer(Alejandro G. Castro, [a...@igalia.com, a...@webkit.org], alexg__), -Reviewer(Adele Peterson, ad...@apple.com, adele), Reviewer(Alexey Proskuryakov, [a...@webkit.org, a...@apple.com], ap), Reviewer(Alice Liu, alice@apple.com, aliu), Reviewer(Alp Toker, [a...@nuanti.com, a...@atoker.com, a...@webkit.org], alp), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109259] trunk/Source/WebCore
Title: [109259] trunk/Source/WebCore
Revision 109259
Author leo.y...@torchmobile.com.cn
Date 2012-02-29 14:11:06 -0800 (Wed, 29 Feb 2012)
Log Message
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatSize.h
https://bugs.webkit.org/show_bug.cgi?id=79893
Reviewed by Antonio Gomes.
Add conversion convenience between WebCore::FloatSize and BlackBerry::Platform::FloatSize.
The porting can't be built yet, no new tests.
* platform/graphics/FloatSize.h:
(Platform):
(FloatSize):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FloatSize.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109258 => 109259)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 22:05:18 UTC (rev 109258)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 22:11:06 UTC (rev 109259)
@@ -1,5 +1,20 @@
2012-02-29 Leo Yang leo.y...@torchmobile.com.cn
+[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatSize.h
+https://bugs.webkit.org/show_bug.cgi?id=79893
+
+Reviewed by Antonio Gomes.
+
+Add conversion convenience between WebCore::FloatSize and BlackBerry::Platform::FloatSize.
+
+The porting can't be built yet, no new tests.
+
+* platform/graphics/FloatSize.h:
+(Platform):
+(FloatSize):
+
+2012-02-29 Leo Yang leo.y...@torchmobile.com.cn
+
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatRect.h
https://bugs.webkit.org/show_bug.cgi?id=79891
Modified: trunk/Source/WebCore/platform/graphics/FloatSize.h (109258 => 109259)
--- trunk/Source/WebCore/platform/graphics/FloatSize.h 2012-02-29 22:05:18 UTC (rev 109258)
+++ trunk/Source/WebCore/platform/graphics/FloatSize.h 2012-02-29 22:11:06 UTC (rev 109259)
@@ -31,6 +31,14 @@
#include IntPoint.h
#include wtf/MathExtras.h
+#if PLATFORM(BLACKBERRY)
+namespace BlackBerry {
+namespace Platform {
+class FloatSize;
+}
+}
+#endif
+
#if USE(CG) || (PLATFORM(WX) OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
typedef struct CGSize CGSize;
#endif
@@ -106,6 +114,11 @@
return FloatSize(m_height, m_width);
}
+#if PLATFORM(BLACKBERRY)
+FloatSize(const BlackBerry::Platform::FloatSize);
+operator BlackBerry::Platform::FloatSize() const;
+#endif
+
#if USE(CG) || (PLATFORM(WX) OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
explicit FloatSize(const CGSize); // don't do this implicitly since it's lossy
operator CGSize() const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109260] trunk/LayoutTests
Title: [109260] trunk/LayoutTests Revision 109260 Author ad...@chromium.org Date 2012-02-29 14:12:12 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed gardening, mark a few more tests as passing. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109259 => 109260) --- trunk/LayoutTests/ChangeLog 2012-02-29 22:11:06 UTC (rev 109259) +++ trunk/LayoutTests/ChangeLog 2012-02-29 22:12:12 UTC (rev 109260) @@ -1,5 +1,11 @@ 2012-02-29 Adam Klein ad...@chromium.org +Unreviewed gardening, mark a few more tests as passing. + +* platform/chromium/test_expectations.txt: + +2012-02-29 Adam Klein ad...@chromium.org + Unreviewed gardening, remove a bunch of expectations for now-passing tests. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109259 => 109260) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 22:11:06 UTC (rev 109259) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 22:12:12 UTC (rev 109260) @@ -2091,9 +2091,6 @@ BUGCR51854 SLOW WIN : http/tests/storage/callbacks-are-called-in-correct-context.html = PASS -// Regressions from r65229 -BUGWK43912 LINUX WIN : svg/custom/grayscale-gradient-mask.svg = IMAGE - // Times out frequently since the test was added BUGCR52017 LINUX MAC RELEASE : http/tests/misc/isindex-with-no-form.html = PASS TIMEOUT BUGCR52017 LINUX MAC DEBUG : http/tests/misc/isindex-with-no-form.html = PASS TIMEOUT CRASH @@ -3761,8 +3758,6 @@ // Started failing at WK r106432. BUGWK77519 WIN LINUX : fast/forms/textfield-overflow.html = IMAGE+TEXT -BUGWK77521 LINUX : fast/repaint/textarea-set-disabled.html = IMAGE -BUGWK77521 LINUX : fast/repaint/search-field-cancel.html = IMAGE BUGWK77526 WIN LINUX : svg/text/text-align-04-b.svg = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109261] trunk
Title: [109261] trunk
Revision 109261
Author tom...@google.com
Date 2012-02-29 14:13:54 -0800 (Wed, 29 Feb 2012)
Log Message
MediaStream API: MediaStreamTrackList out-of-bounds access fix
https://bugs.webkit.org/show_bug.cgi?id=79889
Reviewed by Adam Barth.
Out-of-bounds access to MediaStreamTrackList ASSERTS instead of returning 0,
this is not according to ecmascript standard. Also fixed a similar issue in MediaStreamList.
Source/WebCore:
Test: fast/mediastream/peerconnection-mediastreamlist.html
* Modules/mediastream/MediaStreamList.cpp:
(WebCore::MediaStreamList::item):
* Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::item):
LayoutTests:
* fast/mediastream/peerconnection-mediastreamlist-expected.txt: Added.
* fast/mediastream/peerconnection-mediastreamlist.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStreamList.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackList.cpp
Added Paths
trunk/LayoutTests/fast/mediastream/peerconnection-mediastreamlist-expected.txt
trunk/LayoutTests/fast/mediastream/peerconnection-mediastreamlist.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109260 => 109261)
--- trunk/LayoutTests/ChangeLog 2012-02-29 22:12:12 UTC (rev 109260)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 22:13:54 UTC (rev 109261)
@@ -1,3 +1,16 @@
+2012-02-29 Tommy Widenflycht tom...@google.com
+
+MediaStream API: MediaStreamTrackList out-of-bounds access fix
+https://bugs.webkit.org/show_bug.cgi?id=79889
+
+Reviewed by Adam Barth.
+
+Out-of-bounds access to MediaStreamTrackList ASSERTS instead of returning 0,
+this is not according to ecmascript standard. Also fixed a similar issue in MediaStreamList.
+
+* fast/mediastream/peerconnection-mediastreamlist-expected.txt: Added.
+* fast/mediastream/peerconnection-mediastreamlist.html: Added.
+
2012-02-29 Adam Klein ad...@chromium.org
Unreviewed gardening, mark a few more tests as passing.
Added: trunk/LayoutTests/fast/mediastream/peerconnection-mediastreamlist-expected.txt (0 => 109261)
--- trunk/LayoutTests/fast/mediastream/peerconnection-mediastreamlist-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/mediastream/peerconnection-mediastreamlist-expected.txt 2012-02-29 22:13:54 UTC (rev 109261)
@@ -0,0 +1,10 @@
+This test confirms that out-of-bounds access of MediaStreamList returns undefined.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS pc.localStreams[0xbadc0ded] is undefined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/mediastream/peerconnection-mediastreamlist.html (0 => 109261)
--- trunk/LayoutTests/fast/mediastream/peerconnection-mediastreamlist.html (rev 0)
+++ trunk/LayoutTests/fast/mediastream/peerconnection-mediastreamlist.html 2012-02-29 22:13:54 UTC (rev 109261)
@@ -0,0 +1,22 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+/body
+script
+description(This test confirms that out-of-bounds access of MediaStreamList returns undefined.);
+
+var pc = new webkitPeerConnection(, function() {});
+
+shouldBeUndefined('pc.localStreams[0xbadc0ded]');
+
+window.successfullyParsed = true;
+
+/script
+script src=""
+/html
Modified: trunk/Source/WebCore/ChangeLog (109260 => 109261)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 22:12:12 UTC (rev 109260)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 22:13:54 UTC (rev 109261)
@@ -1,3 +1,20 @@
+2012-02-29 Tommy Widenflycht tom...@google.com
+
+MediaStream API: MediaStreamTrackList out-of-bounds access fix
+https://bugs.webkit.org/show_bug.cgi?id=79889
+
+Reviewed by Adam Barth.
+
+Out-of-bounds access to MediaStreamTrackList ASSERTS instead of returning 0,
+this is not according to ecmascript standard. Also fixed a similar issue in MediaStreamList.
+
+Test: fast/mediastream/peerconnection-mediastreamlist.html
+
+* Modules/mediastream/MediaStreamList.cpp:
+(WebCore::MediaStreamList::item):
+* Modules/mediastream/MediaStreamTrackList.cpp:
+(WebCore::MediaStreamTrackList::item):
+
2012-02-29 Leo Yang leo.y...@torchmobile.com.cn
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatSize.h
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamList.cpp (109260 => 109261)
--- trunk/Source/WebCore/Modules/mediastream/MediaStreamList.cpp 2012-02-29 22:12:12 UTC (rev 109260)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamList.cpp 2012-02-29 22:13:54 UTC (rev 109261)
@@ -50,6 +50,8 @@
MediaStream* MediaStreamList::item(unsigned index) const
{
+if (index = m_streams.size())
+return 0;
return
[webkit-changes] [109263] trunk/Source
Title: [109263] trunk/Source
Revision 109263
Author commit-qu...@webkit.org
Date 2012-02-29 14:35:01 -0800 (Wed, 29 Feb 2012)
Log Message
[chromium] Don't let invalidation for next frame prevent tile upload
https://bugs.webkit.org/show_bug.cgi?id=79841
Patch by Dana Jansens dan...@chromium.org on 2012-02-29
Reviewed by James Robinson.
Source/WebCore:
We currently don't push dirty tiles to the impl thread so there are no
tiles with garbage data on the impl thread. However, this judgement is
overzealous and blocks tiles that get invalidated by WebKit for the
next frame during the paint of the current frame.
Instead, check if a tile is dirty and was not painted for the current
frame when deciding to push the tile to the impl thread. This requires
that we know if a tile was painted during the current frame, which we
can do if we always reset m_updateRect to be empty each frame.
New unit tests: TiledLayerChromiumTest.pushTilesMarkedDirtyDuringPaint
TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnNextLayer
TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnPreviousLayer
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdate):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
Source/WebKit/chromium:
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (109262 => 109263)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 22:30:33 UTC (rev 109262)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 22:35:01 UTC (rev 109263)
@@ -1,3 +1,34 @@
+2012-02-29 Dana Jansens dan...@chromium.org
+
+[chromium] Don't let invalidation for next frame prevent tile upload
+https://bugs.webkit.org/show_bug.cgi?id=79841
+
+Reviewed by James Robinson.
+
+We currently don't push dirty tiles to the impl thread so there are no
+tiles with garbage data on the impl thread. However, this judgement is
+overzealous and blocks tiles that get invalidated by WebKit for the
+next frame during the paint of the current frame.
+
+Instead, check if a tile is dirty and was not painted for the current
+frame when deciding to push the tile to the impl thread. This requires
+that we know if a tile was painted during the current frame, which we
+can do if we always reset m_updateRect to be empty each frame.
+
+New unit tests: TiledLayerChromiumTest.pushTilesMarkedDirtyDuringPaint
+TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnNextLayer
+TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnPreviousLayer
+
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::UpdatableTile::isDirtyForCurrentFrame):
+(WebCore::TiledLayerChromium::pushPropertiesTo):
+(WebCore::TiledLayerChromium::prepareToUpdateTiles):
+(WebCore::TiledLayerChromium::resetUpdateState):
+(WebCore):
+(WebCore::TiledLayerChromium::prepareToUpdate):
+* platform/graphics/chromium/TiledLayerChromium.h:
+(TiledLayerChromium):
+
2012-02-29 Tommy Widenflycht tom...@google.com
MediaStream API: MediaStreamTrackList out-of-bounds access fix
Modified: trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp (109262 => 109263)
--- trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2012-02-29 22:30:33 UTC (rev 109262)
+++ trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2012-02-29 22:35:01 UTC (rev 109263)
@@ -67,6 +67,7 @@
m_updateRect = m_dirtyRect;
m_dirtyRect = IntRect();
}
+bool isDirtyForCurrentFrame() { return !m_dirtyRect.isEmpty() m_updateRect.isEmpty(); }
IntRect m_dirtyRect;
IntRect m_updateRect;
@@ -263,7 +264,7 @@
invalidTiles.append(tile);
continue;
}
-if (tile-isDirty())
+if (tile-isDirtyForCurrentFrame())
continue;
tiledLayer-pushTileProperties(i, j, tile-managedTexture()-textureId(), tile-m_opaqueRect);
@@ -398,13 +399,6 @@
void TiledLayerChromium::prepareToUpdateTiles(bool idle, int left, int top, int right, int bottom)
{
-// Reset m_updateRect for all tiles.
-for (CCLayerTilingData::TileMap::const_iterator iter = m_tiler-tiles().begin(); iter != m_tiler-tiles().end(); ++iter) {
-
[webkit-changes] [109264] trunk/Tools
Title: [109264] trunk/Tools
Revision 109264
Author dpra...@chromium.org
Date 2012-02-29 14:40:32 -0800 (Wed, 29 Feb 2012)
Log Message
nrwt: support more than two drivers in DriverProxy
https://bugs.webkit.org/show_bug.cgi?id=79736
Reviewed by Adam Barth.
Now that we can support per-test command lines for
Drivers, modify DriverProxy to keep a map of running
drivers for each needed command-line; this will allow
us to transparently maintain a pool of appropriately
configured DRTs without having to constantly start and stop
them.
Note that this potentially raises a garbage collection
problem - the number of running DRTs will grow with the
number of different sets of command line args. For now
this is no worse than the current code - if you're running
with pixel tests, you will only need one DRT per worker,
and if you aren't, you'll need two (one for text-only tests,
and one for reftests).
An alternative would be to only ever have one running driver,
and restart the driver as the command line changes, but this
might (?) slow down execution in the text-only case - we
should benchmark this because it would be simpler and possibly
allow us to eliminate DriverProxy altogether.
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverProxy.__init__):
(DriverProxy):
(DriverProxy._make_driver):
(DriverProxy.run_test):
(DriverProxy.has_crashed):
(DriverProxy.stop):
(DriverProxy.cmd_line):
(DriverProxy._cmd_line_as_key):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
Diff
Modified: trunk/Tools/ChangeLog (109263 => 109264)
--- trunk/Tools/ChangeLog 2012-02-29 22:35:01 UTC (rev 109263)
+++ trunk/Tools/ChangeLog 2012-02-29 22:40:32 UTC (rev 109264)
@@ -1,3 +1,41 @@
+2012-02-29 Dirk Pranke dpra...@chromium.org
+
+nrwt: support more than two drivers in DriverProxy
+https://bugs.webkit.org/show_bug.cgi?id=79736
+
+Reviewed by Adam Barth.
+
+Now that we can support per-test command lines for
+Drivers, modify DriverProxy to keep a map of running
+drivers for each needed command-line; this will allow
+us to transparently maintain a pool of appropriately
+configured DRTs without having to constantly start and stop
+them.
+
+Note that this potentially raises a garbage collection
+problem - the number of running DRTs will grow with the
+number of different sets of command line args. For now
+this is no worse than the current code - if you're running
+with pixel tests, you will only need one DRT per worker,
+and if you aren't, you'll need two (one for text-only tests,
+and one for reftests).
+
+An alternative would be to only ever have one running driver,
+and restart the driver as the command line changes, but this
+might (?) slow down execution in the text-only case - we
+should benchmark this because it would be simpler and possibly
+allow us to eliminate DriverProxy altogether.
+
+* Scripts/webkitpy/layout_tests/port/driver.py:
+(DriverProxy.__init__):
+(DriverProxy):
+(DriverProxy._make_driver):
+(DriverProxy.run_test):
+(DriverProxy.has_crashed):
+(DriverProxy.stop):
+(DriverProxy.cmd_line):
+(DriverProxy._cmd_line_as_key):
+
2012-02-29 Adrienne Walker e...@google.com
Unreviewed, add myself as a reviewer
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py (109263 => 109264)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-02-29 22:35:01 UTC (rev 109263)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py 2012-02-29 22:40:32 UTC (rev 109264)
@@ -172,29 +172,39 @@
single driver.
def __init__(self, port, worker_number, driver_instance_constructor, pixel_tests, no_timeout):
+self._port = port
+self._worker_number = worker_number
+self._driver_instance_constructor = driver_instance_constructor
+self._no_timeout = no_timeout
self._pixel_tests = pixel_tests
-self._driver = driver_instance_constructor(port, worker_number, pixel_tests, no_timeout)
-if pixel_tests:
-self._reftest_driver = self._driver
-else:
-self._reftest_driver = driver_instance_constructor(port, worker_number, True, no_timeout)
+# FIXME: We shouldn't need to create a driver until we actually run a test.
+self._driver = self._make_driver(pixel_tests)
+self._running_drivers = {}
+self._running_drivers[self._cmd_line_as_key(pixel_tests, [])] = self._driver
+
+def _make_driver(self, pixel_tests):
+return self._driver_instance_constructor(self._port, self._worker_number, pixel_tests, self._no_timeout)
+
+# FIXME: this should be a @classmethod (or implemented on Port instead).
def is_http_test(self, test_name):
return
[webkit-changes] [109265] trunk/Source/WebCore
Title: [109265] trunk/Source/WebCore
Revision 109265
Author ander...@apple.com
Date 2012-02-29 14:43:05 -0800 (Wed, 29 Feb 2012)
Log Message
[Chromium] Some Layout Tests in platform/chromium/rubberbanding and platform/chromium/compositing/rubberbanding are failing
https://bugs.webkit.org/show_bug.cgi?id=79878
Reviewed by James Robinson.
Make sure that ScrollableArea::setScrollOffsetFromAnimation doesn't end up
setting the ScrollAnimator's current scroll position by making a new function, scrollPositionChanged,
that both notifyScrollPositionChanged and setScrollOffsetFromAnimation call and move the call to update
the position to notifyScrollPositionChanged.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::notifyScrollPositionChanged):
(WebCore):
(WebCore::ScrollableArea::scrollPositionChanged):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
* platform/ScrollableArea.h:
(ScrollableArea):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollableArea.cpp
trunk/Source/WebCore/platform/ScrollableArea.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109264 => 109265)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 22:40:32 UTC (rev 109264)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 22:43:05 UTC (rev 109265)
@@ -1,3 +1,23 @@
+2012-02-29 Anders Carlsson ander...@apple.com
+
+[Chromium] Some Layout Tests in platform/chromium/rubberbanding and platform/chromium/compositing/rubberbanding are failing
+https://bugs.webkit.org/show_bug.cgi?id=79878
+
+Reviewed by James Robinson.
+
+Make sure that ScrollableArea::setScrollOffsetFromAnimation doesn't end up
+setting the ScrollAnimator's current scroll position by making a new function, scrollPositionChanged,
+that both notifyScrollPositionChanged and setScrollOffsetFromAnimation call and move the call to update
+the position to notifyScrollPositionChanged.
+
+* platform/ScrollableArea.cpp:
+(WebCore::ScrollableArea::notifyScrollPositionChanged):
+(WebCore):
+(WebCore::ScrollableArea::scrollPositionChanged):
+(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
+* platform/ScrollableArea.h:
+(ScrollableArea):
+
2012-02-29 Dana Jansens dan...@chromium.org
[chromium] Don't let invalidation for next frame prevent tile upload
Modified: trunk/Source/WebCore/platform/ScrollableArea.cpp (109264 => 109265)
--- trunk/Source/WebCore/platform/ScrollableArea.cpp 2012-02-29 22:40:32 UTC (rev 109264)
+++ trunk/Source/WebCore/platform/ScrollableArea.cpp 2012-02-29 22:43:05 UTC (rev 109265)
@@ -124,6 +124,12 @@
void ScrollableArea::notifyScrollPositionChanged(const IntPoint position)
{
+scrollPositionChanged(position);
+scrollAnimator()-setCurrentPosition(position);
+}
+
+void ScrollableArea::scrollPositionChanged(const IntPoint position)
+{
// Tell the derived class to scroll its contents.
setScrollOffset(position);
@@ -150,7 +156,6 @@
verticalScrollbar-invalidate();
}
-scrollAnimator()-setCurrentPosition(position);
scrollAnimator()-notifyContentAreaScrolled();
}
@@ -170,7 +175,7 @@
if (requestScrollPositionUpdate(offset))
return;
-notifyScrollPositionChanged(offset);
+scrollPositionChanged(offset);
}
void ScrollableArea::willStartLiveResize()
Modified: trunk/Source/WebCore/platform/ScrollableArea.h (109264 => 109265)
--- trunk/Source/WebCore/platform/ScrollableArea.h 2012-02-29 22:40:32 UTC (rev 109264)
+++ trunk/Source/WebCore/platform/ScrollableArea.h 2012-02-29 22:43:05 UTC (rev 109265)
@@ -179,6 +179,8 @@
bool hasLayerForScrollCorner() const;
private:
+void scrollPositionChanged(const IntPoint);
+
// NOTE: Only called from the ScrollAnimator.
friend class ScrollAnimator;
void setScrollOffsetFromAnimation(const IntPoint);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109266] trunk/Tools
Title: [109266] trunk/Tools Revision 109266 Author dpra...@chromium.org Date 2012-02-29 14:43:27 -0800 (Wed, 29 Feb 2012) Log Message nrwt: implement simple 'virtual test suite' support https://bugs.webkit.org/show_bug.cgi?id=79737 Reviewed by Adam Barth. Add very basic support for 'virtual test suites' to NRWT: a virtual suite is a directory that may contain new baselines, contains a pointer to a base directory of tests, and an optional list of command line arguments to pass to DRT; it gives us a way to run all of the tests in a given directory multiple times with multiple (potentially differing) sets of results and baselines. This patch implements the support needed for this feature, and some basic tests, but no actual port will use the feature yet. This is probably the simplest implementation possible - the list of virtual suites will be hard-coded into the port's implementation. One can imagine a more data-driven approach where the suite instructions are stored in a manifest file either in LayoutTests (all suites in one file), or per-port, or per-directory. If this feature ends up being useful we should probably add something like that so people don't have to hunt around in the code to add suites. * Scripts/webkitpy/layout_tests/port/base.py: (Port.__init__): (Port.expected_filename): (Port.tests): (Port): (Port._real_tests): (Port._driver_class): (Port.virtual_test_suites): (Port.virtual_suite): (Port.virtual_suite.VirtualTestSuite): (Port.virtual_suite.VirtualTestSuite.__init__): (Port.virtual_suite.VirtualTestSuite.__repr__): (Port.populated_virtual_test_suites): (Port._virtual_tests): (Port.lookup_virtual_test_base): (Port.lookup_virtual_test_args): * Scripts/webkitpy/layout_tests/port/base_unittest.py: (PortTest.test_find_with_skipped_directories): * Scripts/webkitpy/layout_tests/port/driver.py: (DriverInput.__init__): (DriverProxy.run_test): * Scripts/webkitpy/layout_tests/port/test.py: (TestPort.virtual_test_suites): (TestDriver.run_test): * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (MainTest.test_all): (MainTest.test_virtual): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py trunk/Tools/Scripts/webkitpy/layout_tests/port/test.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py Diff Modified: trunk/Tools/ChangeLog (109265 => 109266) --- trunk/Tools/ChangeLog 2012-02-29 22:43:05 UTC (rev 109265) +++ trunk/Tools/ChangeLog 2012-02-29 22:43:27 UTC (rev 109266) @@ -1,5 +1,60 @@ 2012-02-29 Dirk Pranke dpra...@chromium.org +nrwt: implement simple 'virtual test suite' support +https://bugs.webkit.org/show_bug.cgi?id=79737 + +Reviewed by Adam Barth. + +Add very basic support for 'virtual test suites' to NRWT: +a virtual suite is a directory that may contain new baselines, +contains a pointer to a base directory of tests, and an +optional list of command line arguments to pass to DRT; +it gives us a way to run all of the tests in a given directory +multiple times with multiple (potentially differing) sets of +results and baselines. + +This patch implements the support needed for this feature, and +some basic tests, but no actual port will use the feature yet. + +This is probably the simplest implementation possible - the +list of virtual suites will be hard-coded into the port's +implementation. One can imagine a more data-driven approach +where the suite instructions are stored in a manifest file +either in LayoutTests (all suites in one file), or per-port, +or per-directory. If this feature ends up being useful we +should probably add something like that so people don't have +to hunt around in the code to add suites. + +* Scripts/webkitpy/layout_tests/port/base.py: +(Port.__init__): +(Port.expected_filename): +(Port.tests): +(Port): +(Port._real_tests): +(Port._driver_class): +(Port.virtual_test_suites): +(Port.virtual_suite): +(Port.virtual_suite.VirtualTestSuite): +(Port.virtual_suite.VirtualTestSuite.__init__): +(Port.virtual_suite.VirtualTestSuite.__repr__): +(Port.populated_virtual_test_suites): +(Port._virtual_tests): +(Port.lookup_virtual_test_base): +(Port.lookup_virtual_test_args): +* Scripts/webkitpy/layout_tests/port/base_unittest.py: +(PortTest.test_find_with_skipped_directories): +* Scripts/webkitpy/layout_tests/port/driver.py: +(DriverInput.__init__): +(DriverProxy.run_test): +* Scripts/webkitpy/layout_tests/port/test.py: +(TestPort.virtual_test_suites): +(TestDriver.run_test): +*
[webkit-changes] [109267] trunk
Title: [109267] trunk Revision 109267 Author hy...@apple.com Date 2012-02-29 14:44:33 -0800 (Wed, 29 Feb 2012) Log Message Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=79940 rdar://problem/10080189 Add support in WebKit for an intra-line character grid for Japanese text layout. Patch logicalLeftOffsetForLine and logicalRightOffsetForLine in order to get the basic edge snapping grid functionality up and running. See all the FIXMEs in the function for some of the issues that still have to be dealt with for it to really work well. Reviewed by Dan Bernstein. Added new tests in fast/line-grid. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::logicalLeftOffsetForLine): (WebCore::RenderBlock::logicalRightOffsetForLine): LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=79940 rdar://problem/10080189 Add support in WebKit for an intra-line character grid for Japanese text layout. New tests for basic left and right alignment of lines in the presence of floating and positioned objects as well as objects with margins and borders. Reviewed by Dan Bernstein. * fast/line-grid/line-align-left-edges.html: Added. * fast/line-grid/line-align-right-edges.html: Added. * platform/mac/fast/line-grid/line-align-left-edges-expected.png: Added. * platform/mac/fast/line-grid/line-align-left-edges-expected.txt: Added. * platform/mac/fast/line-grid/line-align-right-edges-expected.png: Added. * platform/mac/fast/line-grid/line-align-right-edges-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBlock.cpp Added Paths trunk/LayoutTests/fast/line-grid/line-align-left-edges.html trunk/LayoutTests/fast/line-grid/line-align-right-edges.html trunk/LayoutTests/platform/mac/fast/line-grid/line-align-left-edges-expected.png trunk/LayoutTests/platform/mac/fast/line-grid/line-align-left-edges-expected.txt trunk/LayoutTests/platform/mac/fast/line-grid/line-align-right-edges-expected.png trunk/LayoutTests/platform/mac/fast/line-grid/line-align-right-edges-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (109266 => 109267) --- trunk/LayoutTests/ChangeLog 2012-02-29 22:43:27 UTC (rev 109266) +++ trunk/LayoutTests/ChangeLog 2012-02-29 22:44:33 UTC (rev 109267) @@ -1,3 +1,22 @@ +2012-02-29 David Hyatt hy...@apple.com + +https://bugs.webkit.org/show_bug.cgi?id=79940 +rdar://problem/10080189 + +Add support in WebKit for an intra-line character grid for Japanese text layout. + +New tests for basic left and right alignment of lines in the presence of +floating and positioned objects as well as objects with margins and borders. + +Reviewed by Dan Bernstein. + +* fast/line-grid/line-align-left-edges.html: Added. +* fast/line-grid/line-align-right-edges.html: Added. +* platform/mac/fast/line-grid/line-align-left-edges-expected.png: Added. +* platform/mac/fast/line-grid/line-align-left-edges-expected.txt: Added. +* platform/mac/fast/line-grid/line-align-right-edges-expected.png: Added. +* platform/mac/fast/line-grid/line-align-right-edges-expected.txt: Added. + 2012-02-29 Adam Klein ad...@chromium.org Unreviewed gardening, remove some more stale expectations (mostly mac repaint tests). Added: trunk/LayoutTests/fast/line-grid/line-align-left-edges.html (0 => 109267) --- trunk/LayoutTests/fast/line-grid/line-align-left-edges.html (rev 0) +++ trunk/LayoutTests/fast/line-grid/line-align-left-edges.html 2012-02-29 22:44:33 UTC (rev 109267) @@ -0,0 +1,15 @@ +!doctype html +html +head +titleLeft Edge Alignment Test/title +/head +body +div style=-webkit-line-grid:grid; font-family:'Ahem'; color:green; -webkit-line-align:edges;line-height:1.25; zoom: 1.5; position:relative +X X X X X X X +div style=border:2px solid black;margin:25px;X X X X X X/div +div style=float:left;width:52px;height:52px;background-color:yellow;/divX X X X Xbr +div style=float:left;width:52px;height:52px;background-color:purple;/divX X X X X +div style=position:absolute;top:200px;width:200px; left:115px; background-color:#ddX X X/div +/div +/body +/html Added: trunk/LayoutTests/fast/line-grid/line-align-right-edges.html (0 => 109267) --- trunk/LayoutTests/fast/line-grid/line-align-right-edges.html (rev 0) +++ trunk/LayoutTests/fast/line-grid/line-align-right-edges.html 2012-02-29 22:44:33 UTC (rev 109267) @@ -0,0 +1,15 @@ +!doctype html +html +head +titleRight Edge Alignment Test/title +/head +body +div style=-webkit-line-grid:grid; font-family:'Ahem'; color:green; -webkit-line-align:edges;line-height:1.25; zoom: 1.5; position:relative; text-align:right +X X X X X X X +div style=border:2px solid black;margin:30px;X X X X X X/div +div style=float:right;width:52px;height:52px;background-color:yellow;/divX X X X Xbr +div
[webkit-changes] [109268] trunk/Source/JavaScriptCore
Title: [109268] trunk/Source/_javascript_Core
Revision 109268
Author fpi...@apple.com
Date 2012-02-29 14:47:31 -0800 (Wed, 29 Feb 2012)
Log Message
RefCounted::deprecatedTurnOffVerifier() should not be deprecated
https://bugs.webkit.org/show_bug.cgi?id=79864
Reviewed by Oliver Hunt.
Removed the word deprecated from the name of this method, since this method
should not be deprecated. It works just fine as it is, and there is simply no
alternative to calling this method for many interesting JSC classes.
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
* runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable):
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorHandle::MetaAllocatorHandle):
(WTF::MetaAllocator::allocate):
* wtf/RefCounted.h:
(RefCountedBase):
(WTF::RefCountedBase::turnOffVerifier):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/SourceProvider.h
trunk/Source/_javascript_Core/runtime/SymbolTable.h
trunk/Source/_javascript_Core/wtf/MetaAllocator.cpp
trunk/Source/_javascript_Core/wtf/RefCounted.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (109267 => 109268)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-29 22:44:33 UTC (rev 109267)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-29 22:47:31 UTC (rev 109268)
@@ -1,3 +1,25 @@
+2012-02-28 Filip Pizlo fpi...@apple.com
+
+RefCounted::deprecatedTurnOffVerifier() should not be deprecated
+https://bugs.webkit.org/show_bug.cgi?id=79864
+
+Reviewed by Oliver Hunt.
+
+Removed the word deprecated from the name of this method, since this method
+should not be deprecated. It works just fine as it is, and there is simply no
+alternative to calling this method for many interesting JSC classes.
+
+* parser/SourceProvider.h:
+(JSC::SourceProvider::SourceProvider):
+* runtime/SymbolTable.h:
+(JSC::SharedSymbolTable::SharedSymbolTable):
+* wtf/MetaAllocator.cpp:
+(WTF::MetaAllocatorHandle::MetaAllocatorHandle):
+(WTF::MetaAllocator::allocate):
+* wtf/RefCounted.h:
+(RefCountedBase):
+(WTF::RefCountedBase::turnOffVerifier):
+
2012-02-29 Gavin Barraclough barraclo...@apple.com
Writable attribute not set correctly when redefining an accessor to a data descriptor
Modified: trunk/Source/_javascript_Core/parser/SourceProvider.h (109267 => 109268)
--- trunk/Source/_javascript_Core/parser/SourceProvider.h 2012-02-29 22:44:33 UTC (rev 109267)
+++ trunk/Source/_javascript_Core/parser/SourceProvider.h 2012-02-29 22:47:31 UTC (rev 109268)
@@ -47,7 +47,7 @@
, m_cache(cache ? cache : new SourceProviderCache)
, m_cacheOwned(!cache)
{
-deprecatedTurnOffVerifier();
+turnOffVerifier();
}
virtual ~SourceProvider()
{
Modified: trunk/Source/_javascript_Core/runtime/SymbolTable.h (109267 => 109268)
--- trunk/Source/_javascript_Core/runtime/SymbolTable.h 2012-02-29 22:44:33 UTC (rev 109267)
+++ trunk/Source/_javascript_Core/runtime/SymbolTable.h 2012-02-29 22:47:31 UTC (rev 109268)
@@ -125,7 +125,7 @@
public:
static PassRefPtrSharedSymbolTable create() { return adoptRef(new SharedSymbolTable); }
private:
-SharedSymbolTable() { deprecatedTurnOffVerifier(); }
+SharedSymbolTable() { turnOffVerifier(); }
};
} // namespace JSC
Modified: trunk/Source/_javascript_Core/wtf/MetaAllocator.cpp (109267 => 109268)
--- trunk/Source/_javascript_Core/wtf/MetaAllocator.cpp 2012-02-29 22:44:33 UTC (rev 109267)
+++ trunk/Source/_javascript_Core/wtf/MetaAllocator.cpp 2012-02-29 22:47:31 UTC (rev 109268)
@@ -64,6 +64,7 @@
ASSERT(allocator);
ASSERT(start);
ASSERT(sizeInBytes);
+turnOffVerifier();
}
MetaAllocatorHandle::~MetaAllocatorHandle()
@@ -169,8 +170,6 @@
#endif
MetaAllocatorHandle* handle = new MetaAllocatorHandle(this, start, sizeInBytes, ownerUID);
-// FIXME: Implement a verifier scheme that groks MetaAllocatorHandles
-handle-deprecatedTurnOffVerifier();
if (UNLIKELY(!!m_tracker))
m_tracker-notify(handle);
Modified: trunk/Source/_javascript_Core/wtf/RefCounted.h (109267 => 109268)
--- trunk/Source/_javascript_Core/wtf/RefCounted.h 2012-02-29 22:44:33 UTC (rev 109267)
+++ trunk/Source/_javascript_Core/wtf/RefCounted.h 2012-02-29 22:47:31 UTC (rev 109268)
@@ -77,8 +77,15 @@
// Turns off verification. Use of this method is discouraged (instead extend
// ThreadRestrictionVerifier to verify your case).
-// FIXME: remove this method.
-void deprecatedTurnOffVerifier()
+// NB. It is necessary to call this in the constructor of many objects in
+// _javascript_Core, because _javascript_Core objects may be used from multiple
+// threads even if the reference counting is done in a racy manner. This is
+// because a JSC
[webkit-changes] [109269] trunk/LayoutTests
Title: [109269] trunk/LayoutTests Revision 109269 Author ad...@chromium.org Date 2012-02-29 14:47:57 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed gardening, add MAC GPU expectations for 2d.transformation.* (removed due to MAC CPU config passing in r109257). * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109268 => 109269) --- trunk/LayoutTests/ChangeLog 2012-02-29 22:47:31 UTC (rev 109268) +++ trunk/LayoutTests/ChangeLog 2012-02-29 22:47:57 UTC (rev 109269) @@ -1,3 +1,10 @@ +2012-02-29 Adam Klein ad...@chromium.org + +Unreviewed gardening, add MAC GPU expectations for 2d.transformation.* +(removed due to MAC CPU config passing in r109257). + +* platform/chromium/test_expectations.txt: + 2012-02-29 David Hyatt hy...@apple.com https://bugs.webkit.org/show_bug.cgi?id=79940 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109268 => 109269) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 22:47:31 UTC (rev 109268) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 22:47:57 UTC (rev 109269) @@ -1993,7 +1993,9 @@ BUGWK45991 LINUX WIN : canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html = TEXT BUGWK45991 LINUX WIN CPU : canvas/philip/tests/2d.shadow.enable.blur.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.transformation.setTransform.skewed.html = TEXT +BUGWK45991 MAC GPU : canvas/philip/tests/2d.transformation.setTransform.skewed.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.transformation.transform.skewed.html = TEXT +BUGWK45991 MAC GPU : canvas/philip/tests/2d.transformation.transform.skewed.html = TEXT // These SVG tests have been flaky on Win from quite some time. // Hard to pin down which roll introduced the flakiness. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109270] trunk/LayoutTests
Title: [109270] trunk/LayoutTests Revision 109270 Author ad...@chromium.org Date 2012-02-29 14:51:25 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed gardening. Remove suppressions for rubberbanding tests. These tests were broken by r109183 and should be fixed by r109265. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109269 => 109270) --- trunk/LayoutTests/ChangeLog 2012-02-29 22:47:57 UTC (rev 109269) +++ trunk/LayoutTests/ChangeLog 2012-02-29 22:51:25 UTC (rev 109270) @@ -1,5 +1,13 @@ 2012-02-29 Adam Klein ad...@chromium.org +Unreviewed gardening. Remove suppressions for rubberbanding tests. + +These tests were broken by r109183 and should be fixed by r109265. + +* platform/chromium/test_expectations.txt: + +2012-02-29 Adam Klein ad...@chromium.org + Unreviewed gardening, add MAC GPU expectations for 2d.transformation.* (removed due to MAC CPU config passing in r109257). Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109269 => 109270) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 22:47:57 UTC (rev 109269) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-29 22:51:25 UTC (rev 109270) @@ -4429,27 +4429,5 @@ BUGWK79863 WIN : svg/W3C-SVG-1.1/animate-elem-37-t.svg = IMAGE -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/overhang-sw.html = IMAGE+TEXT -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/overhang-nw.html = IMAGE -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/custom-scrollbars-ne.html = IMAGE+TEXT -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/custom-scrollbars-sw.html = IMAGE+TEXT -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/overhang-n.html = IMAGE -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/custom-scrollbars-se.html = IMAGE+TEXT -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/overhang-ne.html = IMAGE+TEXT -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/custom-scrollbars-nw.html = IMAGE -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/overhang-se.html = IMAGE+TEXT -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/overhang-w.html = IMAGE -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/overhang-e.html = IMAGE+TEXT -BUGWK79878 LEOPARD SNOWLEOPARD : platform/chromium/rubberbanding/overhang-s.html = IMAGE+TEXT - -BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-nw.html = IMAGE -BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-se.html = IMAGE -BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-s.html = IMAGE -BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-e.html = IMAGE -BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-sw.html = IMAGE -BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-n.html = IMAGE -BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-ne.html = IMAGE -BUGWK79878 SNOWLEOPARD : platform/chromium/compositing/rubberbanding/transform-overhang-w.html = IMAGE - // EPOGER: To be rebaselined after skia rev. 3283 lands in webkit BUGCR116252 LINUX : platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109271] trunk
Title: [109271] trunk
Revision 109271
Author jsb...@chromium.org
Date 2012-02-29 15:03:19 -0800 (Wed, 29 Feb 2012)
Log Message
IndexedDB: Resource leak with IDBObjectStore.openCursor
https://bugs.webkit.org/show_bug.cgi?id=79835
Source/WebCore:
IDBCursor object that were never continue()'d to the end would leak due to a
reference cycle with IDBRequest. In addition, the IDBRequest would never be
marked finished which would prevent GC from reclaiming it. IDBTransactions
now track and notify IDBCursors to break these references when the transaction
can no longer not process requests.
Reviewed by Tony Chang.
Tests: storage/indexeddb/cursor-continue.html
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::IDBCursor): Register with IDBTransaction bookkeeping.
(WebCore::IDBCursor::continueFunction): Early error if transaction has finished.
(WebCore::IDBCursor::close): Break the reference cycle with IDBRequest, and notify it
that the cursor is finished.
(WebCore):
* storage/IDBCursor.h:
(WebCore):
(IDBCursor):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::finishCursor): If there is no request in flight, mark itself as
finished to allow GC.
(WebCore):
(WebCore::IDBRequest::dispatchEvent): Once an in-flight request has been processed,
mark the request as finished if the cursor is finished, to allow GC.
* storage/IDBRequest.h:
(IDBRequest):
* storage/IDBTransaction.cpp: Track open cursors, close them when finished.
(WebCore::IDBTransaction::OpenCursorNotifier::OpenCursorNotifier):
(WebCore):
(WebCore::IDBTransaction::OpenCursorNotifier::~OpenCursorNotifier):
(WebCore::IDBTransaction::registerOpenCursor):
(WebCore::IDBTransaction::unregisterOpenCursor):
(WebCore::IDBTransaction::closeOpenCursors):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
(WebCore):
(OpenCursorNotifier):
(IDBTransaction):
LayoutTests:
Ensure that IDBCursor.continue() throws the right exception when transaction is finished.
Reviewed by Tony Chang.
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-continue.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/cursor-continue-expected.txt
trunk/LayoutTests/storage/indexeddb/cursor-continue.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBCursor.cpp
trunk/Source/WebCore/storage/IDBCursor.h
trunk/Source/WebCore/storage/IDBRequest.cpp
trunk/Source/WebCore/storage/IDBRequest.h
trunk/Source/WebCore/storage/IDBTransaction.cpp
trunk/Source/WebCore/storage/IDBTransaction.h
Diff
Modified: trunk/LayoutTests/ChangeLog (109270 => 109271)
--- trunk/LayoutTests/ChangeLog 2012-02-29 22:51:25 UTC (rev 109270)
+++ trunk/LayoutTests/ChangeLog 2012-02-29 23:03:19 UTC (rev 109271)
@@ -1,3 +1,15 @@
+2012-02-29 Joshua Bell jsb...@chromium.org
+
+IndexedDB: Resource leak with IDBObjectStore.openCursor
+https://bugs.webkit.org/show_bug.cgi?id=79835
+
+Ensure that IDBCursor.continue() throws the right exception when transaction is finished.
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/cursor-continue-expected.txt:
+* storage/indexeddb/cursor-continue.html:
+
2012-02-29 Adam Klein ad...@chromium.org
Unreviewed gardening. Remove suppressions for rubberbanding tests.
Modified: trunk/LayoutTests/storage/indexeddb/cursor-continue-expected.txt (109270 => 109271)
--- trunk/LayoutTests/storage/indexeddb/cursor-continue-expected.txt 2012-02-29 22:51:25 UTC (rev 109270)
+++ trunk/LayoutTests/storage/indexeddb/cursor-continue-expected.txt 2012-02-29 23:03:19 UTC (rev 109271)
@@ -108,9 +108,13 @@
PASS event.target.result.primaryKey is 17
event.target.result.continue('A bit2')
PASS event.target.result.primaryKey is 15
+cursor = event.target.result
Expecting exception from event.target.result.continue('A bit2')
PASS Exception was thrown.
PASS code is IDBDatabaseException.DATA_ERR
+Expecting exception from cursor.continue()
+PASS Exception was thrown.
+PASS code is IDBDatabaseException.TRANSACTION_INACTIVE_ERR
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/storage/indexeddb/cursor-continue.html (109270 => 109271)
--- trunk/LayoutTests/storage/indexeddb/cursor-continue.html 2012-02-29 22:51:25 UTC (rev 109270)
+++ trunk/LayoutTests/storage/indexeddb/cursor-continue.html 2012-02-29 23:03:19 UTC (rev 109271)
@@ -262,8 +262,9 @@
evalAndLog(event.target.result.continue('A bit2'));
} else if (window.stage == 1) {
shouldBe(event.target.result.primaryKey, 15);
+evalAndLog(cursor = event.target.result);
evalAndExpectException(event.target.result.continue('A bit2'), IDBDatabaseException.DATA_ERR);
-done();
+window.trans._oncomplete_ = onTransactionComplete;
return;
} else {
testFailed(Illegal stage.);
@@ -272,6 +273,12 @@
};
}
[webkit-changes] [109272] branches/chromium/1025
Title: [109272] branches/chromium/1025
Revision 109272
Author rn...@webkit.org
Date 2012-02-29 15:08:25 -0800 (Wed, 29 Feb 2012)
Log Message
Merge 108668 - REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305
Reviewed by Tony Chang.
Source/WebCore:
The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.
Test: editing/input/paste-text-ending-with-interchange-newline.html
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
LayoutTests:
Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.
* editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
* editing/input/paste-text-ending-with-interchange-newline.html: Added.
* resources/dump-as-markup.js:
(Markup._get):
(Markup._getShadowHostIfPossible):
Review URL: https://chromiumcodereview.appspot.com/9555006
Modified Paths
branches/chromium/1025/LayoutTests/resources/dump-as-markup.js
branches/chromium/1025/Source/WebCore/editing/ReplaceSelectionCommand.cpp
Added Paths
branches/chromium/1025/LayoutTests/editing/input/paste-text-ending-with-interchange-newline-expected.txt
branches/chromium/1025/LayoutTests/editing/input/paste-text-ending-with-interchange-newline.html
Diff
Copied: branches/chromium/1025/LayoutTests/editing/input/paste-text-ending-with-interchange-newline-expected.txt (from rev 108668, trunk/LayoutTests/editing/input/paste-text-ending-with-interchange-newline-expected.txt) (0 => 109272)
--- branches/chromium/1025/LayoutTests/editing/input/paste-text-ending-with-interchange-newline-expected.txt (rev 0)
+++ branches/chromium/1025/LayoutTests/editing/input/paste-text-ending-with-interchange-newline-expected.txt 2012-02-29 23:08:25 UTC (rev 109272)
@@ -0,0 +1,4 @@
+This tests pasting a text with an interchange new line at the end. WebKit shouldn't insert a new line.
+| shadow:root
+| div
+| abc def
Copied: branches/chromium/1025/LayoutTests/editing/input/paste-text-ending-with-interchange-newline.html (from rev 108668, trunk/LayoutTests/editing/input/paste-text-ending-with-interchange-newline.html) (0 => 109272)
--- branches/chromium/1025/LayoutTests/editing/input/paste-text-ending-with-interchange-newline.html (rev 0)
+++ branches/chromium/1025/LayoutTests/editing/input/paste-text-ending-with-interchange-newline.html 2012-02-29 23:08:25 UTC (rev 109272)
@@ -0,0 +1,27 @@
+!DOCTYPE html
+html
+body
+textareaabc
+def
+/textarea
+input type=text
+script src=""
+script
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+document.querySelector('textarea').focus();
+document.execCommand('SelectAll', false, null);
+document.execCommand('Copy', false, null);
+
+var input = document.querySelector('input');
+input.focus();
+document.execCommand('Paste', false, null);
+
+Markup.description(This tests pasting a text with an interchange new line at the end. WebKit shouldn't insert a new line.);
+Markup.dump(input);
+
+/script
+/body
+/html
Modified: branches/chromium/1025/LayoutTests/resources/dump-as-markup.js (109271 => 109272)
--- branches/chromium/1025/LayoutTests/resources/dump-as-markup.js 2012-02-29 23:03:19 UTC (rev 109271)
+++ branches/chromium/1025/LayoutTests/resources/dump-as-markup.js 2012-02-29 23:08:25 UTC (rev 109272)
@@ -126,14 +126,16 @@
Markup.get = function(node)
{
+var markup = Markup._getShadowHostIfPossible(node, 0);
+if (markup)
+return markup.substring(1);
+
if (!node.firstChild)
return '| ';
// Don't print any markup for the root node.
-var markup = '';
-for (var i = 0, len = node.childNodes.length; i len; i++) {
+for (var i = 0, len = node.childNodes.length; i len; i++)
markup += Markup._get(node.childNodes[i], 0);
-}
return markup.substring(1);
}
@@ -227,11 +229,7 @@
str += Markup._get(node.childNodes[i], depth + 1);
}
-if (!Markup._useHTML5libOutputFormat node.nodeType == Node.ELEMENT_NODE window.internals) {
-var root = window.internals.shadowRoot(node);
-if (root)
-str += Markup._get(root, depth + 1);
-}
+str += Markup._getShadowHostIfPossible(node, depth);
var selection = Markup._getSelectionMarker(node, i);
if (selection)
@@ -240,6 +238,16 @@
return str;
}
+Markup._getShadowHostIfPossible = function (node, depth)
+{
+if (!Markup._useHTML5libOutputFormat node.nodeType == Node.ELEMENT_NODE window.internals) {
+var root = window.internals.shadowRoot(node);
+if (root)
+return
[webkit-changes] [109273] trunk/Source/WebCore
Title: [109273] trunk/Source/WebCore Revision 109273 Author bda...@apple.com Date 2012-02-29 15:10:06 -0800 (Wed, 29 Feb 2012) Log Message https://bugs.webkit.org/show_bug.cgi?id=79705 didNewFirstVisuallyNonEmptyLayout should be enhanced to look at size instead of a raw tally -and corresponding- rdar://problem/10821314 Reviewed by Dave Hyatt. Instead of firing didNewFirstVisuallyNonEmptyLayout() when a raw tally of relevant painted objects has reached a port-defined threshold, this patch looks at the size of those objects with respect to the view area. The patch also looks at relevant objects that cannot yet be fully painted, such as incrementally loading images. We no longer need a HashSet for the relevant painted objects since Region can do all of the heavy lifting. We now have a Region for the painted and unpainted regions. We do need a HashSet for the unpainted objects though, because we need to know if a painted object needs to be subtracted from the unpainted region before being added to the painted region. * page/Page.cpp: (WebCore): (WebCore::Page::isCountingRelevantRepaintedObjects): (WebCore::Page::startCountingRelevantRepaintedObjects): (WebCore::Page::resetRelevantPaintedObjectCounter): (WebCore::Page::addRelevantRepaintedObject): (WebCore::Page::addRelevantUnpaintedObject): * page/Page.h: (Page): New function on Region iterates through the rects and calculates the total area. * platform/graphics/Region.cpp: (WebCore::Region::totalArea): (WebCore): * platform/graphics/Region.h: (Region): Remove code from these classes since they are not actually relevant objects. * rendering/InlineBox.cpp: (WebCore::InlineBox::paint): * rendering/RenderRegion.cpp: (WebCore::RenderRegion::paintReplaced): * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): All of these other callers send a rect that actually represents their size (usually the visualOverflowRect) instead of the paintInfo's paintRect, and they call addRelevantUnpaintedObject when appropriate. * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): * rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paint): (WebCore::RenderEmbeddedObject::paintReplaced): * rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced): * rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): * rendering/RenderVideo.cpp: (WebCore::RenderVideo::paintReplaced): * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paintReplaced): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h trunk/Source/WebCore/platform/graphics/Region.cpp trunk/Source/WebCore/platform/graphics/Region.h trunk/Source/WebCore/rendering/InlineBox.cpp trunk/Source/WebCore/rendering/InlineTextBox.cpp trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp trunk/Source/WebCore/rendering/RenderHTMLCanvas.cpp trunk/Source/WebCore/rendering/RenderImage.cpp trunk/Source/WebCore/rendering/RenderRegion.cpp trunk/Source/WebCore/rendering/RenderReplaced.cpp trunk/Source/WebCore/rendering/RenderVideo.cpp trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (109272 => 109273) --- trunk/Source/WebCore/ChangeLog 2012-02-29 23:08:25 UTC (rev 109272) +++ trunk/Source/WebCore/ChangeLog 2012-02-29 23:10:06 UTC (rev 109273) @@ -1,3 +1,67 @@ +2012-02-29 Beth Dakin bda...@apple.com + +https://bugs.webkit.org/show_bug.cgi?id=79705 +didNewFirstVisuallyNonEmptyLayout should be enhanced to look at size instead +of a raw tally +-and corresponding- +rdar://problem/10821314 + +Reviewed by Dave Hyatt. + +Instead of firing didNewFirstVisuallyNonEmptyLayout() when a raw tally of +relevant painted objects has reached a port-defined threshold, this patch +looks at the size of those objects with respect to the view area. The patch +also looks at relevant objects that cannot yet be fully painted, such as +incrementally loading images. + +We no longer need a HashSet for the relevant painted objects since Region can +do all of the heavy lifting. We now have a Region for the painted and +unpainted regions. We do need a HashSet for the unpainted objects though, +because we need to know if a painted object needs to be subtracted from the +unpainted region before being added to the painted region. +* page/Page.cpp: +(WebCore): +(WebCore::Page::isCountingRelevantRepaintedObjects): +(WebCore::Page::startCountingRelevantRepaintedObjects): +(WebCore::Page::resetRelevantPaintedObjectCounter): +(WebCore::Page::addRelevantRepaintedObject): +(WebCore::Page::addRelevantUnpaintedObject): +* page/Page.h: +(Page): + +New function on Region iterates through the rects and calculates the total +area. +*
[webkit-changes] [109274] trunk/Source/WebKit/chromium
Title: [109274] trunk/Source/WebKit/chromium
Revision 109274
Author commit-qu...@webkit.org
Date 2012-02-29 15:10:26 -0800 (Wed, 29 Feb 2012)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot webkit.review@gmail.com on 2012-02-29
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (109273 => 109274)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-02-29 23:10:06 UTC (rev 109273)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-02-29 23:10:26 UTC (rev 109274)
@@ -1,3 +1,9 @@
+2012-02-29 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-02-29 Dana Jansens dan...@chromium.org
[chromium] Don't let invalidation for next frame prevent tile upload
Modified: trunk/Source/WebKit/chromium/DEPS (109273 => 109274)
--- trunk/Source/WebKit/chromium/DEPS 2012-02-29 23:10:06 UTC (rev 109273)
+++ trunk/Source/WebKit/chromium/DEPS 2012-02-29 23:10:26 UTC (rev 109274)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '123945'
+ 'chromium_rev': '124176'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109275] trunk
Title: [109275] trunk Revision 109275 Author barraclo...@apple.com Date 2012-02-29 15:23:58 -0800 (Wed, 29 Feb 2012) Log Message Source/_javascript_Core: RefCounted::deprecatedTurnOffVerifier() should not be deprecated https://bugs.webkit.org/show_bug.cgi?id=79864 Patch by Filip Pizlo fpi...@apple.com on 2012-02-28 Reviewed by Oliver Hunt. Removed the word deprecated from the name of this method, since this method should not be deprecated. It works just fine as it is, and there is simply no alternative to calling this method for many interesting JSC classes. * parser/SourceProvider.h: (JSC::SourceProvider::SourceProvider): * runtime/SymbolTable.h: (JSC::SharedSymbolTable::SharedSymbolTable): * wtf/MetaAllocator.cpp: (WTF::MetaAllocatorHandle::MetaAllocatorHandle): (WTF::MetaAllocator::allocate): * wtf/RefCounted.h: (RefCountedBase): (WTF::RefCountedBase::turnOffVerifier): LayoutTests: 'source' property of RegExp instance cannot be https://bugs.webkit.org/show_bug.cgi?id=79938 Reviewed by Oliver Hunt. 15.10.6.4 specifies that RegExp.prototype.toString must return '/' + source + '/', and also states that the result must be a valid RegularExpressionLiteral. '//' is not a valid RegularExpressionLiteral (since it is a single line comment), and hence source cannot ever validly be . If the source is empty, return a different Pattern that would match the same thing. * fast/js/kde/RegExp-expected.txt: * fast/js/kde/script-tests/RegExp.js: * fast/regex/script-tests/toString.js: * fast/regex/toString-expected.txt: - Update these tests to check for the correct result. * sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T1-expected.txt: * sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T2-expected.txt: * sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T3-expected.txt: * sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T4-expected.txt: * sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T5-expected.txt: * sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T2-expected.txt: * sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T3-expected.txt: * sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T5-expected.txt: - Check in failing results, these tests are all incorrect. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/js/kde/RegExp-expected.txt trunk/LayoutTests/fast/js/kde/script-tests/RegExp.js trunk/LayoutTests/fast/regex/script-tests/toString.js trunk/LayoutTests/fast/regex/toString-expected.txt trunk/LayoutTests/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T1-expected.txt trunk/LayoutTests/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T2-expected.txt trunk/LayoutTests/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T3-expected.txt trunk/LayoutTests/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T4-expected.txt trunk/LayoutTests/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T5-expected.txt trunk/LayoutTests/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T2-expected.txt trunk/LayoutTests/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T3-expected.txt trunk/LayoutTests/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T5-expected.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/RegExpObject.cpp trunk/Source/_javascript_Core/runtime/RegExpPrototype.cpp Diff Modified: trunk/LayoutTests/ChangeLog (109274 => 109275) --- trunk/LayoutTests/ChangeLog 2012-02-29 23:10:26 UTC (rev 109274) +++ trunk/LayoutTests/ChangeLog 2012-02-29 23:23:58 UTC (rev 109275) @@ -1,3 +1,31 @@ +2012-02-29 Gavin Barraclough barraclo...@apple.com + +'source' property of RegExp instance cannot be +https://bugs.webkit.org/show_bug.cgi?id=79938 + +Reviewed by Oliver Hunt. + +15.10.6.4 specifies that RegExp.prototype.toString must return '/' + source + '/', +and also states that the result must be a valid RegularExpressionLiteral. '//' is +not a valid RegularExpressionLiteral (since it is a single line comment), and hence +source cannot ever validly be . If the source is empty, return a different Pattern +that would match the same thing. + +* fast/js/kde/RegExp-expected.txt: +* fast/js/kde/script-tests/RegExp.js: +* fast/regex/script-tests/toString.js: +* fast/regex/toString-expected.txt: +- Update these tests to check for the correct result. +* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T1-expected.txt: +* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T2-expected.txt: +*
[webkit-changes] [109276] trunk/Tools
Title: [109276] trunk/Tools
Revision 109276
Author lforsch...@apple.com
Date 2012-02-29 15:28:00 -0800 (Wed, 29 Feb 2012)
Log Message
Removed unused Apple buildslaves from the master configuration
https://bugs.webkit.org/show_bug.cgi?id=79925
Reviewed by Stephanie Lewis.
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (109275 => 109276)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-02-29 23:23:58 UTC (rev 109275)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-02-29 23:28:00 UTC (rev 109276)
@@ -8,8 +8,6 @@
{ name: apple-xserve-7, platform: mac-snowleopard },
{ name: apple-xserve-8, platform: mac-snowleopard },
{ name: apple-xserve-9, platform: mac-snowleopard },
-{ name: apple-macpro-1, platform: mac-snowleopard },
-{ name: apple-macpro-2, platform: mac-snowleopard },
{ name: apple-macpro-7, platform: mac-snowleopard },
{ name: apple-macpro-3, platform: mac-lion },
@@ -31,10 +29,6 @@
{ name: apple-windows-6, platform: win},
{ name: apple-windows-7, platform: win},
{ name: apple-windows-8, platform: win},
-{ name: apple-windows-9, platform: win},
-{ name: apple-windows-10, platform: win},
-{ name: apple-windows-11, platform: win},
-{ name: apple-windows-12, platform: win},
{ name: apple-windows-13, platform: win},
{ name: apple-windows-14, platform: win},
{ name: apple-windows-15, platform: win},
@@ -147,7 +141,7 @@
{
name: Windows 7 Release (Tests), type: Test, builddir: win-release-tests,
platform: win, configuration: release, architectures: [i386],
- slavenames: [apple-windows-5, apple-windows-6, apple-windows-11, apple-windows-12, test-slave]
+ slavenames: [apple-windows-5, apple-windows-6, test-slave]
},
{
name: Windows Debug (Build), type: Build, builddir: win-debug,
@@ -162,7 +156,7 @@
},
{ name: Windows 7 Release (WebKit2 Tests), type: TestWebKit2, builddir: win-release-tests-wk2,
platform: win, configuration: release, architectures: [i386],
- slavenames: [apple-windows-7, apple-windows-8, apple-windows-9, apple-windows-10, test-slave]
+ slavenames: [apple-windows-7, apple-windows-8, test-slave]
},
{
name: GTK Linux 32-bit Release, type: BuildAndTest, builddir: gtk-linux-32-release,
Modified: trunk/Tools/ChangeLog (109275 => 109276)
--- trunk/Tools/ChangeLog 2012-02-29 23:23:58 UTC (rev 109275)
+++ trunk/Tools/ChangeLog 2012-02-29 23:28:00 UTC (rev 109276)
@@ -1,3 +1,12 @@
+2012-02-29 Lucas Forschler lforsch...@apple.com
+
+Removed unused Apple buildslaves from the master configuration
+https://bugs.webkit.org/show_bug.cgi?id=79925
+
+Reviewed by Stephanie Lewis.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
2012-02-29 Dirk Pranke dpra...@chromium.org
nrwt: implement simple 'virtual test suite' support
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109277] trunk
Title: [109277] trunk Revision 109277 Author bweinst...@apple.com Date 2012-02-29 15:32:33 -0800 (Wed, 29 Feb 2012) Log Message Source/WebKit2: WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle https://bugs.webkit.org/show_bug.cgi?id=79849 Tell the injected bundle about didNewFirstVisuallyNonEmptyLayout (we currently just tell the UI process). Reviewed by Beth Dakin. * WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add didNewFirstVisuallyNonEmptyLayout to version 1. * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didNewFirstVisuallyNonEmptyLayout): Call through to the client. * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h: (InjectedBundlePageLoaderClient): * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout): Tell the injected bundle. Tools: WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle https://bugs.webkit.org/show_bug.cgi?id=79849 Reviewed by Beth Dakin. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (109276 => 109277) --- trunk/Source/WebKit2/ChangeLog 2012-02-29 23:28:00 UTC (rev 109276) +++ trunk/Source/WebKit2/ChangeLog 2012-02-29 23:32:33 UTC (rev 109277) @@ -1,3 +1,23 @@ +2012-02-28 Brian Weinstein bweinst...@apple.com + +WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle +https://bugs.webkit.org/show_bug.cgi?id=79849 + +Tell the injected bundle about didNewFirstVisuallyNonEmptyLayout (we currently +just tell the UI process). + +Reviewed by Beth Dakin. + +* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add didNewFirstVisuallyNonEmptyLayout to version 1. +* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: +(WebKit::InjectedBundlePageLoaderClient::didNewFirstVisuallyNonEmptyLayout): Call through to the +client. +* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h: +(InjectedBundlePageLoaderClient): +* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: +(WebKit::WebFrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout): Tell the injected +bundle. + 2012-02-29 Tim Horton timothy_hor...@apple.com Make use of CG rounded-rect primitives Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h (109276 => 109277) --- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2012-02-29 23:28:00 UTC (rev 109276) +++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2012-02-29 23:32:33 UTC (rev 109277) @@ -95,6 +95,7 @@ typedef void (*WKBundlePageDidDetectXSSForFrameCallback)(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userData, const void *clientInfo); typedef void (*WKBundlePageDidFirstLayoutForFrameCallback)(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userData, const void *clientInfo); typedef void (*WKBundlePageDidFirstVisuallyNonEmptyLayoutForFrameCallback)(WKBundlePageRef page, WKBundleFrameRef frame, WKTypeRef* userData, const void *clientInfo); +typedef void (*WKBundlePageDidNewFirstVisuallyNonEmptyLayoutCallback)(WKBundlePageRef page, WKTypeRef* userData, const void *clientInfo); typedef void (*WKBundlePageDidLayoutForFrameCallback)(WKBundlePageRef page, WKBundleFrameRef frame, const void* clientInfo); typedef void (*WKBundlePageDidClearWindowObjectForFrameCallback)(WKBundlePageRef page, WKBundleFrameRef frame, WKBundleScriptWorldRef world, const void *clientInfo); typedef void (*WKBundlePageDidCancelClientRedirectForFrameCallback)(WKBundlePageRef page, WKBundleFrameRef frame, const void *clientInfo); @@ -127,6 +128,7 @@ // Version 1. WKBundlePageDidLayoutForFrameCallback didLayoutForFrame; +WKBundlePageDidNewFirstVisuallyNonEmptyLayoutCallback didNewFirstVisuallyNonEmptyLayout; WKBundlePageDidDetectXSSForFrameCallbackdidDetectXSSForFrame; }; typedef struct WKBundlePageLoaderClient WKBundlePageLoaderClient; Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp (109276 => 109277) --- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp 2012-02-29 23:28:00 UTC (rev
[webkit-changes] [109278] trunk/Source/WebCore
Title: [109278] trunk/Source/WebCore
Revision 109278
Author bda...@apple.com
Date 2012-02-29 15:59:59 -0800 (Wed, 29 Feb 2012)
Log Message
Speculative build-fix.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderImage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (109277 => 109278)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 23:32:33 UTC (rev 109277)
+++ trunk/Source/WebCore/ChangeLog 2012-02-29 23:59:59 UTC (rev 109278)
@@ -1,5 +1,12 @@
2012-02-29 Beth Dakin bda...@apple.com
+Speculative build-fix.
+
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::paintReplaced):
+
+2012-02-29 Beth Dakin bda...@apple.com
+
https://bugs.webkit.org/show_bug.cgi?id=79705
didNewFirstVisuallyNonEmptyLayout should be enhanced to look at size instead
of a raw tally
Modified: trunk/Source/WebCore/rendering/RenderImage.cpp (109277 => 109278)
--- trunk/Source/WebCore/rendering/RenderImage.cpp 2012-02-29 23:32:33 UTC (rev 109277)
+++ trunk/Source/WebCore/rendering/RenderImage.cpp 2012-02-29 23:59:59 UTC (rev 109278)
@@ -338,7 +338,7 @@
return;
}
-if (page paintInfo.phase == PaintPhaseForeground) {
+if (cachedImage() page paintInfo.phase == PaintPhaseForeground) {
// For now, count images as unpainted if they are still progressively loading. We may want
// to refine this in the future to account for the portion of the image that has painted.
if (cachedImage()-isLoading())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109279] trunk/Source/WebCore
Title: [109279] trunk/Source/WebCore
Revision 109279
Author macpher...@chromium.org
Date 2012-02-29 16:11:45 -0800 (Wed, 29 Feb 2012)
Log Message
Clean up CSSPrimitiveValue::computeLengthDouble().
https://bugs.webkit.org/show_bug.cgi?id=77065
Reviewed by Eric Seidel.
Refactoring only / no behavioral change.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (109278 => 109279)
--- trunk/Source/WebCore/ChangeLog 2012-02-29 23:59:59 UTC (rev 109278)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 00:11:45 UTC (rev 109279)
@@ -1,3 +1,15 @@
+2012-02-29 Luke Macpherson macpher...@chromium.org
+
+Clean up CSSPrimitiveValue::computeLengthDouble().
+https://bugs.webkit.org/show_bug.cgi?id=77065
+
+Reviewed by Eric Seidel.
+
+Refactoring only / no behavioral change.
+
+* css/CSSPrimitiveValue.cpp:
+(WebCore::CSSPrimitiveValue::computeLengthDouble):
+
2012-02-29 Beth Dakin bda...@apple.com
Speculative build-fix.
Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (109278 => 109279)
--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2012-02-29 23:59:59 UTC (rev 109278)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2012-03-01 00:11:45 UTC (rev 109279)
@@ -429,33 +429,26 @@
double CSSPrimitiveValue::computeLengthDouble(RenderStyle* style, RenderStyle* rootStyle, float multiplier, bool computingFontSize)
{
-unsigned short type = primitiveType();
+double factor;
-// We do not apply the zoom factor when we are computing the value of the font-size property. The zooming
-// for font sizes is much more complicated, since we have to worry about enforcing the minimum font size preference
-// as well as enforcing the implicit smart minimum. In addition the CSS property text-size-adjust is used to
-// prevent text from zooming at all. Therefore we will not apply the zoom here if we are computing font-size.
-bool applyZoomMultiplier = !computingFontSize;
-
-double factor = 1.0;
-switch (type) {
+switch (primitiveType()) {
case CSS_EMS:
-applyZoomMultiplier = false;
factor = computingFontSize ? style-fontDescription().specifiedSize() : style-fontDescription().computedSize();
break;
case CSS_EXS:
// FIXME: We have a bug right now where the zoom will be applied twice to EX units.
// We really need to compute EX using fontMetrics for the original specifiedSize and not use
// our actual constructed rendering font.
-applyZoomMultiplier = false;
factor = style-fontMetrics().xHeight();
break;
case CSS_REMS:
-applyZoomMultiplier = false;
if (rootStyle)
factor = computingFontSize ? rootStyle-fontDescription().specifiedSize() : rootStyle-fontDescription().computedSize();
+else
+factor = 1.0;
break;
case CSS_PX:
+factor = 1.0;
break;
case CSS_CM:
factor = cssPixelsPerInch / 2.54; // (2.54 cm/in)
@@ -489,15 +482,19 @@
else
computedValue = getDoubleValue();
+// We do not apply the zoom factor when we are computing the value of the font-size property. The zooming
+// for font sizes is much more complicated, since we have to worry about enforcing the minimum font size preference
+// as well as enforcing the implicit smart minimum. In addition the CSS property text-size-adjust is used to
+// prevent text from zooming at all. Therefore we will not apply the zoom here if we are computing font-size.
double result = computedValue * factor;
-if (!applyZoomMultiplier || multiplier == 1.0f)
+if (computingFontSize || isFontRelativeLength())
return result;
// Any original result that was = 1 should not be allowed to fall below 1. This keeps border lines from
// vanishing.
double zoomedResult = result * multiplier;
-if (result = 1.0)
-zoomedResult = max(1.0, zoomedResult);
+if (zoomedResult 1.0 result = 1.0)
+return 1.0;
return zoomedResult;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109280] trunk
Title: [109280] trunk
Revision 109280
Author dch...@chromium.org
Date 2012-02-29 16:14:42 -0800 (Wed, 29 Feb 2012)
Log Message
[chromium] REGRESSION: Cannot drag a file out
https://bugs.webkit.org/show_bug.cgi?id=79817
Reviewed by Ryosuke Niwa.
Source/WebCore:
Temporary fix for file drag out. This change won't be needed once DataTransferItemList
support is better implemented.
Test: platform/chromium/fast/events/drag-downloadURL.html
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
LayoutTests:
* platform/chromium/fast/events/drag-downloadURL-expected.txt: Added.
* platform/chromium/fast/events/drag-downloadURL.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ChromiumDataObject.cpp
Added Paths
trunk/LayoutTests/platform/chromium/fast/events/drag-downloadURL-expected.txt
trunk/LayoutTests/platform/chromium/fast/events/drag-downloadURL.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109279 => 109280)
--- trunk/LayoutTests/ChangeLog 2012-03-01 00:11:45 UTC (rev 109279)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 00:14:42 UTC (rev 109280)
@@ -1,3 +1,13 @@
+2012-02-29 Daniel Cheng dch...@chromium.org
+
+[chromium] REGRESSION: Cannot drag a file out
+https://bugs.webkit.org/show_bug.cgi?id=79817
+
+Reviewed by Ryosuke Niwa.
+
+* platform/chromium/fast/events/drag-downloadURL-expected.txt: Added.
+* platform/chromium/fast/events/drag-downloadURL.html: Added.
+
2012-02-29 Gavin Barraclough barraclo...@apple.com
'source' property of RegExp instance cannot be
Added: trunk/LayoutTests/platform/chromium/fast/events/drag-downloadURL-expected.txt (0 => 109280)
--- trunk/LayoutTests/platform/chromium/fast/events/drag-downloadURL-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/drag-downloadURL-expected.txt 2012-03-01 00:14:42 UTC (rev 109280)
@@ -0,0 +1,6 @@
+To manually test, drag 'Drag Me' to 'Drop Here' and drop. The word 'SUCCESS' should appear.
+
+Drag Me
+Drop Here
+SUCCESS
+
Property changes on: trunk/LayoutTests/platform/chromium/fast/events/drag-downloadURL-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/platform/chromium/fast/events/drag-downloadURL.html (0 => 109280)
--- trunk/LayoutTests/platform/chromium/fast/events/drag-downloadURL.html (rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/drag-downloadURL.html 2012-03-01 00:14:42 UTC (rev 109280)
@@ -0,0 +1,72 @@
+!DOCTYPE html
+html
+head
+style
+#drag {
+border: 1px solid black;
+height: 200px;
+width: 200px;
+}
+#drop {
+border: 1px solid black;
+height: 200px;
+width: 200px;
+}
+/style
+script
+function log(str)
+{
+var result = document.getElementById('result');
+result.appendChild(document.createTextNode(str));
+result.appendChild(document.createElement('br'));
+}
+function dragstart(event) {
+event.dataTransfer.setData('DownloadURL', 'http://google.com/');
+}
+function dragenter(event) {
+event.preventDefault();
+}
+function dragover(event) {
+event.preventDefault();
+}
+function drop(event) {
+var failed = false;
+if (event.dataTransfer.types.indexOf('downloadurl') 0) {
+log('types: ' + event.dataTransfer.types);
+failed = true;
+}
+if (event.dataTransfer.getData('DownloadURL') != 'http://google.com/') {
+log('getData: ' + event.dataTransfer.getData('DownloadURL'));
+failed = true;
+}
+log(failed ? 'FAILURE' : 'SUCCESS');
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+window._onload_ = function()
+{
+if (!window.layoutTestController)
+return;
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+
+var dragElement = document.getElementById('drag');
+eventSender.mouseMoveTo(dragElement.offsetLeft + dragElement.offsetWidth / 2,
+dragElement.offsetTop + dragElement.offsetHeight / 2);
+eventSender.mouseDown();
+eventSender.leapForward(100);
+var dropElement = document.getElementById('drop');
+eventSender.mouseMoveTo(dropElement.offsetLeft + dropElement.offsetWidth / 2,
+dropElement.offsetTop + dropElement.offsetHeight / 2);
+eventSender.mouseUp();
+}
+/script
+/head
+body
+pTo manually test, drag 'Drag Me' to 'Drop Here' and drop. The word 'SUCCESS' should appear.
+div draggable=true id=drag _ondragstart_=dragstart(event)Drag Me/div
+div id=drop _ondragenter_=dragenter(event) _ondragover_=dragover(event) _ondrop_=drop(event)Drop Here/div
+/div
+div id=result/div
+/body
+/html
Property changes on: trunk/LayoutTests/platform/chromium/fast/events/drag-downloadURL.html
___
[webkit-changes] [109281] trunk/LayoutTests
Title: [109281] trunk/LayoutTests Revision 109281 Author ad...@chromium.org Date 2012-02-29 16:27:52 -0800 (Wed, 29 Feb 2012) Log Message Mark fast/js/kde/RegExp.html test as failing on Chromium due to differing V8 behavior. Opened http://code.google.com/p/v8/issues/detail?id=1982 to track this issue in V8. Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109280 => 109281) --- trunk/LayoutTests/ChangeLog 2012-03-01 00:14:42 UTC (rev 109280) +++ trunk/LayoutTests/ChangeLog 2012-03-01 00:27:52 UTC (rev 109281) @@ -1,3 +1,13 @@ +2012-02-29 Adam Klein ad...@chromium.org + +Mark fast/js/kde/RegExp.html test as failing on Chromium due to +differing V8 behavior. Opened http://code.google.com/p/v8/issues/detail?id=1982 +to track this issue in V8. + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2012-02-29 Daniel Cheng dch...@chromium.org [chromium] REGRESSION: Cannot drag a file out Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109280 => 109281) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-01 00:14:42 UTC (rev 109280) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-01 00:27:52 UTC (rev 109281) @@ -4431,3 +4431,5 @@ // EPOGER: To be rebaselined after skia rev. 3283 lands in webkit BUGCR116252 LINUX : platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html = IMAGE+TEXT + +BUGV8_1982 : fast/js/kde/RegExp.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109282] trunk/Tools
Title: [109282] trunk/Tools
Revision 109282
Author dpra...@chromium.org
Date 2012-02-29 16:33:13 -0800 (Wed, 29 Feb 2012)
Log Message
nrwt: make --print trace work with virtual tests
https://bugs.webkit.org/show_bug.cgi?id=79952
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_test_trace):
(Printer._print_baseline):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py
Diff
Modified: trunk/Tools/ChangeLog (109281 => 109282)
--- trunk/Tools/ChangeLog 2012-03-01 00:27:52 UTC (rev 109281)
+++ trunk/Tools/ChangeLog 2012-03-01 00:33:13 UTC (rev 109282)
@@ -1,3 +1,14 @@
+2012-02-29 Dirk Pranke dpra...@chromium.org
+
+nrwt: make --print trace work with virtual tests
+https://bugs.webkit.org/show_bug.cgi?id=79952
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/views/printing.py:
+(Printer._print_test_trace):
+(Printer._print_baseline):
+
2012-02-28 Brian Weinstein bweinst...@apple.com
WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py (109281 => 109282)
--- trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py 2012-03-01 00:27:52 UTC (rev 109281)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py 2012-03-01 00:33:13 UTC (rev 109282)
@@ -315,18 +315,25 @@
- actual result
- timing info
-filename = self._port.abspath_for_test(result.test_name)
test_name = result.test_name
self._write('trace: %s' % test_name)
+
+base = self._port.lookup_virtual_test_base(test_name)
+if base:
+args = ' '.join(self._port.lookup_virtual_test_args(test_name))
+self._write(' base: %s' % base)
+self._write(' args: %s' % args)
+
for extension in ('.txt', '.png', '.wav', '.webarchive'):
-self._print_baseline(filename, extension)
+self._print_baseline(test_name, extension)
+
self._write(' exp: %s' % exp_str)
self._write(' got: %s' % got_str)
self._write(' took: %-.3f' % result.test_run_time)
self._write('')
-def _print_baseline(self, filename, extension):
-baseline = self._port.expected_filename(filename, extension)
+def _print_baseline(self, test_name, extension):
+baseline = self._port.expected_filename(test_name, extension)
if self._port._filesystem.exists(baseline):
relpath = self._port.relative_test_filename(baseline)
else:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109284] trunk/Source/WebKit/blackberry
Title: [109284] trunk/Source/WebKit/blackberry
Revision 109284
Author commit-qu...@webkit.org
Date 2012-02-29 16:33:56 -0800 (Wed, 29 Feb 2012)
Log Message
Autocomplete attribute should apply to textarea's.
https://bugs.webkit.org/show_bug.cgi?id=79929
Patch by Mike Fenton mifen...@rim.com on 2012-02-29
Reviewed by Antonio Gomes.
Allow the autocomplete attribute to bubble back to the form setting.
Expand support to include checking autocorrect, autocomplete and
name/id matching to text areas.
Reviewed internally by Nima Ghanavatian and Gen Mak.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
(BlackBerry::WebKit::DOMSupport::elementSupportsAutocomplete):
(BlackBerry::WebKit::DOMSupport::elementAttributeState):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::inputStyle):
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.h
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (109283 => 109284)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-03-01 00:33:46 UTC (rev 109283)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-03-01 00:33:56 UTC (rev 109284)
@@ -1,3 +1,25 @@
+2012-02-29 Mike Fenton mifen...@rim.com
+
+Autocomplete attribute should apply to textarea's.
+https://bugs.webkit.org/show_bug.cgi?id=79929
+
+Reviewed by Antonio Gomes.
+
+Allow the autocomplete attribute to bubble back to the form setting.
+
+Expand support to include checking autocorrect, autocomplete and
+name/id matching to text areas.
+
+Reviewed internally by Nima Ghanavatian and Gen Mak.
+
+* WebKitSupport/DOMSupport.cpp:
+(BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
+(BlackBerry::WebKit::DOMSupport::elementSupportsAutocomplete):
+(BlackBerry::WebKit::DOMSupport::elementAttributeState):
+* WebKitSupport/DOMSupport.h:
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::inputStyle):
+
2012-02-29 Max Feil mf...@rim.com
[BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp (109283 => 109284)
--- trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-03-01 00:33:46 UTC (rev 109283)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp 2012-03-01 00:33:56 UTC (rev 109284)
@@ -173,13 +173,27 @@
return false;
}
+// This is a Tristate return to allow us to override name matching when
+// the attribute is expressly requested for a field. Default indicates
+// that the setting is On which is the default but not expressly requested
+// for the element being checked. On indicates that it is directly added
+// to the element.
AttributeState elementSupportsAutocorrect(const Element* element)
{
+return elementAttributeState(element, QualifiedName(nullAtom, autocorrect, nullAtom));
+}
+
+AttributeState elementSupportsAutocomplete(const Element* element)
+{
+return elementAttributeState(element, HTMLNames::autocompleteAttr);
+}
+
+AttributeState elementAttributeState(const Element* element, const QualifiedName attributeName)
+{
// First we check the input item itself. If the attribute is not defined,
// we check its parent form.
-QualifiedName autocorrectAttr = QualifiedName(nullAtom, autocorrect, nullAtom);
-if (element-fastHasAttribute(autocorrectAttr)) {
-AtomicString attributeString = element-fastGetAttribute(autocorrectAttr);
+if (element-fastHasAttribute(attributeName)) {
+AtomicString attributeString = element-fastGetAttribute(attributeName);
if (equalIgnoringCase(attributeString, off))
return Off;
if (equalIgnoringCase(attributeString, on))
@@ -189,8 +203,8 @@
}
if (element-isFormControlElement()) {
const HTMLFormControlElement* formElement = static_castconst HTMLFormControlElement*(element);
-if (formElement-form() formElement-form()-fastHasAttribute(autocorrectAttr)) {
-AtomicString attributeString = formElement-form()-fastGetAttribute(autocorrectAttr);
+if (formElement-form() formElement-form()-fastHasAttribute(attributeName)) {
+AtomicString attributeString = formElement-form()-fastGetAttribute(attributeName);
if (equalIgnoringCase(attributeString, off))
return Off;
if (equalIgnoringCase(attributeString, on))
@@ -285,25 +299,6 @@
return rangeForNode-isPointInRange(domNodeAtPos, offset, ec);
}
-// This is a Tristate return to allow us to override name matching when
-// autocomplete is expressly requested for a field. Default indicates
-// that the setting is On which is the default but not expressly requested
[webkit-changes] [109283] trunk/LayoutTests
Title: [109283] trunk/LayoutTests Revision 109283 Author ad...@chromium.org Date 2012-02-29 16:33:46 -0800 (Wed, 29 Feb 2012) Log Message Rebaseline line-grid tests for Chromium after r109267. Unreviewed gardening. * platform/chromium-linux/fast/line-grid/line-align-left-edges-expected.png: Added. * platform/chromium-linux/fast/line-grid/line-align-right-edges-expected.png: Added. * platform/chromium-mac-snowleopard/fast/line-grid/line-align-left-edges-expected.png: Added. * platform/chromium-mac-snowleopard/fast/line-grid/line-align-right-edges-expected.png: Added. * platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png: Added. * platform/chromium-win/fast/line-grid/line-align-right-edges-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-align-left-edges-expected.png trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-align-right-edges-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/line-grid/line-align-left-edges-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/line-grid/line-align-right-edges-expected.png trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-align-right-edges-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (109282 => 109283) --- trunk/LayoutTests/ChangeLog 2012-03-01 00:33:13 UTC (rev 109282) +++ trunk/LayoutTests/ChangeLog 2012-03-01 00:33:46 UTC (rev 109283) @@ -1,5 +1,18 @@ 2012-02-29 Adam Klein ad...@chromium.org +Rebaseline line-grid tests for Chromium after r109267. + +Unreviewed gardening. + +* platform/chromium-linux/fast/line-grid/line-align-left-edges-expected.png: Added. +* platform/chromium-linux/fast/line-grid/line-align-right-edges-expected.png: Added. +* platform/chromium-mac-snowleopard/fast/line-grid/line-align-left-edges-expected.png: Added. +* platform/chromium-mac-snowleopard/fast/line-grid/line-align-right-edges-expected.png: Added. +* platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png: Added. +* platform/chromium-win/fast/line-grid/line-align-right-edges-expected.png: Added. + +2012-02-29 Adam Klein ad...@chromium.org + Mark fast/js/kde/RegExp.html test as failing on Chromium due to differing V8 behavior. Opened http://code.google.com/p/v8/issues/detail?id=1982 to track this issue in V8. Added: trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-align-left-edges-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-align-left-edges-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-align-right-edges-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/line-grid/line-align-right-edges-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/line-grid/line-align-left-edges-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/line-grid/line-align-left-edges-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/line-grid/line-align-right-edges-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/line-grid/line-align-right-edges-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-align-right-edges-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/fast/line-grid/line-align-right-edges-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109285] trunk/Source/WebCore
Title: [109285] trunk/Source/WebCore
Revision 109285
Author kl...@webkit.org
Date 2012-02-29 17:03:41 -0800 (Wed, 29 Feb 2012)
Log Message
IsSynchronizingStyleAttributeFlag could be purged.
http://webkit.org/b/79313
Reviewed by Anders Carlsson.
We were using IsSynchronizingStyleAttributeFlag to prevent various things from
happening below setAttribute() when serializing the style attribute based on
an element's inline style.
Simplify the whole thing by adding a way to set an attribute without triggering
any callbacks (a 'notifyChanged' argument to Element::setAttribute().)
This removes the need for IsSynchronizingStyleAttributeFlag in the first place
and makes StyledElement::updateStyleAttribute() a bit cheaper to boot.
* dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::willModifyAttribute):
(WebCore::Element::didModifyAttribute):
(WebCore::Element::didRemoveAttribute):
* dom/Element.h:
* dom/Node.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::attributeChanged):
* html/HTMLElement.cpp:
(WebCore::StyledElement::copyNonAttributeProperties):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/StyledElement.cpp
trunk/Source/WebCore/html/HTMLElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (109284 => 109285)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 00:33:56 UTC (rev 109284)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 01:03:41 UTC (rev 109285)
@@ -1,3 +1,33 @@
+2012-02-29 Andreas Kling awesomekl...@apple.com
+
+IsSynchronizingStyleAttributeFlag could be purged.
+http://webkit.org/b/79313
+
+Reviewed by Anders Carlsson.
+
+We were using IsSynchronizingStyleAttributeFlag to prevent various things from
+happening below setAttribute() when serializing the style attribute based on
+an element's inline style.
+
+Simplify the whole thing by adding a way to set an attribute without triggering
+any callbacks (a 'notifyChanged' argument to Element::setAttribute().)
+This removes the need for IsSynchronizingStyleAttributeFlag in the first place
+and makes StyledElement::updateStyleAttribute() a bit cheaper to boot.
+
+* dom/Element.cpp:
+(WebCore::Element::setAttribute):
+(WebCore::Element::setAttributeInternal):
+(WebCore::Element::willModifyAttribute):
+(WebCore::Element::didModifyAttribute):
+(WebCore::Element::didRemoveAttribute):
+* dom/Element.h:
+* dom/Node.h:
+* dom/StyledElement.cpp:
+(WebCore::StyledElement::updateStyleAttribute):
+(WebCore::StyledElement::attributeChanged):
+* html/HTMLElement.cpp:
+(WebCore::StyledElement::copyNonAttributeProperties):
+
2012-02-29 Daniel Cheng dch...@chromium.org
[chromium] REGRESSION: Cannot drag a file out
Modified: trunk/Source/WebCore/dom/Element.cpp (109284 => 109285)
--- trunk/Source/WebCore/dom/Element.cpp 2012-03-01 00:33:56 UTC (rev 109284)
+++ trunk/Source/WebCore/dom/Element.cpp 2012-03-01 01:03:41 UTC (rev 109285)
@@ -624,12 +624,12 @@
setAttributeInternal(index, qName, value);
}
-void Element::setAttribute(const QualifiedName name, const AtomicString value)
+void Element::setAttribute(const QualifiedName name, const AtomicString value, bool notifyChanged)
{
-setAttributeInternal(ensureUpdatedAttributeData()-getAttributeItemIndex(name), name, value);
+setAttributeInternal(ensureUpdatedAttributeData()-getAttributeItemIndex(name), name, value, notifyChanged);
}
-inline void Element::setAttributeInternal(size_t index, const QualifiedName name, const AtomicString value)
+inline void Element::setAttributeInternal(size_t index, const QualifiedName name, const AtomicString value, bool notifyChanged)
{
ElementAttributeData* attributeData = m_attributeMap-m_attributeData;
Attribute* old = index != notFound ? attributeData-attributeItem(index) : 0;
@@ -644,14 +644,16 @@
return;
}
-willModifyAttribute(name, old ? old-value() : nullAtom, value);
+if (notifyChanged)
+willModifyAttribute(name, old ? old-value() : nullAtom, value);
if (Attr* attrNode = old-attr())
attrNode-setValue(value);
else
old-setValue(value);
-didModifyAttribute(old);
+if (notifyChanged)
+didModifyAttribute(old);
}
void Element::attributeChanged(Attribute* attr)
@@ -1939,15 +1941,12 @@
updateName(oldValue, newValue);
#if ENABLE(MUTATION_OBSERVERS)
-if (!isSynchronizingStyleAttribute()) {
-if (OwnPtrMutationObserverInterestGroup recipients = MutationObserverInterestGroup::createForAttributesMutation(this, name))
-recipients-enqueueMutationRecord(MutationRecord::createAttributes(this, name,
[webkit-changes] [109286] trunk/Source/WebCore
Title: [109286] trunk/Source/WebCore Revision 109286 Author commit-qu...@webkit.org Date 2012-02-29 17:17:33 -0800 (Wed, 29 Feb 2012) Log Message msubsup setNeedsLayout() correction https://bugs.webkit.org/show_bug.cgi?id=79856 Patch by David Barton dbar...@mathscribe.com on 2012-02-29 Reviewed by Julien Chaffraix. m_scripts-setNeedsLayout(true, false); needs to be added to the fix for bug 79274. No new tests. It's actually difficult to test the need for this with the current code, because there are a lot of extra setNeedsLayout() calls right now. I caught this after removing some of those calls that should be redundant, for a future patch. Actually removing those calls now changes other behavior, due to other bugs, so I'll save all that for future patches. We should land this fix now though I think, as it could possibly matter in some cases. * rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::layout): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (109285 => 109286) --- trunk/Source/WebCore/ChangeLog 2012-03-01 01:03:41 UTC (rev 109285) +++ trunk/Source/WebCore/ChangeLog 2012-03-01 01:17:33 UTC (rev 109286) @@ -1,3 +1,22 @@ +2012-02-29 David Barton dbar...@mathscribe.com + +msubsup setNeedsLayout() correction +https://bugs.webkit.org/show_bug.cgi?id=79856 + +Reviewed by Julien Chaffraix. + +m_scripts-setNeedsLayout(true, false); needs to be added to the fix for bug 79274. + +No new tests. It's actually difficult to test the need for this with the current code, +because there are a lot of extra setNeedsLayout() calls right now. I caught this after +removing some of those calls that should be redundant, for a future patch. Actually +removing those calls now changes other behavior, due to other bugs, so I'll save all +that for future patches. We should land this fix now though I think, as it could +possibly matter in some cases. + +* rendering/mathml/RenderMathMLSubSup.cpp: +(WebCore::RenderMathMLSubSup::layout): + 2012-02-29 Andreas Kling awesomekl...@apple.com IsSynchronizingStyleAttributeFlag could be purged. Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp (109285 => 109286) --- trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp 2012-03-01 01:03:41 UTC (rev 109285) +++ trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp 2012-03-01 01:17:33 UTC (rev 109286) @@ -183,6 +183,7 @@ superscriptWrapper-style()-setPaddingBottom(Length(superPaddingBottom, Fixed)); superscriptWrapper-setNeedsLayout(true, false); +m_scripts-setNeedsLayout(true, false); RenderBlock::layout(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109287] trunk/Source/JavaScriptCore
Title: [109287] trunk/Source/_javascript_Core Revision 109287 Author mr...@apple.com Date 2012-02-29 17:26:15 -0800 (Wed, 29 Feb 2012) Log Message Stop installing JSCLLIntOffsetsExtractor. Replace the separate TestRegExp and TestAPI xcconfig files with a single ToolExecutable xcconfig file that derives the product name from the target name. We can then use that xcconfig file for JSCLLIntOffsetsExtractor. This has the results of setting SKIP_INSTALL = YES for JSCLLIntOffsetsExtractor. While I was doing this fiddling I noticed that the JSCLLIntOffsetsExtractor target had a custom value for USER_HEADER_SEARCH_PATHS to allow it to find LLIntDesiredOffsets.h. A better way of doing that is to add LLIntDesiredOffsets.h to the Xcode project so that it'll be included in the header map. That allows us to remove the override of USER_HEADER_SEARCH_PATHS entirely. So I did that too! Reviewed by Filip Pizlo. * Configurations/TestRegExp.xcconfig: Removed. * Configurations/ToolExecutable.xcconfig: Renamed from Source/_javascript_Core/Configurations/TestAPI.xcconfig. * _javascript_Core.xcodeproj/project.pbxproj: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj Added Paths trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig Removed Paths trunk/Source/_javascript_Core/Configurations/TestAPI.xcconfig trunk/Source/_javascript_Core/Configurations/TestRegExp.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (109286 => 109287) --- trunk/Source/_javascript_Core/ChangeLog 2012-03-01 01:17:33 UTC (rev 109286) +++ trunk/Source/_javascript_Core/ChangeLog 2012-03-01 01:26:15 UTC (rev 109287) @@ -1,3 +1,22 @@ +2012-02-29 Mark Rowe mr...@apple.com + +Stop installing JSCLLIntOffsetsExtractor. + +Replace the separate TestRegExp and TestAPI xcconfig files with a single ToolExecutable xcconfig file +that derives the product name from the target name. We can then use that xcconfig file for JSCLLIntOffsetsExtractor. +This has the results of setting SKIP_INSTALL = YES for JSCLLIntOffsetsExtractor. + +While I was doing this fiddling I noticed that the JSCLLIntOffsetsExtractor target had a custom value +for USER_HEADER_SEARCH_PATHS to allow it to find LLIntDesiredOffsets.h. A better way of doing that is +to add LLIntDesiredOffsets.h to the Xcode project so that it'll be included in the header map. That +allows us to remove the override of USER_HEADER_SEARCH_PATHS entirely. So I did that too! + +Reviewed by Filip Pizlo. + +* Configurations/TestRegExp.xcconfig: Removed. +* Configurations/ToolExecutable.xcconfig: Renamed from Source/_javascript_Core/Configurations/TestAPI.xcconfig. +* _javascript_Core.xcodeproj/project.pbxproj: + 2012-02-28 Filip Pizlo fpi...@apple.com RefCounted::deprecatedTurnOffVerifier() should not be deprecated Deleted: trunk/Source/_javascript_Core/Configurations/TestAPI.xcconfig (109286 => 109287) --- trunk/Source/_javascript_Core/Configurations/TestAPI.xcconfig 2012-03-01 01:17:33 UTC (rev 109286) +++ trunk/Source/_javascript_Core/Configurations/TestAPI.xcconfig 2012-03-01 01:26:15 UTC (rev 109287) @@ -1,30 +0,0 @@ -// Copyright (C) 2011 Apple Inc. All rights reserved. -// -// Redistribution and use in source and binary forms, with or without -// modification, are permitted provided that the following conditions -// are met: -// 1. Redistributions of source code must retain the above copyright -//notice, this list of conditions and the following disclaimer. -// 2. Redistributions in binary form must reproduce the above copyright -//notice, this list of conditions and the following disclaimer in the -//documentation and/or other materials provided with the distribution. -// -// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY -// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE -// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR -// PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR -// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, -// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, -// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR -// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY -// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - -INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR)/_javascript_Core.framework/Resources -PRODUCT_NAME = testapi; - -SKIP_INSTALL = $(SKIP_INSTALL_$(FORCE_TOOL_INSTALL)); -SKIP_INSTALL_ = YES; -SKIP_INSTALL_NO = YES; -SKIP_INSTALL_YES = NO; Deleted: trunk/Source/_javascript_Core/Configurations/TestRegExp.xcconfig (109286 => 109287) ---
[webkit-changes] [109288] trunk
Title: [109288] trunk
Revision 109288
Author le...@chromium.org
Date 2012-02-29 17:29:56 -0800 (Wed, 29 Feb 2012)
Log Message
[chromium] Add the ability to turn off autoresize.
https://bugs.webkit.org/show_bug.cgi?id=77452
Reviewed by Darin Fisher.
Source/WebCore:
Test: fast/autoresize/turn-off-autoresize.html
* page/FrameView.cpp:
(WebCore::FrameView::enableAutoSizeMode): Fix the code
path for turning off autoresize to set the scrollbars to auto.
Source/WebKit/chromium:
* public/WebView.h:
(WebKit::WebViewImpl::enableAutoResizeMode): Cleaned up the api.
(WebKit::WebViewImpl::disableAutoResizeMode): Added the ability to disable auto-resize.
(WebKit::WebViewImpl::enableAutoResizeMode): Deprecated it.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enableAutoResizeMode): Adjust for new api.
(WebKit::WebViewImpl::disableAutoResizeMode): Allow turning off autoresize.
(WebKit::WebViewImpl::enableAutoResizeMode): Call the other two apis, but
this api will be deleted shortly.
(WebKit::WebViewImpl::configureAutoResizeMode): Common code.
* src/WebViewImpl.h:
(WebViewImpl): Adjust to new public api.
Tools:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
(LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
(LayoutTestController::disableAutoResizeMode): Ditto.
* DumpRenderTree/chromium/LayoutTestController.h: Ditto.
LayoutTests:
* fast/autoresize/turn-off-autoresize-expected.txt: Added.
* fast/autoresize/turn-off-autoresize.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h
Added Paths
trunk/LayoutTests/fast/autoresize/turn-off-autoresize-expected.txt
trunk/LayoutTests/fast/autoresize/turn-off-autoresize.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109287 => 109288)
--- trunk/LayoutTests/ChangeLog 2012-03-01 01:26:15 UTC (rev 109287)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 01:29:56 UTC (rev 109288)
@@ -1,3 +1,13 @@
+2012-02-29 David Levin le...@chromium.org
+
+[chromium] Add the ability to turn off autoresize.
+https://bugs.webkit.org/show_bug.cgi?id=77452
+
+Reviewed by Darin Fisher.
+
+* fast/autoresize/turn-off-autoresize-expected.txt: Added.
+* fast/autoresize/turn-off-autoresize.html: Added.
+
2012-02-29 Adam Klein ad...@chromium.org
Rebaseline line-grid tests for Chromium after r109267.
Added: trunk/LayoutTests/fast/autoresize/turn-off-autoresize-expected.txt (0 => 109288)
--- trunk/LayoutTests/fast/autoresize/turn-off-autoresize-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/autoresize/turn-off-autoresize-expected.txt 2012-03-01 01:29:56 UTC (rev 109288)
@@ -0,0 +1,15 @@
+This test verifies that turning off auto resize functions correctly. It only works when run in dumprendertree as it relies on having auto-resize function available.
+
+When it succeeds, there should be a series of PASS messages followed by a DONE message.
+
+PASS: document.body.clientWidth equaled window.innerWidth
+PASS: document.body.clientHeight equaled window.innerHeight
+PASS: document.body.scrollWidth equaled window.innerWidth
+PASS: document.body.scrollHeight equaled window.innerHeight
+PASS: window.innerWidth equaled window.outerWidth
+PASS: window.innerHeight equaled window.outerHeight
+PASS: window.outerWidth equaled 200
+PASS: window.outerHeight equaled 200
+PASS: window.outerWidth equaled 200
+DONE
+
Property changes on: trunk/LayoutTests/fast/autoresize/turn-off-autoresize-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/fast/autoresize/turn-off-autoresize.html (0 => 109288)
--- trunk/LayoutTests/fast/autoresize/turn-off-autoresize.html (rev 0)
+++ trunk/LayoutTests/fast/autoresize/turn-off-autoresize.html 2012-03-01 01:29:56 UTC (rev 109288)
@@ -0,0 +1,38 @@
+!doctype html
+html
+script src=''/script
+script
+function runTest()
+{
+if (window.layoutTestController) {
+layoutTestController.enableAutoResizeMode(10, 10, 1000, 1000);
+layoutTestController.dumpAsText();
+}
+shouldBe('document.body.clientWidth', 'window.innerWidth');
+shouldBe('document.body.clientHeight', 'window.innerHeight');
+shouldBe('document.body.scrollWidth', 'window.innerWidth');
+shouldBe('document.body.scrollHeight', 'window.innerHeight');
+shouldBe('window.innerWidth', 'window.outerWidth');
+shouldBe('window.innerHeight', 'window.outerHeight');
+if
[webkit-changes] [109289] trunk/Source/JavaScriptCore
Title: [109289] trunk/Source/_javascript_Core Revision 109289 Author barraclo...@apple.com Date 2012-02-29 17:34:07 -0800 (Wed, 29 Feb 2012) Log Message Rubber stamped by Oliver Hunt. * tests/mozilla/ecma_2/RegExp/constructor-001.js: * tests/mozilla/ecma_2/RegExp/function-001.js: * tests/mozilla/ecma_2/RegExp/properties-001.js: - Check in new test cases results. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/constructor-001.js trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/function-001.js trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/properties-001.js Diff Modified: trunk/Source/_javascript_Core/ChangeLog (109288 => 109289) --- trunk/Source/_javascript_Core/ChangeLog 2012-03-01 01:29:56 UTC (rev 109288) +++ trunk/Source/_javascript_Core/ChangeLog 2012-03-01 01:34:07 UTC (rev 109289) @@ -1,3 +1,12 @@ +2012-02-29 Gavin Barraclough barraclo...@apple.com + +Rubber stamped by Oliver Hunt. + +* tests/mozilla/ecma_2/RegExp/constructor-001.js: +* tests/mozilla/ecma_2/RegExp/function-001.js: +* tests/mozilla/ecma_2/RegExp/properties-001.js: +- Check in new test cases results. + 2012-02-29 Mark Rowe mr...@apple.com Stop installing JSCLLIntOffsetsExtractor. Modified: trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/constructor-001.js (109288 => 109289) --- trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/constructor-001.js 2012-03-01 01:29:56 UTC (rev 109288) +++ trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/constructor-001.js 2012-03-01 01:34:07 UTC (rev 109289) @@ -40,7 +40,7 @@ AddTestCase( (new RegExp()).source, -, +(?:), re.source ); AddTestCase( Modified: trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/function-001.js (109288 => 109289) --- trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/function-001.js 2012-03-01 01:29:56 UTC (rev 109288) +++ trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/function-001.js 2012-03-01 01:34:07 UTC (rev 109289) @@ -40,7 +40,7 @@ AddTestCase( (new RegExp()).source, -, +(?:), re.source ); AddTestCase( Modified: trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/properties-001.js (109288 => 109289) --- trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/properties-001.js 2012-03-01 01:29:56 UTC (rev 109288) +++ trunk/Source/_javascript_Core/tests/mozilla/ecma_2/RegExp/properties-001.js 2012-03-01 01:34:07 UTC (rev 109289) @@ -52,10 +52,6 @@ // properties -AddTestCase( re + .source, - s, - re.source ); - /* * http://bugzilla.mozilla.org/show_bug.cgi?id=225550 changed * the behavior of toString() and toSource() on empty regexps. @@ -63,6 +59,10 @@ */ var S = s? s : '(?:)'; +AddTestCase( re + .source, + S, + re.source ); + AddTestCase( re + .toString(), / + S +/ + (g?g:) + (i?i:) +(m?m:), re.toString() ); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109290] trunk
Title: [109290] trunk
Revision 109290
Author shin...@chromium.org
Date 2012-02-29 17:55:08 -0800 (Wed, 29 Feb 2012)
Log Message
Methods in ShadowTree and TreeScopeAdopter should be multiple shadow roots aware.
https://bugs.webkit.org/show_bug.cgi?id=79768
Reviewed by Hajime Morita.
Source/WebCore:
Some methods in ShadowTree and TreeScopeAdopter were not multiple shadow roots aware.
They should consider multiple shadow roots.
Test: fast/dom/shadow/multiple-shadowroot-adopt.html
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::setParentTreeScope):
(WebCore):
(WebCore::ShadowTree::childNeedsStyleRecalc):
(WebCore::ShadowTree::needsStyleRecalc):
* dom/ShadowTree.h:
(WebCore):
(ShadowTree):
* dom/TreeScopeAdopter.cpp:
(WebCore::shadowTreeFor):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::moveShadowTreeToNewDocument):
(WebCore):
* dom/TreeScopeAdopter.h:
(TreeScopeAdopter):
LayoutTests:
* fast/dom/shadow/multiple-shadowroot-adopt-expected.txt: Added.
* fast/dom/shadow/multiple-shadowroot-adopt.html: Added.
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ShadowTree.cpp
trunk/Source/WebCore/dom/ShadowTree.h
trunk/Source/WebCore/dom/TreeScopeAdopter.cpp
trunk/Source/WebCore/dom/TreeScopeAdopter.h
Added Paths
trunk/LayoutTests/fast/dom/shadow/multiple-shadowroot-adopt-expected.txt
trunk/LayoutTests/fast/dom/shadow/multiple-shadowroot-adopt.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109289 => 109290)
--- trunk/LayoutTests/ChangeLog 2012-03-01 01:34:07 UTC (rev 109289)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 01:55:08 UTC (rev 109290)
@@ -1,3 +1,19 @@
+2012-02-29 Shinya Kawanaka shin...@chromium.org
+
+Methods in ShadowTree and TreeScopeAdopter should be multiple shadow roots aware.
+https://bugs.webkit.org/show_bug.cgi?id=79768
+
+Reviewed by Hajime Morita.
+
+* fast/dom/shadow/multiple-shadowroot-adopt-expected.txt: Added.
+* fast/dom/shadow/multiple-shadowroot-adopt.html: Added.
+* platform/efl/Skipped:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+* platform/wincairo/Skipped:
+* platform/wk2/Skipped:
+
2012-02-29 David Levin le...@chromium.org
[chromium] Add the ability to turn off autoresize.
Added: trunk/LayoutTests/fast/dom/shadow/multiple-shadowroot-adopt-expected.txt (0 => 109290)
--- trunk/LayoutTests/fast/dom/shadow/multiple-shadowroot-adopt-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/multiple-shadowroot-adopt-expected.txt 2012-03-01 01:55:08 UTC (rev 109290)
@@ -0,0 +1,10 @@
+This test checks multiple shadow trees can be moved into another document.
+
+PASS document is sr1.ownerDocument
+PASS sr1.ownerDocument is sr2.ownerDocument
+PASS sr1.ownerDocument is iframeDoc
+PASS sr2.ownerDocument is iframeDoc
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/shadow/multiple-shadowroot-adopt.html (0 => 109290)
--- trunk/LayoutTests/fast/dom/shadow/multiple-shadowroot-adopt.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/multiple-shadowroot-adopt.html 2012-03-01 01:55:08 UTC (rev 109290)
@@ -0,0 +1,44 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+pThis test checks multiple shadow trees can be moved into another document./p
+pre id=console/pre
+
+iframe id=iframe/iframe
+
+script
+function setUpOnce() {
+internals.setMultipleShadowSubtreesEnabled(true);
+}
+
+function tearDownOnce() {
+internals.setMultipleShadowSubtreesEnabled(false);
+}
+
+function doTest() {
+var target = document.createElement('div');
+sr1 = new WebKitShadowRoot(target);
+sr2 = new WebKitShadowRoot(target);
+
+shouldBe('document', 'sr1.ownerDocument');
+shouldBe('sr1.ownerDocument', 'sr2.ownerDocument');
+
+var iframe = document.getElementById('iframe');
+iframeDoc = iframe.contentDocument;
+iframeDoc.body.appendChild(target);
+
+shouldBe('sr1.ownerDocument', 'iframeDoc');
+shouldBe('sr2.ownerDocument', 'iframeDoc');
+}
+
+setUpOnce();
+doTest();
+tearDownOnce();
+var successfullyParsed = true;
+/script
+script src=""
+/body
+/html
Modified: trunk/LayoutTests/platform/efl/Skipped (109289 => 109290)
--- trunk/LayoutTests/platform/efl/Skipped 2012-03-01 01:34:07 UTC (rev 109289)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-03-01 01:55:08 UTC (rev 109290)
@@ -2094,6 +2094,7 @@
[webkit-changes] [109291] trunk/LayoutTests
Title: [109291] trunk/LayoutTests Revision 109291 Author hara...@chromium.org Date 2012-02-29 17:56:39 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed, marking RegExp.html as FAIL in Chromium/V8 since it requires a fix in V8. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109290 => 109291) --- trunk/LayoutTests/ChangeLog 2012-03-01 01:55:08 UTC (rev 109290) +++ trunk/LayoutTests/ChangeLog 2012-03-01 01:56:39 UTC (rev 109291) @@ -1,3 +1,10 @@ +2012-02-29 Kentaro Hara hara...@chromium.org + +Unreviewed, marking RegExp.html as FAIL in Chromium/V8 +since it requires a fix in V8. + +* platform/chromium/test_expectations.txt: + 2012-02-29 Shinya Kawanaka shin...@chromium.org Methods in ShadowTree and TreeScopeAdopter should be multiple shadow roots aware. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109290 => 109291) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-01 01:55:08 UTC (rev 109290) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-01 01:56:39 UTC (rev 109291) @@ -1151,6 +1151,9 @@ // Fails on webkit windows as well. BUGCR24207 : fast/events/attempt-scroll-with-no-scrollbars.html = FAIL +// Needs a fix in V8. V8 bug: http://code.google.com/p/v8/issues/detail?id=1983thanks=1983ts=1330565749 +BUGWK79938 : fast/js/kde/RegExp.html = TEXT + // No glyph for U+FFFD (Replacement Character : black diamond with // question mark) in them BUGCR10315 WIN : fast/encoding/invalid-UTF-8.html = IMAGE+TEXT @@ -4431,5 +4434,3 @@ // EPOGER: To be rebaselined after skia rev. 3283 lands in webkit BUGCR116252 LINUX : platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html = IMAGE+TEXT - -BUGV8_1982 : fast/js/kde/RegExp.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109293] trunk/LayoutTests
Title: [109293] trunk/LayoutTests Revision 109293 Author hara...@chromium.org Date 2012-02-29 18:28:22 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed gardening. * platform/chromium/fast/regions/select-in-region-crash-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium/fast/regions/ trunk/LayoutTests/platform/chromium/fast/regions/select-in-region-crash-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (109292 => 109293) --- trunk/LayoutTests/ChangeLog 2012-03-01 02:09:25 UTC (rev 109292) +++ trunk/LayoutTests/ChangeLog 2012-03-01 02:28:22 UTC (rev 109293) @@ -1,5 +1,11 @@ 2012-02-29 Kentaro Hara hara...@chromium.org +Unreviewed gardening. + +* platform/chromium/fast/regions/select-in-region-crash-expected.txt: Added. + +2012-02-29 Kentaro Hara hara...@chromium.org + Unreviewed, marking RegExp.html as FAIL in Chromium/V8 since it requires a fix in V8. Added: trunk/LayoutTests/platform/chromium/fast/regions/select-in-region-crash-expected.txt (0 => 109293) --- trunk/LayoutTests/platform/chromium/fast/regions/select-in-region-crash-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/regions/select-in-region-crash-expected.txt 2012-03-01 02:28:22 UTC (rev 109293) @@ -0,0 +1,6 @@ +Bug 77474: Crash in RenderFlowThread::setRegionBoxesRegionStyle + +This test PASSES if it does not CRASH or ASSERT. + + + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109294] trunk/Tools
Title: [109294] trunk/Tools
Revision 109294
Author mr...@apple.com
Date 2012-02-29 18:38:03 -0800 (Wed, 29 Feb 2012)
Log Message
Switch to using json rather than simplejson now that the master is using Python 2.7.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (109293 => 109294)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-03-01 02:28:22 UTC (rev 109293)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2012-03-01 02:38:03 UTC (rev 109294)
@@ -15,7 +15,7 @@
import os
import re
-import simplejson
+import json
import urllib
from committer_auth import CommitterAuth
@@ -802,8 +802,8 @@
def loadBuilderConfig(c):
# FIXME: These file handles are leaked.
-passwords = simplejson.load(open('passwords.json'))
-config = simplejson.load(open('config.json'))
+passwords = json.load(open('passwords.json'))
+config = json.load(open('config.json'))
c['slaves'] = [BuildSlave(slave['name'], passwords[slave['name']], max_builds=1) for slave in config['slaves']]
@@ -813,8 +813,8 @@
scheduler[change_filter] = globals()[scheduler[change_filter]]
kls = globals()[scheduler.pop('type')]
# Python 2.6 can't handle unicode keys as keyword arguments:
-# http://bugs.python.org/issue2646. Modern versions of simplejson return
-# unicode strings from simplejson.load, so we map all keys to str objects.
+# http://bugs.python.org/issue2646. Modern versions of json return
+# unicode strings from json.load, so we map all keys to str objects.
scheduler = dict(map(lambda key_value_pair: (str(key_value_pair[0]), key_value_pair[1]), scheduler.items()))
# BaseScheduler asserts if given unicode objects instead of strs.
Modified: trunk/Tools/ChangeLog (109293 => 109294)
--- trunk/Tools/ChangeLog 2012-03-01 02:28:22 UTC (rev 109293)
+++ trunk/Tools/ChangeLog 2012-03-01 02:38:03 UTC (rev 109294)
@@ -1,3 +1,10 @@
+2012-02-29 Mark Rowe mr...@apple.com
+
+Switch to using json rather than simplejson now that the master is using Python 2.7.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(loadBuilderConfig):
+
2012-02-29 David Levin le...@chromium.org
[chromium] Add the ability to turn off autoresize.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109295] trunk/ChangeLog
Title: [109295] trunk/ChangeLog Revision 109295 Author k...@profusion.mobi Date 2012-02-29 18:39:26 -0800 (Wed, 29 Feb 2012) Log Message [CMake] Unreviewed, fix build on 64-bit platforms with SHARED_CORE=ON after r109197. https://bugs.webkit.org/show_bug.cgi?id=79965 This partially reverts r66714, in that whether -fPIC is passed to the compiler does not depend on the value of SHARED_CORE anymore: since we always build WTF as a static library, it will always need -fPIC because our shared libraries are built with it. * Source/cmake/WebKitHelpers.cmake: Always pass -fPIC to STATIC_LIBRARY targets. Modified Paths trunk/ChangeLog Diff Modified: trunk/ChangeLog (109294 => 109295) --- trunk/ChangeLog 2012-03-01 02:38:03 UTC (rev 109294) +++ trunk/ChangeLog 2012-03-01 02:39:26 UTC (rev 109295) @@ -1,6 +1,7 @@ 2012-02-29 Raphael Kubo da Costa k...@profusion.mobi [CMake] Unreviewed, fix build on 64-bit platforms with SHARED_CORE=ON after r109197. +https://bugs.webkit.org/show_bug.cgi?id=79965 This partially reverts r66714, in that whether -fPIC is passed to the compiler does not depend on the value of SHARED_CORE anymore: @@ -10,6 +11,18 @@ * Source/cmake/WebKitHelpers.cmake: Always pass -fPIC to STATIC_LIBRARY targets. +2012-02-29 Raphael Kubo da Costa k...@profusion.mobi + +[CMake] Unreviewed, fix build on 64-bit platforms with SHARED_CORE=ON after r109197. + +This partially reverts r66714, in that whether -fPIC is passed to +the compiler does not depend on the value of SHARED_CORE anymore: +since we always build WTF as a static library, it will always need +-fPIC because our shared libraries are built with it. + +* Source/cmake/WebKitHelpers.cmake: Always pass -fPIC to +STATIC_LIBRARY targets. + 2012-02-29 Carlos Garcia Campos cgar...@igalia.com Unreviewed. Bump WebKitGTK+ version number. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109298] trunk
Title: [109298] trunk
Revision 109298
Author fisch...@chromium.org
Date 2012-02-29 19:38:02 -0800 (Wed, 29 Feb 2012)
Log Message
Continue the search for playable mime types among source children of video even when using data: URLs
https://bugs.webkit.org/show_bug.cgi?id=79934
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/sources-fallback-codecs.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectNextSourceChild):
LayoutTests:
* media/sources-fallback-codecs-expected.txt: Added.
* media/sources-fallback-codecs.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Added Paths
trunk/LayoutTests/media/sources-fallback-codecs-expected.txt
trunk/LayoutTests/media/sources-fallback-codecs.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109297 => 109298)
--- trunk/LayoutTests/ChangeLog 2012-03-01 03:34:31 UTC (rev 109297)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 03:38:02 UTC (rev 109298)
@@ -1,3 +1,13 @@
+2012-02-29 Ami Fischman fisch...@chromium.org
+
+Continue the search for playable mime types among source children of video even when using data: URLs
+https://bugs.webkit.org/show_bug.cgi?id=79934
+
+Reviewed by Eric Carlson.
+
+* media/sources-fallback-codecs-expected.txt: Added.
+* media/sources-fallback-codecs.html: Added.
+
2012-02-29 Dirk Pranke dpra...@chromium.org
need to clone the gpu baselines and expectations into the new virtual dir
Added: trunk/LayoutTests/media/sources-fallback-codecs-expected.txt (0 => 109298)
--- trunk/LayoutTests/media/sources-fallback-codecs-expected.txt (rev 0)
+++ trunk/LayoutTests/media/sources-fallback-codecs-expected.txt 2012-03-01 03:38:02 UTC (rev 109298)
@@ -0,0 +1,3 @@
+Test that fallback among codecs is done correctly regardless of their order.
+END OF TEST
+
Added: trunk/LayoutTests/media/sources-fallback-codecs.html (0 => 109298)
--- trunk/LayoutTests/media/sources-fallback-codecs.html (rev 0)
+++ trunk/LayoutTests/media/sources-fallback-codecs.html 2012-03-01 03:38:02 UTC (rev 109298)
@@ -0,0 +1,261 @@
+!DOCTYPE html
+html
+head
+script src=""
+script
+var canPlayThroughCount = 0;
+function onCanPlayThrough() {
+if (++canPlayThroughCount == document.getElementsByTagName('video').length + document.getElementsByTagName('audio').length) {
+endTest();
+return;
+}
+}
+function onError(e) {
+var type = e.target.type;
+if (!type) {
+var src = ""
+var semicolon;
+if ((src.substr(0,5) == data:) ((semicolon = src.substr(5).indexOf(';')) 0))
+type = src.substr(5).substr(0, semicolon);
+if (!type) {
+failTest(Couldn't find type);
+return;
+}
+}
+
+if (e.target.tagName == 'SOURCE' !e.target.parentNode.canPlayType(type)) {
+// Expected error; ignore.
+return;
+}
+var id = (e.target.tagName == 'SOURCE' ? e.target.parentNode.id : e.target.id);
+failTest(tag: + e.target.tagName + , id: + id + , src: + e.target.src);
+}
+/script
+/head
+body
+Test that fallback among codecs is done correctly regardless of their order.
+!-- This could be made far more general, testing all permutations of
+ (audio|video)Codecs and so on, but in reality we only have these 4
+ test files, so simply enumerating them manually and testing they
+ all hit canplaythrough is good enough. Someday when many more
+ files are present, consider generalizing this.
+--
+
+video id='v1' controls _oncanplaythrough_='onCanPlayThrough()' _onerror_='onError(event)'
+source _onerror_='onError(event)' type=video/mp4 src=""
+source _onerror_='onError(event)' type=video/ogg src=""
+/video
+
+video id='v2' controls _oncanplaythrough_='onCanPlayThrough()' _onerror_='onError(event)'
+source _onerror_='onError(event)' type=video/ogg src=""
+source _onerror_='onError(event)' type=video/mp4 src=""
+/video
+
+audio id='a1' controls _oncanplaythrough_='onCanPlayThrough()' _onerror_='onError(event)'
+source _onerror_='onError(event)' type=audio/wav src=""
+source _onerror_='onError(event)' type=audio/ogg src=""
+/audio
+
+audio id='a2' controls _oncanplaythrough_='onCanPlayThrough()' _onerror_='onError(event)'
+source _onerror_='onError(event)' type=audio/ogg src=""
+source
[webkit-changes] [109299] trunk
Title: [109299] trunk
Revision 109299
Author commit-qu...@webkit.org
Date 2012-02-29 19:54:24 -0800 (Wed, 29 Feb 2012)
Log Message
SVG use element allows invalid contents
https://bugs.webkit.org/show_bug.cgi?id=77764
Patch by Stephen Chenney schen...@chromium.org on 2012-02-29
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Modify the isDisallowedElement method to disallow all of the
disallowed elements, instead of just a few. It is now a whitelist
implementation.
This also fixes bugs 78807, 78838 and 79798 related to memory
corruption issues.
Tests: svg/custom/bug78807.svg
svg/custom/bug78838.html
svg/custom/bug79798.html
* svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):
LayoutTests:
These test all use invalid elements in the use and crash in the absence
of this patch. Existing tests cover the valid elements in use, so no
additional tests for those.
* svg/custom/bug78807-expected.txt: Added.
* svg/custom/bug78807.svg: Added.
* svg/custom/bug78838-expected.txt: Added.
* svg/custom/bug78838.html: Added.
* svg/custom/bug79798-expected.txt: Added.
* svg/custom/bug79798.html: Added.
* svg/custom/resources/bug78838.svg: Added.
* svg/custom/resources/bug79798.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp
Added Paths
trunk/LayoutTests/svg/custom/bug78807-expected.txt
trunk/LayoutTests/svg/custom/bug78807.svg
trunk/LayoutTests/svg/custom/bug78838-expected.txt
trunk/LayoutTests/svg/custom/bug78838.html
trunk/LayoutTests/svg/custom/bug79798-expected.txt
trunk/LayoutTests/svg/custom/bug79798.html
trunk/LayoutTests/svg/custom/resources/bug78838.svg
trunk/LayoutTests/svg/custom/resources/bug79798.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (109298 => 109299)
--- trunk/LayoutTests/ChangeLog 2012-03-01 03:38:02 UTC (rev 109298)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 03:54:24 UTC (rev 109299)
@@ -1,3 +1,23 @@
+2012-02-29 Stephen Chenney schen...@chromium.org
+
+SVG use element allows invalid contents
+https://bugs.webkit.org/show_bug.cgi?id=77764
+
+Reviewed by Nikolas Zimmermann.
+
+These test all use invalid elements in the use and crash in the absence
+of this patch. Existing tests cover the valid elements in use, so no
+additional tests for those.
+
+* svg/custom/bug78807-expected.txt: Added.
+* svg/custom/bug78807.svg: Added.
+* svg/custom/bug78838-expected.txt: Added.
+* svg/custom/bug78838.html: Added.
+* svg/custom/bug79798-expected.txt: Added.
+* svg/custom/bug79798.html: Added.
+* svg/custom/resources/bug78838.svg: Added.
+* svg/custom/resources/bug79798.svg: Added.
+
2012-02-29 Ami Fischman fisch...@chromium.org
Continue the search for playable mime types among source children of video even when using data: URLs
Added: trunk/LayoutTests/svg/custom/bug78807-expected.txt (0 => 109299)
--- trunk/LayoutTests/svg/custom/bug78807-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/bug78807-expected.txt 2012-03-01 03:54:24 UTC (rev 109299)
@@ -0,0 +1,6 @@
+This page contains the following errors:
+
+error on line 11 at column 19: Extra content at the end of the document
+Below is a rendering of the page up to the first error.
+
+
Added: trunk/LayoutTests/svg/custom/bug78807.svg (0 => 109299)
--- trunk/LayoutTests/svg/custom/bug78807.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/bug78807.svg 2012-03-01 03:54:24 UTC (rev 109299)
@@ -0,0 +1,11 @@
+svg style=content:counter(counter_0); xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
+ !-- This test passes if there is no crash. --
+ script
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+ /script
+ g id=g
+style
+/style
+ /g
+ use xlink:href=""
Added: trunk/LayoutTests/svg/custom/bug78838-expected.txt (0 => 109299)
--- trunk/LayoutTests/svg/custom/bug78838-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/bug78838-expected.txt 2012-03-01 03:54:24 UTC (rev 109299)
@@ -0,0 +1,2 @@
+
+PASSED
Added: trunk/LayoutTests/svg/custom/bug78838.html (0 => 109299)
--- trunk/LayoutTests/svg/custom/bug78838.html (rev 0)
+++ trunk/LayoutTests/svg/custom/bug78838.html 2012-03-01 03:54:24 UTC (rev 109299)
@@ -0,0 +1,19 @@
+!-- This test passes if there is no crash. --
+script
+function go() {
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+q = document.getElementById('root').contentDocument;
+q.firstChild.setAttribute('style', 'content:counter(item)');
+
+document.designMode = 'on';
+q.execCommand('selectAll');
+q.execCommand('insertImage');
+q.getElementById('x').appendChild( q.firstChild.cloneNode(1) );
+q.execCommand('undo');
+}
+/script
+object data="" id=root
[webkit-changes] [109300] trunk/Source
Title: [109300] trunk/Source
Revision 109300
Author simon...@chromium.org
Date 2012-02-29 20:08:54 -0800 (Wed, 29 Feb 2012)
Log Message
[chromium] Fix navigation start time on cross-renderer navigation
https://bugs.webkit.org/show_bug.cgi?id=75922
Reviewed by Darin Fisher.
Source/WebCore:
* loader/DocumentLoadTiming.cpp:
(WebCore::DocumentLoadTiming::setNavigationStart): Added.
* loader/DocumentLoadTiming.h:
Source/WebKit/chromium:
* public/WebDataSource.h:
* src/WebDataSource.cpp:
(WebKit::WebDataSource::setNavigationStartTime): Added.
* src/WebDataSource.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoadTiming.cpp
trunk/Source/WebCore/loader/DocumentLoadTiming.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDataSource.h
trunk/Source/WebKit/chromium/src/WebDataSourceImpl.cpp
trunk/Source/WebKit/chromium/src/WebDataSourceImpl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109299 => 109300)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 03:54:24 UTC (rev 109299)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 04:08:54 UTC (rev 109300)
@@ -1,3 +1,14 @@
+2012-02-29 James Simonsen simon...@chromium.org
+
+[chromium] Fix navigation start time on cross-renderer navigation
+https://bugs.webkit.org/show_bug.cgi?id=75922
+
+Reviewed by Darin Fisher.
+
+* loader/DocumentLoadTiming.cpp:
+(WebCore::DocumentLoadTiming::setNavigationStart): Added.
+* loader/DocumentLoadTiming.h:
+
2012-02-29 Stephen Chenney schen...@chromium.org
SVG use element allows invalid contents
Modified: trunk/Source/WebCore/loader/DocumentLoadTiming.cpp (109299 => 109300)
--- trunk/Source/WebCore/loader/DocumentLoadTiming.cpp 2012-03-01 03:54:24 UTC (rev 109299)
+++ trunk/Source/WebCore/loader/DocumentLoadTiming.cpp 2012-03-01 04:08:54 UTC (rev 109300)
@@ -72,6 +72,12 @@
}
}
+void DocumentLoadTiming::setNavigationStart(double navigationStart)
+{
+ASSERT(m_referenceMonotonicTime m_referenceWallTime);
+m_navigationStart = navigationStart;
+}
+
void DocumentLoadTiming::addRedirect(const KURL redirectingUrl, const KURL redirectedUrl)
{
m_redirectCount++;
Modified: trunk/Source/WebCore/loader/DocumentLoadTiming.h (109299 => 109300)
--- trunk/Source/WebCore/loader/DocumentLoadTiming.h 2012-03-01 03:54:24 UTC (rev 109299)
+++ trunk/Source/WebCore/loader/DocumentLoadTiming.h 2012-03-01 04:08:54 UTC (rev 109300)
@@ -38,6 +38,7 @@
DocumentLoadTiming();
void markNavigationStart(Frame*);
+void setNavigationStart(double);
void addRedirect(const KURL redirectingUrl, const KURL redirectedUrl);
double convertMonotonicTimeToDocumentTime(double monotonicTime) const;
Modified: trunk/Source/WebKit/chromium/ChangeLog (109299 => 109300)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-01 03:54:24 UTC (rev 109299)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-01 04:08:54 UTC (rev 109300)
@@ -1,3 +1,15 @@
+2012-02-29 James Simonsen simon...@chromium.org
+
+[chromium] Fix navigation start time on cross-renderer navigation
+https://bugs.webkit.org/show_bug.cgi?id=75922
+
+Reviewed by Darin Fisher.
+
+* public/WebDataSource.h:
+* src/WebDataSource.cpp:
+(WebKit::WebDataSource::setNavigationStartTime): Added.
+* src/WebDataSource.h:
+
2012-02-29 Ian Vollick voll...@chromium.org
[chromium] Add impl-thread support for animation-timing-function
Modified: trunk/Source/WebKit/chromium/public/WebDataSource.h (109299 => 109300)
--- trunk/Source/WebKit/chromium/public/WebDataSource.h 2012-03-01 03:54:24 UTC (rev 109299)
+++ trunk/Source/WebKit/chromium/public/WebDataSource.h 2012-03-01 04:08:54 UTC (rev 109300)
@@ -103,6 +103,14 @@
// testing.
virtual void setDeferMainResourceDataLoad(bool) = 0;
+// Sets the navigation start time for this datasource. Ordinarily,
+// navigation start is determined in WebCore. But, in some situations,
+// the embedder might have a better value and can override it here. This
+// should be called before WebFrameClient::didCommitProvisionalLoad.
+// Calling it later may confuse users, because _javascript_ may have run and
+// the user may have already recorded the original value.
+virtual void setNavigationStartTime(double) = 0;
+
protected:
~WebDataSource() { }
};
Modified: trunk/Source/WebKit/chromium/src/WebDataSourceImpl.cpp (109299 => 109300)
--- trunk/Source/WebKit/chromium/src/WebDataSourceImpl.cpp 2012-03-01 03:54:24 UTC (rev 109299)
+++ trunk/Source/WebKit/chromium/src/WebDataSourceImpl.cpp 2012-03-01 04:08:54 UTC (rev 109300)
@@ -129,6 +129,11 @@
DocumentLoader::setDeferMainResourceDataLoad(defer);
}
+void WebDataSourceImpl::setNavigationStartTime(double navigationStart)
+{
+timing()-setNavigationStart(navigationStart);
+}
+
WebNavigationType
[webkit-changes] [109302] trunk/Source
Title: [109302] trunk/Source Revision 109302 Author noam.rosent...@nokia.com Date 2012-02-29 20:22:28 -0800 (Wed, 29 Feb 2012) Log Message [Qt][WK2] Get rid of the #ifdef mess in LayerTreeHost[Proxy] https://bugs.webkit.org/show_bug.cgi?id=79501 Source/_javascript_Core: Enable WTF_USE_UI_SIDE_COMPOSITING for Qt. Reviewed by Kenneth Rohde Christiansen. * wtf/Platform.h: Source/WebKit2: Use a new UI_SIDE_COMPOSITING flag instead of the several #ifdef flags we currently use. Reviewed by Kenneth Rohde Christiansen. * Shared/WebLayerTreeInfo.cpp: * Shared/WebLayerTreeInfo.h: * UIProcess/DrawingAreaProxy.cpp: (WebKit): * UIProcess/DrawingAreaProxy.h: (DrawingAreaProxy): * UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit): * UIProcess/DrawingAreaProxyImpl.h: (DrawingAreaProxyImpl): * UIProcess/LayerTreeHostProxy.h: (LayerTreeHostProxy): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): * UIProcess/qt/LayerBackingStore.cpp: * UIProcess/qt/LayerBackingStore.h: * UIProcess/qt/LayerTreeHostProxyQt.cpp: * WebProcess/WebCoreSupport/WebGraphicsLayer.cpp: * WebProcess/WebCoreSupport/WebGraphicsLayer.h: * WebProcess/WebPage/DrawingArea.h: (DrawingArea): * WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit): * WebProcess/WebPage/DrawingAreaImpl.h: (DrawingAreaImpl): * WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create): * WebProcess/WebPage/qt/LayerTreeHostQt.cpp: (WebKit::LayerTreeHostQt::purgeBackingStores): * WebProcess/WebPage/qt/LayerTreeHostQt.h: (LayerTreeHostQt): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/Platform.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebLayerTreeInfo.cpp trunk/Source/WebKit2/Shared/WebLayerTreeInfo.h trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.cpp trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h trunk/Source/WebKit2/UIProcess/LayerTreeHostProxy.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/qt/LayerBackingStore.cpp trunk/Source/WebKit2/UIProcess/qt/LayerBackingStore.h trunk/Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h trunk/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.cpp trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (109301 => 109302) --- trunk/Source/_javascript_Core/ChangeLog 2012-03-01 04:20:18 UTC (rev 109301) +++ trunk/Source/_javascript_Core/ChangeLog 2012-03-01 04:22:28 UTC (rev 109302) @@ -1,3 +1,14 @@ +2012-02-29 No'am Rosenthal noam.rosent...@nokia.com + +[Qt][WK2] Get rid of the #ifdef mess in LayerTreeHost[Proxy] +https://bugs.webkit.org/show_bug.cgi?id=79501 + +Enable WTF_USE_UI_SIDE_COMPOSITING for Qt. + +Reviewed by Kenneth Rohde Christiansen. + +* wtf/Platform.h: + 2012-02-29 Gavin Barraclough barraclo...@apple.com Rubber stamped by Oliver Hunt. Modified: trunk/Source/_javascript_Core/wtf/Platform.h (109301 => 109302) --- trunk/Source/_javascript_Core/wtf/Platform.h 2012-03-01 04:20:18 UTC (rev 109301) +++ trunk/Source/_javascript_Core/wtf/Platform.h 2012-03-01 04:22:28 UTC (rev 109302) @@ -1074,6 +1074,11 @@ #define WTF_USE_ACCELERATED_COMPOSITING 1 #endif +/* Compositing on the UI-process in WebKit2 */ +#if PLATFORM(QT) +#define WTF_USE_UI_SIDE_COMPOSITING 1 +#endif + #if (PLATFORM(MAC) !defined(BUILDING_ON_LEOPARD)) || PLATFORM(IOS) #define WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK 1 #endif Modified: trunk/Source/WebKit2/ChangeLog (109301 => 109302) --- trunk/Source/WebKit2/ChangeLog 2012-03-01 04:20:18 UTC (rev 109301) +++ trunk/Source/WebKit2/ChangeLog 2012-03-01 04:22:28 UTC (rev 109302) @@ -1,3 +1,46 @@ +2012-02-29 No'am Rosenthal noam.rosent...@nokia.com + +[Qt][WK2] Get rid of the #ifdef mess in LayerTreeHost[Proxy] +https://bugs.webkit.org/show_bug.cgi?id=79501 + +Use a new UI_SIDE_COMPOSITING flag instead of the several #ifdef flags we currently use. + +Reviewed by Kenneth Rohde Christiansen. + +* Shared/WebLayerTreeInfo.cpp: +* Shared/WebLayerTreeInfo.h: +* UIProcess/DrawingAreaProxy.cpp: +(WebKit): +* UIProcess/DrawingAreaProxy.h: +(DrawingAreaProxy): +* UIProcess/DrawingAreaProxyImpl.cpp: +(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): +
[webkit-changes] [109303] trunk/LayoutTests
Title: [109303] trunk/LayoutTests Revision 109303 Author hara...@chromium.org Date 2012-02-29 20:26:39 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed, gardening. * platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-linux/fast/workers/ trunk/LayoutTests/platform/chromium-linux/fast/workers/storage/ trunk/LayoutTests/platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (109302 => 109303) --- trunk/LayoutTests/ChangeLog 2012-03-01 04:22:28 UTC (rev 109302) +++ trunk/LayoutTests/ChangeLog 2012-03-01 04:26:39 UTC (rev 109303) @@ -1,3 +1,9 @@ +2012-02-29 Kentaro Hara hara...@chromium.org + +Unreviewed, gardening. + +* platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Added. + 2012-02-29 Stephen Chenney schen...@chromium.org SVG use element allows invalid contents Added: trunk/LayoutTests/platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt (0 => 109303) --- trunk/LayoutTests/platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt 2012-03-01 04:26:39 UTC (rev 109303) @@ -0,0 +1,3 @@ + +Test that we can successfully use the same database in the page and in multiple workers at the same time. + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109304] trunk/Source
Title: [109304] trunk/Source
Revision 109304
Author wjmacl...@chromium.org
Date 2012-02-29 20:33:03 -0800 (Wed, 29 Feb 2012)
Log Message
[chromium] Estimate pixel count for frame rate control
https://bugs.webkit.org/show_bug.cgi?id=74982
Reviewed by James Robinson.
Source/WebCore:
Value checks added to unit tests.
Adds mechanism to compute and collect statistics on pixel overdraw for selected frames.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::wedgeProduct):
(WebCore):
(WebCore::quadArea):
(WebCore::CCQuadCuller::cullOccludedQuads):
* platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::optimizeQuads):
* platform/graphics/chromium/cc/CCRenderPass.h:
(CCOverdrawCounts):
(WebCore):
(CCRenderPass):
Source/WebKit/chromium:
Adds mechanism to compute and collect statistics on pixel overdraw for selected frames.
* tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCQuadCullerTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (109303 => 109304)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 04:26:39 UTC (rev 109303)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 04:33:03 UTC (rev 109304)
@@ -1,3 +1,30 @@
+2012-02-29 W. James MacLean wjmacl...@chromium.org
+
+[chromium] Estimate pixel count for frame rate control
+https://bugs.webkit.org/show_bug.cgi?id=74982
+
+Reviewed by James Robinson.
+
+Value checks added to unit tests.
+
+Adds mechanism to compute and collect statistics on pixel overdraw for selected frames.
+
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
+* platform/graphics/chromium/cc/CCQuadCuller.cpp:
+(WebCore::wedgeProduct):
+(WebCore):
+(WebCore::quadArea):
+(WebCore::CCQuadCuller::cullOccludedQuads):
+* platform/graphics/chromium/cc/CCQuadCuller.h:
+(CCQuadCuller):
+* platform/graphics/chromium/cc/CCRenderPass.cpp:
+(WebCore::CCRenderPass::optimizeQuads):
+* platform/graphics/chromium/cc/CCRenderPass.h:
+(CCOverdrawCounts):
+(WebCore):
+(CCRenderPass):
+
2012-02-29 Jason Liu jason@torchmobile.com.cn
[BlackBerry]Make about:cache feature available in release version.
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (109303 => 109304)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2012-03-01 04:26:39 UTC (rev 109303)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2012-03-01 04:33:03 UTC (rev 109304)
@@ -234,10 +234,17 @@
bool haveDamageRect = layerRendererCapabilities().usingPartialSwap;
+// FIXME: compute overdraw metrics only occasionally, not every frame.
+CCOverdrawCounts overdrawCounts;
for (unsigned i = 0; i passes.size(); ++i) {
FloatRect damageRect = passes[i]-targetSurface()-damageTracker()-currentDamageRect();
-passes[i]-optimizeQuads(haveDamageRect, damageRect);
+passes[i]-optimizeQuads(haveDamageRect, damageRect, overdrawCounts);
}
+
+float normalization = 1000.f / (m_layerRenderer-viewportWidth() * m_layerRenderer-viewportHeight());
+PlatformSupport::histogramCustomCounts(Renderer4.pixelOverdrawOpaque, static_castint(normalization * overdrawCounts.m_pixelsDrawnOpaque), 100, 100, 50);
+PlatformSupport::histogramCustomCounts(Renderer4.pixelOverdrawTransparent, static_castint(normalization * overdrawCounts.m_pixelsDrawnTransparent), 100, 100, 50);
+PlatformSupport::histogramCustomCounts(Renderer4.pixelOverdrawCulled, static_castint(normalization * overdrawCounts.m_pixelsCulled), 100, 100, 50);
}
void CCLayerTreeHostImpl::animateLayersRecursive(CCLayerImpl* current, double frameBeginTimeSecs, CCAnimationEventsVector events, bool didAnimate, bool needsAnimateLayers)
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.cpp (109303 => 109304)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.cpp 2012-03-01 04:26:39 UTC (rev 109303)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCQuadCuller.cpp 2012-03-01 04:33:03 UTC (rev 109304)
@@ -75,8 +75,23 @@
return rect;
}
-void CCQuadCuller::cullOccludedQuads(CCQuadList
[webkit-changes] [109305] trunk
Title: [109305] trunk
Revision 109305
Author jsb...@chromium.org
Date 2012-02-29 21:22:57 -0800 (Wed, 29 Feb 2012)
Log Message
IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
https://bugs.webkit.org/show_bug.cgi?id=79950
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/list-ordering.html
* dom/DOMStringList.cpp: Added sort method, not exposed via IDL.
(WebCore::DOMStringList::sort):
(WebCore):
* dom/DOMStringList.h:
(DOMStringList):
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::objectStoreNames):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::indexNames):
LayoutTests:
* storage/indexeddb/list-ordering-expected.txt: Added.
* storage/indexeddb/list-ordering.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMStringList.cpp
trunk/Source/WebCore/dom/DOMStringList.h
trunk/Source/WebCore/storage/IDBDatabaseBackendImpl.cpp
trunk/Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp
Added Paths
trunk/LayoutTests/storage/indexeddb/list-ordering-expected.txt
trunk/LayoutTests/storage/indexeddb/list-ordering.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109304 => 109305)
--- trunk/LayoutTests/ChangeLog 2012-03-01 04:33:03 UTC (rev 109304)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 05:22:57 UTC (rev 109305)
@@ -1,3 +1,13 @@
+2012-02-29 Joshua Bell jsb...@chromium.org
+
+IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
+https://bugs.webkit.org/show_bug.cgi?id=79950
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/list-ordering-expected.txt: Added.
+* storage/indexeddb/list-ordering.html: Added.
+
2012-02-29 Kentaro Hara hara...@chromium.org
Unreviewed, gardening.
Added: trunk/LayoutTests/storage/indexeddb/list-ordering-expected.txt (0 => 109305)
--- trunk/LayoutTests/storage/indexeddb/list-ordering-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/list-ordering-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
@@ -0,0 +1,65 @@
+
+Test string list ordering in IndexedDB.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+indexedDB = window.indexedDB || window.webkitIndexedDB
+PASS indexedDB != null is true
+check that the expected order is the canonical JS sort order:
+sorted_order = expected_order.slice(); sorted_order.sort()
+PASS areArraysEqual(sorted_order, expected_order) is true
+
+testStoresAndIndexes():
+indexedDB.deleteDatabase('list-ordering')
+indexedDB.open('list-ordering')
+db = request.result
+PASS db.version is
+db.setVersion('1')
+
+Object stores:
+db.createObjectStore(턞)
+db.createObjectStore(�)
+db.createObjectStore(Ā)
+db.createObjectStore(က)
+db.createObjectStore(á)
+db.createObjectStore(ÿ)
+db.createObjectStore(Á)
+db.createObjectStore(à)
+db.createObjectStore()
+db.createObjectStore(À)
+db.createObjectStore(a)
+db.createObjectStore(b)
+db.createObjectStore(A)
+db.createObjectStore(B)
+db.createObjectStore(0)
+db.createObjectStore(1)
+db.createObjectStore(\u)
+db.createObjectStore()
+PASS areArraysEqual(db.objectStoreNames, expected_order) is true
+
+Indexes:
+store = db.createObjectStore('store')
+store.createIndex(턞, 'keyPath')
+store.createIndex(�, 'keyPath')
+store.createIndex(Ā, 'keyPath')
+store.createIndex(က, 'keyPath')
+store.createIndex(á, 'keyPath')
+store.createIndex(ÿ, 'keyPath')
+store.createIndex(Á, 'keyPath')
+store.createIndex(à, 'keyPath')
+store.createIndex(, 'keyPath')
+store.createIndex(À, 'keyPath')
+store.createIndex(a, 'keyPath')
+store.createIndex(b, 'keyPath')
+store.createIndex(A, 'keyPath')
+store.createIndex(B, 'keyPath')
+store.createIndex(0, 'keyPath')
+store.createIndex(1, 'keyPath')
+store.createIndex(\u, 'keyPath')
+store.createIndex(, 'keyPath')
+PASS areArraysEqual(store.indexNames, expected_order) is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/storage/indexeddb/list-ordering.html (0 => 109305)
--- trunk/LayoutTests/storage/indexeddb/list-ordering.html (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/list-ordering.html 2012-03-01 05:22:57 UTC (rev 109305)
@@ -0,0 +1,100 @@
+html
+head
+script src=""
+script src=""
+/head
+body
+input type=file id=fileInput multiple/input
+p id=description/p
+div id=console/div
+script
+
+description(Test string list ordering in IndexedDB.);
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+var expected_order = [
+ ,
+ \x00, // 'NULL' (U+)
+ 0,
+ 1,
+ A,
+ B,
+ a,
+ b,
+ \x7F, // 'DELETE' (U+007F)
+ \xC0, // 'LATIN CAPITAL LETTER A WITH GRAVE' (U+00C0)
+ \xC1, // 'LATIN CAPITAL LETTER A WITH ACUTE' (U+00C1)
+ \xE0, // 'LATIN SMALL LETTER A WITH GRAVE' (U+00E0)
+ \xE1, // 'LATIN SMALL LETTER A WITH ACUTE' (U+00E1)
+ \xFF, // 'LATIN
[webkit-changes] [109306] trunk
Title: [109306] trunk
Revision 109306
Author a...@chromium.org
Date 2012-02-29 21:34:33 -0800 (Wed, 29 Feb 2012)
Log Message
Rename DOMSelection to Selection
https://bugs.webkit.org/show_bug.cgi?id=79688
Reviewed by Adam Barth.
Source/WebCore:
No new tests. Existing tests have been updated to cover this.
* page/DOMSelection.idl:
* page/DOMWindow.idl:
LayoutTests:
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt
trunk/LayoutTests/fast/dom/dom-constructors-expected.txt
trunk/LayoutTests/fast/dom/dom-constructors.html
trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt
trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt
trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt
trunk/LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt
trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt
trunk/LayoutTests/platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt
trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMSelection.idl
trunk/Source/WebCore/page/DOMWindow.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (109305 => 109306)
--- trunk/LayoutTests/ChangeLog 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 05:34:33 UTC (rev 109306)
@@ -1,3 +1,21 @@
+2012-02-29 Erik Arvidsson a...@chromium.org
+
+Rename DOMSelection to Selection
+https://bugs.webkit.org/show_bug.cgi?id=79688
+
+Reviewed by Adam Barth.
+
+* fast/dom/Window/window-properties-expected.txt:
+* fast/dom/dom-constructors-expected.txt:
+* fast/dom/dom-constructors.html:
+* platform/gtk/fast/dom/Window/window-properties-expected.txt:
+* platform/mac/fast/dom/Window/window-properties-expected.txt:
+* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
+* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
+* platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
+* platform/qt/fast/dom/Window/window-properties-expected.txt:
+* platform/win/fast/dom/Window/window-properties-expected.txt:
+
2012-02-29 Joshua Bell jsb...@chromium.org
IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
Modified: trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt (109305 => 109306)
--- trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -2494,7 +2494,7 @@
window.webkitConvertPointFromNodeToPage [function]
window.webkitConvertPointFromPageToNode [function]
window.window [printed above as window]
-window.getSelection() [object DOMSelection]
+window.getSelection() [object Selection]
window.getSelection().addRange [function]
window.getSelection().anchorNode [null]
window.getSelection().anchorOffset [number]
Modified: trunk/LayoutTests/fast/dom/dom-constructors-expected.txt (109305 => 109306)
--- trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -115,7 +115,7 @@
PASS TryAllocate('CanvasGradient') is 'exception'
PASS TryAllocate('CanvasPattern') is 'exception'
FAIL TryAllocate('Console') should be exception. Was no constructor.
-FAIL TryAllocate('DOMSelection') should be exception. Was no constructor.
+PASS TryAllocate('Selection') is 'exception'
PASS TryAllocate('Window') is 'exception'
FAIL TryAllocate('History') should be exception. Was no constructor.
FAIL TryAllocate('HTMLOptionsCollection') should be exception. Was no constructor.
Modified: trunk/LayoutTests/fast/dom/dom-constructors.html (109305 => 109306)
--- trunk/LayoutTests/fast/dom/dom-constructors.html 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/fast/dom/dom-constructors.html 2012-03-01 05:34:33 UTC (rev 109306)
@@ -47,7 +47,7 @@
'NodeFilter', 'NodeList', 'Plugin',
'PluginArray', 'Range', 'Rect', 'StyleSheet', 'StyleSheetList',
'TextEvent', 'UIEvent',
[webkit-changes] [109308] trunk/Source/JavaScriptCore
Title: [109308] trunk/Source/_javascript_Core
Revision 109308
Author fpi...@apple.com
Date 2012-02-29 21:47:19 -0800 (Wed, 29 Feb 2012)
Log Message
The JIT should not crash the entire process just because there is not
enough executable memory, if the LLInt is enabled
https://bugs.webkit.org/show_bug.cgi?id=79962
rdar://problem/10922215
Unreviewed, adding forgotten file.
* jit/JITCompilationEffort.h: Added.
(JSC):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
Added Paths
trunk/Source/_javascript_Core/jit/JITCompilationEffort.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (109307 => 109308)
--- trunk/Source/_javascript_Core/ChangeLog 2012-03-01 05:46:20 UTC (rev 109307)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-03-01 05:47:19 UTC (rev 109308)
@@ -5,6 +5,18 @@
https://bugs.webkit.org/show_bug.cgi?id=79962
rdar://problem/10922215
+Unreviewed, adding forgotten file.
+
+* jit/JITCompilationEffort.h: Added.
+(JSC):
+
+2012-02-29 Filip Pizlo fpi...@apple.com
+
+The JIT should not crash the entire process just because there is not
+enough executable memory, if the LLInt is enabled
+https://bugs.webkit.org/show_bug.cgi?id=79962
+rdar://problem/10922215
+
Reviewed by Gavin Barraclough.
Added the notion of JITCompilationEffort. If we're JIT'ing as a result of
Added: trunk/Source/_javascript_Core/jit/JITCompilationEffort.h (0 => 109308)
--- trunk/Source/_javascript_Core/jit/JITCompilationEffort.h (rev 0)
+++ trunk/Source/_javascript_Core/jit/JITCompilationEffort.h 2012-03-01 05:47:19 UTC (rev 109308)
@@ -0,0 +1,39 @@
+/*
+ * Copyright (C) 2012 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef JITCompilationEffort_h
+#define JITCompilationEffort_h
+
+namespace JSC {
+
+enum JITCompilationEffort {
+JITCompilationCanFail,
+JITCompilationMustSucceed
+};
+
+} // namespace JSC
+
+#endif // JITCompilationEffort_h
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109309] trunk/LayoutTests
Title: [109309] trunk/LayoutTests
Revision 109309
Author shin...@chromium.org
Date 2012-02-29 21:57:05 -0800 (Wed, 29 Feb 2012)
Log Message
createContentWithSelect in shadow-test-driver.js is not intuitive.
https://bugs.webkit.org/show_bug.cgi?id=80002
Reviewed by Hajime Morita.
createContentWithSelect takes an agument 'fallback', but it used to create a text node
if the argument is missing. This is not intuitive at all.
This patch changes the createContentWithSelect behavior to make it intuitive.
* fast/dom/resources/shadow-test-driver.js:
(createContentWithSelect):
* fast/dom/shadow/content-element-move.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js
trunk/LayoutTests/fast/dom/shadow/content-element-move.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109308 => 109309)
--- trunk/LayoutTests/ChangeLog 2012-03-01 05:47:19 UTC (rev 109308)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 05:57:05 UTC (rev 109309)
@@ -1,3 +1,19 @@
+2012-02-29 Shinya Kawanaka shin...@chromium.org
+
+createContentWithSelect in shadow-test-driver.js is not intuitive.
+https://bugs.webkit.org/show_bug.cgi?id=80002
+
+Reviewed by Hajime Morita.
+
+createContentWithSelect takes an agument 'fallback', but it used to create a text node
+if the argument is missing. This is not intuitive at all.
+
+This patch changes the createContentWithSelect behavior to make it intuitive.
+
+* fast/dom/resources/shadow-test-driver.js:
+(createContentWithSelect):
+* fast/dom/shadow/content-element-move.html:
+
2012-02-29 Erik Arvidsson a...@chromium.org
Rename DOMSelection to Selection
Modified: trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js (109308 => 109309)
--- trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js 2012-03-01 05:47:19 UTC (rev 109308)
+++ trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js 2012-03-01 05:57:05 UTC (rev 109309)
@@ -61,11 +61,11 @@
return span;
}
-function createContentWithSelect(select, fallback) {
+function createContentWithSelect(select, fallbackText) {
var content = internals.createContentElement(document);
content.setAttribute('select', select);
-if (!fallback)
-content.appendChild(createSpanWithText(FALLBACK));
+if (fallbackText)
+content.appendChild(createSpanWithText(fallbackText));
return content;
}
Modified: trunk/LayoutTests/fast/dom/shadow/content-element-move.html (109308 => 109309)
--- trunk/LayoutTests/fast/dom/shadow/content-element-move.html 2012-03-01 05:47:19 UTC (rev 109308)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-move.html 2012-03-01 05:57:05 UTC (rev 109309)
@@ -22,7 +22,7 @@
root.innerHTML = spanLIGHT/span;
// Create shadow tree.
-var content = createContentWithSelect('span');
+var content = createContentWithSelect('span', 'FALLBACK');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content);
@@ -48,8 +48,8 @@
root.innerHTML = span class='c1'LIGHT 1/spanspanLIGHT 2/span;
// Create shadow tree.
-var content1 = createContentWithSelect('.c1');
-var content2 = createContentWithSelect('span');
+var content1 = createContentWithSelect('.c1', 'FALLBACK');
+var content2 = createContentWithSelect('span', 'FALLBACK');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content1);
@@ -77,8 +77,8 @@
root.innerHTML = spanLIGHT 1/spanspan class='c1'LIGHT 2/span;
// Create shadow tree.
-var content1 = createContentWithSelect('.c1');
-var content2 = createContentWithSelect('span');
+var content1 = createContentWithSelect('.c1', 'FALLBACK');
+var content2 = createContentWithSelect('span', 'FALLBACK');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content1);
@@ -133,7 +133,7 @@
root.innerHTML = spanLIGHT/span;
// Create shadow tree.
-var content = createContentWithSelect('span');
+var content = createContentWithSelect('span', 'FALLBACK');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content);
@@ -159,7 +159,7 @@
root.innerHTML = spanLIGHT/span;
// Create shadow tree.
-var content = createContentWithSelect('span');
+var content = createContentWithSelect('span', 'FALLBACK');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content);
@@ -186,7 +186,7 @@
root.innerHTML = spanLIGHT 1/spanspan class='c1'LIGHT 2/span;
// Create shadow tree.
-var content = createContentWithSelect('.c1');
+var content = createContentWithSelect('.c1', 'FALLBACK');
var sr = internals.ensureShadowRoot(root);
[webkit-changes] [109310] trunk/Source/WebCore
Title: [109310] trunk/Source/WebCore Revision 109310 Author macpher...@chromium.org Date 2012-02-29 22:12:22 -0800 (Wed, 29 Feb 2012) Log Message Handle CSSPropertyWebkitColumnAxis in CSSStyleApplyProperty. https://bugs.webkit.org/show_bug.cgi?id=79869 Reviewed by Eric Seidel. No new tests / refactoring only. * css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::collectMatchingRulesForList): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp trunk/Source/WebCore/css/CSSStyleSelector.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (109309 => 109310) --- trunk/Source/WebCore/ChangeLog 2012-03-01 05:57:05 UTC (rev 109309) +++ trunk/Source/WebCore/ChangeLog 2012-03-01 06:12:22 UTC (rev 109310) @@ -1,3 +1,17 @@ +2012-02-29 Luke Macpherson macpher...@chromium.org + +Handle CSSPropertyWebkitColumnAxis in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=79869 + +Reviewed by Eric Seidel. + +No new tests / refactoring only. + +* css/CSSStyleApplyProperty.cpp: +(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): +* css/CSSStyleSelector.cpp: +(WebCore::CSSStyleSelector::collectMatchingRulesForList): + 2012-02-29 Erik Arvidsson a...@chromium.org Rename DOMSelection to Selection Modified: trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp (109309 => 109310) --- trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp 2012-03-01 05:57:05 UTC (rev 109309) +++ trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp 2012-03-01 06:12:22 UTC (rev 109310) @@ -1821,6 +1821,7 @@ setPropertyHandler(CSSPropertyWebkitBoxOrdinalGroup, ApplyPropertyDefaultunsigned int, RenderStyle::boxOrdinalGroup, unsigned int, RenderStyle::setBoxOrdinalGroup, unsigned int, RenderStyle::initialBoxOrdinalGroup::createHandler()); setPropertyHandler(CSSPropertyWebkitBoxOrient, ApplyPropertyDefaultEBoxOrient, RenderStyle::boxOrient, EBoxOrient, RenderStyle::setBoxOrient, EBoxOrient, RenderStyle::initialBoxOrient::createHandler()); setPropertyHandler(CSSPropertyWebkitBoxPack, ApplyPropertyDefaultEBoxPack, RenderStyle::boxPack, EBoxPack, RenderStyle::setBoxPack, EBoxPack, RenderStyle::initialBoxPack::createHandler()); +setPropertyHandler(CSSPropertyWebkitColumnAxis, ApplyPropertyDefaultColumnAxis, RenderStyle::columnAxis, ColumnAxis, RenderStyle::setColumnAxis, ColumnAxis, RenderStyle::initialColumnAxis::createHandler()); setPropertyHandler(CSSPropertyWebkitColumnCount, ApplyPropertyAutounsigned short, RenderStyle::columnCount, RenderStyle::setColumnCount, RenderStyle::hasAutoColumnCount, RenderStyle::setHasAutoColumnCount::createHandler()); setPropertyHandler(CSSPropertyWebkitColumnGap, ApplyPropertyAutofloat, RenderStyle::columnGap, RenderStyle::setColumnGap, RenderStyle::hasNormalColumnGap, RenderStyle::setHasNormalColumnGap, ComputeLength, CSSValueNormal::createHandler()); setPropertyHandler(CSSPropertyWebkitColumnRuleColor, ApplyPropertyColorNoInheritFromParent, RenderStyle::columnRuleColor, RenderStyle::setColumnRuleColor, RenderStyle::setVisitedLinkColumnRuleColor, RenderStyle::color::createHandler()); Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (109309 => 109310) --- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-03-01 05:57:05 UTC (rev 109309) +++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-03-01 06:12:22 UTC (rev 109310) @@ -3741,10 +3741,6 @@ return; } -case CSSPropertyWebkitColumnAxis: -HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(columnAxis, ColumnAxis); -return; - case CSSPropertyWebkitWrapShapeInside: HANDLE_INHERIT_AND_INITIAL(wrapShapeInside, WrapShapeInside); if (!primitiveValue) @@ -3969,6 +3965,7 @@ case CSSPropertyWebkitBoxOrdinalGroup: case CSSPropertyWebkitBoxOrient: case CSSPropertyWebkitBoxPack: +case CSSPropertyWebkitColumnAxis: case CSSPropertyWebkitColumnCount: case CSSPropertyWebkitColumnGap: case CSSPropertyWebkitColumnRuleColor: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109311] trunk/Source/WebCore
Title: [109311] trunk/Source/WebCore
Revision 109311
Author macpher...@chromium.org
Date 2012-02-29 22:22:39 -0800 (Wed, 29 Feb 2012)
Log Message
Handle CSSPropertySpeak in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79879
Reviewed by Eric Seidel.
No new tests / refactoring only.
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* rendering/style/RenderStyle.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109310 => 109311)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 06:12:22 UTC (rev 109310)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 06:22:39 UTC (rev 109311)
@@ -1,5 +1,20 @@
2012-02-29 Luke Macpherson macpher...@chromium.org
+Handle CSSPropertySpeak in CSSStyleApplyProperty.
+https://bugs.webkit.org/show_bug.cgi?id=79879
+
+Reviewed by Eric Seidel.
+
+No new tests / refactoring only.
+
+* css/CSSStyleApplyProperty.cpp:
+(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+* rendering/style/RenderStyle.h:
+
+2012-02-29 Luke Macpherson macpher...@chromium.org
+
Handle CSSPropertyWebkitColumnAxis in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79869
Modified: trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp (109310 => 109311)
--- trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp 2012-03-01 06:12:22 UTC (rev 109310)
+++ trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp 2012-03-01 06:22:39 UTC (rev 109311)
@@ -1784,6 +1784,7 @@
setPropertyHandler(CSSPropertyResize, ApplyPropertyResize::createHandler());
setPropertyHandler(CSSPropertyRight, ApplyPropertyLengthRenderStyle::right, RenderStyle::setRight, RenderStyle::initialOffset, AutoEnabled::createHandler());
setPropertyHandler(CSSPropertySize, ApplyPropertyPageSize::createHandler());
+setPropertyHandler(CSSPropertySpeak, ApplyPropertyDefaultESpeak, RenderStyle::speak, ESpeak, RenderStyle::setSpeak, ESpeak, RenderStyle::initialSpeak::createHandler());
setPropertyHandler(CSSPropertyTableLayout, ApplyPropertyDefaultETableLayout, RenderStyle::tableLayout, ETableLayout, RenderStyle::setTableLayout, ETableLayout, RenderStyle::initialTableLayout::createHandler());
setPropertyHandler(CSSPropertyTextAlign, ApplyPropertyTextAlign::createHandler());
setPropertyHandler(CSSPropertyTextDecoration, ApplyPropertyTextDecoration::createHandler());
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (109310 => 109311)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-03-01 06:12:22 UTC (rev 109310)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2012-03-01 06:22:39 UTC (rev 109311)
@@ -3646,9 +3646,6 @@
case CSSPropertyWebkitColorCorrection:
HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(colorSpace, ColorSpace);
return;
-case CSSPropertySpeak:
-HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(speak, Speak);
-return;
case CSSPropertyInvalid:
return;
// Directional properties are resolved by resolveDirectionAwareProperty() before the switch.
@@ -3928,6 +3925,7 @@
case CSSPropertyResize:
case CSSPropertyRight:
case CSSPropertySize:
+case CSSPropertySpeak:
case CSSPropertyTableLayout:
case CSSPropertyTextAlign:
case CSSPropertyTextDecoration:
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (109310 => 109311)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2012-03-01 06:12:22 UTC (rev 109310)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2012-03-01 06:22:39 UTC (rev 109311)
@@ -961,7 +961,7 @@
EImageRendering imageRendering() const { return static_castEImageRendering(rareInheritedData-m_imageRendering); }
-ESpeak speak() { return static_castESpeak(rareInheritedData-speak); }
+ESpeak speak() const { return static_castESpeak(rareInheritedData-speak); }
#if ENABLE(CSS_FILTERS)
FilterOperations filter() { return rareNonInheritedData.access()-m_filter.access()-m_operations; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109312] trunk/LayoutTests
Title: [109312] trunk/LayoutTests Revision 109312 Author hara...@chromium.org Date 2012-02-29 22:36:06 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed, gardening. * platform/chromium-mac-snowleopard/media/sources-fallback-codecs-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-mac-snowleopard/media/sources-fallback-codecs-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (109311 => 109312) --- trunk/LayoutTests/ChangeLog 2012-03-01 06:22:39 UTC (rev 109311) +++ trunk/LayoutTests/ChangeLog 2012-03-01 06:36:06 UTC (rev 109312) @@ -1,3 +1,9 @@ +2012-02-29 Kentaro Hara hara...@chromium.org + +Unreviewed, gardening. + +* platform/chromium-mac-snowleopard/media/sources-fallback-codecs-expected.txt: Added. + 2012-02-29 Shinya Kawanaka shin...@chromium.org createContentWithSelect in shadow-test-driver.js is not intuitive. Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/media/sources-fallback-codecs-expected.txt (0 => 109312) --- trunk/LayoutTests/platform/chromium-mac-snowleopard/media/sources-fallback-codecs-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-mac-snowleopard/media/sources-fallback-codecs-expected.txt 2012-03-01 06:36:06 UTC (rev 109312) @@ -0,0 +1,3 @@ +Test that fallback among codecs is done correctly regardless of their order. +END OF TEST + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109313] trunk/Source/WebCore
Title: [109313] trunk/Source/WebCore
Revision 109313
Author shin...@chromium.org
Date 2012-02-29 22:39:22 -0800 (Wed, 29 Feb 2012)
Log Message
Refactoring: HTMLContentSelector should be InsertionPoint-aware.
https://bugs.webkit.org/show_bug.cgi?id=79901
Reviewed by Hajime Morita.
ContentSelectorQuery took HTMLContentElement as argument, but patch changes it to take InsertionPoint instead.
If InsertionPoint is not HTMLContentElement, ContentSelectorQuery will selects the rest of light children.
Now InsertionPoint has pure virtual method 'select'. shadow will implement this as a method returning empty string.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::hasInsertionPoint):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::needsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::hostChildrenChanged):
* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):
* html/shadow/ContentSelectorQuery.h:
(WebCore):
(ContentSelectorQuery):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::detach):
* html/shadow/HTMLContentElement.h:
(WebCore::toHTMLContentElement):
(WebCore):
* html/shadow/HTMLContentSelector.cpp:
(WebCore::HTMLContentSelector::select):
* html/shadow/HTMLContentSelector.h:
(HTMLContentSelector):
* html/shadow/InsertionPoint.h:
(InsertionPoint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/dom/ShadowRoot.h
trunk/Source/WebCore/dom/ShadowTree.cpp
trunk/Source/WebCore/html/shadow/ContentSelectorQuery.cpp
trunk/Source/WebCore/html/shadow/ContentSelectorQuery.h
trunk/Source/WebCore/html/shadow/HTMLContentElement.cpp
trunk/Source/WebCore/html/shadow/HTMLContentElement.h
trunk/Source/WebCore/html/shadow/HTMLContentSelector.cpp
trunk/Source/WebCore/html/shadow/HTMLContentSelector.h
trunk/Source/WebCore/html/shadow/InsertionPoint.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (109312 => 109313)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 06:36:06 UTC (rev 109312)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 06:39:22 UTC (rev 109313)
@@ -1,3 +1,40 @@
+2012-02-29 Shinya Kawanaka shin...@chromium.org
+
+Refactoring: HTMLContentSelector should be InsertionPoint-aware.
+https://bugs.webkit.org/show_bug.cgi?id=79901
+
+Reviewed by Hajime Morita.
+
+ContentSelectorQuery took HTMLContentElement as argument, but patch changes it to take InsertionPoint instead.
+If InsertionPoint is not HTMLContentElement, ContentSelectorQuery will selects the rest of light children.
+
+Now InsertionPoint has pure virtual method 'select'. shadow will implement this as a method returning empty string.
+
+* dom/ShadowRoot.cpp:
+(WebCore::ShadowRoot::hasInsertionPoint):
+* dom/ShadowRoot.h:
+(ShadowRoot):
+* dom/ShadowTree.cpp:
+(WebCore::ShadowTree::needsReattachHostChildrenAndShadow):
+(WebCore::ShadowTree::hostChildrenChanged):
+* html/shadow/ContentSelectorQuery.cpp:
+(WebCore::ContentSelectorQuery::ContentSelectorQuery):
+(WebCore::ContentSelectorQuery::matches):
+* html/shadow/ContentSelectorQuery.h:
+(WebCore):
+(ContentSelectorQuery):
+* html/shadow/HTMLContentElement.cpp:
+(WebCore::HTMLContentElement::detach):
+* html/shadow/HTMLContentElement.h:
+(WebCore::toHTMLContentElement):
+(WebCore):
+* html/shadow/HTMLContentSelector.cpp:
+(WebCore::HTMLContentSelector::select):
+* html/shadow/HTMLContentSelector.h:
+(HTMLContentSelector):
+* html/shadow/InsertionPoint.h:
+(InsertionPoint):
+
2012-02-29 Luke Macpherson macpher...@chromium.org
Handle CSSPropertySpeak in CSSStyleApplyProperty.
Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (109312 => 109313)
--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-03-01 06:36:06 UTC (rev 109312)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2012-03-01 06:39:22 UTC (rev 109313)
@@ -178,10 +178,10 @@
return 0;
}
-bool ShadowRoot::hasContentElement() const
+bool ShadowRoot::hasInsertionPoint() const
{
for (Node* n = firstChild(); n; n = n-traverseNextNode(this)) {
-if (n-isContentElement())
+if (isInsertionPoint(n))
return true;
}
Modified: trunk/Source/WebCore/dom/ShadowRoot.h (109312 => 109313)
--- trunk/Source/WebCore/dom/ShadowRoot.h 2012-03-01 06:36:06 UTC (rev 109312)
+++ trunk/Source/WebCore/dom/ShadowRoot.h 2012-03-01 06:39:22 UTC (rev 109313)
@@ -79,7 +79,7 @@
bool isYoungest() const { return !youngerShadowRoot(); }
bool isOldest() const { return !olderShadowRoot(); }
-bool hasContentElement() const;
+bool hasInsertionPoint() const;
private:
ShadowRoot(Document*);
Modified: trunk/Source/WebCore/dom/ShadowTree.cpp (109312 => 109313)
---
[webkit-changes] [109314] trunk/Source/WebKit/chromium
Title: [109314] trunk/Source/WebKit/chromium
Revision 109314
Author kin...@chromium.org
Date 2012-02-29 22:54:16 -0800 (Wed, 29 Feb 2012)
Log Message
Unreviewed. Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (109313 => 109314)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-01 06:39:22 UTC (rev 109313)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-01 06:54:16 UTC (rev 109314)
@@ -1,3 +1,9 @@
+2012-02-29 Kinuko Yasuda kin...@chromium.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-02-29 W. James MacLean wjmacl...@chromium.org
[chromium] Estimate pixel count for frame rate control
Modified: trunk/Source/WebKit/chromium/DEPS (109313 => 109314)
--- trunk/Source/WebKit/chromium/DEPS 2012-03-01 06:39:22 UTC (rev 109313)
+++ trunk/Source/WebKit/chromium/DEPS 2012-03-01 06:54:16 UTC (rev 109314)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '124176'
+ 'chromium_rev': '124223'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [109315] trunk/LayoutTests
Title: [109315] trunk/LayoutTests
Revision 109315
Author shin...@chromium.org
Date 2012-02-29 23:10:42 -0800 (Wed, 29 Feb 2012)
Log Message
Unreviewed, rolling out r109309.
http://trac.webkit.org/changeset/109309
https://bugs.webkit.org/show_bug.cgi?id=80002
broke
* fast/dom/resources/shadow-test-driver.js:
(createContentWithSelect):
* fast/dom/shadow/content-element-move.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js
trunk/LayoutTests/fast/dom/shadow/content-element-move.html
Diff
Modified: trunk/LayoutTests/ChangeLog (109314 => 109315)
--- trunk/LayoutTests/ChangeLog 2012-03-01 06:54:16 UTC (rev 109314)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 07:10:42 UTC (rev 109315)
@@ -1,3 +1,15 @@
+2012-02-29 Shinya Kawanaka shin...@chromium.org
+
+Unreviewed, rolling out r109309.
+http://trac.webkit.org/changeset/109309
+https://bugs.webkit.org/show_bug.cgi?id=80002
+
+broke
+
+* fast/dom/resources/shadow-test-driver.js:
+(createContentWithSelect):
+* fast/dom/shadow/content-element-move.html:
+
2012-02-29 Kentaro Hara hara...@chromium.org
Unreviewed, gardening.
Modified: trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js (109314 => 109315)
--- trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js 2012-03-01 06:54:16 UTC (rev 109314)
+++ trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js 2012-03-01 07:10:42 UTC (rev 109315)
@@ -61,11 +61,11 @@
return span;
}
-function createContentWithSelect(select, fallbackText) {
+function createContentWithSelect(select, fallback) {
var content = internals.createContentElement(document);
content.setAttribute('select', select);
-if (fallbackText)
-content.appendChild(createSpanWithText(fallbackText));
+if (!fallback)
+content.appendChild(createSpanWithText(FALLBACK));
return content;
}
Modified: trunk/LayoutTests/fast/dom/shadow/content-element-move.html (109314 => 109315)
--- trunk/LayoutTests/fast/dom/shadow/content-element-move.html 2012-03-01 06:54:16 UTC (rev 109314)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-move.html 2012-03-01 07:10:42 UTC (rev 109315)
@@ -22,7 +22,7 @@
root.innerHTML = spanLIGHT/span;
// Create shadow tree.
-var content = createContentWithSelect('span', 'FALLBACK');
+var content = createContentWithSelect('span');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content);
@@ -48,8 +48,8 @@
root.innerHTML = span class='c1'LIGHT 1/spanspanLIGHT 2/span;
// Create shadow tree.
-var content1 = createContentWithSelect('.c1', 'FALLBACK');
-var content2 = createContentWithSelect('span', 'FALLBACK');
+var content1 = createContentWithSelect('.c1');
+var content2 = createContentWithSelect('span');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content1);
@@ -77,8 +77,8 @@
root.innerHTML = spanLIGHT 1/spanspan class='c1'LIGHT 2/span;
// Create shadow tree.
-var content1 = createContentWithSelect('.c1', 'FALLBACK');
-var content2 = createContentWithSelect('span', 'FALLBACK');
+var content1 = createContentWithSelect('.c1');
+var content2 = createContentWithSelect('span');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content1);
@@ -133,7 +133,7 @@
root.innerHTML = spanLIGHT/span;
// Create shadow tree.
-var content = createContentWithSelect('span', 'FALLBACK');
+var content = createContentWithSelect('span');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content);
@@ -159,7 +159,7 @@
root.innerHTML = spanLIGHT/span;
// Create shadow tree.
-var content = createContentWithSelect('span', 'FALLBACK');
+var content = createContentWithSelect('span');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content);
@@ -186,7 +186,7 @@
root.innerHTML = spanLIGHT 1/spanspan class='c1'LIGHT 2/span;
// Create shadow tree.
-var content = createContentWithSelect('.c1', 'FALLBACK');
+var content = createContentWithSelect('.c1');
var sr = internals.ensureShadowRoot(root);
sr.appendChild(createSpanWithText(BEFORE));
sr.appendChild(content);
@@ -221,7 +221,7 @@
var f = (function(root, callIfDone) {
return function() {
-var content = createContentWithSelect('span', 'FALLBACK');
+var content = createContentWithSelect('span');
var sr = internals.ensureShadowRoot(root);
sr.insertBefore(content, sr.lastChild);
document.getElementById('expect-container').innerHTML =
[webkit-changes] [109316] trunk/LayoutTests
Title: [109316] trunk/LayoutTests Revision 109316 Author hara...@chromium.org Date 2012-02-29 23:23:26 -0800 (Wed, 29 Feb 2012) Log Message Unreviewed, gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (109315 => 109316) --- trunk/LayoutTests/ChangeLog 2012-03-01 07:10:42 UTC (rev 109315) +++ trunk/LayoutTests/ChangeLog 2012-03-01 07:23:26 UTC (rev 109316) @@ -1,3 +1,9 @@ +2012-02-29 Kentaro Hara hara...@chromium.org + +Unreviewed, gardening. + +* platform/chromium/test_expectations.txt: + 2012-02-29 Shinya Kawanaka shin...@chromium.org Unreviewed, rolling out r109309. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (109315 => 109316) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-01 07:10:42 UTC (rev 109315) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-01 07:23:26 UTC (rev 109316) @@ -4410,6 +4410,7 @@ BUGWK79540 DEBUG : fast/files/workers/worker-read-blob-sync.html = PASS CRASH BUGWK79572 : css3/filters/effect-drop-shadow-hw.html = PASS IMAGE +BUGWK80007 : css3/filters/filtered-compositing-descendant.html = PASS IMAGE BUGWK79613 WIN : svg/carto.net/scrollbar.svg = TEXT BUGWK79613 WIN : svg/carto.net/selectionlist.svg = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
