[webkit-changes] [111982] trunk/Source
Title: [111982] trunk/Source
Revision 111982
Author shawnsi...@chromium.org
Date 2012-03-23 23:51:34 -0700 (Fri, 23 Mar 2012)
Log Message
[chromium] Incorrect replica originTransform used in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=82118
Reviewed by Adrienne Walker.
Source/WebCore:
Unit test added to CCDamageTrackerTest.cpp
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
Source/WebKit/chromium:
* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (111981 => 111982)
--- trunk/Source/WebCore/ChangeLog 2012-03-24 06:44:52 UTC (rev 111981)
+++ trunk/Source/WebCore/ChangeLog 2012-03-24 06:51:34 UTC (rev 111982)
@@ -1,3 +1,15 @@
+2012-03-23 Shawn Singh
+
+[chromium] Incorrect replica originTransform used in CCDamageTracker
+https://bugs.webkit.org/show_bug.cgi?id=82118
+
+Reviewed by Adrienne Walker.
+
+Unit test added to CCDamageTrackerTest.cpp
+
+* platform/graphics/chromium/cc/CCDamageTracker.cpp:
+(WebCore::CCDamageTracker::extendDamageForRenderSurface):
+
2012-03-23 Dana Jansens
[chromium] When prepainting fails, tiles dirty rects may be cleared
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp (111981 => 111982)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp 2012-03-24 06:44:52 UTC (rev 111981)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp 2012-03-24 06:51:34 UTC (rev 111982)
@@ -297,11 +297,7 @@
removeRectFromCurrentFrame(replicaMaskLayer->id(), replicaIsNew);
// Compute the replica's "originTransform" that maps from the replica's origin space to the target surface origin space.
-TransformationMatrix replicaOriginTransform = layer->renderSurface()->originTransform();
-replicaOriginTransform.translate(layer->replicaLayer()->position().x(), layer->replicaLayer()->position().y());
-replicaOriginTransform.multiply(layer->replicaLayer()->transform());
-replicaOriginTransform.translate(-layer->replicaLayer()->position().x(), -layer->replicaLayer()->position().y());
-
+const TransformationMatrix& replicaOriginTransform = renderSurface->replicaOriginTransform();
FloatRect replicaMaskLayerRect = replicaOriginTransform.mapRect(FloatRect(FloatPoint::zero(), FloatSize(replicaMaskLayer->bounds().width(), replicaMaskLayer->bounds().height(;
saveRectForNextFrame(replicaMaskLayer->id(), replicaMaskLayerRect);
Modified: trunk/Source/WebKit/chromium/ChangeLog (111981 => 111982)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-24 06:44:52 UTC (rev 111981)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-24 06:51:34 UTC (rev 111982)
@@ -1,3 +1,14 @@
+2012-03-23 Shawn Singh
+
+[chromium] Incorrect replica originTransform used in CCDamageTracker
+https://bugs.webkit.org/show_bug.cgi?id=82118
+
+Reviewed by Adrienne Walker.
+
+* tests/CCDamageTrackerTest.cpp:
+(WebKitTests::TEST_F):
+(WebKitTests):
+
2012-03-23 Dana Jansens
[chromium] When prepainting fails, tiles dirty rects may be cleared
Modified: trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp (111981 => 111982)
--- trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp 2012-03-24 06:44:52 UTC (rev 111981)
+++ trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp 2012-03-24 06:51:34 UTC (rev 111982)
@@ -797,6 +797,56 @@
EXPECT_FLOAT_RECT_EQ(FloatRect(194, 200, 6, 8), childDamageRect);
}
+TEST_F(CCDamageTrackerTest, verifyDamageForReplicaMaskWithAnchor)
+{
+OwnPtr root = createAndSetUpTestTreeWithTwoSurfaces();
+CCLayerImpl* child1 = root->children()[0].get();
+CCLayerImpl* grandChild1 = child1->children()[0].get();
+
+// Verify that the correct replicaOriginTransform is used for the replicaMask; the
+// incorrect old code did not actually correctly account for the anchor for the
+// replica.
+//
+// Create a reflection about the left edge, but the anchor point is shifted all the
+// way to the right. this case the reflection should be directly on top (but
+// horizontally flipped) of grandChild1.
+
+grandChild1->setAnchorPoint(FloatPoint(1.0, 0.0)); // This is the anchor being tested.
+
+{
+OwnPtr grandChild1Replica = CCLayerImpl::create(6);
+grandChild1Replica->setPosition(FloatPoint::zero());
+grandChild1Replica->setAnchorPoint(FloatPoint::zero()); // note, this is not the anchor being tested.
+TransformationMatrix reflection;
+reflection.scale3d(-1.0, 1.0, 1.0);
+g
[webkit-changes] [111981] trunk/LayoutTests
Title: [111981] trunk/LayoutTests Revision 111981 Author pfeld...@chromium.org Date 2012-03-23 23:44:52 -0700 (Fri, 23 Mar 2012) Log Message Not reviewed: chromium expectations updated. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (111980 => 111981) --- trunk/LayoutTests/ChangeLog 2012-03-24 06:27:12 UTC (rev 111980) +++ trunk/LayoutTests/ChangeLog 2012-03-24 06:44:52 UTC (rev 111981) @@ -1,5 +1,11 @@ 2012-03-23 Pavel Feldman +Not reviewed: chromium expectations updated. + +* platform/chromium/test_expectations.txt: + +2012-03-23 Pavel Feldman + Not reviewed: adding chromium baselines. * platform/chromium-linux/editing/selection/selection-button-text-expected.png: Added. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (111980 => 111981) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-24 06:27:12 UTC (rev 111980) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-24 06:44:52 UTC (rev 111981) @@ -50,7 +50,9 @@ // BUGCR24182 SLOW DEBUG : svg/filters/big-sized-filter.svg = PASS // See BUGCR104797 -BUGWK77184 DEBUG SLOW : fast/js/dfg-double-vote-fuzz.html = PASS +// V8 roll to 3.9.24.1. Remember to remove WIN LINUX from the line below upon fixing. +BUGCR119915 MAC : fast/js/dfg-double-vote-fuzz.html = TEXT +BUGWK77184 DEBUG WIN LINUX SLOW : fast/js/dfg-double-vote-fuzz.html = PASS BUGWK77069 DEBUG SLOW : fast/js/dfg-uint32array-overflow-values.html = PASS BUGWK74787 DEBUG SLOW : fast/js/dfg-poison-fuzz.html = PASS BUGWK77365 DEBUG SLOW : fast/js/dfg-int32array-overflow-values.html = PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111980] trunk/LayoutTests
Title: [111980] trunk/LayoutTests
Revision 111980
Author pfeld...@chromium.org
Date 2012-03-23 23:27:12 -0700 (Fri, 23 Mar 2012)
Log Message
Not reviewed: adding chromium baselines.
* platform/chromium-linux/editing/selection/selection-button-text-expected.png: Added.
* platform/chromium-linux/editing/selection/selection-button-text-expected.txt: Added.
* platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png: Added.
* platform/chromium-mac/editing/selection/selection-button-text-expected.png: Added.
* platform/chromium-mac/editing/selection/selection-button-text-expected.txt: Added.
* platform/chromium-win-vista/editing/selection/selection-button-text-expected.png: Added.
* platform/chromium-win-vista/editing/selection/selection-button-text-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-linux/editing/selection/selection-button-text-expected.png
trunk/LayoutTests/platform/chromium-linux/editing/selection/selection-button-text-expected.txt
trunk/LayoutTests/platform/chromium-mac/editing/selection/selection-button-text-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/selection-button-text-expected.txt
trunk/LayoutTests/platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png
trunk/LayoutTests/platform/chromium-win-vista/editing/selection/
trunk/LayoutTests/platform/chromium-win-vista/editing/selection/selection-button-text-expected.png
trunk/LayoutTests/platform/chromium-win-vista/editing/selection/selection-button-text-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (111979 => 111980)
--- trunk/LayoutTests/ChangeLog 2012-03-24 06:22:02 UTC (rev 111979)
+++ trunk/LayoutTests/ChangeLog 2012-03-24 06:27:12 UTC (rev 111980)
@@ -1,5 +1,18 @@
2012-03-23 Pavel Feldman
+Not reviewed: adding chromium baselines.
+
+* platform/chromium-linux/editing/selection/selection-button-text-expected.png: Added.
+* platform/chromium-linux/editing/selection/selection-button-text-expected.txt: Added.
+* platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png: Added.
+* platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png: Added.
+* platform/chromium-mac/editing/selection/selection-button-text-expected.png: Added.
+* platform/chromium-mac/editing/selection/selection-button-text-expected.txt: Added.
+* platform/chromium-win-vista/editing/selection/selection-button-text-expected.png: Added.
+* platform/chromium-win-vista/editing/selection/selection-button-text-expected.txt: Added.
+
+2012-03-23 Pavel Feldman
+
Not reviewed: chromium expectations updated.
* platform/chromium/test_expectations.txt:
Added: trunk/LayoutTests/platform/chromium-linux/editing/selection/selection-button-text-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-linux/editing/selection/selection-button-text-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-linux/editing/selection/selection-button-text-expected.txt (0 => 111980)
--- trunk/LayoutTests/platform/chromium-linux/editing/selection/selection-button-text-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/editing/selection/selection-button-text-expected.txt 2012-03-24 06:27:12 UTC (rev 111980)
@@ -0,0 +1,35 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x152
+ RenderBlock {HTML} at (0,0) size 800x152
+RenderBody {BODY} at (8,16) size 784x128
+ RenderBlock {P} at (0,0) size 784x20
+RenderText {#text} at (0,0) size 533x19
+ text run at (0,0) width 533: "To PASS this test case the text of the button label should not be selected in the selection."
+ RenderBlock {DIV} at (0,36) size 784x92
+RenderBlock (anonymous) at (0,0) size 784x46
+ RenderText {#text} at (0,0) size 46x19
+text run at (0,0) width 46: "Buttons"
+ RenderBR {BR} at (46,0) size 0x19
+ RenderText {#text} at (0,23) size 55x19
+text run at (0,23) width 55: "with text "
+ RenderButton {INPUT} at (57,22) size 62x22 [bgcolor=#DD] [border: (2px outset #DD)]
+RenderBlock (anonymous) at (8,3) size 46x16
+ RenderText at (0,0) size 46x16
+text run at (0,0) width 46: "too little"
+ RenderText {#text} at (121,23) size 52x19
+text run at (121,23) width 52: " too little"
+RenderBlock {DIV} at (0,46) size 784x26
+ RenderText {#t
[webkit-changes] [111979] trunk/LayoutTests
Title: [111979] trunk/LayoutTests Revision 111979 Author pfeld...@chromium.org Date 2012-03-23 23:22:02 -0700 (Fri, 23 Mar 2012) Log Message Not reviewed: chromium expectations updated. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (111978 => 111979) --- trunk/LayoutTests/ChangeLog 2012-03-24 05:54:38 UTC (rev 111978) +++ trunk/LayoutTests/ChangeLog 2012-03-24 06:22:02 UTC (rev 111979) @@ -1,3 +1,9 @@ +2012-03-23 Pavel Feldman + +Not reviewed: chromium expectations updated. + +* platform/chromium/test_expectations.txt: + 2012-03-23 Dan Bernstein Updated the Mac expected results for this test after CSS shaders were disabled in r111893. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (111978 => 111979) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-24 05:54:38 UTC (rev 111978) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-24 06:22:02 UTC (rev 111979) @@ -4295,3 +4295,6 @@ BUGWK81936 : ietestcenter/css3/text/textshadow-009.htm = FAIL MISSING BUGWK81936 : ietestcenter/css3/text/textshadow-010.htm = FAIL MISSING +BUGWK82119 : editing/selection/3690703-2.html = IMAGE +BUGWK82119 : editing/selection/3690703.html = IMAGE +BUGWK82119 : editing/selection/3690719.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111978] trunk/Source
Title: [111978] trunk/Source
Revision 111978
Author commit-qu...@webkit.org
Date 2012-03-23 22:54:38 -0700 (Fri, 23 Mar 2012)
Log Message
[chromium] When prepainting fails, tiles dirty rects may be cleared
https://bugs.webkit.org/show_bug.cgi?id=82107
Patch by Dana Jansens on 2012-03-23
Reviewed by Adrienne Walker.
Source/WebCore:
When prepainting, if a tile is unable to be reserved due to memory
limits, we bail out of prepareToUpdateTiles. But we would have
cleared the dirty rect of any previous tiles. This leaves them
in a bad state where their textures are reserved, but their textureIds
are set to 0, and they are not marked dirty. This means that they will
not be updated and displayed if they become visible, since it is
assumed that valid textures with zero textureId must have a dirty
region.
We fix this by not clearing the dirty rects until we know we are
going to update the layer.
Unit test: TiledLayerChromiumTest.pushTilesAfterIdlePaintFailed
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::hasTextureIdForTileAt):
(WebCore):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
Source/WebKit/chromium:
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTextureAllocator::createTexture):
(WTF::FakeLayerTextureUpdater::Texture::updateRect):
(FakeCCTiledLayerImpl):
(WTF::FakeCCTiledLayerImpl::hasTextureIdForTileAt):
(WTF::TEST):
(WTF):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (111977 => 111978)
--- trunk/Source/WebCore/ChangeLog 2012-03-24 05:21:26 UTC (rev 111977)
+++ trunk/Source/WebCore/ChangeLog 2012-03-24 05:54:38 UTC (rev 111978)
@@ -1,3 +1,32 @@
+2012-03-23 Dana Jansens
+
+[chromium] When prepainting fails, tiles dirty rects may be cleared
+https://bugs.webkit.org/show_bug.cgi?id=82107
+
+Reviewed by Adrienne Walker.
+
+When prepainting, if a tile is unable to be reserved due to memory
+limits, we bail out of prepareToUpdateTiles. But we would have
+cleared the dirty rect of any previous tiles. This leaves them
+in a bad state where their textures are reserved, but their textureIds
+are set to 0, and they are not marked dirty. This means that they will
+not be updated and displayed if they become visible, since it is
+assumed that valid textures with zero textureId must have a dirty
+region.
+
+We fix this by not clearing the dirty rects until we know we are
+going to update the layer.
+
+Unit test: TiledLayerChromiumTest.pushTilesAfterIdlePaintFailed
+
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::prepareToUpdateTiles):
+* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
+(WebCore::CCTiledLayerImpl::hasTextureIdForTileAt):
+(WebCore):
+* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
+(CCTiledLayerImpl):
+
2012-03-23 Stephanie Lewis
https://bugs.webkit.org/show_bug.cgi?id=81963 WebProcess can get stuck in GC during many low memory signals.
Modified: trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp (111977 => 111978)
--- trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2012-03-24 05:21:26 UTC (rev 111977)
+++ trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2012-03-24 05:54:38 UTC (rev 111978)
@@ -467,10 +467,19 @@
}
dirtyLayerRect.unite(tile->m_dirtyRect);
-tile->copyAndClearDirty();
}
}
+// For tiles that were not culled, we are going to update the area currently marked as dirty. So
+// clear that dirty area and mark it for update instead.
+for (int j = top; j <= bottom; ++j) {
+for (int i = left; i <= right; ++i) {
+UpdatableTile* tile = tileAt(i, j);
+if (tile->m_updated)
+tile->copyAndClearDirty();
+}
+}
+
m_paintRect = dirtyLayerRect;
if (dirtyLayerRect.isEmpty())
return;
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp (111977 => 111978)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp 2012-03-24 05:21:26 UTC (rev 111977)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp 2012-03-24 05:54:38 UTC (rev 111978)
@@ -101,6 +101,11 @@
return m_tiler->tileAt(i, j);
}
+bool CCTiledLayerImpl::hasTextureIdForTileAt(int i, int j) const
[webkit-changes] [111977] trunk/Source/WebCore
Title: [111977] trunk/Source/WebCore Revision 111977 Author sle...@apple.com Date 2012-03-23 22:21:26 -0700 (Fri, 23 Mar 2012) Log Message https://bugs.webkit.org/show_bug.cgi?id=81963 WebProcess can get stuck in GC during many low memory signals. WebProcess appears to get stuck in its GC handler (81963). Remove the call to garbage collect in low memory signal handler. Did some testing with hitting the low memory handler during Membuster and we would get back at most 100k - 200k. That isn't enough to help the system, and in that state the GC collection can take a substantial amount of time. Reviewed by Geoff Garen. Performance Change, no change in behavior. * platform/mac/MemoryPressureHandlerMac.mm: (WebCore::MemoryPressureHandler::releaseMemory): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (111976 => 111977) --- trunk/Source/WebCore/ChangeLog 2012-03-24 04:04:27 UTC (rev 111976) +++ trunk/Source/WebCore/ChangeLog 2012-03-24 05:21:26 UTC (rev 111977) @@ -1,3 +1,18 @@ +2012-03-23 Stephanie Lewis + +https://bugs.webkit.org/show_bug.cgi?id=81963 WebProcess can get stuck in GC during many low memory signals. + WebProcess appears to get stuck in its GC handler (81963). +Remove the call to garbage collect in low memory signal handler. Did some testing with hitting the low memory handler +during Membuster and we would get back at most 100k - 200k. That isn't enough to help the system, and in +that state the GC collection can take a substantial amount of time. + +Reviewed by Geoff Garen. + +Performance Change, no change in behavior. + +* platform/mac/MemoryPressureHandlerMac.mm: +(WebCore::MemoryPressureHandler::releaseMemory): + 2012-03-23 W. James MacLean [chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found. Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (111976 => 111977) --- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2012-03-24 04:04:27 UTC (rev 111976) +++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2012-03-24 05:21:26 UTC (rev 111977) @@ -135,8 +135,6 @@ memoryCache()->pruneToPercentage(critical ? 0 : 0.5f); -gcController().garbageCollectNow(); - WTF::releaseFastMallocFreeMemory(); } #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111976] releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Element.cpp
Title: [111976] releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Element.cpp
Revision 111976
Author mrobin...@webkit.org
Date 2012-03-23 21:04:27 -0700 (Fri, 23 Mar 2012)
Log Message
Fix a bad merge.
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Element.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Element.cpp (111975 => 111976)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Element.cpp 2012-03-24 03:30:35 UTC (rev 111975)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Element.cpp 2012-03-24 04:04:27 UTC (rev 111976)
@@ -2027,9 +2027,6 @@
}
}
-void Element::didModifyAttribute(Attribute* attr)
-{
-
void Element::didRemoveAttribute(Attribute* attr)
{
if (attr->isNull())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111975] trunk/LayoutTests
Title: [111975] trunk/LayoutTests Revision 111975 Author m...@apple.com Date 2012-03-23 20:30:35 -0700 (Fri, 23 Mar 2012) Log Message Updated the Mac expected results for this test after CSS shaders were disabled in r111893. WebKitCSSFilterValue.CSS_FILTER_CUSTOM is no longer defined. * platform/mac/fast/dom/Window/window-properties-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (111974 => 111975) --- trunk/LayoutTests/ChangeLog 2012-03-24 03:23:02 UTC (rev 111974) +++ trunk/LayoutTests/ChangeLog 2012-03-24 03:30:35 UTC (rev 111975) @@ -1,3 +1,10 @@ +2012-03-23 Dan Bernstein + +Updated the Mac expected results for this test after CSS shaders were disabled in r111893. +WebKitCSSFilterValue.CSS_FILTER_CUSTOM is no longer defined. + +* platform/mac/fast/dom/Window/window-properties-expected.txt: + 2012-03-22 Ojan Vafai Fix more Chromium 10.6/10.5 tests that broke with r111917. There's a bug Modified: trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt (111974 => 111975) --- trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt 2012-03-24 03:23:02 UTC (rev 111974) +++ trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt 2012-03-24 03:30:35 UTC (rev 111975) @@ -2226,7 +2226,6 @@ window.WebKitCSSFilterValue.CSS_FILTER_BLUR [number] window.WebKitCSSFilterValue.CSS_FILTER_BRIGHTNESS [number] window.WebKitCSSFilterValue.CSS_FILTER_CONTRAST [number] -window.WebKitCSSFilterValue.CSS_FILTER_CUSTOM [number] window.WebKitCSSFilterValue.CSS_FILTER_DROP_SHADOW [number] window.WebKitCSSFilterValue.CSS_FILTER_GRAYSCALE [number] window.WebKitCSSFilterValue.CSS_FILTER_HUE_ROTATE [number] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111974] trunk/Source/JavaScriptCore
Title: [111974] trunk/Source/_javascript_Core Revision 111974 Author fpi...@apple.com Date 2012-03-23 20:23:02 -0700 (Fri, 23 Mar 2012) Log Message DFG Fixup should be able to short-circuit trivial ValueToInt32's https://bugs.webkit.org/show_bug.cgi?id=82030 Reviewed by Michael Saboff. Takes the fixup() method of the prediction propagation phase and makes it into its own phase. Adds the ability to short-circuit trivial ValueToInt32 nodes, and mark pure ValueToInt32's as such. * CMakeLists.txt: * GNUmakefile.list.am: * _javascript_Core.xcodeproj/project.pbxproj: * Target.pri: * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::makeSafe): (JSC::DFG::ByteCodeParser::handleCall): (JSC::DFG::ByteCodeParser::parseBlock): * dfg/DFGCommon.h: * dfg/DFGDriver.cpp: (JSC::DFG::compile): * dfg/DFGFixupPhase.cpp: Added. (DFG): (FixupPhase): (JSC::DFG::FixupPhase::FixupPhase): (JSC::DFG::FixupPhase::run): (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::fixIntEdge): (JSC::DFG::performFixup): * dfg/DFGFixupPhase.h: Added. (DFG): * dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::run): (PredictionPropagationPhase): Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/Target.pri trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGCommon.h trunk/Source/_javascript_Core/dfg/DFGDriver.cpp trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp Added Paths trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp trunk/Source/_javascript_Core/dfg/DFGFixupPhase.h Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (111973 => 111974) --- trunk/Source/_javascript_Core/CMakeLists.txt 2012-03-24 03:11:45 UTC (rev 111973) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2012-03-24 03:23:02 UTC (rev 111974) @@ -65,6 +65,7 @@ dfg/DFGCorrectableJumpPoint.cpp dfg/DFGCSEPhase.cpp dfg/DFGDriver.cpp +dfg/DFGFixupPhase.cpp dfg/DFGGraph.cpp dfg/DFGJITCompiler.cpp dfg/DFGNodeFlags.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (111973 => 111974) --- trunk/Source/_javascript_Core/ChangeLog 2012-03-24 03:11:45 UTC (rev 111973) +++ trunk/Source/_javascript_Core/ChangeLog 2012-03-24 03:23:02 UTC (rev 111974) @@ -1,3 +1,39 @@ +2012-03-23 Filip Pizlo + +DFG Fixup should be able to short-circuit trivial ValueToInt32's +https://bugs.webkit.org/show_bug.cgi?id=82030 + +Reviewed by Michael Saboff. + +Takes the fixup() method of the prediction propagation phase and makes it +into its own phase. Adds the ability to short-circuit trivial ValueToInt32 +nodes, and mark pure ValueToInt32's as such. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* _javascript_Core.xcodeproj/project.pbxproj: +* Target.pri: +* dfg/DFGByteCodeParser.cpp: +(JSC::DFG::ByteCodeParser::makeSafe): +(JSC::DFG::ByteCodeParser::handleCall): +(JSC::DFG::ByteCodeParser::parseBlock): +* dfg/DFGCommon.h: +* dfg/DFGDriver.cpp: +(JSC::DFG::compile): +* dfg/DFGFixupPhase.cpp: Added. +(DFG): +(FixupPhase): +(JSC::DFG::FixupPhase::FixupPhase): +(JSC::DFG::FixupPhase::run): +(JSC::DFG::FixupPhase::fixupNode): +(JSC::DFG::FixupPhase::fixIntEdge): +(JSC::DFG::performFixup): +* dfg/DFGFixupPhase.h: Added. +(DFG): +* dfg/DFGPredictionPropagationPhase.cpp: +(JSC::DFG::PredictionPropagationPhase::run): +(PredictionPropagationPhase): + 2012-03-23 Mark Hahnenberg tryReallocate could break the zero-ed memory invariant of CopiedBlocks Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (111973 => 111974) --- trunk/Source/_javascript_Core/GNUmakefile.list.am 2012-03-24 03:11:45 UTC (rev 111973) +++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2012-03-24 03:23:02 UTC (rev 111974) @@ -161,6 +161,8 @@ Source/_javascript_Core/dfg/DFGDriver.cpp \ Source/_javascript_Core/dfg/DFGDriver.h \ Source/_javascript_Core/dfg/DFGFPRInfo.h \ + Source/_javascript_Core/dfg/DFGFixupPhase.cpp \ + Source/_javascript_Core/dfg/DFGFixupPhase.h \ Source/_javascript_Core/dfg/DFGGenerationInfo.h \ Source/_javascript_Core/dfg/DFGGPRInfo.h \ Source/_javascript_Core/dfg/DFGGraph.cpp \ Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (111973 => 111974) --- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2012-03-24 03:11:45 UTC (rev 111973) +++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2012-03-24 03:23:02 UTC (rev 111974) @@ -72,6 +72,8 @@ 0F21C27D14BE727A00ADC64B /* CodeSpecializationKind.h i
[webkit-changes] [111973] trunk/Source/JavaScriptCore
Title: [111973] trunk/Source/_javascript_Core
Revision 111973
Author mhahnenb...@apple.com
Date 2012-03-23 20:11:45 -0700 (Fri, 23 Mar 2012)
Log Message
tryReallocate could break the zero-ed memory invariant of CopiedBlocks
https://bugs.webkit.org/show_bug.cgi?id=82087
Reviewed by Filip Pizlo.
Removing this optimization turned out to be ~1% regression on kraken, so I simply
undid the modification to the current block if we fail.
* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::tryReallocate): Undid the reset in the CopiedAllocator if we fail
to reallocate from the current block.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/CopiedAllocator.h
trunk/Source/_javascript_Core/heap/CopiedSpace.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (111972 => 111973)
--- trunk/Source/_javascript_Core/ChangeLog 2012-03-24 02:27:51 UTC (rev 111972)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-03-24 03:11:45 UTC (rev 111973)
@@ -1,3 +1,17 @@
+2012-03-23 Mark Hahnenberg
+
+tryReallocate could break the zero-ed memory invariant of CopiedBlocks
+https://bugs.webkit.org/show_bug.cgi?id=82087
+
+Reviewed by Filip Pizlo.
+
+Removing this optimization turned out to be ~1% regression on kraken, so I simply
+undid the modification to the current block if we fail.
+
+* heap/CopiedSpace.cpp:
+(JSC::CopiedSpace::tryReallocate): Undid the reset in the CopiedAllocator if we fail
+to reallocate from the current block.
+
2012-03-23 Alexey Proskuryakov
[Mac] No need for platform-specific ENABLE_BLOB values
Modified: trunk/Source/_javascript_Core/heap/CopiedAllocator.h (111972 => 111973)
--- trunk/Source/_javascript_Core/heap/CopiedAllocator.h 2012-03-24 02:27:51 UTC (rev 111972)
+++ trunk/Source/_javascript_Core/heap/CopiedAllocator.h 2012-03-24 03:11:45 UTC (rev 111973)
@@ -39,7 +39,6 @@
bool wasLastAllocation(void*, size_t);
void startedCopying();
void resetCurrentBlock(CopiedBlock*);
-void resetLastAllocation(void*);
size_t currentCapacity();
private:
@@ -97,11 +96,6 @@
return m_currentBlock->capacity();
}
-inline void CopiedAllocator::resetLastAllocation(void* ptr)
-{
-m_currentOffset = static_cast(ptr);
-}
-
} // namespace JSC
#endif
Modified: trunk/Source/_javascript_Core/heap/CopiedSpace.cpp (111972 => 111973)
--- trunk/Source/_javascript_Core/heap/CopiedSpace.cpp 2012-03-24 02:27:51 UTC (rev 111972)
+++ trunk/Source/_javascript_Core/heap/CopiedSpace.cpp 2012-03-24 03:11:45 UTC (rev 111973)
@@ -100,9 +100,11 @@
return tryReallocateOversize(ptr, oldSize, newSize);
if (m_allocator.wasLastAllocation(oldPtr, oldSize)) {
-m_allocator.resetLastAllocation(oldPtr);
-if (m_allocator.fitsInCurrentBlock(newSize))
-return m_allocator.allocate(newSize);
+size_t delta = newSize - oldSize;
+if (m_allocator.fitsInCurrentBlock(delta)) {
+(void)m_allocator.allocate(delta);
+return true;
+}
}
void* result = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111971] trunk/Source
Title: [111971] trunk/Source
Revision 111971
Author wjmacl...@chromium.org
Date 2012-03-23 19:23:46 -0700 (Fri, 23 Mar 2012)
Log Message
[chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found.
https://bugs.webkit.org/show_bug.cgi?id=82106
Reviewed by Adrienne Walker.
Source/WebCore:
Existing unit tests updated.
With gesture scroll events now being handled as mouse wheel events, we should not start a gesture scroll when
wheel handlers are present.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scrollBegin):
Source/WebKit/chromium:
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (111970 => 111971)
--- trunk/Source/WebCore/ChangeLog 2012-03-24 02:22:05 UTC (rev 111970)
+++ trunk/Source/WebCore/ChangeLog 2012-03-24 02:23:46 UTC (rev 111971)
@@ -1,3 +1,18 @@
+2012-03-23 W. James MacLean
+
+[chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found.
+https://bugs.webkit.org/show_bug.cgi?id=82106
+
+Reviewed by Adrienne Walker.
+
+Existing unit tests updated.
+
+With gesture scroll events now being handled as mouse wheel events, we should not start a gesture scroll when
+wheel handlers are present.
+
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::scrollBegin):
+
2012-03-23 Adam Barth
Move Notifications APIs from WorkerContext.idl to WorkerContextNotifications.idl
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (111970 => 111971)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2012-03-24 02:22:05 UTC (rev 111970)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2012-03-24 02:23:46 UTC (rev 111971)
@@ -619,7 +619,7 @@
return ScrollFailed;
}
-if (type == CCInputHandlerClient::Wheel && m_scrollLayerImpl->haveWheelEventHandlers()) {
+if ((type == CCInputHandlerClient::Wheel || type == CCInputHandlerClient::Gesture) && m_scrollLayerImpl->haveWheelEventHandlers()) {
TRACE_EVENT("scrollBegin Failed wheelEventHandlers", this, 0);
return ScrollFailed;
}
Modified: trunk/Source/WebKit/chromium/ChangeLog (111970 => 111971)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-24 02:22:05 UTC (rev 111970)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-24 02:23:46 UTC (rev 111971)
@@ -1,3 +1,13 @@
+2012-03-23 W. James MacLean
+
+[chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found.
+https://bugs.webkit.org/show_bug.cgi?id=82106
+
+Reviewed by Adrienne Walker.
+
+* tests/CCLayerTreeHostImplTest.cpp:
+(WebKit::TEST_F):
+
2012-03-23 Shawn Singh
[chromium] Fix race bug that clobbers CCLayerImpl updateRect
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (111970 => 111971)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2012-03-24 02:22:05 UTC (rev 111970)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2012-03-24 02:23:46 UTC (rev 111971)
@@ -203,11 +203,9 @@
CCLayerImpl* root = m_hostImpl->rootLayer();
root->setHaveWheelEventHandlers(true);
-// With registered event handlers, wheel scrolls have to go to the main thread.
+// With registered event handlers, wheel and gesture scrolls have to go to the main thread.
EXPECT_EQ(m_hostImpl->scrollBegin(IntPoint(0, 0), CCInputHandlerClient::Wheel), CCInputHandlerClient::ScrollFailed);
-
-// But gesture scrolls can still be handled.
-EXPECT_EQ(m_hostImpl->scrollBegin(IntPoint(0, 0), CCInputHandlerClient::Gesture), CCInputHandlerClient::ScrollStarted);
+EXPECT_EQ(m_hostImpl->scrollBegin(IntPoint(0, 0), CCInputHandlerClient::Gesture), CCInputHandlerClient::ScrollFailed);
}
TEST_F(CCLayerTreeHostImplTest, shouldScrollOnMainThread)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111970] releases/WebKitGTK/webkit-1.8
Title: [111970] releases/WebKitGTK/webkit-1.8
Revision 111970
Author mrobin...@webkit.org
Date 2012-03-23 19:22:05 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r111882
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderTable.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/table/double-height-table-no-tbody.html-disabled
Removed Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/table/double-height-table-no-tbody.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111969 => 111970)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 02:20:42 UTC (rev 111969)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 02:22:05 UTC (rev 111970)
@@ -1,3 +1,23 @@
+2012-03-23 Julien Chaffraix
+
+REGRESSION(107971): Google Voice contact list is broken in WebKit due to badly allocating the extra height
+https://bugs.webkit.org/show_bug.cgi?id=81826
+
+Reviewed by Tony Chang.
+
+* fast/table/double-height-table-no-tbody.html-disabled: Renamed from LayoutTests/fast/table/double-height-table-no-tbody.html.
+Disabled this test as it relies on our algorithm not to discriminate between first sections.
+
+* platform/chromium/test_expectations.txt:
+* platform/qt/Skipped:
+Mark those 2 tests as needing a new baseline again.
+
+* platform/efl/test_expectations.txt:
+* platform/gtk/Skipped:
+* platform/mac/test_expectations.txt:
+* platform/win/Skipped:
+Those platforms did not rebaseline those 2 tests so they should automatically pass them.
+
2012-03-23 Adam Barth
Remove support for "magic" iframe
Deleted: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/table/double-height-table-no-tbody.html (111969 => 111970)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/table/double-height-table-no-tbody.html 2012-03-24 02:20:42 UTC (rev 111969)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/table/double-height-table-no-tbody.html 2012-03-24 02:22:05 UTC (rev 111970)
@@ -1,63 +0,0 @@
-
-
-
-
-body { font-size: 13px; font-family: serif; }
-table { border: 1px solid red; border-spacing: 0px; padding: 0px; }
-th { border: 1px solid red; width: 125px; }
-.height20px { height: 20px; }
-.height19px { height: 19px; }
-.smallerFont { font-size: 10px; }
-
-
-
-Bug
-There should not be any gap between the tables' border and the rows'.
-height = 20px
-
-
-
-A
-B
-C
-D
-
-
-
-
-
-
-
-A
-B
-C
-D
-
-
-
-
-height = 19px, font-size = 10px
-
-
-
-A
-B
-C
-D
-
-
-
-
-
-
-
-A
-B
-C
-D
-
-
-
-
-
-
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/table/double-height-table-no-tbody.html-disabled (0 => 111970)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/table/double-height-table-no-tbody.html-disabled (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/table/double-height-table-no-tbody.html-disabled 2012-03-24 02:22:05 UTC (rev 111970)
@@ -0,0 +1,63 @@
+
+
+
+
+body { font-size: 13px; font-family: serif; }
+table { border: 1px solid red; border-spacing: 0px; padding: 0px; }
+th { border: 1px solid red; width: 125px; }
+.height20px { height: 20px; }
+.height19px { height: 19px; }
+.smallerFont { font-size: 10px; }
+
+
+
+Bug
+There should not be any gap between the tables' border and the rows'.
+height = 20px
+
+
+
+A
+B
+C
+D
+
+
+
+
+
+
+
+A
+B
+C
+D
+
+
+
+
+height = 19px, font-size = 10px
+
+
+
+A
+B
+C
+D
+
+
+
+
+
+
+
+A
+B
+C
+D
+
+
+
+
+
+
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111969 => 111970)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 02:20:42 UTC (rev 111969)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 02:22:05 UTC (rev 111970)
@@ -1,3 +1,23 @@
+2012-03-23 Julien Chaffraix
+
+REGRESSION(107971): Google Voice contact list is broken in WebKit due to badly allocating the extra height
+https://bugs.webkit.org/show_bug.cgi?id=81826
+
+Reviewed by Tony Chang.
+
+Covered by tables/mozilla/bugs/bug27038-{1|2}.html.
+
+This partly reverts r107971: the extra logical height distribution change was not needed
+to fix the bug (it is needed by the test though). We revert to giving all the extra height
+to the first tbody and not the first section.
+
+This is broken but unfortunately some websites are relying on that. Getting a real
+distribution algorithm is covered by bug 81824. However this is super tricky to get
+right and I did not want to add more compatibility risks until I have something solid.
+
+* rendering/RenderTable.
[webkit-changes] [111969] trunk/Source/WebCore
Title: [111969] trunk/Source/WebCore Revision 111969 Author aba...@webkit.org Date 2012-03-23 19:20:42 -0700 (Fri, 23 Mar 2012) Log Message Move Notifications APIs from WorkerContext.idl to WorkerContextNotifications.idl https://bugs.webkit.org/show_bug.cgi?id=79635 Reviewed by Kentaro Hara. This patch moves the NotificationCenter from WorkerContext to WorkerContextNotificiations, reducing clutter in WorkerContext. After this patch, Notifications are almost entirely contained in the notifications directory. * CMakeLists.txt: * DerivedSources.make: * DerivedSources.pri: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * workers/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): * workers/WorkerContext.h: (WebCore): (WorkerContext): * workers/WorkerContext.idl: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/DerivedSources.pri trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/workers/WorkerContext.cpp trunk/Source/WebCore/workers/WorkerContext.h trunk/Source/WebCore/workers/WorkerContext.idl Added Paths trunk/Source/WebCore/notifications/WorkerContextNotifications.cpp trunk/Source/WebCore/notifications/WorkerContextNotifications.h trunk/Source/WebCore/notifications/WorkerContextNotifications.idl Diff Modified: trunk/Source/WebCore/CMakeLists.txt (111968 => 111969) --- trunk/Source/WebCore/CMakeLists.txt 2012-03-24 02:15:59 UTC (rev 111968) +++ trunk/Source/WebCore/CMakeLists.txt 2012-03-24 02:20:42 UTC (rev 111969) @@ -1630,12 +1630,14 @@ notifications/NotificationCenter.cpp notifications/NotificationController.cpp notifications/Notification.cpp +notifications/WorkerContextNotifications.cpp ) LIST(APPEND WebCore_IDL_FILES notifications/DOMWindowNotifications.idl notifications/Notification.idl notifications/NotificationCenter.idl +notifications/WorkerContextNotifications.idl ) ENDIF () Modified: trunk/Source/WebCore/ChangeLog (111968 => 111969) --- trunk/Source/WebCore/ChangeLog 2012-03-24 02:15:59 UTC (rev 111968) +++ trunk/Source/WebCore/ChangeLog 2012-03-24 02:20:42 UTC (rev 111969) @@ -1,3 +1,30 @@ +2012-03-23 Adam Barth + +Move Notifications APIs from WorkerContext.idl to WorkerContextNotifications.idl +https://bugs.webkit.org/show_bug.cgi?id=79635 + +Reviewed by Kentaro Hara. + +This patch moves the NotificationCenter from WorkerContext to +WorkerContextNotificiations, reducing clutter in WorkerContext. After +this patch, Notifications are almost entirely contained in the +notifications directory. + +* CMakeLists.txt: +* DerivedSources.make: +* DerivedSources.pri: +* GNUmakefile.list.am: +* Target.pri: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* workers/WorkerContext.cpp: +(WebCore::WorkerContext::~WorkerContext): +* workers/WorkerContext.h: +(WebCore): +(WorkerContext): +* workers/WorkerContext.idl: + 2012-03-23 Michal Mocny [chromium] RootLayer was not being checked for null causing segfaults very rarely. Modified: trunk/Source/WebCore/DerivedSources.make (111968 => 111969) --- trunk/Source/WebCore/DerivedSources.make 2012-03-24 02:15:59 UTC (rev 111968) +++ trunk/Source/WebCore/DerivedSources.make 2012-03-24 02:20:42 UTC (rev 111969) @@ -387,6 +387,7 @@ $(WebCore)/notifications/DOMWindowNotifications.idl \ $(WebCore)/notifications/Notification.idl \ $(WebCore)/notifications/NotificationCenter.idl \ +$(WebCore)/notifications/WorkerContextNotifications.idl \ $(WebCore)/page/AbstractView.idl \ $(WebCore)/page/BarInfo.idl \ $(WebCore)/page/Console.idl \ Modified: trunk/Source/WebCore/DerivedSources.pri (111968 => 111969) --- trunk/Source/WebCore/DerivedSources.pri 2012-03-24 02:15:59 UTC (rev 111968) +++ trunk/Source/WebCore/DerivedSources.pri 2012-03-24 02:20:42 UTC (rev 111969) @@ -400,6 +400,7 @@ $$PWD/notifications/DOMWindowNotifications.idl \ $$PWD/notifications/Notification.idl \ $$PWD/notifications/NotificationCenter.idl \ +$$PWD/notifications/WorkerContextNotifications.idl \ $$PWD/page/BarInfo.idl \ $$PWD/page/Console.idl \ $$PWD/page/Coordinates.idl \ Modified: trunk/Source/WebCore/GNUmakefile.list.am (111968 => 111969) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-03-24 02:15:59 UTC (rev 111968) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-03-24 02:20:42 UTC (rev 111969) @@ -2851,6 +2851,8 @@ Source/WebCo
[webkit-changes] [111968] trunk/Source/WebCore
Title: [111968] trunk/Source/WebCore
Revision 111968
Author commit-qu...@webkit.org
Date 2012-03-23 19:15:59 -0700 (Fri, 23 Mar 2012)
Log Message
[chromium] RootLayer was not being checked for null causing segfaults very rarely.
https://bugs.webkit.org/show_bug.cgi?id=82111
Patch by Michal Mocny on 2012-03-23
Reviewed by Adrienne Walker.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::beginDrawingFrame):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (111967 => 111968)
--- trunk/Source/WebCore/ChangeLog 2012-03-24 02:13:24 UTC (rev 111967)
+++ trunk/Source/WebCore/ChangeLog 2012-03-24 02:15:59 UTC (rev 111968)
@@ -1,3 +1,15 @@
+2012-03-23 Michal Mocny
+
+[chromium] RootLayer was not being checked for null causing segfaults very rarely.
+https://bugs.webkit.org/show_bug.cgi?id=82111
+
+Reviewed by Adrienne Walker.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::beginDrawingFrame):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::drawLayers):
+
2012-03-23 Shawn Singh
[chromium] Fix race bug that clobbers CCLayerImpl updateRect
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (111967 => 111968)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2012-03-24 02:13:24 UTC (rev 111967)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2012-03-24 02:15:59 UTC (rev 111968)
@@ -404,6 +404,7 @@
void LayerRendererChromium::beginDrawingFrame()
{
+ASSERT(rootLayer());
m_defaultRenderSurface = rootLayer()->renderSurface();
// FIXME: use the frame begin time from the overall compositor scheduler.
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (111967 => 111968)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2012-03-24 02:13:24 UTC (rev 111967)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2012-03-24 02:15:59 UTC (rev 111968)
@@ -379,6 +379,9 @@
TRACE_EVENT("CCLayerTreeHostImpl::drawLayers", this, 0);
ASSERT(m_layerRenderer);
+if (!rootLayer())
+return;
+
m_layerRenderer->beginDrawingFrame();
for (size_t i = 0; i < frame.renderPasses.size(); ++i)
m_layerRenderer->drawRenderPass(frame.renderPasses[i].get());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111967] releases/WebKitGTK/webkit-1.8/Source/WebCore
Title: [111967] releases/WebKitGTK/webkit-1.8/Source/WebCore
Revision 111967
Author mrobin...@webkit.org
Date 2012-03-23 19:13:24 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r111400
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EventHandler.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111966 => 111967)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 02:12:38 UTC (rev 111966)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 02:13:24 UTC (rev 111967)
@@ -1,3 +1,15 @@
+2012-03-23 Konrad Piascik
+
+(r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro
+https://bugs.webkit.org/show_bug.cgi?id=81666
+
+Reviewed by Rob Buis.
+
+Compiled with feature disabled and built.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::selectCursor):
+
2012-03-23 Adam Barth
Remove support for "magic" iframe
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EventHandler.cpp (111966 => 111967)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EventHandler.cpp 2012-03-24 02:12:38 UTC (rev 111966)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EventHandler.cpp 2012-03-24 02:13:24 UTC (rev 111967)
@@ -1260,7 +1260,11 @@
// During selection, use an I-beam no matter what we're over.
// If a drag may be starting or we're capturing mouse events for a particular node, don't treat this as a selection.
-if (m_mousePressed && m_mouseDownMayStartSelect && !m_mouseDownMayStartDrag && m_frame->selection()->isCaretOrRange() && !m_capturingMouseEventsNode)
+if (m_mousePressed && m_mouseDownMayStartSelect
+#if ENABLE(DRAG_SUPPORT)
+&& !m_mouseDownMayStartDrag
+#endif
+&& m_frame->selection()->isCaretOrRange() && !m_capturingMouseEventsNode)
return iBeam;
if (renderer) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111965] releases/WebKitGTK/webkit-1.8
Title: [111965] releases/WebKitGTK/webkit-1.8
Revision 111965
Author mrobin...@webkit.org
Date 2012-03-23 18:39:18 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r110938
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/page/FrameView.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/page/FrameView.h
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/resize-events-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/resize-events.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111964 => 111965)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:38:25 UTC (rev 111964)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:39:18 UTC (rev 111965)
@@ -1,3 +1,16 @@
+2012-03-23 Allan Sandfeld Jensen
+
+REGRESSION(r106232): The resize handler is always called after loading.
+https://bugs.webkit.org/show_bug.cgi?id=80242
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Tests that no resize events are emitted during page creation,
+even if the page overflows and adds a scrollbar.
+
+* fast/events/resize-events-expected.txt: Added.
+* fast/events/resize-events.html: Added.
+
2012-03-23 Adam Klein
REGRESSION(r103452): 100% CPU usage and 5s pause after clicking on a link in Yahoo Mail
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/resize-events-expected.txt (0 => 111965)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/resize-events-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/resize-events-expected.txt 2012-03-24 01:39:18 UTC (rev 111965)
@@ -0,0 +1,20 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x582
+ RenderBlock {DIV} at (0,0) size 784x79
+RenderBlock (anonymous) at (0,0) size 784x42
+ RenderText {#text} at (0,0) size 772x42
+text run at (0,0) width 652: "Test how many resize events are emitted during page load and dynamic content generation. "
+text run at (652,0) width 120: "Do not resize the"
+text run at (0,21) width 192: "page. It invalidates the test."
+RenderBlock {P} at (0,58) size 784x21
+ RenderText {#text} at (10,0) size 206x21
+text run at (10,0) width 206: "Resize events (should be 0): "
+ RenderInline {SPAN} at (0,0) size 9x21
+RenderText {#text} at (216,0) size 9x21
+ text run at (216,0) width 9: "0"
+ RenderText {#text} at (0,0) size 0x0
+ RenderBlock {DIV} at (0,95) size 784x402
+RenderBlock {DIV} at (10,0) size 764x402 [border: (1px solid #00)]
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/resize-events-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/resize-events.html (0 => 111965)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/resize-events.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/resize-events.html 2012-03-24 01:39:18 UTC (rev 111965)
@@ -0,0 +1,54 @@
+
+
+
+div.block { height: 400px; border: 1px solid black; margin:10px; }
+
+
+var resizecount = 0;
+var loaded = false;
+window._onresize_ = function() {
+resizecount++;
+document.getElementById('count1').innerHTML = resizecount;
+}
+
+
+
+
+Test how many resize events are emitted during page load and dynamic content generation.
+
+Do not resize the page. It invalidates the test.
+
+Resize events (should be 0): 0
+
+
+
+
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+}
+
+var blockcount = 0;
+function addBlock() {
+var el = document.createElement('div');
+el.setAttribute('class','block');
+document.getElementById('expandingblock').appendChild(el);
+if (++blockcount < 10)
+setTimeout(addBlock, 20);
+else
+finish();
+}
+function finish() {
+var result;
+// No resize events are acceptable.
+if (resizecount < 1)
+result = 'PASS';
+else
+result = '
FAIL';
+var resultElement = document.getElementById('result1')
+resultElement.innerHTML += result;
+if (window.layoutTestController)
+layoutTestController.notifyDone()
[webkit-changes] [111964] releases/WebKitGTK/webkit-1.8
Title: [111964] releases/WebKitGTK/webkit-1.8
Revision 111964
Author mrobin...@webkit.org
Date 2012-03-23 18:38:25 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r110925
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Element.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Element.h
releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ElementAttributeData.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/subtree-modified-attributes-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/subtree-modified-attributes.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111963 => 111964)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:28:12 UTC (rev 111963)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:38:25 UTC (rev 111964)
@@ -1,3 +1,13 @@
+2012-03-23 Adam Klein
+
+REGRESSION(r103452): 100% CPU usage and 5s pause after clicking on a link in Yahoo Mail
+https://bugs.webkit.org/show_bug.cgi?id=81141
+
+Reviewed by Ojan Vafai.
+
+* fast/dom/subtree-modified-attributes-expected.txt: Added.
+* fast/dom/subtree-modified-attributes.html: Added.
+
2012-03-23 Daniel Bates
REGRESSION(r99369): File input button doesn't highlight when pressed
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/subtree-modified-attributes-expected.txt (0 => 111964)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/subtree-modified-attributes-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/subtree-modified-attributes-expected.txt 2012-03-24 01:38:25 UTC (rev 111964)
@@ -0,0 +1,13 @@
+DOMSubtreeModified should fire when attributes are added or removed, but not modified (see bug 81141)
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS expected is true
+PASS expected is true
+PASS expected is true
+PASS expected is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/subtree-modified-attributes-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/subtree-modified-attributes.html (0 => 111964)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/subtree-modified-attributes.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/subtree-modified-attributes.html 2012-03-24 01:38:25 UTC (rev 111964)
@@ -0,0 +1,30 @@
+
+
+
+description('DOMSubtreeModified should fire when attributes are added or removed, but not modified (see bug 81141)');
+
+var div = document.createElement('div');
+document.body.appendChild(div);
+var expected = false;
+div.addEventListener('DOMSubtreeModified', function(evt) {
+shouldBeTrue('expected');
+});
+expected = true;
+div.setAttribute('foo', 'bar');
+expected = false;
+div.setAttribute('foo', 'baz');
+expected = true;
+div.removeAttribute('foo');
+
+var attr = document.createAttribute('bar');
+attr.value = 'foo';
+expected = true;
+div.setAttributeNode(attr);
+expected = false;
+attr.value = 'bar';
+expected = true;
+div.removeAttributeNode(attr);
+
+
[webkit-changes] [111963] trunk/Source
Title: [111963] trunk/Source
Revision 111963
Author shawnsi...@chromium.org
Date 2012-03-23 18:28:12 -0700 (Fri, 23 Mar 2012)
Log Message
[chromium] Fix race bug that clobbers CCLayerImpl updateRect
https://bugs.webkit.org/show_bug.cgi?id=82109
Reviewed by Dirk Pranke.
Source/WebCore:
If the main thread commits twice before the impl thread actually
draws, then the updateRect of the first frame gets lost forever,
and not propagated to the damage tracker.
The solution is to accumulate the updateRect. The CCLayerImpl
updateRect is already being correctly cleared at the appropriate
time after drawing.
Unit test added to LayerChromiumTest.cpp.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
Source/WebKit/chromium:
* tests/LayerChromiumTest.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (111962 => 111963)
--- trunk/Source/WebCore/ChangeLog 2012-03-24 01:25:20 UTC (rev 111962)
+++ trunk/Source/WebCore/ChangeLog 2012-03-24 01:28:12 UTC (rev 111963)
@@ -1,3 +1,23 @@
+2012-03-23 Shawn Singh
+
+[chromium] Fix race bug that clobbers CCLayerImpl updateRect
+https://bugs.webkit.org/show_bug.cgi?id=82109
+
+Reviewed by Dirk Pranke.
+
+If the main thread commits twice before the impl thread actually
+draws, then the updateRect of the first frame gets lost forever,
+and not propagated to the damage tracker.
+
+The solution is to accumulate the updateRect. The CCLayerImpl
+updateRect is already being correctly cleared at the appropriate
+time after drawing.
+
+Unit test added to LayerChromiumTest.cpp.
+
+* platform/graphics/chromium/LayerChromium.cpp:
+(WebCore::LayerChromium::pushPropertiesTo):
+
2012-03-23 Rafael Weinstein
[MutationObservers] attributeFilter should be case sensitive at all times
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp (111962 => 111963)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2012-03-24 01:25:20 UTC (rev 111962)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp 2012-03-24 01:28:12 UTC (rev 111963)
@@ -480,6 +480,11 @@
layer->setSublayerTransform(m_sublayerTransform);
if (!transformIsAnimating())
layer->setTransform(m_transform);
+
+// If the main thread commits multiple times before the impl thread actually draws, then damage tracking
+// will become incorrect if we simply clobber the updateRect here. The CCLayerImpl's updateRect needs to
+// accumulate (i.e. union) any update changes that have occurred on the main thread.
+m_updateRect.uniteIfNonZero(layer->updateRect());
layer->setUpdateRect(m_updateRect);
layer->setScrollDelta(layer->scrollDelta() - layer->sentScrollDelta());
Modified: trunk/Source/WebKit/chromium/ChangeLog (111962 => 111963)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-24 01:25:20 UTC (rev 111962)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-24 01:28:12 UTC (rev 111963)
@@ -1,3 +1,12 @@
+2012-03-23 Shawn Singh
+
+[chromium] Fix race bug that clobbers CCLayerImpl updateRect
+https://bugs.webkit.org/show_bug.cgi?id=82109
+
+Reviewed by Dirk Pranke.
+
+* tests/LayerChromiumTest.cpp:
+
2012-03-23 Daniel Cheng
[chromium] Support file drag out using DataTransferItemList::add(File)
Modified: trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp (111962 => 111963)
--- trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp 2012-03-24 01:25:20 UTC (rev 111962)
+++ trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp 2012-03-24 01:28:12 UTC (rev 111963)
@@ -26,13 +26,14 @@
#include "LayerChromium.h"
-#include "cc/CCLayerTreeHost.h"
#include "CCLayerTreeTestCommon.h"
#include "FakeCCLayerTreeHostClient.h"
#include "LayerPainterChromium.h"
#include "NonCompositedContentHost.h"
#include "WebCompositor.h"
+#include "cc/CCLayerImpl.h"
#include "cc/CCLayerTreeHost.h"
+#include "cc/CCSingleThreadProxy.h"
#include
#include
@@ -530,6 +531,29 @@
EXPECT_TRUE(testLayer->needsDisplay());
}
+TEST_F(LayerChromiumTest, verifyPushPropertiesAccumulatesUpdateRect)
+{
+DebugScopedSetImplThread setImplThread;
+
+RefPtr testLayer = LayerChromium::create();
+OwnPtr implLayer = CCLayerImpl::create(1);
+
+testLayer->setNeedsDisplayRect(FloatRect(FloatPoint::zero(), FloatSize(5, 5)));
+testLayer->pushPropertiesTo(implLayer.get());
+EXPECT_FLOAT_RECT_EQ(FloatRect(FloatPoint::zero(), FloatSize(5, 5)), implLayer->updateRect());
+
+// The CCLayerImpl's updateRect should be accumulated here, since we did not do anything to clear it.
+testLayer->setNeedsDisplayRect(FloatRec
[webkit-changes] [111962] releases/WebKitGTK/webkit-1.8/Source/WebKit2
Title: [111962] releases/WebKitGTK/webkit-1.8/Source/WebKit2
Revision 111962
Author mrobin...@webkit.org
Date 2012-03-23 18:25:20 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r110888
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit2/ChangeLog (111961 => 111962)
--- releases/WebKitGTK/webkit-1.8/Source/WebKit2/ChangeLog 2012-03-24 01:13:46 UTC (rev 111961)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit2/ChangeLog 2012-03-24 01:25:20 UTC (rev 111962)
@@ -1,3 +1,16 @@
+2012-03-23 Anders Carlsson
+
+REGRESSION(r107168?): Assertion failures under pageContainsAnyHorizontalScrollbars causing multiple "crashes" on the Lion Intel Debug WebKit2 testers
+https://bugs.webkit.org/show_bug.cgi?id=81162
+
+
+Reviewed by Beth Dakin and Jessie Berlin.
+
+Downgrade the ASSERT to a simple if check since scrollableArea->isOnActivePage() can return false when layout happens during page transitions.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::pageContainsAnyHorizontalScrollbars):
+
2012-03-07 Carlos Garcia Campos
[GTK] Fix several documentation issues in WebKit2 GTK+ API
Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (111961 => 111962)
--- releases/WebKitGTK/webkit-1.8/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-03-24 01:13:46 UTC (rev 111961)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-03-24 01:25:20 UTC (rev 111962)
@@ -3036,7 +3036,8 @@
for (HashSet::const_iterator it = scrollableAreas->begin(), end = scrollableAreas->end(); it != end; ++it) {
ScrollableArea* scrollableArea = *it;
-ASSERT(scrollableArea->isOnActivePage());
+if (!scrollableArea->isOnActivePage())
+continue;
if (hasEnabledHorizontalScrollbar(scrollableArea))
return true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111960] releases/WebKitGTK/webkit-1.8
Title: [111960] releases/WebKitGTK/webkit-1.8
Revision 111960
Author mrobin...@webkit.org
Date 2012-03-23 18:13:23 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r110598
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderFileUploadControl.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderFileUploadControl.h
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/file/file-input-pressed-state-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/file/file-input-pressed-state.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111959 => 111960)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:12:23 UTC (rev 111959)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:13:23 UTC (rev 111960)
@@ -1,3 +1,16 @@
+2012-03-23 Daniel Bates
+
+REGRESSION(r99369): File input button doesn't highlight when pressed
+https://bugs.webkit.org/show_bug.cgi?id=79385
+
+Reviewed by Kent Tamura.
+
+Add test to ensure that the file input button visually changes when pressed.
+
+* fast/forms/file/file-input-pressed-state-expected.txt: Added.
+* fast/forms/file/file-input-pressed-state.html: Added.
+* platform/mac/fast/forms/file/file-input-pressed-state-expected.png: Added.
+
2012-03-23 Shawn Singh
REGRESSION (r93614): scrolling div does not repaint
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/file/file-input-pressed-state-expected.txt (0 => 111960)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/file/file-input-pressed-state-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/file/file-input-pressed-state-expected.txt 2012-03-24 01:13:23 UTC (rev 111960)
@@ -0,0 +1 @@
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/file/file-input-pressed-state-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/file/file-input-pressed-state.html (0 => 111960)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/file/file-input-pressed-state.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/file/file-input-pressed-state.html 2012-03-24 01:13:23 UTC (rev 111960)
@@ -0,0 +1,30 @@
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText(true); // Dump pixel test result.
+
+
+
+
+
+
+This tests that pressing on the file input button visually changes its appearance. For instance, when pressed, the button will have an Aqua background color when using the Blue appearance (System Preferences > General) on OS X.
+To run this test manually, click and hold on the input file button (below). This test PASSED if the button visually highlights when pressed. Otherwise, it FAILED.
+
+
+
+if (window.eventSender) {
+// Remove the descriptive text so as minimize pixel differences due to discrepancies in font rendering.
+document.body.removeChild(document.getElementById("description"));
+
+var file = document.getElementById("file");
+var x = file.offsetLeft + 10;
+var y = file.offsetTop + 10;
+eventSender.mouseMoveTo(x, y);
+eventSender.mouseDown();
+}
+
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/file/file-input-pressed-state.html
___
Added: svn:eol-style
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111959 => 111960)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:12:23 UTC (rev 111959)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:13:23 UTC (rev 111960)
@@ -1,3 +1,27 @@
+2012-03-23 Daniel Bates
+
+REGRESSION(r99369): File input button doesn't highlight when pressed
+https://bugs.webkit.org/show_bug.cgi?id=79385
+
+Reviewed by Kent Tamura.
+
+Fixes an issue where the file input button doesn't highlight on mouse press.
+
+Currently we always override the active state of the button with whether
+a dragged file is being hovered over the file input control (i.e. can the control
+receive a dropped file; HTMLInputElement::canReceiveDroppedFiles()).
+Instead, we should only override the active state of the button when the state
+changes for whether we can receive dropped files (e.g. during a drag) so that
+we honor the active state of the button when it is pressed.
+
+Test: fast/forms/file/file-input-pressed-state.html
+
+* rendering/RenderFileUploadControl.cpp:
+(WebCore::RenderFileUploadControl::RenderFileUploadControl):
+(WebCore::RenderFileUploadControl::updat
[webkit-changes] [111959] trunk/Source/WebKit/blackberry
Title: [111959] trunk/Source/WebKit/blackberry
Revision 111959
Author commit-qu...@webkit.org
Date 2012-03-23 18:12:23 -0700 (Fri, 23 Mar 2012)
Log Message
[BlackBerry] Add WebPageCompositor class to BlackBerry WebKit API
https://bugs.webkit.org/show_bug.cgi?id=81121
RIM PR: 136687
Patch by Arvid Nilsson on 2012-03-23
Reviewed by Rob Buis.
The idea is for the API client to use a WebPageCompositor object to
render the WebPage when there's no screen window available.
The WebPageCompositorPrivate becomes reference counted in order to be
kept alive either because it's used for accelerated compositing layers
or used for the WebPageCompositor API. It can still work standalone.
Clean up some code - no need to keep track of a separate boolean
WebPagePrivate::m_isAcceleratedCompositingActive when the state of
m_compositor can tell you.
Also remove duplicated code from WebPagePrivate - go directly to the
compositor object instead, if you need to draw the AC layers.
Reviewed internally by Robin Cao and the hasBlitJobs/blitOnIdle change
by Filip Spacek.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStore::hasBlitJobs):
(BlackBerry::WebKit::BackingStore::blitOnIdle):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
(BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
(BlackBerry::WebKit::BackingStorePrivate::buffer):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):
(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
* Api/WebPage.h:
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):
(BlackBerry::WebKit::WebPageCompositorPrivate::compositorDestroyed):
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::client):
(BlackBerry::WebKit::WebPageCompositor::prepareFrame):
(BlackBerry::WebKit::WebPageCompositor::render):
(BlackBerry::WebKit::WebPageCompositor::cleanup):
(BlackBerry::WebKit::WebPageCompositor::contextLost):
* Api/WebPageCompositor.h: Added.
* Api/WebPageCompositorClient.h: Added.
* Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::create):
(BlackBerry::WebKit::WebPageCompositorPrivate::context):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameTimestamp):
(BlackBerry::WebKit::WebPageCompositorPrivate::page):
(BlackBerry::WebKit::WebPageCompositorPrivate::client):
* Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::client):
(BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
(BlackBerry::WebKit::WebPagePrivate::compositor):
Modified Paths
trunk/Source/WebKit/blackberry/Api/BackingStore.cpp
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage.h
trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp
trunk/Source/WebKit/blackberry/Api/WebPageCompositor_p.h
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog
Added Paths
trunk/Source/WebKit/blackberry/Api/WebPageCompositor.h
trunk/Source/WebKit/blackberry/Api/WebPageCompositorClient.h
Diff
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (111958 => 111959)
--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-03-24 01:11:47 UTC (rev 111958)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-03-24 01:12:23 UTC (rev 111959)
@@ -32,6 +32,8 @@
#include "SurfacePool.h"
#include "WebPage.h"
#include "WebPageClient.h"
+#include "WebPageCompositorClient.h"
+#include "WebPageCompositor_p.h"
#include "WebPage_p.h"
#include "WebSettings.h"
@@ -1240,6 +1242,16 @@
}
if (m_defersBlit && !force) {
+#if USE(ACCELERATED_COMPOSITING)
+// If there's a WebPageCompositorClient, let it schedule the blit.
+if (WebPageCompositorPrivate* compositor = m_webPage->d->compositor()) {
+if (WebPageCompositorClient* client = compositor->client()) {
+client->invalidate(compositor->animationFrameTimestamp());
+return;
+}
+}
+#endif
+
m_hasBlitJobs = true;
return;
}
@@ -1445,7 +1457,8 @@
if (blittingDirectlyToCompositingWindow) {
WebCore::Fl
[webkit-changes] [111958] releases/WebKitGTK/webkit-1.8
Title: [111958] releases/WebKitGTK/webkit-1.8
Revision 111958
Author mrobin...@webkit.org
Date 2012-03-23 18:11:47 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r110401
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderLayerCompositor.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/compositing/repaint/newly-composited-repaint-rect-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/compositing/repaint/newly-composited-repaint-rect.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111957 => 111958)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:10:45 UTC (rev 111957)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:11:47 UTC (rev 111958)
@@ -1,3 +1,25 @@
+2012-03-23 Shawn Singh
+
+REGRESSION (r93614): scrolling div does not repaint
+https://bugs.webkit.org/show_bug.cgi?id=80641
+
+Reviewed by Simon Fraser.
+
+* compositing/repaint/newly-composited-repaint-rect-expected.png: Added.
+* compositing/repaint/newly-composited-repaint-rect-expected.txt: Added.
+* compositing/repaint/newly-composited-repaint-rect.html: Added.
+
+2012-03-23 Shawn Singh
+
+REGRESSION (r93614): scrolling div does not repaint
+https://bugs.webkit.org/show_bug.cgi?id=80641
+
+Reviewed by Simon Fraser.
+
+* compositing/repaint/newly-composited-repaint-rect-expected.png: Added.
+* compositing/repaint/newly-composited-repaint-rect-expected.txt: Added.
+* compositing/repaint/newly-composited-repaint-rect.html: Added.
+
2012-03-23 Gavin Barraclough
REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/compositing/repaint/newly-composited-repaint-rect-expected.txt (0 => 111958)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/compositing/repaint/newly-composited-repaint-rect-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/compositing/repaint/newly-composited-repaint-rect-expected.txt 2012-03-24 01:11:47 UTC (rev 111958)
@@ -0,0 +1 @@
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/compositing/repaint/newly-composited-repaint-rect-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/compositing/repaint/newly-composited-repaint-rect.html (0 => 111958)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/compositing/repaint/newly-composited-repaint-rect.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/compositing/repaint/newly-composited-repaint-rect.html 2012-03-24 01:11:47 UTC (rev 111958)
@@ -0,0 +1,87 @@
+
+
+
+
+
+
+ .composited {
+ -webkit-transform: translatez(0);
+ border: 2px solid black;
+ }
+
+ .box {
+ width: 200px;
+ height: 200px;
+ }
+
+ #scrolldiv {
+ position: absolute;
+ width: 100px;
+ height: 100px;
+ left: 250px;
+ top: 50px;
+ overflow-x: hidden;
+ overflow-y: scroll;
+ }
+
+ .shouldNotBeSeen {
+ background-color: red;
+ }
+
+ .shouldBeSeen {
+ background-color: green;
+ }
+
+
+
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText(true);
+layoutTestController.waitUntilDone();
+}
+
+function changeDivPosition() {
+document.getElementById("scrolldiv").style.left="50px";
+}
+
+function repaintTest() {
+// Changing the position will cause the scrolldiv to become composited becuase it overlaps another compostied element.
+changeDivPosition();
+
+// Force DumpRenderTree to do a layout and repaint here, this is where the repaintRect
+// goes wrong because it does not get updated for a newly composited element.
+if (window.layoutTestController)
+layoutTestController.display();
+
+window.setTimeout(function() {
+// Scrolling a little will demonstrate whether the repaint rect is correct or not.
+document.getElementById('scrolldiv').scrollTop = 500;
+layoutTestController.notifyDone();
+}, 0);
+}
+
+
+
+
+
+
+
+
+
+
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/compositing/repaint/newly-composited-repaint-rect.html
___
Added: svn:eol-style
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111957 => 111958)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:10:45 UTC (rev 111957)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:11:47 UTC (rev 1119
[webkit-changes] [111957] releases/WebKitGTK/webkit-1.8
Title: [111957] releases/WebKitGTK/webkit-1.8
Revision 111957
Author mrobin...@webkit.org
Date 2012-03-23 18:10:45 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r110331
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/wtf/DateMath.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111956 => 111957)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:08:17 UTC (rev 111956)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:10:45 UTC (rev 111957)
@@ -1,3 +1,16 @@
+2012-03-23 Gavin Barraclough
+
+REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
+https://bugs.webkit.org/show_bug.cgi?id=49989
+
+Reviewed by Oliver Hunt.
+
+Patch originally by chris reiss ,
+allow the year to appear before the timezone in date strings.
+
+* fast/js/date-parse-test-expected.txt:
+* fast/js/script-tests/date-parse-test.js:
+
2012-03-23 Andy Estes
REGRESSION (r105396): Dragging an iWork document into icloud.com opens it in the Mac app instead of uploading it to icloud.com
Modified: releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog (111956 => 111957)
--- releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog 2012-03-24 01:08:17 UTC (rev 111956)
+++ releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog 2012-03-24 01:10:45 UTC (rev 111957)
@@ -1,3 +1,16 @@
+2012-03-23 Gavin Barraclough
+
+REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
+https://bugs.webkit.org/show_bug.cgi?id=49989
+
+Reviewed by Oliver Hunt.
+
+Patch originally by chris reiss ,
+allow the year to appear before the timezone in date strings.
+
+* wtf/DateMath.cpp:
+(WTF::parseDateFromNullTerminatedCharacters):
+
2012-03-23 Mahesh Kulkarni
Unreviewed. Build fix for linux-bot (qt) after r109021.
Modified: releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/wtf/DateMath.cpp (111956 => 111957)
--- releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/wtf/DateMath.cpp 2012-03-24 01:08:17 UTC (rev 111956)
+++ releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/wtf/DateMath.cpp 2012-03-24 01:10:45 UTC (rev 111957)
@@ -935,6 +935,14 @@
}
}
}
+
+// The year may be after the time but before the time zone.
+if (isASCIIDigit(*dateString) && year == -1) {
+if (!parseLong(dateString, &newPosStr, 10, &year))
+return std::numeric_limits::quiet_NaN();
+dateString = newPosStr;
+skipSpacesAndComments(dateString);
+}
// Don't fail if the time zone is missing.
// Some websites omit the time zone (4275206).
@@ -987,10 +995,9 @@
if (!parseLong(dateString, &newPosStr, 10, &year))
return std::numeric_limits::quiet_NaN();
dateString = newPosStr;
+skipSpacesAndComments(dateString);
}
-skipSpacesAndComments(dateString);
-
// Trailing garbage
if (*dateString)
return std::numeric_limits::quiet_NaN();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111956] releases/WebKitGTK/webkit-1.8
Title: [111956] releases/WebKitGTK/webkit-1.8
Revision 111956
Author mrobin...@webkit.org
Date 2012-03-23 18:08:17 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r110243
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/page/DragController.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/file-input-hidden-in-ondrop-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/file-input-hidden-in-ondrop.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111955 => 111956)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:07:10 UTC (rev 111955)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:08:17 UTC (rev 111956)
@@ -1,3 +1,15 @@
+2012-03-23 Andy Estes
+
+REGRESSION (r105396): Dragging an iWork document into icloud.com opens it in the Mac app instead of uploading it to icloud.com
+https://bugs.webkit.org/show_bug.cgi?id=79443
+
+Reviewed by Ryosuke Niwa.
+
+* fast/events/file-input-hidden-in-ondrop-expected.txt: Added.
+* fast/events/file-input-hidden-in-ondrop.html: Added.
+* platform/wk2/Skipped: WebKitTestRunner doesn't support
+EventSender.beginDragWithFiles().
+
2012-03-23 Dan Bernstein
REGRESSION (r100847): Entries are clipped out in Day One
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/file-input-hidden-in-ondrop-expected.txt (0 => 111956)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/file-input-hidden-in-ondrop-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/file-input-hidden-in-ondrop-expected.txt 2012-03-24 01:08:17 UTC (rev 111956)
@@ -0,0 +1,2 @@
+PASS dropTarget.value is "C:\\fakepath\\abe.png"
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/file-input-hidden-in-ondrop-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/file-input-hidden-in-ondrop.html (0 => 111956)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/file-input-hidden-in-ondrop.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/file-input-hidden-in-ondrop.html 2012-03-24 01:08:17 UTC (rev 111956)
@@ -0,0 +1,38 @@
+
+
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+var dropTarget;
+
+function test()
+{
+dropTarget = document.getElementById("drop-target");
+dropTarget.addEventListener("drop", function() {
+dropTarget.style.display = "none";
+setTimeout(function() {
+shouldBeEqualToString("dropTarget.value", "C:\\fakepath\\abe.png");
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}, 0);
+}, false);
+
+if (window.eventSender) {
+eventSender.beginDragWithFiles(["resources/abe.png"]);
+var x = dropTarget.offsetLeft + dropTarget.offsetWidth / 2;
+var y = dropTarget.offsetTop + dropTarget.offsetHeight / 2;
+eventSender.mouseMoveTo(x, y);
+eventSender.mouseUp();
+}
+}
+
+
+
+
+
+
\ No newline at end of file
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/events/file-input-hidden-in-ondrop.html
___
Added: svn:eol-style
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111955 => 111956)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:07:10 UTC (rev 111955)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:08:17 UTC (rev 111956)
@@ -1,3 +1,32 @@
+2012-03-23 Andy Estes
+
+REGRESSION (r105396): Dragging an iWork document into icloud.com opens it in the Mac app instead of uploading it to icloud.com
+https://bugs.webkit.org/show_bug.cgi?id=79443
+
+Reviewed by Ryosuke Niwa.
+
+icloud.com registers a drop event handler that sets display:none on the
+file input element receiving the drop. After dispatching the drop event,
+DragController hit tests the position under the mouse to see if it is a
+file input element in need of receiving files. Since the file input
+element has lost its renderer, it cannot be found by hit testing, so
+the dropped file is never attached to the file input element, no change
+event fires, and no upload commences. We want these things to happen
+even if the ele
[webkit-changes] [111955] releases/WebKitGTK/webkit-1.8/Source/WebCore
Title: [111955] releases/WebKitGTK/webkit-1.8/Source/WebCore
Revision 111955
Author mrobin...@webkit.org
Date 2012-03-23 18:07:10 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r110178.diff
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/plugins/gtk/PluginViewGtk.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111954 => 111955)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:06:19 UTC (rev 111954)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:07:10 UTC (rev 111955)
@@ -1,3 +1,13 @@
+2012-03-23 Mikkel Kruse Johnsen
+
+WebKitGtk+ fails to build on win32 against GTK3
+https://bugs.webkit.org/show_bug.cgi?id=63919
+
+Reviewed by Gustavo Noronha Silva.
+
+* plugins/gtk/PluginViewGtk.cpp: Don't use gtk_socket_new with GTK3 on Win32
+(WebCore::PluginView::platformStart):
+
2012-03-23 Dan Bernstein
REGRESSION (r100847): Entries are clipped out in Day One
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/plugins/gtk/PluginViewGtk.cpp (111954 => 111955)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/plugins/gtk/PluginViewGtk.cpp 2012-03-24 01:06:19 UTC (rev 111954)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/plugins/gtk/PluginViewGtk.cpp 2012-03-24 01:07:10 UTC (rev 111955)
@@ -884,7 +884,11 @@
} else
setPlatformWidget(gtk_xtbin_new(pageClient, 0));
#else
+#if OS(WINDOWS) && !defined(GTK_API_VERSION_2)
+setPlatformWidget(0);
+#else
setPlatformWidget(gtk_socket_new());
+#endif
gtk_container_add(GTK_CONTAINER(pageClient), platformPluginWidget());
#endif
} else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111954] releases/WebKitGTK/webkit-1.8
Title: [111954] releases/WebKitGTK/webkit-1.8
Revision 111954
Author mrobin...@webkit.org
Date 2012-03-23 18:06:19 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r110065
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLDocument.idl
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/HTMLDocument/width-and-height.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111953 => 111954)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:04:50 UTC (rev 111953)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:06:19 UTC (rev 111954)
@@ -1,3 +1,13 @@
+2012-03-23 Dan Bernstein
+
+ REGRESSION (r100847): Entries are clipped out in Day One
+https://bugs.webkit.org/show_bug.cgi?id=80494
+
+Reviewed by Sam Weinig.
+
+* fast/dom/HTMLDocument/width-and-height-expected.txt: Added.
+* fast/dom/HTMLDocument/width-and-height.html: Added.
+
2012-03-23 Maciej Stachowiak
REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt (0 => 111954)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt 2012-03-24 01:06:19 UTC (rev 111954)
@@ -0,0 +1 @@
+PASS. The document.width and document.height properties are accessible from _javascript_.
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/HTMLDocument/width-and-height.html (0 => 111954)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/HTMLDocument/width-and-height.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/HTMLDocument/width-and-height.html 2012-03-24 01:06:19 UTC (rev 111954)
@@ -0,0 +1,9 @@
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+if ('width' in document && 'height' in document)
+document.write("PASS. The document.width and document.height properties are accessible from _javascript_.");
+else
+document.write("FAIL. document.width or document.height are not accessible from _javascript_.");
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/HTMLDocument/width-and-height.html
___
Added: svn:eol-style
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111953 => 111954)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:04:50 UTC (rev 111953)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:06:19 UTC (rev 111954)
@@ -1,3 +1,15 @@
+2012-03-23 Dan Bernstein
+
+ REGRESSION (r100847): Entries are clipped out in Day One
+https://bugs.webkit.org/show_bug.cgi?id=80494
+
+Reviewed by Sam Weinig.
+
+Test: fast/dom/HTMLDocument/width-and-height.html
+
+* html/HTMLDocument.idl: Reverted r100847 by re-enabling the width and height properties
+in the _javascript_ bindings.
+
2012-03-23 Adele Peterson
REGRESSION(r96566): Cursor is I-beam upon dragging an attachment in mail
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLDocument.idl (111953 => 111954)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLDocument.idl 2012-03-24 01:04:50 UTC (rev 111953)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/html/HTMLDocument.idl 2012-03-24 01:06:19 UTC (rev 111954)
@@ -45,10 +45,8 @@
void captureEvents();
void releaseEvents();
-#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
readonly attribute long width;
readonly attribute long height;
-#endif
attribute [TreatNullAs=NullString] DOMString dir;
attribute [TreatNullAs=NullString] DOMString designMode;
readonly attribute DOMString compatMode;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111953] releases/WebKitGTK/webkit-1.8/Source/WebCore
Title: [111953] releases/WebKitGTK/webkit-1.8/Source/WebCore
Revision 111953
Author mrobin...@webkit.org
Date 2012-03-23 18:04:50 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r110063
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EventHandler.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111952 => 111953)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:03:22 UTC (rev 111952)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 01:04:50 UTC (rev 111953)
@@ -1,3 +1,18 @@
+2012-03-23 Adele Peterson
+
+REGRESSION(r96566): Cursor is I-beam upon dragging an attachment in mail
+https://bugs.webkit.org/show_bug.cgi?id=80458
+
+
+Reviewed by Dan Bernstein.
+
+No tests because we currently don't have any test machinery for cursors.
+
+Make sure the shortcut to always use an iBeam cursor during selection isn't used during dragging.
+Before r96566, we handled plugin cursors as a special case before calling into selectCursor, so we never hit this code path.
+
+* page/EventHandler.cpp: (WebCore::EventHandler::selectCursor):
+
2012-03-23 Maciej Stachowiak
REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EventHandler.cpp (111952 => 111953)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EventHandler.cpp 2012-03-24 01:03:22 UTC (rev 111952)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/page/EventHandler.cpp 2012-03-24 01:04:50 UTC (rev 111953)
@@ -1259,8 +1259,8 @@
const Cursor& iBeam = horizontalText ? iBeamCursor() : verticalTextCursor();
// During selection, use an I-beam no matter what we're over.
-// If you're capturing mouse events for a particular node, don't treat this as a selection.
-if (m_mousePressed && m_mouseDownMayStartSelect && m_frame->selection()->isCaretOrRange() && !m_capturingMouseEventsNode)
+// If a drag may be starting or we're capturing mouse events for a particular node, don't treat this as a selection.
+if (m_mousePressed && m_mouseDownMayStartSelect && !m_mouseDownMayStartDrag && m_frame->selection()->isCaretOrRange() && !m_capturingMouseEventsNode)
return iBeam;
if (renderer) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111952] releases/WebKitGTK/webkit-1.8
Title: [111952] releases/WebKitGTK/webkit-1.8
Revision 111952
Author mrobin...@webkit.org
Date 2012-03-23 18:03:22 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r109594
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/bindings/js/JSDOMBinding.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/page/DOMWindow.idl
releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/sql/SQLiteStatement.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/navigated-window-properties-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/navigated-window-properties.html
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe1.html
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe2.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111951 => 111952)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:58:40 UTC (rev 111951)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 01:03:22 UTC (rev 111952)
@@ -1,3 +1,15 @@
+2012-03-23 Maciej Stachowiak
+
+REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
+https://bugs.webkit.org/show_bug.cgi?id=80133
+
+Reviewed by Antti Koivisto.
+
+* fast/dom/Window/navigated-window-properties-expected.txt: Added.
+* fast/dom/Window/navigated-window-properties.html: Added.
+* fast/dom/Window/resources/navigated-window-prop-subframe1.html: Added.
+* fast/dom/Window/resources/navigated-window-prop-subframe2.html: Added.
+
2012-03-23 Ryosuke Niwa
REGRESSION(r74971): Can't select a line of RTL text on Facebook
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/navigated-window-properties-expected.txt (0 => 111952)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/navigated-window-properties-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/navigated-window-properties-expected.txt 2012-03-24 01:03:22 UTC (rev 111952)
@@ -0,0 +1,3 @@
+Accessing properties of a navigated window shouldn't crash
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/navigated-window-properties-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/navigated-window-properties.html (0 => 111952)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/navigated-window-properties.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/navigated-window-properties.html 2012-03-24 01:03:22 UTC (rev 111952)
@@ -0,0 +1,26 @@
+
+Properties of a navigated window shouldn't crash
+
+Accessing properties of a navigated window shouldn't crash
+
+
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+layoutTestController.dumpAsText();
+}
+
+
+var func;
+function testPhase1() {
+var subframe = document.getElementById("subframe");
+func = subframe.contentWindow.testFunction;
+subframe.src = ""
+}
+
+function testPhase2() {
+func();
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/navigated-window-properties.html
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe1.html (0 => 111952)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe1.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe1.html 2012-03-24 01:03:22 UTC (rev 111952)
@@ -0,0 +1,9 @@
+
+function testFunction() {
+try {
+ var s = location.href + history.length;
+} catch (e) {
+}
+}
+parent.testPhase1();
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe1.html
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe2.html (0 => 111952)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe2.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe2.html 2012-03-24 01:03:22 UTC (rev 111952)
@@ -0,0 +1,3
[webkit-changes] [111951] releases/WebKitGTK/webkit-1.8
Title: [111951] releases/WebKitGTK/webkit-1.8
Revision 111951
Author mrobin...@webkit.org
Date 2012-03-23 17:58:40 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r109593
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Position.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/RenderedPosition.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/InlineBox.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/InlineBox.h
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderBlock.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderText.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RootInlineBox.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/select-line-break-with-opposite-directionality-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/select-line-break-with-opposite-directionality.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111950 => 111951)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:58:06 UTC (rev 111950)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:58:40 UTC (rev 111951)
@@ -1,3 +1,15 @@
+2012-03-23 Ryosuke Niwa
+
+REGRESSION(r74971): Can't select a line of RTL text on Facebook
+https://bugs.webkit.org/show_bug.cgi?id=59435
+
+Reviewed by Eric Seidel.
+
+Add a regression test for selecting multiline bidirectional text.
+
+* editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
+* editing/selection/select-line-break-with-opposite-directionality.html: Added.
+
2012-03-23 Antti Koivisto
REGRESSION (r104060): Page contents not painted if inserting a new stylesheet and temporary body node
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/select-line-break-with-opposite-directionality-expected.txt (0 => 111951)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/select-line-break-with-opposite-directionality-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/select-line-break-with-opposite-directionality-expected.txt 2012-03-24 00:58:40 UTC (rev 111951)
@@ -0,0 +1,30 @@
+This tests selecting LTR/RTL text that spans multiple lines in RTL/LTR block (opposite directionality). To manually test, select text in each of editable regions below by dragging mouse from one edge to another. The entire line should be selected.
+
+TEST 1 line 1:PASS
+TEST 1 line 2:PASS
+TEST 2 line 1:PASS
+TEST 3 line 1:PASS
+TEST 4 line 1:PASS
+TEST 4 line 2:PASS
+TEST 4 line 3:PASS
+TEST 5 line 1:PASS
+TEST 5 line 2:PASS
+TEST 5 line 3:PASS
+TEST 6 line 1:PASS
+TEST 6 line 2:PASS
+TEST 6 line 3:PASS
+TEST 7 line 1:PASS
+TEST 7 line 2:PASS
+TEST 7 line 3:PASS
+TEST 8 line 1:PASS
+TEST 8 line 2:PASS
+TEST 8 line 3:PASS
+TEST 9 line 1:PASS
+TEST 9 line 2:PASS
+TEST 9 line 3:PASS
+TEST 10 line 1:PASS
+TEST 10 line 2:PASS
+TEST 10 line 3:PASS
+
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/select-line-break-with-opposite-directionality-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/select-line-break-with-opposite-directionality.html (0 => 111951)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/select-line-break-with-opposite-directionality.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/editing/selection/select-line-break-with-opposite-directionality.html 2012-03-24 00:58:40 UTC (rev 111951)
@@ -0,0 +1,112 @@
+
+
+
+
+
+
+.tests {
+width: 250px;
+float: left;
+list-style: none;
+}
+
+.tests div, .tests pre {
+border: solid 1px black;
+width: 200px;
+font-size: 13px;
+line-height: 13px;
+padding: 13px;
+}
+
+.hideTestsInDRT .tests {
+display: none;
+}
+
+
+
+
+This tests selecting LTR/RTL text that spans multiple lines in RTL/LTR block (opposite directionality).
+To manually test, select text in each of editable regions below by dragging mouse from one edge to another.
+The entire line should be selected.
+
+
+abcdef
+ابص
+abc
+ابصa
+abcا
+ابصa
+ابصa
+
+
+ابص
+
+a
+abc
+
+a
+abc
+
+a
+
+
[webkit-changes] [111950] trunk
Title: [111950] trunk
Revision 111950
Author rafa...@chromium.org
Date 2012-03-23 17:58:06 -0700 (Fri, 23 Mar 2012)
Log Message
[MutationObservers] attributeFilter should be case sensitive at all times
https://bugs.webkit.org/show_bug.cgi?id=81822
Reviewed by Ryosuke Niwa.
Source/WebCore:
This removes the behavior in MutationObserverRegistration which treats
attributeFilter as case insensitive for HTML elements in HTML documents.
Relevant tests have been updated.
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
* dom/MutationObserverRegistration.h:
(MutationObserverRegistration):
LayoutTests:
* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mutation/observe-attributes-expected.txt
trunk/LayoutTests/fast/mutation/observe-attributes.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MutationObserverRegistration.cpp
trunk/Source/WebCore/dom/MutationObserverRegistration.h
Diff
Modified: trunk/LayoutTests/ChangeLog (111949 => 111950)
--- trunk/LayoutTests/ChangeLog 2012-03-24 00:55:59 UTC (rev 111949)
+++ trunk/LayoutTests/ChangeLog 2012-03-24 00:58:06 UTC (rev 111950)
@@ -1,3 +1,13 @@
+2012-03-23 Rafael Weinstein
+
+[MutationObservers] attributeFilter should be case sensitive at all times
+https://bugs.webkit.org/show_bug.cgi?id=81822
+
+Reviewed by Ryosuke Niwa.
+
+* fast/mutation/observe-attributes-expected.txt:
+* fast/mutation/observe-attributes.html:
+
2012-03-23 Parag Radke
REGRESSION: can select text of an input button
Modified: trunk/LayoutTests/fast/mutation/observe-attributes-expected.txt (111949 => 111950)
--- trunk/LayoutTests/fast/mutation/observe-attributes-expected.txt 2012-03-24 00:55:59 UTC (rev 111949)
+++ trunk/LayoutTests/fast/mutation/observe-attributes-expected.txt 2012-03-24 00:58:06 UTC (rev 111950)
@@ -101,18 +101,15 @@
PASS mutations[2].attributeName is "id"
PASS mutations[2].oldValue is "bar"
-Testing that attributeFilter works as expected and ignores case with HTML elements.
-...only foo, bar & boom should be received.
-PASS mutations.length is 3
+Testing that attributeFilter works as expected and observes case with HTML elements.
+...only foo and bar should be received.
+PASS mutations.length is 2
PASS mutations[0].type is "attributes"
PASS mutations[0].attributeName is "foo"
PASS mutations[0].attributeNamespace is null
PASS mutations[1].type is "attributes"
PASS mutations[1].attributeName is "bar"
PASS mutations[1].attributeNamespace is null
-PASS mutations[2].type is "attributes"
-PASS mutations[2].attributeName is "boom"
-PASS mutations[2].attributeNamespace is null
Testing the behavior of attributeFilter when the same observer observes at multiple nodes in a subtree with different filter options.
...only foo, bar & bat should be received.
Modified: trunk/LayoutTests/fast/mutation/observe-attributes.html (111949 => 111950)
--- trunk/LayoutTests/fast/mutation/observe-attributes.html 2012-03-24 00:55:59 UTC (rev 111949)
+++ trunk/LayoutTests/fast/mutation/observe-attributes.html 2012-03-24 00:58:06 UTC (rev 111950)
@@ -451,7 +451,7 @@
var observer;
function start() {
-debug('Testing that attributeFilter works as expected and ignores case with HTML elements.');
+debug('Testing that attributeFilter works as expected and observes case with HTML elements.');
mutations = null;
observer = new WebKitMutationObserver(function(m) {
@@ -469,18 +469,15 @@
}
function finish() {
-debug('...only foo, bar & boom should be received.');
+debug('...only foo and bar should be received.');
-shouldBe('mutations.length', '3');
+shouldBe('mutations.length', '2');
shouldBe('mutations[0].type', '"attributes"');
shouldBe('mutations[0].attributeName', '"foo"');
shouldBe('mutations[0].attributeNamespace', 'null');
shouldBe('mutations[1].type', '"attributes"');
shouldBe('mutations[1].attributeName', '"bar"');
shouldBe('mutations[1].attributeNamespace', 'null');
-shouldBe('mutations[2].type', '"attributes"');
-shouldBe('mutations[2].attributeName', '"boom"');
-shouldBe('mutations[2].attributeNamespace', 'null');
observer.disconnect();
debug('');
runNextTest();
Modified: trunk/Source/WebCore/ChangeLog (111949 => 111950)
--- trunk/Source/WebCore/ChangeLog 2012-03-24 00:55:59 UTC (rev 111949)
+++ trunk/Source/WebCore/ChangeLog 2012-03-24 00:58:06 UTC (rev 111950)
@@ -1,3 +1,21 @@
+2012-03-23 Rafael Weinstein
+
+[MutationObservers] attributeFilter should be case sensitive at all times
+https://bugs.webkit.org/show_bug.cgi?id=81822
+
+Reviewed by Ryosuke Niwa
[webkit-changes] [111949] trunk/Source/WebCore
Title: [111949] trunk/Source/WebCore Revision 111949 Author hara...@chromium.org Date 2012-03-23 17:55:59 -0700 (Fri, 23 Mar 2012) Log Message Move WebSocket APIs from WorkerContext.idl to WorkerContextWebSocket.idl https://bugs.webkit.org/show_bug.cgi?id=79663 Reviewed by Adam Barth. For WebKit modularization, this patch moves WebSocket APIs from WorkerContext.idl to WorkerContextWebSocket.idl. Tests: http/tests/websocket/tests/hybi/workers/* (No change in test results) * CMakeLists.txt: * DerivedSources.make: * DerivedSources.pri: * GNUmakefile.list.am: * Modules/websockets/WorkerContextWebSocket.idl: Added. * WebCore.gypi: * WebCore.xcodeproj/project.xcodeproj: * workers/WorkerContext.idl: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/DerivedSources.pri trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/workers/WorkerContext.idl Added Paths trunk/Source/WebCore/Modules/websockets/WorkerContextWebSocket.idl Diff Modified: trunk/Source/WebCore/CMakeLists.txt (111948 => 111949) --- trunk/Source/WebCore/CMakeLists.txt 2012-03-24 00:55:04 UTC (rev 111948) +++ trunk/Source/WebCore/CMakeLists.txt 2012-03-24 00:55:59 UTC (rev 111949) @@ -148,6 +148,7 @@ Modules/websockets/CloseEvent.idl Modules/websockets/DOMWindowWebSocket.idl +Modules/websockets/WorkerContextWebSocket.idl css/Counter.idl css/CSSCharsetRule.idl Modified: trunk/Source/WebCore/ChangeLog (111948 => 111949) --- trunk/Source/WebCore/ChangeLog 2012-03-24 00:55:04 UTC (rev 111948) +++ trunk/Source/WebCore/ChangeLog 2012-03-24 00:55:59 UTC (rev 111949) @@ -1,3 +1,24 @@ +2012-03-23 Kentaro Hara + +Move WebSocket APIs from WorkerContext.idl to WorkerContextWebSocket.idl +https://bugs.webkit.org/show_bug.cgi?id=79663 + +Reviewed by Adam Barth. + +For WebKit modularization, this patch moves WebSocket APIs from WorkerContext.idl +to WorkerContextWebSocket.idl. + +Tests: http/tests/websocket/tests/hybi/workers/* (No change in test results) + +* CMakeLists.txt: +* DerivedSources.make: +* DerivedSources.pri: +* GNUmakefile.list.am: +* Modules/websockets/WorkerContextWebSocket.idl: Added. +* WebCore.gypi: +* WebCore.xcodeproj/project.xcodeproj: +* workers/WorkerContext.idl: + 2012-03-23 Parag Radke REGRESSION: can select text of an input button Modified: trunk/Source/WebCore/DerivedSources.make (111948 => 111949) --- trunk/Source/WebCore/DerivedSources.make 2012-03-24 00:55:04 UTC (rev 111948) +++ trunk/Source/WebCore/DerivedSources.make 2012-03-24 00:55:59 UTC (rev 111949) @@ -150,6 +150,7 @@ $(WebCore)/Modules/websockets/CloseEvent.idl \ $(WebCore)/Modules/websockets/DOMWindowWebSocket.idl \ $(WebCore)/Modules/websockets/WebSocket.idl \ +$(WebCore)/Modules/websockets/WorkerContextWebSocket.idl \ $(WebCore)/css/CSSCharsetRule.idl \ $(WebCore)/css/CSSFontFaceRule.idl \ $(WebCore)/css/CSSImportRule.idl \ Modified: trunk/Source/WebCore/DerivedSources.pri (111948 => 111949) --- trunk/Source/WebCore/DerivedSources.pri 2012-03-24 00:55:04 UTC (rev 111948) +++ trunk/Source/WebCore/DerivedSources.pri 2012-03-24 00:55:59 UTC (rev 111949) @@ -169,6 +169,7 @@ $$PWD/Modules/websockets/CloseEvent.idl \ $$PWD/Modules/websockets/DOMWindowWebSocket.idl \ $$PWD/Modules/websockets/WebSocket.idl \ +$$PWD/Modules/websockets/WorkerContextWebSocket.idl \ $$PWD/css/Counter.idl \ $$PWD/css/CSSCharsetRule.idl \ $$PWD/css/CSSFontFaceRule.idl \ Modified: trunk/Source/WebCore/GNUmakefile.list.am (111948 => 111949) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-03-24 00:55:04 UTC (rev 111948) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-03-24 00:55:59 UTC (rev 111949) @@ -5636,7 +5636,8 @@ dom_binding_idls += \ $(WebCore)/Modules/websockets/CloseEvent.idl \ $(WebCore)/Modules/websockets/DOMWindowWebSocket.idl \ - $(WebCore)/Modules/websockets/WebSocket.idl + $(WebCore)/Modules/websockets/WebSocket.idl \ + $(WebCore)/Modules/websockets/WorkerContextWebSocket.idl endif # END ENABLE_WEB_SOCKETS # --- Added: trunk/Source/WebCore/Modules/websockets/WorkerContextWebSocket.idl (0 => 111949) --- trunk/Source/WebCore/Modules/websockets/WorkerContextWebSocket.idl (rev 0) +++ trunk/Source/WebCore/Modules/websockets/WorkerContextWebSocket.idl 2012-03-24 00:55:59 UTC (rev 111949) @@ -0,0 +1,36 @@ +/* + * Copyright (C) 2008 Apple Inc. All Rights Reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list
[webkit-changes] [111948] releases/WebKitGTK/webkit-1.8
Title: [111948] releases/WebKitGTK/webkit-1.8
Revision 111948
Author mrobin...@webkit.org
Date 2012-03-23 17:55:04 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r109543
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Document.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/pending-stylesheet-repaint-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/pending-stylesheet-repaint.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111947 => 111948)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:54:19 UTC (rev 111947)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:55:04 UTC (rev 111948)
@@ -1,3 +1,14 @@
+2012-03-23 Antti Koivisto
+
+REGRESSION (r104060): Page contents not painted if inserting a new stylesheet and temporary body node
+https://bugs.webkit.org/show_bug.cgi?id=76590
+
+Reviewed by Maciej Stachowiak.
+
+* fast/css/pending-stylesheet-repaint-expected.png: Added.
+* fast/css/pending-stylesheet-repaint-expected.txt: Added.
+* fast/css/pending-stylesheet-repaint.html: Added.
+
2012-03-23 Kent Tamura
REGRESSION(90089): Input type='search' text shakes up and down when the style is changed.
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/pending-stylesheet-repaint-expected.txt (0 => 111948)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/pending-stylesheet-repaint-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/pending-stylesheet-repaint-expected.txt 2012-03-24 00:55:04 UTC (rev 111948)
@@ -0,0 +1,7 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x8
+ RenderBlock {HTML} at (0,0) size 800x8
+RenderBody {BODY} at (8,8) size 784x0
+layer at (8,8) size 32x32
+ RenderBlock (positioned) {DIV} at (8,8) size 32x32 [bgcolor=#008000]
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/pending-stylesheet-repaint-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/pending-stylesheet-repaint.html (0 => 111948)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/pending-stylesheet-repaint.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/pending-stylesheet-repaint.html 2012-03-24 00:55:04 UTC (rev 111948)
@@ -0,0 +1,39 @@
+
+
+
+ Test case
+
+
+
+
+
+
+window.addEventListener(
+'DOMContentLoaded',
+function() {
+ // Must dynamically fetch another stylesheet
+ var el = document.createElement('link');
+ el.href = '';
+ el.type = 'text/css';
+ el.rel = 'stylesheet';
+ document.getElementsByTagName('head')[0].appendChild(el);
+
+ // Based on jQuery pre-1.6.2 code, which creates a temporary
+ // element to do tests on:
+ // https://github.com/jquery/jquery/blob/304dd618b7aa17158446bedd80af330375d8d4d4/src/support.js#L138
+ // The behavior was changed for jQuery 1.6.2 with this commit:
+ // https://github.com/jquery/jquery/commit/ceba855c010c792aad8fc15edc06b86285f71142/
+ var anotherBody = document.createElement('body');
+
+ document.documentElement.insertBefore(
+ anotherBody, document.documentElement.firstChild);
+
+ // Triggering a style recalc here is necessary.
+ anotherBody.offsetHeight;
+
+ anotherBody.parentNode.removeChild(anotherBody);
+},
+false);
+
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/pending-stylesheet-repaint.html
___
Added: svn:eol-style
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111947 => 111948)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 00:54:19 UTC (rev 111947)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 00:55:04 UTC (rev 111948)
@@ -1,3 +1,18 @@
+2012-03-23 Antti Koivisto
+
+REGRESSION (r104060): Page contents not painted if inserting a new stylesheet and temporary body node
+https://bugs.webkit.org/show_bug.cgi?id=76590
+
+Reviewed by Maciej Stachowiak.
+
+Test: fast/css/pending-stylesheet-repaint.html
+
+If there has been a style recalc with a pending stylesheet, the forced repaint will need to be triggered even
+if the stylesheet doesn't affect the rendering. Otherwise we may end up never painting at all.
+
+* dom/Document.cpp:
+(WebCore::Document::styleSelectorChanged):
+
2012-03-23 Kent Tamura
REGRESSION(90089): Input type='search' te
[webkit-changes] [111946] trunk
Title: [111946] trunk
Revision 111946
Author rn...@webkit.org
Date 2012-03-23 17:54:04 -0700 (Fri, 23 Mar 2012)
Log Message
REGRESSION: can select text of an input button
https://bugs.webkit.org/show_bug.cgi?id=13624
Patch by Parag Radke on 2012-03-23
Reviewed by Ryosuke Niwa.
Source/WebCore:
Text in a button should never have a selection background of its own painted
but if the button is inside an editable area, then the whole button should
have it's selection background painted.
Test: editing/selection/selection-button-text.html
* rendering/RenderButton.h:
Added implementation for the virtual function canBeSelectionLeaf()
which returns true if the button renderer is editable, false other wise.
* rendering/RenderTextFragment.h:
Added implementation for the virtual function canBeSelectionLeaf()
which returns true if the text fragment renderer is editable, false other wise.
LayoutTests:
Added a pixel test case to test the selection background for button label text.
* editing/selection/selection-button-text.html: Added.
* platform/gtk/editing/selection/selection-button-text-expected.png: Added.
* platform/gtk/editing/selection/selection-button-text-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderButton.h
trunk/Source/WebCore/rendering/RenderTextFragment.h
Added Paths
trunk/LayoutTests/editing/selection/selection-button-text.html
trunk/LayoutTests/platform/gtk/editing/selection/selection-button-text-expected.png
trunk/LayoutTests/platform/gtk/editing/selection/selection-button-text-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (111945 => 111946)
--- trunk/LayoutTests/ChangeLog 2012-03-24 00:53:34 UTC (rev 111945)
+++ trunk/LayoutTests/ChangeLog 2012-03-24 00:54:04 UTC (rev 111946)
@@ -1,3 +1,16 @@
+2012-03-23 Parag Radke
+
+REGRESSION: can select text of an input button
+https://bugs.webkit.org/show_bug.cgi?id=13624
+
+Reviewed by Ryosuke Niwa.
+
+Added a pixel test case to test the selection background for button label text.
+
+* editing/selection/selection-button-text.html: Added.
+* platform/gtk/editing/selection/selection-button-text-expected.png: Added.
+* platform/gtk/editing/selection/selection-button-text-expected.txt: Added.
+
2012-03-23 Dan Bernstein
Added Mac WebKit2 expected results for this test. The fact that it is failing is tracked by
Added: trunk/LayoutTests/editing/selection/selection-button-text.html (0 => 111946)
--- trunk/LayoutTests/editing/selection/selection-button-text.html (rev 0)
+++ trunk/LayoutTests/editing/selection/selection-button-text.html 2012-03-24 00:54:04 UTC (rev 111946)
@@ -0,0 +1,19 @@
+
+
+
+
+
+To PASS this test case the text of the button label should not be selected in the selection.
+
+Buttons
+with text too little
+
+and text too much
+
+Should not be selected in the selection.
+
+
+
+document.execCommand("SelectAll");
+
+
Added: trunk/LayoutTests/platform/gtk/editing/selection/selection-button-text-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/gtk/editing/selection/selection-button-text-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/gtk/editing/selection/selection-button-text-expected.txt (0 => 111946)
--- trunk/LayoutTests/platform/gtk/editing/selection/selection-button-text-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/editing/selection/selection-button-text-expected.txt 2012-03-24 00:54:04 UTC (rev 111946)
@@ -0,0 +1,35 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x156
+ RenderBlock {HTML} at (0,0) size 800x156
+RenderBody {BODY} at (8,16) size 784x132
+ RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 568x17
+ text run at (0,0) width 568: "To PASS this test case the text of the button label should not be selected in the selection."
+ RenderBlock {DIV} at (0,34) size 784x98
+RenderBlock (anonymous) at (0,0) size 784x49
+ RenderText {#text} at (0,0) size 50x17
+text run at (0,0) width 50: "Buttons"
+ RenderBR {BR} at (49,0) size 1x17
+ RenderText {#text} at (0,24) size 61x17
+text run at (0,24) width 61: "with text "
+ RenderButton {INPUT} at (62,20) size 72x27 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
+RenderBlock (anonymous) at (8,4) size 56x18
+ RenderText at (0,0) size 56x17
+text run at (0,0) width 56: "too little"
+ RenderText {#text} at (136,24) size 59x17
+text run at (136,24) width 59: " too little"
+RenderBlock {DIV} at (0,49) size 784x31
+ RenderText {#text} at (0,6) size 56x17
+text run at (0,6) wid
[webkit-changes] [111947] releases/WebKitGTK/webkit-1.8
Title: [111947] releases/WebKitGTK/webkit-1.8
Revision 111947
Author mrobin...@webkit.org
Date 2012-03-23 17:54:19 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r109503
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/LayoutTests/platform/chromium/test_expectations.txt
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/search-shaking-text-expected.html
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/search-shaking-text.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111946 => 111947)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:54:04 UTC (rev 111946)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:54:19 UTC (rev 111947)
@@ -1,5 +1,17 @@
2012-03-23 Kent Tamura
+REGRESSION(90089): Input type='search' text shakes up and down when the style is changed.
+https://bugs.webkit.org/show_bug.cgi?id=79445
+
+Reviewed by Dimitri Glazkov.
+
+* fast/forms/search/search-shaking-text-expected.html: Added.
+* fast/forms/search/search-shaking-text.html: Added.
+* platform/chromium/test_expectations.txt:
+ This change might need a rebaseline of fast/repaint/search-field-cancel.html
+
+2012-03-23 Kent Tamura
+
REGRESSION(r106388): Form state is restored to a wrong document.
https://bugs.webkit.org/show_bug.cgi?id=79206
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/search-shaking-text-expected.html (0 => 111947)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/search-shaking-text-expected.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/search-shaking-text-expected.html 2012-03-24 00:54:19 UTC (rev 111947)
@@ -0,0 +1,11 @@
+
+
+
+#testField {
+width: 200px;
+height: 30px;
+-webkit-appearance: none;
+}
+
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/search-shaking-text-expected.html
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/search-shaking-text.html (0 => 111947)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/search-shaking-text.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/search-shaking-text.html 2012-03-24 00:54:19 UTC (rev 111947)
@@ -0,0 +1,23 @@
+
+
+
+#testField {
+width: 100px;
+height: 30px;
+-webkit-appearance: none;
+}
+
+
+
+
+function startTest() {
+document.getElementById('testField').offsetTop;
+document.getElementById('testField').style.width = '200px';
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/forms/search/search-shaking-text.html
___
Added: svn:eol-style
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/platform/chromium/test_expectations.txt (111946 => 111947)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/platform/chromium/test_expectations.txt 2012-03-24 00:54:04 UTC (rev 111946)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/platform/chromium/test_expectations.txt 2012-03-24 00:54:19 UTC (rev 111947)
@@ -4194,6 +4194,8 @@
// Started failing http://trac.webkit.org/log/?verbose=on&rev=107837&stop_rev=107836
BUGWK78755 : compositing/culling/scrolled-within-boxshadow.html = IMAGE
+BUGWK79445 LINUX WIN : fast/repaint/search-field-cancel.html = FAIL
+
// Need rebaselining.
BUGWK69210 MAC : fast/encoding/utf-16-big-endian.html = IMAGE+TEXT
BUGWK69210 MAC : fast/encoding/utf-16-little-endian.html = IMAGE+TEXT
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111946 => 111947)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 00:54:04 UTC (rev 111946)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 00:54:19 UTC (rev 111947)
@@ -1,5 +1,29 @@
2012-03-23 Kent Tamura
+REGRESSION(90089): Input type='search' text shakes up and down when the style is changed.
+https://bugs.webkit.org/show_bug.cgi?id=79445
+
+Reviewed by Dimitri Glazkov.
+
+If the inner text height of a search field is smaller than the
+content box height of the , the height of the container
+element should be same as the content box height.
+
+When the element style is changed, the RenderStyle height of the
+container element is cleared, but the renderer height of th
[webkit-changes] [111945] trunk/Tools
Title: [111945] trunk/Tools
Revision 111945
Author dpra...@chromium.org
Date 2012-03-23 17:53:34 -0700 (Fri, 23 Mar 2012)
Log Message
nrwt: don't wait for safari to exit before exiting after showing the results file
https://bugs.webkit.org/show_bug.cgi?id=81845
Reviewed by Ryosuke Niwa.
Prior to this change, if you ran new-run-webkit-tests and
displayed the HTML results file at the end, we would block
waiting for the user to quit the browser. There doesn't seem to
be a need for that, and the Chromium ports don't do this.
Also, update the mac tests to capture the output and be quiet :).
* Scripts/webkitpy/common/system/executive_mock.py:
Make popen() testable, implement should_log for it.
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.show_results_html_file):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
Silence some of the tests via outputcapture.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (111944 => 111945)
--- trunk/Tools/ChangeLog 2012-03-24 00:52:56 UTC (rev 111944)
+++ trunk/Tools/ChangeLog 2012-03-24 00:53:34 UTC (rev 111945)
@@ -1,3 +1,24 @@
+2012-03-23 Dirk Pranke
+
+nrwt: don't wait for safari to exit before exiting after showing the results file
+https://bugs.webkit.org/show_bug.cgi?id=81845
+
+Reviewed by Ryosuke Niwa.
+
+Prior to this change, if you ran new-run-webkit-tests and
+displayed the HTML results file at the end, we would block
+waiting for the user to quit the browser. There doesn't seem to
+be a need for that, and the Chromium ports don't do this.
+
+Also, update the mac tests to capture the output and be quiet :).
+
+* Scripts/webkitpy/common/system/executive_mock.py:
+ Make popen() testable, implement should_log for it.
+* Scripts/webkitpy/layout_tests/port/mac.py:
+(MacPort.show_results_html_file):
+* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
+ Silence some of the tests via outputcapture.
+
2012-03-23 Gustavo Noronha Silva
[GTK] libgcrypt and p11-kit should not be in jhbuild modules
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py (111944 => 111945)
--- trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py 2012-03-24 00:52:56 UTC (rev 111944)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py 2012-03-24 00:53:34 UTC (rev 111945)
@@ -95,8 +95,15 @@
def cpu_count(self):
return 2
-def popen(self, *args, **kwargs):
-# FIXME: Implement logging when self._should_log is set.
+def popen(self, args, cwd=None, env=None, **kwargs):
+if self._should_log:
+cwd_string = ""
+if cwd:
+cwd_string = ", cwd=%s" % cwd
+env_string = ""
+if env:
+env_string = ", env=%s" % env
+log("MOCK popen: %s%s%s" % (args, cwd_string, env_string))
if not self._proc:
self._proc = MockProcess()
return self._proc
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (111944 => 111945)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-03-24 00:52:56 UTC (rev 111944)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-03-24 00:53:34 UTC (rev 111945)
@@ -139,7 +139,10 @@
return self._build_path('WebCore.framework/Versions/A/WebCore')
def show_results_html_file(self, results_filename):
-self._run_script('run-safari', ['--no-saved-state', '-NSOpen', results_filename])
+# We don't use self._run_script() because we don't want to wait for the script
+# to exit and we want the output to show up on stdout in case there are errors
+# launching the browser.
+self._executive.popen([self._config.script_path('run-safari')] + self._arguments_for_configuration() + ['--no-saved-state', '-NSOpen', results_filename], cwd=self._config.webkit_base_dir())
# FIXME: The next two routines turn off the http locking in order
# to work around failures on the bots caused when the slave restarts.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py (111944 => 111945)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py 2012-03-24 00:52:56 UTC (rev 111944)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py 2012-03-24 00:53:34 UTC (rev 111945)
@@ -172,7 +172,7 @@
port = self.make_port()
# Delay setting a should_log executive to avoid logging from MacPort.__init__.
port._executive = MockExecutive(should_log=True)
-expected_stderr = "MOCK run_command: ['Tools/Scripts/run-safari', '--release', '--no-saved-state', '-NSOpen', 'test.html'], cwd=/mock-checkout\n"
+expect
[webkit-changes] [111944] releases/WebKitGTK/webkit-1.8
Title: [111944] releases/WebKitGTK/webkit-1.8
Revision 111944
Author mrobin...@webkit.org
Date 2012-03-23 17:52:56 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r109480
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/loader/FrameLoader.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/loader/FrameLoader.h
releases/WebKitGTK/webkit-1.8/Source/WebCore/loader/HistoryController.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/form-state-restore-with-locked-back-forward-list-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/form-state-restore-with-locked-back-forward-list.html
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/resources/form-state-restore-with-locked-back-forward-list-2.html
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/resources/form-state-restore-with-locked-back-forward-list-3.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111943 => 111944)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:51:56 UTC (rev 111943)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:52:56 UTC (rev 111944)
@@ -1,3 +1,15 @@
+2012-03-23 Kent Tamura
+
+REGRESSION(r106388): Form state is restored to a wrong document.
+https://bugs.webkit.org/show_bug.cgi?id=79206
+
+Reviewed by Brady Eidson.
+
+* fast/loader/form-state-restore-with-locked-back-forward-list-expected.txt: Added.
+* fast/loader/form-state-restore-with-locked-back-forward-list.html: Added.
+* fast/loader/resources/form-state-restore-with-locked-back-forward-list-2.html: Added.
+* fast/loader/resources/form-state-restore-with-locked-back-forward-list-3.html: Added.
+
2012-03-23 Oliver Hunt
REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/form-state-restore-with-locked-back-forward-list-expected.txt (0 => 111944)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/form-state-restore-with-locked-back-forward-list-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/form-state-restore-with-locked-back-forward-list-expected.txt 2012-03-24 00:52:56 UTC (rev 111944)
@@ -0,0 +1,2 @@
+PASS location.search is "?TestName1=Ok1&TestName2=Ok2"
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/form-state-restore-with-locked-back-forward-list-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/form-state-restore-with-locked-back-forward-list.html (0 => 111944)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/form-state-restore-with-locked-back-forward-list.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/form-state-restore-with-locked-back-forward-list.html 2012-03-24 00:52:56 UTC (rev 111944)
@@ -0,0 +1,15 @@
+
+
+
+
+
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/form-state-restore-with-locked-back-forward-list.html
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/resources/form-state-restore-with-locked-back-forward-list-2.html (0 => 111944)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/resources/form-state-restore-with-locked-back-forward-list-2.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/resources/form-state-restore-with-locked-back-forward-list-2.html 2012-03-24 00:52:56 UTC (rev 111944)
@@ -0,0 +1,9 @@
+
+
+
+
+
+
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/resources/form-state-restore-with-locked-back-forward-list-2.html
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/resources/form-state-restore-with-locked-back-forward-list-3.html (0 => 111944)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/resources/form-state-restore-with-locked-back-forward-list-3.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/resources/form-state-restore-with-locked-back-forward-list-3.html 2012-03-24 00:52:56 UTC (rev 111944)
@@ -0,0 +1,9 @@
+
+
+
+shouldBeEqualToString("location.search", '?TestName1=Ok1&TestName2=Ok2');
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/loader/resources/form-state-restore-with-locke
[webkit-changes] [111943] releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore
Title: [111943] releases/WebKitGTK/webkit-1.8/Source/_javascript_Core
Revision 111943
Author mrobin...@webkit.org
Date 2012-03-23 17:51:56 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r109034
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/runtime/Error.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog (111942 => 111943)
--- releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog 2012-03-24 00:44:29 UTC (rev 111942)
+++ releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog 2012-03-24 00:51:56 UTC (rev 111943)
@@ -1,3 +1,9 @@
+2012-03-23 Mahesh Kulkarni
+
+Unreviewed. Build fix for linux-bot (qt) after r109021.
+
+* runtime/Error.cpp:
+
2012-03-23 Oliver Hunt
REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
Modified: releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/runtime/Error.cpp (111942 => 111943)
--- releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/runtime/Error.cpp 2012-03-24 00:44:29 UTC (rev 111942)
+++ releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/runtime/Error.cpp 2012-03-24 00:51:56 UTC (rev 111943)
@@ -35,8 +35,9 @@
#include "JSString.h"
#include "NativeErrorConstructor.h"
#include "SourceCode.h"
-#include "StringBuilder.h"
+#include
+
namespace JSC {
static const char* linePropertyName = "line";
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111942] releases/WebKitGTK/webkit-1.8
Title: [111942] releases/WebKitGTK/webkit-1.8
Revision 111942
Author mrobin...@webkit.org
Date 2012-03-23 17:44:29 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r109021
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/js/script-tests/stack-trace.js
releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/runtime/Error.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111941 => 111942)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:34:32 UTC (rev 111941)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:44:29 UTC (rev 111942)
@@ -1,3 +1,15 @@
+2012-03-23 Oliver Hunt
+
+REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
+https://bugs.webkit.org/show_bug.cgi?id=79693
+
+Reviewed by Filip Pizlo.
+
+Update test case to handle Error.stack being a string rather than an array.
+
+* fast/js/script-tests/stack-trace.js:
+(printStack):
+
2012-03-23 Abhishek Arya
Regression(r107477): Crash in StaticNodeList::itemWithName.
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/js/script-tests/stack-trace.js (111941 => 111942)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/js/script-tests/stack-trace.js 2012-03-24 00:34:32 UTC (rev 111941)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/js/script-tests/stack-trace.js 2012-03-24 00:44:29 UTC (rev 111942)
@@ -9,6 +9,7 @@
function printStack(stackTrace) {
debug("--> Stack Trace:")
+stackTrace = stackTrace.split("\n");
var length = Math.min(stackTrace.length, 100);
for (var i = 0; i < length; i++) {
var indexOfAt = stackTrace[i].indexOf('@')
@@ -21,7 +22,6 @@
}
debug('');
}
-
function hostThrower() { Element.prototype.appendChild.call({ }, [{ }]); }
function callbacker(f) { [0].map(f); }
function outer(errorName) { inner(errorName); }
Modified: releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog (111941 => 111942)
--- releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog 2012-03-24 00:34:32 UTC (rev 111941)
+++ releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/ChangeLog 2012-03-24 00:44:29 UTC (rev 111942)
@@ -1,3 +1,20 @@
+2012-03-23 Oliver Hunt
+
+REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
+https://bugs.webkit.org/show_bug.cgi?id=79693
+
+Reviewed by Filip Pizlo.
+
+Alas we can't provide the stack trace as an array, as despite everyone wanting
+an array, everyone arbitrarily creates the array by calling split on the stack
+trace. To create the array we would have provided them in the first place.
+
+This changes the exception's stack property to a \n separated string. To get the
+old array just do .stack.split("\n").
+
+* runtime/Error.cpp:
+(JSC::addErrorInfo):
+
2012-03-05 Mario Sanchez Prada
[GTK] Add GMainLoop and GMainContext to be handled by GRefPtr
Modified: releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/runtime/Error.cpp (111941 => 111942)
--- releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/runtime/Error.cpp 2012-03-24 00:34:32 UTC (rev 111941)
+++ releases/WebKitGTK/webkit-1.8/Source/_javascript_Core/runtime/Error.cpp 2012-03-24 00:44:29 UTC (rev 111942)
@@ -35,6 +35,7 @@
#include "JSString.h"
#include "NativeErrorConstructor.h"
#include "SourceCode.h"
+#include "StringBuilder.h"
namespace JSC {
@@ -132,20 +133,14 @@
globalObject = globalData->dynamicGlobalObject;
else
globalObject = error->globalObject();
-// We use the tryCreateUninitialized creation mechanism and related initialization
-// functions as they're the only mechanism we currently have that will guarantee we
-// don't call setters on the prototype. Technically it's faster than the alternative,
-// but the numerous allocations that take place in this loop makes that last bit
-// somewhat moot.
-JSArray* stackTraceArray = JSArray::tryCreateUninitialized(*globalData, globalObject->arrayStructure(), stackTrace.size());
-if (!stackTraceArray)
-return error;
+StringBuilder builder;
for (unsigned i = 0; i < stackTrace.size(); i++) {
-UString stackLevel = stackTrace[i].toString(globalObject->globalExec());
-stackTraceArray->initializeIndex(*globalData, i, jsString(globalData, stackLevel));
+builder.append(String(stackTrace[i].toString(globalObject->globalExec()).impl()));
+if (i != stackTrace.size() - 1)
+builder.append('\n');
}
-stackTraceArray->completeInitialization(stackTrace.size());
-error->putDirect(*globalData, globalData->propertyNames->stack, stackTraceA
[webkit-changes] [111941] trunk/Source/WebCore
Title: [111941] trunk/Source/WebCore
Revision 111941
Author eric.carl...@apple.com
Date 2012-03-23 17:34:32 -0700 (Fri, 23 Mar 2012)
Log Message
Remove unnecessary ASSERT from LoadableTextTrack::trackElementIndex
https://bugs.webkit.org/show_bug.cgi?id=82095
Reviewed by Dan Bernstein.
No new tests, removed a bogus ASSERT that was sometimes triggered by tests.
* html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::trackElementIndex): Remove ASSERT.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/LoadableTextTrack.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (111940 => 111941)
--- trunk/Source/WebCore/ChangeLog 2012-03-24 00:32:02 UTC (rev 111940)
+++ trunk/Source/WebCore/ChangeLog 2012-03-24 00:34:32 UTC (rev 111941)
@@ -1,5 +1,17 @@
2012-03-23 Eric Carlson
+Remove unnecessary ASSERT from LoadableTextTrack::trackElementIndex
+https://bugs.webkit.org/show_bug.cgi?id=82095
+
+Reviewed by Dan Bernstein.
+
+No new tests, removed a bogus ASSERT that was sometimes triggered by tests.
+
+* html/track/LoadableTextTrack.cpp:
+(WebCore::LoadableTextTrack::trackElementIndex): Remove ASSERT.
+
+2012-03-23 Eric Carlson
+
Layout Test media/video-source-load.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82094
Modified: trunk/Source/WebCore/html/track/LoadableTextTrack.cpp (111940 => 111941)
--- trunk/Source/WebCore/html/track/LoadableTextTrack.cpp 2012-03-24 00:32:02 UTC (rev 111940)
+++ trunk/Source/WebCore/html/track/LoadableTextTrack.cpp 2012-03-24 00:34:32 UTC (rev 111941)
@@ -135,7 +135,6 @@
{
ASSERT(m_trackElement);
ASSERT(m_trackElement->parentNode());
-ASSERT(m_trackElement->inDocument());
size_t index = 0;
for (Node* node = m_trackElement->parentNode()->firstChild(); node; node = node->nextSibling()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111940] releases/WebKitGTK/webkit-1.8
Title: [111940] releases/WebKitGTK/webkit-1.8
Revision 111940
Author mrobin...@webkit.org
Date 2012-03-23 17:32:02 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r108878
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/StaticNodeList.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/mutation/mutation-callback-non-element-crash-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/mutation/mutation-callback-non-element-crash.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111939 => 111940)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:30:59 UTC (rev 111939)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:32:02 UTC (rev 111940)
@@ -1,3 +1,13 @@
+2012-03-23 Abhishek Arya
+
+Regression(r107477): Crash in StaticNodeList::itemWithName.
+https://bugs.webkit.org/show_bug.cgi?id=79532
+
+Reviewed by Andreas Kling.
+
+* fast/mutation/mutation-callback-non-element-crash-expected.txt: Added.
+* fast/mutation/mutation-callback-non-element-crash.html: Added.
+
2012-03-23 Ryosuke Niwa
REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/mutation/mutation-callback-non-element-crash-expected.txt (0 => 111940)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/mutation/mutation-callback-non-element-crash-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/mutation/mutation-callback-non-element-crash-expected.txt 2012-03-24 00:32:02 UTC (rev 111940)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/mutation/mutation-callback-non-element-crash-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/mutation/mutation-callback-non-element-crash.html (0 => 111940)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/mutation/mutation-callback-non-element-crash.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/mutation/mutation-callback-non-element-crash.html 2012-03-24 00:32:02 UTC (rev 111940)
@@ -0,0 +1,17 @@
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function mutationCallback(mutations, observer) {
+mutations[0].addedNodes[-1];
+}
+
+var mutationObserver = new WebKitMutationObserver(mutationCallback);
+mutationObserver.observe(document.body, {childList: true});
+document.body.appendChild(document.createTextNode("PASS. WebKit didn't crash"));
+
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/mutation/mutation-callback-non-element-crash.html
___
Added: svn:executable
Added: svn:eol-style
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (111939 => 111940)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 00:30:59 UTC (rev 111939)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-03-24 00:32:02 UTC (rev 111940)
@@ -1,3 +1,17 @@
+2012-03-23 Abhishek Arya
+
+Regression(r107477): Crash in StaticNodeList::itemWithName.
+https://bugs.webkit.org/show_bug.cgi?id=79532
+
+Reviewed by Andreas Kling.
+
+Make sure that node is an element node before checking its id attribute.
+
+Test: fast/mutation/mutation-callback-non-element-crash.html
+
+* dom/StaticNodeList.cpp:
+(WebCore::StaticNodeList::itemWithName):
+
2012-03-23 Ryosuke Niwa
REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/StaticNodeList.cpp (111939 => 111940)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/StaticNodeList.cpp 2012-03-24 00:30:59 UTC (rev 111939)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/StaticNodeList.cpp 2012-03-24 00:32:02 UTC (rev 111940)
@@ -50,7 +50,7 @@
size_t length = m_nodes.size();
for (size_t i = 0; i < length; ++i) {
Node* node = m_nodes[i].get();
-if (static_cast(node)->getIdAttribute() == elementId)
+if (node->isElementNode() && toElement(node)->getIdAttribute() == elementId)
return node;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111939] releases/WebKitGTK/webkit-1.8
Title: [111939] releases/WebKitGTK/webkit-1.8
Revision 111939
Author mrobin...@webkit.org
Date 2012-03-23 17:30:59 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r108668
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/LayoutTests/resources/dump-as-markup.js
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/editing/ReplaceSelectionCommand.cpp
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/editing/input/paste-text-ending-with-interchange-newline-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/editing/input/paste-text-ending-with-interchange-newline.html
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111938 => 111939)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:29:48 UTC (rev 111938)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:30:59 UTC (rev 111939)
@@ -1,3 +1,18 @@
+2012-03-23 Ryosuke Niwa
+
+REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
+https://bugs.webkit.org/show_bug.cgi?id=79305
+
+Reviewed by Tony Chang.
+
+Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.
+
+* editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
+* editing/input/paste-text-ending-with-interchange-newline.html: Added.
+* resources/dump-as-markup.js:
+(Markup._get):
+(Markup._getShadowHostIfPossible):
+
2012-03-23 Antti Koivisto
REGRESSION (r104060): Web font is not loaded if specified by link element dynamically inserted
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/input/paste-text-ending-with-interchange-newline-expected.txt (0 => 111939)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/editing/input/paste-text-ending-with-interchange-newline-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/editing/input/paste-text-ending-with-interchange-newline-expected.txt 2012-03-24 00:30:59 UTC (rev 111939)
@@ -0,0 +1,4 @@
+This tests pasting a text with an interchange new line at the end. WebKit shouldn't insert a new line.
+|
+|
+| "abc def "
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/input/paste-text-ending-with-interchange-newline-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/input/paste-text-ending-with-interchange-newline.html (0 => 111939)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/editing/input/paste-text-ending-with-interchange-newline.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/editing/input/paste-text-ending-with-interchange-newline.html 2012-03-24 00:30:59 UTC (rev 111939)
@@ -0,0 +1,27 @@
+
+
+
+abc
+def
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+document.querySelector('textarea').focus();
+document.execCommand('SelectAll', false, null);
+document.execCommand('Copy', false, null);
+
+var input = document.querySelector('input');
+input.focus();
+document.execCommand('Paste', false, null);
+
+Markup.description("This tests pasting a text with an interchange new line at the end. WebKit shouldn't insert a new line.");
+Markup.dump(input);
+
+
+
+
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/editing/input/paste-text-ending-with-interchange-newline.html
___
Added: svn:eol-style
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/resources/dump-as-markup.js (111938 => 111939)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/resources/dump-as-markup.js 2012-03-24 00:29:48 UTC (rev 111938)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/resources/dump-as-markup.js 2012-03-24 00:30:59 UTC (rev 111939)
@@ -126,14 +126,16 @@
Markup.get = function(node)
{
+var markup = Markup._getShadowHostIfPossible(node, 0);
+if (markup)
+return markup.substring(1);
+
if (!node.firstChild)
return '| ';
// Don't print any markup for the root node.
-var markup = '';
-for (var i = 0, len = node.childNodes.length; i < len; i++) {
+for (var i = 0, len = node.childNodes.length; i < len; i++)
markup += Markup._get(node.childNodes[i], 0);
-}
return markup.substring(1);
}
@@ -228,11 +230,7 @@
str += Markup._get(node.childNodes[i], depth + 1);
}
-if (!Markup._useHTML5libOutputFormat && node.nodeType == Node.ELEMENT_NODE && window.internals) {
-var root = window.internals.shadowRoot(node);
-if (root)
-str += Markup._get(root, depth + 1);
-}
+str += Markup._getShadowHostIfPossible(node, depth);
var selection = Markup._getSelectionMarker(node, i);
if (selection)
@@ -2
[webkit-changes] [111938] trunk/Source/WebCore
Title: [111938] trunk/Source/WebCore
Revision 111938
Author eric.carl...@apple.com
Date 2012-03-23 17:29:48 -0700 (Fri, 23 Mar 2012)
Log Message
Layout Test media/video-source-load.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82094
Reviewed by Alexey Proskuryakov.
No new tests, tested by media/video-source-load.html.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::sourceWasAdded): Set m_nextChildNodeToConsider when called
with networkState == NETWORK_EMPTY because the resource selection algorithm has
not started yet.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (111937 => 111938)
--- trunk/Source/WebCore/ChangeLog 2012-03-24 00:25:20 UTC (rev 111937)
+++ trunk/Source/WebCore/ChangeLog 2012-03-24 00:29:48 UTC (rev 111938)
@@ -1,3 +1,17 @@
+2012-03-23 Eric Carlson
+
+Layout Test media/video-source-load.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=82094
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests, tested by media/video-source-load.html.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::sourceWasAdded): Set m_nextChildNodeToConsider when called
+with networkState == NETWORK_EMPTY because the resource selection algorithm has
+not started yet.
+
2012-03-23 Alexey Proskuryakov
[Mac] No need for platform-specific ENABLE_BLOB values
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (111937 => 111938)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-03-24 00:25:20 UTC (rev 111937)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-03-24 00:29:48 UTC (rev 111938)
@@ -2874,6 +2874,7 @@
// the media element's resource selection algorithm.
if (networkState() == HTMLMediaElement::NETWORK_EMPTY) {
scheduleLoad(MediaResource);
+m_nextChildNodeToConsider = source;
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [111937] releases/WebKitGTK/webkit-1.8
Title: [111937] releases/WebKitGTK/webkit-1.8
Revision 111937
Author mrobin...@webkit.org
Date 2012-03-23 17:25:20 -0700 (Fri, 23 Mar 2012)
Log Message
Merging r108574
Modified Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/css/CSSFontSelector.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/css/CSSFontSelector.h
releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/graphics/Font.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/graphics/FontFallbackList.cpp
releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/graphics/FontFallbackList.h
releases/WebKitGTK/webkit-1.8/Source/WebCore/platform/graphics/FontSelector.h
Added Paths
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/font-face-insert-link-expected.txt
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/font-face-insert-link.html
releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/resources/ahem.css
Diff
Modified: releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog (111936 => 111937)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:24:10 UTC (rev 111936)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog 2012-03-24 00:25:20 UTC (rev 111937)
@@ -1,3 +1,15 @@
+2012-03-23 Antti Koivisto
+
+REGRESSION (r104060): Web font is not loaded if specified by link element dynamically inserted
+https://bugs.webkit.org/show_bug.cgi?id=79186
+
+Reviewed by Andreas Kling.
+
+* fast/css/font-face-insert-link-expected.txt: Added.
+* fast/css/font-face-insert-link.html: Added.
+* fast/css/resources/ahem.css: Added.
+(@font-face):
+
2012-03-23 Nikolas Zimmermann
REGRESSION(58212): html foreignObjects with positions other than static not hidden correctly when parent has display:none
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/font-face-insert-link-expected.txt (0 => 111937)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/font-face-insert-link-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/font-face-insert-link-expected.txt 2012-03-24 00:25:20 UTC (rev 111937)
@@ -0,0 +1,5 @@
+PASS window.getComputedStyle(a).width == window.getComputedStyle(b).width is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+TextText
Property changes on: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/font-face-insert-link-expected.txt
___
Added: svn:eol-style
Added: releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/font-face-insert-link.html (0 => 111937)
--- releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/font-face-insert-link.html (rev 0)
+++ releases/WebKitGTK/webkit-1.8/LayoutTests/fast/css/font-face-insert-link.html 2012-03-24 00:25:20 UTC (rev 111937)
@@ -0,0 +1,39 @@
+
+
+.test {
+ font-family: 'myahem';
+}
+#a, #b, #container { position:absolute; }
+#b { top: 20px }
+
+
+
+
+Text
+Text
+
+
+