date:20120402

[webkit-changes] [112835] trunk/LayoutTests

2012-04-02 Thread philn

Title: [112835] trunk/LayoutTests








Revision 112835
Author ph...@webkit.org
Date 2012-04-02 00:43:23 -0700 (Mon, 02 Apr 2012)


Log Message
Unreviewed, rebaseline after r112825.

The test baseline updated in r112825 is specific to GURL's way of
printing URLs so it belongs to the chromium platform directory.

* http/tests/security/no-popup-from-sandbox-top-expected.txt:
* platform/chromium/http/tests/security/no-popup-from-sandbox-top-expected.txt: Copied from LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium/http/tests/security/no-popup-from-sandbox-top-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112834 => 112835)

--- trunk/LayoutTests/ChangeLog	2012-04-02 07:31:41 UTC (rev 112834)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 07:43:23 UTC (rev 112835)
@@ -1,3 +1,13 @@
+2012-04-02  Philippe Normand  
+
+Unreviewed, rebaseline after r112825.
+
+The test baseline updated in r112825 is specific to GURL's way of
+printing URLs so it belongs to the chromium platform directory.
+
+* http/tests/security/no-popup-from-sandbox-top-expected.txt:
+* platform/chromium/http/tests/security/no-popup-from-sandbox-top-expected.txt: Copied from LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt.
+
 2012-04-01  Philippe Normand  
 
 Unreviewed, GTK svg rebaseline after r112806.


Modified: trunk/LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt (112834 => 112835)

--- trunk/LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt	2012-04-02 07:31:41 UTC (rev 112834)
+++ trunk/LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt	2012-04-02 07:43:23 UTC (rev 112835)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Unsafe _javascript_ attempt to initiate a navigation change for frame with URL http://127.0.0.1:8000/security/no-popup-from-sandbox-top.html from frame with URL data:text/html,  var win = window.open('about:blank', '_top');   alert(win ? 'FAIL' : 'PASS');   .
+CONSOLE MESSAGE: Unsafe _javascript_ attempt to initiate a navigation change for frame with URL http://127.0.0.1:8000/security/no-popup-from-sandbox-top.html from frame with URL data:text/html,  var win = window.open('about:blank', '_top');   alert(win ?%20'FAIL'%20:%20'PASS');%20%20%20%20%20%20%20%3C/script%3E.
 
 ALERT: PASS
 To run this test outside of DumpRenderTree, please disable your popup blocker!

Copied: trunk/LayoutTests/platform/chromium/http/tests/security/no-popup-from-sandbox-top-expected.txt (from rev 112834, trunk/LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt) (0 => 112835)


--- trunk/LayoutTests/platform/chromium/http/tests/security/no-popup-from-sandbox-top-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/security/no-popup-from-sandbox-top-expected.txt	2012-04-02 07:43:23 UTC (rev 112835)
@@ -0,0 +1,6 @@
+CONSOLE MESSAGE: Unsafe _javascript_ attempt to initiate a navigation change for frame with URL http://127.0.0.1:8000/security/no-popup-from-sandbox-top.html from frame with URL data:text/html,   
+
+
+
+
+
+This page contains a @page style rule.

+Making a WebArchive out of it should not crash.
+
+
+		WebResourceFrameName
+		
+		WebResourceMIMEType
+		text/html
+		WebResourceTextEncodingName
+		UTF-8
+		WebResourceURL
+		file:///LayoutTests/webarchive/css-page-rule-crash.html
+	
+
+


Added: trunk/LayoutTests/webarchive/css-page-rule-crash.html (0 => 112913)

--- trunk/LayoutTests/webarchive/css-page-rule-crash.html	(rev 0)
+++ trunk/LayoutTests/webarchive/css-page-rule-crash.html	2012-04-02 18:23:19 UTC (rev 112913)
@@ -0,0 +1,21 @@
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpDOMAsWebArchive();
+
+
+
+
+
+@page {
+	margin: 2cm;
+}
+
+
+
+
+
+This page contains a @page style rule.
+Making a WebArchive out of it should not crash.
+


Modified: trunk/Source/WebCore/ChangeLog (112912 => 112913)

--- trunk/Source/WebCore/ChangeLog	2012-04-02 18:21:27 UTC (rev 112912)
+++ trunk/Source/WebCore/ChangeLog	2012-04-02 18:23:19 UTC (rev 112913)
@@ -1,3 +1,16 @@
+2012-04-02  Brady Eidson  
+
+ and https://bugs.webkit.org/show_bug.cgi?id=82910
+REGRESSION (98963 and 109091):  Crash when creating a WebArchive of a page with @page style rules
+
+Reviewed by Antti Koivisto.
+
+Test: webarchive/css-page-rule-crash.html
+
+* css/CSSStyleSheet.cpp:
+(WebCore::CSSStyleSheet::addSubresourceStyleURLs): Page rules do not (currently) have subresource urls to get,
+  and are not CSSStyleRules.
+
 2012-04-02  Sheriff Bot  
 
 Unreviewed, rolling out r112851.


Modified: trunk/Source/WebCore/css/CSSStyleSheet.cpp (112912 => 112913)

--- trunk/Source/WebCore/css/CSSStyleSheet.cpp	2012-04-02 18:21:27 UTC (rev 112912)
+++ trunk/Source/WebCore/css/CSSStyleSheet.cpp	2012-04-02 18:23:19 UTC (rev 112913)
@@ -461,7 +461,7 @@
 CSSRule* rule = styleSheet->m_childRules[i].get();
 if (rule->isFontFaceRule())
 static_cast(rule)->addSubresourceStyleURLs(urls);
-else if (rule->isStyleRule() || rule->isPageRule())
+else if (rule->isStyleRule())
 static_cast(rule)->styleRule()->addSubresourceStyleURLs(urls, this);
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112916] trunk/LayoutTests

2012-04-02 Thread enrica

Title: [112916] trunk/LayoutTests








Revision 112916
Author enr...@apple.com
Date 2012-04-02 12:06:04 -0700 (Mon, 02 Apr 2012)


Log Message
Skipping inspector/styles/override-screen-size.html on Mac.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (112915 => 112916)

--- trunk/LayoutTests/ChangeLog	2012-04-02 18:53:02 UTC (rev 112915)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 19:06:04 UTC (rev 112916)
@@ -1,3 +1,9 @@
+2012-04-02  Enrica Casucci  
+
+Skipping inspector/styles/override-screen-size.html on Mac.
+
+* platform/mac/Skipped:
+
 2012-04-02  Philip Rogers  
 
 Updating test expectations


Modified: trunk/LayoutTests/platform/mac/Skipped (112915 => 112916)

--- trunk/LayoutTests/platform/mac/Skipped	2012-04-02 18:53:02 UTC (rev 112915)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-04-02 19:06:04 UTC (rev 112916)
@@ -731,3 +731,6 @@
 
 # https://bugs.webkit.org/show_bug.cgi?id=82818
 fast/forms/listbox-clear-restore.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=82923
+inspector/styles/override-screen-size.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112919] trunk

2012-04-02 Thread commit-queue

Title: [112919] trunk








Revision 112919
Author commit-qu...@webkit.org
Date 2012-04-02 12:37:59 -0700 (Mon, 02 Apr 2012)


Log Message
Scroll position is lost after hide/show element
https://bugs.webkit.org/show_bug.cgi?id=72852

Source/WebCore:

Maintain the scroll position of an overflowing element in the ElementRareData when the scrollable
RenderLayer is destroyed, which can be used to restore the scroll position if the same element gets
back a RenderLayer.

WebKit behaviour will be the same as Firefox and IE. It differs from Opera as it does not reset the
scroll position when an element is moved to another location in the same document. However Opera resets
the scroll position for elements moved to another document, which matches other browsers.

Patch by Rakesh KN  on 2012-04-02
Reviewed by Julien Chaffraix.

Test: fast/overflow/scroll-div-hide-show.html

* dom/Element.cpp:
(WebCore::Element::removedFromDocument):
Reset the saved scroll offset if the node is moved to another location in the same document or another one.

(WebCore::Element::savedLayerScrollOffset):
(WebCore::Element::setSavedLayerScrollOffset):
* dom/Element.h:
Add helper functions to access the layer scroll offset from the element's rare data.

* dom/ElementRareData.h:
(ElementRareData):
Add the scroll offset book-keeping.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
Restore the scroll offset.
(WebCore::RenderLayer::~RenderLayer):
Store the scroll offset if document is not being destroyed.

LayoutTests:

Patch by Rakesh KN  on 2012-04-02
Reviewed by Julien Chaffraix.

* fast/overflow/scroll-div-hide-show-expected.txt: Added.
* fast/overflow/scroll-div-hide-show.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ElementRareData.h
trunk/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

trunk/LayoutTests/fast/overflow/scroll-div-hide-show-expected.txt
trunk/LayoutTests/fast/overflow/scroll-div-hide-show.html




Diff

Modified: trunk/LayoutTests/ChangeLog (112918 => 112919)

--- trunk/LayoutTests/ChangeLog	2012-04-02 19:33:52 UTC (rev 112918)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 19:37:59 UTC (rev 112919)
@@ -1,3 +1,13 @@
+2012-04-02  Rakesh KN  
+
+Scroll position is lost after hide/show element
+https://bugs.webkit.org/show_bug.cgi?id=72852
+
+Reviewed by Julien Chaffraix.
+
+* fast/overflow/scroll-div-hide-show-expected.txt: Added.
+* fast/overflow/scroll-div-hide-show.html: Added.
+
 2012-04-02  Stephen Chenney  
 
 [Chromium] Update expectations for SVG Lion results


Added: trunk/LayoutTests/fast/overflow/scroll-div-hide-show-expected.txt (0 => 112919)

--- trunk/LayoutTests/fast/overflow/scroll-div-hide-show-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/overflow/scroll-div-hide-show-expected.txt	2012-04-02 19:37:59 UTC (rev 112919)
@@ -0,0 +1,78 @@
+Scrolled position should be restored when the div is hidden and shown again
+
+Div will be moved here.
+
+Scrolling to 0, 75
+Div's display is none now
+PASS e.scrollTop is 0
+Div's display is block again
+PASS e.scrollTop is 75
+
+Test that after changing the scroll position to different values the scroll position is restored
+Scrolling to 50, 50
+Div's display is none now
+PASS e.scrollTop is 0
+PASS e.scrollLeft is 0
+Div's display is block again
+PASS e.scrollTop is 50
+PASS e.scrollLeft is 50
+Scrolling to 30, 10
+Div's display is none now
+PASS e.scrollTop is 0
+PASS e.scrollLeft is 0
+Div's display is block again
+PASS e.scrollTop is 10
+PASS e.scrollLeft is 30
+Scrolling to 100, 0
+Div's display is none now
+PASS e.scrollTop is 0
+PASS e.scrollLeft is 0
+Div's display is block again
+PASS e.scrollTop is 0
+PASS e.scrollLeft is 100
+
+Testing that scroll position is restored when height and width of scrolling area is changed
+Scrolling to 35, 75
+Div's display is none now
+PASS e.scrollTop is 0
+PASS e.scrollLeft is 0
+Div's display is block again
+PASS e.scrollTop is 75
+PASS e.scrollLeft is 35
+Adding some more text to div
+Scrolling to 125, 100
+Div's display is none now
+PASS e.scrollTop is 0
+PASS e.scrollLeft is 0
+Div's display is block again
+PASS e.scrollTop is 100
+PASS e.scrollLeft is 125
+
+Test that scroll position is reset when the node is moved to different location in the document
+PASS e.scrollTop is 0
+PASS e.scrollLeft is 0
+
+Testing that scroll position is restored for RTL texts
+Scrolling to 50, 150
+Div's display is none now
+PASS e.scrollTop is 0
+PASS e.scrollLeft is 0
+Div's display is block again
+PASS e.scrollTop is 150
+PASS e.scrollLeft is 50
+
+Test iframe scrolling
+Scrolling Iframe to (50, 75)
+Iframe's display is none now
+Iframe's display is block again
+PASS frame.contentWindow.pageYOffset is 75
+PASS frame.contentWindow.pageXOffset is 50
+
+Testing scroll offset getting reset when moved to other doc

[webkit-changes] [112921] trunk/Source/WebKit2

2012-04-02 Thread jesus

Title: [112921] trunk/Source/WebKit2








Revision 112921
Author je...@webkit.org
Date 2012-04-02 12:46:43 -0700 (Mon, 02 Apr 2012)


Log Message
[Qt][WK2] ResourceError::isCancellation() is always returning false
https://bugs.webkit.org/show_bug.cgi?id=82917

Reviewed by Noam Rosenthal.

We were missing the encoding of a boolean in ArgumentCoder
and, therefore, we were getting always "false" for ResourceError::isCancellation()
for errors being sent through the IPC.

* Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPCencode):
(CoreIPCdecode):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/qt/WebCoreArgumentCodersQt.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (112920 => 112921)

--- trunk/Source/WebKit2/ChangeLog	2012-04-02 19:41:52 UTC (rev 112920)
+++ trunk/Source/WebKit2/ChangeLog	2012-04-02 19:46:43 UTC (rev 112921)
@@ -1,3 +1,18 @@
+2012-04-02  Jesus Sanchez-Palencia  
+
+[Qt][WK2] ResourceError::isCancellation() is always returning false
+https://bugs.webkit.org/show_bug.cgi?id=82917
+
+Reviewed by Noam Rosenthal.
+
+We were missing the encoding of a boolean in ArgumentCoder
+and, therefore, we were getting always "false" for ResourceError::isCancellation()
+for errors being sent through the IPC.
+
+* Shared/qt/WebCoreArgumentCodersQt.cpp:
+(CoreIPCencode):
+(CoreIPCdecode):
+
 2012-03-29  Sam Weinig  
 
 Add setting to disable Java for local files even if it is otherwise enabled


Modified: trunk/Source/WebKit2/Shared/qt/WebCoreArgumentCodersQt.cpp (112920 => 112921)

--- trunk/Source/WebKit2/Shared/qt/WebCoreArgumentCodersQt.cpp	2012-04-02 19:41:52 UTC (rev 112920)
+++ trunk/Source/WebKit2/Shared/qt/WebCoreArgumentCodersQt.cpp	2012-04-02 19:46:43 UTC (rev 112921)
@@ -102,8 +102,9 @@
 {
 encoder->encode(resourceError.domain());
 encoder->encode(resourceError.errorCode());
-encoder->encode(resourceError.failingURL()); 
+encoder->encode(resourceError.failingURL());
 encoder->encode(resourceError.localizedDescription());
+encoder->encode(resourceError.isCancellation());
 }
 
 bool ArgumentCoder::decode(ArgumentDecoder* decoder, ResourceError& resourceError)
@@ -123,8 +124,13 @@
 String localizedDescription;
 if (!decoder->decode(localizedDescription))
 return false;
-
+
+bool isCancellation;
+if (!decoder->decode(isCancellation))
+return false;
+
 resourceError = ResourceError(domain, errorCode, failingURL, localizedDescription);
+resourceError.setIsCancellation(isCancellation);
 return true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112924] trunk

2012-04-02 Thread darin

Title: [112924] trunk








Revision 112924
Author da...@chromium.org
Date 2012-04-02 13:14:07 -0700 (Mon, 02 Apr 2012)


Log Message
HistoryItem not updated properly when a form submission begins before a
previous form submission has finished.
https://bugs.webkit.org/show_bug.cgi?id=76686

Reviewed by Nate Chapin.

Source/WebCore:

Test: LayoutTests/fast/loader/form-submission-before-load-{get,post}.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadPostRequest):

LayoutTests:

* fast/loader/form-submission-before-load-get-expected.txt: Added.
* fast/loader/form-submission-before-load-get.html: Added.
* fast/loader/form-submission-before-load-post-expected.txt: Added.
* fast/loader/form-submission-before-load-post.html: Added.
* fast/loader/resources/form-submission-before-load-page2.html: Added.
* fast/loader/resources/form-submission-before-load-page3.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp


Added Paths

trunk/LayoutTests/fast/loader/form-submission-before-load-get-expected.txt
trunk/LayoutTests/fast/loader/form-submission-before-load-get.html
trunk/LayoutTests/fast/loader/form-submission-before-load-post-expected.txt
trunk/LayoutTests/fast/loader/form-submission-before-load-post.html
trunk/LayoutTests/fast/loader/resources/form-submission-before-load-page2.html
trunk/LayoutTests/fast/loader/resources/form-submission-before-load-page3.html




Diff

Modified: trunk/LayoutTests/ChangeLog (112923 => 112924)

--- trunk/LayoutTests/ChangeLog	2012-04-02 19:50:34 UTC (rev 112923)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 20:14:07 UTC (rev 112924)
@@ -1,3 +1,18 @@
+2012-04-02  Darin Fisher  
+
+HistoryItem not updated properly when a form submission begins before a
+previous form submission has finished.
+https://bugs.webkit.org/show_bug.cgi?id=76686
+
+Reviewed by Nate Chapin.
+
+* fast/loader/form-submission-before-load-get-expected.txt: Added.
+* fast/loader/form-submission-before-load-get.html: Added.
+* fast/loader/form-submission-before-load-post-expected.txt: Added.
+* fast/loader/form-submission-before-load-post.html: Added.
+* fast/loader/resources/form-submission-before-load-page2.html: Added.
+* fast/loader/resources/form-submission-before-load-page3.html: Added.
+
 2012-04-02  Philip Rogers  
 
 Rebaseline svg/W3C-SVG-1.1/animate-elem-XX-t.svg


Added: trunk/LayoutTests/fast/loader/form-submission-before-load-get-expected.txt (0 => 112924)

--- trunk/LayoutTests/fast/loader/form-submission-before-load-get-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/loader/form-submission-before-load-get-expected.txt	2012-04-02 20:14:07 UTC (rev 112924)
@@ -0,0 +1,6 @@
+Done.
+
+== Back Forward List ==
+(file test):fast/loader/resources/form-submission-before-load-page2.html?  **nav target**
+curr->  (file test):fast/loader/resources/form-submission-before-load-page3.html  **nav target**
+===


Added: trunk/LayoutTests/fast/loader/form-submission-before-load-get.html (0 => 112924)

--- trunk/LayoutTests/fast/loader/form-submission-before-load-get.html	(rev 0)
+++ trunk/LayoutTests/fast/loader/form-submission-before-load-get.html	2012-04-02 20:14:07 UTC (rev 112924)
@@ -0,0 +1,12 @@
+
+if (window.layoutTestController) {
+layoutTestController.clearBackForwardList();
+layoutTestController.dumpBackForwardList();
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+// Test that submitting the form, using a GET method, before the 'load' event
+// results in the current session history item being replaced by the next one.
+document.forms[0].submit();
+


Added: trunk/LayoutTests/fast/loader/form-submission-before-load-post-expected.txt (0 => 112924)

--- trunk/LayoutTests/fast/loader/form-submission-before-load-post-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/loader/form-submission-before-load-post-expected.txt	2012-04-02 20:14:07 UTC (rev 112924)
@@ -0,0 +1,6 @@
+Done.
+
+== Back Forward List ==
+(file test):fast/loader/resources/form-submission-before-load-page2.html  **nav target**
+curr->  (file test):fast/loader/resources/form-submission-before-load-page3.html  **nav target**
+===


Added: trunk/LayoutTests/fast/loader/form-submission-before-load-post.html (0 => 112924)

--- trunk/LayoutTests/fast/loader/form-submission-before-load-post.html	(rev 0)
+++ trunk/LayoutTests/fast/loader/form-submission-before-load-post.html	2012-04-02 20:14:07 UTC (rev 112924)
@@ -0,0 +1,12 @@
+
+if (window.layoutTestController) {
+layoutTestController.clearBackForwardList();
+layoutTestController.dumpBackForwardList();
+layoutTestController.dum

[webkit-changes] [112925] trunk/LayoutTests

2012-04-02 Thread enrica

Title: [112925] trunk/LayoutTests








Revision 112925
Author enr...@apple.com
Date 2012-04-02 13:17:51 -0700 (Mon, 02 Apr 2012)


Log Message
Skipping inspector/profiler/cpu-profiler-profiling.html
since it produces intermittent crashes.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (112924 => 112925)

--- trunk/LayoutTests/ChangeLog	2012-04-02 20:14:07 UTC (rev 112924)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 20:17:51 UTC (rev 112925)
@@ -1,3 +1,10 @@
+2012-04-02  Enrica Casucci  
+
+Skipping inspector/profiler/cpu-profiler-profiling.html
+since it produces intermittent crashes.
+
+* platform/mac/Skipped:
+
 2012-04-02  Darin Fisher  
 
 HistoryItem not updated properly when a form submission begins before a


Modified: trunk/LayoutTests/platform/mac/Skipped (112924 => 112925)

--- trunk/LayoutTests/platform/mac/Skipped	2012-04-02 20:14:07 UTC (rev 112924)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-04-02 20:17:51 UTC (rev 112925)
@@ -734,3 +734,6 @@
 
 # https://bugs.webkit.org/show_bug.cgi?id=82923
 inspector/styles/override-screen-size.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=82932
+inspector/profiler/cpu-profiler-profiling.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112926] trunk/LayoutTests

2012-04-02 Thread schenney

Title: [112926] trunk/LayoutTests








Revision 112926
Author schen...@chromium.org
Date 2012-04-02 13:21:37 -0700 (Mon, 02 Apr 2012)


Log Message
REGRESSION(r110469): Some SVG Image related test is crashing on cr-mac
https://bugs.webkit.org/show_bug.cgi?id=80976

Unreviewed Chromium test_expectations clean-up

The tests reported in this bug are either no longer crashing or
crashing due to the same problem as Bug 82232. So they are being
consolidated in the test_expectations file.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112925 => 112926)

--- trunk/LayoutTests/ChangeLog	2012-04-02 20:17:51 UTC (rev 112925)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 20:21:37 UTC (rev 112926)
@@ -1,3 +1,16 @@
+2012-04-02  Stephen Chenney  
+
+REGRESSION(r110469): Some SVG Image related test is crashing on cr-mac
+https://bugs.webkit.org/show_bug.cgi?id=80976
+
+Unreviewed Chromium test_expectations clean-up
+
+The tests reported in this bug are either no longer crashing or
+crashing due to the same problem as Bug 82232. So they are being
+consolidated in the test_expectations file.
+
+* platform/chromium/test_expectations.txt:
+
 2012-04-02  Enrica Casucci  
 
 Skipping inspector/profiler/cpu-profiler-profiling.html


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112925 => 112926)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-04-02 20:17:51 UTC (rev 112925)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-04-02 20:21:37 UTC (rev 112926)
@@ -1817,21 +1817,6 @@
 BUGWK82505 SNOWLEOPARD LEOPARD XP LINUX DEBUG : http/tests/xmlhttprequest/uri-resolution-opera-open-004.html = PASS TEXT CRASH
 BUGWK82505 SNOWLEOPARD LEOPARD XP LINUX DEBUG : http/tests/xmlhttprequest/upload-progress-events.html = PASS CRASH
 
-// These are due to an assertion in FrameView::paintContents().
-BUGWK82505 SNOWLEOPARD DEBUG : fast/writing-mode/body-writing-mode-propagation-blocked.html = PASS TEXT CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : fast/writing-mode/body-direction-propagation.html = PASS CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : fast/writing-mode/borders.html = PASS TEXT CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : fast/writing-mode/broken-ideographic-font.html = CRASH PASS
-BUGWK82505 SNOWLEOPARD DEBUG : fast/writing-mode/japanese-ruby-horizontal-bt.html = PASS CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : svg/as-background-image/svg-as-background-3.html = PASS CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : svg/as-background-image/svg-as-background-with-relative-size.html = PASS CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : svg/css/background-image-svg.html = PASS TEXT CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : svg/zoom/page/zoom-foreign-content.svg = PASS TEXT CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : svg/zoom/page/zoom-svg-as-background-with-relative-size.html = PASS CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : svg/zoom/page/zoom-svg-as-image.html = PASS TEXT CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : transitions/remove-transition-style.html = PASS TEXT CRASH
-BUGWK82505 SNOWLEOPARD DEBUG : traversal/node-iterator-prototype.html = PASS CRASH
-
 // Started failing with move from Lighttpd to Apache.
 // Since we have some bots on Lighttpd and some on Apache, mark it as flaky for
 // now. Once we decide on one or the other, then we can address these tests.
@@ -3676,14 +3661,6 @@
 
 BUGWK81050 : fast/forms/file/recover-file-input-in-unposted-form.html = PASS TEXT
 
-BUGWK80976 SNOWLEOPARD : svg/as-image/svg-nested.html = PASS CRASH
-BUGWK80976 SNOWLEOPARD : svg/custom/fill-opacity-rgba.svg = PASS CRASH
-BUGWK80976 SNOWLEOPARD : tables/mozilla_expected_failures/marvin/table_overflow_td_align_right.html = PASS CRASH
-BUGWK80976 SNOWLEOPARD : transitions/interrupt-transform-transition.html = PASS CRASH
-BUGWK80976 SNOWLEOPARD : svg/as-image/svg-image-leak-loader.html = PASS CRASH
-BUGWK80976 SNOWLEOPARD : svg/custom/feComponentTransfer-Gamma.svg = PASS CRASH
-BUGWK80976 SNOWLEOPARD : transitions/multiple-text-shadow-transition.html = PASS CRASH
-
 BUGWK81145 LION : compositing/plugins/composited-plugin.html = IMAGE+TEXT
 BUGWK81145 LION : fast/repaint/transform-absolute-in-positioned-container.html = IMAGE+TEXT
 BUGWK81145 LION : fast/text/international/bidi-AN-after-empty-run.html = IMAGE+TEXT
@@ -3937,10 +3914,28 @@
 BUGWK82230 LINUX DEBUG : http/tests/cache/post-redirect-get.php = PASS CRASH
 BUGWK82231 WIN DEBUG : fast/canvas/webgl/program-test.html = PASS CRASH
 
+// These all fail with roughly the same stack that passes through SVG code. But it is not entirely clear
+// that it is an SVG issue, as some of the tests do not include any SVG at all.
 BUGWK82232 SNOWLEOPARD LINUX : svg/as-image/animated-svg-as-image-same-image.html = PASS IMAGE CRASH
 BUGWK82232 SNOWLEOPARD DEBUG : svg/as-background-image/background-image-tiled.h

[webkit-changes] [112927] trunk/LayoutTests

2012-04-02 Thread enrica

Title: [112927] trunk/LayoutTests








Revision 112927
Author enr...@apple.com
Date 2012-04-02 13:25:51 -0700 (Mon, 02 Apr 2012)


Log Message
Skipping flakey test on Mac.

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (112926 => 112927)

--- trunk/LayoutTests/ChangeLog	2012-04-02 20:21:37 UTC (rev 112926)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 20:25:51 UTC (rev 112927)
@@ -1,3 +1,9 @@
+2012-04-02  Enrica Casucci  
+
+Skipping flakey test on Mac.
+
+* platform/mac/Skipped:
+
 2012-04-02  Stephen Chenney  
 
 REGRESSION(r110469): Some SVG Image related test is crashing on cr-mac


Modified: trunk/LayoutTests/platform/mac/Skipped (112926 => 112927)

--- trunk/LayoutTests/platform/mac/Skipped	2012-04-02 20:21:37 UTC (rev 112926)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-04-02 20:25:51 UTC (rev 112927)
@@ -737,3 +737,6 @@
 
 # https://bugs.webkit.org/show_bug.cgi?id=82932
 inspector/profiler/cpu-profiler-profiling.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=82934
+storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112928] trunk/Source/JavaScriptCore

2012-04-02 Thread dbates

Title: [112928] trunk/Source/_javascript_Core








Revision 112928
Author dba...@webkit.org
Date 2012-04-02 13:28:57 -0700 (Mon, 02 Apr 2012)


Log Message
Remove Source/_javascript_Core/wtf and its empty subdirectories

Rubber-stamped by Eric Seidel.

Following the move of WTF from Source/_javascript_Core/wtf to Source/WTF
(https://bugs.webkit.org/show_bug.cgi?id=75673), remove directory
Source/_javascript_Core/wtf and its empty subdirectories.

* wtf: Removed.
* wtf/android: Removed.
* wtf/blackberry: Removed.
* wtf/chromium: Removed.
* wtf/dtoa: Removed.
* wtf/efl: Removed.
* wtf/gobject: Removed.
* wtf/gtk: Removed.
* wtf/mac: Removed.
* wtf/qt: Removed.
* wtf/qt/compat: Removed.
* wtf/tests: Removed.
* wtf/text: Removed.
* wtf/threads: Removed.
* wtf/threads/win: Removed.
* wtf/unicode: Removed.
* wtf/unicode/glib: Removed.
* wtf/unicode/icu: Removed.
* wtf/unicode/qt4: Removed.
* wtf/unicode/wince: Removed.
* wtf/url: Removed.
* wtf/url/api: Removed.
* wtf/url/src: Removed.
* wtf/win: Removed.
* wtf/wince: Removed.
* wtf/wx: Removed.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog


Removed Paths

trunk/Source/_javascript_Core/wtf/




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (112927 => 112928)

--- trunk/Source/_javascript_Core/ChangeLog	2012-04-02 20:25:51 UTC (rev 112927)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-04-02 20:28:57 UTC (rev 112928)
@@ -1,3 +1,40 @@
+2012-04-02  Daniel Bates  
+
+Remove Source/_javascript_Core/wtf and its empty subdirectories
+
+Rubber-stamped by Eric Seidel.
+
+Following the move of WTF from Source/_javascript_Core/wtf to Source/WTF
+(https://bugs.webkit.org/show_bug.cgi?id=75673), remove directory
+Source/_javascript_Core/wtf and its empty subdirectories.
+
+* wtf: Removed.
+* wtf/android: Removed.
+* wtf/blackberry: Removed.
+* wtf/chromium: Removed.
+* wtf/dtoa: Removed.
+* wtf/efl: Removed.
+* wtf/gobject: Removed.
+* wtf/gtk: Removed.
+* wtf/mac: Removed.
+* wtf/qt: Removed.
+* wtf/qt/compat: Removed.
+* wtf/tests: Removed.
+* wtf/text: Removed.
+* wtf/threads: Removed.
+* wtf/threads/win: Removed.
+* wtf/unicode: Removed.
+* wtf/unicode/glib: Removed.
+* wtf/unicode/icu: Removed.
+* wtf/unicode/qt4: Removed.
+* wtf/unicode/wince: Removed.
+* wtf/url: Removed.
+* wtf/url/api: Removed.
+* wtf/url/src: Removed.
+* wtf/win: Removed.
+* wtf/wince: Removed.
+* wtf/wx: Removed.
+
 2012-04-02  Carlos Garcia Campos  
 
 Unreviewed. Fix make distcheck issues.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112929] trunk/LayoutTests

2012-04-02 Thread schenney

Title: [112929] trunk/LayoutTests








Revision 112929
Author schen...@chromium.org
Date 2012-04-02 13:34:55 -0700 (Mon, 02 Apr 2012)


Log Message
[chromium] Layout Test svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm is flaky for DEBUG
https://bugs.webkit.org/show_bug.cgi?id=79455

Unreviewed Chromium test_expectations clean-up.

Closing another bug that is an instance of WK82232.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112928 => 112929)

--- trunk/LayoutTests/ChangeLog	2012-04-02 20:28:57 UTC (rev 112928)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 20:34:55 UTC (rev 112929)
@@ -1,3 +1,14 @@
+2012-04-02  Stephen Chenney  
+
+[chromium] Layout Test svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm is flaky for DEBUG
+https://bugs.webkit.org/show_bug.cgi?id=79455
+
+Unreviewed Chromium test_expectations clean-up.
+
+Closing another bug that is an instance of WK82232.
+
+* platform/chromium/test_expectations.txt:
+
 2012-04-02  Enrica Casucci  
 
 Skipping flakey test on Mac.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112928 => 112929)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-04-02 20:28:57 UTC (rev 112928)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-04-02 20:34:55 UTC (rev 112929)
@@ -3564,10 +3564,6 @@
 BUGWK79454 LINUX : svg/text/text-rescale.html = IMAGE PASS
 BUGWK79454 MAC WIN : svg/text/text-viewbox-rescale.html = IMAGE
 
-// Flaky for DEBUG since r108585
-// CRASH is from BUGWK82505.
-BUGWK79455 DEBUG : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS IMAGE+TEXT CRASH
-
 BUGWK79456 DEBUG : svg/repaint/image-with-clip-path.svg = PASS IMAGE
 
 BUGWK79540 : fast/files/workers/worker-apply-blob-url-to-xhr.html = PASS CRASH
@@ -3936,6 +3932,7 @@
 BUGWK82232 SNOWLEOPARD DEBUG : fast/writing-mode/japanese-ruby-horizontal-bt.html = PASS CRASH
 BUGWK82232 SNOWLEOPARD DEBUG : transitions/remove-transition-style.html = PASS TEXT CRASH
 BUGWK82232 SNOWLEOPARD DEBUG : traversal/node-iterator-prototype.html = PASS CRASH
+BUGWK82232 SNOWLEOPARD DEBUG : svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm = PASS CRASH
 
 // Flaky since at least r111670
 BUGWK82258 DEBUG : svg/custom/circular-marker-reference-4.svg = TEXT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112930] trunk/Source/WebCore

2012-04-02 Thread msaboff

Title: [112930] trunk/Source/WebCore








Revision 112930
Author msab...@apple.com
Date 2012-04-02 13:34:59 -0700 (Mon, 02 Apr 2012)


Log Message
WebKit should throttle memory pressure notifications in proportion to handler time
https://bugs.webkit.org/show_bug.cgi?id=82674

Rubber-stamped by Darin Adler.

Updated r112910:  to address
post checkin concerns raised in original bug.

No additional tests. This passes existing test and was verified using
manual tests on a small memory system with many websites open.

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (112929 => 112930)

--- trunk/Source/WebCore/ChangeLog	2012-04-02 20:34:55 UTC (rev 112929)
+++ trunk/Source/WebCore/ChangeLog	2012-04-02 20:34:59 UTC (rev 112930)
@@ -1,3 +1,20 @@
+2012-04-02  Michael Saboff  
+
+WebKit should throttle memory pressure notifications in proportion to handler time
+https://bugs.webkit.org/show_bug.cgi?id=82674
+
+Rubber-stamped by Darin Adler.
+
+Updated r112910:  to address
+post checkin concerns raised in original bug.
+
+No additional tests. This passes existing test and was verified using
+manual tests on a small memory system with many websites open.
+
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore):
+(WebCore::MemoryPressureHandler::respondToMemoryPressure):
+
 2012-04-02  Darin Fisher  
 
 HistoryItem not updated properly when a form submission begins before a


Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (112929 => 112930)

--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2012-04-02 20:34:55 UTC (rev 112929)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm	2012-04-02 20:34:59 UTC (rev 112930)
@@ -38,6 +38,8 @@
 #import 
 #endif
 
+using std::max;
+
 namespace WebCore {
 
 #if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
@@ -53,8 +55,8 @@
 // this is 1 / s_holdOffMultiplier percent of the time.
 // These value seems reasonable and testing verifies that it throttles frequent
 // low memory events, greatly reducing CPU usage.
-static const time_t s_minimumHoldOffTime = 5;
-static const time_t s_holdOffMultiplier = 20;
+static const unsigned s_minimumHoldOffTime = 5;
+static const unsigned s_holdOffMultiplier = 20;
 
 void MemoryPressureHandler::install()
 {
@@ -116,23 +118,15 @@
 
 void MemoryPressureHandler::respondToMemoryPressure()
 {
-double startTime, endTime;
-unsigned holdOffTime;
-
 uninstall();
 
-startTime = monotonicallyIncreasingTime();
+double startTime = monotonicallyIncreasingTime();
 
 releaseMemory(false);
 
-endTime = monotonicallyIncreasingTime();
+unsigned holdOffTime = (monotonicallyIncreasingTime() - startTime) * s_holdOffMultiplier;
 
-holdOffTime = (unsigned)((endTime - startTime) * (double)s_holdOffMultiplier);
-
-if (holdOffTime < s_minimumHoldOffTime)
-holdOffTime = s_minimumHoldOffTime;
-
-holdOff(holdOffTime);
+holdOff(max(holdOffTime, s_minimumHoldOffTime));
 }
 #endif // !PLATFORM(IOS)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112931] trunk/LayoutTests

2012-04-02 Thread enrica

Title: [112931] trunk/LayoutTests








Revision 112931
Author enr...@apple.com
Date 2012-04-02 13:38:04 -0700 (Mon, 02 Apr 2012)


Log Message
Skipping 2 Unicode tests that are crashing intermittently.

* platform/mac-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (112930 => 112931)

--- trunk/LayoutTests/ChangeLog	2012-04-02 20:34:59 UTC (rev 112930)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 20:38:04 UTC (rev 112931)
@@ -1,3 +1,9 @@
+2012-04-02  Enrica Casucci  
+
+Skipping 2 Unicode tests that are crashing intermittently.
+
+* platform/mac-wk2/Skipped:
+
 2012-04-02  Stephen Chenney  
 
 [chromium] Layout Test svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm is flaky for DEBUG


Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (112930 => 112931)

--- trunk/LayoutTests/platform/mac-wk2/Skipped	2012-04-02 20:34:59 UTC (rev 112930)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2012-04-02 20:38:04 UTC (rev 112931)
@@ -347,6 +347,10 @@
 platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html
 svg/transforms/change-transform-origin-css.xhtml
 
+# Intermittent crashes
+# https://bugs.webkit.org/show_bug.cgi?id=82939
+sputnik/Unicode/Unicode_218/S7.6_A2.4.html
+sputnik/Unicode/Unicode_218/S7.6_A5.2_T1.html
 
 ### END OF (3) Unclassified failures
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112932] trunk/LayoutTests

2012-04-02 Thread enrica

Title: [112932] trunk/LayoutTests








Revision 112932
Author enr...@apple.com
Date 2012-04-02 13:45:32 -0700 (Mon, 02 Apr 2012)


Log Message
Skipping ASSERTING inspector/debugging tests. 

* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (112931 => 112932)

--- trunk/LayoutTests/ChangeLog	2012-04-02 20:38:04 UTC (rev 112931)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 20:45:32 UTC (rev 112932)
@@ -1,5 +1,11 @@
 2012-04-02  Enrica Casucci  
 
+Skipping ASSERTING inspector/debugging tests. 
+
+* platform/mac/Skipped:
+
+2012-04-02  Enrica Casucci  
+
 Skipping 2 Unicode tests that are crashing intermittently.
 
 * platform/mac-wk2/Skipped:


Modified: trunk/LayoutTests/platform/mac/Skipped (112931 => 112932)

--- trunk/LayoutTests/platform/mac/Skipped	2012-04-02 20:38:04 UTC (rev 112931)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-04-02 20:45:32 UTC (rev 112932)
@@ -740,3 +740,7 @@
 
 # https://bugs.webkit.org/show_bug.cgi?id=82934
 storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=82943
+inspector/debugger/copy-stack-trace.html
+inspector/debugger/callstack-placards-discarded.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112933] trunk/Source/WebCore

2012-04-02 Thread commit-queue

Title: [112933] trunk/Source/WebCore








Revision 112933
Author commit-qu...@webkit.org
Date 2012-04-02 13:46:07 -0700 (Mon, 02 Apr 2012)


Log Message
Align IDL to Typed Array Specification
https://bugs.webkit.org/show_bug.cgi?id=82919

Patch by Seo Sanghyeon  on 2012-04-02
Reviewed by Darin Adler.

No tests. No change in behavior.

* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/Float32Array.idl
trunk/Source/WebCore/html/canvas/Float64Array.idl
trunk/Source/WebCore/html/canvas/Int16Array.idl
trunk/Source/WebCore/html/canvas/Int32Array.idl
trunk/Source/WebCore/html/canvas/Int8Array.idl
trunk/Source/WebCore/html/canvas/Uint16Array.idl
trunk/Source/WebCore/html/canvas/Uint32Array.idl
trunk/Source/WebCore/html/canvas/Uint8Array.idl
trunk/Source/WebCore/html/canvas/Uint8ClampedArray.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (112932 => 112933)

--- trunk/Source/WebCore/ChangeLog	2012-04-02 20:45:32 UTC (rev 112932)
+++ trunk/Source/WebCore/ChangeLog	2012-04-02 20:46:07 UTC (rev 112933)
@@ -1,3 +1,22 @@
+2012-04-02  Seo Sanghyeon  
+
+Align IDL to Typed Array Specification
+https://bugs.webkit.org/show_bug.cgi?id=82919
+
+Reviewed by Darin Adler.
+
+No tests. No change in behavior.
+
+* html/canvas/Float32Array.idl:
+* html/canvas/Float64Array.idl:
+* html/canvas/Int16Array.idl:
+* html/canvas/Int32Array.idl:
+* html/canvas/Int8Array.idl:
+* html/canvas/Uint16Array.idl:
+* html/canvas/Uint32Array.idl:
+* html/canvas/Uint8Array.idl:
+* html/canvas/Uint8ClampedArray.idl:
+
 2012-04-02  Michael Saboff  
 
 WebKit should throttle memory pressure notifications in proportion to handler time


Modified: trunk/Source/WebCore/html/canvas/Float32Array.idl (112932 => 112933)

--- trunk/Source/WebCore/html/canvas/Float32Array.idl	2012-04-02 20:45:32 UTC (rev 112932)
+++ trunk/Source/WebCore/html/canvas/Float32Array.idl	2012-04-02 20:46:07 UTC (rev 112933)
@@ -35,7 +35,7 @@
 CustomToJSObject,
 DoNotCheckConstants
 ] Float32Array : ArrayBufferView {
-const unsigned int BYTES_PER_ELEMENT = 4;
+const unsigned long BYTES_PER_ELEMENT = 4;
 
 readonly attribute unsigned long length;
 Float32Array subarray(in [Optional=DefaultIsUndefined] long start, 


Modified: trunk/Source/WebCore/html/canvas/Float64Array.idl (112932 => 112933)

--- trunk/Source/WebCore/html/canvas/Float64Array.idl	2012-04-02 20:45:32 UTC (rev 112932)
+++ trunk/Source/WebCore/html/canvas/Float64Array.idl	2012-04-02 20:46:07 UTC (rev 112933)
@@ -35,7 +35,7 @@
 CustomToJSObject,
 DoNotCheckConstants
 ] Float64Array : ArrayBufferView {
-const unsigned int BYTES_PER_ELEMENT = 8;
+const unsigned long BYTES_PER_ELEMENT = 8;
 
 readonly attribute unsigned long length;
 Float64Array subarray(in [Optional=DefaultIsUndefined] long start, 


Modified: trunk/Source/WebCore/html/canvas/Int16Array.idl (112932 => 112933)

--- trunk/Source/WebCore/html/canvas/Int16Array.idl	2012-04-02 20:45:32 UTC (rev 112932)
+++ trunk/Source/WebCore/html/canvas/Int16Array.idl	2012-04-02 20:46:07 UTC (rev 112933)
@@ -34,7 +34,7 @@
 CustomToJSObject,
 DoNotCheckConstants
 ] Int16Array : ArrayBufferView {
-const unsigned int BYTES_PER_ELEMENT = 2;
+const unsigned long BYTES_PER_ELEMENT = 2;
 
 readonly attribute unsigned long length;
 Int16Array subarray(in [Optional=DefaultIsUndefined] long start, 


Modified: trunk/Source/WebCore/html/canvas/Int32Array.idl (112932 => 112933)

--- trunk/Source/WebCore/html/canvas/Int32Array.idl	2012-04-02 20:45:32 UTC (rev 112932)
+++ trunk/Source/WebCore/html/canvas/Int32Array.idl	2012-04-02 20:46:07 UTC (rev 112933)
@@ -35,7 +35,7 @@
 CustomToJSObject,
 DoNotCheckConstants
 ] Int32Array : ArrayBufferView {
-const unsigned int BYTES_PER_ELEMENT = 4;
+const unsigned long BYTES_PER_ELEMENT = 4;
 
 readonly attribute unsigned long length;
 Int32Array subarray(in [Optional=DefaultIsUndefined] long start, 


Modified: trunk/Source/WebCore/html/canvas/Int8Array.idl (112932 => 112933)

--- trunk/Source/WebCore/html/canvas/Int8Array.idl	2012-04-02 20:45:32 UTC (rev 112932)
+++ trunk/Source/WebCore/html/canvas/Int8Array.idl	2012-04-02 20:46:07 UTC (rev 112933)
@@ -35,7 +35,7 @@
 CustomToJSObject,
 DoNotCheckConstants
 ] Int8Array : ArrayBufferView {
-const unsigned int BYTES_PER_ELEMENT = 1;
+const unsigned long BYTES_PER_ELEMENT = 1;
 
 readonly attribute unsigned long length;

[webkit-changes] [112934] trunk/LayoutTests

2012-04-02 Thread schenney

Title: [112934] trunk/LayoutTests








Revision 112934
Author schen...@chromium.org
Date 2012-04-02 13:53:26 -0700 (Mon, 02 Apr 2012)


Log Message
[chromium] Layout Test svg/text/text-rescale.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79454

Unreviewed Chromium test_expectations update.

Some the of results for svg/text/text-rescale.svg and svg/text/text-viewbox-rescale.svg
are just in need of rebaselining, while others are flakey. Clarifying
the situation in test_expectations.

* platform/chromium-linux/svg/text/text-rescale-expected.txt: Removed.
* platform/chromium-linux/svg/text/text-viewbox-rescale-expected.txt: Removed.
* platform/chromium-mac/svg/text/text-rescale-expected.png: Added.
* platform/chromium-win/svg/text/text-rescale-expected.png: Added.
* platform/chromium-win/svg/text/text-rescale-expected.txt: Added.
* platform/chromium-win/svg/text/text-viewbox-rescale-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/svg/text/text-viewbox-rescale-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-mac/svg/text/text-rescale-expected.png
trunk/LayoutTests/platform/chromium-win/svg/text/text-rescale-expected.png
trunk/LayoutTests/platform/chromium-win/svg/text/text-rescale-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/text/text-viewbox-rescale-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-linux/svg/text/text-rescale-expected.txt
trunk/LayoutTests/platform/chromium-linux/svg/text/text-viewbox-rescale-expected.txt
trunk/LayoutTests/platform/mac/svg/text/text-viewbox-rescale-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112933 => 112934)

--- trunk/LayoutTests/ChangeLog	2012-04-02 20:46:07 UTC (rev 112933)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 20:53:26 UTC (rev 112934)
@@ -1,3 +1,23 @@
+2012-04-02  Stephen Chenney  
+
+[chromium] Layout Test svg/text/text-rescale.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=79454
+
+Unreviewed Chromium test_expectations update.
+
+Some the of results for svg/text/text-rescale.svg and svg/text/text-viewbox-rescale.svg
+are just in need of rebaselining, while others are flakey. Clarifying
+the situation in test_expectations.
+
+* platform/chromium-linux/svg/text/text-rescale-expected.txt: Removed.
+* platform/chromium-linux/svg/text/text-viewbox-rescale-expected.txt: Removed.
+* platform/chromium-mac/svg/text/text-rescale-expected.png: Added.
+* platform/chromium-win/svg/text/text-rescale-expected.png: Added.
+* platform/chromium-win/svg/text/text-rescale-expected.txt: Added.
+* platform/chromium-win/svg/text/text-viewbox-rescale-expected.png: Added.
+* platform/chromium/test_expectations.txt:
+* platform/mac/svg/text/text-viewbox-rescale-expected.txt: Removed.
+
 2012-04-02  Enrica Casucci  
 
 Skipping ASSERTING inspector/debugging tests. 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112933 => 112934)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-04-02 20:46:07 UTC (rev 112933)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-04-02 20:53:26 UTC (rev 112934)
@@ -3559,10 +3559,9 @@
 BUGWK81217 : svg/hixie/perf/003.xml = FAIL
 
 // Failing since added by r108699
-BUGWK79454 WIN : svg/text/text-rescale.html = IMAGE+TEXT
-BUGWK79454 MAC : svg/text/text-rescale.html = IMAGE
-BUGWK79454 LINUX : svg/text/text-rescale.html = IMAGE PASS
-BUGWK79454 MAC WIN : svg/text/text-viewbox-rescale.html = IMAGE
+BUGWK79454 MAC DEBUG : svg/text/text-rescale.html = IMAGE PASS
+BUGWK79454 LINUX DEBUG : svg/text/text-rescale.html = IMAGE PASS
+BUGWK79454 LINUX MAC : svg/text/text-viewbox-rescale.html = IMAGE PASS
 
 BUGWK79456 DEBUG : svg/repaint/image-with-clip-path.svg = PASS IMAGE
 


Deleted: trunk/LayoutTests/platform/chromium-linux/svg/text/text-rescale-expected.txt (112933 => 112934)

--- trunk/LayoutTests/platform/chromium-linux/svg/text/text-rescale-expected.txt	2012-04-02 20:46:07 UTC (rev 112933)
+++ trunk/LayoutTests/platform/chromium-linux/svg/text/text-rescale-expected.txt	2012-04-02 20:53:26 UTC (rev 112934)
@@ -1,55 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
-layer at (0,0) size 500x200
-  RenderSVGRoot {svg} at (0,13) size 405x187
-RenderSVGContainer {g} at (0,13) size 405x100
-  RenderSVGText {text} at (0,14) size 200x46 contains 1 chunk(s)
-RenderSVGInlineText {#text} at (0,0) size 105x46
-  chunk 1 text run 1 at (0.00,50.00) startOffset 0 endOffset 5 width 105.00: "PASS "
-RenderSVGTSpan {tspan} at (0,0) size 95x46
-  RenderSVGInlineText {#text} at (105,0) size 95x46
-

[webkit-changes] [112935] trunk

2012-04-02 Thread commit-queue

Title: [112935] trunk








Revision 112935
Author commit-qu...@webkit.org
Date 2012-04-02 13:58:10 -0700 (Mon, 02 Apr 2012)


Log Message
Crash due to floating object lists not properly being cleared
https://bugs.webkit.org/show_bug.cgi?id=74056

Patch by Ken Buchanan  on 2012-04-02
Reviewed by David Hyatt.

Source/WebCore:

Add a check to clearFloats() that determines when intruding floats
are being cleared and not re-added. In this condition, ensure
children with floats are also getting layout because they might
need to have the same intruding floats cleared from their floating
object lists also.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats):

LayoutTests:

This test creates a condition where an intruding float is changed so
that it no longer intrudes. The child of a sibling was not getting
properly updated during the next layout.

* fast/block/float/intruding-float-not-removed-from-descendant-crash-expected.txt: Added
* fast/block/float/intruding-float-not-removed-from-descendant-crash.html: Added

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp


Added Paths

trunk/LayoutTests/fast/block/float/intruding-float-not-removed-from-descendant-crash-expected.txt
trunk/LayoutTests/fast/block/float/intruding-float-not-removed-from-descendant-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (112934 => 112935)

--- trunk/LayoutTests/ChangeLog	2012-04-02 20:53:26 UTC (rev 112934)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 20:58:10 UTC (rev 112935)
@@ -1,3 +1,17 @@
+2012-04-02  Ken Buchanan  
+
+Crash due to floating object lists not properly being cleared
+https://bugs.webkit.org/show_bug.cgi?id=74056
+
+Reviewed by David Hyatt.
+
+This test creates a condition where an intruding float is changed so
+that it no longer intrudes. The child of a sibling was not getting
+properly updated during the next layout.
+
+* fast/block/float/intruding-float-not-removed-from-descendant-crash-expected.txt: Added
+* fast/block/float/intruding-float-not-removed-from-descendant-crash.html: Added
+
 2012-04-02  Stephen Chenney  
 
 [chromium] Layout Test svg/text/text-rescale.html is failing


Added: trunk/LayoutTests/fast/block/float/intruding-float-not-removed-from-descendant-crash-expected.txt (0 => 112935)

--- trunk/LayoutTests/fast/block/float/intruding-float-not-removed-from-descendant-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/block/float/intruding-float-not-removed-from-descendant-crash-expected.txt	2012-04-02 20:58:10 UTC (rev 112935)
@@ -0,0 +1,3 @@
+Test passes if it does not crash.
+PASS
+


Added: trunk/LayoutTests/fast/block/float/intruding-float-not-removed-from-descendant-crash.html (0 => 112935)

--- trunk/LayoutTests/fast/block/float/intruding-float-not-removed-from-descendant-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/block/float/intruding-float-not-removed-from-descendant-crash.html	2012-04-02 20:58:10 UTC (rev 112935)
@@ -0,0 +1,54 @@
+
+Test passes if it does not crash.
+
+.div2 { float: none; width: 100px; }
+.div2:nth-last-child(odd) { float: right; }
+.span1 { float: right; height: 100px; }
+.td1 { height: 100px; }
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function runTest() {
+span1 = document.createElement('span');
+span1.setAttribute('class', 'span1');
+document.documentElement.appendChild(span1);
+
+div2 = document.createElement('div');
+div2.setAttribute('class', 'div2');
+document.documentElement.appendChild(div2);
+
+document.documentElement.appendChild(document.createElement('div'));
+
+div3 = document.createElement('div');
+document.documentElement.appendChild(div3);
+
+document.documentElement.appendChild(document.createElement('span'));
+document.documentElement.appendChild(document.createElement('span'));
+document.documentElement.appendChild(document.createElement('span'));
+
+span2 = document.createElement('span');
+document.documentElement.appendChild(span2);
+
+document.documentElement.appendChild(document.createElement('div'));
+
+document.body.offsetTop;
+div1 = document.createElement('div');
+td1 = document.createElement('td');
+td1.appendChild(document.createTextNode('PASS'));
+td1.setAttribute('class', 'td1');
+div1.appendChild(td1);
+div2.appendChild(div1);
+
+document.body.offsetTop;
+document.body.appendChild(div3);
+
+document.body.offsetTop;
+span2.appendChild(span1);
+document.createElement("span").appendChild(span2);
+}
+
+window._onload_ = runTest;
+
+


Modified: trunk/Source/WebCore/ChangeLog (112934 => 112935)

--- trunk/Source/WebCore/ChangeLog	2012-04-02 20:53:26 UTC (rev 112934)
+++ trunk/Source/WebCore/ChangeLog	2012-04-02 20:58:10 UTC (rev 112935)
@@ -1,3 +1,19 @@
+2012-04-02  Ken Buchanan  
+
+Crash due to floating object lists not properly being cleared
+https://bugs.webkit.org/

[webkit-changes] [112936] trunk/Source/WebCore

2012-04-02 Thread leviw

Title: [112936] trunk/Source/WebCore








Revision 112936
Author le...@chromium.org
Date 2012-04-02 14:00:08 -0700 (Mon, 02 Apr 2012)


Log Message
Correct remaining LayoutUnit misuse in RenderReplaced and RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=82899

Reviewed by Darin Adler.

Removing remaining LayoutUnit misuse and compiler errors that exist in RenderReplaced
and RenderFlexibleBox once LayoutUnit becomes sub-pixel.

No new tests. No change in behavior.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Switching
a raw zero in a ternary operation to zeroLayoutUnit.
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Ditto for std::max.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint): Adding missing pixel snapping before painting.
(WebCore::RenderReplaced::computeReplacedLogicalWidth): Like above, switching
a raw zero to zeroLayoutUnit.
(WebCore::RenderReplaced::computePreferredLogicalWidths): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderReplaced.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112935 => 112936)

--- trunk/Source/WebCore/ChangeLog	2012-04-02 20:58:10 UTC (rev 112935)
+++ trunk/Source/WebCore/ChangeLog	2012-04-02 21:00:08 UTC (rev 112936)
@@ -1,3 +1,25 @@
+2012-04-02  Levi Weintraub  
+
+Correct remaining LayoutUnit misuse in RenderReplaced and RenderFlexibleBox
+https://bugs.webkit.org/show_bug.cgi?id=82899
+
+Reviewed by Darin Adler.
+
+Removing remaining LayoutUnit misuse and compiler errors that exist in RenderReplaced
+and RenderFlexibleBox once LayoutUnit becomes sub-pixel.
+
+No new tests. No change in behavior.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Switching
+a raw zero in a ternary operation to zeroLayoutUnit.
+(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Ditto for std::max.
+* rendering/RenderReplaced.cpp:
+(WebCore::RenderReplaced::paint): Adding missing pixel snapping before painting.
+(WebCore::RenderReplaced::computeReplacedLogicalWidth): Like above, switching
+a raw zero to zeroLayoutUnit.
+(WebCore::RenderReplaced::computePreferredLogicalWidths): Ditto.
+
 2012-04-02  Ken Buchanan  
 
 Crash due to floating object lists not properly being cleared


Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (112935 => 112936)

--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2012-04-02 20:58:10 UTC (rev 112935)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2012-04-02 21:00:08 UTC (rev 112936)
@@ -296,7 +296,7 @@
 
 void RenderFlexibleBox::repositionLogicalHeightDependentFlexItems(FlexOrderIterator& iterator, WTF::Vector& lineContexts, LayoutUnit& oldClientAfterEdge)
 {
-LayoutUnit crossAxisStartEdge = lineContexts.isEmpty() ? 0 : lineContexts[0].crossAxisOffset;
+LayoutUnit crossAxisStartEdge = lineContexts.isEmpty() ? zeroLayoutUnit : lineContexts[0].crossAxisOffset;
 packFlexLines(iterator, lineContexts);
 
 // If we have a single line flexbox, the line height is all the available space.
@@ -1120,7 +1120,7 @@
 } else if (isColumnFlow() && child->style()->logicalWidth().isAuto() && isMultiline()) {
 // FIXME: Handle min-width and max-width.
 LayoutUnit childWidth = lineCrossAxisExtent - crossAxisMarginExtentForChild(child);
-child->setOverrideWidth(std::max(0, childWidth));
+child->setOverrideWidth(std::max(zeroLayoutUnit, childWidth));
 child->setChildNeedsLayout(true);
 child->layoutIfNeeded();
 }


Modified: trunk/Source/WebCore/rendering/RenderReplaced.cpp (112935 => 112936)

--- trunk/Source/WebCore/rendering/RenderReplaced.cpp	2012-04-02 20:58:10 UTC (rev 112935)
+++ trunk/Source/WebCore/rendering/RenderReplaced.cpp	2012-04-02 21:00:08 UTC (rev 112936)
@@ -161,7 +161,7 @@
 if (drawSelectionTint) {
 LayoutRect selectionPaintingRect = localSelectionRect();
 selectionPaintingRect.moveBy(adjustedPaintOffset);
-paintInfo.context->fillRect(selectionPaintingRect, selectionBackgroundColor(), style()->colorSpace());
+paintInfo.context->fillRect(pixelSnappedIntRect(selectionPaintingRect), selectionBackgroundColor(), style()->colorSpace());
 }
 }
 
@@ -360,7 +360,7 @@
 // This solves above equation for 'width' (== logicalWidth).
 LayoutUnit marginStart = minimumValueForLength(style()->marginStart(), logicalWidth);
 LayoutUnit marginEnd = minimumValueForLength(style()->marginEnd(), logicalWidth);
-logicalWidth = max(0, logicalWidth - (marginStart + marginEnd + (width() - clientWidth(;
+logicalWidth = max(zeroLayoutUnit, logicalWidth - (marginSta

[webkit-changes] [112937] trunk/LayoutTests

2012-04-02 Thread scherkus

Title: [112937] trunk/LayoutTests








Revision 112937
Author scher...@chromium.org
Date 2012-04-02 14:05:09 -0700 (Mon, 02 Apr 2012)


Log Message
2012-04-02  David Dorwin  

Add layout test expectations for Chromium to exhibit support WebM types
https://bugs.webkit.org/show_bug.cgi?id=82925

Unreviewed.

* platform/chromium/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
* platform/chromium/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
* platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
* platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium/media/W3C/
trunk/LayoutTests/platform/chromium/media/W3C/video/
trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/
trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt
trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt
trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt
trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112936 => 112937)

--- trunk/LayoutTests/ChangeLog	2012-04-02 21:00:08 UTC (rev 112936)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 21:05:09 UTC (rev 112937)
@@ -1,3 +1,16 @@
+2012-04-02  David Dorwin  
+
+Add layout test expectations for Chromium to exhibit support WebM types
+https://bugs.webkit.org/show_bug.cgi?id=82925
+
+Unreviewed.
+
+* platform/chromium/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
+* platform/chromium/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
+* platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
+* platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
 2012-04-02  Ken Buchanan  
 
 Crash due to floating object lists not properly being cleared


Added: trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt (0 => 112937)

--- trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt	2012-04-02 21:05:09 UTC (rev 112937)
@@ -0,0 +1,11 @@
+video.canPlayType() - codecs parameter order
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS "probably" is "probably"
+
+TEST COMPLETE
+spec reference
+
+
Property changes on: trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt (0 => 112937)

--- trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt	2012-04-02 21:05:09 UTC (rev 112937)
@@ -0,0 +1,11 @@
+video.canPlayType() - supported format w/o codecs parameter
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS "maybe" is "maybe"
+
+TEST COMPLETE
+spec reference
+
+
Property changes on: trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt (0 => 112937)

--- trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt	2012-04-02 21:05:09 UTC (rev 112937)
@@ -0,0 +1,11 @@
+video.canPlayType() - codecs parameter logic
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS "probably" is "probably"
+
+TEST COMPLETE
+spec referenc

[webkit-changes] [112939] trunk

2012-04-02 Thread simon . fraser

Title: [112939] trunk








Revision 112939
Author simon.fra...@apple.com
Date 2012-04-02 14:10:28 -0700 (Mon, 02 Apr 2012)


Log Message
Fix issue with reflections and composited layers
https://bugs.webkit.org/show_bug.cgi?id=82636

Source/WebCore:

Reviewed by Alexey Proskuryakov

When tearing down GraphicsLayers which referene eachother via m_replicatedLayer/m_replicaLayer,
we need to clean up the replica layer pointers.

No new tests; tested by existing compositing and repaint tests.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::setReplicatedByLayer):

LayoutTests:

Reviewed by Alexey Proskuryakov

Unskip some compositing tests that should pass now.

* platform/mac-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (112938 => 112939)

--- trunk/LayoutTests/ChangeLog	2012-04-02 21:07:37 UTC (rev 112938)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 21:10:28 UTC (rev 112939)
@@ -1,3 +1,14 @@
+2012-04-02  Simon Fraser  
+
+Fix issue with reflections and composited layers
+https://bugs.webkit.org/show_bug.cgi?id=82636
+
+Reviewed by Alexey Proskuryakov
+
+Unskip some compositing tests that should pass now.
+
+* platform/mac-wk2/Skipped:
+
 2012-04-02  Chris Rogers  
 
 Add Oscillator/WaveTable implementation and tests


Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (112938 => 112939)

--- trunk/LayoutTests/platform/mac-wk2/Skipped	2012-04-02 21:07:37 UTC (rev 112938)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2012-04-02 21:10:28 UTC (rev 112939)
@@ -314,14 +314,6 @@
 # All tests that crashed more than once on the Lion WebKit2 bots between r111865 and r111885
 accessibility/adjacent-continuations-cause-assertion-failure.html
 accessibility/contenteditable-hidden-div.html
-compositing/absolute-position-changed-in-composited-layer.html
-compositing/animation/animation-compositing.html
-compositing/culling/clear-fixed-iframe.html
-compositing/framesets/composited-frame-alignment.html
-compositing/iframes/become-composited-nested-iframes.html
-compositing/overflow/overflow-positioning.html
-compositing/self-painting-layers.html
-compositing/video/video-poster.html
 css3/filters/custom/effect-custom-combined-missing.html
 fast/workers/empty-worker-nocrash.html
 svg/custom/font-face-name-without-name-attr.svg


Modified: trunk/Source/WebCore/ChangeLog (112938 => 112939)

--- trunk/Source/WebCore/ChangeLog	2012-04-02 21:07:37 UTC (rev 112938)
+++ trunk/Source/WebCore/ChangeLog	2012-04-02 21:10:28 UTC (rev 112939)
@@ -1,3 +1,19 @@
+2012-04-02  Simon Fraser  
+
+Fix issue with reflections and composited layers
+https://bugs.webkit.org/show_bug.cgi?id=82636
+
+Reviewed by Alexey Proskuryakov
+
+When tearing down GraphicsLayers which referene eachother via m_replicatedLayer/m_replicaLayer,
+we need to clean up the replica layer pointers.
+
+No new tests; tested by existing compositing and repaint tests.
+
+* platform/graphics/GraphicsLayer.cpp:
+(WebCore::GraphicsLayer::~GraphicsLayer):
+(WebCore::GraphicsLayer::setReplicatedByLayer):
+
 2012-04-02  Chris Rogers  
 
 Add Oscillator/WaveTable implementation and tests


Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp (112938 => 112939)

--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp	2012-04-02 21:07:37 UTC (rev 112938)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp	2012-04-02 21:10:28 UTC (rev 112939)
@@ -99,6 +99,10 @@
 if (m_client)
 m_client->verifyNotPainting();
 #endif
+
+if (m_replicatedLayer)
+m_replicatedLayer->setReplicatedByLayer(0);
+
 removeAllChildren();
 removeFromParent();
 }
@@ -259,6 +263,12 @@
 
 void GraphicsLayer::setReplicatedByLayer(GraphicsLayer* layer)
 {
+if (m_replicaLayer == layer)
+return;
+
+if (m_replicaLayer)
+m_replicaLayer->setReplicatedLayer(0);
+
 if (layer)
 layer->setReplicatedLayer(this);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112940] trunk/Source

2012-04-02 Thread commit-queue

Title: [112940] trunk/Source








Revision 112940
Author commit-qu...@webkit.org
Date 2012-04-02 14:15:23 -0700 (Mon, 02 Apr 2012)


Log Message
[BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()
https://bugs.webkit.org/show_bug.cgi?id=80519

Source/WebCore:

Stop asserting in platformCachePolicyForRequest() as now it is expected
that the ResourceRequest might not have the right TargetType setup at
this time for main loads.

Patch by Lianghui Chen  on 2012-04-02
Reviewed by Rob Buis.

No new tests as no change in behaviour.

* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::platformCachePolicyForRequest):

Source/WebKit/blackberry:

Set the right TargetType for main loads if they are not already set in
dispatchWillSendRequest().

Also adjust NetworkRequest TargetType for decidePolicyForExternalLoad()
and dispatchDecidePolicyForNavigationAction() as they are called before
dispatchWillSendRequest() is called. Patch to change ResourceRequest
TargetType earlier has been rejected as in WebKit bug
https://bugs.webkit.org/show_bug.cgi?id=80713

Patch by Lianghui Chen  on 2012-04-02
Reviewed by Rob Buis.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112939 => 112940)

--- trunk/Source/WebCore/ChangeLog	2012-04-02 21:10:28 UTC (rev 112939)
+++ trunk/Source/WebCore/ChangeLog	2012-04-02 21:15:23 UTC (rev 112940)
@@ -1,3 +1,19 @@
+2012-04-02  Lianghui Chen  
+
+[BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()
+https://bugs.webkit.org/show_bug.cgi?id=80519
+
+Stop asserting in platformCachePolicyForRequest() as now it is expected
+that the ResourceRequest might not have the right TargetType setup at
+this time for main loads.
+
+Reviewed by Rob Buis.
+
+No new tests as no change in behaviour.
+
+* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
+(WebCore::platformCachePolicyForRequest):
+
 2012-04-02  Simon Fraser  
 
 Fix issue with reflections and composited layers


Modified: trunk/Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp (112939 => 112940)

--- trunk/Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp	2012-04-02 21:10:28 UTC (rev 112939)
+++ trunk/Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp	2012-04-02 21:15:23 UTC (rev 112940)
@@ -46,7 +46,6 @@
 case WebCore::ReturnCacheDataDontLoad:
 return NetworkRequest::ReturnCacheDataDontLoad;
 default:
-ASSERT_NOT_REACHED();
 return NetworkRequest::UseProtocolCachePolicy;
 }
 }


Modified: trunk/Source/WebKit/blackberry/ChangeLog (112939 => 112940)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-04-02 21:10:28 UTC (rev 112939)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-04-02 21:15:23 UTC (rev 112940)
@@ -1,3 +1,24 @@
+2012-04-02  Lianghui Chen  
+
+[BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()
+https://bugs.webkit.org/show_bug.cgi?id=80519
+
+Set the right TargetType for main loads if they are not already set in
+dispatchWillSendRequest().
+
+Also adjust NetworkRequest TargetType for decidePolicyForExternalLoad()
+and dispatchDecidePolicyForNavigationAction() as they are called before
+dispatchWillSendRequest() is called. Patch to change ResourceRequest
+TargetType earlier has been rejected as in WebKit bug
+https://bugs.webkit.org/show_bug.cgi?id=80713
+
+Reviewed by Rob Buis.
+
+* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
+(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
+(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
+
 2012-04-01  Arvid Nilsson  
 
 [BlackBerry] Simplify the code that gets accelerated compositing output onto the screen


Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (112939 => 112940)

--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp	2012-04-02 21:10:28 UTC (rev 112939)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp	2012-04-02 21:15:23 UTC (rev 112940)
@@ -72,6 +72,7 @@
 using WTF::String;
 using namespace WebCore;
 using namespace BlackBerry::WebKit;
+using BlackBerry::Platform::NetworkRequest;

[webkit-changes] [112941] trunk/LayoutTests

2012-04-02 Thread schenney

Title: [112941] trunk/LayoutTests








Revision 112941
Author schen...@chromium.org
Date 2012-04-02 14:16:03 -0700 (Mon, 02 Apr 2012)


Log Message
svg/W3C-SVG-1.1/animate-elem-80-t.svg is flaky on mac
https://bugs.webkit.org/show_bug.cgi?id=82911

Unreviewed test_expectations update.

Fixing Mac 10.7 buildbot redness by marking animate-elem-80-t.svg as flaky.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (112940 => 112941)

--- trunk/LayoutTests/ChangeLog	2012-04-02 21:15:23 UTC (rev 112940)
+++ trunk/LayoutTests/ChangeLog	2012-04-02 21:16:03 UTC (rev 112941)
@@ -1,3 +1,14 @@
+2012-04-02  Stephen Chenney  
+
+svg/W3C-SVG-1.1/animate-elem-80-t.svg is flaky on mac
+https://bugs.webkit.org/show_bug.cgi?id=82911
+
+Unreviewed test_expectations update.
+
+Fixing Mac 10.7 buildbot redness by marking animate-elem-80-t.svg as flaky.
+
+* platform/chromium/test_expectations.txt:
+
 2012-04-02  Simon Fraser  
 
 Fix issue with reflections and composited layers


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (112940 => 112941)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-04-02 21:15:23 UTC (rev 112940)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-04-02 21:16:03 UTC (rev 112941)
@@ -1189,7 +1189,7 @@
 BUGWK75968 LEOPARD SNOWLEOPARD : svg/text/text-text-05-t.svg = TEXT
 
 // Flaky on MAC
-BUGWK82911 MAC : svg/W3C-SVG-1.1/animate-elem-80-t.svg = TEXT PASS
+BUGWK82911 MAC : svg/W3C-SVG-1.1/animate-elem-80-t.svg = TEXT IMAGE+TEXT IMAGE PASS
 
 // Flaky on Linux after http://trac.webkit.org/changeset/112022
 BUGWK82217 LINUX : svg/zoom/text/zoom-foreignObject.svg = IMAGE PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112942] trunk/Source/WebCore

2012-04-02 Thread timothy_horton

Title: [112942] trunk/Source/WebCore








Revision 112942
Author timothy_hor...@apple.com
Date 2012-04-02 14:19:29 -0700 (Mon, 02 Apr 2012)


Log Message
ASSERTION FAILED: m_purgePreventCount in FontCache::getCachedFontData running svg/custom/animate-disallowed-use-element.svg
https://bugs.webkit.org/show_bug.cgi?id=81002


Reviewed by Simon Fraser.

Don't spend time rebuilding SVG text layout attributes if the document is being torn down, as
they won't be used, and can cause assertion failures in the font cache.

No new tests, as it fixes an intermittent assertion failure during document destruction.

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::willBeDestroyed):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112941 => 112942)

--- trunk/Source/WebCore/ChangeLog	2012-04-02 21:16:03 UTC (rev 112941)
+++ trunk/Source/WebCore/ChangeLog	2012-04-02 21:19:29 UTC (rev 112942)
@@ -1,3 +1,19 @@
+2012-04-02  Tim Horton  
+
+ASSERTION FAILED: m_purgePreventCount in FontCache::getCachedFontData running svg/custom/animate-disallowed-use-element.svg
+https://bugs.webkit.org/show_bug.cgi?id=81002
+
+
+Reviewed by Simon Fraser.
+
+Don't spend time rebuilding SVG text layout attributes if the document is being torn down, as
+they won't be used, and can cause assertion failures in the font cache.
+
+No new tests, as it fixes an intermittent assertion failure during document destruction.
+
+* rendering/svg/RenderSVGInlineText.cpp:
+(WebCore::RenderSVGInlineText::willBeDestroyed):
+
 2012-04-02  Lianghui Chen  
 
 [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()


Modified: trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp (112941 => 112942)

--- trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp	2012-04-02 21:16:03 UTC (rev 112941)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp	2012-04-02 21:19:29 UTC (rev 112942)
@@ -87,7 +87,8 @@
 if (affectedAttributes.isEmpty())
 return;
 
-textRenderer->rebuildLayoutAttributes(affectedAttributes);
+if (!documentBeingDestroyed())
+textRenderer->rebuildLayoutAttributes(affectedAttributes);
 }
 
 void RenderSVGInlineText::setTextInternal(PassRefPtr text)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112943] trunk/Tools

2012-04-02 Thread timothy_horton

Title: [112943] trunk/Tools








Revision 112943
Author timothy_hor...@apple.com
Date 2012-04-02 14:23:38 -0700 (Mon, 02 Apr 2012)


Log Message
[mac] LayoutTestHelper crashes if there is no main display
https://bugs.webkit.org/show_bug.cgi?id=82944


Reviewed by Simon Fraser.

If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
a null dictionary, so we shouldn't go ahead and try to read from it.

* DumpRenderTree/mac/LayoutTestHelper.m:
(installLayoutTestColorProfile):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m




Diff

Modified: trunk/Tools/ChangeLog (112942 => 112943)

--- trunk/Tools/ChangeLog	2012-04-02 21:19:29 UTC (rev 112942)
+++ trunk/Tools/ChangeLog	2012-04-02 21:23:38 UTC (rev 112943)
@@ -1,3 +1,17 @@
+2012-04-02  Tim Horton  
+
+[mac] LayoutTestHelper crashes if there is no main display
+https://bugs.webkit.org/show_bug.cgi?id=82944
+
+
+Reviewed by Simon Fraser.
+
+If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
+a null dictionary, so we shouldn't go ahead and try to read from it.
+
+* DumpRenderTree/mac/LayoutTestHelper.m:
+(installLayoutTestColorProfile):
+
 2012-04-02  Balazs Kelemen  
 
 [Qt][WK2] Set up plugin process on Unix


Modified: trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m (112942 => 112943)

--- trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m	2012-04-02 21:19:29 UTC (rev 112942)
+++ trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m	2012-04-02 21:23:38 UTC (rev 112943)
@@ -54,6 +54,13 @@
 
 if (!sUserColorProfileURL) {
 CFDictionaryRef deviceInfo = ColorSyncDeviceCopyDeviceInfo(kColorSyncDisplayDeviceClass, mainDisplayID);
+
+if (!deviceInfo) {
+NSLog(@"No display attached to system; not setting main display's color profile.");
+CFRelease(mainDisplayID);
+return;
+}
+
 CFDictionaryRef profileInfo = (CFDictionaryRef)CFDictionaryGetValue(deviceInfo, kColorSyncCustomProfiles);
 if (profileInfo) {
 sUserColorProfileURL = (CFURLRef)CFDictionaryGetValue(profileInfo, CFSTR("1"));
@@ -83,7 +90,7 @@
 CFDictionarySetValue(profileInfo, kColorSyncDeviceDefaultProfileID, profileURL);
 
 if (!ColorSyncDeviceSetCustomProfiles(kColorSyncDisplayDeviceClass, mainDisplayID, profileInfo)) {
-fprintf(stderr, "Failed to set color profile for main display! Many pixel tests may fail as a result.\n");
+NSLog(@"Failed to set color profile for main display! Many pixel tests may fail as a result.");
 
 if (sUserColorProfileURL) {
 CFRelease(sUserColorProfileURL);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112944] trunk/Tools

2012-04-02 Thread dpranke

Title: [112944] trunk/Tools








Revision 112944
Author dpra...@chromium.org
Date 2012-04-02 14:33:46 -0700 (Mon, 02 Apr 2012)


Log Message
NRWT is not printing out the builder it's uploading JSON files for
https://bugs.webkit.org/show_bug.cgi?id=82834

Reviewed by Ojan Vafai.

Handle log messages of the form log.info("%s", arg) properly ...
I didn't even know you could do that :).

* Scripts/webkitpy/layout_tests/views/metered_stream.py:
(_LogHandler.emit):
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(RegularTest.test_log_args):
(VerboseTest.test_log_args):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py
trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (112943 => 112944)

--- trunk/Tools/ChangeLog	2012-04-02 21:23:38 UTC (rev 112943)
+++ trunk/Tools/ChangeLog	2012-04-02 21:33:46 UTC (rev 112944)
@@ -1,3 +1,19 @@
+2012-04-02  Dirk Pranke  
+
+NRWT is not printing out the builder it's uploading JSON files for
+https://bugs.webkit.org/show_bug.cgi?id=82834
+
+Reviewed by Ojan Vafai.
+
+Handle log messages of the form log.info("%s", arg) properly ...
+I didn't even know you could do that :).
+
+* Scripts/webkitpy/layout_tests/views/metered_stream.py:
+(_LogHandler.emit):
+* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
+(RegularTest.test_log_args):
+(VerboseTest.test_log_args):
+
 2012-04-02  Tim Horton  
 
 [mac] LayoutTestHelper crashes if there is no main display


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py (112943 => 112944)

--- trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py	2012-04-02 21:23:38 UTC (rev 112943)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py	2012-04-02 21:33:46 UTC (rev 112944)
@@ -122,4 +122,4 @@
 self.name = LOG_HANDLER_NAME
 
 def emit(self, record):
-self._meter.writeln(record.msg, record.created)
+self._meter.writeln(record.getMessage(), record.created)


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py (112943 => 112944)

--- trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py	2012-04-02 21:23:38 UTC (rev 112943)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py	2012-04-02 21:33:46 UTC (rev 112944)
@@ -104,6 +104,9 @@
 buflist = self._log_after_update()
 self.assertEquals(buflist, ['foo\n', 'bar\n'])
 
+def test_log_args(self):
+self.logger.info('foo %s %d', 'bar', 2)
+self.assertEquals(self.buflist, ['foo bar 2\n'])
 
 class TtyTest(RegularTest):
 verbose = False
@@ -138,6 +141,11 @@
 self.assertEquals(len(buflist), 2)
 self.assertTrue(re.match('\d\d:\d\d:\d\d.\d\d\d \d+ bar\n', buflist[1]))
 
+def test_log_args(self):
+self.logger.info('foo %s %d', 'bar', 2)
+self.assertEquals(len(self.buflist), 1)
+self.assertTrue(self.buflist[0].endswith('foo bar 2\n'))
 
+
 if __name__ == '__main__':
 unittest.main()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112947] trunk/Source/JavaScriptCore

2012-04-02 Thread fpizlo

Title: [112947] trunk/Source/_javascript_Core








Revision 112947
Author fpi...@apple.com
Date 2012-04-02 14:53:12 -0700 (Mon, 02 Apr 2012)


Log Message
Activation tear-off neglects to copy the callee and scope chain, leading to crashes if we
try to create an arguments object from the activation
https://bugs.webkit.org/show_bug.cgi?id=82947


Reviewed by Gavin Barraclough.

We now copy the entire call frame header just to be sure. This is mostly perf-netural,
except for a 3.7% slow-down in V8/earley.

* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
* runtime/JSActivation.h:
(JSC::JSActivation::tearOff):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSActivation.cpp
trunk/Source/_javascript_Core/runtime/JSActivation.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (112946 => 112947)

--- trunk/Source/_javascript_Core/ChangeLog	2012-04-02 21:44:26 UTC (rev 112946)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-04-02 21:53:12 UTC (rev 112947)
@@ -1,3 +1,20 @@
+2012-04-02  Filip Pizlo  
+
+Activation tear-off neglects to copy the callee and scope chain, leading to crashes if we
+try to create an arguments object from the activation
+https://bugs.webkit.org/show_bug.cgi?id=82947
+
+
+Reviewed by Gavin Barraclough.
+
+We now copy the entire call frame header just to be sure. This is mostly perf-netural,
+except for a 3.7% slow-down in V8/earley.
+
+* runtime/JSActivation.cpp:
+(JSC::JSActivation::visitChildren):
+* runtime/JSActivation.h:
+(JSC::JSActivation::tearOff):
+
 2012-04-02  Daniel Bates  
 
 Remove Source/_javascript_Core/wtf and its empty subdirectories


Modified: trunk/Source/_javascript_Core/runtime/JSActivation.cpp (112946 => 112947)

--- trunk/Source/_javascript_Core/runtime/JSActivation.cpp	2012-04-02 21:44:26 UTC (rev 112946)
+++ trunk/Source/_javascript_Core/runtime/JSActivation.cpp	2012-04-02 21:53:12 UTC (rev 112947)
@@ -78,11 +78,15 @@
 WriteBarrier* registerArray = thisObject->m_registerArray.get();
 if (!registerArray)
 return;
-
+
 visitor.appendValues(registerArray, thisObject->m_numCapturedArgs);
 
-// Skip 'this' and call frame.
-visitor.appendValues(registerArray + CallFrame::offsetFor(thisObject->m_numCapturedArgs + 1), thisObject->m_numCapturedVars);
+// Skip 'this' and call frame, except for callee and scope chain.
+int offset = CallFrame::offsetFor(thisObject->m_numCapturedArgs + 1);
+visitor.append(registerArray + offset + RegisterFile::ScopeChain);
+visitor.append(registerArray + offset + RegisterFile::Callee);
+
+visitor.appendValues(registerArray + offset, thisObject->m_numCapturedVars);
 }
 
 inline bool JSActivation::symbolTableGet(const Identifier& propertyName, PropertySlot& slot)


Modified: trunk/Source/_javascript_Core/runtime/JSActivation.h (112946 => 112947)

--- trunk/Source/_javascript_Core/runtime/JSActivation.h	2012-04-02 21:44:26 UTC (rev 112946)
+++ trunk/Source/_javascript_Core/runtime/JSActivation.h	2012-04-02 21:53:12 UTC (rev 112947)
@@ -127,16 +127,9 @@
 OwnArrayPtr > registerArray = adoptArrayPtr(new WriteBarrier[registerArraySize]);
 WriteBarrier* registers = registerArray.get() + registerOffset;
 
-// Copy all arguments that can be captured by name or by the arguments object.
-for (int i = 0; i < m_numCapturedArgs; ++i) {
-int index = CallFrame::argumentOffset(i);
-registers[index].set(globalData, this, m_registers[index].get());
-}
-
-// Skip 'this' and call frame.
-
-// Copy all captured vars.
-for (int i = 0; i < m_numCapturedVars; ++i)
+int from = CallFrame::argumentOffset(m_numCapturedArgs - 1);
+int to = m_numCapturedVars;
+for (int i = from; i < to; ++i)
 registers[i].set(globalData, this, m_registers[i].get());
 
 setRegisters(registers, registerArray.release());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112948] trunk/Tools

2012-04-02 Thread slewis

Title: [112948] trunk/Tools








Revision 112948
Author sle...@apple.com
Date 2012-04-02 15:05:59 -0700 (Mon, 02 Apr 2012)


Log Message
2012-04-02  Stephanie Lewis  

run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
https://bugs.webkit.org/show_bug.cgi?id=82552

Reviewed by Dirk Pranke.

Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._start):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (112947 => 112948)

--- trunk/Tools/ChangeLog	2012-04-02 21:53:12 UTC (rev 112947)
+++ trunk/Tools/ChangeLog	2012-04-02 22:05:59 UTC (rev 112948)
@@ -1,3 +1,15 @@
+2012-04-02  Stephanie Lewis  
+
+run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
+https://bugs.webkit.org/show_bug.cgi?id=82552
+
+Reviewed by Dirk Pranke.
+
+Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
+
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitDriver._start):
+
 2012-04-02  Dirk Pranke  
 
 NRWT is not printing out the builder it's uploading JSON files for


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (112947 => 112948)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-04-02 21:53:12 UTC (rev 112947)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-04-02 22:05:59 UTC (rev 112948)
@@ -482,6 +482,7 @@
 environment = self._port.setup_environ_for_server(server_name)
 environment['DYLD_LIBRARY_PATH'] = self._port._build_path()
 environment['DYLD_FRAMEWORK_PATH'] = self._port._build_path()
+environment['DYLD_LIBRARY_PATH'] = self._port._build_path()
 # FIXME: We're assuming that WebKitTestRunner checks this DumpRenderTree-named environment variable.
 environment['DUMPRENDERTREE_TEMP'] = str(self._driver_tempdir)
 environment['LOCAL_RESOURCE_ROOT'] = self._port.layout_tests_dir()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112949] trunk/Source/WebCore

2012-04-02 Thread japhet

Title: [112949] trunk/Source/WebCore








Revision 112949
Author jap...@chromium.org
Date 2012-04-02 15:08:19 -0700 (Mon, 02 Apr 2012)


Log Message
Simplify main resource load start/end in FrameLoader
and DocumentLoader.
https://bugs.webkit.org/show_bug.cgi?id=82935

1. Have FrameLoader call prepareForLoadStart() on itself directly, rather
than through DocumentLoader.
2. Remove DocumentLoader::m_primaryLoadComplete, since this is basically equivalent
to m_mainResourceLoader.
3. Rename setPrimaryLoadComplete() to clearMainResourceLoader(), and only call it at
the end of the main resource load.
4. Move clearing DocumentLoader::m_mainResourceError into startLoadingMainResource(),
which leaves DocumentLoader::prepareForLoadStart() empty.

Reviewed by Adam Barth.

No new tests, refactor only.

* WebCore.exp.in:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore):
(WebCore::DocumentLoader::mainReceivedError):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
* loader/FrameLoader.h: prepareForLoadStart() is now called directly,
so make it private.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/DocumentLoader.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/FrameLoader.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112948 => 112949)

--- trunk/Source/WebCore/ChangeLog	2012-04-02 22:05:59 UTC (rev 112948)
+++ trunk/Source/WebCore/ChangeLog	2012-04-02 22:08:19 UTC (rev 112949)
@@ -1,3 +1,39 @@
+2012-04-02  Nate Chapin  
+
+Simplify main resource load start/end in FrameLoader
+and DocumentLoader.
+https://bugs.webkit.org/show_bug.cgi?id=82935
+
+1. Have FrameLoader call prepareForLoadStart() on itself directly, rather
+than through DocumentLoader.
+2. Remove DocumentLoader::m_primaryLoadComplete, since this is basically equivalent
+to m_mainResourceLoader.
+3. Rename setPrimaryLoadComplete() to clearMainResourceLoader(), and only call it at
+the end of the main resource load.
+4. Move clearing DocumentLoader::m_mainResourceError into startLoadingMainResource(),
+which leaves DocumentLoader::prepareForLoadStart() empty.
+
+Reviewed by Adam Barth.
+
+No new tests, refactor only.
+
+* WebCore.exp.in:
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::DocumentLoader):
+(WebCore):
+(WebCore::DocumentLoader::mainReceivedError):
+(WebCore::DocumentLoader::finishedLoading):
+(WebCore::DocumentLoader::clearMainResourceLoader):
+(WebCore::DocumentLoader::isLoadingInAPISense):
+(WebCore::DocumentLoader::startLoadingMainResource):
+* loader/DocumentLoader.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::commitProvisionalLoad):
+(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
+(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
+* loader/FrameLoader.h: prepareForLoadStart() is now called directly,
+so make it private.
+
 2012-04-02  Tim Horton  
 
 ASSERTION FAILED: m_purgePreventCount in FontCache::getCachedFontData running svg/custom/animate-disallowed-use-element.svg


Modified: trunk/Source/WebCore/WebCore.exp.in (112948 => 112949)

--- trunk/Source/WebCore/WebCore.exp.in	2012-04-02 22:05:59 UTC (rev 112948)
+++ trunk/Source/WebCore/WebCore.exp.in	2012-04-02 22:08:19 UTC (rev 112949)
@@ -327,7 +327,6 @@
 __ZN7WebCore14DocumentLoader13attachToFrameEv
 __ZN7WebCore14DocumentLoader15detachFromFrameEv
 __ZN7WebCore14DocumentLoader18addArchiveResourceEN3WTF10PassRefPtrINS_15ArchiveResourceEEE
-__ZN7WebCore14DocumentLoader19prepareForLoadStartEv
 __ZN7WebCore14DocumentLoader21addPlugInStreamLoaderEPNS_14ResourceLoaderE
 __ZN7WebCore14DocumentLoader22addAllArchiveResourcesEPNS_7ArchiveE
 __ZN7WebCore14DocumentLoader22cancelMainResourceLoadERKNS_13ResourceErrorE


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (112948 => 112949)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2012-04-02 22:05:59 UTC (rev 112948)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2012-04-02 22:08:19 UTC (rev 112949)
@@ -91,7 +91,6 @@
 , m_committed(false)
 , m_isStopping(false)
 , m_gotFirstByte(false)
-, m_primaryLoadComplete(false)
 , m_isClientRedirect(false)
 , m_wasOnloadHandled(false)
 , m_stopRecordingResponses(false)
@@ -188,11 +187,6 @@
 frameLoader()->client()->set

[webkit-changes] [112950] trunk/Source/WebKit2

2012-04-02 Thread andersca

Title: [112950] trunk/Source/WebKit2








Revision 112950
Author ander...@apple.com
Date 2012-04-02 15:11:51 -0700 (Mon, 02 Apr 2012)


Log Message
Call NPP_SetValue with WKNVCALayerRenderServerPort when a WKView is moved from a buffered to an unbuffered window, or vice versa
https://bugs.webkit.org/show_bug.cgi?id=82951


Reviewed by Sam Weinig.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::setLayerHostingMode):
Call Plugin::setLayerHostingMode).

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
Move WKNVCALayerRenderServerPort to the header file.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_layerHostingMode.

(WebKit::NetscapePlugin::initialize):
Set m_layerHostingMode from the parameters struct.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::compositingRenderServerPort):
Return MACH_PORT_NULL when hosted in the window server.

(WebKit::NetscapePlugin::platformPostInitialize):
Move the code that gets the layer out into a separate function, updatePluginLayer.

(WebKit::NetscapePlugin::setLayerHostingMode):
Let the plug-in know that the layer hosting mode changed and update the plug-in layer if
setting the new compositing port was successful.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (112949 => 112950)

--- trunk/Source/WebKit2/ChangeLog	2012-04-02 22:08:19 UTC (rev 112949)
+++ trunk/Source/WebKit2/ChangeLog	2012-04-02 22:11:51 UTC (rev 112950)
@@ -1,3 +1,37 @@
+2012-04-02  Anders Carlsson  
+
+Call NPP_SetValue with WKNVCALayerRenderServerPort when a WKView is moved from a buffered to an unbuffered window, or vice versa
+https://bugs.webkit.org/show_bug.cgi?id=82951
+
+
+Reviewed by Sam Weinig.
+
+* PluginProcess/mac/PluginControllerProxyMac.mm:
+(WebKit::PluginControllerProxy::setLayerHostingMode):
+Call Plugin::setLayerHostingMode).
+
+* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
+* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
+Move WKNVCALayerRenderServerPort to the header file.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::NetscapePlugin):
+Initialize m_layerHostingMode.
+
+(WebKit::NetscapePlugin::initialize):
+Set m_layerHostingMode from the parameters struct.
+
+* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
+(WebKit::NetscapePlugin::compositingRenderServerPort):
+Return MACH_PORT_NULL when hosted in the window server.
+
+(WebKit::NetscapePlugin::platformPostInitialize):
+Move the code that gets the layer out into a separate function, updatePluginLayer.
+
+(WebKit::NetscapePlugin::setLayerHostingMode):
+Let the plug-in know that the layer hosting mode changed and update the plug-in layer if
+setting the new compositing port was successful.
+
 2012-04-02  Jesus Sanchez-Palencia  
 
 [Qt][WK2] ResourceError::isCancellation() is always returning false


Modified: trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm (112949 => 112950)

--- trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm	2012-04-02 22:08:19 UTC (rev 112949)
+++ trunk/Source/WebKit2/PluginProcess/mac/PluginControllerProxyMac.mm	2012-04-02 22:11:51 UTC (rev 112950)
@@ -111,6 +111,8 @@
 void PluginControllerProxy::setLayerHostingMode(uint32_t opaqueLayerHostingMode)
 {
 LayerHostingMode layerHostingMode = static_cast(opaqueLayerHostingMode);
+
+m_plugin->setLayerHostingMode(layerHostingMode);
 updateLayerHostingContext(layerHostingMode);
 
 m_connection->connection()->send(Messages::PluginProxy::SetLayerHostingContextID(m_layerHostingContext->contextID()), m_pluginInstanceID);


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp (112949 => 112950)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp	2012-04-02 22:08:19 UTC (rev 112949)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp	2012-04-02 22:11:51 UTC (rev 112950)
@@ -417,9 +417,6 @@
 
 // WKNVSandboxFunctions = 74659 is defined in NetscapeSandboxFunctions.h
 
-// The Core Animation render server port.
-static const unsigned WKNVCALayerRenderServerPort = 71879;
-
 #endif
 
 static NPError NPN_GetValue(NPP npp, NPNVariable variable, void *val

[webkit-changes] [112951] trunk/Tools

2012-04-02 Thread abarth

Title: [112951] trunk/Tools








Revision 112951
Author aba...@webkit.org
Date 2012-04-02 15:19:32 -0700 (Mon, 02 Apr 2012)


Log Message
garden-o-matic should let you listen to audio failures
https://bugs.webkit.org/show_bug.cgi?id=82953

Reviewed by Chris Rogers.

Now that we've actually got an audio failure on the bots, we can clean
up the last stray bugs.  This patch doesn't have any tests because I'm
lame.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(.):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html (112950 => 112951)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html	2012-04-02 22:11:51 UTC (rev 112950)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html	2012-04-02 22:19:32 UTC (rev 112951)
@@ -33,6 +33,7 @@
  style-src 'self' 'unsafe-inline' file: https://ajax.googleapis.com http://fonts.googleapis.com;
  font-src http://themes.googleusercontent.com;
  img-src https://ajax.googleapis.com http://build.chromium.org file:;
+ media-src http://build.chromium.org;
  frame-src http://build.chromium.org;
  connect-src http://trac.webkit.org http://build.chromium.org http://127.0.0.1:8127">
 Garden-O-Matic


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js (112950 => 112951)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js	2012-04-02 22:11:51 UTC (rev 112950)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js	2012-04-02 22:19:32 UTC (rev 112951)
@@ -79,7 +79,7 @@
 
 // Types of tests.
 results.kImageType = 'image'
-results.kTextType = 'audio'
+results.kAudioType = 'audio'
 results.kTextType = 'text'
 // FIXME: There are more types of tests.
 


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (112950 => 112951)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js	2012-04-02 22:11:51 UTC (rev 112950)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js	2012-04-02 22:19:32 UTC (rev 112951)
@@ -78,9 +78,22 @@
 }
 });
 
+ui.results.AudioResult = base.extends('audio', {
+init: function(url)
+{
+this.className = 'audio-result';
+this.src = ""
+this.controls = 'controls';
+}
+});
+
 function constructorForResultType(type)
 {
-return (type == results.kImageType) ? ui.results.ImageResult : ui.results.TextResult;
+if (type == results.kImageType)
+return ui.results.ImageResult;
+if (type == results.kAudioType)
+return ui.results.AudioResult;
+return ui.results.TextResult;
 }
 
 ui.results.ResultsGrid = base.extends('div', {
@@ -119,6 +132,7 @@
 var resultsURLsByTypeAndKind = {};
 
 resultsURLsByTypeAndKind[results.kImageType] = {};
+resultsURLsByTypeAndKind[results.kAudioType] = {};
 resultsURLsByTypeAndKind[results.kTextType] = {};
 
 resultsURLs.forEach(function(url) {


Modified: trunk/Tools/ChangeLog (112950 => 112951)

--- trunk/Tools/ChangeLog	2012-04-02 22:11:51 UTC (rev 112950)
+++ trunk/Tools/ChangeLog	2012-04-02 22:19:32 UTC (rev 112951)
@@ -1,3 +1,19 @@
+2012-04-02  Adam Barth  
+
+garden-o-matic should let you listen to audio failures
+https://bugs.webkit.org/show_bug.cgi?id=82953
+
+Reviewed by Chris Rogers.
+
+Now that we've actually got an audio failure on the bots, we can clean
+up the last stray bugs.  This patch doesn't have any tests because I'm
+lame.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+(.):
+
 2012-04-02  Stephanie Lewis  
 
 run-webkit-tests --root fails if /usr/local/lib/li

[webkit-changes] [112835] trunk/LayoutTests

Copied: trunk/LayoutTests/platform/chromium/http/tests/security/no-popup-from-sandbox-top-expected.txt (from rev 112834, trunk/LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt) (0 => 112835)

[webkit-changes] [112916] trunk/LayoutTests

[webkit-changes] [112919] trunk

[webkit-changes] [112921] trunk/Source/WebKit2

[webkit-changes] [112924] trunk

[webkit-changes] [112925] trunk/LayoutTests

[webkit-changes] [112926] trunk/LayoutTests

[webkit-changes] [112927] trunk/LayoutTests

[webkit-changes] [112928] trunk/Source/JavaScriptCore

[webkit-changes] [112929] trunk/LayoutTests

[webkit-changes] [112930] trunk/Source/WebCore

[webkit-changes] [112931] trunk/LayoutTests

[webkit-changes] [112932] trunk/LayoutTests

[webkit-changes] [112933] trunk/Source/WebCore

[webkit-changes] [112934] trunk/LayoutTests

[webkit-changes] [112935] trunk

[webkit-changes] [112936] trunk/Source/WebCore

[webkit-changes] [112937] trunk/LayoutTests

[webkit-changes] [112939] trunk

[webkit-changes] [112940] trunk/Source

[webkit-changes] [112941] trunk/LayoutTests

[webkit-changes] [112942] trunk/Source/WebCore

[webkit-changes] [112943] trunk/Tools

[webkit-changes] [112944] trunk/Tools

[webkit-changes] [112947] trunk/Source/JavaScriptCore

[webkit-changes] [112948] trunk/Tools

[webkit-changes] [112949] trunk/Source/WebCore

[webkit-changes] [112950] trunk/Source/WebKit2

[webkit-changes] [112951] trunk/Tools

1 2 >

1 - 100 of 130 matches

Site Navigation

Mail list logo

Footer information