[webkit-changes] [114352] trunk/Source
Title: [114352] trunk/Source Revision 114352 Author carlo...@webkit.org Date 2012-04-16 23:45:27 -0700 (Mon, 16 Apr 2012) Log Message Unreviewed. Fix make distcheck issues. Source/_javascript_Core: * GNUmakefile.list.am: Add missing files. Source/WebCore: * GNUmakefile.list.am: Add missing files. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am Diff Modified: trunk/Source/_javascript_Core/ChangeLog (114351 => 114352) --- trunk/Source/_javascript_Core/ChangeLog 2012-04-17 06:40:55 UTC (rev 114351) +++ trunk/Source/_javascript_Core/ChangeLog 2012-04-17 06:45:27 UTC (rev 114352) @@ -1,3 +1,9 @@ +2012-04-16 Carlos Garcia Campos + +Unreviewed. Fix make distcheck issues. + +* GNUmakefile.list.am: Add missing files. + 2012-04-16 Sheriff Bot Unreviewed, rolling out r114309. Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (114351 => 114352) --- trunk/Source/_javascript_Core/GNUmakefile.list.am 2012-04-17 06:40:55 UTC (rev 114351) +++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2012-04-17 06:45:27 UTC (rev 114352) @@ -142,6 +142,7 @@ Source/_javascript_Core/dfg/DFGAbstractState.cpp \ Source/_javascript_Core/dfg/DFGAbstractState.h \ Source/_javascript_Core/dfg/DFGAbstractValue.h \ + Source/_javascript_Core/dfg/DFGArgumentPosition.h \ Source/_javascript_Core/dfg/DFGAssemblyHelpers.cpp \ Source/_javascript_Core/dfg/DFGAssemblyHelpers.h \ Source/_javascript_Core/dfg/DFGBasicBlock.h \ @@ -158,6 +159,7 @@ Source/_javascript_Core/dfg/DFGCorrectableJumpPoint.h \ Source/_javascript_Core/dfg/DFGCSEPhase.cpp \ Source/_javascript_Core/dfg/DFGCSEPhase.h \ + Source/_javascript_Core/dfg/DFGDoubleFormatState.h \ Source/_javascript_Core/dfg/DFGDriver.cpp \ Source/_javascript_Core/dfg/DFGDriver.h \ Source/_javascript_Core/dfg/DFGFPRInfo.h \ Modified: trunk/Source/WebCore/ChangeLog (114351 => 114352) --- trunk/Source/WebCore/ChangeLog 2012-04-17 06:40:55 UTC (rev 114351) +++ trunk/Source/WebCore/ChangeLog 2012-04-17 06:45:27 UTC (rev 114352) @@ -1,3 +1,9 @@ +2012-04-16 Carlos Garcia Campos + +Unreviewed. Fix make distcheck issues. + +* GNUmakefile.list.am: Add missing files. + 2012-04-16 Hajime Morrita insertedIntoDocument and insertedIntoTree should be unitifed. Modified: trunk/Source/WebCore/GNUmakefile.list.am (114351 => 114352) --- trunk/Source/WebCore/GNUmakefile.list.am 2012-04-17 06:40:55 UTC (rev 114351) +++ trunk/Source/WebCore/GNUmakefile.list.am 2012-04-17 06:45:27 UTC (rev 114352) @@ -871,6 +871,8 @@ $(WebCore)/html/ImageData.idl \ $(WebCore)/html/MediaController.idl \ $(WebCore)/html/MediaError.idl \ + $(WebCore)/html/MediaKeyError.idl \ + $(WebCore)/html/MediaKeyEvent.idl \ $(WebCore)/html/TextMetrics.idl \ $(WebCore)/html/TimeRanges.idl \ $(WebCore)/html/ValidityState.idl \ @@ -2433,6 +2435,9 @@ Source/WebCore/html/MediaDocument.cpp \ Source/WebCore/html/MediaDocument.h \ Source/WebCore/html/MediaError.h \ + Source/WebCore/html/MediaKeyError.h \ + Source/WebCore/html/MediaKeyEvent.cpp \ + Source/WebCore/html/MediaKeyEvent.h \ Source/WebCore/html/MediaFragmentURIParser.cpp \ Source/WebCore/html/MediaFragmentURIParser.h \ Source/WebCore/html/MicroDataItemValue.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114350] trunk
Title: [114350] trunk
Revision 114350
Author commit-qu...@webkit.org
Date 2012-04-16 23:26:53 -0700 (Mon, 16 Apr 2012)
Log Message
Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545
Patch by David Barr on 2012-04-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: http/tests/css/css-imports-redirect-cycle.html
* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
LayoutTests:
* http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
* http/tests/css/css-imports-redirect-cycle.css: Added.
* http/tests/css/css-imports-redirect-cycle.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSImportRule.cpp
Added Paths
trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle-expected.txt
trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle.css
trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle.html
Diff
Modified: trunk/LayoutTests/ChangeLog (114349 => 114350)
--- trunk/LayoutTests/ChangeLog 2012-04-17 06:22:45 UTC (rev 114349)
+++ trunk/LayoutTests/ChangeLog 2012-04-17 06:26:53 UTC (rev 114350)
@@ -1,3 +1,14 @@
+2012-04-16 David Barr
+
+Stack overflow in CSS parser caused by recursive stylesheet import
+https://bugs.webkit.org/show_bug.cgi?id=83545
+
+Reviewed by Ryosuke Niwa.
+
+* http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
+* http/tests/css/css-imports-redirect-cycle.css: Added.
+* http/tests/css/css-imports-redirect-cycle.html: Added.
+
2012-04-16 Takashi Toyoshima
Unreviewed, skip one more worker WebSocket test.
Added: trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle-expected.txt (0 => 114350)
--- trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle-expected.txt 2012-04-17 06:26:53 UTC (rev 114350)
@@ -0,0 +1 @@
+
Added: trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle.css (0 => 114350)
--- trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle.css (rev 0)
+++ trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle.css 2012-04-17 06:26:53 UTC (rev 114350)
@@ -0,0 +1 @@
+@import url("../resources/redirect.php?url=""
Added: trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle.html (0 => 114350)
--- trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle.html (rev 0)
+++ trunk/LayoutTests/http/tests/css/css-imports-redirect-cycle.html 2012-04-17 06:26:53 UTC (rev 114350)
@@ -0,0 +1,11 @@
+
+
+
+
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (114349 => 114350)
--- trunk/Source/WebCore/ChangeLog 2012-04-17 06:22:45 UTC (rev 114349)
+++ trunk/Source/WebCore/ChangeLog 2012-04-17 06:26:53 UTC (rev 114350)
@@ -1,3 +1,15 @@
+2012-04-16 David Barr
+
+Stack overflow in CSS parser caused by recursive stylesheet import
+https://bugs.webkit.org/show_bug.cgi?id=83545
+
+Reviewed by Ryosuke Niwa.
+
+Test: http/tests/css/css-imports-redirect-cycle.html
+
+* css/CSSImportRule.cpp:
+(WebCore::StyleRuleImport::requestStyleSheet):
+
2012-04-16 Kent Tamura
Rename LocalizedNumberICU.h to ICULocale.h
Modified: trunk/Source/WebCore/css/CSSImportRule.cpp (114349 => 114350)
--- trunk/Source/WebCore/css/CSSImportRule.cpp 2012-04-17 06:22:45 UTC (rev 114349)
+++ trunk/Source/WebCore/css/CSSImportRule.cpp 2012-04-17 06:26:53 UTC (rev 114350)
@@ -137,7 +137,7 @@
StyleSheetInternal* rootSheet = m_parentStyleSheet;
for (StyleSheetInternal* sheet = m_parentStyleSheet; sheet; sheet = sheet->parentStyleSheet()) {
// FIXME: This is wrong if the finalURL was updated via document::updateBaseURL.
-if (absHref == sheet->finalURL().string())
+if (absHref == sheet->finalURL().string() || absHref == sheet->originalURL())
return;
rootSheet = sheet;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114349] branches/safari-534.57-branch/Source
Title: [114349] branches/safari-534.57-branch/Source Revision 114349 Author lforsch...@apple.com Date 2012-04-16 23:22:45 -0700 (Mon, 16 Apr 2012) Log Message Versioning. Modified Paths branches/safari-534.57-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.57-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.57-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.57-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.57-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.57-branch/Source/_javascript_Core/Configurations/Version.xcconfig (114348 => 114349) --- branches/safari-534.57-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-04-17 06:11:54 UTC (rev 114348) +++ branches/safari-534.57-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-04-17 06:22:45 UTC (rev 114349) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 57; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.57-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (114348 => 114349) --- branches/safari-534.57-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-04-17 06:11:54 UTC (rev 114348) +++ branches/safari-534.57-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-04-17 06:22:45 UTC (rev 114349) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 57; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.57-branch/Source/WebCore/Configurations/Version.xcconfig (114348 => 114349) --- branches/safari-534.57-branch/Source/WebCore/Configurations/Version.xcconfig 2012-04-17 06:11:54 UTC (rev 114348) +++ branches/safari-534.57-branch/Source/WebCore/Configurations/Version.xcconfig 2012-04-17 06:22:45 UTC (rev 114349) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 57; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.57-branch/Source/WebKit/mac/Configurations/Version.xcconfig (114348 => 114349) --- branches/safari-534.57-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-04-17 06:11:54 UTC (rev 114348) +++ branches/safari-534.57-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-04-17 06:22:45 UTC (rev 114349) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 57; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.57-branch/Source/WebKit2/Configurations/Version.xcconfig (114348 => 114349) --- branches/safari-534.57-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-04-17 06:11:54 UTC (rev 114348) +++ branches/safari-534.57-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-04-17 06:22:45 UTC (rev 114349) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 57; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114348] trunk/Source/Platform
Title: [114348] trunk/Source/Platform
Revision 114348
Author tk...@chromium.org
Date 2012-04-16 23:11:54 -0700 (Mon, 16 Apr 2012)
Log Message
[Chromium] Fix Chromium-Mac build
https://bugs.webkit.org/show_bug.cgi?id=80054
* chromium/public/WebFilterOperations.h:
(WebKit): WebFilterOperation is a struct, not a class.
Modified Paths
trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebFilterOperations.h
Diff
Modified: trunk/Source/Platform/ChangeLog (114347 => 114348)
--- trunk/Source/Platform/ChangeLog 2012-04-17 05:57:20 UTC (rev 114347)
+++ trunk/Source/Platform/ChangeLog 2012-04-17 06:11:54 UTC (rev 114348)
@@ -1,3 +1,11 @@
+2012-04-16 Kent Tamura
+
+[Chromium] Fix Chromium-Mac build
+https://bugs.webkit.org/show_bug.cgi?id=80054
+
+* chromium/public/WebFilterOperations.h:
+(WebKit): WebFilterOperation is a struct, not a class.
+
2012-04-16 Dana Jansens
[chromium] Expose compositor filters to Aura through WebLayer
Modified: trunk/Source/Platform/chromium/public/WebFilterOperations.h (114347 => 114348)
--- trunk/Source/Platform/chromium/public/WebFilterOperations.h 2012-04-17 05:57:20 UTC (rev 114347)
+++ trunk/Source/Platform/chromium/public/WebFilterOperations.h 2012-04-17 06:11:54 UTC (rev 114348)
@@ -36,7 +36,7 @@
#endif
namespace WebKit {
-class WebFilterOperation;
+struct WebFilterOperation;
// An ordered set of filter operations.
class WebFilterOperations {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114347] trunk/Source
Title: [114347] trunk/Source Revision 114347 Author tk...@chromium.org Date 2012-04-16 22:57:20 -0700 (Mon, 16 Apr 2012) Log Message Rename LocalizedNumberICU.h to ICULocale.h https://bugs.webkit.org/show_bug.cgi?id=84119 Reviewed by Kentaro Hara. Source/WebCore: LocalizedNumberICU.h contains only ICULocale class. It should be named as ICULocale.h. We're going to move some functions in LocalizedDateICU.cpp and LocalizedCalendarICU.cpp to ICULocale, and add unit tests for them. * WebCore.gypi: Rename LocalizedNumberICU.h to ICULocale.h * platform/text/ICULocale.h: Renamed from Source/WebCore/platform/text/LocalizedNumberICU.h. * platform/text/LocalizedNumberICU.cpp: Rename LocalizedNumberICU.h to ICULocale.h Source/WebKit/chromium: * tests/LocalizedNumberICUTest.cpp: Rename LocalizedNumberICU.h to ICULocale.h Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/platform/text/LocalizedNumberICU.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp Added Paths trunk/Source/WebCore/platform/text/ICULocale.h Removed Paths trunk/Source/WebCore/platform/text/LocalizedNumberICU.h Diff Modified: trunk/Source/WebCore/ChangeLog (114346 => 114347) --- trunk/Source/WebCore/ChangeLog 2012-04-17 05:49:08 UTC (rev 114346) +++ trunk/Source/WebCore/ChangeLog 2012-04-17 05:57:20 UTC (rev 114347) @@ -1,3 +1,21 @@ +2012-04-16 Kent Tamura + +Rename LocalizedNumberICU.h to ICULocale.h +https://bugs.webkit.org/show_bug.cgi?id=84119 + +Reviewed by Kentaro Hara. + +LocalizedNumberICU.h contains only ICULocale class. It should be +named as ICULocale.h. We're going to move some functions in +LocalizedDateICU.cpp and LocalizedCalendarICU.cpp to ICULocale, +and add unit tests for them. + +* WebCore.gypi: Rename LocalizedNumberICU.h to ICULocale.h +* platform/text/ICULocale.h: +Renamed from Source/WebCore/platform/text/LocalizedNumberICU.h. +* platform/text/LocalizedNumberICU.cpp: +Rename LocalizedNumberICU.h to ICULocale.h + 2012-04-16 James Robinson [chromium] Move paintRenderedResultsToCanvas code into DrawingBuffer Modified: trunk/Source/WebCore/WebCore.gypi (114346 => 114347) --- trunk/Source/WebCore/WebCore.gypi 2012-04-17 05:49:08 UTC (rev 114346) +++ trunk/Source/WebCore/WebCore.gypi 2012-04-17 05:57:20 UTC (rev 114347) @@ -4449,6 +4449,7 @@ 'platform/text/BidiContext.cpp', 'platform/text/Hyphenation.cpp', 'platform/text/Hyphenation.h', +'platform/text/ICULocale.h', 'platform/text/LineEnding.cpp', 'platform/text/LocaleToScriptMapping.h', 'platform/text/LocaleToScriptMappingDefault.cpp', @@ -4460,7 +4461,6 @@ 'platform/text/LocalizedDateNone.cpp', 'platform/text/LocalizedNumber.h', 'platform/text/LocalizedNumberICU.cpp', -'platform/text/LocalizedNumberICU.h', 'platform/text/LocalizedNumberNone.cpp', 'platform/text/ParserUtilities.h', 'platform/text/QuotedPrintable.h', Copied: trunk/Source/WebCore/platform/text/ICULocale.h (from rev 114344, trunk/Source/WebCore/platform/text/LocalizedNumberICU.h) (0 => 114347) --- trunk/Source/WebCore/platform/text/ICULocale.h (rev 0) +++ trunk/Source/WebCore/platform/text/ICULocale.h 2012-04-17 05:57:20 UTC (rev 114347) @@ -0,0 +1,77 @@ +/* + * Copyright (C) 2012 Google Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are + * met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above + * copyright notice, this list of conditions and the following disclaimer + * in the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Google Inc. nor the names of its + * contributors may be used to endorse or promote products derived from + * this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + *
[webkit-changes] [114346] trunk/LayoutTests
Title: [114346] trunk/LayoutTests Revision 114346 Author toyos...@chromium.org Date 2012-04-16 22:49:08 -0700 (Mon, 16 Apr 2012) Log Message Unreviewed, skip one more worker WebSocket test. https://bugs.webkit.org/show_bug.cgi?id=84125 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (114345 => 114346) --- trunk/LayoutTests/ChangeLog 2012-04-17 05:46:55 UTC (rev 114345) +++ trunk/LayoutTests/ChangeLog 2012-04-17 05:49:08 UTC (rev 114346) @@ -1,5 +1,12 @@ 2012-04-16 Takashi Toyoshima +Unreviewed, skip one more worker WebSocket test. +https://bugs.webkit.org/show_bug.cgi?id=84125 + +* platform/chromium/test_expectations.txt: + +2012-04-16 Takashi Toyoshima + Unreviewed, remove invalid text expectation for Snow Leopard. * platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Removed. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (114345 => 114346) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-17 05:46:55 UTC (rev 114345) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-17 05:49:08 UTC (rev 114346) @@ -481,8 +481,9 @@ WONTFIX SKIP : http/tests/xmlhttprequest/workers/shared-worker-methods.html = TIMEOUT WONTFIX SKIP : http/tests/xmlhttprequest/workers/shared-worker-referer.html = TIMEOUT WONTFIX SKIP : http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html = TIMEOUT +WONTFIX SKIP : http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html = TIMEOUT WONTFIX SKIP : http/tests/websocket/tests/hixie76/workers/close-in-shared-worker.html = TIMEOUT -WONTFIX SKIP : http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html = TIMEOUT +WONTFIX SKIP : http/tests/websocket/tests/hixie76/workers/close-in-worker.html = TIMEOUT WONTFIX SKIP : http/tests/websocket/tests/hixie76/workers/shared-worker-simple.html = TIMEOUT WONTFIX SKIP : http/tests/websocket/tests/hybi/workers/close-in-shared-worker.html = TIMEOUT WONTFIX SKIP : http/tests/websocket/tests/hybi/workers/shared-worker-simple.html = TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114344] trunk/Source/WebCore
Title: [114344] trunk/Source/WebCore
Revision 114344
Author commit-qu...@webkit.org
Date 2012-04-16 22:36:46 -0700 (Mon, 16 Apr 2012)
Log Message
[chromium] Move paintRenderedResultsToCanvas code into DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=84066
Patch by James Robinson on 2012-04-16
Reviewed by Adrienne Walker.
WebGLLayerChromium used to be responsible for the readback path for software painting WebGL canvases (for
printing, etc), but this path no longer has any compositor interaction. This moves the code into
DrawingBufferChromium which is responsible for managing the front / back buffers for WebGL.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (114343 => 114344)
--- trunk/Source/WebCore/ChangeLog 2012-04-17 05:28:33 UTC (rev 114343)
+++ trunk/Source/WebCore/ChangeLog 2012-04-17 05:36:46 UTC (rev 114344)
@@ -1,3 +1,20 @@
+2012-04-16 James Robinson
+
+[chromium] Move paintRenderedResultsToCanvas code into DrawingBuffer
+https://bugs.webkit.org/show_bug.cgi?id=84066
+
+Reviewed by Adrienne Walker.
+
+WebGLLayerChromium used to be responsible for the readback path for software painting WebGL canvases (for
+printing, etc), but this path no longer has any compositor interaction. This moves the code into
+DrawingBufferChromium which is responsible for managing the front / back buffers for WebGL.
+
+* platform/graphics/chromium/DrawingBufferChromium.cpp:
+(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
+* platform/graphics/chromium/WebGLLayerChromium.cpp:
+* platform/graphics/chromium/WebGLLayerChromium.h:
+(WebGLLayerChromium):
+
2012-04-16 Dana Jansens
[chromium] Expose compositor filters to Aura through WebLayer
Modified: trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp (114343 => 114344)
--- trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp 2012-04-17 05:28:33 UTC (rev 114343)
+++ trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp 2012-04-17 05:36:46 UTC (rev 114344)
@@ -169,8 +169,26 @@
#if USE(ACCELERATED_COMPOSITING)
void DrawingBuffer::paintCompositedResultsToCanvas(CanvasRenderingContext* context)
{
-if (m_platformLayer)
-m_platformLayer->paintRenderedResultsToCanvas(context->canvas()->buffer());
+if (!m_context->makeContextCurrent() || m_context->getExtensions()->getGraphicsResetStatusARB() != GraphicsContext3D::NO_ERROR)
+return;
+
+IntSize framebufferSize = m_context->getInternalFramebufferSize();
+
+// Since we're using the same context as WebGL, we have to restore any state we change (in this case, just the framebuffer binding).
+// FIXME: The WebGLRenderingContext tracks the current framebuffer binding, it would be slightly more efficient to use this value
+// rather than querying it off of the context.
+GC3Dint previousFramebuffer = 0;
+m_context->getIntegerv(GraphicsContext3D::FRAMEBUFFER_BINDING, &previousFramebuffer);
+
+Platform3DObject framebuffer = m_context->createFramebuffer();
+m_context->bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, framebuffer);
+m_context->framebufferTexture2D(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::COLOR_ATTACHMENT0, GraphicsContext3D::TEXTURE_2D, frontColorBuffer(), 0);
+
+Extensions3DChromium* extensions = static_cast(m_context->getExtensions());
+extensions->paintFramebufferToCanvas(framebuffer, framebufferSize.width(), framebufferSize.height(), !m_context->getContextAttributes().premultipliedAlpha, context->canvas()->buffer());
+m_context->deleteFramebuffer(framebuffer);
+
+m_context->bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, previousFramebuffer);
}
#endif
Modified: trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp (114343 => 114344)
--- trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp 2012-04-17 05:28:33 UTC (rev 114343)
+++ trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp 2012-04-17 05:36:46 UTC (rev 114344)
@@ -98,31 +98,6 @@
textureLayer->setPremultipliedAlpha(m_premultipliedAlpha);
}
-bool WebGLLayerChromium::paintRenderedResultsToCanvas(ImageBuffer* imageBuffer)
-{
-if (!m_drawingBuffer || !drawsContent())
-return false;
-
-IntSize framebufferSize = context()->getInternalFramebufferSize();
-
-// Since we're using the same context as WebGL, we have t
[webkit-changes] [114343] trunk/Source
Title: [114343] trunk/Source Revision 114343 Author dan...@chromium.org Date 2012-04-16 22:28:33 -0700 (Mon, 16 Apr 2012) Log Message [chromium] Expose compositor filters to Aura through WebLayer https://bugs.webkit.org/show_bug.cgi?id=80054 Reviewed by James Robinson. Source/Platform: * chromium/public/WebFilterOperation.h: Added. (WebKit): (WebFilterOperation): (WebKit::WebFilterOperation::WebFilterOperation): (WebBasicColorMatrixFilterOperation): (WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation): (WebBasicComponentTransferFilterOperation): (WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation): (WebBlurFilterOperation): (WebKit::WebBlurFilterOperation::WebBlurFilterOperation): (WebDropShadowFilterOperation): (WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation): * chromium/public/WebFilterOperations.h: Added. (WebKit): (WebFilterOperations): * chromium/public/WebLayer.h: (WebKit): (WebLayer): Source/WebCore: Adds WebFilterOperation that wraps WebCore::FilterOperation and WebFilterOperations that wraps WebCore::FilterOperations. We add support for most of the FilterOperation subclasses, and allow the user to set the WebFilterOperations for both layer content filters and background filters. * WebCore.gypi: * platform/chromium/support/WebFilterOperation.cpp: Added. (WebKit): (WebKit::WebBasicColorMatrixFilterOperation::toFilterOperation): (WebKit::WebBasicComponentTransferFilterOperation::toFilterOperation): (WebKit::WebBlurFilterOperation::toFilterOperation): (WebKit::WebDropShadowFilterOperation::toFilterOperation): * platform/chromium/support/WebFilterOperations.cpp: Added. (WebKit): (WebKit::WebFilterOperations::WebFilterOperations): (WebKit::WebFilterOperations::append): (WebKit::WebFilterOperations::clear): (WebKit::WebFilterOperations::toFilterOperations): Source/WebKit/chromium: * WebKit.gyp: * src/WebLayer.cpp: (WebKit::WebLayer::setFilters): (WebKit): (WebKit::WebLayer::setBackgroundFilters): Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/chromium/public/WebLayer.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp trunk/Source/WebKit/chromium/src/WebLayer.cpp Added Paths trunk/Source/Platform/chromium/public/WebFilterOperation.h trunk/Source/Platform/chromium/public/WebFilterOperations.h trunk/Source/WebCore/platform/chromium/support/WebFilterOperation.cpp trunk/Source/WebCore/platform/chromium/support/WebFilterOperations.cpp Diff Modified: trunk/Source/Platform/ChangeLog (114342 => 114343) --- trunk/Source/Platform/ChangeLog 2012-04-17 05:08:58 UTC (rev 114342) +++ trunk/Source/Platform/ChangeLog 2012-04-17 05:28:33 UTC (rev 114343) @@ -1,3 +1,29 @@ +2012-04-16 Dana Jansens + +[chromium] Expose compositor filters to Aura through WebLayer +https://bugs.webkit.org/show_bug.cgi?id=80054 + +Reviewed by James Robinson. + +* chromium/public/WebFilterOperation.h: Added. +(WebKit): +(WebFilterOperation): +(WebKit::WebFilterOperation::WebFilterOperation): +(WebBasicColorMatrixFilterOperation): +(WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation): +(WebBasicComponentTransferFilterOperation): +(WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation): +(WebBlurFilterOperation): +(WebKit::WebBlurFilterOperation::WebBlurFilterOperation): +(WebDropShadowFilterOperation): +(WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation): +* chromium/public/WebFilterOperations.h: Added. +(WebKit): +(WebFilterOperations): +* chromium/public/WebLayer.h: +(WebKit): +(WebLayer): + 2012-04-13 James Robinson [chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it Added: trunk/Source/Platform/chromium/public/WebFilterOperation.h (0 => 114343) --- trunk/Source/Platform/chromium/public/WebFilterOperation.h (rev 0) +++ trunk/Source/Platform/chromium/public/WebFilterOperation.h 2012-04-17 05:28:33 UTC (rev 114343) @@ -0,0 +1,126 @@ +/* + * Copyright (C) 2012 Google Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * + * THIS SOF
[webkit-changes] [114342] trunk/Source/WebCore
Title: [114342] trunk/Source/WebCore
Revision 114342
Author commit-qu...@webkit.org
Date 2012-04-16 22:08:58 -0700 (Mon, 16 Apr 2012)
Log Message
Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106
Patch by Andrei Burago on 2012-04-16
Reviewed by David Levin.
No new tests. The repro steps require using Chrome notifications on Win.
* page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114341 => 114342)
--- trunk/Source/WebCore/ChangeLog 2012-04-17 05:08:25 UTC (rev 114341)
+++ trunk/Source/WebCore/ChangeLog 2012-04-17 05:08:58 UTC (rev 114342)
@@ -1,3 +1,15 @@
+2012-04-16 Andrei Burago
+
+Auto-sized frames may be taller than expected
+https://bugs.webkit.org/show_bug.cgi?id=84106
+
+Reviewed by David Levin.
+
+No new tests. The repro steps require using Chrome notifications on Win.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::autoSizeIfEnabled):
+
2012-04-13 James Robinson
[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it
Modified: trunk/Source/WebCore/page/FrameView.cpp (114341 => 114342)
--- trunk/Source/WebCore/page/FrameView.cpp 2012-04-17 05:08:25 UTC (rev 114341)
+++ trunk/Source/WebCore/page/FrameView.cpp 2012-04-17 05:08:58 UTC (rev 114342)
@@ -2433,12 +2433,13 @@
if (!m_didRunAutosize)
resize(frameRect().width(), m_minAutoSize.height());
+IntSize size = frameRect().size();
+
// Do the resizing twice. The first time is basically a rough calculation using the preferred width
// which may result in a height change during the second iteration.
for (int i = 0; i < 2; i++) {
// Update various sizes including contentsSize, scrollHeight, etc.
document->updateLayoutIgnorePendingStylesheets();
-IntSize size = frameRect().size();
int width = documentView->minPreferredLogicalWidth();
int height = documentRenderBox->scrollHeight();
IntSize newSize(width, height);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114341] trunk/LayoutTests
Title: [114341] trunk/LayoutTests
Revision 114341
Author toyos...@chromium.org
Date 2012-04-16 22:08:25 -0700 (Mon, 16 Apr 2012)
Log Message
Unreviewed, remove invalid text expectation for Snow Leopard.
* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (114340 => 114341)
--- trunk/LayoutTests/ChangeLog 2012-04-17 05:07:06 UTC (rev 114340)
+++ trunk/LayoutTests/ChangeLog 2012-04-17 05:08:25 UTC (rev 114341)
@@ -1,5 +1,11 @@
2012-04-16 Takashi Toyoshima
+Unreviewed, remove invalid text expectation for Snow Leopard.
+
+* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
+
+2012-04-16 Takashi Toyoshima
+
Unreviewed, remove useless text expectation for WinXP
* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
Deleted: trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt (114340 => 114341)
--- trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt 2012-04-17 05:07:06 UTC (rev 114340)
+++ trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt 2012-04-17 05:08:25 UTC (rev 114341)
@@ -1,19 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x360
- RenderBlock {HTML} at (0,0) size 800x360
-RenderBody {BODY} at (8,16) size 784x336
- RenderBlock {P} at (0,0) size 784x18
-RenderText {#text} at (0,0) size 379x18
- text run at (0,0) width 379: "The top left box, and all reflections should be rotated 45deg."
- RenderBlock {DIV} at (0,300) size 784x36
-RenderText {#text} at (0,0) size 782x36
- text run at (0,0) width 782: "FAIL - \"webkitTransform.0\" property for \"animated\" element at 0.5s expected: 0.76 but saw: matrix(0.4525653383899637,"
- text run at (0,18) width 478: "0.8917312456609209, -0.8917312456609209, 0.4525653383899637, 0, 0)"
-RenderBR {BR} at (478,18) size 0x18
-layer at (28,54) size 122x242
- RenderBlock {DIV} at (20,38) size 122x242 [border: (1px solid #00)]
-layer at (39,65) size 104x104
- RenderBlock {DIV} at (11,11) size 104x104 [border: (2px solid #FF)]
-layer at (51,77) size 80x80
- RenderBlock {DIV} at (12,12) size 80x80 [bgcolor=#008000]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114340] tags/Safari-534.57.1/
Title: [114340] tags/Safari-534.57.1/ Revision 114340 Author lforsch...@apple.com Date 2012-04-16 22:07:06 -0700 (Mon, 16 Apr 2012) Log Message New tag. Added Paths tags/Safari-534.57.1/ Diff Property changes: tags/Safari-534.57.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114339] trunk/LayoutTests
Title: [114339] trunk/LayoutTests
Revision 114339
Author toyos...@chromium.org
Date 2012-04-16 21:32:38 -0700 (Mon, 16 Apr 2012)
Log Message
Unreviewed, remove useless text expectation for WinXP
* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (114338 => 114339)
--- trunk/LayoutTests/ChangeLog 2012-04-17 04:09:44 UTC (rev 114338)
+++ trunk/LayoutTests/ChangeLog 2012-04-17 04:32:38 UTC (rev 114339)
@@ -1,5 +1,11 @@
2012-04-16 Takashi Toyoshima
+Unreviewed, remove useless text expectation for WinXP
+
+* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
+
+2012-04-16 Takashi Toyoshima
+
Unreviewed, skip a worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125
Deleted: trunk/LayoutTests/platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt (114338 => 114339)
--- trunk/LayoutTests/platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt 2012-04-17 04:09:44 UTC (rev 114338)
+++ trunk/LayoutTests/platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt 2012-04-17 04:32:38 UTC (rev 114339)
@@ -1,19 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x356
- RenderBlock {HTML} at (0,0) size 800x356
-RenderBody {BODY} at (8,16) size 784x332
- RenderBlock {P} at (0,0) size 784x20
-RenderText {#text} at (0,0) size 593x19
- text run at (0,0) width 593: "Animation on original and reflection should both be paused half way through, giving 45deg rotation."
- RenderBlock {DIV} at (0,292) size 784x40
-RenderText {#text} at (0,0) size 645x39
- text run at (0,0) width 536: "FAIL - \"webkitTransform.0\" property for \"inner\" element at 0.5s expected: 0.76 but saw:"
- text run at (0,20) width 645: "matrix(0.0002220446049250313, 1, -1, 0.0002220446049250313, 0, 0)"
-RenderBR {BR} at (645,20) size 0x19
-layer at (108,56) size 122x232
- RenderBlock {DIV} at (100,40) size 122x232 [border: (1px solid #00)]
-layer at (119,67) size 100x100
- RenderBlock {DIV} at (11,11) size 100x100 [bgcolor=#008000]
-RenderText {#text} at (33,1) size 34x76
- text run at (33,1) width 34: "1"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114338] trunk/LayoutTests
Title: [114338] trunk/LayoutTests Revision 114338 Author toyos...@chromium.org Date 2012-04-16 21:09:44 -0700 (Mon, 16 Apr 2012) Log Message Unreviewed, skip a worker WebSocket test. https://bugs.webkit.org/show_bug.cgi?id=84125 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (114337 => 114338) --- trunk/LayoutTests/ChangeLog 2012-04-17 03:58:18 UTC (rev 114337) +++ trunk/LayoutTests/ChangeLog 2012-04-17 04:09:44 UTC (rev 114338) @@ -1,3 +1,10 @@ +2012-04-16 Takashi Toyoshima + +Unreviewed, skip a worker WebSocket test. +https://bugs.webkit.org/show_bug.cgi?id=84125 + +* platform/chromium/test_expectations.txt: + 2012-04-16 Sheriff Bot Unreviewed, rolling out r114285. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (114337 => 114338) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-17 03:58:18 UTC (rev 114337) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-17 04:09:44 UTC (rev 114338) @@ -482,6 +482,7 @@ WONTFIX SKIP : http/tests/xmlhttprequest/workers/shared-worker-referer.html = TIMEOUT WONTFIX SKIP : http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html = TIMEOUT WONTFIX SKIP : http/tests/websocket/tests/hixie76/workers/close-in-shared-worker.html = TIMEOUT +WONTFIX SKIP : http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html = TIMEOUT WONTFIX SKIP : http/tests/websocket/tests/hixie76/workers/shared-worker-simple.html = TIMEOUT WONTFIX SKIP : http/tests/websocket/tests/hybi/workers/close-in-shared-worker.html = TIMEOUT WONTFIX SKIP : http/tests/websocket/tests/hybi/workers/shared-worker-simple.html = TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114337] trunk/Source/WebKit/chromium
Title: [114337] trunk/Source/WebKit/chromium
Revision 114337
Author commit-qu...@webkit.org
Date 2012-04-16 20:58:18 -0700 (Mon, 16 Apr 2012)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot on 2012-04-16
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (114336 => 114337)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-17 03:42:46 UTC (rev 114336)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-17 03:58:18 UTC (rev 114337)
@@ -1,3 +1,9 @@
+2012-04-16 Sheriff Bot
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2012-04-16 Kent Tamura
[Chromium] Move popup location detection code from WebViewImpl to WebPagePopupImpl
Modified: trunk/Source/WebKit/chromium/DEPS (114336 => 114337)
--- trunk/Source/WebKit/chromium/DEPS 2012-04-17 03:42:46 UTC (rev 114336)
+++ trunk/Source/WebKit/chromium/DEPS 2012-04-17 03:58:18 UTC (rev 114337)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '132093'
+ 'chromium_rev': '132474'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114336] trunk/Source/WebKit/chromium
Title: [114336] trunk/Source/WebKit/chromium
Revision 114336
Author tk...@chromium.org
Date 2012-04-16 20:42:46 -0700 (Mon, 16 Apr 2012)
Log Message
[Chromium] Move popup location detection code from WebViewImpl to WebPagePopupImpl
https://bugs.webkit.org/show_bug.cgi?id=84116
Reviewed by Kentaro Hara.
This makes no behavior change. Just move some code.
To fix Bug 84007, WebPagePopupImpl needs to know if the popup is
above the target element or below the target element.
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::init): Move some code from WebViewImpl::openPagePopup().
* src/WebPagePopupImpl.h:
(WebPagePopupImpl): Rename an argument name.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::openPagePopup): Move some code to WebPagePopupImpl::init().
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp
trunk/Source/WebKit/chromium/src/WebPagePopupImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (114335 => 114336)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-17 03:04:11 UTC (rev 114335)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-17 03:42:46 UTC (rev 114336)
@@ -1,3 +1,21 @@
+2012-04-16 Kent Tamura
+
+[Chromium] Move popup location detection code from WebViewImpl to WebPagePopupImpl
+https://bugs.webkit.org/show_bug.cgi?id=84116
+
+Reviewed by Kentaro Hara.
+
+This makes no behavior change. Just move some code.
+To fix Bug 84007, WebPagePopupImpl needs to know if the popup is
+above the target element or below the target element.
+
+* src/WebPagePopupImpl.cpp:
+(WebKit::WebPagePopupImpl::init): Move some code from WebViewImpl::openPagePopup().
+* src/WebPagePopupImpl.h:
+(WebPagePopupImpl): Rename an argument name.
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::openPagePopup): Move some code to WebPagePopupImpl::init().
+
2012-04-13 James Robinson
[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it
Modified: trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp (114335 => 114336)
--- trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp 2012-04-17 03:04:11 UTC (rev 114335)
+++ trunk/Source/WebKit/chromium/src/WebPagePopupImpl.cpp 2012-04-17 03:42:46 UTC (rev 114336)
@@ -31,6 +31,7 @@
#include "config.h"
#include "WebPagePopupImpl.h"
+#include "Chrome.h"
#include "EmptyClients.h"
#include "FileChooser.h"
#include "FocusController.h"
@@ -44,9 +45,11 @@
#include "WebInputEvent.h"
#include "WebInputEventConversion.h"
#include "WebPagePopup.h"
+#include "WebViewImpl.h"
#include "WebWidgetClient.h"
using namespace WebCore;
+using namespace std;
namespace WebKit {
@@ -133,13 +136,22 @@
ASSERT(!m_page);
}
-bool WebPagePopupImpl::init(WebViewImpl* webView, PagePopupClient* popupClient, const IntRect& boundsInScreen)
+bool WebPagePopupImpl::init(WebViewImpl* webView, PagePopupClient* popupClient, const IntRect& originBoundsInRootView)
{
ASSERT(webView);
ASSERT(popupClient);
m_webView = webView;
m_popupClient = popupClient;
+WebSize rootViewSize = webView->size();
+IntSize popupSize = popupClient->contentSize();
+IntRect popupBoundsInRootView(IntPoint(max(0, originBoundsInRootView.x()), max(0, originBoundsInRootView.maxY())), popupSize);
+if (popupBoundsInRootView.maxY() > rootViewSize.height)
+popupBoundsInRootView.setY(max(0, originBoundsInRootView.y() - popupSize.height()));
+if (popupBoundsInRootView.maxX() > rootViewSize.width)
+popupBoundsInRootView.setX(max(0, rootViewSize.width - popupSize.width()));
+IntRect boundsInScreen = webView->page()->chrome()->rootViewToScreen(popupBoundsInRootView);
+
m_widgetClient->setWindowRect(boundsInScreen);
m_windowRectInScreen = boundsInScreen;
if (!initPage())
Modified: trunk/Source/WebKit/chromium/src/WebPagePopupImpl.h (114335 => 114336)
--- trunk/Source/WebKit/chromium/src/WebPagePopupImpl.h 2012-04-17 03:04:11 UTC (rev 114335)
+++ trunk/Source/WebKit/chromium/src/WebPagePopupImpl.h 2012-04-17 03:42:46 UTC (rev 114336)
@@ -56,7 +56,7 @@
WTF_MAKE_FAST_ALLOCATED;
public:
-bool init(WebViewImpl*, WebCore::PagePopupClient*, const WebCore::IntRect& boundsInScreen);
+bool init(WebViewImpl*, WebCore::PagePopupClient*, const WebCore::IntRect& originBoundsInRootView);
bool handleKeyEvent(const WebCore::PlatformKeyboardEvent&);
void closePopup();
WebWidgetClient* widgetClient() const { return m_widgetClient; }
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (114335 => 114336)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-04-17 03:04:11 UTC (rev 114335)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-04-17 03:42:46 UTC (rev 114336)
@@ -1207,14 +1207,7 @@
WebWidget* popupWidget = m_client->createPopupM
[webkit-changes] [114335] trunk/Source
Title: [114335] trunk/Source Revision 114335 Author jam...@google.com Date 2012-04-16 20:04:11 -0700 (Mon, 16 Apr 2012) Log Message [chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it https://bugs.webkit.org/show_bug.cgi?id=83963 Reviewed by Adrienne Walker. Source/Platform: Adds a compositor layer type for video, WebVideoLayer, and a WebVideoProvider interface. * Platform.gypi: * chromium/public/WebContentLayer.h: (WebContentLayer): * chromium/public/WebLayer.h: (WebLayer): (WebKit::WebLayer::unwrap): * chromium/public/WebVideoFrameProvider.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameProvider.h. (WebKit): (WebVideoFrameProvider): (WebKit::WebVideoFrameProvider::~WebVideoFrameProvider): (Client): * chromium/public/WebVideoLayer.h: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp. (WebCore): (WebKit): (WebVideoLayer): (WebKit::WebVideoLayer::WebVideoLayer): (WebKit::WebVideoLayer::~WebVideoLayer): Source/WebCore: Converts VideoLayerChromium / CCVideoLayerImpl to use a Platform WebVideoFrameProvider interface instead of a WebCore VideoFrameProvider. * WebCore.gypi: * platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::create): (WebCore::VideoLayerChromium::VideoLayerChromium): * platform/graphics/chromium/VideoLayerChromium.h: (WebKit): (WebCore): (VideoLayerChromium): * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: (WebCore::CCVideoLayerImpl::CCVideoLayerImpl): * platform/graphics/chromium/cc/CCVideoLayerImpl.h: (WebCore::CCVideoLayerImpl::create): (CCVideoLayerImpl): Source/WebKit/chromium: Adds implementation of WebVideoLayer and ports WebMediaPlayerClientImpl over to using it. WebMediaPlayerClientImpl still exposes a WebCore::VideoLayerChromium* to the compositor via the platformLayer() interface, but this is temporary until we can change the PlatformLayer typedef over to WebLayer. * WebKit.gyp: * src/WebContentLayer.cpp: * src/WebLayer.cpp: (WebKit::WebLayer::invalidate): (WebKit): * src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::readyStateChanged): (WebKit::WebMediaPlayerClientImpl::repaint): (WebKit::WebMediaPlayerClientImpl::setOpaque): (WebKit::WebMediaPlayerClientImpl::platformLayer): (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): (WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient): (WebKit::WebMediaPlayerClientImpl::supportsType): * src/WebMediaPlayerClientImpl.h: (WebMediaPlayerClientImpl): * src/WebVideoLayer.cpp: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp. (WebKit): (WebKit::WebVideoLayer::create): (WebKit::WebVideoLayer::WebVideoLayer): (WebKit::WebVideoLayer::active): Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/Platform.gypi trunk/Source/Platform/chromium/public/WebContentLayer.h trunk/Source/Platform/chromium/public/WebLayer.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gyp trunk/Source/WebKit/chromium/src/WebContentLayer.cpp trunk/Source/WebKit/chromium/src/WebLayer.cpp trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h Added Paths trunk/Source/Platform/chromium/public/WebVideoFrameProvider.h trunk/Source/Platform/chromium/public/WebVideoLayer.h trunk/Source/WebKit/chromium/src/WebVideoLayer.cpp Removed Paths trunk/Source/WebCore/platform/graphics/chromium/VideoFrameProvider.h Diff Modified: trunk/Source/Platform/ChangeLog (114334 => 114335) --- trunk/Source/Platform/ChangeLog 2012-04-17 02:55:40 UTC (rev 114334) +++ trunk/Source/Platform/ChangeLog 2012-04-17 03:04:11 UTC (rev 114335) @@ -1,3 +1,30 @@ +2012-04-13 James Robinson + +[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it +https://bugs.webkit.org/show_bug.cgi?id=83963 + +Reviewed by Adrienne Walker. + +Adds a compositor layer type for video, WebVideoLayer, and a WebVideoProvider interface. + +* Platform.gypi: +* chromium/public/WebContentLayer.h: +(WebContentLayer): +* chromium/public/WebLayer.h: +(WebLayer): +(WebKit::WebLayer::unwrap): +* chromium/public/WebVideoFrameProvider.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameProvider.h. +(WebKit): +(WebVideoFrameProvider): +(WebKit::WebVideoFrameProvider::~WebVideoFrameProvider): +(Client): +* chromium/public/WebVideoLayer.h: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp. +(WebCore): +(WebKi
[webkit-changes] [114334] trunk
Title: [114334] trunk
Revision 114334
Author commit-qu...@webkit.org
Date 2012-04-16 19:55:40 -0700 (Mon, 16 Apr 2012)
Log Message
[Shadow DOM] InsertionPoint should have isActive() member function.
https://bugs.webkit.org/show_bug.cgi?id=82010
Patch by Takashi Sakamoto on 2012-04-16
Reviewed by Hajime Morita.
This patch adds isActive public member function to InsertionPoint and
makes InsertionPoint elements consider whether active or not.
If an InsertionPoint is inactive, the element is not shadow boundary
and is needed to be rendered.
c.f. https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#dfn-active-insertion-point
Test: update existing tests, i.e.
LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic.html and
LayoutTests/fast/dom/shadow/shadow-contents-fallback.html
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::isActive):
A new public method for checking whether an insertion point is active or inactive.
If active, returns true. Otherwise, false.
(WebCore::InsertionPoint::isShadowBoundary):
Make the method consider whether an insertin point is active or inactive.
(WebCore::InsertionPoint::rendererIsNeeded):
Changed to return true If an insertion point is inactive.
(WebCore::InsertionPoint::attach):
Changed to call only HTMLElement::attach If an insertion point is inactive.
(WebCore::InsertionPoint::detach):
Changed to call only HTMLElement::detach If an insertion point is inactive.
* html/shadow/InsertionPoint.h:
(InsertionPoint):
Added isActive public method.
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
Changed to take into account an insertion point's activeness when parent is an insertion point.
(WebCore::NodeRenderingContext::firstRendererOf):
(WebCore::NodeRenderingContext::lastRendererOf):
Changed to take into account an insertion point's activeness.
Modified Paths
trunk/LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic.html
trunk/LayoutTests/fast/dom/shadow/shadow-contents-fallback.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/NodeRenderingContext.cpp
trunk/Source/WebCore/html/shadow/InsertionPoint.cpp
trunk/Source/WebCore/html/shadow/InsertionPoint.h
Diff
Modified: trunk/LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic.html (114333 => 114334)
--- trunk/LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic.html 2012-04-17 02:15:18 UTC (rev 114333)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic.html 2012-04-17 02:55:40 UTC (rev 114334)
@@ -342,7 +342,7 @@
function testContentInContent(callIfDone) {
document.getElementById('expect-container').innerHTML =
-"{SHADOW: S1S2}";
+"{SHADOW: CONTENT 2 FALLBACK}";
var target = document.createElement('div');
target.appendChild(createSpanWithText('S1'));
@@ -373,7 +373,7 @@
function testContentInContentFallback(callIfDone) {
document.getElementById('expect-container').innerHTML =
-"{SHADOW: CONTENT 2 FALLBACK}";
+"{SHADOW: CONTENT 2 FALLBACK}";
var target = document.createElement('div');
target.appendChild(createSpanWithText('S1'));
@@ -404,7 +404,7 @@
function testContentInContentFallbackDirect(callIfDone) {
document.getElementById('expect-container').innerHTML =
-"CONTENT 2 FALLBACK";
+"CONTENT 2 FALLBACK";
var target = document.createElement('div');
target.appendChild(createSpanWithText('S1'));
Modified: trunk/LayoutTests/fast/dom/shadow/shadow-contents-fallback.html (114333 => 114334)
--- trunk/LayoutTests/fast/dom/shadow/shadow-contents-fallback.html 2012-04-17 02:15:18 UTC (rev 114333)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-contents-fallback.html 2012-04-17 02:55:40 UTC (rev 114334)
@@ -267,7 +267,7 @@
document.getElementById('actual-container').appendChild(target);
document.getElementById('expect-container').innerHTML =
-"{SHADOW: S1S2}";
+"{SHADOW: CONTENT 2 FALLBACK}";
}
function testContentInContentFallback() {
@@ -290,7 +290,7 @@
document.getElementById('actual-container').appendChild(target);
document.getElementById('expect-container').innerHTML =
-"{SHADOW: CONTENT 2 FALLBACK}";
+"{SHADOW: CONTENT 2 FALLBACK}";
}
function testContentInContentFallbackWithDisplayNone() {
@@ -316,7 +316,7 @@
document.getElementById('actual-container').appendChild(target);
document.getElementById('expect-container').innerHTML =
-"{SHADOW: CONTENT 2 FALLBACK}";
+"{SHADOW: CONTENT 2 FALLBACK}";
}
function testContentInContentFallbackDirect() {
@@ -337,7 +337,7 @@
document.getElementById('actual-container').appendChild(target);
document.getElementById('expect-container').innerHTML =
-"CONTENT 2 FALLBACK";
+"CONTENT 2 FALLBACK";
}
var testFuncs = [
Modified: trunk/Source/WebCore/ChangeLog (114333 => 114334)
--- trunk/Source/WebCore/ChangeLog 2012-04-17 0
[webkit-changes] [114333] trunk/Source/WebCore
Title: [114333] trunk/Source/WebCore
Revision 114333
Author morr...@google.com
Date 2012-04-16 19:15:18 -0700 (Mon, 16 Apr 2012)
Log Message
Type tags in NodeFlags could be compressed
https://bugs.webkit.org/show_bug.cgi?id=79299
Because existing node flags which indicate the class of each node
are mutually exclusive, these flags can be represented as a enum.
This patch introduces Node::NodeTypeTag to turn these flags into a
enum, and embeds it into Node::m_nodeFlags.
Reviewed by Antti Koivisto.
No new tests. No bahavior change.
* dom/Node.cpp:
(WebCore):
* dom/Node.h:
(WebCore):
(Node):
(WebCore::Node::typeTag):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):
(WebCore::Node::isContainerNode):
(WebCore::Node::isElementNode):
(WebCore::Node::isStyledElement):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isShadowRoot):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (114332 => 114333)
--- trunk/Source/WebCore/ChangeLog 2012-04-17 02:02:26 UTC (rev 114332)
+++ trunk/Source/WebCore/ChangeLog 2012-04-17 02:15:18 UTC (rev 114333)
@@ -1,3 +1,33 @@
+2012-04-16 MORITA Hajime
+
+Type tags in NodeFlags could be compressed
+https://bugs.webkit.org/show_bug.cgi?id=79299
+
+Because existing node flags which indicate the class of each node
+are mutually exclusive, these flags can be represented as a enum.
+This patch introduces Node::NodeTypeTag to turn these flags into a
+enum, and embeds it into Node::m_nodeFlags.
+
+Reviewed by Antti Koivisto.
+
+No new tests. No bahavior change.
+
+* dom/Node.cpp:
+(WebCore):
+* dom/Node.h:
+(WebCore):
+(Node):
+(WebCore::Node::typeTag):
+(WebCore::Node::parentNode):
+(WebCore::Node::parentNodeGuaranteedHostFree):
+(WebCore::Node::isContainerNode):
+(WebCore::Node::isElementNode):
+(WebCore::Node::isStyledElement):
+(WebCore::Node::isTextNode):
+(WebCore::Node::isHTMLElement):
+(WebCore::Node::isSVGElement):
+(WebCore::Node::isShadowRoot):
+
2012-04-16 Sheriff Bot
Unreviewed, rolling out r114285.
Modified: trunk/Source/WebCore/dom/Node.cpp (114332 => 114333)
--- trunk/Source/WebCore/dom/Node.cpp 2012-04-17 02:02:26 UTC (rev 114332)
+++ trunk/Source/WebCore/dom/Node.cpp 2012-04-17 02:15:18 UTC (rev 114333)
@@ -128,6 +128,8 @@
namespace WebCore {
+COMPILE_ASSERT(Node::TypeTagSize <= 8, Node_tag_should_fit_in_bits);
+
using namespace HTMLNames;
bool Node::isSupported(const String& feature, const String& version)
Modified: trunk/Source/WebCore/dom/Node.h (114332 => 114333)
--- trunk/Source/WebCore/dom/Node.h 2012-04-17 02:02:26 UTC (rev 114332)
+++ trunk/Source/WebCore/dom/Node.h 2012-04-17 02:15:18 UTC (rev 114333)
@@ -90,7 +90,7 @@
typedef int ExceptionCode;
-const int nodeStyleChangeShift = 21;
+const int nodeStyleChangeShift = 17;
// SyntheticStyleChange means that we need to go through the entire style change logic even though
// no style property has actually changed. It is used to restructure the tree when, for instance,
@@ -200,21 +200,20 @@
virtual bool isActiveNode() const { return false; }
// Other methods (not part of DOM)
+bool isContainerNode() const;
+bool isElementNode() const;
+bool isStyledElement() const;
+bool isTextNode() const;
+bool isHTMLElement() const;
+bool isSVGElement() const;
+bool isShadowRoot() const;
-bool isElementNode() const { return getFlag(IsElementFlag); }
-bool isContainerNode() const { return getFlag(IsContainerFlag); }
-bool isTextNode() const { return getFlag(IsTextFlag); }
-bool isHTMLElement() const { return getFlag(IsHTMLFlag); }
-bool isSVGElement() const { return getFlag(IsSVGFlag); }
-
virtual bool isMediaControlElement() const { return false; }
virtual bool isMediaControls() const { return false; }
-bool isStyledElement() const { return getFlag(IsStyledElementFlag); }
virtual bool isFrameOwnerElement() const { return false; }
virtual bool isAttributeNode() const { return false; }
virtual bool isCharacterDataNode() const { return false; }
bool isDocumentNode() const;
-bool isShadowRoot() const { return getFlag(IsShadowRootFlag); }
bool inNamedFlow() const { return getFlag(InNamedFlowFlag); }
Node* shadowAncestorNode() const;
@@ -629,72 +628,79 @@
bool hasScopedHTMLStyleChild() const;
size_t numberOfScopedHTMLStyleChildren() const;
+enum NodeTypeTag {
+TypeTagOther = 0, // Node subclasses other than listed below.
+TypeTagText, // Text
+TypeTagContainerNode, // ContainerNode subclasses other than Element and ShadowRoot.
+TypeTagElement, //
[webkit-changes] [114332] trunk/Tools
Title: [114332] trunk/Tools Revision 114332 Author k...@webkit.org Date 2012-04-16 19:02:26 -0700 (Mon, 16 Apr 2012) Log Message [GTK] Use configure instead of autogen.sh for gtk+ https://bugs.webkit.org/show_bug.cgi?id=84112 Rubber-stamped by Martin Robinson. * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection; we don't want to depend on that for now, so run configure instead - we can, since we are using a tarball Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (114331 => 114332) --- trunk/Tools/ChangeLog 2012-04-17 01:06:57 UTC (rev 114331) +++ trunk/Tools/ChangeLog 2012-04-17 02:02:26 UTC (rev 114332) @@ -1,5 +1,16 @@ 2012-04-16 Gustavo Noronha Silva +[GTK] Use configure instead of autogen.sh for gtk+ +https://bugs.webkit.org/show_bug.cgi?id=84112 + +Rubber-stamped by Martin Robinson. + +* gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection; +we don't want to depend on that for now, so run configure instead - we +can, since we are using a tarball + +2012-04-16 Gustavo Noronha Silva + Unreviewed, rolling out r114322. http://trac.webkit.org/changeset/114322 https://bugs.webkit.org/show_bug.cgi?id=84096 Modified: trunk/Tools/gtk/jhbuild.modules (114331 => 114332) --- trunk/Tools/gtk/jhbuild.modules 2012-04-17 01:06:57 UTC (rev 114331) +++ trunk/Tools/gtk/jhbuild.modules 2012-04-17 02:02:26 UTC (rev 114332) @@ -112,7 +112,7 @@ md5sum="2a70627ffd9f43c52c04cc0b05fe359f"/> - +autogenargs="--disable-introspection"> ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114331] releases/WebKitGTK/webkit-1.8/Source/WebCore
Title: [114331] releases/WebKitGTK/webkit-1.8/Source/WebCore
Revision 114331
Author mrobin...@webkit.org
Date 2012-04-16 18:06:57 -0700 (Mon, 16 Apr 2012)
Log Message
Merging r110150
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ContainerNode.cpp
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog (114330 => 114331)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-17 00:55:31 UTC (rev 114330)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/ChangeLog 2012-04-17 01:06:57 UTC (rev 114331)
@@ -1,3 +1,19 @@
+2012-04-16 Adam Barth
+
+ContainerNode::insertedIntoDocument and removedFromDocument use weak iteration patterns
+https://bugs.webkit.org/show_bug.cgi?id=80569
+
+Reviewed by Ryosuke Niwa.
+
+This patch moves ContainerNode::insertedIntoDocument and
+removedFromDocument to using a better iteration pattern in which we
+collect all the nodes we're planning to iterate into a vector and then
+iterate over them.
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::insertedIntoDocument):
+(WebCore::ContainerNode::removedFromDocument):
+
2012-04-03 Dominik Röttsches
Soup HTTP backend does not send Content-Length in certain cases
Modified: releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ContainerNode.cpp (114330 => 114331)
--- releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ContainerNode.cpp 2012-04-17 00:55:31 UTC (rev 114330)
+++ releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ContainerNode.cpp 2012-04-17 01:06:57 UTC (rev 114331)
@@ -809,13 +809,17 @@
Node::insertedIntoDocument();
insertedIntoTree(false);
-for (RefPtr child = m_firstChild; child; child = child->nextSibling()) {
-// Guard against mutation during re-parenting.
-if (!inDocument()) // Check for self being removed from document while reparenting.
+NodeVector children;
+collectNodes(this, children);
+for (size_t i = 0; i < children.size(); ++i) {
+// If we have been removed from the document during this loop, then
+// we don't want to tell the rest of our children that they've been
+// inserted into the document because they haven't.
+if (!inDocument())
break;
-if (child->parentNode() != this) // Check for child being removed from subtree while reparenting.
-break;
-child->insertedIntoDocument();
+if (children[i]->parentNode() != this)
+continue;
+children[i]->insertedIntoDocument();
}
}
@@ -826,8 +830,19 @@
document()->setCSSTarget(0);
clearInDocument();
removedFromTree(false);
-for (Node* child = m_firstChild; child; child = child->nextSibling())
-child->removedFromDocument();
+
+NodeVector children;
+collectNodes(this, children);
+for (size_t i = 0; i < children.size(); ++i) {
+// If we have been added to the document during this loop, then we
+// don't want to tell the rest of our children that they've been
+// removed from the document because they haven't.
+if (inDocument())
+break;
+if (children[i]->parentNode() != this)
+continue;
+children[i]->removedFromDocument();
+}
}
void ContainerNode::insertedIntoTree(bool deep)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114330] trunk
Title: [114330] trunk
Revision 114330
Author commit-qu...@webkit.org
Date 2012-04-16 17:55:31 -0700 (Mon, 16 Apr 2012)
Log Message
Unreviewed, rolling out r114285.
http://trac.webkit.org/changeset/114285
https://bugs.webkit.org/show_bug.cgi?id=84107
broke fast/media/media-query-list-08.html in Mac (Requested by
andersca on #webkit).
Patch by Sheriff Bot on 2012-04-16
Source/WebCore:
* dom/Document.cpp:
(WebCore::Document::styleSelectorChanged):
* dom/Document.h:
(Document):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
LayoutTests:
* fast/media/media-query-list-08-expected.txt: Removed.
* fast/media/media-query-list-08.html: Removed.
* platform/qt/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/FrameView.cpp
Removed Paths
trunk/LayoutTests/fast/media/media-query-list-08-expected.txt
trunk/LayoutTests/fast/media/media-query-list-08.html
Diff
Modified: trunk/LayoutTests/ChangeLog (114329 => 114330)
--- trunk/LayoutTests/ChangeLog 2012-04-17 00:48:17 UTC (rev 114329)
+++ trunk/LayoutTests/ChangeLog 2012-04-17 00:55:31 UTC (rev 114330)
@@ -1,3 +1,16 @@
+2012-04-16 Sheriff Bot
+
+Unreviewed, rolling out r114285.
+http://trac.webkit.org/changeset/114285
+https://bugs.webkit.org/show_bug.cgi?id=84107
+
+broke fast/media/media-query-list-08.html in Mac (Requested by
+andersca on #webkit).
+
+* fast/media/media-query-list-08-expected.txt: Removed.
+* fast/media/media-query-list-08.html: Removed.
+* platform/qt/Skipped:
+
2012-04-16 Anders Carlsson
Add two flaky tests in fast/profiler.
Deleted: trunk/LayoutTests/fast/media/media-query-list-08-expected.txt (114329 => 114330)
--- trunk/LayoutTests/fast/media/media-query-list-08-expected.txt 2012-04-17 00:48:17 UTC (rev 114329)
+++ trunk/LayoutTests/fast/media/media-query-list-08-expected.txt 2012-04-17 00:55:31 UTC (rev 114330)
@@ -1,6 +0,0 @@
-Test the MediaQueryList interface: http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface.
-
-Testing viewport related callbacks
-
-PASS
-
Deleted: trunk/LayoutTests/fast/media/media-query-list-08.html (114329 => 114330)
--- trunk/LayoutTests/fast/media/media-query-list-08.html 2012-04-17 00:48:17 UTC (rev 114329)
+++ trunk/LayoutTests/fast/media/media-query-list-08.html 2012-04-17 00:55:31 UTC (rev 114330)
@@ -1,34 +0,0 @@
-
-
-Test CSSOM View module: MediaQueryList interface
-
-if (window.layoutTestController) {
-layoutTestController.dumpAsText();
-layoutTestController.waitUntilDone();
-}
-
-function log(m) {
-document.getElementById('results').innerHTML += m + '
';
-}
-
-function callback(query) {
-log("PASS");
-if (window.layoutTestController)
-layoutTestController.notifyDone();
-}
-
-function runTests()
-{
-window.matchMedia("(max-width: 250px)").addListener(callback);
-window.resizeTo(200, 300);
-}
-
-
-
-
-Test the MediaQueryList interface: http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface.
-Testing viewport related callbacks
-
-
-
-
Modified: trunk/LayoutTests/platform/qt/Skipped (114329 => 114330)
--- trunk/LayoutTests/platform/qt/Skipped 2012-04-17 00:48:17 UTC (rev 114329)
+++ trunk/LayoutTests/platform/qt/Skipped 2012-04-17 00:55:31 UTC (rev 114330)
@@ -1108,9 +1108,6 @@
fast/canvas/2d.backingStorePixelRatio.html
fast/canvas/2d.imageDataHD.html
-# window.resizeTo() does not trigger a relayout in our DumpRenderTree
-fast/media/media-query-list-08.html
-
# This requires didClearWindowObjectForFrameInIsolatedWorld foo in FrameLoaderClient
http/tests/security/isolatedWorld/didClearWindowObject.html
# This needs more investigation
Modified: trunk/Source/WebCore/ChangeLog (114329 => 114330)
--- trunk/Source/WebCore/ChangeLog 2012-04-17 00:48:17 UTC (rev 114329)
+++ trunk/Source/WebCore/ChangeLog 2012-04-17 00:55:31 UTC (rev 114330)
@@ -1,3 +1,19 @@
+2012-04-16 Sheriff Bot
+
+Unreviewed, rolling out r114285.
+http://trac.webkit.org/changeset/114285
+https://bugs.webkit.org/show_bug.cgi?id=84107
+
+broke fast/media/media-query-list-08.html in Mac (Requested by
+andersca on #webkit).
+
+* dom/Document.cpp:
+(WebCore::Document::styleSelectorChanged):
+* dom/Document.h:
+(Document):
+* page/FrameView.cpp:
+(WebCore::FrameView::layout):
+
2012-04-16 Nate Chapin
Remove unused variable CachedResourceLoader::m_loadFinishing
Modified: trunk/Source/WebCore/dom/Document.cpp (114329 => 114330)
--- trunk/Source/WebCore/dom/Document.cpp 2012-04-17 00:48:17 UTC (rev 114329)
+++ trunk/Source/WebCore/dom/Document.cpp 2012-04-17 00:55:31 UTC (rev 114330)
@@ -3145,12 +3145,6 @@
[webkit-changes] [114329] trunk/Source/WebKit/chromium
Title: [114329] trunk/Source/WebKit/chromium
Revision 114329
Author commit-qu...@webkit.org
Date 2012-04-16 17:48:17 -0700 (Mon, 16 Apr 2012)
Log Message
Fix WebKit style violations in Chromium WebMediaPlayer.h & WebMediaPlayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=84046
Patch by Aaron Colwell on 2012-04-16
Reviewed by Darin Fisher.
* WebKit.gyp:
* public/WebMediaPlayer.h:
(WebKit):
* public/WebMediaPlayerClient.h:
* public/WebTimeRange.h: Copied from Source/WebKit/chromium/public/WebMediaPlayerClient.h.
(WebKit):
(WebKit::WebTimeRange::WebTimeRange):
(WebTimeRange):
* src/AssertMatchingEnums.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/WebMediaPlayer.h
trunk/Source/WebKit/chromium/public/WebMediaPlayerClient.h
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
Added Paths
trunk/Source/WebKit/chromium/public/WebTimeRange.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (114328 => 114329)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-04-17 00:47:31 UTC (rev 114328)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-04-17 00:48:17 UTC (rev 114329)
@@ -1,3 +1,20 @@
+2012-04-16 Aaron Colwell
+
+Fix WebKit style violations in Chromium WebMediaPlayer.h & WebMediaPlayerClient.h
+https://bugs.webkit.org/show_bug.cgi?id=84046
+
+Reviewed by Darin Fisher.
+
+* WebKit.gyp:
+* public/WebMediaPlayer.h:
+(WebKit):
+* public/WebMediaPlayerClient.h:
+* public/WebTimeRange.h: Copied from Source/WebKit/chromium/public/WebMediaPlayerClient.h.
+(WebKit):
+(WebKit::WebTimeRange::WebTimeRange):
+(WebTimeRange):
+* src/AssertMatchingEnums.cpp:
+
2012-04-16 Terry Anderson
[chromium] Allow WebGestureEvent to store four floating point values
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (114328 => 114329)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2012-04-17 00:47:31 UTC (rev 114328)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2012-04-17 00:48:17 UTC (rev 114329)
@@ -272,6 +272,7 @@
'public/WebTextFieldDecoratorClient.h',
'public/WebTextInputType.h',
'public/WebTextRun.h',
+'public/WebTimeRange.h',
'public/WebURLLoaderOptions.h',
'public/WebUserMediaClient.h',
'public/WebUserMediaRequest.h',
Modified: trunk/Source/WebKit/chromium/public/WebMediaPlayer.h (114328 => 114329)
--- trunk/Source/WebKit/chromium/public/WebMediaPlayer.h 2012-04-17 00:47:31 UTC (rev 114328)
+++ trunk/Source/WebKit/chromium/public/WebMediaPlayer.h 2012-04-17 00:48:17 UTC (rev 114329)
@@ -31,9 +31,9 @@
#ifndef WebMediaPlayer_h
#define WebMediaPlayer_h
+#include "WebTimeRange.h"
#include "WebVideoFrame.h"
#include "platform/WebCanvas.h"
-#include "platform/WebVector.h"
namespace WebKit {
@@ -46,61 +46,76 @@
struct WebRect;
struct WebSize;
-struct WebTimeRange {
-WebTimeRange() : start(0), end(0) {}
-WebTimeRange(float s, float e) : start(s), end(e) {}
-
-float start;
-float end;
-};
-
-typedef WebVector WebTimeRanges;
-
class WebMediaPlayer {
public:
enum NetworkState {
-Empty,
-Idle,
-Loading,
-Loaded,
-FormatError,
-NetworkError,
-DecodeError,
+NetworkStateEmpty,
+NetworkStateIdle,
+NetworkStateLoading,
+NetworkStateLoaded,
+NetworkStateFormatError,
+NetworkStateNetworkError,
+NetworkStateDecodeError,
+Empty = NetworkStateEmpty,
+Idle = NetworkStateIdle,
+Loading = NetworkStateLoading,
+Loaded = NetworkStateLoaded,
+FormatError = NetworkStateFormatError,
+NetworkError = NetworkStateNetworkError,
+DecodeError = NetworkStateDecodeError,
};
enum ReadyState {
-HaveNothing,
-HaveMetadata,
-HaveCurrentData,
-HaveFutureData,
-HaveEnoughData,
+ReadyStateHaveNothing,
+ReadyStateHaveMetadata,
+ReadyStateHaveCurrentData,
+ReadyStateHaveFutureData,
+ReadyStateHaveEnoughData,
+HaveNothing = ReadyStateHaveNothing,
+HaveMetadata = ReadyStateHaveMetadata,
+HaveCurrentData = ReadyStateHaveCurrentData,
+HaveFutureData = ReadyStateHaveFutureData,
+HaveEnoughData = ReadyStateHaveEnoughData,
};
enum MovieLoadType {
-Unknown,
-Download,
-StoredStream,
-LiveStream,
+MovieLoadTypeUnknown,
+MovieLoadTypeDownload,
+MovieLoadTypeStoredStream,
+MovieLoadTypeLiveStream,
+Unknown = MovieLoadTypeUnknown,
+Download = MovieLoadTypeDownload,
+StoredStream = MovieLoadTypeStoredStream,
+LiveStream = MovieLoadTypeLiveStream,
};
enum Preload {
-None,
-MetaData
[webkit-changes] [114328] trunk/Source/WebCore
Title: [114328] trunk/Source/WebCore
Revision 114328
Author jap...@chromium.org
Date 2012-04-16 17:47:31 -0700 (Mon, 16 Apr 2012)
Log Message
Remove unused variable CachedResourceLoader::m_loadFinishing
https://bugs.webkit.org/show_bug.cgi?id=84100
Reviewed by Alexey Proskuryakov.
No new tests, removing dead code.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::decrementRequestCount):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
(WebCore::CachedResourceLoader::requestCount):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (114327 => 114328)
--- trunk/Source/WebCore/ChangeLog 2012-04-17 00:35:09 UTC (rev 114327)
+++ trunk/Source/WebCore/ChangeLog 2012-04-17 00:47:31 UTC (rev 114328)
@@ -1,3 +1,20 @@
+2012-04-16 Nate Chapin
+
+Remove unused variable CachedResourceLoader::m_loadFinishing
+https://bugs.webkit.org/show_bug.cgi?id=84100
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests, removing dead code.
+
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::CachedResourceLoader):
+(WebCore::CachedResourceLoader::loadDone):
+(WebCore::CachedResourceLoader::decrementRequestCount):
+* loader/cache/CachedResourceLoader.h:
+(CachedResourceLoader):
+(WebCore::CachedResourceLoader::requestCount):
+
2012-04-16 Andreas Kling
Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue().
Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (114327 => 114328)
--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2012-04-17 00:35:09 UTC (rev 114327)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp 2012-04-17 00:47:31 UTC (rev 114328)
@@ -117,7 +117,6 @@
, m_requestCount(0)
, m_garbageCollectDocumentResourcesTimer(this, &CachedResourceLoader::garbageCollectDocumentResourcesTimerFired)
, m_autoLoadImages(true)
-, m_loadFinishing(false)
, m_allowStaleResources(false)
{
}
@@ -681,8 +680,6 @@
void CachedResourceLoader::loadDone()
{
-m_loadFinishing = false;
-
RefPtr protect(m_document);
if (frame())
frame()->loader()->loadDone();
@@ -747,13 +744,6 @@
--m_requestCount;
ASSERT(m_requestCount > -1);
}
-
-int CachedResourceLoader::requestCount()
-{
-if (m_loadFinishing)
- return m_requestCount + 1;
-return m_requestCount;
-}
void CachedResourceLoader::preload(CachedResource::Type type, ResourceRequest& request, const String& charset, bool referencedFromBody)
{
Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.h (114327 => 114328)
--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.h 2012-04-17 00:35:09 UTC (rev 114327)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.h 2012-04-17 00:47:31 UTC (rev 114328)
@@ -104,13 +104,11 @@
Document* document() const { return m_document; }
void removeCachedResource(CachedResource*) const;
-
-void loadFinishing() { m_loadFinishing = true; }
void loadDone();
void incrementRequestCount(const CachedResource*);
void decrementRequestCount(const CachedResource*);
-int requestCount();
+int requestCount() const { return m_requestCount; }
bool isPreloaded(const String& urlString) const;
void clearPreloads();
@@ -151,9 +149,8 @@
Timer m_garbageCollectDocumentResourcesTimer;
-//29 bits left
+// 30 bits left
bool m_autoLoadImages : 1;
-bool m_loadFinishing : 1;
bool m_allowStaleResources : 1;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114326] trunk/Tools
Title: [114326] trunk/Tools Revision 114326 Author k...@webkit.org Date 2012-04-16 17:35:01 -0700 (Mon, 16 Apr 2012) Log Message Unreviewed, rolling out r114322. http://trac.webkit.org/changeset/114322 https://bugs.webkit.org/show_bug.cgi?id=84096 Didn't make the debug bot happy, so back out * gtk/jhbuild.modules: Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (114325 => 114326) --- trunk/Tools/ChangeLog 2012-04-17 00:28:11 UTC (rev 114325) +++ trunk/Tools/ChangeLog 2012-04-17 00:35:01 UTC (rev 114326) @@ -1,5 +1,15 @@ 2012-04-16 Gustavo Noronha Silva +Unreviewed, rolling out r114322. +http://trac.webkit.org/changeset/114322 +https://bugs.webkit.org/show_bug.cgi?id=84096 + +Didn't make the debug bot happy, so back out + +* gtk/jhbuild.modules: + +2012-04-16 Gustavo Noronha Silva + [GTK] Try to fix debug bot by adding gobject-introspection to the build https://bugs.webkit.org/show_bug.cgi?id=84096 Modified: trunk/Tools/gtk/jhbuild.modules (114325 => 114326) --- trunk/Tools/gtk/jhbuild.modules 2012-04-17 00:28:11 UTC (rev 114325) +++ trunk/Tools/gtk/jhbuild.modules 2012-04-17 00:35:01 UTC (rev 114326) @@ -116,7 +116,6 @@ autogenargs="--disable-introspection"> - @@ -138,16 +137,6 @@ md5sum="c5fa76fbf9184d20dfb04af66b598190"/> - - - - - - - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114327] trunk/Source/WebKit2
Title: [114327] trunk/Source/WebKit2
Revision 114327
Author beid...@apple.com
Date 2012-04-16 17:35:09 -0700 (Mon, 16 Apr 2012)
Log Message
Followup to http://trac.webkit.org/changeset/114323
For more correctness, actually include an autorelease pool instead of cleverly trying to avoid its use.
Reviewed by Mark Rowe.
* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (114326 => 114327)
--- trunk/Source/WebKit2/ChangeLog 2012-04-17 00:35:01 UTC (rev 114326)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-17 00:35:09 UTC (rev 114327)
@@ -1,5 +1,16 @@
2012-04-16 Brady Eidson
+Followup to http://trac.webkit.org/changeset/114323
+
+For more correctness, actually include an autorelease pool instead of cleverly trying to avoid its use.
+
+Reviewed by Mark Rowe.
+
+* PluginProcess/mac/PluginProcessMainMac.mm:
+(WebKit::PluginProcessMain):
+
+2012-04-16 Brady Eidson
+
Leak in Plugin Process when launched 32-bit
Reviewed by Jessie Berlin.
Modified: trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm (114326 => 114327)
--- trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm 2012-04-17 00:35:01 UTC (rev 114326)
+++ trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm 2012-04-17 00:35:09 UTC (rev 114327)
@@ -89,9 +89,15 @@
WKSetDefaultLocalization(cfLocalization.get());
#if defined(__i386__)
-NSDictionary *defaults = [[NSDictionary alloc] initWithObjectsAndKeys:[NSNumber numberWithBool:YES], @"AppleMagnifiedMode", nil];
-[[NSUserDefaults standardUserDefaults] registerDefaults:defaults];
-[defaults release];
+{
+NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
+
+NSDictionary *defaults = [[NSDictionary alloc] initWithObjectsAndKeys:[NSNumber numberWithBool:YES], @"AppleMagnifiedMode", nil];
+[[NSUserDefaults standardUserDefaults] registerDefaults:defaults];
+[defaults release];
+
+[pool drain];
+}
#endif
#if !SHOW_CRASH_REPORTER
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114325] trunk/Source/WebCore
Title: [114325] trunk/Source/WebCore
Revision 114325
Author kl...@webkit.org
Date 2012-04-16 17:28:11 -0700 (Mon, 16 Apr 2012)
Log Message
Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue().
Reviewed by Antti Koivisto.
Remove the 'context style sheet' argument to value parsing.
It was only ever used to grab at the CSSValuePool back when they were per-Document.
* css/CSSParser.h:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceValue):
* css/CSSValuePool.h:
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFaceValue):
* html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParser.h
trunk/Source/WebCore/css/CSSValuePool.cpp
trunk/Source/WebCore/css/CSSValuePool.h
trunk/Source/WebCore/html/HTMLFontElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114324 => 114325)
--- trunk/Source/WebCore/ChangeLog 2012-04-17 00:21:46 UTC (rev 114324)
+++ trunk/Source/WebCore/ChangeLog 2012-04-17 00:28:11 UTC (rev 114325)
@@ -1,3 +1,22 @@
+2012-04-16 Andreas Kling
+
+Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue().
+
+
+Reviewed by Antti Koivisto.
+
+Remove the 'context style sheet' argument to value parsing.
+It was only ever used to grab at the CSSValuePool back when they were per-Document.
+
+* css/CSSParser.h:
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseFontFaceValue):
+* css/CSSValuePool.h:
+* css/CSSValuePool.cpp:
+(WebCore::CSSValuePool::createFontFaceValue):
+* html/HTMLFontElement.cpp:
+(WebCore::HTMLFontElement::collectStyleForAttribute):
+
2012-04-16 Dana Jansens
[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
Modified: trunk/Source/WebCore/css/CSSParser.cpp (114324 => 114325)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-04-17 00:21:46 UTC (rev 114324)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-04-17 00:28:11 UTC (rev 114325)
@@ -940,10 +940,10 @@
return true;
}
-PassRefPtr CSSParser::parseFontFaceValue(const AtomicString& string, StyleSheetInternal* contextStyleSheet)
+PassRefPtr CSSParser::parseFontFaceValue(const AtomicString& string)
{
RefPtr dummyStyle = StylePropertySet::create();
-if (!parseValue(dummyStyle.get(), CSSPropertyFontFamily, string, false, CSSQuirksMode, contextStyleSheet))
+if (!parseValue(dummyStyle.get(), CSSPropertyFontFamily, string, false, CSSQuirksMode, 0))
return 0;
return static_pointer_cast(dummyStyle->getPropertyCSSValue(CSSPropertyFontFamily));
}
Modified: trunk/Source/WebCore/css/CSSParser.h (114324 => 114325)
--- trunk/Source/WebCore/css/CSSParser.h 2012-04-17 00:21:46 UTC (rev 114324)
+++ trunk/Source/WebCore/css/CSSParser.h 2012-04-17 00:28:11 UTC (rev 114325)
@@ -76,7 +76,7 @@
static bool parseValue(StylePropertySet*, CSSPropertyID, const String&, bool important, CSSParserMode, StyleSheetInternal*);
static bool parseColor(RGBA32& color, const String&, bool strict = false);
static bool parseSystemColor(RGBA32& color, const String&, Document*);
-static PassRefPtr parseFontFaceValue(const AtomicString&, StyleSheetInternal* contextStyleSheet);
+static PassRefPtr parseFontFaceValue(const AtomicString&);
PassRefPtr parseValidPrimitive(int ident, CSSParserValue*);
bool parseDeclaration(StylePropertySet*, const String&, RefPtr*, StyleSheetInternal* contextStyleSheet);
PassOwnPtr parseMediaQuery(const String&);
Modified: trunk/Source/WebCore/css/CSSValuePool.cpp (114324 => 114325)
--- trunk/Source/WebCore/css/CSSValuePool.cpp 2012-04-17 00:21:46 UTC (rev 114324)
+++ trunk/Source/WebCore/css/CSSValuePool.cpp 2012-04-17 00:28:11 UTC (rev 114325)
@@ -134,7 +134,7 @@
return value;
}
-PassRefPtr CSSValuePool::createFontFaceValue(const AtomicString& string, StyleSheetInternal* contextStyleSheet)
+PassRefPtr CSSValuePool::createFontFaceValue(const AtomicString& string)
{
// Just wipe out the cache and start rebuilding if it gets too big.
const int maximumFontFaceCacheSize = 128;
@@ -143,7 +143,7 @@
RefPtr& value = m_fontFaceValueCache.add(string, 0).iterator->second;
if (!value)
-value = CSSParser::parseFontFaceValue(string, contextStyleSheet);
+value = CSSParser::parseFontFaceValue(string);
return value;
}
Modified: trunk/Source/WebCore/css/CSSValuePool.h (114324 => 114325)
--- trunk/Source/WebCore/css/CSSValuePool.h 2012-04-17 00:21:46 UTC (rev 114324)
+++ trunk/Source/WebCore/css/CSSValuePool.h 2012-04-17 00:28:11 UTC (rev 114325)
@@ -36,11 +36,10 @@
namespace WebCore {
class CSSValueList;
-class StyleSheetInternal;
class CSSValuePool {
public:
-PassRefPtr createFontFaceValue(const AtomicString&, StyleSheetInter
[webkit-changes] [114324] trunk/Source/WebCore/ChangeLog
Title: [114324] trunk/Source/WebCore/ChangeLog Revision 114324 Author dan...@chromium.org Date 2012-04-16 17:21:46 -0700 (Mon, 16 Apr 2012) Log Message [chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result https://bugs.webkit.org/show_bug.cgi?id=83543 Reviewed by Adrienne Walker. It should not be possible to make a rect in layer space that is clipped by the camera but for which the screen space transform gives a rectilinear output. But use consistent methods for checking that the result remains enclosed within the actual pixels. One day when clipped is true, we can find an interior axis-aligned rect within the clipped result, and checking clipped explicitly makes this more clear. Covered by existing tests. * platform/graphics/chromium/cc/CCOcclusionTracker.cpp: (WebCore::computeOcclusionBehindLayer): (WebCoremarkOccludedBehindLayer): Modified Paths trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/ChangeLog (114323 => 114324) --- trunk/Source/WebCore/ChangeLog 2012-04-17 00:21:10 UTC (rev 114323) +++ trunk/Source/WebCore/ChangeLog 2012-04-17 00:21:46 UTC (rev 114324) @@ -1,3 +1,25 @@ +2012-04-16 Dana Jansens + +[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result +https://bugs.webkit.org/show_bug.cgi?id=83543 + +Reviewed by Adrienne Walker. + +It should not be possible to make a rect in layer space that is clipped +by the camera but for which the screen space transform gives a +rectilinear output. But use consistent methods for checking that the +result remains enclosed within the actual pixels. + +One day when clipped is true, we can find an interior axis-aligned rect +within the clipped result, and checking clipped explicitly makes this +more clear. + +Covered by existing tests. + +* platform/graphics/chromium/cc/CCOcclusionTracker.cpp: +(WebCore::computeOcclusionBehindLayer): +(WebCoremarkOccludedBehindLayer): + 2012-04-16 Erik Arvidsson [V8] Don't delete the per context data until the V8IsolatedContext is deleted ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114323] trunk/Source/WebKit2
Title: [114323] trunk/Source/WebKit2 Revision 114323 Author beid...@apple.com Date 2012-04-16 17:21:10 -0700 (Mon, 16 Apr 2012) Log Message Leak in Plugin Process when launched 32-bit Reviewed by Jessie Berlin. * PluginProcess/mac/PluginProcessMainMac.mm: (WebKit::PluginProcessMain): alloc/init an NSDictionary then release it, instead of leaking an autoreleased one. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (114322 => 114323) --- trunk/Source/WebKit2/ChangeLog 2012-04-17 00:18:15 UTC (rev 114322) +++ trunk/Source/WebKit2/ChangeLog 2012-04-17 00:21:10 UTC (rev 114323) @@ -1,3 +1,12 @@ +2012-04-16 Brady Eidson + + Leak in Plugin Process when launched 32-bit + +Reviewed by Jessie Berlin. + +* PluginProcess/mac/PluginProcessMainMac.mm: +(WebKit::PluginProcessMain): alloc/init an NSDictionary then release it, instead of leaking an autoreleased one. + 2012-04-16 Anders Carlsson Nightly Back/Forward no longer calls plug-in's NPP_NewStream Modified: trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm (114322 => 114323) --- trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm 2012-04-17 00:18:15 UTC (rev 114322) +++ trunk/Source/WebKit2/PluginProcess/mac/PluginProcessMainMac.mm 2012-04-17 00:21:10 UTC (rev 114323) @@ -89,8 +89,9 @@ WKSetDefaultLocalization(cfLocalization.get()); #if defined(__i386__) -NSDictionary *defaults = [NSDictionary dictionaryWithObject:[NSNumber numberWithBool:YES] forKey:@"AppleMagnifiedMode"]; +NSDictionary *defaults = [[NSDictionary alloc] initWithObjectsAndKeys:[NSNumber numberWithBool:YES], @"AppleMagnifiedMode", nil]; [[NSUserDefaults standardUserDefaults] registerDefaults:defaults]; +[defaults release]; #endif #if !SHOW_CRASH_REPORTER ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114322] trunk/Tools
Title: [114322] trunk/Tools Revision 114322 Author k...@webkit.org Date 2012-04-16 17:18:15 -0700 (Mon, 16 Apr 2012) Log Message [GTK] Try to fix debug bot by adding gobject-introspection to the build https://bugs.webkit.org/show_bug.cgi?id=84096 Unreviewed speculative build fix. * gtk/jhbuild.modules: Added gobject-introspection, since modules need an up-to-date introspection m4 for running autogen. Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (114321 => 114322) --- trunk/Tools/ChangeLog 2012-04-17 00:17:09 UTC (rev 114321) +++ trunk/Tools/ChangeLog 2012-04-17 00:18:15 UTC (rev 114322) @@ -1,5 +1,15 @@ 2012-04-16 Gustavo Noronha Silva +[GTK] Try to fix debug bot by adding gobject-introspection to the build +https://bugs.webkit.org/show_bug.cgi?id=84096 + +Unreviewed speculative build fix. + +* gtk/jhbuild.modules: Added gobject-introspection, since modules need +an up-to-date introspection m4 for running autogen. + +2012-04-16 Gustavo Noronha Silva + [GTK] Add pango to jhbuild https://bugs.webkit.org/show_bug.cgi?id=84086 Modified: trunk/Tools/gtk/jhbuild.modules (114321 => 114322) --- trunk/Tools/gtk/jhbuild.modules 2012-04-17 00:17:09 UTC (rev 114321) +++ trunk/Tools/gtk/jhbuild.modules 2012-04-17 00:18:15 UTC (rev 114322) @@ -116,6 +116,7 @@ autogenargs="--disable-introspection"> + @@ -137,6 +138,16 @@ md5sum="c5fa76fbf9184d20dfb04af66b598190"/> + + + + + + + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114321] trunk/LayoutTests
Title: [114321] trunk/LayoutTests Revision 114321 Author ander...@apple.com Date 2012-04-16 17:17:09 -0700 (Mon, 16 Apr 2012) Log Message Add two flaky tests in fast/profiler. * platform/mac/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (114320 => 114321) --- trunk/LayoutTests/ChangeLog 2012-04-16 23:53:38 UTC (rev 114320) +++ trunk/LayoutTests/ChangeLog 2012-04-17 00:17:09 UTC (rev 114321) @@ -1,3 +1,9 @@ +2012-04-16 Anders Carlsson + +Add two flaky tests in fast/profiler. + +* platform/mac/Skipped: + 2012-04-16 Erik Arvidsson [V8] Don't delete the per context data until the V8IsolatedContext is deleted Modified: trunk/LayoutTests/platform/mac/Skipped (114320 => 114321) --- trunk/LayoutTests/platform/mac/Skipped 2012-04-16 23:53:38 UTC (rev 114320) +++ trunk/LayoutTests/platform/mac/Skipped 2012-04-17 00:17:09 UTC (rev 114321) @@ -788,3 +788,7 @@ # https://bugs.webkit.org/show_bug.cgi?id=83618 fast/dom/inline-event-attributes-release.html + +# https://bugs.webkit.org/show_bug.cgi?id=84102 +fast/profiler/stop-profiling-after-setTimeout.html +fast/profiler/dead-time.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114320] trunk
Title: [114320] trunk
Revision 114320
Author a...@chromium.org
Date 2012-04-16 16:53:38 -0700 (Mon, 16 Apr 2012)
Log Message
[V8] Don't delete the per context data until the V8IsolatedContext is deleted
https://bugs.webkit.org/show_bug.cgi?id=83831
Reviewed by Nate Chapin.
Source/WebCore:
Test: http/tests/security/isolatedWorld/context-destroy.html
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::destroy):
LayoutTests:
* http/tests/security/isolatedWorld/context-destroy-expected.txt: Added.
* http/tests/security/isolatedWorld/context-destroy.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp
Added Paths
trunk/LayoutTests/http/tests/security/isolatedWorld/context-destroy-expected.txt
trunk/LayoutTests/http/tests/security/isolatedWorld/context-destroy.html
Diff
Modified: trunk/LayoutTests/ChangeLog (114319 => 114320)
--- trunk/LayoutTests/ChangeLog 2012-04-16 23:50:37 UTC (rev 114319)
+++ trunk/LayoutTests/ChangeLog 2012-04-16 23:53:38 UTC (rev 114320)
@@ -1,3 +1,13 @@
+2012-04-16 Erik Arvidsson
+
+[V8] Don't delete the per context data until the V8IsolatedContext is deleted
+https://bugs.webkit.org/show_bug.cgi?id=83831
+
+Reviewed by Nate Chapin.
+
+* http/tests/security/isolatedWorld/context-destroy-expected.txt: Added.
+* http/tests/security/isolatedWorld/context-destroy.html: Added.
+
2012-04-16 Vincent Scheib
[Chromium] Marking test failing TEXT: css3/filters/custom/custom-filter-property-computed-style.html.
Added: trunk/LayoutTests/http/tests/security/isolatedWorld/context-destroy-expected.txt (0 => 114320)
--- trunk/LayoutTests/http/tests/security/isolatedWorld/context-destroy-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/security/isolatedWorld/context-destroy-expected.txt 2012-04-16 23:53:38 UTC (rev 114320)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/http/tests/security/isolatedWorld/context-destroy.html (0 => 114320)
--- trunk/LayoutTests/http/tests/security/isolatedWorld/context-destroy.html (rev 0)
+++ trunk/LayoutTests/http/tests/security/isolatedWorld/context-destroy.html 2012-04-16 23:53:38 UTC (rev 114320)
@@ -0,0 +1,32 @@
+
+FAIL
+
+
+window._onunload_ = function() {
+Window;
+};
+
+
+
+
+window._onload_ = function() {
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+layoutTestController.dumpAsText();
+
+var iframeElement = document.querySelector('iframe');
+iframeElement.focus();
+layoutTestController.evaluateScriptInIsolatedWorld(0, document.querySelector('#s1').textContent);
+
+iframeElement._onload_ = function() {
+document.body.textContent = 'PASS';
+layoutTestController.notifyDone();
+};
+iframeElement.src = '';
+}
+};
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (114319 => 114320)
--- trunk/Source/WebCore/ChangeLog 2012-04-16 23:50:37 UTC (rev 114319)
+++ trunk/Source/WebCore/ChangeLog 2012-04-16 23:53:38 UTC (rev 114320)
@@ -1,3 +1,15 @@
+2012-04-16 Erik Arvidsson
+
+[V8] Don't delete the per context data until the V8IsolatedContext is deleted
+https://bugs.webkit.org/show_bug.cgi?id=83831
+
+Reviewed by Nate Chapin.
+
+Test: http/tests/security/isolatedWorld/context-destroy.html
+
+* bindings/v8/V8IsolatedContext.cpp:
+(WebCore::V8IsolatedContext::destroy):
+
2012-04-16 Greg Billock
Add V8 code generation support for MessagePortArray attributes.
Modified: trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp (114319 => 114320)
--- trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp 2012-04-16 23:50:37 UTC (rev 114319)
+++ trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp 2012-04-16 23:53:38 UTC (rev 114320)
@@ -87,7 +87,6 @@
void V8IsolatedContext::destroy()
{
-m_perContextData.clear();
m_frame->loader()->client()->willReleaseScriptContext(context(), m_world->id());
m_context->get().MakeWeak(this, &contextWeakReferenceCallback);
m_frame = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114319] trunk/Source/WebCore
Title: [114319] trunk/Source/WebCore Revision 114319 Author commit-qu...@webkit.org Date 2012-04-16 16:50:37 -0700 (Mon, 16 Apr 2012) Log Message Add V8 code generation support for MessagePortArray attributes. https://bugs.webkit.org/show_bug.cgi?id=83943 Patch by Greg Billock on 2012-04-16 Reviewed by Kentaro Hara. * bindings/scripts/CodeGeneratorV8.pm: (GenerateNormalAttrGetter): * bindings/scripts/IDLAttributes.txt: * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: (WebDOMTestSerializedScriptValueInterface::ports): * bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: (WebDOMTestSerializedScriptValueInterface): * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: (webkit_dom_test_serialized_script_value_interface_get_property): (webkit_dom_test_serialized_script_value_interface_class_init): (webkit_dom_test_serialized_script_value_interface_get_ports): * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: (WebCore): (WebCore::jsTestSerializedScriptValueInterfacePorts): * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: (WebCore): * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: * bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: (-[DOMTestSerializedScriptValueInterface ports]): * bindings/scripts/test/TestSerializedScriptValueInterface.idl: * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: (WebCore::TestSerializedScriptValueInterfaceInternal::portsAttrGetter): (TestSerializedScriptValueInterfaceInternal): (WebCore): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm trunk/Source/WebCore/bindings/scripts/test/TestSerializedScriptValueInterface.idl trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (114318 => 114319) --- trunk/Source/WebCore/ChangeLog 2012-04-16 23:45:21 UTC (rev 114318) +++ trunk/Source/WebCore/ChangeLog 2012-04-16 23:50:37 UTC (rev 114319) @@ -1,3 +1,36 @@ +2012-04-16 Greg Billock + +Add V8 code generation support for MessagePortArray attributes. +https://bugs.webkit.org/show_bug.cgi?id=83943 + +Reviewed by Kentaro Hara. + +* bindings/scripts/CodeGeneratorV8.pm: +(GenerateNormalAttrGetter): +* bindings/scripts/IDLAttributes.txt: +* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: +(WebDOMTestSerializedScriptValueInterface::ports): +* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: +(WebDOMTestSerializedScriptValueInterface): +* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: +(webkit_dom_test_serialized_script_value_interface_get_property): +(webkit_dom_test_serialized_script_value_interface_class_init): +(webkit_dom_test_serialized_script_value_interface_get_ports): +* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: +* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: +(WebCore): +(WebCore::jsTestSerializedScriptValueInterfacePorts): +* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: +(WebCore): +* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: +* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: +(-[DOMTestSerializedScriptValueInterface ports]): +* bindings/scripts/test/TestSerializedScriptValueInterface.idl: +* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: +(WebCore::TestSerializedScriptValueInterfaceInternal::portsAttrGetter): +(TestSerializedScriptValueInterfaceInternal): +(WebCore): + 2012-04-16 Xiaomei Ji platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break' Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (114318 => 114319) --- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-04-16 23:45
[webkit-changes] [114318] trunk/LayoutTests
Title: [114318] trunk/LayoutTests Revision 114318 Author sch...@chromium.org Date 2012-04-16 16:45:21 -0700 (Mon, 16 Apr 2012) Log Message [Chromium] Marking test failing TEXT: css3/filters/custom/custom-filter-property-computed-style.html. Unreviewed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (114317 => 114318) --- trunk/LayoutTests/ChangeLog 2012-04-16 23:37:40 UTC (rev 114317) +++ trunk/LayoutTests/ChangeLog 2012-04-16 23:45:21 UTC (rev 114318) @@ -1,3 +1,11 @@ +2012-04-16 Vincent Scheib + +[Chromium] Marking test failing TEXT: css3/filters/custom/custom-filter-property-computed-style.html. + +Unreviewed. + +* platform/chromium/test_expectations.txt: + 2012-04-16 Sheriff Bot Unreviewed, rolling out r114309. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (114317 => 114318) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-16 23:37:40 UTC (rev 114317) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-04-16 23:45:21 UTC (rev 114318) @@ -2812,6 +2812,8 @@ BUGWK82803 SKIP : css3/filters/custom/effect-custom-parameters.html = FAIL BUGWK82803 SKIP : css3/filters/custom/custom-filter-shader-cache.html = FAIL +BUGWK84067 : css3/filters/custom/custom-filter-property-computed-style.html = TEXT + //
[webkit-changes] [114317] trunk
Title: [114317] trunk
Revision 114317
Author commit-qu...@webkit.org
Date 2012-04-16 16:37:40 -0700 (Mon, 16 Apr 2012)
Log Message
Unreviewed, rolling out r114309.
http://trac.webkit.org/changeset/114309
https://bugs.webkit.org/show_bug.cgi?id=84097
it broke everything (Requested by olliej on #webkit).
Patch by Sheriff Bot on 2012-04-16
Source/_javascript_Core:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
* bytecode/CodeBlock.h:
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
* interpreter/Interpreter.h:
(Interpreter):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jsc.cpp:
(functionJSCStack):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
* parser/Parser.h:
(JSCparse):
* runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
* runtime/Error.h:
(JSC):
LayoutTests:
* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js:
(selfRecursive1):
* fast/js/stack-trace-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/exception-properties-expected.txt
trunk/LayoutTests/fast/js/script-tests/exception-properties.js
trunk/LayoutTests/fast/js/script-tests/stack-trace.js
trunk/LayoutTests/fast/js/stack-trace-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/interpreter/Interpreter.h
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/parser/Parser.h
trunk/Source/_javascript_Core/runtime/Error.cpp
trunk/Source/_javascript_Core/runtime/Error.h
Diff
Modified: trunk/LayoutTests/ChangeLog (114316 => 114317)
--- trunk/LayoutTests/ChangeLog 2012-04-16 23:32:16 UTC (rev 114316)
+++ trunk/LayoutTests/ChangeLog 2012-04-16 23:37:40 UTC (rev 114317)
@@ -1,3 +1,17 @@
+2012-04-16 Sheriff Bot
+
+Unreviewed, rolling out r114309.
+http://trac.webkit.org/changeset/114309
+https://bugs.webkit.org/show_bug.cgi?id=84097
+
+it broke everything (Requested by olliej on #webkit).
+
+* fast/js/exception-properties-expected.txt:
+* fast/js/script-tests/exception-properties.js:
+* fast/js/script-tests/stack-trace.js:
+(selfRecursive1):
+* fast/js/stack-trace-expected.txt:
+
2012-04-16 Vincent Scheib
[Chromium] Rebaseline continued from xji's rebase after r114267.
Modified: trunk/LayoutTests/fast/js/exception-properties-expected.txt (114316 => 114317)
--- trunk/LayoutTests/fast/js/exception-properties-expected.txt 2012-04-16 23:32:16 UTC (rev 114316)
+++ trunk/LayoutTests/fast/js/exception-properties-expected.txt 2012-04-16 23:37:40 UTC (rev 114317)
@@ -4,7 +4,7 @@
PASS enumerableProperties(error) is []
-PASS enumerableProperties(nativeError) is ["stack", "line", "sourceURL"]
+PASS enumerableProperties(nativeError) is ["line", "sourceURL", "stack"]
PASS Object.getPrototypeOf(nativeError).name is "RangeError"
PASS Object.getPrototypeOf(nativeError).message is ""
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/js/script-tests/exception-properties.js (114316 => 114317)
--- trunk/LayoutTests/fast/js/script-tests/exception-properties.js 2012-04-16 23:32:16 UTC (rev 114316)
+++ trunk/LayoutTests/fast/js/script-tests/exception-properties.js 2012-04-16 23:37:40 UTC (rev 114317)
@@ -16,7 +16,7 @@
var error = new Error("message");
shouldBe('enumerableProperties(error)', '[]');
-shouldBe('enumerableProperties(nativeError)', '["stack", "line", "sourceURL"]');
+shouldBe('enumerableProperties(nativeError)', '["line", "sourceURL", "stack"]');
shouldBe('Object.getPrototypeOf(nativeError).name', '"RangeError"');
shouldBe('Object.getPrototypeOf(nativeError).message', '""');
Modified: trunk/LayoutTests/fast/js/script-tests/stack-trace.js (114316 => 114317)
--- trunk/LayoutTests/fast/js/script-tests/stack-trace.js 2012-04-16 23:32:16 UTC (rev 114316)
+++ trunk/LayoutTests/fast/js/script-tests/stack-trace.js 2012-04-16 23:37:40 UTC (rev 114317)
@@ -49,10 +49,10 @@
try { scripterInner(); } catch (e) { printStack(e.stack) } // program -> scripter -> inner
try { scripterOuter(); } catch (e) { printStack(e.stack) } // program -> scripter -> outer -> inner
-function selfRecursive1() { selfRecursive1();
+function selfRecursive1() {
+selfRecursive1();
}
-
try { selfRecursive1(); } catch (e) { printStack(e.stack) } // selfRecursive1 -> selfRecursive1 -> selfRecursive1 -> selfRecursive1 ...
function selfRecursiv
[webkit-changes] [114316] trunk/Source/WebCore
Title: [114316] trunk/Source/WebCore
Revision 114316
Author x...@chromium.org
Date 2012-04-16 16:32:16 -0700 (Mon, 16 Apr 2012)
Log Message
platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
https://bugs.webkit.org/show_bug.cgi?id=83521
Reviewed by David Levin.
No functionality change, so no new tests.
* platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
(WebCore::GlyphPage::fill):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114315 => 114316)
--- trunk/Source/WebCore/ChangeLog 2012-04-16 23:24:15 UTC (rev 114315)
+++ trunk/Source/WebCore/ChangeLog 2012-04-16 23:32:16 UTC (rev 114316)
@@ -1,3 +1,15 @@
+2012-04-16 Xiaomei Ji
+
+platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
+https://bugs.webkit.org/show_bug.cgi?id=83521
+
+Reviewed by David Levin.
+
+No functionality change, so no new tests.
+
+* platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
+(WebCore::GlyphPage::fill):
+
2012-04-16 Levi Weintraub
Make borderBoxRect sub-pixel precise and add a pixel snapped version
Modified: trunk/Source/WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp (114315 => 114316)
--- trunk/Source/WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp 2012-04-16 23:24:15 UTC (rev 114315)
+++ trunk/Source/WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp 2012-04-16 23:32:16 UTC (rev 114316)
@@ -96,15 +96,12 @@
}
if (fontData->hasVerticalGlyphs()) {
-bool lookVariants = false;
for (unsigned i = 0; i < bufferLength; ++i) {
if (!Font::isCJKIdeograph(buffer[i])) {
-lookVariants = true;
-continue;
+substituteWithVerticalGlyphs(fontData, glyphs, length);
+break;
}
}
-if (lookVariants)
-substituteWithVerticalGlyphs(fontData, glyphs, length);
}
unsigned allGlyphs = 0; // track if any of the glyphIDs are non-zero
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114315] trunk/Source/WebCore
Title: [114315] trunk/Source/WebCore Revision 114315 Author le...@chromium.org Date 2012-04-16 16:24:15 -0700 (Mon, 16 Apr 2012) Log Message Make borderBoxRect sub-pixel precise and add a pixel snapped version https://bugs.webkit.org/show_bug.cgi?id=84063 Reviewed by Eric Seidel. In an effort to prevent misuse, we previously decided to have borderBoxRect return a pixel-snapped IntRect. This is because borderBoxRect returns a rect that's positioned at (0,0), and therefore won't snap to the same size as the element it's covering. There are a couple uses of borderBoxRect that don't pixel snap the values and require sub-pixel precision. This patch adds a pixelSnappedBorderBoxRect that makes the snapping explicit, and moves uses that would otherwise pixel snap the rect to this version to avoid producing a rect of the incorrect size. For details about pixel snapping with LayoutUnits, please see https://trac.webkit.org/wiki/LayoutUnit No new tests. No change in behavior. * html/shadow/TextControlInnerElements.cpp: (WebCore::SpinButtonElement::defaultEventHandler): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::addVisualOverflowFromTheme): * rendering/RenderBox.h: (WebCore::RenderBox::borderBoxRect): (WebCore::RenderBox::pixelSnappedBorderBoxRect): (WebCore::RenderBox::borderBoundingBox): (WebCore::RenderBox::hasVisualOverflow): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollCornerRect): (WebCore::RenderLayer::scrollCornerAndResizerRect): (WebCore::RenderLayer::horizontalScrollbarStart): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::hitTestOverflowControls): * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition): * rendering/RenderTable.cpp: (WebCore::RenderTable::addOverflowFromChildren): * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paintReplaced): (WebCore::RenderSVGRoot::computeFloatRectForRepaint): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayerBacking.cpp trunk/Source/WebCore/rendering/RenderTable.cpp trunk/Source/WebCore/rendering/RenderThemeMac.mm trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (114314 => 114315) --- trunk/Source/WebCore/ChangeLog 2012-04-16 23:19:29 UTC (rev 114314) +++ trunk/Source/WebCore/ChangeLog 2012-04-16 23:24:15 UTC (rev 114315) @@ -1,3 +1,52 @@ +2012-04-16 Levi Weintraub + +Make borderBoxRect sub-pixel precise and add a pixel snapped version +https://bugs.webkit.org/show_bug.cgi?id=84063 + +Reviewed by Eric Seidel. + +In an effort to prevent misuse, we previously decided to have borderBoxRect return a +pixel-snapped IntRect. This is because borderBoxRect returns a rect that's positioned +at (0,0), and therefore won't snap to the same size as the element it's covering. + +There are a couple uses of borderBoxRect that don't pixel snap the values and require +sub-pixel precision. This patch adds a pixelSnappedBorderBoxRect that makes the snapping +explicit, and moves uses that would otherwise pixel snap the rect to this version to +avoid producing a rect of the incorrect size. For details about pixel snapping with +LayoutUnits, please see https://trac.webkit.org/wiki/LayoutUnit + +No new tests. No change in behavior. + +* html/shadow/TextControlInnerElements.cpp: +(WebCore::SpinButtonElement::defaultEventHandler): +* rendering/RenderBlock.cpp: +(WebCore::RenderBlock::addVisualOverflowFromTheme): +* rendering/RenderBox.h: +(WebCore::RenderBox::borderBoxRect): +(WebCore::RenderBox::pixelSnappedBorderBoxRect): +(WebCore::RenderBox::borderBoundingBox): +(WebCore::RenderBox::hasVisualOverflow): +* rendering/RenderLayer.cpp: +(WebCore::RenderLayer::scrollCornerRect): +(WebCore::RenderLayer::scrollCornerAndResizerRect): +(WebCore::RenderLayer::horizontalScrollbarStart): +(WebCore::RenderLayer::positionOverflowControls): +(WebCore::RenderLayer::paintResizer): +(WebCore::RenderLayer::hitTestOverflowControls): +* rendering/RenderLayerBacking.cpp: +(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): +(WebCore::RenderLayerBacking::startAnimation): +(WebCore::RenderLayerBacking::startTransition):
[webkit-changes] [114314] trunk/LayoutTests
Title: [114314] trunk/LayoutTests Revision 114314 Author sch...@chromium.org Date 2012-04-16 16:19:29 -0700 (Mon, 16 Apr 2012) Log Message [Chromium] Rebaseline continued from xji's rebase after r114267. Unreviewed. * platform/chromium-win-xp/fast/text/international/arabic-justify-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-win-xp/fast/text/international/arabic-justify-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (114313 => 114314) --- trunk/LayoutTests/ChangeLog 2012-04-16 23:10:32 UTC (rev 114313) +++ trunk/LayoutTests/ChangeLog 2012-04-16 23:19:29 UTC (rev 114314) @@ -1,3 +1,11 @@ +2012-04-16 Vincent Scheib + +[Chromium] Rebaseline continued from xji's rebase after r114267. + +Unreviewed. + +* platform/chromium-win-xp/fast/text/international/arabic-justify-expected.png: Added. + 2012-04-16 Dave Tharp Unreviewed gardening for ietestcenter/grid. Adding reference tests Added: trunk/LayoutTests/platform/chromium-win-xp/fast/text/international/arabic-justify-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win-xp/fast/text/international/arabic-justify-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114312] trunk/Tools
Title: [114312] trunk/Tools Revision 114312 Author k...@webkit.org Date 2012-04-16 15:54:01 -0700 (Mon, 16 Apr 2012) Log Message [GTK] Add pango to jhbuild https://bugs.webkit.org/show_bug.cgi?id=84086 Unreviewed build fix. * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our jhbuild environment. It's required for latest stable GTK+ and some systems may lack it. Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (114311 => 114312) --- trunk/Tools/ChangeLog 2012-04-16 22:50:33 UTC (rev 114311) +++ trunk/Tools/ChangeLog 2012-04-16 22:54:01 UTC (rev 114312) @@ -1,5 +1,16 @@ 2012-04-16 Gustavo Noronha Silva +[GTK] Add pango to jhbuild +https://bugs.webkit.org/show_bug.cgi?id=84086 + +Unreviewed build fix. + +* gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our +jhbuild environment. It's required for latest stable GTK+ and some +systems may lack it. + +2012-04-16 Gustavo Noronha Silva + [GTK] fonts jhbuild module needs an empty clean target https://bugs.webkit.org/show_bug.cgi?id=84085 Modified: trunk/Tools/gtk/jhbuild.modules (114311 => 114312) --- trunk/Tools/gtk/jhbuild.modules 2012-04-16 22:50:33 UTC (rev 114311) +++ trunk/Tools/gtk/jhbuild.modules 2012-04-16 22:54:01 UTC (rev 114312) @@ -99,11 +99,25 @@ md5sum="1c186f9903a20e96587b9afb27944b40"/> + + + + + + + + + autogenargs="--disable-introspection"> + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114311] trunk/Source/WebCore
Title: [114311] trunk/Source/WebCore
Revision 114311
Author ander...@apple.com
Date 2012-04-16 15:50:33 -0700 (Mon, 16 Apr 2012)
Log Message
Crash when running some editing related tests
https://bugs.webkit.org/show_bug.cgi?id=84091
Reviewed by Andreas Kling.
Null check triggeringEvent.
* editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (114310 => 114311)
--- trunk/Source/WebCore/ChangeLog 2012-04-16 22:27:32 UTC (rev 114310)
+++ trunk/Source/WebCore/ChangeLog 2012-04-16 22:50:33 UTC (rev 114311)
@@ -1,3 +1,15 @@
+2012-04-16 Anders Carlsson
+
+Crash when running some editing related tests
+https://bugs.webkit.org/show_bug.cgi?id=84091
+
+Reviewed by Andreas Kling.
+
+Null check triggeringEvent.
+
+* editing/Editor.cpp:
+(WebCore::Editor::insertTextWithoutSendingTextEvent):
+
2012-04-16 Simon Fraser
Rename to updateZOrderListsSlowCase to rebuildZOrderLists
Modified: trunk/Source/WebCore/editing/Editor.cpp (114310 => 114311)
--- trunk/Source/WebCore/editing/Editor.cpp 2012-04-16 22:27:32 UTC (rev 114310)
+++ trunk/Source/WebCore/editing/Editor.cpp 2012-04-16 22:50:33 UTC (rev 114311)
@@ -916,7 +916,7 @@
RefPtr document = selectionStart->document();
// Insert the text
-if (triggeringEvent->isDictation())
+if (triggeringEvent && triggeringEvent->isDictation())
DictationCommand::insertText(document.get(), text, triggeringEvent->dictationAlternatives(), selection);
else {
TypingCommand::Options options = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [114310] branches/subpixellayout
Title: [114310] branches/subpixellayout Revision 114310 Author le...@chromium.org Date 2012-04-16 15:27:32 -0700 (Mon, 16 Apr 2012) Log Message Reverting unnecessary changes to RenderRubyRun, and applying the patch from webkit.org/b/84063. Modified Paths branches/subpixellayout/LayoutTests/fast/block/float/overhanging-tall-block.html branches/subpixellayout/LayoutTests/fast/canvas/canvas-skia-excessive-size.html branches/subpixellayout/LayoutTests/fast/css/large-number-round-trip.html branches/subpixellayout/LayoutTests/fast/text/text-shadow-extreme-value.html branches/subpixellayout/LayoutTests/platform/mac/mathml/xHeight-expected.png branches/subpixellayout/Source/WebCore/html/shadow/TextControlInnerElements.cpp branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp branches/subpixellayout/Source/WebCore/rendering/RenderBox.h branches/subpixellayout/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp branches/subpixellayout/Source/WebCore/rendering/RenderLayerBacking.cpp branches/subpixellayout/Source/WebCore/rendering/RenderRubyRun.cpp branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp branches/subpixellayout/Source/WebCore/rendering/RenderThemeMac.mm branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp Diff Modified: branches/subpixellayout/LayoutTests/fast/block/float/overhanging-tall-block.html (114309 => 114310) --- branches/subpixellayout/LayoutTests/fast/block/float/overhanging-tall-block.html 2012-04-16 22:26:36 UTC (rev 114309) +++ branches/subpixellayout/LayoutTests/fast/block/float/overhanging-tall-block.html 2012-04-16 22:27:32 UTC (rev 114310) @@ -1,9 +1,9 @@ - + - + - +
