[webkit-changes] [116611] trunk

[tkent]

Title: [116611] trunk








Revision 116611
Author tk...@chromium.org
Date 2012-05-09 23:13:00 -0700 (Wed, 09 May 2012)


Log Message
Calendar Picker: Fix a crash by changing input type.
https://bugs.webkit.org/show_bug.cgi?id=86007

Reviewed by Hajime Morita.

.:

* ManualTests/forms/calendar-picker-crash-by-type-change.html: Added.

Source/WebCore:

Manual test: forms/calendar-picker-crash-by-type-change.html

* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::~CalendarPickerElement):
Added. Make sure the popup is closed.
* html/shadow/CalendarPickerElement.h:
(CalendarPickerElement): Add declaration of the destructor.

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/CalendarPickerElement.cpp
trunk/Source/WebCore/html/shadow/CalendarPickerElement.h


Added Paths

trunk/ManualTests/forms/calendar-picker-crash-by-type-change.html




Diff

Modified: trunk/ChangeLog (116610 => 116611)

--- trunk/ChangeLog	2012-05-10 06:11:21 UTC (rev 116610)
+++ trunk/ChangeLog	2012-05-10 06:13:00 UTC (rev 116611)
@@ -1,3 +1,12 @@
+2012-05-09  Kent Tamura  tk...@chromium.org
+
+Calendar Picker: Fix a crash by changing input type.
+https://bugs.webkit.org/show_bug.cgi?id=86007
+
+Reviewed by Hajime Morita.
+
+* ManualTests/forms/calendar-picker-crash-by-type-change.html: Added.
+
 2012-05-09  Gyuyoung Kim  gyuyoung@samsung.com
 
 Move suspendAnimations to use Internals interface.


Added: trunk/ManualTests/forms/calendar-picker-crash-by-type-change.html (0 => 116611)

--- trunk/ManualTests/forms/calendar-picker-crash-by-type-change.html	(rev 0)
+++ trunk/ManualTests/forms/calendar-picker-crash-by-type-change.html	2012-05-10 06:13:00 UTC (rev 116611)
@@ -0,0 +1,10 @@
+!DOCTYPE html
+script
+var input = document.createElement('input')
+input.type = 'date'
+var event = document.createEvent('KeyboardEvent')
+event.initKeyboardEvent('keydown', false, false, null, 'Down')
+input.dispatchEvent(event)
+input.type = 'color'
+/script
+pSuccess if the browser didn't crash./p
Property changes on: trunk/ManualTests/forms/calendar-picker-crash-by-type-change.html
___


Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (116610 => 116611)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 06:11:21 UTC (rev 116610)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 06:13:00 UTC (rev 116611)
@@ -1,3 +1,18 @@
+2012-05-09  Kent Tamura  tk...@chromium.org
+
+Calendar Picker: Fix a crash by changing input type.
+https://bugs.webkit.org/show_bug.cgi?id=86007
+
+Reviewed by Hajime Morita.
+
+Manual test: forms/calendar-picker-crash-by-type-change.html
+
+* html/shadow/CalendarPickerElement.cpp:
+(WebCore::CalendarPickerElement::~CalendarPickerElement):
+Added. Make sure the popup is closed.
+* html/shadow/CalendarPickerElement.h:
+(CalendarPickerElement): Add declaration of the destructor.
+
 2012-05-09  Gyuyoung Kim  gyuyoung@samsung.com
 
 Move suspendAnimations to use Internals interface.


Modified: trunk/Source/WebCore/html/shadow/CalendarPickerElement.cpp (116610 => 116611)

--- trunk/Source/WebCore/html/shadow/CalendarPickerElement.cpp	2012-05-10 06:11:21 UTC (rev 116610)
+++ trunk/Source/WebCore/html/shadow/CalendarPickerElement.cpp	2012-05-10 06:13:00 UTC (rev 116611)
@@ -68,6 +68,12 @@
 return adoptRef(new CalendarPickerElement(document));
 }
 
+CalendarPickerElement::~CalendarPickerElement()
+{
+closePopup();
+ASSERT(!m_popup);
+}
+
 RenderObject* CalendarPickerElement::createRenderer(RenderArena* arena, RenderStyle*)
 {
 return new (arena) RenderDetailsMarker(this);


Modified: trunk/Source/WebCore/html/shadow/CalendarPickerElement.h (116610 => 116611)

--- trunk/Source/WebCore/html/shadow/CalendarPickerElement.h	2012-05-10 06:11:21 UTC (rev 116610)
+++ trunk/Source/WebCore/html/shadow/CalendarPickerElement.h	2012-05-10 06:13:00 UTC (rev 116611)
@@ -43,6 +43,7 @@
 class CalendarPickerElement : public HTMLDivElement, public PagePopupClient {
 public:
 static PassRefPtrCalendarPickerElement create(Document*);
+virtual ~CalendarPickerElement();
 void openPopup();
 void closePopup();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116612] trunk/Source/WebKit/chromium

[commit-queue]

Title: [116612] trunk/Source/WebKit/chromium








Revision 116612
Author commit-qu...@webkit.org
Date 2012-05-09 23:42:14 -0700 (Wed, 09 May 2012)


Log Message
[chromium] Add ability to override user agent string per-WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=83959

Patch by Dan Alcantara dfalcant...@chromium.org on 2012-05-09
Reviewed by Adam Barth.

Adds a method that can be used to override the normal user agent in
chromium.  Also adds a unit test to check if the override is taking effect.

* WebKit.gypi:
* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::userAgent):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::userAgent):
* tests/FrameLoaderClientImplTest.cpp: Added.
(WebKit):
(TestWebFrameClient):
(WebKit::TestWebFrameClient::setUserAgentOverride):
(FrameLoaderClientImplTest):
(WebKit::FrameLoaderClientImplTest::SetUp):
(WebKit::FrameLoaderClientImplTest::TearDown):
(WebKit::FrameLoaderClientImplTest::setUserAgentOverride):
(WebKit::FrameLoaderClientImplTest::userAgent):
(WebKit::TEST_F):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp


Added Paths

trunk/Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (116611 => 116612)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-05-10 06:13:00 UTC (rev 116611)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-05-10 06:42:14 UTC (rev 116612)
@@ -1,3 +1,30 @@
+2012-05-09  Dan Alcantara  dfalcant...@chromium.org
+
+[chromium] Add ability to override user agent string per-WebFrameClient
+https://bugs.webkit.org/show_bug.cgi?id=83959
+
+Reviewed by Adam Barth.
+
+Adds a method that can be used to override the normal user agent in
+chromium.  Also adds a unit test to check if the override is taking effect.
+
+* WebKit.gypi:
+* public/WebFrameClient.h:
+(WebFrameClient):
+(WebKit::WebFrameClient::userAgent):
+* src/FrameLoaderClientImpl.cpp:
+(WebKit::FrameLoaderClientImpl::userAgent):
+* tests/FrameLoaderClientImplTest.cpp: Added.
+(WebKit):
+(TestWebFrameClient):
+(WebKit::TestWebFrameClient::setUserAgentOverride):
+(FrameLoaderClientImplTest):
+(WebKit::FrameLoaderClientImplTest::SetUp):
+(WebKit::FrameLoaderClientImplTest::TearDown):
+(WebKit::FrameLoaderClientImplTest::setUserAgentOverride):
+(WebKit::FrameLoaderClientImplTest::userAgent):
+(WebKit::TEST_F):
+
 2012-05-09  Charlie Reis  cr...@chromium.org
 
 Add dispatchMessageEventWithOriginCheck to WebFrame


Modified: trunk/Source/WebKit/chromium/WebKit.gypi (116611 => 116612)

--- trunk/Source/WebKit/chromium/WebKit.gypi	2012-05-10 06:13:00 UTC (rev 116611)
+++ trunk/Source/WebKit/chromium/WebKit.gypi	2012-05-10 06:42:14 UTC (rev 116612)
@@ -102,6 +102,7 @@
 'tests/FakeGraphicsContext3DTest.cpp',
 'tests/FakeWebGraphicsContext3D.h',
 'tests/FloatQuadTest.cpp',
+'tests/FrameLoaderClientImplTest.cpp',
 'tests/FrameTestHelpers.cpp',
 'tests/FrameTestHelpers.h',
 'tests/IDBBindingUtilitiesTest.cpp',


Modified: trunk/Source/WebKit/chromium/public/WebFrameClient.h (116611 => 116612)

--- trunk/Source/WebKit/chromium/public/WebFrameClient.h	2012-05-10 06:13:00 UTC (rev 116611)
+++ trunk/Source/WebKit/chromium/public/WebFrameClient.h	2012-05-10 06:42:14 UTC (rev 116612)
@@ -397,6 +397,11 @@
 WebSecurityOrigin target,
 WebDOMMessageEvent) { return false; }
 
+// Asks the embedder if a specific user agent should be used for the given
+// URL. Returns true if it should, along with the user agent. If false,
+// WebKitPlatformSupport::userAgent() will be called to provide one.
+virtual bool userAgent(const WebURL url, WebString* userAgent) { return false; }
+
 protected:
 ~WebFrameClient() { }
 };


Modified: trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp (116611 => 116612)

--- trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp	2012-05-10 06:13:00 UTC (rev 116611)
+++ trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp	2012-05-10 06:42:14 UTC (rev 116612)
@@ -1383,6 +1383,10 @@
 
 String FrameLoaderClientImpl::userAgent(const KURL url)
 {
+WebString override;
+if (m_webFrame-client()-userAgent(WebURL(url), override))
+return override;
+
 return WebKit::Platform::current()-userAgent(url);
 }
 


Added: trunk/Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp (0 => 116612)

--- trunk/Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp	(rev 0)
+++ trunk/Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp	2012-05-10 06:42:14 UTC (rev 116612)
@@ 

[webkit-changes] [116613] trunk/Source/WebKit/chromium

[tkent]

Title: [116613] trunk/Source/WebKit/chromium








Revision 116613
Author tk...@chromium.org
Date 2012-05-10 00:00:36 -0700 (Thu, 10 May 2012)


Log Message
[Chromium] Mark CCLayerTreeHostTestSetNeedsCommit2.runMultiThread and
CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread flaky.

* tests/CCLayerTreeHostTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (116612 => 116613)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-05-10 06:42:14 UTC (rev 116612)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-05-10 07:00:36 UTC (rev 116613)
@@ -1,3 +1,10 @@
+2012-05-09  Kent Tamura  tk...@chromium.org
+
+[Chromium] Mark CCLayerTreeHostTestSetNeedsCommit2.runMultiThread and
+CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity.runMultiThread flaky.
+
+* tests/CCLayerTreeHostTest.cpp:
+
 2012-05-09  Dan Alcantara  dfalcant...@chromium.org
 
 [chromium] Add ability to override user agent string per-WebFrameClient


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (116612 => 116613)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp	2012-05-10 06:42:14 UTC (rev 116612)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp	2012-05-10 07:00:36 UTC (rev 116613)
@@ -788,7 +788,12 @@
 int m_numDraws;
 };
 
+#if OS(WINDOWS)
+// http://webkit.org/b/74623
+TEST_F(CCLayerTreeHostTestSetNeedsCommit2, FLAKY_runMultiThread)
+#else
 TEST_F(CCLayerTreeHostTestSetNeedsCommit2, runMultiThread)
+#endif
 {
 runTestThreaded();
 }
@@ -1220,7 +1225,12 @@
 }
 };
 
+#if OS(WINDOWS)
+// http://webkit.org/b/74623
+TEST_F(CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity, FLAKY_runMultiThread)
+#else
 TEST_F(CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity, runMultiThread)
+#endif
 {
 runTestThreaded();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116614] trunk/LayoutTests

[zandobersek]

Title: [116614] trunk/LayoutTests








Revision 116614
Author zandober...@gmail.com
Date 2012-05-10 00:10:19 -0700 (Thu, 10 May 2012)


Log Message
Unreviewed GTK gardening.

* platform/gtk/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116613 => 116614)

--- trunk/LayoutTests/ChangeLog	2012-05-10 07:00:36 UTC (rev 116613)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 07:10:19 UTC (rev 116614)
@@ -1,3 +1,9 @@
+2012-05-10  Zan Dobersek  zandober...@gmail.com
+
+Unreviewed GTK gardening.
+
+* platform/gtk/test_expectations.txt:
+
 2012-05-09  Gyuyoung Kim  gyuyoung@samsung.com
 
 Move suspendAnimations to use Internals interface.


Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (116613 => 116614)

--- trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-05-10 07:00:36 UTC (rev 116613)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-05-10 07:10:19 UTC (rev 116614)
@@ -1263,6 +1263,7 @@
 
 BUGWK79203 : fast/mediastream/argument-types.html = FAIL
 BUGWK79203 : fast/mediastream/constructors.html = FAIL
+BUGWK79203 : fast/mediastream/MediaStreamConstructor.html = FAIL
 BUGWK79203 : fast/mediastream/peerconnection-argument-types.html = FAIL
 BUGWK79203 : fast/mediastream/peerconnection-iceoptions.html = FAIL
 BUGWK79203 : fast/mediastream/getusermedia.html = FAIL
@@ -1339,6 +1340,16 @@
 // Interferes with the rAF tests that are enabled
 BUGWK85689 SKIP : fast/animation/request-animation-frame-disabled.html = TEXT
 
+// Started failing after it was added in r116473
+BUGWK85969 : http/tests/loading/post-in-iframe-with-back-navigation.html = FAIL
+
+// Started failing after it was added in r116563
+BUGWK86061 : http/tests/security/referrer-policy-redirect-link.html = FAIL
+
+// Started failing after they were added in r116498
+BUGWK86062 : svg/text/add-tspan-position-bug.html = IMAGE
+BUGWK86062 : svg/text/modify-tspan-position-bug.html = IMAGE
+
 //
 // End of Tests failing
 //






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116615] trunk/Source/WebCore

[commit-queue]

Title: [116615] trunk/Source/WebCore








Revision 116615
Author commit-qu...@webkit.org
Date 2012-05-10 00:22:32 -0700 (Thu, 10 May 2012)


Log Message
[Forms] Move step related methods to InputType class from HTMLInputElement class
https://bugs.webkit.org/show_bug.cgi?id=85978

Patch by Yoshifumi Inoue yo...@chromium.org on 2012-05-10
Reviewed by Kent Tamura.

This patch is part of re-factoring of HTMLInputElement.cpp for numeric input type.
In this patch, we move implementation of getAllowedValueStep and stepUp/stepUpFromRenderer
to InputType class because of these are for DateTime/Number/Range.

Following patches will change implementation of getAllowedValueStep to use StepRange and
remove step related methods, defaultStep, stepScaleFactor, and so on.

No new tests. This patch should not change behavior.

* html/HTMLInputElement.cpp:
(WebCore):
(WebCore::HTMLInputElement::getAllowedValueStep):
(WebCore::HTMLInputElement::stepUp):
(WebCore::HTMLInputElement::stepDown):
(WebCore::HTMLInputElement::stepUpFromRenderer):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::InputType::applyStep):
(WebCore):
(WebCore::InputType::alignValueForStep):
(WebCore::InputType::getAllowedValueStep):
(WebCore::InputType::getAllowedValueStepWithDecimalPlaces):
(WebCore::InputType::stepUp):
(WebCore::InputType::stepUpFromRenderer):
* html/InputType.h:
(InputType):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/InputType.cpp
trunk/Source/WebCore/html/InputType.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116614 => 116615)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 07:10:19 UTC (rev 116614)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 07:22:32 UTC (rev 116615)
@@ -1,3 +1,38 @@
+2012-05-10  Yoshifumi Inoue  yo...@chromium.org
+
+[Forms] Move step related methods to InputType class from HTMLInputElement class
+https://bugs.webkit.org/show_bug.cgi?id=85978
+
+Reviewed by Kent Tamura.
+
+This patch is part of re-factoring of HTMLInputElement.cpp for numeric input type.
+In this patch, we move implementation of getAllowedValueStep and stepUp/stepUpFromRenderer
+to InputType class because of these are for DateTime/Number/Range.
+
+Following patches will change implementation of getAllowedValueStep to use StepRange and
+remove step related methods, defaultStep, stepScaleFactor, and so on.
+
+No new tests. This patch should not change behavior.
+
+* html/HTMLInputElement.cpp:
+(WebCore):
+(WebCore::HTMLInputElement::getAllowedValueStep):
+(WebCore::HTMLInputElement::stepUp):
+(WebCore::HTMLInputElement::stepDown):
+(WebCore::HTMLInputElement::stepUpFromRenderer):
+* html/HTMLInputElement.h:
+(HTMLInputElement):
+* html/InputType.cpp:
+(WebCore::InputType::applyStep):
+(WebCore):
+(WebCore::InputType::alignValueForStep):
+(WebCore::InputType::getAllowedValueStep):
+(WebCore::InputType::getAllowedValueStepWithDecimalPlaces):
+(WebCore::InputType::stepUp):
+(WebCore::InputType::stepUpFromRenderer):
+* html/InputType.h:
+(InputType):
+
 2012-05-09  Kent Tamura  tk...@chromium.org
 
 Calendar Picker: Fix a crash by changing input type.


Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (116614 => 116615)

--- trunk/Source/WebCore/html/HTMLInputElement.cpp	2012-05-10 07:10:19 UTC (rev 116614)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp	2012-05-10 07:22:32 UTC (rev 116615)
@@ -298,136 +298,17 @@
 
 bool HTMLInputElement::getAllowedValueStep(double* step) const
 {
-return getAllowedValueStepWithDecimalPlaces(RejectAny, step, 0);
+return m_inputType-getAllowedValueStep(step);
 }
 
-bool HTMLInputElement::getAllowedValueStepWithDecimalPlaces(AnyStepHandling anyStepHandling, double* step, unsigned* decimalPlaces) const
-{
-ASSERT(step);
-double defaultStep = m_inputType-defaultStep();
-double stepScaleFactor = m_inputType-stepScaleFactor();
-if (!isfinite(defaultStep) || !isfinite(stepScaleFactor))
-return false;
-const AtomicString stepString = fastGetAttribute(stepAttr);
-if (stepString.isEmpty()) {
-*step = defaultStep * stepScaleFactor;
-if (decimalPlaces)
-*decimalPlaces = 0;
-return true;
-}
-
-if (equalIgnoringCase(stepString, any)) {
-switch (anyStepHandling) {
-case RejectAny:
-return false;
-case AnyIsDefaultStep:
-*step = defaultStep * stepScaleFactor;
-if (decimalPlaces)
-*decimalPlaces = 0;
-return true;
-default:
-ASSERT_NOT_REACHED();
-}
-}
-
-double parsed;
-if (!decimalPlaces) {
-if 

[webkit-changes] [116616] trunk/Source/WebCore

[ossy]

Title: [116616] trunk/Source/WebCore








Revision 116616
Author o...@webkit.org
Date 2012-05-10 00:34:06 -0700 (Thu, 10 May 2012)


Log Message
Use suitable viewport values when a Mobile DTD is used.
https://bugs.webkit.org/show_bug.cgi?id=85425

Unreviewed debug buildfix after r116571.

* dom/Document.cpp:
(WebCore::Document::setDocType):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116615 => 116616)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 07:22:32 UTC (rev 116615)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 07:34:06 UTC (rev 116616)
@@ -1,3 +1,13 @@
+2012-05-10  Csaba Osztrogonác  o...@webkit.org
+
+Use suitable viewport values when a Mobile DTD is used.
+https://bugs.webkit.org/show_bug.cgi?id=85425
+
+Unreviewed debug buildfix after r116571.
+
+* dom/Document.cpp:
+(WebCore::Document::setDocType):
+
 2012-05-10  Yoshifumi Inoue  yo...@chromium.org
 
 [Forms] Move step related methods to InputType class from HTMLInputElement class


Modified: trunk/Source/WebCore/dom/Document.cpp (116615 => 116616)

--- trunk/Source/WebCore/dom/Document.cpp	2012-05-10 07:22:32 UTC (rev 116615)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-05-10 07:34:06 UTC (rev 116616)
@@ -774,7 +774,7 @@
 if (m_docType) {
 this-adoptIfNeeded(m_docType.get());
 #if USE(LEGACY_VIEWPORT_ADAPTION)
-ASSERT(m_viewportArgument.type == Implicit);
+ASSERT(m_viewportArguments.type == ViewportArguments::Implicit);
 if (m_docType-publicId().startsWith(-//wapforum//dtd xhtml mobile 1., /* caseSensitive */ false))
 processViewport(width=device-width, height=device-height, initial-scale=1);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116618] trunk

[inferno]

Title: [116618] trunk








Revision 116618
Author infe...@chromium.org
Date 2012-05-10 00:42:03 -0700 (Thu, 10 May 2012)


Log Message
Make DOMCharacterDataModified a scoped event (similar to r73690).
https://bugs.webkit.org/show_bug.cgi?id=85920

Reviewed by Ryosuke Niwa.

Source/WebCore:

DOMCharacterDataModified was missing in the list of already scoped
DOM mutation events like DOMSubtreeModified, DOMNodeInserted, etc.
It helps to delay event dispatches until the completion of each call
of EditCommand::doApply. This has been useful in the past and helped to
prevent unexpected DOM tree mutations while the editing command is executing.

* dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

* fast/events/scoped/editing-commands.html: test modified to check DOMCharacterDataModified event.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/scoped/editing-commands.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/CharacterData.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (116617 => 116618)

--- trunk/LayoutTests/ChangeLog	2012-05-10 07:38:51 UTC (rev 116617)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 07:42:03 UTC (rev 116618)
@@ -1,3 +1,12 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Make DOMCharacterDataModified a scoped event (similar to r73690).
+https://bugs.webkit.org/show_bug.cgi?id=85920
+
+Reviewed by Ryosuke Niwa.
+
+* fast/events/scoped/editing-commands.html: test modified to check DOMCharacterDataModified event.
+
 2012-05-10  Zan Dobersek  zandober...@gmail.com
 
 Unreviewed GTK gardening.


Modified: trunk/LayoutTests/fast/events/scoped/editing-commands.html (116617 => 116618)

--- trunk/LayoutTests/fast/events/scoped/editing-commands.html	2012-05-10 07:38:51 UTC (rev 116617)
+++ trunk/LayoutTests/fast/events/scoped/editing-commands.html	2012-05-10 07:42:03 UTC (rev 116618)
@@ -47,6 +47,7 @@
 ];
 
 var events = {
+'DOMCharacterDataModified': false,
 'DOMSubtreeModified': false,
 'DOMNodeInserted': false,
 'DOMNodeRemoved': false,


Modified: trunk/Source/WebCore/ChangeLog (116617 => 116618)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 07:38:51 UTC (rev 116617)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 07:42:03 UTC (rev 116618)
@@ -1,3 +1,19 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Make DOMCharacterDataModified a scoped event (similar to r73690).
+https://bugs.webkit.org/show_bug.cgi?id=85920
+
+Reviewed by Ryosuke Niwa.
+
+DOMCharacterDataModified was missing in the list of already scoped
+DOM mutation events like DOMSubtreeModified, DOMNodeInserted, etc.
+It helps to delay event dispatches until the completion of each call
+of EditCommand::doApply. This has been useful in the past and helped to 
+prevent unexpected DOM tree mutations while the editing command is executing.
+
+* dom/CharacterData.cpp:
+(WebCore::CharacterData::dispatchModifiedEvent):
+
 2012-05-10  Alexandre Elias  ael...@google.com
 
 Default to null value for HistoryItem::m_pageScaleFactor


Modified: trunk/Source/WebCore/dom/CharacterData.cpp (116617 => 116618)

--- trunk/Source/WebCore/dom/CharacterData.cpp	2012-05-10 07:38:51 UTC (rev 116617)
+++ trunk/Source/WebCore/dom/CharacterData.cpp	2012-05-10 07:42:03 UTC (rev 116618)
@@ -200,7 +200,7 @@
 if (parentNode())
 parentNode()-childrenChanged();
 if (document()-hasListenerType(Document::DOMCHARACTERDATAMODIFIED_LISTENER))
-dispatchEvent(MutationEvent::create(eventNames().DOMCharacterDataModifiedEvent, true, 0, oldData, m_data));
+dispatchScopedEvent(MutationEvent::create(eventNames().DOMCharacterDataModifiedEvent, true, 0, oldData, m_data));
 dispatchSubtreeModifiedEvent();
 #if ENABLE(INSPECTOR)
 InspectorInstrumentation::characterDataModified(document(), this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116619] trunk/Source/WebCore

[apavlov]

Title: [116619] trunk/Source/WebCore








Revision 116619
Author apav...@chromium.org
Date 2012-05-10 00:48:10 -0700 (Thu, 10 May 2012)


Log Message
Web Inspector: Autocomplete for CSS property values in the Styles pane behaving incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85784

Reviewed by Vsevolod Vlasov.

Before executing the number increment/decrement within CSS property value, the current word is checked
for being a valid suggestion for the current property, and if it is, the numeric change is skipped
in favor of the suggested property value switch by a suggest box.

* inspector/front-end/StylesSidebarPane.js:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (116618 => 116619)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 07:42:03 UTC (rev 116618)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 07:48:10 UTC (rev 116619)
@@ -1,3 +1,16 @@
+2012-05-10  Alexander Pavlov  apav...@chromium.org
+
+Web Inspector: Autocomplete for CSS property values in the Styles pane behaving incorrectly
+https://bugs.webkit.org/show_bug.cgi?id=85784
+
+Reviewed by Vsevolod Vlasov.
+
+Before executing the number increment/decrement within CSS property value, the current word is checked
+for being a valid suggestion for the current property, and if it is, the numeric change is skipped
+in favor of the suggested property value switch by a suggest box.
+
+* inspector/front-end/StylesSidebarPane.js:
+
 2012-05-10  Abhishek Arya  infe...@chromium.org
 
 Make DOMCharacterDataModified a scoped event (similar to r73690).


Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (116618 => 116619)

--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2012-05-10 07:42:03 UTC (rev 116618)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js	2012-05-10 07:48:10 UTC (rev 116619)
@@ -2561,6 +2561,9 @@
 
 var wordRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, WebInspector.StylesSidebarPane.StyleValueDelimiters, this._sidebarPane.valueElement);
 var wordString = wordRange.toString();
+if (this._isValueSuggestion(wordString))
+return false;
+
 var replacementString;
 var prefix, suffix, number;
 
@@ -2611,6 +2614,14 @@
 return false;
 },
 
+_isValueSuggestion: function(word)
+{
+if (!word)
+return false;
+word = word.toLowerCase();
+return this._cssCompletions.keySet().hasOwnProperty(word);
+},
+
 _buildPropertyCompletions: function(textPrompt, wordRange, force, completionsReadyCallback)
 {
 var prefix = wordRange.toString().toLowerCase();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116620] branches/dfgopt/Source/JavaScriptCore

[fpizlo]

Title: [116620] branches/dfgopt/Source/_javascript_Core








Revision 116620
Author fpi...@apple.com
Date 2012-05-10 00:53:27 -0700 (Thu, 10 May 2012)


Log Message
DFG should allow inlining in case of certain arity mismatches
https://bugs.webkit.org/show_bug.cgi?id=86059

Reviewed by Geoff Garen.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):

Modified Paths

branches/dfgopt/Source/_javascript_Core/ChangeLog
branches/dfgopt/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp




Diff

Modified: branches/dfgopt/Source/_javascript_Core/ChangeLog (116619 => 116620)

--- branches/dfgopt/Source/_javascript_Core/ChangeLog	2012-05-10 07:48:10 UTC (rev 116619)
+++ branches/dfgopt/Source/_javascript_Core/ChangeLog	2012-05-10 07:53:27 UTC (rev 116620)
@@ -1,3 +1,13 @@
+2012-05-09  Filip Pizlo  fpi...@apple.com
+
+DFG should allow inlining in case of certain arity mismatches
+https://bugs.webkit.org/show_bug.cgi?id=86059
+
+Reviewed by Geoff Garen.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::handleInlining):
+
 2012-05-08  Filip Pizlo  fpi...@apple.com
 
 DFG variable capture analysis should work even if the variables arose through inlining


Modified: branches/dfgopt/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (116619 => 116620)

--- branches/dfgopt/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2012-05-10 07:48:10 UTC (rev 116619)
+++ branches/dfgopt/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2012-05-10 07:53:27 UTC (rev 116620)
@@ -1116,9 +1116,10 @@
 
 FunctionExecutable* executable = expectedFunction-jsExecutable();
 
-// Does the number of arguments we're passing match the arity of the target? We could
-// inline arity check failures, but for simplicity we currently don't.
-if (static_castint(executable-parameterCount()) + 1 != argumentCountIncludingThis)
+// Does the number of arguments we're passing match the arity of the target? We currently
+// inline only if the number of arguments passed is greater than or equal to the number
+// arguments expected.
+if (static_castint(executable-parameterCount()) + 1  argumentCountIncludingThis)
 return false;
 
 // Have we exceeded inline stack depth, or are we trying to inline a recursive call?
@@ -1183,8 +1184,11 @@
 InlineStackEntry inlineStackEntry(this, codeBlock, profiledBlock, m_graph.m_blocks.size() - 1, (VirtualRegister)m_inlineStackTop-remapOperand(callTarget), expectedFunction, (VirtualRegister)m_inlineStackTop-remapOperand(usesResult ? resultOperand : InvalidVirtualRegister), (VirtualRegister)inlineCallFrameStart, kind);
 
 // Link up the argument variable access datas to their argument positions.
-for (int i = 1; i  argumentCountIncludingThis; ++i)
+for (int i = 1; i  argumentCountIncludingThis; ++i) {
+if (static_castsize_t(i) = inlineStackEntry.m_argumentPositions.size())
+break;
 inlineStackEntry.m_argumentPositions[i]-addVariable(arguments[i - 1]);
+}
 
 // This is where the actual inlining really happens.
 unsigned oldIndex = m_currentIndex;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116622] trunk/LayoutTests

[ossy]

Title: [116622] trunk/LayoutTests








Revision 116622
Author o...@webkit.org
Date 2012-05-10 02:23:43 -0700 (Thu, 10 May 2012)


Log Message
[Qt] Unreviewed gardening. Skip news failing and crashing tests to paint the bot green.

* platform/qt-mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (116621 => 116622)

--- trunk/LayoutTests/ChangeLog	2012-05-10 08:26:30 UTC (rev 116621)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 09:23:43 UTC (rev 116622)
@@ -1,3 +1,9 @@
+2012-05-10  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] Unreviewed gardening. Skip news failing and crashing tests to paint the bot green.
+
+* platform/qt-mac/Skipped:
+
 2012-05-10  Kristóf Kosztyó  kkris...@inf.u-szeged.hu
 
 [Qt] new test http/tests/cookies/single-quoted-value.html is failing


Modified: trunk/LayoutTests/platform/qt-mac/Skipped (116621 => 116622)

--- trunk/LayoutTests/platform/qt-mac/Skipped	2012-05-10 08:26:30 UTC (rev 116621)
+++ trunk/LayoutTests/platform/qt-mac/Skipped	2012-05-10 09:23:43 UTC (rev 116622)
@@ -5630,3 +5630,95 @@
 
 # new crashing test
 css3/filters/huge-region.html
+
+# new failing tests
+css2.1/20110323/first-letter-000.htm
+css2.1/20110323/first-letter-001.htm
+css2.1/20110323/first-letter-dynamic-001.htm
+css2.1/20110323/first-letter-dynamic-002.htm
+css2.1/20110323/first-letter-dynamic-003a.htm
+css2.1/20110323/first-letter-dynamic-003b.htm
+css2.1/20110323/first-letter-inherit-001.htm
+css2.1/20110323/first-letter-nested-001.htm
+css2.1/20110323/first-letter-nested-002.htm
+css2.1/20110323/first-letter-nested-003.htm
+css2.1/20110323/first-letter-nested-004.htm
+css2.1/20110323/first-letter-nested-005.htm
+css2.1/20110323/first-letter-nested-006.htm
+css2.1/20110323/first-letter-nested-007.htm
+css2.1/20110323/first-letter-quote-001.htm
+css2.1/20110323/first-letter-quote-002.htm
+css2.1/20110323/first-letter-quote-003.htm
+css2.1/20110323/first-letter-quote-004.htm
+css2.1/20110323/first-letter-quote-005.htm
+css2.1/20110323/first-letter-quote-006.htm
+fast/block/float/avoiding-float-centered.html
+fast/block/float/editable-text-overlapping-float.html
+fast/block/float/multiple-float-positioning.html
+fast/block/margin-collapse/103.html
+fast/block/positioning/auto/006.html
+fast/block/positioning/offsetLeft-offsetTop-multicolumn.html
+fast/css/color-correction-backgrounds-and-text.html
+fast/css/first-letter-nested-positioned.htm
+fast/css/first-letter-quotes-no-content-before-after.html
+fast/dom/HTMLMeterElement/meter-boundary-values.html
+fast/dom/HTMLMeterElement/meter-optimums.html
+fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
+fast/dom/HTMLMeterElement/meter-styles.html
+fast/dom/HTMLTextAreaElement/reset-textarea.html
+fast/dynamic/008.html
+fast/forms/box-shadow-override.html
+fast/forms/disabled-select-change-index.html
+fast/forms/file/file-input-direction.html
+fast/forms/file/file-input-disabled.html
+fast/forms/form-element-geometry.html
+fast/forms/input-disabled-color.html
+fast/forms/negativeLineHeight.html
+fast/forms/placeholder-pseudo-style.html
+fast/forms/range/slider-padding.html
+fast/forms/textarea-align.html
+fast/forms/textarea-setinnerhtml.html
+fast/html/details-marker-style.html
+fast/inline/inline-borders-with-bidi-override.html
+fast/invalid/016.html
+fast/js/stack-trace.html
+fast/layers/scroll-rect-to-visible.html
+fast/overflow/image-selection-highlight.html
+fast/overflow/unreachable-overflow-rtl-bug.html
+fast/parser/entity-comment-in-textarea.html
+fast/parser/open-comment-in-textarea.html
+fast/repaint/button-spurious-layout-hint.html
+fast/repaint/control-clip.html
+fast/repaint/inline-outline-repaint.html
+fast/repaint/scale-page-shrink.html
+fast/repaint/selection-after-delete.html
+fast/repaint/selection-after-remove.html
+fast/repaint/selection-clear.html
+fast/replaced/border-radius-clip.html
+fast/table/003.html
+fast/table/cell-pref-width-invalidation.html
+fast/text/atsui-small-caps-punctuation-size.html
+fast/text/basic/003.html
+fast/text/cg-vs-atsui.html
+fast/text/complex-text-opacity.html
+fast/text/embed-at-end-of-pre-wrap-line.html
+fast/text/international/text-spliced-font.html
+fast/text/large-text-composed-char.html
+fast/text/letter-spacing-negative-opacity.html
+fast/text/line-breaks-after-white-space.html
+fast/text/whitespace/normal-after-nowrap-breaking.html
+fast/text/whitespace/pre-break-word.html
+fast/text/whitespace/pre-wrap-line-test.html
+fast/text/whitespace/pre-wrap-overflow-selection.html
+fast/text/word-break.html
+fast/writing-mode/flipped-blocks-inline-map-local-to-container.html
+fast/xsl/xslt-entity.xml
+http/tests/loading/pdf-commit-load-callbacks.html
+http/tests/security/sandboxed-iframe-modify-self.html
+svg/as-image/image-respects-pageScaleFactor.html
+
+# new crashing tests
+css3/filters/multiple-filters-invalidation.html
+canvas/philip/tests/2d.pattern.basic.zerocanvas.html

[webkit-changes] [116623] trunk/Source/WebCore

[kinuko]

Title: [116623] trunk/Source/WebCore








Revision 116623
Author kin...@chromium.org
Date 2012-05-10 02:59:40 -0700 (Thu, 10 May 2012)


Log Message
Change the return type of Entry.toURL() back to String from KURL
https://bugs.webkit.org/show_bug.cgi?id=85858

Reviewed by Ryosuke Niwa.

I once changed it from String to KURL in r116273 but it turned out that
it involves implicit conversion and may incur extra overhead.
This partly reverts r116273 while keeping some internal functions
returning KURL as it's what we initially create as and is more
convenient to operate on.

No new tests; no functional or visible changes.

* Modules/filesystem/EntryBase.cpp:
(WebCore::EntryBase::toURL):
* Modules/filesystem/EntryBase.h:
(EntryBase):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/filesystem/EntryBase.cpp
trunk/Source/WebCore/Modules/filesystem/EntryBase.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116622 => 116623)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 09:23:43 UTC (rev 116622)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 09:59:40 UTC (rev 116623)
@@ -1,3 +1,23 @@
+2012-05-10  Kinuko Yasuda  kin...@chromium.org
+
+Change the return type of Entry.toURL() back to String from KURL
+https://bugs.webkit.org/show_bug.cgi?id=85858
+
+Reviewed by Ryosuke Niwa.
+
+I once changed it from String to KURL in r116273 but it turned out that
+it involves implicit conversion and may incur extra overhead.
+This partly reverts r116273 while keeping some internal functions
+returning KURL as it's what we initially create as and is more
+convenient to operate on.
+
+No new tests; no functional or visible changes.
+
+* Modules/filesystem/EntryBase.cpp:
+(WebCore::EntryBase::toURL):
+* Modules/filesystem/EntryBase.h:
+(EntryBase):
+
 2012-05-10  Alexander Pavlov  apav...@chromium.org
 
 Web Inspector: Autocomplete for CSS property values in the Styles pane behaving incorrectly


Modified: trunk/Source/WebCore/Modules/filesystem/EntryBase.cpp (116622 => 116623)

--- trunk/Source/WebCore/Modules/filesystem/EntryBase.cpp	2012-05-10 09:23:43 UTC (rev 116622)
+++ trunk/Source/WebCore/Modules/filesystem/EntryBase.cpp	2012-05-10 09:59:40 UTC (rev 116623)
@@ -54,13 +54,13 @@
 {
 }
 
-KURL EntryBase::toURL() const
+String EntryBase::toURL() const
 {
 // Some filesystem type may not support toURL.
 if (!m_fileSystem-supportsToURL())
-return KURL();
+return String();
 
-return m_fileSystem-createFileSystemURL(this);
+return m_fileSystem-createFileSystemURL(this).string();
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/Modules/filesystem/EntryBase.h (116622 => 116623)

--- trunk/Source/WebCore/Modules/filesystem/EntryBase.h	2012-05-10 09:23:43 UTC (rev 116622)
+++ trunk/Source/WebCore/Modules/filesystem/EntryBase.h	2012-05-10 09:59:40 UTC (rev 116623)
@@ -33,9 +33,8 @@
 
 #if ENABLE(FILE_SYSTEM)
 
-#include KURL.h
-#include wtf/PassRefPtr.h
 #include wtf/RefCounted.h
+#include wtf/text/WTFString.h
 
 namespace WebCore {
 
@@ -55,7 +54,7 @@
 const String fullPath() const { return m_fullPath; }
 const String name() const { return m_name; }
 
-KURL toURL() const;
+String toURL() const;
 
 protected:
 EntryBase(PassRefPtrDOMFileSystemBase, const String fullPath);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116624] trunk/LayoutTests

[commit-queue]

Title: [116624] trunk/LayoutTests








Revision 116624
Author commit-qu...@webkit.org
Date 2012-05-10 03:06:14 -0700 (Thu, 10 May 2012)


Log Message
[EFL][DRT] fast/events/js-keyboard-event-creation.html needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85485

Unreviewed, fast/events/js-keyboard-event-creation.html is rebased.

Patch by Mikhail Pozdnyakov mikhail.pozdnya...@intel.com on 2012-05-10

* platform/efl/Skipped: removed fast/events/js-keyboard-event-creation.html
* platform/efl/fast/events/js-keyboard-event-creation-expected.txt: Added (Taken from GTK port).

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped


Added Paths

trunk/LayoutTests/platform/efl/fast/events/js-keyboard-event-creation-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116623 => 116624)

--- trunk/LayoutTests/ChangeLog	2012-05-10 09:59:40 UTC (rev 116623)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 10:06:14 UTC (rev 116624)
@@ -1,3 +1,13 @@
+2012-05-10  Mikhail Pozdnyakov  mikhail.pozdnya...@intel.com
+
+[EFL][DRT] fast/events/js-keyboard-event-creation.html needs rebaselining
+https://bugs.webkit.org/show_bug.cgi?id=85485
+
+Unreviewed, fast/events/js-keyboard-event-creation.html is rebased.
+
+* platform/efl/Skipped: removed fast/events/js-keyboard-event-creation.html
+* platform/efl/fast/events/js-keyboard-event-creation-expected.txt: Added (Taken from GTK port).
+
 2012-05-10  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Unreviewed gardening. Skip news failing and crashing tests to paint the bot green.


Modified: trunk/LayoutTests/platform/efl/Skipped (116623 => 116624)

--- trunk/LayoutTests/platform/efl/Skipped	2012-05-10 09:59:40 UTC (rev 116623)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-05-10 10:06:14 UTC (rev 116624)
@@ -902,7 +902,6 @@
 fast/events/drag-parent-node.html
 
 # BUG: keyboard-related bugs, generally in the EventSender-PlatformKeyboardEventEfl interaction
-fast/events/js-keyboard-event-creation.html
 fast/events/key-events-in-input-button.html
 fast/events/key-events-in-input-text.html
 fast/events/option-tab.html


Added: trunk/LayoutTests/platform/efl/fast/events/js-keyboard-event-creation-expected.txt (0 => 116624)

--- trunk/LayoutTests/platform/efl/fast/events/js-keyboard-event-creation-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/efl/fast/events/js-keyboard-event-creation-expected.txt	2012-05-10 10:06:14 UTC (rev 116624)
@@ -0,0 +1,6 @@
+ 
+This tests that DOMKeyboardEvents are created correctly in the _javascript_ API.
+
+keydown - key: U+0009@0 (keyCode/charCode: 9/0) modifiers: false,false,false,false
+
+keyup - key: U+0009@0 (keyCode/charCode: 9/0) modifiers: false,false,true,false






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116625] trunk

[commit-queue]

Title: [116625] trunk








Revision 116625
Author commit-qu...@webkit.org
Date 2012-05-10 03:56:00 -0700 (Thu, 10 May 2012)


Log Message
[EFL][DRT] Clear added user style sheets before a new testcase execution.
https://bugs.webkit.org/show_bug.cgi?id=84792

Source/WebKit/efl:

Patch by Mikhail Pozdnyakov mikhail.pozdnya...@intel.com on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Add a helper function for clearing of the added user style sheets.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::clearUserStyleSheets):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Reviewed Gustavo Noronha Silva.

The added user style sheets from the previous testcases are cleared in order to avoid
flaky results.

Patch by Mikhail Pozdnyakov mikhail.pozdnya...@intel.com on 2012-05-10

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Patch by Mikhail Pozdnyakov mikhail.pozdnya...@intel.com on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Unskip userscripts/user-style-top-frame-only.html

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (116624 => 116625)

--- trunk/LayoutTests/ChangeLog	2012-05-10 10:06:14 UTC (rev 116624)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 10:56:00 UTC (rev 116625)
@@ -1,5 +1,16 @@
 2012-05-10  Mikhail Pozdnyakov  mikhail.pozdnya...@intel.com
 
+[EFL][DRT] Clear added user style sheets before a new testcase execution.
+https://bugs.webkit.org/show_bug.cgi?id=84792
+
+Reviewed by Gustavo Noronha Silva.
+
+Unskip userscripts/user-style-top-frame-only.html
+
+* platform/efl/Skipped:
+
+2012-05-10  Mikhail Pozdnyakov  mikhail.pozdnya...@intel.com
+
 [EFL][DRT] fast/events/js-keyboard-event-creation.html needs rebaselining
 https://bugs.webkit.org/show_bug.cgi?id=85485
 


Modified: trunk/LayoutTests/platform/efl/Skipped (116624 => 116625)

--- trunk/LayoutTests/platform/efl/Skipped	2012-05-10 10:06:14 UTC (rev 116624)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-05-10 10:56:00 UTC (rev 116625)
@@ -1336,7 +1336,6 @@
 http/tests/websocket/tests/hixie76/url-no-trailing-slash.html
 http/tests/websocket/tests/hixie76/url-with-credential.html
 http/tests/websocket/tests/hixie76/websocket-protocol-ignored.html
-userscripts/user-style-top-frame-only.html
 userscripts/window-onerror-for-isolated-world-2.html
 
 # Unexpected flakiness (tests timed out)


Modified: trunk/Source/WebKit/efl/ChangeLog (116624 => 116625)

--- trunk/Source/WebKit/efl/ChangeLog	2012-05-10 10:06:14 UTC (rev 116624)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-05-10 10:56:00 UTC (rev 116625)
@@ -1,3 +1,16 @@
+2012-05-10  Mikhail Pozdnyakov  mikhail.pozdnya...@intel.com
+
+[EFL][DRT] Clear added user style sheets before a new testcase execution.
+https://bugs.webkit.org/show_bug.cgi?id=84792
+
+Reviewed by Gustavo Noronha Silva.
+
+Add a helper function for clearing of the added user style sheets.
+
+* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+(DumpRenderTreeSupportEfl::clearUserStyleSheets):
+* WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
 2012-05-09  Gyuyoung Kim  gyuyoung@samsung.com
 
 Move suspendAnimations to use Internals interface.


Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (116624 => 116625)

--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-05-10 10:06:14 UTC (rev 116624)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-05-10 10:56:00 UTC (rev 116625)
@@ -397,6 +397,15 @@
 page-group().addUserStyleSheetToWorld(WebCore::mainThreadNormalWorld(), sourceCode, WebCore::KURL(), nullptr, nullptr, allFrames ? WebCore::InjectInAllFrames : WebCore::InjectInTopFrameOnly);
 }
 
+void DumpRenderTreeSupportEfl::clearUserStyleSheets(const Evas_Object* ewkView)
+{
+WebCore::Page* page = EWKPrivate::corePage(ewkView);
+if (!page)
+return;
+
+page-group().removeUserStyleSheetsFromWorld(WebCore::mainThreadNormalWorld());
+}
+
 void DumpRenderTreeSupportEfl::executeCoreCommandByName(const Evas_Object* ewkView, const char* name, const char* value)
 {
 WebCore::Page* page = EWKPrivate::corePage(ewkView);


Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (116624 => 116625)

--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-05-10 10:06:14 UTC (rev 116624)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-05-10 10:56:00 UTC (rev 116625)
@@ -73,6 +73,7 @@
 static void 

[webkit-changes] [116626] trunk

[vestbo]

Title: [116626] trunk








Revision 116626
Author ves...@webkit.org
Date 2012-05-10 04:12:25 -0700 (Thu, 10 May 2012)


Log Message
WebPageProxy::activeURL() should return the pending API request, even when there's no main frame

https://bugs.webkit.org/show_bug.cgi?id=85806

The m_pendingAPIRequestURL member is used (presumably) to mask over the async
nature of WebKit2, so that starting a load of a URL will reflect that URL
immedeatly from activeURL, even if the request has not been passed over to
the web process yet and reflected there.

This works well, except in the case of the initial request, where the main
frame creation happens on the web process side and is notified back to the
UI process. Until we've recived the notification we don't know about the main
frame, and this race condition will potentially give us an empty url instead
of the pending request.

To solve this we always return the pending API request if it's set, even
when there's no mainframe yet (that we known about).

Reviewed by Simon Hausmann.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116625 => 116626)

--- trunk/Source/WebKit2/ChangeLog	2012-05-10 10:56:00 UTC (rev 116625)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-10 11:12:25 UTC (rev 116626)
@@ -1,3 +1,26 @@
+2012-05-07  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
+https://bugs.webkit.org/show_bug.cgi?id=85806
+
+The m_pendingAPIRequestURL member is used (presumably) to mask over the async
+nature of WebKit2, so that starting a load of a URL will reflect that URL
+immedeatly from activeURL, even if the request has not been passed over to
+the web process yet and reflected there.
+
+This works well, except in the case of the initial request, where the main
+frame creation happens on the web process side and is notified back to the
+UI process. Until we've recived the notification we don't know about the main
+frame, and this race condition will potentially give us an empty url instead
+of the pending request.
+
+To solve this we always return the pending API request if it's set, even
+when there's no mainframe yet (that we known about).
+
+Reviewed by Simon Hausmann.
+
+* UIProcess/WebPageProxy.cpp:
+
 2012-05-09  Gyuyoung Kim  gyuyoung@samsung.com
 
 Move suspendAnimations to use Internals interface.


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (116625 => 116626)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2012-05-10 10:56:00 UTC (rev 116625)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2012-05-10 11:12:25 UTC (rev 116626)
@@ -660,13 +660,15 @@
 
 String WebPageProxy::activeURL() const
 {
+// If there is a currently pending url, it is the active URL,
+// even when there's no main frame yet, as it might be the
+// first API request.
+if (!m_pendingAPIRequestURL.isNull())
+return m_pendingAPIRequestURL;
+
 if (!m_mainFrame)
 return String();
 
-// If there is a currently pending url, it is the active URL.
-if (!m_pendingAPIRequestURL.isNull())
-return m_pendingAPIRequestURL;
-
 if (!m_mainFrame-unreachableURL().isEmpty())
 return m_mainFrame-unreachableURL();
 


Modified: trunk/Tools/ChangeLog (116625 => 116626)

--- trunk/Tools/ChangeLog	2012-05-10 10:56:00 UTC (rev 116625)
+++ trunk/Tools/ChangeLog	2012-05-10 11:12:25 UTC (rev 116626)
@@ -1,3 +1,26 @@
+2012-05-07  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
+https://bugs.webkit.org/show_bug.cgi?id=85806
+
+The m_pendingAPIRequestURL member is used (presumably) to mask over the async
+nature of WebKit2, so that starting a load of a URL will reflect that URL
+immedeatly from activeURL, even if the request has not been passed over to
+the web process yet and reflected there.
+
+This works well, except in the case of the initial request, where the main
+frame creation happens on the web process side and is notified back to the
+UI process. Until we've recived the notification we don't know about the main
+frame, and this race condition will potentially give us an empty url instead
+of the pending request.
+
+To solve this we always return the pending API request if it's set, even
+when there's no mainframe yet (that we known about).
+
+Reviewed by Simon Hausmann.
+
+* TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
+
 2012-05-10  Mikhail Pozdnyakov  mikhail.pozdnya...@intel.com
 
 [EFL][DRT] Clear added 

[webkit-changes] [116627] trunk/LayoutTests

[zandobersek]

Title: [116627] trunk/LayoutTests








Revision 116627
Author zandober...@gmail.com
Date 2012-05-10 04:21:01 -0700 (Thu, 10 May 2012)


Log Message
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, unskipping another batch of tests that are passing but have
test expectations present that indicate a failure is expected. Their
bug entries will be properly updated after they either remain stable and
passing or they backfire.

* platform/gtk/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116626 => 116627)

--- trunk/LayoutTests/ChangeLog	2012-05-10 11:12:25 UTC (rev 116626)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 11:21:01 UTC (rev 116627)
@@ -1,3 +1,15 @@
+2012-05-10  Zan Dobersek  zandober...@gmail.com
+
+[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
+https://bugs.webkit.org/show_bug.cgi?id=85591
+
+Unreviewed, unskipping another batch of tests that are passing but have
+test expectations present that indicate a failure is expected. Their
+bug entries will be properly updated after they either remain stable and
+passing or they backfire.
+
+* platform/gtk/test_expectations.txt:
+
 2012-05-10  Mikhail Pozdnyakov  mikhail.pozdnya...@intel.com
 
 [EFL][DRT] Clear added user style sheets before a new testcase execution.


Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (116626 => 116627)

--- trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-05-10 11:12:25 UTC (rev 116626)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-05-10 11:21:01 UTC (rev 116627)
@@ -146,7 +146,6 @@
 // Web Timing issues.
 BUGWKGTK : fast/dom/Window/window-properties-performance.html = FAIL
 BUGWKGTK : http/tests/misc/webtiming-origins.html = FAIL
-BUGWKGTK : http/tests/misc/webtiming-ssl.php = FAIL
 
 // FileSystem API is not supported.
 BUGWKGTK SKIP : fast/filesystem = FAIL
@@ -619,7 +618,6 @@
 // This port doesn't support v8 i18n extension.
 BUGWKGTK : fast/js/i18n-bindings-locale.html = FAIL
 
-BUGWKGTK : http/tests/appcache/fallback.html = FAIL
 BUGWKGTK : http/tests/appcache/origin-quota.html = FAIL
 BUGWKGTK : http/tests/appcache/origin-quota-continued-download.html = FAIL
 BUGWKGTK : http/tests/appcache/origin-quota-continued-download-multiple-manifests.html = FAIL
@@ -828,7 +826,6 @@
 
 // Need to dump context menu items on eventSender.contextClick(true).
 BUGWK39102 : editing/spelling/context-menu-suggestions.html = FAIL
-BUGWK39102 : editing/selection/context-menu-on-text.html = FAIL
 
 // Some input type=range tests fail because of the size
 // of the slider thumb in GTK+ themes.
@@ -1048,9 +1045,6 @@
 BUGWK44316 : platform/gtk/accessibility/title-and-alt.html = FAIL
 
 // viewport meta tag tests that differ from the Opera results
-BUGWKGTK : fast/viewport/viewport-65.html = FAIL
-BUGWKGTK : fast/viewport/viewport-82.html = FAIL
-BUGWKGTK : fast/viewport/viewport-84.html = FAIL
 BUGWKGTK : fast/viewport/viewport-87.html = FAIL
 BUGWKGTK : fast/viewport/viewport-126.html = FAIL
 BUGWKGTK : fast/viewport/viewport-127.html = FAIL
@@ -1151,9 +1145,6 @@
 BUGWK68979 : http/tests/multipart/stop-crash.html = FAIL
 BUGWK68979 : http/tests/multipart/load-last-non-html-frame.php = FAIL
 
-// REGRESSION(r96870): editing/pasteboard/smart-paste-008.html = FAIL fails on non-Mac
-BUGWK69587 : editing/pasteboard/smart-paste-008.html = FAIL
-
 // Fails because it does not throw a couple of expected exceptions
 BUGWKGTK : http/tests/local/fileapi/send-sliced-dragged-file.html = FAIL
 
@@ -1279,8 +1270,6 @@
 
 BUGWK83560 : fast/events/drop-with-file-paths.html = FAIL
 
-BUGWK83675 : fast/multicol/cell-shrinkback.html = FAIL
-
 // EditorClient::checkTextOfParagraph() is not implemented.
 BUGWKGTK : editing/spelling/spelling-marker-description.html = FAIL
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116628] trunk/LayoutTests

[ossy]

Title: [116628] trunk/LayoutTests








Revision 116628
Author o...@webkit.org
Date 2012-05-10 04:25:53 -0700 (Thu, 10 May 2012)


Log Message
[Qt][WK2] REGRESSION(r116560): It made 7 compositing tests fail
https://bugs.webkit.org/show_bug.cgi?id=86086

Unreviewed gardening, skip new failing tests.

* platform/qt-5.0-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-5.0-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (116627 => 116628)

--- trunk/LayoutTests/ChangeLog	2012-05-10 11:21:01 UTC (rev 116627)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 11:25:53 UTC (rev 116628)
@@ -1,3 +1,12 @@
+2012-05-10  Csaba Osztrogonác  o...@webkit.org
+
+[Qt][WK2] REGRESSION(r116560): It made 7 compositing tests fail
+https://bugs.webkit.org/show_bug.cgi?id=86086
+
+Unreviewed gardening, skip new failing tests.
+
+* platform/qt-5.0-wk2/Skipped:
+
 2012-05-10  Zan Dobersek  zandober...@gmail.com
 
 [Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt


Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (116627 => 116628)

--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-05-10 11:21:01 UTC (rev 116627)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-05-10 11:25:53 UTC (rev 116628)
@@ -599,3 +599,13 @@
 fast/sub-pixel/client-width-height-snapping.html
 fast/sub-pixel/layout-boxes-with-zoom.html
 fast/sub-pixel/size-of-box-with-zoom.html
+
+# [Qt] REGRESSION(r116560): It made 7 compositing tests fail
+# https://bugs.webkit.org/show_bug.cgi?id=86086
+compositing/rtl/rtl-absolute-overflow.html
+compositing/rtl/rtl-fixed-overflow-scrolled.html
+compositing/rtl/rtl-fixed-overflow.html
+compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
+compositing/rtl/rtl-iframe-absolute-overflow.html
+compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
+compositing/rtl/rtl-iframe-fixed-overflow.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116629] trunk/Source/WebCore

[morrita]

Title: [116629] trunk/Source/WebCore








Revision 116629
Author morr...@google.com
Date 2012-05-10 04:37:09 -0700 (Thu, 10 May 2012)


Log Message
Remove support for Node::willRemove()
https://bugs.webkit.org/show_bug.cgi?id=55209

Reviewed by Ryosuke Niwa.

This change de-virtualizes Node::willRemove(), gains
5% speedup on Dromaeo dom-modify.

Originally there were 5 willRemove() overrides:
- Element
- HTMLStyleElement
- HTMLSourceElement
- HTMLTrackElement
- HTMLFrameOwnerElement

For first 4 items, this change moves their implementations to
Node::removedFrom() overrides.

Then HTMLFrameOwnerElement is the only class which needs the
notification.  Because it emits the unload event, it needs some
notification _before_ its removal. To handle that, this change
introduces ChildFrameDisconnector which collects
corresponding decendant elements and disconnect their content frame.

Even though this approach doesn't kill pre-removal tree traversal
completely, it's a bit more efficient due to the de-virtualization.

No new tests. Covered by existing test.

* dom/ContainerNode.cpp:
(WebCore::willRemoveChild): Replaced willRemove() call with ChildFrameDisconnector.
(WebCore::willRemoveChildren): Ditto.
(WebCore::ContainerNode::disconnectDescendantFrames): Added. Used from FrameLoader to replace Document::willRemove() call.
(WebCore):
* dom/ContainerNode.h:
(ContainerNode):
* dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildFrameDisconnector::collectDescendant):
(WebCore):
(WebCore::ChildFrameDisconnector::Target::disconnect):
* dom/ContainerNodeAlgorithms.h:
(ChildFrameDisconnector):
(Target):
(WebCore::ChildFrameDisconnector::Target::Target):
(WebCore::ChildFrameDisconnector::Target::isValid):
(WebCore):
(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::collectDescendant):
(WebCore::ChildFrameDisconnector::disconnect):
* dom/Element.cpp:
(WebCore::Element::removedFrom):
* dom/Element.h:
* dom/ElementShadow.cpp:
* dom/ElementShadow.h:
(ElementShadow):
* dom/Node.cpp:
* dom/Node.h: Added IsFrameOwnerElement flag to de-virtualize IsFrameOwnerElement().
(WebCore::Node::isFrameOwnerElement): De-virtualized.
(Node):
* html/HTMLElement.h:
(HTMLElement):
(WebCore::HTMLElement::HTMLElement):
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame): Extracted from original willRemove().
* html/HTMLFrameOwnerElement.h:
(HTMLFrameOwnerElement):
(WebCore::toFrameOwnerElement):
(WebCore):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::sourceWasRemoved): Renamed from sourceWillBeRemoved(), dealing with the timing change.
* html/HTMLMediaElement.h:
(HTMLMediaElement):
(WebCore::isMediaElement):
(WebCore):
(WebCore::toMediaElement):
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::removedFrom): Moved some code from willRemove().
* html/HTMLSourceElement.h:
(HTMLSourceElement):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::removedFrom):
(WebCore):
* html/HTMLStyleElement.h:
(HTMLStyleElement):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::removedFrom): Moved some code from willRemove().
* html/HTMLTrackElement.h:
(HTMLTrackElement):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/ContainerNodeAlgorithms.cpp
trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ElementShadow.cpp
trunk/Source/WebCore/dom/ElementShadow.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/html/HTMLElement.h
trunk/Source/WebCore/html/HTMLFrameOwnerElement.cpp
trunk/Source/WebCore/html/HTMLFrameOwnerElement.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLSourceElement.cpp
trunk/Source/WebCore/html/HTMLSourceElement.h
trunk/Source/WebCore/html/HTMLStyleElement.cpp
trunk/Source/WebCore/html/HTMLStyleElement.h
trunk/Source/WebCore/html/HTMLTrackElement.cpp
trunk/Source/WebCore/html/HTMLTrackElement.h
trunk/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116628 => 116629)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 11:25:53 UTC (rev 116628)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 11:37:09 UTC (rev 116629)
@@ -1,3 +1,97 @@
+2012-05-10  MORITA Hajime  morr...@google.com
+
+Remove support for Node::willRemove()
+https://bugs.webkit.org/show_bug.cgi?id=55209
+
+Reviewed by Ryosuke Niwa.
+
+This change de-virtualizes Node::willRemove(), gains
+5% speedup on Dromaeo dom-modify.
+
+Originally there were 5 willRemove() overrides:
+- Element
+- HTMLStyleElement
+- 

[webkit-changes] [116630] trunk

[commit-queue]

Title: [116630] trunk








Revision 116630
Author commit-qu...@webkit.org
Date 2012-05-10 04:56:35 -0700 (Thu, 10 May 2012)


Log Message
[EFL][DRT] EventSender - set delayed event information if it was not set before
https://bugs.webkit.org/show_bug.cgi?id=85972

Patch by Alexander Shalamov alexander.shala...@intel.com on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Tools:

Reset delayed event information if it is missing.

* DumpRenderTree/efl/EventSender.cpp:
(feedOrQueueMouseEvent):

LayoutTests:

Unskipping layout tests that were skipped because of the bug.

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/EventSender.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (116629 => 116630)

--- trunk/LayoutTests/ChangeLog	2012-05-10 11:37:09 UTC (rev 116629)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 11:56:35 UTC (rev 116630)
@@ -1,3 +1,14 @@
+2012-05-10  Alexander Shalamov  alexander.shala...@intel.com
+
+[EFL][DRT] EventSender - set delayed event information if it was not set before
+https://bugs.webkit.org/show_bug.cgi?id=85972
+
+Reviewed by Gustavo Noronha Silva.
+
+Unskipping layout tests that were skipped because of the bug.
+
+* platform/efl/Skipped:
+
 2012-05-10  Csaba Osztrogonác  o...@webkit.org
 
 [Qt][WK2] REGRESSION(r116560): It made 7 compositing tests fail


Modified: trunk/LayoutTests/platform/efl/Skipped (116629 => 116630)

--- trunk/LayoutTests/platform/efl/Skipped	2012-05-10 11:37:09 UTC (rev 116629)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-05-10 11:56:35 UTC (rev 116630)
@@ -81,7 +81,6 @@
 editing/selection/4895428-1.html
 editing/selection/4895428-4.html
 editing/selection/5333725.html
-editing/selection/caret-ltr-2-left.html
 editing/selection/caret-ltr-2.html
 editing/selection/caret-ltr-right.html
 editing/selection/caret-ltr.html
@@ -126,17 +125,12 @@
 fast/events/selectstart-by-drag.html
 fast/events/standalone-image-drag-to-editable.html
 fast/events/touch/touch-gesture-click.html
-fast/events/zoom-dblclick.html
 fast/forms/drag-into-textarea.html
 fast/forms/drag-out-of-textarea.html
 fast/forms/focus-change-on-keypress.html
 fast/forms/search-cancel-button-mouseup.html
 fast/forms/search-disabled-readonly.html
 fast/forms/textfield-drag-into-disabled.html
-fast/frames/frame-programmatic-noresize.html
-fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
-fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html
-fast/forms/type-after-focus-rule-shrink-width.html
 fast/lists/drag-into-marker.html
 fast/table/click-near-anonymous-table.html
 fast/text/offsetForPosition-complex-fallback.html


Modified: trunk/Tools/ChangeLog (116629 => 116630)

--- trunk/Tools/ChangeLog	2012-05-10 11:37:09 UTC (rev 116629)
+++ trunk/Tools/ChangeLog	2012-05-10 11:56:35 UTC (rev 116630)
@@ -1,3 +1,15 @@
+2012-05-10  Alexander Shalamov  alexander.shala...@intel.com
+
+[EFL][DRT] EventSender - set delayed event information if it was not set before
+https://bugs.webkit.org/show_bug.cgi?id=85972
+
+Reviewed by Gustavo Noronha Silva.
+
+Reset delayed event information if it is missing.
+
+* DumpRenderTree/efl/EventSender.cpp:
+(feedOrQueueMouseEvent):
+
 2012-05-07  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 WebPageProxy::activeURL() should return the pending API request, even when there's no main frame


Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (116629 => 116630)

--- trunk/Tools/DumpRenderTree/efl/EventSender.cpp	2012-05-10 11:37:09 UTC (rev 116629)
+++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp	2012-05-10 11:56:35 UTC (rev 116630)
@@ -651,9 +651,9 @@
 {
 if (!delayedEventQueue().isEmpty()) {
 if (delayedEventQueue().last().eventInfo)
+delayedEventQueue().append(DelayedEvent(eventInfo));
+else
 delayedEventQueue().last().eventInfo = eventInfo;
-else
-delayedEventQueue().append(DelayedEvent(eventInfo));
 
 if (strategy == FeedQueuedEvents)
 feedQueuedMouseEvents();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116631] trunk/Source/WebKit/qt

[vestbo]

Title: [116631] trunk/Source/WebKit/qt








Revision 116631
Author ves...@webkit.org
Date 2012-05-10 05:09:30 -0700 (Thu, 10 May 2012)


Log Message
[Qt] Fix \sa usage in documentation

Ensure comma between elements (6 missing).

Patch by Marius Storm-Olsen marius.storm-ol...@nokia.com on 2012-05-10
Reviewed by Tor Arne Vestbø.

Modified Paths

trunk/Source/WebKit/qt/Api/qwebpage.cpp
trunk/Source/WebKit/qt/ChangeLog




Diff

Modified: trunk/Source/WebKit/qt/Api/qwebpage.cpp (116630 => 116631)

--- trunk/Source/WebKit/qt/Api/qwebpage.cpp	2012-05-10 11:56:35 UTC (rev 116630)
+++ trunk/Source/WebKit/qt/Api/qwebpage.cpp	2012-05-10 12:09:30 UTC (rev 116631)
@@ -3407,7 +3407,7 @@
 
 \inmodule QtWebKit
 
-\sa QWebPage::extension() QWebPage::ExtensionReturn
+\sa QWebPage::extension(), QWebPage::ExtensionReturn
 */
 
 
@@ -3418,7 +3418,7 @@
 
 \inmodule QtWebKit
 
-\sa QWebPage::extension() QWebPage::ExtensionOption
+\sa QWebPage::extension(), QWebPage::ExtensionOption
 */
 
 /*!
@@ -3434,7 +3434,7 @@
 
 The error itself is reported by an error \a domain, the \a error code as well as \a errorString.
 
-\sa QWebPage::extension() QWebPage::ErrorPageExtensionReturn
+\sa QWebPage::extension(), QWebPage::ErrorPageExtensionReturn
 */
 
 /*!
@@ -3481,7 +3481,7 @@
 External objects such as stylesheets or images referenced in the HTML are located relative to
 \a baseUrl.
 
-\sa QWebPage::extension() QWebPage::ErrorPageExtensionOption, QString::toUtf8()
+\sa QWebPage::extension(), QWebPage::ErrorPageExtensionOption, QString::toUtf8()
 */
 
 /*!
@@ -3524,7 +3524,7 @@
 The ChooseMultipleFilesExtensionOption class holds the frame originating the request
 and the suggested filenames which might be provided.
 
-\sa QWebPage::extension() QWebPage::chooseFile(), QWebPage::ChooseMultipleFilesExtensionReturn
+\sa QWebPage::extension(), QWebPage::chooseFile(), QWebPage::ChooseMultipleFilesExtensionReturn
 */
 
 /*!
@@ -3553,7 +3553,7 @@
 The ChooseMultipleFilesExtensionReturn class holds the filenames selected by the user
 when the extension is invoked.
 
-\sa QWebPage::extension() QWebPage::ChooseMultipleFilesExtensionOption
+\sa QWebPage::extension(), QWebPage::ChooseMultipleFilesExtensionOption
 */
 
 /*!


Modified: trunk/Source/WebKit/qt/ChangeLog (116630 => 116631)

--- trunk/Source/WebKit/qt/ChangeLog	2012-05-10 11:56:35 UTC (rev 116630)
+++ trunk/Source/WebKit/qt/ChangeLog	2012-05-10 12:09:30 UTC (rev 116631)
@@ -1,3 +1,13 @@
+2012-05-10  Marius Storm-Olsen  marius.storm-ol...@nokia.com
+
+[Qt] Fix \sa usage in documentation
+
+Ensure comma between elements (6 missing).
+
+Reviewed by Tor Arne Vestbø.
+
+* Api/qwebpage.cpp:
+
 2012-05-09  Gyuyoung Kim  gyuyoung@samsung.com
 
 Move suspendAnimations to use Internals interface.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116632] trunk/Source

[kenneth]

Title: [116632] trunk/Source








Revision 116632
Author kenn...@webkit.org
Date 2012-05-10 05:20:04 -0700 (Thu, 10 May 2012)


Log Message
[Qt] Implement fit-to-width behaviour
https://bugs.webkit.org/show_bug.cgi?id=86085

Reviewed by Simon Hausmann.

Source/WebCore:

Add a method to get the minimum scale factor that contains the content
without showing any chrome background.

* dom/ViewportArguments.cpp:
(WebCore::computeMinimumScaleFactorForContentContained):
(WebCore):
* dom/ViewportArguments.h:
(WebCore):

Source/WebKit2:

We don't restrict the minimum scale to the layout viewport anymore,
but instead update the minimum scale when the content size changes.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
* UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ViewportArguments.cpp
trunk/Source/WebCore/dom/ViewportArguments.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116631 => 116632)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 12:09:30 UTC (rev 116631)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 12:20:04 UTC (rev 116632)
@@ -1,3 +1,19 @@
+2012-05-10  Kenneth Rohde Christiansen  kenn...@webkit.org
+
+[Qt] Implement fit-to-width behaviour
+https://bugs.webkit.org/show_bug.cgi?id=86085
+
+Reviewed by Simon Hausmann.
+
+Add a method to get the minimum scale factor that contains the content
+without showing any chrome background.
+
+* dom/ViewportArguments.cpp:
+(WebCore::computeMinimumScaleFactorForContentContained):
+(WebCore):
+* dom/ViewportArguments.h:
+(WebCore):
+
 2012-05-10  MORITA Hajime  morr...@google.com
 
 Remove support for Node::willRemove()


Modified: trunk/Source/WebCore/dom/ViewportArguments.cpp (116631 => 116632)

--- trunk/Source/WebCore/dom/ViewportArguments.cpp	2012-05-10 12:09:30 UTC (rev 116631)
+++ trunk/Source/WebCore/dom/ViewportArguments.cpp	2012-05-10 12:20:04 UTC (rev 116632)
@@ -185,6 +185,19 @@
 return result;
 }
 
+float computeMinimumScaleFactorForContentContained(const ViewportAttributes result, const IntSize viewportSize, const IntSize contentsSize)
+{
+float availableWidth = viewportSize.width();
+float availableHeight = viewportSize.height();
+
+if (result.devicePixelRatio != 1.0) {
+availableWidth /= result.devicePixelRatio;
+availableHeight /= result.devicePixelRatio;
+}
+
+return maxfloat(result.minimumScale, max(availableWidth / contentsSize.width(), availableHeight / contentsSize.height()));
+}
+
 void restrictMinimumScaleFactorToViewportSize(ViewportAttributes result, IntSize visibleViewport)
 {
 float availableWidth = visibleViewport.width();


Modified: trunk/Source/WebCore/dom/ViewportArguments.h (116631 => 116632)

--- trunk/Source/WebCore/dom/ViewportArguments.h	2012-05-10 12:09:30 UTC (rev 116631)
+++ trunk/Source/WebCore/dom/ViewportArguments.h	2012-05-10 12:20:04 UTC (rev 116632)
@@ -109,6 +109,7 @@
 ViewportAttributes computeViewportAttributes(ViewportArguments args, int desktopWidth, int deviceWidth, int deviceHeight, int deviceDPI, IntSize visibleViewport);
 void restrictMinimumScaleFactorToViewportSize(ViewportAttributes result, IntSize visibleViewport);
 void restrictScaleFactorToInitialScaleIfNotUserScalable(ViewportAttributes result);
+float computeMinimumScaleFactorForContentContained(const ViewportAttributes result, const IntSize viewportSize, const IntSize contentSize);
 
 void setViewportFeature(const String keyString, const String valueString, Document*, void* data);
 void reportViewportWarning(Document*, ViewportErrorCode, const String replacement1, const String replacement2);


Modified: trunk/Source/WebKit2/ChangeLog (116631 => 116632)

--- trunk/Source/WebKit2/ChangeLog	2012-05-10 12:09:30 UTC (rev 116631)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-10 12:20:04 UTC (rev 116632)
@@ -1,3 +1,22 @@
+2012-05-10  Kenneth Rohde Christiansen  kenn...@webkit.org
+
+[Qt] Implement fit-to-width behaviour
+https://bugs.webkit.org/show_bug.cgi?id=86085
+
+Reviewed by Simon Hausmann.
+
+We don't restrict the minimum scale to the layout viewport anymore,
+but instead update the minimum scale when the content size changes.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
+(QQuickWebViewFlickablePrivate::didChangeContentsSize):
+* UIProcess/API/qt/qwebviewportinfo.cpp:
+ 

[webkit-changes] [116633] trunk

[commit-queue]

Title: [116633] trunk








Revision 116633
Author commit-qu...@webkit.org
Date 2012-05-10 05:28:18 -0700 (Thu, 10 May 2012)


Log Message
[EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
https://bugs.webkit.org/show_bug.cgi?id=82864

Patch by Alexander Shalamov alexander.shala...@intel.com on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Add missing implementation for setTabKeyCyclesThroughElements to EFL's
DumpRenderTreeSupport.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation for setTabKeyCyclesThroughElements to EFL's LayoutTestController
in order to unskip fast/events/keypress-insert-tab.html

* DumpRenderTree/efl/EventSender.cpp:
(keyDownCallback):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setTabKeyCyclesThroughElements):

LayoutTests:

Unskip fast/events/keypress-insert-tab.html

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
trunk/Tools/DumpRenderTree/efl/EventSender.cpp
trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (116632 => 116633)

--- trunk/LayoutTests/ChangeLog	2012-05-10 12:20:04 UTC (rev 116632)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 12:28:18 UTC (rev 116633)
@@ -1,5 +1,16 @@
 2012-05-10  Alexander Shalamov  alexander.shala...@intel.com
 
+[EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
+https://bugs.webkit.org/show_bug.cgi?id=82864
+
+Reviewed by Gustavo Noronha Silva.
+
+Unskip fast/events/keypress-insert-tab.html
+
+* platform/efl/Skipped:
+
+2012-05-10  Alexander Shalamov  alexander.shala...@intel.com
+
 [EFL][DRT] EventSender - set delayed event information if it was not set before
 https://bugs.webkit.org/show_bug.cgi?id=85972
 


Modified: trunk/LayoutTests/platform/efl/Skipped (116632 => 116633)

--- trunk/LayoutTests/platform/efl/Skipped	2012-05-10 12:20:04 UTC (rev 116632)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-05-10 12:28:18 UTC (rev 116633)
@@ -249,9 +249,6 @@
 editing/selection/selection-background.html
 fast/dom/Window/window-onFocus.html
 
-# EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements
-fast/events/keypress-insert-tab.html
-
 # EFL's LayoutTestController does not implement setUseDashboardCompatibilityMode
 fast/canvas/canvas-gradient-addStop-error.html
 fast/canvas/fill-stroke-clip-reset-path.html


Modified: trunk/Source/WebKit/efl/ChangeLog (116632 => 116633)

--- trunk/Source/WebKit/efl/ChangeLog	2012-05-10 12:20:04 UTC (rev 116632)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-05-10 12:28:18 UTC (rev 116633)
@@ -1,3 +1,17 @@
+2012-05-10  Alexander Shalamov  alexander.shala...@intel.com
+
+[EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
+https://bugs.webkit.org/show_bug.cgi?id=82864
+
+Reviewed by Gustavo Noronha Silva.
+
+Add missing implementation for setTabKeyCyclesThroughElements to EFL's
+DumpRenderTreeSupport.
+
+* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+(DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements):
+* WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
 2012-05-10  Mikhail Pozdnyakov  mikhail.pozdnya...@intel.com
 
 [EFL][DRT] Clear added user style sheets before a new testcase execution.


Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (116632 => 116633)

--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-05-10 12:20:04 UTC (rev 116632)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-05-10 12:28:18 UTC (rev 116633)
@@ -478,6 +478,15 @@
 editorClient-setSelectTrailingWhitespaceEnabled(enabled);
 }
 
+void DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles)
+{
+WebCore::Page* page = EWKPrivate::corePage(ewkView);
+if (!page)
+return;
+
+page-setTabKeyCyclesThroughElements(cycles);
+}
+
 void DumpRenderTreeSupportEfl::garbageCollectorCollect()
 {
 WebCore::gcController().garbageCollectNow();


Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (116632 => 116633)

--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-05-10 12:20:04 UTC (rev 116632)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-05-10 12:28:18 UTC (rev 116633)
@@ -80,6 +80,7 @@
 static void setJavaScriptProfilingEnabled(const Evas_Object* 

[webkit-changes] [116634] trunk/Source/WebKit2

[jocelyn . turcotte]

Title: [116634] trunk/Source/WebKit2








Revision 116634
Author jocelyn.turco...@nokia.com
Date 2012-05-10 05:38:56 -0700 (Thu, 10 May 2012)


Log Message
[Qt] Fix sites with a viewport meta tag when devicePixelRatio isn't explicitely set on the WebView
https://bugs.webkit.org/show_bug.cgi?id=86002

Reviewed by Kenneth Rohde Christiansen.

The preference was recently changed to a double ratio, but was still left under
FOR_EACH_WEBKIT_UINT32_PREFERENCE and was initialized to inf instead of 1.0.
This would cause the viewport constraints to apply a multi-millionaire device
pixel ratio and make the contents invisible.

This moves it with other double preferences under FOR_EACH_WEBKIT_DOUBLE_PREFERENCE.

* Shared/WebPreferencesStore.h:
(WebKit):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116633 => 116634)

--- trunk/Source/WebKit2/ChangeLog	2012-05-10 12:28:18 UTC (rev 116633)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-10 12:38:56 UTC (rev 116634)
@@ -1,3 +1,20 @@
+2012-05-10  Jocelyn Turcotte  jocelyn.turco...@nokia.com
+
+[Qt] Fix sites with a viewport meta tag when devicePixelRatio isn't explicitely set on the WebView
+https://bugs.webkit.org/show_bug.cgi?id=86002
+
+Reviewed by Kenneth Rohde Christiansen.
+
+The preference was recently changed to a double ratio, but was still left under
+FOR_EACH_WEBKIT_UINT32_PREFERENCE and was initialized to inf instead of 1.0.
+This would cause the viewport constraints to apply a multi-millionaire device
+pixel ratio and make the contents invisible.
+
+This moves it with other double preferences under FOR_EACH_WEBKIT_DOUBLE_PREFERENCE.
+
+* Shared/WebPreferencesStore.h:
+(WebKit):
+
 2012-05-10  Kenneth Rohde Christiansen  kenn...@webkit.org
 
 [Qt] Implement fit-to-width behaviour


Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (116633 => 116634)

--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2012-05-10 12:28:18 UTC (rev 116633)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2012-05-10 12:38:56 UTC (rev 116634)
@@ -115,6 +115,7 @@
 \
 
 #define FOR_EACH_WEBKIT_DOUBLE_PREFERENCE(macro) \
+macro(DevicePixelRatio, devicePixelRatio, Double, double, 1.0) \
 macro(PDFScaleFactor, pdfScaleFactor, Double, double, 0) \
 \
 
@@ -131,7 +132,6 @@
 macro(DefaultFontSize, defaultFontSize, UInt32, uint32_t, 16) \
 macro(DefaultFixedFontSize, defaultFixedFontSize, UInt32, uint32_t, 13) \
 macro(LayoutFallbackWidth, layoutFallbackWidth, UInt32, uint32_t, 980) \
-macro(DevicePixelRatio, devicePixelRatio, Double, double, 1.0) \
 macro(DeviceWidth, deviceWidth, UInt32, uint32_t, 480) \
 macro(DeviceHeight, deviceHeight, UInt32, uint32_t, 854) \
 macro(PDFDisplayMode, pdfDisplayMode, UInt32, uint32_t, 1) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116635] trunk/LayoutTests

[commit-queue]

Title: [116635] trunk/LayoutTests








Revision 116635
Author commit-qu...@webkit.org
Date 2012-05-10 05:55:38 -0700 (Thu, 10 May 2012)


Log Message
[EFL] Gardening of flaky tests
https://bugs.webkit.org/show_bug.cgi?id=86069

Unreviewed gardening.

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-05-10

* platform/efl/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116634 => 116635)

--- trunk/LayoutTests/ChangeLog	2012-05-10 12:38:56 UTC (rev 116634)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 12:55:38 UTC (rev 116635)
@@ -1,3 +1,12 @@
+2012-05-10  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[EFL] Gardening of flaky tests
+https://bugs.webkit.org/show_bug.cgi?id=86069
+
+Unreviewed gardening.
+
+* platform/efl/test_expectations.txt:
+
 2012-05-10  Alexander Shalamov  alexander.shala...@intel.com
 
 [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements


Modified: trunk/LayoutTests/platform/efl/test_expectations.txt (116634 => 116635)

--- trunk/LayoutTests/platform/efl/test_expectations.txt	2012-05-10 12:38:56 UTC (rev 116634)
+++ trunk/LayoutTests/platform/efl/test_expectations.txt	2012-05-10 12:55:38 UTC (rev 116635)
@@ -64,8 +64,6 @@
 BUGWKEFL SKIP : storage/storageinfo-query-usage.html = FAIL
 BUGWKEFL SKIP : storage/storageinfo-request-quota.html = FAIL
 
-BUGWK59801 : fast/workers/storage/use-same-database-in-page-and-workers.html = TEXT TIMEOUT PASS
-
 // EFL's LayoutTestController does not implement originsWithLocalStorage.
 BUGWKEFL SKIP : storage/domstorage/localstorage/storagetracker = FAIL
 
@@ -186,9 +184,6 @@
 BUGWK84777 : ietestcenter/css3/multicolumn/column-width-applies-to-015.htm = IMAGE
 BUGWK84778 : ietestcenter/css3/multicolumn/column-width-negative-001.htm = IMAGE
 
-// Test doesn't work when the machine is under heavy load.
-BUGWK85180 : media/audio-delete-while-step-button-clicked.html = TEXT PASS
-
 // Turn on blob support for the EFL port.
 BUGWK85363 : fast/dom/DOMURL/check-instanceof-domurl-functions.html = TEXT
 BUGWK85363 : fast/dom/call-a-constructor-as-a-function.html = TEXT
@@ -401,3 +396,26 @@
 BUGWK85879 : fast/frames/frame-crash-with-page-cache.html = CRASH
 
 BUGWK85995 : fast/events/frame-click-focus.html = TEXT
+
+BUGWKEFL SLOW DEBUG : http/tests/incremental/slow-utf8-html.pl = PASS
+
+// Perf tests are way too slow on debug builds.
+WONTFIX DEBUG : perf/adding-radio-buttons.html = FAIL PASS
+WONTFIX DEBUG : perf/array-binary-search.html = FAIL PASS
+WONTFIX DEBUG : perf/mouse-event.html = FAIL PASS
+
+// Flaky tests.
+BUGWK85603 : fast/forms/textarea-placeholder-set-attribute.html = TEXT PASS
+BUGWK59801 : fast/workers/storage/use-same-database-in-page-and-workers.html = FAIL PASS
+BUGWK83878 : media/track/track-mode.html = TEXT PASS
+BUGWK85180 : media/audio-delete-while-step-button-clicked.html = TEXT PASS
+BUGWK86072 : media/sources-fallback-codecs.html = FAIL PASS
+BUGWK86073 : ietestcenter/css3/flexbox/flexbox-layout-001.htm = IMAGE PASS
+BUGWK86073 : ietestcenter/css3/flexbox/flexbox-layout-003.htm = IMAGE PASS
+BUGWK86074 : media/svg-as-image-with-media-blocked.html = CRASH PASS
+BUGWK86075 : fast/events/message-port-close.html = CRASH PASS
+BUGWK86078 : http/tests/misc/favicon-loads-with-icon-loading-override.html = TEXT PASS
+BUGWK86079 : http/tests/misc/link-rel-icon-beforeload.html = TEXT PASS
+BUGWK86081 : loader/navigation-while-deferring-loads.html = TEXT PASS
+BUGWK86082 : security/block-test.html = TEXT PASS
+BUGWK86084 : svg/dom/SVGScriptElement/script-onerror-bubbling.svg = TEXT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116637] trunk/Source/WebCore

[alexis . menard]

Title: [116637] trunk/Source/WebCore








Revision 116637
Author alexis.men...@openbossa.org
Date 2012-05-10 06:19:08 -0700 (Thu, 10 May 2012)


Log Message
[Qt] Avoid string conversions to construct a QUrl when using Qt5.
https://bugs.webkit.org/show_bug.cgi?id=86006

Reviewed by Kenneth Rohde Christiansen.

In Qt5, the QUrl constructor can handle the string directly, even in UTF-16 because the
constructor QUrl(QString) has been fixed. Unfortunately we still need to use the old
code path when building with Qt4.

No new tests : it's a performance improvement which should be covered by tests.

* platform/qt/KURLQt.cpp:
(WebCore::KURL::operator QUrl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/KURLQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116636 => 116637)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 13:15:47 UTC (rev 116636)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 13:19:08 UTC (rev 116637)
@@ -1,3 +1,19 @@
+2012-05-10  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Avoid string conversions to construct a QUrl when using Qt5.
+https://bugs.webkit.org/show_bug.cgi?id=86006
+
+Reviewed by Kenneth Rohde Christiansen.
+
+In Qt5, the QUrl constructor can handle the string directly, even in UTF-16 because the
+constructor QUrl(QString) has been fixed. Unfortunately we still need to use the old
+code path when building with Qt4.
+
+No new tests : it's a performance improvement which should be covered by tests.
+
+* platform/qt/KURLQt.cpp:
+(WebCore::KURL::operator QUrl):
+
 2012-05-10  Noel Gordon  noel.gor...@gmail.com
 
 [chromium] REGRESSION(r107389) Visible line artifacts on some JPEG images


Modified: trunk/Source/WebCore/platform/qt/KURLQt.cpp (116636 => 116637)

--- trunk/Source/WebCore/platform/qt/KURLQt.cpp	2012-05-10 13:15:47 UTC (rev 116636)
+++ trunk/Source/WebCore/platform/qt/KURLQt.cpp	2012-05-10 13:19:08 UTC (rev 116637)
@@ -34,11 +34,15 @@
 
 KURL::operator QUrl() const
 {
+#if QT_VERSION  QT_VERSION_CHECK(5, 0, 0)
 QString str = QString::fromRawData(reinterpret_castconst QChar*(m_string.characters()), m_string.length());
 QByteArray ba = str.toUtf8();
 
 QUrl url = ""
 return url;
+#else
+return QUrl(m_string);
+#endif
 }
 
 String KURL::fileSystemPath() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116638] trunk/Tools

[commit-queue]

Title: [116638] trunk/Tools








Revision 116638
Author commit-qu...@webkit.org
Date 2012-05-10 06:42:54 -0700 (Thu, 10 May 2012)


Log Message
[EFL] Memory leaks found in EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=85889

Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
created with JSStringCreateWithUTF8CString.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWindowObjectCleared):
* DumpRenderTree/efl/EventSender.cpp:
(modifiersFromJSValue):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
trunk/Tools/DumpRenderTree/efl/EventSender.cpp




Diff

Modified: trunk/Tools/ChangeLog (116637 => 116638)

--- trunk/Tools/ChangeLog	2012-05-10 13:19:08 UTC (rev 116637)
+++ trunk/Tools/ChangeLog	2012-05-10 13:42:54 UTC (rev 116638)
@@ -1,3 +1,18 @@
+2012-05-10  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
+
+[EFL] Memory leaks found in EFL DRT
+https://bugs.webkit.org/show_bug.cgi?id=85889
+
+Reviewed by Gustavo Noronha Silva.
+
+Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
+created with JSStringCreateWithUTF8CString.
+
+* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+(DumpRenderTreeChrome::onWindowObjectCleared):
+* DumpRenderTree/efl/EventSender.cpp:
+(modifiersFromJSValue):
+
 2012-05-10  Alexander Shalamov  alexander.shala...@intel.com
 
 [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements


Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (116637 => 116638)

--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp	2012-05-10 13:19:08 UTC (rev 116637)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp	2012-05-10 13:42:54 UTC (rev 116638)
@@ -367,7 +367,7 @@
 gcController-makeWindowObject(objectClearedInfo-context, objectClearedInfo-windowObject, exception);
 ASSERT(!exception);
 
-JSRetainPtrJSStringRef controllerName(JSStringCreateWithUTF8CString(eventSender));
+JSRetainPtrJSStringRef controllerName(Adopt, JSStringCreateWithUTF8CString(eventSender));
 JSObjectSetProperty(objectClearedInfo-context, objectClearedInfo-windowObject,
 controllerName.get(),
 makeEventSender(objectClearedInfo-context, !DumpRenderTreeSupportEfl::frameParent(objectClearedInfo-frame)),


Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (116637 => 116638)

--- trunk/Tools/DumpRenderTree/efl/EventSender.cpp	2012-05-10 13:19:08 UTC (rev 116637)
+++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp	2012-05-10 13:42:54 UTC (rev 116638)
@@ -236,7 +236,8 @@
 return EvasKeyModifierNone;
 
 unsigned modifier = 0;
-int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, JSStringCreateWithUTF8CString(length), 0), 0);
+JSRetainPtrJSStringRef lengthProperty(Adopt, JSStringCreateWithUTF8CString(length));
+int modifiersCount = JSValueToNumber(context, JSObjectGetProperty(context, modifiersArray, lengthProperty.get(), 0), 0);
 for (int i = 0; i  modifiersCount; ++i)
 modifier |= static_castunsigned(modifierFromJSValue(context, JSObjectGetPropertyAtIndex(context, modifiersArray, i, 0)));
 return static_castEvasKeyModifier(modifier);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116639] trunk

[commit-queue]

Title: [116639] trunk








Revision 116639
Author commit-qu...@webkit.org
Date 2012-05-10 06:48:47 -0700 (Thu, 10 May 2012)


Log Message
Unreviewed, rolling out r116633.
http://trac.webkit.org/changeset/116633
https://bugs.webkit.org/show_bug.cgi?id=86093

Breaks EFL tests (Requested by kov on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-05-10

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/EventSender.cpp:
(keyDownCallback):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setTabKeyCyclesThroughElements):

LayoutTests:

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
trunk/Tools/DumpRenderTree/efl/EventSender.cpp
trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (116638 => 116639)

--- trunk/LayoutTests/ChangeLog	2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 13:48:47 UTC (rev 116639)
@@ -1,3 +1,13 @@
+2012-05-10  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r116633.
+http://trac.webkit.org/changeset/116633
+https://bugs.webkit.org/show_bug.cgi?id=86093
+
+Breaks EFL tests (Requested by kov on #webkit).
+
+* platform/efl/Skipped:
+
 2012-05-10  Noel Gordon  noel.gor...@gmail.com
 
 [chromium] REGRESSION(r107389) Visible line artifacts on JPEG images


Modified: trunk/LayoutTests/platform/efl/Skipped (116638 => 116639)

--- trunk/LayoutTests/platform/efl/Skipped	2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-05-10 13:48:47 UTC (rev 116639)
@@ -249,6 +249,9 @@
 editing/selection/selection-background.html
 fast/dom/Window/window-onFocus.html
 
+# EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements
+fast/events/keypress-insert-tab.html
+
 # EFL's LayoutTestController does not implement setUseDashboardCompatibilityMode
 fast/canvas/canvas-gradient-addStop-error.html
 fast/canvas/fill-stroke-clip-reset-path.html


Modified: trunk/Source/WebKit/efl/ChangeLog (116638 => 116639)

--- trunk/Source/WebKit/efl/ChangeLog	2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-05-10 13:48:47 UTC (rev 116639)
@@ -1,3 +1,14 @@
+2012-05-10  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r116633.
+http://trac.webkit.org/changeset/116633
+https://bugs.webkit.org/show_bug.cgi?id=86093
+
+Breaks EFL tests (Requested by kov on #webkit).
+
+* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+* WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
 2012-05-10  Alexander Shalamov  alexander.shala...@intel.com
 
 [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements


Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (116638 => 116639)

--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-05-10 13:48:47 UTC (rev 116639)
@@ -478,15 +478,6 @@
 editorClient-setSelectTrailingWhitespaceEnabled(enabled);
 }
 
-void DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles)
-{
-WebCore::Page* page = EWKPrivate::corePage(ewkView);
-if (!page)
-return;
-
-page-setTabKeyCyclesThroughElements(cycles);
-}
-
 void DumpRenderTreeSupportEfl::garbageCollectorCollect()
 {
 WebCore::gcController().garbageCollectNow();


Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (116638 => 116639)

--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-05-10 13:42:54 UTC (rev 116638)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-05-10 13:48:47 UTC (rev 116639)
@@ -80,7 +80,6 @@
 static void setJavaScriptProfilingEnabled(const Evas_Object* ewkView, bool enabled);
 static void setSmartInsertDeleteEnabled(Evas_Object* ewkView, bool enabled);
 static void setSelectTrailingWhitespaceEnabled(Evas_Object* ewkView, bool enabled);
-static void setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles);
 
 static void garbageCollectorCollect();
 static void garbageCollectorCollectOnAlternateThread(bool waitUntilDone);


Modified: trunk/Tools/ChangeLog (116638 => 116639)

--- trunk/Tools/ChangeLog	2012-05-10 13:42:54 UTC (rev 116638)
+++ 

[webkit-changes] [116640] trunk/Source/WTF

[rakuco]

Title: [116640] trunk/Source/WTF








Revision 116640
Author rak...@webkit.org
Date 2012-05-10 07:04:55 -0700 (Thu, 10 May 2012)


Log Message
[EFL] Add OwnPtr specialization for Eina_Hash.
https://bugs.webkit.org/show_bug.cgi?id=85046

Patch by Michał Pakuła vel Rutka m.pak...@samsung.com on 2012-05-10
Reviewed by Andreas Kling.

Add an override for Eina_Hash for EFL port.

* wtf/OwnPtrCommon.h:
(WTF):
* wtf/efl/OwnPtrEfl.cpp:
(WTF::deleteOwnedPtr):
(WTF):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/OwnPtrCommon.h
trunk/Source/WTF/wtf/efl/OwnPtrEfl.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (116639 => 116640)

--- trunk/Source/WTF/ChangeLog	2012-05-10 13:48:47 UTC (rev 116639)
+++ trunk/Source/WTF/ChangeLog	2012-05-10 14:04:55 UTC (rev 116640)
@@ -1,3 +1,18 @@
+2012-05-10  Michał Pakuła vel Rutka  m.pak...@samsung.com
+
+[EFL] Add OwnPtr specialization for Eina_Hash.
+https://bugs.webkit.org/show_bug.cgi?id=85046
+
+Reviewed by Andreas Kling.
+
+Add an override for Eina_Hash for EFL port.
+
+* wtf/OwnPtrCommon.h:
+(WTF):
+* wtf/efl/OwnPtrEfl.cpp:
+(WTF::deleteOwnedPtr):
+(WTF):
+
 2012-05-09  Filip Pizlo  fpi...@apple.com
 
 It should be possible to get useful debug logging from the JIT memory allocator


Modified: trunk/Source/WTF/wtf/OwnPtrCommon.h (116639 => 116640)

--- trunk/Source/WTF/wtf/OwnPtrCommon.h	2012-05-10 13:48:47 UTC (rev 116639)
+++ trunk/Source/WTF/wtf/OwnPtrCommon.h	2012-05-10 14:04:55 UTC (rev 116640)
@@ -42,6 +42,7 @@
 typedef struct _Ecore_Evas Ecore_Evas;
 typedef struct _Ecore_Pipe Ecore_Pipe;
 typedef struct _Ecore_Timer Ecore_Timer;
+typedef struct _Eina_Hash Eina_Hash;
 typedef struct _Eina_Module Eina_Module;
 typedef struct _Evas_Object Evas_Object;
 #endif
@@ -69,6 +70,7 @@
 void deleteOwnedPtr(Ecore_Evas*);
 void deleteOwnedPtr(Ecore_Pipe*);
 void deleteOwnedPtr(Ecore_Timer*);
+void deleteOwnedPtr(Eina_Hash*);
 void deleteOwnedPtr(Eina_Module*);
 void deleteOwnedPtr(Evas_Object*);
 #endif


Modified: trunk/Source/WTF/wtf/efl/OwnPtrEfl.cpp (116639 => 116640)

--- trunk/Source/WTF/wtf/efl/OwnPtrEfl.cpp	2012-05-10 13:48:47 UTC (rev 116639)
+++ trunk/Source/WTF/wtf/efl/OwnPtrEfl.cpp	2012-05-10 14:04:55 UTC (rev 116640)
@@ -51,6 +51,12 @@
 ecore_pipe_del(ptr);
 }
 
+void deleteOwnedPtr(Eina_Hash* ptr)
+{
+if (ptr)
+eina_hash_free(ptr);
+}
+
 void deleteOwnedPtr(Eina_Module* ptr)
 {
 if (ptr)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116641] trunk/Source

[commit-queue]

Title: [116641] trunk/Source








Revision 116641
Author commit-qu...@webkit.org
Date 2012-05-10 07:05:32 -0700 (Thu, 10 May 2012)


Log Message
Web Inspector: rename InspectorBackendStub.js to InspectorBackendCommands.js
https://bugs.webkit.org/show_bug.cgi?id=72306

Source/WebCore:

Changed name for InspectorBackendStub.js to
InspectorBackendCommands.js

Patch by Sam D dsam2...@gmail.com on 2012-05-10
Reviewed by Yury Semikhatsky.

No new tests required. File name is changed.

* DerivedSources.pri:
* GNUmakefile.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/copyWebCoreResourceFiles.cmd:
* WebCore.xcodeproj/project.pbxproj:
* gyp/copy-inspector-resources.sh:
* inspector/CodeGeneratorInspector.py:
* inspector/front-end/InspectorBackendCommands.qrc: Added.
* inspector/front-end/InspectorBackendStub.qrc: Removed.
* inspector/front-end/inspector.html:

Source/WebKit:

Changed name for InspectorBackendStub.js to
InspectorBackendCommands.js

Patch by Sam D dsam2...@gmail.com on 2012-05-10
Reviewed by Yury Semikhatsky.

* PlatformBlackBerry.cmake:

Source/WebKit/chromium:

Changed name for InspectorBackendStub.js to InspectorBackendCommands.js

Patch by Sam D dsam2...@gmail.com on 2012-05-10
Reviewed by Yury Semikhatsky.

* WebKit.gyp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.pri
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/copyWebCoreResourceFiles.cmd
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/gyp/copy-inspector-resources.sh
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py
trunk/Source/WebCore/inspector/front-end/inspector.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformBlackBerry.cmake
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp


Added Paths

trunk/Source/WebCore/inspector/front-end/InspectorBackendCommands.qrc


Removed Paths

trunk/Source/WebCore/inspector/front-end/InspectorBackendStub.qrc




Diff

Modified: trunk/Source/WebCore/ChangeLog (116640 => 116641)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 14:04:55 UTC (rev 116640)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 14:05:32 UTC (rev 116641)
@@ -1,3 +1,28 @@
+2012-05-10  Sam D  dsam2...@gmail.com
+
+Web Inspector: rename InspectorBackendStub.js to InspectorBackendCommands.js
+https://bugs.webkit.org/show_bug.cgi?id=72306
+
+Changed name for InspectorBackendStub.js to
+InspectorBackendCommands.js
+
+Reviewed by Yury Semikhatsky.
+
+No new tests required. File name is changed.
+
+* DerivedSources.pri:
+* GNUmakefile.am:
+* Target.pri:
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+* WebCore.vcproj/copyWebCoreResourceFiles.cmd:
+* WebCore.xcodeproj/project.pbxproj:
+* gyp/copy-inspector-resources.sh:
+* inspector/CodeGeneratorInspector.py:
+* inspector/front-end/InspectorBackendCommands.qrc: Added.
+* inspector/front-end/InspectorBackendStub.qrc: Removed.
+* inspector/front-end/inspector.html:
+
 2012-05-10  Alexis Menard  alexis.men...@openbossa.org
 
 [Qt] Avoid string conversions to construct a QUrl when using Qt5.


Modified: trunk/Source/WebCore/DerivedSources.pri (116640 => 116641)

--- trunk/Source/WebCore/DerivedSources.pri	2012-05-10 14:04:55 UTC (rev 116640)
+++ trunk/Source/WebCore/DerivedSources.pri	2012-05-10 14:05:32 UTC (rev 116641)
@@ -57,7 +57,7 @@
 
 INSPECTOR_JSON = $$PWD/inspector/Inspector.json
 
-INSPECTOR_BACKEND_STUB_QRC = $$PWD/inspector/front-end/InspectorBackendStub.qrc
+INSPECTOR_BACKEND_COMMANDS_QRC = $$PWD/inspector/front-end/InspectorBackendCommands.qrc
 
 INJECTED_SCRIPT_SOURCE = $$PWD/inspector/InjectedScriptSource.js
 
@@ -755,11 +755,11 @@
 inspectorJSON.depends = $$inspectorJSON.script
 GENERATORS += inspectorJSON
 
-inspectorBackendStub.output = InspectorBackendStub.qrc
-inspectorBackendStub.input = INSPECTOR_BACKEND_STUB_QRC
-inspectorBackendStub.commands = $$QMAKE_COPY $$toSystemPath($$INSPECTOR_BACKEND_STUB_QRC) ${QMAKE_FUNC_FILE_OUT_PATH}$${QMAKE_DIR_SEP}InspectorBackendStub.qrc
-inspectorBackendStub.add_output_to_sources = false
-GENERATORS += inspectorBackendStub
+inspectorBackendCommands.output = InspectorBackendCommands.qrc
+inspectorBackendCommands.input = INSPECTOR_BACKEND_COMMANDS_QRC
+inspectorBackendCommands.commands = $$QMAKE_COPY $$toSystemPath($$INSPECTOR_BACKEND_COMMANDS_QRC) ${QMAKE_FUNC_FILE_OUT_PATH}$${QMAKE_DIR_SEP}InspectorBackendCommands.qrc
+inspectorBackendCommands.add_output_to_sources = false
+GENERATORS += inspectorBackendCommands
 
 # GENERATOR 2-a: inspector injected script source compiler
 injectedScriptSource.output = InjectedScriptSource.h


Modified: trunk/Source/WebCore/GNUmakefile.am (116640 => 116641)

--- 

[webkit-changes] [116642] trunk/Source/WebCore

[keishi]

Title: [116642] trunk/Source/WebCore








Revision 116642
Author kei...@webkit.org
Date 2012-05-10 07:11:37 -0700 (Thu, 10 May 2012)


Log Message
Crash in HTMLFormControlElement::m_fieldSetAncestor
https://bugs.webkit.org/show_bug.cgi?id=86070

Reviewed by Kent Tamura.

No new tests.

The previous patch r115990 didn't completely resolve the crash (Bug 85453)
We don't have a reproducible test case, so we are reverting to the old code for setting m_fieldSetAncestor.

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::updateFieldSetAndLegendAncestor):
(WebCore::HTMLFormControlElement::insertedInto): Set m_dataListAncestorState to Unknown because ancestor has changed. Call setNeedsWillValidateCheck because style might need to be updated.
(WebCore::HTMLFormControlElement::removedFrom):
(WebCore::HTMLFormControlElement::disabled):
(WebCore::HTMLFormControlElement::recalcWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
* html/HTMLFormControlElement.h:
(HTMLFormControlElement): Added m_dataListAncestorState.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormControlElement.cpp
trunk/Source/WebCore/html/HTMLFormControlElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116641 => 116642)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 14:05:32 UTC (rev 116641)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 14:11:37 UTC (rev 116642)
@@ -1,3 +1,27 @@
+2012-05-10  Keishi Hattori  kei...@webkit.org
+
+Crash in HTMLFormControlElement::m_fieldSetAncestor
+https://bugs.webkit.org/show_bug.cgi?id=86070
+
+Reviewed by Kent Tamura.
+
+No new tests.
+
+The previous patch r115990 didn't completely resolve the crash (Bug 85453)
+We don't have a reproducible test case, so we are reverting to the old code for setting m_fieldSetAncestor.
+
+* html/HTMLFormControlElement.cpp:
+(WebCore::HTMLFormControlElement::HTMLFormControlElement):
+(WebCore::HTMLFormControlElement::updateFieldSetAndLegendAncestor):
+(WebCore::HTMLFormControlElement::insertedInto): Set m_dataListAncestorState to Unknown because ancestor has changed. Call setNeedsWillValidateCheck because style might need to be updated.
+(WebCore::HTMLFormControlElement::removedFrom):
+(WebCore::HTMLFormControlElement::disabled):
+(WebCore::HTMLFormControlElement::recalcWillValidate):
+(WebCore::HTMLFormControlElement::willValidate):
+(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
+* html/HTMLFormControlElement.h:
+(HTMLFormControlElement): Added m_dataListAncestorState.
+
 2012-05-10  Sam D  dsam2...@gmail.com
 
 Web Inspector: rename InspectorBackendStub.js to InspectorBackendCommands.js


Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (116641 => 116642)

--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp	2012-05-10 14:05:32 UTC (rev 116641)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp	2012-05-10 14:11:37 UTC (rev 116642)
@@ -50,17 +50,17 @@
 : LabelableElement(tagName, document)
 , m_fieldSetAncestor(0)
 , m_legendAncestor(0)
-, m_ancestorsValid(false)
+, m_fieldSetAncestorValid(false)
 , m_disabled(false)
 , m_readOnly(false)
 , m_required(false)
 , m_valueMatchesRenderer(false)
+, m_dataListAncestorState(Unknown)
 , m_willValidateInitialized(false)
 , m_willValidate(true)
 , m_isValid(true)
 , m_wasChangedSinceLastFormControlChangeEvent(false)
 , m_hasAutofocused(false)
-, m_hasDataListAncestor(false)
 {
 setForm(form ? form : findFormAncestor());
 setHasCustomWillOrDidRecalcStyle();
@@ -101,22 +101,19 @@
 return fastHasAttribute(formnovalidateAttr);
 }
 
-void HTMLFormControlElement::updateAncestors() const
+void HTMLFormControlElement::updateFieldSetAndLegendAncestor() const
 {
 m_fieldSetAncestor = 0;
 m_legendAncestor = 0;
-m_hasDataListAncestor = false;
 for (ContainerNode* ancestor = parentNode(); ancestor; ancestor = ancestor-parentNode()) {
 if (!m_legendAncestor  ancestor-hasTagName(legendTag))
 m_legendAncestor = static_castHTMLLegendElement*(ancestor);
-if (!m_fieldSetAncestor  ancestor-hasTagName(fieldsetTag))
+if (ancestor-hasTagName(fieldsetTag)) {
 m_fieldSetAncestor = static_castHTMLFieldSetElement*(ancestor);
-if (!m_hasDataListAncestor  ancestor-hasTagName(datalistTag))
-m_hasDataListAncestor = true;
-if (m_hasDataListAncestor  m_fieldSetAncestor)
 break;
+}
 }
-m_ancestorsValid = true;
+m_fieldSetAncestorValid = true;
 }
 
 void HTMLFormControlElement::parseAttribute(Attribute* attr)
@@ -227,18 +224,19 @@
 
 Node::InsertionNotificationRequest 

[webkit-changes] [116643] branches/chromium/1132/Source

[kareng]

Title: [116643] branches/chromium/1132/Source








Revision 116643
Author kar...@chromium.org
Date 2012-05-10 07:23:01 -0700 (Thu, 10 May 2012)


Log Message
Merge 116319 - Unreviewed, rolling out r115525.
http://trac.webkit.org/changeset/115525
https://bugs.webkit.org/show_bug.cgi?id=66683

Too many pages rely on DOMTimeStamp as first argument.
Reverting while we consider next steps.

Source/WebCore:

* WebCore.exp.in:
* bindings/js/JSRequestAnimationFrameCallbackCustom.cpp:
(WebCore::JSRequestAnimationFrameCallback::handleEvent):
* dom/Document.cpp:
(WebCore::Document::serviceScriptedAnimations):
* dom/Document.h:
(Document):
* dom/RequestAnimationFrameCallback.h:
(RequestAnimationFrameCallback):
* dom/RequestAnimationFrameCallback.idl:
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::animationTimerFired):
* dom/ScriptedAnimationController.h:
(ScriptedAnimationController):
(WebCore::ScriptedAnimationController::displayRefreshFired):
* page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
* page/FrameView.h:
(FrameView):
* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::notifyClients):
* platform/graphics/DisplayRefreshMonitor.h:
(DisplayRefreshMonitor):
* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):
* platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
(WebCore):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

Source/WebKit/chromium:

* src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::animate):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateAnimations):

TBR=nd...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10391049

Modified Paths

branches/chromium/1132/Source/WebCore/WebCore.exp.in
branches/chromium/1132/Source/WebCore/bindings/js/JSRequestAnimationFrameCallbackCustom.cpp
branches/chromium/1132/Source/WebCore/dom/Document.cpp
branches/chromium/1132/Source/WebCore/dom/Document.h
branches/chromium/1132/Source/WebCore/dom/RequestAnimationFrameCallback.h
branches/chromium/1132/Source/WebCore/dom/RequestAnimationFrameCallback.idl
branches/chromium/1132/Source/WebCore/dom/ScriptedAnimationController.cpp
branches/chromium/1132/Source/WebCore/dom/ScriptedAnimationController.h
branches/chromium/1132/Source/WebCore/page/FrameView.cpp
branches/chromium/1132/Source/WebCore/page/FrameView.h
branches/chromium/1132/Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp
branches/chromium/1132/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h
branches/chromium/1132/Source/WebCore/platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp
branches/chromium/1132/Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.cpp
branches/chromium/1132/Source/WebKit/chromium/src/PageWidgetDelegate.cpp
branches/chromium/1132/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: branches/chromium/1132/Source/WebCore/WebCore.exp.in (116642 => 116643)

--- branches/chromium/1132/Source/WebCore/WebCore.exp.in	2012-05-10 14:11:37 UTC (rev 116642)
+++ branches/chromium/1132/Source/WebCore/WebCore.exp.in	2012-05-10 14:23:01 UTC (rev 116643)
@@ -2050,7 +2050,7 @@
 #endif
 
 #if ENABLE(REQUEST_ANIMATION_FRAME)
-__ZN7WebCore9FrameView25serviceScriptedAnimationsEd
+__ZN7WebCore9FrameView25serviceScriptedAnimationsEy
 #endif
 
 #if ENABLE(VIDEO)


Modified: branches/chromium/1132/Source/WebCore/bindings/js/JSRequestAnimationFrameCallbackCustom.cpp (116642 => 116643)

--- branches/chromium/1132/Source/WebCore/bindings/js/JSRequestAnimationFrameCallbackCustom.cpp	2012-05-10 14:11:37 UTC (rev 116642)
+++ branches/chromium/1132/Source/WebCore/bindings/js/JSRequestAnimationFrameCallbackCustom.cpp	2012-05-10 14:23:01 UTC (rev 116643)
@@ -33,7 +33,7 @@
 
 namespace WebCore {
 
-bool JSRequestAnimationFrameCallback::handleEvent(double highResNowMs)
+bool JSRequestAnimationFrameCallback::handleEvent(DOMTimeStamp time)
 {
 if (!canInvokeCallback())
 return true;
@@ -43,7 +43,7 @@
 JSLock lock(SilenceAssertionsOnly);
 
 MarkedArgumentBuffer args;
-args.append(jsNumber(highResNowMs));
+args.append(jsNumber(time));
 
 bool raisedException = false;
 m_data-invokeCallback(args, raisedException);


Modified: branches/chromium/1132/Source/WebCore/dom/Document.cpp (116642 => 116643)

--- branches/chromium/1132/Source/WebCore/dom/Document.cpp	2012-05-10 14:11:37 UTC (rev 116642)
+++ branches/chromium/1132/Source/WebCore/dom/Document.cpp	2012-05-10 14:23:01 UTC (rev 116643)
@@ -5805,11 +5805,11 @@
 

[webkit-changes] [116644] trunk/Source/WebCore

[morrita]

Title: [116644] trunk/Source/WebCore








Revision 116644
Author morr...@google.com
Date 2012-05-10 07:43:27 -0700 (Thu, 10 May 2012)


Log Message
Node::InDetachFlag could be removed.
https://bugs.webkit.org/show_bug.cgi?id=85963

Reviewed by Antti Koivisto.

Removed Node::inDetach() since it can never true
on the only call site setFocusedNode().

No new test. Covered by existing tests.

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Node.cpp:
(WebCore::Node::detach):
* dom/Node.h:
(WebCore):
(Node):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116643 => 116644)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 14:23:01 UTC (rev 116643)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 14:43:27 UTC (rev 116644)
@@ -1,3 +1,23 @@
+2012-05-10  MORITA Hajime morr...@google.com
+
+Node::InDetachFlag could be removed.
+https://bugs.webkit.org/show_bug.cgi?id=85963
+
+Reviewed by Antti Koivisto.
+
+Removed Node::inDetach() since it can never true
+on the only call site setFocusedNode().
+
+No new test. Covered by existing tests.
+
+* dom/Document.cpp:
+(WebCore::Document::setFocusedNode):
+* dom/Node.cpp:
+(WebCore::Node::detach):
+* dom/Node.h:
+(WebCore):
+(Node):
+
 2012-05-10  Keishi Hattori  kei...@webkit.org
 
 Crash in HTMLFormControlElement::m_fieldSetAncestor


Modified: trunk/Source/WebCore/dom/Document.cpp (116643 => 116644)

--- trunk/Source/WebCore/dom/Document.cpp	2012-05-10 14:23:01 UTC (rev 116643)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-05-10 14:43:27 UTC (rev 116644)
@@ -3646,7 +3646,7 @@
 m_focusedNode = 0;
 
 // Remove focus from the existing focus node (if any)
-if (oldFocusedNode  !oldFocusedNode-inDetach()) {
+if (oldFocusedNode) {
 if (oldFocusedNode-active())
 oldFocusedNode-setActive(false);
 


Modified: trunk/Source/WebCore/dom/Node.cpp (116643 => 116644)

--- trunk/Source/WebCore/dom/Node.cpp	2012-05-10 14:23:01 UTC (rev 116643)
+++ trunk/Source/WebCore/dom/Node.cpp	2012-05-10 14:43:27 UTC (rev 116644)
@@ -1344,8 +1344,6 @@
 
 void Node::detach()
 {
-setFlag(InDetachFlag);
-
 if (renderer())
 renderer()-destroyAndCleanupAnonymousWrappers();
 setRenderer(0);
@@ -1360,8 +1358,6 @@
 clearFlag(IsHoveredFlag);
 clearFlag(InActiveChainFlag);
 clearFlag(IsAttachedFlag);
-
-clearFlag(InDetachFlag);
 }
 
 // FIXME: This code is used by editing.  Seems like it could move over there and not pollute Node.


Modified: trunk/Source/WebCore/dom/Node.h (116643 => 116644)

--- trunk/Source/WebCore/dom/Node.h	2012-05-10 14:23:01 UTC (rev 116643)
+++ trunk/Source/WebCore/dom/Node.h	2012-05-10 14:43:27 UTC (rev 116644)
@@ -91,7 +91,7 @@
 
 typedef int ExceptionCode;
 
-const int nodeStyleChangeShift = 21;
+const int nodeStyleChangeShift = 20;
 
 // SyntheticStyleChange means that we need to go through the entire style change logic even though
 // no style property has actually changed. It is used to restructure the tree when, for instance,
@@ -298,10 +298,9 @@
 bool hasName() const { return getFlag(HasNameFlag); }
 bool hasID() const;
 bool hasClass() const;
-
+
 bool active() const { return getFlag(IsActiveFlag); }
 bool inActiveChain() const { return getFlag(InActiveChainFlag); }
-bool inDetach() const { return getFlag(InDetachFlag); }
 bool hovered() const { return getFlag(IsHoveredFlag); }
 bool focused() const { return hasRareData() ? rareDataFocused() : false; }
 bool attached() const { return getFlag(IsAttachedFlag); }
@@ -664,41 +663,40 @@
 IsActiveFlag = 1  10,
 IsHoveredFlag = 1  11,
 InActiveChainFlag = 1  12,
-InDetachFlag = 1  13,
-HasRareDataFlag = 1  14,
-IsShadowRootFlag = 1  15,
+HasRareDataFlag = 1  13,
+IsShadowRootFlag = 1  14,
 
 // These bits are used by derived classes, pulled up here so they can
 // be stored in the same memory word as the Node bits above.
-IsParsingChildrenFinishedFlag = 1  16, // Element
-IsStyleAttributeValidFlag = 1  17, // StyledElement
+IsParsingChildrenFinishedFlag = 1  15, // Element
+IsStyleAttributeValidFlag = 1  16, // StyledElement
 #if ENABLE(SVG)
-AreSVGAttributesValidFlag = 1  18, // Element
-IsSynchronizingSVGAttributesFlag = 1  19, // SVGElement
-HasSVGRareDataFlag = 1  20, // SVGElement
+AreSVGAttributesValidFlag = 1  17, // Element
+IsSynchronizingSVGAttributesFlag = 1  18, // SVGElement
+HasSVGRareDataFlag = 1  19, // SVGElement
 #endif
 
 StyleChangeMask = 1  nodeStyleChangeShift | 1  (nodeStyleChangeShift + 1),
 
-SelfOrAncestorHasDirAutoFlag = 1  23,
-

[webkit-changes] [116646] trunk/Source/WebKit2

[kent . hansen]

Title: [116646] trunk/Source/WebKit2








Revision 116646
Author kent.han...@nokia.com
Date 2012-05-10 08:12:36 -0700 (Thu, 10 May 2012)


Log Message
[Qt] Rename QDeclarative* to QQml*
https://bugs.webkit.org/show_bug.cgi?id=86089

Reviewed by Simon Hausmann.

The QtDeclarative module was deprecated in favor of QtQml.

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::_q_onReceivedResponseFromDownload):
(QQuickWebViewExperimental::alertDialog):
(QQuickWebViewExperimental::setAlertDialog):
(QQuickWebViewExperimental::confirmDialog):
(QQuickWebViewExperimental::setConfirmDialog):
(QQuickWebViewExperimental::promptDialog):
(QQuickWebViewExperimental::setPromptDialog):
(QQuickWebViewExperimental::authenticationDialog):
(QQuickWebViewExperimental::setAuthenticationDialog):
(QQuickWebViewExperimental::proxyAuthenticationDialog):
(QQuickWebViewExperimental::setProxyAuthenticationDialog):
(QQuickWebViewExperimental::certificateVerificationDialog):
(QQuickWebViewExperimental::setCertificateVerificationDialog):
(QQuickWebViewExperimental::itemSelector):
(QQuickWebViewExperimental::setItemSelector):
(QQuickWebViewExperimental::filePicker):
(QQuickWebViewExperimental::setFilePicker):
(QQuickWebViewExperimental::databaseQuotaDialog):
(QQuickWebViewExperimental::setDatabaseQuotaDialog):
(QQuickWebViewExperimental::schemeDelegates_At):
(QQuickWebViewExperimental::schemeDelegates_Append):
(QQuickWebViewExperimental::schemeDelegates_Count):
(QQuickWebViewExperimental::schemeDelegates_Clear):
(QQuickWebViewExperimental::schemeDelegates):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/qwebiconimageprovider.cpp:
(QWebIconImageProvider::QWebIconImageProvider):
* UIProcess/API/qt/qwebiconimageprovider_p.h:
* UIProcess/API/qt/qwebviewportinfo_p.h:
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
* UIProcess/qt/WebPopupMenuProxyQt.h:
(WebPopupMenuProxyQt):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qwebiconimageprovider.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qwebiconimageprovider_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qwebviewportinfo_p.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/tests.pri
trunk/Source/WebKit2/UIProcess/qt/QtDialogRunner.h
trunk/Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116645 => 116646)

--- trunk/Source/WebKit2/ChangeLog	2012-05-10 15:10:11 UTC (rev 116645)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-10 15:12:36 UTC (rev 116646)
@@ -1,3 +1,51 @@
+2012-05-10  Kent Hansen  kent.han...@nokia.com
+
+[Qt] Rename QDeclarative* to QQml*
+https://bugs.webkit.org/show_bug.cgi?id=86089
+
+Reviewed by Simon Hausmann.
+
+The QtDeclarative module was deprecated in favor of QtQml.
+
+* Target.pri:
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::_q_onReceivedResponseFromDownload):
+(QQuickWebViewExperimental::alertDialog):
+(QQuickWebViewExperimental::setAlertDialog):
+(QQuickWebViewExperimental::confirmDialog):
+(QQuickWebViewExperimental::setConfirmDialog):
+(QQuickWebViewExperimental::promptDialog):
+(QQuickWebViewExperimental::setPromptDialog):
+(QQuickWebViewExperimental::authenticationDialog):
+(QQuickWebViewExperimental::setAuthenticationDialog):
+(QQuickWebViewExperimental::proxyAuthenticationDialog):
+(QQuickWebViewExperimental::setProxyAuthenticationDialog):
+(QQuickWebViewExperimental::certificateVerificationDialog):
+(QQuickWebViewExperimental::setCertificateVerificationDialog):
+(QQuickWebViewExperimental::itemSelector):
+(QQuickWebViewExperimental::setItemSelector):
+(QQuickWebViewExperimental::filePicker):
+(QQuickWebViewExperimental::setFilePicker):
+(QQuickWebViewExperimental::databaseQuotaDialog):
+(QQuickWebViewExperimental::setDatabaseQuotaDialog):
+(QQuickWebViewExperimental::schemeDelegates_At):
+(QQuickWebViewExperimental::schemeDelegates_Append):
+(QQuickWebViewExperimental::schemeDelegates_Count):
+(QQuickWebViewExperimental::schemeDelegates_Clear):
+(QQuickWebViewExperimental::schemeDelegates):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/qquickwebview_p_p.h:
+(QQuickWebViewPrivate):
+* UIProcess/API/qt/qwebiconimageprovider.cpp:
+(QWebIconImageProvider::QWebIconImageProvider):
+* UIProcess/API/qt/qwebiconimageprovider_p.h:
+* UIProcess/API/qt/qwebviewportinfo_p.h:
+* UIProcess/API/qt/tests/tests.pri:
+* 

[webkit-changes] [116647] trunk

[schenney]

Title: [116647] trunk








Revision 116647
Author schen...@chromium.org
Date 2012-05-10 08:22:04 -0700 (Thu, 10 May 2012)


Log Message
SVG Filters allow invalid elements as children
https://bugs.webkit.org/show_bug.cgi?id=83979

Reviewed by Nikolas Zimmermann.

.: 

This test will crash upon load in Chromium, unless the associated fix is in.

* ManualTests/bugzilla-83979.svg: Added.

Source/WebCore: 

According to the SVG spec, there are numerous restrictions on the
content of nodes (that is, their children). Specific to this problem,
SVGFilter elements may only contain SVGFilterPrimitive elements, and
those may only contain animation related elements. This patch enforces
the restriction on filters in the render tree, thus preventing us from
having (for instance) content that is inside a filter yet filtered by
the filter.

Manual test: ManualTests/bugzilla-83979.svg

* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::childShouldCreateRenderer): Added to only allow renderers for fe* children
(WebCore):
* svg/SVGFilterElement.h:
(SVGFilterElement):
* svg/SVGFilterPrimitiveStandardAttributes.h: Do not allow any children at all for fe* elements.
(SVGFilterPrimitiveStandardAttributes):

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGFilterElement.cpp
trunk/Source/WebCore/svg/SVGFilterElement.h
trunk/Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.h


Added Paths

trunk/ManualTests/bugzilla-83979.svg




Diff

Modified: trunk/ChangeLog (116646 => 116647)

--- trunk/ChangeLog	2012-05-10 15:12:36 UTC (rev 116646)
+++ trunk/ChangeLog	2012-05-10 15:22:04 UTC (rev 116647)
@@ -1,3 +1,14 @@
+2012-05-09  Stephen Chenney  schen...@chromium.org
+
+SVG Filters allow invalid elements as children
+https://bugs.webkit.org/show_bug.cgi?id=83979
+
+Reviewed by Nikolas Zimmermann.
+
+This test will crash upon load in Chromium, unless the associated fix is in.
+
+* ManualTests/bugzilla-83979.svg: Added.
+
 2012-05-09  Kent Tamura  tk...@chromium.org
 
 Calendar Picker: Fix a crash by changing input type.
@@ -35,7 +46,7 @@
 https://bugs.webkit.org/show_bug.cgi?id=85907
 
 Reviewed by Rob Buis.
-   
+
 Enable PAGE_POPUP option in make files.
 
 Internal reviewed by Yong Li.


Added: trunk/ManualTests/bugzilla-83979.svg (0 => 116647)

--- trunk/ManualTests/bugzilla-83979.svg	(rev 0)
+++ trunk/ManualTests/bugzilla-83979.svg	2012-05-10 15:22:04 UTC (rev 116647)
@@ -0,0 +1,16 @@
+svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
+  defs
+filter id=ds2
+  feGaussianBlur id=blur result=blur/
+/filter
+  /defs
+  text x=50 y=50This test passes if it does not crash after load in Debug builds./text
+  image id=image xlink:href="" xmlns='http://www.w3.org/2000/svg'%3E%3Crect/%3E%3C/svg%3E width=50 height=50 filter=url(#ds2)/
+script![CDATA[
+for (var i = 0; i  1; i++) {
+}
+document.getElementById(blur).appendChild(document.getElementById(image).cloneNode());
+for (var i = 0; i  1; i++) {
+}
+]]/script
+/svg


Modified: trunk/Source/WebCore/ChangeLog (116646 => 116647)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 15:12:36 UTC (rev 116646)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 15:22:04 UTC (rev 116647)
@@ -1,3 +1,28 @@
+2012-05-10  Stephen Chenney  schen...@chromium.org
+
+SVG Filters allow invalid elements as children
+https://bugs.webkit.org/show_bug.cgi?id=83979
+
+Reviewed by Nikolas Zimmermann.
+
+According to the SVG spec, there are numerous restrictions on the
+content of nodes (that is, their children). Specific to this problem,
+SVGFilter elements may only contain SVGFilterPrimitive elements, and
+those may only contain animation related elements. This patch enforces
+the restriction on filters in the render tree, thus preventing us from
+having (for instance) content that is inside a filter yet filtered by
+the filter.
+
+Manual test: ManualTests/bugzilla-83979.svg
+
+* svg/SVGFilterElement.cpp:
+(WebCore::SVGFilterElement::childShouldCreateRenderer): Added to only allow renderers for fe* children
+(WebCore):
+* svg/SVGFilterElement.h:
+(SVGFilterElement):
+* svg/SVGFilterPrimitiveStandardAttributes.h: Do not allow any children at all for fe* elements.
+(SVGFilterPrimitiveStandardAttributes):
+
 2012-05-10  Joe Thomas  joetho...@motorola.com
 
 [CSS3 Backgrounds and Borders] Add background-size to the background shorthand


Modified: trunk/Source/WebCore/svg/SVGFilterElement.cpp (116646 => 116647)

--- trunk/Source/WebCore/svg/SVGFilterElement.cpp	2012-05-10 15:12:36 UTC (rev 116646)
+++ trunk/Source/WebCore/svg/SVGFilterElement.cpp	2012-05-10 15:22:04 UTC (rev 116647)
@@ -27,6 +27,7 @@
 #include SVGFilterElement.h
 
 #include Attr.h
+#include 

[webkit-changes] [116648] trunk/Source/WebKit2

[kenneth]

Title: [116648] trunk/Source/WebKit2








Revision 116648
Author kenn...@webkit.org
Date 2012-05-10 08:35:02 -0700 (Thu, 10 May 2012)


Log Message
[Qt] Double tap to zoom is considered a user interaction
https://bugs.webkit.org/show_bug.cgi?id=86094

Reviewed by Simon Hausmann.

This makes it so that the content size change doesn't change scale
after a double tap to zoom.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116647 => 116648)

--- trunk/Source/WebKit2/ChangeLog	2012-05-10 15:22:04 UTC (rev 116647)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-10 15:35:02 UTC (rev 116648)
@@ -1,3 +1,16 @@
+2012-05-10  Kenneth Rohde Christiansen  kenn...@webkit.org
+
+[Qt] Double tap to zoom is considered a user interaction
+https://bugs.webkit.org/show_bug.cgi?id=86094
+
+Reviewed by Simon Hausmann.
+
+This makes it so that the content size change doesn't change scale
+after a double tap to zoom.
+
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
+
 2012-05-10  Kent Hansen  kent.han...@nokia.com
 
 [Qt] Rename QDeclarative* to QQml*


Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp (116647 => 116648)

--- trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp	2012-05-10 15:22:04 UTC (rev 116647)
+++ trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp	2012-05-10 15:35:02 UTC (rev 116648)
@@ -365,6 +365,8 @@
 if (scrollAnimationActive() || scaleAnimationActive())
 return;
 
+m_hadUserInteraction = true;
+
 const int margin = 10; // We want at least a little bit of margin.
 QRectF endArea = itemRectFromCSS(targetArea.adjusted(-margin, -margin, margin, margin));
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116649] trunk/Source/WebCore

[commit-queue]

Title: [116649] trunk/Source/WebCore








Revision 116649
Author commit-qu...@webkit.org
Date 2012-05-10 08:59:36 -0700 (Thu, 10 May 2012)


Log Message
Fix typo in filename
https://bugs.webkit.org/show_bug.cgi?id=86095

Patch by Konrad Piascik kpias...@rim.com on 2012-05-10
Reviewed by Andreas Kling.

* UseJSC.cmake:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/UseJSC.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (116648 => 116649)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 15:35:02 UTC (rev 116648)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 15:59:36 UTC (rev 116649)
@@ -1,3 +1,12 @@
+2012-05-10  Konrad Piascik  kpias...@rim.com
+
+Fix typo in filename
+https://bugs.webkit.org/show_bug.cgi?id=86095
+
+Reviewed by Andreas Kling.
+
+* UseJSC.cmake:
+
 2012-05-10  Stephen Chenney  schen...@chromium.org
 
 SVG Filters allow invalid elements as children


Modified: trunk/Source/WebCore/UseJSC.cmake (116648 => 116649)

--- trunk/Source/WebCore/UseJSC.cmake	2012-05-10 15:35:02 UTC (rev 116648)
+++ trunk/Source/WebCore/UseJSC.cmake	2012-05-10 15:59:36 UTC (rev 116649)
@@ -250,7 +250,7 @@
 IF (ENABLE_NOTIFICATIONS)
 LIST(APPEND WebCore_SOURCES
 bindings/js/JSDesktopNotificationsCustom.cpp
-bindings/js/JSNotificationsCustom.cpp
+bindings/js/JSNotificationCustom.cpp
 )
 ENDIF ()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116650] trunk/Source/WebCore

[commit-queue]

Title: [116650] trunk/Source/WebCore








Revision 116650
Author commit-qu...@webkit.org
Date 2012-05-10 09:17:53 -0700 (Thu, 10 May 2012)


Log Message
TouchAdjustment doesn't correct for scroll-offsets.
https://bugs.webkit.org/show_bug.cgi?id=86083

Patch by Allan Sandfeld Jensen allan.jen...@nokia.com on 2012-05-10
Reviewed by Kenneth Rohde Christiansen.

Already tested by: touchadjustment/scroll-delegation

* page/EventHandler.cpp:
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
* testing/Internals.cpp:
(WebCore::Internals::bestZoomableAreaForTouchPoint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/TouchAdjustment.cpp
trunk/Source/WebCore/testing/Internals.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116649 => 116650)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 15:59:36 UTC (rev 116649)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 16:17:53 UTC (rev 116650)
@@ -1,3 +1,20 @@
+2012-05-10  Allan Sandfeld Jensen  allan.jen...@nokia.com
+
+TouchAdjustment doesn't correct for scroll-offsets.
+https://bugs.webkit.org/show_bug.cgi?id=86083
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Already tested by: touchadjustment/scroll-delegation
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::bestClickableNodeForTouchPoint):
+(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
+* page/TouchAdjustment.cpp:
+(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
+* testing/Internals.cpp:
+(WebCore::Internals::bestZoomableAreaForTouchPoint):
+
 2012-05-10  Konrad Piascik  kpias...@rim.com
 
 Fix typo in filename


Modified: trunk/Source/WebCore/page/EventHandler.cpp (116649 => 116650)

--- trunk/Source/WebCore/page/EventHandler.cpp	2012-05-10 15:59:36 UTC (rev 116649)
+++ trunk/Source/WebCore/page/EventHandler.cpp	2012-05-10 16:17:53 UTC (rev 116650)
@@ -2478,7 +2478,8 @@
 bool EventHandler::bestClickableNodeForTouchPoint(const IntPoint touchCenter, const IntSize touchRadius, IntPoint targetPoint, Node* targetNode)
 {
 HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active;
-HitTestResult result = hitTestResultAtPoint(touchCenter, /*allowShadowContent*/ false, /*ignoreClipping*/ false, DontHitTestScrollbars, hitType, touchRadius);
+IntPoint hitTestPoint = m_frame-view()-windowToContents(touchCenter);
+HitTestResult result = hitTestResultAtPoint(hitTestPoint, /*allowShadowContent*/ false, /*ignoreClipping*/ false, DontHitTestScrollbars, hitType, touchRadius);
 
 IntRect touchRect = result.rectForPoint(touchCenter);
 RefPtrStaticHashSetNodeList nodeList = StaticHashSetNodeList::adopt(result.rectBasedTestResult());
@@ -2488,7 +2489,8 @@
 bool EventHandler::bestZoomableAreaForTouchPoint(const IntPoint touchCenter, const IntSize touchRadius, IntRect targetArea, Node* targetNode)
 {
 HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active;
-HitTestResult result = hitTestResultAtPoint(touchCenter, /*allowShadowContent*/ false, /*ignoreClipping*/ false, DontHitTestScrollbars, hitType, touchRadius);
+IntPoint hitTestPoint = m_frame-view()-windowToContents(touchCenter);
+HitTestResult result = hitTestResultAtPoint(hitTestPoint, /*allowShadowContent*/ false, /*ignoreClipping*/ false, DontHitTestScrollbars, hitType, touchRadius);
 
 IntRect touchRect = result.rectForPoint(touchCenter);
 RefPtrStaticHashSetNodeList nodeList = StaticHashSetNodeList::adopt(result.rectBasedTestResult());


Modified: trunk/Source/WebCore/page/TouchAdjustment.cpp (116649 => 116650)

--- trunk/Source/WebCore/page/TouchAdjustment.cpp	2012-05-10 15:59:36 UTC (rev 116649)
+++ trunk/Source/WebCore/page/TouchAdjustment.cpp	2012-05-10 16:17:53 UTC (rev 116650)
@@ -265,6 +265,10 @@
 }
 }
 }
+if (targetNode) {
+targetArea = targetNode-document()-view()-contentsToWindow(targetArea);
+targetPoint = targetNode-document()-view()-contentsToWindow(targetPoint);
+}
 
 return (targetNode);
 }


Modified: trunk/Source/WebCore/testing/Internals.cpp (116649 => 116650)

--- trunk/Source/WebCore/testing/Internals.cpp	2012-05-10 15:59:36 UTC (rev 116649)
+++ trunk/Source/WebCore/testing/Internals.cpp	2012-05-10 16:17:53 UTC (rev 116650)
@@ -774,8 +774,6 @@
 Node* targetNode;
 IntRect zoomableArea;
 document-frame()-eventHandler()-bestZoomableAreaForTouchPoint(point, radius, zoomableArea, targetNode);
-if (targetNode)
-zoomableArea = targetNode-document()-view()-contentsToWindow(zoomableArea);
 
 return ClientRect::create(zoomableArea);
 }






___
webkit-changes mailing list

[webkit-changes] [116651] trunk/Source/WebKit2

[commit-queue]

Title: [116651] trunk/Source/WebKit2








Revision 116651
Author commit-qu...@webkit.org
Date 2012-05-10 09:33:28 -0700 (Thu, 10 May 2012)


Log Message
[GTK] Missing field initializers for WKPageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=86005

Patch by Simon Pena sp...@igalia.com on 2012-05-10
Reviewed by Martin Robinson.

Initialize willGoToBackForwardListItem and
interactionOccurredWhileProcessUnresponsive fields of
WKPageLoaderClient.

* UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116650 => 116651)

--- trunk/Source/WebKit2/ChangeLog	2012-05-10 16:17:53 UTC (rev 116650)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-10 16:33:28 UTC (rev 116651)
@@ -1,3 +1,17 @@
+2012-05-10  Simon Pena  sp...@igalia.com
+
+[GTK] Missing field initializers for WKPageLoaderClient
+https://bugs.webkit.org/show_bug.cgi?id=86005
+
+Reviewed by Martin Robinson.
+
+Initialize willGoToBackForwardListItem and
+interactionOccurredWhileProcessUnresponsive fields of
+WKPageLoaderClient.
+
+* UIProcess/API/gtk/WebKitLoaderClient.cpp:
+(attachLoaderClientToView):
+
 2012-05-10  Kenneth Rohde Christiansen  kenn...@webkit.org
 
 [Qt] Double tap to zoom is considered a user interaction


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp (116650 => 116651)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp	2012-05-10 16:17:53 UTC (rev 116650)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp	2012-05-10 16:33:28 UTC (rev 116651)
@@ -145,7 +145,9 @@
 0, // shouldGoToBackForwardListItem
 0, // didFailToInitializePlugin
 0, // didDetectXSSForFrame
-0 // didFirstVisuallyNonEmptyLayoutForFrame 
+0, // didFirstVisuallyNonEmptyLayoutForFrame
+0, // willGoToBackForwardListItem
+0 // interactionOccurredWhileProcessUnresponsive
 };
 WKPageRef wkPage = toAPI(webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(webView)));
 WKPageSetPageLoaderClient(wkPage, wkLoaderClient);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116652] trunk/Source/WebKit2

[commit-queue]

Title: [116652] trunk/Source/WebKit2








Revision 116652
Author commit-qu...@webkit.org
Date 2012-05-10 09:38:13 -0700 (Thu, 10 May 2012)


Log Message
[GTK] WK2 misses WebKitSettings for media playback requiring user gestures and inline playback
https://bugs.webkit.org/show_bug.cgi?id=85999

Patch by Simon Pena sp...@igalia.com on 2012-05-10
Reviewed by Martin Robinson.

Expose WebKitSettings for media playback requiring user gesture and
media playback allows inline to GTK side.

This adds two properties (mediaPlaybackRequiresUserGesture and
mediaPlaybackAllowsInline), with their setters and getters, to
WebKitSettings. It also updates the WebKitSettings tests so these
two properties are checked, and includes the new methods in the
documentation.

* UIProcess/API/gtk/WebKitSettings.cpp: added the new properties and
their accessors
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_media_playback_requires_user_gesture):
(webkit_settings_get_media_playback_requires_user_gesture):
(webkit_settings_set_media_playback_allows_inline):
(webkit_settings_get_media_playback_allows_inline):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: included the new
methods in the documentation
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp: tested the newly
added methods
(testWebKitSettings):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116651 => 116652)

--- trunk/Source/WebKit2/ChangeLog	2012-05-10 16:33:28 UTC (rev 116651)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-10 16:38:13 UTC (rev 116652)
@@ -1,5 +1,37 @@
 2012-05-10  Simon Pena  sp...@igalia.com
 
+[GTK] WK2 misses WebKitSettings for media playback requiring user gestures and inline playback
+https://bugs.webkit.org/show_bug.cgi?id=85999
+
+Reviewed by Martin Robinson.
+
+Expose WebKitSettings for media playback requiring user gesture and
+media playback allows inline to GTK side.
+
+This adds two properties (mediaPlaybackRequiresUserGesture and
+mediaPlaybackAllowsInline), with their setters and getters, to
+WebKitSettings. It also updates the WebKitSettings tests so these
+two properties are checked, and includes the new methods in the
+documentation.
+
+* UIProcess/API/gtk/WebKitSettings.cpp: added the new properties and
+their accessors
+(webKitSettingsSetProperty):
+(webKitSettingsGetProperty):
+(webkit_settings_class_init):
+(webkit_settings_set_media_playback_requires_user_gesture):
+(webkit_settings_get_media_playback_requires_user_gesture):
+(webkit_settings_set_media_playback_allows_inline):
+(webkit_settings_get_media_playback_allows_inline):
+* UIProcess/API/gtk/WebKitSettings.h:
+* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: included the new
+methods in the documentation
+* UIProcess/API/gtk/tests/TestWebKitSettings.cpp: tested the newly
+added methods
+(testWebKitSettings):
+
+2012-05-10  Simon Pena  sp...@igalia.com
+
 [GTK] Missing field initializers for WKPageLoaderClient
 https://bugs.webkit.org/show_bug.cgi?id=86005
 


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (116651 => 116652)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp	2012-05-10 16:33:28 UTC (rev 116651)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp	2012-05-10 16:38:13 UTC (rev 116652)
@@ -106,7 +106,9 @@
 PROP_ENABLE_WEBAUDIO,
 PROP_ENABLE_WEBGL,
 PROP_ZOOM_TEXT_ONLY,
-PROP_JAVASCRIPT_CAN_ACCESS_CLIPBOARD
+PROP_JAVASCRIPT_CAN_ACCESS_CLIPBOARD,
+PROP_MEDIA_PLAYBACK_REQUIRES_USER_GESTURE,
+PROP_MEDIA_PLAYBACK_ALLOWS_INLINE
 };
 
 static void webKitSettingsSetProperty(GObject* object, guint propId, const GValue* value, GParamSpec* paramSpec)
@@ -219,6 +221,12 @@
 case PROP_JAVASCRIPT_CAN_ACCESS_CLIPBOARD:
 webkit_settings_set_javascript_can_access_clipboard(settings, g_value_get_boolean(value));
 break;
+case PROP_MEDIA_PLAYBACK_REQUIRES_USER_GESTURE:
+webkit_settings_set_media_playback_requires_user_gesture(settings, g_value_get_boolean(value));
+break;
+case PROP_MEDIA_PLAYBACK_ALLOWS_INLINE:
+webkit_settings_set_media_playback_allows_inline(settings, g_value_get_boolean(value));
+break;
 default:
 G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propId, paramSpec);
 break;
@@ -335,6 +343,12 @@
 case PROP_JAVASCRIPT_CAN_ACCESS_CLIPBOARD:
 g_value_set_boolean(value, 

[webkit-changes] [116653] trunk

[inferno]

Title: [116653] trunk








Revision 116653
Author infe...@chromium.org
Date 2012-05-10 09:44:26 -0700 (Thu, 10 May 2012)


Log Message
Crash in InsertParagraphSeparatorCommand::doApply.
https://bugs.webkit.org/show_bug.cgi?id=84995

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/inserting/insert-paragraph-seperator-crash.html

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs): no need of static cast, since
type of enclosingBlock returned is already Element*.
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::tryIndentingAsListItem): no need of static cast, since
type of enclosingBlock returned is already Element*.
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): RefPtr startBlock to guard against
mutation events.
* editing/htmlediting.cpp:
(WebCore::enclosingBlock): make sure type of enclosingNode is an element before doing
the static cast. This was already failing in a couple of layout tests. Also, isBlock
check already exists in the function call to enclosingNodeOfType, so don't need it
again on enclosingNode's renderer.
* editing/htmlediting.h:
(WebCore):

LayoutTests:

* editing/inserting/insert-paragraph-seperator-crash-expected.txt: Added.
* editing/inserting/insert-paragraph-seperator-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp
trunk/Source/WebCore/editing/IndentOutdentCommand.cpp
trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp
trunk/Source/WebCore/editing/htmlediting.cpp
trunk/Source/WebCore/editing/htmlediting.h


Added Paths

trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt
trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (116652 => 116653)

--- trunk/LayoutTests/ChangeLog	2012-05-10 16:38:13 UTC (rev 116652)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 16:44:26 UTC (rev 116653)
@@ -1,3 +1,13 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Crash in InsertParagraphSeparatorCommand::doApply.
+https://bugs.webkit.org/show_bug.cgi?id=84995
+
+Reviewed by Ryosuke Niwa.
+
+* editing/inserting/insert-paragraph-seperator-crash-expected.txt: Added.
+* editing/inserting/insert-paragraph-seperator-crash.html: Added.
+
 2012-05-10  Joe Thomas  joetho...@motorola.com
 
 [CSS3 Backgrounds and Borders] Add background-size to the background shorthand


Added: trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt (0 => 116653)

--- trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt	2012-05-10 16:44:26 UTC (rev 116653)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.


Added: trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html (0 => 116653)

--- trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html	(rev 0)
+++ trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html	2012-05-10 16:44:26 UTC (rev 116653)
@@ -0,0 +1,34 @@
+!DOCTYPE html
+html
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function handler() {
+var element = event.srcElement;
+document.execCommand('Undo', false, false);
+element.parentNode.removeChild(element);
+var em = document.getElementById('em');
+var span = document.getElementById('span');
+em.insertBefore(element, span);
+document.execCommand('JustifyFull', false, false);
+}
+document.addEventListener(DOMCharacterDataModified, handler, true);
+
+window._onload_ = function() {
+var selection = window.getSelection();
+document.execCommand(SelectAll, false, false)
+var element = document.getElementById(ruby);
+element.innerHTML = em id='em'^x?xspan id='span'x'x;
+selection.deleteFromDocument();
+selection.deleteFromDocument();
+document.designMode = on;
+document.execCommand('JustifyRight', false, false);
+document.execCommand('InsertHorizontalRule', false, '');
+document.documentElement.innerHTML = PASS. WebKit didn't crash.;
+};
+/script
+ruby id=ruby
+aA/a
+/ruby
+/html
Property changes on: trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html
___


Added: svn:executable

Modified: trunk/Source/WebCore/ChangeLog (116652 => 116653)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 16:38:13 UTC (rev 116652)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 16:44:26 UTC (rev 116653)
@@ -1,3 +1,29 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Crash in InsertParagraphSeparatorCommand::doApply.
+https://bugs.webkit.org/show_bug.cgi?id=84995
+
+

[webkit-changes] [116654] trunk/Source/WebKit2

[carlosgc]

Title: [116654] trunk/Source/WebKit2








Revision 116654
Author carlo...@webkit.org
Date 2012-05-10 09:45:09 -0700 (Thu, 10 May 2012)


Log Message
[GTK] Test /webkit2/WebKitWebView/resources times out
https://bugs.webkit.org/show_bug.cgi?id=86088

Reviewed by Martin Robinson.

* UIProcess/API/gtk/tests/TestResources.cpp:
(testWebViewResources): Use webkit_web_view_reload_bypass_cache()
instead of webkit_web_view_reload() to make sure resources are not
read from the cache.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116653 => 116654)

--- trunk/Source/WebKit2/ChangeLog	2012-05-10 16:44:26 UTC (rev 116653)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-10 16:45:09 UTC (rev 116654)
@@ -1,3 +1,15 @@
+2012-05-10  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Test /webkit2/WebKitWebView/resources times out
+https://bugs.webkit.org/show_bug.cgi?id=86088
+
+Reviewed by Martin Robinson.
+
+* UIProcess/API/gtk/tests/TestResources.cpp:
+(testWebViewResources): Use webkit_web_view_reload_bypass_cache()
+instead of webkit_web_view_reload() to make sure resources are not
+read from the cache.
+
 2012-05-10  Simon Pena  sp...@igalia.com
 
 [GTK] WK2 misses WebKitSettings for media playback requiring user gestures and inline playback


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp (116653 => 116654)

--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp	2012-05-10 16:44:26 UTC (rev 116653)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp	2012-05-10 16:45:09 UTC (rev 116654)
@@ -207,7 +207,7 @@
 #endif
 
 // Reload.
-webkit_web_view_reload(test-m_webView);
+webkit_web_view_reload_bypass_cache(test-m_webView);
 test-waitUntilResourcesLoaded(4);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116655] trunk/LayoutTests

[arv]

Title: [116655] trunk/LayoutTests








Revision 116655
Author a...@chromium.org
Date 2012-05-10 09:47:45 -0700 (Thu, 10 May 2012)


Log Message
Add test that makes sure wrappers are setup using the correct window scope
https://bugs.webkit.org/show_bug.cgi?id=85526

Reviewed by Ojan Vafai.

This tests the same thing as the recently removed fast/dom/prototype-inheritance.html test.

* fast/dom/wrapper-scope-expected.txt: Added.
* fast/dom/wrapper-scope.html: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/fast/dom/wrapper-scope-expected.txt
trunk/LayoutTests/fast/dom/wrapper-scope.html




Diff

Modified: trunk/LayoutTests/ChangeLog (116654 => 116655)

--- trunk/LayoutTests/ChangeLog	2012-05-10 16:45:09 UTC (rev 116654)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 16:47:45 UTC (rev 116655)
@@ -1,3 +1,16 @@
+2012-05-10  Erik Arvidsson  a...@chromium.org
+
+Add test that makes sure wrappers are setup using the correct window scope
+https://bugs.webkit.org/show_bug.cgi?id=85526
+
+Reviewed by Ojan Vafai.
+
+This tests the same thing as the recently removed fast/dom/prototype-inheritance.html test.
+
+* fast/dom/wrapper-scope-expected.txt: Added.
+* fast/dom/wrapper-scope.html: Added.
+* platform/chromium/test_expectations.txt:
+
 2012-05-10  Abhishek Arya  infe...@chromium.org
 
 Crash in InsertParagraphSeparatorCommand::doApply.


Added: trunk/LayoutTests/fast/dom/wrapper-scope-expected.txt (0 => 116655)

--- trunk/LayoutTests/fast/dom/wrapper-scope-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/wrapper-scope-expected.txt	2012-05-10 16:47:45 UTC (rev 116655)
@@ -0,0 +1,49 @@
+Make sure wrappers are setup using the window the property came from, instead of the lexical global object.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS inner.HTMLElement.isInner is true
+PASS inner.HTMLElement.constructor.isInner is true
+PASS inner.HTMLElement.constructor.prototype.isInner is true
+PASS inner.HTMLElement.__proto__.isInner is true
+PASS inner.Window.isInner is true
+PASS inner.Window.constructor.isInner is true
+PASS inner.Window.constructor.prototype.isInner is true
+PASS inner.Window.__proto__.isInner is true
+PASS inner.close.isInner is true
+PASS inner.close.constructor.isInner is true
+PASS inner.close.constructor.prototype.isInner is true
+PASS inner.close.__proto__.isInner is true
+PASS inner.console.isInner is true
+PASS inner.console.constructor.isInner is true
+PASS inner.console.constructor.prototype.isInner is true
+PASS inner.console.__proto__.isInner is true
+PASS inner.document.isInner is true
+PASS inner.document.constructor.isInner is true
+PASS inner.document.constructor.prototype.isInner is true
+PASS inner.document.__proto__.isInner is true
+PASS inner.document.body.isInner is true
+PASS inner.document.body.constructor.isInner is true
+PASS inner.document.body.constructor.prototype.isInner is true
+PASS inner.document.body.__proto__.isInner is true
+PASS inner.document.childNodes.isInner is true
+PASS inner.document.childNodes.constructor.isInner is true
+PASS inner.document.childNodes.constructor.prototype.isInner is true
+PASS inner.document.childNodes.__proto__.isInner is true
+PASS inner.navigator.isInner is true
+PASS inner.navigator.constructor.isInner is true
+PASS inner.navigator.constructor.prototype.isInner is true
+PASS inner.navigator.__proto__.isInner is true
+PASS inner.postMessage.isInner is true
+PASS inner.postMessage.constructor.isInner is true
+PASS inner.postMessage.constructor.prototype.isInner is true
+PASS inner.postMessage.__proto__.isInner is true
+PASS inner.window.isInner is true
+PASS inner.window.constructor.isInner is true
+PASS inner.window.constructor.prototype.isInner is true
+PASS inner.window.__proto__.isInner is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/wrapper-scope.html (0 => 116655)

--- trunk/LayoutTests/fast/dom/wrapper-scope.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/wrapper-scope.html	2012-05-10 16:47:45 UTC (rev 116655)
@@ -0,0 +1,39 @@
+!DOCTYPE html
+body
+script src=""
+script
+
+description('Make sure wrappers are setup using the window the property came from, instead of the lexical global object.');
+
+var frame = document.createElement('iframe');
+document.body.appendChild(frame);
+var inner = frame.contentWindow;
+
+window.Object.prototype.isInner = false;
+inner.Object.prototype.isInner = true;
+
+var pathsToTest = [
+'HTMLElement',
+'Window',
+'close',
+'console',
+'document',
+'document.body',
+'document.childNodes',
+'navigator',
+'postMessage',
+'window',
+];
+
+function testPath(path) {
+shouldBeTrue('inner.' + path + '.isInner');
+

[webkit-changes] [116656] trunk

[commit-queue]

Title: [116656] trunk








Revision 116656
Author commit-qu...@webkit.org
Date 2012-05-10 09:54:02 -0700 (Thu, 10 May 2012)


Log Message
[EFL][DRT] ewk_view_paint_contents may trigger assertion failure
https://bugs.webkit.org/show_bug.cgi?id=85058

Patch by Dominik Röttsches dominik.rottsc...@intel.com on 2012-05-10
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Fixing assertion failure triggered in media/media-fragment cases.
The assertion is hit because of a race between scheduleRelayout() and
the EWK's idle tiling painting. This is exposed by test cases
that rapidly insert child nodes to the document which lead to
scheduleRelayout() calls. Using the general purpose defensive
layout function, not causing any extra relayout work if there's
nothing to be done, but still avoiding the assertion failure if
layout is needed.

* ewk/ewk_view.cpp:
(ewk_view_paint):
(ewk_view_paint_contents):

LayoutTests:

Unskipping media-fragments that pass after the assertion failure was fixed.

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (116655 => 116656)

--- trunk/LayoutTests/ChangeLog	2012-05-10 16:47:45 UTC (rev 116655)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 16:54:02 UTC (rev 116656)
@@ -1,3 +1,14 @@
+2012-05-10  Dominik Röttsches  dominik.rottsc...@intel.com
+
+[EFL][DRT] ewk_view_paint_contents may trigger assertion failure
+https://bugs.webkit.org/show_bug.cgi?id=85058
+
+Reviewed by Gustavo Noronha Silva.
+
+Unskipping media-fragments that pass after the assertion failure was fixed.
+
+* platform/efl/Skipped:
+
 2012-05-10  Erik Arvidsson  a...@chromium.org
 
 Add test that makes sure wrappers are setup using the correct window scope


Modified: trunk/LayoutTests/platform/efl/Skipped (116655 => 116656)

--- trunk/LayoutTests/platform/efl/Skipped	2012-05-10 16:47:45 UTC (rev 116655)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-05-10 16:54:02 UTC (rev 116656)
@@ -1038,16 +1038,6 @@
 media/media-controller-playback.html
 media/media-element-play-after-eos.html
 media/media-extension-with-fragment.html
-media/media-fragments/TC0001-TC0009.html
-media/media-fragments/TC0010-TC0019.html
-media/media-fragments/TC0020-TC0029.html
-media/media-fragments/TC0030-TC0039.html
-media/media-fragments/TC0040-TC0049.html
-media/media-fragments/TC0050-TC0059.html
-media/media-fragments/TC0060-TC0069.html
-media/media-fragments/TC0070-TC0079.html
-media/media-fragments/TC0080-TC0089.html
-media/media-fragments/TC0090-TC0099.html
 media/media-initialTime.html
 media/media-load-event.html
 media/media-startTime.html


Modified: trunk/Source/WebKit/efl/ChangeLog (116655 => 116656)

--- trunk/Source/WebKit/efl/ChangeLog	2012-05-10 16:47:45 UTC (rev 116655)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-05-10 16:54:02 UTC (rev 116656)
@@ -1,3 +1,23 @@
+2012-05-10  Dominik Röttsches  dominik.rottsc...@intel.com
+
+[EFL][DRT] ewk_view_paint_contents may trigger assertion failure
+https://bugs.webkit.org/show_bug.cgi?id=85058
+
+Reviewed by Gustavo Noronha Silva.
+
+Fixing assertion failure triggered in media/media-fragment cases.
+The assertion is hit because of a race between scheduleRelayout() and
+the EWK's idle tiling painting. This is exposed by test cases
+that rapidly insert child nodes to the document which lead to
+scheduleRelayout() calls. Using the general purpose defensive
+layout function, not causing any extra relayout work if there's
+nothing to be done, but still avoiding the assertion failure if
+layout is needed.
+
+* ewk/ewk_view.cpp:
+(ewk_view_paint):
+(ewk_view_paint_contents):
+
 2012-05-10  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r116633.


Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (116655 => 116656)

--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2012-05-10 16:47:45 UTC (rev 116655)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2012-05-10 16:54:02 UTC (rev 116656)
@@ -2778,8 +2778,7 @@
 WebCore::FrameView* view = priv-mainFrame-view();
 EINA_SAFETY_ON_NULL_RETURN_VAL(view, false);
 
-if (view-needsLayout())
-view-forceLayout();
+view-updateLayoutAndStyleIfNeededRecursive();
 WebCore::GraphicsContext graphicsContext(cr);
 WebCore::IntRect rect(*area);
 
@@ -2806,6 +2805,7 @@
 WebCore::GraphicsContext graphicsContext(cr);
 WebCore::IntRect rect(*area);
 
+view-updateLayoutAndStyleIfNeededRecursive();
 cairo_save(cr);
 graphicsContext.save();
 graphicsContext.clip(rect);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116657] trunk/Source/WebKit/blackberry

[tonikitoo]

Title: [116657] trunk/Source/WebKit/blackberry








Revision 116657
Author toniki...@webkit.org
Date 2012-05-10 10:15:55 -0700 (Thu, 10 May 2012)


Log Message
[BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame and m_frame-view() are invalid
https://bugs.webkit.org/show_bug.cgi?id=86096

Reviewed by Rob Buis.
Patch by Antonio Gomes ago...@rim.com

A Frame's FrameView has always to be checked since it is
a volatile object, and gets created and destroyed all the time.

We have been facing a particular issue, where during our automated
interaction tests, the main frame object was being pinch zoomed in
the middle of it creation, and WebKit thread was blocked by a mutex.
In practice, it is a case that would not be possible in a real
world scenario, but shows that the ASSERTs are bogus regardless.

* WebKitSupport/BackingStoreClient.cpp:
(BlackBerry::WebKit::BackingStoreClient::scrollPosition):
(BlackBerry::WebKit::BackingStoreClient::setScrollPosition):
(BlackBerry::WebKit::BackingStoreClient::maximumScrollPosition):
(BlackBerry::WebKit::BackingStoreClient::viewportSize):
(BlackBerry::WebKit::BackingStoreClient::transformedViewportSize):
(BlackBerry::WebKit::BackingStoreClient::visibleContentsRect):
(BlackBerry::WebKit::BackingStoreClient::contentsSize):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreClient.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (116656 => 116657)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-05-10 16:54:02 UTC (rev 116656)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-05-10 17:15:55 UTC (rev 116657)
@@ -1,3 +1,28 @@
+2012-05-10  Antonio Gomes  ago...@rim.com
+
+[BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame and m_frame-view() are invalid
+https://bugs.webkit.org/show_bug.cgi?id=86096
+
+Reviewed by Rob Buis.
+
+A Frame's FrameView has always to be checked since it is
+a volatile object, and gets created and destroyed all the time.
+
+We have been facing a particular issue, where during our automated
+interaction tests, the main frame object was being pinch zoomed in
+the middle of it creation, and WebKit thread was blocked by a mutex.
+In practice, it is a case that would not be possible in a real
+world scenario, but shows that the ASSERTs are bogus regardless.
+
+* WebKitSupport/BackingStoreClient.cpp:
+(BlackBerry::WebKit::BackingStoreClient::scrollPosition):
+(BlackBerry::WebKit::BackingStoreClient::setScrollPosition):
+(BlackBerry::WebKit::BackingStoreClient::maximumScrollPosition):
+(BlackBerry::WebKit::BackingStoreClient::viewportSize):
+(BlackBerry::WebKit::BackingStoreClient::transformedViewportSize):
+(BlackBerry::WebKit::BackingStoreClient::visibleContentsRect):
+(BlackBerry::WebKit::BackingStoreClient::contentsSize):
+
 2012-05-09  Jonathan Dong  jonathan.d...@torchmobile.com.cn
 
 [BlackBerry] Autofill feature implementation for BlackBerry porting


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreClient.cpp (116656 => 116657)

--- trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreClient.cpp	2012-05-10 16:54:02 UTC (rev 116656)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/BackingStoreClient.cpp	2012-05-10 17:15:55 UTC (rev 116657)
@@ -168,6 +168,9 @@
 IntPoint BackingStoreClient::scrollPosition() const
 {
 ASSERT(m_frame);
+if (!m_frame-view())
+return IntPoint();
+
 return m_frame-view()-scrollPosition() - pointToSize(m_frame-view()-minimumScrollPosition());
 }
 
@@ -178,7 +181,10 @@
 
 void BackingStoreClient::setScrollPosition(const IntPoint pos)
 {
-ASSERT(m_frame-view());
+ASSERT(m_frame);
+if (!m_frame-view())
+return;
+
 if (pos == scrollPosition())
 return;
 
@@ -196,7 +202,10 @@
 
 IntPoint BackingStoreClient::maximumScrollPosition() const
 {
-ASSERT(m_frame-view());
+ASSERT(m_frame);
+if (!m_frame-view())
+return IntPoint();
+
 return m_frame-view()-maximumScrollPosition() - pointToSize(m_frame-view()-minimumScrollPosition());
 }
 
@@ -220,7 +229,10 @@
 
 IntSize BackingStoreClient::viewportSize() const
 {
-ASSERT(m_frame-view());
+ASSERT(m_frame);
+if (!m_frame-view())
+return IntSize();
+
 if (isMainFrame())
 return m_webPage-d-viewportSize();
 
@@ -229,10 +241,13 @@
 
 IntSize BackingStoreClient::transformedViewportSize() const
 {
+ASSERT(m_frame);
+if (!m_frame-view())
+return IntSize();
+
 if (isMainFrame())
 return m_webPage-d-transformedViewportSize();
 
-ASSERT(m_frame-view());
 const IntSize untransformedViewportSize = m_frame-view()-visibleContentRect().size();
 const FloatPoint transformedBottomRight = m_webPage-d-m_transformationMatrix-mapPoint(
 

[webkit-changes] [116658] trunk/LayoutTests

[tomz]

Title: [116658] trunk/LayoutTests








Revision 116658
Author t...@codeaurora.org
Date 2012-05-10 10:26:32 -0700 (Thu, 10 May 2012)


Log Message
Integrate IETC CSS : values and units tests
https://bugs.webkit.org/show_bug.cgi?id=85307

Patch by Dave Tharp dth...@codeaurora.org on 2012-05-10
Reviewed by Adam Barth.

Added the IETC values and unit tests and associated reference tests.

Also removed two file not found test entries in the mac test_expectations.txt
file that were causing a style check failure.

* ietestcenter/css3/valuesandunits/units-000-expected.htm: Added.
* ietestcenter/css3/valuesandunits/units-000.htm: Added.
* ietestcenter/css3/valuesandunits/units-010-expected.htm: Added.
* ietestcenter/css3/valuesandunits/units-010.htm: Added.
* ietestcenter/css3/valuesandunits/units-020-expected.htm: Added.
* ietestcenter/css3/valuesandunits/units-020.htm: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/efl/test_expectations.txt
trunk/LayoutTests/platform/gtk/test_expectations.txt
trunk/LayoutTests/platform/mac/test_expectations.txt
trunk/LayoutTests/platform/qt/test_expectations.txt


Added Paths

trunk/LayoutTests/ietestcenter/css3/valuesandunits/
trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm
trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000.htm
trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-010-expected.htm
trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-010.htm
trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-020-expected.htm
trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-020.htm




Diff

Modified: trunk/LayoutTests/ChangeLog (116657 => 116658)

--- trunk/LayoutTests/ChangeLog	2012-05-10 17:15:55 UTC (rev 116657)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 17:26:32 UTC (rev 116658)
@@ -1,3 +1,27 @@
+2012-05-10  Dave Tharp  dth...@codeaurora.org
+
+Integrate IETC CSS : values and units tests
+https://bugs.webkit.org/show_bug.cgi?id=85307
+
+Reviewed by Adam Barth.
+
+Added the IETC values and unit tests and associated reference tests.
+
+Also removed two file not found test entries in the mac test_expectations.txt
+file that were causing a style check failure.
+
+* ietestcenter/css3/valuesandunits/units-000-expected.htm: Added.
+* ietestcenter/css3/valuesandunits/units-000.htm: Added.
+* ietestcenter/css3/valuesandunits/units-010-expected.htm: Added.
+* ietestcenter/css3/valuesandunits/units-010.htm: Added.
+* ietestcenter/css3/valuesandunits/units-020-expected.htm: Added.
+* ietestcenter/css3/valuesandunits/units-020.htm: Added.
+* platform/chromium/test_expectations.txt:
+* platform/efl/test_expectations.txt:
+* platform/gtk/test_expectations.txt:
+* platform/mac/test_expectations.txt:
+* platform/qt/test_expectations.txt:
+
 2012-05-10  Dominik Röttsches  dominik.rottsc...@intel.com
 
 [EFL][DRT] ewk_view_paint_contents may trigger assertion failure


Added: trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm (0 => 116658)

--- trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm	(rev 0)
+++ trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm	2012-05-10 17:26:32 UTC (rev 116658)
@@ -0,0 +1,22 @@
+!DOCTYPE html PUBLIC -//W3C//DTD//XHTML 1.0 Strict//EN http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd
+html xmlns=http://www.w3.org/1999/xhtml
+head
+titleCSS Test: All unit and function values - Reference/title
+link rel=author title=Codeaurora href="" /
+link rel=help href="" /
+style type=text/css
+#parent
+{
+height: 272px;
+width: 1in;
+background: green;
+position: relative;
+}
+/style
+/head
+body
+pTest passes if there is no red visible on the page./p
+div id=parent
+/div
+/body
+/html


Added: trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000.htm (0 => 116658)

--- trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000.htm	(rev 0)
+++ trunk/LayoutTests/ietestcenter/css3/valuesandunits/units-000.htm	2012-05-10 17:26:32 UTC (rev 116658)
@@ -0,0 +1,182 @@
+!DOCTYPE html PUBLIC -//W3C//DTD//XHTML 1.0 Strict//EN http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd
+!--
+ Internet Explorer Test Pages Copyright © 2012 Microsoft Corporation. All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without modification,
+ are permitted provided that the following 

[webkit-changes] [116659] trunk/Source/JavaScriptCore

[msaboff]

Title: [116659] trunk/Source/_javascript_Core








Revision 116659
Author msab...@apple.com
Date 2012-05-10 10:32:39 -0700 (Thu, 10 May 2012)


Log Message
Enh: Hash Const JSString in Backing Stores to Save Memory
https://bugs.webkit.org/show_bug.cgi?id=86024

Reviewed by Filip Pizlo.

During garbage collection, each marking thread keeps a HashMap of
strings.  While visiting via MarkStack::copyAndAppend(), we check to
see if the string we are visiting is already in the HashMap.  If not
we add it.  If so, we change the reference to the current string we're
visiting to the prior string.

To somewhat reduce the performance impact of this change, if a string
is unique at the end of a marking it will not be checked during further
GC phases.  In some cases this won't catch all duplicates, but we are
trying to catch the growth of duplicate strings.

* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::resetChildren): New method called by the 
main thread to reset the slave threads.  This is primarily done to
clear the m_uniqueStrings HashMap.
(JSC):
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::reset): Added call to clear m_uniqueStrings.
(JSC::MarkStack::internalAppend): New method that performs the hash consting.
(JSC::SlotVisitor::copyAndAppend): Changed to call the new hash consting
internalAppend()
* heap/MarkStack.h:
(MarkStackThreadSharedData):
(MarkStack):
(JSC::MarkStack::sharedData):
* runtime/JSString.h:
(JSString): Added m_isHashConstSingleton flag, accessors for the flag and
code to initialize the flag.
(JSC::JSString::finishCreation):
(JSC::JSString::isHashConstSingleton):
(JSC::JSString::clearHashConstSingleton):
(JSC::JSString::setHashConstSingleton):
(JSC::JSRopeString::finishCreation):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/MarkStack.cpp
trunk/Source/_javascript_Core/heap/MarkStack.h
trunk/Source/_javascript_Core/runtime/JSString.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (116658 => 116659)

--- trunk/Source/_javascript_Core/ChangeLog	2012-05-10 17:26:32 UTC (rev 116658)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-05-10 17:32:39 UTC (rev 116659)
@@ -1,3 +1,49 @@
+2012-05-10  Michael Saboff  msab...@apple.com
+
+Enh: Hash Const JSString in Backing Stores to Save Memory
+https://bugs.webkit.org/show_bug.cgi?id=86024
+
+Reviewed by Filip Pizlo.
+
+During garbage collection, each marking thread keeps a HashMap of
+strings.  While visiting via MarkStack::copyAndAppend(), we check to
+see if the string we are visiting is already in the HashMap.  If not
+we add it.  If so, we change the reference to the current string we're
+visiting to the prior string.
+
+To somewhat reduce the performance impact of this change, if a string
+is unique at the end of a marking it will not be checked during further
+GC phases.  In some cases this won't catch all duplicates, but we are
+trying to catch the growth of duplicate strings.
+
+* heap/Heap.cpp:
+(JSC::Heap::markRoots):
+* heap/MarkStack.cpp:
+(JSC::MarkStackThreadSharedData::resetChildren): New method called by the 
+main thread to reset the slave threads.  This is primarily done to
+clear the m_uniqueStrings HashMap.
+(JSC):
+(JSC::MarkStackThreadSharedData::markingThreadMain):
+(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
+(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
+(JSC::MarkStackThreadSharedData::reset):
+(JSC::MarkStack::reset): Added call to clear m_uniqueStrings.
+(JSC::MarkStack::internalAppend): New method that performs the hash consting.
+(JSC::SlotVisitor::copyAndAppend): Changed to call the new hash consting
+internalAppend()
+* heap/MarkStack.h:
+(MarkStackThreadSharedData):
+(MarkStack):
+(JSC::MarkStack::sharedData):
+* runtime/JSString.h:
+(JSString): Added m_isHashConstSingleton flag, accessors for the flag and
+code to initialize the flag.
+(JSC::JSString::finishCreation):
+(JSC::JSString::isHashConstSingleton):
+(JSC::JSString::clearHashConstSingleton):
+(JSC::JSString::setHashConstSingleton):
+(JSC::JSRopeString::finishCreation):
+
 2012-05-09  Filip Pizlo  fpi...@apple.com
 
 JIT memory allocator is not returning memory to the OS on Darwin


Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (116658 => 116659)

--- trunk/Source/_javascript_Core/heap/Heap.cpp	2012-05-10 17:26:32 UTC (rev 116658)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp	

[webkit-changes] [116660] trunk/LayoutTests

[jianli]

Title: [116660] trunk/LayoutTests








Revision 116660
Author jia...@chromium.org
Date 2012-05-10 11:05:59 -0700 (Thu, 10 May 2012)


Log Message
Unreviewed chromium gardening. Marked tests as failure.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116659 => 116660)

--- trunk/LayoutTests/ChangeLog	2012-05-10 17:32:39 UTC (rev 116659)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 18:05:59 UTC (rev 116660)
@@ -1,3 +1,9 @@
+2012-05-10  Jian Li  jia...@chromium.org
+
+Unreviewed chromium gardening. Marked tests as failure.
+
+* platform/chromium/test_expectations.txt:
+
 2012-05-10  Dave Tharp  dth...@codeaurora.org
 
 Integrate IETC CSS : values and units tests


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (116659 => 116660)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-10 17:32:39 UTC (rev 116659)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-10 18:05:59 UTC (rev 116660)
@@ -3888,6 +3888,7 @@
 BUGNOEL : fast/backgrounds/size/contain-and-cover.html = IMAGE
 BUGNOEL : fast/block/float/014.html = IMAGE
 BUGNOEL : fast/css/line-height-determined-by-primary-font.html = IMAGE
+BUGNOEL : fast/images/color-jpeg-with-color-profile.html = IMAGE
 BUGNOEL : fast/images/gray-scale-jpeg-with-color-profile.html = IMAGE
 BUGNOEL : fast/images/image-css3-content-data.html = IMAGE
 BUGNOEL : fast/images/rgb-jpeg-with-adobe-marker-only.html = IMAGE
@@ -3923,6 +3924,7 @@
 BUGNOEL : svg/repaint/image-href-change.svg = IMAGE
 BUGNOEL : tables/mozilla/bugs/bug101674.html = IMAGE
 BUGNOEL : tables/mozilla/bugs/bug10565.html = IMAGE
+BUGNOEL : tables/mozilla/bugs/bug1188.html = IMAGE
 BUGNOEL : tables/mozilla/bugs/bug11026.html = IMAGE
 BUGNOEL : tables/mozilla/bugs/bug120107.html = IMAGE
 BUGNOEL : tables/mozilla/bugs/bug1271.html = IMAGE
@@ -4056,3 +4058,5 @@
 
 BUGWK85308 : ietestcenter/css3/valuesandunits/units-000.htm = IMAGE
 BUGWK85310 : ietestcenter/css3/valuesandunits/units-010.htm = IMAGE
+
+BUGWK86114 MAC DEBUG : animations/combo-transform-translate+scale.html = PASS TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116661] trunk/LayoutTests

[rakuco]

Title: [116661] trunk/LayoutTests








Revision 116661
Author rak...@webkit.org
Date 2012-05-10 11:09:35 -0700 (Thu, 10 May 2012)


Log Message
[EFL] Gardening away IETC crash for now
https://bugs.webkit.org/show_bug.cgi?id=86115

Unreviewed, EFL gardening.

Patch by Dominik Röttsches dominik.rottsc...@intel.com on 2012-05-10

* platform/efl/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116660 => 116661)

--- trunk/LayoutTests/ChangeLog	2012-05-10 18:05:59 UTC (rev 116660)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 18:09:35 UTC (rev 116661)
@@ -1,3 +1,12 @@
+2012-05-10  Dominik Röttsches  dominik.rottsc...@intel.com
+
+[EFL] Gardening away IETC crash for now
+https://bugs.webkit.org/show_bug.cgi?id=86115
+
+Unreviewed, EFL gardening.
+
+* platform/efl/test_expectations.txt:
+
 2012-05-10  Jian Li  jia...@chromium.org
 
 Unreviewed chromium gardening. Marked tests as failure.


Modified: trunk/LayoutTests/platform/efl/test_expectations.txt (116660 => 116661)

--- trunk/LayoutTests/platform/efl/test_expectations.txt	2012-05-10 18:05:59 UTC (rev 116660)
+++ trunk/LayoutTests/platform/efl/test_expectations.txt	2012-05-10 18:09:35 UTC (rev 116661)
@@ -420,5 +420,6 @@
 BUGWK86082 : security/block-test.html = TEXT PASS
 BUGWK86084 : svg/dom/SVGScriptElement/script-onerror-bubbling.svg = TEXT PASS
 
-BUGWK85308 : ietestcenter/css3/valuesandunits/units-000.htm = IMAGE
+// Tests imported in r116658
+BUGWK85308 : ietestcenter/css3/valuesandunits/units-000.htm = CRASH
 BUGWK85310 : ietestcenter/css3/valuesandunits/units-010.htm = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116662] trunk/Tools

[rakuco]

Title: [116662] trunk/Tools








Revision 116662
Author rak...@webkit.org
Date 2012-05-10 11:15:04 -0700 (Thu, 10 May 2012)


Log Message
[EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
https://bugs.webkit.org/show_bug.cgi?id=86117

Reviewed by Adam Barth.

Simplify the code used to wrap driver calls with jhbuild: we can
just define the 'wrapper' option instead of having to create a
Driver class just for that.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.__init__):
(EflPort._port_flag_for_scripts):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py




Diff

Modified: trunk/Tools/ChangeLog (116661 => 116662)

--- trunk/Tools/ChangeLog	2012-05-10 18:09:35 UTC (rev 116661)
+++ trunk/Tools/ChangeLog	2012-05-10 18:15:04 UTC (rev 116662)
@@ -1,3 +1,18 @@
+2012-05-10  Raphael Kubo da Costa  rak...@webkit.org
+
+[EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
+https://bugs.webkit.org/show_bug.cgi?id=86117
+
+Reviewed by Adam Barth.
+
+Simplify the code used to wrap driver calls with jhbuild: we can
+just define the 'wrapper' option instead of having to create a
+Driver class just for that.
+
+* Scripts/webkitpy/layout_tests/port/efl.py:
+(EflPort.__init__):
+(EflPort._port_flag_for_scripts):
+
 2012-05-10  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r116633.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py (116661 => 116662)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py	2012-05-10 18:09:35 UTC (rev 116661)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py	2012-05-10 18:15:04 UTC (rev 116662)
@@ -32,25 +32,21 @@
 import subprocess
 
 from webkitpy.layout_tests.models.test_configuration import TestConfiguration
-from webkitpy.layout_tests.port.webkit import WebKitDriver, WebKitPort
+from webkitpy.layout_tests.port.webkit import WebKitPort
 from webkitpy.layout_tests.port.pulseaudio_sanitizer import PulseAudioSanitizer
 
 
-class EflDriver(WebKitDriver):
-def cmd_line(self, pixel_tests, per_test_args):
-wrapper_path = self._port.path_from_webkit_base(Tools, efl, run-with-jhbuild)
-return [wrapper_path] + WebKitDriver.cmd_line(self, pixel_tests, per_test_args)
-
-
 class EflPort(WebKitPort, PulseAudioSanitizer):
 port_name = 'efl'
 
+def __init__(self, *args, **kwargs):
+WebKitPort.__init__(self, *args, **kwargs)
+
+self.set_option_default('wrapper', self.path_from_webkit_base('Tools', 'efl', 'run-with-jhbuild'))
+
 def _port_flag_for_scripts(self):
 return --efl
 
-def _driver_class(self):
-return EflDriver
-
 def setup_test_run(self):
 self._unload_pulseaudio_module()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116663] trunk/LayoutTests

[commit-queue]

Title: [116663] trunk/LayoutTests








Revision 116663
Author commit-qu...@webkit.org
Date 2012-05-10 11:15:57 -0700 (Thu, 10 May 2012)


Log Message
Test from bug 34875 does not work on chromium/mac
https://bugs.webkit.org/show_bug.cgi?id=85913

Patch by Shezan Baig shezbaig...@gmail.com on 2012-05-10
Reviewed by Julien Chaffraix.

* fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html: Added.
* fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt: Removed.
* fast/block/positioning/offsetLeft-offsetTop-multicolumn.html:
Turned the test back into a ref-test as keeping the test cross-platform and
dumpAsText is proving cumbersome. Apart from that, it also make the test work
cross-browser.

* platform/chromium/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt-mac/Skipped:
Re-enabled the test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/block/positioning/offsetLeft-offsetTop-multicolumn.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt-mac/Skipped


Added Paths

trunk/LayoutTests/fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html


Removed Paths

trunk/LayoutTests/fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116662 => 116663)

--- trunk/LayoutTests/ChangeLog	2012-05-10 18:15:04 UTC (rev 116662)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 18:15:57 UTC (rev 116663)
@@ -1,3 +1,22 @@
+2012-05-10  Shezan Baig shezbaig...@gmail.com
+
+Test from bug 34875 does not work on chromium/mac
+https://bugs.webkit.org/show_bug.cgi?id=85913
+
+Reviewed by Julien Chaffraix.
+
+* fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html: Added.
+* fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt: Removed.
+* fast/block/positioning/offsetLeft-offsetTop-multicolumn.html:
+Turned the test back into a ref-test as keeping the test cross-platform and
+dumpAsText is proving cumbersome. Apart from that, it also make the test work
+cross-browser.
+
+* platform/chromium/test_expectations.txt:
+* platform/mac/Skipped:
+* platform/qt-mac/Skipped:
+Re-enabled the test.
+
 2012-05-10  Dominik Röttsches  dominik.rottsc...@intel.com
 
 [EFL] Gardening away IETC crash for now


Added: trunk/LayoutTests/fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html (0 => 116663)

--- trunk/LayoutTests/fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html	2012-05-10 18:15:57 UTC (rev 116663)
@@ -0,0 +1,119 @@
+!DOCTYPE html
+html
+head
+style
+#multicol {
+-webkit-column-width: 100px;
+-moz-column-width: 100px;
+column-width: 100px;
+height: 200px;
+}
+
+span {
+display: inline-block;
+height: 20px;
+background: green;
+padding: 2px;
+}
+
+.size1 {
+width: 10px;
+}
+.size2 {
+width: 20px;
+}
+.size3 {
+width: 40px;
+}
+/style
+/head
+body
+p Bug a href="" offsetLeft broken within CSS3 columns /p
+pThere should not be any red spans visible./p
+p
+This test checks that offsetLeft and offsetTop return correct values when used
+on elements contained in multiple columns. We put a number of red spans (of
+arbitrary size) in a multi-column div. The script at the end creates an
+identically sized green span for each of the red spans, and places it at the
+offsetLeft and offsetTop of the red span, using absolute position. This ensures
+that the green span completely covers the red span.
+/p
+!--
+Note: This is the test reference file. Therefore, there is no script and
+  all the spans are set to green in the css.
+--
+div id=multicol
+div
+span class=size1/span
+span class=size2/span
+span class=size2/span
+span class=size3/span
+span class=size2/span
+span class=size1/span
+/div
+div
+span class=size2/span
+span class=size1/span
+span class=size3/span
+span class=size3/span
+span class=size2/span
+span class=size3/span
+span class=size1/span
+span class=size2/span
+span class=size2/span
+span class=size2/span
+span class=size3/span
+span class=size2/span
+span class=size3/span
+span class=size1/span
+span class=size3/span
+span class=size3/span
+span class=size3/span
+span class=size2/span
+span class=size3/span
+/div
+div
+span class=size3/span
+span class=size2/span
+span class=size1/span
+span class=size1/span
+span class=size2/span
+

[webkit-changes] [116664] trunk/Source/WebCore

[arv]

Title: [116664] trunk/Source/WebCore








Revision 116664
Author a...@chromium.org
Date 2012-05-10 11:22:59 -0700 (Thu, 10 May 2012)


Log Message
Unreviewed, rebaselined run-bindings-tests results.

* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::wrap):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116663 => 116664)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 18:15:57 UTC (rev 116663)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 18:22:59 UTC (rev 116664)
@@ -1,3 +1,18 @@
+2012-05-10  Erik Arvidsson  a...@chromium.org
+
+Unreviewed, rebaselined run-bindings-tests results.
+
+* bindings/scripts/test/JS/JSTestEventTarget.cpp:
+(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
+(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::jsTestObjPrototypeFunctionAddEventListener):
+(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
+* bindings/scripts/test/V8/V8TestException.cpp:
+(WebCore::V8TestException::wrapSlow):
+* bindings/scripts/test/V8/V8TestException.h:
+(WebCore::V8TestException::wrap):
+
 2012-05-10  Abhishek Arya  infe...@chromium.org
 
 Crash in InsertParagraphSeparatorCommand::doApply.


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp (116663 => 116664)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp	2012-05-10 18:15:57 UTC (rev 116663)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp	2012-05-10 18:22:59 UTC (rev 116664)
@@ -252,8 +252,6 @@
 JSTestEventTarget* castedThis = jsCastJSTestEventTarget*(asObject(thisValue));
 ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestEventTarget::s_info);
 TestEventTarget* impl = static_castTestEventTarget*(castedThis-impl());
-if (exec-argumentCount()  2)
-return throwVMError(exec, createNotEnoughArgumentsError(exec));
 JSValue listener = exec-argument(1);
 if (!listener.isObject())
 return JSValue::encode(jsUndefined());
@@ -269,8 +267,6 @@
 JSTestEventTarget* castedThis = jsCastJSTestEventTarget*(asObject(thisValue));
 ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestEventTarget::s_info);
 TestEventTarget* impl = static_castTestEventTarget*(castedThis-impl());
-if (exec-argumentCount()  2)
-return throwVMError(exec, createNotEnoughArgumentsError(exec));
 JSValue listener = exec-argument(1);
 if (!listener.isObject())
 return JSValue::encode(jsUndefined());


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (116663 => 116664)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2012-05-10 18:15:57 UTC (rev 116663)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2012-05-10 18:22:59 UTC (rev 116664)
@@ -1826,8 +1826,6 @@
 JSTestObj* castedThis = jsCastJSTestObj*(asObject(thisValue));
 ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::s_info);
 TestObj* impl = static_castTestObj*(castedThis-impl());
-if (exec-argumentCount()  2)
-return throwVMError(exec, createNotEnoughArgumentsError(exec));
 JSValue listener = exec-argument(1);
 if (!listener.isObject())
 return JSValue::encode(jsUndefined());
@@ -1843,8 +1841,6 @@
 JSTestObj* castedThis = jsCastJSTestObj*(asObject(thisValue));
 ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::s_info);
 TestObj* impl = static_castTestObj*(castedThis-impl());
-if (exec-argumentCount()  2)
-return throwVMError(exec, createNotEnoughArgumentsError(exec));
 JSValue listener = exec-argument(1);
 if (!listener.isObject())
 return JSValue::encode(jsUndefined());


Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp (116663 => 116664)

--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp	2012-05-10 18:15:57 UTC (rev 116663)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestException.cpp	2012-05-10 18:22:59 UTC (rev 116664)
@@ -112,7 +112,7 @@
 
 if (!hasDependentLifetime)
 wrapperHandle.MarkIndependent();
-V8DOMWrapper::setJSWrapperForDOMObject(impl, wrapperHandle);
+

[webkit-changes] [116665] trunk/LayoutTests

[inferno]

Title: [116665] trunk/LayoutTests








Revision 116665
Author infe...@chromium.org
Date 2012-05-10 11:23:06 -0700 (Thu, 10 May 2012)


Log Message
Unreviewed. Correct spelling in test name.

* editing/inserting/insert-paragraph-separator-crash-expected.txt: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt.
* editing/inserting/insert-paragraph-separator-crash.html: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt
trunk/LayoutTests/editing/inserting/insert-paragraph-separator-crash.html


Removed Paths

trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt
trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (116664 => 116665)

--- trunk/LayoutTests/ChangeLog	2012-05-10 18:22:59 UTC (rev 116664)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 18:23:06 UTC (rev 116665)
@@ -1,3 +1,10 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Unreviewed. Correct spelling in test name.
+
+* editing/inserting/insert-paragraph-separator-crash-expected.txt: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt.
+* editing/inserting/insert-paragraph-separator-crash.html: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html.
+
 2012-05-10  Shezan Baig shezbaig...@gmail.com
 
 Test from bug 34875 does not work on chromium/mac


Copied: trunk/LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt (from rev 116663, trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt) (0 => 116665)

--- trunk/LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt	2012-05-10 18:23:06 UTC (rev 116665)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.


Copied: trunk/LayoutTests/editing/inserting/insert-paragraph-separator-crash.html (from rev 116663, trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html) (0 => 116665)

--- trunk/LayoutTests/editing/inserting/insert-paragraph-separator-crash.html	(rev 0)
+++ trunk/LayoutTests/editing/inserting/insert-paragraph-separator-crash.html	2012-05-10 18:23:06 UTC (rev 116665)
@@ -0,0 +1,34 @@
+!DOCTYPE html
+html
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function handler() {
+var element = event.srcElement;
+document.execCommand('Undo', false, false);
+element.parentNode.removeChild(element);
+var em = document.getElementById('em');
+var span = document.getElementById('span');
+em.insertBefore(element, span);
+document.execCommand('JustifyFull', false, false);
+}
+document.addEventListener(DOMCharacterDataModified, handler, true);
+
+window._onload_ = function() {
+var selection = window.getSelection();
+document.execCommand(SelectAll, false, false)
+var element = document.getElementById(ruby);
+element.innerHTML = em id='em'^x?xspan id='span'x'x;
+selection.deleteFromDocument();
+selection.deleteFromDocument();
+document.designMode = on;
+document.execCommand('JustifyRight', false, false);
+document.execCommand('InsertHorizontalRule', false, '');
+document.documentElement.innerHTML = PASS. WebKit didn't crash.;
+};
+/script
+ruby id=ruby
+aA/a
+/ruby
+/html


Deleted: trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt (116664 => 116665)

--- trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt	2012-05-10 18:22:59 UTC (rev 116664)
+++ trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt	2012-05-10 18:23:06 UTC (rev 116665)
@@ -1 +0,0 @@
-PASS. WebKit didn't crash.


Deleted: trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html (116664 => 116665)

--- trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html	2012-05-10 18:22:59 UTC (rev 116664)
+++ trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html	2012-05-10 18:23:06 UTC (rev 116665)
@@ -1,34 +0,0 @@
-!DOCTYPE html
-html
-script
-if (window.layoutTestController)
-layoutTestController.dumpAsText();
-
-function handler() {
-var element = event.srcElement;
-document.execCommand('Undo', false, false);
-element.parentNode.removeChild(element);
-var em = document.getElementById('em');
-var span = document.getElementById('span');
-em.insertBefore(element, span);
-document.execCommand('JustifyFull', false, false);
-}
-document.addEventListener(DOMCharacterDataModified, handler, true);
-
-window._onload_ = function() {
-var selection = 

[webkit-changes] [116666] trunk/Source

[pilgrim]

Title: [11] trunk/Source








Revision 11
Author pilg...@chromium.org
Date 2012-05-10 11:25:52 -0700 (Thu, 10 May 2012)


Log Message
[Chromium] Remove dead code behind unused WEBKIT_USING_CG
https://bugs.webkit.org/show_bug.cgi?id=86018

Reviewed by Adam Barth.

We never use CoreGraphics as the backend for GraphicsContext in
Chromium, so this is all dead code.

Source/Platform:

* chromium/public/WebCanvas.h:
(WebKit):
* chromium/public/WebImage.h:
(WebImage):

Source/WebKit/chromium:

* README:
* src/PageOverlay.cpp:
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::paintContents):
* src/WebFontImpl.cpp:
(WebKit::WebFontImpl::drawText):
* src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::getFrameAtIndex):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::paint):
(WebKit::WebPluginContainerImpl::printPage):
* src/painting/GraphicsContextBuilder.h:
(WebKit):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebCanvas.h
trunk/Source/Platform/chromium/public/WebImage.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/README
trunk/Source/WebKit/chromium/src/PageOverlay.cpp
trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebFontImpl.cpp
trunk/Source/WebKit/chromium/src/WebImageDecoder.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Source/WebKit/chromium/src/painting/GraphicsContextBuilder.h




Diff

Modified: trunk/Source/Platform/ChangeLog (116665 => 11)

--- trunk/Source/Platform/ChangeLog	2012-05-10 18:23:06 UTC (rev 116665)
+++ trunk/Source/Platform/ChangeLog	2012-05-10 18:25:52 UTC (rev 11)
@@ -1,3 +1,18 @@
+2012-05-10  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove dead code behind unused WEBKIT_USING_CG
+https://bugs.webkit.org/show_bug.cgi?id=86018
+
+Reviewed by Adam Barth.
+
+We never use CoreGraphics as the backend for GraphicsContext in
+Chromium, so this is all dead code.
+
+* chromium/public/WebCanvas.h:
+(WebKit):
+* chromium/public/WebImage.h:
+(WebImage):
+
 2012-05-09  Mark Pilgrim  pilg...@chromium.org
 
 [Chromium] Move clipboard to Platform.h


Modified: trunk/Source/Platform/chromium/public/WebCanvas.h (116665 => 11)

--- trunk/Source/Platform/chromium/public/WebCanvas.h	2012-05-10 18:23:06 UTC (rev 116665)
+++ trunk/Source/Platform/chromium/public/WebCanvas.h	2012-05-10 18:25:52 UTC (rev 11)
@@ -35,16 +35,12 @@
 
 #if WEBKIT_USING_SKIA
 class SkCanvas;
-#elif WEBKIT_USING_CG
-struct CGContext;
 #endif
 
 namespace WebKit {
 
 #if WEBKIT_USING_SKIA
 typedef SkCanvas WebCanvas;
-#elif WEBKIT_USING_CG
-typedef struct CGContext WebCanvas;
 #else
 #error Need to define WebCanvas
 #endif


Modified: trunk/Source/Platform/chromium/public/WebImage.h (116665 => 11)

--- trunk/Source/Platform/chromium/public/WebImage.h	2012-05-10 18:23:06 UTC (rev 116665)
+++ trunk/Source/Platform/chromium/public/WebImage.h	2012-05-10 18:25:52 UTC (rev 11)
@@ -35,8 +35,6 @@
 
 #if WEBKIT_USING_SKIA
 #include SkBitmap.h
-#elif WEBKIT_USING_CG
-typedef struct CGImage* CGImageRef;
 #endif
 
 #if WEBKIT_IMPLEMENTATION
@@ -99,25 +97,6 @@
 void init() { }
 SkBitmap m_bitmap;
 
-#elif WEBKIT_USING_CG
-WebImage(CGImageRef imageRef)
-{
-init();
-assign(imageRef);
-}
-
-WebImage operator=(CGImageRef imageRef)
-{
-assign(imageRef);
-return *this;
-}
-
-CGImageRef getCGImageRef() const { return m_imageRef; }
-
-private:
-void init() { m_imageRef = 0; }
-WEBKIT_EXPORT void assign(CGImageRef);
-CGImageRef m_imageRef;
 #endif
 };
 


Modified: trunk/Source/WebKit/chromium/ChangeLog (116665 => 11)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-05-10 18:23:06 UTC (rev 116665)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-05-10 18:25:52 UTC (rev 11)
@@ -1,3 +1,27 @@
+2012-05-10  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Remove dead code behind unused WEBKIT_USING_CG
+https://bugs.webkit.org/show_bug.cgi?id=86018
+
+Reviewed by Adam Barth.
+
+We never use CoreGraphics as the backend for GraphicsContext in
+Chromium, so this is all dead code.
+
+* README:
+* src/PageOverlay.cpp:
+* src/WebContentLayerImpl.cpp:
+(WebKit::WebContentLayerImpl::paintContents):
+* src/WebFontImpl.cpp:
+(WebKit::WebFontImpl::drawText):
+* src/WebImageDecoder.cpp:
+(WebKit::WebImageDecoder::getFrameAtIndex):
+* src/WebPluginContainerImpl.cpp:
+(WebKit::WebPluginContainerImpl::paint):
+(WebKit::WebPluginContainerImpl::printPage):
+* src/painting/GraphicsContextBuilder.h:
+(WebKit):
+
 2012-05-10  Sam D  dsam2...@gmail.com
 
 Web Inspector: rename InspectorBackendStub.js to InspectorBackendCommands.js


Modified: 

[webkit-changes] [116669] trunk

[inferno]

Title: [116669] trunk








Revision 116669
Author infe...@chromium.org
Date 2012-05-10 11:39:43 -0700 (Thu, 10 May 2012)


Log Message
Crash in ApplyStyleCommand::joinChildTextNodes.
https://bugs.webkit.org/show_bug.cgi?id=85939

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/style/apply-style-join-child-text-nodes-crash.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): add conditions
to bail out if our start and end position nodes are removed due to
mutation events in joinChildTextNodes.
(WebCore::ApplyStyleCommand::applyInlineStyle): this executes after
applyRelativeFontStyleChange in ApplyStyleCommand::doApply. So, need
to bail out if our start and end position nodes are removed due to
mutation events.
(WebCore::ApplyStyleCommand::joinChildTextNodes): hold all the children
in a ref vector to prevent them from getting destroyed due to mutation events.

LayoutTests:

* editing/style/apply-style-join-child-text-nodes-crash-expected.txt: Added.
* editing/style/apply-style-join-child-text-nodes-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ApplyStyleCommand.cpp


Added Paths

trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash-expected.txt
trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (116668 => 116669)

--- trunk/LayoutTests/ChangeLog	2012-05-10 18:38:34 UTC (rev 116668)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 18:39:43 UTC (rev 116669)
@@ -1,5 +1,15 @@
 2012-05-10  Abhishek Arya  infe...@chromium.org
 
+Crash in ApplyStyleCommand::joinChildTextNodes.
+https://bugs.webkit.org/show_bug.cgi?id=85939
+
+Reviewed by Ryosuke Niwa.
+
+* editing/style/apply-style-join-child-text-nodes-crash-expected.txt: Added.
+* editing/style/apply-style-join-child-text-nodes-crash.html: Added.
+
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
 Unreviewed. Correct spelling in test name.
 
 * editing/inserting/insert-paragraph-separator-crash-expected.txt: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt.


Added: trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash-expected.txt (0 => 116669)

--- trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash-expected.txt	2012-05-10 18:39:43 UTC (rev 116669)
@@ -0,0 +1,4 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS. WebKit didn't crash.


Added: trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html (0 => 116669)

--- trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html	(rev 0)
+++ trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html	2012-05-10 18:39:43 UTC (rev 116669)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+body
+script src=""
+script id=script1
+document.addEventListener(DOMCharacterDataModified,function(){
+document.body.innerHTML = PASS. WebKit didn't crash.; 
+gc();
+finishJSTest();
+},true);
+/script
+script
+window.jsTestIsAsync = true;
+
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+var scriptElement = document.getElementById('script1');
+scriptElement.parentNode.appendChild(scriptElement.firstChild);
+scriptElement.parentNode.removeChild(scriptElement);
+document.designMode = on;
+document.execCommand(SelectAll);
+document.execCommand(FontSizeDelta, false, 3);
+/script
+script src=""
+/body
+/html
+
Property changes on: trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html
___


Added: svn:executable

Modified: trunk/Source/WebCore/ChangeLog (116668 => 116669)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 18:38:34 UTC (rev 116668)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 18:39:43 UTC (rev 116669)
@@ -1,3 +1,23 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Crash in ApplyStyleCommand::joinChildTextNodes.
+https://bugs.webkit.org/show_bug.cgi?id=85939
+
+Reviewed by Ryosuke Niwa.
+
+Test: editing/style/apply-style-join-child-text-nodes-crash.html
+
+* editing/ApplyStyleCommand.cpp:
+(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): add conditions
+to bail out if our start and end position nodes are removed due to 
+mutation events in joinChildTextNodes.
+(WebCore::ApplyStyleCommand::applyInlineStyle): this executes after
+applyRelativeFontStyleChange in ApplyStyleCommand::doApply. So, need
+to bail out if our start and end position nodes are removed due to
+mutation events.
+(WebCore::ApplyStyleCommand::joinChildTextNodes): hold 

[webkit-changes] [116670] trunk/Source/JavaScriptCore

[barraclough]

Title: [116670] trunk/Source/_javascript_Core








Revision 116670
Author barraclo...@apple.com
Date 2012-05-10 11:40:29 -0700 (Thu, 10 May 2012)


Log Message
Cache inheritorID on JSFunction
https://bugs.webkit.org/show_bug.cgi?id=85853

Reviewed by Geoff Garen  Filip Pizlo.

An object's prototype is indicated via its structure.  To create an otherwise
empty object with object A as its prototype, we require a structure with its
prototype set to point to A.  We wish to use this same structure for all empty
objects created with a prototype of A, so we presently store this structure as
a property of A, known as the inheritorID.

When a function F is invoked as a constructor, where F has a property 'prototype'
set to point to A, in order to create the 'this' value for the constructor to
use the following steps are taken:
  - the 'prototype' proptery of F is read, via a regular [[Get]] access.
  - the inheritorID internal property of the prototype is read.
  - a new, empty object is constructed with its structure set to point to inheritorID.

There are two drawbacks to the current approach:
  - it requires that every object has an inheritorID field.
  - it requires a [[Get]] access on every constructor call to access the 'prototype' property.

Instead, switch to caching a copy of the inheritorID on the function.  Constructor
calls now only need read the internal property from the callee, saving a [[Get]].
This also means that JSObject::m_inheritorID is no longer commonly read, and in a
future patch we can move to storing this in a more memory efficient fashion.

* _javascript_Core.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSFunction):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::cacheInheritorID):
(JSC):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):
* runtime/JSFunction.h:
(JSC::JSFunction::cachedInheritorID):
(JSFunction):
(JSC::JSFunction::offsetOfCachedInheritorID):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/Opcode.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/jit/JITInlineMethods.h
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (116669 => 116670)

--- trunk/Source/_javascript_Core/ChangeLog	2012-05-10 18:39:43 UTC (rev 116669)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-05-10 18:40:29 UTC (rev 116670)
@@ -1,3 +1,81 @@
+2012-05-10  Gavin Barraclough  barraclo...@apple.com
+
+Cache inheritorID on JSFunction
+https://bugs.webkit.org/show_bug.cgi?id=85853
+
+Reviewed by Geoff Garen  Filip Pizlo.
+
+An object's prototype is indicated via its structure.  To create an otherwise
+empty object with object A as its prototype, we require a structure with its
+prototype set to point to A.  We wish to use this same structure for all empty
+objects created with a prototype of A, so we 

[webkit-changes] [116671] trunk

[commit-queue]

Title: [116671] trunk








Revision 116671
Author commit-qu...@webkit.org
Date 2012-05-10 11:42:54 -0700 (Thu, 10 May 2012)


Log Message
[chromium] Trigger context menu for long press gesture
https://bugs.webkit.org/show_bug.cgi?id=85919

Patch by Varun Jain varunj...@google.com on 2012-05-10
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/touch/gesture/context-menu-on-long-press.html

* page/EventHandler.cpp:
(WebCore):
(WebCore::EventHandler::sendContextMenuEventForGesture):
* page/EventHandler.h:
(EventHandler):

Source/WebKit/chromium:

* src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):

Tools:

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::gestureLongPress):
(EventSender::gestureEvent):
* DumpRenderTree/chromium/EventSender.h:
(EventSender):

LayoutTests:

* fast/events/touch/gesture/context-menu-on-long-press.html: Added.
* platform/chromium/fast/events/touch/gesture/context-menu-on-long-press-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PageWidgetDelegate.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/EventSender.cpp
trunk/Tools/DumpRenderTree/chromium/EventSender.h


Added Paths

trunk/LayoutTests/fast/events/touch/gesture/context-menu-on-long-press.html
trunk/LayoutTests/platform/chromium/fast/events/touch/gesture/context-menu-on-long-press-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116670 => 116671)

--- trunk/LayoutTests/ChangeLog	2012-05-10 18:40:29 UTC (rev 116670)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 18:42:54 UTC (rev 116671)
@@ -1,3 +1,13 @@
+2012-05-10  Varun Jain  varunj...@google.com
+
+[chromium] Trigger context menu for long press gesture
+https://bugs.webkit.org/show_bug.cgi?id=85919
+
+Reviewed by Adam Barth.
+
+* fast/events/touch/gesture/context-menu-on-long-press.html: Added.
+* platform/chromium/fast/events/touch/gesture/context-menu-on-long-press-expected.txt: Added.
+
 2012-05-10  Abhishek Arya  infe...@chromium.org
 
 Crash in ApplyStyleCommand::joinChildTextNodes.


Added: trunk/LayoutTests/fast/events/touch/gesture/context-menu-on-long-press.html (0 => 116671)

--- trunk/LayoutTests/fast/events/touch/gesture/context-menu-on-long-press.html	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/gesture/context-menu-on-long-press.html	2012-05-10 18:42:54 UTC (rev 116671)
@@ -0,0 +1,34 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body _onload_=test()
+pThis test checks that the context menu is shown on long press gesture./p
+div id=textTesting/div
+div id=resultFAIL/div
+script
+function test()
+{
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+document._oncontextmenu_ = function() { document.getElementById(result).innerHTML = PASS; }
+
+var text = document.getElementById(text);
+
+var x = text.offsetParent.offsetLeft + text.offsetLeft + 4;
+var y = text.offsetParent.offsetTop + text.offsetTop + text.offsetHeight / 2;
+
+if (!window.eventSender)
+return;
+if (eventSender.gestureLongPress) {
+eventSender.gestureLongPress(x, y);
+} else {
+debug(gestureLongPress not implemented by this platform);
+return;
+}
+}
+/script
+/body
+/html


Added: trunk/LayoutTests/platform/chromium/fast/events/touch/gesture/context-menu-on-long-press-expected.txt (0 => 116671)

--- trunk/LayoutTests/platform/chromium/fast/events/touch/gesture/context-menu-on-long-press-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/touch/gesture/context-menu-on-long-press-expected.txt	2012-05-10 18:42:54 UTC (rev 116671)
@@ -0,0 +1,4 @@
+This test checks that the context menu is shown on long press gesture.
+
+Testing
+PASS


Modified: trunk/Source/WebCore/ChangeLog (116670 => 116671)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 18:40:29 UTC (rev 116670)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 18:42:54 UTC (rev 116671)
@@ -1,3 +1,18 @@
+2012-05-10  Varun Jain  varunj...@google.com
+
+[chromium] Trigger context menu for long press gesture
+https://bugs.webkit.org/show_bug.cgi?id=85919
+
+Reviewed by Adam Barth.
+
+Test: fast/events/touch/gesture/context-menu-on-long-press.html
+
+* page/EventHandler.cpp:
+(WebCore):
+(WebCore::EventHandler::sendContextMenuEventForGesture):
+* page/EventHandler.h:
+(EventHandler):
+
 2012-05-10  Abhishek Arya  infe...@chromium.org
 
 Crash in ApplyStyleCommand::joinChildTextNodes.


Modified: 

[webkit-changes] [116672] trunk/Source/WebCore

[pfeldman]

Title: [116672] trunk/Source/WebCore








Revision 116672
Author pfeld...@chromium.org
Date 2012-05-10 11:47:04 -0700 (Thu, 10 May 2012)


Log Message
Web Inspector: search title is shown beside the search field (not under) in the vertical mode.
https://bugs.webkit.org/show_bug.cgi?id=86120

Reviewed by Yury Semikhatsky.

This change makes search title render as placeholder at all times.
It also adjusts the size of the search field when navigation arrows appear.

* inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._createSearchNavigationButton):
* inspector/front-end/inspector.css:
(#toolbar-search-item):
(.with-navigation-buttons #search):
(.toolbar-search-navigation-label):
(.with-navigation-buttons .toolbar-search-navigation-label):
* inspector/front-end/inspector.html:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SearchController.js
trunk/Source/WebCore/inspector/front-end/inspector.css
trunk/Source/WebCore/inspector/front-end/inspector.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (116671 => 116672)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 18:42:54 UTC (rev 116671)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 18:47:04 UTC (rev 116672)
@@ -1,3 +1,25 @@
+2012-05-10  Pavel Feldman  pfeld...@chromium.org
+
+Web Inspector: search title is shown beside the search field (not under) in the vertical mode.
+https://bugs.webkit.org/show_bug.cgi?id=86120
+
+Reviewed by Yury Semikhatsky.
+
+This change makes search title render as placeholder at all times.
+It also adjusts the size of the search field when navigation arrows appear.
+
+* inspector/front-end/SearchController.js:
+(WebInspector.SearchController):
+(WebInspector.SearchController.prototype.updateSearchLabel):
+(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
+(WebInspector.SearchController.prototype._createSearchNavigationButton):
+* inspector/front-end/inspector.css:
+(#toolbar-search-item):
+(.with-navigation-buttons #search):
+(.toolbar-search-navigation-label):
+(.with-navigation-buttons .toolbar-search-navigation-label):
+* inspector/front-end/inspector.html:
+
 2012-05-10  Varun Jain  varunj...@google.com
 
 [chromium] Trigger context menu for long press gesture


Modified: trunk/Source/WebCore/inspector/front-end/SearchController.js (116671 => 116672)

--- trunk/Source/WebCore/inspector/front-end/SearchController.js	2012-05-10 18:42:54 UTC (rev 116671)
+++ trunk/Source/WebCore/inspector/front-end/SearchController.js	2012-05-10 18:47:04 UTC (rev 116672)
@@ -36,7 +36,7 @@
 {
 this.element = document.getElementById(search);
 this._matchesElement = document.getElementById(search-results-matches);
-this._toolbarLabelElement = document.getElementById(search-toolbar-label);
+this._searchItemElement = document.getElementById(toolbar-search-item);
 this._searchControlBoxElement = document.getElementById(toolbar-search-navigation-control);
 
 this.element.addEventListener(search, this._onSearch.bind(this), false); // when the search is emptied
@@ -70,12 +70,7 @@
 if (!panelName)
 return;
 var newLabel = WebInspector.UIString(Search %s, panelName);
-if (WebInspector.isCompactMode())
-this.element.setAttribute(placeholder, newLabel);
-else {
-this.element.removeAttribute(placeholder);
-this._toolbarLabelElement.textContent = newLabel;
-}
+this.element.setAttribute(placeholder, newLabel);
 },
 
 cancelSearch: function()
@@ -156,13 +151,10 @@
 
 _updateSearchNavigationButtonState: function(visible)
 {
-if (visible) {
-this._searchNavigationNext.removeStyleClass(hidden);
-this._searchNavigationPrev.removeStyleClass(hidden);
-} else {
-this._searchNavigationNext.addStyleClass(hidden);
-this._searchNavigationPrev.addStyleClass(hidden);
-}
+if (visible)
+this._searchItemElement.addStyleClass(with-navigation-buttons);
+else
+this._searchItemElement.removeStyleClass(with-navigation-buttons);
 },
 
 /**
@@ -338,7 +330,7 @@
 var searchNavigationControlElement = document.createElement(div);
 var searchNavigationIconElement = document.createElement(div);
 
-searchNavigationControlElement.className = toolbar-search-navigation-label hidden;
+searchNavigationControlElement.className = toolbar-search-navigation-label;
 
 switch (direction) {
 case prev:


Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (116671 => 

[webkit-changes] [116673] trunk/Source/JavaScriptCore

[barraclough]

Title: [116673] trunk/Source/_javascript_Core








Revision 116673
Author barraclo...@apple.com
Date 2012-05-10 12:01:07 -0700 (Thu, 10 May 2012)


Log Message
Remove op_get_callee

Rubber stamped by Geoff Garen.

This is now redundant.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC):
* jit/JITOpcodes32_64.cpp:
(JSC):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/Opcode.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGCapabilities.h
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (116672 => 116673)

--- trunk/Source/_javascript_Core/ChangeLog	2012-05-10 18:47:04 UTC (rev 116672)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-05-10 19:01:07 UTC (rev 116673)
@@ -1,5 +1,34 @@
 2012-05-10  Gavin Barraclough  barraclo...@apple.com
 
+Remove op_get_callee
+
+Rubber stamped by Geoff Garen.
+
+This is now redundant.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::dump):
+* bytecode/Opcode.h:
+(JSC):
+(JSC::padOpcodeName):
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGCapabilities.h:
+(JSC::DFG::canCompileOpcode):
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::privateExecute):
+* jit/JIT.cpp:
+(JSC::JIT::privateCompileMainPass):
+* jit/JIT.h:
+* jit/JITOpcodes.cpp:
+(JSC):
+* jit/JITOpcodes32_64.cpp:
+(JSC):
+* llint/LowLevelInterpreter32_64.asm:
+* llint/LowLevelInterpreter64.asm:
+
+2012-05-10  Gavin Barraclough  barraclo...@apple.com
+
 Cache inheritorID on JSFunction
 https://bugs.webkit.org/show_bug.cgi?id=85853
 


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (116672 => 116673)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2012-05-10 18:47:04 UTC (rev 116672)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2012-05-10 19:01:07 UTC (rev 116673)
@@ -512,11 +512,6 @@
 dataLog([%4d] init_lazy_reg\t %s\n, location, registerName(exec, r0).data());
 break;
 }
-case op_get_callee: {
-int r0 = (++it)-u.operand;
-dataLog([%4d] op_get_callee %s\n, location, registerName(exec, r0).data());
-break;
-}
 case op_create_this: {
 int r0 = (++it)-u.operand;
 dataLog([%4d] create_this %s\n, location, registerName(exec, r0).data());


Modified: trunk/Source/_javascript_Core/bytecode/Opcode.h (116672 => 116673)

--- trunk/Source/_javascript_Core/bytecode/Opcode.h	2012-05-10 18:47:04 UTC (rev 116672)
+++ trunk/Source/_javascript_Core/bytecode/Opcode.h	2012-05-10 19:01:07 UTC (rev 116673)
@@ -43,7 +43,6 @@
 macro(op_init_lazy_reg, 2) \
 macro(op_create_arguments, 2) \
 macro(op_create_this, 2) \
-macro(op_get_callee, 2) \
 macro(op_convert_this, 2) \
 \
 macro(op_new_object, 2) \


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (116672 => 116673)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2012-05-10 18:47:04 UTC (rev 116672)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2012-05-10 19:01:07 UTC (rev 116673)
@@ -1567,14 +1567,6 @@
 NEXT_OPCODE(op_new_regexp);
 }
 
-case op_get_callee: {
-if (m_inlineStackTop-m_inlineCallFrame)
-set(currentInstruction[1].u.operand, getDirect(m_inlineStackTop-m_calleeVR));
-else
-set(currentInstruction[1].u.operand, addToGraph(GetCallee));
-NEXT_OPCODE(op_get_callee);
-}
-
 // === Bitwise operations ===
 
 case op_bitand: {


Modified: trunk/Source/_javascript_Core/dfg/DFGCapabilities.h (116672 => 116673)

--- trunk/Source/_javascript_Core/dfg/DFGCapabilities.h	2012-05-10 18:47:04 UTC (rev 116672)
+++ trunk/Source/_javascript_Core/dfg/DFGCapabilities.h	2012-05-10 19:01:07 UTC (rev 116673)
@@ -73,7 +73,6 @@
 case op_enter:
 case 

[webkit-changes] [116674] trunk

[tommyw]

Title: [116674] trunk








Revision 116674
Author tom...@google.com
Date 2012-05-10 12:11:17 -0700 (Thu, 10 May 2012)


Log Message
[chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=86087

Reviewed by Adam Barth.

Source/WebCore:

Not easy to test but I have added code that excercises this to WebUserMediaClientMock (in DumpRenderTree).

* platform/chromium/support/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::setExtraData):

Tools:

* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(MockExtraData):
(WebKit):
(WebKit::WebUserMediaClientMock::requestUserMedia):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/support/WebMediaStreamDescriptor.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116673 => 116674)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 19:01:07 UTC (rev 116673)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 19:11:17 UTC (rev 116674)
@@ -1,3 +1,15 @@
+2012-05-10  Tommy Widenflycht  tom...@google.com
+
+[chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
+https://bugs.webkit.org/show_bug.cgi?id=86087
+
+Reviewed by Adam Barth.
+
+Not easy to test but I have added code that excercises this to WebUserMediaClientMock (in DumpRenderTree).
+
+* platform/chromium/support/WebMediaStreamDescriptor.cpp:
+(WebKit::WebMediaStreamDescriptor::setExtraData):
+
 2012-05-10  Pavel Feldman  pfeld...@chromium.org
 
 Web Inspector: search title is shown beside the search field (not under) in the vertical mode.


Modified: trunk/Source/WebCore/platform/chromium/support/WebMediaStreamDescriptor.cpp (116673 => 116674)

--- trunk/Source/WebCore/platform/chromium/support/WebMediaStreamDescriptor.cpp	2012-05-10 19:01:07 UTC (rev 116673)
+++ trunk/Source/WebCore/platform/chromium/support/WebMediaStreamDescriptor.cpp	2012-05-10 19:11:17 UTC (rev 116674)
@@ -88,7 +88,7 @@
 
 void WebMediaStreamDescriptor::setExtraData(ExtraData* extraData)
 {
-m_private-setExtraData(new ExtraDataContainer(extraData));
+m_private-setExtraData(adoptRef(new ExtraDataContainer(extraData)));
 }
 
 // FIXME: Cleanup when the chromium code has switched to the split sources implementation.


Modified: trunk/Tools/ChangeLog (116673 => 116674)

--- trunk/Tools/ChangeLog	2012-05-10 19:01:07 UTC (rev 116673)
+++ trunk/Tools/ChangeLog	2012-05-10 19:11:17 UTC (rev 116674)
@@ -1,3 +1,15 @@
+2012-05-10  Tommy Widenflycht  tom...@google.com
+
+[chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
+https://bugs.webkit.org/show_bug.cgi?id=86087
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
+(MockExtraData):
+(WebKit):
+(WebKit::WebUserMediaClientMock::requestUserMedia):
+
 2012-05-10  Varun Jain  varunj...@google.com
 
 [chromium] Trigger context menu for long press gesture


Modified: trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp (116673 => 116674)

--- trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp	2012-05-10 19:01:07 UTC (rev 116673)
+++ trunk/Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp	2012-05-10 19:11:17 UTC (rev 116674)
@@ -42,6 +42,11 @@
 
 namespace WebKit {
 
+class MockExtraData : public WebMediaStreamDescriptor::ExtraData {
+public:
+int foo;
+};
+
 PassOwnPtrWebUserMediaClientMock WebUserMediaClientMock::create()
 {
 return adoptPtr(new WebUserMediaClientMock());
@@ -63,7 +68,12 @@
 if (request.video())
 videoSources[0].initialize(MockVideoDevice#1, WebMediaStreamSource::TypeVideo, Mock video device);
 
-request.requestSucceeded(audioSources, videoSources);
+WebKit::WebMediaStreamDescriptor descriptor;
+descriptor.initialize(foobar, audioSources, videoSources);
+
+descriptor.setExtraData(new MockExtraData());
+
+request.requestSucceeded(descriptor);
 }
 
 void WebUserMediaClientMock::cancelUserMediaRequest(const WebUserMediaRequest)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116675] trunk/Source/WebCore

[tommyw]

Title: [116675] trunk/Source/WebCore








Revision 116675
Author tom...@google.com
Date 2012-05-10 12:17:21 -0700 (Thu, 10 May 2012)


Log Message
MediaStream API: Fix MediaHints parsing
https://bugs.webkit.org/show_bug.cgi?id=86098

Reviewed by Adam Barth.

Not currently testable. Working on a series of patches that will fix that.

* Modules/mediastream/PeerConnection00.cpp:
(WebCore::PeerConnection00::createMediaHints):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/PeerConnection00.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116674 => 116675)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 19:11:17 UTC (rev 116674)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 19:17:21 UTC (rev 116675)
@@ -1,5 +1,17 @@
 2012-05-10  Tommy Widenflycht  tom...@google.com
 
+MediaStream API: Fix MediaHints parsing
+https://bugs.webkit.org/show_bug.cgi?id=86098
+
+Reviewed by Adam Barth.
+
+Not currently testable. Working on a series of patches that will fix that.
+
+* Modules/mediastream/PeerConnection00.cpp:
+(WebCore::PeerConnection00::createMediaHints):
+
+2012-05-10  Tommy Widenflycht  tom...@google.com
+
 [chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
 https://bugs.webkit.org/show_bug.cgi?id=86087
 


Modified: trunk/Source/WebCore/Modules/mediastream/PeerConnection00.cpp (116674 => 116675)

--- trunk/Source/WebCore/Modules/mediastream/PeerConnection00.cpp	2012-05-10 19:11:17 UTC (rev 116674)
+++ trunk/Source/WebCore/Modules/mediastream/PeerConnection00.cpp	2012-05-10 19:17:21 UTC (rev 116675)
@@ -96,7 +96,7 @@
 bool audio = hasLocalAudioTrack();
 bool video = hasLocalVideoTrack();
 dictionary.get(has_audio, audio);
-dictionary.get(has_video, audio);
+dictionary.get(has_video, video);
 return MediaHints::create(audio, video);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116676] trunk/Tools

[rakuco]

Title: [116676] trunk/Tools








Revision 116676
Author rak...@webkit.org
Date 2012-05-10 12:28:18 -0700 (Thu, 10 May 2012)


Log Message
[EFL][webkitpy] Do not redefine check_build() in EflPort.
https://bugs.webkit.org/show_bug.cgi?id=86124

Reviewed by Dirk Pranke.

Remove an old FIXME and do not redefine check_build in EflPort;
once build-dumprendertree recognizes --efl, we can use the
check_build implementation in WebKitPort.

* Scripts/build-dumprendertree:
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.check_build):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-dumprendertree
trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py




Diff

Modified: trunk/Tools/ChangeLog (116675 => 116676)

--- trunk/Tools/ChangeLog	2012-05-10 19:17:21 UTC (rev 116675)
+++ trunk/Tools/ChangeLog	2012-05-10 19:28:18 UTC (rev 116676)
@@ -1,3 +1,18 @@
+2012-05-10  Raphael Kubo da Costa  rak...@webkit.org
+
+[EFL][webkitpy] Do not redefine check_build() in EflPort.
+https://bugs.webkit.org/show_bug.cgi?id=86124
+
+Reviewed by Dirk Pranke.
+
+Remove an old FIXME and do not redefine check_build in EflPort;
+once build-dumprendertree recognizes --efl, we can use the
+check_build implementation in WebKitPort.
+
+* Scripts/build-dumprendertree:
+* Scripts/webkitpy/layout_tests/port/efl.py:
+(EflPort.check_build):
+
 2012-05-10  Tommy Widenflycht  tom...@google.com
 
 [chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor


Modified: trunk/Tools/Scripts/build-dumprendertree (116675 => 116676)

--- trunk/Tools/Scripts/build-dumprendertree	2012-05-10 19:17:21 UTC (rev 116675)
+++ trunk/Tools/Scripts/build-dumprendertree	2012-05-10 19:28:18 UTC (rev 116676)
@@ -46,6 +46,7 @@
   --qt  Build the Qt port
   --wx  Build the wxWindows port
   --chromiumBuild the Chromium port
+  --efl Build the EFL port
 EOF
 
 GetOptions(
@@ -70,8 +71,8 @@
 $result = buildXCodeProject(DumpRenderTree, $clean, XcodeOptions(), @ARGV);
 } elsif (isAppleWinWebKit()) {
 $result = buildVisualStudioProject(DumpRenderTree.sln, $clean);
-} elsif (isQt() || isGtk() || isWx() || isChromium()) {
-# Qt, Gtk wxWindows, and Chromium build everything in one shot. No need to build anything here.
+} elsif (isQt() || isGtk() || isWx() || isChromium() || isEfl()) {
+# Qt, Gtk wxWindows, Chromium and EFL build everything in one shot. No need to build anything here.
 $result = 0;
 } else {
 die Building not defined for this platform!\n;


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py (116675 => 116676)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py	2012-05-10 19:17:21 UTC (rev 116675)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py	2012-05-10 19:28:18 UTC (rev 116676)
@@ -62,10 +62,6 @@
 def _path_to_image_diff(self):
 return self._build_path('bin', 'ImageDiff')
 
-# FIXME: I doubt EFL wants to override this method.
-def check_build(self, needs_http):
-return self._check_driver()
-
 def _path_to_webcore_library(self):
 static_path = self._build_path('WebCore', 'libwebcore_efl.a')
 dyn_path = self._build_path('WebCore', 'libwebcore_efl.so')






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116677] trunk/Source/WebCore

[antti]

Title: [116677] trunk/Source/WebCore








Revision 116677
Author an...@apple.com
Date 2012-05-10 12:52:05 -0700 (Thu, 10 May 2012)


Log Message
Inline Node::traverseNextNode
https://bugs.webkit.org/show_bug.cgi?id=85844

Reviewed by Ryosuke Niwa.

Inline traverseNextNode and traverseNextSibling to reduce entry/exit overhead and allow better code generation
for many hot loops.

In this version only the firstChild()/nextSibling() tests are inlined and the ancestor traversal is not.

Performance bots will tell if this was worthwhile.

* dom/ContainerNode.h:
(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):
* dom/Node.cpp:
(WebCore::Node::traverseNextAncestorSibling):
* dom/Node.h:
(Node):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116676 => 116677)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 19:28:18 UTC (rev 116676)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 19:52:05 UTC (rev 116677)
@@ -1,3 +1,26 @@
+2012-05-10  Antti Koivisto  an...@apple.com
+
+Inline Node::traverseNextNode
+https://bugs.webkit.org/show_bug.cgi?id=85844
+
+Reviewed by Ryosuke Niwa.
+
+Inline traverseNextNode and traverseNextSibling to reduce entry/exit overhead and allow better code generation
+for many hot loops.
+
+In this version only the firstChild()/nextSibling() tests are inlined and the ancestor traversal is not.
+
+Performance bots will tell if this was worthwhile.
+
+* dom/ContainerNode.h:
+(WebCore::Node::traverseNextNode):
+(WebCore):
+(WebCore::Node::traverseNextSibling):
+* dom/Node.cpp:
+(WebCore::Node::traverseNextAncestorSibling):
+* dom/Node.h:
+(Node):
+
 2012-05-10  Tommy Widenflycht  tom...@google.com
 
 MediaStream API: Fix MediaHints parsing


Modified: trunk/Source/WebCore/WebCore.exp.in (116676 => 116677)

--- trunk/Source/WebCore/WebCore.exp.in	2012-05-10 19:28:18 UTC (rev 116676)
+++ trunk/Source/WebCore/WebCore.exp.in	2012-05-10 19:52:05 UTC (rev 116677)
@@ -2099,7 +2099,7 @@
 __ZN7WebCore8Document36setFullScreenRendererBackgroundColorENS_5ColorE
 __ZN7WebCore8Document22setAnimatingFullScreenEb
 __ZNK7WebCore8Document9domWindowEv
-__ZNK7WebCore4Node16traverseNextNodeEPKS0_
+__ZNK7WebCore4Node27traverseNextAncestorSiblingEv
 #endif
 
 __ZN7WebCore16ApplicationCache18diskUsageForOriginEPNS_14SecurityOriginE


Modified: trunk/Source/WebCore/dom/ContainerNode.h (116676 => 116677)

--- trunk/Source/WebCore/dom/ContainerNode.h	2012-05-10 19:28:18 UTC (rev 116676)
+++ trunk/Source/WebCore/dom/ContainerNode.h	2012-05-10 19:52:05 UTC (rev 116677)
@@ -229,6 +229,36 @@
 return highest;
 }
 
+inline Node* Node::traverseNextSibling() const
+{
+if (nextSibling())
+return nextSibling();
+return traverseNextAncestorSibling();
+}
+
+inline Node* Node::traverseNextNode() const
+{
+if (firstChild())
+return firstChild();
+return traverseNextSibling();
+}
+
+inline Node* Node::traverseNextSibling(const Node* stayWithin) const
+{
+if (this == stayWithin)
+return 0;
+if (nextSibling())
+return nextSibling();
+return traverseNextAncestorSibling(stayWithin);
+}
+
+inline Node* Node::traverseNextNode(const Node* stayWithin) const
+{
+if (firstChild())
+return firstChild();
+return traverseNextSibling(stayWithin);
+}
+
 typedef VectorRefPtrNode, 11 NodeVector;
 
 inline void getChildNodes(Node* node, NodeVector nodes)


Modified: trunk/Source/WebCore/dom/Node.cpp (116676 => 116677)

--- trunk/Source/WebCore/dom/Node.cpp	2012-05-10 19:28:18 UTC (rev 116676)
+++ trunk/Source/WebCore/dom/Node.cpp	2012-05-10 19:52:05 UTC (rev 116677)
@@ -1088,33 +1088,26 @@
 rareData()-setChildNodeList(0);
 }
 
-Node* Node::traverseNextNode(const Node* stayWithin) const
+Node* Node::traverseNextAncestorSibling() const
 {
-if (firstChild())
-return firstChild();
-if (this == stayWithin)
-return 0;
-if (nextSibling())
-return nextSibling();
-const Node *n = this;
-while (n  !n-nextSibling()  (!stayWithin || n-parentNode() != stayWithin))
-n = n-parentNode();
-if (n)
-return n-nextSibling();
+ASSERT(!nextSibling());
+for (const Node* node = parentNode(); node; node = node-parentNode()) {
+if (node-nextSibling())
+return node-nextSibling();
+}
 return 0;
 }
 
-Node* Node::traverseNextSibling(const Node* stayWithin) const
+Node* Node::traverseNextAncestorSibling(const Node* stayWithin) const
 {
-if (this == stayWithin)
-return 0;
-if (nextSibling())
-return nextSibling();
-const Node *n = this;
-while (n  !n-nextSibling()  (!stayWithin || n-parentNode() 

[webkit-changes] [116678] trunk/LayoutTests

[jchaffraix]

Title: [116678] trunk/LayoutTests








Revision 116678
Author jchaffr...@webkit.org
Date 2012-05-10 12:57:36 -0700 (Thu, 10 May 2012)


Log Message
Unreviewed Qt gardening.

* platform/qt/Skipped:
Skipped the test as it fails only on Qt (double-checked locally on Mac),
the difference is very small and likely minor.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (116677 => 116678)

--- trunk/LayoutTests/ChangeLog	2012-05-10 19:52:05 UTC (rev 116677)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 19:57:36 UTC (rev 116678)
@@ -1,3 +1,11 @@
+2012-05-10  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed Qt gardening.
+
+* platform/qt/Skipped:
+Skipped the test as it fails only on Qt (double-checked locally on Mac),
+the difference is very small and likely minor.
+
 2012-05-10  Varun Jain  varunj...@google.com
 
 [chromium] Trigger context menu for long press gesture


Modified: trunk/LayoutTests/platform/qt/Skipped (116677 => 116678)

--- trunk/LayoutTests/platform/qt/Skipped	2012-05-10 19:52:05 UTC (rev 116677)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-05-10 19:57:36 UTC (rev 116678)
@@ -1943,6 +1943,10 @@
 # https://bugs.webkit.org/show_bug.cgi?id=84013
 fast/repaint/line-flow-with-floats-in-regions.html
 
+# [Qt] fast/block/positioning/offsetLeft-offsetTop-multicolumn.html is failing
+# https://bugs.webkit.org/show_bug.cgi?id=86130
+fast/block/positioning/offsetLeft-offsetTop-multicolumn.html
+
 # = #
 # failing fonts tests
 # = #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116679] trunk

[zandobersek]

Title: [116679] trunk








Revision 116679
Author zandober...@gmail.com
Date 2012-05-10 13:10:22 -0700 (Thu, 10 May 2012)


Log Message
[GTK] ENABLE_IFRAME_SEAMLESS support
https://bugs.webkit.org/show_bug.cgi?id=85843

Reviewed by Eric Seidel.

.:

Add a configuration option for enabling the iframe seamless
attribute support, enabling it by default.

* configure.ac:

Source/WebCore:

Export the ENABLE_IFRAME_SEAMLESS feature define when the feature is
enabled.

No new tests - all the related tests should now be passing.

* GNUmakefile.am:

Tools:

Add the iframe-seamless option to the options list. This makes it
possible to enable the iframe seamless support through build-webkit
script. Enabled by default for all the ports.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove test expectations for the iframe seamless tests. All these
tests should be passing now as the feature is enabled.

* platform/gtk/test_expectations.txt:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.am
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (116678 => 116679)

--- trunk/ChangeLog	2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/ChangeLog	2012-05-10 20:10:22 UTC (rev 116679)
@@ -1,3 +1,15 @@
+2012-05-10  Zan Dobersek  zandober...@gmail.com
+
+[GTK] ENABLE_IFRAME_SEAMLESS support
+https://bugs.webkit.org/show_bug.cgi?id=85843
+
+Reviewed by Eric Seidel.
+
+Add a configuration option for enabling the iframe seamless
+attribute support, enabling it by default.
+
+* configure.ac:
+
 2012-05-09  Stephen Chenney  schen...@chromium.org
 
 SVG Filters allow invalid elements as children


Modified: trunk/LayoutTests/ChangeLog (116678 => 116679)

--- trunk/LayoutTests/ChangeLog	2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 20:10:22 UTC (rev 116679)
@@ -1,3 +1,15 @@
+2012-05-10  Zan Dobersek  zandober...@gmail.com
+
+[GTK] ENABLE_IFRAME_SEAMLESS support
+https://bugs.webkit.org/show_bug.cgi?id=85843
+
+Reviewed by Eric Seidel.
+
+Remove test expectations for the iframe seamless tests. All these
+tests should be passing now as the feature is enabled.
+
+* platform/gtk/test_expectations.txt:
+
 2012-05-10  Julien Chaffraix  jchaffr...@webkit.org
 
 Unreviewed Qt gardening.


Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (116678 => 116679)

--- trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-05-10 20:10:22 UTC (rev 116679)
@@ -299,8 +299,6 @@
 // These tests require subpixel layout to be enabled
 BUGWK60318 : fast/sub-pixel = FAIL
 
-BUGWK85843 : fast/frames/seamless = FAIL
-
 //
 // End of Expected failures
 //


Modified: trunk/Source/WebCore/ChangeLog (116678 => 116679)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 20:10:22 UTC (rev 116679)
@@ -1,3 +1,17 @@
+2012-05-10  Zan Dobersek  zandober...@gmail.com
+
+[GTK] ENABLE_IFRAME_SEAMLESS support
+https://bugs.webkit.org/show_bug.cgi?id=85843
+
+Reviewed by Eric Seidel.
+
+Export the ENABLE_IFRAME_SEAMLESS feature define when the feature is
+enabled.
+
+No new tests - all the related tests should now be passing.
+
+* GNUmakefile.am:
+
 2012-05-10  Antti Koivisto  an...@apple.com
 
 Inline Node::traverseNextNode


Modified: trunk/Source/WebCore/GNUmakefile.am (116678 => 116679)

--- trunk/Source/WebCore/GNUmakefile.am	2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/Source/WebCore/GNUmakefile.am	2012-05-10 20:10:22 UTC (rev 116679)
@@ -656,6 +656,14 @@
 webcore_cppflags += -DENABLE_WEB_TIMING=1
 endif  # END ENABLE_WEB_TIMING
 
+# ---
+# HTML iframe seamless attribute support
+# ---
+if ENABLE_IFRAME_SEAMLESS
+FEATURE_DEFINES += ENABLE_IFRAME_SEAMLESS=1
+webcore_cppflags += -DENABLE_IFRAME_SEAMLESS=1
+endif  # END ENABLE_IFRAME_SEAMLESS
+
 DerivedSources/WebCore/CSSPropertyNames.cpp: DerivedSources/WebCore/CSSPropertyNames.h
 DerivedSources/WebCore/CSSPropertyNames.h: $(WEBCORE_CSS_PROPERTY_NAMES) $(WebCore)/css/makeprop.pl
 	$(AM_V_GEN)


Modified: trunk/Tools/ChangeLog (116678 => 116679)

--- trunk/Tools/ChangeLog	2012-05-10 19:57:36 UTC (rev 116678)
+++ trunk/Tools/ChangeLog	2012-05-10 20:10:22 UTC (rev 116679)
@@ -1,3 +1,16 @@
+2012-05-10  Zan Dobersek  zandober...@gmail.com
+
+[GTK] ENABLE_IFRAME_SEAMLESS support
+https://bugs.webkit.org/show_bug.cgi?id=85843
+
+Reviewed by Eric 

[webkit-changes] [116680] trunk/LayoutTests

[jianli]

Title: [116680] trunk/LayoutTests








Revision 116680
Author jia...@chromium.org
Date 2012-05-10 13:24:14 -0700 (Thu, 10 May 2012)


Log Message
Unreviewed chromium gardening. Updated failed tests.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116679 => 116680)

--- trunk/LayoutTests/ChangeLog	2012-05-10 20:10:22 UTC (rev 116679)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 20:24:14 UTC (rev 116680)
@@ -1,3 +1,9 @@
+2012-05-10  Jian Li  jia...@chromium.org
+
+Unreviewed chromium gardening. Updated failed tests.
+
+* platform/chromium/test_expectations.txt:
+
 2012-05-10  Zan Dobersek  zandober...@gmail.com
 
 [GTK] ENABLE_IFRAME_SEAMLESS support


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (116679 => 116680)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-10 20:10:22 UTC (rev 116679)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-10 20:24:14 UTC (rev 116680)
@@ -3867,7 +3867,6 @@
 BUGWK83954 : fast/table/overflowHidden.html = TEXT
 BUGWK83954 : fast/table/spanOverlapRepaint.html = TEXT
 BUGWK83954 : fast/table/text-field-baseline.html = TEXT
-BUGWK83954 : tables/mozilla/bugs/bug1188.html = IMAGE TEXT
 BUGWK83954 WIN LINUX : fast/block/float/avoiding-float-centered.html = TEXT
 BUGWK83954 WIN LINUX : fast/clip/008.html = TEXT
 BUGWK83954 WIN LINUX : fast/clip/011.html = TEXT
@@ -3924,7 +3923,7 @@
 BUGNOEL : svg/repaint/image-href-change.svg = IMAGE
 BUGNOEL : tables/mozilla/bugs/bug101674.html = IMAGE
 BUGNOEL : tables/mozilla/bugs/bug10565.html = IMAGE
-BUGNOEL : tables/mozilla/bugs/bug1188.html = IMAGE
+BUGNOEL : tables/mozilla/bugs/bug1188.html = IMAGE+TEXT
 BUGNOEL : tables/mozilla/bugs/bug11026.html = IMAGE
 BUGNOEL : tables/mozilla/bugs/bug120107.html = IMAGE
 BUGNOEL : tables/mozilla/bugs/bug1271.html = IMAGE
@@ -4054,7 +4053,7 @@
 
 BUGWK81416 : fast/dom/wrapper-scope.html = TEXT
 
-BUGWK85308 : ietestcenter/css3/valuesandunits/units-000.htm = IMAGE
+BUGWK85308 : ietestcenter/css3/valuesandunits/units-000.htm = CRASH
 BUGWK85310 : ietestcenter/css3/valuesandunits/units-010.htm = IMAGE
 
 BUGWK86114 MAC DEBUG : animations/combo-transform-translate+scale.html = PASS TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116681] trunk/Source/WebCore

[yurys]

Title: [116681] trunk/Source/WebCore








Revision 116681
Author yu...@chromium.org
Date 2012-05-10 13:24:20 -0700 (Thu, 10 May 2012)


Log Message
Web Inspector: heap snapshot comparison view is broken
https://bugs.webkit.org/show_bug.cgi?id=86102

Reviewed by Pavel Feldman.

Pass HeapSnapshotProxy instead of undefined to the profile load callback. Added
compiler annotations to avoid such errors in the future.

* inspector/front-end/HeapSnapshotView.js:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (116680 => 116681)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 20:24:14 UTC (rev 116680)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 20:24:20 UTC (rev 116681)
@@ -1,3 +1,15 @@
+2012-05-10  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: heap snapshot comparison view is broken
+https://bugs.webkit.org/show_bug.cgi?id=86102
+
+Reviewed by Pavel Feldman.
+
+Pass HeapSnapshotProxy instead of undefined to the profile load callback. Added
+compiler annotations to avoid such errors in the future.
+
+* inspector/front-end/HeapSnapshotView.js:
+
 2012-05-10  Zan Dobersek  zandober...@gmail.com
 
 [GTK] ENABLE_IFRAME_SEAMLESS support


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js (116680 => 116681)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js	2012-05-10 20:24:14 UTC (rev 116680)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js	2012-05-10 20:24:20 UTC (rev 116681)
@@ -790,12 +790,12 @@
 WebInspector.HeapProfileHeader.prototype = {
 /**
  * @override
- * @param {Function} callback
+ * @param {function(WebInspector.HeapSnapshotProxy):void} callback
  */
 load: function(callback)
 {
 if (this._loaded) {
-callback.call(null);
+callback(this._proxy);
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116682] trunk/Source/WebCore

[kling]

Title: [116682] trunk/Source/WebCore








Revision 116682
Author kl...@webkit.org
Date 2012-05-10 13:43:08 -0700 (Thu, 10 May 2012)


Log Message
Remove empty ElementAttributeData destructor.
http://webkit.org/b/86126

Reviewed by Antti Koivisto.

* dom/ElementAttributeData.cpp:
* dom/ElementAttributeData.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ElementAttributeData.cpp
trunk/Source/WebCore/dom/ElementAttributeData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116681 => 116682)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 20:24:20 UTC (rev 116681)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 20:43:08 UTC (rev 116682)
@@ -1,3 +1,13 @@
+2012-05-10  Andreas Kling  kl...@webkit.org
+
+Remove empty ElementAttributeData destructor.
+http://webkit.org/b/86126
+
+Reviewed by Antti Koivisto.
+
+* dom/ElementAttributeData.cpp:
+* dom/ElementAttributeData.h:
+
 2012-05-10  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: heap snapshot comparison view is broken


Modified: trunk/Source/WebCore/dom/ElementAttributeData.cpp (116681 => 116682)

--- trunk/Source/WebCore/dom/ElementAttributeData.cpp	2012-05-10 20:24:20 UTC (rev 116681)
+++ trunk/Source/WebCore/dom/ElementAttributeData.cpp	2012-05-10 20:43:08 UTC (rev 116682)
@@ -127,10 +127,6 @@
 ASSERT_NOT_REACHED();
 }
 
-ElementAttributeData::~ElementAttributeData()
-{
-}
-
 void ElementAttributeData::setClass(const String className, bool shouldFoldCase)
 {
 m_classNames.set(className, shouldFoldCase);


Modified: trunk/Source/WebCore/dom/ElementAttributeData.h (116681 => 116682)

--- trunk/Source/WebCore/dom/ElementAttributeData.h	2012-05-10 20:24:20 UTC (rev 116681)
+++ trunk/Source/WebCore/dom/ElementAttributeData.h	2012-05-10 20:43:08 UTC (rev 116682)
@@ -55,8 +55,6 @@
 return adoptPtr(new ElementAttributeData);
 }
 
-~ElementAttributeData();
-
 void clearClass() { m_classNames.clear(); }
 void setClass(const String className, bool shouldFoldCase);
 const SpaceSplitString classNames() const { return m_classNames; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116683] trunk

[inferno]

Title: [116683] trunk








Revision 116683
Author infe...@chromium.org
Date 2012-05-10 13:50:43 -0700 (Thu, 10 May 2012)


Log Message
Crash due to floats not removed from first-letter element.
https://bugs.webkit.org/show_bug.cgi?id=86019

Reviewed by Julien Chaffraix.

Source/WebCore:

Move clearing logic of a floating/positioned object from removeChild
to removeChildNode. There are lot of places which use removeChildNode
directly and hence the object is not removed from the floating or
positioned objects list.

Test: fast/block/float/float-not-removed-from-first-letter.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::removeChild):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):

LayoutTests:

* fast/block/float/float-not-removed-from-first-letter-expected.txt: Added.
* fast/block/float/float-not-removed-from-first-letter.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObjectChildList.cpp


Added Paths

trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter-expected.txt
trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter.html




Diff

Modified: trunk/LayoutTests/ChangeLog (116682 => 116683)

--- trunk/LayoutTests/ChangeLog	2012-05-10 20:43:08 UTC (rev 116682)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 20:50:43 UTC (rev 116683)
@@ -1,3 +1,13 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Crash due to floats not removed from first-letter element.
+https://bugs.webkit.org/show_bug.cgi?id=86019
+
+Reviewed by Julien Chaffraix.
+
+* fast/block/float/float-not-removed-from-first-letter-expected.txt: Added.
+* fast/block/float/float-not-removed-from-first-letter.html: Added.
+
 2012-05-10  Jian Li  jia...@chromium.org
 
 Unreviewed chromium gardening. Updated failed tests.


Added: trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter-expected.txt (0 => 116683)

--- trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter-expected.txt	2012-05-10 20:50:43 UTC (rev 116683)
@@ -0,0 +1,3 @@
+Webkit Bug 86019 - Crash due to floats not removed from first-letter element.
+
+PASS. WebKit didn't crash.


Added: trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter.html (0 => 116683)

--- trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter.html	(rev 0)
+++ trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter.html	2012-05-10 20:50:43 UTC (rev 116683)
@@ -0,0 +1,27 @@
+!DOCTYPE html
+html
+Webkit Bug 86019 - Crash due to floats not removed from first-letter element.
+style
+.li2 { width: 0px; }
+.li2:first-letter { float: left; content: counter(section); }
+.li2:first-of-type { display: -webkit-inline-flexbox; }
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function crash() {
+li1 = document.createElement('li');
+document.documentElement.appendChild(li1);
+keygen1 = document.createElement('keygen');
+keygen1.setAttribute('autofocus', 'autofocus');
+document.documentElement.appendChild(keygen1);
+li2 = document.createElement('li');
+li2.setAttribute('class', 'li2');
+document.documentElement.appendChild(li2);
+text1 = document.createTextNode(PASS. WebKit didn't crash.);
+li2.appendChild(text1);
+}
+window._onload_ = crash;
+/script
+/html
Property changes on: trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter.html
___


Added: svn:executable

Modified: trunk/Source/WebCore/ChangeLog (116682 => 116683)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 20:43:08 UTC (rev 116682)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 20:50:43 UTC (rev 116683)
@@ -1,3 +1,22 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Crash due to floats not removed from first-letter element.
+https://bugs.webkit.org/show_bug.cgi?id=86019
+
+Reviewed by Julien Chaffraix.
+
+Move clearing logic of a floating/positioned object from removeChild
+to removeChildNode. There are lot of places which use removeChildNode
+directly and hence the object is not removed from the floating or
+positioned objects list.
+
+Test: fast/block/float/float-not-removed-from-first-letter.html
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::removeChild):
+* rendering/RenderObjectChildList.cpp:
+(WebCore::RenderObjectChildList::removeChildNode):
+
 2012-05-10  Andreas Kling  kl...@webkit.org
 
 Remove empty ElementAttributeData destructor.


Modified: 

[webkit-changes] [116684] trunk/Source/WebKit/blackberry

[mifenton]

Title: [116684] trunk/Source/WebKit/blackberry








Revision 116684
Author mifen...@rim.com
Date 2012-05-10 14:01:07 -0700 (Thu, 10 May 2012)


Log Message
Caret node boundary should be adjusted to account for the visible region.
https://bugs.webkit.org/show_bug.cgi?id=86116

Reviewed by Antonio Gomes.

PR 138988.

Update the node bounding box to be clipped and adjusted
for the visible region of the frame.

Reviewed Internally by Gen Mak.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (116683 => 116684)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-05-10 20:50:43 UTC (rev 116683)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-05-10 21:01:07 UTC (rev 116684)
@@ -1,3 +1,20 @@
+2012-05-10  Mike Fenton  mifen...@rim.com
+
+Caret node boundary should be adjusted to account for the visible region.
+https://bugs.webkit.org/show_bug.cgi?id=86116
+
+Reviewed by Antonio Gomes.
+
+PR 138988.
+
+Update the node bounding box to be clipped and adjusted
+for the visible region of the frame.
+
+Reviewed Internally by Gen Mak.
+
+* WebKitSupport/SelectionHandler.cpp:
+(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
+
 2012-05-10  Antonio Gomes  ago...@rim.com
 
 [BlackBerry] Assertions and assumptions in BackingStoreClient around m_frame and m_frame-view() are invalid


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (116683 => 116684)

--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2012-05-10 20:50:43 UTC (rev 116683)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp	2012-05-10 21:01:07 UTC (rev 116684)
@@ -955,14 +955,14 @@
 // This function should only reach this point if input mode is active.
 ASSERT(m_webPage-m_inputHandler-isInputMode());
 
+WebCore::IntPoint frameOffset(m_webPage-frameOffset(m_webPage-focusedOrMainFrame()));
+WebCore::IntRect clippingRectForContent(clippingRectForVisibleContent());
 if (m_webPage-focusedOrMainFrame()-selection()-selectionType() == VisibleSelection::CaretSelection) {
-WebCore::IntPoint frameOffset = m_webPage-frameOffset(m_webPage-focusedOrMainFrame());
-
 caretLocation = m_webPage-focusedOrMainFrame()-selection()-selection().visibleStart().absoluteCaretBounds();
 caretLocation.move(frameOffset.x(), frameOffset.y());
 
 // Clip against the containing frame and node boundaries.
-caretLocation.intersect(clippingRectForVisibleContent());
+caretLocation.intersect(clippingRectForContent);
 }
 
 m_caretActive = !caretLocation.isEmpty();
@@ -976,6 +976,19 @@
 bool singleLineInput = !m_webPage-m_inputHandler-isMultilineInputMode();
 WebCore::IntRect nodeBoundingBox = singleLineInput ? m_webPage-m_inputHandler-boundingBoxForInputField() : WebCore::IntRect();
 
+if (!nodeBoundingBox.isEmpty()) {
+nodeBoundingBox.move(frameOffset.x(), frameOffset.y());
+
+// Clip against the containing frame and node boundaries.
+nodeBoundingBox.intersect(clippingRectForContent);
+
+nodeBoundingBox = m_webPage-mapToTransformed(nodeBoundingBox);
+m_webPage-clipToTransformedContentsRect(nodeBoundingBox);
+}
+
+DEBUG_SELECTION(LogLevelInfo, SelectionHandler::single line %s single line bounding box %d, %d, %dx%d,
+singleLineInput ? true : false, nodeBoundingBox.x(), nodeBoundingBox.y(), nodeBoundingBox.width(), nodeBoundingBox.height());
+
 m_webPage-m_client-notifyCaretChanged(caretLocation, m_webPage-m_touchEventHandler-lastFatFingersResult().isTextInput() /* userTouchTriggered */, singleLineInput, nodeBoundingBox);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116685] trunk

[beidson]

Title: [116685] trunk








Revision 116685
Author beid...@apple.com
Date 2012-05-10 14:09:31 -0700 (Thu, 10 May 2012)


Log Message
rdar://problem/10972577 and https://bugs.webkit.org/show_bug.cgi?id=80170
Contents of noscript elements turned into strings in WebArchives

Source/WebCore:

Reviewed by Andy Estes.

There's a much deeper question about how innerHTML of noscript is expected to work in
both a scripting and non-scripting environment that we should pursue separately.

But for webarchives, we can solve this by filtering out the noscript elements completely
if scripting is enabled.

Test: webarchive/ignore-noscript-if-scripting-enabled.html

* WebCore.exp.in:

Add arguments to createMarkup and MarkupAccumulator methods to pass a Vector of QualifiedNames
that should be filtered from the resulting markup:
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodes):
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):
* editing/MarkupAccumulator.h:
* editing/markup.cpp:
(WebCore::createMarkup):
* editing/markup.h:

If scripting is enabled, add the noscriptTag to the tag names to filter:
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):

LayoutTests:

Reviewed by Andy Estes.

* webarchive/ignore-noscript-if-scripting-enabled-expected.txt: Added.
* webarchive/ignore-noscript-if-scripting-enabled.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/editing/MarkupAccumulator.cpp
trunk/Source/WebCore/editing/MarkupAccumulator.h
trunk/Source/WebCore/editing/markup.cpp
trunk/Source/WebCore/editing/markup.h
trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp


Added Paths

trunk/LayoutTests/webarchive/ignore-noscript-if-scripting-enabled-expected.txt
trunk/LayoutTests/webarchive/ignore-noscript-if-scripting-enabled.html




Diff

Modified: trunk/LayoutTests/ChangeLog (116684 => 116685)

--- trunk/LayoutTests/ChangeLog	2012-05-10 21:01:07 UTC (rev 116684)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 21:09:31 UTC (rev 116685)
@@ -1,3 +1,13 @@
+2012-05-10  Brady Eidson  beid...@apple.com
+
+rdar://problem/10972577 and https://bugs.webkit.org/show_bug.cgi?id=80170
+Contents of noscript elements turned into strings in WebArchives
+
+Reviewed by Andy Estes.
+
+* webarchive/ignore-noscript-if-scripting-enabled-expected.txt: Added.
+* webarchive/ignore-noscript-if-scripting-enabled.html: Added.
+
 2012-05-10  Abhishek Arya  infe...@chromium.org
 
 Crash due to floats not removed from first-letter element.


Added: trunk/LayoutTests/webarchive/ignore-noscript-if-scripting-enabled-expected.txt (0 => 116685)

--- trunk/LayoutTests/webarchive/ignore-noscript-if-scripting-enabled-expected.txt	(rev 0)
+++ trunk/LayoutTests/webarchive/ignore-noscript-if-scripting-enabled-expected.txt	2012-05-10 21:09:31 UTC (rev 116685)
@@ -0,0 +1,30 @@
+?xml version=1.0 encoding=UTF-8?
+!DOCTYPE plist PUBLIC -//Apple//DTD PLIST 1.0//EN http://www.apple.com/DTDs/PropertyList-1.0.dtd
+plist version=1.0
+dict
+	keyWebMainResource/key
+	dict
+		keyWebResourceData/key
+		stringlt;htmlgt;lt;headgt;
+lt;scriptgt;
+if (window.layoutTestController)
+layoutTestController.dumpDOMAsWebArchive();
+lt;/scriptgt;
+lt;/headgt;
+lt;bodygt;
+This should appear in the webarchive.
+
+
+
+lt;/bodygt;lt;/htmlgt;/string
+		keyWebResourceFrameName/key
+		string/string
+		keyWebResourceMIMEType/key
+		stringtext/html/string
+		keyWebResourceTextEncodingName/key
+		stringUTF-8/string
+		keyWebResourceURL/key
+		stringfile:///LayoutTests/webarchive/ignore-noscript-if-scripting-enabled.html/string
+	/dict
+/dict
+/plist


Added: trunk/LayoutTests/webarchive/ignore-noscript-if-scripting-enabled.html (0 => 116685)

--- trunk/LayoutTests/webarchive/ignore-noscript-if-scripting-enabled.html	(rev 0)
+++ trunk/LayoutTests/webarchive/ignore-noscript-if-scripting-enabled.html	2012-05-10 21:09:31 UTC (rev 116685)
@@ -0,0 +1,14 @@
+html
+head
+script
+if (window.layoutTestController)
+layoutTestController.dumpDOMAsWebArchive();
+/script
+/head
+body
+This should appear in the webarchive.
+noscript
+Assuming scripting was enabled earlier, this should *not* appear in the webarchive.
+/noscript
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (116684 => 116685)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 21:01:07 UTC (rev 116684)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 21:09:31 UTC (rev 116685)
@@ -1,3 +1,34 @@
+2012-05-10  Brady Eidson  beid...@apple.com
+
+rdar://problem/10972577 and https://bugs.webkit.org/show_bug.cgi?id=80170
+Contents of noscript elements turned into strings in WebArchives
+
+Reviewed by Andy Estes.
+
+There's a much deeper question about how innerHTML of noscript is expected to work in 
+both a scripting and non-scripting 

[webkit-changes] [116686] trunk/Source/WebKit/chromium

[tsepez]

Title: [116686] trunk/Source/WebKit/chromium








Revision 116686
Author tse...@chromium.org
Date 2012-05-10 14:14:12 -0700 (Thu, 10 May 2012)


Log Message
[Chromium] WebFrameTest.ChromePageNoJavascript isn't catching regressions
https://bugs.webkit.org/show_bug.cgi?id=86046

Reviewed by Adam Barth.

Test both cases for registerURLSchemeAsNotAllowingJavascriptURLs.  Also add
a call to layout() to ensure the _javascript_ result is seen.

* tests/WebFrameTest.cpp:
(WebKit::TEST_F):
(WebKit):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (116685 => 116686)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-05-10 21:09:31 UTC (rev 116685)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-05-10 21:14:12 UTC (rev 116686)
@@ -1,3 +1,17 @@
+2012-05-10  Tom Sepez  tse...@chromium.org
+
+[Chromium] WebFrameTest.ChromePageNoJavascript isn't catching regressions
+https://bugs.webkit.org/show_bug.cgi?id=86046
+
+Reviewed by Adam Barth.
+
+Test both cases for registerURLSchemeAsNotAllowingJavascriptURLs.  Also add
+a call to layout() to ensure the _javascript_ result is seen.
+
+* tests/WebFrameTest.cpp:
+(WebKit::TEST_F):
+(WebKit):
+
 2012-05-10  Varun Jain  varunj...@google.com
 
 [chromium] Trigger context menu for long press gesture


Modified: trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp (116685 => 116686)

--- trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp	2012-05-10 21:09:31 UTC (rev 116685)
+++ trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp	2012-05-10 21:14:12 UTC (rev 116686)
@@ -137,19 +137,40 @@
 WebSearchableFormData searchableDataForm(forms[0]);
 }
 
+TEST_F(WebFrameTest, ChromePageJavascript)
+{
+registerMockedChromeURLLoad(history.html);
+ 
+// Pass true to enable _javascript_.
+WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_chromeURL + history.html, true);
+
+// Try to run JS against the chrome-style URL.
+FrameTestHelpers::loadFrame(webView-mainFrame(), _javascript_:document.body.appendChild(document.createTextNode('Clobbered')));
+
+// Required to see any updates in contentAsText.
+webView-layout();
+
+// Now retrieve the frame's text and ensure it was modified by running _javascript_.
+std::string content = webView-mainFrame()-contentAsText(1024).utf8();
+EXPECT_NE(std::string::npos, content.find(Clobbered));
+}
+
 TEST_F(WebFrameTest, ChromePageNoJavascript)
 {
 registerMockedChromeURLLoad(history.html);
 
+/// Pass true to enable _javascript_.
 WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_chromeURL + history.html, true);
 
-// Try to run JS against the chrome-style URL.
+// Try to run JS against the chrome-style URL after prohibiting it.
 WebSecurityPolicy::registerURLSchemeAsNotAllowingJavascriptURLs(chrome);
 FrameTestHelpers::loadFrame(webView-mainFrame(), _javascript_:document.body.appendChild(document.createTextNode('Clobbered')));
 
-// Now retrieve the frames text and see if it was clobbered.
+// Required to see any updates in contentAsText.
+webView-layout();
+
+// Now retrieve the frame's text and ensure it wasn't modified by running _javascript_.
 std::string content = webView-mainFrame()-contentAsText(1024).utf8();
-EXPECT_NE(std::string::npos, content.find(Simulated Chromium History Page));
 EXPECT_EQ(std::string::npos, content.find(Clobbered));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116687] trunk/Source

[andersca]

Title: [116687] trunk/Source








Revision 116687
Author ander...@apple.com
Date 2012-05-10 14:21:00 -0700 (Thu, 10 May 2012)


Log Message
Rename the missing plug-in indicator to the unavailable plug-in indicator
https://bugs.webkit.org/show_bug.cgi?id=86136

Reviewed by Sam Weinig.

Source/WebCore:

Since the indicator is shown for more than just missing plug-ins, generalize it and use a plug-in unavailability
reason enum to make it easier to extend. Also, pass the unavailability reason to the ChromeClient member functions.

* WebCore.exp.in:
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):
* page/ChromeClient.h:
(WebCore::ChromeClient::shouldUnavailablePluginMessageBeButton):
(WebCore::ChromeClient::unavailablePluginButtonClicked):
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::showsUnavailablePluginIndicator):
(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsPressed):
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::paintReplaced):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
(WebCore::RenderEmbeddedObject::unavailablePluginReplacementText):
(WebCore):
(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
(WebCore::shouldUnavailablePluginMessageBeButton):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
(WebCore::RenderEmbeddedObject::getCursor):
* rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject):

Source/WebKit/mac:

* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView pluginHostDied]):
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

Source/WebKit2:

Update for WebCore changes.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginProcessCrashed):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/html/HTMLEmbedElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp
trunk/Source/WebCore/html/HTMLPlugInElement.cpp
trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp
trunk/Source/WebCore/loader/SubframeLoader.cpp
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp
trunk/Source/WebCore/rendering/RenderEmbeddedObject.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116686 => 116687)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 21:14:12 UTC (rev 116686)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 21:21:00 UTC (rev 116687)
@@ -1,3 +1,46 @@
+2012-05-10  Anders Carlsson  ander...@apple.com
+
+Rename the missing plug-in indicator to the unavailable plug-in indicator
+https://bugs.webkit.org/show_bug.cgi?id=86136
+
+Reviewed by Sam Weinig.
+
+Since the indicator is shown for more than just missing plug-ins, generalize it and use a plug-in unavailability
+reason enum to make it easier to extend. Also, pass the unavailability reason to the ChromeClient member functions.
+
+* WebCore.exp.in:
+* html/HTMLEmbedElement.cpp:
+(WebCore::HTMLEmbedElement::updateWidget):
+* html/HTMLObjectElement.cpp:
+(WebCore::HTMLObjectElement::updateWidget):
+* html/HTMLPlugInElement.cpp:
+(WebCore::HTMLPlugInElement::defaultEventHandler):
+* 

[webkit-changes] [116688] trunk/Source/WebCore

[abarth]

Title: [116688] trunk/Source/WebCore








Revision 116688
Author aba...@webkit.org
Date 2012-05-10 14:37:46 -0700 (Thu, 10 May 2012)


Log Message
ScrollView::fixedVisibleContentRect should be public
https://bugs.webkit.org/show_bug.cgi?id=86147

Reviewed by Eric Seidel.

Some code in the WebKit layer of OS(ANDROID) uses this function. That
could will be upstreamed in a later patch. For now, this patch just
makes this function public so that we remove the diff to this file.

* platform/ScrollView.h:
(WebCore::ScrollView::fixedVisibleContentRect):
(WebCore::ScrollView::delegatesScrollingDidChange):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116687 => 116688)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 21:21:00 UTC (rev 116687)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 21:37:46 UTC (rev 116688)
@@ -1,3 +1,18 @@
+2012-05-10  Adam Barth  aba...@webkit.org
+
+ScrollView::fixedVisibleContentRect should be public
+https://bugs.webkit.org/show_bug.cgi?id=86147
+
+Reviewed by Eric Seidel.
+
+Some code in the WebKit layer of OS(ANDROID) uses this function. That
+could will be upstreamed in a later patch. For now, this patch just
+makes this function public so that we remove the diff to this file.
+
+* platform/ScrollView.h:
+(WebCore::ScrollView::fixedVisibleContentRect):
+(WebCore::ScrollView::delegatesScrollingDidChange):
+
 2012-05-10  Anders Carlsson  ander...@apple.com
 
 Rename the missing plug-in indicator to the unavailable plug-in indicator


Modified: trunk/Source/WebCore/platform/ScrollView.h (116687 => 116688)

--- trunk/Source/WebCore/platform/ScrollView.h	2012-05-10 21:21:00 UTC (rev 116687)
+++ trunk/Source/WebCore/platform/ScrollView.h	2012-05-10 21:37:46 UTC (rev 116688)
@@ -145,6 +145,7 @@
 // which usually will happen when panning, pinching and rotation ends, or when scale or position are changed manually.
 virtual IntRect visibleContentRect(bool includeScrollbars = false) const;
 virtual void setFixedVisibleContentRect(const IntRect visibleContentRect) { m_fixedVisibleContentRect = visibleContentRect; }
+IntRect fixedVisibleContentRect() const { return m_fixedVisibleContentRect; }
 int visibleWidth() const { return visibleContentRect().width(); }
 int visibleHeight() const { return visibleContentRect().height(); }
 
@@ -294,9 +295,6 @@
 
 virtual void visibleContentsResized() = 0;
 virtual void delegatesScrollingDidChange() { }
-
-IntRect fixedVisibleContentRect() const { return m_fixedVisibleContentRect; }
-
 // These functions are used to create/destroy scrollbars.
 void setHasHorizontalScrollbar(bool);
 void setHasVerticalScrollbar(bool);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116689] trunk/Source

[pilgrim]

Title: [116689] trunk/Source








Revision 116689
Author pilg...@chromium.org
Date 2012-05-10 14:44:03 -0700 (Thu, 10 May 2012)


Log Message
[Chromium] Remove WEBKIT_USING_SKIA ifdefs that are always true
https://bugs.webkit.org/show_bug.cgi?id=86121

Reviewed by Adam Barth.

Chromium always uses Skia now, so this just removes the barriers
around code that was previously #if'd.

Source/Platform:

* chromium/public/WebCanvas.h:
(WebKit):
* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):
* chromium/public/WebImage.h:
(WebImage):

Source/WebKit/chromium:

* README:
* src/DragClientImpl.cpp:
(WebKit::DragClientImpl::startDrag):
* src/PageOverlay.cpp:
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardWriteImage):
(WebCore::PlatformSupport::paintScrollbarThumb):
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::paintContents):
* src/WebFontImpl.cpp:
(WebKit::WebFontImpl::drawText):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::printPage):
(WebKit::WebFrameImpl::printPagesWithBoundaries):
* src/WebGraphicsContext3D.cpp:
(WebKit::WebGraphicsContext3D::createGrGLInterface):
* src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::getFrameAtIndex):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::paint):
(WebKit::WebPluginContainerImpl::printPage):
* src/painting/GraphicsContextBuilder.h:
(WebKit):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebCanvas.h
trunk/Source/Platform/chromium/public/WebGraphicsContext3D.h
trunk/Source/Platform/chromium/public/WebImage.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/README
trunk/Source/WebKit/chromium/src/DragClientImpl.cpp
trunk/Source/WebKit/chromium/src/PageOverlay.cpp
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebFontImpl.cpp
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
trunk/Source/WebKit/chromium/src/WebGraphicsContext3D.cpp
trunk/Source/WebKit/chromium/src/WebImageDecoder.cpp
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Source/WebKit/chromium/src/painting/GraphicsContextBuilder.h




Diff

Modified: trunk/Source/Platform/ChangeLog (116688 => 116689)

--- trunk/Source/Platform/ChangeLog	2012-05-10 21:37:46 UTC (rev 116688)
+++ trunk/Source/Platform/ChangeLog	2012-05-10 21:44:03 UTC (rev 116689)
@@ -1,5 +1,23 @@
 2012-05-10  Mark Pilgrim  pilg...@chromium.org
 
+[Chromium] Remove WEBKIT_USING_SKIA ifdefs that are always true
+https://bugs.webkit.org/show_bug.cgi?id=86121
+
+Reviewed by Adam Barth.
+
+Chromium always uses Skia now, so this just removes the barriers
+around code that was previously #if'd.
+
+* chromium/public/WebCanvas.h:
+(WebKit):
+* chromium/public/WebGraphicsContext3D.h:
+(WebGraphicsContext3D):
+(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):
+* chromium/public/WebImage.h:
+(WebImage):
+
+2012-05-10  Mark Pilgrim  pilg...@chromium.org
+
 [Chromium] Remove dead code behind unused WEBKIT_USING_CG
 https://bugs.webkit.org/show_bug.cgi?id=86018
 


Modified: trunk/Source/Platform/chromium/public/WebCanvas.h (116688 => 116689)

--- trunk/Source/Platform/chromium/public/WebCanvas.h	2012-05-10 21:37:46 UTC (rev 116688)
+++ trunk/Source/Platform/chromium/public/WebCanvas.h	2012-05-10 21:44:03 UTC (rev 116689)
@@ -33,17 +33,11 @@
 
 #include WebCommon.h
 
-#if WEBKIT_USING_SKIA
 class SkCanvas;
-#endif
 
 namespace WebKit {
 
-#if WEBKIT_USING_SKIA
 typedef SkCanvas WebCanvas;
-#else
-#error Need to define WebCanvas
-#endif
 
 } // namespace WebKit
 


Modified: trunk/Source/Platform/chromium/public/WebGraphicsContext3D.h (116688 => 116689)

--- trunk/Source/Platform/chromium/public/WebGraphicsContext3D.h	2012-05-10 21:37:46 UTC (rev 116688)
+++ trunk/Source/Platform/chromium/public/WebGraphicsContext3D.h	2012-05-10 21:44:03 UTC (rev 116689)
@@ -38,9 +38,7 @@
 
 #define USE_WGC3D_TYPES
 
-#if WEBKIT_USING_SKIA
 struct GrGLInterface;
-#endif
 
 namespace WebKit {
 
@@ -413,14 +411,10 @@
 virtual void getQueryivEXT(WGC3Denum target, WGC3Denum pname, WGC3Dint* params) { }
 virtual void getQueryObjectuivEXT(WebGLId query, WGC3Denum pname, WGC3Duint* params) { }
 
-#if WEBKIT_USING_SKIA
 GrGLInterface* createGrGLInterface();
-#endif
 
 protected:
-#if WEBKIT_USING_SKIA
 virtual GrGLInterface* onCreateGrGLInterface() { return 0; }
-#endif
 
 };
 


Modified: trunk/Source/Platform/chromium/public/WebImage.h (116688 => 116689)

--- trunk/Source/Platform/chromium/public/WebImage.h	2012-05-10 21:37:46 UTC (rev 116688)
+++ trunk/Source/Platform/chromium/public/WebImage.h	2012-05-10 21:44:03 UTC (rev 116689)
@@ -33,9 +33,7 @@
 
 #include WebCommon.h
 
-#if WEBKIT_USING_SKIA
 #include SkBitmap.h
-#endif
 
 #if WEBKIT_IMPLEMENTATION
 

[webkit-changes] [116690] trunk/Source

[pilgrim]

Title: [116690] trunk/Source








Revision 116690
Author pilg...@chromium.org
Date 2012-05-10 14:52:01 -0700 (Thu, 10 May 2012)


Log Message
[Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag directly
https://bugs.webkit.org/show_bug.cgi?id=85399

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/EventTracer.cpp: Added.
(WebCore):
(WebCore::EventTracer::getTraceCategoryEnabledFlag):
(WebCore::EventTracer::addTraceEvent):
* platform/EventTracer.h: Added.
(WebCore):
(EventTracer):
* platform/chromium/EventTracerChromium.cpp: Added.
(WebCore):
(WebCore::EventTracer::getTraceCategoryEnabledFlag):
(WebCore::EventTracer::addTraceEvent):
* platform/chromium/PlatformSupport.h:
* platform/chromium/TraceEvent.h:

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/chromium/TraceEvent.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp


Added Paths

trunk/Source/WebCore/platform/EventTracer.cpp
trunk/Source/WebCore/platform/EventTracer.h
trunk/Source/WebCore/platform/chromium/EventTracerChromium.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (116689 => 116690)

--- trunk/Source/WebCore/CMakeLists.txt	2012-05-10 21:44:03 UTC (rev 116689)
+++ trunk/Source/WebCore/CMakeLists.txt	2012-05-10 21:52:01 UTC (rev 116690)
@@ -1104,6 +1104,7 @@
 platform/DateComponents.cpp
 platform/DragData.cpp
 platform/DragImage.cpp
+platform/EventTracer.cpp
 platform/FileChooser.cpp
 platform/FileIconLoader.cpp
 platform/FileSystem.cpp


Modified: trunk/Source/WebCore/ChangeLog (116689 => 116690)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 21:44:03 UTC (rev 116689)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 21:52:01 UTC (rev 116690)
@@ -1,3 +1,32 @@
+2012-05-10  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag directly
+https://bugs.webkit.org/show_bug.cgi?id=85399
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* Target.pri:
+* WebCore.gypi:
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/EventTracer.cpp: Added.
+(WebCore):
+(WebCore::EventTracer::getTraceCategoryEnabledFlag):
+(WebCore::EventTracer::addTraceEvent):
+* platform/EventTracer.h: Added.
+(WebCore):
+(EventTracer):
+* platform/chromium/EventTracerChromium.cpp: Added.
+(WebCore):
+(WebCore::EventTracer::getTraceCategoryEnabledFlag):
+(WebCore::EventTracer::addTraceEvent):
+* platform/chromium/PlatformSupport.h:
+* platform/chromium/TraceEvent.h:
+
 2012-05-10  Adam Barth  aba...@webkit.org
 
 ScrollView::fixedVisibleContentRect should be public


Modified: trunk/Source/WebCore/GNUmakefile.list.am (116689 => 116690)

--- trunk/Source/WebCore/GNUmakefile.list.am	2012-05-10 21:44:03 UTC (rev 116689)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2012-05-10 21:52:01 UTC (rev 116690)
@@ -3096,6 +3096,8 @@
 	Source/WebCore/platform/DragImage.cpp \
 	Source/WebCore/platform/DragImage.h \
 	Source/WebCore/platform/EventLoop.h \
+	Source/WebCore/platform/EventTracer.cpp \
+	Source/WebCore/platform/EventTracer.h \
 	Source/WebCore/platform/FileChooser.cpp \
 	Source/WebCore/platform/FileChooser.h \
 	Source/WebCore/platform/FileIconLoader.cpp \


Modified: trunk/Source/WebCore/Target.pri (116689 => 116690)

--- trunk/Source/WebCore/Target.pri	2012-05-10 21:44:03 UTC (rev 116689)
+++ trunk/Source/WebCore/Target.pri	2012-05-10 21:52:01 UTC (rev 116690)
@@ -1081,6 +1081,7 @@
 platform/DateComponents.cpp \
 platform/DragData.cpp \
 platform/DragImage.cpp \
+platform/EventTracer.cpp \
 platform/FileChooser.cpp \
 platform/FileIconLoader.cpp \
 platform/FileStream.cpp \
@@ -2188,6 +2189,7 @@
 platform/DateComponents.h \
 platform/DragData.h \
 platform/DragImage.h \
+platform/EventTracer.h \
 platform/FileChooser.h \
 platform/FileStream.h \
 platform/FileStreamClient.h \


Modified: trunk/Source/WebCore/WebCore.gypi (116689 => 116690)

--- trunk/Source/WebCore/WebCore.gypi	2012-05-10 21:44:03 UTC (rev 116689)
+++ trunk/Source/WebCore/WebCore.gypi	2012-05-10 21:52:01 UTC (rev 116690)
@@ -273,6 +273,7 

[webkit-changes] [116691] trunk/Source/WebCore

[abarth]

Title: [116691] trunk/Source/WebCore








Revision 116691
Author aba...@webkit.org
Date 2012-05-10 14:53:35 -0700 (Thu, 10 May 2012)


Log Message
ASSERT in BidiResolverIterator, Run::commitExplicitEmbedding makes running debug builds annoying
https://bugs.webkit.org/show_bug.cgi?id=86140

Reviewed by Eric Seidel.

The correct fix here is to resolve
https://bugs.webkit.org/show_bug.cgi?id=76574, but in the mean time,
this ASSERT is annoying.

* platform/text/BidiResolver.h:
(WebCorecommitExplicitEmbedding):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/BidiResolver.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116690 => 116691)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 21:52:01 UTC (rev 116690)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 21:53:35 UTC (rev 116691)
@@ -1,3 +1,17 @@
+2012-05-10  Adam Barth  aba...@webkit.org
+
+ASSERT in BidiResolverIterator, Run::commitExplicitEmbedding makes running debug builds annoying
+https://bugs.webkit.org/show_bug.cgi?id=86140
+
+Reviewed by Eric Seidel.
+
+The correct fix here is to resolve
+https://bugs.webkit.org/show_bug.cgi?id=76574, but in the mean time,
+this ASSERT is annoying.
+
+* platform/text/BidiResolver.h:
+(WebCorecommitExplicitEmbedding):
+
 2012-05-10  Mark Pilgrim  pilg...@chromium.org
 
 [Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag directly


Modified: trunk/Source/WebCore/platform/text/BidiResolver.h (116690 => 116691)

--- trunk/Source/WebCore/platform/text/BidiResolver.h	2012-05-10 21:52:01 UTC (rev 116690)
+++ trunk/Source/WebCore/platform/text/BidiResolver.h	2012-05-10 21:53:35 UTC (rev 116691)
@@ -403,7 +403,8 @@
 bool BidiResolverIterator, Run::commitExplicitEmbedding()
 {
 // This gets called from bidiFirst when setting up our start position.
-ASSERT(!inIsolate() || m_currentExplicitEmbeddingSequence.isEmpty());
+// FIXME: Re-enable this assert once https://bugs.webkit.org/show_bug.cgi?id=76574 is fixed.
+// ASSERT(!inIsolate() || m_currentExplicitEmbeddingSequence.isEmpty());
 
 using namespace WTF::Unicode;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116692] trunk/Tools

[rakuco]

Title: [116692] trunk/Tools








Revision 116692
Author rak...@webkit.org
Date 2012-05-10 15:00:02 -0700 (Thu, 10 May 2012)


Log Message
[webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
https://bugs.webkit.org/show_bug.cgi?id=86145

Reviewed by Dirk Pranke.

The GTK+ and EFL ports use jhbuild to build a few base libraries
which are then used when building the port itself. Programs such
as DRT and ImageDiff are then supposed to be run with the
`run-with-jhbuild' wrapper so that the libraries are properly
found and loaded.

This was already the case for DumpRenderTree (EflPort defines the
'wrapper' option for that), but it was not possible to do the same
with ImageDiff so far.

The code which created the ImageDiff command-line call has been
moved to a separate method, _image_diff_command, which is then
overridden by EflPort to add the jhbuild wrapper.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.__init__):
(EflPort._image_diff_command):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort):
(WebKitPort._image_diff_command):
(WebKitPort._start_image_diff_process):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (116691 => 116692)

--- trunk/Tools/ChangeLog	2012-05-10 21:53:35 UTC (rev 116691)
+++ trunk/Tools/ChangeLog	2012-05-10 22:00:02 UTC (rev 116692)
@@ -1,3 +1,32 @@
+2012-05-10  Raphael Kubo da Costa  rak...@webkit.org
+
+[webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
+https://bugs.webkit.org/show_bug.cgi?id=86145
+
+Reviewed by Dirk Pranke.
+
+The GTK+ and EFL ports use jhbuild to build a few base libraries
+which are then used when building the port itself. Programs such
+as DRT and ImageDiff are then supposed to be run with the
+`run-with-jhbuild' wrapper so that the libraries are properly
+found and loaded.
+
+This was already the case for DumpRenderTree (EflPort defines the
+'wrapper' option for that), but it was not possible to do the same
+with ImageDiff so far.
+
+The code which created the ImageDiff command-line call has been
+moved to a separate method, _image_diff_command, which is then
+overridden by EflPort to add the jhbuild wrapper.
+
+* Scripts/webkitpy/layout_tests/port/efl.py:
+(EflPort.__init__):
+(EflPort._image_diff_command):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitPort):
+(WebKitPort._image_diff_command):
+(WebKitPort._start_image_diff_process):
+
 2012-05-10  Zan Dobersek  zandober...@gmail.com
 
 [GTK] ENABLE_IFRAME_SEAMLESS support


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py (116691 => 116692)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py	2012-05-10 21:53:35 UTC (rev 116691)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py	2012-05-10 22:00:02 UTC (rev 116692)
@@ -42,8 +42,10 @@
 def __init__(self, *args, **kwargs):
 WebKitPort.__init__(self, *args, **kwargs)
 
-self.set_option_default('wrapper', self.path_from_webkit_base('Tools', 'efl', 'run-with-jhbuild'))
+self._jhbuild_wrapper_path = self.path_from_webkit_base('Tools', 'efl', 'run-with-jhbuild')
 
+self.set_option_default('wrapper', self._jhbuild_wrapper_path)
+
 def _port_flag_for_scripts(self):
 return --efl
 
@@ -62,6 +64,9 @@
 def _path_to_image_diff(self):
 return self._build_path('bin', 'ImageDiff')
 
+def _image_diff_command(self, *args, **kwargs):
+return [self._jhbuild_wrapper_path] + super(EflPort, self)._image_diff_command(*args, **kwargs)
+
 def _path_to_webcore_library(self):
 static_path = self._build_path('WebCore', 'libwebcore_efl.a')
 dyn_path = self._build_path('WebCore', 'libwebcore_efl.so')


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (116691 => 116692)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-05-10 21:53:35 UTC (rev 116691)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2012-05-10 22:00:02 UTC (rev 116692)
@@ -170,7 +170,7 @@
 process = self._start_image_diff_process(expected_contents, actual_contents, tolerance=tolerance)
 return self._read_image_diff(process)
 
-def _start_image_diff_process(self, expected_contents, actual_contents, tolerance=None):
+def _image_diff_command(self, tolerance=None):
 # FIXME: There needs to be a more sane way of handling default
 # values for options so that you can distinguish between a default
 # value of None and a default value that wasn't set.
@@ -179,7 +179,12 @@
 tolerance = self.get_option('tolerance')
 else:
 tolerance = 0.1
+
 command = 

[webkit-changes] [116693] trunk

[jchaffraix]

Title: [116693] trunk








Revision 116693
Author jchaffr...@webkit.org
Date 2012-05-10 15:08:27 -0700 (Thu, 10 May 2012)


Log Message
Crash in computedCSSPadding* functions due to RenderImage::imageDimensionsChanged called during attachment
https://bugs.webkit.org/show_bug.cgi?id=85912

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/images/link-body-content-imageDimensionChanged-crash.html
   fast/images/script-counter-imageDimensionChanged-crash.html

The bug comes from CSS generated images that could end up calling imageDimensionsChanged during attachment. As the
rest of the code (e.g. computedCSSPadding*) would assumes that we are already inserted in the tree, we would crash.

The solution is to bail out in this case as newly inserted RenderObject will trigger layout later on and properly
handle what we would be doing as part of imageDimensionChanged (the only exception being updating our intrinsic
size which should be done as part of imageDimensionsChanged).

* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):

LayoutTests:

* fast/images/link-body-content-imageDimensionChanged-crash-expected.txt: Added.
* fast/images/link-body-content-imageDimensionChanged-crash.html: Added.
* fast/images/script-counter-imageDimensionChanged-crash-expected.txt: Added.
* fast/images/script-counter-imageDimensionChanged-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderImage.cpp


Added Paths

trunk/LayoutTests/fast/images/link-body-content-imageDimensionChanged-crash-expected.txt
trunk/LayoutTests/fast/images/link-body-content-imageDimensionChanged-crash.html
trunk/LayoutTests/fast/images/script-counter-imageDimensionChanged-crash-expected.txt
trunk/LayoutTests/fast/images/script-counter-imageDimensionChanged-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (116692 => 116693)

--- trunk/LayoutTests/ChangeLog	2012-05-10 22:00:02 UTC (rev 116692)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 22:08:27 UTC (rev 116693)
@@ -1,3 +1,15 @@
+2012-05-10  Julien Chaffraix  jchaffr...@webkit.org
+
+Crash in computedCSSPadding* functions due to RenderImage::imageDimensionsChanged called during attachment
+https://bugs.webkit.org/show_bug.cgi?id=85912
+
+Reviewed by Eric Seidel.
+
+* fast/images/link-body-content-imageDimensionChanged-crash-expected.txt: Added.
+* fast/images/link-body-content-imageDimensionChanged-crash.html: Added.
+* fast/images/script-counter-imageDimensionChanged-crash-expected.txt: Added.
+* fast/images/script-counter-imageDimensionChanged-crash.html: Added.
+
 2012-05-10  Brady Eidson  beid...@apple.com
 
 rdar://problem/10972577 and https://bugs.webkit.org/show_bug.cgi?id=80170


Added: trunk/LayoutTests/fast/images/link-body-content-imageDimensionChanged-crash-expected.txt (0 => 116693)

--- trunk/LayoutTests/fast/images/link-body-content-imageDimensionChanged-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/images/link-body-content-imageDimensionChanged-crash-expected.txt	2012-05-10 22:08:27 UTC (rev 116693)
@@ -0,0 +1,5 @@
+Bug 85912: Crash in computedCSSPadding* functions due to RenderImage::imageDimensionsChanged called during attachment
+
+This test PASSED if it did not crash.
+
+


Added: trunk/LayoutTests/fast/images/link-body-content-imageDimensionChanged-crash.html (0 => 116693)

--- trunk/LayoutTests/fast/images/link-body-content-imageDimensionChanged-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/images/link-body-content-imageDimensionChanged-crash.html	2012-05-10 22:08:27 UTC (rev 116693)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+head
+style
+div {
+content: url(data:image/png;base64,iVBORw0KGgoNSUhEUg8PAQMBGAcJA1BMVEUAgACc+aWRDElEQVR42mNgIAEtAAH7KhMqAElFTkSuQmCC);
+padding-bottom: 10581%;
+}
+ /style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+/head
+p Bug a href="" Crash in computedCSSPadding* functions due to RenderImage::imageDimensionsChanged called during attachment/p
+p This test PASSED if it did not crash. /p
+div
+link href="" rel=stylesheet
+body style='content: PASSED, no crash; '/body
+/div
+/html


Added: trunk/LayoutTests/fast/images/script-counter-imageDimensionChanged-crash-expected.txt (0 => 116693)

--- trunk/LayoutTests/fast/images/script-counter-imageDimensionChanged-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/images/script-counter-imageDimensionChanged-crash-expected.txt	2012-05-10 22:08:27 UTC (rev 116693)
@@ -0,0 +1,5 @@
+Bug 85912: Crash in computedCSSPadding* functions due to RenderImage::imageDimensionsChanged called during attachment
+
+This test PASSED if it did not crash.
+
+


Added: trunk/LayoutTests/fast/images/script-counter-imageDimensionChanged-crash.html (0 => 116693)

--- 

[webkit-changes] [116694] trunk

[eric]

Title: [116694] trunk








Revision 116694
Author e...@webkit.org
Date 2012-05-10 15:11:57 -0700 (Thu, 10 May 2012)


Log Message
Make IFRAME_SEAMLESS child documents inherit styles from their parent iframe element
https://bugs.webkit.org/show_bug.cgi?id=85940

Reviewed by Ojan Vafai.

Source/WebCore:

The HTML5 iframe seamless spec says:
In a CSS-supporting user agent: the user agent must, for the purpose of CSS property
inheritance only, treat the root element of the active document of the iframe
element's nested browsing context as being a child of the iframe element.
(Thus inherited properties on the root element of the document in the
iframe will inherit the computed values of those properties on the iframe
element instead of taking their initial values.)

Initially I implemented this support to the letter of the spec. However, doing so I learned
that WebKit has a RenderStyle for the Document Node, not just the root element of the document.
In this RenderStyle on the Document, we add a bunch of per-document styles from settings
including designMode.

This change makes StyleResolver::styleForDocument inherit style from the parent iframe's
style, before applying any of these per-document styles.  This may or may not be correct
depending on what behavior we want for rtl-ordering, page-zoom, locale, design mode, etc.
For now, we continue to treat the iframe's document as independent in these regards, and
the settings on that document override those inherited from the iframe.

Also, intially when making this work, I added redirects in recalcStyle and scheduleStyleRecalc
from the child document to the parent document in the case of seamless (since the parent
document effectively manages the style resolve and layout of the child in seamless mode).
However, I was not able to find a test which depended on this code change, so in this final patch
I have removed both of these modifications and replaced them with FIXMEs.  Based on discussions
with Ojan and James Robinson, I believe both of those changes may eventually be wanted.

This change basically does 3 things:
1.  Makes StyleResolver::styleForDocument inherit from the parent iframe.
2.  Makes any recalcStyle calls on the iframe propogate down into the child document (HTMLIFrameElement::didRecalcStyle).
3.  Makes Document::recalcStyle aware of the fact that the Document's style *can* change
for reasons other than recalcStyle(Force).

I'm open to more testing suggestions, if reviewers have settings on the Document's style
that you want to make sure we inherit from the parent iframe, or don't inherit, etc.
I view this as a complete solution to this aspect of the current iframe seamless spec,
but likely not the last code we will write for this aspect of the seamless feature. :)

Tested by fast/frames/seamlesss/seamless-css-cascade.html and seamless-designMode.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* dom/Document.cpp:
(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::recalcStyle):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::HTMLIFrameElement):
(WebCore::HTMLIFrameElement::didRecalcStyle):
(WebCore):
* html/HTMLIFrameElement.h:
(HTMLIFrameElement):

LayoutTests:

This single pass is deceptive.  seamless-designMode exists
to make sure that we do not regress application of Document-level
styles in the child document.

* fast/frames/seamless/seamless-css-cascade-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/frames/seamless/seamless-css-cascade-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLIFrameElement.cpp
trunk/Source/WebCore/html/HTMLIFrameElement.h


Added Paths

trunk/LayoutTests/fast/frames/seamless/seamless-inherited-document-style-expected.txt
trunk/LayoutTests/fast/frames/seamless/seamless-inherited-document-style.html




Diff

Modified: trunk/LayoutTests/ChangeLog (116693 => 116694)

--- trunk/LayoutTests/ChangeLog	2012-05-10 22:08:27 UTC (rev 116693)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 22:11:57 UTC (rev 116694)
@@ -1,3 +1,16 @@
+2012-05-10  Eric Seidel  e...@webkit.org
+
+Make IFRAME_SEAMLESS child documents inherit styles from their parent iframe element
+https://bugs.webkit.org/show_bug.cgi?id=85940
+
+Reviewed by Ojan Vafai.
+
+This single pass is deceptive.  seamless-designMode exists
+to make sure that we do not regress application of Document-level
+styles in the child document.
+
+* fast/frames/seamless/seamless-css-cascade-expected.txt:
+
 2012-05-10  Julien Chaffraix  jchaffr...@webkit.org
 
 Crash in computedCSSPadding* functions due to RenderImage::imageDimensionsChanged called during attachment


Modified: trunk/LayoutTests/fast/frames/seamless/seamless-css-cascade-expected.txt (116693 => 116694)

--- 

[webkit-changes] [116695] trunk

[andersca]

Title: [116695] trunk








Revision 116695
Author ander...@apple.com
Date 2012-05-10 15:45:41 -0700 (Thu, 10 May 2012)


Log Message
WebKit1: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86150
rdar://problem/9551196

Reviewed by Sam Weinig.

Source/WebCore:

* English.lproj/Localizable.strings:
Update.

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):
It is possible that the client has already set the unavailability reason so don't try to set it twice.

* platform/LocalizedStrings.cpp:
(WebCore::insecurePluginVersionText):
* platform/LocalizedStrings.h:
Add insecure plug-in version text.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::unavailablePluginReplacementText):
* rendering/RenderEmbeddedObject.h:
Add InsecurePluginVersion unavailability reason.

Source/WebKit/mac:

* Misc/WebKitErrors.h:
Add WebKitErrorInsecurePlugInVersion enum.

* Plugins/WebBasePluginPackage.h:
* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage bundleIdentifier]):
(-[WebBasePluginPackage bundleVersion]):
Add bundleIdentifier and bundleVersion getters.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
Check if the plug-in is blocked. If it is, set the unavailability reason and the error code.

WebKitLibraries:

Add WKShouldBlockPlugin.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/Localizable.strings
trunk/Source/WebCore/loader/SubframeLoader.cpp
trunk/Source/WebCore/platform/LocalizedStrings.cpp
trunk/Source/WebCore/platform/LocalizedStrings.h
trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp
trunk/Source/WebCore/rendering/RenderEmbeddedObject.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Misc/WebKitErrors.h
trunk/Source/WebKit/mac/Plugins/WebBasePluginPackage.h
trunk/Source/WebKit/mac/Plugins/WebBasePluginPackage.mm
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/WebKitSystemInterface.h
trunk/WebKitLibraries/libWebKitSystemInterfaceLion.a
trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a




Diff

Modified: trunk/Source/WebCore/ChangeLog (116694 => 116695)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 22:11:57 UTC (rev 116694)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 22:45:41 UTC (rev 116695)
@@ -1,3 +1,28 @@
+2012-05-10  Anders Carlsson  ander...@apple.com
+
+WebKit1: Add a way to blacklist specific plug-ins/plug-in versions
+https://bugs.webkit.org/show_bug.cgi?id=86150
+rdar://problem/9551196
+
+Reviewed by Sam Weinig.
+
+* English.lproj/Localizable.strings:
+Update.
+
+* loader/SubframeLoader.cpp:
+(WebCore::SubframeLoader::loadPlugin):
+It is possible that the client has already set the unavailability reason so don't try to set it twice.
+
+* platform/LocalizedStrings.cpp:
+(WebCore::insecurePluginVersionText):
+* platform/LocalizedStrings.h:
+Add insecure plug-in version text.
+
+* rendering/RenderEmbeddedObject.cpp:
+(WebCore::RenderEmbeddedObject::unavailablePluginReplacementText):
+* rendering/RenderEmbeddedObject.h:
+Add InsecurePluginVersion unavailability reason.
+
 2012-05-10  Eric Seidel  e...@webkit.org
 
 Make IFRAME_SEAMLESS child documents inherit styles from their parent iframe element


Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (116694 => 116695)

--- trunk/Source/WebCore/English.lproj/Localizable.strings	2012-05-10 22:11:57 UTC (rev 116694)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings	2012-05-10 22:45:41 UTC (rev 116695)
@@ -172,6 +172,9 @@
 /* Undo action name */
 Indent (Undo action name) = Indent;
 
+/* Label text to be used when an insecure plug-in version was blocked from loading */
+Insecure Plug-In Version = Insecure Plug-In Version;
+
 /* Undo action name */
 Insert List (Undo action name) = Insert List;
 


Modified: trunk/Source/WebCore/loader/SubframeLoader.cpp (116694 => 116695)

--- trunk/Source/WebCore/loader/SubframeLoader.cpp	2012-05-10 22:11:57 UTC (rev 116694)
+++ trunk/Source/WebCore/loader/SubframeLoader.cpp	2012-05-10 22:45:41 UTC (rev 116695)
@@ -376,7 +376,8 @@
 pluginElement, url, paramNames, paramValues, mimeType, loadManually);
 
 if (!widget) {
-renderer-setPluginUnavailabilityReason(RenderEmbeddedObject::PluginMissing);
+if (!renderer-showsUnavailablePluginIndicator())
+

[webkit-changes] [116696] tags/Safari-536.10.3/

[lforschler]

Title: [116696] tags/Safari-536.10.3/








Revision 116696
Author lforsch...@apple.com
Date 2012-05-10 15:55:03 -0700 (Thu, 10 May 2012)


Log Message
new Tag.

Added Paths

tags/Safari-536.10.3/




Diff

Property changes: tags/Safari-536.10.3



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116697] trunk/Source/WebCore

[bdakin]

Title: [116697] trunk/Source/WebCore








Revision 116697
Author bda...@apple.com
Date 2012-05-10 15:58:28 -0700 (Thu, 10 May 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=82131
[Mac] REGRESSION (r110480): Text field that specifies background-color 
(or is auto-filled) gets un-themed border
-and corresponding-
rdar://problem/5221

Reviewed by Maciej Stachowiak.

This change rolls out r110480 which is what caused styled text fields 
to get the un-themed border, and it does a bunch of work to make sure 
we get the pretty, new version of the NSTextField art whenever 
possible. We do this differently for post-Lion OS's since there is now 
a way to opt into it all the time. Lion and SnowLeopard can only use 
the new art in HiDPI mode when the background color of the text field 
is just white.

RenderThemeMac::textField() takes a boolean paramter used to determine 
if the new gradient will be used.
* rendering/RenderThemeMac.h:
(RenderThemeMac):

This is the post-Lion workaround. This code has no effect on Lion and 
SnowLeopard. This allows up to opt into a version of [NSTextField drawWithFrame:] that will only draw the frame of the text field; without this, it will draw the frame and the background, which creates a number of problems with styled text fields and text fields in HiDPI. There is a less comprehesive workaround for Lion and SnowLeopard in place in RenderThemeMac::textField().
* rendering/RenderThemeMac.mm:
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):

This is the roll-out of r110480.
(WebCore::RenderThemeMac::isControlStyled):

See the comments for a full explanation, but this is mostly code for 
Lion and SnowLeopard to determine if we can opt into the new artwork.
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeMac.h
trunk/Source/WebCore/rendering/RenderThemeMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (116696 => 116697)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 22:55:03 UTC (rev 116696)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 22:58:28 UTC (rev 116697)
@@ -1,3 +1,39 @@
+2012-05-10  Beth Dakin  bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=82131
+[Mac] REGRESSION (r110480): Text field that specifies background-color 
+(or is auto-filled) gets un-themed border
+-and corresponding-
+rdar://problem/5221
+
+Reviewed by Maciej Stachowiak.
+
+This change rolls out r110480 which is what caused styled text fields 
+to get the un-themed border, and it does a bunch of work to make sure 
+we get the pretty, new version of the NSTextField art whenever 
+possible. We do this differently for post-Lion OS's since there is now 
+a way to opt into it all the time. Lion and SnowLeopard can only use 
+the new art in HiDPI mode when the background color of the text field 
+is just white.
+
+RenderThemeMac::textField() takes a boolean paramter used to determine 
+if the new gradient will be used.
+* rendering/RenderThemeMac.h:
+(RenderThemeMac):
+
+This is the post-Lion workaround. This code has no effect on Lion and 
+SnowLeopard. This allows up to opt into a version of [NSTextField drawWithFrame:] that will only draw the frame of the text field; without this, it will draw the frame and the background, which creates a number of problems with styled text fields and text fields in HiDPI. There is a less comprehesive workaround for Lion and SnowLeopard in place in RenderThemeMac::textField().
+* rendering/RenderThemeMac.mm:
+(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
+
+This is the roll-out of r110480.
+(WebCore::RenderThemeMac::isControlStyled):
+
+See the comments for a full explanation, but this is mostly code for 
+Lion and SnowLeopard to determine if we can opt into the new artwork.
+(WebCore::RenderThemeMac::paintTextField):
+(WebCore::RenderThemeMac::textField):
+
 2012-05-10  Anders Carlsson  ander...@apple.com
 
 WebKit1: Add a way to blacklist specific plug-ins/plug-in versions


Modified: trunk/Source/WebCore/rendering/RenderThemeMac.h (116696 => 116697)

--- trunk/Source/WebCore/rendering/RenderThemeMac.h	2012-05-10 22:55:03 UTC (rev 116696)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.h	2012-05-10 22:58:28 UTC (rev 116697)
@@ -219,7 +219,7 @@
 NSMenu* searchMenuTemplate() const;
 NSSliderCell* sliderThumbHorizontal() const;
 NSSliderCell* sliderThumbVertical() const;
-NSTextFieldCell* textField() const;
+NSTextFieldCell* textField(bool useNewGradient) const;
 
 #if ENABLE(METER_TAG)
 NSLevelIndicatorStyle levelIndicatorStyleFor(ControlPart) const;


Modified: 

[webkit-changes] [116698] trunk

[inferno]

Title: [116698] trunk








Revision 116698
Author infe...@chromium.org
Date 2012-05-10 16:02:00 -0700 (Thu, 10 May 2012)


Log Message
Crash in FontCache::releaseFontData due to infinite float size.
https://bugs.webkit.org/show_bug.cgi?id=86110

Reviewed by Andreas Kling.

Source/WebCore:

New callers always forget to clamp the font size, which overflows
to infinity on multiplication. It is best to clamp it at the end
to avoid getting greater than std::numeric_limitsfloat::max().

Test: fast/css/large-font-size-crash.html

* platform/graphics/FontDescription.h:
(WebCore::FontDescription::setComputedSize):
(WebCore::FontDescription::setSpecifiedSize):

LayoutTests:

* fast/css/large-font-size-crash-expected.txt: Added.
* fast/css/large-font-size-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontDescription.h


Added Paths

trunk/LayoutTests/fast/css/large-font-size-crash-expected.txt
trunk/LayoutTests/fast/css/large-font-size-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (116697 => 116698)

--- trunk/LayoutTests/ChangeLog	2012-05-10 22:58:28 UTC (rev 116697)
+++ trunk/LayoutTests/ChangeLog	2012-05-10 23:02:00 UTC (rev 116698)
@@ -1,3 +1,13 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Crash in FontCache::releaseFontData due to infinite float size.
+https://bugs.webkit.org/show_bug.cgi?id=86110
+
+Reviewed by Andreas Kling.
+
+* fast/css/large-font-size-crash-expected.txt: Added.
+* fast/css/large-font-size-crash.html: Added.
+
 2012-05-10  Eric Seidel  e...@webkit.org
 
 Make IFRAME_SEAMLESS child documents inherit styles from their parent iframe element


Added: trunk/LayoutTests/fast/css/large-font-size-crash-expected.txt (0 => 116698)

--- trunk/LayoutTests/fast/css/large-font-size-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/large-font-size-crash-expected.txt	2012-05-10 23:02:00 UTC (rev 116698)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.


Added: trunk/LayoutTests/fast/css/large-font-size-crash.html (0 => 116698)

--- trunk/LayoutTests/fast/css/large-font-size-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/css/large-font-size-crash.html	2012-05-10 23:02:00 UTC (rev 116698)
@@ -0,0 +1,10 @@
+!DOCTYPE html
+html
+body style='font: 99in Ahem;'
+PASS. WebKit didn't crash.
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+/body
+/html
Property changes on: trunk/LayoutTests/fast/css/large-font-size-crash.html
___


Added: svn:executable

Modified: trunk/Source/WebCore/ChangeLog (116697 => 116698)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 22:58:28 UTC (rev 116697)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 23:02:00 UTC (rev 116698)
@@ -1,3 +1,20 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Crash in FontCache::releaseFontData due to infinite float size.
+https://bugs.webkit.org/show_bug.cgi?id=86110
+
+Reviewed by Andreas Kling.
+
+New callers always forget to clamp the font size, which overflows
+to infinity on multiplication. It is best to clamp it at the end
+to avoid getting greater than std::numeric_limitsfloat::max().
+
+Test: fast/css/large-font-size-crash.html
+
+* platform/graphics/FontDescription.h:
+(WebCore::FontDescription::setComputedSize):
+(WebCore::FontDescription::setSpecifiedSize):
+
 2012-05-10  Beth Dakin  bda...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=82131


Modified: trunk/Source/WebCore/platform/graphics/FontDescription.h (116697 => 116698)

--- trunk/Source/WebCore/platform/graphics/FontDescription.h	2012-05-10 22:58:28 UTC (rev 116697)
+++ trunk/Source/WebCore/platform/graphics/FontDescription.h	2012-05-10 23:02:00 UTC (rev 116698)
@@ -138,8 +138,8 @@
 FontDescription makeNormalFeatureSettings() const;
 
 void setFamily(const FontFamily family) { m_familyList = family; }
-void setComputedSize(float s) { ASSERT(isfinite(s)); m_computedSize = s; }
-void setSpecifiedSize(float s) { ASSERT(isfinite(s)); m_specifiedSize = s; }
+void setComputedSize(float s) { m_computedSize = clampToFloat(s); }
+void setSpecifiedSize(float s) { m_specifiedSize = clampToFloat(s); }
 void setItalic(FontItalic i) { m_italic = i; }
 void setItalic(bool i) { setItalic(i ? FontItalicOn : FontItalicOff); }
 void setSmallCaps(FontSmallCaps c) { m_smallCaps = c; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116700] tags/Safari-536.10.3/Source

[lforschler]

Title: [116700] tags/Safari-536.10.3/Source








Revision 116700
Author lforsch...@apple.com
Date 2012-05-10 16:11:40 -0700 (Thu, 10 May 2012)


Log Message
Versioning.

Modified Paths

tags/Safari-536.10.3/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-536.10.3/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-536.10.3/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-536.10.3/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-536.10.3/Source/_javascript_Core/Configurations/Version.xcconfig (116699 => 116700)

--- tags/Safari-536.10.3/Source/_javascript_Core/Configurations/Version.xcconfig	2012-05-10 23:10:25 UTC (rev 116699)
+++ tags/Safari-536.10.3/Source/_javascript_Core/Configurations/Version.xcconfig	2012-05-10 23:11:40 UTC (rev 116700)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 536;
 MINOR_VERSION = 10;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: tags/Safari-536.10.3/Source/WebCore/Configurations/Version.xcconfig (116699 => 116700)

--- tags/Safari-536.10.3/Source/WebCore/Configurations/Version.xcconfig	2012-05-10 23:10:25 UTC (rev 116699)
+++ tags/Safari-536.10.3/Source/WebCore/Configurations/Version.xcconfig	2012-05-10 23:11:40 UTC (rev 116700)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 536;
 MINOR_VERSION = 10;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: tags/Safari-536.10.3/Source/WebKit/mac/Configurations/Version.xcconfig (116699 => 116700)

--- tags/Safari-536.10.3/Source/WebKit/mac/Configurations/Version.xcconfig	2012-05-10 23:10:25 UTC (rev 116699)
+++ tags/Safari-536.10.3/Source/WebKit/mac/Configurations/Version.xcconfig	2012-05-10 23:11:40 UTC (rev 116700)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 536;
 MINOR_VERSION = 10;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: tags/Safari-536.10.3/Source/WebKit2/Configurations/Version.xcconfig (116699 => 116700)

--- tags/Safari-536.10.3/Source/WebKit2/Configurations/Version.xcconfig	2012-05-10 23:10:25 UTC (rev 116699)
+++ tags/Safari-536.10.3/Source/WebKit2/Configurations/Version.xcconfig	2012-05-10 23:11:40 UTC (rev 116700)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 536;
 MINOR_VERSION = 10;
-TINY_VERSION = 2;
+TINY_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116702] branches/chromium/1132/Tools/Scripts/webkitpy/thirdparty/ mod_pywebsocket/

[kerz]

Title: [116702] branches/chromium/1132/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/








Revision 116702
Author k...@chromium.org
Date 2012-05-10 16:38:02 -0700 (Thu, 10 May 2012)


Log Message
Add new pywebsocket files.

Added Paths

branches/chromium/1132/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket/




Diff

Property changes: branches/chromium/1132/Tools/Scripts/webkitpy/thirdparty/mod_pywebsocket



Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116703] trunk/Tools

[dpranke]

Title: [116703] trunk/Tools








Revision 116703
Author dpra...@chromium.org
Date 2012-05-10 16:48:11 -0700 (Thu, 10 May 2012)


Log Message
[chromium] Set Valgrind environment variables for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=86156

Patch by Lei Zhang thes...@chromium.org on 2012-05-10
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.setup_environ_for_server):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py




Diff

Modified: trunk/Tools/ChangeLog (116702 => 116703)

--- trunk/Tools/ChangeLog	2012-05-10 23:38:02 UTC (rev 116702)
+++ trunk/Tools/ChangeLog	2012-05-10 23:48:11 UTC (rev 116703)
@@ -1,3 +1,13 @@
+2012-05-10  Lei Zhang  thes...@chromium.org
+
+[chromium] Set Valgrind environment variables for layout tests.
+https://bugs.webkit.org/show_bug.cgi?id=86156
+
+Reviewed by Dirk Pranke.
+
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumPort.setup_environ_for_server):
+
 2012-05-10  Raphael Kubo da Costa  rak...@webkit.org
 
 [webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (116702 => 116703)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-05-10 23:38:02 UTC (rev 116702)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-05-10 23:48:11 UTC (rev 116703)
@@ -235,6 +235,13 @@
 def path_to_test_expectations_file(self):
 return self.path_from_webkit_base('LayoutTests', 'platform', 'chromium', 'test_expectations.txt')
 
+def setup_environ_for_server(self, server_name=None):
+clean_env = super(ChromiumPort, self).setup_environ_for_server(server_name)
+# Webkit Linux (valgrind layout) bot needs these envvars.
+self._copy_value_from_environ_if_set(clean_env, 'VALGRIND_LIB')
+self._copy_value_from_environ_if_set(clean_env, 'VALGRIND_LIB_INNER')
+return clean_env
+
 def default_results_directory(self):
 try:
 return self.path_from_chromium_base('webkit', self.get_option('configuration'), 'layout-test-results')






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116704] tags/Safari-536.11/

[lforschler]

Title: [116704] tags/Safari-536.11/








Revision 116704
Author lforsch...@apple.com
Date 2012-05-10 16:53:24 -0700 (Thu, 10 May 2012)


Log Message
New Tag.

Added Paths

tags/Safari-536.11/




Diff

Property changes: tags/Safari-536.11



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116705] trunk/Source/WebCore

[commit-queue]

Title: [116705] trunk/Source/WebCore








Revision 116705
Author commit-qu...@webkit.org
Date 2012-05-10 17:02:04 -0700 (Thu, 10 May 2012)


Log Message
Unreviewed, rolling out r116677.
http://trac.webkit.org/changeset/116677
https://bugs.webkit.org/show_bug.cgi?id=86159

This patch causes linker error to some mac bots (Requested by
jianli_ on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-05-10

* WebCore.exp.in:
* dom/ContainerNode.h:
* dom/Node.cpp:
(WebCore::Node::traverseNextNode):
(WebCore::Node::traverseNextSibling):
* dom/Node.h:
(Node):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116704 => 116705)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 23:53:24 UTC (rev 116704)
+++ trunk/Source/WebCore/ChangeLog	2012-05-11 00:02:04 UTC (rev 116705)
@@ -1,3 +1,20 @@
+2012-05-10  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r116677.
+http://trac.webkit.org/changeset/116677
+https://bugs.webkit.org/show_bug.cgi?id=86159
+
+This patch causes linker error to some mac bots (Requested by
+jianli_ on #webkit).
+
+* WebCore.exp.in:
+* dom/ContainerNode.h:
+* dom/Node.cpp:
+(WebCore::Node::traverseNextNode):
+(WebCore::Node::traverseNextSibling):
+* dom/Node.h:
+(Node):
+
 2012-05-10  Abhishek Arya  infe...@chromium.org
 
 Crash in FontCache::releaseFontData due to infinite float size.


Modified: trunk/Source/WebCore/WebCore.exp.in (116704 => 116705)

--- trunk/Source/WebCore/WebCore.exp.in	2012-05-10 23:53:24 UTC (rev 116704)
+++ trunk/Source/WebCore/WebCore.exp.in	2012-05-11 00:02:04 UTC (rev 116705)
@@ -2099,7 +2099,7 @@
 __ZN7WebCore8Document36setFullScreenRendererBackgroundColorENS_5ColorE
 __ZN7WebCore8Document22setAnimatingFullScreenEb
 __ZNK7WebCore8Document9domWindowEv
-__ZNK7WebCore4Node27traverseNextAncestorSiblingEv
+__ZNK7WebCore4Node16traverseNextNodeEPKS0_
 #endif
 
 __ZN7WebCore16ApplicationCache18diskUsageForOriginEPNS_14SecurityOriginE


Modified: trunk/Source/WebCore/dom/ContainerNode.h (116704 => 116705)

--- trunk/Source/WebCore/dom/ContainerNode.h	2012-05-10 23:53:24 UTC (rev 116704)
+++ trunk/Source/WebCore/dom/ContainerNode.h	2012-05-11 00:02:04 UTC (rev 116705)
@@ -229,36 +229,6 @@
 return highest;
 }
 
-inline Node* Node::traverseNextSibling() const
-{
-if (nextSibling())
-return nextSibling();
-return traverseNextAncestorSibling();
-}
-
-inline Node* Node::traverseNextNode() const
-{
-if (firstChild())
-return firstChild();
-return traverseNextSibling();
-}
-
-inline Node* Node::traverseNextSibling(const Node* stayWithin) const
-{
-if (this == stayWithin)
-return 0;
-if (nextSibling())
-return nextSibling();
-return traverseNextAncestorSibling(stayWithin);
-}
-
-inline Node* Node::traverseNextNode(const Node* stayWithin) const
-{
-if (firstChild())
-return firstChild();
-return traverseNextSibling(stayWithin);
-}
-
 typedef VectorRefPtrNode, 11 NodeVector;
 
 inline void getChildNodes(Node* node, NodeVector nodes)


Modified: trunk/Source/WebCore/dom/Node.cpp (116704 => 116705)

--- trunk/Source/WebCore/dom/Node.cpp	2012-05-10 23:53:24 UTC (rev 116704)
+++ trunk/Source/WebCore/dom/Node.cpp	2012-05-11 00:02:04 UTC (rev 116705)
@@ -1088,26 +1088,33 @@
 rareData()-setChildNodeList(0);
 }
 
-Node* Node::traverseNextAncestorSibling() const
+Node* Node::traverseNextNode(const Node* stayWithin) const
 {
-ASSERT(!nextSibling());
-for (const Node* node = parentNode(); node; node = node-parentNode()) {
-if (node-nextSibling())
-return node-nextSibling();
-}
+if (firstChild())
+return firstChild();
+if (this == stayWithin)
+return 0;
+if (nextSibling())
+return nextSibling();
+const Node *n = this;
+while (n  !n-nextSibling()  (!stayWithin || n-parentNode() != stayWithin))
+n = n-parentNode();
+if (n)
+return n-nextSibling();
 return 0;
 }
 
-Node* Node::traverseNextAncestorSibling(const Node* stayWithin) const
+Node* Node::traverseNextSibling(const Node* stayWithin) const
 {
-ASSERT(!nextSibling());
-ASSERT(this != stayWithin);
-for (const Node* node = parentNode(); node; node = node-parentNode()) {
-if (node == stayWithin)
-return 0;
-if (node-nextSibling())
-return node-nextSibling();
-}
+if (this == stayWithin)
+return 0;
+if (nextSibling())
+return nextSibling();
+const Node *n = this;
+while (n  !n-nextSibling()  (!stayWithin || n-parentNode() != stayWithin))
+n = n-parentNode();
+if (n)
+return n-nextSibling();
 return 0;
 }
 


Modified: 

[webkit-changes] [116706] branches/chromium/1132/Source

[jsbell]

Title: [116706] branches/chromium/1132/Source








Revision 116706
Author jsb...@chromium.org
Date 2012-05-10 17:03:51 -0700 (Thu, 10 May 2012)


Log Message
Merge 116333 - IndexedDB: LevelDB coding for bools is broken
https://bugs.webkit.org/show_bug.cgi?id=85810

Reviewed by Tony Chang.

Source/WebCore:

Code was appending to a pre-sized Vector, rather than using an
index setter. This caused uninitialized data to be written out.
Issue was detected on the Chromium side in http://crbug.com/126388

Tests: webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*codeBool'

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeBool):

Source/WebKit/chromium:

Added tests for encodeBool/decodeBool.

* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding):


TBR=jsb...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10377101

Modified Paths

branches/chromium/1132/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp
branches/chromium/1132/Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp




Diff

Modified: branches/chromium/1132/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp (116705 => 116706)

--- branches/chromium/1132/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp	2012-05-11 00:02:04 UTC (rev 116705)
+++ branches/chromium/1132/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp	2012-05-11 00:03:51 UTC (rev 116706)
@@ -180,7 +180,7 @@
 Vectorchar encodeBool(bool b)
 {
 Vectorchar ret(1);
-ret.append(b ? 1 : 0);
+ret[0] = b ? 1 : 0;
 return ret;
 }
 


Modified: branches/chromium/1132/Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp (116705 => 116706)

--- branches/chromium/1132/Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp	2012-05-11 00:02:04 UTC (rev 116705)
+++ branches/chromium/1132/Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp	2012-05-11 00:03:51 UTC (rev 116706)
@@ -83,6 +83,20 @@
 EXPECT_EQ(expected, encodeByte(c));
 }
 
+TEST(IDBLevelDBCodingTest, EncodeBool)
+{
+{
+Vectorchar expected;
+expected.append(1);
+EXPECT_EQ(expected, encodeBool(true));
+}
+{
+Vectorchar expected;
+expected.append(0);
+EXPECT_EQ(expected, encodeBool(false));
+}
+}
+
 TEST(IDBLevelDBCodingTest, MaxIDBKey)
 {
 Vectorchar maxKey = maxIDBKey();
@@ -126,6 +140,20 @@
 EXPECT_EQ(static_castsize_t(4), encodeInt(0x).size());
 }
 
+TEST(IDBLevelDBCodingTest, DecodeBool)
+{
+{
+Vectorchar encoded;
+encoded.append(1);
+EXPECT_TRUE(decodeBool(encoded.data(), encoded.data() + encoded.size()));
+}
+{
+Vectorchar encoded;
+encoded.append(0);
+EXPECT_FALSE(decodeBool(encoded.data(), encoded.data() + encoded.size()));
+}
+}
+
 TEST(IDBLevelDBCodingTest, DecodeInt)
 {
 Vectorint64_t testCases;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116707] trunk/Tools

[dpranke]

Title: [116707] trunk/Tools








Revision 116707
Author dpra...@chromium.org
Date 2012-05-10 17:06:02 -0700 (Thu, 10 May 2012)


Log Message
nrwt: [chromium] fix path to asan symbolize script
https://bugs.webkit.org/show_bug.cgi?id=86161

Reviewed by Abhishek Arya.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py




Diff

Modified: trunk/Tools/ChangeLog (116706 => 116707)

--- trunk/Tools/ChangeLog	2012-05-11 00:03:51 UTC (rev 116706)
+++ trunk/Tools/ChangeLog	2012-05-11 00:06:02 UTC (rev 116707)
@@ -1,3 +1,13 @@
+2012-05-10  Dirk Pranke  dpra...@chromium.org
+
+nrwt: [chromium] fix path to asan symbolize script
+https://bugs.webkit.org/show_bug.cgi?id=86161
+
+Reviewed by Abhishek Arya.
+
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+(ChromiumPort._get_crash_log):
+
 2012-05-10  Lei Zhang  thes...@chromium.org
 
 [chromium] Set Valgrind environment variables for layout tests.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (116706 => 116707)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-05-11 00:03:51 UTC (rev 116706)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2012-05-11 00:06:02 UTC (rev 116707)
@@ -344,7 +344,7 @@
 def _get_crash_log(self, name, pid, stdout, stderr, newer_than):
 new_stderr = stderr
 if stderr and 'AddressSanitizer' in stderr:
-asan_filter_path = self.path_from_chromium_base('third_party', 'asan', 'scripts', 'asan_symbolize.py')
+asan_filter_path = self.path_from_chromium_base('tools', 'valgrind', 'asan', 'asan_symbolize.py')
 if self._filesystem.exists(asan_filter_path):
 output = self._executive.run_command([asan_filter_path], input=stderr)
 new_stderr = self._executive.run_command(['c++filt'], input=output)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116708] trunk/Source/WebCore

[andersca]

Title: [116708] trunk/Source/WebCore








Revision 116708
Author ander...@apple.com
Date 2012-05-10 17:06:37 -0700 (Thu, 10 May 2012)


Log Message
Add insecurePluginVersionText stubs.

* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::insecurePluginVersionText):
(WebCore):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::insecurePluginVersionText):
(WebCore):
* platform/qt/LocalizedStringsQt.cpp:
(WebCore::insecurePluginVersionText):
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp
trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp
trunk/Source/WebCore/platform/qt/LocalizedStringsQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116707 => 116708)

--- trunk/Source/WebCore/ChangeLog	2012-05-11 00:06:02 UTC (rev 116707)
+++ trunk/Source/WebCore/ChangeLog	2012-05-11 00:06:37 UTC (rev 116708)
@@ -1,3 +1,17 @@
+2012-05-10  Anders Carlsson  ander...@apple.com
+
+Add insecurePluginVersionText stubs.
+
+* platform/blackberry/LocalizedStringsBlackBerry.cpp:
+(WebCore::insecurePluginVersionText):
+(WebCore):
+* platform/efl/LocalizedStringsEfl.cpp:
+(WebCore::insecurePluginVersionText):
+(WebCore):
+* platform/qt/LocalizedStringsQt.cpp:
+(WebCore::insecurePluginVersionText):
+(WebCore):
+
 2012-05-10  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r116677.


Modified: trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp (116707 => 116708)

--- trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp	2012-05-11 00:06:02 UTC (rev 116707)
+++ trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp	2012-05-11 00:06:37 UTC (rev 116708)
@@ -572,6 +572,12 @@
 return String();
 }
 
+String insecurePluginVersionText()
+{
+notImplemented();
+return String();
+}
+
 String multipleFileUploadText(unsigned)
 {
 return String(, ...);


Modified: trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp (116707 => 116708)

--- trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp	2012-05-11 00:06:02 UTC (rev 116707)
+++ trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp	2012-05-11 00:06:37 UTC (rev 116708)
@@ -560,6 +560,12 @@
 return String::fromUTF8(plugin crashed);
 }
 
+String insecurePluginVersionText()
+{
+notImplemented();
+return String();
+}
+
 String localizedString(const char* key)
 {
 return String::fromUTF8(key, strlen(key));


Modified: trunk/Source/WebCore/platform/qt/LocalizedStringsQt.cpp (116707 => 116708)

--- trunk/Source/WebCore/platform/qt/LocalizedStringsQt.cpp	2012-05-11 00:06:02 UTC (rev 116707)
+++ trunk/Source/WebCore/platform/qt/LocalizedStringsQt.cpp	2012-05-11 00:06:37 UTC (rev 116708)
@@ -445,6 +445,12 @@
 return String();
 }
 
+String insecurePluginVersionText()
+{
+notImplemented();
+return String();
+}
+
 String multipleFileUploadText(unsigned)
 {
 notImplemented();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116716] trunk

[andersca]

Title: [116716] trunk








Revision 116716
Author ander...@apple.com
Date 2012-05-10 18:49:40 -0700 (Thu, 10 May 2012)


Log Message
WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
https://bugs.webkit.org/show_bug.cgi?id=86164
rdar://problem/9551196

Reviewed by Sam Weinig.

Source/WebKit2:

* Shared/API/c/WKError.h:
Add kWKErrorCodeInsecurePlugInVersion error code.

* Shared/APIClientTraits.cpp:
Update now that didFailToInitializePlugin is deprecated.

* UIProcess/API/C/WKPage.h:
Deprecate didFailToInitializePlugin and replace it with the more generic pluginDidFail.
Also, deprecate missingPluginButtonClicked and replace it with unavailablePluginButtonClicked.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::shouldBlockPlugin):
Non-Mac version, always return false.

* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldBlockPlugin):
Call WKShouldBlockPlugin.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::getPluginPath):
Check if the plug-in should be blocked.

* UIProcess/WebContext.messages.in:
GetPluginPath now takes an additional out parameter, a boolean that determines whether the plug-in
should be blocked from loading or not.

* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailToInitializePlugin):
Call m_client.pluginDidFail.

(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
Ditto.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Call the loader client.

(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Ditto.

* UIProcess/WebPageProxy.messages.in:
Rename MissingPluginButtonClicked to UnavailablePluginButtonClicked and add a new DidBlockInsecurePluginVersion message.

* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::unavailablePluginButtonClicked):
Call missingPluginButtonClicked and unavailablePluginButtonClicked.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
Handle RenderEmbeddedObject::InsecurePluginVersion.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
WebPage::createPlugin now takes the plug-in element.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
If the plug-in is blocked, set the appropriate unavailability reason.

* WebProcess/WebProcess.cpp:
(WebKit::canPluginHandleResponse):
Update now that GetPluginPath returns a blocked parameter as well.

Tools:

Update for WK2 API changes.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/c/WKError.h
trunk/Source/WebKit2/Shared/APIClientTraits.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPage.h
trunk/Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp
trunk/Source/WebKit2/UIProcess/Plugins/PluginInfoStore.h
trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/UIProcess/WebContext.messages.in
trunk/Source/WebKit2/UIProcess/WebLoaderClient.cpp
trunk/Source/WebKit2/UIProcess/WebLoaderClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/UIProcess/WebUIClient.cpp
trunk/Source/WebKit2/UIProcess/WebUIClient.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/BrowserWindowController.m
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116715 => 116716)

--- trunk/Source/WebKit2/ChangeLog	2012-05-11 01:45:47 UTC (rev 116715)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-11 01:49:40 UTC (rev 116716)
@@ -1,5 +1,77 @@
 2012-05-10  Anders Carlsson  ander...@apple.com
 
+WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
+https://bugs.webkit.org/show_bug.cgi?id=86164
+rdar://problem/9551196
+
+Reviewed by Sam Weinig.
+
+* Shared/API/c/WKError.h:
+Add kWKErrorCodeInsecurePlugInVersion error code.
+
+* Shared/APIClientTraits.cpp:
+Update now that didFailToInitializePlugin is deprecated.
+
+* UIProcess/API/C/WKPage.h:
+Deprecate didFailToInitializePlugin and replace it with the more generic pluginDidFail. 
+Also, deprecate missingPluginButtonClicked and replace it with unavailablePluginButtonClicked.
+
+* 

[webkit-changes] [116717] trunk/Source/WebCore

[inferno]

Title: [116717] trunk/Source/WebCore








Revision 116717
Author infe...@chromium.org
Date 2012-05-10 19:06:11 -0700 (Thu, 10 May 2012)


Log Message
Crash in swapInNodePreservingAttributesAndChildren.
https://bugs.webkit.org/show_bug.cgi?id=85197

Reviewed by Ryosuke Niwa.

Keep the children in a ref vector before adding them to newNode.
They can get destroyed due to mutation events.

No new tests because we don't have a reduction.

* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116716 => 116717)

--- trunk/Source/WebCore/ChangeLog	2012-05-11 01:49:40 UTC (rev 116716)
+++ trunk/Source/WebCore/ChangeLog	2012-05-11 02:06:11 UTC (rev 116717)
@@ -1,3 +1,18 @@
+2012-05-10  Abhishek Arya  infe...@chromium.org
+
+Crash in swapInNodePreservingAttributesAndChildren.
+https://bugs.webkit.org/show_bug.cgi?id=85197
+ 
+Reviewed by Ryosuke Niwa.
+ 
+Keep the children in a ref vector before adding them to newNode.
+They can get destroyed due to mutation events.
+
+No new tests because we don't have a reduction.
+
+* editing/ReplaceNodeWithSpanCommand.cpp:
+(WebCore::swapInNodePreservingAttributesAndChildren):
+
 2012-05-10  Shinya Kawanaka  shin...@chromium.org
 
 [Refactoring] Move Selection from DOMWindow to TreeScope.


Modified: trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp (116716 => 116717)

--- trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp	2012-05-11 01:49:40 UTC (rev 116716)
+++ trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp	2012-05-11 02:06:11 UTC (rev 116717)
@@ -56,10 +56,10 @@
 parentNode-insertBefore(newNode, nodeToReplace, ec);
 ASSERT(!ec);
 
-RefPtrNode nextChild;
-for (Node* child = nodeToReplace-firstChild(); child; child = nextChild.get()) {
-nextChild = child-nextSibling();
-newNode-appendChild(child, ec);
+NodeVector children;
+getChildNodes(nodeToReplace, children);
+for (size_t i = 0; i  children.size(); ++i) {
+newNode-appendChild(children[i], ec);
 ASSERT(!ec);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116718] trunk/Source/WebCore

[commit-queue]

Title: [116718] trunk/Source/WebCore








Revision 116718
Author commit-qu...@webkit.org
Date 2012-05-10 19:08:06 -0700 (Thu, 10 May 2012)


Log Message
Eliminate duplicated code for culled line box in RenderInline
https://bugs.webkit.org/show_bug.cgi?id=85725

This patch extracts the common part of culledInlineBoundingBox() /
culledInlineAbsoluteRects() / culledInlineAbsoluteQuads() to become a
template function generateCulledLineBoxRects(). The template function
accepts a new parameter, GeneratorContext functor, which will be
invoked everytime a new line box rect has been generated. The generated
rect will be in local coordinate. The functor will be responsible for
appropriate transformation, then appending to vector or union with
existing bounding box.

Patch by Tien-Ren Chen trc...@chromium.org on 2012-05-10
Reviewed by Eric Seidel.

No new tests. No change in behavior.

* rendering/RenderInline.cpp:
(WebCore):
(WebCore::RenderInline::generateLineBoxRects):
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
* rendering/RenderInline.h:
(RenderInline):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderInline.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116717 => 116718)

--- trunk/Source/WebCore/ChangeLog	2012-05-11 02:06:11 UTC (rev 116717)
+++ trunk/Source/WebCore/ChangeLog	2012-05-11 02:08:06 UTC (rev 116718)
@@ -1,3 +1,33 @@
+2012-05-10  Tien-Ren Chen  trc...@chromium.org
+
+Eliminate duplicated code for culled line box in RenderInline
+https://bugs.webkit.org/show_bug.cgi?id=85725
+
+This patch extracts the common part of culledInlineBoundingBox() /
+culledInlineAbsoluteRects() / culledInlineAbsoluteQuads() to become a
+template function generateCulledLineBoxRects(). The template function
+accepts a new parameter, GeneratorContext functor, which will be
+invoked everytime a new line box rect has been generated. The generated
+rect will be in local coordinate. The functor will be responsible for
+appropriate transformation, then appending to vector or union with
+existing bounding box.
+
+Reviewed by Eric Seidel.
+
+No new tests. No change in behavior.
+
+* rendering/RenderInline.cpp:
+(WebCore):
+(WebCore::RenderInline::generateLineBoxRects):
+(WebCore::RenderInline::generateCulledLineBoxRects):
+(WebCore::RenderInline::absoluteRects):
+(WebCore::RenderInline::absoluteQuads):
+(WebCore::RenderInline::linesBoundingBox):
+(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
+(WebCore::RenderInline::addFocusRingRects):
+* rendering/RenderInline.h:
+(RenderInline):
+
 2012-05-10  Abhishek Arya  infe...@chromium.org
 
 Crash in swapInNodePreservingAttributesAndChildren.


Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (116717 => 116718)

--- trunk/Source/WebCore/rendering/RenderInline.cpp	2012-05-11 02:06:11 UTC (rev 116717)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp	2012-05-11 02:08:06 UTC (rev 116718)
@@ -505,33 +505,28 @@
 m_lineBoxes.paint(this, paintInfo, paintOffset);
 }
 
-void RenderInline::absoluteRects(VectorIntRect rects, const LayoutPoint accumulatedOffset) const
+templatetypename GeneratorContext
+void RenderInline::generateLineBoxRects(GeneratorContext yield) const
 {
 if (!alwaysCreateLineBoxes())
-culledInlineAbsoluteRects(this, rects, toLayoutSize(accumulatedOffset));
+generateCulledLineBoxRects(yield, this);
 else if (InlineFlowBox* curr = firstLineBox()) {
 for (; curr; curr = curr-nextLineBox())
-rects.append(enclosingIntRect(FloatRect(accumulatedOffset + curr-topLeft(), curr-size(;
+yield(FloatRect(curr-topLeft(), curr-size()));
 } else
-rects.append(IntRect(roundedIntPoint(accumulatedOffset), IntSize()));
-
-if (continuation()) {
-if (continuation()-isBox()) {
-RenderBox* box = toRenderBox(continuation());
-continuation()-absoluteRects(rects, toLayoutPoint(accumulatedOffset - containingBlock()-location() + box-size()));
-} else
-continuation()-absoluteRects(rects, toLayoutPoint(accumulatedOffset - containingBlock()-location()));
-}
+yield(FloatRect());
 }
 
-void RenderInline::culledInlineAbsoluteRects(const RenderInline* container, VectorIntRect rects, const LayoutSize offset) const
+templatetypename GeneratorContext
+void RenderInline::generateCulledLineBoxRects(GeneratorContext yield, const RenderInline* container) const
 {
 if (!culledInlineFirstLineBox()) {
-

[webkit-changes] [116721] trunk/Source/WebCore

[tkent]

Title: [116721] trunk/Source/WebCore








Revision 116721
Author tk...@chromium.org
Date 2012-05-10 19:47:12 -0700 (Thu, 10 May 2012)


Log Message
[Chromium] attempt to build fix for Chromium-mac.
r116697 introduced an override of a system function. It's intentional
and WebCoreTextFieldCell should be in the whitelist.

* WebCore.gyp/WebCore.gyp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116720 => 116721)

--- trunk/Source/WebCore/ChangeLog	2012-05-11 02:34:11 UTC (rev 116720)
+++ trunk/Source/WebCore/ChangeLog	2012-05-11 02:47:12 UTC (rev 116721)
@@ -1,3 +1,11 @@
+2012-05-10  Kent Tamura  tk...@chromium.org
+
+[Chromium] attempt to build fix for Chromium-mac.
+r116697 introduced an override of a system function. It's intentional
+and WebCoreTextFieldCell should be in the whitelist.
+
+* WebCore.gyp/WebCore.gyp:
+
 2012-05-10  Anders Carlsson  ander...@apple.com
 
 PDF files won't scroll in Safari when using Adobe plug-in


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (116720 => 116721)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-05-11 02:34:11 UTC (rev 116720)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-05-11 02:47:12 UTC (rev 116721)
@@ -1363,7 +1363,7 @@
 'postbuild_name': 'Check Objective-C Rename',
 'variables': {
   'class_whitelist_regex':
-  'ChromiumWebCoreObjC|TCMVisibleView|RTCMFlippedView',
+  'ChromiumWebCoreObjC|TCMVisibleView|RTCMFlippedView|WebCoreTextFieldCell',
   'category_whitelist_regex':
   'TCMInterposing|ScrollAnimatorChromiumMacExt',
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116722] trunk/Source

[piman]

Title: [116722] trunk/Source








Revision 116722
Author pi...@chromium.org
Date 2012-05-10 20:07:08 -0700 (Thu, 10 May 2012)


Log Message
Sync with impl thread when removing references to external textures
https://bugs.webkit.org/show_bug.cgi?id=86054

We want to ensure the client side is safe to release textures, so we
sync with the impl thread when:
- we change the texture (and we had one)
- the layer is removed from the tree (and we had a texture)
- the layer is destroyed (and we had a texture)

Reviewed by James Robinson.

Test: TextureLayerChromiumTest.

* platform/graphics/chromium/TextureLayerChromium.cpp:
(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setLayerTreeHost):
(WebCore):
* platform/graphics/chromium/TextureLayerChromium.h:
(TextureLayerChromium):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TextureLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/TextureLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebKit/chromium/WebKit.gypi


Added Paths

trunk/Source/WebKit/chromium/tests/TextureLayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116721 => 116722)

--- trunk/Source/WebCore/ChangeLog	2012-05-11 02:47:12 UTC (rev 116721)
+++ trunk/Source/WebCore/ChangeLog	2012-05-11 03:07:08 UTC (rev 116722)
@@ -1,3 +1,26 @@
+2012-05-10  Antoine Labour  pi...@chromium.org
+
+Sync with impl thread when removing references to external textures
+https://bugs.webkit.org/show_bug.cgi?id=86054
+
+We want to ensure the client side is safe to release textures, so we
+sync with the impl thread when:
+- we change the texture (and we had one)
+- the layer is removed from the tree (and we had a texture)
+- the layer is destroyed (and we had a texture)
+
+Reviewed by James Robinson.
+
+Test: TextureLayerChromiumTest.
+
+* platform/graphics/chromium/TextureLayerChromium.cpp:
+(WebCore::TextureLayerChromium::~TextureLayerChromium):
+(WebCore::TextureLayerChromium::setTextureId):
+(WebCore::TextureLayerChromium::setLayerTreeHost):
+(WebCore):
+* platform/graphics/chromium/TextureLayerChromium.h:
+(TextureLayerChromium):
+
 2012-05-10  Kent Tamura  tk...@chromium.org
 
 [Chromium] attempt to build fix for Chromium-mac.


Modified: trunk/Source/WebCore/platform/graphics/chromium/TextureLayerChromium.cpp (116721 => 116722)

--- trunk/Source/WebCore/platform/graphics/chromium/TextureLayerChromium.cpp	2012-05-11 02:47:12 UTC (rev 116721)
+++ trunk/Source/WebCore/platform/graphics/chromium/TextureLayerChromium.cpp	2012-05-11 03:07:08 UTC (rev 116722)
@@ -54,8 +54,12 @@
 
 TextureLayerChromium::~TextureLayerChromium()
 {
-if (m_rateLimitContext  m_client  layerTreeHost())
-layerTreeHost()-stopRateLimiter(m_client-context());
+if (layerTreeHost()) {
+if (m_textureId)
+layerTreeHost()-acquireLayerTextures();
+if (m_rateLimitContext  m_client)
+layerTreeHost()-stopRateLimiter(m_client-context());
+}
 }
 
 PassOwnPtrCCLayerImpl TextureLayerChromium::createCCLayerImpl()
@@ -91,6 +95,10 @@
 
 void TextureLayerChromium::setTextureId(unsigned id)
 {
+if (m_textureId == id)
+return;
+if (m_textureId  layerTreeHost())
+layerTreeHost()-acquireLayerTextures();
 m_textureId = id;
 setNeedsCommit();
 }
@@ -103,6 +111,13 @@
 layerTreeHost()-startRateLimiter(m_client-context());
 }
 
+void TextureLayerChromium::setLayerTreeHost(CCLayerTreeHost* host)
+{
+if (m_textureId  layerTreeHost()  host != layerTreeHost())
+layerTreeHost()-acquireLayerTextures();
+LayerChromium::setLayerTreeHost(host);
+}
+
 bool TextureLayerChromium::drawsContent() const
 {
 return (m_client || m_textureId)  !m_contextLost  LayerChromium::drawsContent();


Modified: trunk/Source/WebCore/platform/graphics/chromium/TextureLayerChromium.h (116721 => 116722)

--- trunk/Source/WebCore/platform/graphics/chromium/TextureLayerChromium.h	2012-05-11 02:47:12 UTC (rev 116721)
+++ trunk/Source/WebCore/platform/graphics/chromium/TextureLayerChromium.h	2012-05-11 03:07:08 UTC (rev 116722)
@@ -79,6 +79,7 @@
 
 virtual void setNeedsDisplayRect(const FloatRect) OVERRIDE;
 
+virtual void setLayerTreeHost(CCLayerTreeHost*) OVERRIDE;
 virtual bool drawsContent() const OVERRIDE;
 virtual void update(CCTextureUpdater, const CCOcclusionTracker*) OVERRIDE;
 virtual void pushPropertiesTo(CCLayerImpl*) OVERRIDE;


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h (116721 => 116722)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h	2012-05-11 02:47:12 UTC (rev 116721)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h	

[webkit-changes] [116724] trunk/Source/WebCore

[tkent]

Title: [116724] trunk/Source/WebCore








Revision 116724
Author tk...@chromium.org
Date 2012-05-10 21:00:34 -0700 (Thu, 10 May 2012)


Log Message
Unreviewed, rolling out r116715.
http://trac.webkit.org/changeset/116715
https://bugs.webkit.org/show_bug.cgi?id=86172

Broke http/tests/security/cross-frame-access-selection.html
(Requested by tkent on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-05-10

* dom/Document.cpp:
(WebCore):
(WebCore::Document::getSelection):
* dom/Document.h:
(Document):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::selection):
* dom/TreeScope.cpp:
(WebCore::TreeScope::~TreeScope):
* dom/TreeScope.h:
(WebCore):
(TreeScope):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::DOMSelection):
* page/DOMSelection.h:
(WebCore):
(WebCore::DOMSelection::create):
(DOMSelection):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore::DOMWindow::getSelection):
* page/DOMWindow.h:
(DOMWindow):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/dom/TreeScope.cpp
trunk/Source/WebCore/dom/TreeScope.h
trunk/Source/WebCore/page/DOMSelection.cpp
trunk/Source/WebCore/page/DOMSelection.h
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/DOMWindow.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (116723 => 116724)

--- trunk/Source/WebCore/ChangeLog	2012-05-11 03:28:46 UTC (rev 116723)
+++ trunk/Source/WebCore/ChangeLog	2012-05-11 04:00:34 UTC (rev 116724)
@@ -1,3 +1,37 @@
+2012-05-10  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r116715.
+http://trac.webkit.org/changeset/116715
+https://bugs.webkit.org/show_bug.cgi?id=86172
+
+Broke http/tests/security/cross-frame-access-selection.html
+(Requested by tkent on #webkit).
+
+* dom/Document.cpp:
+(WebCore):
+(WebCore::Document::getSelection):
+* dom/Document.h:
+(Document):
+* dom/ShadowRoot.cpp:
+(WebCore::ShadowRoot::selection):
+* dom/TreeScope.cpp:
+(WebCore::TreeScope::~TreeScope):
+* dom/TreeScope.h:
+(WebCore):
+(TreeScope):
+* page/DOMSelection.cpp:
+(WebCore::DOMSelection::DOMSelection):
+* page/DOMSelection.h:
+(WebCore):
+(WebCore::DOMSelection::create):
+(DOMSelection):
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::~DOMWindow):
+(WebCore::DOMWindow::clearDOMWindowProperties):
+(WebCore::DOMWindow::getSelection):
+* page/DOMWindow.h:
+(DOMWindow):
+
 2012-05-10  Hajime Morrita  morr...@google.com
 
 WebKit should support tab-size.


Modified: trunk/Source/WebCore/dom/Document.cpp (116723 => 116724)

--- trunk/Source/WebCore/dom/Document.cpp	2012-05-11 03:28:46 UTC (rev 116723)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-05-11 04:00:34 UTC (rev 116724)
@@ -46,7 +46,6 @@
 #include ContentSecurityPolicy.h
 #include CookieJar.h
 #include DOMImplementation.h
-#include DOMSelection.h
 #include DOMWindow.h
 #include DateComponents.h
 #include DeviceMotionController.h
@@ -5093,6 +5092,12 @@
 element-updateFocusAppearance(m_updateFocusAppearanceRestoresSelection);
 }
 
+// FF method for accessing the selection added for compatibility.
+DOMSelection* Document::getSelection() const
+{
+return frame() ? frame()-domWindow()-getSelection() : 0;
+}
+
 void Document::attachRange(Range* range)
 {
 ASSERT(!m_ranges.contains(range));


Modified: trunk/Source/WebCore/dom/Document.h (116723 => 116724)

--- trunk/Source/WebCore/dom/Document.h	2012-05-11 03:28:46 UTC (rev 116723)
+++ trunk/Source/WebCore/dom/Document.h	2012-05-11 04:00:34 UTC (rev 116724)
@@ -969,6 +969,9 @@
 void updateFocusAppearanceSoon(bool restorePreviousSelection);
 void cancelFocusAppearanceUpdate();
 
+// FF method for accessing the selection added for compatibility.
+DOMSelection* getSelection() const;
+
 // Extension for manipulating canvas drawing contexts for use in CSS
 CanvasRenderingContext* getCSSCanvasContext(const String type, const String name, int width, int height);
 HTMLCanvasElement* getCSSCanvasElement(const String name);


Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (116723 => 116724)

--- trunk/Source/WebCore/dom/ShadowRoot.cpp	2012-05-11 03:28:46 UTC (rev 116723)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp	2012-05-11 04:00:34 UTC (rev 116724)
@@ -151,8 +151,8 @@
 
 DOMSelection* ShadowRoot::selection()
 {
-if (document())
-return document()-getSelection();
+if (document()  document()-domWindow())
+return document()-domWindow()-getSelection();
 return 0;
 }
 


Modified: trunk/Source/WebCore/dom/TreeScope.cpp (116723 => 116724)

--- trunk/Source/WebCore/dom/TreeScope.cpp	2012-05-11 03:28:46 UTC (rev 

[webkit-changes] [116726] trunk

[commit-queue]

Title: [116726] trunk








Revision 116726
Author commit-qu...@webkit.org
Date 2012-05-10 21:16:04 -0700 (Thu, 10 May 2012)


Log Message
[EFL][DRT] Editor doesn't cancel composition as change of value
https://bugs.webkit.org/show_bug.cgi?id=85122

Patch by Kangil Han kangil@samsung.com on 2012-05-10
Reviewed by Martin Robinson.

IME composition should be cancelled when the value of input element is changed programmatically.
However, EFL port doesn't cancel as change of value.
Therefore, this patch will fix the bug.

Source/WebKit/efl:

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):

LayoutTests:

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (116725 => 116726)

--- trunk/LayoutTests/ChangeLog	2012-05-11 04:14:04 UTC (rev 116725)
+++ trunk/LayoutTests/ChangeLog	2012-05-11 04:16:04 UTC (rev 116726)
@@ -1,3 +1,16 @@
+2012-05-10  Kangil Han  kangil@samsung.com
+
+[EFL][DRT] Editor doesn't cancel composition as change of value
+https://bugs.webkit.org/show_bug.cgi?id=85122
+
+Reviewed by Martin Robinson.
+
+IME composition should be cancelled when the value of input element is changed programmatically.
+However, EFL port doesn't cancel as change of value.
+Therefore, this patch will fix the bug.
+
+* platform/efl/Skipped:
+
 2012-05-10  Noel Gordon  noel.gor...@gmail.com
 
 [chromium] Rebaseline compositing/geometry/horizontal-scroll-composited.html after r107389


Modified: trunk/LayoutTests/platform/efl/Skipped (116725 => 116726)

--- trunk/LayoutTests/platform/efl/Skipped	2012-05-11 04:14:04 UTC (rev 116725)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-05-11 04:16:04 UTC (rev 116726)
@@ -204,10 +204,6 @@
 editing/input/password-echo-passnode.html
 editing/input/password-echo-passnode2.html
 
-# EFL's editor doesn't cancel composition as change of value
-# https://bugs.webkit.org/show_bug.cgi?id=85122
-editing/input/setting-input-value-cancel-ime-composition.html
-
 # EFL's textarea and textfield doesn't handle whitespace style
 # https://bugs.webkit.org/show_bug.cgi?id=85123
 fast/forms/cursor-at-editable-content-boundary.html


Modified: trunk/Source/WebKit/efl/ChangeLog (116725 => 116726)

--- trunk/Source/WebKit/efl/ChangeLog	2012-05-11 04:14:04 UTC (rev 116725)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-05-11 04:16:04 UTC (rev 116726)
@@ -1,3 +1,17 @@
+2012-05-10  Kangil Han  kangil@samsung.com
+
+[EFL][DRT] Editor doesn't cancel composition as change of value
+https://bugs.webkit.org/show_bug.cgi?id=85122
+
+Reviewed by Martin Robinson.
+
+IME composition should be cancelled when the value of input element is changed programmatically.
+However, EFL port doesn't cancel as change of value.
+Therefore, this patch will fix the bug.
+
+* WebCoreSupport/EditorClientEfl.cpp:
+(WebCore::EditorClientEfl::respondToChangedSelection):
+
 2012-05-10  Dominik Röttsches  dominik.rottsc...@intel.com
 
 [EFL][DRT] ewk_view_paint_contents may trigger assertion failure


Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp (116725 => 116726)

--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp	2012-05-11 04:14:04 UTC (rev 116725)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp	2012-05-11 04:16:04 UTC (rev 116726)
@@ -144,6 +144,15 @@
 
 Evas_Object* webFrame = EWKPrivate::kitFrame(coreFrame);
 ewk_frame_editor_client_selection_changed(webFrame);
+
+if (!coreFrame-editor()-hasComposition() || coreFrame-editor()-ignoreCompositionSelectionChange())
+return;
+
+unsigned start;
+unsigned end;
+
+if (!coreFrame-editor()-getCompositionSelection(start, end))
+coreFrame-editor()-cancelComposition();
 }
 
 void EditorClientEfl::didEndEditing()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116727] trunk/Source

[commit-queue]

Title: [116727] trunk/Source








Revision 116727
Author commit-qu...@webkit.org
Date 2012-05-10 21:27:19 -0700 (Thu, 10 May 2012)


Log Message
split MediaPlayer::enterFullscreen into 2 seperate functions
https://bugs.webkit.org/show_bug.cgi?id=86052

Patch by Min Qin qin...@google.com on 2012-05-10
Reviewed by Benjamin Poulain.

Source/WebCore:

It is confusing that enterFullscreen returns a boolean while exitFullscreen does
not do the same. And ios does not need the return value.
So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
function for android.
No tests as there are no behavior change, just refactoring.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::enterFullscreen):
(WebCore):
(WebCore::MediaPlayer::canEnterFullscreen):
* platform/graphics/MediaPlayer.h:
(MediaPlayer):
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::canEnterFullscreen):

Source/WebKit/chromium:

It is confusing that enterFullscreen returns a boolean while exitFullscreen does
not do the same. And ios does not need the return value.
So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
function for android.
No behavior change, just refactoring.

* public/WebMediaPlayer.h:
(WebMediaPlayer):
(WebKit::WebMediaPlayer::enterFullscreen):
(WebKit::WebMediaPlayer::canEnterFullscreen):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::exitFullscreen):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enterFullScreenForElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebMediaPlayer.h
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116726 => 116727)

--- trunk/Source/WebCore/ChangeLog	2012-05-11 04:16:04 UTC (rev 116726)
+++ trunk/Source/WebCore/ChangeLog	2012-05-11 04:27:19 UTC (rev 116727)
@@ -1,3 +1,27 @@
+2012-05-10  Min Qin  qin...@google.com
+
+split MediaPlayer::enterFullscreen into 2 seperate functions
+https://bugs.webkit.org/show_bug.cgi?id=86052
+
+Reviewed by Benjamin Poulain.
+
+It is confusing that enterFullscreen returns a boolean while exitFullscreen does
+not do the same. And ios does not need the return value.
+So remove the return value on enterFullscreen and make a seperate canEnterFullscreen()
+function for android.
+No tests as there are no behavior change, just refactoring.
+
+* platform/graphics/MediaPlayer.cpp:
+(WebCore::MediaPlayer::enterFullscreen):
+(WebCore):
+(WebCore::MediaPlayer::canEnterFullscreen):
+* platform/graphics/MediaPlayer.h:
+(MediaPlayer):
+* platform/graphics/MediaPlayerPrivate.h:
+(WebCore::MediaPlayerPrivateInterface::enterFullscreen):
+(MediaPlayerPrivateInterface):
+(WebCore::MediaPlayerPrivateInterface::canEnterFullscreen):
+
 2012-05-10  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r116715.


Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp (116726 => 116727)

--- trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp	2012-05-11 04:16:04 UTC (rev 116726)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp	2012-05-11 04:27:19 UTC (rev 116727)
@@ -770,9 +770,9 @@
 #endif
 
 #if ENABLE(PLUGIN_PROXY_FOR_VIDEO) || USE(NATIVE_FULLSCREEN_VIDEO)
-bool MediaPlayer::enterFullscreen() const
+void MediaPlayer::enterFullscreen()
 {
-return m_private-enterFullscreen();
+m_private-enterFullscreen();
 }
 
 void MediaPlayer::exitFullscreen()
@@ -781,6 +781,13 @@
 }
 #endif
 
+#if USE(NATIVE_FULLSCREEN_VIDEO)
+bool MediaPlayer::canEnterFullscreen() const
+{
+return m_private-canEnterFullscreen();
+}
+#endif
+
 #if USE(ACCELERATED_COMPOSITING)
 void MediaPlayer::acceleratedRenderingStateChanged()
 {


Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.h (116726 => 116727)

--- trunk/Source/WebCore/platform/graphics/MediaPlayer.h	2012-05-11 04:16:04 UTC (rev 116726)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.h	2012-05-11 04:27:19 UTC (rev 116727)
@@ -327,10 +327,14 @@
 #endif
 
 #if ENABLE(PLUGIN_PROXY_FOR_VIDEO) || USE(NATIVE_FULLSCREEN_VIDEO)
-bool enterFullscreen() const;
+void enterFullscreen();
 void exitFullscreen();
 #endif
 
+#if USE(NATIVE_FULLSCREEN_VIDEO)
+bool canEnterFullscreen() const;

[webkit-changes] [116728] trunk/LayoutTests

[tkent]

Title: [116728] trunk/LayoutTests








Revision 116728
Author tk...@chromium.org
Date 2012-05-10 21:51:59 -0700 (Thu, 10 May 2012)


Log Message
[Chromium] Test expectation update

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116727 => 116728)

--- trunk/LayoutTests/ChangeLog	2012-05-11 04:27:19 UTC (rev 116727)
+++ trunk/LayoutTests/ChangeLog	2012-05-11 04:51:59 UTC (rev 116728)
@@ -1,3 +1,9 @@
+2012-05-10  Kent Tamura  tk...@chromium.org
+
+[Chromium] Test expectation update
+
+* platform/chromium/test_expectations.txt:
+
 2012-05-10  Kangil Han  kangil@samsung.com
 
 [EFL][DRT] Editor doesn't cancel composition as change of value


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (116727 => 116728)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-11 04:27:19 UTC (rev 116727)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-11 04:51:59 UTC (rev 116728)
@@ -3732,7 +3732,8 @@
 BUGWK83954 SLOW : editing/selection/select-across-readonly-input-3.html = TEXT
 BUGWK83954 SLOW : editing/selection/select-across-readonly-input-4.html = TEXT
 BUGWK83954 SLOW : editing/selection/select-across-readonly-input-5.html = TEXT
-BUGWK83954 : fast/block/float/032.html = TEXT
+BUGWK83954 LINUX WIN : fast/block/float/032.html = TEXT
+BUGWK83954 MAC : fast/block/float/032.html = IMAGE+TEXT
 BUGWK83954 : fast/block/float/033.html = TEXT
 BUGWK83954 : fast/block/float/avoidance-rtl.html = TEXT
 BUGWK83954 : fast/block/float/float-not-removed-from-next-sibling3.html = TEXT
@@ -3767,7 +3768,8 @@
 BUGWK83954 : fast/forms/fieldset-align.html = TEXT
 BUGWK83954 : fast/forms/floating-textfield-relayout.html = TEXT
 BUGWK83954 : fast/forms/input-align.html = TEXT
-BUGWK83954 : fast/forms/input-appearance-bkcolor.html = TEXT
+BUGWK83954 LINUX WIN : fast/forms/input-appearance-bkcolor.html = TEXT
+BUGWK83954 MAC : fast/forms/input-appearance-bkcolor.html = FAIL
 BUGWK83954 : fast/forms/input-appearance-default-bkcolor.html = TEXT
 BUGWK83954 : fast/forms/input-appearance-disabled.html = TEXT
 BUGWK83954 : fast/forms/input-appearance-focus.html = TEXT
@@ -3803,7 +3805,8 @@
 BUGWK83954 : fast/forms/search-vertical-alignment.html = TEXT
 BUGWK83954 : fast/forms/searchfield-heights.html = TEXT
 BUGWK83954 : fast/forms/tabbing-input-iframe.html = TEXT
-BUGWK83954 : fast/forms/text-style-color.html = TEXT
+BUGWK83954 LINUX WIN : fast/forms/text-style-color.html = TEXT
+BUGWK83954 MAC : fast/forms/text-style-color.html = IMAGE+TEXT
 BUGWK83954 : fast/forms/textfield-focus-ring.html = TEXT
 BUGWK83954 : fast/forms/validation-message-appearance.html = TEXT
 BUGWK83954 : fast/forms/visual-hebrew-text-field.html = TEXT
@@ -3849,7 +3852,8 @@
 BUGWK83954 : tables/mozilla/bugs/bug51037.html = TEXT
 BUGWK83954 : tables/mozilla/bugs/bug55545.html = TEXT
 BUGWK83954 : tables/mozilla/bugs/bug7342.html = TEXT
-BUGWK83954 : tables/mozilla/bugs/bug99948.html = TEXT
+BUGWK83954 LINUX WIN : tables/mozilla/bugs/bug99948.html = TEXT
+BUGWK83954 MAC : tables/mozilla/bugs/bug99948.html = IMAGE+TEXT
 BUGWK83954 : tables/mozilla/dom/tableDom.html = TEXT
 BUGWK83954 : tables/mozilla/other/move_row.html = TEXT
 BUGWK83954 : tables/mozilla_expected_failures/bugs/bug106966.html = TEXT
@@ -3873,7 +3877,8 @@
 BUGWK83954 WIN LINUX : fast/clip/012.html = TEXT
 BUGWK83954 : fast/forms/input-text-double-click.html = TEXT
 BUGWK83954 : http/tests/navigation/_javascript_link-frames.html = TEXT
-BUGWK83954 : fast/forms/date/date-appearance.html = TEXT
+BUGWK83954 LINUX WIN : fast/forms/date/date-appearance.html = TEXT
+BUGWK83954 MAC : fast/forms/date/date-appearance.html = IMAGE+TEXT
 
 BUGNOEL : compositing/geometry/vertical-scroll-composited.html = IMAGE
 BUGNOEL : fast/backgrounds/size/backgroundSize17.html = IMAGE
@@ -3886,7 +3891,7 @@
 BUGNOEL : fast/backgrounds/size/contain-and-cover.html = IMAGE
 BUGNOEL : fast/block/float/014.html = IMAGE
 BUGNOEL : fast/css/line-height-determined-by-primary-font.html = IMAGE
-BUGNOEL : fast/images/color-jpeg-with-color-profile.html = IMAGE
+BUGNOEL MAC : fast/images/color-jpeg-with-color-profile.html = IMAGE
 BUGNOEL : fast/images/gray-scale-jpeg-with-color-profile.html = IMAGE
 BUGNOEL : fast/images/image-css3-content-data.html = IMAGE
 BUGNOEL : fast/images/rgb-jpeg-with-adobe-marker-only.html = IMAGE
@@ -4032,6 +4037,25 @@
 // Requires ENABLE(MEDIA_CAPTURE)
 BUGWK85958 : fast/forms/file/file-input-capture.html = TEXT
 
+// Need rebaseline
+BUGTKENT : svg/css/getComputedStyle-basic.xhtml = TEXT
+BUGTKENT : fast/css/getComputedStyle/computed-style-without-renderer.html = TEXT
+BUGTKENT : fast/css/getComputedStyle/computed-style.html = TEXT
+BUGTKENT MAC : css3/selectors3/html/css3-modsel-23.html = IMAGE
+BUGTKENT MAC : css3/selectors3/html/css3-modsel-24.html = IMAGE
+BUGTKENT MAC :