[webkit-changes] [119064] trunk/Source/WebCore
Title: [119064] trunk/Source/WebCore
Revision 119064
Author yo...@chromium.org
Date 2012-05-30 23:58:10 -0700 (Wed, 30 May 2012)
Log Message
Build fix for Linon/SnowLeopard after r119062
* platform/Decimal.cpp:
(WebCore::Decimal::Decimal):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Decimal.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (119063 => 119064)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 06:46:16 UTC (rev 119063)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 06:58:10 UTC (rev 119064)
@@ -1,5 +1,12 @@
2012-05-30 Yoshifumi Inoue
+Build fix for Linon/SnowLeopard after r119062
+
+* platform/Decimal.cpp:
+(WebCore::Decimal::Decimal):
+
+2012-05-30 Yoshifumi Inoue
+
[Platform] Introduce Decimal class for Number/Range input type.
https://bugs.webkit.org/show_bug.cgi?id=87360
Modified: trunk/Source/WebCore/platform/Decimal.cpp (119063 => 119064)
--- trunk/Source/WebCore/platform/Decimal.cpp 2012-05-31 06:46:16 UTC (rev 119063)
+++ trunk/Source/WebCore/platform/Decimal.cpp 2012-05-31 06:58:10 UTC (rev 119064)
@@ -278,7 +278,7 @@
}
Decimal::Decimal(int32_t i32)
-: m_data(i32 < 0 ? Negative : Positive, 0, i32 < 0 ? static_cast(-i32) : i32)
+: m_data(i32 < 0 ? Negative : Positive, 0, static_cast(i32 < 0 ? -i32 : i32))
{
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119063] trunk/Source
Title: [119063] trunk/Source
Revision 119063
Author commit-qu...@webkit.org
Date 2012-05-30 23:46:16 -0700 (Wed, 30 May 2012)
Log Message
[GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
https://bugs.webkit.org/show_bug.cgi?id=87756
Patch by Sudarsana Nagineni on 2012-05-30
Reviewed by Carlos Garcia Campos.
Source/WebKit/gtk:
Fixed a memory leak in drag and drop by using adoptRef instead
of just getting a new reference of targetList.
* WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag):
Source/WebKit2:
Fixed memory leaks in drag and drop by using adoptRef instead
of just getting new references.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseStartDrag):
Modified Paths
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (119062 => 119063)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-05-31 06:36:42 UTC (rev 119062)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-05-31 06:46:16 UTC (rev 119063)
@@ -1,3 +1,16 @@
+2012-05-30 Sudarsana Nagineni
+
+[GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
+https://bugs.webkit.org/show_bug.cgi?id=87756
+
+Reviewed by Carlos Garcia Campos.
+
+Fixed a memory leak in drag and drop by using adoptRef instead
+of just getting a new reference of targetList.
+
+* WebCoreSupport/DragClientGtk.cpp:
+(WebKit::DragClient::startDrag):
+
2012-05-25 Jesus Sanchez-Palencia
WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp (119062 => 119063)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp 2012-05-31 06:36:42 UTC (rev 119062)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp 2012-05-31 06:46:16 UTC (rev 119063)
@@ -79,7 +79,7 @@
WebKitWebView* webView = webkit_web_frame_get_web_view(kit(frame));
RefPtr dataObject = clipboardGtk->dataObject();
-GRefPtr targetList(PasteboardHelper::defaultPasteboardHelper()->targetListForDataObject(dataObject.get()));
+GRefPtr targetList = adoptGRef(PasteboardHelper::defaultPasteboardHelper()->targetListForDataObject(dataObject.get()));
GOwnPtr currentEvent(gtk_get_current_event());
GdkDragContext* context = gtk_drag_begin(GTK_WIDGET(m_webView), targetList.get(), dragOperationToGdkDragActions(clipboard->sourceOperation()), 1, currentEvent.get());
Modified: trunk/Source/WebKit2/ChangeLog (119062 => 119063)
--- trunk/Source/WebKit2/ChangeLog 2012-05-31 06:36:42 UTC (rev 119062)
+++ trunk/Source/WebKit2/ChangeLog 2012-05-31 06:46:16 UTC (rev 119063)
@@ -1,3 +1,16 @@
+2012-05-30 Sudarsana Nagineni
+
+[GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
+https://bugs.webkit.org/show_bug.cgi?id=87756
+
+Reviewed by Carlos Garcia Campos.
+
+Fixed memory leaks in drag and drop by using adoptRef instead
+of just getting new references.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseStartDrag):
+
2012-05-30 Luiz Agostini
[Qt] handled touchmove events should not cancel tap gesture recognition
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (119062 => 119063)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2012-05-31 06:36:42 UTC (rev 119062)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2012-05-31 06:46:16 UTC (rev 119063)
@@ -675,8 +675,8 @@
{
WebKitWebViewBasePrivate* priv = webViewBase->priv;
-RefPtr dataObject(dragData.platformData());
-GRefPtr targetList(PasteboardHelper::defaultPasteboardHelper()->targetListForDataObject(dataObject.get()));
+RefPtr dataObject = adoptRef(dragData.platformData());
+GRefPtr targetList = adoptGRef(PasteboardHelper::defaultPasteboardHelper()->targetListForDataObject(dataObject.get()));
GOwnPtr currentEvent(gtk_get_current_event());
GdkDragContext* context = gtk_drag_begin(GTK_WIDGET(webViewBase),
targetList.get(),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119061] trunk/Source/WebCore
Title: [119061] trunk/Source/WebCore
Revision 119061
Author par...@webkit.org
Date 2012-05-30 23:30:03 -0700 (Wed, 30 May 2012)
Log Message
Build fix for WinCE after r116723.
* platform/graphics/wince/FontWinCE.cpp:
(WebCore::TextRunComponent::TextRunComponent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/wince/FontWinCE.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (119060 => 119061)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 06:23:53 UTC (rev 119060)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 06:30:03 UTC (rev 119061)
@@ -1,3 +1,10 @@
+2012-05-30 Patrick Gansterer
+
+Build fix for WinCE after r116723.
+
+* platform/graphics/wince/FontWinCE.cpp:
+(WebCore::TextRunComponent::TextRunComponent):
+
2012-05-30 Kentaro Hara
Implement CSSParser::determineNameInNamespace() as a helper function for CSSGrammar.y
Modified: trunk/Source/WebCore/platform/graphics/wince/FontWinCE.cpp (119060 => 119061)
--- trunk/Source/WebCore/platform/graphics/wince/FontWinCE.cpp 2012-05-31 06:23:53 UTC (rev 119060)
+++ trunk/Source/WebCore/platform/graphics/wince/FontWinCE.cpp 2012-05-31 06:30:03 UTC (rev 119061)
@@ -85,13 +85,15 @@
};
TextRunComponent::TextRunComponent(const UChar *start, int length, const TextRun& parentTextRun, const Font &font, int o)
-: m_textRun(start, length, parentTextRun.allowTabs(), 0, 0
+: m_textRun(start, length, 0, 0
, parentTextRun.allowsTrailingExpansion() ? TextRun::AllowTrailingExpansion : TextRun::ForbidTrailingExpansion
, parentTextRun.direction()
, parentTextRun.directionalOverride())
, m_offset(o)
, m_spaces(0)
{
+m_textRun.setTabSize(parentTextRun.allowTabs(), parentTextRun.tabSize());
+
WidthIterator it(&font, m_textRun);
it.advance(m_textRun.length(), 0);
m_width = it.m_runWidthSoFar;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119060] trunk/Source/WebCore
Title: [119060] trunk/Source/WebCore
Revision 119060
Author hara...@chromium.org
Date 2012-05-30 23:23:53 -0700 (Wed, 30 May 2012)
Log Message
Implement CSSParser::determineNameInNamespace() as a helper function for CSSGrammar.y
https://bugs.webkit.org/show_bug.cgi?id=87799
Reviewed by Darin Adler.
As pointed out by darin@ in https://bugs.webkit.org/show_bug.cgi?id=87627#c12,
we should avoid repeating the following code in CSSGrammar.y:
if (p->m_styleSheet)
$$->setTag(QualifiedName(namespacePrefix, $2, p->m_styleSheet->determineNamespace(namespacePrefix)));
else
$$->setTag(QualifiedName(namespacePrefix, $2, p->m_defaultNamespace));
This patch implements CSSParser::determineNameInNamespace() as a helper function
and replaces the above code.
Tests: fast/dom/SelectorAPI/*. No change in test results.
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::determineNameInNamespace):
(WebCore):
* css/CSSParser.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParser.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (119059 => 119060)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 06:15:17 UTC (rev 119059)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 06:23:53 UTC (rev 119060)
@@ -1,3 +1,29 @@
+2012-05-30 Kentaro Hara
+
+Implement CSSParser::determineNameInNamespace() as a helper function for CSSGrammar.y
+https://bugs.webkit.org/show_bug.cgi?id=87799
+
+Reviewed by Darin Adler.
+
+As pointed out by darin@ in https://bugs.webkit.org/show_bug.cgi?id=87627#c12,
+we should avoid repeating the following code in CSSGrammar.y:
+
+if (p->m_styleSheet)
+$$->setTag(QualifiedName(namespacePrefix, $2, p->m_styleSheet->determineNamespace(namespacePrefix)));
+else
+$$->setTag(QualifiedName(namespacePrefix, $2, p->m_defaultNamespace));
+
+This patch implements CSSParser::determineNameInNamespace() as a helper function
+and replaces the above code.
+
+Tests: fast/dom/SelectorAPI/*. No change in test results.
+
+* css/CSSGrammar.y:
+* css/CSSParser.cpp:
+(WebCore::CSSParser::determineNameInNamespace):
+(WebCore):
+* css/CSSParser.h:
+
2012-05-30 Patrick Gansterer
Build fix for WinCE after r117697.
Modified: trunk/Source/WebCore/css/CSSGrammar.y (119059 => 119060)
--- trunk/Source/WebCore/css/CSSGrammar.y 2012-05-31 06:15:17 UTC (rev 119059)
+++ trunk/Source/WebCore/css/CSSGrammar.y 2012-05-31 06:23:53 UTC (rev 119060)
@@ -954,13 +954,9 @@
static_cast(parser)->updateSpecifiersWithElementName(nullAtom, starAtom, $$);
}
| namespace_selector element_name {
-AtomicString namespacePrefix = $1;
CSSParser* p = static_cast(parser);
$$ = p->createFloatingSelector();
-if (p->m_styleSheet)
-$$->setTag(QualifiedName(namespacePrefix, $2, p->m_styleSheet->determineNamespace(namespacePrefix)));
-else
-$$->setTag(QualifiedName(namespacePrefix, $2, p->m_defaultNamespace));
+$$->setTag(p->determineNameInNamespace($1, $2));
}
| namespace_selector element_name specifier_list {
$$ = $3;
@@ -1086,23 +1082,15 @@
$$->setValue($6);
}
| '[' maybe_space namespace_selector attr_name ']' {
-AtomicString namespacePrefix = $3;
CSSParser* p = static_cast(parser);
$$ = p->createFloatingSelector();
-if (p->m_styleSheet)
-$$->setAttribute(QualifiedName(namespacePrefix, $4, p->m_styleSheet->determineNamespace(namespacePrefix)));
-else
-$$->setAttribute(QualifiedName(namespacePrefix, $4, p->m_defaultNamespace));
+$$->setAttribute(p->determineNameInNamespace($3, $4));
$$->setMatch(CSSSelector::Set);
}
| '[' maybe_space namespace_selector attr_name match maybe_space ident_or_string maybe_space ']' {
-AtomicString namespacePrefix = $3;
CSSParser* p = static_cast(parser);
$$ = p->createFloatingSelector();
-if (p->m_styleSheet)
-$$->setAttribute(QualifiedName(namespacePrefix, $4, p->m_styleSheet->determineNamespace(namespacePrefix)));
-else
-$$->setAttribute(QualifiedName(namespacePrefix, $4, p->m_defaultNamespace));
+$$->setAttribute(p->determineNameInNamespace($3, $4));
$$->setMatch((CSSSelector::Match)$5);
$$->setValue($7);
}
Modified: trunk/Source/WebCore/css/CSSParser.cpp (119059 => 119060)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-05-31 06:15:17 UTC (rev 119059)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-05-31 06:23:53 UTC (rev 119060)
@@ -9192,6 +9192,13 @@
m_defaultNamespace = uri;
}
+QualifiedName CSSParser::determineNameInNamespace(const AtomicString& prefix, const AtomicString& localNam
[webkit-changes] [119059] trunk/Source/WebCore
Title: [119059] trunk/Source/WebCore Revision 119059 Author par...@webkit.org Date 2012-05-30 23:15:17 -0700 (Wed, 30 May 2012) Log Message Build fix for WinCE after r117697. * page/wince/FrameWinCE.cpp: (WebCore::computePageRectsForFrame): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/wince/FrameWinCE.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (119058 => 119059) --- trunk/Source/WebCore/ChangeLog 2012-05-31 06:05:30 UTC (rev 119058) +++ trunk/Source/WebCore/ChangeLog 2012-05-31 06:15:17 UTC (rev 119059) @@ -1,3 +1,10 @@ +2012-05-30 Patrick Gansterer + +Build fix for WinCE after r117697. + +* page/wince/FrameWinCE.cpp: +(WebCore::computePageRectsForFrame): + 2012-05-30 Shawn Singh [chromium] Fix min/max bounds error in CCMathUtil.cpp Modified: trunk/Source/WebCore/page/wince/FrameWinCE.cpp (119058 => 119059) --- trunk/Source/WebCore/page/wince/FrameWinCE.cpp 2012-05-31 06:05:30 UTC (rev 119058) +++ trunk/Source/WebCore/page/wince/FrameWinCE.cpp 2012-05-31 06:15:17 UTC (rev 119059) @@ -76,7 +76,7 @@ float ratio = (float)printRect.height() / (float)printRect.width(); -float pageWidth = (float) root->maxXLayoutOverflow(); +float pageWidth = (float) root->layoutOverflowRect().maxX(); float pageHeight = pageWidth * ratio; outPageHeight = (int) pageHeight; // this is the height of the page adjusted by margins pageHeight -= (headerHeight + footerHeight); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119058] trunk/Source
Title: [119058] trunk/Source
Revision 119058
Author shawnsi...@chromium.org
Date 2012-05-30 23:05:30 -0700 (Wed, 30 May 2012)
Log Message
[chromium] Fix min/max bounds error in CCMathUtil.cpp
https://bugs.webkit.org/show_bug.cgi?id=87915
Reviewed by James Robinson.
Source/WebCore:
Two unit tests added to CCMathUtilTest:
CCMathUtilTest.verifyEnclosingClippedRectUsesCorrectInitialBounds
CCMathUtilTest.verifyEnclosingRectOfVerticesUsesCorrectInitialBounds
While computing bounds, the initial values for xmax and ymax are
intended to be set to -float_max. It turns out that
std::numeric_limits::min() actually returns the smallest
positive value close to zero, which is not what was intended. This
patch fixes the code to use -float_max instead, which is the
intended value.
* platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::computeEnclosingRectOfVertices):
(WebCore::CCMathUtil::computeEnclosingClippedRect):
(WebCore):
* platform/graphics/chromium/cc/CCMathUtil.h:
(WebCore::HomogeneousCoordinate::HomogeneousCoordinate):
(HomogeneousCoordinate):
(WebCore::HomogeneousCoordinate::shouldBeClipped):
(WebCore::HomogeneousCoordinate::cartesianPoint2d):
(WebCore):
(CCMathUtil):
Source/WebKit/chromium:
* tests/CCMathUtilTest.cpp:
(WebCore::TEST):
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCMathUtil.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCMathUtil.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCMathUtilTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (119057 => 119058)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 05:58:45 UTC (rev 119057)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 06:05:30 UTC (rev 119058)
@@ -1,3 +1,35 @@
+2012-05-30 Shawn Singh
+
+[chromium] Fix min/max bounds error in CCMathUtil.cpp
+https://bugs.webkit.org/show_bug.cgi?id=87915
+
+Reviewed by James Robinson.
+
+Two unit tests added to CCMathUtilTest:
+CCMathUtilTest.verifyEnclosingClippedRectUsesCorrectInitialBounds
+CCMathUtilTest.verifyEnclosingRectOfVerticesUsesCorrectInitialBounds
+
+While computing bounds, the initial values for xmax and ymax are
+intended to be set to -float_max. It turns out that
+std::numeric_limits::min() actually returns the smallest
+positive value close to zero, which is not what was intended. This
+patch fixes the code to use -float_max instead, which is the
+intended value.
+
+* platform/graphics/chromium/cc/CCMathUtil.cpp:
+(WebCore::CCMathUtil::mapClippedRect):
+(WebCore::CCMathUtil::projectClippedRect):
+(WebCore::CCMathUtil::computeEnclosingRectOfVertices):
+(WebCore::CCMathUtil::computeEnclosingClippedRect):
+(WebCore):
+* platform/graphics/chromium/cc/CCMathUtil.h:
+(WebCore::HomogeneousCoordinate::HomogeneousCoordinate):
+(HomogeneousCoordinate):
+(WebCore::HomogeneousCoordinate::shouldBeClipped):
+(WebCore::HomogeneousCoordinate::cartesianPoint2d):
+(WebCore):
+(CCMathUtil):
+
2012-05-30 Patrick Gansterer
Build fix for WinCE after r118568.
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCMathUtil.cpp (119057 => 119058)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCMathUtil.cpp 2012-05-31 05:58:45 UTC (rev 119057)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCMathUtil.cpp 2012-05-31 06:05:30 UTC (rev 119058)
@@ -33,37 +33,6 @@
namespace WebCore {
-struct HomogeneousCoordinate {
-HomogeneousCoordinate(double newX, double newY, double newZ, double newW)
-: x(newX)
-, y(newY)
-, z(newZ)
-, w(newW)
-{
-}
-
-bool shouldBeClipped() const
-{
-return w <= 0;
-}
-
-FloatPoint cartesianPoint2d() const
-{
-if (w == 1)
-return FloatPoint(x, y);
-
-// For now, because this code is used privately only by CCMathUtil, it should never be called when w == 0, and we do not yet need to handle that case.
-ASSERT(w);
-double invW = 1.0 / w;
-return FloatPoint(x * invW, y * invW);
-}
-
-double x;
-double y;
-double z;
-double w;
-};
-
static HomogeneousCoordinate projectPoint(const TransformationMatrix& transform, const FloatPoint& p)
{
// In this case, the layer we are trying to project onto is perpendicular to ray
@@ -138,55 +107,6 @@
ymax = std::max(p.y(), ymax);
}
-static FloatRect computeEnclosingRect(const HomogeneousCoordinate& h1, const HomogeneousCoordinate& h2, const HomogeneousCoordinate& h3, const HomogeneousCoordinate& h4)
-{
-// This function performs clipping as necessary and computes the enclosing 2d
-// FloatRect of the vertices. Doing these tw
[webkit-changes] [119057] trunk/Source/WebCore
Title: [119057] trunk/Source/WebCore Revision 119057 Author par...@webkit.org Date 2012-05-30 22:58:45 -0700 (Wed, 30 May 2012) Log Message Build fix for WinCE after r118568. * platform/text/wince/TextBreakIteratorWinCE.cpp: (WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/text/wince/TextBreakIteratorWinCE.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (119056 => 119057) --- trunk/Source/WebCore/ChangeLog 2012-05-31 05:54:27 UTC (rev 119056) +++ trunk/Source/WebCore/ChangeLog 2012-05-31 05:58:45 UTC (rev 119057) @@ -1,3 +1,10 @@ +2012-05-30 Patrick Gansterer + +Build fix for WinCE after r118568. + +* platform/text/wince/TextBreakIteratorWinCE.cpp: +(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): + 2012-05-30 Abhishek Arya Crash in ContainerNode::parserAddChild. Modified: trunk/Source/WebCore/platform/text/wince/TextBreakIteratorWinCE.cpp (119056 => 119057) --- trunk/Source/WebCore/platform/text/wince/TextBreakIteratorWinCE.cpp 2012-05-31 05:54:27 UTC (rev 119056) +++ trunk/Source/WebCore/platform/text/wince/TextBreakIteratorWinCE.cpp 2012-05-31 05:58:45 UTC (rev 119057) @@ -245,7 +245,7 @@ bool createdIterator = m_iterator && weakCompareAndSwap(reinterpret_cast(&nonSharedCharacterBreakIterator), m_iterator, 0); if (!createdIterator) m_iterator = new CharBreakIterator; -m_iterator.reset(string, length); +m_iterator->reset(buffer, length); } NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator() ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119055] trunk/Source/WebKit/chromium
Title: [119055] trunk/Source/WebKit/chromium
Revision 119055
Author fisch...@chromium.org
Date 2012-05-30 22:50:23 -0700 (Wed, 30 May 2012)
Log Message
Roll chromium DEPS from r139300 to r139542. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=87868
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (119054 => 119055)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-05-31 04:47:34 UTC (rev 119054)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-05-31 05:50:23 UTC (rev 119055)
@@ -1,3 +1,10 @@
+2012-05-30 Ami Fischman
+
+Roll chromium DEPS from r139300 to r139542. Unreviewed.
+https://bugs.webkit.org/show_bug.cgi?id=87868
+
+* DEPS:
+
2012-05-30 Mark Pilgrim
[Chromium] Call fileUtilities methods directly
Modified: trunk/Source/WebKit/chromium/DEPS (119054 => 119055)
--- trunk/Source/WebKit/chromium/DEPS 2012-05-31 04:47:34 UTC (rev 119054)
+++ trunk/Source/WebKit/chromium/DEPS 2012-05-31 05:50:23 UTC (rev 119055)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '139300'
+ 'chromium_rev': '139542'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119054] branches/safari-536-branch
Title: [119054] branches/safari-536-branch Revision 119054 Author lforsch...@apple.com Date 2012-05-30 21:47:34 -0700 (Wed, 30 May 2012) Log Message Merged r118956 -> Modified Paths branches/safari-536-branch/LayoutTests/ChangeLog branches/safari-536-branch/Source/_javascript_Core/ChangeLog branches/safari-536-branch/Source/_javascript_Core/dfg/DFGOperations.cpp branches/safari-536-branch/Source/_javascript_Core/llint/LLIntSlowPaths.cpp Added Paths branches/safari-536-branch/LayoutTests/fast/js/exception-propagate-from-dfg-to-llint-expected.txt branches/safari-536-branch/LayoutTests/fast/js/exception-propagate-from-dfg-to-llint.html branches/safari-536-branch/LayoutTests/fast/js/script-tests/exception-propagate-from-dfg-to-llint.js Diff Modified: branches/safari-536-branch/LayoutTests/ChangeLog (119053 => 119054) --- branches/safari-536-branch/LayoutTests/ChangeLog 2012-05-31 04:45:47 UTC (rev 119053) +++ branches/safari-536-branch/LayoutTests/ChangeLog 2012-05-31 04:47:34 UTC (rev 119054) @@ -1,5 +1,28 @@ 2012-05-30 Lucas Forschler +Merge 118956 + +2012-05-30 Oliver Hunt + +DFG does not correctly handle exceptions caught in the LLInt +https://bugs.webkit.org/show_bug.cgi?id=87885 + +Reviewed by Filip Pizlo. + +Pile of code to convince the DFG to throw an exception that ends up being caught +in the LLInt + +* fast/js/exception-propagate-from-dfg-to-llint-expected.txt: Added. +* fast/js/exception-propagate-from-dfg-to-llint.html: Added. +* fast/js/script-tests/exception-propagate-from-dfg-to-llint.js: Added. +(o.toString): +(h): +(g): +(f1): +(f2): + +2012-05-30 Lucas Forschler + Merge 2012-05-30 Lucas Forschler Copied: branches/safari-536-branch/LayoutTests/fast/js/exception-propagate-from-dfg-to-llint-expected.txt (from rev 118956, trunk/LayoutTests/fast/js/exception-propagate-from-dfg-to-llint-expected.txt) (0 => 119054) --- branches/safari-536-branch/LayoutTests/fast/js/exception-propagate-from-dfg-to-llint-expected.txt (rev 0) +++ branches/safari-536-branch/LayoutTests/fast/js/exception-propagate-from-dfg-to-llint-expected.txt 2012-05-31 04:47:34 UTC (rev 119054) @@ -0,0 +1,10 @@ +Ensures that we pass exceptions to the correct codeblock when throwing from the DFG to the LLInt. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS Caught exception in correct codeblock +PASS successfullyParsed is true + +TEST COMPLETE + Copied: branches/safari-536-branch/LayoutTests/fast/js/exception-propagate-from-dfg-to-llint.html (from rev 118956, trunk/LayoutTests/fast/js/exception-propagate-from-dfg-to-llint.html) (0 => 119054) --- branches/safari-536-branch/LayoutTests/fast/js/exception-propagate-from-dfg-to-llint.html (rev 0) +++ branches/safari-536-branch/LayoutTests/fast/js/exception-propagate-from-dfg-to-llint.html 2012-05-31 04:47:34 UTC (rev 119054) @@ -0,0 +1,10 @@ + + + +
[webkit-changes] [119053] branches/safari-536-branch/Source/WebKit2
Title: [119053] branches/safari-536-branch/Source/WebKit2
Revision 119053
Author lforsch...@apple.com
Date 2012-05-30 21:45:47 -0700 (Wed, 30 May 2012)
Log Message
Merged r118896 ->
Modified Paths
branches/safari-536-branch/Source/WebKit2/ChangeLog
branches/safari-536-branch/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm
Diff
Modified: branches/safari-536-branch/Source/WebKit2/ChangeLog (119052 => 119053)
--- branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 04:39:36 UTC (rev 119052)
+++ branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 04:45:47 UTC (rev 119053)
@@ -1,5 +1,26 @@
2012-05-30 Lucas Forschler
+Merge 118896
+
+2012-05-29 Jer Noble
+
+Noticeable delay taking an HTML5 trailer fullscreen.
+https://bugs.webkit.org/show_bug.cgi?id=87794
+
+Reviewed by Darin Adler.
+
+Work around a not-entirely understood delay when using the results of a CGWindowListCreateImage()
+call as the contents of a placeholder view. The backing of the resulting CGImageRef resides on
+the WindowServer, and drawing that image requires synchronous calls to the WindowServer process.
+By copying the image data, up front, into our own process, we can avoid those synchronous calls
+later and avoid the delay-causing drawing behavior.
+
+* UIProcess/mac/WKFullScreenWindowController.mm:
+(CGImageDeepCopy): Added a helper function which copies the image data into a new CGImage.
+(-[WKFullScreenWindowController enterFullScreen:]): Use the above.
+
+2012-05-30 Lucas Forschler
+
Merge 118615
2012-05-25 Maciej Stachowiak
Modified: branches/safari-536-branch/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (119052 => 119053)
--- branches/safari-536-branch/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm 2012-05-31 04:39:36 UTC (rev 119052)
+++ branches/safari-536-branch/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm 2012-05-31 04:45:47 UTC (rev 119053)
@@ -183,6 +183,28 @@
#pragma mark -
#pragma mark Exposed Interface
+static RetainPtr createImageProviderWithCopiedData(CGDataProviderRef sourceProvider)
+{
+RetainPtr data = ""
+return adoptCF(CGDataProviderCreateWithCFData(data.get()));
+}
+
+static RetainPtr createImageWithCopiedData(CGImageRef sourceImage)
+{
+size_t width = CGImageGetWidth(sourceImage);
+size_t height = CGImageGetHeight(sourceImage);
+size_t bitsPerComponent = CGImageGetBitsPerComponent(sourceImage);
+size_t bitsPerPixel = CGImageGetBitsPerPixel(sourceImage);
+size_t bytesPerRow = CGImageGetBytesPerRow(sourceImage);
+CGColorSpaceRef colorSpace = CGImageGetColorSpace(sourceImage);
+CGBitmapInfo bitmapInfo = CGImageGetBitmapInfo(sourceImage);
+RetainPtr provider = createImageProviderWithCopiedData(CGImageGetDataProvider(sourceImage));
+bool shouldInterpolate = CGImageGetShouldInterpolate(sourceImage);
+CGColorRenderingIntent intent = CGImageGetRenderingIntent(sourceImage);
+
+return adoptCF(CGImageCreate(width, height, bitsPerComponent, bitsPerPixel, bytesPerRow, colorSpace, bitmapInfo, provider.get(), 0, shouldInterpolate, intent));
+}
+
- (void)enterFullScreen:(NSScreen *)screen
{
if (_isFullScreen)
@@ -204,6 +226,11 @@
CGWindowID windowID = [[_webView window] windowNumber];
RetainPtr webViewContents(AdoptCF, CGWindowListCreateImage(NSRectToCGRect(webViewFrame), kCGWindowListOptionIncludingWindow, windowID, kCGWindowImageShouldBeOpaque));
+// Using the returned CGImage directly would result in calls to the WindowServer every time
+// the image was painted. Instead, copy the image data into our own process to eliminate that
+// future overhead.
+webViewContents = createImageWithCopiedData(webViewContents.get());
+
// Screen updates to be re-enabled in beganEnterFullScreenWithInitialFrame:finalFrame:
NSDisableScreenUpdates();
[[self window] setAutodisplay:NO];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119052] branches/safari-536-branch/Source/WebCore
Title: [119052] branches/safari-536-branch/Source/WebCore
Revision 119052
Author lforsch...@apple.com
Date 2012-05-30 21:39:36 -0700 (Wed, 30 May 2012)
Log Message
Merged r118883 ->
Modified Paths
branches/safari-536-branch/Source/WebCore/ChangeLog
branches/safari-536-branch/Source/WebCore/dom/SecurityContext.h
branches/safari-536-branch/Source/WebCore/html/HTMLIFrameElement.cpp
Diff
Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (119051 => 119052)
--- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 04:30:56 UTC (rev 119051)
+++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 04:39:36 UTC (rev 119052)
@@ -1,5 +1,32 @@
2012-05-30 Lucas Forschler
+Merge 118883
+
+2012-05-29 Eric Seidel
+
+Fix ENABLE_IFRAME_SEAMLESS to actually fully disable
+https://bugs.webkit.org/show_bug.cgi?id=87646
+
+Reviewed by Adam Barth.
+
+In the process of moving the seamless feature out of github and into bugs.webkit.org
+multiple versions of the shouldDisplaySeamlessly function got written
+(and moved from HTMLIFrameElement to Document), but only one of them was wrapped
+in ENABLE_IFRAME_SEAMLESS. HTMLIFrameElement was checking mayDisplaySeamlessly
+directly (as was my original design), which got around the ENABLE_IFRAME_SEAMLESS check.
+I've fixed this oversight, and the feature is now off when we tell it to be off.
+
+This is covered by many existing tests. I've verified locally that
+all tests fail when ENABLE_IFRAME_SEAMLESS is disabled instead of
+only some of them.
+
+* dom/SecurityContext.h:
+(SecurityContext):
+* html/HTMLIFrameElement.cpp:
+(WebCore::HTMLIFrameElement::shouldDisplaySeamlessly):
+
+2012-05-30 Lucas Forschler
+
Merge 118820
2012-05-29 John Sullivan
Modified: branches/safari-536-branch/Source/WebCore/dom/SecurityContext.h (119051 => 119052)
--- branches/safari-536-branch/Source/WebCore/dom/SecurityContext.h 2012-05-31 04:30:56 UTC (rev 119051)
+++ branches/safari-536-branch/Source/WebCore/dom/SecurityContext.h 2012-05-31 04:39:36 UTC (rev 119052)
@@ -67,8 +67,6 @@
static SandboxFlags parseSandboxPolicy(const String& policy);
-bool mayDisplaySeamlessWithParent() const { return m_mayDisplaySeamlessWithParent; }
-
protected:
SecurityContext();
~SecurityContext();
Modified: branches/safari-536-branch/Source/WebCore/html/HTMLIFrameElement.cpp (119051 => 119052)
--- branches/safari-536-branch/Source/WebCore/html/HTMLIFrameElement.cpp 2012-05-31 04:30:56 UTC (rev 119051)
+++ branches/safari-536-branch/Source/WebCore/html/HTMLIFrameElement.cpp 2012-05-31 04:39:36 UTC (rev 119052)
@@ -117,7 +117,7 @@
bool HTMLIFrameElement::shouldDisplaySeamlessly() const
{
-return contentDocument() && contentDocument()->mayDisplaySeamlessWithParent() && hasAttribute(seamlessAttr);
+return contentDocument() && contentDocument()->shouldDisplaySeamlesslyWithParent();
}
#if ENABLE(MICRODATA)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119051] branches/safari-536-branch
Title: [119051] branches/safari-536-branch
Revision 119051
Author lforsch...@apple.com
Date 2012-05-30 21:30:56 -0700 (Wed, 30 May 2012)
Log Message
Merge
Modified Paths
branches/safari-536-branch/LayoutTests/compositing/geometry/preserve-3d-switching-expected.txt
branches/safari-536-branch/LayoutTests/compositing/visibility/layer-visible-content-expected.txt
branches/safari-536-branch/Source/WebCore/rendering/RenderLayer.cpp
branches/safari-536-branch/Source/WebCore/rendering/RenderLayer.h
branches/safari-536-branch/Source/WebCore/rendering/RenderLayerBacking.cpp
branches/safari-536-branch/Source/WebCore/rendering/RenderLayerBacking.h
branches/safari-536-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp
branches/safari-536-branch/Source/WebCore/rendering/RenderLayerCompositor.h
branches/safari-536-branch/Source/WebCore/rendering/RenderObject.cpp
branches/safari-536-branch/Source/WebCore/rendering/RenderTreeAsText.cpp
branches/safari-536-branch/Source/WebCore/rendering/RenderView.cpp
Removed Paths
branches/safari-536-branch/LayoutTests/compositing/backing/
branches/safari-536-branch/LayoutTests/compositing/visibility/layer-visible-content-expected.png
Diff
Modified: branches/safari-536-branch/LayoutTests/compositing/geometry/preserve-3d-switching-expected.txt (119050 => 119051)
--- branches/safari-536-branch/LayoutTests/compositing/geometry/preserve-3d-switching-expected.txt 2012-05-31 04:25:01 UTC (rev 119050)
+++ branches/safari-536-branch/LayoutTests/compositing/geometry/preserve-3d-switching-expected.txt 2012-05-31 04:30:56 UTC (rev 119051)
@@ -10,6 +10,7 @@
(GraphicsLayer
(position 108.00 73.00)
(bounds 304.00 304.00)
+ (drawsContent 1)
(childrenTransform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 -0.00] [0.00 0.00 0.00 1.00])
(children 1
(GraphicsLayer
Deleted: branches/safari-536-branch/LayoutTests/compositing/visibility/layer-visible-content-expected.png
(Binary files differ)
Modified: branches/safari-536-branch/LayoutTests/compositing/visibility/layer-visible-content-expected.txt (119050 => 119051)
--- branches/safari-536-branch/LayoutTests/compositing/visibility/layer-visible-content-expected.txt 2012-05-31 04:25:01 UTC (rev 119050)
+++ branches/safari-536-branch/LayoutTests/compositing/visibility/layer-visible-content-expected.txt 2012-05-31 04:30:56 UTC (rev 119051)
@@ -6,6 +6,7 @@
(children 2
(GraphicsLayer
(bounds 200.00 200.00)
+ (drawsContent 1)
(children 1
(GraphicsLayer
(bounds 200.00 200.00)
Modified: branches/safari-536-branch/Source/WebCore/rendering/RenderLayer.cpp (119050 => 119051)
--- branches/safari-536-branch/Source/WebCore/rendering/RenderLayer.cpp 2012-05-31 04:25:01 UTC (rev 119050)
+++ branches/safari-536-branch/Source/WebCore/rendering/RenderLayer.cpp 2012-05-31 04:30:56 UTC (rev 119051)
@@ -965,19 +965,6 @@
return 0;
}
-
-RenderLayer* RenderLayer::enclosingCompositingLayerForRepaint(bool includeSelf) const
-{
-if (includeSelf && isComposited() && !backing()->paintsIntoCompositedAncestor())
-return const_cast(this);
-
-for (const RenderLayer* curr = compositingContainer(this); curr; curr = compositingContainer(curr)) {
-if (curr->isComposited() && !curr->backing()->paintsIntoCompositedAncestor())
-return const_cast(curr);
-}
-
-return 0;
-}
#endif
#if ENABLE(CSS_FILTERS)
@@ -1082,7 +1069,7 @@
ASSERT(current);
if (current->transform()
#if USE(ACCELERATED_COMPOSITING)
-|| (current->isComposited() && !current->backing()->paintsIntoCompositedAncestor())
+|| (current->isComposited())
#endif
)
return const_cast(current);
@@ -2896,7 +2883,7 @@
// but we need to ensure that we don't cache clip rects computed with the wrong root in this case.
if (context->updatingControlTints() || (paintBehavior & PaintBehaviorFlattenCompositingLayers))
paintFlags |= PaintLayerTemporaryClipRects;
-else if (!backing()->paintsIntoWindow() && !backing()->paintsIntoCompositedAncestor() && !shouldDoSoftwarePaint(this, paintFlags & PaintLayerPaintingReflection) && !(rootLayer->containsDirtyOverlayScrollbars() && (paintFlags & PaintLayerPaintingOverlayScrollbars))) {
+else if (!backing()->paintsIntoWindow() && !shouldDoSoftwarePaint(this, paintFlags & PaintLayerPaintingReflection) && !(rootLayer->containsDirtyOverlayScrollbars() && (paintFlags & PaintLayerPaintingOverlayScrollbars))) {
// If this RenderLayer should paint into its backing, that will be done via RenderLayerBacking::paintIntoLayer().
return;
}
Modified: branches/safari-536-branch/Source/WebCore/rendering/RenderLayer.h (119050 => 119051)
--- branches/safari-536-branch/Source/WebCore/rendering/RenderLayer.h 2012-05-31 04:2
[webkit-changes] [119050] trunk
Title: [119050] trunk
Revision 119050
Author infe...@chromium.org
Date 2012-05-30 21:25:01 -0700 (Wed, 30 May 2012)
Log Message
Crash in ContainerNode::parserAddChild.
https://bugs.webkit.org/show_bug.cgi?id=87903
Reviewed by Ryosuke Niwa.
Source/WebCore:
Call the ChildNodeInsertionNotifier.notify call at the end since
it can destroy |this| and some of the local pointers like |last|.
This also matches the order of calls - childrenChanged precedes
ChildNodeInsertionNotifier.notify in updateTreeAfterInsertion and
ContainerNode::parserInsertBefore.
Also remove a FIXME since we use ChildNodeInsertionNotifier.notify
instead of ChildNodeInsertionNotifier.notifyInsertedIntoDocument
(as recommended in the FIXME).
Test: fast/dom/child-insertion-notify-crash.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserAddChild):
LayoutTests:
* fast/dom/child-insertion-notify-crash-expected.txt: Added.
* fast/dom/child-insertion-notify-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
Added Paths
trunk/LayoutTests/fast/dom/child-insertion-notify-crash-expected.txt
trunk/LayoutTests/fast/dom/child-insertion-notify-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (119049 => 119050)
--- trunk/LayoutTests/ChangeLog 2012-05-31 04:23:37 UTC (rev 119049)
+++ trunk/LayoutTests/ChangeLog 2012-05-31 04:25:01 UTC (rev 119050)
@@ -1,3 +1,13 @@
+2012-05-30 Abhishek Arya
+
+Crash in ContainerNode::parserAddChild.
+https://bugs.webkit.org/show_bug.cgi?id=87903
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/child-insertion-notify-crash-expected.txt: Added.
+* fast/dom/child-insertion-notify-crash.html: Added.
+
2012-05-30 Rick Byers
[chromium] Implement pointer and hover CSS media features
Added: trunk/LayoutTests/fast/dom/child-insertion-notify-crash-expected.txt (0 => 119050)
--- trunk/LayoutTests/fast/dom/child-insertion-notify-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/child-insertion-notify-crash-expected.txt 2012-05-31 04:25:01 UTC (rev 119050)
@@ -0,0 +1,4 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS. WebKit didn't crash.
Added: trunk/LayoutTests/fast/dom/child-insertion-notify-crash.html (0 => 119050)
--- trunk/LayoutTests/fast/dom/child-insertion-notify-crash.html (rev 0)
+++ trunk/LayoutTests/fast/dom/child-insertion-notify-crash.html 2012-05-31 04:25:01 UTC (rev 119050)
@@ -0,0 +1,14 @@
+
+
+
+function crash()
+{
+document.getElementById("test").innerHTML = "PASS. WebKit didn't crash.";
+gc();
+}
+
+A
+
[webkit-changes] [119049] branches/safari-536-branch/Source/WebCore
Title: [119049] branches/safari-536-branch/Source/WebCore
Revision 119049
Author lforsch...@apple.com
Date 2012-05-30 21:23:37 -0700 (Wed, 30 May 2012)
Log Message
Merged r118820 ->
Modified Paths
branches/safari-536-branch/Source/WebCore/ChangeLog
branches/safari-536-branch/Source/WebCore/English.lproj/Localizable.strings
branches/safari-536-branch/Source/WebCore/platform/LocalizedStrings.cpp
Diff
Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (119048 => 119049)
--- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 04:20:17 UTC (rev 119048)
+++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 04:23:37 UTC (rev 119049)
@@ -1,5 +1,24 @@
2012-05-30 Lucas Forschler
+Merge 118820
+
+2012-05-29 John Sullivan
+
+Update label for blacklisted plug-in
+https://bugs.webkit.org/show_bug.cgi?id=87767
+rdar://problem/11550048
+
+Reviewed by Kevin Decker.
+
+* English.lproj/Localizable.strings:
+Regenerated.
+
+* platform/LocalizedStrings.cpp:
+(WebCore::insecurePluginVersionText):
+Changed this string.
+
+2012-05-30 Lucas Forschler
+
Merge 118553
2012-05-25 Dean Jackson
Modified: branches/safari-536-branch/Source/WebCore/English.lproj/Localizable.strings (119048 => 119049)
--- branches/safari-536-branch/Source/WebCore/English.lproj/Localizable.strings 2012-05-31 04:20:17 UTC (rev 119048)
+++ branches/safari-536-branch/Source/WebCore/English.lproj/Localizable.strings 2012-05-31 04:23:37 UTC (rev 119049)
@@ -55,6 +55,9 @@
/ * B a c k c o n t e x t m e n u i t e m * /
" B a c k " = " B a c k " ;
+ / * L a b e l t e x t t o b e u s e d w h e n a n i n s e c u r e p l u g - i n v e r s i o n w a s b l o c k e d f r o m l o a d i n g * /
+ " B l o c k e d P l u g - i n " = " B l o c k e d P l u g - i n " ;
+
/ * B o l d c o n t e x t m e n u i t e m * /
" B o l d " = " B o l d " ;
@@ -172,9 +175,6 @@
/ * U n d o a c t i o n n a m e * /
" I n d e n t ( U n d o a c t i o n n a m e ) " = " I n d e n t " ;
- / * L a b e l t e x t t o b e u s e d w h e n a n i n s e c u r e p l u g - i n v e r s i o n w a s b l o c k e d f r o m l o a d i n g * /
- " I n s e c u r e P l u g - I n V e r s i o n " = " I n s e c u r e P l u g - I n V e r s i o n " ;
-
/ * U n d o a c t i o n n a m e * /
" I n s e r t L i s t ( U n d o a c t i o n n a m e ) " = " I n s e r t L i s t " ;
Modified: branches/safari-536-branch/Source/WebCore/platform/LocalizedStrings.cpp (119048 => 119049)
--- branches/safari-536-branch/Source/WebCore/platform/LocalizedStrings.cpp 2012-05-31 04:20:17 UTC (rev 119048)
+++ branches/safari-536-branch/Source/WebCore/platform/LocalizedStrings.cpp 2012-05-31 04:23:37 UTC (rev 119049)
@@ -675,7 +675,7 @@
String insecurePluginVersionText()
{
-return WEB_UI_STRING("Insecure Plug-In Version", "Label text to be used when an insecure plug-in version was blocked from loading");
+return WEB_UI_STRING("Blocked Plug-in", "Label text to be used when an insecure plug-in version was blocked from loading");
}
String multipleFileUploadText(unsigned numberOfFiles)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119048] branches/safari-536-branch/Source/JavaScriptCore
Title: [119048] branches/safari-536-branch/Source/_javascript_Core
Revision 119048
Author lforsch...@apple.com
Date 2012-05-30 21:20:17 -0700 (Wed, 30 May 2012)
Log Message
Merged r118810 ->
Modified Paths
branches/safari-536-branch/Source/_javascript_Core/ChangeLog
branches/safari-536-branch/Source/_javascript_Core/heap/Heap.h
Diff
Modified: branches/safari-536-branch/Source/_javascript_Core/ChangeLog (119047 => 119048)
--- branches/safari-536-branch/Source/_javascript_Core/ChangeLog 2012-05-31 04:12:00 UTC (rev 119047)
+++ branches/safari-536-branch/Source/_javascript_Core/ChangeLog 2012-05-31 04:20:17 UTC (rev 119048)
@@ -1,5 +1,31 @@
2012-05-30 Lucas Forschler
+Merge 118810
+
+2012-05-29 Mark Hahnenberg
+
+CopiedSpace::doneCopying could start another collection
+https://bugs.webkit.org/show_bug.cgi?id=86538
+
+Reviewed by Geoffrey Garen.
+
+It's possible that if we don't have anything at the head of to-space
+after a collection and the BlockAllocator doesn't have any fresh blocks
+to give us right now we could start another collection while still in
+the middle of the first collection when we call CopiedSpace::addNewBlock().
+
+One way to resolve this would be to have Heap::shouldCollect() check that
+m_operationInProgress is NoOperation. This would prevent the path in
+getFreshBlock() that starts the collection if we're already in the middle of one.
+
+I could not come up with a test case to reproduce this crash on ToT.
+
+* heap/Heap.h:
+(JSC::Heap::shouldCollect): We shouldn't collect if we're already in the middle
+of a collection, i.e. the current operation should be NoOperation.
+
+2012-05-30 Lucas Forschler
+
Merge
2012-05-23 Lucas Forschler
Modified: branches/safari-536-branch/Source/_javascript_Core/heap/Heap.h (119047 => 119048)
--- branches/safari-536-branch/Source/_javascript_Core/heap/Heap.h 2012-05-31 04:12:00 UTC (rev 119047)
+++ branches/safari-536-branch/Source/_javascript_Core/heap/Heap.h 2012-05-31 04:20:17 UTC (rev 119048)
@@ -253,9 +253,9 @@
inline bool Heap::shouldCollect()
{
#if ENABLE(GGC)
-return m_objectSpace.nurseryWaterMark() >= m_minBytesPerCycle && m_isSafeToCollect;
+return m_objectSpace.nurseryWaterMark() >= m_minBytesPerCycle && m_isSafeToCollect && m_operationInProgress == NoOperation;
#else
-return m_bytesAllocated > m_bytesAllocatedLimit && m_isSafeToCollect;
+return m_bytesAllocated > m_bytesAllocatedLimit && m_isSafeToCollect && m_operationInProgress == NoOperation;
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119047] branches/safari-536-branch/Source/WebKit2
Title: [119047] branches/safari-536-branch/Source/WebKit2
Revision 119047
Author lforsch...@apple.com
Date 2012-05-30 21:12:00 -0700 (Wed, 30 May 2012)
Log Message
Merged r118615 ->
Modified Paths
branches/safari-536-branch/Source/WebKit2/ChangeLog
branches/safari-536-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm
Diff
Modified: branches/safari-536-branch/Source/WebKit2/ChangeLog (119046 => 119047)
--- branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:59:39 UTC (rev 119046)
+++ branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 04:12:00 UTC (rev 119047)
@@ -1,5 +1,25 @@
2012-05-30 Lucas Forschler
+Merge 118615
+
+2012-05-25 Maciej Stachowiak
+
+REGRESSION (r116720): Subframe PDF scrolls extremely slowly
+https://bugs.webkit.org/show_bug.cgi?id=87557
+
+
+Reviewed by Anders Carlsson.
+
+It's not possible to make an automated test for this.
+
+* WebProcess/Plugins/PDF/BuiltInPDFView.mm:
+(WebKit::BuiltInPDFView::wantsWheelEvents): Return true instead of false and delete
+misleading comment. While the built-in PDF view would get added to the set of scrollable
+areas anyway, there are some code paths that check wantsWheelEvents explicitly, so it seems
+necessary to reutrn true.
+
+2012-05-30 Lucas Forschler
+
Merge 118559
2012-05-25 Beth Dakin
Modified: branches/safari-536-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm (119046 => 119047)
--- branches/safari-536-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm 2012-05-31 03:59:39 UTC (rev 119046)
+++ branches/safari-536-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm 2012-05-31 04:12:00 UTC (rev 119047)
@@ -473,8 +473,7 @@
bool BuiltInPDFView::wantsWheelEvents()
{
-// We return false here even though we do want wheel events, because we add ourselves to the scrollable area set in updateScrollbars().
-return false;
+return true;
}
void BuiltInPDFView::geometryDidChange(const IntSize& pluginSize, const IntRect& clipRect, const AffineTransform& pluginToRootViewTransform)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119046] trunk/Source/WebKit
Title: [119046] trunk/Source/WebKit
Revision 119046
Author commit-qu...@webkit.org
Date 2012-05-30 20:59:39 -0700 (Wed, 30 May 2012)
Log Message
[BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.
https://bugs.webkit.org/show_bug.cgi?id=81001
Source/WebKit:
Patch by Konrad Piascik on 2012-05-30
Reviewed by Antonio Gomes
Added new InspectorOverlay class
* PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
Patch by Konrad Piascik on 2012-05-30
Reviewed by Antonio Gomes.
Implemented InspectorOverlay using WebOverlayAPI.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
(WebKit):
* Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
* WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::highlight):
(WebCore::InspectorClientBlackBerry::hideHighlight):
(WebCore::InspectorClientBlackBerry::paintInspectorOverlay):
(WebCore):
* WebCoreSupport/InspectorClientBlackBerry.h:
(InspectorClientBlackBerry):
* WebCoreSupport/InspectorOverlay.cpp: Added.
(WebCore):
(WebCore::InspectorOverlay::create):
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::notifySyncRequired):
(WebCore::InspectorOverlay::paintContents):
(WebCore::InspectorOverlay::showDebugBorders):
(WebCore::InspectorOverlay::showRepaintCounter):
(WebCore::InspectorOverlay::contentsVisible):
(WebCore::InspectorOverlay::~InspectorOverlay):
(WebCore::InspectorOverlay::clear):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::paintWebFrame):
(WebCore::InspectorOverlay::invalidateWebFrame):
* WebCoreSupport/InspectorOverlay.h: Added.
(WebKit):
(WebCore):
(InspectorOverlay):
(InspectorOverlayClient):
(WebCore::InspectorOverlay::setClient):
(WebCore::InspectorOverlay::notifyAnimationStarted):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformBlackBerry.cmake
trunk/Source/WebKit/blackberry/Api/BackingStore.cpp
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h
Added Paths
trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorOverlay.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (119045 => 119046)
--- trunk/Source/WebKit/ChangeLog 2012-05-31 03:56:21 UTC (rev 119045)
+++ trunk/Source/WebKit/ChangeLog 2012-05-31 03:59:39 UTC (rev 119046)
@@ -1,3 +1,14 @@
+2012-05-30 Konrad Piascik
+
+[BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.
+https://bugs.webkit.org/show_bug.cgi?id=81001
+
+Reviewed by Antonio Gomes
+
+Added new InspectorOverlay class
+
+* PlatformBlackBerry.cmake:
+
2012-05-29 Arvid Nilsson
[BlackBerry] WebKit-side implementation of SelectionOverlay
Modified: trunk/Source/WebKit/PlatformBlackBerry.cmake (119045 => 119046)
--- trunk/Source/WebKit/PlatformBlackBerry.cmake 2012-05-31 03:56:21 UTC (rev 119045)
+++ trunk/Source/WebKit/PlatformBlackBerry.cmake 2012-05-31 03:59:39 UTC (rev 119046)
@@ -75,6 +75,7 @@
blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp
blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp
blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp
+blackberry/WebCoreSupport/InspectorOverlay.cpp
blackberry/WebCoreSupport/_javascript_DebuggerBlackBerry.cpp
blackberry/WebCoreSupport/NotificationPresenterImpl.cpp
blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp
Modified: trunk/Source/WebKit/blackberry/Api/BackingStore.cpp (119045 => 119046)
--- trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-05-31 03:56:21 UTC (rev 119045)
+++ trunk/Source/WebKit/blackberry/Api/BackingStore.cpp 2012-05-31 03:59:39 UTC (rev 119046)
@@ -2443,7 +2443,8 @@
if (m_webPage->d->m_page->inspectorController()->enabled()) {
WebCore::IntPoint scrollPosition = m_client->frame()->view()->scrollPosition();
graphicsContext.translate(scrollPosition.x(), scrollPosition.y());
-m_webPage->d->m_page->inspectorController()->drawHighlight(graphicsContext);
+if (m_webPage->d->m_inspectorOverlay)
+m_webPage->d->m_inspectorOverlay->paintWebFrame(graphicsContext);
}
#endif
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (119045 => 119046)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-05-31 03:56:21 UTC (rev 119045)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-05-31 03:59:39 UTC (rev 119046)
@@ -75,6 +75,7 @@
#include
[webkit-changes] [119045] trunk
Title: [119045] trunk
Revision 119045
Author commit-qu...@webkit.org
Date 2012-05-30 20:56:21 -0700 (Wed, 30 May 2012)
Log Message
[chromium] Implement pointer and hover CSS media features
https://bugs.webkit.org/show_bug.cgi?id=87403
Patch by Rick Byers on 2012-05-30
Reviewed by Adam Barth.
Source/WebCore:
Add initial support for the pointer and hover media features as defined
here:
http://dev.w3.org/csswg/css4-mediaqueries/#pointer
http://dev.w3.org/csswg/css4-mediaqueries/#hover
For now this only supports the case where we know a touch screen is
available (currently known only for the chromium port on certain
platforms). All other cases continue to behave exactly as if the media
feature isn't supported.
Tests: fast/media/mq-pointer.html
* css/CSSValueKeywords.in:
* css/MediaFeatureNames.h:
(MediaFeatureNames):
* css/MediaQueryEvaluator.cpp:
(WebCore::getLeastCapablePrimaryPointerDeviceType):
(WebCore):
(WebCore::hoverMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setDeviceSupportsTouch):
(WebCore):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:
LayoutTests:
Adds tests for pointer and hover media features, for the initial cases
with and without a touch screen.
* fast/media/mq-pointer-expected.txt: Added.
* fast/media/mq-pointer.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/css/MediaFeatureNames.h
trunk/Source/WebCore/css/MediaQueryEvaluator.cpp
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
Added Paths
trunk/LayoutTests/fast/media/mq-pointer-expected.txt
trunk/LayoutTests/fast/media/mq-pointer.html
Diff
Modified: trunk/LayoutTests/ChangeLog (119044 => 119045)
--- trunk/LayoutTests/ChangeLog 2012-05-31 03:55:01 UTC (rev 119044)
+++ trunk/LayoutTests/ChangeLog 2012-05-31 03:56:21 UTC (rev 119045)
@@ -1,3 +1,16 @@
+2012-05-30 Rick Byers
+
+[chromium] Implement pointer and hover CSS media features
+https://bugs.webkit.org/show_bug.cgi?id=87403
+
+Reviewed by Adam Barth.
+
+Adds tests for pointer and hover media features, for the initial cases
+with and without a touch screen.
+
+* fast/media/mq-pointer-expected.txt: Added.
+* fast/media/mq-pointer.html: Added.
+
2012-05-30 Jessie Berlin
[Win] Need implementation of layoutTestController.setBackingScaleFactor
Added: trunk/LayoutTests/fast/media/mq-pointer-expected.txt (0 => 119045)
--- trunk/LayoutTests/fast/media/mq-pointer-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/media/mq-pointer-expected.txt 2012-05-31 03:56:21 UTC (rev 119045)
@@ -0,0 +1,27 @@
+Test the (pointer) and (hover) media features. See Bug 87403 for details.
+
+- default configuration -
+Query "(pointer)": false
+Query "(Pointer)": false
+Query "(pointer:none)": false
+Query "(pointer:coarse)": false
+Query "(pointer:coARse)": false
+Query "(pointer:bogusvalue)": false
+Query "(pointer:fine)": false
+Query "(hover)": false
+Query "(hover:0)": false
+Query "(hover:1)": false
+Query "(hover:bogusvalue)": false
+- with touch screen -
+Query "(pointer)": true
+Query "(Pointer)": true
+Query "(pointer:none)": false
+Query "(pointer:coarse)": true
+Query "(pointer:coARse)": true
+Query "(pointer:bogusvalue)": false
+Query "(pointer:fine)": false
+Query "(hover)": false
+Query "(hover:0)": true
+Query "(hover:1)": false
+Query "(hover:bogusvalue)": false
+
Added: trunk/LayoutTests/fast/media/mq-pointer.html (0 => 119045)
--- trunk/LayoutTests/fast/media/mq-pointer.html (rev 0)
+++ trunk/LayoutTests/fast/media/mq-pointer.html 2012-05-31 03:56:21 UTC (rev 119045)
@@ -0,0 +1,58 @@
+
+
+Test CSS4 media query "pointer" and "hover" features.
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function log(m) {
+document.getElementById('results').innerHTML += m + '
';
+}
+
+function testQueries()
+{
+var queries = [
+"(pointer)",
+"(Pointer)",
+"(pointer:none)",
+"(pointer:coarse)",
+"(pointer:coARse)",
+"(pointer:bogusvalue)",
+"(pointer:fine)",
+"(hover)",
+"(hover:0)",
+"(hover:1)",
+"(hover:bogusvalue)" ];
+for (var index=0; index < queries.length; index++) {
+log("Query "" + queries[index] + "": " +
+window.matchMedia(queries[index]).matches);
+}
+}
+
+function runTests()
+{
+log("- default configuration
[webkit-changes] [119044] branches/safari-536-branch/Source/WebKit2
Title: [119044] branches/safari-536-branch/Source/WebKit2 Revision 119044 Author lforsch...@apple.com Date 2012-05-30 20:55:01 -0700 (Wed, 30 May 2012) Log Message Merged r118559 -> Modified Paths branches/safari-536-branch/Source/WebKit2/ChangeLog branches/safari-536-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp Diff Modified: branches/safari-536-branch/Source/WebKit2/ChangeLog (119043 => 119044) --- branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:53:23 UTC (rev 119043) +++ branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:55:01 UTC (rev 119044) @@ -1,5 +1,23 @@ 2012-05-30 Lucas Forschler +Merge 118559 + +2012-05-25 Beth Dakin + +https://bugs.webkit.org/show_bug.cgi?id=87529 +Background tabs hosted in window server flash before painting +when they first become active + +Reviewed by Anders Carlsson. + +Initialize to LayerHostingModeInWindowServer if that is +available to avoid having to re-make the context and re-set +everything later on. +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::WebPageProxy): + +2012-05-30 Lucas Forschler + Merge 118505 2012-05-24 Andreas Kling Modified: branches/safari-536-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp (119043 => 119044) --- branches/safari-536-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-05-31 03:53:23 UTC (rev 119043) +++ branches/safari-536-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-05-31 03:55:01 UTC (rev 119044) @@ -164,7 +164,11 @@ , m_pageScaleFactor(1) , m_intrinsicDeviceScaleFactor(1) , m_customDeviceScaleFactor(0) +#if HAVE(LAYER_HOSTING_IN_WINDOW_SERVER) +, m_layerHostingMode(LayerHostingModeInWindowServer) +#else , m_layerHostingMode(LayerHostingModeDefault) +#endif , m_drawsBackground(true) , m_drawsTransparentBackground(false) , m_areMemoryCacheClientCallsEnabled(true) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119043] branches/safari-536-branch/Source/WebCore
Title: [119043] branches/safari-536-branch/Source/WebCore
Revision 119043
Author lforsch...@apple.com
Date 2012-05-30 20:53:23 -0700 (Wed, 30 May 2012)
Log Message
Merged r118553 ->
Modified Paths
branches/safari-536-branch/Source/WebCore/ChangeLog
branches/safari-536-branch/Source/WebCore/dom/Element.cpp
Diff
Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (119042 => 119043)
--- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:50:54 UTC (rev 119042)
+++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:53:23 UTC (rev 119043)
@@ -1,5 +1,23 @@
2012-05-30 Lucas Forschler
+Merge 118553
+
+2012-05-25 Dean Jackson
+
+Unreviewed, rolling out r112155.
+http://trac.webkit.org/changeset/112155
+https://bugs.webkit.org/show_bug.cgi?id=79389
+Hitch (due to style recalc?) when starting CSS3 animation
+
+This caused a number of issues, including:
+https://bugs.webkit.org/show_bug.cgi?id=87146
+https://bugs.webkit.org/show_bug.cgi?id=84194
+
+
+
+
+2012-05-30 Lucas Forschler
+
Merge 118450
2012-05-24 Anders Carlsson
Modified: branches/safari-536-branch/Source/WebCore/dom/Element.cpp (119042 => 119043)
--- branches/safari-536-branch/Source/WebCore/dom/Element.cpp 2012-05-31 03:50:54 UTC (rev 119042)
+++ branches/safari-536-branch/Source/WebCore/dom/Element.cpp 2012-05-31 03:53:23 UTC (rev 119043)
@@ -1143,7 +1143,7 @@
}
if (change != Force) {
-if (styleChangeType() == FullStyleChange)
+if (styleChangeType() >= FullStyleChange)
change = Force;
else
change = ch;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119042] branches/safari-536-branch/Source/WebKit2
Title: [119042] branches/safari-536-branch/Source/WebKit2
Revision 119042
Author lforsch...@apple.com
Date 2012-05-30 20:50:54 -0700 (Wed, 30 May 2012)
Log Message
Merged r118505 ->
Modified Paths
branches/safari-536-branch/Source/WebKit2/ChangeLog
branches/safari-536-branch/Source/WebKit2/UIProcess/WebContext.cpp
branches/safari-536-branch/Source/WebKit2/UIProcess/WebContext.h
Diff
Modified: branches/safari-536-branch/Source/WebKit2/ChangeLog (119041 => 119042)
--- branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:41:07 UTC (rev 119041)
+++ branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:50:54 UTC (rev 119042)
@@ -1,5 +1,25 @@
2012-05-30 Lucas Forschler
+Merge 118505
+
+2012-05-24 Andreas Kling
+
+Mac bots crashing under PluginInfo destructor.
+
+
+
+Reviewed by Darin Adler.
+
+We can't safely pass WTF::String to another thread without a deref() race,
+so pass the PluginInfo vector by pointer instead of by value.
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::sendDidGetPlugins):
+(WebKit::WebContext::handleGetPlugins):
+* UIProcess/WebContext.h:
+
+2012-05-30 Lucas Forschler
+
Merge 118443
2012-05-24 Brady Eidson
Modified: branches/safari-536-branch/Source/WebKit2/UIProcess/WebContext.cpp (119041 => 119042)
--- branches/safari-536-branch/Source/WebKit2/UIProcess/WebContext.cpp 2012-05-31 03:41:07 UTC (rev 119041)
+++ branches/safari-536-branch/Source/WebKit2/UIProcess/WebContext.cpp 2012-05-31 03:50:54 UTC (rev 119042)
@@ -612,20 +612,20 @@
m_visitedLinkProvider.addVisitedLink(linkHash);
}
-void WebContext::sendDidGetPlugins(uint64_t requestID, const Vector& pluginInfos)
+void WebContext::sendDidGetPlugins(uint64_t requestID, PassOwnPtr > pluginInfos)
{
ASSERT(isMainThread());
-Vector plugins(pluginInfos);
+OwnPtr > plugins(pluginInfos);
#if PLATFORM(MAC)
// Add built-in PDF last, so that it's not used when a real plug-in is installed.
// NOTE: This has to be done on the main thread as it calls localizedString().
if (!omitPDFSupport())
-plugins.append(BuiltInPDFView::pluginInfo());
+plugins->append(BuiltInPDFView::pluginInfo());
#endif
-process()->send(Messages::WebProcess::DidGetPlugins(requestID, plugins), 0);
+process()->send(Messages::WebProcess::DidGetPlugins(requestID, *plugins), 0);
}
void WebContext::handleGetPlugins(uint64_t requestID, bool refresh)
@@ -633,13 +633,15 @@
if (refresh)
m_pluginInfoStore.refresh();
-Vector pluginInfos;
+OwnPtr > pluginInfos = adoptPtr(new Vector);
Vector plugins = m_pluginInfoStore.plugins();
for (size_t i = 0; i < plugins.size(); ++i)
-pluginInfos.append(plugins[i].info);
+pluginInfos->append(plugins[i].info);
-RunLoop::main()->dispatch(bind(&WebContext::sendDidGetPlugins, this, requestID, pluginInfos));
+// NOTE: We have to pass the PluginInfo vector to the secondary thread via a pointer as otherwise
+// we'd end up with a deref() race on all the WTF::Strings it contains.
+RunLoop::main()->dispatch(bind(&WebContext::sendDidGetPlugins, this, requestID, pluginInfos.release()));
}
void WebContext::getPlugins(CoreIPC::Connection*, uint64_t requestID, bool refresh)
Modified: branches/safari-536-branch/Source/WebKit2/UIProcess/WebContext.h (119041 => 119042)
--- branches/safari-536-branch/Source/WebKit2/UIProcess/WebContext.h 2012-05-31 03:41:07 UTC (rev 119041)
+++ branches/safari-536-branch/Source/WebKit2/UIProcess/WebContext.h 2012-05-31 03:50:54 UTC (rev 119042)
@@ -261,7 +261,7 @@
String platformDefaultLocalStorageDirectory() const;
void handleGetPlugins(uint64_t requestID, bool refresh);
-void sendDidGetPlugins(uint64_t requestID, const Vector&);
+void sendDidGetPlugins(uint64_t requestID, PassOwnPtr >);
ProcessModel m_processModel;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119041] branches/safari-536-branch
Title: [119041] branches/safari-536-branch Revision 119041 Author lforsch...@apple.com Date 2012-05-30 20:41:07 -0700 (Wed, 30 May 2012) Log Message Fix Changelogs after rolling out 115573. Modified Paths branches/safari-536-branch/LayoutTests/ChangeLog branches/safari-536-branch/Source/WebCore/ChangeLog Diff Modified: branches/safari-536-branch/LayoutTests/ChangeLog (119040 => 119041) --- branches/safari-536-branch/LayoutTests/ChangeLog 2012-05-31 03:27:48 UTC (rev 119040) +++ branches/safari-536-branch/LayoutTests/ChangeLog 2012-05-31 03:41:07 UTC (rev 119041) @@ -6,18 +6,49 @@ Rollout 115573 -2012-04-28 Zan Dobersek +2012-04-26 Emil A Eklund + +Move Length and CSS length computation to float +https://bugs.webkit.org/show_bug.cgi?id=84801 + +Reviewed by Eric Seidel. + +Change Length and CSS length computation to floating point. This gets us +closer to the goal of supporting subpixel layout and improves precision +for SVG which already uses floating point for its layout. + +This change makes computedStyle return fractional values for pixel values +if a fraction is specified. It also changes the result of computations +where two or more values with fractional precision. Prior to this change +the result of Length(2.9) + Length(2.9) would be 4 as each value would be +floored. with this change the result is 5 as the addition is done with +floating point precision and then the result will be floored. Once we +enable subpixel layout the resulting value in this example would be 5.8. + +* fast/dom/length-attribute-mapping-expected.txt: +* fast/dom/length-attribute-mapping.html: +* platform/mac-snowleopard/fast/forms/001-expected.png: +* platform/mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: +* platform/mac/fast/forms/001-expected.txt: +* platform/mac/fast/html/details-position-expected.png: +* platform/mac/fast/html/details-position-expected.txt: +* platform/mac/fast/replaced/width100percent-checkbox-expected.png: +* platform/mac/fast/replaced/width100percent-checkbox-expected.txt: +* platform/mac/fast/replaced/width100percent-radio-expected.png: +* platform/mac/fast/replaced/width100percent-radio-expected.txt: +* platform/mac/mathml/presentation/fractions-expected.png: +* platform/mac/mathml/presentation/fractions-expected.txt: +* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png: +* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt: +* platform/mac/mathml/presentation/mo-stretch-expected.png: +* platform/mac/mathml/presentation/mo-stretch-expected.txt: +* platform/mac/mathml/presentation/subsup-expected.png: +* platform/mac/mathml/presentation/subsup-expected.txt: +* platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: +* platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: +* platform/mac/tables/mozilla/bugs/bug1318-expected.png: +* platform/mac/tables/mozilla/bugs/bug1318-expected.txt: -[WK2] http/tests/navigation/anchor-frames-gbk.html fails -https://bugs.webkit.org/show_bug.cgi?id=76896 - -Reviewed by Darin Adler. - -Unskip the now-passing test for Mac and Qt WK2 ports. - -* platform/mac-wk2/Skipped: -* platform/qt-5.0-wk2/Skipped: - 2012-05-29 Jessie Berlin Merge r118078, which skips the test added in r118039, onto the 536 branch. Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (119040 => 119041) --- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:27:48 UTC (rev 119040) +++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:41:07 UTC (rev 119041) @@ -133,22 +133,55 @@ Rollout 115573 -2012-04-28 Alexander Pavlov - -Web Inspector: Enable touch events feature fails touch feature detection -https://bugs.webkit.org/show_bug.cgi?id=84397 - -Whenever the touch emulation is enabled, Inspector adds a script to evaluate on load, -that adds ontouch(start|end|move|cancel) properties to window.__proto__ and document.__proto__. - -Reviewed by Pavel Feldman. - -* inspector/front-end/DOMAgent.js: -(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged.get if): -(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged.scriptAddedCallback): -(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged): -* inspector/front-end/ins
[webkit-changes] [119040] branches/safari-536-branch/Source/WebCore
Title: [119040] branches/safari-536-branch/Source/WebCore
Revision 119040
Author lforsch...@apple.com
Date 2012-05-30 20:27:48 -0700 (Wed, 30 May 2012)
Log Message
Merged r118450 ->
Modified Paths
branches/safari-536-branch/Source/WebCore/ChangeLog
branches/safari-536-branch/Source/WebCore/page/FrameView.cpp
Diff
Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (119039 => 119040)
--- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:26:15 UTC (rev 119039)
+++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:27:48 UTC (rev 119040)
@@ -1,5 +1,23 @@
2012-05-30 Lucas Forschler
+Merge 118450
+
+2012-05-24 Anders Carlsson
+
+Corrupted pages rendering when images are zoomed on Google+
+https://bugs.webkit.org/show_bug.cgi?id=87439
+
+
+Reviewed by Beth Dakin.
+
+The rect that's given to scrollContentsSlowPath is in frame view coordinates, but if we end up
+passing them to RenderLayer::setBackingNeedsRepaintInRect we need to account for the frame scale factor.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::scrollContentsSlowPath):
+
+2012-05-30 Lucas Forschler
+
Merge 118411
2012-05-24 Jer Noble
Modified: branches/safari-536-branch/Source/WebCore/page/FrameView.cpp (119039 => 119040)
--- branches/safari-536-branch/Source/WebCore/page/FrameView.cpp 2012-05-31 03:26:15 UTC (rev 119039)
+++ branches/safari-536-branch/Source/WebCore/page/FrameView.cpp 2012-05-31 03:27:48 UTC (rev 119040)
@@ -1532,7 +1532,14 @@
if (contentsInCompositedLayer()) {
RenderView* root = rootRenderer(this);
ASSERT(root);
-root->layer()->setBackingNeedsRepaintInRect(visibleContentRect());
+
+IntRect updateRect = visibleContentRect();
+
+// Make sure to "apply" the scale factor here since we're converting from frame view
+// coordinates to layer backing coordinates.
+updateRect.scale(1 / m_frame->frameScaleFactor());
+
+root->layer()->setBackingNeedsRepaintInRect(updateRect);
}
if (RenderPart* frameRenderer = m_frame->ownerRenderer()) {
if (isEnclosedInCompositingLayer()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119039] trunk/LayoutTests
Title: [119039] trunk/LayoutTests Revision 119039 Author jber...@webkit.org Date 2012-05-30 20:26:15 -0700 (Wed, 30 May 2012) Log Message [Win] Need implementation of layoutTestController.setBackingScaleFactor https://bugs.webkit.org/show_bug.cgi?id=87919 Add tests that use setBackingScaleFactor to the Windows Skipped list. * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (119038 => 119039) --- trunk/LayoutTests/ChangeLog 2012-05-31 03:25:32 UTC (rev 119038) +++ trunk/LayoutTests/ChangeLog 2012-05-31 03:26:15 UTC (rev 119039) @@ -1,3 +1,12 @@ +2012-05-30 Jessie Berlin + +[Win] Need implementation of layoutTestController.setBackingScaleFactor +https://bugs.webkit.org/show_bug.cgi?id=87919 + +Add tests that use setBackingScaleFactor to the Windows Skipped list. + +* platform/win/Skipped: + 2012-05-30 Christophe Dumez [JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be found in transferred ports Modified: trunk/LayoutTests/platform/win/Skipped (119038 => 119039) --- trunk/LayoutTests/platform/win/Skipped 2012-05-31 03:25:32 UTC (rev 119038) +++ trunk/LayoutTests/platform/win/Skipped 2012-05-31 03:26:15 UTC (rev 119039) @@ -1546,8 +1546,13 @@ # Microdata DOM API is not yet enabled. fast/dom/MicroData -# HiDPI tests require test infrastructure enhancements +# HiDPI tests require test infrastructure enhancements (e.g. layoutTestController.setBackingScaleFactor) +# https://bugs.webkit.org/show_bug.cgi?id=87919 +compositing/tiled-layers-hidpi.html +fast/canvas/2d.backingStorePixelRatio.html +fast/canvas/2d.imageDataHD.html fast/hidpi +svg/as-image/image-respects-deviceScaleFactor.html # Skip because this platform does not support a paging mouse wheel event fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119038] branches/safari-536-branch/Source/WebKit2
Title: [119038] branches/safari-536-branch/Source/WebKit2
Revision 119038
Author lforsch...@apple.com
Date 2012-05-30 20:25:32 -0700 (Wed, 30 May 2012)
Log Message
Merged r118443 ->
Modified Paths
branches/safari-536-branch/Source/WebKit2/ChangeLog
branches/safari-536-branch/Source/WebKit2/UIProcess/cf/WebBackForwardListCF.cpp
Diff
Modified: branches/safari-536-branch/Source/WebKit2/ChangeLog (119037 => 119038)
--- branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:23:54 UTC (rev 119037)
+++ branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:25:32 UTC (rev 119038)
@@ -1,5 +1,18 @@
2012-05-30 Lucas Forschler
+Merge 118443
+
+2012-05-24 Brady Eidson
+
+Fix the build after http://trac.webkit.org/changeset/118441
+Also fix a glaring bug with the new code, will run it by original reviewer retroactively.
+
+* UIProcess/cf/WebBackForwardListCF.cpp:
+(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Fix up the types of the ? operands
+ to appease super-strict compilers. Don't allow negative indexes (besides the -1 "No index" index).
+
+2012-05-30 Lucas Forschler
+
Merge 118441
2012-05-24 Brady Eidson
Modified: branches/safari-536-branch/Source/WebKit2/UIProcess/cf/WebBackForwardListCF.cpp (119037 => 119038)
--- branches/safari-536-branch/Source/WebKit2/UIProcess/cf/WebBackForwardListCF.cpp 2012-05-31 03:23:54 UTC (rev 119037)
+++ branches/safari-536-branch/Source/WebKit2/UIProcess/cf/WebBackForwardListCF.cpp 2012-05-31 03:25:32 UTC (rev 119038)
@@ -131,14 +131,14 @@
}
CFIndex size = CFArrayGetCount(cfEntries);
-if (currentCFIndex != -1 && currentCFIndex >= size) {
+if (currentCFIndex < -1 || currentCFIndex >= size ) {
LOG(SessionState, "WebBackForwardList dictionary representation contains an invalid current index (%ld) for the number of entries (%ld)", currentCFIndex, size);
return false;
}
// FIXME: We're relying on currentIndex == -1 to mean the exact same thing as NoCurrentItemIndex (UINT_MAX) in unsigned form.
// That seems implicit and fragile and we should find a better way of representing the NoCurrentItemIndex case.
-uint32_t currentIndex = currentCFIndex == -1 ? NoCurrentItemIndex : currentCFIndex;
+uint32_t currentIndex = currentCFIndex == -1 ? NoCurrentItemIndex : static_cast(currentCFIndex);
if (currentIndex == NoCurrentItemIndex && size) {
LOG(SessionState, "WebBackForwardList dictionary representation says there is no current item index, but there is a list of %ld entries - this is bogus", size);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119037] branches/safari-536-branch/Source/WebKit2
Title: [119037] branches/safari-536-branch/Source/WebKit2
Revision 119037
Author lforsch...@apple.com
Date 2012-05-30 20:23:54 -0700 (Wed, 30 May 2012)
Log Message
Merged r118441 ->
Modified Paths
branches/safari-536-branch/Source/WebKit2/ChangeLog
branches/safari-536-branch/Source/WebKit2/UIProcess/WebBackForwardList.cpp
branches/safari-536-branch/Source/WebKit2/UIProcess/cf/WebBackForwardListCF.cpp
Diff
Modified: branches/safari-536-branch/Source/WebKit2/ChangeLog (119036 => 119037)
--- branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:22:19 UTC (rev 119036)
+++ branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:23:54 UTC (rev 119037)
@@ -1,5 +1,31 @@
2012-05-30 Lucas Forschler
+Merge 118441
+
+2012-05-24 Brady Eidson
+
+ and https://bugs.webkit.org/show_bug.cgi?id=87417
+(Unrepro) Crashes saving session state in WebBackForwardList
+
+Reviewed by Darin Adler.
+
+* UIProcess/WebBackForwardList.cpp:
+(WebKit::WebBackForwardList::addItem): Null check the proposed item and also m_page, to make
+ sure the page hasn't been closed making this list inactive. Be more aggressive about
+ clearing the current entries out if there is no current item index.
+(WebKit::WebBackForwardList::itemAtIndex): Early null return if there is no current index.
+(WebKit::WebBackForwardList::clear): Don't put the current item back in the array if there was
+ no current item.
+
+* UIProcess/cf/WebBackForwardListCF.cpp:
+(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Don't create a meaningless WebURL.
+ Don't successfully return a dictionary if any of the entries were null. Be more aggressive about
+ validating the current index we plan to return in the dictionary.
+(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): More aggressively validate the
+ current index read from disk. Replace a meaningless sanity check with our typical ASSERT.
+
+2012-05-30 Lucas Forschler
+
Merge 118439
2012-05-24 Anders Carlsson
Modified: branches/safari-536-branch/Source/WebKit2/UIProcess/WebBackForwardList.cpp (119036 => 119037)
--- branches/safari-536-branch/Source/WebKit2/UIProcess/WebBackForwardList.cpp 2012-05-31 03:22:19 UTC (rev 119036)
+++ branches/safari-536-branch/Source/WebKit2/UIProcess/WebBackForwardList.cpp 2012-05-31 03:23:54 UTC (rev 119037)
@@ -39,7 +39,7 @@
, m_closed(true)
, m_enabled(true)
{
-ASSERT(m_current == NoCurrentItemIndex || m_current < m_entries.size());
+ASSERT(m_page);
}
WebBackForwardList::~WebBackForwardList()
@@ -61,40 +61,51 @@
{
ASSERT(m_current == NoCurrentItemIndex || m_current < m_entries.size());
-if (m_capacity == 0 || !m_enabled)
+if (!m_capacity || !m_enabled || !newItem || !m_page)
return;
Vector > removedItems;
-// Toss anything in the forward list
if (m_current != NoCurrentItemIndex) {
+// Toss everything in the forward list.
unsigned targetSize = m_current + 1;
removedItems.reserveCapacity(m_entries.size() - targetSize);
while (m_entries.size() > targetSize) {
-if (m_page)
-m_page->backForwardRemovedItem(m_entries.last()->itemID());
+m_page->backForwardRemovedItem(m_entries.last()->itemID());
removedItems.append(m_entries.last().release());
m_entries.removeLast();
}
-}
-// Toss the first item if the list is getting too big, as long as we're not using it
-// (or even if we are, if we only want 1 entry).
-if (m_entries.size() == m_capacity && (m_current != 0 || m_capacity == 1)) {
-if (m_page)
+// Toss the first item if the list is getting too big, as long as we're not using it
+// (or even if we are, if we only want 1 entry).
+if (m_entries.size() == m_capacity && (m_current || m_capacity == 1)) {
m_page->backForwardRemovedItem(m_entries[0]->itemID());
-removedItems.append(m_entries[0].release());
-m_entries.remove(0);
-m_current--;
+removedItems.append(m_entries[0].release());
+m_entries.remove(0);
+m_current--;
+}
+} else {
+// If we have no current item index, we should have no other entries before adding this new item.
+size_t size = m_entries.size();
+for (size_t i = 0; i < size; ++i) {
+m_page->backForwardRemovedItem(m_entries[i]->itemID());
+removedItems.append(m_entries[i].release());
+}
+m_entries.clear();
}
+
+if (m_current == NoCurrentItemIndex)
+m_current = 0;
+else
+m_current++;
-m_entries.insert(m_current + 1, newItem);
-m_current++;
+// m_current never be po
[webkit-changes] [119035] branches/safari-536-branch/Source/WebKit2
Title: [119035] branches/safari-536-branch/Source/WebKit2 Revision 119035 Author lforsch...@apple.com Date 2012-05-30 20:18:29 -0700 (Wed, 30 May 2012) Log Message Merged r118439 -> Modified Paths branches/safari-536-branch/Source/WebKit2/ChangeLog branches/safari-536-branch/Source/WebKit2/Shared/WebPageCreationParameters.cpp branches/safari-536-branch/Source/WebKit2/Shared/WebPageCreationParameters.h branches/safari-536-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp branches/safari-536-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp branches/safari-536-branch/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h branches/safari-536-branch/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm Diff Modified: branches/safari-536-branch/Source/WebKit2/ChangeLog (119034 => 119035) --- branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:16:42 UTC (rev 119034) +++ branches/safari-536-branch/Source/WebKit2/ChangeLog 2012-05-31 03:18:29 UTC (rev 119035) @@ -1,3 +1,35 @@ +2012-05-30 Lucas Forschler + +Merge 118439 + +2012-05-24 Anders Carlsson + +Make sure that the layer hosting mode is up-to-date when reconnecting to a new web process +https://bugs.webkit.org/show_bug.cgi?id=87421 + + +Reviewed by Beth Dakin. + +Send over the layer hosting mode as part of the web page creation parameters and create the right +layer hosting context based on the mode. + +* Shared/WebPageCreationParameters.cpp: +(WebKit::WebPageCreationParameters::encode): +(WebKit::WebPageCreationParameters::decode): +* Shared/WebPageCreationParameters.h: +(WebPageCreationParameters): +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::creationParameters): +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::WebPage): +* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: +(TiledCoreAnimationDrawingArea): +* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: +(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea): +(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode): +(WebKit): +(WebKit::TiledCoreAnimationDrawingArea::updateLayerHostingContext): + 2012-05-28 Lucas Forschler Merge 118397 Modified: branches/safari-536-branch/Source/WebKit2/Shared/WebPageCreationParameters.cpp (119034 => 119035) --- branches/safari-536-branch/Source/WebKit2/Shared/WebPageCreationParameters.cpp 2012-05-31 03:16:42 UTC (rev 119034) +++ branches/safari-536-branch/Source/WebKit2/Shared/WebPageCreationParameters.cpp 2012-05-31 03:18:29 UTC (rev 119035) @@ -60,6 +60,7 @@ #if PLATFORM(MAC) encoder->encode(isSmartInsertDeleteEnabled); +encoder->encodeEnum(layerHostingMode); #endif #if PLATFORM(WIN) @@ -121,6 +122,8 @@ #if PLATFORM(MAC) if (!decoder->decode(parameters.isSmartInsertDeleteEnabled)) return false; +if (!decoder->decodeEnum(parameters.layerHostingMode)) +return false; #endif #if PLATFORM(WIN) Modified: branches/safari-536-branch/Source/WebKit2/Shared/WebPageCreationParameters.h (119034 => 119035) --- branches/safari-536-branch/Source/WebKit2/Shared/WebPageCreationParameters.h 2012-05-31 03:16:42 UTC (rev 119034) +++ branches/safari-536-branch/Source/WebKit2/Shared/WebPageCreationParameters.h 2012-05-31 03:18:29 UTC (rev 119035) @@ -82,6 +82,7 @@ #if PLATFORM(MAC) bool isSmartInsertDeleteEnabled; +LayerHostingMode layerHostingMode; #endif #if PLATFORM(WIN) Modified: branches/safari-536-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp (119034 => 119035) --- branches/safari-536-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-05-31 03:16:42 UTC (rev 119034) +++ branches/safari-536-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-05-31 03:18:29 UTC (rev 119035) @@ -3459,6 +3459,7 @@ #if PLATFORM(MAC) parameters.isSmartInsertDeleteEnabled = m_isSmartInsertDeleteEnabled; +parameters.layerHostingMode = m_layerHostingMode; #endif #if PLATFORM(WIN) Modified: branches/safari-536-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (119034 => 119035) --- branches/safari-536-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-05-31 03:16:42 UTC (rev 119034) +++ branches/safari-536-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-05-31 03:18:29 UTC (rev 119035) @@ -192,7 +192,7 @@ #if PLATFORM(MAC) , m_windowIsVisible(false) , m_isSmartInsertDeleteEnabled(parameters.isSmartInsertDeleteEnabled) -, m_layerHostingMode(LayerHostingModeDefault) +, m_layerHostingMode(parameters.layerHostingMode) , m_keyboardEventBeingInterpreted(0) #elif PLATFORM(WIN) , m_nativeWindow(parameters.nativeWindow) Modified: branches/safari-536-branch/Source/WebKit2/We
[webkit-changes] [119034] branches/safari-536-branch/Source/WebCore
Title: [119034] branches/safari-536-branch/Source/WebCore
Revision 119034
Author lforsch...@apple.com
Date 2012-05-30 20:16:42 -0700 (Wed, 30 May 2012)
Log Message
Merged r118411 ->
Modified Paths
branches/safari-536-branch/Source/WebCore/ChangeLog
branches/safari-536-branch/Source/WebCore/html/shadow/MediaControlElements.cpp
Diff
Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (119033 => 119034)
--- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:15:06 UTC (rev 119033)
+++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:16:42 UTC (rev 119034)
@@ -1,5 +1,24 @@
2012-05-30 Lucas Forschler
+Merge 118411
+
+2012-05-24 Jer Noble
+
+MediaControlTimelineElement is adjusting time 3 times per click
+https://bugs.webkit.org/show_bug.cgi?id=58160
+
+Reviewed by Eric Carlson.
+
+No new tests; we intentionally throttle timeupdate events for the same
+movie time, so there is no way to write a layout test for this case.
+
+Only call setCurrentTime() on mousedown or mousemove events.
+
+* html/shadow/MediaControlElements.cpp:
+(WebCore::MediaControlTimelineElement::defaultEventHandler):
+
+2012-05-30 Lucas Forschler
+
Merge 118314
2012-05-23 Jer Noble
Modified: branches/safari-536-branch/Source/WebCore/html/shadow/MediaControlElements.cpp (119033 => 119034)
--- branches/safari-536-branch/Source/WebCore/html/shadow/MediaControlElements.cpp 2012-05-31 03:15:06 UTC (rev 119033)
+++ branches/safari-536-branch/Source/WebCore/html/shadow/MediaControlElements.cpp 2012-05-31 03:16:42 UTC (rev 119034)
@@ -836,8 +836,7 @@
return;
float time = narrowPrecisionToFloat(value().toDouble());
-if (time != mediaController()->currentTime()) {
-// FIXME: This is fired 3 times on every click. We should not be doing that .
+if (event->type() == eventNames().inputEvent && time != mediaController()->currentTime()) {
ExceptionCode ec;
mediaController()->setCurrentTime(time, ec);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119033] trunk/Source/WebCore
Title: [119033] trunk/Source/WebCore Revision 119033 Author jchaffr...@webkit.org Date 2012-05-30 20:15:06 -0700 (Wed, 30 May 2012) Log Message Add an helper function to get the style for a cell's flow computation https://bugs.webkit.org/show_bug.cgi?id=87902 Reviewed by Ojan Vafai. No expected change in behavior. This change introduces styleForCellFlow that unify which function we use to determine a cell's direction and writing mode. This unification will make it easier to support direction on table row group (section in WebKit land). * rendering/RenderTableCell.h: (WebCore::RenderTableCell::styleForCellFlow): Added the new function along with a comment as to its purpose. * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::clippedOverflowRectForRepaint): (WebCore::RenderTableCell::computeCollapsedStartBorder): (WebCore::RenderTableCell::computeCollapsedEndBorder): (WebCore::RenderTableCell::computeCollapsedBeforeBorder): (WebCore::RenderTableCell::computeCollapsedAfterBorder): (WebCore::RenderTableCell::borderHalfLeft): (WebCore::RenderTableCell::borderHalfRight): (WebCore::RenderTableCell::borderHalfTop): (WebCore::RenderTableCell::borderHalfBottom): (WebCore::RenderTableCell::borderHalfStart): (WebCore::RenderTableCell::borderHalfEnd): (WebCore::RenderTableCell::borderHalfBefore): (WebCore::RenderTableCell::borderHalfAfter): (WebCore::RenderTableCell::paintCollapsedBorders): Mostly mechanical replacement. * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::cachedCollapsedLeftBorder): (WebCore::RenderTableCell::cachedCollapsedRightBorder): (WebCore::RenderTableCell::cachedCollapsedTopBorder): (WebCore::RenderTableCell::cachedCollapsedBottomBorder): Made the argument 'const' now. * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): Added a FIXME to unify with the rest. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderTableCell.cpp trunk/Source/WebCore/rendering/RenderTableCell.h trunk/Source/WebCore/rendering/RenderTableSection.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (119032 => 119033) --- trunk/Source/WebCore/ChangeLog 2012-05-31 03:14:38 UTC (rev 119032) +++ trunk/Source/WebCore/ChangeLog 2012-05-31 03:15:06 UTC (rev 119033) @@ -1,3 +1,50 @@ +2012-05-30 Julien Chaffraix + +Add an helper function to get the style for a cell's flow computation +https://bugs.webkit.org/show_bug.cgi?id=87902 + +Reviewed by Ojan Vafai. + +No expected change in behavior. + +This change introduces styleForCellFlow that unify which function we use +to determine a cell's direction and writing mode. + +This unification will make it easier to support direction on table row +group (section in WebKit land). + +* rendering/RenderTableCell.h: +(WebCore::RenderTableCell::styleForCellFlow): +Added the new function along with a comment as to its purpose. + +* rendering/RenderTableCell.cpp: +(WebCore::RenderTableCell::clippedOverflowRectForRepaint): +(WebCore::RenderTableCell::computeCollapsedStartBorder): +(WebCore::RenderTableCell::computeCollapsedEndBorder): +(WebCore::RenderTableCell::computeCollapsedBeforeBorder): +(WebCore::RenderTableCell::computeCollapsedAfterBorder): +(WebCore::RenderTableCell::borderHalfLeft): +(WebCore::RenderTableCell::borderHalfRight): +(WebCore::RenderTableCell::borderHalfTop): +(WebCore::RenderTableCell::borderHalfBottom): +(WebCore::RenderTableCell::borderHalfStart): +(WebCore::RenderTableCell::borderHalfEnd): +(WebCore::RenderTableCell::borderHalfBefore): +(WebCore::RenderTableCell::borderHalfAfter): +(WebCore::RenderTableCell::paintCollapsedBorders): +Mostly mechanical replacement. + +* rendering/RenderTableCell.cpp: +(WebCore::RenderTableCell::cachedCollapsedLeftBorder): +(WebCore::RenderTableCell::cachedCollapsedRightBorder): +(WebCore::RenderTableCell::cachedCollapsedTopBorder): +(WebCore::RenderTableCell::cachedCollapsedBottomBorder): +Made the argument 'const' now. + +* rendering/RenderTableSection.cpp: +(WebCore::RenderTableSection::layoutRows): +Added a FIXME to unify with the rest. + 2012-05-30 Christophe Dumez [JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be found in transferred ports Modified: trunk/Source/WebCore/rendering/RenderTableCell.cpp (119032 => 119033) --- trunk/Source/WebCore/rendering/RenderTableCell.cpp 2012-05-31 03:14:38 UTC (rev 119032) +++ trunk/Source/WebCore/rendering/RenderTableCell.cpp 2012-05-31 03:15:06 UTC (rev 119033) @@ -260,7 +260,7 @@ if (!table()->collapseBorders() || table()->needsSectionRecalc()) return RenderBlock::clippedOverflowRectForRepaint(repaintContainer); -bool rtl = !table()->style()->isL
[webkit-changes] [119032] branches/safari-536-branch/Source/WebCore
Title: [119032] branches/safari-536-branch/Source/WebCore
Revision 119032
Author lforsch...@apple.com
Date 2012-05-30 20:14:38 -0700 (Wed, 30 May 2012)
Log Message
Merged r118314 ->
Modified Paths
branches/safari-536-branch/Source/WebCore/ChangeLog
branches/safari-536-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
Diff
Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (119031 => 119032)
--- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:12:49 UTC (rev 119031)
+++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:14:38 UTC (rev 119032)
@@ -1,5 +1,29 @@
2012-05-30 Lucas Forschler
+Merge 118314
+
+2012-05-23 Jer Noble
+
+REGRESSION: compositing/video/video-poster.html fails on Mac
+https://bugs.webkit.org/show_bug.cgi?id=87199
+
+Reviewed by Maciej Stachowiak.
+
+No new tests; fixes failing compositing/video/video-poster.html test.
+
+Instead of creating the video layer directly, simply allow the layer
+to be created in updateStates() by changing the definition of
+isReadyForVideoSetup() to bypass the m_isAllowedToRender check if
+the player reports a video track is present. This causes the video layer
+to be created and for future calls to prepareForRendering() to result
+in calls to mediaPlayerRenderingModeChanged().
+
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+(WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup):
+(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):
+
+2012-05-30 Lucas Forschler
+
Merge 118087
2012-05-22 Jer Noble
Modified: branches/safari-536-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (119031 => 119032)
--- branches/safari-536-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2012-05-31 03:12:49 UTC (rev 119031)
+++ branches/safari-536-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2012-05-31 03:14:38 UTC (rev 119032)
@@ -378,7 +378,10 @@
bool MediaPlayerPrivateAVFoundation::isReadyForVideoSetup() const
{
-return m_isAllowedToRender && m_readyState >= MediaPlayer::HaveMetadata && m_player->visible();
+// AVFoundation will not return true for firstVideoFrameAvailable until
+// an AVPlayerLayer has been added to the AVPlayerItem, so allow video setup
+// here if a video track to trigger allocation of a AVPlayerLayer.
+return (m_isAllowedToRender || m_cachedHasVideo) && m_readyState >= MediaPlayer::HaveMetadata && m_player->visible();
}
void MediaPlayerPrivateAVFoundation::prepareForRendering()
@@ -530,14 +533,6 @@
{
m_loadingMetadata = false;
tracksChanged();
-
-#if USE(ACCELERATED_COMPOSITING)
-// AVFoundation will not return true for firstVideoFrameAvailable until
-// an AVPlayerLayer has been added to the AVPlayerItem, so call createVideoLayer()
-// here to trigger allocation of a AVPlayerLayer.
-if (m_cachedHasVideo)
-createVideoLayer();
-#endif
}
void MediaPlayerPrivateAVFoundation::rateChanged()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119031] branches/safari-536-branch/Source/WebCore
Title: [119031] branches/safari-536-branch/Source/WebCore Revision 119031 Author lforsch...@apple.com Date 2012-05-30 20:12:49 -0700 (Wed, 30 May 2012) Log Message Merged r118087 -> Modified Paths branches/safari-536-branch/Source/WebCore/ChangeLog branches/safari-536-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp Diff Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (119030 => 119031) --- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:05:34 UTC (rev 119030) +++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:12:49 UTC (rev 119031) @@ -1,5 +1,26 @@ 2012-05-30 Lucas Forschler +Merge 118087 + +2012-05-22 Jer Noble + +REGRESSION (r98359): Video does not render on http://panic.com/dietcoda/ +https://bugs.webkit.org/show_bug.cgi?id=87171 + +Reviewed by Maciej Stachowiak. + +No new tests; behavior is very timing specific and only occurs on a subset of all platforms. + +Instead of calling prepareForRendering() from metadataLoaded(), which may fail and cause subsequent +calls to prepareForRendering() to short circuit, call createVideoLayer() directly, which achieves +the original goals of the fix for http://webkit.org/b/70448, but without breaking subsequent calls +to prepareForRendering() if called at the wrong time. + +* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: +(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): + +2012-05-30 Lucas Forschler + Merge 116319 2012-05-07 Nat Duca Modified: branches/safari-536-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (119030 => 119031) --- branches/safari-536-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2012-05-31 03:05:34 UTC (rev 119030) +++ branches/safari-536-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp 2012-05-31 03:12:49 UTC (rev 119031) @@ -531,11 +531,13 @@ m_loadingMetadata = false; tracksChanged(); +#if USE(ACCELERATED_COMPOSITING) // AVFoundation will not return true for firstVideoFrameAvailable until -// an AVPlayerLayer has been added to the AVPlayerItem, so call prepareForRendering() +// an AVPlayerLayer has been added to the AVPlayerItem, so call createVideoLayer() // here to trigger allocation of a AVPlayerLayer. if (m_cachedHasVideo) -prepareForRendering(); +createVideoLayer(); +#endif } void MediaPlayerPrivateAVFoundation::rateChanged() ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119030] trunk/Tools
Title: [119030] trunk/Tools
Revision 119030
Author sle...@apple.com
Date 2012-05-30 20:05:34 -0700 (Wed, 30 May 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=87803
Layout tests often fail trying to stat nonexistent logs
Reviewed by Dirk Pranke.
CrashReporter removes logs using a heuristic to conserve space. Wrap a
try/catch block around accessing the logs as a precaution.
* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs._find_newest_log_darwin):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py
trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (119029 => 119030)
--- trunk/Tools/ChangeLog 2012-05-31 03:05:30 UTC (rev 119029)
+++ trunk/Tools/ChangeLog 2012-05-31 03:05:34 UTC (rev 119030)
@@ -1,3 +1,16 @@
+2012-05-30 Stephanie Lewis
+
+https://bugs.webkit.org/show_bug.cgi?id=87803
+Layout tests often fail trying to stat nonexistent logs
+
+Reviewed by Dirk Pranke.
+
+CrashReporter removes logs using a heuristic to conserve space. Wrap a
+try/catch block around accessing the logs as a precaution.
+
+* Scripts/webkitpy/common/system/crashlogs.py:
+(CrashLogs._find_newest_log_darwin):
+
2012-05-30 Gavin Peters
Add a LayoutTest for prerender remove after stop.
Modified: trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py (119029 => 119030)
--- trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py 2012-05-31 03:05:30 UTC (rev 119029)
+++ trunk/Tools/Scripts/webkitpy/common/system/crashlogs.py 2012-05-31 03:05:34 UTC (rev 119030)
@@ -56,15 +56,18 @@
first_line_regex = re.compile(r'^Process:\s+(?P.*) \[(?P\d+)\]$')
errors = ''
for path in reversed(sorted(logs)):
-if not newer_than or self._host.filesystem.mtime(path) > newer_than:
-try:
+try:
+if not newer_than or self._host.filesystem.mtime(path) > newer_than:
f = self._host.filesystem.read_text_file(path)
match = first_line_regex.match(f[0:f.find('\n')])
if match and match.group('process_name') == process_name and (pid is None or int(match.group('pid')) == pid):
return errors + f
-except IOError, e:
-if include_errors:
-errors += "ERROR: Failed to read '%s': %s\n" % (path, str(e))
+except IOError, e:
+if include_errors:
+errors += "ERROR: Failed to read '%s': %s\n" % (path, str(e))
+except OSError, e:
+if include_errors:
+errors += "ERROR: Failed to read '%s': %s\n" % (path, str(e))
if include_errors and errors:
return errors
Modified: trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py (119029 => 119030)
--- trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py 2012-05-31 03:05:30 UTC (rev 119029)
+++ trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py 2012-05-31 03:05:34 UTC (rev 119030)
@@ -75,6 +75,7 @@
else:
self.assertEqual(a.splitlines(), b.splitlines())
+
def test_find_log_darwin(self):
if not SystemHost().platform.is_mac():
return
@@ -105,8 +106,17 @@
self.assertEqual(log, None)
def bad_read(path):
-raise IOError('No such file or directory')
+raise IOError('IOError: No such file or directory')
+def bad_mtime(path):
+raise OSError('OSError: No such file or directory')
+
filesystem.read_text_file = bad_read
log = crash_logs.find_newest_log("DumpRenderTree", 28531, include_errors=True)
-self.assertTrue('No such file or directory' in log)
+self.assertTrue('IOError: No such file or directory' in log)
+
+filesystem = MockFileSystem(files)
+crash_logs = CrashLogs(MockSystemHost(filesystem=filesystem))
+filesystem.mtime = bad_mtime
+log = crash_logs.find_newest_log("DumpRenderTree", newer_than=1.0, include_errors=True)
+self.assertTrue('OSError: No such file or directory' in log)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119029] branches/safari-536-branch/Source
Title: [119029] branches/safari-536-branch/Source Revision 119029 Author lforsch...@apple.com Date 2012-05-30 20:05:30 -0700 (Wed, 30 May 2012) Log Message Merged r116319 -> Modified Paths branches/safari-536-branch/Source/WebCore/ChangeLog branches/safari-536-branch/Source/WebKit/chromium/ChangeLog Diff Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (119028 => 119029) --- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:04:00 UTC (rev 119028) +++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-05-31 03:05:30 UTC (rev 119029) @@ -1,5 +1,54 @@ 2012-05-30 Lucas Forschler +Merge 116319 + +2012-05-07 Nat Duca + +Unreviewed, rolling out r115525. +http://trac.webkit.org/changeset/115525 +https://bugs.webkit.org/show_bug.cgi?id=66683 + +Too many pages rely on DOMTimeStamp as first argument. +Reverting while we consider next steps. + +* WebCore.exp.in: +* bindings/js/JSRequestAnimationFrameCallbackCustom.cpp: +(WebCore::JSRequestAnimationFrameCallback::handleEvent): +* dom/Document.cpp: +(WebCore::Document::serviceScriptedAnimations): +* dom/Document.h: +(Document): +* dom/RequestAnimationFrameCallback.h: +(RequestAnimationFrameCallback): +* dom/RequestAnimationFrameCallback.idl: +* dom/ScriptedAnimationController.cpp: +(WebCore::ScriptedAnimationController::ScriptedAnimationController): +(WebCore::ScriptedAnimationController::serviceScriptedAnimations): +(WebCore): +(WebCore::ScriptedAnimationController::windowScreenDidChange): +(WebCore::ScriptedAnimationController::scheduleAnimation): +(WebCore::ScriptedAnimationController::animationTimerFired): +* dom/ScriptedAnimationController.h: +(ScriptedAnimationController): +(WebCore::ScriptedAnimationController::displayRefreshFired): +* page/FrameView.cpp: +(WebCore::FrameView::serviceScriptedAnimations): +* page/FrameView.h: +(FrameView): +* platform/graphics/DisplayRefreshMonitor.cpp: +(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor): +(WebCore::DisplayRefreshMonitor::notifyClients): +* platform/graphics/DisplayRefreshMonitor.h: +(DisplayRefreshMonitor): +* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: +(WebCore::DisplayRefreshMonitor::displayLinkFired): +* platform/graphics/mac/DisplayRefreshMonitorMac.cpp: +(WebCore): +(WebCore::DisplayRefreshMonitor::requestRefreshCallback): +(WebCore::DisplayRefreshMonitor::displayLinkFired): + +2012-05-30 Lucas Forschler + Rollout 115573 2012-04-28 Alexander Pavlov Modified: branches/safari-536-branch/Source/WebKit/chromium/ChangeLog (119028 => 119029) --- branches/safari-536-branch/Source/WebKit/chromium/ChangeLog 2012-05-31 03:04:00 UTC (rev 119028) +++ branches/safari-536-branch/Source/WebKit/chromium/ChangeLog 2012-05-31 03:05:30 UTC (rev 119029) @@ -1,3 +1,21 @@ +2012-05-30 Lucas Forschler + +Merge 116319 + +2012-05-07 Nat Duca + +Unreviewed, rolling out r115525. +http://trac.webkit.org/changeset/115525 +https://bugs.webkit.org/show_bug.cgi?id=66683 + +Too many pages rely on DOMTimeStamp as first argument. +Reverting while we consider next steps. + +* src/PageWidgetDelegate.cpp: +(WebKit::PageWidgetDelegate::animate): +* src/WebViewImpl.cpp: +(WebKit::WebViewImpl::updateAnimations): + 2012-05-23 Lucas Forschler Merge 116319 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119028] trunk/Source/JavaScriptCore
Title: [119028] trunk/Source/_javascript_Core Revision 119028 Author mhahnenb...@apple.com Date 2012-05-30 20:04:00 -0700 (Wed, 30 May 2012) Log Message Heap should sweep incrementally https://bugs.webkit.org/show_bug.cgi?id=85429 We shouldn't have to wait for the opportunistic GC timer to fire in order to call object destructors. Instead, we should incrementally sweep some subset of the blocks requiring sweeping periodically. We tie this sweeping to a timer rather than to collections because we want to reclaim this memory even if we stop allocating. This way, our memory usage scales smoothly with actual use, regardless of whether we've recently done an opportunistic GC or not. Reviewed by Geoffrey Garen. * CMakeLists.txt: * GNUmakefile.list.am: * _javascript_Core.gypi: * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj: * _javascript_Core.xcodeproj/project.pbxproj: * Target.pri: * heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::collect): We no longer sweep during a full sweep. We only shrink now, which we will switch over to being done during incremental sweeping too as soon as all finalizers can be run lazily (and, by extension, incrementally). (JSC::Heap::sweeper): (JSC): * heap/Heap.h: (JSC): (Heap): * heap/IncrementalSweeper.cpp: Added. (JSC): (JSC::IncrementalSweeper::timerDidFire): The IncrementalSweeper works very similarly to GCActivityCallback. It is tied to a run-loop based timer that fires periodically based on how long the previous sweep increment took to run. The IncrementalSweeper doesn't do anything if the platform doesn't support CoreFoundation. (JSC::IncrementalSweeper::IncrementalSweeper): (JSC::IncrementalSweeper::~IncrementalSweeper): (JSC::IncrementalSweeper::create): (JSC::IncrementalSweeper::scheduleTimer): (JSC::IncrementalSweeper::cancelTimer): (JSC::IncrementalSweeper::doSweep): Iterates over the snapshot of the MarkedSpace taken during the last collection, checking to see which blocks need sweeping. If it successfully gets to the end of the blocks that need sweeping then it cancels the timer. (JSC::IncrementalSweeper::startSweeping): We take a snapshot of the Heap and store it in a Vector that the incremental sweep will iterate over. We also reset our index into this Vector. * heap/IncrementalSweeper.h: Added. (JSC): (IncrementalSweeper): * heap/MarkedBlock.h: (JSC::MarkedBlock::needsSweeping): If a block is in the Marked state it needs sweeping to be usable and to run any destructors that need to be run. Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/_javascript_Core/_javascript_Core.gypi trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/Target.pri trunk/Source/_javascript_Core/heap/Heap.cpp trunk/Source/_javascript_Core/heap/Heap.h trunk/Source/_javascript_Core/heap/MarkedBlock.h Added Paths trunk/Source/_javascript_Core/heap/IncrementalSweeper.cpp trunk/Source/_javascript_Core/heap/IncrementalSweeper.h Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (119027 => 119028) --- trunk/Source/_javascript_Core/CMakeLists.txt 2012-05-31 02:58:48 UTC (rev 119027) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2012-05-31 03:04:00 UTC (rev 119028) @@ -97,6 +97,7 @@ heap/HandleSet.cpp heap/HandleStack.cpp heap/Heap.cpp +heap/IncrementalSweeper.cpp heap/MachineStackMarker.cpp heap/MarkedAllocator.cpp heap/MarkedBlock.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (119027 => 119028) --- trunk/Source/_javascript_Core/ChangeLog 2012-05-31 02:58:48 UTC (rev 119027) +++ trunk/Source/_javascript_Core/ChangeLog 2012-05-31 03:04:00 UTC (rev 119028) @@ -1,3 +1,56 @@ +2012-05-30 Mark Hahnenberg + +Heap should sweep incrementally +https://bugs.webkit.org/show_bug.cgi?id=85429 + +We shouldn't have to wait for the opportunistic GC timer to fire in order +to call object destructors. Instead, we should incrementally sweep some +subset of the blocks requiring sweeping periodically. We tie this sweeping +to a timer rather than to collections because we want to reclaim this memory +even if we stop allocating. This way, our memory usage scales smoothly with +actual use, regardless of whether we've recently done an opportunistic GC or not. + +Reviewed by Geoffrey Garen. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* _javascript_Core.gypi: +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj: +* _javascript_Core.xcodeproj/project.pbxproj: +* Target.pri: +* heap/Heap.cpp: +(JSC::Heap::Heap): +(JSC::Heap::collect): We no longer sweep during a full sweep. We only shrink now, +
[webkit-changes] [119027] trunk
Title: [119027] trunk
Revision 119027
Author commit-qu...@webkit.org
Date 2012-05-30 19:58:48 -0700 (Wed, 30 May 2012)
Log Message
[JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be found in transferred ports
https://bugs.webkit.org/show_bug.cgi?id=87118
Patch by Christophe Dumez on 2012-05-30
Reviewed by Adam Barth.
Source/WebCore:
Make SerializedScriptValue.create() throw an exception if one of the
MessagePort objects cannot be found in the transferred ports. This
matches the behavior of the V8 implementation.
Test: webintents/web-intents-obj-constructor.html
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
LayoutTests:
Unskip webintents/web-intents-obj-constructor.html now that
SerializedScriptValue.create() throws an exception if one of the
MessagePort objects cannot be found in the transferred ports.
* platform/efl/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (119026 => 119027)
--- trunk/LayoutTests/ChangeLog 2012-05-31 02:53:48 UTC (rev 119026)
+++ trunk/LayoutTests/ChangeLog 2012-05-31 02:58:48 UTC (rev 119027)
@@ -1,3 +1,16 @@
+2012-05-30 Christophe Dumez
+
+[JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be found in transferred ports
+https://bugs.webkit.org/show_bug.cgi?id=87118
+
+Reviewed by Adam Barth.
+
+Unskip webintents/web-intents-obj-constructor.html now that
+SerializedScriptValue.create() throws an exception if one of the
+MessagePort objects cannot be found in the transferred ports.
+
+* platform/efl/test_expectations.txt:
+
2012-05-30 Jessie Berlin
[Win] Need results for ietestcenter CSS3 tests
Modified: trunk/LayoutTests/platform/efl/test_expectations.txt (119026 => 119027)
--- trunk/LayoutTests/platform/efl/test_expectations.txt 2012-05-31 02:53:48 UTC (rev 119026)
+++ trunk/LayoutTests/platform/efl/test_expectations.txt 2012-05-31 02:58:48 UTC (rev 119027)
@@ -651,7 +651,6 @@
// Incomplete Web Intents support
BUGWK86866 SKIP : webintents/intent-tag.html = TEXT
BUGWK86865 SKIP : webintents/web-intents-delivery.html = TEXT
-BUGWK87118 : webintents/web-intents-obj-constructor.html = TEXT
// EFL's LayoutTestController does not implement setAutomaticLinkDetectionEnabled
BUGWK85463 SKIP : editing/inserting/typing-space-to-trigger-smart-link.html = FAIL
Modified: trunk/Source/WebCore/ChangeLog (119026 => 119027)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 02:53:48 UTC (rev 119026)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 02:58:48 UTC (rev 119027)
@@ -1,3 +1,19 @@
+2012-05-30 Christophe Dumez
+
+[JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be found in transferred ports
+https://bugs.webkit.org/show_bug.cgi?id=87118
+
+Reviewed by Adam Barth.
+
+Make SerializedScriptValue.create() throw an exception if one of the
+MessagePort objects cannot be found in the transferred ports. This
+matches the behavior of the V8 implementation.
+
+Test: webintents/web-intents-obj-constructor.html
+
+* bindings/js/SerializedScriptValue.cpp:
+(WebCore::CloneSerializer::dumpIfTerminal):
+
2012-05-30 Mark Pilgrim
[Chromium] Call fileUtilities methods directly
Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (119026 => 119027)
--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2012-05-31 02:53:48 UTC (rev 119026)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2012-05-31 02:58:48 UTC (rev 119027)
@@ -634,7 +634,9 @@
write(index->second);
return true;
}
-return false;
+// MessagePort object could not be found in transferred message ports
+code = ValidationError;
+return true;
}
if (obj->inherits(&JSArrayBuffer::s_info)) {
RefPtr arrayBuffer = toArrayBuffer(obj);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119024] trunk/Source
Title: [119024] trunk/Source
Revision 119024
Author pilg...@chromium.org
Date 2012-05-30 19:31:36 -0700 (Wed, 30 May 2012)
Log Message
[Chromium] Call fileUtilities methods directly
https://bugs.webkit.org/show_bug.cgi?id=87852
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
* platform/chromium/FileSystemChromium.cpp:
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::getFileMetadata):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/DragDataChromium.cpp
trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (119023 => 119024)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 02:24:22 UTC (rev 119023)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 02:31:36 UTC (rev 119024)
@@ -1,3 +1,32 @@
+2012-05-30 Mark Pilgrim
+
+[Chromium] Call fileUtilities methods directly
+https://bugs.webkit.org/show_bug.cgi?id=87852
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* platform/chromium/DragDataChromium.cpp:
+(WebCore::DragData::asURL):
+* platform/chromium/FileSystemChromium.cpp:
+(WebCore::deleteFile):
+(WebCore::deleteEmptyDirectory):
+(WebCore::getFileSize):
+(WebCore::getFileModificationTime):
+(WebCore::getFileMetadata):
+(WebCore::directoryName):
+(WebCore::pathByAppendingComponent):
+(WebCore::makeAllDirectories):
+(WebCore::openFile):
+(WebCore::closeFile):
+(WebCore::seekFile):
+(WebCore::truncateFile):
+(WebCore::readFromFile):
+(WebCore::writeToFile):
+* platform/chromium/PlatformSupport.h:
+(PlatformSupport):
+
2012-05-30 Kent Tamura
Form controls in should not be focusable.
Modified: trunk/Source/WebCore/platform/chromium/DragDataChromium.cpp (119023 => 119024)
--- trunk/Source/WebCore/platform/chromium/DragDataChromium.cpp 2012-05-31 02:24:22 UTC (rev 119023)
+++ trunk/Source/WebCore/platform/chromium/DragDataChromium.cpp 2012-05-31 02:31:36 UTC (rev 119024)
@@ -38,9 +38,11 @@
#include "KURL.h"
#include "NotImplemented.h"
#include "PlatformString.h"
-#include "PlatformSupport.h"
#include "markup.h"
+#include
+#include
+
namespace WebCore {
static bool containsHTML(const ChromiumDataObject* dropData)
@@ -60,7 +62,8 @@
if (m_platformDragData->types().contains(mimeTypeTextURIList))
m_platformDragData->urlAndTitle(url, title);
else if (filenamePolicy == ConvertFilenames && containsFiles()) {
-url = ""
+String path = String(WebKit::Platform::current()->fileUtilities()->getAbsolutePath(m_platformDragData->filenames()[0]));
+url = ""
}
return url;
}
Modified: trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp (119023 => 119024)
--- trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp 2012-05-31 02:24:22 UTC (rev 119023)
+++ trunk/Source/WebCore/platform/chromium/FileSystemChromium.cpp 2012-05-31 02:31:36 UTC (rev 119024)
@@ -34,27 +34,27 @@
#include "FileMetadata.h"
#include "NotImplemented.h"
#include "PlatformString.h"
-#include "PlatformSupport.h"
#include
+#include
#include
namespace WebCore {
bool deleteFile(const String& path)
{
-return PlatformSupport::deleteFile(path);
+return WebKit::Platform::current()->fileUtilities()->deleteFile(path);
}
bool deleteEmptyDirectory(const String& path)
{
-return PlatformSupport::deleteEmptyDirectory(path);
+return WebKit::Platform::current()->fileUtilities()->deleteEmptyDirectory(path);
}
bool getFileSize(const String& path, long long& result)
{
FileMetadata metadata;
-if (!PlatformSupport::getFileMetadata(path, metadata))
+if (!getFileMetadata(path, metadata))
return false;
result = metadata.length;
return true;
@@ -63,7 +63,7 @@
bool getFileModificationTime(const String& path, time_t& result)
{
FileMetadata metadata;
-if (!PlatformSupport::getFileMetadata(path, metadata))
+if (!getFileMetadata(path, metadata))
return false;
result = metadata.modificationTime;
return true;
@@ -71,22 +71,28 @@
bool getFileMetadata(const String& path, FileMetadat
[webkit-changes] [119023] trunk
Title: [119023] trunk Revision 119023 Author tk...@chromium.org Date 2012-05-30 19:24:22 -0700 (Wed, 30 May 2012) Log Message Form controls in should not be focusable. https://bugs.webkit.org/show_bug.cgi?id=87380 Reviewed by Darin Adler. Source/WebCore: Test: fast/forms/fieldset/focus-in-fieldset-disabled.html * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::supportsFocus): Refer to disabled() instead of m_disabled to take account of wrapping fieldset elements. LayoutTests: * fast/forms/fieldset/fieldset-disabled-expected.txt: * fast/forms/fieldset/fieldset-disabled.html: Updated because disabled controls are not focusable. Also, remove testing elements to remove unnecessary blank lines. * fast/forms/fieldset/focus-in-fieldset-disabled-expected.txt: Added. * fast/forms/fieldset/focus-in-fieldset-disabled.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/fieldset/fieldset-disabled-expected.txt trunk/LayoutTests/fast/forms/fieldset/fieldset-disabled.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLFormControlElement.cpp Added Paths trunk/LayoutTests/fast/forms/fieldset/focus-in-fieldset-disabled-expected.txt trunk/LayoutTests/fast/forms/fieldset/focus-in-fieldset-disabled.html Diff Modified: trunk/LayoutTests/ChangeLog (119022 => 119023) --- trunk/LayoutTests/ChangeLog 2012-05-31 02:17:42 UTC (rev 119022) +++ trunk/LayoutTests/ChangeLog 2012-05-31 02:24:22 UTC (rev 119023) @@ -1,3 +1,17 @@ +2012-05-30 Kent Tamura + +Form controls in should not be focusable. +https://bugs.webkit.org/show_bug.cgi?id=87380 + +Reviewed by Darin Adler. + +* fast/forms/fieldset/fieldset-disabled-expected.txt: +* fast/forms/fieldset/fieldset-disabled.html: +Updated because disabled controls are not focusable. +Also, remove testing elements to remove unnecessary blank lines. +* fast/forms/fieldset/focus-in-fieldset-disabled-expected.txt: Added. +* fast/forms/fieldset/focus-in-fieldset-disabled.html: Added. + 2012-05-30 Hayato Ito Fix a composed-shadow-tree-walker.html so that it uses correct selectors. Modified: trunk/LayoutTests/fast/forms/fieldset/fieldset-disabled-expected.txt (119022 => 119023) --- trunk/LayoutTests/fast/forms/fieldset/fieldset-disabled-expected.txt 2012-05-31 02:17:42 UTC (rev 119022) +++ trunk/LayoutTests/fast/forms/fieldset/fieldset-disabled-expected.txt 2012-05-31 02:24:22 UTC (rev 119023) @@ -9,7 +9,7 @@ PASS parserGeneratedInput2.value is "M" PASS parserGeneratedInput3.value is "NO" PASS parserGeneratedInput4.value is "" -PASS parserGeneratedInput5.value is "P" +PASS parserGeneratedInput5.value is "PQRST" PASS parserGeneratedInput6.value is "" PASS parserGeneratedInput7.value is "" PASS parserGeneratedInput8.value is "" @@ -56,52 +56,39 @@ PASS innerTextInput.value is "F" Disabling the inner fieldset only. PASS innerFieldSet.disabled is true -PASS outerTextInput.value is "FG" +PASS outerTextInput.value is "FGG" PASS innerTextInput.value is "F" Enabling the inner and disabling the outer fieldset. PASS outerFieldSet.disabled is true PASS innerFieldSet.disabled is false -PASS outerTextInput.value is "FG" +PASS outerTextInput.value is "FGG" PASS innerTextInput.value is "F" Disabling both fieldset elements. PASS outerFieldSet.disabled is true PASS innerFieldSet.disabled is true -PASS outerTextInput.value is "FG" +PASS outerTextInput.value is "FGG" PASS innerTextInput.value is "F" Enabling both fieldset elements. PASS outerFieldSet.disabled is false PASS innerFieldSet.disabled is false -PASS outerTextInput.value is "FGH" +PASS outerTextInput.value is "FGGH" PASS innerTextInput.value is "FH" Test behavior of the first legend element in a fieldset elements. Children of the first legend element in a fieldset should not get disabled with the fieldset. PASS legendFieldSet.disabled is true -PASS firstLegendTextInput.value is "I" +PASS firstLegendTextInput.value is "II" PASS secondLegendTextInput.value is "" Insert another legend element before the currently first one, and check again. -PASS insertedLegendTextInput.value is "J" -PASS firstLegendTextInput.value is "I" +PASS insertedLegendTextInput.value is "JJJ" +PASS firstLegendTextInput.value is "II" PASS secondLegendTextInput.value is "" Enable the fieldset again and check for sanity. PASS legendFieldSet.disabled is false -PASS insertedLegendTextInput.value is "JK" -PASS firstLegendTextInput.value is "IK" +PASS insertedLegendTextInput.value is "JJJK" +PASS firstLegendTextInput.value is "IIK" PASS secondLegendTextInput.value is "K" PASS successfullyParsed is true TEST COMPLETE - - - - - - - - - - - - - Modified: trunk/LayoutTests/fast/forms/fieldset/fieldset-disabled.html (119022 => 119023) --- trunk/LayoutTests/fast/forms/fieldset/fieldset-disabled.html 2012-05-31 02:17:42 UTC (rev 119022) +++ trunk/LayoutTests/fast/forms/fieldset/f
[webkit-changes] [119022] trunk/LayoutTests
Title: [119022] trunk/LayoutTests
Revision 119022
Author hay...@chromium.org
Date 2012-05-30 19:17:42 -0700 (Wed, 30 May 2012)
Log Message
Fix a composed-shadow-tree-walker.html so that it uses correct selectors.
https://bugs.webkit.org/show_bug.cgi?id=87500
Reviewed by Dimitri Glazkov.
Fix a test and an expectation for composed-shadow-tree-walker.html.
A current composed-shadow-tree-walker.html uses class selector
(.class). That's not the test author's intention and the expected
text was wrongly generated based on wrong tests.
* fast/dom/shadow/composed-shadow-tree-walker-expected.txt:
* fast/dom/shadow/composed-shadow-tree-walker.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-expected.txt
trunk/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker.html
Diff
Modified: trunk/LayoutTests/ChangeLog (119021 => 119022)
--- trunk/LayoutTests/ChangeLog 2012-05-31 02:03:00 UTC (rev 119021)
+++ trunk/LayoutTests/ChangeLog 2012-05-31 02:17:42 UTC (rev 119022)
@@ -1,3 +1,18 @@
+2012-05-30 Hayato Ito
+
+Fix a composed-shadow-tree-walker.html so that it uses correct selectors.
+https://bugs.webkit.org/show_bug.cgi?id=87500
+
+Reviewed by Dimitri Glazkov.
+
+Fix a test and an expectation for composed-shadow-tree-walker.html.
+A current composed-shadow-tree-walker.html uses class selector
+(.class). That's not the test author's intention and the expected
+text was wrongly generated based on wrong tests.
+
+* fast/dom/shadow/composed-shadow-tree-walker-expected.txt:
+* fast/dom/shadow/composed-shadow-tree-walker.html:
+
2012-05-30 Gavin Peters
Add a LayoutTest for prerender remove after stop.
Modified: trunk/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-expected.txt (119021 => 119022)
--- trunk/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-expected.txt 2012-05-31 02:03:00 UTC (rev 119021)
+++ trunk/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-expected.txt 2012-05-31 02:17:42 UTC (rev 119022)
@@ -37,24 +37,36 @@
Composed Shadow Tree:
DIV id=a
DIV id=b
+ DIV id=d
Traverse in forward.
DIV id=a
+DIV id=b
+DIV id=d
Traverse in backward.
+DIV id=d
+DIV id=b
DIV id=a
Light children should be selected only at once.
Composed Shadow Tree:
DIV id=a
DIV id=b
+ DIV id=d
+ DIV id=c
+ DIV id=e
Traverse in forward.
DIV id=a
DIV id=b
+DIV id=d
+DIV id=c
+DIV id=e
Traverse in backward.
DIV id=e
+DIV id=c
DIV id=d
-DIV id=c
+DIV id=b
DIV id=a
A content element can have fallback elements.
@@ -79,17 +91,14 @@
Composed Shadow Tree:
DIV id=a
DIV id=b
- DIV id=f1
- DIV id=f2
+ DIV id=c
Traverse in forward.
DIV id=a
DIV id=b
-DIV id=f1
-DIV id=f2
+DIV id=c
Traverse in backward.
-DIV id=f2
-DIV id=f1
+DIV id=c
DIV id=b
DIV id=a
Modified: trunk/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker.html (119021 => 119022)
--- trunk/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker.html 2012-05-31 02:03:00 UTC (rev 119021)
+++ trunk/LayoutTests/fast/dom/shadow/composed-shadow-tree-walker.html 2012-05-31 02:17:42 UTC (rev 119022)
@@ -98,7 +98,7 @@
showComposedShadowTree(
createDOM('div', {'id': 'a'},
createShadowRoot(createDOM('div', {'id': 'b'}),
- createDOM('content', {'select': '.d'})),
+ createDOM('content', {'select': '#d'})),
createDOM('div', {'id': 'c'}),
createDOM('div', {'id': 'd'}),
createDOM('div', {'id': 'e'})));
@@ -107,7 +107,7 @@
showComposedShadowTree(
createDOM('div', {'id': 'a'},
createShadowRoot(createDOM('div', {'id': 'b'}),
- createDOM('content', {'select': '.d'}),
+ createDOM('content', {'select': '#d'}),
createDOM('content')),
createDOM('div', {'id': 'c'}),
createDOM('div', {'id': 'd'}),
@@ -117,7 +117,7 @@
showComposedShadowTree(
createDOM('div', {'id': 'a'},
createShadowRoot(createDOM('div', {'id': 'b'}),
- createDOM('content', {'select': '.z'},
+ createDOM('content', {'select': '#z'},
createDOM('div', {'id': 'f1'}),
createDOM('div', {'id': 'f2'}))),
createDOM('div', {'id': 'c'})));
@@ -126,7 +126,7 @@
showComposedShadowTree(
createDOM('div', {'id': 'a'},
createShadowRoot(createDOM('div', {'id': 'b'}),
- createDOM('content', {'select': '.c'},
+ createDOM('content', {'select': '#c'},
createDOM('div', {'id': 'f1'}),
createDO
[webkit-changes] [119021] trunk/Source/WebCore
Title: [119021] trunk/Source/WebCore
Revision 119021
Author kev...@webkit.org
Date 2012-05-30 19:03:00 -0700 (Wed, 30 May 2012)
Log Message
[wx] Implement HTML clipboard support.
https://bugs.webkit.org/show_bug.cgi?id=87883
Reviewed by Kevin Ollivier.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/wx/ClipboardWx.cpp
trunk/Source/WebCore/platform/wx/PasteboardWx.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (119020 => 119021)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 02:01:50 UTC (rev 119020)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 02:03:00 UTC (rev 119021)
@@ -1,3 +1,16 @@
+2012-05-30 Robin Dunn
+
+[wx] Implement HTML clipboard support.
+https://bugs.webkit.org/show_bug.cgi?id=87883
+
+Reviewed by Kevin Ollivier.
+
+* platform/wx/ClipboardWx.cpp:
+(WebCore::ClipboardWx::writeRange):
+* platform/wx/PasteboardWx.cpp:
+(WebCore::Pasteboard::writeSelection):
+(WebCore::Pasteboard::documentFragment):
+
2012-05-30 Garrett Casto
TextFieldDecorationElement should respect style attribute
Modified: trunk/Source/WebCore/platform/wx/ClipboardWx.cpp (119020 => 119021)
--- trunk/Source/WebCore/platform/wx/ClipboardWx.cpp 2012-05-31 02:01:50 UTC (rev 119020)
+++ trunk/Source/WebCore/platform/wx/ClipboardWx.cpp 2012-05-31 02:03:00 UTC (rev 119021)
@@ -26,7 +26,9 @@
#include "config.h"
#include "ClipboardWx.h"
+#include "Editor.h"
#include "FileList.h"
+#include "Frame.h"
#include "HashTable.h"
#include "IntPoint.h"
#include "NotImplemented.h"
@@ -127,9 +129,9 @@
Pasteboard::generalPasteboard()->writeURL(url, string, frame);
}
-void ClipboardWx::writeRange(Range*, Frame*)
+void ClipboardWx::writeRange(Range* range, Frame* frame)
{
-notImplemented();
+Pasteboard::generalPasteboard()->writeSelection(range, frame->editor()->smartInsertDeleteEnabled() && frame->selection()->granularity() == WordGranularity, frame);
}
bool ClipboardWx::hasData()
Modified: trunk/Source/WebCore/platform/wx/PasteboardWx.cpp (119020 => 119021)
--- trunk/Source/WebCore/platform/wx/PasteboardWx.cpp 2012-05-31 02:01:50 UTC (rev 119020)
+++ trunk/Source/WebCore/platform/wx/PasteboardWx.cpp 2012-05-31 02:03:00 UTC (rev 119021)
@@ -53,7 +53,10 @@
void Pasteboard::writeSelection(Range* selectedRange, bool canSmartCopyOrDelete, Frame* frame)
{
if (wxTheClipboard->Open()) {
-wxTheClipboard->SetData( new wxTextDataObject(frame->editor()->selectedText()) );
+#if wxCHECK_VERSION(2, 9, 4)
+wxTheClipboard->SetData(new wxHTMLDataObject(createMarkup(selectedRange, 0, AnnotateForInterchange)));
+#endif
+wxTheClipboard->SetData(new wxTextDataObject(frame->editor()->selectedText()));
wxTheClipboard->Close();
}
}
@@ -91,11 +94,21 @@
{
RefPtr fragment = 0;
if (wxTheClipboard->Open()) {
-if (allowPlainText && wxTheClipboard->IsSupported( wxDF_TEXT )) {
-wxTextDataObject data;
-wxTheClipboard->GetData( data );
-chosePlainText = true;
-fragment = createFragmentFromText(context.get(), data.GetText());
+#if wxCHECK_VERSION(2, 9, 4)
+if (wxTheClipboard->IsSupported(wxDF_HTML)) {
+wxHTMLDataObject data;
+wxTheClipboard->GetData(data);
+chosePlainText = false;
+fragment = createFragmentFromMarkup(frame->document(), data.GetHTML(), "", FragmentScriptingNotAllowed);
+} else
+#endif
+{
+if (allowPlainText && wxTheClipboard->IsSupported( wxDF_TEXT )) {
+wxTextDataObject data;
+wxTheClipboard->GetData( data );
+chosePlainText = true;
+fragment = createFragmentFromText(context.get(), data.GetText());
+}
}
wxTheClipboard->Close();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119020] trunk/Source/WebCore
Title: [119020] trunk/Source/WebCore
Revision 119020
Author commit-qu...@webkit.org
Date 2012-05-30 19:01:50 -0700 (Wed, 30 May 2012)
Log Message
TextFieldDecorationElement should respect style attribute
https://bugs.webkit.org/show_bug.cgi?id=87762
Patch by Garrett Casto on 2012-05-30
Reviewed by Kent Tamura.
* html/shadow/TextFieldDecorationElement.cpp: Use style set on the
Element when creating rendering style.
(WebCore::TextFieldDecorationElement::customStyleForRenderer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (119019 => 119020)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 01:54:50 UTC (rev 119019)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 02:01:50 UTC (rev 119020)
@@ -1,3 +1,14 @@
+2012-05-30 Garrett Casto
+
+TextFieldDecorationElement should respect style attribute
+https://bugs.webkit.org/show_bug.cgi?id=87762
+
+Reviewed by Kent Tamura.
+
+* html/shadow/TextFieldDecorationElement.cpp: Use style set on the
+Element when creating rendering style.
+(WebCore::TextFieldDecorationElement::customStyleForRenderer):
+
2012-05-30 Ojan Vafai
Avoid second layout for flex-direction:row, flex-basis:auto flex items
Modified: trunk/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp (119019 => 119020)
--- trunk/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp 2012-05-31 01:54:50 UTC (rev 119019)
+++ trunk/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp 2012-05-31 02:01:50 UTC (rev 119020)
@@ -40,6 +40,7 @@
#include "NodeRenderStyle.h"
#include "RenderImage.h"
#include "ShadowRoot.h"
+#include "StyleResolver.h"
namespace WebCore {
@@ -143,7 +144,8 @@
PassRefPtr TextFieldDecorationElement::customStyleForRenderer()
{
-RefPtr style = RenderStyle::create();
+RefPtr originalStyle = document()->styleResolver()->styleForElement(this);
+RefPtr style = RenderStyle::clone(originalStyle.get());
RenderStyle* inputStyle = hostInput()->renderStyle();
ASSERT(inputStyle);
style->setWidth(Length(inputStyle->fontSize(), Fixed));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119019] trunk
Title: [119019] trunk
Revision 119019
Author gav...@chromium.org
Date 2012-05-30 18:54:50 -0700 (Wed, 30 May 2012)
Log Message
Add a LayoutTest for prerender remove after stop.
https://bugs.webkit.org/show_bug.cgi?id=87860
Tools:
These very boring mocks in DumpRenderTree mean that the basic Prerendering API
can be tested by LayoutTests now.
Reviewed by Adam Barth.
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
(MockWebPrerenderingSupport::MockWebPrerenderingSupport):
(MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
(MockWebPrerenderingSupport::add):
(MockWebPrerenderingSupport::cancel):
(MockWebPrerenderingSupport::abandon):
* DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
(MockWebPrerenderingSupport):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willAddPrerender):
(WebViewHost::setWebWidget):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
LayoutTests:
Bug 87746 was uploaded without a LayoutTest because I originally thought
it would only be testable in Chrome with a browser test. However, that was
wrong.
Note that this test doesn't need to be disabled based on if the platform
uses Prerendering, since the test is for a crash, which won't happen on
platforms without prerendering, either.
Reviewed by Adam Barth.
* fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt: Added.
* fast/dom/HTMLLinkElement/prerender-remove-after-stop.html: Added.
* fast/dom/HTMLLinkElement/resources/empty.html: Added.
* fast/dom/HTMLLinkElement/resources/simple-prerender.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gypi
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h
Added Paths
trunk/LayoutTests/fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt
trunk/LayoutTests/fast/dom/HTMLLinkElement/prerender-remove-after-stop.html
trunk/LayoutTests/fast/dom/HTMLLinkElement/resources/empty.html
trunk/LayoutTests/fast/dom/HTMLLinkElement/resources/simple-prerender.html
trunk/Tools/DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp
trunk/Tools/DumpRenderTree/chromium/MockWebPrerenderingSupport.h
Diff
Modified: trunk/LayoutTests/ChangeLog (119018 => 119019)
--- trunk/LayoutTests/ChangeLog 2012-05-31 01:51:50 UTC (rev 119018)
+++ trunk/LayoutTests/ChangeLog 2012-05-31 01:54:50 UTC (rev 119019)
@@ -1,3 +1,23 @@
+2012-05-30 Gavin Peters
+
+Add a LayoutTest for prerender remove after stop.
+https://bugs.webkit.org/show_bug.cgi?id=87860
+
+Bug 87746 was uploaded without a LayoutTest because I originally thought
+it would only be testable in Chrome with a browser test. However, that was
+wrong.
+
+Note that this test doesn't need to be disabled based on if the platform
+uses Prerendering, since the test is for a crash, which won't happen on
+platforms without prerendering, either.
+
+Reviewed by Adam Barth.
+
+* fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt: Added.
+* fast/dom/HTMLLinkElement/prerender-remove-after-stop.html: Added.
+* fast/dom/HTMLLinkElement/resources/empty.html: Added.
+* fast/dom/HTMLLinkElement/resources/simple-prerender.html: Added.
+
2012-05-30 Zhenyao Mo
WebKit incorrectly clears the alpha channel on readPixels, even for Framebuffers
Added: trunk/LayoutTests/fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt (0 => 119019)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt 2012-05-31 01:54:50 UTC (rev 119019)
@@ -0,0 +1,4 @@
+Test navigation and removal of link prerender elements
+
+
+This test succeeds when it does not crash. The iframe above this text should also not crash, and should show an empty page.
Added: trunk/LayoutTests/fast/dom/HTMLLinkElement/prerender-remove-after-stop.html (0 => 119019)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/prerender-remove-after-stop.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/prerender-remove-after-stop.html 2012-05-31 01:54:50 UTC (rev 119019)
@@ -0,0 +1,38 @@
+
+
+
+
+function done() {
+ if (window.layoutTestController) {
+ layoutTestController.notifyDone();
+ }
+}
+
+function elementRemover(doc, id) {
+return function() {
+var element = doc.getElementById(id);
+element.parentNode.removeChild(element);
+setTimeout(done, 0);
+}
+}
+
+function navigateIFrameThenRemoveLink() {
+var iframe
[webkit-changes] [119018] trunk/Tools
Title: [119018] trunk/Tools
Revision 119018
Author sle...@apple.com
Date 2012-05-30 18:51:50 -0700 (Wed, 30 May 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=87717
Unresponsive WebProcesses can be mistaken for WebProcess crashes.
Reviewed by Dirk Pranke.
Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
If there isn't a crash log found for the process add a message saying
the process was unresponsive.
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.__init__):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_check_for_driver_crash.assert_crash):
(WebKitDriverTest):
(WebKitDriverTest.test_check_for_driver_crash):
* WebKitTestRunner/TestController.cpp:
(WTR):
(WTR::TestController::runTest):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py
trunk/Tools/WebKitTestRunner/TestController.cpp
Diff
Modified: trunk/Tools/ChangeLog (119017 => 119018)
--- trunk/Tools/ChangeLog 2012-05-31 01:51:26 UTC (rev 119017)
+++ trunk/Tools/ChangeLog 2012-05-31 01:51:50 UTC (rev 119018)
@@ -1,5 +1,28 @@
2012-05-30 Stephanie Lewis
+https://bugs.webkit.org/show_bug.cgi?id=87717
+Unresponsive WebProcesses can be mistaken for WebProcess crashes.
+
+Reviewed by Dirk Pranke.
+
+Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
+If there isn't a crash log found for the process add a message saying
+the process was unresponsive.
+
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitDriver.__init__):
+(WebKitDriver._check_for_driver_crash):
+(WebKitDriver.run_test):
+* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+(WebKitDriverTest.test_check_for_driver_crash.assert_crash):
+(WebKitDriverTest):
+(WebKitDriverTest.test_check_for_driver_crash):
+* WebKitTestRunner/TestController.cpp:
+(WTR):
+(WTR::TestController::runTest):
+
+2012-05-30 Stephanie Lewis
+
https://bugs.webkit.org/show_bug.cgi?id=87714
Mac crash logs can take a really long time to be written out.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (119017 => 119018)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2012-05-31 01:51:26 UTC (rev 119017)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2012-05-31 01:51:50 UTC (rev 119018)
@@ -449,6 +449,10 @@
self._crashed_process_name = None
self._crashed_pid = None
+# WebKitTestRunner can report back subprocesses that became unresponsive
+# This could mean they crashed.
+self._subprocess_was_unresponsive = False
+
# stderr reading is scoped on a per-test (not per-block) basis, so we store the accumulated
# stderr output, as well as if we've seen #EOF on this driver instance.
# FIXME: We should probably remove _read_first_block and _read_optional_image_block and
@@ -513,7 +517,8 @@
# See http://trac.webkit.org/changeset/65537.
self._crashed_process_name = self._server_process.name()
self._crashed_pid = self._server_process.pid()
-elif error_line.startswith("#CRASHED - WebProcess"):
+elif (error_line.startswith("#CRASHED - WebProcess")
+or error_line.startswith("#PROCESS UNRESPONSIVE - WebProcess")):
# WebKitTestRunner uses this to report that the WebProcess subprocess crashed.
pid = None
m = re.search('pid (\d+)', error_line)
@@ -523,6 +528,8 @@
self._crashed_pid = pid
# FIXME: delete this after we're sure this code is working :)
_log.debug('WebProcess crash, pid = %s, error_line = %s' % (str(pid), error_line))
+if error_line.startswith("#PROCESS UNRESPONSIVE - WebProcess"):
+self._subprocess_was_unresponsive = True
return True
return self.has_crashed()
@@ -581,6 +588,9 @@
# If we don't find a crash log use a placeholder error message instead.
if not crash_log:
crash_log = 'no crash log found for %s:%d.' % (self._crashed_process_name, self._crashed_pid)
+# If we were unresponsive append a message informing there may not have been a crash.
+if self._subprocess_was_unresponsive:
+crash_log += ' Process failed to become responsive before timing out.'
timeout = self._server_process.timed_out
if timeout:
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (119017 => 119018)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2012-05-31 01:51:26 UTC (rev 119017)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_un
[webkit-changes] [119017] trunk/Tools
Title: [119017] trunk/Tools
Revision 119017
Author sle...@apple.com
Date 2012-05-30 18:51:26 -0700 (Wed, 30 May 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=87714
Mac crash logs can take a really long time to be written out.
Reviewed by Dirk Pranke.
Make a second pass looking for crash logs after the tests have completed running.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(use_trac_links_in_results_html):
(Manager.run):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.repository_paths):
(Port.look_for_new_crash_logs):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.look_for_new_crash_logs):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_get_crash_log):
(test_look_for_new_crash_logs):
(test_look_for_new_crash_logs.fake_time_cb):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
Diff
Modified: trunk/Tools/ChangeLog (119016 => 119017)
--- trunk/Tools/ChangeLog 2012-05-31 01:38:17 UTC (rev 119016)
+++ trunk/Tools/ChangeLog 2012-05-31 01:51:26 UTC (rev 119017)
@@ -1,3 +1,25 @@
+2012-05-30 Stephanie Lewis
+
+https://bugs.webkit.org/show_bug.cgi?id=87714
+Mac crash logs can take a really long time to be written out.
+
+Reviewed by Dirk Pranke.
+
+Make a second pass looking for crash logs after the tests have completed running.
+
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(use_trac_links_in_results_html):
+(Manager.run):
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.repository_paths):
+(Port.look_for_new_crash_logs):
+* Scripts/webkitpy/layout_tests/port/mac.py:
+(MacPort.look_for_new_crash_logs):
+* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
+(test_get_crash_log):
+(test_look_for_new_crash_logs):
+(test_look_for_new_crash_logs.fake_time_cb):
+
2012-05-30 Kevin Ollivier
[wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (119016 => 119017)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-05-31 01:38:17 UTC (rev 119016)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2012-05-31 01:51:26 UTC (rev 119017)
@@ -46,6 +46,7 @@
from webkitpy.layout_tests.controllers import manager_worker_broker
from webkitpy.layout_tests.controllers import worker
+from webkitpy.layout_tests.controllers.test_result_writer import TestResultWriter
from webkitpy.layout_tests.layout_package import json_layout_results_generator
from webkitpy.layout_tests.layout_package import json_results_generator
from webkitpy.layout_tests.models import test_expectations
@@ -106,6 +107,7 @@
# Use existence of builder_name as a proxy for knowing we're on a bot.
return port_obj.get_option("builder_name")
+
# FIXME: This should be on the Manager class (since that's the only caller)
# or split off from Manager onto another helper class, but should not be a free function.
# Most likely this should be made into its own class, and this super-long function
@@ -909,6 +911,10 @@
end_time = time.time()
+# Some crash logs can take a long time to be written out so look
+# for new logs after the test run finishes.
+self._look_for_new_crash_logs(result_summary, start_time)
+self._look_for_new_crash_logs(retry_summary, start_time)
self._clean_up_run()
self._print_timing_statistics(end_time - start_time, thread_timings, test_timings, individual_test_timings, result_summary)
@@ -970,6 +976,29 @@
_log.debug("cleaning up port")
self._port.clean_up_test_run()
+def _look_for_new_crash_logs(self, result_summary, start_time):
+"""Since crash logs can take a long time to be written out if the system is
+ under stress do a second pass at the end of the test run.
+
+ result_summary: the results of the test run
+ start_time: time the tests started at. We're looking for crash
+ logs after that time.
+"""
+crashed_processes = []
+for test, result in result_summary.unexpected_results.iteritems():
+if (result.type != test_expectations.CRASH):
+continue
+for failure in result.failures:
+if not isinstance(failure, test_failures.FailureCrash):
+continue
+crashed_processes.append([test, failure.process_name, failure.pid])
+
+crash_logs = self._port.look_for_new_crash_logs(crashed_processes, start_time)
+if crash_logs:
+for
[webkit-changes] [119016] trunk/Source/JavaScriptCore
Title: [119016] trunk/Source/_javascript_Core
Revision 119016
Author par...@webkit.org
Date 2012-05-30 18:38:17 -0700 (Wed, 30 May 2012)
Log Message
[WINCE] Fix JSString after r115516.
https://bugs.webkit.org/show_bug.cgi?id=87892
Reviewed by Geoffrey Garen.
r115516 splitted JSString into two classes, with addition nested classes.
Add a workaround for the WinCE compiler since it can't resolve the friend class
declerations corretly and denies the access to protected members of JSString.
* runtime/JSString.h:
(JSC::JSRopeString::RopeBuilder::append):
(JSC::JSRopeString::append):
(JSRopeString):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSString.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (119015 => 119016)
--- trunk/Source/_javascript_Core/ChangeLog 2012-05-31 01:37:04 UTC (rev 119015)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-05-31 01:38:17 UTC (rev 119016)
@@ -1,3 +1,19 @@
+2012-05-30 Patrick Gansterer
+
+[WINCE] Fix JSString after r115516.
+https://bugs.webkit.org/show_bug.cgi?id=87892
+
+Reviewed by Geoffrey Garen.
+
+r115516 splitted JSString into two classes, with addition nested classes.
+Add a workaround for the WinCE compiler since it can't resolve the friend class
+declerations corretly and denies the access to protected members of JSString.
+
+* runtime/JSString.h:
+(JSC::JSRopeString::RopeBuilder::append):
+(JSC::JSRopeString::append):
+(JSRopeString):
+
2012-05-30 Oliver Hunt
Really provide error information with the inspector disabled
Modified: trunk/Source/_javascript_Core/runtime/JSString.h (119015 => 119016)
--- trunk/Source/_javascript_Core/runtime/JSString.h 2012-05-31 01:37:04 UTC (rev 119015)
+++ trunk/Source/_javascript_Core/runtime/JSString.h 2012-05-31 01:38:17 UTC (rev 119016)
@@ -200,9 +200,7 @@
{
if (m_index == JSRopeString::s_maxInternalRopeLength)
expand();
-m_jsString->m_fibers[m_index++].set(m_globalData, m_jsString, jsString);
-m_jsString->m_length += jsString->m_length;
-m_jsString->m_is8Bit = m_jsString->m_is8Bit && jsString->m_is8Bit;
+m_jsString->append(m_globalData, m_index++, jsString);
}
JSRopeString* release()
@@ -252,6 +250,13 @@
JSString::finishCreation(globalData);
}
+void append(JSGlobalData& globalData, size_t index, JSString* jsString)
+{
+m_fibers[index].set(globalData, this, jsString);
+m_length += jsString->m_length;
+m_is8Bit = m_is8Bit && jsString->m_is8Bit;
+}
+
static JSRopeString* createNull(JSGlobalData& globalData)
{
JSRopeString* newString = new (NotNull, allocateCell(globalData.heap)) JSRopeString(globalData);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119015] trunk/Source/WebCore
Title: [119015] trunk/Source/WebCore
Revision 119015
Author o...@chromium.org
Date 2012-05-30 18:37:04 -0700 (Wed, 30 May 2012)
Log Message
Avoid second layout for flex-direction:row, flex-basis:auto flex items
https://bugs.webkit.org/show_bug.cgi?id=87901
Reviewed by Tony Chang.
No new tests. This is strictly a performance optimization and has no other
web visible changes.
Also, add FIXMEs for other cases where we could avoid doing layouts.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (119014 => 119015)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 01:31:46 UTC (rev 119014)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 01:37:04 UTC (rev 119015)
@@ -1,3 +1,20 @@
+2012-05-30 Ojan Vafai
+
+Avoid second layout for flex-direction:row, flex-basis:auto flex items
+https://bugs.webkit.org/show_bug.cgi?id=87901
+
+Reviewed by Tony Chang.
+
+No new tests. This is strictly a performance optimization and has no other
+web visible changes.
+
+Also, add FIXMEs for other cases where we could avoid doing layouts.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
+(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
+(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
+
2012-05-30 Zhenyao Mo
WebKit incorrectly clears the alpha channel on readPixels, even for Framebuffers
Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (119014 => 119015)
--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2012-05-31 01:31:46 UTC (rev 119014)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2012-05-31 01:37:04 UTC (rev 119015)
@@ -757,7 +757,8 @@
continue;
child->clearOverrideSize();
-if (preferredLengthForChild(child).isAuto()) {
+// Only need to layout here if we will need to get the logicalHeight of the child in computeNextFlexLine.
+if (hasOrthogonalFlow(child) && preferredLengthForChild(child).isAuto()) {
if (!relayoutChildren)
child->setChildNeedsLayout(true);
child->layoutIfNeeded();
@@ -991,6 +992,7 @@
}
LayoutUnit childPreferredSize = childSizes[i] + mainAxisBorderAndPaddingExtentForChild(child);
setLogicalOverrideSize(child, childPreferredSize);
+// FIXME: Can avoid laying out here in some cases. See https://webkit.org/b/87905.
child->setChildNeedsLayout(true);
child->layoutIfNeeded();
@@ -1213,6 +1215,7 @@
child->setLogicalHeight(stretchedLogicalHeight);
child->computeLogicalHeight();
+// FIXME: Can avoid laying out here in some cases. See https://webkit.org/b/87905.
if (child->logicalHeight() != logicalHeightBefore) {
child->setOverrideHeight(child->logicalHeight());
child->setLogicalHeight(0);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119014] trunk
Title: [119014] trunk
Revision 119014
Author z...@google.com
Date 2012-05-30 18:31:46 -0700 (Wed, 30 May 2012)
Log Message
WebKit incorrectly clears the alpha channel on readPixels, even for Framebuffers
https://bugs.webkit.org/show_bug.cgi?id=87310
Reviewed by Kenneth Russell.
Source/WebCore:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getParameter): set DEPTH_BITS/STENCIL_BITS to 0 if related channels are not requested.
(WebCore::WebGLRenderingContext::readPixels): don't do the alpha value fix if the current bound is not the internal drawing buffer.
LayoutTests:
* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: synced with khronos
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt
trunk/LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (119013 => 119014)
--- trunk/LayoutTests/ChangeLog 2012-05-31 01:21:39 UTC (rev 119013)
+++ trunk/LayoutTests/ChangeLog 2012-05-31 01:31:46 UTC (rev 119014)
@@ -1,3 +1,13 @@
+2012-05-30 Zhenyao Mo
+
+WebKit incorrectly clears the alpha channel on readPixels, even for Framebuffers
+https://bugs.webkit.org/show_bug.cgi?id=87310
+
+Reviewed by Kenneth Russell.
+
+* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
+* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: synced with khronos
+
2012-05-30 Sheriff Bot
Unreviewed, rolling out r118986.
Modified: trunk/LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt (119013 => 119014)
--- trunk/LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt 2012-05-31 01:21:39 UTC (rev 119013)
+++ trunk/LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt 2012-05-31 01:31:46 UTC (rev 119014)
@@ -3,46 +3,110 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Testing alpha = true
-PASS webGL = getWebGL(1, 1, { alpha: true, depth: false, stencil: false, antialias: false }, [ 0, 0, 0, 0 ], 1, 0) is non-null.
-PASS contextAttribs = webGL.getContextAttributes() is non-null.
+PASS getError was expected value: NO_ERROR : should be no errors
+PASS gl = getWebGL(1, 1, { alpha: true, depth: false, stencil: false, antialias: false }, [ 0, 0, 0, 0 ], 1, 0) is non-null.
+PASS gl.getParameter(gl.ALPHA_BITS) >= 8 is true
+PASS gl.getParameter(gl.RED_BITS) >= 8 is true
+PASS gl.getParameter(gl.GREEN_BITS) >= 8 is true
+PASS gl.getParameter(gl.BLUE_BITS) >= 8 is true
+PASS gl.getParameter(gl.DEPTH_BITS) == 0 is true
+PASS gl.getParameter(gl.STENCIL_BITS) == 0 is true
+PASS contextAttribs = gl.getContextAttributes() is non-null.
PASS contextAttribs.alpha == true is true
PASS pixel is correctColor
+PASS Math.abs(pixel[0] - 127) <= 1 && Math.abs(pixel[1] - 127) <= 1 && Math.abs(pixel[2] - 127) <= 1 && Math.abs(pixel[3] - 127) <= 1 is true
Testing alpha = false
-PASS webGL = getWebGL(1, 1, { alpha: false, depth: false, stencil: false, antialias: false }, [ 0, 0, 0, 0 ], 1, 0) is non-null.
-PASS contextAttribs = webGL.getContextAttributes() is non-null.
+PASS getError was expected value: NO_ERROR : should be no errors
+PASS gl = getWebGL(1, 1, { alpha: false, depth: false, stencil: false, antialias: false }, [ 0, 0, 0, 0 ], 1, 0) is non-null.
+PASS gl.getParameter(gl.ALPHA_BITS) == 0 is true
+PASS gl.getParameter(gl.RED_BITS) >= 8 is true
+PASS gl.getParameter(gl.GREEN_BITS) >= 8 is true
+PASS gl.getParameter(gl.BLUE_BITS) >= 8 is true
+PASS gl.getParameter(gl.DEPTH_BITS) == 0 is true
+PASS gl.getParameter(gl.STENCIL_BITS) == 0 is true
+PASS contextAttribs = gl.getContextAttributes() is non-null.
PASS contextAttribs.alpha == false is true
PASS pixel is correctColor
+PASS Math.abs(pixel[0] - 127) <= 1 && Math.abs(pixel[1] - 127) <= 1 && Math.abs(pixel[2] - 127) <= 1 && Math.abs(pixel[3] - 127) <= 1 is true
Testing depth = true
-PASS webGL = getWebGL(1, 1, { stencil: false, antialias: false }, [ 0, 0, 0, 1 ], 1, 0) is non-null.
-PASS contextAttribs = webGL.getContextAttributes() is non-null.
+PASS getError was expected value: NO_ERROR : should be no errors
+PASS gl = getWebGL(1, 1, { stencil: false, antialias: false }, [ 0, 0, 0, 1 ], 1, 0) is non-null.
+PASS gl.getParameter(gl.DEPTH_BITS) >= 16 is true
+PASS gl.getParameter(gl.RED_BITS) >= 8 is true
+PASS gl.getParameter(gl.GREEN_BITS) >= 8 is true
+PASS gl.getParameter(gl.BLUE_BITS) >= 8 is true
+PASS gl.getParameter(gl.ALPHA_BITS) >= 8 is true
+PASS contextAttribs = gl.getContextAttributes() is non-null.
PASS pixel is
[webkit-changes] [119011] trunk/Tools
Title: [119011] trunk/Tools
Revision 119011
Author kev...@webkit.org
Date 2012-05-30 18:03:42 -0700 (Wed, 30 May 2012)
Log Message
[wx] Unreviewed build fix. Fix 2.9 issues with c_str() type errors by using the wx fprintf wrapper.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/wx/DumpRenderTreeWx.cpp
Diff
Modified: trunk/Tools/ChangeLog (119010 => 119011)
--- trunk/Tools/ChangeLog 2012-05-31 01:01:16 UTC (rev 119010)
+++ trunk/Tools/ChangeLog 2012-05-31 01:03:42 UTC (rev 119011)
@@ -1,3 +1,15 @@
+2012-05-30 Kevin Ollivier
+
+[wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
+
+* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
+(LayoutWebViewEventHandler::OnAlertEvent):
+(LayoutWebViewEventHandler::OnConfirmEvent):
+(LayoutWebViewEventHandler):
+(LayoutWebViewEventHandler::OnPromptEvent):
+(LayoutWebViewEventHandler::OnConsoleMessageEvent):
+(LayoutWebViewEventHandler::OnReceivedTitleEvent):
+
2012-05-30 Ojan Vafai
Only give lint errors for -expected.png png files that lack a checksum
Modified: trunk/Tools/DumpRenderTree/wx/DumpRenderTreeWx.cpp (119010 => 119011)
--- trunk/Tools/DumpRenderTree/wx/DumpRenderTreeWx.cpp 2012-05-31 01:01:16 UTC (rev 119010)
+++ trunk/Tools/DumpRenderTree/wx/DumpRenderTreeWx.cpp 2012-05-31 01:03:42 UTC (rev 119011)
@@ -103,18 +103,18 @@
void OnAlertEvent(WebViewAlertEvent& event)
{
-fprintf(stdout, "ALERT: %S\n", event.GetMessage().c_str());
+wxFprintf(stdout, "ALERT: %S\n", event.GetMessage());
}
void OnConfirmEvent(WebViewConfirmEvent& event)
{
-fprintf(stdout, "CONFIRM: %S\n", event.GetMessage().c_str());
+wxFprintf(stdout, "CONFIRM: %S\n", event.GetMessage());
event.SetReturnCode(1);
}
-
+
void OnPromptEvent(WebViewPromptEvent& event)
{
-fprintf(stdout, "PROMPT: %S, default text: %S\n", event.GetMessage().c_str(), event.GetResponse().c_str());
+wxFprintf(stdout, "PROMPT: %S, default text: %S\n", event.GetMessage(), event.GetResponse());
event.SetReturnCode(1);
}
@@ -123,15 +123,13 @@
fprintf(stdout, "CONSOLE MESSAGE: ");
if (event.GetLineNumber())
fprintf(stdout, "line %d: ", event.GetLineNumber());
-fprintf(stdout, "%S\n", event.GetMessage().c_str());
+wxFprintf(stdout, "%S\n", event.GetMessage());
}
void OnReceivedTitleEvent(WebViewReceivedTitleEvent& event)
{
-if (gLayoutTestController->dumpTitleChanges() && !done) {
-const char* title = event.GetTitle().mb_str(wxConvUTF8);
-printf("TITLE CHANGED: %S\n", title ? title : "");
-}
+if (gLayoutTestController->dumpTitleChanges() && !done)
+wxFprintf(stdout, "TITLE CHANGED: %S\n", event.GetTitle());
}
void OnWindowObjectClearedEvent(WebViewWindowObjectClearedEvent& event)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119010] trunk/Websites/bugs.webkit.org
Title: [119010] trunk/Websites/bugs.webkit.org
Revision 119010
Author o...@chromium.org
Date 2012-05-30 18:01:16 -0700 (Wed, 30 May 2012)
Log Message
Only include the image checksum error in pretty-diffs for -expected.png files.
https://bugs.webkit.org/show_bug.cgi?id=87881
Reviewed by Tony Chang.
* PrettyPatch/PrettyPatch.rb:
* PrettyPatch/PrettyPatch_test.rb:
Modified Paths
trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb
Diff
Modified: trunk/Websites/bugs.webkit.org/ChangeLog (119009 => 119010)
--- trunk/Websites/bugs.webkit.org/ChangeLog 2012-05-31 00:49:06 UTC (rev 119009)
+++ trunk/Websites/bugs.webkit.org/ChangeLog 2012-05-31 01:01:16 UTC (rev 119010)
@@ -1,3 +1,13 @@
+2012-05-30 Ojan Vafai
+
+Only include the image checksum error in pretty-diffs for -expected.png files.
+https://bugs.webkit.org/show_bug.cgi?id=87881
+
+Reviewed by Tony Chang.
+
+* PrettyPatch/PrettyPatch.rb:
+* PrettyPatch/PrettyPatch_test.rb:
+
2012-05-29 Ojan Vafai
Show an error in the pretty diff when an image lacks a checksum
Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (119009 => 119010)
--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2012-05-31 00:49:06 UTC (rev 119009)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb 2012-05-31 01:01:16 UTC (rev 119010)
@@ -98,7 +98,7 @@
Websites
]
-IMAGE_CHECKSUM_ERROR = "INVALID: Image lacks a checksum. This will fail with a MISSING error in run-webkit-tests. Always generate new png files using run-webkit-tests."
+IMAGE_CHECKSUM_ERROR = "INVALID: Image lacks a checksum. This will fail with a MISSING error in run-webkit-tests. Always generate new png files using run-webkit-tests."
def self.normalize_line_ending(s)
s.gsub /\r\n?/, "\n"
@@ -578,11 +578,15 @@
if not @image_url then
return "Image file removed"
end
-image_snippet = ""
-if not @image_checksum then
-return IMAGE_CHECKSUM_ERROR + image_snippet
+
+image_checksum = ""
+if @image_checksum
+image_checksum = @image_checksum
+elsif @filename.include? "-expected.png"
+image_checksum = IMAGE_CHECKSUM_ERROR
end
-return "" + @image_checksum + "" + image_snippet
+
+return "" + image_checksum + ""
end
def to_html
@@ -602,10 +606,13 @@
str += ""
if image_checksum
-str += image_checksum + ""
-else
-str += IMAGE_CHECKSUM_ERROR + ""
+str += image_checksum
+elsif @filename.include? "-expected.png"
+str += IMAGE_CHECKSUM_ERROR
end
+
+str += ""
+
if image_url
str += ""
else
Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb (119009 => 119010)
--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb 2012-05-31 00:49:06 UTC (rev 119009)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb 2012-05-31 01:01:16 UTC (rev 119010)
@@ -69,7 +69,6 @@
def test_images_without_checksum
pretty = check_one_patch(144064, ["Images without checksums", 10, 5, 4, 8])
-puts pretty
matches = pretty.match("INVALID: Image lacks a checksum.")
assert(matches, "Should have invalid checksums")
# FIXME: This should only have 4 invalid images, but git apply needs an actual copy of the before binary
@@ -77,4 +76,17 @@
# thought to have no checksum, instead of the 4 images that actually don't have a checksum.
assert_equal(10, pretty.scan(/INVALID\: Image lacks a checksum\./).size)
end
+
+def test_images_correctly_without_checksum_git
+pretty = check_one_patch(101620, ["Images correctly without checksums git", 7, 15, 10, 26])
+matches = pretty.match("INVALID: Image lacks a checksum.")
+assert(!matches, "Png should lack a checksum without an error.")
+end
+
+def test_images_correctly_without_checksum_svn
+pretty = check_one_patch(31202, ["Images correctly without checksums svn", 4, 4, 1, 4])
+matches = pretty.match("INVALID: Image lacks a checksum.")
+assert(!matches, "Png should lack a checksum without an error.")
+end
+
end
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119009] trunk/LayoutTests
Title: [119009] trunk/LayoutTests Revision 119009 Author jber...@webkit.org Date 2012-05-30 17:49:06 -0700 (Wed, 30 May 2012) Log Message Enhance Windows DRT implementation to support platform scroll wheel events https://bugs.webkit.org/show_bug.cgi?id=36002 Skip more tests that use eventSender.mouseScrollBy on Windows. * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (119008 => 119009) --- trunk/LayoutTests/ChangeLog 2012-05-31 00:48:54 UTC (rev 119008) +++ trunk/LayoutTests/ChangeLog 2012-05-31 00:49:06 UTC (rev 119009) @@ -1,3 +1,12 @@ +2012-05-30 Jessie Berlin + +Enhance Windows DRT implementation to support platform scroll wheel events +https://bugs.webkit.org/show_bug.cgi?id=36002 + +Skip more tests that use eventSender.mouseScrollBy on Windows. + +* platform/win/Skipped: + 2012-05-30 Tim Horton WebKitTestRunner needs an implementation of eventSender Modified: trunk/LayoutTests/platform/win/Skipped (119008 => 119009) --- trunk/LayoutTests/platform/win/Skipped 2012-05-31 00:48:54 UTC (rev 119008) +++ trunk/LayoutTests/platform/win/Skipped 2012-05-31 00:49:06 UTC (rev 119009) @@ -1004,9 +1004,14 @@ fast/events/remove-child-onscroll.html fast/events/platform-wheelevent-in-scrolling-div.html fast/events/continuous-platform-wheelevent-in-scrolling-div.html +fast/events/scroll-in-scaled-page-with-overflow-hidden.html fast/events/wheelevent-direction-inverted-from-device.html fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html +fast/repaint/overflow-auto-in-overflow-auto-scrolled.html +fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html +fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html +fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html scrollbars/scrollevent-iframe-no-scrolling-wheel.html scrollbars/scroll-rtl-or-bt-layer.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119008] trunk/Source
Title: [119008] trunk/Source
Revision 119008
Author shawnsi...@chromium.org
Date 2012-05-30 17:48:54 -0700 (Wed, 30 May 2012)
Log Message
Simplify TransformationMatrix rotation code to improve precision
https://bugs.webkit.org/show_bug.cgi?id=8
Reviewed by Adrienne Walker.
Source/WebCore:
Change covered by existing layout tests;
Additional unit tests added.
The original rotation code for WebCore::TransformationMatrix was
using indirect trig identities to compute basic rotation
matrices. As far as I can imagine, this is unnecessary, and brief
informal experiments showed that we can gain a few extra bits of
precision by avoiding that indirection.
Indeed, precision improved such that it revealed a mistake on one
of the unit tests, where the test was actually degenerate so that
the layer was aligned with a viewport boundary. When it was
imprecise, it didnt appear to be aligned. Putting an additional
translation on that test fixes it so it is no longer a degenerate
test.
This patch also revealed a few chinks in the unit testing armor of
this code, an error that should have been caught in unit tests was
luckily caught by SVG layout tests. This chink is fixed by adding
2 extra unit tests.
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::rotate3d):
Source/WebKit/chromium:
* tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
* tests/WebTransformationMatrixTest.cpp:
(WebKit::TEST):
(WebKit):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp
trunk/Source/WebKit/chromium/tests/WebTransformationMatrixTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (119007 => 119008)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 00:47:37 UTC (rev 119007)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 00:48:54 UTC (rev 119008)
@@ -1,3 +1,34 @@
+2012-05-30 Shawn Singh
+
+Simplify TransformationMatrix rotation code to improve precision
+https://bugs.webkit.org/show_bug.cgi?id=8
+
+Reviewed by Adrienne Walker.
+
+Change covered by existing layout tests;
+Additional unit tests added.
+
+The original rotation code for WebCore::TransformationMatrix was
+using indirect trig identities to compute basic rotation
+matrices. As far as I can imagine, this is unnecessary, and brief
+informal experiments showed that we can gain a few extra bits of
+precision by avoiding that indirection.
+
+Indeed, precision improved such that it revealed a mistake on one
+of the unit tests, where the test was actually degenerate so that
+the layer was aligned with a viewport boundary. When it was
+imprecise, it didnt appear to be aligned. Putting an additional
+translation on that test fixes it so it is no longer a degenerate
+test.
+
+This patch also revealed a few chinks in the unit testing armor of
+this code, an error that should have been caught in unit tests was
+luckily caught by SVG layout tests. This chink is fixed by adding
+2 extra unit tests.
+
+* platform/graphics/transforms/TransformationMatrix.cpp:
+(WebCore::TransformationMatrix::rotate3d):
+
2012-05-30 Alec Flett
IndexedDB: Remove old get/getKey implementations
Modified: trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp (119007 => 119008)
--- trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp 2012-05-31 00:47:37 UTC (rev 119007)
+++ trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp 2012-05-31 00:48:54 UTC (rev 119008)
@@ -727,15 +727,13 @@
TransformationMatrix& TransformationMatrix::rotate3d(double x, double y, double z, double angle)
{
-// angles are in degrees. Switch to radians
+// Angles are in degrees. Switch to radians.
angle = deg2rad(angle);
+
+double sinTheta = sin(angle);
+double cosTheta = cos(angle);
-angle /= 2.0f;
-double sinA = sin(angle);
-double cosA = cos(angle);
-double sinA2 = sinA * sinA;
-
-// normalize
+// Normalize the axis of rotation
double length = sqrt(x * x + y * y + z * z);
if (length == 0) {
// bad vector, just use something reasonable
@@ -750,39 +748,39 @@
TransformationMatrix mat;
-// optimize case where axis is along major axis
+// Optimize cases where the axis is along a major axis
if (x == 1.0f && y == 0.0f && z == 0.0f) {
mat.m_matrix[0][0] = 1.0f;
mat.m_matrix[0][1] = 0.0f;
mat.m_matrix[0][2] = 0.0f;
mat.m_matrix[1][0] = 0.0f;
-mat.m_matrix[1][1] = 1.0f - 2.0f * sinA2;
-mat.m_matrix[1][2] = 2.0f * sinA * cosA;
+mat.m_matrix[1][1] = cosTheta;
+mat.m_matrix[1][2] = sinThet
[webkit-changes] [119007] trunk/LayoutTests
Title: [119007] trunk/LayoutTests Revision 119007 Author timothy_hor...@apple.com Date 2012-05-30 17:47:37 -0700 (Wed, 30 May 2012) Log Message WebKitTestRunner needs an implementation of eventSender Unreviewed mac-wk2 skip of fast/forms/file/input-file-write-files.html, which depends on eventSender. * platform/mac-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (119006 => 119007) --- trunk/LayoutTests/ChangeLog 2012-05-31 00:46:53 UTC (rev 119006) +++ trunk/LayoutTests/ChangeLog 2012-05-31 00:47:37 UTC (rev 119007) @@ -1,3 +1,12 @@ +2012-05-30 Tim Horton + +WebKitTestRunner needs an implementation of eventSender + + +Unreviewed mac-wk2 skip of fast/forms/file/input-file-write-files.html, which depends on eventSender. + +* platform/mac-wk2/Skipped: + 2012-05-30 Jessie Berlin [Win] 8 accessibility tests failing Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (119006 => 119007) --- trunk/LayoutTests/platform/mac-wk2/Skipped 2012-05-31 00:46:53 UTC (rev 119006) +++ trunk/LayoutTests/platform/mac-wk2/Skipped 2012-05-31 00:47:37 UTC (rev 119007) @@ -165,6 +165,7 @@ fast/forms/range/slider-mouse-events.html fast/forms/range/slider-onchange-event.html fast/forms/select-type-ahead-non-latin.html +fast/forms/file/input-file-write-files.html fast/history/window-open.html fast/lists/drag-into-marker.html fast/loader/policy-delegate-action-hit-test-zoomed.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119006] trunk/Source/WebCore
Title: [119006] trunk/Source/WebCore
Revision 119006
Author commit-qu...@webkit.org
Date 2012-05-30 17:46:53 -0700 (Wed, 30 May 2012)
Log Message
IndexedDB: Remove old get/getKey implementations
https://bugs.webkit.org/show_bug.cgi?id=87879
Patch by Alec Flett on 2012-05-30
Reviewed by Ojan Vafai.
Removal of dead code, was scaffolding for a complicated
Chromium landing.
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
* Modules/indexeddb/IDBIndexBackendImpl.h:
(IDBIndexBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBIndexBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBIndexBackendImpl.h
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (119005 => 119006)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 00:39:18 UTC (rev 119005)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 00:46:53 UTC (rev 119006)
@@ -1,3 +1,26 @@
+2012-05-30 Alec Flett
+
+IndexedDB: Remove old get/getKey implementations
+https://bugs.webkit.org/show_bug.cgi?id=87879
+
+Reviewed by Ojan Vafai.
+
+Removal of dead code, was scaffolding for a complicated
+Chromium landing.
+
+* Modules/indexeddb/IDBIndexBackendImpl.cpp:
+(WebCore::IDBIndexBackendImpl::getInternal):
+(WebCore::IDBIndexBackendImpl::getKeyInternal):
+(WebCore::IDBIndexBackendImpl::get):
+(WebCore::IDBIndexBackendImpl::getKey):
+* Modules/indexeddb/IDBIndexBackendImpl.h:
+(IDBIndexBackendImpl):
+* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
+(WebCore::IDBObjectStoreBackendImpl::get):
+(WebCore::IDBObjectStoreBackendImpl::getInternal):
+* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
+(IDBObjectStoreBackendImpl):
+
2012-05-30 Joe Mason
[BlackBerry] Fix assertion fail on redirect due to multiple jobs per handle
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBIndexBackendImpl.cpp (119005 => 119006)
--- trunk/Source/WebCore/Modules/indexeddb/IDBIndexBackendImpl.cpp 2012-05-31 00:39:18 UTC (rev 119005)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBIndexBackendImpl.cpp 2012-05-31 00:46:53 UTC (rev 119006)
@@ -145,21 +145,10 @@
ec = IDBDatabaseException::TRANSACTION_INACTIVE_ERR;
}
-void IDBIndexBackendImpl::getInternal(ScriptExecutionContext*, PassRefPtr index, PassRefPtr key, PassRefPtr callbacks)
+void IDBIndexBackendImpl::getInternal(ScriptExecutionContext*, PassRefPtr index, PassRefPtr keyRange, PassRefPtr callbacks)
{
IDB_TRACE("IDBIndexBackendImpl::getInternal");
-String value = index->backingStore()->getObjectViaIndex(index->databaseId(), index->m_objectStoreBackend->id(), index->id(), *key);
-if (value.isNull()) {
-callbacks->onSuccess(SerializedScriptValue::undefinedValue());
-return;
-}
-callbacks->onSuccess(SerializedScriptValue::createFromWire(value));
-}
-void IDBIndexBackendImpl::getByRangeInternal(ScriptExecutionContext*, PassRefPtr index, PassRefPtr keyRange, PassRefPtr callbacks)
-{
-IDB_TRACE("IDBIndexBackendImpl::getByRangeInternal");
-
RefPtr backingStoreCursor =
index->backingStore()->openIndexCursor(index->databaseId(), index->m_objectStoreBackend->id(), index->id(), keyRange.get(), IDBCursor::NEXT);
@@ -178,21 +167,10 @@
backingStoreCursor->close();
}
-void IDBIndexBackendImpl::getKeyInternal(ScriptExecutionContext*, PassRefPtr index, PassRefPtr key, PassRefPtr callbacks)
+void IDBIndexBackendImpl::getKeyInternal(ScriptExecutionContext* context, PassRefPtr index, PassRefPtr keyRange, PassRefPtr callbacks)
{
-IDB_TRACE("IDBIndexBackendImpl::getKeyInternal");
-RefPtr keyResult = index->backingStore()->getPrimaryKeyViaIndex(index->databaseId(), index->m_objectStoreBackend->id(), index->id(), *key);
-if (!keyResult) {
-callbacks->onSuccess(static_cast(0));
-return;
-}
-callbacks->onSuccess(keyResult.get());
-}
+IDB_TRACE("IDBIndexBackendImpl::getInternal");
-void IDBIndexBackendImpl::getKeyByRangeInternal(ScriptExecutionContext* context, PassRefPtr index, PassRefPtr keyRange, PassRefPtr callbacks)
-{
-IDB_TRACE("IDBIndexBackendImpl::getByRangeInternal");
-
RefPtr backingStoreCursor =
index->backingStore()->openIndexKeyCursor(index->databaseId(), index->m_objectStoreBackend->id(), index->id(), keyRange.get(), IDBCursor::NEXT);
@@ -218,40 +196,20 @@
RefPtr in
[webkit-changes] [119005] trunk/Source/WebCore
Title: [119005] trunk/Source/WebCore
Revision 119005
Author commit-qu...@webkit.org
Date 2012-05-30 17:39:18 -0700 (Wed, 30 May 2012)
Log Message
[BlackBerry] Fix assertion fail on redirect due to multiple jobs per handle
https://bugs.webkit.org/show_bug.cgi?id=87579
Patch by Joe Mason on 2012-05-30
Reviewed by George Staikos.
RIM PR #158892:
When we start a redirect, we now call cancelJob instead of just deleting it immediately to make sure
that all cleanup is performed. However, we also reassign the ResourceHandle to the new job, and
since cancelJob is asynchronous it is now assigned to two jobs simultaneously.
Work around this by only returning handles that have not been cancelled from findJobForHandle.
Cancelled jobs still technically exist in the jobs list, but they're invisible to callers. This is
safe because there is literally nothing that can be done with a cancelled job - it is supposed to
merely consume any notifications that are already in progress and then kill itself off - so no
callers of findJobForHandle are expecting a cancelled job. (All existing callers call methods on the
returned job which are no-ops for cancelled jobs, so there is no behaviour change.)
No new tests because there is no behaviour change (fixes a regression).
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::findJobForHandle):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/NetworkManager.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (119004 => 119005)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 00:30:10 UTC (rev 119004)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 00:39:18 UTC (rev 119005)
@@ -1,3 +1,28 @@
+2012-05-30 Joe Mason
+
+[BlackBerry] Fix assertion fail on redirect due to multiple jobs per handle
+https://bugs.webkit.org/show_bug.cgi?id=87579
+
+Reviewed by George Staikos.
+
+RIM PR #158892:
+
+When we start a redirect, we now call cancelJob instead of just deleting it immediately to make sure
+that all cleanup is performed. However, we also reassign the ResourceHandle to the new job, and
+since cancelJob is asynchronous it is now assigned to two jobs simultaneously.
+
+Work around this by only returning handles that have not been cancelled from findJobForHandle.
+Cancelled jobs still technically exist in the jobs list, but they're invisible to callers. This is
+safe because there is literally nothing that can be done with a cancelled job - it is supposed to
+merely consume any notifications that are already in progress and then kill itself off - so no
+callers of findJobForHandle are expecting a cancelled job. (All existing callers call methods on the
+returned job which are no-ops for cancelled jobs, so there is no behaviour change.)
+
+No new tests because there is no behaviour change (fixes a regression).
+
+* platform/network/blackberry/NetworkManager.cpp:
+(WebCore::NetworkManager::findJobForHandle):
+
2012-05-30 Kentaro Hara
[V8][Performance] Optimize DOM attribute getters that return an empty string
Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkManager.cpp (119004 => 119005)
--- trunk/Source/WebCore/platform/network/blackberry/NetworkManager.cpp 2012-05-31 00:30:10 UTC (rev 119004)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkManager.cpp 2012-05-31 00:39:18 UTC (rev 119005)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009, 2010, 2011 Research In Motion Limited. All rights reserved.
+ * Copyright (C) 2009, 2010, 2011, 2012 Research In Motion Limited. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@@ -160,10 +160,10 @@
{
for (unsigned i = 0; i < m_jobs.size(); ++i) {
NetworkJob* networkJob = m_jobs[i];
-if (networkJob->handle() == job) {
-// We have only one job for one handle.
+// We have only one job for one handle (not including cancelled jobs which may hang
+// around briefly), so return the first non-cancelled job.
+if (!networkJob->isCancelled() && networkJob->handle() == job)
return networkJob;
-}
}
return 0;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [119004] trunk/Source/WebCore
Title: [119004] trunk/Source/WebCore
Revision 119004
Author hara...@chromium.org
Date 2012-05-30 17:30:10 -0700 (Wed, 30 May 2012)
Log Message
[V8][Performance] Optimize DOM attribute getters that return an empty string
https://bugs.webkit.org/show_bug.cgi?id=87820
Reviewed by Adam Barth.
This patch optimizes the performance of DOM attribute getters that return an
empty string by 65.8% (e.g. div.id, div.className, div.title, div.lang ...etc)
Performance test: Bindings/undefined-id-getter.html
[Without the patch]
RESULT Bindings: undefined-id-getter= 441.984669644 runs/s
median= 445.544554455 runs/s, stdev= 11.8406070959 runs/s, min= 405.063291139 runs/s, max= 447.204968944 runs/s
[With the patch]
RESULT Bindings: undefined-id-getter= 738.840460474 runs/s
median= 738.786279683 runs/s, stdev= 2.00249797161 runs/s, min= 733.944954128 runs/s, max= 741.721854305 runs/s
- This patch passes Isolate to v8::String::Empty(), which removes Isolate
look-up inside v8::String::Empty().
- This patch inlines V8Binding::getElementStringAttr() and
V8Binding::setElementStringAttr().
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
* bindings/v8/V8Binding.cpp:
(WebCore::StringCache::v8ExternalStringSlow):
* bindings/v8/V8Binding.h:
(WebCore::StringCache::v8ExternalString):
(StringCache):
(WebCore::v8ExternalString):
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (119003 => 119004)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 00:28:00 UTC (rev 119003)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 00:30:10 UTC (rev 119004)
@@ -1,5 +1,44 @@
2012-05-30 Kentaro Hara
+[V8][Performance] Optimize DOM attribute getters that return an empty string
+https://bugs.webkit.org/show_bug.cgi?id=87820
+
+Reviewed by Adam Barth.
+
+This patch optimizes the performance of DOM attribute getters that return an
+empty string by 65.8% (e.g. div.id, div.className, div.title, div.lang ...etc)
+
+Performance test: Bindings/undefined-id-getter.html
+
+[Without the patch]
+RESULT Bindings: undefined-id-getter= 441.984669644 runs/s
+median= 445.544554455 runs/s, stdev= 11.8406070959 runs/s, min= 405.063291139 runs/s, max= 447.204968944 runs/s
+
+[With the patch]
+RESULT Bindings: undefined-id-getter= 738.840460474 runs/s
+median= 738.786279683 runs/s, stdev= 2.00249797161 runs/s, min= 733.944954128 runs/s, max= 741.721854305 runs/s
+
+- This patch passes Isolate to v8::String::Empty(), which removes Isolate
+look-up inside v8::String::Empty().
+
+- This patch inlines V8Binding::getElementStringAttr() and
+V8Binding::setElementStringAttr().
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateNormalAttrGetter):
+(GenerateNormalAttrSetter):
+* bindings/v8/V8Binding.cpp:
+(WebCore::StringCache::v8ExternalStringSlow):
+* bindings/v8/V8Binding.h:
+(WebCore::StringCache::v8ExternalString):
+(StringCache):
+(WebCore::v8ExternalString):
+(WebCore):
+
+2012-05-30 Kentaro Hara
+
[V8] Implement V8Binding::v8BooleanWithCheck(isolate)
https://bugs.webkit.org/show_bug.cgi?id=87814
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (119003 => 119004)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-31 00:28:00 UTC (rev 119003)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-31 00:30:10 UTC (rev 119004)
@@ -822,7 +822,8 @@
my $contentAttributeName = $reflect eq "VALUE_IS_MISSING" ? lc $attrName : $reflect;
my $namespace = $codeGenerator->NamespaceForAttributeName($interfaceName, $contentAttributeName);
AddToImplIncludes("${namespace}.h");
-push(@implContentDecls, "return getElementStringAttr(info, ${namespace}::${contentAttributeName}Attr);\n");
+push(@implContentDecls, "Element* imp = V8Element::toNative(info.Holder());\n");
+push(@implContentDecls, "return v8ExternalString(imp->getAttribute(${namespace}::${contentAttributeName}Attr), info.GetIsolate());\n");
push(@implContentDecls, "}\n\n");
push(@implContentDecls, "#endif // ${conditionalString}\n\n") if $conditionalString;
return;
@@ -1092,7 +1093,9 @@
my $contentAttributeName = $reflect eq "VALUE_IS_MISSING" ? lc $attrName : $reflect;
my $namespace = $codeGenerator->NamespaceForAttributeName($interfaceName, $contentAttributeName);
AddToImplIncludes("${namespace}.h");
-push(@implContentDecls, "setEle
[webkit-changes] [119003] trunk/Source/WebCore
Title: [119003] trunk/Source/WebCore
Revision 119003
Author hara...@chromium.org
Date 2012-05-30 17:28:00 -0700 (Wed, 30 May 2012)
Log Message
[V8] Implement V8Binding::v8BooleanWithCheck(isolate)
https://bugs.webkit.org/show_bug.cgi?id=87814
Reviewed by Adam Barth.
The objective is to pass Isolate to v8::True() and v8::False().
Similarly to v8NullWithCheck() (bug 87713), this patch implements
V8Binding::v8BooleanWithCheck(isolate), which calls v8::True()/v8::False()
or v8::True(isolate)/v8::False(isolate) depending on whether the
passed isolate is null or not.
This patch also passes Isolate to v8Boolean() in CodeGeneratorV8.pm.
No tests. No behavior change.
* bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::createAttrGetter):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetter):
* bindings/v8/V8Binding.h:
(WebCore::v8Boolean):
(WebCore):
(WebCore::v8BooleanWithCheck):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (119002 => 119003)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 00:16:11 UTC (rev 119002)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 00:28:00 UTC (rev 119003)
@@ -1,5 +1,35 @@
2012-05-30 Kentaro Hara
+[V8] Implement V8Binding::v8BooleanWithCheck(isolate)
+https://bugs.webkit.org/show_bug.cgi?id=87814
+
+Reviewed by Adam Barth.
+
+The objective is to pass Isolate to v8::True() and v8::False().
+Similarly to v8NullWithCheck() (bug 87713), this patch implements
+V8Binding::v8BooleanWithCheck(isolate), which calls v8::True()/v8::False()
+or v8::True(isolate)/v8::False(isolate) depending on whether the
+passed isolate is null or not.
+
+This patch also passes Isolate to v8Boolean() in CodeGeneratorV8.pm.
+
+No tests. No behavior change.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(NativeToJSValue):
+* bindings/scripts/test/V8/V8TestEventTarget.cpp:
+(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjV8Internal::createAttrGetter):
+(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetter):
+(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetter):
+* bindings/v8/V8Binding.h:
+(WebCore::v8Boolean):
+(WebCore):
+(WebCore::v8BooleanWithCheck):
+
+2012-05-30 Kentaro Hara
+
[V8] Replace v8::True() and v8::False() with v8Boolean()
https://bugs.webkit.org/show_bug.cgi?id=87812
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (119002 => 119003)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-31 00:16:11 UTC (rev 119002)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-31 00:28:00 UTC (rev 119003)
@@ -3802,7 +3802,7 @@
my $getIsolateArg = $getIsolate ? ", $getIsolate" : "";
my $type = GetTypeFromSignature($signature);
-return "v8Boolean($value)" if $type eq "boolean";
+return ($getIsolate ? "v8Boolean($value, $getIsolate)" : "v8Boolean($value)") if $type eq "boolean";
return "v8::Handle()" if $type eq "void"; # equivalent to v8::Undefined()
# HTML5 says that unsigned reflected attributes should be in the range
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.cpp (119002 => 119003)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.cpp 2012-05-31 00:16:11 UTC (rev 119002)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.cpp 2012-05-31 00:28:00 UTC (rev 119003)
@@ -96,7 +96,7 @@
bool result = imp->dispatchEvent(evt, ec);
if (UNLIKELY(ec))
goto fail;
-return v8Boolean(result);
+return v8Boolean(result, args.GetIsolate());
}
fail:
return V8Proxy::setDOMException(ec, args.GetIsolate());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (119002 => 119003)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-05-31 00:16:11 UTC (rev 119002)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-05-31 00:28:00 UTC (rev 119003)
@@ -464,7 +464,7 @@
{
INC_STATS("DOM.TestObj.create._get");
TestObj* imp = V8TestObj::toNative(info.Holder());
-return v8Boolean(imp->isCreate());
+return v8Boolean(imp->isCreate(), info.GetIsolate());
}
static void createAttrSetter(v8::Local name, v8::Local value, const v8::Accessor
[webkit-changes] [119002] trunk/Source/WebCore
Title: [119002] trunk/Source/WebCore
Revision 119002
Author hara...@chromium.org
Date 2012-05-30 17:16:11 -0700 (Wed, 30 May 2012)
Log Message
[V8] Replace v8::True() and v8::False() with v8Boolean()
https://bugs.webkit.org/show_bug.cgi?id=87812
Reviewed by Adam Barth.
To avoid implementing all of v8TrueWithCheck(isolate), v8FalseWithCheck(isolate)
and v8BooleanWithCheck(isolate), we can first replace v8::True() and v8::False()
with v8Boolean(). Then we can just implement v8BooleanWithCheck(isolate).
No tests. No change in behavior.
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/V8Binding.h:
(WebCore::v8StringOrFalse):
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertNPVariantToV8Object):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyDeleter):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageDeleter):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/bindings/v8/V8NPUtils.cpp
trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (119001 => 119002)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 00:13:23 UTC (rev 119001)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 00:16:11 UTC (rev 119002)
@@ -1,5 +1,30 @@
2012-05-30 Kentaro Hara
+[V8] Replace v8::True() and v8::False() with v8Boolean()
+https://bugs.webkit.org/show_bug.cgi?id=87812
+
+Reviewed by Adam Barth.
+
+To avoid implementing all of v8TrueWithCheck(isolate), v8FalseWithCheck(isolate)
+and v8BooleanWithCheck(isolate), we can first replace v8::True() and v8::False()
+with v8Boolean(). Then we can just implement v8BooleanWithCheck(isolate).
+
+No tests. No change in behavior.
+
+* bindings/v8/SerializedScriptValue.cpp:
+* bindings/v8/V8Binding.h:
+(WebCore::v8StringOrFalse):
+* bindings/v8/V8NPUtils.cpp:
+(WebCore::convertNPVariantToV8Object):
+* bindings/v8/custom/V8DOMStringMapCustom.cpp:
+(WebCore::V8DOMStringMap::namedPropertyDeleter):
+* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
+* bindings/v8/custom/V8StorageCustom.cpp:
+(WebCore::storageDeleter):
+
+2012-05-30 Kentaro Hara
+
[V8] Replace v8::Null() with v8NullWithCheck(isolate) in custom bindings where isolate can be 0
https://bugs.webkit.org/show_bug.cgi?id=87807
Modified: trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp (119001 => 119002)
--- trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp 2012-05-31 00:13:23 UTC (rev 119001)
+++ trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp 2012-05-31 00:16:11 UTC (rev 119002)
@@ -1266,10 +1266,10 @@
*value = v8NullWithCheck(m_isolate);
break;
case TrueTag:
-*value = v8::True();
+*value = v8Boolean(true);
break;
case FalseTag:
-*value = v8::False();
+*value = v8Boolean(false);
break;
case TrueObjectTag:
*value = v8::BooleanObject::New(true);
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (119001 => 119002)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-05-31 00:13:23 UTC (rev 119001)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-05-31 00:16:11 UTC (rev 119002)
@@ -440,7 +440,7 @@
inline v8::Handle v8StringOrFalse(const String& str, v8::Isolate* isolate = 0)
{
-return str.isNull() ? v8::Handle(v8::False()) : v8::Handle(v8String(str, isolate));
+return str.isNull() ? v8::Handle(v8Boolean(false)) : v8::Handle(v8String(str, isolate));
}
template v8::Handle v8NumberArray(const Vector& values)
Modified: trunk/Source/WebCore/bindings/v8/V8NPUtils.cpp (119001 => 119002)
--- trunk/Source/WebCore/bindings/v8/V8NPUtils.cpp 2012-05-31 00:13:23 UTC (rev 119001)
+++ trunk/Source/WebCore/bindings/v8/V8NPUtils.cpp 2012-05-31 00:16:11 UTC (rev 119002)
@@ -37,6 +37,7 @@
#include "npruntime_impl.h"
#include "npruntime_priv.h"
#include "NPV8Object.h"
+#include "V8Binding.h"
#include "V8NPObject.h"
#include "V8Proxy.h"
@@ -86,7 +87,7 @@
case NPVariantType_Double:
return v8::Number::New(NPVARIANT_TO_DOUBLE(*variant));
case NPVariantType_Bool:
-return NPVARIANT_TO_BOOLEAN(*variant) ? v8::True() : v8::False();
+return v8Boolean(NPVARIANT_TO_BOOLEAN(*variant));
case NPVariantType_Null:
return v8::Null();
case NPVariantType_Void:
Modified: trunk/Sou
[webkit-changes] [119001] trunk/Source/WebCore
Title: [119001] trunk/Source/WebCore Revision 119001 Author hara...@chromium.org Date 2012-05-30 17:13:23 -0700 (Wed, 30 May 2012) Log Message [V8] Replace v8::Null() with v8NullWithCheck(isolate) in custom bindings where isolate can be 0 https://bugs.webkit.org/show_bug.cgi?id=87807 Reviewed by Adam Barth. The objective is to pass Isolate around in V8 bindings. This patch replaces v8::Null() with v8NullWithCheck(isolate) in custom bindings where isolate can be 0. 'where isolate can be 0' means all the places where we cannot retrieve Isolate directly from AccessorInfo or Arguments. No tests. No behavior change. * bindings/v8/custom/V8BlobCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8CSSRuleCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8CSSStyleSheetCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8CSSValueCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8DOMStringMapCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8DOMTokenListCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8DataViewCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8EntryCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8EntrySyncCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8Float32ArrayCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8Float64ArrayCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8HTMLElementCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8IDBKeyCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8ImageDataCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8Int16ArrayCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8Int32ArrayCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8Int8ArrayCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8LocationCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow): * bindings/v8/custom/V8SVGDocumentCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8SVGElementCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8SVGPathSegCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8ScriptProfileCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8StyleSheetCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8Uint16ArrayCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8Uint32ArrayCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8Uint8ArrayCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp: (WebCore::toV8): * bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::toV8): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8CSSRuleCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleSheetCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8CSSValueCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8DOMTokenListCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8EntryCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8EntrySyncCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8EventCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8Float32ArrayCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8Float64ArrayCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8IDBKeyCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8ImageDataCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8Int16ArrayCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8Int32ArrayCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8Int8ArrayCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8SVGDocumentCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8SVGElementCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8SVGPathSegCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8Uint16ArrayCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8Uint32ArrayCustom.cpp trunk/Source/WebCore/bin
[webkit-changes] [119000] trunk/LayoutTests
Title: [119000] trunk/LayoutTests Revision 119000 Author jber...@webkit.org Date 2012-05-30 17:12:26 -0700 (Wed, 30 May 2012) Log Message [Win] 8 accessibility tests failing https://bugs.webkit.org/show_bug.cgi?id=87909 Add expected (failing?) results for Windows to get the bots greener. * platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added. * platform/win/accessibility/disabled-controls-not-focusable-expected.txt: Added. * platform/win/accessibility/focus-events-expected.txt: * platform/win/accessibility/img-alt-tag-only-whitespace-expected.txt: Added. * platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: * platform/win/accessibility/select-element-valuechange-event-expected.txt: * platform/win/accessibility/textbox-role-reports-line-number-expected.txt: Added. * platform/win/accessibility/textbox-role-reports-selection-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/accessibility/focus-events-expected.txt trunk/LayoutTests/platform/win/accessibility/option-element-selection-and-focus-events-expected.txt trunk/LayoutTests/platform/win/accessibility/select-element-valuechange-event-expected.txt Added Paths trunk/LayoutTests/platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt trunk/LayoutTests/platform/win/accessibility/disabled-controls-not-focusable-expected.txt trunk/LayoutTests/platform/win/accessibility/img-alt-tag-only-whitespace-expected.txt trunk/LayoutTests/platform/win/accessibility/textbox-role-reports-line-number-expected.txt trunk/LayoutTests/platform/win/accessibility/textbox-role-reports-selection-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (118999 => 119000) --- trunk/LayoutTests/ChangeLog 2012-05-31 00:11:19 UTC (rev 118999) +++ trunk/LayoutTests/ChangeLog 2012-05-31 00:12:26 UTC (rev 119000) @@ -1,3 +1,19 @@ +2012-05-30 Jessie Berlin + +[Win] 8 accessibility tests failing +https://bugs.webkit.org/show_bug.cgi?id=87909 + +Add expected (failing?) results for Windows to get the bots greener. + +* platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added. +* platform/win/accessibility/disabled-controls-not-focusable-expected.txt: Added. +* platform/win/accessibility/focus-events-expected.txt: +* platform/win/accessibility/img-alt-tag-only-whitespace-expected.txt: Added. +* platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: +* platform/win/accessibility/select-element-valuechange-event-expected.txt: +* platform/win/accessibility/textbox-role-reports-line-number-expected.txt: Added. +* platform/win/accessibility/textbox-role-reports-selection-expected.txt: Added. + 2012-05-30 Emil A Eklund Unreviewed test expectations updates for window and mac now that we no longer skip a couple of tests on those platforms. Added: trunk/LayoutTests/platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt (0 => 119000) --- trunk/LayoutTests/platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt (rev 0) +++ trunk/LayoutTests/platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt 2012-05-31 00:12:26 UTC (rev 119000) @@ -0,0 +1,70 @@ +Before + +After + +End of test + +This tests that deleting an iframe doesn't cause the accessibility cache to be destroyed and recreated. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + + +Before: +document +client +grouping +editable text +grouping +client +client +client +grouping +push button +grouping +editable text +grouping +editable text +grouping +editable text +grouping +editable text +editable text +editable text +editable text +editable text +grouping +editable text + +After: +document +client +grouping +editable text +grouping +grouping +editable text +grouping +editable text +grouping +editable text +grouping +editable text +editable text +editable text +editable text +editable text +grouping +editable text +client + +FAIL frameBodyRole == frameBody.role should be false. Was true. +PASS frameGroupRole == frameGroup.role is false +PASS frameButtonRole == frameButton.role is false +PASS root.isEqual(newRoot) is true +PASS body.isEqual(newBody) is true +PASS before.isEqual(newBefore) is true +FAIL after.isEqual(newAfter) should be true. Was f
[webkit-changes] [118999] trunk/Source/WebCore
Title: [118999] trunk/Source/WebCore
Revision 118999
Author hara...@chromium.org
Date 2012-05-30 17:11:19 -0700 (Wed, 30 May 2012)
Log Message
[V8] Replace v8::Null() with v8::Null(isolate) or v8NullWithCheck(isolate) in non-custom bindings
https://bugs.webkit.org/show_bug.cgi?id=87810
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
For non-custom bindings, we replace v8::Null() with v8::Null(isolate)
where isolate cannot be 0, and replace v8::Null() with v8NullWithCheck(isolate)
where isolate can be 0.
This will be the final patch for passing Isolate to v8::Null().
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserialize):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (118998 => 118999)
--- trunk/Source/WebCore/ChangeLog 2012-05-31 00:02:42 UTC (rev 118998)
+++ trunk/Source/WebCore/ChangeLog 2012-05-31 00:11:19 UTC (rev 118999)
@@ -1,5 +1,35 @@
2012-05-30 Kentaro Hara
+[V8] Replace v8::Null() with v8::Null(isolate) or v8NullWithCheck(isolate) in non-custom bindings
+https://bugs.webkit.org/show_bug.cgi?id=87810
+
+Reviewed by Adam Barth.
+
+The objective is to pass Isolate around in V8 bindings.
+For non-custom bindings, we replace v8::Null() with v8::Null(isolate)
+where isolate cannot be 0, and replace v8::Null() with v8NullWithCheck(isolate)
+where isolate can be 0.
+
+This will be the final patch for passing Isolate to v8::Null().
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateNormalAttrGetter):
+(GenerateFunctionCallback):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
+(WebCore::TestObjV8Internal::getSVGDocumentCallback):
+* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
+(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
+(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
+* bindings/v8/SerializedScriptValue.cpp:
+(WebCore::SerializedScriptValue::deserialize):
+* bindings/v8/V8DOMWrapper.cpp:
+(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
+
+2012-05-30 Kentaro Hara
+
[V8] Replace v8::Null() with v8::Null(isolate) in custom bindings where isolate shouldn't be 0
https://bugs.webkit.org/show_bug.cgi?id=87809
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (118998 => 118999)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-31 00:02:42 UTC (rev 118998)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-31 00:11:19 UTC (rev 118999)
@@ -843,7 +843,7 @@
# Generate security checks if necessary
if ($attribute->signature->extendedAttributes->{"CheckSecurityForNode"}) {
-push(@implContentDecls, "if (!V8BindingSecurity::shouldAllowAccessToNode(V8BindingState::Only(), imp->" . $attribute->signature->name . "()))\nreturn v8::Handle(v8::Null());\n\n");
+push(@implContentDecls, "if (!V8BindingSecurity::shouldAllowAccessToNode(V8BindingState::Only(), imp->" . $attribute->signature->name . "()))\nreturn v8::Handle(v8::Null(info.GetIsolate()));\n\n");
}
my $useExceptions = 1 if @{$attribute->getterExceptions};
@@ -1005,7 +1005,7 @@
my $getterFunc = $codeGenerator->WK_lcfirst($attribute->signature->name);
push(@implContentDecls, < SerializedScriptValue* serialized = imp->${getterFunc}();
-value = serialized ? serialized->deserialize() : v8::Handle(v8::Null());
+value = serialized ? serialized->deserialize() : v8::Handle(v8::Null(info.GetIsolate()));
info.Holder()->SetHiddenValue(propertyName, value);
return value;
END
@@ -1438,7 +1438,7 @@
if ($function->signature->extendedAttributes->{"CheckSecurityForNode"}) {
push(@
[webkit-changes] [118998] trunk/Source/WebCore
Title: [118998] trunk/Source/WebCore Revision 118998 Author hara...@chromium.org Date 2012-05-30 17:02:42 -0700 (Wed, 30 May 2012) Log Message [V8] Replace v8::Null() with v8::Null(isolate) in custom bindings where isolate shouldn't be 0 https://bugs.webkit.org/show_bug.cgi?id=87809 Reviewed by Adam Barth. The objective is to pass Isolate around in V8 bindings. This patch replaces v8::Null() with v8::Null(isolate) in custom bindings where isolate shouldn't be 0. 'where isolate shouldn't be 0' is the place where isolate is retrieved directly from AccessorInfo and Arguments. This patch includes a couple of refactorings: - Makes V8DeviceMotionEvent::createAccelerationObject() and V8DeviceMotionEvent::createRotationRateObject() static - Moves V8HTMLElement::toV8Object() into the existing ENABLE(MICRODATA) flag. No tests. No change in behavior. * bindings/v8/custom/V8ClipboardCustom.cpp: (WebCore::V8Clipboard::typesAccessorGetter): * bindings/v8/custom/V8CoordinatesCustom.cpp: (WebCore::V8Coordinates::altitudeAccessorGetter): (WebCore::V8Coordinates::altitudeAccuracyAccessorGetter): (WebCore::V8Coordinates::headingAccessorGetter): (WebCore::V8Coordinates::speedAccessorGetter): * bindings/v8/custom/V8DeviceMotionEventCustom.cpp: (WebCore::V8DeviceMotionEvent::accelerationAccessorGetter): (WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter): (WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter): (WebCore::V8DeviceMotionEvent::intervalAccessorGetter): * bindings/v8/custom/V8DeviceOrientationEventCustom.cpp: (WebCore::V8DeviceOrientationEvent::alphaAccessorGetter): (WebCore::V8DeviceOrientationEvent::betaAccessorGetter): (WebCore::V8DeviceOrientationEvent::gammaAccessorGetter): (WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter): * bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorGetter): * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback): * bindings/v8/custom/V8HTMLElementCustom.cpp: (WebCore::toV8): (WebCore): (WebCore::toV8Object): * bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::stateAccessorGetter): * bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::dataAccessorGetter): * bindings/v8/custom/V8NodeCustom.cpp: (WebCore::V8Node::insertBeforeCallback): (WebCore::V8Node::replaceChildCallback): (WebCore::V8Node::removeChildCallback): (WebCore::V8Node::appendChildCallback): * bindings/v8/custom/V8PopStateEventCustom.cpp: (WebCore::V8PopStateEvent::stateAccessorGetter): * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: (WebCore::V8SQLResultSetRowList::itemCallback): * bindings/v8/custom/V8TrackEventCustom.cpp: (WebCore::V8TrackEvent::trackAccessorGetter): * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object): (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback): (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8CoordinatesCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8DeviceMotionEventCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8DeviceOrientationEventCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8DocumentLocationCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (118997 => 118998) --- trunk/Source/WebCore/ChangeLog 2012-05-30 23:56:24 UTC (rev 118997) +++ trunk/Source/WebCore/ChangeLog 2012-05-31 00:02:42 UTC (rev 118998) @@ -1,3 +1,69 @@ +2012-05-30 Kentaro Hara + +[V8] Replace v8::Null() with v8::Null(isolate) in custom bindings where isolate shouldn't be 0 +https://bugs.webkit.org/show_bug.cgi?id=87809 + +Reviewed by Adam Barth. + +The objective is to pass Isolate around in V8 bindings. +This patch replaces v8::Null() with v8::Null(isolate) in custom bindings +where isolate shouldn't be 0. 'where isolate shouldn't be 0' is the place +where isolate is retrieved directly from AccessorInfo and Arguments. + +This patch includes a couple of refactorings: + +- Makes V8DeviceMotionEvent::createAccelerationObject() and +V8DeviceMotionEvent::createRotationRateObject() static + +- Moves V8HTMLElement::toV8Object() into the existing ENABLE(MICRODA
[webkit-changes] [118997] trunk/Source/WebKit2
Title: [118997] trunk/Source/WebKit2
Revision 118997
Author commit-qu...@webkit.org
Date 2012-05-30 16:56:24 -0700 (Wed, 30 May 2012)
Log Message
[Qt] handled touchmove events should not cancel tap gesture recognition
https://bugs.webkit.org/show_bug.cgi?id=87808
Patch by Luiz Agostini on 2012-05-30
Reviewed by Kenneth Rohde Christiansen.
Tap gesture recognition should not be canceled if a touchmove event is handled
by the web process.
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (118996 => 118997)
--- trunk/Source/WebKit2/ChangeLog 2012-05-30 23:55:44 UTC (rev 118996)
+++ trunk/Source/WebKit2/ChangeLog 2012-05-30 23:56:24 UTC (rev 118997)
@@ -1,3 +1,16 @@
+2012-05-30 Luiz Agostini
+
+[Qt] handled touchmove events should not cancel tap gesture recognition
+https://bugs.webkit.org/show_bug.cgi?id=87808
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Tap gesture recognition should not be canceled if a touchmove event is handled
+by the web process.
+
+* UIProcess/qt/QtWebPageEventHandler.cpp:
+(WebKit::QtWebPageEventHandler::doneWithTouchEvent):
+
2012-05-30 Mario Sanchez Prada
[GTK][WK2] Errors in documentation about webkit_web_view_run_javascript()
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp (118996 => 118997)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp 2012-05-30 23:55:44 UTC (rev 118996)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp 2012-05-30 23:56:24 UTC (rev 118997)
@@ -436,7 +436,10 @@
return;
if (wasEventHandled || event.type() == WebEvent::TouchCancel) {
-resetGestureRecognizers();
+m_panGestureRecognizer.cancel();
+m_pinchGestureRecognizer.cancel();
+if (event.type() != WebEvent::TouchMove)
+m_tapGestureRecognizer.cancel();
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118996] trunk/Tools
Title: [118996] trunk/Tools
Revision 118996
Author o...@chromium.org
Date 2012-05-30 16:55:44 -0700 (Wed, 30 May 2012)
Log Message
Only give lint errors for -expected.png png files that lack a checksum
https://bugs.webkit.org/show_bug.cgi?id=87875
Reviewed by Tony Chang.
We have other pngs in the tree, e.g. for the inspector, that legitimately
lack a checksum.
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.check):
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_check):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/png.py
trunk/Tools/Scripts/webkitpy/style/checkers/png_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (118995 => 118996)
--- trunk/Tools/ChangeLog 2012-05-30 23:47:27 UTC (rev 118995)
+++ trunk/Tools/ChangeLog 2012-05-30 23:55:44 UTC (rev 118996)
@@ -1,3 +1,18 @@
+2012-05-30 Ojan Vafai
+
+Only give lint errors for -expected.png png files that lack a checksum
+https://bugs.webkit.org/show_bug.cgi?id=87875
+
+Reviewed by Tony Chang.
+
+We have other pngs in the tree, e.g. for the inspector, that legitimately
+lack a checksum.
+
+* Scripts/webkitpy/style/checkers/png.py:
+(PNGChecker.check):
+* Scripts/webkitpy/style/checkers/png_unittest.py:
+(PNGCheckerTest.test_check):
+
2012-05-30 Dirk Pranke
nrwt: seems to leak temp dirs
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/png.py (118995 => 118996)
--- trunk/Tools/Scripts/webkitpy/style/checkers/png.py 2012-05-30 23:47:27 UTC (rev 118995)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/png.py 2012-05-30 23:55:44 UTC (rev 118996)
@@ -48,7 +48,7 @@
config_file_path = ""
detection = self._detector.display_name()
-if self._fs.exists(self._file_path):
+if self._fs.exists(self._file_path) and self._file_path.endswith("-expected.png"):
with self._fs.open_binary_file_for_reading(self._file_path) as filehandle:
if not read_checksum_from_png.read_checksum(filehandle):
self._handle_style_error(0, 'image/png', 5, "Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum.")
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/png_unittest.py (118995 => 118996)
--- trunk/Tools/Scripts/webkitpy/style/checkers/png_unittest.py 2012-05-30 23:47:27 UTC (rev 118995)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/png_unittest.py 2012-05-30 23:55:44 UTC (rev 118996)
@@ -119,6 +119,14 @@
errors = []
checker = PNGChecker(file_path, mock_handle_style_error, scm, MockSystemHost(os_name='linux', filesystem=fs))
checker.check()
+self.assertEquals(len(errors), 1)
+
+file_path = "foo-expected.png"
+fs.write_binary_file(file_path, "Dummy binary data")
+scm = MockSCMDetector('git')
+errors = []
+checker = PNGChecker(file_path, mock_handle_style_error, scm, MockSystemHost(os_name='linux', filesystem=fs))
+checker.check()
self.assertEquals(len(errors), 2)
self.assertEquals(errors[0], (0, 'image/png', 5, 'Image lacks a checksum. Generate pngs using run-webkit-tests to ensure they have a checksum.'))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118995] trunk/Source/JavaScriptCore
Title: [118995] trunk/Source/_javascript_Core
Revision 118995
Author oli...@apple.com
Date 2012-05-30 16:47:27 -0700 (Wed, 30 May 2012)
Log Message
Really provide error information with the inspector disabled
https://bugs.webkit.org/show_bug.cgi?id=87910
Reviewed by Filip Pizlo.
Don't bother checking for anything other than pre-existing error info.
In the absence of complete line number information you'll only get the
line a function starts on, but at least it's something.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (118994 => 118995)
--- trunk/Source/_javascript_Core/ChangeLog 2012-05-30 23:35:34 UTC (rev 118994)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-05-30 23:47:27 UTC (rev 118995)
@@ -1,3 +1,17 @@
+2012-05-30 Oliver Hunt
+
+Really provide error information with the inspector disabled
+https://bugs.webkit.org/show_bug.cgi?id=87910
+
+Reviewed by Filip Pizlo.
+
+Don't bother checking for anything other than pre-existing error info.
+In the absence of complete line number information you'll only get the
+line a function starts on, but at least it's something.
+
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::throwException):
+
2012-05-30 Filip Pizlo
LLInt broken on x86-32 with JIT turned off
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (118994 => 118995)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2012-05-30 23:35:34 UTC (rev 118994)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2012-05-30 23:47:27 UTC (rev 118995)
@@ -1024,7 +1024,7 @@
if (exception->isErrorInstance() && static_cast(exception)->appendSourceToMessage())
appendSourceToError(callFrame, static_cast(exception), bytecodeOffset);
-if (codeBlock->hasLineInfo() && !hasErrorInfo(callFrame, exception)) {
+if (!hasErrorInfo(callFrame, exception)) {
// FIXME: should only really be adding these properties to VM generated exceptions,
// but the inspector currently requires these for all thrown objects.
addErrorInfo(callFrame, exception, codeBlock->lineNumberForBytecodeOffset(bytecodeOffset), codeBlock->ownerExecutable()->source());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118994] trunk/LayoutTests
Title: [118994] trunk/LayoutTests
Revision 118994
Author e...@chromium.org
Date 2012-05-30 16:35:34 -0700 (Wed, 30 May 2012)
Log Message
Unreviewed test expectations updates for window and mac now that we no longer skip a couple of tests on those platforms.
* platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.png:
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png:
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt:
* platform/chromium-win/fast/block/margin-collapse/103-expected.png:
* platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.png
trunk/LayoutTests/platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png
trunk/LayoutTests/platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/block/margin-collapse/103-expected.png
trunk/LayoutTests/platform/chromium-win/fast/block/margin-collapse/103-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (118993 => 118994)
--- trunk/LayoutTests/ChangeLog 2012-05-30 23:10:40 UTC (rev 118993)
+++ trunk/LayoutTests/ChangeLog 2012-05-30 23:35:34 UTC (rev 118994)
@@ -1,3 +1,13 @@
+2012-05-30 Emil A Eklund
+
+Unreviewed test expectations updates for window and mac now that we no longer skip a couple of tests on those platforms.
+
+* platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.png:
+* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png:
+* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt:
+* platform/chromium-win/fast/block/margin-collapse/103-expected.png:
+* platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
+
2012-05-30 Dan Bernstein
[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/fast/backgrounds/background-position-parsing-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt (118993 => 118994)
--- trunk/LayoutTests/platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt 2012-05-30 23:10:40 UTC (rev 118993)
+++ trunk/LayoutTests/platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt 2012-05-30 23:35:34 UTC (rev 118994)
@@ -1,7 +1,7 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x232
- RenderBlock {HTML} at (0,0) size 800x233
+layer at (0,0) size 800x407
+ RenderBlock {HTML} at (0,0) size 800x408
RenderBody {BODY} at (8,16) size 784x20
RenderBlock {P} at (0,0) size 784x20
RenderText {#text} at (0,0) size 470x19
@@ -60,99 +60,99 @@
RenderBlock (floating) {DIV} at (678,97) size 82x57 [border: (3px solid #00)]
RenderBlock {DIV} at (3,3) size 75x50 [bgcolor=#CC]
RenderBlock {DIV} at (8,8) size 59x34
- RenderBlock (floating) {DIV} at (1,158) size 82x57 [border: (3px solid #00)]
+ RenderBlock (floating) {DIV} at (1,156) size 82x57 [border: (3px solid #00)]
RenderBlock {DIV} at (3,3) size 75x50 [bgcolor=#CC]
RenderBlock {DIV} at (8,8) size 59x34
- RenderBlock (floating) {DIV} at (1,158) size 82x57 [border: (3px solid #00)]
+ RenderBlock (floating) {DIV} at (86,156) size 82x57 [border: (3px solid #00)]
RenderBlock {DIV} at (3,3) size 75x50 [bgcolor=#CC]
RenderBlock {DIV} at (8,8) size 59x34
- RenderBlock (floating) {DIV} at (1,158) size 82x57 [border: (3px solid #00)]
+ RenderBlock (floating) {DIV} at (170,156) size 82x57 [border: (3px solid #00)]
RenderBlock {DIV} at (3,3) size 75x50 [bgcolor=#CC]
RenderBlock {DIV} at (8,8) size 59x34
- RenderBlock (floating) {DIV} at (1,158) size 82x57 [border: (3px solid #00)]
+ RenderBlock (floating) {DIV} at (255,156) size 82x57 [border: (3px solid #00)]
RenderBlock {DIV} at (3,3) size 75x50 [bgcolor=#CC]
RenderBlock {DIV} at (8,8) size 59x34
- RenderBlock (floating) {DIV} at (1,158) size 82x57 [border: (3px solid #00)]
+ RenderBlock (floating) {DIV} at (340,156) size 82x57 [border: (3px solid #00)]
RenderBlock {DIV} at (3,3) size 75x50 [bgcolor=#CC]
RenderBlock {DIV} at (8,8) size 59x34
- RenderBlock (floating) {DIV} at (1,158) size 82x57 [border: (3px solid #00)]
+ RenderBlock (floating) {DIV} at (424,156) size 82x
[webkit-changes] [118993] trunk
Title: [118993] trunk
Revision 118993
Author tha...@chromium.org
Date 2012-05-30 16:10:40 -0700 (Wed, 30 May 2012)
Log Message
Make the files attribute of HTMLInputElement writable
https://bugs.webkit.org/show_bug.cgi?id=87154
Reviewed by Adam Barth.
whatwg thread:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-May/036140.html
* bindings/objc/PublicDOMInterfaces.h:
Remove readonly on files property.
* html/FileInputType.cpp:
(FileInputType):
Add a NULL check to setFiles().
* html/FileInputType.h:
(FileInputType):
Let setFiles() overwrite the base class's method.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setFiles):
Add setFiles() implementation, delegate to input type.
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/HTMLInputElement.idl:
* html/InputType.cpp:
(WebCore::InputType::setFiles):
setFiles() does nothing by default.
* html/InputType.h:
(InputType):
Add a virtual setFiles() method.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/objc/PublicDOMInterfaces.h
trunk/Source/WebCore/html/FileInputType.cpp
trunk/Source/WebCore/html/FileInputType.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/HTMLInputElement.idl
trunk/Source/WebCore/html/InputType.cpp
trunk/Source/WebCore/html/InputType.h
Added Paths
trunk/LayoutTests/fast/forms/file/input-file-write-files-expected.txt
trunk/LayoutTests/fast/forms/file/input-file-write-files.html
Diff
Added: trunk/LayoutTests/fast/forms/file/input-file-write-files-expected.txt (0 => 118993)
--- trunk/LayoutTests/fast/forms/file/input-file-write-files-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/file/input-file-write-files-expected.txt 2012-05-30 23:10:40 UTC (rev 118993)
@@ -0,0 +1,6 @@
+Test drops files here
+
+PASS: 1 file after drag
+PASS: writing nonempty string to value had no effect
+PASS: writing empty string to value cleared files
+
Added: trunk/LayoutTests/fast/forms/file/input-file-write-files.html (0 => 118993)
--- trunk/LayoutTests/fast/forms/file/input-file-write-files.html (rev 0)
+++ trunk/LayoutTests/fast/forms/file/input-file-write-files.html 2012-05-30 23:10:40 UTC (rev 118993)
@@ -0,0 +1,85 @@
+
+
+
+Test drops files here
+
+
+
+
+
+
+function log(message)
+{
+document.getElementById('output').appendChild(document.createTextNode(message + "\n"));
+}
+
+function onInputFileChange()
+{
+var files = document.getElementById("files").files;
+if (files.length != 1)
+log("FAIL: Expected 1 file after drag.")
+else
+log("PASS: 1 file after drag");
+
+doStringTest();
+
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+function handleDragOver(e) {
+e.stopPropagation();
+e.preventDefault();
+}
+
+function handleDrop(e) {
+e.stopPropagation();
+e.preventDefault();
+document.getElementById("files").files = e.dataTransfer.files;
+}
+
+var droptarget = document.getElementById('droptarget');
+droptarget.addEventListener('dragover', handleDragOver, false);
+droptarget.addEventListener('drop', handleDrop, false);
+
+function doTest(fileList)
+{
+// This drops files on a div, which copies them to the input element, whose
+// callback calls notifyDone().
+document.getElementById("files")._onchange_ = onInputFileChange;
+var fi = document.getElementById("files");
+eventSender.beginDragWithFiles(['../resources/test.txt']);
+eventSender.mouseMoveTo(droptarget.offsetLeft + 10, droptarget.offsetTop + droptarget.offsetHeight / 2);
+eventSender.mouseUp();
+}
+
+function doStringTest()
+{
+var files = document.getElementById("files");
+files.files = "foo"; // Shouldn't crash.
+
+files.value = "foo"; // Should do nothing.
+if (files.files.length > 0)
+log("PASS: writing nonempty string to value had no effect");
+else
+log("FAIL: writing nonempty string to value cleared elements");
+
+files.value = "";
+if (files.files.length === 0)
+log("PASS: writing empty string to value cleared files");
+else
+log("FAIL: writing empty string to value did not clear files");
+}
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+if (window.eventSender) {
+doTest();
+}
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (118992 => 118993)
--- trunk/Source/WebCore/ChangeLog 2012-05-30 23:09:45 UTC (rev 118992)
+++ trunk/Source/WebCore/ChangeLog 2012-05-30 23:10:40 UTC (rev 118993)
@@ -1,3 +1,34 @@
+2012-05-30 Nico Weber
+
+Make the files attribute of HTMLInputElement writable
+https://bugs.webkit.org/show_bug.cgi?id=87154
+
+Reviewed by Adam Barth.
+
+whatwg thread:
+http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-May/036140.html
+
+* bindings/
[webkit-changes] [118992] trunk/Source/JavaScriptCore
Title: [118992] trunk/Source/_javascript_Core Revision 118992 Author fpi...@apple.com Date 2012-05-30 16:09:45 -0700 (Wed, 30 May 2012) Log Message LLInt broken on x86-32 with JIT turned off https://bugs.webkit.org/show_bug.cgi?id=87906 Reviewed by Geoffrey Garen. Fixed the code to not clobber registers that contain important things, like the call frame. * llint/LowLevelInterpreter32_64.asm: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm Diff Modified: trunk/Source/_javascript_Core/ChangeLog (118991 => 118992) --- trunk/Source/_javascript_Core/ChangeLog 2012-05-30 23:07:22 UTC (rev 118991) +++ trunk/Source/_javascript_Core/ChangeLog 2012-05-30 23:09:45 UTC (rev 118992) @@ -1,5 +1,16 @@ 2012-05-30 Filip Pizlo +LLInt broken on x86-32 with JIT turned off +https://bugs.webkit.org/show_bug.cgi?id=87906 + +Reviewed by Geoffrey Garen. + +Fixed the code to not clobber registers that contain important things, like the call frame. + +* llint/LowLevelInterpreter32_64.asm: + +2012-05-30 Filip Pizlo + ScriptDebugServer wants sourceIDs that are non-zero because that's what HashMaps want, so JSC should placate it https://bugs.webkit.org/show_bug.cgi?id=87887 Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (118991 => 118992) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2012-05-30 23:07:22 UTC (rev 118991) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2012-05-30 23:09:45 UTC (rev 118992) @@ -1668,8 +1668,8 @@ storei CellTag, ScopeChain + TagOffset[cfr] storei t1, ScopeChain + PayloadOffset[cfr] if X86 -loadp JITStackFrame::globalData + 4[sp], t0 # Additional offset for return address -storep cfr, JSGlobalData::topCallFrame[t0] +loadp JITStackFrame::globalData + 4[sp], t3 # Additional offset for return address +storep cfr, JSGlobalData::topCallFrame[t3] peek 0, t1 storep t1, ReturnPC[cfr] move cfr, t2 # t2 = ecx @@ -1681,8 +1681,8 @@ addp 16 - 4, sp loadp JITStackFrame::globalData + 4[sp], t3 elsif ARMv7 -loadp JITStackFrame::globalData[sp], t1 -storep cfr, JSGlobalData::topCallFrame[t1] +loadp JITStackFrame::globalData[sp], t3 +storep cfr, JSGlobalData::topCallFrame[t3] move t0, t2 preserveReturnAddressAfterCall(t3) storep t3, ReturnPC[cfr] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118991] trunk/Source/WebCore
Title: [118991] trunk/Source/WebCore
Revision 118991
Author commit-qu...@webkit.org
Date 2012-05-30 16:07:22 -0700 (Wed, 30 May 2012)
Log Message
[BlackBerry] Remove useless string->char*->string conversion in NetworkJob.
https://bugs.webkit.org/show_bug.cgi?id=87861
Patch by Joe Mason on 2012-05-30
Reviewed by Antonio Gomes.
RIM PR #152383: username is a WTF::String. ResourceHandleInternal::m_user is a string. Yet they're
assigned with "username = m_user.utf8().data()". Pointless: "username = m_user" will do.
No new tests since there is no behaviour change.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (118990 => 118991)
--- trunk/Source/WebCore/ChangeLog 2012-05-30 22:58:54 UTC (rev 118990)
+++ trunk/Source/WebCore/ChangeLog 2012-05-30 23:07:22 UTC (rev 118991)
@@ -1,3 +1,18 @@
+2012-05-30 Joe Mason
+
+[BlackBerry] Remove useless string->char*->string conversion in NetworkJob.
+https://bugs.webkit.org/show_bug.cgi?id=87861
+
+Reviewed by Antonio Gomes.
+
+RIM PR #152383: username is a WTF::String. ResourceHandleInternal::m_user is a string. Yet they're
+assigned with "username = m_user.utf8().data()". Pointless: "username = m_user" will do.
+
+No new tests since there is no behaviour change.
+
+* platform/network/blackberry/NetworkJob.cpp:
+(WebCore::NetworkJob::sendRequestWithCredentials):
+
2012-05-30 Dan Bernstein
[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (118990 => 118991)
--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-05-30 22:58:54 UTC (rev 118990)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-05-30 23:07:22 UTC (rev 118991)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009, 2010, 2011 Research In Motion Limited. All rights reserved.
+ * Copyright (C) 2009, 2010, 2011, 2012 Research In Motion Limited. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@@ -749,8 +749,8 @@
if (username.isEmpty() || password.isEmpty()) {
// Before asking the user for credentials, we check if the URL contains that.
if (!m_handle->getInternal()->m_user.isEmpty() && !m_handle->getInternal()->m_pass.isEmpty()) {
-username = m_handle->getInternal()->m_user.utf8().data();
-password = m_handle->getInternal()->m_pass.utf8().data();
+username = m_handle->getInternal()->m_user;
+password = m_handle->getInternal()->m_pass;
// Prevent them from been used again if they are wrong.
// If they are correct, they will the put into CredentialStorage.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118990] trunk
Title: [118990] trunk
Revision 118990
Author m...@apple.com
Date 2012-05-30 15:58:54 -0700 (Wed, 30 May 2012)
Log Message
[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=87740
Reviewed by Darin Adler.
Source/WebCore:
* platform/text/qt/TextBreakIteratorQt.cpp:
(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Changed to use
the return value of setUpIterator.
LayoutTests:
* platform/qt-4.8/Skipped: Removed fast/forms/textarea-maxlength.html.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-4.8/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/qt/TextBreakIteratorQt.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (118989 => 118990)
--- trunk/LayoutTests/ChangeLog 2012-05-30 22:50:31 UTC (rev 118989)
+++ trunk/LayoutTests/ChangeLog 2012-05-30 22:58:54 UTC (rev 118990)
@@ -1,3 +1,12 @@
+2012-05-30 Dan Bernstein
+
+[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
+https://bugs.webkit.org/show_bug.cgi?id=87740
+
+Reviewed by Darin Adler.
+
+* platform/qt-4.8/Skipped: Removed fast/forms/textarea-maxlength.html.
+
2012-05-30 Raphael Kubo da Costa
[EFL] Gardening. Unskip test that is now passing.
Modified: trunk/LayoutTests/platform/qt-4.8/Skipped (118989 => 118990)
--- trunk/LayoutTests/platform/qt-4.8/Skipped 2012-05-30 22:50:31 UTC (rev 118989)
+++ trunk/LayoutTests/platform/qt-4.8/Skipped 2012-05-30 22:58:54 UTC (rev 118990)
@@ -156,7 +156,3 @@
# Fail with QtXmlPatterns (used by Qt 4.8 buid), but pass with libxslt (used by Qt 5 build)
fast/parser/innerhtml-with-prefixed-elements.xhtml
-
-# [Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
-# https://bugs.webkit.org/show_bug.cgi?id=87740
-fast/forms/textarea-maxlength.html
Modified: trunk/Source/WebCore/ChangeLog (118989 => 118990)
--- trunk/Source/WebCore/ChangeLog 2012-05-30 22:50:31 UTC (rev 118989)
+++ trunk/Source/WebCore/ChangeLog 2012-05-30 22:58:54 UTC (rev 118990)
@@ -1,3 +1,14 @@
+2012-05-30 Dan Bernstein
+
+[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
+https://bugs.webkit.org/show_bug.cgi?id=87740
+
+Reviewed by Darin Adler.
+
+* platform/text/qt/TextBreakIteratorQt.cpp:
+(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Changed to use
+the return value of setUpIterator.
+
2012-05-30 Zeno Albisser
GraphicsSurface: allow importing and exporting of textures directly on GPU side.
Modified: trunk/Source/WebCore/platform/text/qt/TextBreakIteratorQt.cpp (118989 => 118990)
--- trunk/Source/WebCore/platform/text/qt/TextBreakIteratorQt.cpp 2012-05-30 22:50:31 UTC (rev 118989)
+++ trunk/Source/WebCore/platform/text/qt/TextBreakIteratorQt.cpp 2012-05-30 22:58:54 UTC (rev 118990)
@@ -76,7 +76,10 @@
bool createdIterator = m_iterator && weakCompareAndSwap(reinterpret_cast(&nonSharedCharacterBreakIterator), m_iterator, 0);
if (!createdIterator)
m_iterator = new TextBreakIterator();
-setUpIterator(*m_iterator, QTextBoundaryFinder::Grapheme, buffer, length);
+if (!setUpIterator(*m_iterator, QTextBoundaryFinder::Grapheme, buffer, length)) {
+delete m_iterator;
+m_iterator = 0;
+}
}
NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118989] trunk/LayoutTests
Title: [118989] trunk/LayoutTests Revision 118989 Author rak...@webkit.org Date 2012-05-30 15:50:31 -0700 (Wed, 30 May 2012) Log Message [EFL] Gardening. Unskip test that is now passing. * platform/efl/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (118988 => 118989) --- trunk/LayoutTests/ChangeLog 2012-05-30 22:49:07 UTC (rev 118988) +++ trunk/LayoutTests/ChangeLog 2012-05-30 22:50:31 UTC (rev 118989) @@ -1,3 +1,9 @@ +2012-05-30 Raphael Kubo da Costa + +[EFL] Gardening. Unskip test that is now passing. + +* platform/efl/test_expectations.txt: + 2012-05-30 Emil A Eklund Unreviewed chromium snowleopard rebaseline for background-position-parsing test following r118978. Modified: trunk/LayoutTests/platform/efl/test_expectations.txt (118988 => 118989) --- trunk/LayoutTests/platform/efl/test_expectations.txt 2012-05-30 22:49:07 UTC (rev 118988) +++ trunk/LayoutTests/platform/efl/test_expectations.txt 2012-05-30 22:50:31 UTC (rev 118989) @@ -587,8 +587,6 @@ // Times-out with debug build during heavy cpu loads BUGWK85902 SLOW DEBUG : fast/overflow/lots-of-sibling-inline-boxes.html = PASS -BUGWK85799 : fast/css/font-face-download-error.html = TIMEOUT - BUGWK82675 : http/tests/local/link-stylesheet-load-order.html = TEXT BUGWKEFL SLOW DEBUG : http/tests/incremental/slow-utf8-html.pl = PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118988] trunk/LayoutTests
Title: [118988] trunk/LayoutTests Revision 118988 Author e...@chromium.org Date 2012-05-30 15:49:07 -0700 (Wed, 30 May 2012) Log Message Unreviewed chromium snowleopard rebaseline for background-position-parsing test following r118978. * platform/chromium-mac-snowleopard/fast/backgrounds/background-position-parsing-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/backgrounds/background-position-parsing-expected.png Property Changed trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/backgrounds/background-position-parsing-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (118987 => 118988) --- trunk/LayoutTests/ChangeLog 2012-05-30 22:43:48 UTC (rev 118987) +++ trunk/LayoutTests/ChangeLog 2012-05-30 22:49:07 UTC (rev 118988) @@ -1,3 +1,9 @@ +2012-05-30 Emil A Eklund + +Unreviewed chromium snowleopard rebaseline for background-position-parsing test following r118978. + +* platform/chromium-mac-snowleopard/fast/backgrounds/background-position-parsing-expected.png: + 2012-05-30 Alec Flett IndexedDB: Implement IDBTransaction.error and IDBRequest.error Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/backgrounds/background-position-parsing-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/backgrounds/background-position-parsing-expected.png ___ Modified: svn:mime-type + image/png ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118987] trunk/Source/WebCore
Title: [118987] trunk/Source/WebCore
Revision 118987
Author zeno.albis...@nokia.com
Date 2012-05-30 15:43:48 -0700 (Wed, 30 May 2012)
Log Message
GraphicsSurface: allow importing and exporting of textures directly on GPU side.
https://bugs.webkit.org/show_bug.cgi?id=87725
Add copyFromFramebuffer function to copy a texture from an FBO
onto the GraphicsSurface.
Add getTextureID function to export the texture ID.
This allows binding/blitting the texture directly on the GPU.
Reviewed by Noam Rosenthal.
* platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::getTextureID):
(WebCore):
(WebCore::GraphicsSurface::copyFromFramebuffer):
* platform/graphics/surfaces/GraphicsSurface.h:
(GraphicsSurface):
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore):
(WebCore::GraphicsSurface::platformCopyFromFramebuffer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.cpp
trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h
trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (118986 => 118987)
--- trunk/Source/WebCore/ChangeLog 2012-05-30 22:39:23 UTC (rev 118986)
+++ trunk/Source/WebCore/ChangeLog 2012-05-30 22:43:48 UTC (rev 118987)
@@ -1,3 +1,26 @@
+2012-05-30 Zeno Albisser
+
+GraphicsSurface: allow importing and exporting of textures directly on GPU side.
+https://bugs.webkit.org/show_bug.cgi?id=87725
+
+Add copyFromFramebuffer function to copy a texture from an FBO
+onto the GraphicsSurface.
+Add getTextureID function to export the texture ID.
+This allows binding/blitting the texture directly on the GPU.
+
+Reviewed by Noam Rosenthal.
+
+* platform/graphics/surfaces/GraphicsSurface.cpp:
+(WebCore::GraphicsSurface::getTextureID):
+(WebCore):
+(WebCore::GraphicsSurface::copyFromFramebuffer):
+* platform/graphics/surfaces/GraphicsSurface.h:
+(GraphicsSurface):
+* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
+(WebCore::GraphicsSurface::platformGetTextureID):
+(WebCore):
+(WebCore::GraphicsSurface::platformCopyFromFramebuffer):
+
2012-05-30 Alec Flett
IndexedDB: Implement IDBTransaction.error and IDBRequest.error
Modified: trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.cpp (118986 => 118987)
--- trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.cpp 2012-05-30 22:39:23 UTC (rev 118986)
+++ trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.cpp 2012-05-30 22:43:48 UTC (rev 118987)
@@ -46,6 +46,11 @@
return platformExport();
}
+uint32_t GraphicsSurface::getTextureID()
+{
+return platformGetTextureID();
+}
+
PassOwnPtr GraphicsSurface::beginPaint(const IntRect& rect, LockOptions lockOptions)
{
int stride = 0;
@@ -59,6 +64,11 @@
platformCopyToGLTexture(target, texture, targetRect, offset);
}
+void GraphicsSurface::copyFromFramebuffer(uint32_t fbo, const IntRect& sourceRect)
+{
+platformCopyFromFramebuffer(fbo, sourceRect);
+}
+
GraphicsSurface::GraphicsSurface(const IntSize& size, Flags flags)
: m_size(size)
, m_flags(flags)
Modified: trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h (118986 => 118987)
--- trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h 2012-05-30 22:39:23 UTC (rev 118986)
+++ trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h 2012-05-30 22:43:48 UTC (rev 118987)
@@ -64,7 +64,9 @@
static PassRefPtr create(const IntSize&, Flags);
static PassRefPtr create(const IntSize&, Flags, uint32_t token);
void copyToGLTexture(uint32_t target, uint32_t texture, const IntRect& targetRect, const IntPoint& sourceOffset);
+void copyFromFramebuffer(uint32_t fbo, const IntRect& sourceRect);
uint32_t exportToken();
+uint32_t getTextureID();
PassOwnPtr beginPaint(const IntRect&, LockOptions);
PassRefPtr createReadOnlyImage(const IntRect&);
@@ -74,9 +76,11 @@
uint32_t platformExport();
void platformDestroy();
+uint32_t platformGetTextureID();
char* platformLock(const IntRect&, int* stride, LockOptions);
void platformUnlock();
void platformCopyToGLTexture(uint32_t target, uint32_t texture, const IntRect&, const IntPoint&);
+void platformCopyFromFramebuffer(uint32_t fbo, const IntRect& sourceRect);
PassOwnPtr platformBeginPaint(const IntSize&, char* bits, int stride);
Modified: trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp (118986 => 118987)
--- trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp 2012-05-30 22:39:23 UTC (rev 118986)
+++ trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp 2012-05-30 22:43:48 UTC (rev 118987)
@@ -64,6 +
[webkit-changes] [118985] trunk/Source/WebKit2
Title: [118985] trunk/Source/WebKit2
Revision 118985
Author commit-qu...@webkit.org
Date 2012-05-30 15:37:50 -0700 (Wed, 30 May 2012)
Log Message
[GTK][WK2] Errors in documentation about webkit_web_view_run_javascript()
https://bugs.webkit.org/show_bug.cgi?id=87866
Patch by Mario Sanchez Prada on 2012-05-30
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitWebView.cpp: Fix errors.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (118984 => 118985)
--- trunk/Source/WebKit2/ChangeLog 2012-05-30 22:29:04 UTC (rev 118984)
+++ trunk/Source/WebKit2/ChangeLog 2012-05-30 22:37:50 UTC (rev 118985)
@@ -1,3 +1,12 @@
+2012-05-30 Mario Sanchez Prada
+
+[GTK][WK2] Errors in documentation about webkit_web_view_run_javascript()
+https://bugs.webkit.org/show_bug.cgi?id=87866
+
+Reviewed by Martin Robinson.
+
+* UIProcess/API/gtk/WebKitWebView.cpp: Fix errors.
+
2012-05-30 Andy Estes
WebProcessMainMac.mm doesn't need to import WKView.h.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (118984 => 118985)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2012-05-30 22:29:04 UTC (rev 118984)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2012-05-30 22:37:50 UTC (rev 118985)
@@ -1939,13 +1939,13 @@
* context = webkit_javascript_result_get_global_context (js_result);
* value = webkit_javascript_result_get_value (js_result);
* if (JSValueIsString (context, value)) {
- * JSStringRef *js_str_value;
- * gchar *str_value;
- * gsizestr_length;
+ * JSStringRef js_str_value;
+ * gchar *str_value;
+ * gsize str_length;
*
- * js_str_value = JSValueToStringCopy (context, value, NULL));
+ * js_str_value = JSValueToStringCopy (context, value, NULL);
* str_length = JSStringGetMaximumUTF8CStringSize (js_str_value);
- * str_value = (gchar *)g_malloc (str_length));
+ * str_value = (gchar *)g_malloc (str_length);
* JSStringGetUTF8CString (js_str_value, str_value, str_length);
* JSStringRelease (js_str_value);
* g_print ("Script result: %s\n", str_value);
@@ -1963,7 +1963,7 @@
* gchar *script;
*
* script = g_strdup_printf ("window.document.getElementById('%s').href;", link_id);
- * webkit_web_view_run_javascript (web_view, script, web_view_javascript_finished, NULL);
+ * webkit_web_view_run_javascript (web_view, script, NULL, web_view_javascript_finished, NULL);
* g_free (script);
* }
*
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118984] trunk/LayoutTests
Title: [118984] trunk/LayoutTests
Revision 118984
Author e...@chromium.org
Date 2012-05-30 15:29:04 -0700 (Wed, 30 May 2012)
Log Message
Unreviewed chromium mac rebaseline for changes in r118978.
* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png:
* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.txt:
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-expected.png
Property Changed
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (118983 => 118984)
--- trunk/LayoutTests/ChangeLog 2012-05-30 22:29:02 UTC (rev 118983)
+++ trunk/LayoutTests/ChangeLog 2012-05-30 22:29:04 UTC (rev 118984)
@@ -1,5 +1,15 @@
2012-05-30 Emil A Eklund
+Unreviewed chromium mac rebaseline for changes in r118978.
+
+* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png:
+* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.txt:
+* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
+* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
+* platform/chromium/test_expectations.txt:
+
+2012-05-30 Emil A Eklund
+
Floats wraps incorrectly when top edge has subpixel precision
https://bugs.webkit.org/show_bug.cgi?id=87688
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (118983 => 118984)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-05-30 22:29:02 UTC (rev 118983)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-05-30 22:29:04 UTC (rev 118984)
@@ -3736,10 +3736,6 @@
BUG_EAE SKIP : fast/repaint/transform-layout-repaint.html = FAIL
BUGWK87282 WIN : fast/sub-pixel/layout-boxes-with-zoom.html = FAIL
-// Mark as failing on mac until I get a chance to rebaseline.
-BUG_EAE MAC : fast/backgrounds/background-position-parsing.html = PASS FAIL
-BUG_EAE MAC : fast/multicol/span/span-as-immediate-columns-child.html = PASS FAIL
-
BUGWK87160 WIN SNOWLEOPARD : platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-canvas2d-layer.html = PASS CRASH
BUGWK87160 XP VISTA : platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html = PASS CRASH
BUGWK87160 LINUX : platform/chromium/virtual/threaded/compositing/visibility/visibility-simple-webgl-layer.html = PASS CRASH
Modified: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.txt (118983 => 118984)
--- trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.txt 2012-05-30 22:29:02 UTC (rev 118983)
+++ trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.txt 2012-05-30 22:29:04 UTC (rev 118984)
@@ -1,7 +1,7 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x410
- RenderBlock {HTML} at (0,0) size 800x410
+layer at (0,0) size 800x405
+ RenderBlock {HTML} at (0,0) size 800x406
RenderBody {BODY} at (8,16) size 784x18
RenderBlock {P} at (0,0) size 784x18
RenderText {#text} at (0,0) size 500x18
@@ -33,126 +33,126 @@
RenderBlock (floating) {DIV} at (678,35) size 82x57 [border: (3px solid #00)]
RenderBlock {DIV} at (3,3) size 75x50 [bgcolor=#CC]
RenderBlock {DIV} at (8,8) size 59x34
- RenderBlock (floating) {DIV} at (1,96) size 82x56 [border: (3px solid #00)]
+ RenderBlock (floating) {DIV} at (1,95) size 82x57 [border: (3px solid #00)]
RenderBlock {DIV} at (3,3) size 75x50 [bgcolor=#CC]
RenderBlock {DIV} at (8,8) size 59x34
- RenderBlock (floating) {DIV} at (86,96) size 82x56 [border: (3px solid #00)]
+ RenderBlock (floating) {DIV} at (86,95) size 82x57 [border: (3px solid #00)]
RenderBlock {DIV} at (3,3) size 75x50 [bgcolor=#CC]
[webkit-changes] [118983] branches/safari-534.57-branch/Source
Title: [118983] branches/safari-534.57-branch/Source Revision 118983 Author lforsch...@apple.com Date 2012-05-30 15:29:02 -0700 (Wed, 30 May 2012) Log Message Versioning. Modified Paths branches/safari-534.57-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.57-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.57-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.57-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.57-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.57-branch/Source/_javascript_Core/Configurations/Version.xcconfig (118982 => 118983) --- branches/safari-534.57-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-05-30 22:21:30 UTC (rev 118982) +++ branches/safari-534.57-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-05-30 22:29:02 UTC (rev 118983) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 57; -TINY_VERSION = 5; +TINY_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.57-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (118982 => 118983) --- branches/safari-534.57-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-05-30 22:21:30 UTC (rev 118982) +++ branches/safari-534.57-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-05-30 22:29:02 UTC (rev 118983) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 57; -TINY_VERSION = 5; +TINY_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.57-branch/Source/WebCore/Configurations/Version.xcconfig (118982 => 118983) --- branches/safari-534.57-branch/Source/WebCore/Configurations/Version.xcconfig 2012-05-30 22:21:30 UTC (rev 118982) +++ branches/safari-534.57-branch/Source/WebCore/Configurations/Version.xcconfig 2012-05-30 22:29:02 UTC (rev 118983) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 57; -TINY_VERSION = 5; +TINY_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.57-branch/Source/WebKit/mac/Configurations/Version.xcconfig (118982 => 118983) --- branches/safari-534.57-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-05-30 22:21:30 UTC (rev 118982) +++ branches/safari-534.57-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-05-30 22:29:02 UTC (rev 118983) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 57; -TINY_VERSION = 5; +TINY_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.57-branch/Source/WebKit2/Configurations/Version.xcconfig (118982 => 118983) --- branches/safari-534.57-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-05-30 22:21:30 UTC (rev 118982) +++ branches/safari-534.57-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-05-30 22:29:02 UTC (rev 118983) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 57; -TINY_VERSION = 5; +TINY_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118982] tags/Safari-534.57.5/
Title: [118982] tags/Safari-534.57.5/ Revision 118982 Author lforsch...@apple.com Date 2012-05-30 15:21:30 -0700 (Wed, 30 May 2012) Log Message New tag. Added Paths tags/Safari-534.57.5/ Diff Property changes: tags/Safari-534.57.5 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118981] branches/safari-534.57-branch/Source/WebCore
Title: [118981] branches/safari-534.57-branch/Source/WebCore
Revision 118981
Author lforsch...@apple.com
Date 2012-05-30 15:18:51 -0700 (Wed, 30 May 2012)
Log Message
Merged r108550.
Modified Paths
branches/safari-534.57-branch/Source/WebCore/ChangeLog
branches/safari-534.57-branch/Source/WebCore/history/BackForwardController.cpp
Diff
Modified: branches/safari-534.57-branch/Source/WebCore/ChangeLog (118980 => 118981)
--- branches/safari-534.57-branch/Source/WebCore/ChangeLog 2012-05-30 22:08:56 UTC (rev 118980)
+++ branches/safari-534.57-branch/Source/WebCore/ChangeLog 2012-05-30 22:18:51 UTC (rev 118981)
@@ -1,3 +1,20 @@
+2012-05-30 Lucas Forschler
+
+Merge 108550
+
+2012-02-22 Anders Carlsson
+
+Crash when marking cached pages for full style recalc
+https://bugs.webkit.org/show_bug.cgi?id=79276
+
+
+Reviewed by Beth Dakin.
+
+Guard against a null history item.
+
+* history/BackForwardController.cpp:
+(WebCore::BackForwardController::markPagesForFullStyleRecalc):
+
2012-04-17 Lucas Forschler
Merge 109480
Modified: branches/safari-534.57-branch/Source/WebCore/history/BackForwardController.cpp (118980 => 118981)
--- branches/safari-534.57-branch/Source/WebCore/history/BackForwardController.cpp 2012-05-30 22:08:56 UTC (rev 118980)
+++ branches/safari-534.57-branch/Source/WebCore/history/BackForwardController.cpp 2012-05-30 22:18:51 UTC (rev 118981)
@@ -111,7 +111,13 @@
for (int i = first; i <= last; i++) {
if (!i)
continue;
-itemAtIndex(i)->markForFullStyleRecalc();
+
+// FIXME: itemAtIndex should never return null here, but due to the way the
+// back/forward list is implemented in WebKit2 it sometimes can, when the
+// session has been updated in the UI process but the session update message
+// hasn't yet reached the web process.
+if (HistoryItem* historyItem = itemAtIndex(i))
+historyItem->markForFullStyleRecalc();
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118980] trunk/Source/WebCore
Title: [118980] trunk/Source/WebCore
Revision 118980
Author commit-qu...@webkit.org
Date 2012-05-30 15:08:56 -0700 (Wed, 30 May 2012)
Log Message
[Qt] ImageDecoderQt doesn't support some decoders.
https://bugs.webkit.org/show_bug.cgi?id=87851
Patch by Allan Sandfeld Jensen on 2012-05-30
Reviewed by Kenneth Rohde Christiansen.
If forced to decode GIF and JPEG, ImageDecoderQt show several
artifacts. This is caused by mismatched decoded image-formats.
Convert mismatched color spaces into ARGB color space, and perform
manual mem-copy when the image has been decoded into a new buffer.
This patch also add support for down-scaling in the decoder.
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::internalDecodeSize):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/qt/ImageDecoderQt.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (118979 => 118980)
--- trunk/Source/WebCore/ChangeLog 2012-05-30 21:58:59 UTC (rev 118979)
+++ trunk/Source/WebCore/ChangeLog 2012-05-30 22:08:56 UTC (rev 118980)
@@ -1,3 +1,22 @@
+2012-05-30 Allan Sandfeld Jensen
+
+[Qt] ImageDecoderQt doesn't support some decoders.
+https://bugs.webkit.org/show_bug.cgi?id=87851
+
+Reviewed by Kenneth Rohde Christiansen.
+
+If forced to decode GIF and JPEG, ImageDecoderQt show several
+artifacts. This is caused by mismatched decoded image-formats.
+
+Convert mismatched color spaces into ARGB color space, and perform
+manual mem-copy when the image has been decoded into a new buffer.
+
+This patch also add support for down-scaling in the decoder.
+
+* platform/graphics/qt/ImageDecoderQt.cpp:
+(WebCore::ImageDecoderQt::internalDecodeSize):
+(WebCore::ImageDecoderQt::internalHandleCurrentImage):
+
2012-05-30 Emil A Eklund
Floats wraps incorrectly when top edge has subpixel precision
Modified: trunk/Source/WebCore/platform/graphics/qt/ImageDecoderQt.cpp (118979 => 118980)
--- trunk/Source/WebCore/platform/graphics/qt/ImageDecoderQt.cpp 2012-05-30 21:58:59 UTC (rev 118979)
+++ trunk/Source/WebCore/platform/graphics/qt/ImageDecoderQt.cpp 2012-05-30 22:08:56 UTC (rev 118980)
@@ -156,6 +156,12 @@
}
setSize(size.width(), size.height());
+
+// We don't need the tables set by prepareScaleDataIfNecessary,
+// but their dimensions are used by ImageDecoder::scaledSize().
+prepareScaleDataIfNecessary();
+if (m_scaled)
+m_reader->setScaledSize(scaledSize());
}
void ImageDecoderQt::internalReadImage(size_t frameIndex)
@@ -184,7 +190,9 @@
bool ImageDecoderQt::internalHandleCurrentImage(size_t frameIndex)
{
ImageFrame* const buffer = &m_frameBufferCache[frameIndex];
-QSize imageSize = m_reader->size();
+QSize imageSize = m_reader->scaledSize();
+if (imageSize.isEmpty())
+imageSize = m_reader->size();
if (!buffer->setSize(imageSize.width(), imageSize.height()))
return false;
@@ -194,6 +202,20 @@
buffer->setDuration(m_reader->nextImageDelay());
m_reader->read(&image);
+// ImageFrame expects ARGB32.
+if (buffer->premultiplyAlpha()) {
+if (image.format() != QImage::Format_ARGB32_Premultiplied)
+image = image.convertToFormat(QImage::Format_ARGB32_Premultiplied);
+} else {
+if (image.format() != QImage::Format_ARGB32)
+image = image.convertToFormat(QImage::Format_ARGB32);
+}
+
+if (reinterpret_cast(image.constBits()) != reinterpret_cast(buffer->getAddr(0, 0))) {
+// The in-buffer was replaced during decoding with another, so copy into it manually.
+memcpy(buffer->getAddr(0, 0), image.constBits(), image.byteCount());
+}
+
if (image.isNull()) {
frameCount();
repetitionCount();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118979] trunk/Tools
Title: [118979] trunk/Tools
Revision 118979
Author dpra...@chromium.org
Date 2012-05-30 14:58:59 -0700 (Wed, 30 May 2012)
Log Message
nrwt: seems to leak temp dirs
https://bugs.webkit.org/show_bug.cgi?id=87795
Reviewed by Ojan Vafai.
There appears to be a bug where the chromium bots are creating
temporary directories and not cleaning them up that started
after the switch to WebKitDriver. It's possible that __del__
wasn't getting called in a timely manner (or at all), and it's
generally bad style to rely on __del__ being called, so this
code changes things so that we create a temp dir in
driver.start() and remove it in driver.stop(). We could be
paranoid and leave the __del__ code in, but there doesn't seem
to be much advantage to it. If there are bugs that result in
drivers being started but not stopped, we have other problems.
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.__init__):
(MockFileSystem._mktemp):
(MockFileSystem.mkdtemp):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.__init__):
(WebKitDriver._start):
(WebKitDriver.stop):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest):
(WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
(WebKitDriverTest.test_stop_cleans_up_properly):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (118978 => 118979)
--- trunk/Tools/ChangeLog 2012-05-30 21:56:40 UTC (rev 118978)
+++ trunk/Tools/ChangeLog 2012-05-30 21:58:59 UTC (rev 118979)
@@ -1,3 +1,35 @@
+2012-05-30 Dirk Pranke
+
+nrwt: seems to leak temp dirs
+https://bugs.webkit.org/show_bug.cgi?id=87795
+
+Reviewed by Ojan Vafai.
+
+There appears to be a bug where the chromium bots are creating
+temporary directories and not cleaning them up that started
+after the switch to WebKitDriver. It's possible that __del__
+wasn't getting called in a timely manner (or at all), and it's
+generally bad style to rely on __del__ being called, so this
+code changes things so that we create a temp dir in
+driver.start() and remove it in driver.stop(). We could be
+paranoid and leave the __del__ code in, but there doesn't seem
+to be much advantage to it. If there are bugs that result in
+drivers being started but not stopped, we have other problems.
+
+* Scripts/webkitpy/common/system/filesystem_mock.py:
+(MockFileSystem.__init__):
+(MockFileSystem._mktemp):
+(MockFileSystem.mkdtemp):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitDriver.__init__):
+(WebKitDriver._start):
+(WebKitDriver.stop):
+* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+(WebKitDriverTest.test_check_for_driver_crash):
+(WebKitDriverTest):
+(WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
+(WebKitDriverTest.test_stop_cleans_up_properly):
+
2012-05-30 Christophe Dumez
[EFL] EFL's DRT should print the number of MessagePorts for new each new intent
Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py (118978 => 118979)
--- trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py 2012-05-30 21:56:40 UTC (rev 118978)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py 2012-05-30 21:58:59 UTC (rev 118979)
@@ -47,6 +47,7 @@
"""
self.files = files or {}
self.written_files = {}
+self.last_tmpdir = None
self._sep = '/'
self.current_tmpno = 0
self.cwd = cwd
@@ -233,7 +234,8 @@
dir = self.sep + '__im_tmp'
curno = self.current_tmpno
self.current_tmpno += 1
-return self.join(dir, "%s_%u_%s" % (prefix, curno, suffix))
+self.last_tmpdir = self.join(dir, '%s_%u_%s' % (prefix, curno, suffix))
+return self.last_tmpdir
def mkdtemp(self, **kwargs):
class TemporaryDirectory(object):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (118978 => 118979)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2012-05-30 21:56:40 UTC (rev 118978)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2012-05-30 21:58:59 UTC (rev 118979)
@@ -441,7 +441,7 @@
def __init__(self, port, worker_number, pixel_tests, no_timeout=False):
Driver.__init__(self, port, worker_number, pixel_tests, no_timeout)
-self._driver_tempdir = port._filesystem.mkdtemp(prefix='%s-' % self._port.driver_name())
+self._driver_tempdir = None
# WebKitTestRunner can report back subprocess crashes by printing
# "#CRASHED - PROCESSNAME". Since thos
[webkit-changes] [118977] trunk
Title: [118977] trunk Revision 118977 Author rak...@webkit.org Date 2012-05-30 14:44:47 -0700 (Wed, 30 May 2012) Log Message [EFL] EFL's DRT should print the number of MessagePorts for new each new intent https://bugs.webkit.org/show_bug.cgi?id=86841 Patch by Christophe Dumez on 2012-05-30 Reviewed by Adam Barth. Source/WebKit/efl: Add EWKPrivate method to retrieve the internal WebCore object for a Ewk_Intent. Add helper function to DumpRenderTreeSupportEfl that returns the MessagePorts for a Ewk_Intent object so that the DRT can print information about them. * WebCoreSupport/DumpRenderTreeSupportEfl.cpp: (DumpRenderTreeSupportEfl::intentMessagePorts): * WebCoreSupport/DumpRenderTreeSupportEfl.h: (WebCore): * ewk/ewk_intent.cpp: (EWKPrivate): (EWKPrivate::coreIntent): * ewk/ewk_intent_private.h: (EWKPrivate): Tools: Print the number of MessagePorts for each new intent in EFL's DRT. This output is expected by several Web Intents test cases. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::onFrameIntentNew): LayoutTests: Unskip the test case which requires the DumpRenderTree to print out the number of MessagePorts for each new intent. * platform/efl/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/test_expectations.txt trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h trunk/Source/WebKit/efl/ewk/ewk_intent.cpp trunk/Source/WebKit/efl/ewk/ewk_intent_private.h trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp Diff Modified: trunk/LayoutTests/ChangeLog (118976 => 118977) --- trunk/LayoutTests/ChangeLog 2012-05-30 21:42:35 UTC (rev 118976) +++ trunk/LayoutTests/ChangeLog 2012-05-30 21:44:47 UTC (rev 118977) @@ -1,3 +1,15 @@ +2012-05-30 Christophe Dumez + +[EFL] EFL's DRT should print the number of MessagePorts for new each new intent +https://bugs.webkit.org/show_bug.cgi?id=86841 + +Reviewed by Adam Barth. + +Unskip the test case which requires the DumpRenderTree to print out +the number of MessagePorts for each new intent. + +* platform/efl/test_expectations.txt: + 2012-05-30 Emil A Eklund Inline blocks with margin wrap incorrectly with subpixel layout turned on Modified: trunk/LayoutTests/platform/efl/test_expectations.txt (118976 => 118977) --- trunk/LayoutTests/platform/efl/test_expectations.txt 2012-05-30 21:42:35 UTC (rev 118976) +++ trunk/LayoutTests/platform/efl/test_expectations.txt 2012-05-30 21:44:47 UTC (rev 118977) @@ -653,8 +653,7 @@ // Incomplete Web Intents support BUGWK86866 SKIP : webintents/intent-tag.html = TEXT BUGWK86865 SKIP : webintents/web-intents-delivery.html = TEXT -BUGWK86841 SKIP : webintents/web-intents-invoke-port.html = TEXT -BUGWK86873 SKIP : webintents/web-intents-obj-constructor.html = TEXT +BUGWK87118 : webintents/web-intents-obj-constructor.html = TEXT // EFL's LayoutTestController does not implement setAutomaticLinkDetectionEnabled BUGWK85463 SKIP : editing/inserting/typing-space-to-trigger-smart-link.html = FAIL Modified: trunk/Source/WebKit/efl/ChangeLog (118976 => 118977) --- trunk/Source/WebKit/efl/ChangeLog 2012-05-30 21:42:35 UTC (rev 118976) +++ trunk/Source/WebKit/efl/ChangeLog 2012-05-30 21:44:47 UTC (rev 118977) @@ -1,5 +1,26 @@ 2012-05-30 Christophe Dumez +[EFL] EFL's DRT should print the number of MessagePorts for new each new intent +https://bugs.webkit.org/show_bug.cgi?id=86841 + +Reviewed by Adam Barth. + +Add EWKPrivate method to retrieve the internal WebCore object for a Ewk_Intent. +Add helper function to DumpRenderTreeSupportEfl that returns the MessagePorts +for a Ewk_Intent object so that the DRT can print information about them. + +* WebCoreSupport/DumpRenderTreeSupportEfl.cpp: +(DumpRenderTreeSupportEfl::intentMessagePorts): +* WebCoreSupport/DumpRenderTreeSupportEfl.h: +(WebCore): +* ewk/ewk_intent.cpp: +(EWKPrivate): +(EWKPrivate::coreIntent): +* ewk/ewk_intent_private.h: +(EWKPrivate): + +2012-05-30 Christophe Dumez + [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument https://bugs.webkit.org/show_bug.cgi?id=87829 Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (118976 => 118977) --- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-05-30 21:42:35 UTC (rev 118976) +++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp 2012-05-30 21:44:47 UTC (rev 118977) @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include <_javascript_Core/OpaqueJSString.h> @@ -679,6 +680,16 @@ #endif } +WebCore::MessagePortChannelArray* DumpRenderTreeSup
[webkit-changes] [118976] trunk/Source/WTF
Title: [118976] trunk/Source/WTF Revision 118976 Author caio.olive...@openbossa.org Date 2012-05-30 14:42:35 -0700 (Wed, 30 May 2012) Log Message HashTable.h has using directives for std::pair and std::make_pair https://bugs.webkit.org/show_bug.cgi?id=29919 Reviewed by Darin Adler. * wtf/HashTraits.h: (WTF): Remove the directives. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/HashTraits.h Diff Modified: trunk/Source/WTF/ChangeLog (118975 => 118976) --- trunk/Source/WTF/ChangeLog 2012-05-30 21:42:13 UTC (rev 118975) +++ trunk/Source/WTF/ChangeLog 2012-05-30 21:42:35 UTC (rev 118976) @@ -5,6 +5,16 @@ Reviewed by Darin Adler. +* wtf/HashTraits.h: +(WTF): Remove the directives. + +2012-05-30 Caio Marcelo de Oliveira Filho + +HashTable.h has using directives for std::pair and std::make_pair +https://bugs.webkit.org/show_bug.cgi?id=29919 + +Reviewed by Darin Adler. + Change code to use std::pair and std::make_pair. Later patch will remove the 'using' directives. Modified: trunk/Source/WTF/wtf/HashTraits.h (118975 => 118976) --- trunk/Source/WTF/wtf/HashTraits.h 2012-05-30 21:42:13 UTC (rev 118975) +++ trunk/Source/WTF/wtf/HashTraits.h 2012-05-30 21:42:35 UTC (rev 118976) @@ -34,9 +34,6 @@ template class OwnPtr; template class PassOwnPtr; -using std::pair; -using std::make_pair; - template struct HashTraits; template struct GenericHashTraitsBase; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118975] trunk
Title: [118975] trunk
Revision 118975
Author e...@chromium.org
Date 2012-05-30 14:42:13 -0700 (Wed, 30 May 2012)
Log Message
Inline blocks with margin wrap incorrectly with subpixel layout turned on
https://bugs.webkit.org/show_bug.cgi?id=87897
Reviewed by Levi Weintraub.
Source/WebCore:
Change WebCore::getBorderPaddingMargin and the helper function
getBPMWidth to return a LayoutUnit rather than an int as the padding and
margin values have subpixel precision. This fixes an issue where we would
incorrectly wrap inline blocks with a subpixel padding or margin.
Test: fast/sub-pixel/inline-block-with-margin.html
* rendering/RenderBlock.cpp:
(WebCore::getBPMWidth):
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
LayoutTests:
Add test for inline blocks with a subpixel margin. Marked as skipped on
all platforms but chromium as subpixel layout has not yet been enabled
for any other platform.
* fast/sub-pixel/inline-block-with-margin-expected.html: Added.
* fast/sub-pixel/inline-block-with-margin.html: Added.
* platform/efl/Skipped:
* platform/gtk-wk2/Skipped:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/LayoutTests/platform/gtk-wk2/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/mac-lion/Skipped
trunk/LayoutTests/platform/mac-snowleopard/Skipped
trunk/LayoutTests/platform/mac-wk2/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt-4.8/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/win-wk2/Skipped
trunk/LayoutTests/platform/win-xp/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/fast/sub-pixel/inline-block-with-margin-expected.html
trunk/LayoutTests/fast/sub-pixel/inline-block-with-margin.html
Diff
Modified: trunk/LayoutTests/ChangeLog (118974 => 118975)
--- trunk/LayoutTests/ChangeLog 2012-05-30 21:35:48 UTC (rev 118974)
+++ trunk/LayoutTests/ChangeLog 2012-05-30 21:42:13 UTC (rev 118975)
@@ -1,3 +1,30 @@
+2012-05-30 Emil A Eklund
+
+Inline blocks with margin wrap incorrectly with subpixel layout turned on
+https://bugs.webkit.org/show_bug.cgi?id=87897
+
+Reviewed by Levi Weintraub.
+
+Add test for inline blocks with a subpixel margin. Marked as skipped on
+all platforms but chromium as subpixel layout has not yet been enabled
+for any other platform.
+
+* fast/sub-pixel/inline-block-with-margin-expected.html: Added.
+* fast/sub-pixel/inline-block-with-margin.html: Added.
+* platform/efl/Skipped:
+* platform/gtk-wk2/Skipped:
+* platform/mac-lion/Skipped:
+* platform/mac-snowleopard/Skipped:
+* platform/mac-wk2/Skipped:
+* platform/mac/Skipped:
+* platform/qt-4.8/Skipped:
+* platform/qt/Skipped:
+* platform/win-wk2/Skipped:
+* platform/win-xp/Skipped:
+* platform/win/Skipped:
+* platform/wincairo/Skipped:
+* platform/wk2/Skipped:
+
2012-05-30 Jessie Berlin
[Qt][GTK][Mac][Win] New plugins/npruntime/delete-plugin-within-* tests introduced in r117012
Added: trunk/LayoutTests/fast/sub-pixel/inline-block-with-margin-expected.html (0 => 118975)
--- trunk/LayoutTests/fast/sub-pixel/inline-block-with-margin-expected.html (rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/inline-block-with-margin-expected.html 2012-05-30 21:42:13 UTC (rev 118975)
@@ -0,0 +1,14 @@
+
+
+
+
+div > span { margin-left: 0.4em; }
+
+
+
+Should not wrap
+
+Line above should not wrap.
+
+
+
Added: trunk/LayoutTests/fast/sub-pixel/inline-block-with-margin.html (0 => 118975)
--- trunk/LayoutTests/fast/sub-pixel/inline-block-with-margin.html (rev 0)
+++ trunk/LayoutTests/fast/sub-pixel/inline-block-with-margin.html 2012-05-30 21:42:13 UTC (rev 118975)
@@ -0,0 +1,15 @@
+
+
+
+
+div { display: inline-block; }
+div > span { margin-left: 0.4em; }
+
+
+
+Should not wrap
+
+Line above should not wrap.
+
+
+
Modified: trunk/LayoutTests/platform/efl/Skipped (118974 => 118975)
--- trunk/LayoutTests/platform/efl/Skipped 2012-05-30 21:35:48 UTC (rev 118974)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-05-30 21:42:13 UTC (rev 118975)
@@ -1228,6 +1228,7 @@
# https://bugs.webkit.org/show_bug.cgi?id=85532
fast/sub-pixel/clie
[webkit-changes] [118974] trunk/LayoutTests
Title: [118974] trunk/LayoutTests Revision 118974 Author jber...@webkit.org Date 2012-05-30 14:35:48 -0700 (Wed, 30 May 2012) Log Message [Qt][GTK][Mac][Win] New plugins/npruntime/delete-plugin-within-* tests introduced in r117012 fail/crash https://bugs.webkit.org/show_bug.cgi?id=86443 Skip these tests on Windows because they crash. * platform/win/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (118973 => 118974) --- trunk/LayoutTests/ChangeLog 2012-05-30 21:23:22 UTC (rev 118973) +++ trunk/LayoutTests/ChangeLog 2012-05-30 21:35:48 UTC (rev 118974) @@ -1,3 +1,13 @@ +2012-05-30 Jessie Berlin + +[Qt][GTK][Mac][Win] New plugins/npruntime/delete-plugin-within-* tests introduced in r117012 +fail/crash +https://bugs.webkit.org/show_bug.cgi?id=86443 + +Skip these tests on Windows because they crash. + +* platform/win/Skipped: + 2012-05-30 Raphael Kubo da Costa [EFL] Unreviewed gardening in fast/transforms. Modified: trunk/LayoutTests/platform/win/Skipped (118973 => 118974) --- trunk/LayoutTests/platform/win/Skipped 2012-05-30 21:23:22 UTC (rev 118973) +++ trunk/LayoutTests/platform/win/Skipped 2012-05-30 21:35:48 UTC (rev 118974) @@ -1790,3 +1790,9 @@ # _javascript_ Experiments are not enabled on Windows # https://bugs.webkit.org/show_bug.cgi?id=87858 fast/js/names.html + +# New plugins/npruntime/delete-plugin-within-* tests introduced in r117012 fail/crash +# https://bugs.webkit.org/show_bug.cgi?id=86443 +plugins/npruntime/delete-plugin-within-hasProperty-return-false.html +plugins/npruntime/delete-plugin-within-hasProperty-return-true.html +plugins/npruntime/delete-plugin-within-setProperty.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118973] trunk/LayoutTests
Title: [118973] trunk/LayoutTests Revision 118973 Author rak...@webkit.org Date 2012-05-30 14:23:22 -0700 (Wed, 30 May 2012) Log Message [EFL] Unreviewed gardening in fast/transforms. Unskip passing tests that just needed baselines and update the PNGs for a few ones which were already passing. * platform/efl/Skipped: * platform/efl/fast/transforms/bounding-rect-zoom-expected.png: * platform/efl/fast/transforms/diamond-expected.png: * platform/efl/fast/transforms/identity-matrix-expected.png: * platform/efl/fast/transforms/overflow-with-transform-expected.png: * platform/efl/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: * platform/efl/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: * platform/efl/fast/transforms/skew-with-unitless-zero-expected.png: * platform/efl/fast/transforms/transform-on-inline-expected.png: * platform/efl/fast/transforms/transform-positioned-ancestor-expected.png: * platform/efl/fast/transforms/transform-table-row-expected.png: * platform/efl/fast/transforms/transformed-caret-expected.png: * platform/efl/fast/transforms/transformed-caret-expected.txt: * platform/efl/fast/transforms/transformed-focused-text-input-expected.png: * platform/efl/fast/transforms/transformed-focused-text-input-expected.txt: * platform/efl/fast/transforms/transforms-with-opacity-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/efl/fast/transforms/bounding-rect-zoom-expected.png trunk/LayoutTests/platform/efl/fast/transforms/diamond-expected.png trunk/LayoutTests/platform/efl/fast/transforms/identity-matrix-expected.png trunk/LayoutTests/platform/efl/fast/transforms/overflow-with-transform-expected.png trunk/LayoutTests/platform/efl/fast/transforms/rotated-transform-affects-scrolling-1-expected.png trunk/LayoutTests/platform/efl/fast/transforms/rotated-transform-affects-scrolling-2-expected.png trunk/LayoutTests/platform/efl/fast/transforms/skew-with-unitless-zero-expected.png trunk/LayoutTests/platform/efl/fast/transforms/transform-on-inline-expected.png trunk/LayoutTests/platform/efl/fast/transforms/transform-positioned-ancestor-expected.png trunk/LayoutTests/platform/efl/fast/transforms/transform-table-row-expected.png trunk/LayoutTests/platform/efl/fast/transforms/transformed-caret-expected.png trunk/LayoutTests/platform/efl/fast/transforms/transformed-caret-expected.txt trunk/LayoutTests/platform/efl/fast/transforms/transformed-focused-text-input-expected.png trunk/LayoutTests/platform/efl/fast/transforms/transformed-focused-text-input-expected.txt trunk/LayoutTests/platform/efl/fast/transforms/transforms-with-opacity-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (118972 => 118973) --- trunk/LayoutTests/ChangeLog 2012-05-30 21:22:18 UTC (rev 118972) +++ trunk/LayoutTests/ChangeLog 2012-05-30 21:23:22 UTC (rev 118973) @@ -1,5 +1,29 @@ 2012-05-30 Raphael Kubo da Costa +[EFL] Unreviewed gardening in fast/transforms. + +Unskip passing tests that just needed baselines and update the +PNGs for a few ones which were already passing. + +* platform/efl/Skipped: +* platform/efl/fast/transforms/bounding-rect-zoom-expected.png: +* platform/efl/fast/transforms/diamond-expected.png: +* platform/efl/fast/transforms/identity-matrix-expected.png: +* platform/efl/fast/transforms/overflow-with-transform-expected.png: +* platform/efl/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: +* platform/efl/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: +* platform/efl/fast/transforms/skew-with-unitless-zero-expected.png: +* platform/efl/fast/transforms/transform-on-inline-expected.png: +* platform/efl/fast/transforms/transform-positioned-ancestor-expected.png: +* platform/efl/fast/transforms/transform-table-row-expected.png: +* platform/efl/fast/transforms/transformed-caret-expected.png: +* platform/efl/fast/transforms/transformed-caret-expected.txt: +* platform/efl/fast/transforms/transformed-focused-text-input-expected.png: +* platform/efl/fast/transforms/transformed-focused-text-input-expected.txt: +* platform/efl/fast/transforms/transforms-with-opacity-expected.png: + +2012-05-30 Raphael Kubo da Costa + [EFL] Unreviewed gardening in fast/parser. Unskip a passing test that just needed a baseline and update the Modified: trunk/LayoutTests/platform/efl/Skipped (118972 => 118973) --- trunk/LayoutTests/platform/efl/Skipped 2012-05-30 21:22:18 UTC (rev 118972) +++ trunk/LayoutTests/platform/efl/Skipped 2012-05-30 21:23:22 UTC (rev 118973) @@ -986,22 +986,6 @@ fast/text/trailing-white-space-2.html fast/text/trailing-white-space.html fast/text/whitespace/024.html -fast/transforms/bounding-rect-zoom.html -fast/transforms/diamond.html -fast/transforms/identity-matrix.html -
[webkit-changes] [118972] trunk/LayoutTests
Title: [118972] trunk/LayoutTests Revision 118972 Author rak...@webkit.org Date 2012-05-30 14:22:18 -0700 (Wed, 30 May 2012) Log Message [EFL] Unreviewed gardening in fast/parser. Unskip a passing test that just needed a baseline and update the PNGs for a few ones which were already passing. * platform/efl/Skipped: * platform/efl/fast/parser/001-expected.png: * platform/efl/fast/parser/bad-xml-slash-expected.png: * platform/efl/fast/parser/broken-comments-vs-parsing-mode-expected.png: * platform/efl/fast/parser/document-write-option-expected.png: * platform/efl/fast/parser/entity-comment-in-style-expected.png: * platform/efl/fast/parser/entity-comment-in-style-expected.txt: * platform/efl/fast/parser/entity-comment-in-textarea-expected.png: * platform/efl/fast/parser/fonts-expected.png: * platform/efl/fast/parser/nofoo-tags-inside-paragraph-expected.png: * platform/efl/fast/parser/open-comment-in-style-expected.png: * platform/efl/fast/parser/open-comment-in-textarea-expected.png: * platform/efl/fast/parser/title-error-test-expected.png: * platform/efl/fast/parser/xhtml-alternate-entities-expected.png: * platform/efl/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/efl/fast/parser/001-expected.png trunk/LayoutTests/platform/efl/fast/parser/bad-xml-slash-expected.png trunk/LayoutTests/platform/efl/fast/parser/broken-comments-vs-parsing-mode-expected.png trunk/LayoutTests/platform/efl/fast/parser/document-write-option-expected.png trunk/LayoutTests/platform/efl/fast/parser/entity-comment-in-style-expected.png trunk/LayoutTests/platform/efl/fast/parser/entity-comment-in-style-expected.txt trunk/LayoutTests/platform/efl/fast/parser/entity-comment-in-textarea-expected.png trunk/LayoutTests/platform/efl/fast/parser/fonts-expected.png trunk/LayoutTests/platform/efl/fast/parser/nofoo-tags-inside-paragraph-expected.png trunk/LayoutTests/platform/efl/fast/parser/open-comment-in-style-expected.png trunk/LayoutTests/platform/efl/fast/parser/open-comment-in-textarea-expected.png trunk/LayoutTests/platform/efl/fast/parser/title-error-test-expected.png trunk/LayoutTests/platform/efl/fast/parser/xhtml-alternate-entities-expected.png trunk/LayoutTests/platform/efl/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (118971 => 118972) --- trunk/LayoutTests/ChangeLog 2012-05-30 21:12:55 UTC (rev 118971) +++ trunk/LayoutTests/ChangeLog 2012-05-30 21:22:18 UTC (rev 118972) @@ -1,3 +1,26 @@ +2012-05-30 Raphael Kubo da Costa + +[EFL] Unreviewed gardening in fast/parser. + +Unskip a passing test that just needed a baseline and update the +PNGs for a few ones which were already passing. + +* platform/efl/Skipped: +* platform/efl/fast/parser/001-expected.png: +* platform/efl/fast/parser/bad-xml-slash-expected.png: +* platform/efl/fast/parser/broken-comments-vs-parsing-mode-expected.png: +* platform/efl/fast/parser/document-write-option-expected.png: +* platform/efl/fast/parser/entity-comment-in-style-expected.png: +* platform/efl/fast/parser/entity-comment-in-style-expected.txt: +* platform/efl/fast/parser/entity-comment-in-textarea-expected.png: +* platform/efl/fast/parser/fonts-expected.png: +* platform/efl/fast/parser/nofoo-tags-inside-paragraph-expected.png: +* platform/efl/fast/parser/open-comment-in-style-expected.png: +* platform/efl/fast/parser/open-comment-in-textarea-expected.png: +* platform/efl/fast/parser/title-error-test-expected.png: +* platform/efl/fast/parser/xhtml-alternate-entities-expected.png: +* platform/efl/test_expectations.txt: + 2012-05-30 Tony Chang rename flexbox css values from justify and distribute to space-between and space-around Modified: trunk/LayoutTests/platform/efl/Skipped (118971 => 118972) --- trunk/LayoutTests/platform/efl/Skipped 2012-05-30 21:12:55 UTC (rev 118971) +++ trunk/LayoutTests/platform/efl/Skipped 2012-05-30 21:22:18 UTC (rev 118972) @@ -920,8 +920,6 @@ fast/multicol fast/overflow/overflow-float-stacking.html fast/overflow/overflow-stacking.html -fast/parser/entity-comment-in-style.html -fast/parser/nested-fragment-parser-crash.html fast/preloader/first-base-tag-scanned-wins.html fast/preloader/first-base-tag-wins.html fast/preloader/understands-base-tag.html Modified: trunk/LayoutTests/platform/efl/fast/parser/001-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/efl/fast/parser/bad-xml-slash-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/efl/fast/parser/broken-comments-vs-parsing-mode-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/efl/fast/parser/document-write-option-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/efl/fast/parser/entity-comment-in-style-expected.png (Binary files differ
[webkit-changes] [118970] trunk/Source/WebCore
Title: [118970] trunk/Source/WebCore Revision 118970 Author kev...@webkit.org Date 2012-05-30 14:08:50 -0700 (Wed, 30 May 2012) Log Message [wx] Unreviewed build fix. Make sure we get the file size with the proper native type. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/wx/FileSystemWx.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (118969 => 118970) --- trunk/Source/WebCore/ChangeLog 2012-05-30 21:08:04 UTC (rev 118969) +++ trunk/Source/WebCore/ChangeLog 2012-05-30 21:08:50 UTC (rev 118970) @@ -1,3 +1,10 @@ +2012-05-30 Kevin Ollivier + +[wx] Unreviewed build fix. Make sure we get the file size with the proper native type. + +* platform/wx/FileSystemWx.cpp: +(WebCore::getFileMetadata): + 2012-05-30 Sheriff Bot Unreviewed, rolling out r118913. Modified: trunk/Source/WebCore/platform/wx/FileSystemWx.cpp (118969 => 118970) --- trunk/Source/WebCore/platform/wx/FileSystemWx.cpp 2012-05-30 21:08:04 UTC (rev 118969) +++ trunk/Source/WebCore/platform/wx/FileSystemWx.cpp 2012-05-30 21:08:50 UTC (rev 118970) @@ -91,7 +91,7 @@ if (!wxFileExists(path)) return false; wxFileName fileName(path); -metadata.length = fileName.GetSize(); +metadata.length = fileName.GetSize().GetValue(); metadata.modificationTime = fileName.GetModificationTime().GetTicks(); metadata.type = fileName.IsDir() ? FileMetadata::TypeDirectory : FileMetadata::TypeFile; return true; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118969] trunk/LayoutTests
Title: [118969] trunk/LayoutTests Revision 118969 Author rafa...@chromium.org Date 2012-05-30 14:08:04 -0700 (Wed, 30 May 2012) Log Message [Chromium] rebaseline fast/dom/Window/mozilla-focus-blur.html * platform/chromium/fast/dom/Window/mozilla-focus-blur-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium/fast/dom/Window/mozilla-focus-blur-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (118968 => 118969) --- trunk/LayoutTests/ChangeLog 2012-05-30 21:06:59 UTC (rev 118968) +++ trunk/LayoutTests/ChangeLog 2012-05-30 21:08:04 UTC (rev 118969) @@ -1,3 +1,10 @@ +2012-05-30 Rafael Weinstein + +[Chromium] rebaseline fast/dom/Window/mozilla-focus-blur.html + + +* platform/chromium/fast/dom/Window/mozilla-focus-blur-expected.txt: Added. + 2012-05-30 Jessie Berlin [Win] Many editing tests failing Added: trunk/LayoutTests/platform/chromium/fast/dom/Window/mozilla-focus-blur-expected.txt (0 => 118969) --- trunk/LayoutTests/platform/chromium/fast/dom/Window/mozilla-focus-blur-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/dom/Window/mozilla-focus-blur-expected.txt 2012-05-30 21:08:04 UTC (rev 118969) @@ -0,0 +1,11 @@ +Check that window.blur() does nothing, and window.focus() only works if it is invoked from the window that opened the former. If the test passes, you should see a series of PASS messages with the last being 'All tests finished'. + +This test is adopted from mozilla's tests. + +PASS: The focus should not have been changed! +PASS: The focus should not have been changed! +PASS: The focus should not have been changed with URL="" "*"); +PASS: The focus should not have been changed with URL="" "*"); +PASS: The last opened window should be able to get focus +PASS: All tests finished + Property changes on: trunk/LayoutTests/platform/chromium/fast/dom/Window/mozilla-focus-blur-expected.txt ___ Added: svn:eol-style ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118968] trunk/Tools
Title: [118968] trunk/Tools
Revision 118968
Author kev...@webkit.org
Date 2012-05-30 14:06:59 -0700 (Wed, 30 May 2012)
Log Message
[wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp
Diff
Modified: trunk/Tools/ChangeLog (118967 => 118968)
--- trunk/Tools/ChangeLog 2012-05-30 21:05:29 UTC (rev 118967)
+++ trunk/Tools/ChangeLog 2012-05-30 21:06:59 UTC (rev 118968)
@@ -1,3 +1,9 @@
+2012-05-30 Kevin Ollivier
+
+[wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
+
+* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
+
2012-05-30 Christophe Dumez
[EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
Modified: trunk/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp (118967 => 118968)
--- trunk/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp 2012-05-30 21:05:29 UTC (rev 118967)
+++ trunk/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp 2012-05-30 21:06:59 UTC (rev 118968)
@@ -155,10 +155,6 @@
// FIXME: implement
}
-void LayoutTestController::setJavaScriptProfilingEnabled(bool flag)
-{
-}
-
void LayoutTestController::setWaitToDump(bool waitUntilDone)
{
static const int timeoutSeconds = 10;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118967] trunk
Title: [118967] trunk
Revision 118967
Author kev...@webkit.org
Date 2012-05-30 14:05:29 -0700 (Wed, 30 May 2012)
Log Message
[wx] Unreviewed build fix. Add needed file back to the wx build.
Modified Paths
trunk/ChangeLog
trunk/wscript
Diff
Modified: trunk/ChangeLog (118966 => 118967)
--- trunk/ChangeLog 2012-05-30 21:04:23 UTC (rev 118966)
+++ trunk/ChangeLog 2012-05-30 21:05:29 UTC (rev 118967)
@@ -1,3 +1,9 @@
+2012-05-30 Kevin Ollivier
+
+[wx] Unreviewed build fix. Add needed file back to the wx build.
+
+* wscript:
+
2012-05-30 Mariusz Grzegorczyk , Ryuan Choi
[EFL][WK2] Fix WebKit2-EFL build
Modified: trunk/wscript (118966 => 118967)
--- trunk/wscript 2012-05-30 21:04:23 UTC (rev 118966)
+++ trunk/wscript 2012-05-30 21:05:29 UTC (rev 118967)
@@ -348,7 +348,6 @@
excludes.append('JSSVGStyleTable.cpp')
excludes.append('JSSVGTests.cpp')
excludes.append('JSSVGStylable.cpp')
-excludes.append('JSSVGZoomAndPan.cpp')
# These are files that expect methods not in the base C++ class, usually XYZAnimated methods.
excludes.append('JSSVGFitToViewBox.cpp')
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [118966] trunk/Source/JavaScriptCore
Title: [118966] trunk/Source/_javascript_Core
Revision 118966
Author fpi...@apple.com
Date 2012-05-30 14:04:23 -0700 (Wed, 30 May 2012)
Log Message
ScriptDebugServer wants sourceIDs that are non-zero because that's what HashMaps want, so JSC should placate it
https://bugs.webkit.org/show_bug.cgi?id=87887
Reviewed by Darin Adler.
Better fix - we now never call SourceProvider::asID() if SourceProvider* is 0.
* parser/Nodes.h:
(JSC::ScopeNode::sourceID):
* parser/SourceCode.h:
(JSC::SourceCode::providerID):
(SourceCode):
* parser/SourceProvider.h:
(SourceProvider):
(JSC::SourceProvider::asID):
* runtime/Executable.h:
(JSC::ScriptExecutable::sourceID):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Nodes.h
trunk/Source/_javascript_Core/parser/SourceCode.h
trunk/Source/_javascript_Core/parser/SourceProvider.h
trunk/Source/_javascript_Core/runtime/Executable.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (118965 => 118966)
--- trunk/Source/_javascript_Core/ChangeLog 2012-05-30 21:01:25 UTC (rev 118965)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-05-30 21:04:23 UTC (rev 118966)
@@ -3,6 +3,26 @@
ScriptDebugServer wants sourceIDs that are non-zero because that's what HashMaps want, so JSC should placate it
https://bugs.webkit.org/show_bug.cgi?id=87887
+Reviewed by Darin Adler.
+
+Better fix - we now never call SourceProvider::asID() if SourceProvider* is 0.
+
+* parser/Nodes.h:
+(JSC::ScopeNode::sourceID):
+* parser/SourceCode.h:
+(JSC::SourceCode::providerID):
+(SourceCode):
+* parser/SourceProvider.h:
+(SourceProvider):
+(JSC::SourceProvider::asID):
+* runtime/Executable.h:
+(JSC::ScriptExecutable::sourceID):
+
+2012-05-30 Filip Pizlo
+
+ScriptDebugServer wants sourceIDs that are non-zero because that's what HashMaps want, so JSC should placate it
+https://bugs.webkit.org/show_bug.cgi?id=87887
+
Reviewed by Geoffrey Garen.
* parser/SourceProvider.h:
Modified: trunk/Source/_javascript_Core/parser/Nodes.h (118965 => 118966)
--- trunk/Source/_javascript_Core/parser/Nodes.h 2012-05-30 21:01:25 UTC (rev 118965)
+++ trunk/Source/_javascript_Core/parser/Nodes.h 2012-05-30 21:04:23 UTC (rev 118966)
@@ -1399,7 +1399,7 @@
const SourceCode& source() const { return m_source; }
const UString& sourceURL() const { return m_source.provider()->url(); }
-intptr_t sourceID() const { return m_source.provider()->asID(); }
+intptr_t sourceID() const { return m_source.providerID(); }
void setFeatures(CodeFeatures features) { m_features = features; }
CodeFeatures features() { return m_features; }
Modified: trunk/Source/_javascript_Core/parser/SourceCode.h (118965 => 118966)
--- trunk/Source/_javascript_Core/parser/SourceCode.h 2012-05-30 21:01:25 UTC (rev 118965)
+++ trunk/Source/_javascript_Core/parser/SourceCode.h 2012-05-30 21:04:23 UTC (rev 118966)
@@ -67,6 +67,13 @@
return m_provider->getRange(m_startChar, m_endChar);
}
+intptr_t providerID() const
+{
+if (!m_provider)
+return SourceProvider::nullID;
+return m_provider->asID();
+}
+
bool isNull() const { return !m_provider; }
SourceProvider* provider() const { return m_provider.get(); }
int firstLine() const { return m_firstLine; }
Modified: trunk/Source/_javascript_Core/parser/SourceProvider.h (118965 => 118966)
--- trunk/Source/_javascript_Core/parser/SourceProvider.h 2012-05-30 21:01:25 UTC (rev 118965)
+++ trunk/Source/_javascript_Core/parser/SourceProvider.h 2012-05-30 21:04:23 UTC (rev 118966)
@@ -40,6 +40,8 @@
class SourceProvider : public RefCounted {
public:
+static const intptr_t nullID = 1;
+
SourceProvider(const UString& url, const TextPosition& startPosition, SourceProviderCache* cache = 0)
: m_url(url)
, m_startPosition(startPosition)
@@ -63,8 +65,9 @@
TextPosition startPosition() const { return m_startPosition; }
intptr_t asID()
{
-if (!this)
-return 1;
+ASSERT(this);
+if (!this) // Be defensive in release mode.
+return nullID;
return reinterpret_cast(this);
}
Modified: trunk/Source/_javascript_Core/runtime/Executable.h (118965 => 118966)
--- trunk/Source/_javascript_Core/runtime/Executable.h 2012-05-30 21:01:25 UTC (rev 118965)
+++ trunk/Source/_javascript_Core/runtime/Executable.h 2012-05-30 21:04:23 UTC (rev 118966)
@@ -285,7 +285,7 @@
#endif
const SourceCode& source() { return m_source; }
-intptr_t sourceID() const { return m_source.provider()->asID(); }
+intptr_t sourceID() const { return m_source.providerID(); }
[webkit-changes] [118965] branches/chromium/1132
Title: [118965] branches/chromium/1132 Revision 118965 Author dmazz...@google.com Date 2012-05-30 14:01:25 -0700 (Wed, 30 May 2012) Log Message Merge 117976 - Chromium AX: Crash when menulist adds selected option via document.write https://bugs.webkit.org/show_bug.cgi?id=87028 Reviewed by Chris Fleizach. Source/WebCore: Test: platform/chromium/accessibility/add-to-menu-list-crashes.html * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::addChild): LayoutTests: * platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt: Added. * platform/chromium/accessibility/add-to-menu-list-crashes.html: Added. TBR=dmazz...@google.com Review URL: https://chromiumcodereview.appspot.com/10446087 Modified Paths branches/chromium/1132/Source/WebCore/rendering/RenderMenuList.cpp Added Paths branches/chromium/1132/LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt branches/chromium/1132/LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes.html Diff Copied: branches/chromium/1132/LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt (from rev 117976, trunk/LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt) (0 => 118965) --- branches/chromium/1132/LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt (rev 0) +++ branches/chromium/1132/LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt 2012-05-30 21:01:25 UTC (rev 118965) @@ -0,0 +1,9 @@ +This test makes sure that adding a selected option to a menu list via an unusual route (document.write from an external script) doesn't trigger a crash when didUpdateActiveOption is called before the children are updated. + +PASS accessiblePopup.childrenCount is 1 +PASS accessiblePopup.childrenCount is 2 +PASS accessiblePopup.childrenCount is 1 +PASS successfullyParsed is true + +TEST COMPLETE + Copied: branches/chromium/1132/LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes.html (from rev 117976, trunk/LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes.html) (0 => 118965) --- branches/chromium/1132/LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes.html (rev 0) +++ branches/chromium/1132/LayoutTests/platform/chromium/accessibility/add-to-menu-list-crashes.html 2012-05-30 21:01:25 UTC (rev 118965) @@ -0,0 +1,41 @@ + + + + + +