[webkit-changes] [120042] trunk
Title: [120042] trunk
Revision 120042
Author kin...@chromium.org
Date 2012-06-11 23:17:27 -0700 (Mon, 11 Jun 2012)
Log Message
XHR returns size==0 Blob
https://bugs.webkit.org/show_bug.cgi?id=88750
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Response Blob's .size field must have the correct response size.
Test: http/tests/xmlhttprequest/response-blob-size.html
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseBlob):
LayoutTests:
* http/tests/xmlhttprequest/response-blob-size-expected.txt: Added.
* http/tests/xmlhttprequest/response-blob-size.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
Added Paths
trunk/LayoutTests/http/tests/xmlhttprequest/response-blob-size-expected.txt
trunk/LayoutTests/http/tests/xmlhttprequest/response-blob-size.html
Diff
Modified: trunk/LayoutTests/ChangeLog (120041 => 120042)
--- trunk/LayoutTests/ChangeLog 2012-06-12 06:03:08 UTC (rev 120041)
+++ trunk/LayoutTests/ChangeLog 2012-06-12 06:17:27 UTC (rev 120042)
@@ -1,3 +1,13 @@
+2012-06-11 Kinuko Yasuda kin...@chromium.org
+
+XHR returns size==0 Blob
+https://bugs.webkit.org/show_bug.cgi?id=88750
+
+Reviewed by Alexey Proskuryakov.
+
+* http/tests/xmlhttprequest/response-blob-size-expected.txt: Added.
+* http/tests/xmlhttprequest/response-blob-size.html: Added.
+
2012-06-11 Silvia Pfeiffer silvi...@chromium.org
Introduce an Enclosure Element for Chromium video controls.
Added: trunk/LayoutTests/http/tests/xmlhttprequest/response-blob-size-expected.txt (0 => 120042)
--- trunk/LayoutTests/http/tests/xmlhttprequest/response-blob-size-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/response-blob-size-expected.txt 2012-06-12 06:17:27 UTC (rev 120042)
@@ -0,0 +1,5 @@
+Test Blob.size of response blob received for XMLHttpRequest
+
+PASS: 200 == 200
+PASS: 103746 == 103746
+
Property changes on: trunk/LayoutTests/http/tests/xmlhttprequest/response-blob-size-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/xmlhttprequest/response-blob-size.html (0 => 120042)
--- trunk/LayoutTests/http/tests/xmlhttprequest/response-blob-size.html (rev 0)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/response-blob-size.html 2012-06-12 06:17:27 UTC (rev 120042)
@@ -0,0 +1,36 @@
+html
+body
+pTest Blob.size of response blob received for XMLHttpRequest/p
+pre id=console/pre
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function log(text)
+{
+var console = document.getElementById('console');
+console.appendChild(document.createTextNode(text + '\n'));
+}
+
+function test(expect, actual)
+{
+log((expect == actual ? 'PASS' : 'FAIL') + ': ' + expect + ' == ' + actual + '');
+}
+
+var req = new XMLHttpRequest;
+req.responseType = 'blob';
+req.open('GET', '../resources/test.ogv', true);
+req._onreadystatechange_ = function() {
+if (req.readyState == 4) {
+test(200, req.status);
+test(103746, req.response.size)
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+};
+req.send(null);
+
+/script
+/body
Property changes on: trunk/LayoutTests/http/tests/xmlhttprequest/response-blob-size.html
___
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (120041 => 120042)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 06:03:08 UTC (rev 120041)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 06:17:27 UTC (rev 120042)
@@ -1,3 +1,17 @@
+2012-06-11 Kinuko Yasuda kin...@chromium.org
+
+XHR returns size==0 Blob
+https://bugs.webkit.org/show_bug.cgi?id=88750
+
+Reviewed by Alexey Proskuryakov.
+
+Response Blob's .size field must have the correct response size.
+
+Test: http/tests/xmlhttprequest/response-blob-size.html
+
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::responseBlob):
+
2012-06-11 Silvia Pfeiffer silvi...@chromium.org
Introduce an Enclosure Element for Chromium video controls.
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (120041 => 120042)
--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2012-06-12 06:03:08 UTC (rev 120041)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2012-06-12 06:17:27 UTC (rev 120042)
@@ -273,7 +273,7 @@
if (m_state != DONE)
return 0;
-if (!m_responseBlob.get()) {
+if (!m_responseBlob) {
// FIXME: This causes two (or more) unnecessary copies of the data.
// Chromium stores blob data in the browser process, so we're pulling the data
// from the network only to copy it into the renderer to copy it back to the browser.
@@ -283,15 +283,16
[webkit-changes] [120034] trunk/LayoutTests
Title: [120034] trunk/LayoutTests Revision 120034 Author domin...@chromium.org Date 2012-06-11 20:21:24 -0700 (Mon, 11 Jun 2012) Log Message [Chromium] Unreviewed: Update test expectations with bugs for media test timeouts * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120033 => 120034) --- trunk/LayoutTests/ChangeLog 2012-06-12 03:04:38 UTC (rev 120033) +++ trunk/LayoutTests/ChangeLog 2012-06-12 03:21:24 UTC (rev 120034) @@ -1,3 +1,9 @@ +2012-06-11 Dominic Cooney domin...@chromium.org + +[Chromium] Unreviewed: Update test expectations with bugs for media test timeouts + +* platform/chromium/TestExpectations: + 2012-06-11 Jin Yang jin.a.y...@intel.com GeneratorGeneratedImage should cache images for the non-tiled case Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120033 => 120034) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 03:04:38 UTC (rev 120033) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 03:21:24 UTC (rev 120034) @@ -3691,12 +3691,9 @@ BUGCR131187 : canvas/philip/tests/2d.gradient.radial.cone.cylinder.html = TEXT BUGCR131187 : fast/canvas/canvas-currentColor.html = TEXT -// Apparently never passing on Vista. -BUG_DOMINICC VISTA : media/track/track-cue-rendering-inner-timestamps.html = TEXT +// The test has its own notion of timeouts that manifest timeouts as TEXT. +BUGWK88833 DEBUG : media/video-played-collapse.html = PASS TEXT -// Timing out in debug. The test has its own notion of timeouts. -BUG_DOMINICC WIN DEBUG : media/video-played-collapse.html = PASS TEXT - -BUG_DOMINICC WIN DEBUG : media/track/track-kind.html = PASS TIMEOUT -BUG_DOMINICC : http/tests/media/video-play-progress.html = PASS TIMEOUT -BUG_DOMINICC XP : http/tests/xmlhttprequest/origin-exact-matching.html = PASS TIMEOUT +BUGWK88833 WIN DEBUG : media/track/track-kind.html = PASS TIMEOUT +BUGWK88833 : http/tests/media/video-play-progress.html = PASS TIMEOUT +BUGWK88832 XP : http/tests/xmlhttprequest/origin-exact-matching.html = PASS TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120043] trunk/LayoutTests
Title: [120043] trunk/LayoutTests Revision 120043 Author domin...@chromium.org Date 2012-06-11 23:22:49 -0700 (Mon, 11 Jun 2012) Log Message [Chromium] Unreviewed: Rebaseline gradients tests r120033 added IMAGE failures for bunch of gradient tests that will need rebaselining as a result of that change. This is that rebaseline. (File list elided because it is too long.) Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-scaled-gradient-expected.png trunk/LayoutTests/platform/chromium-linux/fast/css/transformed-mask-expected.png trunk/LayoutTests/platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png trunk/LayoutTests/platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png trunk/LayoutTests/platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.png trunk/LayoutTests/platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png trunk/LayoutTests/platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.png trunk/LayoutTests/platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-scaled-gradient-expected.png trunk/LayoutTests/platform/chromium-mac/fast/css/transformed-mask-expected.png trunk/LayoutTests/platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png trunk/LayoutTests/platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png trunk/LayoutTests/platform/chromium-mac/fast/gradients/css3-linear-right-angle-gradients-expected.png trunk/LayoutTests/platform/chromium-mac/fast/gradients/css3-radial-gradients-expected.png trunk/LayoutTests/platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png trunk/LayoutTests/platform/chromium-mac/fast/gradients/css3-repeating-radial-gradients-expected.png trunk/LayoutTests/platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/css/transformed-mask-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/reflections/reflection-with-zoom-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/css/transformed-mask-expected.png trunk/LayoutTests/platform/chromium-win/fast/borders/border-image-scaled-gradient-expected.png trunk/LayoutTests/platform/chromium-win/fast/css/transformed-mask-expected.png trunk/LayoutTests/platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png trunk/LayoutTests/platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png trunk/LayoutTests/platform/chromium-win/fast/gradients/css3-linear-right-angle-gradients-expected.png trunk/LayoutTests/platform/chromium-win/fast/gradients/css3-radial-gradients-expected.png trunk/LayoutTests/platform/chromium-win/fast/gradients/gradient-after-transparent-border-expected.png trunk/LayoutTests/platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png Added Paths trunk/LayoutTests/platform/chromium-linux-x86/fast/gradients/ trunk/LayoutTests/platform/chromium-linux-x86/fast/gradients/css3-radial-gradients2-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png Removed Paths trunk/LayoutTests/platform/chromium-linux-x86/fast/borders/border-image-scaled-gradient-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/borders/border-image-scaled-gradient-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-gradient-expected.png trunk/LayoutTests/platform/chromium-win-vista/fast/borders/border-image-scaled-gradient-expected.png trunk/LayoutTests/platform/chromium-win-xp/fast/borders/border-image-scaled-gradient-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (120042 => 120043) --- trunk/LayoutTests/ChangeLog 2012-06-12 06:17:27 UTC (rev 120042) +++ trunk/LayoutTests/ChangeLog 2012-06-12 06:22:49 UTC (rev 120043) @@ -1,3 +1,13 @@ +2012-06-11 Dominic Cooney domin...@chromium.org + +[Chromium] Unreviewed: Rebaseline gradients tests + +r120033 added IMAGE failures for bunch of gradient tests that will +need rebaselining as a result of that change. This is that +rebaseline. + +(File list elided because it is too long.) + 2012-06-11 Kinuko Yasuda kin...@chromium.org XHR returns size==0 Blob Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120042 => 120043) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 06:17:27 UTC (rev 120042) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 06:22:49 UTC (rev 120043) @@ -3624,17 +3624,6 @@ BUGWK87075 : svg/animations/animate-path-animation-qQ-tT-inverse.html = PASS TIMEOUT BUGWK87075 :
[webkit-changes] [120036] trunk/Source/WebCore
Title: [120036] trunk/Source/WebCore
Revision 120036
Author mary...@torchmobile.com.cn
Date 2012-06-11 20:46:36 -0700 (Mon, 11 Jun 2012)
Log Message
[BlackBerry] Add handling of notifyDataReceived in NetworkJob even there's no data inside
https://bugs.webkit.org/show_bug.cgi?id=88773
Reviewed by Rob Buis.
Handling notifyDataReceived event even if there is no data inside.
This event was critical because it gives downloadFilterStream a chance
to follow up NetworkStream close event, and it also make pluginView in
FrameLoaderBlackBerry return normal logic.
RIM PR# 164563
Reviewed internally by Leo Yang.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyDataReceived):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120035 => 120036)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 03:44:38 UTC (rev 120035)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 03:46:36 UTC (rev 120036)
@@ -1,5 +1,24 @@
2012-06-11 Mary Wu mary...@torchmobile.com.cn
+[BlackBerry] Add handling of notifyDataReceived in NetworkJob even there's no data inside
+https://bugs.webkit.org/show_bug.cgi?id=88773
+
+Reviewed by Rob Buis.
+
+Handling notifyDataReceived event even if there is no data inside.
+This event was critical because it gives downloadFilterStream a chance
+to follow up NetworkStream close event, and it also make pluginView in
+FrameLoaderBlackBerry return normal logic.
+
+RIM PR# 164563
+
+Reviewed internally by Leo Yang.
+
+* platform/network/blackberry/NetworkJob.cpp:
+(WebCore::NetworkJob::handleNotifyDataReceived):
+
+2012-06-11 Mary Wu mary...@torchmobile.com.cn
+
[BlackBerry] Wrong mimetype for empty file link
https://bugs.webkit.org/show_bug.cgi?id=88642
Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (120035 => 120036)
--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-06-12 03:44:38 UTC (rev 120035)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp 2012-06-12 03:46:36 UTC (rev 120036)
@@ -385,9 +385,12 @@
if ((!m_isFile !m_statusReceived) || m_cancelled)
return;
-if (!buf || !len)
+if (!buf || !len) {
+sendResponseIfNeeded();
+if (isClientAvailable())
+m_handle-client()-didReceiveData(m_handle.get(), 0, 0, 0);
return;
-
+}
// The loadFile API sets the override content type,
// this will always be used as the content type and should not be overridden.
if (!m_dataReceived !m_isOverrideContentType) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120045] trunk
Title: [120045] trunk
Revision 120045
Author commit-qu...@webkit.org
Date 2012-06-12 00:08:14 -0700 (Tue, 12 Jun 2012)
Log Message
Property names of the built-in object cannot be retrieved
after trying to delete one of its properties
https://bugs.webkit.org/show_bug.cgi?id=86461
Patch by Hojong Han hojong@samsung.com on 2012-06-12
Reviewed by Gavin Barraclough.
Source/_javascript_Core:
* runtime/JSObject.cpp:
(JSC::getClassPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
LayoutTests:
* fast/js/delete-syntax-expected.txt:
* fast/js/script-tests/delete-syntax.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/js/delete-syntax-expected.txt
trunk/LayoutTests/fast/js/script-tests/delete-syntax.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (120044 => 120045)
--- trunk/LayoutTests/ChangeLog 2012-06-12 06:24:48 UTC (rev 120044)
+++ trunk/LayoutTests/ChangeLog 2012-06-12 07:08:14 UTC (rev 120045)
@@ -1,3 +1,14 @@
+2012-06-12 Hojong Han hojong@samsung.com
+
+Property names of the built-in object cannot be retrieved
+after trying to delete one of its properties
+https://bugs.webkit.org/show_bug.cgi?id=86461
+
+Reviewed by Gavin Barraclough.
+
+* fast/js/delete-syntax-expected.txt:
+* fast/js/script-tests/delete-syntax.js:
+
2012-06-11 Dominic Cooney domin...@chromium.org
[Chromium] Unreviewed: Rebaseline gradients tests
Modified: trunk/LayoutTests/fast/js/delete-syntax-expected.txt (120044 => 120045)
--- trunk/LayoutTests/fast/js/delete-syntax-expected.txt 2012-06-12 06:24:48 UTC (rev 120044)
+++ trunk/LayoutTests/fast/js/delete-syntax-expected.txt 2012-06-12 07:08:14 UTC (rev 120045)
@@ -30,6 +30,19 @@
PASS RegExp.prototype.exec is undefined
PASS RegExp.prototype.test is null
PASS Object.getOwnPropertyNames(Object.prototype).indexOf('__defineSetter__') is -1
+PASS navigatorPropertyNames.indexOf('appName') != -1 is true
+PASS navigatorPropertyNames.indexOf('appVersion') != -1 is true
+PASS navigatorPropertyNames.indexOf('language') != -1 is true
+PASS navigatorPropertyNames.indexOf('userAgent') != -1 is true
+PASS navigatorPropertyNames.indexOf('platform') != -1 is true
+PASS navigatorPropertyNames.indexOf('plugins') != -1 is true
+PASS navigatorPropertyNames.indexOf('mimeTypes') != -1 is true
+PASS navigatorPropertyNames.indexOf('product') != -1 is true
+PASS navigatorPropertyNames.indexOf('productSub') != -1 is true
+PASS navigatorPropertyNames.indexOf('vendor') != -1 is true
+PASS navigatorPropertyNames.indexOf('vendorSub') != -1 is true
+PASS navigatorPropertyNames.indexOf('cookieEnabled') != -1 is true
+PASS navigatorPropertyNames.indexOf('onLine') != -1 is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/js/script-tests/delete-syntax.js (120044 => 120045)
--- trunk/LayoutTests/fast/js/script-tests/delete-syntax.js 2012-06-12 06:24:48 UTC (rev 120044)
+++ trunk/LayoutTests/fast/js/script-tests/delete-syntax.js 2012-06-12 07:08:14 UTC (rev 120045)
@@ -72,3 +72,23 @@
delete Object.prototype.__defineSetter__;
shouldBe(Object.getOwnPropertyNames(Object.prototype).indexOf('__defineSetter__'), -1);
+delete navigator.appCodeName;
+var navigatorPropertyNames = Object.getOwnPropertyNames(navigator);
+var expectedPropertyNames = [
+appName,
+appVersion,
+language,
+userAgent,
+platform,
+plugins,
+mimeTypes,
+product,
+productSub,
+vendor,
+vendorSub,
+cookieEnabled,
+onLine
+];
+
+for (var i = 0; i expectedPropertyNames.length; ++i)
+shouldBeTrue(navigatorPropertyNames.indexOf(' + expectedPropertyNames[i] +') != -1);
Modified: trunk/Source/_javascript_Core/ChangeLog (120044 => 120045)
--- trunk/Source/_javascript_Core/ChangeLog 2012-06-12 06:24:48 UTC (rev 120044)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-06-12 07:08:14 UTC (rev 120045)
@@ -1,3 +1,15 @@
+2012-06-12 Hojong Han hojong@samsung.com
+
+Property names of the built-in object cannot be retrieved
+after trying to delete one of its properties
+https://bugs.webkit.org/show_bug.cgi?id=86461
+
+Reviewed by Gavin Barraclough.
+
+* runtime/JSObject.cpp:
+(JSC::getClassPropertyNames):
+(JSC::JSObject::getOwnPropertyNames):
+
2012-06-11 Gyuyoung Kim gyuyoung@samsung.com
[CMAKE][EFL] Remove duplicated executable output path
Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (120044 => 120045)
--- trunk/Source/_javascript_Core/runtime/JSObject.cpp 2012-06-12 06:24:48 UTC (rev 120044)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp 2012-06-12 07:08:14 UTC (rev 120045)
@@ -56,7 +56,7 @@
const ClassInfo JSFinalObject::s_info = { Object, Base::s_info, 0, 0, CREATE_METHOD_TABLE(JSFinalObject) };
-static inline void getClassPropertyNames(ExecState*
[webkit-changes] [120047] trunk/LayoutTests
Title: [120047] trunk/LayoutTests Revision 120047 Author ann...@chromium.org Date 2012-06-12 01:21:27 -0700 (Tue, 12 Jun 2012) Log Message [Chromium] video-media-source-add-and-remove-ids.html needs to be skipped until a chromium patch lands that will cause different expectations. Unreviewed. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120046 => 120047) --- trunk/LayoutTests/ChangeLog 2012-06-12 07:46:19 UTC (rev 120046) +++ trunk/LayoutTests/ChangeLog 2012-06-12 08:21:27 UTC (rev 120047) @@ -1,3 +1,12 @@ +2012-06-12 Anna Cavender ann...@chromium.org + +[Chromium] video-media-source-add-and-remove-ids.html needs to be skipped +until a chromium patch lands that will cause different expectations. + +Unreviewed. + +* platform/chromium/TestExpectations: + 2012-06-12 Dominic Cooney domin...@chromium.org [Chromium] Unreviewed: Rebaseline gradients tests Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120046 => 120047) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 07:46:19 UTC (rev 120046) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 08:21:27 UTC (rev 120047) @@ -3563,6 +3563,8 @@ BUGWK85952 : http/tests/media/media-source/video-media-source-seek.html = PASS TIMEOUT BUGWK85952 : http/tests/media/media-source/video-media-source-state-changes.html = PASS TIMEOUT TEXT +BUGWK88798 : http/tests/media/media-source/video-media-source-add-and-remove-ids.html = TEXT + // Started flaking at around http://trac.webkit.org/changeset/116278. BUGWK85950 LINUX DEBUG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = PASS TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120048] trunk/LayoutTests
Title: [120048] trunk/LayoutTests Revision 120048 Author ma...@webkit.org Date 2012-06-12 01:58:28 -0700 (Tue, 12 Jun 2012) Log Message Unreviewed gardening. Skip test crashing on GTK debug bots. * platform/gtk/TestExpectations: Skip test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120047 => 120048) --- trunk/LayoutTests/ChangeLog 2012-06-12 08:21:27 UTC (rev 120047) +++ trunk/LayoutTests/ChangeLog 2012-06-12 08:58:28 UTC (rev 120048) @@ -1,3 +1,9 @@ +2012-06-12 Mario Sanchez Prada msanc...@igalia.com + +Unreviewed gardening. Skip test crashing on GTK debug bots. + +* platform/gtk/TestExpectations: Skip test. + 2012-06-12 Anna Cavender ann...@chromium.org [Chromium] video-media-source-add-and-remove-ids.html needs to be skipped Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120047 => 120048) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 08:21:27 UTC (rev 120047) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 08:58:28 UTC (rev 120048) @@ -341,6 +341,8 @@ // Crashes due to debug assert until we fix issues with style elements in SVG BUGWKGTK DEBUG : svg/custom/use-referencing-style-crash.svg = CRASH +BUGWK63611 DEBUG : editing/pasteboard/interchange-newline-3.html = CRASH + BUGWK85811 DEBUG : fast/events/message-port-close.html = CRASH BUGWK86443 : plugins/npruntime/delete-plugin-within-getProperty.html = CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120049] trunk
Title: [120049] trunk Revision 120049 Author tk...@chromium.org Date 2012-06-12 02:10:04 -0700 (Tue, 12 Jun 2012) Log Message Remove unnecessary functions: setName() and formControlName() https://bugs.webkit.org/show_bug.cgi?id=88392 Reviewed by Kentaro Hara. Source/WebCore: 'name' IDL attributes of form-related elements should be [Reflected], and we don't need to have setName(). We used formControlName() for name() implementation, and formControlName() is not needed because it just converts a null attribute to an empty string. Our binding code does it. We don't remove FormAssociatedElement::name() because many C++ code use it. FormAssociatedElement::name() is virtual, and HTMLInputElement overrides it so that it returns a cache of the name attribtue value because CheckedRadioButtons class needs to know an old name attribute value when the name attribtue is changed. References: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-object-name http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-form-name http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#dom-fe-name Test: fast/forms/name-attribute.html * dom/Element.h: Remove formControlName(). * html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::name): Copied from formControlName() implementation of HTMLFormControlElement. * html/FormAssociatedElement.h: (FormAssociatedElement): Make name() virtual, remove formControlName(). * html/FormController.cpp: (WebCore::FormController::formElementsState): Use name() instead of formControlName(). * html/HTMLFormControlElement.cpp: Remove formControlName() and setName(). * html/HTMLFormControlElement.h: ditto. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::name): Renamed from formControlName(). * html/HTMLInputElement.h: (HTMLInputElement): Renamed formControlName() to name(), and make it public. * html/HTMLKeygenElement.idl: Make 'name' [Reflected]. * html/HTMLObjectElement.cpp: Remove formControlName(). * html/HTMLObjectElement.h: ditto. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::appendFormData): Use name() instead of formControlName(). * html/HTMLSelectElement.idl: Make 'name' [Reflected]. * html/HTMLTextAreaElement.idl: Make 'name' [Reflected]. LayoutTests: * fast/forms/name-attribute-expected.txt: Added. * fast/forms/name-attribute.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/html/FormAssociatedElement.cpp trunk/Source/WebCore/html/FormAssociatedElement.h trunk/Source/WebCore/html/FormController.cpp trunk/Source/WebCore/html/HTMLFormControlElement.cpp trunk/Source/WebCore/html/HTMLFormControlElement.h trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLInputElement.h trunk/Source/WebCore/html/HTMLKeygenElement.idl trunk/Source/WebCore/html/HTMLObjectElement.cpp trunk/Source/WebCore/html/HTMLObjectElement.h trunk/Source/WebCore/html/HTMLSelectElement.cpp trunk/Source/WebCore/html/HTMLSelectElement.idl trunk/Source/WebCore/html/HTMLTextAreaElement.idl Added Paths trunk/LayoutTests/fast/forms/name-attribute-expected.txt trunk/LayoutTests/fast/forms/name-attribute.html Diff Modified: trunk/LayoutTests/ChangeLog (120048 => 120049) --- trunk/LayoutTests/ChangeLog 2012-06-12 08:58:28 UTC (rev 120048) +++ trunk/LayoutTests/ChangeLog 2012-06-12 09:10:04 UTC (rev 120049) @@ -1,3 +1,13 @@ +2012-06-12 Kent Tamura tk...@chromium.org + +Remove unnecessary functions: setName() and formControlName() +https://bugs.webkit.org/show_bug.cgi?id=88392 + +Reviewed by Kentaro Hara. + +* fast/forms/name-attribute-expected.txt: Added. +* fast/forms/name-attribute.html: Added. + 2012-06-12 Mario Sanchez Prada msanc...@igalia.com Unreviewed gardening. Skip test crashing on GTK debug bots. Added: trunk/LayoutTests/fast/forms/name-attribute-expected.txt (0 => 120049) --- trunk/LayoutTests/fast/forms/name-attribute-expected.txt (rev 0) +++ trunk/LayoutTests/fast/forms/name-attribute-expected.txt 2012-06-12 09:10:04 UTC (rev 120049) @@ -0,0 +1,279 @@ +Check behavior of name attribute for various form elements + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +Test cases for button +Initial value: +PASS element.name is +PASS element.getAttribute(name) is null +Setting a value via the IDL attribute: +PASS element.name = foo; element.name is foo +PASS element.getAttribute(name) is foo +Setting a value via the content attribute: +PASS element.setAttribute(name, bar\n); element.name is bar\n +PASS element.getAttribute(name) is bar\n +Setting null via the IDL attribute: +PASS element.name = null; element.name is +PASS element.getAttribute(name) is null +Setting null via the content attribute: +PASS element.setAttribute(name, null);
[webkit-changes] [120050] trunk/LayoutTests
Title: [120050] trunk/LayoutTests Revision 120050 Author domin...@chromium.org Date 2012-06-12 02:21:06 -0700 (Tue, 12 Jun 2012) Log Message [Chromium] Unreviewed: Rebaseline gradient-after-transparent-border Font antialiasing differences are causing this to fail after rebaseline in r120043. * platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (120049 => 120050) --- trunk/LayoutTests/ChangeLog 2012-06-12 09:10:04 UTC (rev 120049) +++ trunk/LayoutTests/ChangeLog 2012-06-12 09:21:06 UTC (rev 120050) @@ -1,3 +1,12 @@ +2012-06-12 Dominic Cooney domin...@chromium.org + +[Chromium] Unreviewed: Rebaseline gradient-after-transparent-border + +Font antialiasing differences are causing this to fail after +rebaseline in r120043. + +* platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png: + 2012-06-12 Kent Tamura tk...@chromium.org Remove unnecessary functions: setName() and formControlName() Modified: trunk/LayoutTests/platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120052] trunk/LayoutTests
Title: [120052] trunk/LayoutTests Revision 120052 Author ma...@webkit.org Date 2012-06-12 03:13:08 -0700 (Tue, 12 Jun 2012) Log Message Unreviewed gardening. Skip test failing on GTK bots after r119947. * platform/gtk/TestExpectations: Skip test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120051 => 120052) --- trunk/LayoutTests/ChangeLog 2012-06-12 09:49:54 UTC (rev 120051) +++ trunk/LayoutTests/ChangeLog 2012-06-12 10:13:08 UTC (rev 120052) @@ -1,3 +1,9 @@ +2012-06-12 Mario Sanchez Prada msanc...@igalia.com + +Unreviewed gardening. Skip test failing on GTK bots after r119947. + +* platform/gtk/TestExpectations: Skip test. + 2012-06-12 Hajime Morrita morr...@chromium.org REGRESSION(r118098): content element does not render distributed children when cloned from another document Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120051 => 120052) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 09:49:54 UTC (rev 120051) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 10:13:08 UTC (rev 120052) @@ -1264,6 +1264,9 @@ // New test introduced in r119911 failing on GTK and EFL ports BUGWK88727 : http/tests/xmlhttprequest/origin-exact-matching.html = TEXT +// New test introduced in r119947 failing on GTK port +BUGWK88760 : http/tests/cookies/js-get-and-set-http-only-cookie.html = TEXT + // Started failing after it was added in r116473 BUGWK85969 : http/tests/loading/post-in-iframe-with-back-navigation.html = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120053] trunk
Title: [120053] trunk Revision 120053 Author h...@chromium.org Date 2012-06-12 03:38:39 -0700 (Tue, 12 Jun 2012) Log Message Speech _javascript_ API: Make SpeechRecognitionError an Event https://bugs.webkit.org/show_bug.cgi?id=88784 Reviewed by Adam Barth. Source/WebCore: Make SpeechRecognitionError an Event. The spec was updated to make it an event in its own right, rather than an attribute of SpeechRecognitionEvent. Test: fast/speech/scripted/speechrecognition-errors.html * Modules/speech/SpeechRecognition.cpp: (WebCore::SpeechRecognition::didReceiveError): * Modules/speech/SpeechRecognitionError.cpp: (WebCore::SpeechRecognitionError::SpeechRecognitionError): (WebCore::SpeechRecognitionError::interfaceName): (WebCore): * Modules/speech/SpeechRecognitionError.h: (WebCore::SpeechRecognitionError::create): (SpeechRecognitionError): * Modules/speech/SpeechRecognitionError.idl: * Modules/speech/SpeechRecognitionEvent.cpp: (WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent): * Modules/speech/SpeechRecognitionEvent.h: (SpeechRecognitionEventInit): (SpeechRecognitionEvent): * Modules/speech/SpeechRecognitionEvent.idl: * dom/EventNames.in: Tools: Make it possible to have MockWebSpeechRecognizer fire error events. * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setMockSpeechRecognitionError): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController): * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: (WebKit): (ErrorTask): (WebKit::ErrorTask::ErrorTask): (MockWebSpeechRecognizer::addMockResult): (MockWebSpeechRecognizer::setError): * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: (MockWebSpeechRecognizer): LayoutTests: Add a layout test that fires a SpeechRecognitionError. * fast/speech/scripted/speechrecognition-errors-expected.txt: Added. * fast/speech/scripted/speechrecognition-errors.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/speech/SpeechRecognition.cpp trunk/Source/WebCore/Modules/speech/SpeechRecognitionError.cpp trunk/Source/WebCore/Modules/speech/SpeechRecognitionError.h trunk/Source/WebCore/Modules/speech/SpeechRecognitionError.idl trunk/Source/WebCore/Modules/speech/SpeechRecognitionEvent.cpp trunk/Source/WebCore/Modules/speech/SpeechRecognitionEvent.h trunk/Source/WebCore/Modules/speech/SpeechRecognitionEvent.idl trunk/Source/WebCore/dom/EventNames.in trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h trunk/Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp trunk/Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h Added Paths trunk/LayoutTests/fast/speech/scripted/speechrecognition-errors-expected.txt trunk/LayoutTests/fast/speech/scripted/speechrecognition-errors.html Diff Modified: trunk/LayoutTests/ChangeLog (120052 => 120053) --- trunk/LayoutTests/ChangeLog 2012-06-12 10:13:08 UTC (rev 120052) +++ trunk/LayoutTests/ChangeLog 2012-06-12 10:38:39 UTC (rev 120053) @@ -1,3 +1,15 @@ +2012-06-11 Hans Wennborg h...@chromium.org + +Speech _javascript_ API: Make SpeechRecognitionError an Event +https://bugs.webkit.org/show_bug.cgi?id=88784 + +Reviewed by Adam Barth. + +Add a layout test that fires a SpeechRecognitionError. + +* fast/speech/scripted/speechrecognition-errors-expected.txt: Added. +* fast/speech/scripted/speechrecognition-errors.html: Added. + 2012-06-12 Mario Sanchez Prada msanc...@igalia.com Unreviewed gardening. Skip test failing on GTK bots after r119947. Added: trunk/LayoutTests/fast/speech/scripted/speechrecognition-errors-expected.txt (0 => 120053) --- trunk/LayoutTests/fast/speech/scripted/speechrecognition-errors-expected.txt (rev 0) +++ trunk/LayoutTests/fast/speech/scripted/speechrecognition-errors-expected.txt 2012-06-12 10:38:39 UTC (rev 120053) @@ -0,0 +1,20 @@ +Test Speech _javascript_ API errors + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS 'webkitSpeechRecognition' in self is true +PASS webkitSpeechRecognition == null is false + +notAllowedTest(): +onerror +PASS count is 0 +PASS event.code is webkitSpeechRecognitionError.NOT_ALLOWED +PASS event.message is not allowed +PASS event.type is error +onend +PASS count is 1 +PASS successfullyParsed is true + +TEST COMPLETE + Property changes on: trunk/LayoutTests/fast/speech/scripted/speechrecognition-errors-expected.txt ___ Added: svn:eol-style Added: trunk/LayoutTests/fast/speech/scripted/speechrecognition-errors.html (0 => 120053) --- trunk/LayoutTests/fast/speech/scripted/speechrecognition-errors.html (rev 0) +++ trunk/LayoutTests/fast/speech/scripted/speechrecognition-errors.html 2012-06-12 10:38:39
[webkit-changes] [120055] trunk/LayoutTests
Title: [120055] trunk/LayoutTests Revision 120055 Author kin...@chromium.org Date 2012-06-12 04:05:01 -0700 (Tue, 12 Jun 2012) Log Message Unreviewed; skipping the new XHR blob test on the platforms where XHR_RESPONSE_BLOB is not enabled. http/tests/xmlhttprequest/response-blob-size.html * platform/efl/Skipped: * platform/gtk/TestExpectations: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: * platform/wincairo/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/win/Skipped trunk/LayoutTests/platform/wincairo/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (120054 => 120055) --- trunk/LayoutTests/ChangeLog 2012-06-12 10:47:39 UTC (rev 120054) +++ trunk/LayoutTests/ChangeLog 2012-06-12 11:05:01 UTC (rev 120055) @@ -1,3 +1,15 @@ +2012-06-12 Kinuko Yasuda kin...@chromium.org + +Unreviewed; skipping the new XHR blob test on the platforms where XHR_RESPONSE_BLOB is not enabled. +http/tests/xmlhttprequest/response-blob-size.html + +* platform/efl/Skipped: +* platform/gtk/TestExpectations: +* platform/mac/Skipped: +* platform/qt/Skipped: +* platform/win/Skipped: +* platform/wincairo/Skipped: + 2012-06-11 Kaustubh Atrawalkar kaust...@motorola.com [DRT] LTC:: counterValueForElementById() could be moved to Internals. Modified: trunk/LayoutTests/platform/efl/Skipped (120054 => 120055) --- trunk/LayoutTests/platform/efl/Skipped 2012-06-12 10:47:39 UTC (rev 120054) +++ trunk/LayoutTests/platform/efl/Skipped 2012-06-12 11:05:01 UTC (rev 120055) @@ -1200,3 +1200,6 @@ # http://webkit.org/b/35981 # Needs a text rebaseline: 30px height difference. fast/block/basic/fieldset-stretch-to-legend.html + +# Fail until ENABLE_XHR_RESPONSE_BLOB is enabled. +http/tests/xmlhttprequest/response-blob-size.html Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120054 => 120055) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 10:47:39 UTC (rev 120054) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 11:05:01 UTC (rev 120055) @@ -326,6 +326,9 @@ // UndoManager is not yet enabled. BUGWK87908 SKIP : editing/undomanager = PASS +// ENABLE_XHR_RESPONSE_BLOB is not yet enabled. +BUGWKGTK SKIP : http/tests/xmlhttprequest/response-blob-size.html = TEXT + // // End of Expected failures // Modified: trunk/LayoutTests/platform/mac/Skipped (120054 => 120055) --- trunk/LayoutTests/platform/mac/Skipped 2012-06-12 10:47:39 UTC (rev 120054) +++ trunk/LayoutTests/platform/mac/Skipped 2012-06-12 11:05:01 UTC (rev 120055) @@ -889,3 +889,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=88736 http/tests/security/mixedContent/blob-url-in-iframe.html + +# Fail until ENABLE_XHR_RESPONSE_BLOB is enabled. +http/tests/xmlhttprequest/response-blob-size.html Modified: trunk/LayoutTests/platform/qt/Skipped (120054 => 120055) --- trunk/LayoutTests/platform/qt/Skipped 2012-06-12 10:47:39 UTC (rev 120054) +++ trunk/LayoutTests/platform/qt/Skipped 2012-06-12 11:05:01 UTC (rev 120055) @@ -2513,3 +2513,6 @@ # http://webkit.org/b/35981 # Needs a text rebaseline: 30px height difference. fast/block/basic/fieldset-stretch-to-legend.html + +# Fail until ENABLE_XHR_RESPONSE_BLOB is enabled. +http/tests/xmlhttprequest/response-blob-size.html Modified: trunk/LayoutTests/platform/win/Skipped (120054 => 120055) --- trunk/LayoutTests/platform/win/Skipped 2012-06-12 10:47:39 UTC (rev 120054) +++ trunk/LayoutTests/platform/win/Skipped 2012-06-12 11:05:01 UTC (rev 120055) @@ -2371,3 +2371,6 @@ svg/css/composite-shadow-text.svg svg/css/composite-shadow-with-opacity.html svg/css/css-box-min-width.html + +# Fail until ENABLE_XHR_RESPONSE_BLOB is enabled. +http/tests/xmlhttprequest/response-blob-size.html Modified: trunk/LayoutTests/platform/wincairo/Skipped (120054 => 120055) --- trunk/LayoutTests/platform/wincairo/Skipped 2012-06-12 10:47:39 UTC (rev 120054) +++ trunk/LayoutTests/platform/wincairo/Skipped 2012-06-12 11:05:01 UTC (rev 120055) @@ -2116,3 +2116,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=86000 http/tests/security/referrer-policy-redirect-link.html + +# Fail until ENABLE_XHR_RESPONSE_BLOB is enabled. +http/tests/xmlhttprequest/response-blob-size.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120056] trunk/LayoutTests
Title: [120056] trunk/LayoutTests
Revision 120056
Author o...@webkit.org
Date 2012-06-12 04:09:00 -0700 (Tue, 12 Jun 2012)
Log Message
[Qt] Diverging test results on 32/64 bit architectures
https://bugs.webkit.org/show_bug.cgi?id=82601
Unreviewed gardening, update expected files.
* platform/qt/Skipped: Unskip svg/transforms/transform-origin-css-property.xhtml, because it passes now.
* platform/qt/fast/repaint/moving-shadow-on-container-expected.png:
* platform/qt/fast/repaint/moving-shadow-on-path-expected.png:
* platform/qt/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
* platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.png:
* platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/qt/svg/transforms/transform-origin-css-property-expected.png: Removed, because it is a reftest.
* platform/qt/svg/transforms/transform-origin-css-property-expected.txt: Removed, because it is a reftest.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt/fast/repaint/moving-shadow-on-container-expected.png
trunk/LayoutTests/platform/qt/fast/repaint/moving-shadow-on-path-expected.png
trunk/LayoutTests/platform/qt/svg/W3C-SVG-1.1/paths-data-03-f-expected.png
trunk/LayoutTests/platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.png
trunk/LayoutTests/platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt
Removed Paths
trunk/LayoutTests/platform/qt/svg/transforms/transform-origin-css-property-expected.png
trunk/LayoutTests/platform/qt/svg/transforms/transform-origin-css-property-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (120055 => 120056)
--- trunk/LayoutTests/ChangeLog 2012-06-12 11:05:01 UTC (rev 120055)
+++ trunk/LayoutTests/ChangeLog 2012-06-12 11:09:00 UTC (rev 120056)
@@ -1,3 +1,19 @@
+2012-06-12 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Diverging test results on 32/64 bit architectures
+https://bugs.webkit.org/show_bug.cgi?id=82601
+
+Unreviewed gardening, update expected files.
+
+* platform/qt/Skipped: Unskip svg/transforms/transform-origin-css-property.xhtml, because it passes now.
+* platform/qt/fast/repaint/moving-shadow-on-container-expected.png:
+* platform/qt/fast/repaint/moving-shadow-on-path-expected.png:
+* platform/qt/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
+* platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.png:
+* platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
+* platform/qt/svg/transforms/transform-origin-css-property-expected.png: Removed, because it is a reftest.
+* platform/qt/svg/transforms/transform-origin-css-property-expected.txt: Removed, because it is a reftest.
+
2012-06-12 Kinuko Yasuda kin...@chromium.org
Unreviewed; skipping the new XHR blob test on the platforms where XHR_RESPONSE_BLOB is not enabled.
Modified: trunk/LayoutTests/platform/qt/Skipped (120055 => 120056)
--- trunk/LayoutTests/platform/qt/Skipped 2012-06-12 11:05:01 UTC (rev 120055)
+++ trunk/LayoutTests/platform/qt/Skipped 2012-06-12 11:09:00 UTC (rev 120056)
@@ -1410,7 +1410,6 @@
svg/W3C-SVG-1.1/paths-data-03-f.svg
svg/css/stars-with-shadow.html
svg/custom/use-on-symbol-inside-pattern.svg
-svg/transforms/transform-origin-css-property.xhtml
# = #
# Failing CSS Tests
Modified: trunk/LayoutTests/platform/qt/fast/repaint/moving-shadow-on-container-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/qt/fast/repaint/moving-shadow-on-path-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/qt/svg/W3C-SVG-1.1/paths-data-03-f-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt (120055 => 120056)
--- trunk/LayoutTests/platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt 2012-06-12 11:05:01 UTC (rev 120055)
+++ trunk/LayoutTests/platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt 2012-06-12 11:09:00 UTC (rev 120056)
@@ -3,6 +3,17 @@
layer at (0,0) size 225x425
RenderSVGRoot {svg} at (8,4) size 205x198
RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+ RenderSVGHiddenContainer {symbol} at (0,0) size 0x0
+RenderSVGPath {path} at (0,0) size 1x15 [stroke={[type=SOLID] [color=#008000] [stroke width=2.00]}] [data="" 0 -15 L 0 15]
+RenderSVGPath {path} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#008000] [stroke width=2.00]}] [data="" 0 -15 C 0 -12.6667 1.7 -11.5 5 -11.5]
+RenderSVGPath {path} at (0,0) size 0x0 [stroke={[type=SOLID] [color=#008000] [stroke width=2.00]}] [data="" 0 -15 C 0 -12.6667 -1.7 -11.5 -5 -11.5]
+RenderSVGPath {path} at (0,0) size 0x0
[webkit-changes] [120058] trunk/LayoutTests
Title: [120058] trunk/LayoutTests Revision 120058 Author domin...@chromium.org Date 2012-06-12 04:30:42 -0700 (Tue, 12 Jun 2012) Log Message [Chromium] Unreviewed: Add expectations for speech-recognition-event-constructor This looks like it was failing as it was added in r120053. Filed bug 88856. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120057 => 120058) --- trunk/LayoutTests/ChangeLog 2012-06-12 11:18:18 UTC (rev 120057) +++ trunk/LayoutTests/ChangeLog 2012-06-12 11:30:42 UTC (rev 120058) @@ -1,3 +1,12 @@ +2012-06-12 Dominic Cooney domin...@chromium.org + +[Chromium] Unreviewed: Add expectations for speech-recognition-event-constructor + +This looks like it was failing as it was added in r120053. Filed +bug 88856. + +* platform/chromium/TestExpectations: + 2012-06-12 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r120051. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120057 => 120058) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 11:18:18 UTC (rev 120057) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 11:30:42 UTC (rev 120058) @@ -3710,3 +3710,5 @@ BUGWK88833 MAC DEBUG : media/track/track-cues-cuechange.html = PASS TIMEOUT BUGWK88832 XP : http/tests/xmlhttprequest/origin-exact-matching.html = PASS TIMEOUT + +BUGWK88856 : fast/events/constructors/speech-recognition-event-constructor.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120066] trunk/Source/WebCore
Title: [120066] trunk/Source/WebCore
Revision 120066
Author commit-qu...@webkit.org
Date 2012-06-12 06:33:36 -0700 (Tue, 12 Jun 2012)
Log Message
[Qt][Texmap] Falling leaves demo missing clipping.
https://bugs.webkit.org/show_bug.cgi?id=88704
The bug originated from begining native painting mode of QPainter after enabling
scissor test, because begining native painting mode disables scissor test.
Covered by existing compositing tests.
Patch by Huang Dongsung luxte...@company100.net on 2012-06-12
Reviewed by Noam Rosenthal.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::beginPainting):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120065 => 120066)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 13:30:54 UTC (rev 120065)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 13:33:36 UTC (rev 120066)
@@ -1,3 +1,18 @@
+2012-06-12 Huang Dongsung luxte...@company100.net
+
+[Qt][Texmap] Falling leaves demo missing clipping.
+https://bugs.webkit.org/show_bug.cgi?id=88704
+
+The bug originated from begining native painting mode of QPainter after enabling
+scissor test, because begining native painting mode disables scissor test.
+
+Covered by existing compositing tests.
+
+Reviewed by Noam Rosenthal.
+
+* platform/graphics/texmap/TextureMapperGL.cpp:
+(WebCore::TextureMapperGL::beginPainting):
+
2012-06-12 Csaba Osztrogonác o...@webkit.org
[Qt][Win] Buildfix related to fromWinHBITMAP
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (120065 => 120066)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2012-06-12 13:30:54 UTC (rev 120065)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2012-06-12 13:33:36 UTC (rev 120066)
@@ -259,8 +259,6 @@
GL_CMD(glGetIntegerv(GL_CURRENT_PROGRAM, data().previousProgram));
data().previousScissorState = glIsEnabled(GL_SCISSOR_TEST);
data().previousDepthState = glIsEnabled(GL_DEPTH_TEST);
-glDisable(GL_DEPTH_TEST);
-glEnable(GL_SCISSOR_TEST);
#if PLATFORM(QT)
if (m_context) {
QPainter* painter = m_context-platformContext();
@@ -268,6 +266,8 @@
painter-beginNativePainting();
}
#endif
+glDisable(GL_DEPTH_TEST);
+glEnable(GL_SCISSOR_TEST);
data().didModifyStencil = false;
GL_CMD(glDepthMask(0));
GL_CMD(glGetIntegerv(GL_VIEWPORT, data().viewport));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120067] trunk/LayoutTests
Title: [120067] trunk/LayoutTests Revision 120067 Author ma...@webkit.org Date 2012-06-12 06:40:19 -0700 (Tue, 12 Jun 2012) Log Message Unreviewed gardening. Skip test failing randomly in GTK bots after r120040. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120066 => 120067) --- trunk/LayoutTests/ChangeLog 2012-06-12 13:33:36 UTC (rev 120066) +++ trunk/LayoutTests/ChangeLog 2012-06-12 13:40:19 UTC (rev 120067) @@ -1,3 +1,9 @@ +2012-06-12 Mario Sanchez Prada msanc...@igalia.com + +Unreviewed gardening. Skip test failing randomly in GTK bots after r120040. + +* platform/gtk/TestExpectations: + 2012-06-12 Takashi Sakamoto ta...@google.com [Shadow DOM] style inside Shadow subtree should be scoped inside the subtree. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120066 => 120067) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 13:33:36 UTC (rev 120066) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 13:40:19 UTC (rev 120067) @@ -488,6 +488,8 @@ BUGWK83878 : media/track/track-mode.html = PASS TEXT +BUGWK88867 : media/track/track-cue-rendering-snap-to-lines-not-set.html is flaky = PASS TEXT + // // End of Flaky tests // ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120068] trunk/Source/WebCore
Title: [120068] trunk/Source/WebCore
Revision 120068
Author m...@apple.com
Date 2012-06-12 06:45:34 -0700 (Tue, 12 Jun 2012)
Log Message
Tried to fix the notification-enabled build after r120044.
* notifications/NotificationController.cpp:
(WebCore::NotificationController::NotificationController):
(WebCore::NotificationController::create):
(WebCore::provideNotification):
* notifications/NotificationController.h:
(NotificationController):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/notifications/NotificationController.cpp
trunk/Source/WebCore/notifications/NotificationController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (120067 => 120068)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 13:40:19 UTC (rev 120067)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 13:45:34 UTC (rev 120068)
@@ -1,3 +1,14 @@
+2012-06-12 Dan Bernstein m...@apple.com
+
+Tried to fix the notification-enabled build after r120044.
+
+* notifications/NotificationController.cpp:
+(WebCore::NotificationController::NotificationController):
+(WebCore::NotificationController::create):
+(WebCore::provideNotification):
+* notifications/NotificationController.h:
+(NotificationController):
+
2012-06-12 Huang Dongsung luxte...@company100.net
[Qt][Texmap] Falling leaves demo missing clipping.
Modified: trunk/Source/WebCore/notifications/NotificationController.cpp (120067 => 120068)
--- trunk/Source/WebCore/notifications/NotificationController.cpp 2012-06-12 13:40:19 UTC (rev 120067)
+++ trunk/Source/WebCore/notifications/NotificationController.cpp 2012-06-12 13:45:34 UTC (rev 120068)
@@ -33,7 +33,7 @@
namespace WebCore {
-NotificationController::NotificationController(Page* page, NotificationClient* client)
+NotificationController::NotificationController(NotificationClient* client)
: m_client(client)
{
}
@@ -44,9 +44,9 @@
m_client-notificationControllerDestroyed();
}
-PassOwnPtrNotificationController NotificationController::create(Page* page, NotificationClient* client)
+PassOwnPtrNotificationController NotificationController::create(NotificationClient* client)
{
-return adoptPtr(new NotificationController(page, client));
+return adoptPtr(new NotificationController(client));
}
NotificationClient* NotificationController::clientFrom(Page* page)
@@ -64,7 +64,7 @@
void provideNotification(Page* page, NotificationClient* client)
{
-NotificationController::provideTo(page, NotificationController::supplementName(), NotificationController::create(page, client));
+NotificationController::provideTo(page, NotificationController::supplementName(), NotificationController::create(client));
}
} // namespace WebCore
Modified: trunk/Source/WebCore/notifications/NotificationController.h (120067 => 120068)
--- trunk/Source/WebCore/notifications/NotificationController.h 2012-06-12 13:40:19 UTC (rev 120067)
+++ trunk/Source/WebCore/notifications/NotificationController.h 2012-06-12 13:45:34 UTC (rev 120068)
@@ -41,7 +41,7 @@
public:
~NotificationController();
-static PassOwnPtrNotificationController create(Page*, NotificationClient*);
+static PassOwnPtrNotificationController create(NotificationClient*);
static const AtomicString supplementName();
static NotificationController* from(Page* page) { return static_castNotificationController*(SupplementPage::from(page, supplementName())); }
static NotificationClient* clientFrom(Page*);
@@ -49,7 +49,7 @@
NotificationClient* client() { return m_client; }
private:
-NotificationController(Page*, NotificationClient*);
+NotificationController(NotificationClient*);
NotificationClient* m_client;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120069] trunk/Source/WebCore
Title: [120069] trunk/Source/WebCore Revision 120069 Author pfeld...@chromium.org Date 2012-06-12 06:52:07 -0700 (Tue, 12 Jun 2012) Log Message 2012-06-12 Pavel Feldman pfeld...@chromium.org Not reviewed: removed svn:mime-type property from English.lproj/localizedStrings.js * English.lproj/localizedStrings.js Modified Paths trunk/Source/WebCore/ChangeLog Property Changed trunk/Source/WebCore/English.lproj/localizedStrings.js Diff Modified: trunk/Source/WebCore/ChangeLog (120068 => 120069) --- trunk/Source/WebCore/ChangeLog 2012-06-12 13:45:34 UTC (rev 120068) +++ trunk/Source/WebCore/ChangeLog 2012-06-12 13:52:07 UTC (rev 120069) @@ -1,3 +1,9 @@ +2012-06-12 Pavel Feldman pfeld...@chromium.org + +Not reviewed: removed svn:mime-type property from English.lproj/localizedStrings.js + +* English.lproj/localizedStrings.js + 2012-06-12 Dan Bernstein m...@apple.com Tried to fix the notification-enabled build after r120044. Property changes: trunk/Source/WebCore/English.lproj/localizedStrings.js Deleted: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120070] trunk/Source/WebCore
Title: [120070] trunk/Source/WebCore Revision 120070 Author pfeld...@chromium.org Date 2012-06-12 06:58:05 -0700 (Tue, 12 Jun 2012) Log Message Web Inspector: Provide context menu for deleting recorded profile on Profiles Panel https://bugs.webkit.org/show_bug.cgi?id=88286 Added the context menu to delete the selected profile. Patch by Rahul Tiwari rahultiwari.cse.i...@gmail.com on 2012-06-12 Reviewed by Pavel Feldman. No new tests required as UI related change * English.lproj/localizedStrings.js: Removed property svn:mime-type. * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js Diff Modified: trunk/Source/WebCore/ChangeLog (120069 => 120070) --- trunk/Source/WebCore/ChangeLog 2012-06-12 13:52:07 UTC (rev 120069) +++ trunk/Source/WebCore/ChangeLog 2012-06-12 13:58:05 UTC (rev 120070) @@ -1,3 +1,18 @@ +2012-06-12 Rahul Tiwari rahultiwari.cse.i...@gmail.com + +Web Inspector: Provide context menu for deleting recorded profile on Profiles Panel +https://bugs.webkit.org/show_bug.cgi?id=88286 + +Added the context menu to delete the selected profile. + +Reviewed by Pavel Feldman. + +No new tests required as UI related change + +* English.lproj/localizedStrings.js: Removed property svn:mime-type. +* inspector/front-end/ProfilesPanel.js: +(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent): + 2012-06-12 Pavel Feldman pfeld...@chromium.org Not reviewed: removed svn:mime-type property from English.lproj/localizedStrings.js Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (120069 => 120070) --- trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-06-12 13:52:07 UTC (rev 120069) +++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-06-12 13:58:05 UTC (rev 120070) @@ -698,3 +698,4 @@ localizedStrings[Hide debugger] = Hide debugger; localizedStrings[Clipboard access is denied] = Clipboard access is denied; localizedStrings[Go to source] = Go to source; +localizedStrings[Delete profile] = Delete profile; Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (120069 => 120070) --- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2012-06-12 13:52:07 UTC (rev 120069) +++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2012-06-12 13:58:05 UTC (rev 120070) @@ -1249,6 +1249,7 @@ if (profile.canSaveToFile()) contextMenu.appendItem(WebInspector.UIString(Save profile\u2026), profile.saveToFile.bind(profile)); contextMenu.appendItem(WebInspector.UIString(Load profile\u2026), WebInspector.panels.profiles._fileSelectorElement.click.bind(WebInspector.panels.profiles._fileSelectorElement)); +contextMenu.appendItem(WebInspector.UIString(Delete profile), this.ondelete.bind(this)); contextMenu.show(event); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120071] trunk
Title: [120071] trunk Revision 120071 Author commit-qu...@webkit.org Date 2012-06-12 07:21:41 -0700 (Tue, 12 Jun 2012) Log Message [CSSRegions]NamedFlow::overset should return true when there's no region chain attached https://bugs.webkit.org/show_bug.cgi?id=88515 The CSS Regions specifies that the overset attribute needs to return true if the content overflows, there's no region attached to the flow or if the NamedFlow is in the NULL state: http://www.w3.org/TR/css3-regions/#dom-named-flow-overset Source/WebCore: This patch updates WebKit's behavior in the last two situations to match the one in the spec. Patch by Andrei Bucur abu...@adobe.com on 2012-06-12 Reviewed by Andreas Kling. Test: fast/regions/webkit-named-flow-overset.html was updated * rendering/RenderFlowThread.cpp: (WebCore::RenderFlowThread::RenderFlowThread): (WebCore::RenderFlowThread::computeOverflowStateForRegions): If the last valid region is null, the flow has not region chain attached or it's in the NULL state. LayoutTests: The overset test was updated to cover the attribute value in case of a flow in the NULL state. Patch by Andrei Bucur abu...@adobe.com on 2012-06-12 Reviewed by Andreas Kling. * fast/regions/webkit-named-flow-overset-expected.txt: * fast/regions/webkit-named-flow-overset.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/regions/webkit-named-flow-overset-expected.txt trunk/LayoutTests/fast/regions/webkit-named-flow-overset.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderFlowThread.cpp Diff Modified: trunk/LayoutTests/ChangeLog (120070 => 120071) --- trunk/LayoutTests/ChangeLog 2012-06-12 13:58:05 UTC (rev 120070) +++ trunk/LayoutTests/ChangeLog 2012-06-12 14:21:41 UTC (rev 120071) @@ -1,3 +1,19 @@ +2012-06-12 Andrei Bucur abu...@adobe.com + +[CSSRegions]NamedFlow::overset should return true when there's no region chain attached +https://bugs.webkit.org/show_bug.cgi?id=88515 + +The CSS Regions specifies that the overset attribute needs to return true if the content overflows, there's no region attached to the flow +or if the NamedFlow is in the NULL state: +http://www.w3.org/TR/css3-regions/#dom-named-flow-overset + +The overset test was updated to cover the attribute value in case of a flow in the NULL state. + +Reviewed by Andreas Kling. + +* fast/regions/webkit-named-flow-overset-expected.txt: +* fast/regions/webkit-named-flow-overset.html: + 2012-06-12 Mario Sanchez Prada msanc...@igalia.com Unreviewed gardening. Skip test failing randomly in GTK bots after r120040. Modified: trunk/LayoutTests/fast/regions/webkit-named-flow-overset-expected.txt (120070 => 120071) --- trunk/LayoutTests/fast/regions/webkit-named-flow-overset-expected.txt 2012-06-12 13:58:05 UTC (rev 120070) +++ trunk/LayoutTests/fast/regions/webkit-named-flow-overset-expected.txt 2012-06-12 14:21:41 UTC (rev 120071) @@ -3,14 +3,15 @@ On success, you will see a series of PASS messages, followed by TEST COMPLETE. +PASS namedFlow.overset is true PASS namedFlow.overset is false +PASS namedFlow.overset is true PASS namedFlow.overset is false PASS namedFlow.overset is true PASS namedFlow.overset is false PASS namedFlow.overset is true PASS namedFlow.overset is false PASS namedFlow.overset is true -PASS namedFlow.overset is false PASS successfullyParsed is true TEST COMPLETE Modified: trunk/LayoutTests/fast/regions/webkit-named-flow-overset.html (120070 => 120071) --- trunk/LayoutTests/fast/regions/webkit-named-flow-overset.html 2012-06-12 13:58:05 UTC (rev 120070) +++ trunk/LayoutTests/fast/regions/webkit-named-flow-overset.html 2012-06-12 14:21:41 UTC (rev 120071) @@ -26,62 +26,68 @@ // Flow article does not have any regions yet var namedFlow = document.webkitGetFlowByName(flow); -// Overflow should be false for a flow without regions -shouldBe(namedFlow.overset, false); +// Overset should be false for a flow without regions +shouldBe(namedFlow.overset, true); -// Add a region to take the content, overflow should be false since the content first the regions. +// Add a region to take the content, overset should be false since the content first the regions. var region = document.createElement(div); document.body.appendChild(region); region.id = region; region.className = region; -// Overflow should be false since the content fits the regions +// Overset should be false since the content fits the regions shouldBe(namedFlow.overset, false); -// Add more content to the flow, overflow should be true. +// Add more content to the flow, overset should be true. var p = document.createElement(p); p.appendChild(document.createTextNode(Content inside article)); document.getElementById(article).appendChild(p); -// Overflow should be true since the content does not fit the regions +
[webkit-changes] [120072] trunk
Title: [120072] trunk Revision 120072 Author commit-qu...@webkit.org Date 2012-06-12 07:31:59 -0700 (Tue, 12 Jun 2012) Log Message Change the volume slider to horizontal rendering for Chrome video controls. https://bugs.webkit.org/show_bug.cgi?id=87835 Patch by Silvia Pfeiffer silvi...@chromium.org on 2012-06-12 Reviewed by Eric Carlson. Source/WebCore: No new tests - final patch in the Chrome controls update series will contain rebaselined tests. The Chrome video controls are receiving a visual update. The volume slider is moved into the controls with horizontal rendering, the volume slider container is removed. The visual update itself is in a separate patch. * css/mediaControlsChromium.css: (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): Removed relative positioning to render all controls elements equally in DOM order. (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): Removed absolute positioning to render all controls elements equally in DOM order. (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container): Removed absolute positioning to render all controls elements equally in DOM order. (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container): Removed volume slider container - it's not necessary any more. (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): Remove flexbox and introduce inline display to always display this field. (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider): Removed absolute positioning to render all controls elements equally in DOM order. * html/shadow/MediaControlRootElementChromium.cpp: (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium): Removed volume slider container - it's not necessary any more. (WebCore::MediaControlRootElementChromium::create): Appended the volume slider and the mute button directly to the panel, removed volume slider container. (WebCore::MediaControlRootElementChromium::setMediaController): Removed volume slider container. (WebCore::MediaControlRootElementChromium::reportedError): Removed volume slider container. (WebCore::MediaControlRootElementChromium::showVolumeSlider): Removed volume slider container. * html/shadow/MediaControlRootElementChromium.h: (WebCore): (MediaControlRootElementChromium): Removed volume slider container. * html/shadow/SliderThumbElement.cpp: (WebCore::hasVerticalAppearance): Allow use of horizontal media volume slider. (WebCore::RenderSliderThumb::layout): Reuse hasVerticalAppearance function. * rendering/RenderMediaControlsChromium.cpp: (WebCore::RenderMediaControlsChromium::paintMediaVolumeSlider): Change line drawing from vertical to horizontal. * rendering/RenderTheme.h: (WebCore::RenderTheme::usesVerticalVolumeSlider): Add usesVerticalVolumeSlider function to allow horizontal volume sliders. * rendering/RenderThemeChromiumMac.h: (WebCore::RenderThemeChromiumMac::usesVerticalVolumeSlider): Add usesVerticalVolumeSlider function to allow horizontal volume sliders. Add usesVerticalVolumeSlider function to allow horizontal volume sliders. * rendering/RenderThemeChromiumSkia.h: (WebCore::RenderThemeChromiumSkia::usesVerticalVolumeSlider): Add usesVerticalVolumeSlider function to allow horizontal volume sliders. LayoutTests: The Chrome video controls are receiving a visual update. The volume slider is included into the controls with horizontal rendering, the volume slider container is removed. The visual update itself is in a separate patch. * platform/chromium/TestExpectations: Temporarily skip tests related to volume controls rendering for Chromium. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/mediaControlsChromium.css trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.h trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp trunk/Source/WebCore/rendering/RenderMediaControlsChromium.cpp trunk/Source/WebCore/rendering/RenderTheme.h trunk/Source/WebCore/rendering/RenderThemeChromiumMac.h trunk/Source/WebCore/rendering/RenderThemeChromiumSkia.h Diff Modified: trunk/LayoutTests/ChangeLog (120071 => 120072) --- trunk/LayoutTests/ChangeLog 2012-06-12 14:21:41 UTC (rev 120071) +++ trunk/LayoutTests/ChangeLog 2012-06-12 14:31:59 UTC (rev 120072) @@ -1,3 +1,17 @@ +2012-06-12 Silvia Pfeiffer silvi...@chromium.org + +Change the volume slider to horizontal rendering for Chrome video controls. +https://bugs.webkit.org/show_bug.cgi?id=87835 + +Reviewed by Eric Carlson. + +The Chrome video controls are receiving a visual update. The volume slider is included into +the controls with horizontal
[webkit-changes] [120073] trunk/Source/WebCore
Title: [120073] trunk/Source/WebCore
Revision 120073
Author dan...@chromium.org
Date 2012-06-12 07:39:24 -0700 (Tue, 12 Jun 2012)
Log Message
[chromium] Use TextureDrawQuad for video layer output when it produces a single GL texture
https://bugs.webkit.org/show_bug.cgi?id=88814
Reviewed by Adrienne Walker.
When a CCVideLayerImpl produces quads for a frame that is contained
in a single GL texture, then use the TextureDrawQuad instead of the
VideoDrawQuad. Moves the computation for the RGBA(software) and
NativeTexture (hardware) cases from LayerRendererChromium into
CCVideoLayerImpl, so it can embed these values in the TextureDrawQuad.
No new tests, behaviour should be the same.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120072 => 120073)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 14:31:59 UTC (rev 120072)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 14:39:24 UTC (rev 120073)
@@ -1,3 +1,26 @@
+2012-06-11 Dana Jansens dan...@chromium.org
+
+[chromium] Use TextureDrawQuad for video layer output when it produces a single GL texture
+https://bugs.webkit.org/show_bug.cgi?id=88814
+
+Reviewed by Adrienne Walker.
+
+When a CCVideLayerImpl produces quads for a frame that is contained
+in a single GL texture, then use the TextureDrawQuad instead of the
+VideoDrawQuad. Moves the computation for the RGBA(software) and
+NativeTexture (hardware) cases from LayerRendererChromium into
+CCVideoLayerImpl, so it can embed these values in the TextureDrawQuad.
+
+No new tests, behaviour should be the same.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::drawStreamTexture):
+(WebCore::LayerRendererChromium::drawVideoQuad):
+* platform/graphics/chromium/LayerRendererChromium.h:
+(LayerRendererChromium):
+* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
+(WebCore::CCVideoLayerImpl::appendQuads):
+
2012-06-12 Silvia Pfeiffer silvi...@chromium.org
Change the volume slider to horizontal rendering for Chrome video controls.
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (120072 => 120073)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2012-06-12 14:31:59 UTC (rev 120072)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2012-06-12 14:39:24 UTC (rev 120073)
@@ -1038,38 +1038,6 @@
GLC(context(), context()-activeTexture(GraphicsContext3D::TEXTURE0));
}
-templateclass Program
-void LayerRendererChromium::drawSingleTextureVideoQuad(const CCVideoDrawQuad* quad, Program* program, float widthScaleFactor, Platform3DObject textureId, GC3Denum target)
-{
-ASSERT(program program-initialized());
-
-GLC(context(), context()-activeTexture(GraphicsContext3D::TEXTURE0));
-GLC(context(), context()-bindTexture(target, textureId));
-
-GLC(context(), context()-useProgram(program-program()));
-GLC(context(), context()-uniform4f(program-vertexShader().texTransformLocation(), 0, 0, widthScaleFactor, 1));
-GLC(context(), context()-uniform1i(program-fragmentShader().samplerLocation(), 0));
-
-const IntSize bounds = quad-quadRect().size();
-drawTexturedQuad(quad-layerTransform(), bounds.width(), bounds.height(), quad-opacity(), sharedGeometryQuad(),
-program-vertexShader().matrixLocation(),
-program-fragmentShader().alphaLocation(),
--1);
-}
-
-void LayerRendererChromium::drawRGBA(const CCVideoDrawQuad* quad)
-{
-const TextureProgram* program = textureProgram();
-const CCVideoLayerImpl::FramePlane plane = quad-planes()[WebKit::WebVideoFrame::rgbPlane];
-float widthScaleFactor = static_castfloat(plane.visibleSize.width()) / plane.size.width();
-drawSingleTextureVideoQuad(quad, program, widthScaleFactor, plane.textureId, GraphicsContext3D::TEXTURE_2D);
-}
-
-void LayerRendererChromium::drawNativeTexture2D(const CCVideoDrawQuad* quad)
-{
-drawSingleTextureVideoQuad(quad, textureProgram(), 1, quad-frameProviderTextureId(), GraphicsContext3D::TEXTURE_2D);
-}
-
void LayerRendererChromium::drawStreamTexture(const CCVideoDrawQuad* quad)
{
static float glMatrix[16];
@@ -1082,7 +1050,17 @@
[webkit-changes] [120074] trunk/Source/WebKit/blackberry
Title: [120074] trunk/Source/WebKit/blackberry
Revision 120074
Author commit-qu...@webkit.org
Date 2012-06-12 07:51:18 -0700 (Tue, 12 Jun 2012)
Log Message
[BlackBerry] Use a safer way to shrink JS memory usage
https://bugs.webkit.org/show_bug.cgi?id=88811
Patch by Yong Li y...@rim.com on 2012-06-12
Reviewed by Antonio Gomes.
We should just make a GC request and JSC will check if it is safe to do anything.
* Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::clearMemoryCaches):
Modified Paths
trunk/Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp
trunk/Source/WebKit/blackberry/ChangeLog
Diff
Modified: trunk/Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp (120073 => 120074)
--- trunk/Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp 2012-06-12 14:39:24 UTC (rev 120073)
+++ trunk/Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp 2012-06-12 14:51:18 UTC (rev 120074)
@@ -105,11 +105,7 @@
BlackBerry::Platform::userInterfaceThreadMessageClient()-dispatchMessage(BlackBerry::Platform::createFunctionCallMessage(clearMemoryCachesInCompositingThread));
#endif
-{
-JSC::JSLock lock(JSC::SilenceAssertionsOnly);
-// This function also performs a GC.
-JSC::releaseExecutableMemory(*JSDOMWindow::commonJSGlobalData());
-}
+collectJavascriptGarbageNow();
// Clean caches after JS garbage collection because JS GC can
// generate more dead resources.
Modified: trunk/Source/WebKit/blackberry/ChangeLog (120073 => 120074)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-12 14:39:24 UTC (rev 120073)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-12 14:51:18 UTC (rev 120074)
@@ -1,3 +1,15 @@
+2012-06-12 Yong Li y...@rim.com
+
+[BlackBerry] Use a safer way to shrink JS memory usage
+https://bugs.webkit.org/show_bug.cgi?id=88811
+
+Reviewed by Antonio Gomes.
+
+We should just make a GC request and JSC will check if it is safe to do anything.
+
+* Api/BlackBerryGlobal.cpp:
+(BlackBerry::WebKit::clearMemoryCaches):
+
2012-06-11 Jonathan Dong jonathan.d...@torchmobile.com.cn
[BlackBerry] Autofill feature implementation for BlackBerry porting
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120075] trunk/Source/WebKit2
Title: [120075] trunk/Source/WebKit2
Revision 120075
Author kenn...@webkit.org
Date 2012-06-12 07:55:14 -0700 (Tue, 12 Jun 2012)
Log Message
[Qt] Do not move/scale content while the user is interacting with it
https://bugs.webkit.org/show_bug.cgi?id=88872
Reviewed by Simon Hausmann.
Don't try moving content into valid bounds when the content
size changes and the user is interacting with the content.
Only apply the viewport initial scale after user interaction
has ended.
* UIProcess/qt/QtViewportHandler.cpp:
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportHandler::setInitialScaleIfNeeded):
(WebKit::QtViewportHandler::viewportAttributesChanged):
(WebKit::QtViewportHandler::pageContentsSizeChanged):
(WebKit::QtViewportHandler::initialRect):
(WebKit):
* UIProcess/qt/QtViewportHandler.h:
(QtViewportHandler):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (120074 => 120075)
--- trunk/Source/WebKit2/ChangeLog 2012-06-12 14:51:18 UTC (rev 120074)
+++ trunk/Source/WebKit2/ChangeLog 2012-06-12 14:55:14 UTC (rev 120075)
@@ -1,3 +1,26 @@
+2012-06-12 Kenneth Rohde Christiansen kenn...@webkit.org
+
+[Qt] Do not move/scale content while the user is interacting with it
+https://bugs.webkit.org/show_bug.cgi?id=88872
+
+Reviewed by Simon Hausmann.
+
+Don't try moving content into valid bounds when the content
+size changes and the user is interacting with the content.
+
+Only apply the viewport initial scale after user interaction
+has ended.
+
+* UIProcess/qt/QtViewportHandler.cpp:
+(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
+(WebKit::QtViewportHandler::setInitialScaleIfNeeded):
+(WebKit::QtViewportHandler::viewportAttributesChanged):
+(WebKit::QtViewportHandler::pageContentsSizeChanged):
+(WebKit::QtViewportHandler::initialRect):
+(WebKit):
+* UIProcess/qt/QtViewportHandler.h:
+(QtViewportHandler):
+
2012-06-11 Kaustubh Atrawalkar kaust...@motorola.com
[DRT] LTC:: counterValueForElementById() could be moved to Internals.
Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp (120074 => 120075)
--- trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp 2012-06-12 14:51:18 UTC (rev 120074)
+++ trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp 2012-06-12 14:55:14 UTC (rev 120075)
@@ -78,6 +78,11 @@
~ViewportUpdateDeferrer()
{
+// We are calling setInitialScaleIfNeeded() here as it requires a
+// possitive m_suspendCount due to the assert in setPageItemRectVisible().
+if (handler-m_suspendCount == 1)
+handler-setInitialScaleIfNeeded();
+
if (--(handler-m_suspendCount))
return;
@@ -195,51 +200,37 @@
return innerBoundedCSSScale(cssScale);
}
-void QtViewportHandler::viewportAttributesChanged(const WebCore::ViewportAttributes newAttributes)
+void QtViewportHandler::setInitialScaleIfNeeded()
{
-m_rawAttributes = newAttributes;
-WebCore::restrictScaleFactorToInitialScaleIfNotUserScalable(m_rawAttributes);
+if (m_rawAttributes.initialScale 0)
+return;
-{
-// FIXME: Resetting here is wrong, it should happen only for the first
-// viewport change for a given page and first when we paint the page for
-// the first time.
+m_zoomOutScale = 0.0;
+m_scaleStack.clear();
-m_hadUserInteraction = false;
+m_hadUserInteraction = false;
-m_zoomOutScale = 0.0;
-m_scaleStack.clear();
+// We must not animate here as the new contents size might be very different
+// than the current one.
+setPageItemRectVisible(initialRect());
-// This part below should go fully away when the above plan is implemented.
+m_rawAttributes.initialScale = -1; // Mark used.
+}
-m_viewportItem-cancelFlick();
-m_scaleAnimation-stop();
+void QtViewportHandler::viewportAttributesChanged(const WebCore::ViewportAttributes newAttributes)
+{
+m_rawAttributes = newAttributes;
+WebCore::restrictScaleFactorToInitialScaleIfNotUserScalable(m_rawAttributes);
-m_scaleUpdateDeferrer.clear();
-m_scrollUpdateDeferrer.clear();
-m_touchUpdateDeferrer.clear();
-m_animationUpdateDeferrer.clear();
-ASSERT(!m_suspendCount);
-ASSERT(!m_hasSuspendedContent);
-}
-
m_devicePixelRatio = m_rawAttributes.devicePixelRatio; // Should return value from the webPageProxy.
m_allowsUserScaling = !!m_rawAttributes.userScalable;
m_minimumScale = m_rawAttributes.minimumScale;
m_maximumScale = m_rawAttributes.maximumScale;
-if (!m_hadUserInteraction !m_hasSuspendedContent) {
-ASSERT(m_pinchStartScale == -1);
-// Emits
[webkit-changes] [120076] trunk/Source
Title: [120076] trunk/Source
Revision 120076
Author jocelyn.turco...@nokia.com
Date 2012-06-12 08:04:41 -0700 (Tue, 12 Jun 2012)
Log Message
Using extrernal ICU library on case unsensitive drives will not work
https://bugs.webkit.org/show_bug.cgi?id=70913
Reviewed by Csaba Osztrogonác.
Source/WebCore:
* platform/graphics/surfaces/GraphicsSurface.h:
Source/WebKit2:
* WebProcess/WebPage/UpdateAtlas.cpp:
Source/WTF:
Properly set the include path for the WTF module and for modules using it.
The path should include Source/WTF/wtf only when building WTF itself. Other
modules are expected to include the headers as #include wtf/Header.h, so
only add Source/WTF to their include path.
unicode/utf8.h should now then always reference to ICU in the include path
and wtf/unicode/UTF8.h reference to the WTF version.
This will work as long as WTF object files don't depend on ICU themselves.
Removed gobject, qt and unicode from the include path as those directories
don't exist anymore.
* WTF.pri:
* WTF.pro:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.pri
trunk/Source/WTF/WTF.pro
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/UpdateAtlas.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (120075 => 120076)
--- trunk/Source/WTF/ChangeLog 2012-06-12 14:55:14 UTC (rev 120075)
+++ trunk/Source/WTF/ChangeLog 2012-06-12 15:04:41 UTC (rev 120076)
@@ -1,3 +1,25 @@
+2012-06-11 Jocelyn Turcotte jocelyn.turco...@nokia.com
+
+Using extrernal ICU library on case unsensitive drives will not work
+https://bugs.webkit.org/show_bug.cgi?id=70913
+
+Reviewed by Csaba Osztrogonác.
+
+Properly set the include path for the WTF module and for modules using it.
+The path should include Source/WTF/wtf only when building WTF itself. Other
+modules are expected to include the headers as #include wtf/Header.h, so
+only add Source/WTF to their include path.
+
+unicode/utf8.h should now then always reference to ICU in the include path
+and wtf/unicode/UTF8.h reference to the WTF version.
+This will work as long as WTF object files don't depend on ICU themselves.
+
+Removed gobject, qt and unicode from the include path as those directories
+don't exist anymore.
+
+* WTF.pri:
+* WTF.pro:
+
2012-06-11 Carlos Garcia Campos cgar...@igalia.com
Unreviewed. Fix make distcheck issues.
Modified: trunk/Source/WTF/WTF.pri (120075 => 120076)
--- trunk/Source/WTF/WTF.pri 2012-06-12 14:55:14 UTC (rev 120075)
+++ trunk/Source/WTF/WTF.pri 2012-06-12 15:04:41 UTC (rev 120076)
@@ -7,18 +7,9 @@
load(features)
-SOURCE_DIR = $${ROOT_WEBKIT_DIR}/Source/WTF
+# All external modules should include WTF headers by prefixing with wtf (#include wtf/some/thing.h).
+INCLUDEPATH += $$PWD
-# FIXME: Including the root directory is a bad idea, likewise
-# no other project besides WTF should need to include WTF sub directories to build!
-INCLUDEPATH += \
-$$SOURCE_DIR/.. \
-$$SOURCE_DIR \
-$$SOURCE_DIR/gobject \
-$$SOURCE_DIR/qt \
-$$SOURCE_DIR/unicode \
-$$SOURCE_DIR/wtf
-
haveQt(5) {
mac {
# Mac OS does ship libicu but not the associated header files.
Modified: trunk/Source/WTF/WTF.pro (120075 => 120076)
--- trunk/Source/WTF/WTF.pro 2012-06-12 14:55:14 UTC (rev 120075)
+++ trunk/Source/WTF/WTF.pro 2012-06-12 15:04:41 UTC (rev 120076)
@@ -12,6 +12,8 @@
VPATH += $$PWD/wtf
+INCLUDEPATH += $$PWD/wtf
+
HEADERS += \
Alignment.h \
AlwaysInline.h \
Modified: trunk/Source/WebCore/ChangeLog (120075 => 120076)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 14:55:14 UTC (rev 120075)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 15:04:41 UTC (rev 120076)
@@ -1,3 +1,12 @@
+2012-06-11 Jocelyn Turcotte jocelyn.turco...@nokia.com
+
+Using extrernal ICU library on case unsensitive drives will not work
+https://bugs.webkit.org/show_bug.cgi?id=70913
+
+Reviewed by Csaba Osztrogonác.
+
+* platform/graphics/surfaces/GraphicsSurface.h:
+
2012-06-11 Dana Jansens dan...@chromium.org
[chromium] Use TextureDrawQuad for video layer output when it produces a single GL texture
Modified: trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h (120075 => 120076)
--- trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h 2012-06-12 14:55:14 UTC (rev 120075)
+++ trunk/Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h 2012-06-12 15:04:41 UTC (rev 120076)
@@ -22,10 +22,10 @@
#include GraphicsContext.h
#include IntRect.h
-#include OwnPtr.h
-#include PassOwnPtr.h
-#include RefCounted.h
-#include RefPtr.h
+#include wtf/OwnPtr.h
+#include wtf/PassOwnPtr.h
+#include wtf/RefCounted.h
+#include wtf/RefPtr.h
#if USE(GRAPHICS_SURFACE)
Modified: trunk/Source/WebKit2/ChangeLog (120075 =>
[webkit-changes] [120077] trunk/Source/WebKit2
Title: [120077] trunk/Source/WebKit2 Revision 120077 Author kenn...@webkit.org Date 2012-06-12 08:06:31 -0700 (Tue, 12 Jun 2012) Log Message Unreviewed build fix. * UIProcess/qt/QtViewportHandler.cpp: (WebKit::QtViewportHandler::initialRect): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (120076 => 120077) --- trunk/Source/WebKit2/ChangeLog 2012-06-12 15:04:41 UTC (rev 120076) +++ trunk/Source/WebKit2/ChangeLog 2012-06-12 15:06:31 UTC (rev 120077) @@ -1,3 +1,10 @@ +2012-06-12 Kenneth Rohde Christiansen kenn...@webkit.org + +Unreviewed build fix. + +* UIProcess/qt/QtViewportHandler.cpp: +(WebKit::QtViewportHandler::initialRect): + 2012-06-11 Jocelyn Turcotte jocelyn.turco...@nokia.com Using extrernal ICU library on case unsensitive drives will not work Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp (120076 => 120077) --- trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp 2012-06-12 15:04:41 UTC (rev 120076) +++ trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp 2012-06-12 15:06:31 UTC (rev 120077) @@ -520,6 +520,7 @@ ASSERT(m_rawAttributes.initialScale 0); qreal endItemScale = itemScaleFromCSS(innerBoundedCSSScale(m_rawAttributes.initialScale)); +const QRectF viewportRect = m_viewportItem-boundingRect(); QRectF endVisibleContentRect(QPointF(0, 0), viewportRect.size() / endItemScale); return endVisibleContentRect; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120079] trunk/LayoutTests
Title: [120079] trunk/LayoutTests Revision 120079 Author ma...@webkit.org Date 2012-06-12 08:11:35 -0700 (Tue, 12 Jun 2012) Log Message [Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt https://bugs.webkit.org/show_bug.cgi?id=85591 Reviewed by Martin Robinson. Remove FAIL text expectations for sputnik tests that have been consistently passing on all the Gtk builders. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120078 => 120079) --- trunk/LayoutTests/ChangeLog 2012-06-12 15:10:06 UTC (rev 120078) +++ trunk/LayoutTests/ChangeLog 2012-06-12 15:11:35 UTC (rev 120079) @@ -1,3 +1,15 @@ +2012-06-12 Mario Sanchez Prada msanc...@igalia.com + +[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt +https://bugs.webkit.org/show_bug.cgi?id=85591 + +Reviewed by Martin Robinson. + +Remove FAIL text expectations for sputnik tests that have been +consistently passing on all the Gtk builders. + +* platform/gtk/TestExpectations: + 2012-06-12 Silvia Pfeiffer silvi...@chromium.org Change the volume slider to horizontal rendering for Chrome video controls. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120078 => 120079) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 15:10:06 UTC (rev 120078) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 15:11:35 UTC (rev 120079) @@ -925,28 +925,6 @@ BUGWK53600 : http/tests/security/cross-frame-access-call.html = FAIL BUGWK53600 : http/tests/security/cross-frame-access-get.html = FAIL BUGWK53600 SKIP : inspector/console/console-long-eval-crash.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9.html = FAIL -BUGWK53600 : sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9.html = FAIL // pastes a space instead of a tab BUGWK38437 : editing/pasteboard/5761530-1.html = FAIL ___ webkit-changes mailing list
[webkit-changes] [120080] trunk/Source/WebCore
Title: [120080] trunk/Source/WebCore Revision 120080 Author commit-qu...@webkit.org Date 2012-06-12 08:29:33 -0700 (Tue, 12 Jun 2012) Log Message Generate -webkit-box-decoration-break property only when the feature is enabled https://bugs.webkit.org/show_bug.cgi?id=88861 Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-06-12 Reviewed by Alexis Menard. Otherwise it will hit an assertion if the property is present on the style but the feature disabled. Also fixes a compilation warning when the feature is disabled. * css/CSSPropertyNames.in: * css/StyleResolver.cpp: (WebCore::StyleResolver::collectMatchingRulesForList): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/StyleResolver.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (120079 => 120080) --- trunk/Source/WebCore/ChangeLog 2012-06-12 15:11:35 UTC (rev 120079) +++ trunk/Source/WebCore/ChangeLog 2012-06-12 15:29:33 UTC (rev 120080) @@ -1,3 +1,18 @@ +2012-06-12 Thiago Marcos P. Santos thiago.san...@intel.com + +Generate -webkit-box-decoration-break property only when the feature is enabled +https://bugs.webkit.org/show_bug.cgi?id=88861 + +Reviewed by Alexis Menard. + +Otherwise it will hit an assertion if the property is present on the +style but the feature disabled. Also fixes a compilation warning when +the feature is disabled. + +* css/CSSPropertyNames.in: +* css/StyleResolver.cpp: +(WebCore::StyleResolver::collectMatchingRulesForList): + 2012-06-12 Darin Adler da...@apple.com Tweaked the Mac export file a bit more, adding more-correct iOS cases. Modified: trunk/Source/WebCore/css/CSSPropertyNames.in (120079 => 120080) --- trunk/Source/WebCore/css/CSSPropertyNames.in 2012-06-12 15:11:35 UTC (rev 120079) +++ trunk/Source/WebCore/css/CSSPropertyNames.in 2012-06-12 15:29:33 UTC (rev 120080) @@ -256,7 +256,9 @@ -webkit-column-span -webkit-column-width -webkit-columns +#if defined(ENABLE_CSS_BOX_DECORATION_BREAK) ENABLE_CSS_BOX_DECORATION_BREAK -webkit-box-decoration-break +#endif #if defined(ENABLE_CSS_FILTERS) ENABLE_CSS_FILTERS -webkit-filter #endif Modified: trunk/Source/WebCore/css/StyleResolver.cpp (120079 => 120080) --- trunk/Source/WebCore/css/StyleResolver.cpp 2012-06-12 15:11:35 UTC (rev 120079) +++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-06-12 15:29:33 UTC (rev 120080) @@ -4098,7 +4098,9 @@ case CSSPropertyWebkitBorderRadius: case CSSPropertyWebkitBorderVerticalSpacing: case CSSPropertyWebkitBoxAlign: +#if ENABLE(CSS_BOX_DECORATION_BREAK) case CSSPropertyWebkitBoxDecorationBreak: +#endif case CSSPropertyWebkitBoxDirection: case CSSPropertyWebkitBoxFlex: case CSSPropertyWebkitBoxFlexGroup: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120081] trunk/Source/WebCore
Title: [120081] trunk/Source/WebCore
Revision 120081
Author kin...@chromium.org
Date 2012-06-12 08:34:15 -0700 (Tue, 12 Jun 2012)
Log Message
Refactor InputType::receiveDroppedFiles to take DragData
https://bugs.webkit.org/show_bug.cgi?id=88860
Reviewed by Kent Tamura.
So that we can centralize the file paths related code into FileInputType
and makes it easier to extract more data from DragData for
input type=file (like bug 88293 for directory drag-and-drop).
No new tests as this has no behavioral changes.
* html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFiles):
* html/FileInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::receiveDroppedFiles):
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::receiveDroppedFiles):
* html/InputType.h:
* page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/FileInputType.cpp
trunk/Source/WebCore/html/FileInputType.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/InputType.cpp
trunk/Source/WebCore/html/InputType.h
trunk/Source/WebCore/page/DragController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120080 => 120081)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 15:29:33 UTC (rev 120080)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 15:34:15 UTC (rev 120081)
@@ -1,3 +1,28 @@
+2012-06-12 Kinuko Yasuda kin...@chromium.org
+
+Refactor InputType::receiveDroppedFiles to take DragData
+https://bugs.webkit.org/show_bug.cgi?id=88860
+
+Reviewed by Kent Tamura.
+
+So that we can centralize the file paths related code into FileInputType
+and makes it easier to extract more data from DragData for
+input type=file (like bug 88293 for directory drag-and-drop).
+
+No new tests as this has no behavioral changes.
+
+* html/FileInputType.cpp:
+(WebCore::FileInputType::receiveDroppedFiles):
+* html/FileInputType.h:
+* html/HTMLInputElement.cpp:
+(WebCore::HTMLInputElement::receiveDroppedFiles):
+* html/HTMLInputElement.h:
+* html/InputType.cpp:
+(WebCore::InputType::receiveDroppedFiles):
+* html/InputType.h:
+* page/DragController.cpp:
+(WebCore::DragController::concludeEditDrag):
+
2012-06-12 Thiago Marcos P. Santos thiago.san...@intel.com
Generate -webkit-box-decoration-break property only when the feature is enabled
Modified: trunk/Source/WebCore/html/FileInputType.cpp (120080 => 120081)
--- trunk/Source/WebCore/html/FileInputType.cpp 2012-06-12 15:29:33 UTC (rev 120080)
+++ trunk/Source/WebCore/html/FileInputType.cpp 2012-06-12 15:34:15 UTC (rev 120081)
@@ -23,6 +23,7 @@
#include FileInputType.h
#include Chrome.h
+#include DragData.h
#include ElementShadow.h
#include Event.h
#include File.h
@@ -389,13 +390,18 @@
element()-renderer()-repaint();
}
-void FileInputType::receiveDroppedFiles(const VectorString paths)
+bool FileInputType::receiveDroppedFiles(const DragData* dragData)
{
+VectorString paths;
+dragData-asFilenames(paths);
+if (paths.isEmpty())
+return false;
+
HTMLInputElement* input = element();
#if ENABLE(DIRECTORY_UPLOAD)
if (input-fastHasAttribute(webkitdirectoryAttr)) {
receiveDropForDirectoryUpload(paths);
-return;
+return true;
}
#endif
@@ -410,6 +416,7 @@
firstFileOnly.append(files[0]);
filesChosen(firstFileOnly);
}
+return true;
}
Icon* FileInputType::icon() const
Modified: trunk/Source/WebCore/html/FileInputType.h (120080 => 120081)
--- trunk/Source/WebCore/html/FileInputType.h 2012-06-12 15:29:33 UTC (rev 120080)
+++ trunk/Source/WebCore/html/FileInputType.h 2012-06-12 15:34:15 UTC (rev 120081)
@@ -39,6 +39,7 @@
namespace WebCore {
+class DragData;
class FileList;
class FileInputType : public BaseClickableWithKeyInputType, private FileChooserClient, private FileIconLoaderClient {
@@ -62,7 +63,7 @@
virtual bool canSetValue(const String) OVERRIDE;
virtual bool getTypeSpecificValue(String) OVERRIDE; // Checked first, before internal storage or the value attribute.
virtual void setValue(const String, bool valueChanged, TextFieldEventBehavior) OVERRIDE;
-virtual void receiveDroppedFiles(const VectorString) OVERRIDE;
+virtual bool receiveDroppedFiles(const DragData*) OVERRIDE;
virtual Icon* icon() const OVERRIDE;
virtual bool isFileUpload() const OVERRIDE;
virtual void createShadowSubtree() OVERRIDE;
Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (120080 => 120081)
--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2012-06-12 15:29:33 UTC (rev 120080)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2012-06-12 15:34:15 UTC (rev 120081)
@@ -1226,9 +1226,9 @@
m_inputType-setFiles(files);
}
-void
[webkit-changes] [120083] trunk/Tools
Title: [120083] trunk/Tools
Revision 120083
Author o...@webkit.org
Date 2012-06-12 09:28:36 -0700 (Tue, 12 Jun 2012)
Log Message
[Qt] Fix -Werror for the buildbots
https://bugs.webkit.org/show_bug.cgi?id=88223
Rubber-stamped by Tor Arne Vestbø.
Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
* qmake/mkspecs/features/unix/default_post.prf:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/unix/default_post.prf
Diff
Modified: trunk/Tools/ChangeLog (120082 => 120083)
--- trunk/Tools/ChangeLog 2012-06-12 16:15:05 UTC (rev 120082)
+++ trunk/Tools/ChangeLog 2012-06-12 16:28:36 UTC (rev 120083)
@@ -1,3 +1,14 @@
+2012-06-12 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Fix -Werror for the buildbots
+https://bugs.webkit.org/show_bug.cgi?id=88223
+
+Rubber-stamped by Tor Arne Vestbø.
+
+Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
+
+* qmake/mkspecs/features/unix/default_post.prf:
+
2012-06-12 Balazs Kelemen kbal...@webkit.org
[REGRESSION][WTR] Build fail with werror after r120054
Modified: trunk/Tools/qmake/mkspecs/features/unix/default_post.prf (120082 => 120083)
--- trunk/Tools/qmake/mkspecs/features/unix/default_post.prf 2012-06-12 16:15:05 UTC (rev 120082)
+++ trunk/Tools/qmake/mkspecs/features/unix/default_post.prf 2012-06-12 16:28:36 UTC (rev 120083)
@@ -13,7 +13,7 @@
}
# Treat warnings as errors on x86/Linux/GCC
-qt_developer_build:linux-g++* {
+linux-g++* {
isEqual(QT_ARCH,x86_64)|isEqual(QT_ARCH,i386): QMAKE_CXXFLAGS += -Werror
greaterThan(QT_GCC_MAJOR_VERSION, 3):greaterThan(QT_GCC_MINOR_VERSION, 5) {
!contains(QMAKE_CXXFLAGS, -std=(c|gnu)\\+\\+(0x|11)) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120084] trunk
Title: [120084] trunk Revision 120084 Author commit-qu...@webkit.org Date 2012-06-12 09:32:58 -0700 (Tue, 12 Jun 2012) Log Message [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag https://bugs.webkit.org/show_bug.cgi?id=88715 Patch by Christophe Dumez christophe.du...@intel.com on 2012-06-12 Reviewed by Noam Rosenthal. .: Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port. * Source/cmake/OptionsEfl.cmake: * Source/cmakeconfig.h.cmake: Tools: Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port. * Scripts/webkitperl/FeatureList.pm: LayoutTests: Unskip fast/files/blob-builder-crash.html now that LEGACY_WEBKIT_BLOB_BUILDER flag is enabled by default on EFL port. * platform/efl/Skipped: Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/Skipped trunk/Source/cmake/OptionsEfl.cmake trunk/Source/cmakeconfig.h.cmake trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitperl/FeatureList.pm Diff Modified: trunk/ChangeLog (120083 => 120084) --- trunk/ChangeLog 2012-06-12 16:28:36 UTC (rev 120083) +++ trunk/ChangeLog 2012-06-12 16:32:58 UTC (rev 120084) @@ -1,3 +1,15 @@ +2012-06-12 Christophe Dumez christophe.du...@intel.com + +[EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag +https://bugs.webkit.org/show_bug.cgi?id=88715 + +Reviewed by Noam Rosenthal. + +Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port. + +* Source/cmake/OptionsEfl.cmake: +* Source/cmakeconfig.h.cmake: + 2012-06-12 Thiago Marcos P. Santos thiago.san...@intel.com [CMake] Enabled CSS_BOX_DECORATION_BREAK by default Modified: trunk/LayoutTests/ChangeLog (120083 => 120084) --- trunk/LayoutTests/ChangeLog 2012-06-12 16:28:36 UTC (rev 120083) +++ trunk/LayoutTests/ChangeLog 2012-06-12 16:32:58 UTC (rev 120084) @@ -1,5 +1,18 @@ 2012-06-12 Christophe Dumez christophe.du...@intel.com +[EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag +https://bugs.webkit.org/show_bug.cgi?id=88715 + +Reviewed by Noam Rosenthal. + +Unskip fast/files/blob-builder-crash.html now that +LEGACY_WEBKIT_BLOB_BUILDER flag is enabled by default +on EFL port. + +* platform/efl/Skipped: + +2012-06-12 Christophe Dumez christophe.du...@intel.com + [GStreamer] http/tests/media/video-buffered-range-contains-currentTime.html is failing https://bugs.webkit.org/show_bug.cgi?id=87575 Modified: trunk/LayoutTests/platform/efl/Skipped (120083 => 120084) --- trunk/LayoutTests/platform/efl/Skipped 2012-06-12 16:28:36 UTC (rev 120083) +++ trunk/LayoutTests/platform/efl/Skipped 2012-06-12 16:32:58 UTC (rev 120084) @@ -829,7 +829,6 @@ fast/events/platform-wheelevent-paging-y-in-scrolling-page.html fast/events/pointer-events-2.html fast/events/remove-target-with-shadow-in-drag.html -fast/files/blob-builder-crash.html fast/forms/001.html fast/forms/float-before-fieldset.html fast/forms/form-element-geometry.html Modified: trunk/Source/cmake/OptionsEfl.cmake (120083 => 120084) --- trunk/Source/cmake/OptionsEfl.cmake 2012-06-12 16:28:36 UTC (rev 120083) +++ trunk/Source/cmake/OptionsEfl.cmake 2012-06-12 16:32:58 UTC (rev 120084) @@ -75,6 +75,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GLIB_SUPPORT ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR ON) +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LEGACY_WEBKIT_BLOB_BUILDER ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API OFF) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETWORK_INFO ON) WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PAGE_VISIBILITY_API ON) Modified: trunk/Source/cmakeconfig.h.cmake (120083 => 120084) --- trunk/Source/cmakeconfig.h.cmake 2012-06-12 16:28:36 UTC (rev 120083) +++ trunk/Source/cmakeconfig.h.cmake 2012-06-12 16:32:58 UTC (rev 120084) @@ -49,6 +49,7 @@ #cmakedefine01 ENABLE_JAVASCRIPT_DEBUGGER #cmakedefine01 ENABLE_JIT #cmakedefine01 ENABLE_LEGACY_NOTIFICATIONS +#cmakedefine01 ENABLE_LEGACY_WEBKIT_BLOB_BUILDER #cmakedefine01 ENABLE_MATHML #cmakedefine01 ENABLE_METER_TAG #cmakedefine01 ENABLE_MICRODATA Modified: trunk/Tools/ChangeLog (120083 => 120084) --- trunk/Tools/ChangeLog 2012-06-12 16:28:36 UTC (rev 120083) +++ trunk/Tools/ChangeLog 2012-06-12 16:32:58 UTC (rev 120084) @@ -1,3 +1,14 @@ +2012-06-12 Christophe Dumez christophe.du...@intel.com + +[EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag +https://bugs.webkit.org/show_bug.cgi?id=88715 + +Reviewed by Noam Rosenthal. + +Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port. + +* Scripts/webkitperl/FeatureList.pm: + 2012-06-12 Csaba Osztrogonác o...@webkit.org [Qt] Fix -Werror for the buildbots Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (120083 => 120084) --- trunk/Tools/Scripts/webkitperl/FeatureList.pm 2012-06-12 16:28:36 UTC (rev 120083) +++
[webkit-changes] [120085] trunk/Source/WebCore
Title: [120085] trunk/Source/WebCore Revision 120085 Author pfeld...@chromium.org Date 2012-06-12 09:44:28 -0700 (Tue, 12 Jun 2012) Log Message Web Inspector: use jsdifflib for revision diff calculation. https://bugs.webkit.org/show_bug.cgi?id=88791 Reviewed by Vsevolod Vlasov. Present diff calculation is incomplete, it does not properly handle the following case: [a, b, c, d, e, f, g, h] = [c, d, e, f, g, h, a, b] We should not be implementing diff by ourselves. I imported jsdifflib from https://github.com/cemerick/jsdifflib. It has BSD license that is compatible with WebKit. * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/RevisionHistoryView.js: (WebInspector.RevisionHistoryTreeElement.prototype.onexpand.step2): (WebInspector.RevisionHistoryTreeElement.prototype.onexpand): (WebInspector.RevisionHistoryTreeElement.prototype._createLine.appendLineNumber): (WebInspector.RevisionHistoryTreeElement.prototype._createLine): * inspector/front-end/WebKit.qrc: * inspector/front-end/externs.js: (difflib.stringAsLines): (difflib.SequenceMatcher): (difflib.SequenceMatcher.prototype.get_opcodes): * inspector/front-end/inspector.html: * inspector/front-end/jsdifflib.js: Added. (difflib.defaultJunkFunction): (difflib.stripLinebreaks): (difflib.stringAsLines): (difflib.__reduce): (difflib.__ntuplecomp): (difflib.__calculate_ratio): (difflib.__dictget): (difflib.SequenceMatcher.this.set_seqs): (difflib.SequenceMatcher.this.set_seq1): (difflib.SequenceMatcher.this.set_seq2): (difflib.SequenceMatcher.this.__chain_b): (difflib.SequenceMatcher.this.find_longest_match): (difflib.SequenceMatcher.this.get_matching_blocks): (difflib.SequenceMatcher.this.get_opcodes): (difflib.SequenceMatcher.this.get_grouped_opcodes): (difflib.SequenceMatcher.this.quick_ratio): (difflib.SequenceMatcher.this.real_quick_ratio): * inspector/front-end/revisionHistory.css: (.revision-history-line-separator .webkit-line-number): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/inspector/front-end/RevisionHistoryView.js trunk/Source/WebCore/inspector/front-end/WebKit.qrc trunk/Source/WebCore/inspector/front-end/externs.js trunk/Source/WebCore/inspector/front-end/inspector.html trunk/Source/WebCore/inspector/front-end/revisionHistory.css Added Paths trunk/Source/WebCore/inspector/front-end/jsdifflib.js Diff Modified: trunk/Source/WebCore/ChangeLog (120084 => 120085) --- trunk/Source/WebCore/ChangeLog 2012-06-12 16:32:58 UTC (rev 120084) +++ trunk/Source/WebCore/ChangeLog 2012-06-12 16:44:28 UTC (rev 120085) @@ -1,3 +1,49 @@ +2012-06-12 Pavel Feldman pfeld...@chromium.org + +Web Inspector: use jsdifflib for revision diff calculation. +https://bugs.webkit.org/show_bug.cgi?id=88791 + +Reviewed by Vsevolod Vlasov. + +Present diff calculation is incomplete, it does not properly handle the following case: +[a, b, c, d, e, f, g, h] = [c, d, e, f, g, h, a, b] +We should not be implementing diff by ourselves. I imported jsdifflib from +https://github.com/cemerick/jsdifflib. It has BSD license that is compatible with WebKit. + +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* inspector/front-end/RevisionHistoryView.js: +(WebInspector.RevisionHistoryTreeElement.prototype.onexpand.step2): +(WebInspector.RevisionHistoryTreeElement.prototype.onexpand): +(WebInspector.RevisionHistoryTreeElement.prototype._createLine.appendLineNumber): +(WebInspector.RevisionHistoryTreeElement.prototype._createLine): +* inspector/front-end/WebKit.qrc: +* inspector/front-end/externs.js: +(difflib.stringAsLines): +(difflib.SequenceMatcher): +(difflib.SequenceMatcher.prototype.get_opcodes): +* inspector/front-end/inspector.html: +* inspector/front-end/jsdifflib.js: Added. +(difflib.defaultJunkFunction): +(difflib.stripLinebreaks): +(difflib.stringAsLines): +(difflib.__reduce): +(difflib.__ntuplecomp): +(difflib.__calculate_ratio): +(difflib.__dictget): +(difflib.SequenceMatcher.this.set_seqs): +(difflib.SequenceMatcher.this.set_seq1): +(difflib.SequenceMatcher.this.set_seq2): +(difflib.SequenceMatcher.this.__chain_b): +(difflib.SequenceMatcher.this.find_longest_match): +(difflib.SequenceMatcher.this.get_matching_blocks): +(difflib.SequenceMatcher.this.get_opcodes): +(difflib.SequenceMatcher.this.get_grouped_opcodes): +(difflib.SequenceMatcher.this.quick_ratio): +(difflib.SequenceMatcher.this.real_quick_ratio): +* inspector/front-end/revisionHistory.css: +(.revision-history-line-separator .webkit-line-number): + 2012-06-12 Christophe Dumez christophe.du...@intel.com [GStreamer]
[webkit-changes] [120086] trunk/Source/WebCore
Title: [120086] trunk/Source/WebCore Revision 120086 Author pfeld...@chromium.org Date 2012-06-12 09:57:12 -0700 (Tue, 12 Jun 2012) Log Message Web Inspector: allow clearing revision history. https://bugs.webkit.org/show_bug.cgi?id=88847 Reviewed by Vsevolod Vlasov. This change also renames Revision history to Local modifications. I intend to list modifications to all files in that view in the subsequent change. * English.lproj/localizedStrings.js: * inspector/front-end/Resource.js: (WebInspector.Resource._clearResourceHistory): * inspector/front-end/RevisionHistoryView.js: (WebInspector.RevisionHistoryView.else.clearHistory): (WebInspector.RevisionHistoryView): (WebInspector.RevisionHistoryView.prototype._revisionAdded): (WebInspector.RevisionHistoryTreeElement): (WebInspector.RevisionHistoryTreeElement.prototype._createLine): (WebInspector.RevisionHistoryTreeElement.prototype.allowRevert): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.appendApplicableItems): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/inspector/front-end/Resource.js trunk/Source/WebCore/inspector/front-end/RevisionHistoryView.js trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js Diff Modified: trunk/Source/WebCore/ChangeLog (120085 => 120086) --- trunk/Source/WebCore/ChangeLog 2012-06-12 16:44:28 UTC (rev 120085) +++ trunk/Source/WebCore/ChangeLog 2012-06-12 16:57:12 UTC (rev 120086) @@ -1,5 +1,28 @@ 2012-06-12 Pavel Feldman pfeld...@chromium.org +Web Inspector: allow clearing revision history. +https://bugs.webkit.org/show_bug.cgi?id=88847 + +Reviewed by Vsevolod Vlasov. + +This change also renames Revision history to Local modifications. +I intend to list modifications to all files in that view in the subsequent change. + +* English.lproj/localizedStrings.js: +* inspector/front-end/Resource.js: +(WebInspector.Resource._clearResourceHistory): +* inspector/front-end/RevisionHistoryView.js: +(WebInspector.RevisionHistoryView.else.clearHistory): +(WebInspector.RevisionHistoryView): +(WebInspector.RevisionHistoryView.prototype._revisionAdded): +(WebInspector.RevisionHistoryTreeElement): +(WebInspector.RevisionHistoryTreeElement.prototype._createLine): +(WebInspector.RevisionHistoryTreeElement.prototype.allowRevert): +* inspector/front-end/ScriptsPanel.js: +(WebInspector.ScriptsPanel.prototype.appendApplicableItems): + +2012-06-12 Pavel Feldman pfeld...@chromium.org + Web Inspector: use jsdifflib for revision diff calculation. https://bugs.webkit.org/show_bug.cgi?id=88791 @@ -44,6 +67,52 @@ * inspector/front-end/revisionHistory.css: (.revision-history-line-separator .webkit-line-number): +2012-06-12 Pavel Feldman pfeld...@chromium.org + +Web Inspector: use jsdifflib for revision diff calculation. +https://bugs.webkit.org/show_bug.cgi?id=88791 + +Reviewed by Vsevolod Vlasov. + +Present diff calculation is incomplete, it does not properly handle the following case: +[a, b, c, d, e, f, g, h] = [c, d, e, f, g, h, a, b] +We should not be implementing diff by ourselves. I imported jsdifflib from +https://github.com/cemerick/jsdifflib. It has BSD license that is compatible with WebKit. + +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* inspector/front-end/RevisionHistoryView.js: +(WebInspector.RevisionHistoryTreeElement.prototype.onexpand.step2): +(WebInspector.RevisionHistoryTreeElement.prototype.onexpand): +(WebInspector.RevisionHistoryTreeElement.prototype._createLine.appendLineNumber): +(WebInspector.RevisionHistoryTreeElement.prototype._createLine): +* inspector/front-end/WebKit.qrc: +* inspector/front-end/externs.js: +(difflib.stringAsLines): +(difflib.SequenceMatcher): +(difflib.SequenceMatcher.prototype.get_opcodes): +* inspector/front-end/inspector.html: +* inspector/front-end/jsdifflib.js: Added. +(difflib.defaultJunkFunction): +(difflib.stripLinebreaks): +(difflib.stringAsLines): +(difflib.__reduce): +(difflib.__ntuplecomp): +(difflib.__calculate_ratio): +(difflib.__dictget): +(difflib.SequenceMatcher.this.set_seqs): +(difflib.SequenceMatcher.this.set_seq1): +(difflib.SequenceMatcher.this.set_seq2): +(difflib.SequenceMatcher.this.__chain_b): +(difflib.SequenceMatcher.this.find_longest_match): +(difflib.SequenceMatcher.this.get_matching_blocks): +(difflib.SequenceMatcher.this.get_opcodes): +(difflib.SequenceMatcher.this.get_grouped_opcodes): +(difflib.SequenceMatcher.this.quick_ratio): +
[webkit-changes] [120087] branches/safari-536-branch/Source/WebKit/mac
Title: [120087] branches/safari-536-branch/Source/WebKit/mac
Revision 120087
Author lforsch...@apple.com
Date 2012-06-12 10:04:07 -0700 (Tue, 12 Jun 2012)
Log Message
Merged r119542 - rdar://problem/11602601
Modified Paths
branches/safari-536-branch/Source/WebKit/mac/ChangeLog
branches/safari-536-branch/Source/WebKit/mac/Misc/WebKitErrors.h
Diff
Modified: branches/safari-536-branch/Source/WebKit/mac/ChangeLog (120086 => 120087)
--- branches/safari-536-branch/Source/WebKit/mac/ChangeLog 2012-06-12 16:57:12 UTC (rev 120086)
+++ branches/safari-536-branch/Source/WebKit/mac/ChangeLog 2012-06-12 17:04:07 UTC (rev 120087)
@@ -1,3 +1,17 @@
+2012-06-12 Lucas Forschler lforsch...@apple.com
+
+Merge 119542
+
+2012-06-05 Anders Carlsson ander...@apple.com
+
+Rename a plug-in loading error constant
+https://bugs.webkit.org/show_bug.cgi?id=88381
+rdar://problem/11602601
+
+Reviewed by Sam Weinig.
+
+* Misc/WebKitErrors.h:
+
2012-06-06 Mark Rowe mr...@apple.com
Merge r119339.
Modified: branches/safari-536-branch/Source/WebKit/mac/Misc/WebKitErrors.h (120086 => 120087)
--- branches/safari-536-branch/Source/WebKit/mac/Misc/WebKitErrors.h 2012-06-12 16:57:12 UTC (rev 120086)
+++ branches/safari-536-branch/Source/WebKit/mac/Misc/WebKitErrors.h 2012-06-12 17:04:07 UTC (rev 120087)
@@ -51,10 +51,11 @@
@constant WebKitErrorCannotFindPlugIn
@constant WebKitErrorCannotLoadPlugIn
@constant WebKitErrorJavaUnavailable
+@constant WebKitErrorBlockedPlugInVersion
*/
enum {
WebKitErrorCannotFindPlugIn = 200,
WebKitErrorCannotLoadPlugIn = 201,
WebKitErrorJavaUnavailable =202,
-WebKitErrorInsecurePlugInVersion = 203,
+WebKitErrorBlockedPlugInVersion = 203,
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120088] branches/safari-536-branch/Source/WebKit/mac
Title: [120088] branches/safari-536-branch/Source/WebKit/mac
Revision 120088
Author lforsch...@apple.com
Date 2012-06-12 10:05:44 -0700 (Tue, 12 Jun 2012)
Log Message
Merged r119543 - rdar://problem/11602601
Modified Paths
branches/safari-536-branch/Source/WebKit/mac/ChangeLog
branches/safari-536-branch/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
Diff
Modified: branches/safari-536-branch/Source/WebKit/mac/ChangeLog (120087 => 120088)
--- branches/safari-536-branch/Source/WebKit/mac/ChangeLog 2012-06-12 17:04:07 UTC (rev 120087)
+++ branches/safari-536-branch/Source/WebKit/mac/ChangeLog 2012-06-12 17:05:44 UTC (rev 120088)
@@ -1,5 +1,17 @@
2012-06-12 Lucas Forschler lforsch...@apple.com
+Merge 119543
+
+2012-06-05 Anders Carlsson ander...@apple.com
+
+Build fix.
+
+* WebCoreSupport/WebFrameLoaderClient.mm:
+(WebFrameLoaderClient::createPlugin):
+The error constant has been renamed.
+
+2012-06-12 Lucas Forschler lforsch...@apple.com
+
Merge 119542
2012-06-05 Anders Carlsson ander...@apple.com
Modified: branches/safari-536-branch/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (120087 => 120088)
--- branches/safari-536-branch/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2012-06-12 17:04:07 UTC (rev 120087)
+++ branches/safari-536-branch/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm 2012-06-12 17:05:44 UTC (rev 120088)
@@ -1686,7 +1686,7 @@
}
#endif
} else {
-errorCode = WebKitErrorInsecurePlugInVersion;
+errorCode = WebKitErrorBlockedPlugInVersion;
if (element-renderer()-isEmbeddedObject())
toRenderEmbeddedObject(element-renderer())-setPluginUnavailabilityReason(RenderEmbeddedObject::InsecurePluginVersion);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120089] branches/safari-536-branch
Title: [120089] branches/safari-536-branch
Revision 120089
Author lforsch...@apple.com
Date 2012-06-12 10:08:25 -0700 (Tue, 12 Jun 2012)
Log Message
Merged r119644 - rdar://problem/11575112
Modified Paths
branches/safari-536-branch/LayoutTests/ChangeLog
branches/safari-536-branch/Source/WebCore/ChangeLog
branches/safari-536-branch/Source/WebCore/loader/DocumentLoader.cpp
Added Paths
branches/safari-536-branch/LayoutTests/fast/loader/resources/utf8-encoded.webarchive
branches/safari-536-branch/LayoutTests/fast/loader/webarchive-encoding-respected-expected.txt
branches/safari-536-branch/LayoutTests/fast/loader/webarchive-encoding-respected.html
Diff
Modified: branches/safari-536-branch/LayoutTests/ChangeLog (120088 => 120089)
--- branches/safari-536-branch/LayoutTests/ChangeLog 2012-06-12 17:05:44 UTC (rev 120088)
+++ branches/safari-536-branch/LayoutTests/ChangeLog 2012-06-12 17:08:25 UTC (rev 120089)
@@ -1,3 +1,18 @@
+2012-06-12 Lucas Forschler lforsch...@apple.com
+
+Merge 119644
+
+2012-06-06 Brady Eidson beid...@apple.com
+
+rdar://problem/11575112 and https://bugs.webkit.org/show_bug.cgi?id=88428
+REGRESSION (r115654): Opening many non-English WebArchives shows obvious encoding issues
+
+Reviewed by Nate Chapin.
+
+* fast/loader/resources/utf8-encoded.webarchive: Added.
+* fast/loader/webarchive-encoding-respected-expected.txt: Added.
+* fast/loader/webarchive-encoding-respected.html: Added.
+
2012-06-06 Mark Rowe mr...@apple.com
Merge r119274.
Copied: branches/safari-536-branch/LayoutTests/fast/loader/resources/utf8-encoded.webarchive (from rev 119644, trunk/LayoutTests/fast/loader/resources/utf8-encoded.webarchive) (0 => 120089)
--- branches/safari-536-branch/LayoutTests/fast/loader/resources/utf8-encoded.webarchive (rev 0)
+++ branches/safari-536-branch/LayoutTests/fast/loader/resources/utf8-encoded.webarchive 2012-06-12 17:08:25 UTC (rev 120089)
@@ -0,0 +1,4 @@
+bplist00\xD1_WebMainResource\xD5
+ _WebResourceMIMEType_WebResourceTextEncodingName_WebResourceFrameName^WebResourceURL_WebResourceDataYtext/htmlUUTF-8P_ http://127.0.0.1:8000/utf-8.cgiOshtmlhead/headbodyThis content is UTF-8 encoded and includes a Hebrew Resh character -gt; ר
+/body/html ( \ s \x82 \x94 \x9E \xA4 \xA5 \xC7
+ =
\ No newline at end of file
Copied: branches/safari-536-branch/LayoutTests/fast/loader/webarchive-encoding-respected-expected.txt (from rev 119644, trunk/LayoutTests/fast/loader/webarchive-encoding-respected-expected.txt) (0 => 120089)
--- branches/safari-536-branch/LayoutTests/fast/loader/webarchive-encoding-respected-expected.txt (rev 0)
+++ branches/safari-536-branch/LayoutTests/fast/loader/webarchive-encoding-respected-expected.txt 2012-06-12 17:08:25 UTC (rev 120089)
@@ -0,0 +1,7 @@
+The webarchive in this iframe is utf-8 encoded and will only display properly if the webarchive's encoding is respected.
+
+
+
+Frame: '!--framePath //!--frame0'
+
+This content is UTF-8 encoded and includes a Hebrew Resh character - ר
Copied: branches/safari-536-branch/LayoutTests/fast/loader/webarchive-encoding-respected.html (from rev 119644, trunk/LayoutTests/fast/loader/webarchive-encoding-respected.html) (0 => 120089)
--- branches/safari-536-branch/LayoutTests/fast/loader/webarchive-encoding-respected.html (rev 0)
+++ branches/safari-536-branch/LayoutTests/fast/loader/webarchive-encoding-respected.html 2012-06-12 17:08:25 UTC (rev 120089)
@@ -0,0 +1,8 @@
+script
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.dumpChildFramesAsText();
+}
+/script
+The webarchive in this iframe is utf-8 encoded and will only display properly if the webarchive's encoding is respected.br
+iframe src=""
Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (120088 => 120089)
--- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-06-12 17:05:44 UTC (rev 120088)
+++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-06-12 17:08:25 UTC (rev 120089)
@@ -1,3 +1,19 @@
+2012-06-12 Lucas Forschler lforsch...@apple.com
+
+Merge 119644
+
+2012-06-06 Brady Eidson beid...@apple.com
+
+rdar://problem/11575112 and https://bugs.webkit.org/show_bug.cgi?id=88428
+REGRESSION (r115654): Opening many non-English WebArchives shows obvious encoding issues
+
+Reviewed by Nate Chapin.
+
+Test: fast/loader/webarchive-encoding-respected.html
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::commitData): Properly set the main resource encoding from the webarchive.
+
2012-06-06 Mark Rowe mr...@apple.com
Merge r119548.
Modified: branches/safari-536-branch/Source/WebCore/loader/DocumentLoader.cpp (120088 => 120089)
---
[webkit-changes] [120090] branches/safari-536-branch
Title: [120090] branches/safari-536-branch
Revision 120090
Author lforsch...@apple.com
Date 2012-06-12 10:11:35 -0700 (Tue, 12 Jun 2012)
Log Message
Merged r119739 - rdar://problem/11616643
Modified Paths
branches/safari-536-branch/LayoutTests/ChangeLog
branches/safari-536-branch/Source/WebCore/ChangeLog
branches/safari-536-branch/Source/WebCore/html/MediaController.cpp
Added Paths
branches/safari-536-branch/LayoutTests/media/media-controller-time-clamp-expected.txt
branches/safari-536-branch/LayoutTests/media/media-controller-time-clamp.html
Diff
Modified: branches/safari-536-branch/LayoutTests/ChangeLog (120089 => 120090)
--- branches/safari-536-branch/LayoutTests/ChangeLog 2012-06-12 17:08:25 UTC (rev 120089)
+++ branches/safari-536-branch/LayoutTests/ChangeLog 2012-06-12 17:11:35 UTC (rev 120090)
@@ -1,5 +1,19 @@
2012-06-12 Lucas Forschler lforsch...@apple.com
+Merge 119739
+
+2012-06-07 Jer Noble jer.no...@apple.com
+
+sometimes all slaved videos don't start playing
+https://bugs.webkit.org/show_bug.cgi?id=88553
+
+Reviewed by Darin Adler.
+
+* media/media-controller-time-clamp-expected.txt: Added.
+* media/media-controller-time-clamp.html: Added.
+
+2012-06-12 Lucas Forschler lforsch...@apple.com
+
Merge 119644
2012-06-06 Brady Eidson beid...@apple.com
Copied: branches/safari-536-branch/LayoutTests/media/media-controller-time-clamp-expected.txt (from rev 119739, trunk/LayoutTests/media/media-controller-time-clamp-expected.txt) (0 => 120090)
--- branches/safari-536-branch/LayoutTests/media/media-controller-time-clamp-expected.txt (rev 0)
+++ branches/safari-536-branch/LayoutTests/media/media-controller-time-clamp-expected.txt 2012-06-12 17:11:35 UTC (rev 120090)
@@ -0,0 +1,9 @@
+RUN(controller = video.controller)
+EVENT(canplaythrough)
+RUN(controller.currentTime = controller.duration - 0.05)
+RUN(video.play())
+RUN(controller.play())
+EVENT(ended)
+EXPECTED (controller.currentTime = controller.duration == 'true') OK
+END OF TEST
+
Copied: branches/safari-536-branch/LayoutTests/media/media-controller-time-clamp.html (from rev 119739, trunk/LayoutTests/media/media-controller-time-clamp.html) (0 => 120090)
--- branches/safari-536-branch/LayoutTests/media/media-controller-time-clamp.html (rev 0)
+++ branches/safari-536-branch/LayoutTests/media/media-controller-time-clamp.html 2012-06-12 17:11:35 UTC (rev 120090)
@@ -0,0 +1,39 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+
+script
+var controller;
+var video;
+
+function start() {
+video = document.getElementById('video');
+run('controller = video.controller');
+controller.addEventListener('canplaythrough', canplaythrough, true);
+var src = "" 'content/test');
+video.src = ""
+}
+
+function canplaythrough() {
+consoleWrite(EVENT(canplaythrough));
+controller.removeEventListener('canplaythrough', canplaythrough, true);
+controller.addEventListener('ended', ended, true);
+// 0.05 is greater than one frame of this 25fps video.
+run('controller.currentTime = controller.duration - 0.05');
+run('video.play()');
+run('controller.play()');
+}
+
+function ended() {
+consoleWrite(EVENT(ended));
+testExpected(controller.currentTime = controller.duration, true);
+endTest();
+}
+/script
+/head
+body _onload_=start()
+video id=video mediaGroup=group controls/video
+/body
+/html
\ No newline at end of file
Modified: branches/safari-536-branch/Source/WebCore/ChangeLog (120089 => 120090)
--- branches/safari-536-branch/Source/WebCore/ChangeLog 2012-06-12 17:08:25 UTC (rev 120089)
+++ branches/safari-536-branch/Source/WebCore/ChangeLog 2012-06-12 17:11:35 UTC (rev 120090)
@@ -1,5 +1,25 @@
2012-06-12 Lucas Forschler lforsch...@apple.com
+Merge 119739
+
+2012-06-07 Jer Noble jer.no...@apple.com
+
+sometimes all slaved videos don't start playing
+https://bugs.webkit.org/show_bug.cgi?id=88553
+
+Reviewed by Darin Adler.
+
+Test: media/media-controller-time-clamp.html
+
+Some PlatformClock classes will occasionally return times 0 and will
+always return times slightly duration() when playback has ended. Clamp
+the value of currentTime() to the specified [0..duration] range.
+
+* html/MediaController.cpp:
+(MediaController::currentTime):
+
+2012-06-12 Lucas Forschler lforsch...@apple.com
+
Merge 119644
2012-06-06 Brady Eidson beid...@apple.com
Modified: branches/safari-536-branch/Source/WebCore/html/MediaController.cpp (120089 => 120090)
---
[webkit-changes] [120091] trunk/Source/WebKit/blackberry
Title: [120091] trunk/Source/WebKit/blackberry
Revision 120091
Author commit-qu...@webkit.org
Date 2012-06-12 10:28:59 -0700 (Tue, 12 Jun 2012)
Log Message
[BlackBerry] Fix crash in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=88808
Patch by Crystal Zhang haizh...@rim.com on 2012-06-12
Reviewed by Antonio Gomes.
m_page is destroyed before InputHandler, so should move the call to destroy popup to chromeDestroyed().
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::chromeDestroyed():
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::~InputHandler):
Modified Paths
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (120090 => 120091)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-12 17:11:35 UTC (rev 120090)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-12 17:28:59 UTC (rev 120091)
@@ -1,3 +1,17 @@
+2012-06-12 Crystal Zhang haizh...@rim.com
+
+[BlackBerry] Fix crash in InputHandler
+https://bugs.webkit.org/show_bug.cgi?id=88808
+
+Reviewed by Antonio Gomes.
+
+m_page is destroyed before InputHandler, so should move the call to destroy popup to chromeDestroyed().
+
+* WebCoreSupport/ChromeClientBlackBerry.cpp:
+(WebCore::ChromeClientBlackBerry::chromeDestroyed():
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::InputHandler::~InputHandler):
+
2012-06-12 Yong Li y...@rim.com
[BlackBerry] Use a safer way to shrink JS memory usage
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (120090 => 120091)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-06-12 17:11:35 UTC (rev 120090)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-06-12 17:28:59 UTC (rev 120091)
@@ -148,6 +148,8 @@
void ChromeClientBlackBerry::chromeDestroyed()
{
+// Destroy popup if we have.
+closePagePopup(0);
delete this;
}
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (120090 => 120091)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-06-12 17:11:35 UTC (rev 120090)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-06-12 17:28:59 UTC (rev 120091)
@@ -125,7 +125,6 @@
InputHandler::~InputHandler()
{
-m_webPage-m_page-chrome()-client()-closePagePopup(0);
}
static BlackBerryInputType convertInputType(const HTMLInputElement* inputElement)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120092] trunk/Source/WebCore
Title: [120092] trunk/Source/WebCore
Revision 120092
Author o...@webkit.org
Date 2012-06-12 10:52:57 -0700 (Tue, 12 Jun 2012)
Log Message
Support !ENABLE(VIDEO) builds with horizontally layed out video controls.
https://bugs.webkit.org/show_bug.cgi?id=1
Patch by Silvia Pfeiffer silvi...@chromium.org on 2012-06-12
Reviewed by Csaba Osztrogonác.
No new tests as this is a regression from WK87835.
* html/shadow/SliderThumbElement.cpp:
(WebCore::hasVerticalAppearance):
Ifdef out video related functionality, since usesVerticalVolumeSlider
does not exist in that case.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120091 => 120092)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 17:28:59 UTC (rev 120091)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 17:52:57 UTC (rev 120092)
@@ -1,3 +1,17 @@
+2012-06-12 Silvia Pfeiffer silvi...@chromium.org
+
+Support !ENABLE(VIDEO) builds with horizontally layed out video controls.
+https://bugs.webkit.org/show_bug.cgi?id=1
+
+Reviewed by Csaba Osztrogonác.
+
+No new tests as this is a regression from WK87835.
+
+* html/shadow/SliderThumbElement.cpp:
+(WebCore::hasVerticalAppearance):
+Ifdef out video related functionality, since usesVerticalVolumeSlider
+does not exist in that case.
+
2012-06-12 Pavel Feldman pfeld...@chromium.org
Web Inspector: allow clearing revision history.
Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (120091 => 120092)
--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2012-06-12 17:28:59 UTC (rev 120091)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2012-06-12 17:52:57 UTC (rev 120092)
@@ -62,10 +62,15 @@
{
ASSERT(input-renderer());
RenderStyle* sliderStyle = input-renderer()-style();
+
+#if ENABLE(VIDEO)
RenderTheme* sliderTheme = input-renderer()-theme();
return sliderStyle-appearance() == SliderVerticalPart
|| (sliderStyle-appearance() == MediaVolumeSliderPart sliderTheme-usesVerticalVolumeSlider());
+#else
+return sliderStyle-appearance() == SliderVerticalPart;
+#endif
}
SliderThumbElement* sliderThumbElementOf(Node* node)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120094] trunk/Source
Title: [120094] trunk/Source
Revision 120094
Author shawnsi...@chromium.org
Date 2012-06-12 11:07:40 -0700 (Tue, 12 Jun 2012)
Log Message
[chromium] Make damage tracking more robust to early exits
https://bugs.webkit.org/show_bug.cgi?id=84803
Reviewed by James Robinson.
Source/WebCore:
All CCDamageTrackerTest unit tests updated;
One new unit test added:
CCDamageTrackerTest.verifyDamageAccumulatesUntilReset
Damage tracking inherently needs to be aware of all changes that
occur for every frame. Before this patch, anyone modifying details
of CCLayerTreeHostImpl and the drawing phases of the compositor
needed to be careful to avoid early exiting once draw is
initiated, otherwise running the risk of damage tracking's state
getting out-of-sync from actual changes. This patch makes the
damage tracker API more asynchronous-like, so that damage will
continue to accumulate until it is explicitly notified that
damaged areas have been drawn. This will allow more freedom in
designing and restructuing drawing code in the compositor, without
worrying as much about damage tracking getting out-of-sync.
* platform/graphics/chromium/cc/CCDamageTracker.h:
(WebCore::CCDamageTracker::didDrawDamagedArea):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
Source/WebKit/chromium:
* tests/CCDamageTrackerTest.cpp:
(WebKitTests::clearDamageForAllSurfaces):
(WebKitTests::TEST_F):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120093 => 120094)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 18:02:56 UTC (rev 120093)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 18:07:40 UTC (rev 120094)
@@ -1,3 +1,33 @@
+2012-06-12 Shawn Singh shawnsi...@chromium.org
+
+[chromium] Make damage tracking more robust to early exits
+https://bugs.webkit.org/show_bug.cgi?id=84803
+
+Reviewed by James Robinson.
+
+All CCDamageTrackerTest unit tests updated;
+One new unit test added:
+ CCDamageTrackerTest.verifyDamageAccumulatesUntilReset
+
+Damage tracking inherently needs to be aware of all changes that
+occur for every frame. Before this patch, anyone modifying details
+of CCLayerTreeHostImpl and the drawing phases of the compositor
+needed to be careful to avoid early exiting once draw is
+initiated, otherwise running the risk of damage tracking's state
+getting out-of-sync from actual changes. This patch makes the
+damage tracker API more asynchronous-like, so that damage will
+continue to accumulate until it is explicitly notified that
+damaged areas have been drawn. This will allow more freedom in
+designing and restructuing drawing code in the compositor, without
+worrying as much about damage tracking getting out-of-sync.
+
+* platform/graphics/chromium/cc/CCDamageTracker.h:
+(WebCore::CCDamageTracker::didDrawDamagedArea):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::drawLayers):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+(CCLayerTreeHostImpl):
+
2012-06-12 Mike West mk...@chromium.org
Make document.documentURI readonly from _javascript_
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp (120093 => 120094)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp 2012-06-12 18:02:56 UTC (rev 120093)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp 2012-06-12 18:07:40 UTC (rev 120094)
@@ -151,20 +151,27 @@
FloatRect damageFromSurfaceMask = trackDamageFromSurfaceMask(targetSurfaceMaskLayer);
FloatRect damageFromLeftoverRects = trackDamageFromLeftoverRects();
+FloatRect damageRectForThisUpdate;
+
if (m_forceFullDamageNextUpdate || targetSurfacePropertyChangedOnlyFromDescendant) {
-m_currentDamageRect = targetSurfaceContentRect;
+damageRectForThisUpdate = targetSurfaceContentRect;
m_forceFullDamageNextUpdate = false;
} else {
// FIXME: can we clamp this damage to the surface's content rect? (affects performance, but not correctness)
-m_currentDamageRect = damageFromActiveLayers;
-m_currentDamageRect.uniteIfNonZero(damageFromSurfaceMask);
-m_currentDamageRect.uniteIfNonZero(damageFromLeftoverRects);
+damageRectForThisUpdate = damageFromActiveLayers;
+damageRectForThisUpdate.uniteIfNonZero(damageFromSurfaceMask);
+
[webkit-changes] [120095] trunk/LayoutTests
Title: [120095] trunk/LayoutTests Revision 120095 Author o...@chromium.org Date 2012-06-12 11:21:32 -0700 (Tue, 12 Jun 2012) Log Message Update some tests to better match actual results on the bots. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120094 => 120095) --- trunk/LayoutTests/ChangeLog 2012-06-12 18:07:40 UTC (rev 120094) +++ trunk/LayoutTests/ChangeLog 2012-06-12 18:21:32 UTC (rev 120095) @@ -1,3 +1,9 @@ +2012-06-12 Ojan Vafai o...@chromium.org + +Update some tests to better match actual results on the bots. + +* platform/chromium/TestExpectations: + 2012-06-12 Mike West mk...@chromium.org Make document.documentURI readonly from _javascript_ Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120094 => 120095) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 18:07:40 UTC (rev 120094) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 18:21:32 UTC (rev 120095) @@ -3568,9 +3568,9 @@ BUGWK85952 : http/tests/media/media-source/video-media-source-play.html = PASS TIMEOUT BUGWK85952 : http/tests/media/media-source/video-media-source-seek.html = PASS TIMEOUT -BUGWK85952 : http/tests/media/media-source/video-media-source-state-changes.html = PASS TIMEOUT TEXT +BUGWK85952 : http/tests/media/media-source/video-media-source-state-changes.html = PASS TIMEOUT TEXT CRASH -BUGWK88798 : http/tests/media/media-source/video-media-source-add-and-remove-ids.html = TEXT +BUGWK88798 : http/tests/media/media-source/video-media-source-add-and-remove-ids.html = TIMEOUT // Started flaking at around http://trac.webkit.org/changeset/116278. BUGWK85950 LINUX DEBUG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = PASS TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120096] trunk
Title: [120096] trunk Revision 120096 Author beid...@apple.com Date 2012-06-12 11:24:27 -0700 (Tue, 12 Jun 2012) Log Message rdar://problem/11593686 and https://bugs.webkit.org/show_bug.cgi?id=88683 Garbage collection of an img element can cause reentrant event dispatch. Reviewed by Darin Adler. Source/WebCore: The most straightforward solution is for ImageLoader to keep its Element alive with ref/deref any time the Image is actually loading. ImageLoader should always do this for all Elements, and if those Elements want/need different behavior for when they are detached then they need to manually stop their loads. Tests: http/tests/loading/embed-image-load-outlives-gc-without-crashing.html http/tests/loading/image-input-type-outlives-gc-without-crashing.html http/tests/loading/image-load-outlives-gc-without-crashing.html http/tests/loading/object-image-load-outlives-gc-without-crashing.html http/tests/loading/svg-image-load-outlives-gc-without-crashing.html http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html * loader/ImageLoader.cpp: (WebCore::ImageLoader::ImageLoader): (WebCore::ImageLoader::~ImageLoader): (WebCore::ImageLoader::setImage): (WebCore::ImageLoader::updateFromElement): (WebCore::ImageLoader::notifyFinished): (WebCore::ImageLoader::updatedHasPendingLoadEvent): (WebCore::ImageLoader::dispatchPendingBeforeLoadEvent): (WebCore::ImageLoader::dispatchPendingLoadEvent): * loader/ImageLoader.h: (ImageLoader): LayoutTests: New tests for all users of ImageLoader: * http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt: Added. * http/tests/loading/embed-image-load-outlives-gc-without-crashing.html: Added. * http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt: Added. * http/tests/loading/image-input-type-outlives-gc-without-crashing.html: Added. * http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt: Added. * http/tests/loading/image-load-outlives-gc-without-crashing.html: Added. * http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt: Added. * http/tests/loading/object-image-load-outlives-gc-without-crashing.html: Added. * http/tests/loading/resources/slowimage.php: Added. * http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt: Added. * http/tests/loading/svg-image-load-outlives-gc-without-crashing.html: Added. * http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt: Added. * http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html: Added. Shared sub resource for all of those tests: * http/tests/loading/resources/slowimage.php: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/ImageLoader.cpp trunk/Source/WebCore/loader/ImageLoader.h Added Paths trunk/LayoutTests/http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/embed-image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/image-input-type-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/object-image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/loading/resources/slowimage.php trunk/LayoutTests/http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/svg-image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html Diff Modified: trunk/LayoutTests/ChangeLog (120095 => 120096) --- trunk/LayoutTests/ChangeLog 2012-06-12 18:21:32 UTC (rev 120095) +++ trunk/LayoutTests/ChangeLog 2012-06-12 18:24:27 UTC (rev 120096) @@ -1,3 +1,28 @@ +2012-06-12 Brady Eidson beid...@apple.com + +rdar://problem/11593686 and https://bugs.webkit.org/show_bug.cgi?id=88683 +Garbage collection of an img element can cause reentrant event dispatch. + +Reviewed by Darin Adler. + +New tests for all users of ImageLoader: +* http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt: Added. +* http/tests/loading/embed-image-load-outlives-gc-without-crashing.html: Added. +* http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt: Added. +* http/tests/loading/image-input-type-outlives-gc-without-crashing.html: Added. +*
[webkit-changes] [120097] trunk/LayoutTests
Title: [120097] trunk/LayoutTests
Revision 120097
Author ann...@chromium.org
Date 2012-06-12 11:52:11 -0700 (Tue, 12 Jun 2012)
Log Message
Separate RemoveID test cases.
https://bugs.webkit.org/show_bug.cgi?id=88798
Reviewed by Eric Carlson.
* http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt:
* http/tests/media/media-source/video-media-source-add-and-remove-ids.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt
trunk/LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids.html
Diff
Modified: trunk/LayoutTests/ChangeLog (120096 => 120097)
--- trunk/LayoutTests/ChangeLog 2012-06-12 18:24:27 UTC (rev 120096)
+++ trunk/LayoutTests/ChangeLog 2012-06-12 18:52:11 UTC (rev 120097)
@@ -1,3 +1,13 @@
+2012-06-12 Anna Cavender ann...@chromium.org
+
+Separate RemoveID test cases.
+https://bugs.webkit.org/show_bug.cgi?id=88798
+
+Reviewed by Eric Carlson.
+
+* http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt:
+* http/tests/media/media-source/video-media-source-add-and-remove-ids.html:
+
2012-06-12 Brady Eidson beid...@apple.com
rdar://problem/11593686 and https://bugs.webkit.org/show_bug.cgi?id=88683
Modified: trunk/LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt (120096 => 120097)
--- trunk/LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt 2012-06-12 18:24:27 UTC (rev 120096)
+++ trunk/LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt 2012-06-12 18:52:11 UTC (rev 120097)
@@ -20,17 +20,35 @@
Test that SourceIDs can't be added while in the ended state.
Got expected exception Error: INVALID_STATE_ERR: DOM Exception 11
-running testRemoveIdFailureCases
+running testRemoveEmptyId
EVENT(loadstart)
EVENT(webkitsourceopen)
Test empty ID case
Got expected exception Error: INVALID_ACCESS_ERR: DOM Exception 15
+
+running testRemoveNonexistentId
+EVENT(loadstart)
+EVENT(webkitsourceopen)
Test removing an ID that was never added.
Got expected exception Error: SYNTAX_ERR: DOM Exception 12
+
+running testRemoveAgain
+EVENT(loadstart)
+EVENT(webkitsourceopen)
+Test removing an ID that was already removed.
Got expected exception Error: SYNTAX_ERR: DOM Exception 12
-Test adding the same ID again.
+
+running testRemoveIdAfterEnded
+EVENT(loadstart)
+EVENT(webkitsourceopen)
Test that an ID can be removed while in the ended state.
+running testAddIdAfterRemoving
+EVENT(loadstart)
+EVENT(webkitsourceopen)
+Test that an ID can be added again after it is removed.
+Unexpected exception: Error: QUOTA_EXCEEDED_ERR: DOM Exception 22
+
running testAppendFailureCases
EVENT(loadstart)
EVENT(webkitsourceopen)
Modified: trunk/LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids.html (120096 => 120097)
--- trunk/LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids.html 2012-06-12 18:24:27 UTC (rev 120096)
+++ trunk/LayoutTests/http/tests/media/media-source/video-media-source-add-and-remove-ids.html 2012-06-12 18:52:11 UTC (rev 120097)
@@ -107,28 +107,57 @@
runNextTestCase();
}
-function testRemoveIdFailureCases(runNextTestCase, videoTag)
+function testRemoveEmptyId(runNextTestCase, videoTag)
{
consoleWrite(Test empty ID case);
expectExceptionOnRemoveId(videoTag, , DOMException.INVALID_ACCESS_ERR);
+runNextTestCase();
+}
+
+function testRemoveNonexistentId(runNextTestCase, videoTag)
+{
consoleWrite(Test removing an ID that was never added.);
expectExceptionOnRemoveId(videoTag, 345, DOMException.SYNTAX_ERR);
+runNextTestCase();
+}
+
+function testRemoveAgain(runNextTestCase, videoTag)
+{
+consoleWrite(Test removing an ID that was already removed.);
videoTag.webkitSourceAddId(123, defaultSourceMimetype);
videoTag.webkitSourceRemoveId(123);
expectExceptionOnRemoveId(videoTag, 123, DOMException.SYNTAX_ERR);
-consoleWrite(Test adding the same ID again.);
-videoTag.webkitSourceAddId(123, defaultSourceMimetype);
+runNextTestCase();
+}
+function testRemoveIdAfterEnded(runNextTestCase, videoTag)
+{
consoleWrite(Test that an ID can be removed while in the ended state.);
+videoTag.webkitSourceAddId(123, defaultSourceMimetype);
videoTag.webkitSourceEndOfStream(videoTag.EOS_NO_ERROR);
videoTag.webkitSourceRemoveId(123);
[webkit-changes] [120098] branches/chromium/1132/Source/WebCore/dom/Document.cpp
Title: [120098] branches/chromium/1132/Source/WebCore/dom/Document.cpp Revision 120098 Author cev...@google.com Date 2012-06-12 11:52:44 -0700 (Tue, 12 Jun 2012) Log Message Merge 119439 BUG=131087 Review URL: https://chromiumcodereview.appspot.com/10537130 Modified Paths branches/chromium/1132/Source/WebCore/dom/Document.cpp Diff Modified: branches/chromium/1132/Source/WebCore/dom/Document.cpp (120097 => 120098) --- branches/chromium/1132/Source/WebCore/dom/Document.cpp 2012-06-12 18:52:11 UTC (rev 120097) +++ branches/chromium/1132/Source/WebCore/dom/Document.cpp 2012-06-12 18:52:44 UTC (rev 120098) @@ -653,6 +653,8 @@ m_fullScreenElementStack.clear(); #endif +detachParser(); + // removeAllChildren() doesn't always unregister IDs, // so tear down scope information upfront to avoid having stale references in the map. destroyTreeScopeData(); @@ -660,8 +662,6 @@ m_markers-detach(); -detachParser(); - m_cssCanvasElements.clear(); #if ENABLE(REQUEST_ANIMATION_FRAME) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120101] branches/chromium/1132
Title: [120101] branches/chromium/1132
Revision 120101
Author cev...@google.com
Date 2012-06-12 12:07:56 -0700 (Tue, 12 Jun 2012)
Log Message
Merge 119914
BUG=121128
Review URL: https://chromiumcodereview.appspot.com/10533113
Modified Paths
branches/chromium/1132/Source/WebCore/rendering/RenderObject.cpp
Added Paths
branches/chromium/1132/LayoutTests/svg/foreignObject/fO-fixed-position-crash-expected.txt
branches/chromium/1132/LayoutTests/svg/foreignObject/fO-fixed-position-crash.html
branches/chromium/1132/LayoutTests/svg/foreignObject/fixed-position-expected.svg
branches/chromium/1132/LayoutTests/svg/foreignObject/fixed-position.svg
Diff
Copied: branches/chromium/1132/LayoutTests/svg/foreignObject/fO-fixed-position-crash-expected.txt (from rev 119914, trunk/LayoutTests/svg/foreignObject/fO-fixed-position-crash-expected.txt) (0 => 120101)
--- branches/chromium/1132/LayoutTests/svg/foreignObject/fO-fixed-position-crash-expected.txt (rev 0)
+++ branches/chromium/1132/LayoutTests/svg/foreignObject/fO-fixed-position-crash-expected.txt 2012-06-12 19:07:56 UTC (rev 120101)
@@ -0,0 +1 @@
+PASS
Copied: branches/chromium/1132/LayoutTests/svg/foreignObject/fO-fixed-position-crash.html (from rev 119914, trunk/LayoutTests/svg/foreignObject/fO-fixed-position-crash.html) (0 => 120101)
--- branches/chromium/1132/LayoutTests/svg/foreignObject/fO-fixed-position-crash.html (rev 0)
+++ branches/chromium/1132/LayoutTests/svg/foreignObject/fO-fixed-position-crash.html 2012-06-12 19:07:56 UTC (rev 120101)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+html
+body
+!-- Test for https://bugs.webkit.org/show_bug.cgi?id=88547 --
+svg xmlns=http://www.w3.org/2000/svg
+ foreignObject
+div id=div style=position:fixed; height:50%; counter-increment:inherit;Passes if replacing this text doesn't cause a crash./div
+ /foreignObject
+
+ script
+window._onload_=function() {
+ document.designMode=on;
+ document.execCommand(SelectAll);
+ document.getElementById('div').innerHTML = PASS;
+};
+
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+ /script
+/svg
+/body
+/html
Copied: branches/chromium/1132/LayoutTests/svg/foreignObject/fixed-position-expected.svg (from rev 119914, trunk/LayoutTests/svg/foreignObject/fixed-position-expected.svg) (0 => 120101)
--- branches/chromium/1132/LayoutTests/svg/foreignObject/fixed-position-expected.svg (rev 0)
+++ branches/chromium/1132/LayoutTests/svg/foreignObject/fixed-position-expected.svg 2012-06-12 19:07:56 UTC (rev 120101)
@@ -0,0 +1,4 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+svg xmlns=http://www.w3.org/2000/svg
+ rect width=100 height=100 fill=green/
+/svg
Copied: branches/chromium/1132/LayoutTests/svg/foreignObject/fixed-position.svg (from rev 119914, trunk/LayoutTests/svg/foreignObject/fixed-position.svg) (0 => 120101)
--- branches/chromium/1132/LayoutTests/svg/foreignObject/fixed-position.svg (rev 0)
+++ branches/chromium/1132/LayoutTests/svg/foreignObject/fixed-position.svg 2012-06-12 19:07:56 UTC (rev 120101)
@@ -0,0 +1,8 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+svg xmlns=http://www.w3.org/2000/svg
+ rect width=98 height=98 fill=red/
+ foreignObject width=200 height=200 transform=translate(-100, 0)
+!-- Fixed-position content should be relative to the foreignObject viewport. --
+div xmlns=http://www.w3.org/1999/xhtml style=position: fixed; left: 100px; width: 100px; height: 50%; background-color: green;/div
+ /foreignObject
+/svg
Modified: branches/chromium/1132/Source/WebCore/rendering/RenderObject.cpp (120100 => 120101)
--- branches/chromium/1132/Source/WebCore/rendering/RenderObject.cpp 2012-06-12 19:06:50 UTC (rev 120100)
+++ branches/chromium/1132/Source/WebCore/rendering/RenderObject.cpp 2012-06-12 19:07:56 UTC (rev 120101)
@@ -710,8 +710,14 @@
{
RenderObject* o = parent();
if (!isText() m_style-position() == FixedPosition) {
-while (o !o-isRenderView() !(o-hasTransform() o-isRenderBlock()))
+while (o !o-isRenderView() !(o-hasTransform() o-isRenderBlock())) {
+#if ENABLE(SVG)
+// foreignObject is the containing block for its contents.
+if (o-isSVGForeignObject())
+break;
+#endif
o = o-parent();
+}
} else if (!isText() m_style-position() == AbsolutePosition) {
while (o (o-style()-position() == StaticPosition || (o-isInline() !o-isReplaced())) !o-isRenderView() !(o-hasTransform() o-isRenderBlock())) {
// For relpositioned inlines, we return the nearest non-anonymous enclosing block. We don't try
@@ -2246,6 +2252,11 @@
while (o o-parent() !(o-hasTransform() o-isRenderBlock())) {
if (repaintContainerSkipped o == repaintContainer)
*repaintContainerSkipped = true;
+#if ENABLE(SVG)
+// foreignObject is the
[webkit-changes] [120102] branches/chromium/1132
Title: [120102] branches/chromium/1132
Revision 120102
Author cev...@google.com
Date 2012-06-12 12:17:26 -0700 (Tue, 12 Jun 2012)
Log Message
Merge 119158
BUG=129191
Review URL: https://chromiumcodereview.appspot.com/10542126
Modified Paths
branches/chromium/1132/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp
branches/chromium/1132/Source/WebCore/dom/Document.cpp
branches/chromium/1132/Source/WebCore/dom/Document.h
Added Paths
branches/chromium/1132/LayoutTests/fast/events/touch/document-create-touch-list-crash-expected.txt
branches/chromium/1132/LayoutTests/fast/events/touch/document-create-touch-list-crash.html
branches/chromium/1132/LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js
Diff
Copied: branches/chromium/1132/LayoutTests/fast/events/touch/document-create-touch-list-crash-expected.txt (from rev 119158, trunk/LayoutTests/fast/events/touch/document-create-touch-list-crash-expected.txt) (0 => 120102)
--- branches/chromium/1132/LayoutTests/fast/events/touch/document-create-touch-list-crash-expected.txt (rev 0)
+++ branches/chromium/1132/LayoutTests/fast/events/touch/document-create-touch-list-crash-expected.txt 2012-06-12 19:17:26 UTC (rev 120102)
@@ -0,0 +1,19 @@
+This test ensures that WebKit doesn't crash when the document.createTouchList API is called with non-Touch parameters
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS document.createTouchList(document).item(0) is null
+PASS document.createTouchList({a:1}).item(0) is null
+PASS document.createTouchList(new Array(5)).item(0) is null
+PASS document.createTouchList(string).item(0) is null
+PASS document.createTouchList(null).item(0) is null
+PASS document.createTouchList(undefined).item(0) is null
+PASS tl.length is 3
+PASS tl.item(0) is non-null.
+PASS tl.item(1) is null
+PASS tl.item(2) is non-null.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: branches/chromium/1132/LayoutTests/fast/events/touch/document-create-touch-list-crash.html (from rev 119158, trunk/LayoutTests/fast/events/touch/document-create-touch-list-crash.html) (0 => 120102)
--- branches/chromium/1132/LayoutTests/fast/events/touch/document-create-touch-list-crash.html (rev 0)
+++ branches/chromium/1132/LayoutTests/fast/events/touch/document-create-touch-list-crash.html 2012-06-12 19:17:26 UTC (rev 120102)
@@ -0,0 +1,16 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+!--
+ Touch tests that involve the ontouchstart, ontouchmove, ontouchend or ontouchcancel callbacks
+ should be written in an asynchronous fashion so they can be run on mobile platforms like Android.
+ You will need to invoke isSuccessfullyParsed() in your test script when the test completes.
+--
+/head
+body
+p id=description/p
+div id=console/div
+script src=""
+/body
+/html
Copied: branches/chromium/1132/LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js (from rev 119158, trunk/LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js) (0 => 120102)
--- branches/chromium/1132/LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js (rev 0)
+++ branches/chromium/1132/LayoutTests/fast/events/touch/script-tests/document-create-touch-list-crash.js 2012-06-12 19:17:26 UTC (rev 120102)
@@ -0,0 +1,19 @@
+description(This test ensures that WebKit doesn't crash when the document.createTouchList API is called with non-Touch parameters);
+
+shouldBeNull('document.createTouchList(document).item(0)');
+shouldBeNull('document.createTouchList({a:1}).item(0)');
+shouldBeNull('document.createTouchList(new Array(5)).item(0)');
+shouldBeNull('document.createTouchList(string).item(0)');
+shouldBeNull('document.createTouchList(null).item(0)');
+shouldBeNull('document.createTouchList(undefined).item(0)');
+
+var t = document.createTouch(window, document.body, 12341, 60, 65, 100, 105);
+var t2 = document.createTouch(window, document.body, 12342, 50, 55, 115, 120);
+var tl = document.createTouchList(t, document, t2);
+
+shouldBe('tl.length', '3');
+shouldBeNonNull('tl.item(0)');
+shouldBeNull('tl.item(1)');
+shouldBeNonNull('tl.item(2)');
+
+isSuccessfullyParsed();
Modified: branches/chromium/1132/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp (120101 => 120102)
--- branches/chromium/1132/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp 2012-06-12 19:07:56 UTC (rev 120101)
+++ branches/chromium/1132/Source/WebCore/bindings/v8/custom/V8DocumentCustom.cpp 2012-06-12 19:17:26 UTC (rev 120102)
@@ -43,6 +43,7 @@
#include V8CanvasRenderingContext2D.h
#include V8CustomXPathNSResolver.h
#include V8DOMImplementation.h
+#include V8DOMWrapper.h
#include V8HTMLDocument.h
#include V8IsolatedContext.h
#include V8Node.h
@@ -142,9 +143,8 @@
RefPtrTouchList touchList = TouchList::create();
for (int i = 0; i args.Length(); i++) {
[webkit-changes] [120103] trunk/Source
Title: [120103] trunk/Source
Revision 120103
Author commit-qu...@webkit.org
Date 2012-06-12 12:17:54 -0700 (Tue, 12 Jun 2012)
Log Message
[chromium] Don't crash in CCLayerIterator if the root layer doesn't have a render surface
https://bugs.webkit.org/show_bug.cgi?id=6
Patch by Sami Kyostila skyos...@chromium.org on 2012-06-12
Reviewed by James Robinson.
If we are iterating over a render render surface layer list where the
root layer does not have a render surface, fail gracefully instead of
crashing.
Tests: CCLayerIteratorTest.{emptyTree,rootLayerWithoutRenderSurface}
* platform/graphics/chromium/cc/CCLayerIterator.h:
(WebCore::CCLayerIterator::CCLayerIterator):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerIterator.h
trunk/Source/WebKit/chromium/tests/CCLayerIteratorTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120102 => 120103)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 19:17:26 UTC (rev 120102)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 19:17:54 UTC (rev 120103)
@@ -1,3 +1,19 @@
+2012-06-12 Sami Kyostila skyos...@chromium.org
+
+[chromium] Don't crash in CCLayerIterator if the root layer doesn't have a render surface
+https://bugs.webkit.org/show_bug.cgi?id=6
+
+Reviewed by James Robinson.
+
+If we are iterating over a render render surface layer list where the
+root layer does not have a render surface, fail gracefully instead of
+crashing.
+
+Tests: CCLayerIteratorTest.{emptyTree,rootLayerWithoutRenderSurface}
+
+* platform/graphics/chromium/cc/CCLayerIterator.h:
+(WebCore::CCLayerIterator::CCLayerIterator):
+
2012-06-06 Ojan Vafai o...@chromium.org
Change default for flex-grow back to 0
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerIterator.h (120102 => 120103)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerIterator.h 2012-06-12 19:17:26 UTC (rev 120102)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerIterator.h 2012-06-12 19:17:54 UTC (rev 120103)
@@ -143,8 +143,9 @@
private:
CCLayerIterator(const LayerList* renderSurfaceLayerList, bool start)
: m_renderSurfaceLayerList(renderSurfaceLayerList)
+, m_targetRenderSurfaceLayerIndex(0)
{
-if (start !renderSurfaceLayerList-isEmpty())
+if (start !renderSurfaceLayerList-isEmpty() targetRenderSurface())
m_actions.begin(*this);
else
m_actions.end(*this);
Modified: trunk/Source/WebKit/chromium/tests/CCLayerIteratorTest.cpp (120102 => 120103)
--- trunk/Source/WebKit/chromium/tests/CCLayerIteratorTest.cpp 2012-06-12 19:17:26 UTC (rev 120102)
+++ trunk/Source/WebKit/chromium/tests/CCLayerIteratorTest.cpp 2012-06-12 19:17:54 UTC (rev 120103)
@@ -82,6 +82,8 @@
renderSurfaceLayer-m_countRepresentingContributingSurface = -1;
renderSurfaceLayer-m_countRepresentingItself = -1;
+if (!renderSurface)
+continue;
for (unsigned layerIndex = 0; layerIndex renderSurface-layerList().size(); ++layerIndex) {
TestLayerChromium* layer = static_castTestLayerChromium*(renderSurface-layerList()[layerIndex].get());
@@ -122,6 +124,14 @@
}
}
+TEST(CCLayerIteratorTest, emptyTree)
+{
+VectorRefPtrLayerChromium renderSurfaceLayerList;
+
+iterateBackToFront(renderSurfaceLayerList);
+iterateFrontToBack(renderSurfaceLayerList);
+}
+
TEST(CCLayerIteratorTest, simpleTree)
{
RefPtrTestLayerChromium rootLayer = TestLayerChromium::create();
@@ -277,4 +287,17 @@
EXPECT_COUNT(root3, -1, -1, 0);
}
+TEST(CCLayerIteratorTest, rootLayerWithoutRenderSurface)
+{
+RefPtrTestLayerChromium rootLayer = TestLayerChromium::create();
+VectorRefPtrLayerChromium renderSurfaceLayerList;
+renderSurfaceLayerList.append(rootLayer.get());
+
+iterateBackToFront(renderSurfaceLayerList);
+EXPECT_COUNT(rootLayer, -1, -1, -1);
+
+iterateFrontToBack(renderSurfaceLayerList);
+EXPECT_COUNT(rootLayer, -1, -1, -1);
+}
+
} // namespace
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120104] trunk/LayoutTests
Title: [120104] trunk/LayoutTests Revision 120104 Author zandober...@gmail.com Date 2012-06-12 12:47:59 -0700 (Tue, 12 Jun 2012) Log Message Unreviewed GTK gardening after r120099, fix two incorrect text expectations. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120103 => 120104) --- trunk/LayoutTests/ChangeLog 2012-06-12 19:17:54 UTC (rev 120103) +++ trunk/LayoutTests/ChangeLog 2012-06-12 19:47:59 UTC (rev 120104) @@ -1,3 +1,9 @@ +2012-06-12 Zan Dobersek zandober...@gmail.com + +Unreviewed GTK gardening after r120099, fix two incorrect text expectations. + +* platform/gtk/TestExpectations: + 2012-06-06 Ojan Vafai o...@chromium.org Change default for flex-grow back to 0 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120103 => 120104) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 19:17:54 UTC (rev 120103) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-06-12 19:47:59 UTC (rev 120104) @@ -304,7 +304,7 @@ BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE // These tests require subpixel layout to be enabled -BUGWK85532 : fast/sub-pixel = TEXT +BUGWK85532 : fast/sub-pixel = TEXT IMAGE BUGWK85532 : fast/sub-pixel/float-containing-block-with-margin.html = PASS BUGWK85532 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS BUGWK85532 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS @@ -1055,7 +1055,7 @@ BUGWK61630 : fast/events/dropzone-005.html = TEXT // This test verifies that a mismatch reftest will fail as intended if both results are same. -BUGWKGTK : fast/harness/sample-fail-mismatch-reftest.html = TEXT +BUGWKGTK : fast/harness/sample-fail-mismatch-reftest.html = IMAGE // Need layoutTestController.setShouldStayOnPageAfterHandlingBeforeUnload BUGWK67014 : fast/loader/form-submission-after-beforeunload-cancel.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120105] trunk/Source/WebKit/chromium
Title: [120105] trunk/Source/WebKit/chromium
Revision 120105
Author e...@google.com
Date 2012-06-12 12:55:29 -0700 (Tue, 12 Jun 2012)
Log Message
[chromium] Fix incorrect LayerChromium scroll position for RTL overflow pages
https://bugs.webkit.org/show_bug.cgi?id=7
Reviewed by James Robinson.
The scroll position on layers needs to take into account the scroll
origin, since RTL pages start scrolled all the way to the right.
Otherwise, when scrolling left the scroll position incorrectly will go
negative, causing havok in scrollbar theme code that just assumes that
it's always scrolled all the way to the left.
Also, now that the scroll origin is passed into NCCH, handle
scrollOrigin.y() for layer adjusting. This is always zero in practice,
but it seemed awkward to just drop it and that assumption could always
change in the future.
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::paintContents):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateLayerTreeViewport):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp
trunk/Source/WebKit/chromium/src/NonCompositedContentHost.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120104 => 120105)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-12 19:47:59 UTC (rev 120104)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-12 19:55:29 UTC (rev 120105)
@@ -1,3 +1,29 @@
+2012-06-12 Adrienne Walker e...@google.com
+
+[chromium] Fix incorrect LayerChromium scroll position for RTL overflow pages
+https://bugs.webkit.org/show_bug.cgi?id=7
+
+Reviewed by James Robinson.
+
+The scroll position on layers needs to take into account the scroll
+origin, since RTL pages start scrolled all the way to the right.
+Otherwise, when scrolling left the scroll position incorrectly will go
+negative, causing havok in scrollbar theme code that just assumes that
+it's always scrolled all the way to the left.
+
+Also, now that the scroll origin is passed into NCCH, handle
+scrollOrigin.y() for layer adjusting. This is always zero in practice,
+but it seemed awkward to just drop it and that assumption could always
+change in the future.
+
+* src/NonCompositedContentHost.cpp:
+(WebKit::NonCompositedContentHost::setViewport):
+(WebKit::NonCompositedContentHost::paintContents):
+* src/NonCompositedContentHost.h:
+(NonCompositedContentHost):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::updateLayerTreeViewport):
+
2012-06-12 Shawn Singh shawnsi...@chromium.org
[chromium] Make damage tracking more robust to early exits
Modified: trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp (120104 => 120105)
--- trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp 2012-06-12 19:47:59 UTC (rev 120104)
+++ trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp 2012-06-12 19:55:29 UTC (rev 120105)
@@ -98,7 +98,7 @@
layer-setAlwaysReserveTextures(true);
}
-void NonCompositedContentHost::setViewport(const WebCore::IntSize viewportSize, const WebCore::IntSize contentsSize, const WebCore::IntPoint scrollPosition, float deviceScale, int layerAdjustX)
+void NonCompositedContentHost::setViewport(const WebCore::IntSize viewportSize, const WebCore::IntSize contentsSize, const WebCore::IntPoint scrollPosition, const WebCore::IntPoint scrollOrigin, float deviceScale)
{
if (!scrollLayer())
return;
@@ -106,7 +106,8 @@
bool visibleRectChanged = m_viewportSize != viewportSize;
m_viewportSize = viewportSize;
-scrollLayer()-setScrollPosition(scrollPosition);
+
+scrollLayer()-setScrollPosition(scrollPosition + toSize(scrollOrigin));
scrollLayer()-setPosition(-scrollPosition);
// Due to the possibility of pinch zoom, the noncomposited layer is always
// assumed to be scrollable.
@@ -115,10 +116,14 @@
m_graphicsLayer-deviceOrPageScaleFactorChanged();
m_graphicsLayer-setSize(contentsSize);
-m_layerAdjustX = layerAdjustX;
-if (m_graphicsLayer-transform().m41() != m_layerAdjustX) {
+// In RTL-style pages, the origin of the initial containing block for the
+// root layer may be positive; translate the layer to avoid negative
+// coordinates.
+m_layerAdjust = -toSize(scrollOrigin);
+if (m_graphicsLayer-transform().m41() != m_layerAdjust.width() || m_graphicsLayer-transform().m42() != m_layerAdjust.height()) {
WebCore::TransformationMatrix transform = m_graphicsLayer-transform();
-transform.setM41(m_layerAdjustX);
+transform.setM41(m_layerAdjust.width());
+transform.setM42(m_layerAdjust.height());
[webkit-changes] [120106] trunk/LayoutTests
Title: [120106] trunk/LayoutTests Revision 120106 Author o...@chromium.org Date 2012-06-12 13:01:59 -0700 (Tue, 12 Jun 2012) Log Message Update more expectations to match the state of the bots. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120105 => 120106) --- trunk/LayoutTests/ChangeLog 2012-06-12 19:55:29 UTC (rev 120105) +++ trunk/LayoutTests/ChangeLog 2012-06-12 20:01:59 UTC (rev 120106) @@ -1,3 +1,8 @@ +2012-06-12 Ojan Vafai o...@chromium.org + +Update more expectations to match the state of the bots. +* platform/chromium/TestExpectations: + 2012-06-12 Zan Dobersek zandober...@gmail.com Unreviewed GTK gardening after r120099, fix two incorrect text expectations. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120105 => 120106) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 19:55:29 UTC (rev 120105) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-12 20:01:59 UTC (rev 120106) @@ -2940,6 +2940,7 @@ BUGWK72039 LINUX RELEASE : fast/forms/form-attribute-elements-order2.html = MISSING PASS BUGWK72039 LINUX RELEASE : fast/forms/form-attribute-nonexistence-form-id.html = MISSING PASS BUGWK72039 DEBUG : http/tests/multipart/policy-ignore-crash.php = MISSING PASS +BUGWK72039 MAC : http/tests/loading/empty-subframe.html = MISSING PASS BUGWK78620 : fast/forms/formaction-attribute.html = MISSING PASS BUGWK78620 LINUX : fast/forms/formmethod-attribute-button-html.html = MISSING PASS BUGWK78620 LINUX : fast/forms/formmethod-attribute-input-html.html = MISSING PASS @@ -3706,6 +3707,8 @@ BUGLEVIW LEOPARD LION WIN LINUX : fast/multicol/vertical-lr/nested-columns.html = PASS FAIL BUGLEVIW LEOPARD LION WIN LINUX : fast/multicol/vertical-rl/nested-columns.html = PASS FAIL +BUGWK88900 MAC : http/tests/loading/embed-image-load-outlives-gc-without-crashing.html = TEXT + BUGCR131187 : canvas/philip/tests/2d.gradient.radial.cone.cylinder.html = TEXT BUGCR131187 : fast/canvas/canvas-currentColor.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120107] trunk/LayoutTests
Title: [120107] trunk/LayoutTests Revision 120107 Author commit-qu...@webkit.org Date 2012-06-12 13:09:22 -0700 (Tue, 12 Jun 2012) Log Message LayoutTests/http/tests/xmlhttprequest/origin-exact-matching.html is giving trouble due to too many redirects https://bugs.webkit.org/show_bug.cgi?id=88896 Patch by Pablo Flouret pab...@motorola.com on 2012-06-12 Reviewed by Darin Adler. The test was giving out too many redirect errors on GTK and EFL due to using redirect-cors.php without an actual url to redirect. Redirects are not actually tested in that test, a script that set the Access-Control-Allow-Origin header to an arbitrary origin was needed and redirect-cors.php was the only existing one that had the capability. The infinite redirect thing was an unintended consequence. Use resources/access-control-allow-lists.php to set the header instead. * http/tests/xmlhttprequest/origin-exact-matching-expected.txt: * http/tests/xmlhttprequest/resources/origin-exact-matching-iframe.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching-expected.txt trunk/LayoutTests/http/tests/xmlhttprequest/resources/origin-exact-matching-iframe.html Diff Modified: trunk/LayoutTests/ChangeLog (120106 => 120107) --- trunk/LayoutTests/ChangeLog 2012-06-12 20:01:59 UTC (rev 120106) +++ trunk/LayoutTests/ChangeLog 2012-06-12 20:09:22 UTC (rev 120107) @@ -1,3 +1,22 @@ +2012-06-12 Pablo Flouret pab...@motorola.com + +LayoutTests/http/tests/xmlhttprequest/origin-exact-matching.html is giving trouble due to too many redirects +https://bugs.webkit.org/show_bug.cgi?id=88896 + +Reviewed by Darin Adler. + +The test was giving out too many redirect errors on GTK and EFL due to +using redirect-cors.php without an actual url to redirect. + +Redirects are not actually tested in that test, a script that set the +Access-Control-Allow-Origin header to an arbitrary origin was needed and +redirect-cors.php was the only existing one that had the capability. The +infinite redirect thing was an unintended consequence. +Use resources/access-control-allow-lists.php to set the header instead. + +* http/tests/xmlhttprequest/origin-exact-matching-expected.txt: +* http/tests/xmlhttprequest/resources/origin-exact-matching-iframe.html: + 2012-06-12 Ojan Vafai o...@chromium.org Update more expectations to match the state of the bots. Modified: trunk/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching-expected.txt (120106 => 120107) --- trunk/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching-expected.txt 2012-06-12 20:01:59 UTC (rev 120106) +++ trunk/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching-expected.txt 2012-06-12 20:09:22 UTC (rev 120107) @@ -1,38 +1,38 @@ -CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8000/xmlhttprequest/resources/redirect-cors.php?access-control-allow-origin=http%3A%2F%2Fwww2.localhost%3A8000. Origin http://localhost:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8000/xmlhttprequest/resources/redirect-cors.php?access-control-allow-origin=%2F%2Flocalhost%3A8000. Origin http://localhost:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8000/xmlhttprequest/resources/redirect-cors.php?access-control-allow-origin=%3A%2F%2Flocalhost%3A8000. Origin http://localhost:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8000/xmlhttprequest/resources/redirect-cors.php?access-control-allow-origin=ftp%3A%2F%2Flocalhost%3A8000. Origin http://localhost:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8000/xmlhttprequest/resources/redirect-cors.php?access-control-allow-origin=http%3A%3A%2F%2Flocalhost%3A8000. Origin http://localhost:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8000/xmlhttprequest/resources/redirect-cors.php?access-control-allow-origin=http%3A%2Flocalhost%3A8000. Origin http://localhost:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8000/xmlhttprequest/resources/redirect-cors.php?access-control-allow-origin=http%3Alocalhost%3A8000. Origin http://localhost:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8000/xmlhttprequest/resources/redirect-cors.php?access-control-allow-origin=localhost%3A8000. Origin http://localhost:8000 is not allowed by Access-Control-Allow-Origin. -CONSOLE MESSAGE: XMLHttpRequest cannot load http://127.0.0.1:8000/xmlhttprequest/resources/redirect-cors.php?access-control-allow-origin=http%3A%2F%2Flocalhost%3A8000%3F. Origin
[webkit-changes] [120108] trunk
Title: [120108] trunk Revision 120108 Author commit-qu...@webkit.org Date 2012-06-12 13:20:57 -0700 (Tue, 12 Jun 2012) Log Message HTML parser should yield more to improve perceived page load time https://bugs.webkit.org/show_bug.cgi?id=86165 Source/WebCore: Patch by Shrey Banga ba...@chromium.org on 2012-06-12 Reviewed by Tony Gentilcore. Test: fast/events/event-yield-timing.html We want the parser to yield at least every 500ms to keep the page somewhat responsive and allow painting. Since it would be too expensive to check the time after each token, the previous heuristic was to check every 4,096 tokens. That works fine for most tokens, but a script may spend an arbitrary amount of time executing. This patch fixes the issue by causing the parser to check the elapsed time immediately after executing a script. * html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): * html/parser/HTMLParserScheduler.h: (WebCore::PumpSession::PumpSession): (PumpSession): (WebCore::HTMLParserScheduler::checkForYieldBeforeToken): LayoutTests: Added test for parser yield times after seeing a script Patch by Shrey Banga ba...@chromium.org on 2012-06-12 Reviewed by Tony Gentilcore. * fast/parser/parser-yield-timing-expected.txt: Added. * fast/parser/parser-yield-timing.html: Added. * http/tests/loading/gmail-assert-on-load-expected.txt: The test was added for an assert that failed on debug builds when an iframe removed itself from its parent window after blocking for 1 second. In previous builds, the destroyIt() function was called without yielding to the event loop, which lead to didFailLoadWithError being called. The fix for bug 86165 ensures that we yield after executing the script, which leads to didHandleOnloadEventsForFrame being called instead. This is the cause of the change in output of the test. The test still successfully removes the iframe and since no asserts fail in the debug build, we should consider it as passing. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/loading/gmail-assert-on-load-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/parser/HTMLParserScheduler.cpp trunk/Source/WebCore/html/parser/HTMLParserScheduler.h Added Paths trunk/LayoutTests/fast/parser/parser-yield-timing-expected.txt trunk/LayoutTests/fast/parser/parser-yield-timing.html Diff Modified: trunk/LayoutTests/ChangeLog (120107 => 120108) --- trunk/LayoutTests/ChangeLog 2012-06-12 20:09:22 UTC (rev 120107) +++ trunk/LayoutTests/ChangeLog 2012-06-12 20:20:57 UTC (rev 120108) @@ -1,3 +1,26 @@ +2012-06-12 Shrey Banga ba...@chromium.org + +HTML parser should yield more to improve perceived page load time +https://bugs.webkit.org/show_bug.cgi?id=86165 + +Added test for parser yield times after seeing a script + +Reviewed by Tony Gentilcore. + +* fast/parser/parser-yield-timing-expected.txt: Added. +* fast/parser/parser-yield-timing.html: Added. +* http/tests/loading/gmail-assert-on-load-expected.txt: The test was added +for an assert that failed on debug builds when an iframe removed itself +from its parent window after blocking for 1 second. In previous builds, +the destroyIt() function was called without yielding to the event loop, +which lead to didFailLoadWithError being called. The fix for bug 86165 +ensures that we yield after executing the script, which leads to +didHandleOnloadEventsForFrame being called instead. This is the cause +of the change in output of the test. The test still successfully removes +the iframe and since no asserts fail in the debug build, we should consider +it as passing. + + 2012-06-12 Pablo Flouret pab...@motorola.com LayoutTests/http/tests/xmlhttprequest/origin-exact-matching.html is giving trouble due to too many redirects Added: trunk/LayoutTests/fast/parser/parser-yield-timing-expected.txt (0 => 120108) --- trunk/LayoutTests/fast/parser/parser-yield-timing-expected.txt (rev 0) +++ trunk/LayoutTests/fast/parser/parser-yield-timing-expected.txt 2012-06-12 20:20:57 UTC (rev 120108) @@ -0,0 +1,12 @@ +Runs 3 separate 1 second script blocks with a setTimeout schedule before each. The execution time of the setTimeout is when the HTML yielded to the event loop. The yields also represent painting opportunities. We want the parser to yield every 0.5 seconds once it has seen a script. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS new Date().getTime() - startTime is within 100 of 1000 +PASS new Date().getTime() - startTime is within 100 of 2000 +PASS new Date().getTime() - startTime is within 100 of 3000 +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/parser/parser-yield-timing.html (0 => 120108) --- trunk/LayoutTests/fast/parser/parser-yield-timing.html
[webkit-changes] [120109] trunk/Tools
Title: [120109] trunk/Tools
Revision 120109
Author lforsch...@apple.com
Date 2012-06-12 13:21:15 -0700 (Tue, 12 Jun 2012)
Log Message
Rename Apple bots to a standard convention.
https://bugs.webkit.org/show_bug.cgi?id=88893
Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
Reviewed by Simon Fraser.
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (120108 => 120109)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-06-12 20:20:57 UTC (rev 120108)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-06-12 20:21:15 UTC (rev 120109)
@@ -66,70 +66,70 @@
{ name: hfreyther-sh4-linux1, platform: qt}
],
-builders: [ { name: SnowLeopard Intel Release (Build), type: Build, builddir: snowleopard-intel-release,
+builders: [ { name: Apple SnowLeopard Release Build, type: Build, builddir: snowleopard-release,
platform: mac-snowleopard, configuration: release, architectures: [x86_64],
- slavenames: [apple-xserve-4, test-slave]
+ slavenames: [apple-xserve-4]
},
-{ name: SnowLeopard Intel Debug (Build), type: Build, builddir: snowleopard-intel-debug,
+{ name: Apple SnowLeopard Debug Build, type: Build, builddir: snowleopard-debug,
platform: mac-snowleopard, configuration: debug, architectures: [x86_64],
slavenames: [apple-xserve-9]
},
-{ name: Lion Leaks, type: BuildAndTestLeaks, builddir: lion-intel-leaks,
+{ name: Apple Lion Leaks, type: BuildAndTestLeaks, builddir: lion-leaks,
platform: mac-lion, configuration: debug, architectures: [x86_64],
slavenames: [apple-macpro-3]
},
-{ name: Lion Debug (Build), type: Build, builddir: lion-intel-debug,
+{ name: Apple Lion Debug Build, type: Build, builddir: lion-debug,
platform: mac-lion, configuration: debug, architectures: [x86_64],
- triggers: [lion-intel-debug-tests, lion-intel-debug-tests-wk2],
+ triggers: [lion-debug-tests-wk1, lion-debug-tests-wk2],
slavenames: [apple-xserve-2, apple-xserve-10]
},
-{ name: Lion Release (Build), type: Build, builddir: lion-intel-release,
+{ name: Apple Lion Release Build, type: Build, builddir: lion-release,
platform: mac-lion, configuration: release, architectures: [x86_64],
- triggers: [lion-intel-release-tests, lion-intel-release-tests-wk2, lion-intel-release-perf],
+ triggers: [lion-release-tests-wk1, lion-release-tests-wk2, lion-release-perf],
slavenames: [apple-xserve-3]
},
-{ name: Lion Debug (Tests), type: Test, builddir: lion-intel-debug-tests,
+{ name: Apple Lion Debug WK1 Tests, type: Test, builddir: lion-debug-tests-wk1,
platform: mac-lion, configuration: debug, architectures: [x86_64],
slavenames: [apple-macpro-4]
},
-{ name: Lion Debug (WebKit2 Tests), type: TestWebKit2, builddir: lion-intel-debug-tests-wk2,
+{ name: Apple Lion Debug WK2 Tests, type: TestWebKit2, builddir: lion-debug-tests-wk2,
platform: mac-lion, configuration: debug, architectures: [x86_64],
slavenames: [apple-macpro-8, apple-xserve-1]
},
-{ name: Lion Release (Tests), type: Test, builddir: lion-intel-release-tests,
+{ name: Apple Lion Release WK1 Tests, type: Test, builddir: lion-release-tests-wk1,
platform: mac-lion, configuration: release, architectures: [x86_64],
slavenames: [apple-macpro-5]
},
-{ name: Lion Release (WebKit2 Tests), type: TestWebKit2, builddir: lion-intel-release-tests-wk2,
+{ name: Apple Lion Release WK2 Tests, type: TestWebKit2, builddir: lion-release-tests-wk2,
platform: mac-lion, configuration: release, architectures: [x86_64],
slavenames: [apple-macpro-6]
},
{
- name: Lion Release (Perf), type: DownloadAndPerfTest, builddir: lion-release-perf-tests,
+ name: Apple Lion Release Perf, type: DownloadAndPerfTest,
[webkit-changes] [120110] trunk/Tools
Title: [120110] trunk/Tools Revision 120110 Author dan...@chromium.org Date 2012-06-12 13:27:48 -0700 (Tue, 12 Jun 2012) Log Message Add zlie...@chromium.org to contributors list https://bugs.webkit.org/show_bug.cgi?id=88904 Unreviewed. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (120109 => 120110) --- trunk/Tools/ChangeLog 2012-06-12 20:21:15 UTC (rev 120109) +++ trunk/Tools/ChangeLog 2012-06-12 20:27:48 UTC (rev 120110) @@ -1,3 +1,12 @@ +2012-06-12 Dana Jansens dan...@chromium.org + +Add zlie...@chromium.org to contributors list +https://bugs.webkit.org/show_bug.cgi?id=88904 + +Unreviewed. + +* Scripts/webkitpy/common/config/committers.py: + 2012-06-12 Lucas Forschler lforsch...@apple.com Rename Apple bots to a standard convention. Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (120109 => 120110) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-06-12 20:21:15 UTC (rev 120109) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-06-12 20:27:48 UTC (rev 120110) @@ -160,6 +160,7 @@ Contributor(Tom Hudson, tomhud...@google.com), Contributor(WebKit Review Bot, webkit.review@gmail.com, sheriff-bot), Contributor(Wyatt Carss, [wca...@chromium.org, wca...@google.com], wcarss), +Contributor(Zeev Lieber, zlie...@chromium.org), Contributor(Zoltan Arvai, zar...@inf.u-szeged.hu, azbest_hu), Contributor(Zsolt Feher, fehe...@inf.u-szeged.hu, Smith), ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120112] trunk
Title: [120112] trunk
Revision 120112
Author commit-qu...@webkit.org
Date 2012-06-12 13:37:16 -0700 (Tue, 12 Jun 2012)
Log Message
Disable autoplay when user gesture is required for media playback
https://bugs.webkit.org/show_bug.cgi?id=88897
Patch by Min Qin qin...@google.com on 2012-06-12
Reviewed by Adam Barth.
When user gesture is required for media playback, we should block autoplay.
Otherwise, people will use autoplay instead of video.play() to bypass the gesture requirement.
Test: media/no-autoplay-with-user-gesture-requirement.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Added Paths
trunk/LayoutTests/media/no-autoplay-with-user-gesture-requirement-expected.txt
trunk/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html
Diff
Added: trunk/LayoutTests/media/no-autoplay-with-user-gesture-requirement-expected.txt (0 => 120112)
--- trunk/LayoutTests/media/no-autoplay-with-user-gesture-requirement-expected.txt (rev 0)
+++ trunk/LayoutTests/media/no-autoplay-with-user-gesture-requirement-expected.txt 2012-06-12 20:37:16 UTC (rev 120112)
@@ -0,0 +1,7 @@
+Test that media autoplay should not work if user gesture is required for playback.
+
+EXPECTED (video.paused == 'true') OK
+EVENT(canplaythrough)
+EXPECTED (video.paused == 'true') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html (0 => 120112)
--- trunk/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html (rev 0)
+++ trunk/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html 2012-06-12 20:37:16 UTC (rev 120112)
@@ -0,0 +1,48 @@
+html
+head
+titleTest that media autoplay should not work if user gesture is required for playback/title
+script src=""
+script src=""
+script
+if (window.internals)
+window.internals.settings.setMediaPlaybackRequiresUserGesture(true);
+
+function cleanGestureRequirement() {
+if (window.internals)
+window.internals.settings.setMediaPlaybackRequiresUserGesture(false);
+}
+
+function testPlay()
+{
+cleanGestureRequirement();
+failTest(play event should not fire without user gesture.);
+}
+
+function testPaused()
+{
+testExpected(video.paused, true);
+cleanGestureRequirement();
+endTest();
+}
+
+function canplaythrough()
+{
+ setTimeout(testPaused, 500);
+}
+
+function start()
+{
+ findMediaElement();
+ video.src = "" content/test);
+ testExpected(video.paused, true);
+ waitForEvent('canplaythrough', canplaythrough);
+ waitForEvent('play', testPlay);
+}
+/script
+/head
+
+body _onload_=start()
+pTest that media autoplay should not work if user gesture is required for playback./p
+video controls autoplay/video
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (120111 => 120112)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 20:37:15 UTC (rev 120111)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 20:37:16 UTC (rev 120112)
@@ -1,3 +1,17 @@
+2012-06-12 Min Qin qin...@google.com
+
+Disable autoplay when user gesture is required for media playback
+https://bugs.webkit.org/show_bug.cgi?id=88897
+
+Reviewed by Adam Barth.
+
+When user gesture is required for media playback, we should block autoplay.
+Otherwise, people will use autoplay instead of video.play() to bypass the gesture requirement.
+Test: media/no-autoplay-with-user-gesture-requirement.html
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::setReadyState):
+
2012-06-12 Shrey Banga ba...@chromium.org
HTML parser should yield more to improve perceived page load time
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (120111 => 120112)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-06-12 20:37:15 UTC (rev 120111)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2012-06-12 20:37:16 UTC (rev 120112)
@@ -1693,7 +1693,7 @@
if (isPotentiallyPlaying oldState = HAVE_CURRENT_DATA)
scheduleEvent(eventNames().playingEvent);
-if (m_autoplaying m_paused autoplay() !document()-isSandboxed(SandboxAutomaticFeatures)) {
+if (m_autoplaying m_paused autoplay() !document()-isSandboxed(SandboxAutomaticFeatures) !userGestureRequiredForRateChange()) {
m_paused = false;
invalidateCachedTime();
scheduleEvent(eventNames().playEvent);
[webkit-changes] [120113] trunk/Tools
Title: [120113] trunk/Tools
Revision 120113
Author commit-qu...@webkit.org
Date 2012-06-12 13:38:01 -0700 (Tue, 12 Jun 2012)
Log Message
[EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
https://bugs.webkit.org/show_bug.cgi?id=84707
Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
use_lib64 variable is preconfigured to True by jhbuild.
Patch by Dominik Röttsches dominik.rottsc...@intel.com on 2012-06-12
Reviewed by Dirk Pranke.
* efl/jhbuildrc:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuildrc
Diff
Modified: trunk/Tools/ChangeLog (120112 => 120113)
--- trunk/Tools/ChangeLog 2012-06-12 20:37:16 UTC (rev 120112)
+++ trunk/Tools/ChangeLog 2012-06-12 20:38:01 UTC (rev 120113)
@@ -1,3 +1,15 @@
+2012-06-12 Dominik Röttsches dominik.rottsc...@intel.com
+
+[EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
+https://bugs.webkit.org/show_bug.cgi?id=84707
+
+Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
+use_lib64 variable is preconfigured to True by jhbuild.
+
+Reviewed by Dirk Pranke.
+
+* efl/jhbuildrc:
+
2012-06-12 Dana Jansens dan...@chromium.org
Add zlie...@chromium.org to contributors list
Modified: trunk/Tools/efl/jhbuildrc (120112 => 120113)
--- trunk/Tools/efl/jhbuildrc 2012-06-12 20:37:16 UTC (rev 120112)
+++ trunk/Tools/efl/jhbuildrc 2012-06-12 20:38:01 UTC (rev 120113)
@@ -61,6 +61,10 @@
addpath('XDG_DATA_DIRS', '/usr/share')
addpath('XDG_CONFIG_DIRS', '/etc/xdg')
-addpath('CMAKE_PREFIX_PATH', prefix)
+# Avoid overlapping search path CMAKE warning on 64bit systems.
+if (use_lib64):
+addpath('CMAKE_PREFIX_PATH', os.path.join(os.sep, prefix, 'lib64'))
+else:
+addpath('CMAKE_PREFIX_PATH', prefix)
partial_build = False
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120114] trunk
Title: [120114] trunk Revision 120114 Author commit-qu...@webkit.org Date 2012-06-12 13:45:58 -0700 (Tue, 12 Jun 2012) Log Message IndexedDB: Error codes, phase two https://bugs.webkit.org/show_bug.cgi?id=88690 Patch by Alec Flett alecfl...@chromium.org on 2012-06-12 Reviewed by Tony Chang. Source/WebCore: Update the next phase of IndexedDB error codes to match the spec. This update is mostly focused on DATA_ERR vs CONSTRAINT_ERR. Also moves some of the error checking for the transaction mode into the frontend and replaces the backend checks with asserts, so that we can consolidate error checking in one place. This also removes a few FIXME's that are no longer true (about I/O errors - the spec was updated and our implementation was already correct) No new tests, existing tests cover changed behavior. * Modules/indexeddb/IDBCursor.cpp: (WebCore::IDBCursor::deleteFunction): * Modules/indexeddb/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::deleteFunction): * Modules/indexeddb/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::setVersionInternal): * Modules/indexeddb/IDBObjectStore.cpp: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::clear): * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::IDBObjectStoreBackendImpl::deleteFunction): (WebCore::IDBObjectStoreBackendImpl::clear): * Modules/indexeddb/IDBTransaction.h: (WebCore::IDBTransaction::enumMode): * Modules/indexeddb/IDBTransactionBackendImpl.h: LayoutTests: * storage/indexeddb/cursor-advance-expected.txt: * storage/indexeddb/index-unique-expected.txt: * storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt: * storage/indexeddb/mozilla/index-prev-no-duplicate.html: * storage/indexeddb/objectstore-basics-expected.txt: * storage/indexeddb/objectstore-basics-workers-expected.txt: * storage/indexeddb/resources/cursor-advance.js: (openSuccess): (createObjectStore.trans.oncomplete): (createObjectStore): (populateObjectStore): * storage/indexeddb/resources/index-unique.js: (addMoreDataFailed): * storage/indexeddb/resources/objectstore-basics.js: (addAgainFailure): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/storage/indexeddb/cursor-advance-expected.txt trunk/LayoutTests/storage/indexeddb/index-unique-expected.txt trunk/LayoutTests/storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt trunk/LayoutTests/storage/indexeddb/mozilla/index-prev-no-duplicate.html trunk/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt trunk/LayoutTests/storage/indexeddb/objectstore-basics-workers-expected.txt trunk/LayoutTests/storage/indexeddb/resources/cursor-advance.js trunk/LayoutTests/storage/indexeddb/resources/index-unique.js trunk/LayoutTests/storage/indexeddb/resources/objectstore-basics.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp trunk/Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h trunk/Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h Diff Modified: trunk/LayoutTests/ChangeLog (120113 => 120114) --- trunk/LayoutTests/ChangeLog 2012-06-12 20:38:01 UTC (rev 120113) +++ trunk/LayoutTests/ChangeLog 2012-06-12 20:45:58 UTC (rev 120114) @@ -1,3 +1,26 @@ +2012-06-12 Alec Flett alecfl...@chromium.org + +IndexedDB: Error codes, phase two +https://bugs.webkit.org/show_bug.cgi?id=88690 + +Reviewed by Tony Chang. + +* storage/indexeddb/cursor-advance-expected.txt: +* storage/indexeddb/index-unique-expected.txt: +* storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt: +* storage/indexeddb/mozilla/index-prev-no-duplicate.html: +* storage/indexeddb/objectstore-basics-expected.txt: +* storage/indexeddb/objectstore-basics-workers-expected.txt: +* storage/indexeddb/resources/cursor-advance.js: +(openSuccess): +(createObjectStore.trans.oncomplete): +(createObjectStore): +(populateObjectStore): +* storage/indexeddb/resources/index-unique.js: +(addMoreDataFailed): +* storage/indexeddb/resources/objectstore-basics.js: +(addAgainFailure): + 2012-06-12 Ryosuke Niwa rn...@webkit.org Use testRunner in accessibility tests instead of layoutTestController Modified: trunk/LayoutTests/storage/indexeddb/cursor-advance-expected.txt (120113 => 120114) --- trunk/LayoutTests/storage/indexeddb/cursor-advance-expected.txt 2012-06-12 20:38:01 UTC (rev 120113) +++ trunk/LayoutTests/storage/indexeddb/cursor-advance-expected.txt 2012-06-12 20:45:58 UTC (rev
[webkit-changes] [120115] branches/chromium/1132/Source/WebCore/editing
Title: [120115] branches/chromium/1132/Source/WebCore/editing
Revision 120115
Author cev...@google.com
Date 2012-06-12 13:50:18 -0700 (Tue, 12 Jun 2012)
Log Message
Merge 119870
BUG=130722
Review URL: https://chromiumcodereview.appspot.com/10536125
Modified Paths
branches/chromium/1132/Source/WebCore/editing/BreakBlockquoteCommand.cpp
branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp
branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.h
branches/chromium/1132/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp
branches/chromium/1132/Source/WebCore/editing/ReplaceSelectionCommand.cpp
Diff
Modified: branches/chromium/1132/Source/WebCore/editing/BreakBlockquoteCommand.cpp (120114 => 120115)
--- branches/chromium/1132/Source/WebCore/editing/BreakBlockquoteCommand.cpp 2012-06-12 20:45:58 UTC (rev 120114)
+++ branches/chromium/1132/Source/WebCore/editing/BreakBlockquoteCommand.cpp 2012-06-12 20:50:18 UTC (rev 120115)
@@ -126,7 +126,7 @@
}
// Build up list of ancestors in between the start node and the top blockquote.
-VectorElement* ancestors;
+VectorRefPtrElement ancestors;
for (Element* node = startNode-parentElement(); node node != topBlockquote; node = node-parentElement())
ancestors.append(node);
@@ -143,7 +143,7 @@
RefPtrElement clonedChild = ancestors[i - 1]-cloneElementWithoutChildren();
// Preserve list item numbering in cloned lists.
if (clonedChild-isElementNode() clonedChild-hasTagName(olTag)) {
-Node* listChildNode = i 1 ? ancestors[i - 2] : startNode;
+Node* listChildNode = i 1 ? ancestors[i - 2].get() : startNode;
// The first child of the cloned list might not be a list item element,
// find the first one so that we know where to start numbering.
while (listChildNode !listChildNode-hasTagName(liTag))
@@ -155,37 +155,23 @@
appendNode(clonedChild.get(), clonedAncestor.get());
clonedAncestor = clonedChild;
}
-
-// Move the startNode and its siblings.
-Node *moveNode = startNode;
-while (moveNode) {
-Node *next = moveNode-nextSibling();
-removeNode(moveNode);
-appendNode(moveNode, clonedAncestor.get());
-moveNode = next;
-}
+moveRemainingSiblingsToNewParent(startNode, 0, clonedAncestor);
+
if (!ancestors.isEmpty()) {
// Split the tree up the ancestor chain until the topBlockquote
// Throughout this loop, clonedParent is the clone of ancestor's parent.
// This is so we can clone ancestor's siblings and place the clones
// into the clone corresponding to the ancestor's parent.
-Element* ancestor;
-Element* clonedParent;
+RefPtrElement ancestor;
+RefPtrElement clonedParent;
for (ancestor = ancestors.first(), clonedParent = clonedAncestor-parentElement();
ancestor ancestor != topBlockquote;
- ancestor = ancestor-parentElement(), clonedParent = clonedParent-parentElement()) {
-moveNode = ancestor-nextSibling();
-while (moveNode) {
-Node *next = moveNode-nextSibling();
-removeNode(moveNode);
-appendNode(moveNode, clonedParent);
-moveNode = next;
-}
-}
-
+ ancestor = ancestor-parentElement(), clonedParent = clonedParent-parentElement())
+moveRemainingSiblingsToNewParent(ancestor-nextSibling(), 0, clonedParent);
+
// If the startNode's original parent is now empty, remove it
-Node* originalParent = ancestors.first();
+Node* originalParent = ancestors.first().get();
if (!originalParent-hasChildNodes())
removeNode(originalParent);
}
Modified: branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp (120114 => 120115)
--- branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp 2012-06-12 20:45:58 UTC (rev 120114)
+++ branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp 2012-06-12 20:50:18 UTC (rev 120115)
@@ -403,6 +403,20 @@
prune(parent.release());
}
+void CompositeEditCommand::moveRemainingSiblingsToNewParent(Node* node, Node* pastLastNodeToMove, PassRefPtrElement prpNewParent)
+{
+NodeVector nodesToRemove;
+RefPtrElement newParent = prpNewParent;
+
+for (; node node != pastLastNodeToMove; node = node-nextSibling())
+nodesToRemove.append(node);
+
+for (unsigned i = 0; i nodesToRemove.size(); i++) {
+removeNode(nodesToRemove[i]);
+appendNode(nodesToRemove[i], newParent);
+}
+}
+
HTMLElement* CompositeEditCommand::replaceElementWithSpanPreservingChildrenAndAttributes(PassRefPtrHTMLElement node)
{
// It would also be possible to implement all of ReplaceNodeWithSpanCommand
Modified:
[webkit-changes] [120116] branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand .cpp
Title: [120116] branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp
Revision 120116
Author cev...@google.com
Date 2012-06-12 13:54:12 -0700 (Tue, 12 Jun 2012)
Log Message
Merge 119872
BUG=130927
Review URL: https://chromiumcodereview.appspot.com/10544115
Modified Paths
branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp
Diff
Modified: branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp (120115 => 120116)
--- branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp 2012-06-12 20:50:18 UTC (rev 120115)
+++ branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp 2012-06-12 20:54:12 UTC (rev 120116)
@@ -1247,14 +1247,14 @@
// FIXME: Send an appropriate shouldDeleteRange call.
bool CompositeEditCommand::breakOutOfEmptyListItem()
{
-Node* emptyListItem = enclosingEmptyListItem(endingSelection().visibleStart());
+RefPtrNode emptyListItem = enclosingEmptyListItem(endingSelection().visibleStart());
if (!emptyListItem)
return false;
RefPtrEditingStyle style = EditingStyle::create(endingSelection().start());
style-mergeTypingStyle(document());
-ContainerNode* listNode = emptyListItem-parentNode();
+RefPtrContainerNode listNode = emptyListItem-parentNode();
// FIXME: Can't we do something better when the immediate parent wasn't a list node?
if (!listNode
|| (!listNode-hasTagName(ulTag) !listNode-hasTagName(olTag))
@@ -1265,7 +1265,7 @@
RefPtrElement newBlock = 0;
if (ContainerNode* blockEnclosingList = listNode-parentNode()) {
if (blockEnclosingList-hasTagName(liTag)) { // listNode is inside another list item
-if (visiblePositionAfterNode(blockEnclosingList) == visiblePositionAfterNode(listNode)) {
+if (visiblePositionAfterNode(blockEnclosingList) == visiblePositionAfterNode(listNode.get())) {
// If listNode appears at the end of the outer list item, then move listNode outside of this list item
// e.g. ullihello ullibr/li/ul /li/ul should become ullihello/li ullibr/li/ul /ul after this section
// If listNode does NOT appear at the end, then we should consider it as a regular paragraph.
@@ -1281,12 +1281,12 @@
if (!newBlock)
newBlock = createDefaultParagraphElement(document());
-Node* previousListNode = emptyListItem-isElementNode() ? toElement(emptyListItem)-previousElementSibling(): emptyListItem-previousSibling();
-Node* nextListNode = emptyListItem-isElementNode() ? toElement(emptyListItem)-nextElementSibling(): emptyListItem-nextSibling();
-if (isListItem(nextListNode) || isListElement(nextListNode)) {
+RefPtrNode previousListNode = emptyListItem-isElementNode() ? toElement(emptyListItem.get())-previousElementSibling(): emptyListItem-previousSibling();
+RefPtrNode nextListNode = emptyListItem-isElementNode() ? toElement(emptyListItem.get())-nextElementSibling(): emptyListItem-nextSibling();
+if (isListItem(nextListNode.get()) || isListElement(nextListNode.get())) {
// If emptyListItem follows another list item or nested list, split the list node.
-if (isListItem(previousListNode) || isListElement(previousListNode))
-splitElement(static_castElement*(listNode), emptyListItem);
+if (isListItem(previousListNode.get()) || isListElement(previousListNode.get()))
+splitElement(static_castElement*(listNode.get()), emptyListItem);
// If emptyListItem is followed by other list item or nested list, then insert newBlock before the list node.
// Because we have splitted the element, emptyListItem is the first element in the list node.
@@ -1297,7 +1297,7 @@
// When emptyListItem does not follow any list item or nested list, insert newBlock after the enclosing list node.
// Remove the enclosing node if emptyListItem is the only child; otherwise just remove emptyListItem.
insertNodeAfter(newBlock, listNode);
-removeNode(isListItem(previousListNode) || isListElement(previousListNode) ? emptyListItem : listNode);
+removeNode(isListItem(previousListNode.get()) || isListElement(previousListNode.get()) ? emptyListItem.get() : listNode.get());
}
appendBlockPlaceholder(newBlock);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120118] trunk
Title: [120118] trunk
Revision 120118
Author tk...@chromium.org
Date 2012-06-12 14:04:05 -0700 (Tue, 12 Jun 2012)
Log Message
Checking a radio button doesn't uncheck other buttons in the same group in some cases.
https://bugs.webkit.org/show_bug.cgi?id=88835
Reviewed by Ryosuke Niwa.
Source/WebCore:
This change fixes a bug that checking a radio button in a radio button
group in a form detached from a document tree doesn't uncheck another
checked radio button in the radio button group.
A radio button participates in a radio button group in the following
conditions:
- If it is owned by a form element regardless of the form is in a
document tree or not, or
- If it is not owned by any form elements and it is in a document tree.
A radio button group for the radio button is owned by the document.
For HTMLInputElement::removedFrom():
The old code always unregistered the radio button if it was removed from
the document tree. It was incorrect because we don't need to unregister
it if it has an owner form and the owner form is not changed by
removedFrom().
If the owner form is cleared by removedFrom(), willChangeForm()
unregisters the radio button. So what we should do in removedFrom() is
to unregister the radio button only if the radio button group is owned
by the document.
For HTMLInputElement::insertedInto():
The old code always registered the radio button if it is inserted into
the document tree. It was incorrect because we don't need to register it
if it has an owner form and the owner form is not changed by
insertedInto().
If the owner form is changed by insertedInto(), didChangeForm()
registers the radio button. So We should register the radio button only
if its radio button group will be owned by the document.
Test: Add test cases to fast/forms/radio/radio-group.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedInto):
Register this to CheckedRadioButtons only if new group owner is Document.
(WebCore::HTMLInputElement::removedFrom):
Unregister this from CheckedRadioButtons only if old group owner was Document.
LayoutTests:
* fast/forms/radio/radio-group-expected.txt:
* fast/forms/radio/radio-group.html: Add test cases.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/radio/radio-group-expected.txt
trunk/LayoutTests/fast/forms/radio/radio-group.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLInputElement.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (120117 => 120118)
--- trunk/LayoutTests/ChangeLog 2012-06-12 20:54:41 UTC (rev 120117)
+++ trunk/LayoutTests/ChangeLog 2012-06-12 21:04:05 UTC (rev 120118)
@@ -1,3 +1,13 @@
+2012-06-12 Kent Tamura tk...@chromium.org
+
+Checking a radio button doesn't uncheck other buttons in the same group in some cases.
+https://bugs.webkit.org/show_bug.cgi?id=88835
+
+Reviewed by Ryosuke Niwa.
+
+* fast/forms/radio/radio-group-expected.txt:
+* fast/forms/radio/radio-group.html: Add test cases.
+
2012-06-12 Alec Flett alecfl...@chromium.org
IndexedDB: Error codes, phase two
Modified: trunk/LayoutTests/fast/forms/radio/radio-group-expected.txt (120117 => 120118)
--- trunk/LayoutTests/fast/forms/radio/radio-group-expected.txt 2012-06-12 20:54:41 UTC (rev 120117)
+++ trunk/LayoutTests/fast/forms/radio/radio-group-expected.txt 2012-06-12 21:04:05 UTC (rev 120118)
@@ -8,7 +8,15 @@
PASS $(radio1-2).checked is true
PASS $(radio1-1).checked is false
PASS $(radio1-2).checked is true
+PASS $(radio1-1).checked = true; $(radio1-1).checked is true
+PASS $(radio1-2).checked is false
+Detach the from from the document tree:
+PASS radioButtons[0].checked is true
+PASS radioButtons[1].checked is false
+PASS radioButtons[1].checked = true; radioButtons[0].checked is false
+PASS radioButtons[1].checked is true
+
Changing the type of an input element to radio:
PASS $(radio1-1).checked is true
PASS $(radio1-1).checked is false
Modified: trunk/LayoutTests/fast/forms/radio/radio-group.html (120117 => 120118)
--- trunk/LayoutTests/fast/forms/radio/radio-group.html 2012-06-12 20:54:41 UTC (rev 120117)
+++ trunk/LayoutTests/fast/forms/radio/radio-group.html 2012-06-12 21:04:05 UTC (rev 120118)
@@ -35,7 +35,18 @@
$('radio1-2').name = 'name1';
shouldBeFalse('$(radio1-1).checked');
shouldBeTrue('$(radio1-2).checked');
+shouldBeTrue('$(radio1-1).checked = true; $(radio1-1).checked');
+shouldBeFalse('$(radio1-2).checked');
+debug('\nDetach the from from the document tree:');
+var orphanForm = parent.firstChild;
+parent.removeChild(orphanForm);
+var radioButtons = orphanForm.getElementsByTagName('input');
+shouldBeTrue('radioButtons[0].checked');
+shouldBeFalse('radioButtons[1].checked');
+shouldBeFalse('radioButtons[1].checked = true; radioButtons[0].checked');
+shouldBeTrue('radioButtons[1].checked');
+
debug('');
debug('Changing the type of an input element to radio:');
parent.innerHTML = 'form' +
Modified: trunk/Source/WebCore/ChangeLog
[webkit-changes] [120120] trunk/Tools
Title: [120120] trunk/Tools Revision 120120 Author hel...@sencha.com Date 2012-06-12 14:09:18 -0700 (Tue, 12 Jun 2012) Log Message Unreviewed. Update my email address in committers.py. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (120119 => 120120) --- trunk/Tools/ChangeLog 2012-06-12 21:08:18 UTC (rev 120119) +++ trunk/Tools/ChangeLog 2012-06-12 21:09:18 UTC (rev 120120) @@ -1,3 +1,9 @@ +2012-06-12 Helder Correia helder.corr...@nokia.com + +Unreviewed. Update my email address in committers.py. + +* Scripts/webkitpy/common/config/committers.py: + 2012-06-12 Dominik Röttsches dominik.rottsc...@intel.com [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (120119 => 120120) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-06-12 21:08:18 UTC (rev 120119) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2012-06-12 21:09:18 UTC (rev 120120) @@ -253,7 +253,7 @@ Committer(Hans Wennborg, h...@chromium.org, hwennborg), Committer(Hayato Ito, hay...@chromium.org, hayato), Committer(Hironori Bono, hb...@chromium.org, hbono), -Committer(Helder Correia, hel...@sencha.com, helder), +Committer(Helder Correia, helder.corr...@nokia.com, helder), Committer(Hin-Chung Lam, [hc...@google.com, hc...@chromium.org]), Committer(Igor Trindade Oliveira, [igor.olive...@webkit.org, igo...@sisa.samsung.com], igoroliveira), Committer(Ilya Sherman, isher...@chromium.org, isherman), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120121] trunk
Title: [120121] trunk
Revision 120121
Author fpi...@apple.com
Date 2012-06-12 14:15:43 -0700 (Tue, 12 Jun 2012)
Log Message
REGRESSION (r119779): _javascript_ TypeError: 'undefined' is not an object
https://bugs.webkit.org/show_bug.cgi?id=88783
rdar://problem/11640299
Source/_javascript_Core:
Reviewed by Geoffrey Garen.
If you don't keep alive the base of an object access over the various checks
you do for the prototype chain, you're going to have a bad time.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
LayoutTests:
Reviewed by Geoffrey Garen.
* fast/js/dfg-proto-access-inline-osr-exit-expected.txt: Added.
* fast/js/dfg-proto-access-inline-osr-exit.html: Added.
* fast/js/script-tests/dfg-proto-access-inline-osr-exit.js: Added.
(foo):
(Thingy):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
Added Paths
trunk/LayoutTests/fast/js/dfg-proto-access-inline-osr-exit-expected.txt
trunk/LayoutTests/fast/js/dfg-proto-access-inline-osr-exit.html
trunk/LayoutTests/fast/js/script-tests/dfg-proto-access-inline-osr-exit.js
Diff
Modified: trunk/LayoutTests/ChangeLog (120120 => 120121)
--- trunk/LayoutTests/ChangeLog 2012-06-12 21:09:18 UTC (rev 120120)
+++ trunk/LayoutTests/ChangeLog 2012-06-12 21:15:43 UTC (rev 120121)
@@ -1,3 +1,17 @@
+2012-06-12 Filip Pizlo fpi...@apple.com
+
+REGRESSION (r119779): _javascript_ TypeError: 'undefined' is not an object
+https://bugs.webkit.org/show_bug.cgi?id=88783
+rdar://problem/11640299
+
+Reviewed by Geoffrey Garen.
+
+* fast/js/dfg-proto-access-inline-osr-exit-expected.txt: Added.
+* fast/js/dfg-proto-access-inline-osr-exit.html: Added.
+* fast/js/script-tests/dfg-proto-access-inline-osr-exit.js: Added.
+(foo):
+(Thingy):
+
2012-06-12 Igor Oliveira igo...@sisa.samsung.com
Apply animations and transitions for first-letter element
Added: trunk/LayoutTests/fast/js/dfg-proto-access-inline-osr-exit-expected.txt (0 => 120121)
--- trunk/LayoutTests/fast/js/dfg-proto-access-inline-osr-exit-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/js/dfg-proto-access-inline-osr-exit-expected.txt 2012-06-12 21:15:43 UTC (rev 120121)
@@ -0,0 +1,209 @@
+Tests what happens when we OSR exit on an inlined prototype access due to a change in the prototype chain.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()}) is 42
+PASS foo({g:new Thingy()})
[webkit-changes] [120122] trunk/Source
Title: [120122] trunk/Source
Revision 120122
Author commit-qu...@webkit.org
Date 2012-06-12 14:39:14 -0700 (Tue, 12 Jun 2012)
Log Message
Source/WebCore: [chromium mac] Don't include things in subframeworks of
ApplicationServices.framework.
Subframeworks move around from SDK to SDK and OS release to OS
release, but just using the top-level umbrella framework guarantees
forward compatibility. When building for Chromium Mac, just #include
ApplicationServices/ApplicationServices.h instead of reaching in to
subframeworks.
https://bugs.webkit.org/show_bug.cgi?id=88569
Patch by Mark Mentovai m...@chromium.org on 2012-06-12
Reviewed by Stephen White.
No new tests.
* platform/graphics/GlyphBuffer.h:
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
* platform/graphics/skia/GraphicsContextSkia.cpp:
Source/WebKit/chromium: [chromium mac] Don't #include things in subframeworks of
ApplicationServices.framework.
#including the umbrella ApplicatonServices/ApplicationServices.h
exposed an ambiguous name, FontMetrics, that needs to be fully
qualified as WebCore::FontMetrics.
https://bugs.webkit.org/show_bug.cgi?id=88569
Patch by Mark Mentovai m...@chromium.org on 2012-06-12
Reviewed by Stephen White.
* src/WebFontImpl.cpp:
(WebKit::WebFontImpl::estimateTextBounds):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GlyphBuffer.h
trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFontImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120121 => 120122)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 21:15:43 UTC (rev 120121)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 21:39:14 UTC (rev 120122)
@@ -1,3 +1,24 @@
+2012-06-12 Mark Mentovai m...@chromium.org
+
+[chromium mac] Don't include things in subframeworks of
+ApplicationServices.framework.
+
+Subframeworks move around from SDK to SDK and OS release to OS
+release, but just using the top-level umbrella framework guarantees
+forward compatibility. When building for Chromium Mac, just #include
+ApplicationServices/ApplicationServices.h instead of reaching in to
+subframeworks.
+
+https://bugs.webkit.org/show_bug.cgi?id=88569
+
+Reviewed by Stephen White.
+
+No new tests.
+
+* platform/graphics/GlyphBuffer.h:
+* platform/graphics/mac/ComplexTextControllerCoreText.mm:
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+
2012-06-12 Igor Oliveira igo...@sisa.samsung.com
Apply animations and transitions for first-letter element
Modified: trunk/Source/WebCore/platform/graphics/GlyphBuffer.h (120121 => 120122)
--- trunk/Source/WebCore/platform/graphics/GlyphBuffer.h 2012-06-12 21:15:43 UTC (rev 120121)
+++ trunk/Source/WebCore/platform/graphics/GlyphBuffer.h 2012-06-12 21:39:14 UTC (rev 120122)
@@ -35,11 +35,11 @@
#include wtf/UnusedParam.h
#include wtf/Vector.h
-#if USE(CG) || USE(SKIA_ON_MAC_CHROMIUM)
+#if USE(CG)
#include CoreGraphics/CGGeometry.h
#endif
-#if PLATFORM(WX) OS(DARWIN)
+#if OS(DARWIN) (PLATFORM(WX) || PLATFORM(CHROMIUM))
#include ApplicationServices/ApplicationServices.h
#endif
@@ -62,7 +62,7 @@
// CG uses CGSize instead of FloatSize so that the result of advances()
// can be passed directly to CGContextShowGlyphsWithAdvances in FontMac.mm
-#if USE(CG) || (PLATFORM(WX) OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
+#if USE(CG) || (OS(DARWIN) (PLATFORM(WX) || PLATFORM(CHROMIUM)))
typedef CGSize GlyphBufferAdvance;
#elif OS(WINCE)
// There is no cross-platform code that uses the height of GlyphBufferAdvance,
@@ -126,7 +126,7 @@
float advanceAt(int index) const
{
-#if USE(CG) || (PLATFORM(WX) OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
+#if USE(CG) || (OS(DARWIN) (PLATFORM(WX) || PLATFORM(CHROMIUM)))
return m_advances[index].width;
#elif OS(WINCE)
return m_advances[index];
@@ -157,7 +157,7 @@
m_glyphs.append(glyph);
#endif
-#if USE(CG) || (PLATFORM(WX) OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
+#if USE(CG) || (OS(DARWIN) (PLATFORM(WX) || PLATFORM(CHROMIUM)))
CGSize advance = { width, 0 };
m_advances.append(advance);
#elif OS(WINCE)
@@ -196,7 +196,7 @@
{
ASSERT(!isEmpty());
GlyphBufferAdvance lastAdvance = m_advances.last();
-#if USE(CG) || (PLATFORM(WX) OS(DARWIN)) || USE(SKIA_ON_MAC_CHROMIUM)
+#if USE(CG) || (OS(DARWIN) (PLATFORM(WX) || PLATFORM(CHROMIUM)))
lastAdvance.width += width;
#elif OS(WINCE)
lastAdvance += width;
Modified: trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm (120121 => 120122)
--- trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm 2012-06-12 21:15:43 UTC (rev 120121)
+++
[webkit-changes] [120123] trunk/LayoutTests
Title: [120123] trunk/LayoutTests
Revision 120123
Author o...@webkit.org
Date 2012-06-12 14:40:42 -0700 (Tue, 12 Jun 2012)
Log Message
[Qt] Unreviwed nightly gardening.
* platform/qt/Skipped: Remove rolled out tests.
* platform/qt/fast/multicol/span/clone-flexbox-expected.txt: Updated after r120100.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt/fast/multicol/span/clone-flexbox-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (120122 => 120123)
--- trunk/LayoutTests/ChangeLog 2012-06-12 21:39:14 UTC (rev 120122)
+++ trunk/LayoutTests/ChangeLog 2012-06-12 21:40:42 UTC (rev 120123)
@@ -1,3 +1,10 @@
+2012-06-12 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Unreviwed nightly gardening.
+
+* platform/qt/Skipped: Remove rolled out tests.
+* platform/qt/fast/multicol/span/clone-flexbox-expected.txt: Updated after r120100.
+
2012-06-12 Filip Pizlo fpi...@apple.com
REGRESSION (r119779): _javascript_ TypeError: 'undefined' is not an object
Modified: trunk/LayoutTests/platform/qt/Skipped (120122 => 120123)
--- trunk/LayoutTests/platform/qt/Skipped 2012-06-12 21:39:14 UTC (rev 120122)
+++ trunk/LayoutTests/platform/qt/Skipped 2012-06-12 21:40:42 UTC (rev 120123)
@@ -684,17 +684,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=72252
http/tests/misc/xslt-bad-import.html
-# New test http/tests/cookies/js-get-and-set-http-only-cookie fails on Mac, GTK, Qt
-# https://bugs.webkit.org/show_bug.cgi?id=87208
-http/tests/cookies/js-get-and-set-http-only-cookie.php
-
-# http/tests/cache/cancel-in-progress-load.html fails on Qt from r118618
-http/tests/cache/cancel-in-progress-load.html
-
-# New test http/tests/cookies/js-get-and-set-http-only-cookie.php fails on Mac, GTK, Qt, EFL (introduced in r119947)
-# https://bugs.webkit.org/show_bug.cgi?id=87208
-http/tests/cookies/js-get-and-set-http-only-cookie.html
-
# === #
# Failing xmlhttprequest tests #
# === #
Modified: trunk/LayoutTests/platform/qt/fast/multicol/span/clone-flexbox-expected.txt (120122 => 120123)
--- trunk/LayoutTests/platform/qt/fast/multicol/span/clone-flexbox-expected.txt 2012-06-12 21:39:14 UTC (rev 120122)
+++ trunk/LayoutTests/platform/qt/fast/multicol/span/clone-flexbox-expected.txt 2012-06-12 21:40:42 UTC (rev 120123)
@@ -10,12 +10,12 @@
layer at (8,8) size 784x17
RenderBlock (anonymous multi-column) at (0,0) size 784x17
RenderFlexibleBox {DIV} at (0,0) size 117x17 [color=#FF]
- RenderBlock (anonymous) at (0,0) size 117x17
+ RenderBlock (anonymous) at (0,0) size 16x17
RenderText {#text} at (0,0) size 16x17
text run at (0,0) width 16: a
layer at (8,25) size 784x17
RenderBlock (anonymous multi-column) at (0,17) size 784x17
RenderFlexibleBox {DIV} at (0,0) size 117x17 [color=#FF]
- RenderBlock (anonymous) at (0,0) size 117x17
+ RenderBlock (anonymous) at (0,0) size 16x17
RenderText {#text} at (0,0) size 16x17
text run at (0,0) width 16: b
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120124] trunk/Source/WebKit/blackberry
Title: [120124] trunk/Source/WebKit/blackberry
Revision 120124
Author zhaji...@rim.com
Date 2012-06-12 14:44:54 -0700 (Tue, 12 Jun 2012)
Log Message
[BlackBerry] Scale was incorrect when reloading a simple web page after initial load
https://bugs.webkit.org/show_bug.cgi?id=9
Reviewed by Adam Treat.
Patch by Jacky Jiang zhaji...@rim.com
PR: 164442
When we were reloading a web page with the load type FrameLoadTypeSame
after the initial load, the first layout timer was fired after the load
Finished state, in which case the web page would have no chance to zoom
to the initial scale during the layout as it was only for load
Committed state. This patch takes care of it.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::layoutFinished):
(BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):
Modified Paths
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (120123 => 120124)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-06-12 21:40:42 UTC (rev 120123)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-06-12 21:44:54 UTC (rev 120124)
@@ -1554,7 +1554,7 @@
m_nestedLayoutFinishedCount++;
-if (loadState() == Committed)
+if (shouldZoomToInitialScaleOnLoad())
zoomToInitialScaleOnLoad();
else if (loadState() != None)
notifyTransformedContentsSizeChanged();
@@ -1591,6 +1591,18 @@
}
}
+bool WebPagePrivate::shouldZoomToInitialScaleOnLoad() const
+{
+// For FrameLoadTypeSame load, the first layout timer can be fired after the load Finished state. We should
+// zoom to initial scale for this case as well, otherwise the scale of the web page can be incorrect.
+FrameLoadType frameLoadType = FrameLoadTypeStandard;
+if (m_mainFrame m_mainFrame-loader())
+frameLoadType = m_mainFrame-loader()-loadType();
+if (m_loadState == Committed || (m_loadState == Finished frameLoadType == FrameLoadTypeSame))
+return true;
+return false;
+}
+
void WebPagePrivate::zoomToInitialScaleOnLoad()
{
#if DEBUG_WEBPAGE_LOAD
@@ -1628,7 +1640,7 @@
if (m_mainFrame m_mainFrame-loader() m_mainFrame-loader()-shouldRestoreScrollPositionAndViewState())
shouldZoom = false;
-if (shouldZoom loadState() == Committed) {
+if (shouldZoom shouldZoomToInitialScaleOnLoad()) {
// Preserve at top and at left position, to avoid scrolling
// to a non top-left position for web page with viewport meta tag
// that specifies an initial-scale that is zoomed in.
Modified: trunk/Source/WebKit/blackberry/Api/WebPage_p.h (120123 => 120124)
--- trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-06-12 21:40:42 UTC (rev 120123)
+++ trunk/Source/WebKit/blackberry/Api/WebPage_p.h 2012-06-12 21:44:54 UTC (rev 120124)
@@ -204,6 +204,7 @@
void notifyPopupAutofillDialog(const VectorString, const WebCore::IntRect);
void notifyDismissAutofillDialog();
+bool shouldZoomToInitialScaleOnLoad() const;
// Called according to our heuristic or from setLoadState depending on whether we have a virtual viewport.
void zoomToInitialScaleOnLoad();
Modified: trunk/Source/WebKit/blackberry/ChangeLog (120123 => 120124)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-12 21:40:42 UTC (rev 120123)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-12 21:44:54 UTC (rev 120124)
@@ -1,3 +1,28 @@
+2012-06-12 Jacky Jiang zhaji...@rim.com
+
+[BlackBerry] Scale was incorrect when reloading a simple web page after initial load
+https://bugs.webkit.org/show_bug.cgi?id=9
+
+Reviewed by Adam Treat.
+Patch by Jacky Jiang zhaji...@rim.com
+
+PR: 164442
+When we were reloading a web page with the load type FrameLoadTypeSame
+after the initial load, the first layout timer was fired after the load
+Finished state, in which case the web page would have no chance to zoom
+to the initial scale during the layout as it was only for load
+Committed state. This patch takes care of it.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::layoutFinished):
+(BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
+(WebKit):
+(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
+* Api/WebPage_p.h:
+(WebPagePrivate):
+* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+(WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):
+
[webkit-changes] [120125] trunk/Source/WebCore
Title: [120125] trunk/Source/WebCore
Revision 120125
Author e...@google.com
Date 2012-06-12 14:46:28 -0700 (Tue, 12 Jun 2012)
Log Message
[chromium] ScrollingCoordinator::setScrollLayer should update scroll layer ids
https://bugs.webkit.org/show_bug.cgi?id=2
Reviewed by James Robinson.
Tested manually, as scrollbar layers are currently only created when
threaded compositing is enabled and none of those layout tests trigger
this bug.
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
* platform/graphics/chromium/ScrollbarLayerChromium.h:
(WebCore::ScrollbarLayerChromium::setScrollLayerId):
(ScrollbarLayerChromium):
* platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/ScrollbarLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/TreeSynchronizer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120124 => 120125)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 21:44:54 UTC (rev 120124)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 21:46:28 UTC (rev 120125)
@@ -1,3 +1,28 @@
+2012-06-12 Adrienne Walker e...@google.com
+
+[chromium] ScrollingCoordinator::setScrollLayer should update scroll layer ids
+https://bugs.webkit.org/show_bug.cgi?id=2
+
+Reviewed by James Robinson.
+
+Tested manually, as scrollbar layers are currently only created when
+threaded compositing is enabled and none of those layout tests trigger
+this bug.
+
+* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
+(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
+(ScrollingCoordinatorPrivate):
+(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
+(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
+(WebCore::createScrollbarLayer):
+(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
+(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
+* platform/graphics/chromium/ScrollbarLayerChromium.h:
+(WebCore::ScrollbarLayerChromium::setScrollLayerId):
+(ScrollbarLayerChromium):
+* platform/graphics/chromium/TreeSynchronizer.cpp:
+(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
+
2012-06-12 Mark Mentovai m...@chromium.org
[chromium mac] Don't include things in subframeworks of
Modified: trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp (120124 => 120125)
--- trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp 2012-06-12 21:44:54 UTC (rev 120124)
+++ trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp 2012-06-12 21:46:28 UTC (rev 120125)
@@ -45,11 +45,33 @@
ScrollingCoordinatorPrivate() { }
~ScrollingCoordinatorPrivate() { }
-void setScrollLayer(LayerChromium* layer) { m_scrollLayer = layer; }
+void setScrollLayer(LayerChromium* layer)
+{
+m_scrollLayer = layer;
+
+int id = layer ? layer-id() : 0;
+if (m_horizontalScrollbarLayer)
+m_horizontalScrollbarLayer-setScrollLayerId(id);
+if (m_verticalScrollbarLayer)
+m_verticalScrollbarLayer-setScrollLayerId(id);
+}
+
+void setHorizontalScrollbarLayer(PassRefPtrScrollbarLayerChromium layer)
+{
+m_horizontalScrollbarLayer = layer;
+}
+
+void setVerticalScrollbarLayer(PassRefPtrScrollbarLayerChromium layer)
+{
+m_verticalScrollbarLayer = layer;
+}
+
LayerChromium* scrollLayer() const { return m_scrollLayer.get(); }
private:
RefPtrLayerChromium m_scrollLayer;
+RefPtrScrollbarLayerChromium m_horizontalScrollbarLayer;
+RefPtrScrollbarLayerChromium m_verticalScrollbarLayer;
};
PassRefPtrScrollingCoordinator ScrollingCoordinator::create(Page* page)
@@ -81,7 +103,7 @@
#endif
}
-static void scrollbarLayerDidChange(Scrollbar* scrollbar, LayerChromium* scrollLayer, GraphicsLayer* scrollbarGraphicsLayer, FrameView* frameView)
+static PassRefPtrScrollbarLayerChromium createScrollbarLayer(Scrollbar* scrollbar, LayerChromium* scrollLayer, GraphicsLayer* scrollbarGraphicsLayer, FrameView* frameView)
{
ASSERT(scrollbar);
ASSERT(scrollbarGraphicsLayer);
@@ -108,13 +130,15 @@
if (scrollbar-isCustomScrollbar() ||
[webkit-changes] [120126] trunk/LayoutTests
Title: [120126] trunk/LayoutTests Revision 120126 Author o...@webkit.org Date 2012-06-12 14:55:26 -0700 (Tue, 12 Jun 2012) Log Message [Qt] Unreviwed nightly gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (120125 => 120126) --- trunk/LayoutTests/ChangeLog 2012-06-12 21:46:28 UTC (rev 120125) +++ trunk/LayoutTests/ChangeLog 2012-06-12 21:55:26 UTC (rev 120126) @@ -2,6 +2,12 @@ [Qt] Unreviwed nightly gardening. +* platform/qt/Skipped: + +2012-06-12 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviwed nightly gardening. + * platform/qt/Skipped: Remove rolled out tests. * platform/qt/fast/multicol/span/clone-flexbox-expected.txt: Updated after r120100. Modified: trunk/LayoutTests/platform/qt/Skipped (120125 => 120126) --- trunk/LayoutTests/platform/qt/Skipped 2012-06-12 21:46:28 UTC (rev 120125) +++ trunk/LayoutTests/platform/qt/Skipped 2012-06-12 21:55:26 UTC (rev 120126) @@ -684,6 +684,10 @@ # https://bugs.webkit.org/show_bug.cgi?id=72252 http/tests/misc/xslt-bad-import.html +# New test http/tests/cookies/js-get-and-set-http-only-cookie.php fails on Mac, GTK, Qt, EFL (introduced in r119947) +# https://bugs.webkit.org/show_bug.cgi?id=87208 +http/tests/cookies/js-get-and-set-http-only-cookie.html + # === # # Failing xmlhttprequest tests # # === # @@ -2505,3 +2509,11 @@ # Fail until ENABLE_XHR_RESPONSE_BLOB is enabled after r120042 # https://bugs.webkit.org/show_bug.cgi?id=88859 http/tests/xmlhttprequest/response-blob-size.html + +# REGRESSION(r120108): It made http/tests/loading/gmail-assert-on-load.html fail +# https://bugs.webkit.org/show_bug.cgi?id=88923 +http/tests/loading/gmail-assert-on-load.html + +# [Qt]REGRESSION(r120107): It made http/tests/xmlhttprequest/origin-exact-matching.html fails +# https://bugs.webkit.org/show_bug.cgi?id=88913 +http/tests/xmlhttprequest/origin-exact-matching.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120127] trunk/Source
Title: [120127] trunk/Source
Revision 120127
Author dan...@chromium.org
Date 2012-06-12 14:57:05 -0700 (Tue, 12 Jun 2012)
Log Message
[chromium] Return empty visibleLayerRect for layers with empty content bounds
https://bugs.webkit.org/show_bug.cgi?id=88901
Reviewed by Adrienne Walker.
Source/WebCore:
This change should only affect tests. Currently if you set up a
CCLayerImpl with some bounds, but don't set the contentBounds, then
they are empty by default. In this case the visibleLayerRect gets
set inappropriately to the layer's target surface contentRect which
in a completely different coordinate space.
Fixed up tests that were passing bogusly and failed after this change.
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateVisibleLayerRect):
Source/WebKit/chromium:
* tests/CCLayerTreeHostImplTest.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120126 => 120127)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 21:55:26 UTC (rev 120126)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 21:57:05 UTC (rev 120127)
@@ -1,3 +1,21 @@
+2012-06-12 Dana Jansens dan...@chromium.org
+
+[chromium] Return empty visibleLayerRect for layers with empty content bounds
+https://bugs.webkit.org/show_bug.cgi?id=88901
+
+Reviewed by Adrienne Walker.
+
+This change should only affect tests. Currently if you set up a
+CCLayerImpl with some bounds, but don't set the contentBounds, then
+they are empty by default. In this case the visibleLayerRect gets
+set inappropriately to the layer's target surface contentRect which
+in a completely different coordinate space.
+
+Fixed up tests that were passing bogusly and failed after this change.
+
+* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
+(WebCore::calculateVisibleLayerRect):
+
2012-06-12 Adrienne Walker e...@google.com
[chromium] ScrollingCoordinator::setScrollLayer should update scroll layer ids
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp (120126 => 120127)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp 2012-06-12 21:55:26 UTC (rev 120126)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp 2012-06-12 21:57:05 UTC (rev 120127)
@@ -165,7 +165,7 @@
targetSurfaceRect.intersect(layer-clipRect());
if (targetSurfaceRect.isEmpty() || layer-contentBounds().isEmpty())
-return targetSurfaceRect;
+return IntRect();
// Note carefully these are aliases
const IntSize bounds = layer-bounds();
Modified: trunk/Source/WebKit/chromium/ChangeLog (120126 => 120127)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-12 21:55:26 UTC (rev 120126)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-12 21:57:05 UTC (rev 120127)
@@ -1,3 +1,12 @@
+2012-06-12 Dana Jansens dan...@chromium.org
+
+[chromium] Return empty visibleLayerRect for layers with empty content bounds
+https://bugs.webkit.org/show_bug.cgi?id=88901
+
+Reviewed by Adrienne Walker.
+
+* tests/CCLayerTreeHostImplTest.cpp:
+
2012-06-12 Mark Mentovai m...@chromium.org
[chromium mac] Don't #include things in subframeworks of
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (120126 => 120127)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2012-06-12 21:55:26 UTC (rev 120126)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2012-06-12 21:57:05 UTC (rev 120127)
@@ -95,6 +95,7 @@
root-setAnchorPoint(FloatPoint(0, 0));
root-setPosition(FloatPoint(0, 0));
root-setBounds(IntSize(10, 10));
+root-setContentBounds(IntSize(10, 10));
root-setVisibleLayerRect(IntRect(0, 0, 10, 10));
root-setDrawsContent(true);
myHostImpl-setRootLayer(root.release());
@@ -722,6 +723,7 @@
{
setAnchorPoint(FloatPoint(0, 0));
setBounds(IntSize(10, 10));
+setContentBounds(IntSize(10, 10));
setDrawsContent(true);
}
@@ -742,6 +744,7 @@
OwnPtrCCLayerImpl root = CCLayerImpl::create(0);
root-setAnchorPoint(FloatPoint(0, 0));
root-setBounds(IntSize(10, 10));
+root-setContentBounds(root-bounds());
root-setDrawsContent(false);
m_hostImpl-setRootLayer(root.release());
}
@@ -1393,6 +1396,7 @@
root-setAnchorPoint(FloatPoint(0, 0));
root-setPosition(FloatPoint(rootRect.x(), rootRect.y()));
root-setBounds(IntSize(rootRect.width(), rootRect.height()));
+root-setContentBounds(root-bounds());
root-setVisibleLayerRect(rootRect);
root-setDrawsContent(false);
[webkit-changes] [120128] trunk/Source/WebKit/chromium
Title: [120128] trunk/Source/WebKit/chromium
Revision 120128
Author dan...@chromium.org
Date 2012-06-12 15:02:51 -0700 (Tue, 12 Jun 2012)
Log Message
[chromium] Set contentBounds() on impl layers in CCLayerTreeHostCommonTests
https://bugs.webkit.org/show_bug.cgi?id=88903
Reviewed by Adrienne Walker.
Without setting the contentBounds() on impl layers, the visibleLayerRect
will be wrong. This is not the case for main-thread layers, which most
of the tests in this file use. But this is a potential serious confusion
for future test implementors so I'd like to make it explicit now.
* tests/CCLayerTreeHostCommonTest.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120127 => 120128)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-12 21:57:05 UTC (rev 120127)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-12 22:02:51 UTC (rev 120128)
@@ -1,5 +1,19 @@
2012-06-12 Dana Jansens dan...@chromium.org
+[chromium] Set contentBounds() on impl layers in CCLayerTreeHostCommonTests
+https://bugs.webkit.org/show_bug.cgi?id=88903
+
+Reviewed by Adrienne Walker.
+
+Without setting the contentBounds() on impl layers, the visibleLayerRect
+will be wrong. This is not the case for main-thread layers, which most
+of the tests in this file use. But this is a potential serious confusion
+for future test implementors so I'd like to make it explicit now.
+
+* tests/CCLayerTreeHostCommonTest.cpp:
+
+2012-06-12 Dana Jansens dan...@chromium.org
+
[chromium] Return empty visibleLayerRect for layers with empty content bounds
https://bugs.webkit.org/show_bug.cgi?id=88901
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp (120127 => 120128)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp 2012-06-12 21:57:05 UTC (rev 120127)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp 2012-06-12 22:02:51 UTC (rev 120128)
@@ -67,6 +67,7 @@
void setLayerPropertiesForTesting(CCLayerImpl* layer, const WebTransformationMatrix transform, const WebTransformationMatrix sublayerTransform, const FloatPoint anchor, const FloatPoint position, const IntSize bounds, bool preserves3D)
{
setLayerPropertiesForTestingCCLayerImpl(layer, transform, sublayerTransform, anchor, position, bounds, preserves3D);
+layer-setContentBounds(bounds);
}
void executeCalculateDrawTransformsAndVisibility(LayerChromium* rootLayer)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120129] trunk/Source/WebCore
Title: [120129] trunk/Source/WebCore
Revision 120129
Author e...@google.com
Date 2012-06-12 15:12:52 -0700 (Tue, 12 Jun 2012)
Log Message
[chromium] Don't set visible layer rect in CCLayerTreeHost paint iteration
https://bugs.webkit.org/show_bug.cgi?id=88895
Reviewed by James Robinson.
We should only set visible layer rects during the recursion in
CClayerTreeHostCommon and not while we're painting. This is one last
straggling piece of code that never got moved.
Tested by existing mask-related layout tests.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateVisibleAndScissorRectsInternal):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120128 => 120129)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 22:02:51 UTC (rev 120128)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 22:12:52 UTC (rev 120129)
@@ -1,3 +1,21 @@
+2012-06-12 Adrienne Walker e...@google.com
+
+[chromium] Don't set visible layer rect in CCLayerTreeHost paint iteration
+https://bugs.webkit.org/show_bug.cgi?id=88895
+
+Reviewed by James Robinson.
+
+We should only set visible layer rects during the recursion in
+CClayerTreeHostCommon and not while we're painting. This is one last
+straggling piece of code that never got moved.
+
+Tested by existing mask-related layout tests.
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
+* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
+(WebCore::calculateVisibleAndScissorRectsInternal):
+
2012-06-12 Dana Jansens dan...@chromium.org
[chromium] Return empty visibleLayerRect for layers with empty content bounds
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (120128 => 120129)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2012-06-12 22:02:51 UTC (rev 120128)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2012-06-12 22:12:52 UTC (rev 120129)
@@ -583,16 +583,12 @@
// mask and replica should be painted.
LayerChromium* maskLayer = renderSurfaceLayer-maskLayer();
-if (maskLayer) {
-maskLayer-setVisibleLayerRect(IntRect(IntPoint(), renderSurfaceLayer-contentBounds()));
+if (maskLayer)
update(maskLayer, paintType, updater, 0);
-}
LayerChromium* replicaMaskLayer = renderSurfaceLayer-replicaLayer() ? renderSurfaceLayer-replicaLayer()-maskLayer() : 0;
-if (replicaMaskLayer) {
-replicaMaskLayer-setVisibleLayerRect(IntRect(IntPoint(), renderSurfaceLayer-contentBounds()));
+if (replicaMaskLayer)
update(replicaMaskLayer, paintType, updater, 0);
-}
}
void CCLayerTreeHost::paintLayerContents(const LayerList renderSurfaceLayerList, PaintType paintType, CCTextureUpdater updater)
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp (120128 => 120129)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp 2012-06-12 22:02:51 UTC (rev 120128)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp 2012-06-12 22:12:52 UTC (rev 120129)
@@ -830,11 +830,17 @@
CCLayerIteratorType end = CCLayerIteratorType::end(renderSurfaceLayerList);
for (CCLayerIteratorType it = CCLayerIteratorType::begin(renderSurfaceLayerList); it != end; ++it) {
-if (!it.representsTargetRenderSurface()) {
+if (it.representsTargetRenderSurface()) {
+LayerType* maskLayer = it-maskLayer();
+if (maskLayer)
+maskLayer-setVisibleLayerRect(IntRect(IntPoint(), it-contentBounds()));
+LayerType* replicaMaskLayer = it-replicaLayer() ? it-replicaLayer()-maskLayer() : 0;
+if (replicaMaskLayer)
+replicaMaskLayer-setVisibleLayerRect(IntRect(IntPoint(), it-contentBounds()));
+} else if (it.representsItself()) {
IntRect visibleLayerRect = calculateVisibleLayerRect(*it);
it-setVisibleLayerRect(visibleLayerRect);
-}
-if (it.representsItself()) {
+
IntRect scissorRect = calculateLayerScissorRectLayerType, RenderSurfaceType(*it, rootScissorRect);
it-setScissorRect(scissorRect);
} else if (it.representsContributingRenderSurface()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120132] trunk
Title: [120132] trunk
Revision 120132
Author t...@chromium.org
Date 2012-06-12 15:39:01 -0700 (Tue, 12 Jun 2012)
Log Message
Replaced items in a flexbox should be coerced to display:block
https://bugs.webkit.org/show_bug.cgi?id=87068
Reviewed by Ojan Vafai.
Source/WebCore:
The flexbox spec lists HTML tags that should automatically be converted
to display:block when a flex child. It also says that atomic inline-level
children should become block (e.g., inline-table should be treated as table).
http://dev.w3.org/csswg/css3-flexbox/#flex-items
Test: css3/flexbox/flexitem.html
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
LayoutTests:
* css3/flexbox/flexitem-expected.txt: Added.
* css3/flexbox/flexitem.html: Added.
* css3/flexbox/resources/flexbox.js:
(checkExpectedValues):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/resources/flexbox.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
Added Paths
trunk/LayoutTests/css3/flexbox/flexitem-expected.txt
trunk/LayoutTests/css3/flexbox/flexitem.html
Diff
Modified: trunk/LayoutTests/ChangeLog (120131 => 120132)
--- trunk/LayoutTests/ChangeLog 2012-06-12 22:36:54 UTC (rev 120131)
+++ trunk/LayoutTests/ChangeLog 2012-06-12 22:39:01 UTC (rev 120132)
@@ -1,3 +1,15 @@
+2012-06-12 Tony Chang t...@chromium.org
+
+Replaced items in a flexbox should be coerced to display:block
+https://bugs.webkit.org/show_bug.cgi?id=87068
+
+Reviewed by Ojan Vafai.
+
+* css3/flexbox/flexitem-expected.txt: Added.
+* css3/flexbox/flexitem.html: Added.
+* css3/flexbox/resources/flexbox.js:
+(checkExpectedValues):
+
2012-06-12 Joshua Bell jsb...@chromium.org
IndexedDB: ObjectStore/Index shouldn't hold reference to backing store
Added: trunk/LayoutTests/css3/flexbox/flexitem-expected.txt (0 => 120132)
--- trunk/LayoutTests/css3/flexbox/flexitem-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/flexbox/flexitem-expected.txt 2012-06-12 22:39:01 UTC (rev 120132)
@@ -0,0 +1,38 @@
+button
+
+object
+
+PASS
+
+PASS
+
+FAIL:
+Expected 100 for height, but got 10.
+
+div class=flexbox
+ img data-expected-display=block data-expected-width=345 style=-webkit-flex: 1 0 auto; src=""
+ !-- FIXME: The image should stretch in the cross direction. --
+ img data-expected-display=block data-expected-width=255 data-expected-height=100 style=-webkit-flex: 1 0 auto; src=""
+/div
+
+FAIL:
+Expected 100 for height, but got 20.
+Expected 100 for height, but got 20.
+
+div class=flexbox
+ img data-expected-display=block data-expected-width=200 style=-webkit-flex: 1 0 auto; src=""
+ !-- FIXME: The missing image placeholders should stretch in the cross direction. --
+ img data-expected-display=block data-expected-width=200 data-expected-height=100 style=-webkit-flex: 2 0 0; src=""
+ img data-expected-display=block data-expected-width=200 data-expected-height=100 style=-webkit-flex: 2 0 0; src="" alt=placeholder text
+/div
+PASS
+ button
+ PASS
+ PASS
+FAIL:
+Expected 600 for width, but got 0.
+
+div class=flexbox
+ !-- FIXME: This table should flex. --
+ div data-expected-display=table data-expected-width=600 style=display: inline-table/div
+/div
Added: trunk/LayoutTests/css3/flexbox/flexitem.html (0 => 120132)
--- trunk/LayoutTests/css3/flexbox/flexitem.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/flexitem.html 2012-06-12 22:39:01 UTC (rev 120132)
@@ -0,0 +1,96 @@
+!DOCTYPE html
+html
+style
+.flexbox {
+width: 600px;
+display: -webkit-flex;
+background-color: #aaa;
+position: relative;
+min-height: 10px;
+}
+.flexbox * {
+-webkit-flex: 1 0 0;
+margin: 0;
+border: 0;
+padding: 0;
+}
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+script src=""
+body _onload_=checkFlexBoxen()
+div class=flexbox
+ button data-expected-display=block data-expected-width=100button/button
+ canvas data-expected-display=block data-expected-width=100canvas/canvas
+ iframe data-expected-display=block data-expected-width=100 src="" bgcolor=#fffiframe/body/iframe
+ object data-expected-display=block data-expected-width=100object/object
+ select data-expected-display=block data-expected-width=100
+optionselect/option
+ /select
+ textarea data-expected-display=block data-expected-width=100textarea/textarea
+/div
+
+
+div class=flexbox
+ input data-expected-display=block data-expected-width=75 type=checkbox value=radio/input
+ input data-expected-display=block data-expected-width=75 type=file value=file/input
+ input data-expected-display=block data-expected-width=75 type=image value=image/input
+ input data-expected-display=block data-expected-width=75 type=password value=password/input
+ input data-expected-display=block data-expected-width=75 type=radio value=radio/input
+ input
[webkit-changes] [120133] trunk/Tools
Title: [120133] trunk/Tools
Revision 120133
Author commit-qu...@webkit.org
Date 2012-06-12 15:47:56 -0700 (Tue, 12 Jun 2012)
Log Message
WinLauncher should show loading errors
https://bugs.webkit.org/show_bug.cgi?id=80760
Patch by Ashod Nakashian ashodnakash...@yahoo.com on 2012-06-12
Reviewed by Brent Fulgham.
* WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
(WinLauncherWebHost::didFailProvisionalLoadWithError):
* WinLauncher/WinLauncher.h:
(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WinLauncher/WinLauncher.cpp
trunk/Tools/WinLauncher/WinLauncher.h
Diff
Modified: trunk/Tools/ChangeLog (120132 => 120133)
--- trunk/Tools/ChangeLog 2012-06-12 22:39:01 UTC (rev 120132)
+++ trunk/Tools/ChangeLog 2012-06-12 22:47:56 UTC (rev 120133)
@@ -1,3 +1,16 @@
+2012-06-12 Ashod Nakashian ashodnakash...@yahoo.com
+
+WinLauncher should show loading errors
+https://bugs.webkit.org/show_bug.cgi?id=80760
+
+Reviewed by Brent Fulgham.
+
+* WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
+(WinLauncherWebHost::didFailProvisionalLoadWithError):
+* WinLauncher/WinLauncher.h:
+(WinLauncherWebHost::didFailProvisionalLoadWithError):
+(WinLauncherWebHost):
+
2012-06-12 Ryuan Choi ryuan.c...@samsung.com
[EFL][WK2] Add MiniBrowserEfl.
Modified: trunk/Tools/WinLauncher/WinLauncher.cpp (120132 => 120133)
--- trunk/Tools/WinLauncher/WinLauncher.cpp 2012-06-12 22:39:01 UTC (rev 120132)
+++ trunk/Tools/WinLauncher/WinLauncher.cpp 2012-06-12 22:47:56 UTC (rev 120133)
@@ -142,6 +142,20 @@
return 0;
}
+HRESULT STDMETHODCALLTYPE WinLauncherWebHost::didFailProvisionalLoadWithError(IWebView*, IWebError *error, IWebFrame*)
+{
+BSTR errorDescription = 0;
+HRESULT hr = error-localizedDescription(errorDescription);
+if (FAILED(hr))
+errorDescription = LFailed to load page and to localize error description.;
+
+::MessageBoxW(0, static_castLPCWSTR(errorDescription), LError, MB_APPLMODAL | MB_OK);
+if (SUCCEEDED(hr))
+SysFreeString(errorDescription);
+
+return S_OK;
+}
+
HRESULT STDMETHODCALLTYPE WinLauncherWebHost::QueryInterface(REFIID riid, void** ppvObject)
{
*ppvObject = 0;
Modified: trunk/Tools/WinLauncher/WinLauncher.h (120132 => 120133)
--- trunk/Tools/WinLauncher/WinLauncher.h 2012-06-12 22:39:01 UTC (rev 120132)
+++ trunk/Tools/WinLauncher/WinLauncher.h 2012-06-12 22:47:56 UTC (rev 120133)
@@ -50,7 +50,7 @@
virtual HRESULT STDMETHODCALLTYPE didFailProvisionalLoadWithError(
/* [in] */ IWebView *webView,
/* [in] */ IWebError *error,
-/* [in] */ IWebFrame *frame) { return S_OK; }
+/* [in] */ IWebFrame*);
virtual HRESULT STDMETHODCALLTYPE didCommitLoadForFrame(
/* [in] */ IWebView *webView,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120134] trunk/Source/WebKit/blackberry
Title: [120134] trunk/Source/WebKit/blackberry Revision 120134 Author commit-qu...@webkit.org Date 2012-06-12 15:52:31 -0700 (Tue, 12 Jun 2012) Log Message [BlackBerry] Crash when rendering web page that's being destroyed https://bugs.webkit.org/show_bug.cgi?id=88915 Patch by Arvid Nilsson anils...@rim.com on 2012-06-12 Reviewed by Rob Buis. PR #164943 This was a null pointer dereference that happened when the compositor was asked to render after being disconnected from its web page. * Api/WebPageCompositor.cpp: (BlackBerry::WebKit::WebPageCompositorPrivate::render): Modified Paths trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp trunk/Source/WebKit/blackberry/ChangeLog Diff Modified: trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp (120133 => 120134) --- trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp 2012-06-12 22:47:56 UTC (rev 120133) +++ trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp 2012-06-12 22:52:31 UTC (rev 120134) @@ -116,7 +116,7 @@ // For thread safety, we have to do it using a round-trip to the WebKit thread, so the // embedder might call this before the round-trip to WebPagePrivate::setCompositor() is // done. -if (m_webPage-compositor() != this) +if (!m_webPage || m_webPage-compositor() != this) return; m_layerRenderer-setClearSurfaceOnDrawLayers(false); Modified: trunk/Source/WebKit/blackberry/ChangeLog (120133 => 120134) --- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-12 22:47:56 UTC (rev 120133) +++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-12 22:52:31 UTC (rev 120134) @@ -1,3 +1,18 @@ +2012-06-12 Arvid Nilsson anils...@rim.com + +[BlackBerry] Crash when rendering web page that's being destroyed +https://bugs.webkit.org/show_bug.cgi?id=88915 + +Reviewed by Rob Buis. + +PR #164943 + +This was a null pointer dereference that happened when the compositor +was asked to render after being disconnected from its web page. + +* Api/WebPageCompositor.cpp: +(BlackBerry::WebKit::WebPageCompositorPrivate::render): + 2012-06-12 Jacky Jiang zhaji...@rim.com [BlackBerry] Scale was incorrect when reloading a simple web page after initial load ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120135] trunk/Source
Title: [120135] trunk/Source Revision 120135 Author e...@google.com Date 2012-06-12 16:04:17 -0700 (Tue, 12 Jun 2012) Log Message [chromium] Paint scrollbars on WebKit thread and composite those textures https://bugs.webkit.org/show_bug.cgi?id=88145 Reviewed by James Robinson. Source/WebCore: Scrollbars were previously painted and uploaded on the compositor thread. This isn't possible to do for many scrollbar themes. This patch changes ScrollbarLayerChromium to paint the scrollbar into two parts: the thumb, and everything else. These are uploaded into textures and synced over to the CCScrollbarImpl where they are composited and drawn. Mac and overlay scrollbars are still not enabled to have compositor thread-updated scrollbars. As a bonus, fix LayerRendererChromium::drawTextureQuad to draw quads that do not fill the entire layer bounds. Tested by existing layout and unit tests by removing the condition that these scrollbar layers are only created when the threaded proxy exists. * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: (WebCore::scrollbarLayerDidChange): * platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::thumbRect): (WebCore): * platform/ScrollbarThemeComposite.h: (ScrollbarThemeComposite): * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawTextureQuad): * platform/graphics/chromium/ScrollbarLayerChromium.cpp: (WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium): (WebCore::ScrollbarLayerChromium::theme): (WebCore): (WebCore::ScrollbarLayerChromium::pushPropertiesTo): (ScrollbarBackgroundPainter): (WebCore::ScrollbarBackgroundPainter::create): (WebCore::ScrollbarBackgroundPainter::paint): (WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter): (ScrollbarThumbPainter): (WebCore::ScrollbarThumbPainter::create): (WebCore::ScrollbarThumbPainter::paint): (WebCore::ScrollbarThumbPainter::ScrollbarThumbPainter): (WebCore::ScrollbarLayerChromium::setLayerTreeHost): (WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded): (WebCore::ScrollbarLayerChromium::updatePart): (WebCore::ScrollbarLayerChromium::update): * platform/graphics/chromium/ScrollbarLayerChromium.h: (WebCore): (ScrollbarLayerChromium): * platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp: (WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl): (WebCore::CCScrollbarLayerImpl::appendQuads): * platform/graphics/chromium/cc/CCScrollbarLayerImpl.h: (WebCore::CCScrollbarLayerImpl::setBackgroundTextureId): (WebCore::CCScrollbarLayerImpl::setThumbTextureId): (CCScrollbarLayerImpl): Source/WebKit/chromium: Remove scrollbarLayerLostContext test that no longer makes sense. The compositor won't draw at all after a lost context if it has no contents. * tests/CCLayerTreeHostImplTest.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp trunk/Source/WebCore/platform/ScrollbarThemeComposite.cpp trunk/Source/WebCore/platform/ScrollbarThemeComposite.h trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/ScrollbarLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/ScrollbarLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (120134 => 120135) --- trunk/Source/WebCore/ChangeLog 2012-06-12 22:52:31 UTC (rev 120134) +++ trunk/Source/WebCore/ChangeLog 2012-06-12 23:04:17 UTC (rev 120135) @@ -1,3 +1,64 @@ +2012-06-12 Adrienne Walker e...@google.com + +[chromium] Paint scrollbars on WebKit thread and composite those textures +https://bugs.webkit.org/show_bug.cgi?id=88145 + +Reviewed by James Robinson. + +Scrollbars were previously painted and uploaded on the compositor +thread. This isn't possible to do for many scrollbar themes. This +patch changes ScrollbarLayerChromium to paint the scrollbar into two +parts: the thumb, and everything else. These are uploaded into +textures and synced over to the CCScrollbarImpl where they are +composited and drawn. + +Mac and overlay scrollbars are still not enabled to have compositor +thread-updated scrollbars. + +As a bonus, fix LayerRendererChromium::drawTextureQuad to draw quads +that do not fill the entire layer bounds. + +Tested by existing layout and unit tests by removing the condition +that these scrollbar layers are only created when the threaded proxy +exists. + +* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: +(WebCore::scrollbarLayerDidChange): +* platform/ScrollbarThemeComposite.cpp: +
[webkit-changes] [120136] trunk/Source/WebCore
Title: [120136] trunk/Source/WebCore
Revision 120136
Author alexis.men...@openbossa.org
Date 2012-06-12 16:07:21 -0700 (Tue, 12 Jun 2012)
Log Message
Fix packing in StyleBoxData for Windows.
https://bugs.webkit.org/show_bug.cgi?id=88858
Reviewed by Tony Chang.
MSVC doesn't pack bitfields if the types are mixed.
We can safely change the bool type to an unsigned so
the packing will happen. I have added a compile assert
for future regressions.
No new tests : we should not see any regressions.
* rendering/style/StyleBoxData.h:
* rendering/style/StyleBoxData.cpp:
(StyleBoxData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/StyleBoxData.cpp
trunk/Source/WebCore/rendering/style/StyleBoxData.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (120135 => 120136)
--- trunk/Source/WebCore/ChangeLog 2012-06-12 23:04:17 UTC (rev 120135)
+++ trunk/Source/WebCore/ChangeLog 2012-06-12 23:07:21 UTC (rev 120136)
@@ -1,3 +1,21 @@
+2012-06-12 Alexis Menard alexis.men...@openbossa.org
+
+Fix packing in StyleBoxData for Windows.
+https://bugs.webkit.org/show_bug.cgi?id=88858
+
+Reviewed by Tony Chang.
+
+MSVC doesn't pack bitfields if the types are mixed.
+We can safely change the bool type to an unsigned so
+the packing will happen. I have added a compile assert
+for future regressions.
+
+No new tests : we should not see any regressions.
+
+* rendering/style/StyleBoxData.h:
+* rendering/style/StyleBoxData.cpp:
+(StyleBoxData):
+
2012-06-12 Adrienne Walker e...@google.com
[chromium] Paint scrollbars on WebKit thread and composite those textures
Modified: trunk/Source/WebCore/rendering/style/StyleBoxData.cpp (120135 => 120136)
--- trunk/Source/WebCore/rendering/style/StyleBoxData.cpp 2012-06-12 23:04:17 UTC (rev 120135)
+++ trunk/Source/WebCore/rendering/style/StyleBoxData.cpp 2012-06-12 23:07:21 UTC (rev 120136)
@@ -27,6 +27,14 @@
namespace WebCore {
+struct SameSizeAsStyleBoxData : public RefCountedSameSizeAsStyleBoxData {
+Length length[7];
+int m_zIndex;
+uint32_t bitfields;
+};
+
+COMPILE_ASSERT(sizeof(StyleBoxData) == sizeof(SameSizeAsStyleBoxData), StyleBoxData_should_not_grow);
+
StyleBoxData::StyleBoxData()
: m_minWidth(RenderStyle::initialMinSize())
, m_maxWidth(RenderStyle::initialMaxSize())
Modified: trunk/Source/WebCore/rendering/style/StyleBoxData.h (120135 => 120136)
--- trunk/Source/WebCore/rendering/style/StyleBoxData.h 2012-06-12 23:04:17 UTC (rev 120135)
+++ trunk/Source/WebCore/rendering/style/StyleBoxData.h 2012-06-12 23:07:21 UTC (rev 120136)
@@ -80,7 +80,7 @@
Length m_verticalAlign;
int m_zIndex;
-bool m_hasAutoZIndex : 1;
+unsigned m_hasAutoZIndex : 1;
unsigned m_boxSizing : 1; // EBoxSizing
#if ENABLE(CSS_BOX_DECORATION_BREAK)
unsigned m_boxDecorationBreak : 1; // EBoxDecorationBreak
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120137] trunk
Title: [120137] trunk Revision 120137 Author fpi...@apple.com Date 2012-06-12 16:16:51 -0700 (Tue, 12 Jun 2012) Log Message DFG should not ASSERT if you have a double use of a variable that is not revealed to be a double until after CFG simplification https://bugs.webkit.org/show_bug.cgi?id=88927 rdar://problem/11513971 Source/_javascript_Core: Reviewed by Geoffrey Garen. Speculation fixup needs to run if simplification did things, because simplification can change predictions - particularly if you had a control flow path that stored weird things into a variable, but that path got axed by the simplifier. Running fixup in the fixpoint requires making it idempotent, which it previously wasn't. Only one place needed to be changed, namely the un-MustGenerate-ion of ValueToInt32. * dfg/DFGDriver.cpp: (JSC::DFG::compile): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): LayoutTests: Reviewed by Geoffrey Garen. * fast/js/dfg-double-use-of-post-simplification-double-prediction-expected.txt: Added. * fast/js/dfg-double-use-of-post-simplification-double-prediction.html: Added. * fast/js/script-tests/dfg-double-use-of-post-simplification-double-prediction.js: Added. (foo): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGDriver.cpp trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp Added Paths trunk/LayoutTests/fast/js/dfg-double-use-of-post-simplification-double-prediction-expected.txt trunk/LayoutTests/fast/js/dfg-double-use-of-post-simplification-double-prediction.html trunk/LayoutTests/fast/js/script-tests/dfg-double-use-of-post-simplification-double-prediction.js Diff Modified: trunk/LayoutTests/ChangeLog (120136 => 120137) --- trunk/LayoutTests/ChangeLog 2012-06-12 23:07:21 UTC (rev 120136) +++ trunk/LayoutTests/ChangeLog 2012-06-12 23:16:51 UTC (rev 120137) @@ -1,3 +1,17 @@ +2012-06-12 Filip Pizlo fpi...@apple.com + +DFG should not ASSERT if you have a double use of a variable that is not revealed to be a double +until after CFG simplification +https://bugs.webkit.org/show_bug.cgi?id=88927 +rdar://problem/11513971 + +Reviewed by Geoffrey Garen. + +* fast/js/dfg-double-use-of-post-simplification-double-prediction-expected.txt: Added. +* fast/js/dfg-double-use-of-post-simplification-double-prediction.html: Added. +* fast/js/script-tests/dfg-double-use-of-post-simplification-double-prediction.js: Added. +(foo): + 2012-06-12 Tony Chang t...@chromium.org Replaced items in a flexbox should be coerced to display:block Added: trunk/LayoutTests/fast/js/dfg-double-use-of-post-simplification-double-prediction-expected.txt (0 => 120137) --- trunk/LayoutTests/fast/js/dfg-double-use-of-post-simplification-double-prediction-expected.txt (rev 0) +++ trunk/LayoutTests/fast/js/dfg-double-use-of-post-simplification-double-prediction-expected.txt 2012-06-12 23:16:51 UTC (rev 120137) @@ -0,0 +1,209 @@ +Tests stability of the DFG compiler when you have a double use of a variable that is not revealed to be a double until after CFG simplification. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5) is 42.5 +PASS foo(0.5)
[webkit-changes] [120138] trunk/LayoutTests
Title: [120138] trunk/LayoutTests Revision 120138 Author beid...@apple.com Date 2012-06-12 16:40:04 -0700 (Tue, 12 Jun 2012) Log Message https://bugs.webkit.org/show_bug.cgi?id=88928 [WK2] New http/tests/loading/* tests fail There's some latent timing issue with WK2 tests that prevents us from getting the last load delegate callback before finishing the test. Fortunately for the sake of these tests the load delegate dumps are entirely irrelevant. Moving them from http/tests/loading to http/tests/misc and getting new, cleaner results fixes this. Rubberstamped by Darin Adler. * http/tests/misc/embed-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt. * http/tests/misc/embed-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/embed-image-load-outlives-gc-without-crashing.html. * http/tests/misc/image-input-type-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt. * http/tests/misc/image-input-type-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/image-input-type-outlives-gc-without-crashing.html. * http/tests/misc/image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt. * http/tests/misc/image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/image-load-outlives-gc-without-crashing.html. * http/tests/misc/object-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt. * http/tests/misc/object-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/object-image-load-outlives-gc-without-crashing.html. * http/tests/misc/resources/slowimage.php: Renamed from LayoutTests/http/tests/loading/resources/slowimage.php. * http/tests/misc/svg-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt. * http/tests/misc/svg-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/svg-image-load-outlives-gc-without-crashing.html. * http/tests/misc/video-poster-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt. * http/tests/misc/video-poster-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/http/tests/misc/embed-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/misc/embed-image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/misc/image-input-type-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/misc/image-input-type-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/misc/image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/misc/image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/misc/object-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/misc/object-image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/misc/resources/slowimage.php trunk/LayoutTests/http/tests/misc/svg-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/misc/svg-image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/misc/video-poster-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/misc/video-poster-image-load-outlives-gc-without-crashing.html Removed Paths trunk/LayoutTests/http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/embed-image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/image-input-type-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/object-image-load-outlives-gc-without-crashing.html trunk/LayoutTests/http/tests/loading/resources/slowimage.php trunk/LayoutTests/http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt trunk/LayoutTests/http/tests/loading/svg-image-load-outlives-gc-without-crashing.html
[webkit-changes] [120146] trunk/LayoutTests
Title: [120146] trunk/LayoutTests Revision 120146 Author o...@chromium.org Date 2012-06-12 17:39:09 -0700 (Tue, 12 Jun 2012) Log Message Chromium rebaselines after r120135. The new results are clearly more correct. * platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png: * platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: * platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (120145 => 120146) --- trunk/LayoutTests/ChangeLog 2012-06-13 00:33:03 UTC (rev 120145) +++ trunk/LayoutTests/ChangeLog 2012-06-13 00:39:09 UTC (rev 120146) @@ -1,3 +1,10 @@ +2012-06-12 Ojan Vafai o...@chromium.org + +Chromium rebaselines after r120135. The new results are clearly more correct. +* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png: +* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: +* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: + 2012-06-12 Christophe Dumez christophe.du...@intel.com [soup] Prevent setting or editing httpOnly cookies from _javascript_ Modified: trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120147] trunk
Title: [120147] trunk
Revision 120147
Author morr...@google.com
Date 2012-06-12 18:28:33 -0700 (Tue, 12 Jun 2012)
Log Message
Shadow Pseudo ID should be able to nest to point nested shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=62218
Reviewed by Dimitri Glazkov.
.:
* Source/autotools/symbols.filter:
Source/WebCore:
- updateSpecifiersWithElementName() didn't take nesting into account.
tag history can contain selector entries which isn't marked as ShadowDescendant yet.
such entry can be found by investigating isUnknownPseudoElement().
- SelectorChecker::checkSelector() was too strict. Unknown pseudo elements are essentially a kind of class or id
in implementation perspective. For such, rejecting by missing elementStyle doesn't make sense:
It isn't a pseudo but a real element for WebCore after all.
- Added Internals::setShadowPseudoId() to create a test harness whose DOM tree contains pseudo shadow ids.
Before this change, following selecdtor chain is created for p::-shadow-child::-nested-shadow-child:
[both tag name and -shadow-id are set] -(ShadowDescendant)- [-nested-shadow-id]
What we want, which is created by this change is:
[tag] -(ShadowDescendant)- [-shadow-id is set] -(ShadowdescenDant)- [-nested-shadow-id]
Test: fast/dom/shadow/shadow-nested-pseudo-id.html
* WebCore.exp.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
* testing/Internals.cpp:
(WebCore::Internals::setShadowPseudoId):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
* fast/dom/shadow/shadow-nested-pseudo-id-expected.txt: Added.
* fast/dom/shadow/shadow-nested-pseudo-id.html: Added.
Modified Paths
trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def
trunk/Source/WebKit2/win/WebKit2CFLite.def
trunk/Source/autotools/symbols.filter
Added Paths
trunk/LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id-expected.txt
trunk/LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id.html
Diff
Modified: trunk/ChangeLog (120146 => 120147)
--- trunk/ChangeLog 2012-06-13 00:39:09 UTC (rev 120146)
+++ trunk/ChangeLog 2012-06-13 01:28:33 UTC (rev 120147)
@@ -1,3 +1,12 @@
+2012-06-12 MORITA Hajime morr...@google.com
+
+Shadow Pseudo ID should be able to nest to point nested shadow DOM.
+https://bugs.webkit.org/show_bug.cgi?id=62218
+
+Reviewed by Dimitri Glazkov.
+
+* Source/autotools/symbols.filter:
+
2012-06-12 Christophe Dumez christophe.du...@intel.com
[EFL] Enable SHADOW_DOM flag
Modified: trunk/LayoutTests/ChangeLog (120146 => 120147)
--- trunk/LayoutTests/ChangeLog 2012-06-13 00:39:09 UTC (rev 120146)
+++ trunk/LayoutTests/ChangeLog 2012-06-13 01:28:33 UTC (rev 120147)
@@ -1,3 +1,13 @@
+2012-06-12 MORITA Hajime morr...@google.com
+
+Shadow Pseudo ID should be able to nest to point nested shadow DOM.
+https://bugs.webkit.org/show_bug.cgi?id=62218
+
+Reviewed by Dimitri Glazkov.
+
+* fast/dom/shadow/shadow-nested-pseudo-id-expected.txt: Added.
+* fast/dom/shadow/shadow-nested-pseudo-id.html: Added.
+
2012-06-12 Ojan Vafai o...@chromium.org
Chromium rebaselines after r120135. The new results are clearly more correct.
Added: trunk/LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id-expected.txt (0 => 120147)
--- trunk/LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id-expected.txt 2012-06-13 01:28:33 UTC (rev 120147)
@@ -0,0 +1,12 @@
+Nested pseudo id should be matchable
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS window.getComputedStyle(tuple.shadowChild).color is 'rgb(255, 0, 0)'
+PASS window.getComputedStyle(shadowTuple.shadowChild).color is 'rgb(0, 0, 255)'
+PASS window.getComputedStyle(shadowTuple.shadowChild).backgroundColor is 'rgb(0, 128, 0)'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id.html (0 => 120147)
--- trunk/LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id.html (rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadow-nested-pseudo-id.html 2012-06-13 01:28:33 UTC (rev 120147)
@@ -0,0 +1,52 @@
+!DOCTYPE html
+html
+head
+script src=""
+style
+
+p::-shadow-child {
+ color: red;
+}
+
+a::-nested-shadow-child {
+ color: blue;
+}
+
+p::-shadow-child::-nested-shadow-child {
+ background-color: green;
+}
+
[webkit-changes] [120148] trunk/Source/JavaScriptCore
Title: [120148] trunk/Source/_javascript_Core
Revision 120148
Author fpi...@apple.com
Date 2012-06-12 18:29:07 -0700 (Tue, 12 Jun 2012)
Log Message
REGRESSION(120121): inspector tests crash in DFG
https://bugs.webkit.org/show_bug.cgi?id=88941
Reviewed by Geoffrey Garen.
The CFG simplifier has two different ways of fixing up GetLocal, Phantom, and Flush. If we've
already fixed up the node one way, we shouldn't try the other way. The reason why we shouldn't
is that the second way depends on the node referring to other nodes in the to-be-jettisoned
block. After fixup they potentially will refer to nodes in the block being merged to.
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (120147 => 120148)
--- trunk/Source/_javascript_Core/ChangeLog 2012-06-13 01:28:33 UTC (rev 120147)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-06-13 01:29:07 UTC (rev 120148)
@@ -1,3 +1,19 @@
+2012-06-12 Filip Pizlo fpi...@apple.com
+
+REGRESSION(120121): inspector tests crash in DFG
+https://bugs.webkit.org/show_bug.cgi?id=88941
+
+Reviewed by Geoffrey Garen.
+
+The CFG simplifier has two different ways of fixing up GetLocal, Phantom, and Flush. If we've
+already fixed up the node one way, we shouldn't try the other way. The reason why we shouldn't
+is that the second way depends on the node referring to other nodes in the to-be-jettisoned
+block. After fixup they potentially will refer to nodes in the block being merged to.
+
+* dfg/DFGCFGSimplificationPhase.cpp:
+(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
+(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
+
2012-06-12 Leo Yang leo.y...@torchmobile.com.cn
Dynamic hash table in DOMObjectHashTableMap is wrong in multiple threads
Modified: trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp (120147 => 120148)
--- trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp 2012-06-13 01:28:33 UTC (rev 120147)
+++ trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp 2012-06-13 01:29:07 UTC (rev 120148)
@@ -288,7 +288,7 @@
if (child.op() != GetLocal)
return;
#if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE)
-dataLog(Considering GetLocal at @%u.\n, edge.index());
+dataLog(Considering GetLocal at @%u, local r%d.\n, edge.index(), child.local());
#endif
if (child.variableAccessData()-isCaptured()) {
#if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE)
@@ -302,6 +302,10 @@
#endif
ASSERT(originalNodeIndex != NoNode);
Node* originalNode = m_graph[originalNodeIndex];
+#if DFG_ENABLE(DEBUG_PROPAGATION_VERBOSE)
+dataLog(Original has local r%d.\n, originalNode-local());
+#endif
+ASSERT(child.local() == originalNode-local());
if (changeRef)
ASSERT(originalNode-shouldGenerate());
// Possibilities:
@@ -600,6 +604,8 @@
NodeIndex nodeIndex = secondBlock-at(i);
Node node = m_graph[nodeIndex];
+bool childrenAlreadyFixed = false;
+
switch (node.op()) {
case Phantom: {
if (!node.child1())
@@ -611,8 +617,12 @@
NodeIndex setLocalIndex =
firstBlock-variablesAtTail.operand(possibleLocalOp.local());
Node setLocal = m_graph[setLocalIndex];
-if (setLocal.op() == SetLocal)
+if (setLocal.op() == SetLocal) {
m_graph.changeEdge(node.children.child1(), setLocal.child1());
+ASSERT(!node.child2());
+ASSERT(!node.child3());
+childrenAlreadyFixed = true;
+}
}
break;
}
@@ -632,6 +642,7 @@
NodeIndex atFirstIndex = firstBlock-variablesAtTail.operand(node.local());
m_graph.changeEdge(node.children.child1(), Edge(skipGetLocal(atFirstIndex)), node.shouldGenerate());
+childrenAlreadyFixed = true;
if (node.op() != GetLocal)
break;
@@ -651,20 +662,22 @@
break;
}
-bool changeRef = node.shouldGenerate();
+if (!childrenAlreadyFixed) {
+bool changeRef = node.shouldGenerate();
-// If the child is a GetLocal, then we might like to fix it.
-if (node.flags() NodeHasVarArgs) {
-for (unsigned childIdx = node.firstChild();
- childIdx
[webkit-changes] [120149] trunk/Source/JavaScriptCore
Title: [120149] trunk/Source/_javascript_Core Revision 120149 Author gga...@apple.com Date 2012-06-12 19:06:50 -0700 (Tue, 12 Jun 2012) Log Message GC should be 1.7X faster https://bugs.webkit.org/show_bug.cgi?id=88840 Reviewed by Oliver Hunt. I profiled, and removed anything that showed up as a concurrency bottleneck. Then, I added 3 threads to our max thread count, since we can scale up to more threads now. * heap/BlockAllocator.cpp: (JSC::BlockAllocator::BlockAllocator): (JSC::BlockAllocator::~BlockAllocator): (JSC::BlockAllocator::releaseFreeBlocks): (JSC::BlockAllocator::waitForRelativeTimeWhileHoldingLock): (JSC::BlockAllocator::waitForRelativeTime): (JSC::BlockAllocator::blockFreeingThreadMain): * heap/BlockAllocator.h: (BlockAllocator): (JSC::BlockAllocator::allocate): (JSC::BlockAllocator::deallocate): Use a spin lock for the common case where we're just popping a linked list. (A pthread mutex would sleep our thread even if the lock were only contended for a microsecond.) Scope the lock to avoid holding it while allocating VM, since that's a slow activity and it doesn't modify any of our data structures. We still use a pthread mutex to handle our condition variable since we have to, and it's not a hot path. * heap/CopiedSpace.cpp: (JSC::CopiedSpace::CopiedSpace): (JSC::CopiedSpace::doneFillingBlock): * heap/CopiedSpace.h: (JSC::CopiedSpace::CopiedSpace): Use a spin lock for the to space lock, since it just guards linked list and hash table manipulation. * heap/MarkStack.cpp: (JSC::MarkStackSegmentAllocator::MarkStackSegmentAllocator): (JSC::MarkStackSegmentAllocator::allocate): (JSC::MarkStackSegmentAllocator::release): (JSC::MarkStackSegmentAllocator::shrinkReserve): Use a spin lock, since we're just managing a linked list. (JSC::MarkStackArray::donateSomeCellsTo): Changed donation to be proportional to our current stack size. This fixes cases where we used to donate too much. Interestingly, donating too much was starving the donor (when it ran out of work later) *and* the recipient (since it had to wait on a long donation operation to complete before it could acquire the lock). In the worst case, we're still guaranteed to donate N cells in roughly log N time. This change also fixes cases where we used to donate too little, since we would always keep a fixed minimum number of cells. In the worst case, with N marking threads, would could have N large object graph roots in our stack for the duration of GC, and scale to only 1 thread. It's an interesting observation that a single object in the mark stack might represent an arbitrarily large object graph -- and only the act of marking can find out. (JSC::MarkStackArray::stealSomeCellsFrom): Steal in proportion to idle threads. Once again, this fixes cases where constants could cause us to steal too much or too little. (JSC::SlotVisitor::donateKnownParallel): Always wake up other threads if they're idle. We can afford to do this because we're conservative about when we donate. (JSC::SlotVisitor::drainFromShared): * heap/MarkStack.h: (MarkStackSegmentAllocator): (MarkStackArray): (JSC): * heap/SlotVisitor.h: Merged the should I donate? decision into a single function, for simplicity. * runtime/Options.cpp: (minimumNumberOfScansBetweenRebalance): Reduced the delay before donation a lot. We can afford to do this because, in the common case, donation is a single branch that decides not to donate. (cpusToUse): Use more CPUs now, since we scale better now. * runtime/Options.h: (Options): Removed now-unused variables. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/heap/BlockAllocator.cpp trunk/Source/_javascript_Core/heap/BlockAllocator.h trunk/Source/_javascript_Core/heap/CopiedSpace.cpp trunk/Source/_javascript_Core/heap/CopiedSpace.h trunk/Source/_javascript_Core/heap/ListableHandler.h trunk/Source/_javascript_Core/heap/MarkStack.cpp trunk/Source/_javascript_Core/heap/MarkStack.h trunk/Source/_javascript_Core/heap/SlotVisitor.h trunk/Source/_javascript_Core/runtime/Options.cpp trunk/Source/_javascript_Core/runtime/Options.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (120148 => 120149) --- trunk/Source/_javascript_Core/ChangeLog 2012-06-13 01:29:07 UTC (rev 120148) +++ trunk/Source/_javascript_Core/ChangeLog 2012-06-13 02:06:50 UTC (rev 120149) @@ -1,3 +1,91 @@ +2012-06-11 Geoffrey Garen gga...@apple.com + +GC should be 1.7X faster +https://bugs.webkit.org/show_bug.cgi?id=88840 + +Reviewed by Oliver Hunt. + +I profiled, and removed anything that showed up as a concurrency +bottleneck. Then, I added 3 threads to our max thread count, since we +can scale up to more threads now. + +* heap/BlockAllocator.cpp: +(JSC::BlockAllocator::BlockAllocator): +(JSC::BlockAllocator::~BlockAllocator): +(JSC::BlockAllocator::releaseFreeBlocks): +
[webkit-changes] [120150] trunk/Tools
Title: [120150] trunk/Tools
Revision 120150
Author lforsch...@apple.com
Date 2012-06-12 19:37:41 -0700 (Tue, 12 Jun 2012)
Log Message
Wrap bot types inside ().
https://bugs.webkit.org/show_bug.cgi?id=88893
Reviewed by Stephanie Lewis.
* BuildSlaveSupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (120149 => 120150)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-06-13 02:06:50 UTC (rev 120149)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2012-06-13 02:37:41 UTC (rev 120150)
@@ -66,68 +66,68 @@
{ name: hfreyther-sh4-linux1, platform: qt}
],
-builders: [ { name: Apple SnowLeopard Release Build, type: Build, builddir: snowleopard-release,
+builders: [ { name: Apple SnowLeopard Release (Build), type: Build, builddir: snowleopard-release,
platform: mac-snowleopard, configuration: release, architectures: [x86_64],
slavenames: [apple-xserve-4]
},
-{ name: Apple SnowLeopard Debug Build, type: Build, builddir: snowleopard-debug,
+{ name: Apple SnowLeopard Debug (Build), type: Build, builddir: snowleopard-debug,
platform: mac-snowleopard, configuration: debug, architectures: [x86_64],
slavenames: [apple-xserve-9]
},
-{ name: Apple Lion Leaks, type: BuildAndTestLeaks, builddir: lion-leaks,
+{ name: Apple Lion (Leaks), type: BuildAndTestLeaks, builddir: lion-leaks,
platform: mac-lion, configuration: debug, architectures: [x86_64],
slavenames: [apple-macpro-3]
},
-{ name: Apple Lion Debug Build, type: Build, builddir: lion-debug,
+{ name: Apple Lion Debug (Build), type: Build, builddir: lion-debug,
platform: mac-lion, configuration: debug, architectures: [x86_64],
triggers: [lion-debug-tests-wk1, lion-debug-tests-wk2],
slavenames: [apple-xserve-2, apple-xserve-10]
},
-{ name: Apple Lion Release Build, type: Build, builddir: lion-release,
+{ name: Apple Lion Release (Build), type: Build, builddir: lion-release,
platform: mac-lion, configuration: release, architectures: [x86_64],
triggers: [lion-release-tests-wk1, lion-release-tests-wk2, lion-release-perf],
slavenames: [apple-xserve-3]
},
-{ name: Apple Lion Debug WK1 Tests, type: Test, builddir: lion-debug-tests-wk1,
+{ name: Apple Lion Debug WK1 (Tests), type: Test, builddir: lion-debug-tests-wk1,
platform: mac-lion, configuration: debug, architectures: [x86_64],
slavenames: [apple-macpro-4]
},
-{ name: Apple Lion Debug WK2 Tests, type: TestWebKit2, builddir: lion-debug-tests-wk2,
+{ name: Apple Lion Debug WK2 (Tests), type: TestWebKit2, builddir: lion-debug-tests-wk2,
platform: mac-lion, configuration: debug, architectures: [x86_64],
slavenames: [apple-macpro-8, apple-xserve-1]
},
-{ name: Apple Lion Release WK1 Tests, type: Test, builddir: lion-release-tests-wk1,
+{ name: Apple Lion Release WK1 (Tests), type: Test, builddir: lion-release-tests-wk1,
platform: mac-lion, configuration: release, architectures: [x86_64],
slavenames: [apple-macpro-5]
},
-{ name: Apple Lion Release WK2 Tests, type: TestWebKit2, builddir: lion-release-tests-wk2,
+{ name: Apple Lion Release WK2 (Tests), type: TestWebKit2, builddir: lion-release-tests-wk2,
platform: mac-lion, configuration: release, architectures: [x86_64],
slavenames: [apple-macpro-6]
},
{
- name: Apple Lion Release Perf, type: DownloadAndPerfTest, builddir: lion-release-perf-tests,
+ name: Apple Lion Release (Perf), type: DownloadAndPerfTest, builddir: lion-release-perf-tests,
platform: mac-lion, configuration: release, architectures: [x86_64],
slavenames: [apple-xserve-11]
},
{
- name: Apple Win Release Build, type: Build, builddir: win-release,
+ name: Apple Win Release (Build), type:
[webkit-changes] [120151] trunk/Source/JavaScriptCore
Title: [120151] trunk/Source/_javascript_Core
Revision 120151
Author gga...@apple.com
Date 2012-06-12 19:50:50 -0700 (Tue, 12 Jun 2012)
Log Message
Build fix for case-sensitive file systems: use the right case.
* heap/ListableHandler.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/ListableHandler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (120150 => 120151)
--- trunk/Source/_javascript_Core/ChangeLog 2012-06-13 02:37:41 UTC (rev 120150)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-06-13 02:50:50 UTC (rev 120151)
@@ -1,3 +1,9 @@
+2012-06-12 Geoffrey Garen gga...@apple.com
+
+Build fix for case-sensitive file systems: use the right case.
+
+* heap/ListableHandler.h:
+
2012-06-11 Geoffrey Garen gga...@apple.com
GC should be 1.7X faster
Modified: trunk/Source/_javascript_Core/heap/ListableHandler.h (120150 => 120151)
--- trunk/Source/_javascript_Core/heap/ListableHandler.h 2012-06-13 02:37:41 UTC (rev 120150)
+++ trunk/Source/_javascript_Core/heap/ListableHandler.h 2012-06-13 02:50:50 UTC (rev 120151)
@@ -24,7 +24,7 @@
#include wtf/Locker.h
#include wtf/Noncopyable.h
#include wtf/ThreadingPrimitives.h
-#include wtf/TCSpinlock.h
+#include wtf/TCSpinLock.h
namespace JSC {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120152] trunk/LayoutTests
Title: [120152] trunk/LayoutTests Revision 120152 Author domin...@chromium.org Date 2012-06-12 20:05:06 -0700 (Tue, 12 Jun 2012) Log Message [Chromium] Unreviewed: Update expectations for video-media-source-add-and-remove-ids.html https://bugs.webkit.org/show_bug.cgi?id=88949 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120151 => 120152) --- trunk/LayoutTests/ChangeLog 2012-06-13 02:50:50 UTC (rev 120151) +++ trunk/LayoutTests/ChangeLog 2012-06-13 03:05:06 UTC (rev 120152) @@ -1,3 +1,10 @@ +2012-06-12 Dominic Cooney domin...@chromium.org + +[Chromium] Unreviewed: Update expectations for video-media-source-add-and-remove-ids.html +https://bugs.webkit.org/show_bug.cgi?id=88949 + +* platform/chromium/TestExpectations: + 2012-06-12 MORITA Hajime morr...@google.com Shadow Pseudo ID should be able to nest to point nested shadow DOM. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120151 => 120152) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-13 02:50:50 UTC (rev 120151) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-13 03:05:06 UTC (rev 120152) @@ -3571,7 +3571,7 @@ BUGWK85952 : http/tests/media/media-source/video-media-source-seek.html = PASS TIMEOUT BUGWK85952 : http/tests/media/media-source/video-media-source-state-changes.html = PASS TIMEOUT TEXT CRASH -BUGWK88798 : http/tests/media/media-source/video-media-source-add-and-remove-ids.html = TIMEOUT +BUGWK88949 : http/tests/media/media-source/video-media-source-add-and-remove-ids.html = TEXT // Started flaking at around http://trac.webkit.org/changeset/116278. BUGWK85950 LINUX DEBUG : compositing/geometry/limit-layer-bounds-transformed-overflow.html = PASS TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120153] trunk/Source/WTF
Title: [120153] trunk/Source/WTF
Revision 120153
Author gga...@apple.com
Date 2012-06-12 20:23:31 -0700 (Tue, 12 Jun 2012)
Log Message
Try to fix the build.
Maybe don't export inlined functions.
* wtf/ThreadingPrimitives.h:
(WTF::MutexTryLocker::MutexTryLocker):
(WTF::MutexTryLocker::~MutexTryLocker):
(WTF::MutexTryLocker::locked):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ThreadingPrimitives.h
Diff
Modified: trunk/Source/WTF/ChangeLog (120152 => 120153)
--- trunk/Source/WTF/ChangeLog 2012-06-13 03:05:06 UTC (rev 120152)
+++ trunk/Source/WTF/ChangeLog 2012-06-13 03:23:31 UTC (rev 120153)
@@ -1,3 +1,14 @@
+2012-06-12 Geoffrey Garen gga...@apple.com
+
+Try to fix the build.
+
+Maybe don't export inlined functions.
+
+* wtf/ThreadingPrimitives.h:
+(WTF::MutexTryLocker::MutexTryLocker):
+(WTF::MutexTryLocker::~MutexTryLocker):
+(WTF::MutexTryLocker::locked):
+
2012-06-11 Jocelyn Turcotte jocelyn.turco...@nokia.com
Using extrernal ICU library on case unsensitive drives will not work
Modified: trunk/Source/WTF/wtf/ThreadingPrimitives.h (120152 => 120153)
--- trunk/Source/WTF/wtf/ThreadingPrimitives.h 2012-06-13 03:05:06 UTC (rev 120152)
+++ trunk/Source/WTF/wtf/ThreadingPrimitives.h 2012-06-13 03:23:31 UTC (rev 120153)
@@ -100,14 +100,14 @@
class MutexTryLocker {
WTF_MAKE_NONCOPYABLE(MutexTryLocker);
public:
-WTF_EXPORT_PRIVATE MutexTryLocker(Mutex mutex) : m_mutex(mutex), m_locked(mutex.tryLock()) { }
-WTF_EXPORT_PRIVATE ~MutexTryLocker()
+MutexTryLocker(Mutex mutex) : m_mutex(mutex), m_locked(mutex.tryLock()) { }
+~MutexTryLocker()
{
if (m_locked)
m_mutex.unlock();
}
-WTF_EXPORT_PRIVATE bool locked() const { return m_locked; }
+bool locked() const { return m_locked; }
private:
Mutex m_mutex;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120155] trunk/LayoutTests
Title: [120155] trunk/LayoutTests Revision 120155 Author domin...@chromium.org Date 2012-06-12 20:39:09 -0700 (Tue, 12 Jun 2012) Log Message [Chromium] Unreviewed: Update expectations fast/forms/datetimelocal/input-valueasdate-datetimelocal.html is passing, so I expanded fast/forms/datetimelocal to TEXT failures for all other tests. See bug 29359. Likewise for fast/forms/color/input-value-sanitization-color.html. See bug 88951. fast/js/integer-division-neg2tothe32-by-neg1.html is passing on Chromium WebKit waterfall, so updating CRASH to PASS CRASH. See bug 81732. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120154 => 120155) --- trunk/LayoutTests/ChangeLog 2012-06-13 03:31:39 UTC (rev 120154) +++ trunk/LayoutTests/ChangeLog 2012-06-13 03:39:09 UTC (rev 120155) @@ -1,5 +1,23 @@ 2012-06-12 Dominic Cooney domin...@chromium.org +[Chromium] Unreviewed: Update expectations + +fast/forms/datetimelocal/input-valueasdate-datetimelocal.html is +passing, so I expanded fast/forms/datetimelocal to TEXT failures +for all other tests. See bug 29359. + +Likewise for +fast/forms/color/input-value-sanitization-color.html. See bug +88951. + +fast/js/integer-division-neg2tothe32-by-neg1.html is passing on +Chromium WebKit waterfall, so updating CRASH to PASS CRASH. See +bug 81732. + +* platform/chromium/TestExpectations: + +2012-06-12 Dominic Cooney domin...@chromium.org + [Chromium] Unreviewed: Update expectations for video-media-source-add-and-remove-ids.html https://bugs.webkit.org/show_bug.cgi?id=88949 Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120154 => 120155) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-13 03:31:39 UTC (rev 120154) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-13 03:39:09 UTC (rev 120155) @@ -1105,7 +1105,15 @@ // Implementation of Date/time input types are incomplete and // ENABLE_INPUT_TYPE_* flags are not enabled. BUGWK29359 : fast/forms/datetime = TEXT -BUGWK29359 : fast/forms/datetimelocal = TEXT +BUGWK29359 : fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html = TEXT +BUGWK29359 : fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html = TEXT +BUGWK29359 : fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal.html = TEXT +BUGWK29359 : fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html = TEXT +BUGWK29359 : fast/forms/datetimelocal/datetimelocal-input-type.html = TEXT +BUGWK29359 : fast/forms/datetimelocal/datetimelocal-input-visible-string.html = TEXT +BUGWK29359 : fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html = TEXT +BUGWK29359 : fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html = TEXT +BUGWK29359 : fast/forms/datetimelocal/input-valueasnumber-datetimelocal.html = TEXT BUGWK29359 : fast/forms/month = TEXT BUGWK29359 : fast/forms/time = TEXT BUGWK29359 : fast/forms/week = TEXT @@ -2687,8 +2695,8 @@ BUGWK61169 LINUX WIN : css3/images/optimize-contrast-canvas.html = IMAGE BUGWK61169 LINUX WIN : css3/images/optimize-contrast-image.html = IMAGE -// New tests added in r87274 -BUGCR83865 : fast/forms/color = TEXT IMAGE+TEXT +BUGWK88951 : fast/forms/color/input-appearance-color.html = IMAGE+TEXT +BUGWK88951 : fast/forms/color/input-color-onchange-event.html = TEXT // New test added in r87324 BUGCR83994 WIN : platform/win/plugins/call-_javascript_-that-destroys-plugin.html = TEXT @@ -3206,7 +3214,7 @@ BUGWK81697 : fast/notifications/notifications-request-permission.html = TEXT BUGWK81697 : fast/notifications/notifications-without-permission.html = TEXT -BUGWK81732 : fast/js/integer-division-neg2tothe32-by-neg1.html = CRASH +BUGWK81732 : fast/js/integer-division-neg2tothe32-by-neg1.html = PASS CRASH // Old test, has been flaky on and off on all platforms since at least r111389 BUGWK81801 : fast/forms/basic-textareas.html = PASS TEXT IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120157] trunk/LayoutTests
Title: [120157] trunk/LayoutTests Revision 120157 Author domin...@chromium.org Date 2012-06-12 21:47:01 -0700 (Tue, 12 Jun 2012) Log Message [Chromium] Unreviewed: Update expectations for http/tests/media/media-source/webm/video-media-source-seek.html This test has racy events (seeked and webkitsourceended) so is flaky on Linux Dbg. Updated bug 85952 that is tracking flakiness in these tests. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (120156 => 120157) --- trunk/LayoutTests/ChangeLog 2012-06-13 04:32:29 UTC (rev 120156) +++ trunk/LayoutTests/ChangeLog 2012-06-13 04:47:01 UTC (rev 120157) @@ -1,3 +1,13 @@ +2012-06-12 Dominic Cooney domin...@chromium.org + +[Chromium] Unreviewed: Update expectations for http/tests/media/media-source/webm/video-media-source-seek.html + +This test has racy events (seeked and webkitsourceended) so is +flaky on Linux Dbg. Updated bug 85952 that is tracking flakiness +in these tests. + +* platform/chromium/TestExpectations: + 2012-06-12 Kenichi Ishibashi ba...@chromium.org [Chromium] Implement font shaping with font-feature-settings on Mac Modified: trunk/LayoutTests/platform/chromium/TestExpectations (120156 => 120157) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-13 04:32:29 UTC (rev 120156) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-13 04:47:01 UTC (rev 120157) @@ -3577,7 +3577,7 @@ BUGWK85958 : fast/forms/file/file-input-capture.html = TEXT BUGWK85952 : http/tests/media/media-source/video-media-source-play.html = PASS TIMEOUT -BUGWK85952 : http/tests/media/media-source/video-media-source-seek.html = PASS TIMEOUT +BUGWK85952 : http/tests/media/media-source/video-media-source-seek.html = PASS TEXT TIMEOUT BUGWK85952 : http/tests/media/media-source/video-media-source-state-changes.html = PASS TIMEOUT TEXT CRASH BUGWK88949 : http/tests/media/media-source/video-media-source-add-and-remove-ids.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120158] trunk
Title: [120158] trunk
Revision 120158
Author commit-qu...@webkit.org
Date 2012-06-12 21:50:42 -0700 (Tue, 12 Jun 2012)
Log Message
Can't set el.type on a button element
https://bugs.webkit.org/show_bug.cgi?id=14439
Patch by Edaena Salinas Jasso eda...@apple.com on 2012-06-12
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/HTMLButtonElement/change-type.html
* bindings/objc/PublicDOMInterfaces.h:
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::setType): Added implementation of setType method.
(WebCore):
* html/HTMLButtonElement.h:
(HTMLButtonElement): Added setType method.
* html/HTMLButtonElement.idl: Removed readonly restriction to the type variable.
LayoutTests:
* fast/dom/HTMLButtonElement/change-type-expected.txt: Added.
* fast/dom/HTMLButtonElement/change-type.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/objc/PublicDOMInterfaces.h
trunk/Source/WebCore/html/HTMLButtonElement.cpp
trunk/Source/WebCore/html/HTMLButtonElement.h
trunk/Source/WebCore/html/HTMLButtonElement.idl
Added Paths
trunk/LayoutTests/fast/dom/HTMLButtonElement/change-type-expected.txt
trunk/LayoutTests/fast/dom/HTMLButtonElement/change-type.html
Diff
Modified: trunk/LayoutTests/ChangeLog (120157 => 120158)
--- trunk/LayoutTests/ChangeLog 2012-06-13 04:47:01 UTC (rev 120157)
+++ trunk/LayoutTests/ChangeLog 2012-06-13 04:50:42 UTC (rev 120158)
@@ -1,3 +1,13 @@
+2012-06-12 Edaena Salinas Jasso eda...@apple.com
+
+Can't set el.type on a button element
+https://bugs.webkit.org/show_bug.cgi?id=14439
+
+Reviewed by Darin Adler.
+
+* fast/dom/HTMLButtonElement/change-type-expected.txt: Added.
+* fast/dom/HTMLButtonElement/change-type.html: Added.
+
2012-06-12 Dominic Cooney domin...@chromium.org
[Chromium] Unreviewed: Update expectations for http/tests/media/media-source/webm/video-media-source-seek.html
Added: trunk/LayoutTests/fast/dom/HTMLButtonElement/change-type-expected.txt (0 => 120158)
--- trunk/LayoutTests/fast/dom/HTMLButtonElement/change-type-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLButtonElement/change-type-expected.txt 2012-06-13 04:50:42 UTC (rev 120158)
@@ -0,0 +1,43 @@
+Tests for bug 14439. Button type should be set using el.type.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS btn.type = 'submit'; btn.type is 'submit'
+PASS btn.getAttribute('type') is 'submit'
+PASS btn.type = 'reset'; btn.type is 'reset'
+PASS btn.getAttribute('type') is 'reset'
+PASS btn.type = 'button'; btn.type is 'button'
+PASS btn.getAttribute('type') is 'button'
+PASS btn.type = 'reset'; btn.type is 'reset'
+PASS btn.getAttribute('type') is 'reset'
+PASS btn.type = 'suBmiT'; btn.type is 'submit'
+PASS btn.getAttribute('type') is 'suBmiT'
+PASS btn.type = ''; btn.type is 'submit'
+PASS btn.getAttribute('type') is ''
+PASS btn.type = 'b'; btn.type is 'submit'
+PASS btn.getAttribute('type') is 'b'
+PASS btn.type = 'RESET'; btn.type is 'reset'
+PASS btn.getAttribute('type') is 'RESET'
+PASS btn.type = ''; btn.type is 'submit'
+PASS btn.getAttribute('type') is ''
+PASS btn.type = '/'; btn.type is 'submit'
+PASS btn.getAttribute('type') is '/'
+PASS btn.type = ' '; btn.type is 'submit'
+PASS btn.getAttribute('type') is ' '
+PASS btn.type = 'button '; btn.type is 'submit'
+PASS btn.getAttribute('type') is 'button '
+PASS btn.type = ' b u t t o n '; btn.type is 'submit'
+PASS btn.getAttribute('type') is ' b u t t o n '
+PASS btn.type = null; btn.type is 'submit'
+PASS btn.getAttribute('type') is null + ''
+PASS btn.type = undefined; btn.type is 'submit'
+PASS btn.getAttribute('type') is undefined + ''
+PASS btn.type = 'reset'; txt.value = 'hello'; btn.click(); txt.value is ''
+PASS didSubmit is false
+PASS btn.type = 'button'; txt.value = 'hello'; btn.click(); txt.value is 'hello'
+PASS btn.type = 'submit'; btn.click(); didSubmit is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/HTMLButtonElement/change-type.html (0 => 120158)
--- trunk/LayoutTests/fast/dom/HTMLButtonElement/change-type.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLButtonElement/change-type.html 2012-06-13 04:50:42 UTC (rev 120158)
@@ -0,0 +1,114 @@
+!DOCTYPE html
+html
+head
+meta charset=utf-8
+script src=""
+/head
+body _onload_=runTests()
+script
+
+description(Tests for a href="" \
+bug 14439/a. Button type should be set using el.type.);
+
+var didSubmit = false;
+var btn;
+var txt;
+
+function testTypeValue()
+{
+btn = document.getElementById(b);
+
+shouldBe(btn.type = 'submit'; btn.type, 'submit');
+shouldBe(btn.getAttribute('type'), 'submit');
+
+shouldBe(btn.type = 'reset'; btn.type, 'reset');
+shouldBe(btn.getAttribute('type'), 'reset');
+
+shouldBe(btn.type = 'button'; btn.type, 'button');
+
[webkit-changes] [120159] trunk/Source/JavaScriptCore
Title: [120159] trunk/Source/_javascript_Core Revision 120159 Author fpi...@apple.com Date 2012-06-12 21:56:22 -0700 (Tue, 12 Jun 2012) Log Message Unreviewed build fix for ARMv7 debug builds. * jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/jit/JITStubs.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (120158 => 120159) --- trunk/Source/_javascript_Core/ChangeLog 2012-06-13 04:50:42 UTC (rev 120158) +++ trunk/Source/_javascript_Core/ChangeLog 2012-06-13 04:56:22 UTC (rev 120159) @@ -1,3 +1,10 @@ +2012-06-12 Filip Pizlo fpi...@apple.com + +Unreviewed build fix for ARMv7 debug builds. + +* jit/JITStubs.cpp: +(JSC::JITThunks::JITThunks): + 2012-06-12 Geoffrey Garen gga...@apple.com Build fix for case-sensitive file systems: use the right case. Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (120158 => 120159) --- trunk/Source/_javascript_Core/jit/JITStubs.cpp 2012-06-13 04:50:42 UTC (rev 120158) +++ trunk/Source/_javascript_Core/jit/JITStubs.cpp 2012-06-13 04:56:22 UTC (rev 120159) @@ -797,7 +797,7 @@ ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, registerFile) == REGISTER_FILE_OFFSET); ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, callFrame) == CALLFRAME_OFFSET); // The fifth argument is the first item already on the stack. -ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, unused2) == FIRST_STACK_ARGUMENT); +ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, unused1) == FIRST_STACK_ARGUMENT); ASSERT(OBJECT_OFFSETOF(struct JITStackFrame, thunkReturnAddress) == THUNK_RETURN_ADDRESS_OFFSET); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120160] trunk/Source/WebCore
Title: [120160] trunk/Source/WebCore
Revision 120160
Author commit-qu...@webkit.org
Date 2012-06-12 22:00:56 -0700 (Tue, 12 Jun 2012)
Log Message
webcore should depend on webcore_arm_neon for only arm target_arch
https://bugs.webkit.org/show_bug.cgi?id=88839
Patch by Wei James james@intel.com on 2012-06-12
Reviewed by Adam Barth.
* WebCore.gyp/WebCore.gyp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
Diff
Modified: trunk/Source/WebCore/ChangeLog (120159 => 120160)
--- trunk/Source/WebCore/ChangeLog 2012-06-13 04:56:22 UTC (rev 120159)
+++ trunk/Source/WebCore/ChangeLog 2012-06-13 05:00:56 UTC (rev 120160)
@@ -1,3 +1,12 @@
+2012-06-12 Wei James james@intel.com
+
+webcore should depend on webcore_arm_neon for only arm target_arch
+https://bugs.webkit.org/show_bug.cgi?id=88839
+
+Reviewed by Adam Barth.
+
+* WebCore.gyp/WebCore.gyp:
+
2012-06-12 Edaena Salinas Jasso eda...@apple.com
Can't set el.type on a button element
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (120159 => 120160)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-06-13 04:56:22 UTC (rev 120159)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-06-13 05:00:56 UTC (rev 120160)
@@ -2000,7 +2000,6 @@
'target_name': 'webcore',
'type': 'none',
'dependencies': [
-'webcore_arm_neon',
'webcore_dom',
'webcore_html',
'webcore_platform',
@@ -2028,6 +2027,11 @@
],
},
'conditions': [
+['target_arch==arm', {
+ 'dependencies': [
+'webcore_arm_neon',
+ ],
+}],
['OS==mac', {
'direct_dependent_settings': {
'include_dirs': [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120161] trunk/Source/WebKit/chromium
Title: [120161] trunk/Source/WebKit/chromium
Revision 120161
Author commit-qu...@webkit.org
Date 2012-06-12 22:19:12 -0700 (Tue, 12 Jun 2012)
Log Message
[chromium] Roll chromium rev in DEPS
https://bugs.webkit.org/show_bug.cgi?id=88934
Patch by Ian Vollick voll...@chromium.org on 2012-06-12
Reviewed by James Robinson.
Rolling to 141410
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (120160 => 120161)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-13 05:00:56 UTC (rev 120160)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-13 05:19:12 UTC (rev 120161)
@@ -1,3 +1,14 @@
+2012-06-12 Ian Vollick voll...@chromium.org
+
+[chromium] Roll chromium rev in DEPS
+https://bugs.webkit.org/show_bug.cgi?id=88934
+
+Reviewed by James Robinson.
+
+Rolling to 141410
+
+* DEPS:
+
2012-06-12 James Robinson jam...@chromium.org
[chromium] Port Canvas2DLayerBridge over to WebExternalTextureLayer
Modified: trunk/Source/WebKit/chromium/DEPS (120160 => 120161)
--- trunk/Source/WebKit/chromium/DEPS 2012-06-13 05:00:56 UTC (rev 120160)
+++ trunk/Source/WebKit/chromium/DEPS 2012-06-13 05:19:12 UTC (rev 120161)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '141227'
+ 'chromium_rev': '141410'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [120162] trunk/Source/WebKit/qt
Title: [120162] trunk/Source/WebKit/qt
Revision 120162
Author o...@webkit.org
Date 2012-06-12 22:39:11 -0700 (Tue, 12 Jun 2012)
Log Message
[Qt][Mac] Unreviewed buildfix after r120076.
* WebCoreSupport/QTKitFullScreenVideoHandler.h:
Modified Paths
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/QTKitFullScreenVideoHandler.h
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (120161 => 120162)
--- trunk/Source/WebKit/qt/ChangeLog 2012-06-13 05:19:12 UTC (rev 120161)
+++ trunk/Source/WebKit/qt/ChangeLog 2012-06-13 05:39:11 UTC (rev 120162)
@@ -1,3 +1,9 @@
+2012-06-12 Csaba Osztrogonác o...@webkit.org
+
+[Qt][Mac] Unreviewed buildfix after r120076.
+
+* WebCoreSupport/QTKitFullScreenVideoHandler.h:
+
2012-06-11 Kaustubh Atrawalkar kaust...@motorola.com
[DRT] LTC:: counterValueForElementById() could be moved to Internals.
Modified: trunk/Source/WebKit/qt/WebCoreSupport/QTKitFullScreenVideoHandler.h (120161 => 120162)
--- trunk/Source/WebKit/qt/WebCoreSupport/QTKitFullScreenVideoHandler.h 2012-06-13 05:19:12 UTC (rev 120161)
+++ trunk/Source/WebKit/qt/WebCoreSupport/QTKitFullScreenVideoHandler.h 2012-06-13 05:39:11 UTC (rev 120162)
@@ -21,7 +21,7 @@
#ifndef QTKitFullScreenVideoHandler_h
#define QTKitFullScreenVideoHandler_h
-#include OwnPtr.h
+#include wtf/OwnPtr.h
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
