[webkit-changes] [121231] trunk/Source/WebCore

[psolanki]

Title: [121231] trunk/Source/WebCore








Revision 121231
Author psola...@apple.com
Date 2012-06-25 23:05:25 -0700 (Mon, 25 Jun 2012)


Log Message
_javascript_ resources have low priority when SVG is enabled
https://bugs.webkit.org/show_bug.cgi?id=89932
rdar://problem/11741325

Reviewed by Adele Peterson.

r108785 inadvertently lowered the priority of _javascript_ resources. Fix the code so we set
the correct priority for scripts. Also, move the code so that all ifdefs are together at the
bottom to make it a bit easier to read..

* loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121230 => 121231)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 05:32:44 UTC (rev 121230)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 06:05:25 UTC (rev 121231)
@@ -1,3 +1,18 @@
+2012-06-25  Pratik Solanki  psola...@apple.com
+
+_javascript_ resources have low priority when SVG is enabled
+https://bugs.webkit.org/show_bug.cgi?id=89932
+rdar://problem/11741325
+
+Reviewed by Adele Peterson.
+
+r108785 inadvertently lowered the priority of _javascript_ resources. Fix the code so we set
+the correct priority for scripts. Also, move the code so that all ifdefs are together at the
+bottom to make it a bit easier to read..
+
+* loader/cache/CachedResource.cpp:
+(WebCore::defaultPriorityForResourceType):
+
 2012-06-25  Luke Macpherson  macpher...@chromium.org
 
 Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag).


Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (121230 => 121231)

--- trunk/Source/WebCore/loader/cache/CachedResource.cpp	2012-06-26 05:32:44 UTC (rev 121230)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp	2012-06-26 06:05:25 UTC (rev 121231)
@@ -56,20 +56,21 @@
 {
 switch (type) {
 case CachedResource::CSSStyleSheet:
+return ResourceLoadPriorityHigh;
+case CachedResource::Script:
+case CachedResource::FontResource:
+case CachedResource::RawResource:
+return ResourceLoadPriorityMedium;
+case CachedResource::ImageResource:
+return ResourceLoadPriorityLow;
 #if ENABLE(XSLT)
 case CachedResource::XSLStyleSheet:
+return ResourceLoadPriorityHigh;
 #endif
-return ResourceLoadPriorityHigh;
-case CachedResource::Script:
 #if ENABLE(SVG)
 case CachedResource::SVGDocumentResource:
 return ResourceLoadPriorityLow;
 #endif
-case CachedResource::FontResource:
-case CachedResource::RawResource:
-return ResourceLoadPriorityMedium;
-case CachedResource::ImageResource:
-return ResourceLoadPriorityLow;
 #if ENABLE(LINK_PREFETCH)
 case CachedResource::LinkPrefetch:
 return ResourceLoadPriorityVeryLow;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121232] trunk/Source

[rniwa]

Title: [121232] trunk/Source








Revision 121232
Author rn...@webkit.org
Date 2012-06-25 23:29:58 -0700 (Mon, 25 Jun 2012)


Log Message
Get rid of firstItem and nextItem from HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=89923

Reviewed by Andreas Kling.

Source/WebCore: 

Removed HTMLCollection::firstItem and HTMLCollection::nextItem.
Also added hasAnyItem() and hasExactlyOneItem() to HTMLCollection so that named getter on Document
doesn't need to compute the full length before returning a HTMLCollection.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::GetNamedProperty):
* dom/Document.cpp:
(WebCore::Document::openSearchDescriptionURL):
* html/HTMLCollection.cpp:
(WebCore::shouldIncludeChildren):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore):
(WebCore::HTMLCollection::item):
* html/HTMLCollection.h:
(HTMLCollection):
(WebCore::HTMLCollection::hasAnyItem):
(WebCore::HTMLCollection::hasExactlyOneItem):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):

Source/WebKit/chromium: 

Re-implement WebNodeCollection::firstItem() and WebNodeCollection::nextItem() in WebKit code
because we got rid of it from WebCore implementation.

This is an extremely poor API and we shouldn't be exposing it in the future.

* public/WebNodeCollection.h:
(WebKit::WebNodeCollection::WebNodeCollection):
(WebNodeCollection):
* src/WebNodeCollection.cpp:
(WebKit::WebNodeCollection::nextItem):
(WebKit::WebNodeCollection::firstItem):
* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::collectTargetFrames):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLCollection.cpp
trunk/Source/WebCore/html/HTMLCollection.h
trunk/Source/WebCore/html/HTMLMapElement.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebNodeCollection.h
trunk/Source/WebKit/chromium/src/WebNodeCollection.cpp
trunk/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121231 => 121232)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 06:05:25 UTC (rev 121231)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 06:29:58 UTC (rev 121232)
@@ -1,3 +1,38 @@
+2012-06-25  Ryosuke Niwa  rn...@webkit.org
+
+Get rid of firstItem and nextItem from HTMLCollection
+https://bugs.webkit.org/show_bug.cgi?id=89923
+
+Reviewed by Andreas Kling.
+
+Removed HTMLCollection::firstItem and HTMLCollection::nextItem.
+Also added hasAnyItem() and hasExactlyOneItem() to HTMLCollection so that named getter on Document
+doesn't need to compute the full length before returning a HTMLCollection.
+
+* accessibility/AccessibilityRenderObject.cpp:
+(WebCore::AccessibilityRenderObject::getDocumentLinks):
+* bindings/js/JSDOMWindowCustom.cpp:
+(WebCore::namedItemGetter):
+* bindings/js/JSHTMLDocumentCustom.cpp:
+(WebCore::JSHTMLDocument::nameGetter):
+* bindings/v8/custom/V8DOMWindowCustom.cpp:
+(WebCore::V8DOMWindow::namedPropertyGetter):
+* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
+(WebCore::V8HTMLDocument::GetNamedProperty):
+* dom/Document.cpp:
+(WebCore::Document::openSearchDescriptionURL):
+* html/HTMLCollection.cpp:
+(WebCore::shouldIncludeChildren):
+(WebCore::HTMLCollection::HTMLCollection):
+(WebCore):
+(WebCore::HTMLCollection::item):
+* html/HTMLCollection.h:
+(HTMLCollection):
+(WebCore::HTMLCollection::hasAnyItem):
+(WebCore::HTMLCollection::hasExactlyOneItem):
+* html/HTMLMapElement.cpp:
+(WebCore::HTMLMapElement::imageElement):
+
 2012-06-25  Pratik Solanki  psola...@apple.com
 
 _javascript_ resources have low priority when SVG is enabled


Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (121231 => 121232)

--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2012-06-26 06:05:25 UTC (rev 121231)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2012-06-26 06:29:58 UTC (rev 121232)
@@ -2424,9 +2424,8 @@
 void AccessibilityRenderObject::getDocumentLinks(AccessibilityChildrenVector result)
 {
 Document* document = m_renderer-document();
-

[webkit-changes] [121233] trunk/Source/WebKit2

[commit-queue]

Title: [121233] trunk/Source/WebKit2








Revision 121233
Author commit-qu...@webkit.org
Date 2012-06-26 00:24:03 -0700 (Tue, 26 Jun 2012)


Log Message
[WK2][GTK] Uninitialized variable in TextCheckerGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=89948

Patch by Christophe Dumez christophe.du...@intel.com on 2012-06-26
Reviewed by Martin Robinson.

Properly initialize didInitializeState in
TextChecker::state().

* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::state):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (121232 => 121233)

--- trunk/Source/WebKit2/ChangeLog	2012-06-26 06:29:58 UTC (rev 121232)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-26 07:24:03 UTC (rev 121233)
@@ -1,3 +1,16 @@
+2012-06-26  Christophe Dumez  christophe.du...@intel.com
+
+[WK2][GTK] Uninitialized variable in TextCheckerGtk.cpp
+https://bugs.webkit.org/show_bug.cgi?id=89948
+
+Reviewed by Martin Robinson.
+
+Properly initialize didInitializeState in
+TextChecker::state().
+
+* UIProcess/gtk/TextCheckerGtk.cpp:
+(WebKit::TextChecker::state):
+
 2012-06-25  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Make it possible to build WebKit without QtWidgets


Modified: trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp (121232 => 121233)

--- trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp	2012-06-26 06:29:58 UTC (rev 121232)
+++ trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp	2012-06-26 07:24:03 UTC (rev 121233)
@@ -38,7 +38,7 @@
 
 const TextCheckerState TextChecker::state()
 {
-static bool didInitializeState;
+static bool didInitializeState = false;
 if (didInitializeState)
 return textCheckerState;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121234] trunk

[dominicc]

Title: [121234] trunk








Revision 121234
Author domin...@chromium.org
Date 2012-06-26 00:41:32 -0700 (Tue, 26 Jun 2012)


Log Message
WheelEvent should inherit from MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=76104

Reviewed by Kentaro Hara.

Source/WebCore:

The spec for WheelEvent is
http://www.w3.org/TR/DOM-Level-3-Events/#webidl-events-WheelEvent

Tests: fast/events/event-creation.html
   http://samples.msdn.microsoft.com/ietestcenter/dominheritance/showdominheritancetest.htm?Prototype_WheelEvent

* bindings/objc/PublicDOMInterfaces.h: Remove redundant MouseEvent API from WheelEvent
* bindings/scripts/CodeGeneratorObjC.pm: MouseEvents are Events
* dom/MouseEvent.h: Expose no-arg constructor to WheelEvent
* dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent): Call MouseEvent superconstructor
(WebCore::WheelEvent::isMouseEvent): Existing callers use this just for
moves and clicks, ie the type is exactly MouseEvent.
* dom/WheelEvent.h: Extend MouseEvent
* dom/WheelEvent.idl: 

LayoutTests:

* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html: Also check WheelEvent instanceof MouseEvent as well as UIEvent, Event

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/event-creation-expected.txt
trunk/LayoutTests/fast/events/event-creation.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/objc/DOMEvents.mm
trunk/Source/WebCore/bindings/objc/PublicDOMInterfaces.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
trunk/Source/WebCore/dom/MouseEvent.h
trunk/Source/WebCore/dom/WheelEvent.cpp
trunk/Source/WebCore/dom/WheelEvent.h
trunk/Source/WebCore/dom/WheelEvent.idl


Property Changed

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/objc/DOMEvents.mm
trunk/Source/WebCore/dom/WheelEvent.cpp
trunk/Source/WebCore/dom/WheelEvent.h




Diff

Modified: trunk/LayoutTests/ChangeLog (121233 => 121234)

--- trunk/LayoutTests/ChangeLog	2012-06-26 07:24:03 UTC (rev 121233)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 07:41:32 UTC (rev 121234)
@@ -1,3 +1,13 @@
+2012-06-26  Dominic Cooney  domin...@chromium.org
+
+WheelEvent should inherit from MouseEvent
+https://bugs.webkit.org/show_bug.cgi?id=76104
+
+Reviewed by Kentaro Hara.
+
+* fast/events/event-creation-expected.txt:
+* fast/events/event-creation.html: Also check WheelEvent instanceof MouseEvent as well as UIEvent, Event
+
 2012-06-25  Fumitoshi Ukai  u...@chromium.org
 
 Unreviewed, update chromium test expectations.


Modified: trunk/LayoutTests/fast/events/event-creation-expected.txt (121233 => 121234)

--- trunk/LayoutTests/fast/events/event-creation-expected.txt	2012-06-26 07:24:03 UTC (rev 121233)
+++ trunk/LayoutTests/fast/events/event-creation-expected.txt	2012-06-26 07:41:32 UTC (rev 121234)
@@ -78,6 +78,7 @@
 PASS document.createEvent('WebKitTransitionEvent') instanceof window.Event is true
 PASS document.createEvent('WebKitTransitionEvent').constructor === window.WebKitTransitionEvent is true
 PASS document.createEvent('WheelEvent') instanceof window.WheelEvent is true
+PASS document.createEvent('WheelEvent') instanceof window.MouseEvent is true
 PASS document.createEvent('WheelEvent') instanceof window.UIEvent is true
 PASS document.createEvent('WheelEvent') instanceof window.Event is true
 PASS document.createEvent('WheelEvent').constructor === window.WheelEvent is true


Modified: trunk/LayoutTests/fast/events/event-creation.html (121233 => 121234)

--- trunk/LayoutTests/fast/events/event-creation.html	2012-06-26 07:24:03 UTC (rev 121233)
+++ trunk/LayoutTests/fast/events/event-creation.html	2012-06-26 07:41:32 UTC (rev 121234)
@@ -129,6 +129,7 @@
 
 // WheelEvent
 shouldBeTrue(document.createEvent('WheelEvent') instanceof window.WheelEvent);
+shouldBeTrue(document.createEvent('WheelEvent') instanceof window.MouseEvent);
 shouldBeTrue(document.createEvent('WheelEvent') instanceof window.UIEvent);
 shouldBeTrue(document.createEvent('WheelEvent') instanceof window.Event);
 shouldBeTrue(document.createEvent('WheelEvent').constructor === window.WheelEvent);


Modified: trunk/Source/WebCore/ChangeLog (121233 => 121234)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 07:24:03 UTC (rev 121233)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 07:41:32 UTC (rev 121234)
@@ -1,3 +1,26 @@
+2012-06-26  Dominic Cooney  domin...@chromium.org
+
+WheelEvent should inherit from MouseEvent
+https://bugs.webkit.org/show_bug.cgi?id=76104
+
+Reviewed by Kentaro Hara.
+
+The spec for WheelEvent is
+http://www.w3.org/TR/DOM-Level-3-Events/#webidl-events-WheelEvent
+
+Tests: fast/events/event-creation.html
+   http://samples.msdn.microsoft.com/ietestcenter/dominheritance/showdominheritancetest.htm?Prototype_WheelEvent
+
+* bindings/objc/PublicDOMInterfaces.h: Remove redundant MouseEvent API from WheelEvent
+* 

[webkit-changes] [121235] trunk/Source/WebCore

[tkent]

Title: [121235] trunk/Source/WebCore








Revision 121235
Author tk...@chromium.org
Date 2012-06-26 00:55:18 -0700 (Tue, 26 Jun 2012)


Log Message
Refactoring: Simplify FormController interface
https://bugs.webkit.org/show_bug.cgi?id=89951

Reviewed by Kentaro Hara.

- Remove FormController::hasStateForNewFormElements()
  takeStateForFormElement() can check the emptiness, and return an empty
  FormControlState.

- Change the argument of takeStateForFormElement()
  Passing just one HTMLFormControlElementWithState object instead of two
  AtomicStringImpl. This is a preparation to use
  HTMLFormControlElementWithState::form() in FormController.

No new tests. Just a refactoring.

* html/FormController.cpp:
(WebCore::FormController::takeStateForFormElement):
* html/FormController.h:
(FormController):
* html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/FormController.cpp
trunk/Source/WebCore/html/FormController.h
trunk/Source/WebCore/html/HTMLFormControlElementWithState.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121234 => 121235)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 07:41:32 UTC (rev 121234)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 07:55:18 UTC (rev 121235)
@@ -1,3 +1,28 @@
+2012-06-26  Kent Tamura  tk...@chromium.org
+
+Refactoring: Simplify FormController interface
+https://bugs.webkit.org/show_bug.cgi?id=89951
+
+Reviewed by Kentaro Hara.
+
+- Remove FormController::hasStateForNewFormElements()
+  takeStateForFormElement() can check the emptiness, and return an empty
+  FormControlState.
+
+- Change the argument of takeStateForFormElement()
+  Passing just one HTMLFormControlElementWithState object instead of two
+  AtomicStringImpl. This is a preparation to use
+  HTMLFormControlElementWithState::form() in FormController.
+
+No new tests. Just a refactoring.
+
+* html/FormController.cpp:
+(WebCore::FormController::takeStateForFormElement):
+* html/FormController.h:
+(FormController):
+* html/HTMLFormControlElementWithState.cpp:
+(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
+
 2012-06-26  Dominic Cooney  domin...@chromium.org
 
 WheelEvent should inherit from MouseEvent


Modified: trunk/Source/WebCore/html/FormController.cpp (121234 => 121235)

--- trunk/Source/WebCore/html/FormController.cpp	2012-06-26 07:41:32 UTC (rev 121234)
+++ trunk/Source/WebCore/html/FormController.cpp	2012-06-26 07:55:18 UTC (rev 121235)
@@ -138,15 +138,12 @@
 m_stateForNewFormElements.clear();
 }
 
-bool FormController::hasStateForNewFormElements() const
+FormControlState FormController::takeStateForFormElement(const HTMLFormControlElementWithState control)
 {
-return !m_stateForNewFormElements.isEmpty();
-}
-
-FormControlState FormController::takeStateForFormElement(AtomicStringImpl* name, AtomicStringImpl* type)
-{
+if (m_stateForNewFormElements.isEmpty())
+return FormControlState();
 typedef FormElementStateMap::iterator Iterator;
-Iterator it = m_stateForNewFormElements.find(FormElementKey(name, type));
+Iterator it = m_stateForNewFormElements.find(FormElementKey(control.name().impl(), control.type().impl()));
 if (it == m_stateForNewFormElements.end())
 return FormControlState();
 ASSERT(it-second.size());


Modified: trunk/Source/WebCore/html/FormController.h (121234 => 121235)

--- trunk/Source/WebCore/html/FormController.h	2012-06-26 07:41:32 UTC (rev 121234)
+++ trunk/Source/WebCore/html/FormController.h	2012-06-26 07:55:18 UTC (rev 121235)
@@ -125,8 +125,7 @@
 VectorString formElementsState() const;
 // This should be callled only by Document::setStateForNewFormElements().
 void setStateForNewFormElements(const VectorString);
-bool hasStateForNewFormElements() const;
-FormControlState takeStateForFormElement(AtomicStringImpl* name, AtomicStringImpl* type);
+FormControlState takeStateForFormElement(const HTMLFormControlElementWithState);
 
 void registerFormElementWithFormAttribute(FormAssociatedElement*);
 void unregisterFormElementWithFormAttribute(FormAssociatedElement*);


Modified: trunk/Source/WebCore/html/HTMLFormControlElementWithState.cpp (121234 => 121235)

--- trunk/Source/WebCore/html/HTMLFormControlElementWithState.cpp	2012-06-26 07:41:32 UTC (rev 121234)
+++ trunk/Source/WebCore/html/HTMLFormControlElementWithState.cpp	2012-06-26 07:55:18 UTC (rev 121235)
@@ -77,12 +77,9 @@
 if (!shouldSaveAndRestoreFormControlState())
 return;
 
-Document* doc = document();
-if (doc-formController()-hasStateForNewFormElements()) {
-FormControlState state = doc-formController()-takeStateForFormElement(name().impl(), type().impl());
-if (state.valueSize()  0)
-

[webkit-changes] [121237] trunk/Source/WebKit/chromium

[commit-queue]

Title: [121237] trunk/Source/WebKit/chromium








Revision 121237
Author commit-qu...@webkit.org
Date 2012-06-26 00:59:07 -0700 (Tue, 26 Jun 2012)


Log Message
Allow using input type=color UI in ChromeOS.
https://bugs.webkit.org/show_bug.cgi?id=89944

Patch by Jun Mukai mu...@chromium.org on 2012-06-26
Reviewed by Kent Tamura.

http://crrev.com/144111 adds the UI of input type=color for
ChromeOS, so now we can set its flag too.

* features.gypi:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (121236 => 121237)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-06-26 07:55:26 UTC (rev 121236)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-06-26 07:59:07 UTC (rev 121237)
@@ -1,3 +1,15 @@
+2012-06-26  Jun Mukai  mu...@chromium.org
+
+Allow using input type=color UI in ChromeOS.
+https://bugs.webkit.org/show_bug.cgi?id=89944
+
+Reviewed by Kent Tamura.
+
+http://crrev.com/144111 adds the UI of input type=color for
+ChromeOS, so now we can set its flag too.
+
+* features.gypi:
+
 2012-06-25  Ryosuke Niwa  rn...@webkit.org
 
 Get rid of firstItem and nextItem from HTMLCollection


Modified: trunk/Source/WebKit/chromium/features.gypi (121236 => 121237)

--- trunk/Source/WebKit/chromium/features.gypi	2012-06-26 07:55:26 UTC (rev 121236)
+++ trunk/Source/WebKit/chromium/features.gypi	2012-06-26 07:59:07 UTC (rev 121237)
@@ -174,7 +174,7 @@
   'ENABLE_WEB_AUDIO=1',
 ],
   }],
-  ['OS==android or chromeos==1', {
+  ['OS==android', {
 'feature_defines': [
   'ENABLE_INPUT_TYPE_COLOR=0',
 ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121238] trunk/LayoutTests

[mario]

Title: [121238] trunk/LayoutTests








Revision 121238
Author ma...@webkit.org
Date 2012-06-26 00:59:11 -0700 (Tue, 26 Jun 2012)


Log Message
Unreviewed gardening after r120845.
Update expectations for test crashing in the GTK 64bit debug bot.

* platform/gtk/TestExpectations: Add test to CRASHING section.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (121237 => 121238)

--- trunk/LayoutTests/ChangeLog	2012-06-26 07:59:07 UTC (rev 121237)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 07:59:11 UTC (rev 121238)
@@ -1,3 +1,10 @@
+2012-06-26  Mario Sanchez Prada  msanc...@igalia.com
+
+Unreviewed gardening after r120845.
+Update expectations for test crashing in the GTK 64bit debug bot.
+
+* platform/gtk/TestExpectations: Add test to CRASHING section.
+
 2012-06-26  Dominic Cooney  domin...@chromium.org
 
 WheelEvent should inherit from MouseEvent


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (121237 => 121238)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-26 07:59:07 UTC (rev 121237)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-26 07:59:11 UTC (rev 121238)
@@ -362,6 +362,8 @@
 
 BUGWK89647 DEBUG : fast/canvas/canvas-createImageData.html = CRASH
 
+BUGWK89954 DEBUG : http/tests/xmlhttprequest/reentrant-cancel.html = CRASH
+
 //
 // End of Crashing tests
 //






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121240] trunk/Source/WebCore

[yurys]

Title: [121240] trunk/Source/WebCore








Revision 121240
Author yu...@chromium.org
Date 2012-06-26 02:04:31 -0700 (Tue, 26 Jun 2012)


Log Message
Web Inspector: columns in heap snapshot summary view are not resizable
https://bugs.webkit.org/show_bug.cgi?id=89952

Reviewed by Vsevolod Vlasov.

* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize): overriden method
should call overriden one to make sure column resizers are added to the DataGrid.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (121239 => 121240)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 08:25:11 UTC (rev 121239)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 09:04:31 UTC (rev 121240)
@@ -1,3 +1,14 @@
+2012-06-26  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: columns in heap snapshot summary view are not resizable
+https://bugs.webkit.org/show_bug.cgi?id=89952
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/HeapSnapshotDataGrids.js:
+(WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize): overriden method
+should call overriden one to make sure column resizers are added to the DataGrid.
+
 2012-06-26  Kent Tamura  tk...@chromium.org
 
 Refactoring: Simplify FormController interface


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js (121239 => 121240)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js	2012-06-26 08:25:11 UTC (rev 121239)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js	2012-06-26 09:04:31 UTC (rev 121240)
@@ -379,6 +379,7 @@
 
 onResize: function()
 {
+WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize.call(this);
 this.updateVisibleNodes();
 },
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121241] trunk

[tony]

Title: [121241] trunk








Revision 121241
Author t...@chromium.org
Date 2012-06-26 02:11:58 -0700 (Tue, 26 Jun 2012)


Log Message
[Qt] Enable grid layout LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=89909

Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

These tests pass, we just need to hook up the overridePreference.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* Api/qwebsettings.h: Add enum value for CSS grid layout

Tools:

These tests pass, we just need to hook up the overridePreference.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.

LayoutTests:

* platform/qt/Skipped: Enable fast/css-grid-layout tests.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebKit/qt/Api/qwebsettings.cpp
trunk/Source/WebKit/qt/Api/qwebsettings.h
trunk/Source/WebKit/qt/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp
trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (121240 => 121241)

--- trunk/LayoutTests/ChangeLog	2012-06-26 09:04:31 UTC (rev 121240)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 09:11:58 UTC (rev 121241)
@@ -1,3 +1,12 @@
+2012-06-26  Tony Chang  t...@chromium.org
+
+[Qt] Enable grid layout LayoutTests
+https://bugs.webkit.org/show_bug.cgi?id=89909
+
+Reviewed by Csaba Osztrogonác.
+
+* platform/qt/Skipped: Enable fast/css-grid-layout tests.
+
 2012-06-26  Mario Sanchez Prada  msanc...@igalia.com
 
 Unreviewed gardening after r120845.


Modified: trunk/LayoutTests/platform/qt/Skipped (121240 => 121241)

--- trunk/LayoutTests/platform/qt/Skipped	2012-06-26 09:04:31 UTC (rev 121240)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-06-26 09:11:58 UTC (rev 121241)
@@ -156,9 +156,6 @@
 svg/custom/manually-parsed-svg-allowed-in-dashboard.html
 svg/custom/svg-allowed-in-dashboard-object.html
 
-# CSS Grid Layout is not yet enabled. http://webkit.org/b/60731
-fast/css-grid-layout
-
 # style scoped is not yet enabled. http://webkit.org/b/49142
 fast/css/style-scoped
 # CSS Regions tests for region styling and scoped styles


Modified: trunk/Source/WebKit/qt/Api/qwebsettings.cpp (121240 => 121241)

--- trunk/Source/WebKit/qt/Api/qwebsettings.cpp	2012-06-26 09:04:31 UTC (rev 121240)
+++ trunk/Source/WebKit/qt/Api/qwebsettings.cpp	2012-06-26 09:11:58 UTC (rev 121241)
@@ -174,6 +174,9 @@
 value = attributes.value(QWebSettings::CSSRegionsEnabled,
  global-attributes.value(QWebSettings::CSSRegionsEnabled));
 settings-setCSSRegionsEnabled(value);
+value = attributes.value(QWebSettings::CSSGridLayoutEnabled,
+ global-attributes.value(QWebSettings::CSSGridLayoutEnabled));
+settings-setCSSGridLayoutEnabled(value);
 
 value = attributes.value(QWebSettings::HyperlinkAuditingEnabled,
  global-attributes.value(QWebSettings::HyperlinkAuditingEnabled));
@@ -522,6 +525,7 @@
 d-attributes.insert(QWebSettings::AcceleratedCompositingEnabled, true);
 d-attributes.insert(QWebSettings::WebGLEnabled, false);
 d-attributes.insert(QWebSettings::CSSRegionsEnabled, false);
+d-attributes.insert(QWebSettings::CSSGridLayoutEnabled, false);
 d-attributes.insert(QWebSettings::HyperlinkAuditingEnabled, false);
 d-attributes.insert(QWebSettings::TiledBackingStoreEnabled, false);
 d-attributes.insert(QWebSettings::FrameFlatteningEnabled, false);


Modified: trunk/Source/WebKit/qt/Api/qwebsettings.h (121240 => 121241)

--- trunk/Source/WebKit/qt/Api/qwebsettings.h	2012-06-26 09:04:31 UTC (rev 121240)
+++ trunk/Source/WebKit/qt/Api/qwebsettings.h	2012-06-26 09:11:58 UTC (rev 121241)
@@ -78,7 +78,8 @@
 _javascript_CanCloseWindows,
 WebGLEnabled,
 CSSRegionsEnabled,
-HyperlinkAuditingEnabled
+HyperlinkAuditingEnabled,
+CSSGridLayoutEnabled
 };
 enum WebGraphic {
 MissingImageGraphic,


Modified: trunk/Source/WebKit/qt/ChangeLog (121240 => 121241)

--- trunk/Source/WebKit/qt/ChangeLog	2012-06-26 09:04:31 UTC (rev 121240)
+++ trunk/Source/WebKit/qt/ChangeLog	2012-06-26 09:11:58 UTC (rev 121241)
@@ -1,3 +1,17 @@
+2012-06-26  Tony Chang  t...@chromium.org
+
+[Qt] Enable grid layout LayoutTests
+https://bugs.webkit.org/show_bug.cgi?id=89909
+
+Reviewed by Csaba Osztrogonác.
+
+These tests pass, we just need to hook up the overridePreference.
+
+* Api/qwebsettings.cpp:
+(QWebSettingsPrivate::apply):
+(QWebSettings::QWebSettings):
+* Api/qwebsettings.h: Add enum value for CSS grid layout
+
 2012-06-25  Simon Hausmann  simon.hausm...@nokia.com
 
 

[webkit-changes] [121242] trunk/Source/WebCore

[ossy]

Title: [121242] trunk/Source/WebCore








Revision 121242
Author o...@webkit.org
Date 2012-06-26 02:21:20 -0700 (Tue, 26 Jun 2012)


Log Message
[Qt] Unreviewed typo fix after r121144.

* Target.pri:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (121241 => 121242)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 09:11:58 UTC (rev 121241)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 09:21:20 UTC (rev 121242)
@@ -1,3 +1,9 @@
+2012-06-26  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] Unreviewed typo fix after r121144.
+
+* Target.pri:
+
 2012-06-26  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: columns in heap snapshot summary view are not resizable


Modified: trunk/Source/WebCore/Target.pri (121241 => 121242)

--- trunk/Source/WebCore/Target.pri	2012-06-26 09:11:58 UTC (rev 121241)
+++ trunk/Source/WebCore/Target.pri	2012-06-26 09:21:20 UTC (rev 121242)
@@ -2037,7 +2037,7 @@
 html/track/WebVTTParser.h \
 html/track/WebVTTToken.h \
 html/track/WebVTTTokenizer.h \
-inspector/BindingVisitor.h \
+inspector/BindingVisitors.h \
 inspector/ConsoleMessage.h \
 inspector/ContentSearchUtils.h \
 inspector/DOMEditor.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121243] trunk/Source/JavaScriptCore

[fpizlo]

Title: [121243] trunk/Source/_javascript_Core








Revision 121243
Author fpi...@apple.com
Date 2012-06-26 02:22:45 -0700 (Tue, 26 Jun 2012)


Log Message
New fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html fails on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=89953

Reviewed by Zoltan Herczeg.

DFG 32-bit JIT was confused about the difference between a predicted type and a
proven type. This is easy to get confused about, since a local that is predicted int32
almost always means that the local must be an int32 since speculations are hoisted to
stores to locals. But that is less likely to be the case for arguments, where there is
an additional least-upper-bounding step: any store to an argument with a weird type
may force the argument to be any type.

This patch basically duplicates the functionality in DFGSpeculativeJIT64.cpp for
GetLocal: the decision of whether to load a local as an int32 (or as an array, or as
a boolean) is made based on the AbstractValue::m_type, which is a type proof, rather
than the VariableAccessData::prediction(), which is a predicted type.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121242 => 121243)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-26 09:21:20 UTC (rev 121242)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-26 09:22:45 UTC (rev 121243)
@@ -1,3 +1,25 @@
+2012-06-26  Filip Pizlo  fpi...@apple.com
+
+New fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html fails on 32 bit
+https://bugs.webkit.org/show_bug.cgi?id=89953
+
+Reviewed by Zoltan Herczeg.
+
+DFG 32-bit JIT was confused about the difference between a predicted type and a
+proven type. This is easy to get confused about, since a local that is predicted int32
+almost always means that the local must be an int32 since speculations are hoisted to
+stores to locals. But that is less likely to be the case for arguments, where there is
+an additional least-upper-bounding step: any store to an argument with a weird type
+may force the argument to be any type.
+
+This patch basically duplicates the functionality in DFGSpeculativeJIT64.cpp for
+GetLocal: the decision of whether to load a local as an int32 (or as an array, or as
+a boolean) is made based on the AbstractValue::m_type, which is a type proof, rather
+than the VariableAccessData::prediction(), which is a predicted type.
+
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
 2012-06-25  Filip Pizlo  fpi...@apple.com
 
 JSC should try to make profiling deterministic because otherwise reproducing failures is


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (121242 => 121243)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2012-06-26 09:21:20 UTC (rev 121242)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2012-06-26 09:22:45 UTC (rev 121243)
@@ -1891,7 +1891,7 @@
 break;
 }
 
-if (isInt32Speculation(prediction)) {
+if (isInt32Speculation(value.m_type)) {
 GPRTemporary result(this);
 m_jit.load32(JITCompiler::payloadFor(node.local()), result.gpr());
 
@@ -1903,7 +1903,7 @@
 break;
 }
 
-if (isArraySpeculation(prediction)) {
+if (isArraySpeculation(value.m_type)) {
 GPRTemporary result(this);
 m_jit.load32(JITCompiler::payloadFor(node.local()), result.gpr());
 
@@ -1915,7 +1915,7 @@
 break;
 }
 
-if (isBooleanSpeculation(prediction)) {
+if (isBooleanSpeculation(value.m_type)) {
 GPRTemporary result(this);
 m_jit.load32(JITCompiler::payloadFor(node.local()), result.gpr());
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121244] trunk/Tools

[commit-queue]

Title: [121244] trunk/Tools








Revision 121244
Author commit-qu...@webkit.org
Date 2012-06-26 02:42:06 -0700 (Tue, 26 Jun 2012)


Log Message
[Qt][NRWT] Fix baseline and skipped file search path.
https://bugs.webkit.org/show_bug.cgi?id=89882

Patch by János Badics jbad...@inf.u-szeged.hu on 2012-06-26
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (121243 => 121244)

--- trunk/Tools/ChangeLog	2012-06-26 09:22:45 UTC (rev 121243)
+++ trunk/Tools/ChangeLog	2012-06-26 09:42:06 UTC (rev 121244)
@@ -1,3 +1,15 @@
+2012-06-26  János Badics  jbad...@inf.u-szeged.hu
+
+[Qt][NRWT] Fix baseline and skipped file search path.
+https://bugs.webkit.org/show_bug.cgi?id=89882
+
+Reviewed by Csaba Osztrogonác.
+
+* Scripts/webkitpy/layout_tests/port/qt.py:
+(QtPort.baseline_search_path):
+* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
+(QtPortTest.test_baseline_search_path):
+
 2012-06-26  Tony Chang  t...@chromium.org
 
 [Qt] Enable grid layout LayoutTests


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py (121243 => 121244)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py	2012-06-26 09:22:45 UTC (rev 121243)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py	2012-06-26 09:42:06 UTC (rev 121244)
@@ -106,7 +106,16 @@
 version = '4.8'
 return version
 
-def baseline_search_path(self):
+def _search_paths(self):
+# Qt port uses same paths for baseline_search_path and _skipped_file_search_paths
+#
+# qt-5.0-wk1qt-5.0-wk2
+#\/
+# qt-5.0qt-4.8
+#\/
+#(qt-linux|qt-mac|qt-win)
+#|
+#   qt
 search_paths = []
 version = self.qt_version()
 if '5.0' in version:
@@ -114,26 +123,21 @@
 search_paths.append('qt-5.0-wk2')
 else:
 search_paths.append('qt-5.0-wk1')
-search_paths.append(self.name())
 if '4.8' in version:
 search_paths.append('qt-4.8')
 elif version:
 search_paths.append('qt-5.0')
+search_paths.append(self.port_name + '-' + self.host.platform.os_name)
 search_paths.append(self.port_name)
-return map(self._webkit_baseline_path, search_paths)
+return search_paths
 
+def baseline_search_path(self):
+return map(self._webkit_baseline_path, self._search_paths())
+
 def _skipped_file_search_paths(self):
-search_paths = set([self.port_name, self.name()])
-version = self.qt_version()
-if '4.8' in version:
-search_paths.add('qt-4.8')
-elif version:
-search_paths.add('qt-5.0')
-if self.get_option('webkit_test_runner'):
-search_paths.update(['qt-5.0-wk2', 'wk2'])
-else:
-search_paths.add('qt-5.0-wk1')
-return search_paths
+skipped_path = self._search_paths()
+skipped_path.append('wk2')
+return skipped_path
 
 def setup_environ_for_server(self, server_name=None):
 clean_env = WebKitPort.setup_environ_for_server(self, server_name)


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py (121243 => 121244)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py	2012-06-26 09:22:45 UTC (rev 121243)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py	2012-06-26 09:42:06 UTC (rev 121244)
@@ -60,21 +60,21 @@
 return 'QMake version 2.01a\nUsing Qt version 5.0.0 in /usr/local/Trolltech/Qt-5.0.0/lib'
 
 def test_baseline_search_path(self):
-self._assert_search_path(['qt-mac', 'qt-4.8', 'qt'], 'mac', qt_version='4.8')
-self._assert_search_path(['qt-win', 'qt-4.8', 'qt'], 'win', qt_version='4.8')
-self._assert_search_path(['qt-linux', 'qt-4.8', 'qt'], 'linux', qt_version='4.8')
+self._assert_search_path(['qt-4.8', 'qt-mac', 'qt'], 'mac', qt_version='4.8')
+self._assert_search_path(['qt-4.8', 'qt-win', 'qt'], 'win', qt_version='4.8')
+self._assert_search_path(['qt-4.8', 'qt-linux', 'qt'], 'linux', qt_version='4.8')
 
-self._assert_search_path(['qt-mac', 'qt-4.8', 'qt'], 'mac')
-self._assert_search_path(['qt-win', 'qt-4.8', 'qt'], 'win')
-self._assert_search_path(['qt-linux', 'qt-4.8', 'qt'], 'linux')
+self._assert_search_path(['qt-4.8', 'qt-mac', 'qt'], 'mac')
+self._assert_search_path(['qt-4.8', 'qt-win', 'qt'], 'win')
+self._assert_search_path(['qt-4.8', 'qt-linux', 

[webkit-changes] [121245] trunk/Source/WebKit/blackberry

[charles . wei]

Title: [121245] trunk/Source/WebKit/blackberry








Revision 121245
Author charles@torchmobile.com.cn
Date 2012-06-26 03:04:40 -0700 (Tue, 26 Jun 2012)


Log Message
[BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
https://bugs.webkit.org/show_bug.cgi?id=89960

Reviewed by Antonio Gomes.

We used to use gesture swipedown to exit fullscreen for plugin, but not fullscreen
HTML5 video; When a swipe down happens, it applies this event to all the pluginviews
in a page, even though only the one in fullscreen mode will process this.

With this patch, the SwipeDown gesture will only apply to the fullscreen elemement,
which is either a plugin, or an Video element.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::notifySwipeEvent):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (121244 => 121245)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-26 09:42:06 UTC (rev 121244)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-26 10:04:40 UTC (rev 121245)
@@ -5572,8 +5572,10 @@
 
 void WebPage::notifySwipeEvent()
 {
-FOR_EACH_PLUGINVIEW(d-m_pluginViews)
-   (*it)-handleSwipeEvent();
+if (d-m_fullScreenPluginView.get())
+   d-m_fullScreenPluginView-handleSwipeEvent();
+else
+   notifyFullScreenVideoExited(true);
 }
 
 void WebPage::notifyScreenPowerStateChanged(bool powered)


Modified: trunk/Source/WebKit/blackberry/ChangeLog (121244 => 121245)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-06-26 09:42:06 UTC (rev 121244)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-06-26 10:04:40 UTC (rev 121245)
@@ -1,3 +1,20 @@
+2012-06-26  Charles Wei  charles@torchmobile.com.cn
+
+[BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
+https://bugs.webkit.org/show_bug.cgi?id=89960
+
+Reviewed by Antonio Gomes.
+
+We used to use gesture swipedown to exit fullscreen for plugin, but not fullscreen
+HTML5 video; When a swipe down happens, it applies this event to all the pluginviews
+in a page, even though only the one in fullscreen mode will process this.
+
+With this patch, the SwipeDown gesture will only apply to the fullscreen elemement,
+which is either a plugin, or an Video element.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPage::notifySwipeEvent):
+
 2012-06-25  Leo Yang  leo.y...@torchmobile.com.cn
 
 [BlackBerry] Fill more data in device motion event






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121246] trunk

[pdr]

Title: [121246] trunk








Revision 121246
Author p...@google.com
Date 2012-06-26 03:06:34 -0700 (Tue, 26 Jun 2012)


Log Message
Fix setCurrentTime for paused animations
https://bugs.webkit.org/show_bug.cgi?id=81350

Reviewed by Nikolas Zimmermann.

Source/WebCore:

SMILTimeContainer::setElapsed was not resetting the pause time, breaking
setCurrentTime if the animation was paused.

Test: svg/custom/animate-pause-resume.html

* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed):

LayoutTests:

This test does not use the SVG animation test framework because the framework
works by pausing animations and testing animated values at fixed times
(through calling setCurrentTime). Testing this patch requires that we run
the animation and cannot be tested with the animation test framework.

* svg/custom/animate-pause-resume-expected.txt: Added.
* svg/custom/animate-pause-resume.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp


Added Paths

trunk/LayoutTests/svg/custom/animate-pause-resume-expected.txt
trunk/LayoutTests/svg/custom/animate-pause-resume.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121245 => 121246)

--- trunk/LayoutTests/ChangeLog	2012-06-26 10:04:40 UTC (rev 121245)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 10:06:34 UTC (rev 121246)
@@ -1,3 +1,18 @@
+2012-06-26  Philip Rogers  p...@google.com
+
+Fix setCurrentTime for paused animations
+https://bugs.webkit.org/show_bug.cgi?id=81350
+
+Reviewed by Nikolas Zimmermann.
+
+This test does not use the SVG animation test framework because the framework
+works by pausing animations and testing animated values at fixed times
+(through calling setCurrentTime). Testing this patch requires that we run
+the animation and cannot be tested with the animation test framework.
+
+* svg/custom/animate-pause-resume-expected.txt: Added.
+* svg/custom/animate-pause-resume.html: Added.
+
 2012-06-26  Tony Chang  t...@chromium.org
 
 [Qt] Enable grid layout LayoutTests


Added: trunk/LayoutTests/svg/custom/animate-pause-resume-expected.txt (0 => 121246)

--- trunk/LayoutTests/svg/custom/animate-pause-resume-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/custom/animate-pause-resume-expected.txt	2012-06-26 10:06:34 UTC (rev 121246)
@@ -0,0 +1 @@
+PASS


Added: trunk/LayoutTests/svg/custom/animate-pause-resume.html (0 => 121246)

--- trunk/LayoutTests/svg/custom/animate-pause-resume.html	(rev 0)
+++ trunk/LayoutTests/svg/custom/animate-pause-resume.html	2012-06-26 10:06:34 UTC (rev 121246)
@@ -0,0 +1,37 @@
+!DOCTYPE HTML
+html
+!--
+Test for WK81350: setCurrentTime() should work when animation is paused.
+--
+body
+svg id=svg width=400 height=400
+rect id=rect x=0 y=0 width=100 height=100 fill=green
+animate attributeName=x from=200 to=400 begin=0s dur=4s /
+/rect
+/svg
+script
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+var svg = document.getElementById(svg);
+var rect = document.getElementById(rect);
+
+svg.pauseAnimations();
+setTimeout(function() {
+svg.setCurrentTime(4);
+svg.unpauseAnimations();
+setTimeout(function() {
+if (rect.x.animVal.value == 0)
+document.body.innerHTML = PASS;
+else
+document.body.innerHTML = FAIL : rect.x.animVal.value was  + rect.x.animVal.value +  but we expected 0.;
+
+if (window.testRunner)
+testRunner.notifyDone();
+}, 1);
+}, 50);
+/script
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (121245 => 121246)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 10:04:40 UTC (rev 121245)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 10:06:34 UTC (rev 121246)
@@ -1,3 +1,18 @@
+2012-06-26  Philip Rogers  p...@google.com
+
+Fix setCurrentTime for paused animations
+https://bugs.webkit.org/show_bug.cgi?id=81350
+
+Reviewed by Nikolas Zimmermann.
+
+SMILTimeContainer::setElapsed was not resetting the pause time, breaking
+setCurrentTime if the animation was paused.
+
+Test: svg/custom/animate-pause-resume.html
+
+* svg/animation/SMILTimeContainer.cpp:
+(WebCore::SMILTimeContainer::setElapsed):
+
 2012-06-26  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Unreviewed typo fix after r121144.


Modified: trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp (121245 => 121246)

--- trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp	2012-06-26 10:04:40 UTC (rev 121245)
+++ trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp	2012-06-26 10:06:34 UTC (rev 121246)
@@ -131,8 +131,12 @@
 if 

[webkit-changes] [121247] trunk/Tools

[ossy]

Title: [121247] trunk/Tools








Revision 121247
Author o...@webkit.org
Date 2012-06-26 03:11:28 -0700 (Tue, 26 Jun 2012)


Log Message
Unreviewed, rolling out r121244.
http://trac.webkit.org/changeset/121244
https://bugs.webkit.org/show_bug.cgi?id=89966

skip list path is incorrect now. (Requested by Ossy on
#webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-06-26

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.baseline_search_path):
(QtPort._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (121246 => 121247)

--- trunk/Tools/ChangeLog	2012-06-26 10:06:34 UTC (rev 121246)
+++ trunk/Tools/ChangeLog	2012-06-26 10:11:28 UTC (rev 121247)
@@ -1,3 +1,18 @@
+2012-06-26  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r121244.
+http://trac.webkit.org/changeset/121244
+https://bugs.webkit.org/show_bug.cgi?id=89966
+
+skip list path is incorrect now. (Requested by Ossy on
+#webkit).
+
+* Scripts/webkitpy/layout_tests/port/qt.py:
+(QtPort.baseline_search_path):
+(QtPort._skipped_file_search_paths):
+* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
+(QtPortTest.test_baseline_search_path):
+
 2012-06-26  János Badics  jbad...@inf.u-szeged.hu
 
 [Qt][NRWT] Fix baseline and skipped file search path.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py (121246 => 121247)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py	2012-06-26 10:06:34 UTC (rev 121246)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py	2012-06-26 10:11:28 UTC (rev 121247)
@@ -106,16 +106,7 @@
 version = '4.8'
 return version
 
-def _search_paths(self):
-# Qt port uses same paths for baseline_search_path and _skipped_file_search_paths
-#
-# qt-5.0-wk1qt-5.0-wk2
-#\/
-# qt-5.0qt-4.8
-#\/
-#(qt-linux|qt-mac|qt-win)
-#|
-#   qt
+def baseline_search_path(self):
 search_paths = []
 version = self.qt_version()
 if '5.0' in version:
@@ -123,21 +114,26 @@
 search_paths.append('qt-5.0-wk2')
 else:
 search_paths.append('qt-5.0-wk1')
+search_paths.append(self.name())
 if '4.8' in version:
 search_paths.append('qt-4.8')
 elif version:
 search_paths.append('qt-5.0')
-search_paths.append(self.port_name + '-' + self.host.platform.os_name)
 search_paths.append(self.port_name)
-return search_paths
+return map(self._webkit_baseline_path, search_paths)
 
-def baseline_search_path(self):
-return map(self._webkit_baseline_path, self._search_paths())
-
 def _skipped_file_search_paths(self):
-skipped_path = self._search_paths()
-skipped_path.append('wk2')
-return skipped_path
+search_paths = set([self.port_name, self.name()])
+version = self.qt_version()
+if '4.8' in version:
+search_paths.add('qt-4.8')
+elif version:
+search_paths.add('qt-5.0')
+if self.get_option('webkit_test_runner'):
+search_paths.update(['qt-5.0-wk2', 'wk2'])
+else:
+search_paths.add('qt-5.0-wk1')
+return search_paths
 
 def setup_environ_for_server(self, server_name=None):
 clean_env = WebKitPort.setup_environ_for_server(self, server_name)


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py (121246 => 121247)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py	2012-06-26 10:06:34 UTC (rev 121246)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py	2012-06-26 10:11:28 UTC (rev 121247)
@@ -60,21 +60,21 @@
 return 'QMake version 2.01a\nUsing Qt version 5.0.0 in /usr/local/Trolltech/Qt-5.0.0/lib'
 
 def test_baseline_search_path(self):
-self._assert_search_path(['qt-4.8', 'qt-mac', 'qt'], 'mac', qt_version='4.8')
-self._assert_search_path(['qt-4.8', 'qt-win', 'qt'], 'win', qt_version='4.8')
-self._assert_search_path(['qt-4.8', 'qt-linux', 'qt'], 'linux', qt_version='4.8')
+self._assert_search_path(['qt-mac', 'qt-4.8', 'qt'], 'mac', qt_version='4.8')
+self._assert_search_path(['qt-win', 'qt-4.8', 'qt'], 'win', qt_version='4.8')
+self._assert_search_path(['qt-linux', 'qt-4.8', 'qt'], 'linux', qt_version='4.8')
 
-self._assert_search_path(['qt-4.8', 'qt-mac', 'qt'], 'mac')
-self._assert_search_path(['qt-4.8', 'qt-win', 'qt'], 'win')
-

[webkit-changes] [121248] trunk/Tools

[jocelyn . turcotte]

Title: [121248] trunk/Tools








Revision 121248
Author jocelyn.turco...@nokia.com
Date 2012-06-26 03:16:05 -0700 (Tue, 26 Jun 2012)


Log Message
Add a note about hostname completion not working well with --cc completion

Reviewed by Simon Hausmann.

Hostname completion tries to resolve anything after an @ sign which is present
in the completed list of contributor emails to CC.

* Scripts/webkit-tools-completion.sh:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkit-tools-completion.sh




Diff

Modified: trunk/Tools/ChangeLog (121247 => 121248)

--- trunk/Tools/ChangeLog	2012-06-26 10:11:28 UTC (rev 121247)
+++ trunk/Tools/ChangeLog	2012-06-26 10:16:05 UTC (rev 121248)
@@ -1,3 +1,14 @@
+2012-06-25  Jocelyn Turcotte  turcott...@gmail.com
+
+Add a note about hostname completion not working well with --cc completion
+
+Reviewed by Simon Hausmann.
+
+Hostname completion tries to resolve anything after an @ sign which is present
+in the completed list of contributor emails to CC.
+
+* Scripts/webkit-tools-completion.sh:
+
 2012-06-26  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r121244.


Modified: trunk/Tools/Scripts/webkit-tools-completion.sh (121247 => 121248)

--- trunk/Tools/Scripts/webkit-tools-completion.sh	2012-06-26 10:11:28 UTC (rev 121247)
+++ trunk/Tools/Scripts/webkit-tools-completion.sh	2012-06-26 10:16:05 UTC (rev 121248)
@@ -39,6 +39,7 @@
 
 __webkit-patch_upload_cc_generate_reply()
 {
+# Note: This won't work well if hostname completion is enabled, disable it with: shopt -u hostcomplete
 # Completion is done on tokens and our comma-separated list is one single token, so we have to do completion on the whole list each time.
 # Return a \n separated list for each possible bugzilla email completion of the substring following the last comma.
 # Redirect strerr to /dev/null to prevent noise in the shell if this ever breaks somehow.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121249] trunk/Source/WebCore

[jocelyn . turcotte]

Title: [121249] trunk/Source/WebCore








Revision 121249
Author jocelyn.turco...@nokia.com
Date 2012-06-26 03:17:44 -0700 (Tue, 26 Jun 2012)


Log Message
GraphicsSurface: Fix IOSurfaceLock failures on Intel video cards.
https://bugs.webkit.org/show_bug.cgi?id=89883

Reviewed by Noam Rosenthal.

Follow the documentation which says: If locking the buffer requires a readback,
the lock will fail with an error return of kIOReturnCannotLock.
Also make sure that we use the same set of flags when locking and unlocking
for simplicity and to follow this requirement on the kIOSurfaceLockReadOnly flag.

* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121248 => 121249)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 10:16:05 UTC (rev 121248)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 10:17:44 UTC (rev 121249)
@@ -1,3 +1,19 @@
+2012-06-25  Jocelyn Turcotte  turcott...@gmail.com
+
+GraphicsSurface: Fix IOSurfaceLock failures on Intel video cards.
+https://bugs.webkit.org/show_bug.cgi?id=89883
+
+Reviewed by Noam Rosenthal.
+
+Follow the documentation which says: If locking the buffer requires a readback,
+the lock will fail with an error return of kIOReturnCannotLock.
+Also make sure that we use the same set of flags when locking and unlocking
+for simplicity and to follow this requirement on the kIOSurfaceLockReadOnly flag.
+
+* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
+(WebCore::GraphicsSurface::platformLock):
+(WebCore::GraphicsSurface::platformUnlock):
+
 2012-06-26  Philip Rogers  p...@google.com
 
 Fix setCurrentTime for paused animations


Modified: trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp (121248 => 121249)

--- trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp	2012-06-26 10:16:05 UTC (rev 121248)
+++ trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp	2012-06-26 10:17:44 UTC (rev 121249)
@@ -168,18 +168,14 @@
 return options;
 }
 
-static int ioSurfaceUnlockOptions(int lockOptions)
-{
-int options = 0;
-if (lockOptions  GraphicsSurface::ReadOnly)
-options |= (kIOSurfaceLockAvoidSync | kIOSurfaceLockReadOnly);
-return options;
-}
-
 char* GraphicsSurface::platformLock(const IntRect rect, int* outputStride, LockOptions lockOptions)
 {
 m_lockOptions = lockOptions;
-IOSurfaceLock(m_platformSurface, ioSurfaceLockOptions(m_lockOptions), 0);
+IOReturn status = IOSurfaceLock(m_platformSurface, ioSurfaceLockOptions(m_lockOptions), 0);
+if (status == kIOReturnCannotLock) {
+m_lockOptions |= RetainPixels;
+IOSurfaceLock(m_platformSurface, ioSurfaceLockOptions(m_lockOptions), 0);
+}
 
 int stride = IOSurfaceGetBytesPerRow(m_platformSurface);
 if (outputStride)
@@ -191,7 +187,7 @@
 
 void GraphicsSurface::platformUnlock()
 {
-IOSurfaceUnlock(m_platformSurface, ioSurfaceUnlockOptions(m_lockOptions)  (~kIOSurfaceLockAvoidSync), 0);
+IOSurfaceUnlock(m_platformSurface, ioSurfaceLockOptions(m_lockOptions), 0);
 }
 
 void GraphicsSurface::platformDestroy()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121250] trunk/Source/WebCore

[jocelyn . turcotte]

Title: [121250] trunk/Source/WebCore








Revision 121250
Author jocelyn.turco...@nokia.com
Date 2012-06-26 03:19:20 -0700 (Tue, 26 Jun 2012)


Log Message
[Qt] GraphicsSurface: Fix tile update artifacts on Mac
https://bugs.webkit.org/show_bug.cgi?id=89887

Reviewed by Noam Rosenthal.

* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformCopyToGLTexture):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121249 => 121250)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 10:17:44 UTC (rev 121249)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 10:19:20 UTC (rev 121250)
@@ -1,5 +1,15 @@
 2012-06-25  Jocelyn Turcotte  turcott...@gmail.com
 
+[Qt] GraphicsSurface: Fix tile update artifacts on Mac
+https://bugs.webkit.org/show_bug.cgi?id=89887
+
+Reviewed by Noam Rosenthal.
+
+* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
+(WebCore::GraphicsSurface::platformCopyToGLTexture):
+
+2012-06-25  Jocelyn Turcotte  turcott...@gmail.com
+
 GraphicsSurface: Fix IOSurfaceLock failures on Intel video cards.
 https://bugs.webkit.org/show_bug.cgi?id=89883
 


Modified: trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp (121249 => 121250)

--- trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp	2012-06-26 10:17:44 UTC (rev 121249)
+++ trunk/Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp	2012-06-26 10:19:20 UTC (rev 121250)
@@ -88,6 +88,12 @@
 glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_RECTANGLE_ARB, 0, 0);
 glBindFramebuffer(GL_READ_FRAMEBUFFER, 0);
 glPopAttrib();
+
+// According to IOSurface's documentation, glBindFramebuffer is the one triggering an update of the surface's cache.
+// If the web process starts rendering and unlocks the surface before this happens, we might copy contents
+// of the currently rendering frame on our texture instead of the previously completed frame.
+// Flush the command buffer to reduce the odds of this happening, this would not be necessary with double buffering.
+glFlush();
 }
 
 void GraphicsSurface::platformCopyFromFramebuffer(uint32_t originFbo, const IntRect sourceRect)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121251] trunk

[kinuko]

Title: [121251] trunk








Revision 121251
Author kin...@chromium.org
Date 2012-06-26 03:26:26 -0700 (Tue, 26 Jun 2012)


Log Message
Web Inspector: Add requestMetadata command and metadataReceived event to FileSystem
https://bugs.webkit.org/show_bug.cgi?id=87856

Patch by Taiju Tsuiki t...@chromium.org on 2012-06-26
Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/filesystem/get-metadata.html

* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._directoryContentReceived):
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.Entry.prototype.get isDirectory):
(WebInspector.FileSystemModel.Entry.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype._directoryContentReceived):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager.prototype._metadataReceived):
(WebInspector.FileSystemDispatcher.prototype.directoryContentReceived):
(WebInspector.FileSystemDispatcher.prototype.metadataReceived):

LayoutTests:

* http/tests/inspector/filesystem/filesystem-test.js:
(initialize_FileSystemTest.InspectorTest.writeFile):
(initialize_FileSystemTest.InspectorTest.dumpMetadataRequestResult):
(initialize_FileSystemTest):
(writeFile.didGetFileSystem):
(writeFile):
(writeFile.didGetWriter.writer.onwrite):
(writeFile.didGetWriter):
* http/tests/inspector/filesystem/get-metadata-expected.txt: Added.
* http/tests/inspector/filesystem/get-metadata.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/filesystem/filesystem-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorFileSystemAgent.cpp
trunk/Source/WebCore/inspector/InspectorFileSystemAgent.h
trunk/Source/WebCore/inspector/front-end/FileSystemModel.js


Added Paths

trunk/LayoutTests/http/tests/inspector/filesystem/get-metadata-expected.txt
trunk/LayoutTests/http/tests/inspector/filesystem/get-metadata.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121250 => 121251)

--- trunk/LayoutTests/ChangeLog	2012-06-26 10:19:20 UTC (rev 121250)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 10:26:26 UTC (rev 121251)
@@ -1,3 +1,21 @@
+2012-06-26  Taiju Tsuiki  t...@chromium.org
+
+Web Inspector: Add requestMetadata command and metadataReceived event to FileSystem
+https://bugs.webkit.org/show_bug.cgi?id=87856
+
+Reviewed by Yury Semikhatsky.
+
+* http/tests/inspector/filesystem/filesystem-test.js:
+(initialize_FileSystemTest.InspectorTest.writeFile):
+(initialize_FileSystemTest.InspectorTest.dumpMetadataRequestResult):
+(initialize_FileSystemTest):
+(writeFile.didGetFileSystem):
+(writeFile):
+(writeFile.didGetWriter.writer.onwrite):
+(writeFile.didGetWriter):
+* http/tests/inspector/filesystem/get-metadata-expected.txt: Added.
+* http/tests/inspector/filesystem/get-metadata.html: Added.
+
 2012-06-26  Philip Rogers  p...@google.com
 
 Fix setCurrentTime for paused animations


Modified: trunk/LayoutTests/http/tests/inspector/filesystem/filesystem-test.js (121250 => 121251)

--- trunk/LayoutTests/http/tests/inspector/filesystem/filesystem-test.js	2012-06-26 10:19:20 UTC (rev 121250)
+++ trunk/LayoutTests/http/tests/inspector/filesystem/filesystem-test.js	2012-06-26 10:26:26 UTC (rev 121251)
@@ -29,6 +29,11 @@
 InspectorTest.evaluateInPage(createFile(unescape(\ + escape(path) + \),  + InspectorTest.registerCallback(callback) + ));
 };
 
+InspectorTest.writeFile = function(path, content, callback)
+{
+InspectorTest.evaluateInPage(writeFile(unescape(\ + escape(path) + \), unescape(\ + escape(content) + \),  + InspectorTest.registerCallback(callback) + ));
+};
+
 InspectorTest.clearFileSystem = function(callback)
 {
 InspectorTest.evaluateInPage(clearFileSystem( + InspectorTest.registerCallback(callback) + ));
@@ -50,6 +55,18 @@
 InspectorTest.addResult( + j + :  + entries[i][j]);
 }
 };
+
+InspectorTest.dumpMetadataRequestResult = function(errorCode, metadata)
+{
+InspectorTest.addResult(errorCode:  + errorCode);
+if (metadata) {
+InspectorTest.addResult(metadata:);
+InspectorTest.addResult(  modificationTime:  + (modificationTime in metadata ? (exists) : (null)));
+InspectorTest.addResult(  size:  + (size in metadata 

[webkit-changes] [121252] trunk/LayoutTests

[commit-queue]

Title: [121252] trunk/LayoutTests








Revision 121252
Author commit-qu...@webkit.org
Date 2012-06-26 03:36:21 -0700 (Tue, 26 Jun 2012)


Log Message
[GTK] Assert failure in fast/canvas/canvas-createImageData.html for 64bit Debug bot
https://bugs.webkit.org/show_bug.cgi?id=89647

Unreviewed, update GTK test expectations.

r121215 has fixed the assertion failure, so the test doesn't crash
anymore.

Patch by Simon Pena sp...@igalia.com on 2012-06-26

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (121251 => 121252)

--- trunk/LayoutTests/ChangeLog	2012-06-26 10:26:26 UTC (rev 121251)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 10:36:21 UTC (rev 121252)
@@ -1,3 +1,15 @@
+2012-06-26  Simon Pena  sp...@igalia.com
+
+[GTK] Assert failure in fast/canvas/canvas-createImageData.html for 64bit Debug bot
+https://bugs.webkit.org/show_bug.cgi?id=89647
+
+Unreviewed, update GTK test expectations.
+
+r121215 has fixed the assertion failure, so the test doesn't crash
+anymore.
+
+* platform/gtk/TestExpectations:
+
 2012-06-26  Taiju Tsuiki  t...@chromium.org
 
 Web Inspector: Add requestMetadata command and metadataReceived event to FileSystem


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (121251 => 121252)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-26 10:26:26 UTC (rev 121251)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-26 10:36:21 UTC (rev 121252)
@@ -360,8 +360,6 @@
 
 BUGWK89188 RELEASE : storage/websql/quota-tracking.html = CRASH PASS
 
-BUGWK89647 DEBUG : fast/canvas/canvas-createImageData.html = CRASH
-
 BUGWK89954 DEBUG : http/tests/xmlhttprequest/reentrant-cancel.html = CRASH
 
 //






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121253] trunk/Source/WebCore

[commit-queue]

Title: [121253] trunk/Source/WebCore








Revision 121253
Author commit-qu...@webkit.org
Date 2012-06-26 04:27:55 -0700 (Tue, 26 Jun 2012)


Log Message
[EFL] REGRESSION (r121163): fast/frames/iframe-access-screen-of-deleted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=89964

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-06-26
Reviewed by Andreas Kling.

Added missing null pointer check.

* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/PlatformScreenEfl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121252 => 121253)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 10:36:21 UTC (rev 121252)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 11:27:55 UTC (rev 121253)
@@ -1,3 +1,16 @@
+2012-06-26  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[EFL] REGRESSION (r121163): fast/frames/iframe-access-screen-of-deleted.html crashes
+https://bugs.webkit.org/show_bug.cgi?id=89964
+
+Reviewed by Andreas Kling.
+
+Added missing null pointer check.
+
+* platform/efl/PlatformScreenEfl.cpp:
+(WebCore::screenDepth):
+(WebCore::screenDepthPerComponent):
+
 2012-06-26  Taiju Tsuiki  t...@chromium.org
 
 Web Inspector: Add requestMetadata command and metadataReceived event to FileSystem


Modified: trunk/Source/WebCore/platform/efl/PlatformScreenEfl.cpp (121252 => 121253)

--- trunk/Source/WebCore/platform/efl/PlatformScreenEfl.cpp	2012-06-26 10:36:21 UTC (rev 121252)
+++ trunk/Source/WebCore/platform/efl/PlatformScreenEfl.cpp	2012-06-26 11:27:55 UTC (rev 121253)
@@ -58,7 +58,7 @@
 
 int screenDepth(Widget* widget)
 {
-if (!widget-evas())
+if (!widget || !widget-evas())
 return 0;
 
 return getPixelDepth(widget-evas());
@@ -66,7 +66,7 @@
 
 int screenDepthPerComponent(Widget* widget)
 {
-if (!widget-evas())
+if (!widget || !widget-evas())
 return 0;
 
 // FIXME: How to support this functionality based on EFL library ?






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121254] trunk/Source/WebCore

[commit-queue]

Title: [121254] trunk/Source/WebCore








Revision 121254
Author commit-qu...@webkit.org
Date 2012-06-26 05:10:58 -0700 (Tue, 26 Jun 2012)


Log Message
[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
https://bugs.webkit.org/show_bug.cgi?id=89655

Patch by Christophe Dumez christophe.du...@intel.com on 2012-06-26
Reviewed by Csaba Osztrogonác.

Simplify the implementation of SharedBuffer::createWithContentsOfFile()
in EFL port.

No new test, no behavior change.

* platform/efl/SharedBufferEfl.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/SharedBufferEfl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121253 => 121254)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 11:27:55 UTC (rev 121253)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 12:10:58 UTC (rev 121254)
@@ -1,3 +1,18 @@
+2012-06-26  Christophe Dumez  christophe.du...@intel.com
+
+[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
+https://bugs.webkit.org/show_bug.cgi?id=89655
+
+Reviewed by Csaba Osztrogonác.
+
+Simplify the implementation of SharedBuffer::createWithContentsOfFile()
+in EFL port.
+
+No new test, no behavior change.
+
+* platform/efl/SharedBufferEfl.cpp:
+(WebCore::SharedBuffer::createWithContentsOfFile):
+
 2012-06-26  Thiago Marcos P. Santos  thiago.san...@intel.com
 
 [EFL] REGRESSION (r121163): fast/frames/iframe-access-screen-of-deleted.html crashes


Modified: trunk/Source/WebCore/platform/efl/SharedBufferEfl.cpp (121253 => 121254)

--- trunk/Source/WebCore/platform/efl/SharedBufferEfl.cpp	2012-06-26 11:27:55 UTC (rev 121253)
+++ trunk/Source/WebCore/platform/efl/SharedBufferEfl.cpp	2012-06-26 12:10:58 UTC (rev 121254)
@@ -39,32 +39,24 @@
 
 PassRefPtrSharedBuffer SharedBuffer::createWithContentsOfFile(const String filePath)
 {
-FILE* file;
-struct stat fileStat;
-RefPtrSharedBuffer result;
-
 if (filePath.isEmpty())
 return 0;
 
-if (!(file = fopen(filePath.utf8().data(), rb)))
+FILE* file = fopen(filePath.utf8().data(), rb);
+if (!file)
 return 0;
 
+struct stat fileStat;
 if (fstat(fileno(file), fileStat)) {
 fclose(file);
 return 0;
 }
 
-result = SharedBuffer::create();
-result-m_buffer.resize(fileStat.st_size);
-if (result-m_buffer.size() != static_castunsigned(fileStat.st_size)) {
-fclose(file);
-return 0;
-}
-
-const size_t bytesRead = fread(result-m_buffer.data(), 1, fileStat.st_size, file);
+Vectorchar buffer(fileStat.st_size);
+const size_t bytesRead = fread(buffer.data(), 1, buffer.size(), file);
 fclose(file);
 
-return bytesRead == static_castunsigned(fileStat.st_size) ? result.release() : 0;
+return (bytesRead == buffer.size()) ? SharedBuffer::adoptVector(buffer) : 0;
 }
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121255] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [121255] trunk/Source/WebKit/blackberry








Revision 121255
Author commit-qu...@webkit.org
Date 2012-06-26 05:17:41 -0700 (Tue, 26 Jun 2012)


Log Message
[BlackBerry] Limit session storage quota to 5MB by default
https://bugs.webkit.org/show_bug.cgi?id=89941

Patch by Jonathan Dong jonathan.d...@torchmobile.com.cn on 2012-06-26
Reviewed by Rob Buis.

Limit session storage quota to 5MB by default for BlackBerry
porting.
Internally reviewed by George Staikos.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::sessionStorageQuota):
(BlackBerry::WebKit::WebSettings::setSessionStorageQuota):
* Api/WebSettings.h:

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebSettings.cpp
trunk/Source/WebKit/blackberry/Api/WebSettings.h
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (121254 => 121255)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-26 12:10:58 UTC (rev 121254)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-26 12:17:41 UTC (rev 121255)
@@ -6312,6 +6312,7 @@
 coreSettings-setOfflineWebApplicationCacheEnabled(webSettings-isAppCacheEnabled());
 
 m_page-group().groupSettings()-setLocalStorageQuotaBytes(webSettings-localStorageQuota());
+coreSettings-setSessionStorageQuota(webSettings-sessionStorageQuota());
 coreSettings-setUsesPageCache(webSettings-maximumPagesInCache());
 coreSettings-setFrameFlatteningEnabled(webSettings-isFrameFlatteningEnabled());
 #endif


Modified: trunk/Source/WebKit/blackberry/Api/WebSettings.cpp (121254 => 121255)

--- trunk/Source/WebKit/blackberry/Api/WebSettings.cpp	2012-06-26 12:10:58 UTC (rev 121254)
+++ trunk/Source/WebKit/blackberry/Api/WebSettings.cpp	2012-06-26 12:17:41 UTC (rev 121255)
@@ -76,6 +76,7 @@
 DEFINE_STATIC_LOCAL(String, WebKitLocalStorageEnabled, (WebKitLocalStorageEnabled));
 DEFINE_STATIC_LOCAL(String, WebKitLocalStoragePath, (WebKitLocalStoragePath));
 DEFINE_STATIC_LOCAL(String, WebKitLocalStorageQuota, (WebKitLocalStorageQuota));
+DEFINE_STATIC_LOCAL(String, WebKitSessionStorageQuota, (WebKitSessionStorageQuota));
 DEFINE_STATIC_LOCAL(String, WebKitMaximumPagesInCache, (WebKitMaximumPagesInCache));
 DEFINE_STATIC_LOCAL(String, WebKitMinimumFontSize, (WebKitMinimumFontSize));
 DEFINE_STATIC_LOCAL(String, WebKitOfflineWebApplicationCacheEnabled, (WebKitOfflineWebApplicationCacheEnabled));
@@ -180,6 +181,7 @@
 settings-m_private-setBoolean(WebKitJavaScriptEnabled, true);
 settings-m_private-setBoolean(WebKitLoadsImagesAutomatically, true);
 settings-m_private-setUnsignedLongLong(WebKitLocalStorageQuota, 5 * 1024 * 1024);
+settings-m_private-setUnsignedLongLong(WebKitSessionStorageQuota, 5 * 1024 * 1024);
 settings-m_private-setInteger(WebKitMaximumPagesInCache, 0);
 settings-m_private-setInteger(WebKitMinimumFontSize, 8);
 settings-m_private-setBoolean(WebKitWebSocketsEnabled, true);
@@ -599,6 +601,16 @@
 m_private-setUnsignedLongLong(WebKitLocalStorageQuota, quota);
 }
 
+unsigned long long WebSettings::sessionStorageQuota() const
+{
+return m_private-getUnsignedLongLong(WebKitSessionStorageQuota);
+}
+
+void WebSettings::setSessionStorageQuota(unsigned long long quota)
+{
+m_private-setUnsignedLongLong(WebKitSessionStorageQuota, quota);
+}
+
 int WebSettings::maximumPagesInCache() const
 {
 // FIXME: We shouldn't be calling into WebCore from here. This class should just be a state store.


Modified: trunk/Source/WebKit/blackberry/Api/WebSettings.h (121254 => 121255)

--- trunk/Source/WebKit/blackberry/Api/WebSettings.h	2012-06-26 12:10:58 UTC (rev 121254)
+++ trunk/Source/WebKit/blackberry/Api/WebSettings.h	2012-06-26 12:17:41 UTC (rev 121255)
@@ -168,6 +168,8 @@
 
 unsigned long long localStorageQuota() const;
 void setLocalStorageQuota(unsigned long long);
+unsigned long long sessionStorageQuota() const;
+void setSessionStorageQuota(unsigned long long);
 
 // Page cache
 void setMaximumPagesInCache(int);


Modified: trunk/Source/WebKit/blackberry/ChangeLog (121254 => 121255)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-06-26 12:10:58 UTC (rev 121254)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-06-26 12:17:41 UTC (rev 121255)
@@ -1,3 +1,23 @@
+2012-06-26  Jonathan Dong  jonathan.d...@torchmobile.com.cn
+
+[BlackBerry] Limit session storage quota to 5MB by default
+https://bugs.webkit.org/show_bug.cgi?id=89941
+
+Reviewed by Rob Buis.
+
+Limit session storage quota to 5MB by default for BlackBerry
+porting.
+Internally reviewed by George Staikos.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
+* Api/WebSettings.cpp:
+(WebKit):
+

[webkit-changes] [121256] trunk/Source/WebCore

[yurys]

Title: [121256] trunk/Source/WebCore








Revision 121256
Author yu...@chromium.org
Date 2012-06-26 05:32:38 -0700 (Tue, 26 Jun 2012)


Log Message
Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS
https://bugs.webkit.org/show_bug.cgi?id=89955

Reviewed by Vsevolod Vlasov.

Show object popover for all heap snapshot nodes event for those whose
canBeQueried flag is false. We didn't show popover for such objects before
as it could lead to the backend crash. In the meantime the backend shouldn't
fail on such DOM wrappers and report an error if it cannot resolve
inspected object.

* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (121255 => 121256)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 12:17:41 UTC (rev 121255)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 12:32:38 UTC (rev 121256)
@@ -1,3 +1,22 @@
+2012-06-26  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS
+https://bugs.webkit.org/show_bug.cgi?id=89955
+
+Reviewed by Vsevolod Vlasov.
+
+Show object popover for all heap snapshot nodes event for those whose
+canBeQueried flag is false. We didn't show popover for such objects before
+as it could lead to the backend crash. In the meantime the backend shouldn't
+fail on such DOM wrappers and report an error if it cannot resolve
+inspected object.
+
+* inspector/front-end/HeapSnapshotGridNodes.js:
+(WebInspector.HeapSnapshotGenericObjectNode):
+(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
+* inspector/front-end/HeapSnapshotView.js:
+(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
+
 2012-06-26  Christophe Dumez  christophe.du...@intel.com
 
 [EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js (121255 => 121256)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js	2012-06-26 12:17:41 UTC (rev 121255)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js	2012-06-26 12:32:38 UTC (rev 121256)
@@ -91,7 +91,7 @@
 node.dispose();
 },
 
-hasHoverMessage: false,
+_reachableFromWindow: false,
 
 queryObjectContent: function(callback)
 {
@@ -356,12 +356,12 @@
 this.snapshotNodeId = node.id;
 this.snapshotNodeIndex = node.nodeIndex;
 if (this._type === string)
-this.hasHoverMessage = true;
+this._reachableFromWindow = true;
 else if (this._type === object  this.isWindow(this._name)) {
 this._name = this.shortenWindowURL(this._name, false);
-this.hasHoverMessage = true;
+this._reachableFromWindow = true;
 } else if (node.flags  tree.snapshot.nodeFlags.canBeQueried)
-this.hasHoverMessage = true;
+this._reachableFromWindow = true;
 if (node.flags  tree.snapshot.nodeFlags.detachedDOMTreeNode)
 this.detachedDOMTreeNode = true;
 };
@@ -435,7 +435,7 @@
 value += [];
 break;
 };
-if (this.hasHoverMessage)
+if (this._reachableFromWindow)
 valueStyle +=  highlight;
 if (value === Object)
 value = ;


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js (121255 => 121256)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js	2012-06-26 12:17:41 UTC (rev 121255)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js	2012-06-26 12:32:38 UTC (rev 121256)
@@ -562,10 +562,7 @@
 var row = target.enclosingNodeOrSelfWithNodeName(tr);
 if (!row)
 return;
-var gridNode = row._dataGridNode;
-if (!gridNode.hasHoverMessage)
-return;
-span.node = gridNode;
+span.node = row._dataGridNode;
 return span;
 },
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121257] trunk/LayoutTests

[commit-queue]

Title: [121257] trunk/LayoutTests








Revision 121257
Author commit-qu...@webkit.org
Date 2012-06-26 05:49:12 -0700 (Tue, 26 Jun 2012)


Log Message
[EFL] Gardening of new passing tests
https://bugs.webkit.org/show_bug.cgi?id=89970

Unreviewed gardening.

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-06-26

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (121256 => 121257)

--- trunk/LayoutTests/ChangeLog	2012-06-26 12:32:38 UTC (rev 121256)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 12:49:12 UTC (rev 121257)
@@ -1,3 +1,12 @@
+2012-06-26  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[EFL] Gardening of new passing tests
+https://bugs.webkit.org/show_bug.cgi?id=89970
+
+Unreviewed gardening.
+
+* platform/efl/TestExpectations:
+
 2012-06-26  Simon Pena  sp...@igalia.com
 
 [GTK] Assert failure in fast/canvas/canvas-createImageData.html for 64bit Debug bot


Modified: trunk/LayoutTests/platform/efl/TestExpectations (121256 => 121257)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-06-26 12:32:38 UTC (rev 121256)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-06-26 12:49:12 UTC (rev 121257)
@@ -574,8 +574,6 @@
 // Times-out with debug build during heavy cpu loads
 BUGWK85902 SLOW DEBUG : fast/overflow/lots-of-sibling-inline-boxes.html = PASS
 
-BUGWK82675 : http/tests/local/link-stylesheet-load-order.html = TEXT
-
 BUGWKEFL SLOW DEBUG : http/tests/incremental/slow-utf8-html.pl = PASS
 
 // Tests imported in r116658






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121258] trunk

[pdr]

Title: [121258] trunk








Revision 121258
Author p...@google.com
Date 2012-06-26 05:56:13 -0700 (Tue, 26 Jun 2012)


Log Message
Fix bug where animations failed to start
https://bugs.webkit.org/show_bug.cgi?id=89943

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The unpause code previously checked that the animations had not started
before un-setting the pause state. This meant that if an animation was
paused and unpaused before the animations started, it would remain in the
paused state. This patch simply reorders the unpause logic to fix this bug.

Test: svg/custom/animate-initial-pause-unpause.html

* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::resume):

LayoutTests:

* svg/custom/animate-initial-pause-unpause-expected.txt: Added.
* svg/custom/animate-initial-pause-unpause.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp


Added Paths

trunk/LayoutTests/svg/custom/animate-initial-pause-unpause-expected.txt
trunk/LayoutTests/svg/custom/animate-initial-pause-unpause.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121257 => 121258)

--- trunk/LayoutTests/ChangeLog	2012-06-26 12:49:12 UTC (rev 121257)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 12:56:13 UTC (rev 121258)
@@ -1,3 +1,13 @@
+2012-06-26  Philip Rogers  p...@google.com
+
+Fix bug where animations failed to start
+https://bugs.webkit.org/show_bug.cgi?id=89943
+
+Reviewed by Nikolas Zimmermann.
+
+* svg/custom/animate-initial-pause-unpause-expected.txt: Added.
+* svg/custom/animate-initial-pause-unpause.html: Added.
+
 2012-06-26  Thiago Marcos P. Santos  thiago.san...@intel.com
 
 [EFL] Gardening of new passing tests


Added: trunk/LayoutTests/svg/custom/animate-initial-pause-unpause-expected.txt (0 => 121258)

--- trunk/LayoutTests/svg/custom/animate-initial-pause-unpause-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/custom/animate-initial-pause-unpause-expected.txt	2012-06-26 12:56:13 UTC (rev 121258)
@@ -0,0 +1 @@
+PASS


Added: trunk/LayoutTests/svg/custom/animate-initial-pause-unpause.html (0 => 121258)

--- trunk/LayoutTests/svg/custom/animate-initial-pause-unpause.html	(rev 0)
+++ trunk/LayoutTests/svg/custom/animate-initial-pause-unpause.html	2012-06-26 12:56:13 UTC (rev 121258)
@@ -0,0 +1,36 @@
+!DOCTYPE HTML
+html
+!--
+Test for WK89943: pausing and unpausing an animation before it starts should have no effect.
+--
+body
+svg id=svg width=400 height=400
+rect x=0 y=0 width=100 height=100 fill=red/
+rect id=rect x=100 y=0 width=100 height=100 fill=green
+set attributeName=x to=0 begin=0.01s fill=freeze/
+/rect
+/svg
+script
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+var svg = document.getElementById(svg);
+var rect = document.getElementById(rect);
+
+svg.pauseAnimations();
+svg.unpauseAnimations();
+
+setTimeout(function() {
+if (rect.x.animVal.value == 0)
+document.body.innerHTML = PASS;
+else
+document.body.innerHTML = FAIL : rect.x.animVal.value was  + rect.x.animVal.value +  but we expected 0.;
+
+if (window.testRunner)
+testRunner.notifyDone();
+}, 50);
+/script
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (121257 => 121258)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 12:49:12 UTC (rev 121257)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 12:56:13 UTC (rev 121258)
@@ -1,3 +1,20 @@
+2012-06-26  Philip Rogers  p...@google.com
+
+Fix bug where animations failed to start
+https://bugs.webkit.org/show_bug.cgi?id=89943
+
+Reviewed by Nikolas Zimmermann.
+
+The unpause code previously checked that the animations had not started
+before un-setting the pause state. This meant that if an animation was
+paused and unpaused before the animations started, it would remain in the
+paused state. This patch simply reorders the unpause logic to fix this bug.
+
+Test: svg/custom/animate-initial-pause-unpause.html
+
+* svg/animation/SMILTimeContainer.cpp:
+(WebCore::SMILTimeContainer::resume):
+
 2012-06-26  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS


Modified: trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp (121257 => 121258)

--- trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp	2012-06-26 12:49:12 UTC (rev 121257)
+++ trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp	2012-06-26 12:56:13 UTC (rev 121258)
@@ -112,10 +112,11 @@
 
 void SMILTimeContainer::resume()
 {
-if (!m_beginTime)
-return;
 ASSERT(isPaused());
-

[webkit-changes] [121259] trunk/Source/WebCore

[commit-queue]

Title: [121259] trunk/Source/WebCore








Revision 121259
Author commit-qu...@webkit.org
Date 2012-06-26 06:07:17 -0700 (Tue, 26 Jun 2012)


Log Message
Shader compiler unprepared to make ESSL output when GLES is used
https://bugs.webkit.org/show_bug.cgi?id=87718

Patch by Roland Takacs takacs.rol...@stud.u-szeged.hu on 2012-06-26
Reviewed by Noam Rosenthal.

Defined a new member that says what type of output code must be generated
(SH_GLSL_OUTPUT, SH_ESSL_OUTPUT). It is set within the constructor.

* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::validateShaderSource):
* platform/graphics/ANGLEWebKitBridge.h:
(ANGLEWebKitBridge):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp
trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h
trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121258 => 121259)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 12:56:13 UTC (rev 121258)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 13:07:17 UTC (rev 121259)
@@ -1,3 +1,21 @@
+2012-06-26  Roland Takacs  takacs.rol...@stud.u-szeged.hu
+
+Shader compiler unprepared to make ESSL output when GLES is used
+https://bugs.webkit.org/show_bug.cgi?id=87718
+
+Reviewed by Noam Rosenthal.
+
+Defined a new member that says what type of output code must be generated
+(SH_GLSL_OUTPUT, SH_ESSL_OUTPUT). It is set within the constructor.
+
+* platform/graphics/ANGLEWebKitBridge.cpp:
+(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
+(WebCore::ANGLEWebKitBridge::validateShaderSource):
+* platform/graphics/ANGLEWebKitBridge.h:
+(ANGLEWebKitBridge):
+* platform/graphics/qt/GraphicsContext3DQt.cpp:
+(WebCore::GraphicsContext3D::GraphicsContext3D):
+
 2012-06-26  Philip Rogers  p...@google.com
 
 Fix bug where animations failed to start


Modified: trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp (121258 => 121259)

--- trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp	2012-06-26 12:56:13 UTC (rev 121258)
+++ trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp	2012-06-26 13:07:17 UTC (rev 121259)
@@ -32,11 +32,11 @@
 
 namespace WebCore {
 
-
-ANGLEWebKitBridge::ANGLEWebKitBridge() :
+ANGLEWebKitBridge::ANGLEWebKitBridge(ShShaderOutput shaderOutput) :
 builtCompilers(false),
 m_fragmentCompiler(0),
-m_vertexCompiler(0)
+m_vertexCompiler(0),
+m_shaderOutput(shaderOutput)
 {
 ShInitialize();
 }
@@ -69,8 +69,8 @@
 bool ANGLEWebKitBridge::validateShaderSource(const char* shaderSource, ANGLEShaderType shaderType, String translatedShaderSource, String shaderValidationLog)
 {
 if (!builtCompilers) {
-m_fragmentCompiler = ShConstructCompiler(SH_FRAGMENT_SHADER, SH_WEBGL_SPEC, SH_GLSL_OUTPUT, m_resources);
-m_vertexCompiler = ShConstructCompiler(SH_VERTEX_SHADER, SH_WEBGL_SPEC, SH_GLSL_OUTPUT, m_resources);
+m_fragmentCompiler = ShConstructCompiler(SH_FRAGMENT_SHADER, SH_WEBGL_SPEC, m_shaderOutput, m_resources);
+m_vertexCompiler = ShConstructCompiler(SH_VERTEX_SHADER, SH_WEBGL_SPEC, m_shaderOutput, m_resources);
 if (!m_fragmentCompiler || !m_vertexCompiler) {
 cleanupCompilers();
 return false;


Modified: trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h (121258 => 121259)

--- trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h	2012-06-26 12:56:13 UTC (rev 121258)
+++ trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h	2012-06-26 13:07:17 UTC (rev 121259)
@@ -47,7 +47,7 @@
 class ANGLEWebKitBridge {
 public:
 
-ANGLEWebKitBridge();
+ANGLEWebKitBridge(ShShaderOutput = SH_GLSL_OUTPUT);
 ~ANGLEWebKitBridge();
 
 ShBuiltInResources getResources() { return m_resources; }
@@ -64,6 +64,8 @@
 ShHandle m_fragmentCompiler;
 ShHandle m_vertexCompiler;
 
+ShShaderOutput m_shaderOutput;
+
 ShBuiltInResources m_resources;
 };
 


Modified: trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp (121258 => 121259)

--- trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp	2012-06-26 12:56:13 UTC (rev 121258)
+++ trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp	2012-06-26 13:07:17 UTC (rev 121259)
@@ -313,6 +313,7 @@
 GraphicsContext3D::GraphicsContext3D(GraphicsContext3D::Attributes attrs, HostWindow* hostWindow, bool)
 : m_currentWidth(0)
 , m_currentHeight(0)
+, m_compiler(isGLES2Compliant() ? SH_ESSL_OUTPUT : SH_GLSL_OUTPUT)
 , m_attrs(attrs)
 , m_texture(0)
 , m_compositorTexture(0)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [121260] trunk/Source/WebCore

[commit-queue]

Title: [121260] trunk/Source/WebCore








Revision 121260
Author commit-qu...@webkit.org
Date 2012-06-26 06:09:25 -0700 (Tue, 26 Jun 2012)


Log Message
[Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.
https://bugs.webkit.org/show_bug.cgi?id=89924

bytesPerLine == targetRect.width() / 4 is invalid.
This patch amended it into bytesPerLine == targetRect.width() * 4.
Moreover, changed magic number 4 to bytesPerPixel.

Patch by Huang Dongsung luxte...@company100.net on 2012-06-26
Reviewed by Noam Rosenthal.

No new tests. Covered by existing tests.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121259 => 121260)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 13:07:17 UTC (rev 121259)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 13:09:25 UTC (rev 121260)
@@ -1,3 +1,19 @@
+2012-06-26  Huang Dongsung  luxte...@company100.net
+
+[Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.
+https://bugs.webkit.org/show_bug.cgi?id=89924
+
+bytesPerLine == targetRect.width() / 4 is invalid.
+This patch amended it into bytesPerLine == targetRect.width() * 4.
+Moreover, changed magic number 4 to bytesPerPixel.
+
+Reviewed by Noam Rosenthal.
+
+No new tests. Covered by existing tests.
+
+* platform/graphics/texmap/TextureMapperGL.cpp:
+(WebCore::BitmapTextureGL::updateContents):
+
 2012-06-26  Roland Takacs  takacs.rol...@stud.u-szeged.hu
 
 Shader compiler unprepared to make ESSL output when GLES is used


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (121259 => 121260)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2012-06-26 13:07:17 UTC (rev 121259)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2012-06-26 13:09:25 UTC (rev 121260)
@@ -474,7 +474,8 @@
 {
 GL_CMD(glBindTexture(GL_TEXTURE_2D, m_id));
 
-if (bytesPerLine == targetRect.width() / 4  sourceOffset == IntPoint::zero()) {
+const unsigned bytesPerPixel = 4;
+if (bytesPerLine == targetRect.width() * bytesPerPixel  sourceOffset == IntPoint::zero()) {
 GL_CMD(glTexSubImage2D(GL_TEXTURE_2D, 0, targetRect.x(), targetRect.y(), targetRect.width(), targetRect.height(), GL_RGBA, DEFAULT_TEXTURE_PIXEL_TRANSFER_TYPE, (const char*)data));
 return;
 }
@@ -482,11 +483,11 @@
 // For ES drivers that don't support sub-images.
 if (!driverSupportsSubImage()) {
 const char* bits = static_castconst char*(data);
-const char* src = "" + sourceOffset.y() * bytesPerLine + sourceOffset.x() * 4;
-Vectorchar temporaryData(targetRect.width() * targetRect.height() * 4);
+const char* src = "" + sourceOffset.y() * bytesPerLine + sourceOffset.x() * bytesPerPixel;
+Vectorchar temporaryData(targetRect.width() * targetRect.height() * bytesPerPixel);
 char* dst = temporaryData.data();
 
-const int targetBytesPerLine = targetRect.width() * 4;
+const int targetBytesPerLine = targetRect.width() * bytesPerPixel;
 for (int y = 0; y  targetRect.height(); ++y) {
 memcpy(dst, src, targetBytesPerLine);
 src += bytesPerLine;
@@ -499,7 +500,7 @@
 
 #if !defined(TEXMAP_OPENGL_ES_2)
 // Use the OpenGL sub-image extension, now that we know it's available.
-GL_CMD(glPixelStorei(GL_UNPACK_ROW_LENGTH, bytesPerLine / 4));
+GL_CMD(glPixelStorei(GL_UNPACK_ROW_LENGTH, bytesPerLine / bytesPerPixel));
 GL_CMD(glPixelStorei(GL_UNPACK_SKIP_ROWS, sourceOffset.y()));
 GL_CMD(glPixelStorei(GL_UNPACK_SKIP_PIXELS, sourceOffset.x()));
 GL_CMD(glTexSubImage2D(GL_TEXTURE_2D, 0, targetRect.x(), targetRect.y(), targetRect.width(), targetRect.height(), GL_RGBA, DEFAULT_TEXTURE_PIXEL_TRANSFER_TYPE, (const char*)data));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121261] trunk

[hausmann]

Title: [121261] trunk








Revision 121261
Author hausm...@webkit.org
Date 2012-06-26 07:01:12 -0700 (Tue, 26 Jun 2012)


Log Message
[Qt][Win] Symbols are not exported in QtWebKit5.dll
https://bugs.webkit.org/show_bug.cgi?id=88873

Reviewed by Tor Arne Vestbø.

Source/WebKit:

* api.pri: Remove MAKEDLL setting done now in win32/default_post.prf.

Tools:

When linking the target dll make sure to re-export the symbols from
the static libraries marked as export, with the help of a little python
script and a qmake extra compiler.

* Scripts/generate-win32-export-forwards: Added.
* qmake/mkspecs/features/win32/default_post.prf:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/api.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/win32/default_post.prf


Added Paths

trunk/Tools/Scripts/generate-win32-export-forwards




Diff

Modified: trunk/Source/WebKit/ChangeLog (121260 => 121261)

--- trunk/Source/WebKit/ChangeLog	2012-06-26 13:09:25 UTC (rev 121260)
+++ trunk/Source/WebKit/ChangeLog	2012-06-26 14:01:12 UTC (rev 121261)
@@ -1,3 +1,12 @@
+2012-06-26  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt][Win] Symbols are not exported in QtWebKit5.dll
+https://bugs.webkit.org/show_bug.cgi?id=88873
+
+Reviewed by Tor Arne Vestbø.
+
+* api.pri: Remove MAKEDLL setting done now in win32/default_post.prf.
+
 2012-06-25  Simon Hausmann  simon.hausm...@nokia.com
 
 Unreviewed build fix: Don't do QT += widgets with Qt 4


Modified: trunk/Source/api.pri (121260 => 121261)

--- trunk/Source/api.pri	2012-06-26 13:09:25 UTC (rev 121260)
+++ trunk/Source/api.pri	2012-06-26 14:01:12 UTC (rev 121261)
@@ -144,8 +144,6 @@
 
 !no_webkit1: WEBKIT += webkit1
 
-!static: DEFINES += QT_MAKEDLL
-
 # - Install rules -
 
 haveQt(5) {


Modified: trunk/Tools/ChangeLog (121260 => 121261)

--- trunk/Tools/ChangeLog	2012-06-26 13:09:25 UTC (rev 121260)
+++ trunk/Tools/ChangeLog	2012-06-26 14:01:12 UTC (rev 121261)
@@ -1,3 +1,17 @@
+2012-06-26  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt][Win] Symbols are not exported in QtWebKit5.dll
+https://bugs.webkit.org/show_bug.cgi?id=88873
+
+Reviewed by Tor Arne Vestbø.
+
+When linking the target dll make sure to re-export the symbols from
+the static libraries marked as export, with the help of a little python
+script and a qmake extra compiler.
+
+* Scripts/generate-win32-export-forwards: Added.
+* qmake/mkspecs/features/win32/default_post.prf:
+
 2012-06-25  Jocelyn Turcotte  turcott...@gmail.com
 
 Add a note about hostname completion not working well with --cc completion


Added: trunk/Tools/Scripts/generate-win32-export-forwards (0 => 121261)

--- trunk/Tools/Scripts/generate-win32-export-forwards	(rev 0)
+++ trunk/Tools/Scripts/generate-win32-export-forwards	2012-06-26 14:01:12 UTC (rev 121261)
@@ -0,0 +1,48 @@
+#!/usr/bin/env python
+
+#Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies)
+
+#This library is free software; you can redistribute it and/or
+#modify it under the terms of the GNU Library General Public
+#License as published by the Free Software Foundation; either
+#version 2 of the License, or (at your option) any later version.
+
+#This library is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+#Library General Public License for more details.
+
+#You should have received a copy of the GNU Library General Public License
+#along with this library; see the file COPYING.LIB.  If not, write to
+#the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+#Boston, MA 02110-1301, USA.
+
+# Extract /EXPORT: linker directives from static library and write it into a
+# separate file as linker pragmas.
+# Usage: generate-win32-export-forwards \path\to\static\library.lib outputfile.cpp
+# Then compile outputfile.cpp into the final .dll and link the static library
+# into the dll.
+
+import subprocess
+import sys
+import re
+
+dumpBin = subprocess.Popen(dumpbin /directives  + sys.argv[1], stdout=subprocess.PIPE, universal_newlines=True);
+
+output, errors = dumpBin.communicate();
+
+exportedSymbolRegexp = re.compile(\s*(?Psymbol/EXPORT:.+));
+
+symbols = set()
+
+for line in output.splitlines():
+match = exportedSymbolRegexp.match(line)
+if match != None:
+symbols.add(match.group(symbol))
+
+print Forwarding %s symbols from static library %s % (len(symbols), sys.argv[1])
+
+exportFile = open(sys.argv[2], w)
+for symbol in symbols:
+exportFile.write(#pragma comment(linker, \%s\)\n % symbol);
+exportFile.close()
Property changes on: trunk/Tools/Scripts/generate-win32-export-forwards
___


Added: svn:executable

Modified: 

[webkit-changes] [121262] trunk/LayoutTests

[commit-queue]

Title: [121262] trunk/LayoutTests








Revision 121262
Author commit-qu...@webkit.org
Date 2012-06-26 07:39:59 -0700 (Tue, 26 Jun 2012)


Log Message
[Qt] Baseline missing for 3D transforms tests.
https://bugs.webkit.org/show_bug.cgi?id=89973

Patch by Allan Sandfeld Jensen allan.jen...@nokia.com on 2012-06-26
Reviewed by Csaba Osztrogonác.

Unskip the transforms/3d/hit-testing, and skip one failing transforms/3d/point-mapping test.
Add missing baselines for all unskipped 3D transforms tests.

* platform/qt/Skipped:
* platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
* platform/qt/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped


Added Paths

trunk/LayoutTests/platform/qt/transforms/3d/
trunk/LayoutTests/platform/qt/transforms/3d/hit-testing/
trunk/LayoutTests/platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt
trunk/LayoutTests/platform/qt/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt
trunk/LayoutTests/platform/qt/transforms/3d/point-mapping/
trunk/LayoutTests/platform/qt/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt
trunk/LayoutTests/platform/qt/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt
trunk/LayoutTests/platform/qt/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt
trunk/LayoutTests/platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt
trunk/LayoutTests/platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.txt
trunk/LayoutTests/platform/qt/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt
trunk/LayoutTests/platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (121261 => 121262)

--- trunk/LayoutTests/ChangeLog	2012-06-26 14:01:12 UTC (rev 121261)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 14:39:59 UTC (rev 121262)
@@ -1,3 +1,24 @@
+2012-06-26  Allan Sandfeld Jensen  allan.jen...@nokia.com
+
+[Qt] Baseline missing for 3D transforms tests.
+https://bugs.webkit.org/show_bug.cgi?id=89973
+
+Reviewed by Csaba Osztrogonác.
+
+Unskip the transforms/3d/hit-testing, and skip one failing transforms/3d/point-mapping test.
+Add missing baselines for all unskipped 3D transforms tests.
+
+* platform/qt/Skipped:
+* platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
+* platform/qt/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
+* platform/qt/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
+* platform/qt/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
+* platform/qt/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
+* platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
+* platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
+* platform/qt/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
+* platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
+
 2012-06-26  Philip Rogers  p...@google.com
 
 Fix bug where animations failed to start


Modified: trunk/LayoutTests/platform/qt/Skipped (121261 => 121262)

--- trunk/LayoutTests/platform/qt/Skipped	2012-06-26 14:01:12 UTC (rev 121261)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-06-26 14:39:59 UTC (rev 121262)
@@ -264,8 +264,8 @@
 transforms/3d/general/perspective-non-layer.html
 transforms/3d/general/perspective-units.html
 
-# backface-visibility: hidden is not hiding test boxes.
-transforms/3d/hit-testing
+# Small rounding error.
+transforms/3d/point-mapping/3d-point-mapping-origins.html
 
 # accessibility support
 accessibility


Added: trunk/LayoutTests/platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt (0 => 121262)

--- trunk/LayoutTests/platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt	2012-06-26 14:39:59 UTC (rev 121262)
@@ -0,0 +1,24 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600

[webkit-changes] [121263] trunk/Tools

[ossy]

Title: [121263] trunk/Tools








Revision 121263
Author o...@webkit.org
Date 2012-06-26 08:00:43 -0700 (Tue, 26 Jun 2012)


Log Message
master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
https://bugs.webkit.org/show_bug.cgi?id=89215

We need it because it is deprecated and will be dropped in buildbot 0.8.7

Reviewed by Tony Chang.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CheckOutSource.__init__):
(Factory.__init__):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (121262 => 121263)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-06-26 14:39:59 UTC (rev 121262)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-06-26 15:00:43 UTC (rev 121263)
@@ -114,10 +114,14 @@
 class CheckOutSource(source.SVN):
 baseURL = http://svn.webkit.org/repository/webkit/
 mode = update
-def __init__(self, *args, **kwargs):
-source.SVN.__init__(self, baseURL=self.baseURL, defaultBranch=trunk, mode=self.mode, *args, **kwargs)
+def __init__(self, **kwargs):
+kwargs['baseURL'] = self.baseURL
+kwargs['defaultBranch'] = trunk
+kwargs['mode'] = self.mode
+source.SVN.__init__(self, **kwargs)
 
 
+
 class InstallWin32Dependencies(shell.Compile):
 description = [installing dependencies]
 descriptionDone = [installed dependencies]
@@ -663,7 +667,7 @@
 def __init__(self, platform, configuration, architectures, buildOnly):
 factory.BuildFactory.__init__(self)
 self.addStep(ConfigureBuild, platform=platform, configuration=configuration, architecture= .join(architectures), buildOnly=buildOnly)
-self.addStep(CheckOutSource)
+self.addStep(CheckOutSource())
 # There are multiple Qt slaves running on same machines, so buildslaves shouldn't kill the processes of other slaves.
 if not platform.startswith(qt):
 self.addStep(KillOldProcesses)


Modified: trunk/Tools/ChangeLog (121262 => 121263)

--- trunk/Tools/ChangeLog	2012-06-26 14:39:59 UTC (rev 121262)
+++ trunk/Tools/ChangeLog	2012-06-26 15:00:43 UTC (rev 121263)
@@ -1,3 +1,16 @@
+2012-06-26  Csaba Osztrogonác  o...@webkit.org
+
+master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
+https://bugs.webkit.org/show_bug.cgi?id=89215
+
+We need it because it is deprecated and will be dropped in buildbot 0.8.7
+
+Reviewed by Tony Chang.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(CheckOutSource.__init__):
+(Factory.__init__):
+
 2012-06-26  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt][Win] Symbols are not exported in QtWebKit5.dll






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121264] trunk/Source/WebKit/chromium

[shawnsingh]

Title: [121264] trunk/Source/WebKit/chromium








Revision 121264
Author shawnsi...@chromium.org
Date 2012-06-26 09:20:07 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements
https://bugs.webkit.org/show_bug.cgi?id=89931

Reviewed by James Robinson.

WEBKIT_IMPLEMENTATION is defined as either 0 or 1, so the usage of
#ifdef or #if have different behavior. There are some places in
the code that use #ifdef WEBKIT_IMLPEMENTATION, but they should
actually be #if WEBKIT_IMPLEMENTATION. This patch fixes those
#ifdef statements.

* public/WebTextRun.h:
(WebTextRun):
* public/linux/WebFontRenderStyle.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebTextRun.h
trunk/Source/WebKit/chromium/public/linux/WebFontRenderStyle.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (121263 => 121264)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-06-26 15:00:43 UTC (rev 121263)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-06-26 16:20:07 UTC (rev 121264)
@@ -1,3 +1,20 @@
+2012-06-26  Shawn Singh  shawnsi...@chromium.org
+
+[chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements
+https://bugs.webkit.org/show_bug.cgi?id=89931
+
+Reviewed by James Robinson.
+
+WEBKIT_IMPLEMENTATION is defined as either 0 or 1, so the usage of
+#ifdef or #if have different behavior. There are some places in
+the code that use #ifdef WEBKIT_IMLPEMENTATION, but they should
+actually be #if WEBKIT_IMPLEMENTATION. This patch fixes those
+#ifdef statements.
+
+* public/WebTextRun.h:
+(WebTextRun):
+* public/linux/WebFontRenderStyle.h:
+
 2012-06-26  Jun Mukai  mu...@chromium.org
 
 Allow using input type=color UI in ChromeOS.


Modified: trunk/Source/WebKit/chromium/public/WebTextRun.h (121263 => 121264)

--- trunk/Source/WebKit/chromium/public/WebTextRun.h	2012-06-26 15:00:43 UTC (rev 121263)
+++ trunk/Source/WebKit/chromium/public/WebTextRun.h	2012-06-26 16:20:07 UTC (rev 121264)
@@ -33,7 +33,7 @@
 
 #include platform/WebString.h
 
-#ifdef WEBKIT_IMPLEMENTATION
+#if WEBKIT_IMPLEMENTATION
 namespace WebCore { class TextRun; }
 #endif
 
@@ -56,7 +56,7 @@
 bool rtl;
 bool directionalOverride;
 
-#ifdef WEBKIT_IMPLEMENTATION
+#if WEBKIT_IMPLEMENTATION
 // The resulting WebCore::TextRun will refer to the text in this
 // struct, so this must outlive the WebCore text run.
 operator WebCore::TextRun() const;


Modified: trunk/Source/WebKit/chromium/public/linux/WebFontRenderStyle.h (121263 => 121264)

--- trunk/Source/WebKit/chromium/public/linux/WebFontRenderStyle.h	2012-06-26 15:00:43 UTC (rev 121263)
+++ trunk/Source/WebKit/chromium/public/linux/WebFontRenderStyle.h	2012-06-26 16:20:07 UTC (rev 121264)
@@ -50,7 +50,7 @@
 char useSubpixelRendering; // use subpixel rendering (partially-filled pixels)
 char useSubpixelPositioning; // use subpixel positioning (fractional X positions for glyphs)
 
-#ifdef WEBKIT_IMPLEMENTATION
+#if WEBKIT_IMPLEMENTATION
 // Translates the members of this struct to a FontRenderStyle
 void toFontRenderStyle(WebCore::FontRenderStyle*);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121265] trunk/Source/WebCore

[commit-queue]

Title: [121265] trunk/Source/WebCore








Revision 121265
Author commit-qu...@webkit.org
Date 2012-06-26 09:30:49 -0700 (Tue, 26 Jun 2012)


Log Message
Web Inspector: Native memory snapshots crash in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=89977

Patch by Alexei Filippov alex...@chromium.org on 2012-06-26
Reviewed by Yury Semikhatsky.

* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::maybeDOMWrapper):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121264 => 121265)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 16:20:07 UTC (rev 121264)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 16:30:49 UTC (rev 121265)
@@ -1,3 +1,13 @@
+2012-06-26  Alexei Filippov  alex...@chromium.org
+
+Web Inspector: Native memory snapshots crash in debug mode.
+https://bugs.webkit.org/show_bug.cgi?id=89977
+
+Reviewed by Yury Semikhatsky.
+
+* bindings/v8/V8DOMWrapper.cpp:
+(WebCore::V8DOMWrapper::maybeDOMWrapper):
+
 2012-06-26  Huang Dongsung  luxte...@company100.net
 
 [Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp (121264 => 121265)

--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp	2012-06-26 16:20:07 UTC (rev 121264)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp	2012-06-26 16:30:49 UTC (rev 121265)
@@ -224,6 +224,7 @@
 
 ASSERT(object-InternalFieldCount() = v8DefaultWrapperInternalFieldCount);
 
+v8::HandleScope scope;
 v8::Handlev8::Value wrapper = object-GetInternalField(v8DOMWrapperObjectIndex);
 ASSERT(wrapper-IsNumber() || wrapper-IsExternal());
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121266] trunk/Tools

[dpranke]

Title: [121266] trunk/Tools








Revision 121266
Author dpra...@chromium.org
Date 2012-06-26 10:01:21 -0700 (Tue, 26 Jun 2012)


Log Message
nrwt: broken for chromium on vista
https://bugs.webkit.org/show_bug.cgi?id=89988

Reviewed by Tony Chang.

r121194 removed support for 'chromium-win-vista' as a separate
port, but this actually prevented the code from running on vista
at all, which is unduly harsh and broke the websocket tests on
the (non-webkit) chromium bots that are still running on vista.

It's probably good enough to pretend that vista is win7 instead;
some layout tests will still fail but at least things'll run.

* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.determine_full_port_name):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_versions):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (121265 => 121266)

--- trunk/Tools/ChangeLog	2012-06-26 16:30:49 UTC (rev 121265)
+++ trunk/Tools/ChangeLog	2012-06-26 17:01:21 UTC (rev 121266)
@@ -1,3 +1,23 @@
+2012-06-26  Dirk Pranke  dpra...@chromium.org
+
+nrwt: broken for chromium on vista
+https://bugs.webkit.org/show_bug.cgi?id=89988
+
+Reviewed by Tony Chang.
+
+r121194 removed support for 'chromium-win-vista' as a separate
+port, but this actually prevented the code from running on vista
+at all, which is unduly harsh and broke the websocket tests on
+the (non-webkit) chromium bots that are still running on vista.
+
+It's probably good enough to pretend that vista is win7 instead;
+some layout tests will still fail but at least things'll run.
+
+* Scripts/webkitpy/layout_tests/port/chromium_win.py:
+(ChromiumWinPort.determine_full_port_name):
+* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
+(ChromiumWinTest.test_versions):
+
 2012-06-26  Csaba Osztrogonác  o...@webkit.org
 
 master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py (121265 => 121266)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py	2012-06-26 16:30:49 UTC (rev 121265)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py	2012-06-26 17:01:21 UTC (rev 121266)
@@ -65,7 +65,8 @@
 def determine_full_port_name(cls, host, options, port_name):
 if port_name.endswith('-win'):
 assert host.platform.is_win()
-if host.platform.os_version in ('7sp0', '7sp1', 'future'):
+# We don't maintain separate baselines for vista, so we pretend it is win7.
+if host.platform.os_version in ('vista', '7sp0', '7sp1', 'future'):
 version = 'win7'
 else:
 version = host.platform.os_version


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py (121265 => 121266)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py	2012-06-26 16:30:49 UTC (rev 121265)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py	2012-06-26 17:01:21 UTC (rev 121266)
@@ -82,9 +82,11 @@
 self.assert_name('chromium-win-xp', '7sp0', 'chromium-win-xp')
 
 self.assert_name(None, '7sp0', 'chromium-win-win7')
+self.assert_name(None, 'vista', 'chromium-win-win7')
 self.assert_name('chromium-win', '7sp0', 'chromium-win-win7')
 self.assert_name('chromium-win-win7', 'xp', 'chromium-win-win7')
 self.assert_name('chromium-win-win7', '7sp0', 'chromium-win-win7')
+self.assert_name('chromium-win-win7', 'vista', 'chromium-win-win7')
 
 self.assertRaises(AssertionError, self.assert_name, None, 'w2k', 'chromium-win-xp')
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121267] trunk/Source/WebCore

[commit-queue]

Title: [121267] trunk/Source/WebCore








Revision 121267
Author commit-qu...@webkit.org
Date 2012-06-26 10:56:46 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] Add the workaround of IOSurface-related corruption during readback on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=89797

Patch by Yasuhiro Matsuda ma...@chromium.org on 2012-06-26
Reviewed by James Robinson.

No new tests. This patch doesn't change behavior.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::getFramebufferPixels):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121266 => 121267)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 17:01:21 UTC (rev 121266)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 17:56:46 UTC (rev 121267)
@@ -1,3 +1,15 @@
+2012-06-26  Yasuhiro Matsuda  ma...@chromium.org
+
+[chromium] Add the workaround of IOSurface-related corruption during readback on Mac OS X.
+https://bugs.webkit.org/show_bug.cgi?id=89797
+
+Reviewed by James Robinson.
+
+No new tests. This patch doesn't change behavior.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::getFramebufferPixels):
+
 2012-06-26  Alexei Filippov  alex...@chromium.org
 
 Web Inspector: Native memory snapshots crash in debug mode.


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (121266 => 121267)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2012-06-26 17:01:21 UTC (rev 121266)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2012-06-26 17:56:46 UTC (rev 121267)
@@ -115,16 +115,10 @@
 return screen;
 }
 
-bool needsLionIOSurfaceReadbackWorkaround()
+bool needsIOSurfaceReadbackWorkaround()
 {
 #if OS(DARWIN)
-static SInt32 systemVersion = 0;
-if (!systemVersion) {
-if (Gestalt(gestaltSystemVersion, systemVersion) != noErr)
-return false;
-}
-
-return systemVersion = 0x1070;
+return true;
 #else
 return false;
 #endif
@@ -1260,13 +1254,13 @@
 
 makeContextCurrent();
 
-bool doWorkaround = needsLionIOSurfaceReadbackWorkaround();
+bool doWorkaround = needsIOSurfaceReadbackWorkaround();
 
 Platform3DObject temporaryTexture = NullPlatform3DObject;
 Platform3DObject temporaryFBO = NullPlatform3DObject;
 
 if (doWorkaround) {
-// On Mac OS X 10.7, calling glReadPixels against an FBO whose color attachment is an
+// On Mac OS X, calling glReadPixels against an FBO whose color attachment is an
 // IOSurface-backed texture causes corruption of future glReadPixels calls, even those on
 // different OpenGL contexts. It is believed that this is the root cause of top crasher
 // http://crbug.com/99393. rdar://problem/10949687






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121268] trunk/Source

[commit-queue]

Title: [121268] trunk/Source








Revision 121268
Author commit-qu...@webkit.org
Date 2012-06-26 11:09:22 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium
https://bugs.webkit.org/show_bug.cgi?id=89933

Patch by James Robinson jam...@chromium.org on 2012-06-26
Reviewed by Kenneth Russell.

Source/WebCore:

GraphicsContext3DPrivate and Extensions3DChromium had a fair amount of plumbing and boilerplate to support the
compositor's use of GraphicsContext3D. A number of extensions, etc, only make sense for a compositor context.
Since the compositor doesn't use GC3D any more, these are no longer needed.

* platform/chromium/support/Extensions3DChromium.cpp:
* platform/chromium/support/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
* platform/chromium/support/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GrMemoryAllocationChangedCallbackAdapter::GrMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DPrivate::grContext):
* platform/chromium/support/GraphicsContext3DPrivate.h:
(WebCore):
(GraphicsContext3DPrivate):
* platform/graphics/chromium/Extensions3DChromium.h:

Source/WebKit/chromium:

* tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp
trunk/Source/WebCore/platform/chromium/support/GraphicsContext3DChromium.cpp
trunk/Source/WebCore/platform/chromium/support/GraphicsContext3DPrivate.cpp
trunk/Source/WebCore/platform/chromium/support/GraphicsContext3DPrivate.h
trunk/Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/Canvas2DLayerBridgeTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121267 => 121268)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 17:56:46 UTC (rev 121267)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 18:09:22 UTC (rev 121268)
@@ -1,3 +1,28 @@
+2012-06-26  James Robinson  jam...@chromium.org
+
+[chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium
+https://bugs.webkit.org/show_bug.cgi?id=89933
+
+Reviewed by Kenneth Russell.
+
+GraphicsContext3DPrivate and Extensions3DChromium had a fair amount of plumbing and boilerplate to support the
+compositor's use of GraphicsContext3D. A number of extensions, etc, only make sense for a compositor context.
+Since the compositor doesn't use GC3D any more, these are no longer needed.
+
+* platform/chromium/support/Extensions3DChromium.cpp:
+* platform/chromium/support/GraphicsContext3DChromium.cpp:
+(WebCore::GraphicsContext3D::~GraphicsContext3D):
+(WebCore::GraphicsContext3D::create):
+* platform/chromium/support/GraphicsContext3DPrivate.cpp:
+(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
+(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
+(WebCore::GrMemoryAllocationChangedCallbackAdapter::GrMemoryAllocationChangedCallbackAdapter):
+(WebCore::GraphicsContext3DPrivate::grContext):
+* platform/chromium/support/GraphicsContext3DPrivate.h:
+(WebCore):
+(GraphicsContext3DPrivate):
+* platform/graphics/chromium/Extensions3DChromium.h:
+
 2012-06-26  Yasuhiro Matsuda  ma...@chromium.org
 
 [chromium] Add the workaround of IOSurface-related corruption during readback on Mac OS X.


Modified: trunk/Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp (121267 => 121268)

--- trunk/Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp	2012-06-26 17:56:46 UTC (rev 121267)
+++ trunk/Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp	2012-06-26 18:09:22 UTC (rev 121268)
@@ -73,11 +73,6 @@
 m_private-webContext()-renderbufferStorageMultisampleCHROMIUM(target, samples, internalformat, width, height);
 }
 
-void Extensions3DChromium::postSubBufferCHROMIUM(int x, int y, int width, int height)
-{
-m_private-webContext()-postSubBufferCHROMIUM(x, y, width, height);
-}
-
 void* Extensions3DChromium::mapBufferSubDataCHROMIUM(unsigned target, int offset, int size, unsigned access)
 {
 return m_private-webContext()-mapBufferSubDataCHROMIUM(target, offset, size, access);
@@ -98,26 +93,6 @@
 m_private-webContext()-unmapTexSubImage2DCHROMIUM(data);
 }
 
-void Extensions3DChromium::setVisibilityCHROMIUM(bool visibility)
-{
-m_private-webContext()-setVisibilityCHROMIUM(visibility);
-}
-
-void Extensions3DChromium::discardFramebufferEXT(GC3Denum target, GC3Dsizei numAttachments, const GC3Denum* attachments)
-{
-

[webkit-changes] [121269] trunk/Tools

[commit-queue]

Title: [121269] trunk/Tools








Revision 121269
Author commit-qu...@webkit.org
Date 2012-06-26 11:27:44 -0700 (Tue, 26 Jun 2012)


Log Message
webkitpy: Make webkit-patch patches-to-review useful
https://bugs.webkit.org/show_bug.cgi?id=89470

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-06-26
Reviewed by Eric Seidel.

webkit-patch patches-to-review will now output the list of
bugs with patches pending for review that has the user on CC,
excluding patches with cq-, sorted by the age of the patch.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.fetch_bugs_from_review_queue):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_from_review_queue):
(MockBugzilla.__init__):
(MockBugzilla.authenticate):
* Scripts/webkitpy/tool/commands/queries.py:
(PatchesToReview):
(PatchesToReview.__init__):
(PatchesToReview._print_report):
(PatchesToReview._generate_report):
(PatchesToReview.execute):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(QueryCommandsTest.test_patches_to_review):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py
trunk/Tools/Scripts/webkitpy/tool/commands/queries.py
trunk/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (121268 => 121269)

--- trunk/Tools/ChangeLog	2012-06-26 18:09:22 UTC (rev 121268)
+++ trunk/Tools/ChangeLog	2012-06-26 18:27:44 UTC (rev 121269)
@@ -1,3 +1,29 @@
+2012-06-26  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+webkitpy: Make webkit-patch patches-to-review useful
+https://bugs.webkit.org/show_bug.cgi?id=89470
+
+Reviewed by Eric Seidel.
+
+webkit-patch patches-to-review will now output the list of
+bugs with patches pending for review that has the user on CC,
+excluding patches with cq-, sorted by the age of the patch.
+
+* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+(BugzillaQueries.fetch_bugs_from_review_queue):
+* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
+(MockBugzillaQueries.fetch_bugs_from_review_queue):
+(MockBugzilla.__init__):
+(MockBugzilla.authenticate):
+* Scripts/webkitpy/tool/commands/queries.py:
+(PatchesToReview):
+(PatchesToReview.__init__):
+(PatchesToReview._print_report):
+(PatchesToReview._generate_report):
+(PatchesToReview.execute):
+* Scripts/webkitpy/tool/commands/queries_unittest.py:
+(QueryCommandsTest.test_patches_to_review):
+
 2012-06-26  Dirk Pranke  dpra...@chromium.org
 
 nrwt: broken for chromium on vista


Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (121268 => 121269)

--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2012-06-26 18:09:22 UTC (rev 121268)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2012-06-26 18:27:44 UTC (rev 121269)
@@ -219,6 +219,14 @@
 return sum([self._fetch_bug(bug_id).reviewed_patches()
 for bug_id in self.fetch_bug_ids_from_pending_commit_list()], [])
 
+def fetch_bugs_from_review_queue(self, cc_email=None):
+query = buglist.cgi?query_format=advancedbug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDfield0-0-0=flagtypes.nametype0-0-0=equalsvalue0-0-0=review?
+
+if cc_email:
+query += emailcc1=1emailtype1=substringemail1=%s % urllib.quote(cc_email)
+
+return self._fetch_bugs_from_advanced_query(query)
+
 def fetch_bug_ids_from_commit_queue(self):
 commit_queue_url = buglist.cgi?query_format=advancedbug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDfield0-0-0=flagtypes.nametype0-0-0=equalsvalue0-0-0=commit-queue%2Border=Last+Changed
 return self._fetch_bug_ids_advanced_query(commit_queue_url)


Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py (121268 => 121269)

--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py	2012-06-26 18:09:22 UTC (rev 121268)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py	2012-06-26 18:27:44 UTC (rev 121269)
@@ -82,7 +82,9 @@
 is_obsolete: False,
 is_patch: True,
 review: ?,
+commit-queue: -,
 attacher_email: e...@webkit.org,
+attach_date: datetime.datetime.today(),
 }
 
 
@@ -266,6 +268,14 @@
 # will return bugs with patches which have r+, but are also obsolete.
 return bug_ids + [50002]
 
+def fetch_bugs_from_review_queue(self, cc_email=None):
+unreviewed_bugs = [bug for bug in self._all_bugs() if bug.unreviewed_patches()]
+
+if cc_email:
+return [bug for bug in unreviewed_bugs if cc_email in bug.cc_emails()]
+
+return unreviewed_bugs
+
 def fetch_patches_from_pending_commit_list(self):
 return 

[webkit-changes] [121270] trunk/Source/WebCore

[commit-queue]

Title: [121270] trunk/Source/WebCore








Revision 121270
Author commit-qu...@webkit.org
Date 2012-06-26 11:34:54 -0700 (Tue, 26 Jun 2012)


Log Message
Do early-return when author and user styles are disabled.
https://bugs.webkit.org/show_bug.cgi?id=89947

Patch by Joe Thomas joetho...@motorola.com on 2012-06-26
Reviewed by Andreas Kling.

* dom/Document.cpp:
(WebCore::Document::collectActiveStylesheets):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121269 => 121270)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 18:27:44 UTC (rev 121269)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 18:34:54 UTC (rev 121270)
@@ -1,3 +1,13 @@
+2012-06-26  Joe Thomas  joetho...@motorola.com
+
+Do early-return when author and user styles are disabled.
+https://bugs.webkit.org/show_bug.cgi?id=89947
+
+Reviewed by Andreas Kling.
+
+* dom/Document.cpp:
+(WebCore::Document::collectActiveStylesheets):
+
 2012-06-26  James Robinson  jam...@chromium.org
 
 [chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium


Modified: trunk/Source/WebCore/dom/Document.cpp (121269 => 121270)

--- trunk/Source/WebCore/dom/Document.cpp	2012-06-26 18:27:44 UTC (rev 121269)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-06-26 18:34:54 UTC (rev 121270)
@@ -3401,14 +3401,11 @@
 
 void Document::collectActiveStylesheets(VectorRefPtrStyleSheet  sheets)
 {
-bool matchAuthorAndUserStyles = true;
-if (Settings* settings = this-settings())
-matchAuthorAndUserStyles = settings-authorAndUserStylesEnabled();
+if (settings()  !settings()-authorAndUserStylesEnabled())
+return;
 
 StyleSheetCandidateListHashSet::iterator begin = m_styleSheetCandidateNodes.begin();
 StyleSheetCandidateListHashSet::iterator end = m_styleSheetCandidateNodes.end();
-if (!matchAuthorAndUserStyles)
-end = begin;
 for (StyleSheetCandidateListHashSet::iterator it = begin; it != end; ++it) {
 Node* n = *it;
 StyleSheet* sheet = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121271] trunk/Source/WebCore

[jpu]

Title: [121271] trunk/Source/WebCore








Revision 121271
Author j...@apple.com
Date 2012-06-26 11:38:56 -0700 (Tue, 26 Jun 2012)


Log Message
On Mac, autocorrection sometimes fails to take place in Safari.
https://bugs.webkit.org/show_bug.cgi?id=89982

Reviewed by Darin Adler.

Existing test was turned off due to intermittent failure, which is caused by autocorrection result depending on user data
that may be altered by previous test runs. Hopefully we can turn the test back on once we have a way to make autocorrection
behave consistently.

Basically we should check the value of shouldCheckForCorrection, not shouldShowCorrectionPanel, to determine if we should
early return in markAndReplaceFor().

* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121270 => 121271)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 18:34:54 UTC (rev 121270)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 18:38:56 UTC (rev 121271)
@@ -1,3 +1,20 @@
+2012-06-26  Jia Pu  j...@apple.com
+
+On Mac, autocorrection sometimes fails to take place in Safari.
+https://bugs.webkit.org/show_bug.cgi?id=89982
+
+Reviewed by Darin Adler.
+
+Existing test was turned off due to intermittent failure, which is caused by autocorrection result depending on user data
+that may be altered by previous test runs. Hopefully we can turn the test back on once we have a way to make autocorrection
+behave consistently.
+
+Basically we should check the value of shouldCheckForCorrection, not shouldShowCorrectionPanel, to determine if we should
+early return in markAndReplaceFor(). 
+
+* editing/Editor.cpp:
+(WebCore::Editor::markAndReplaceFor):
+
 2012-06-26  Joe Thomas  joetho...@motorola.com
 
 Do early-return when author and user styles are disabled.


Modified: trunk/Source/WebCore/editing/Editor.cpp (121270 => 121271)

--- trunk/Source/WebCore/editing/Editor.cpp	2012-06-26 18:34:54 UTC (rev 121270)
+++ trunk/Source/WebCore/editing/Editor.cpp	2012-06-26 18:38:56 UTC (rev 121271)
@@ -2085,7 +2085,7 @@
 if (result-type == TextCheckingTypeLink  selectionOffset  resultLocation + resultLength + 1)
 continue;
 
-if (!(shouldPerformReplacement || shouldShowCorrectionPanel || shouldMarkLink) || !doReplacement)
+if (!(shouldPerformReplacement || shouldCheckForCorrection || shouldMarkLink) || !doReplacement)
 continue;
 
 String replacedString = plainText(rangeToReplace.get());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121272] trunk/LayoutTests

[hclam]

Title: [121272] trunk/LayoutTests








Revision 121272
Author hc...@chromium.org
Date 2012-06-26 11:39:31 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] Mark a layout test as fail
https://bugs.webkit.org/show_bug.cgi?id=89998

compositing/webgl/webgl-nonpremultiplied-blend.html started failing after r121267, give it IMAGE failure.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (121271 => 121272)

--- trunk/LayoutTests/ChangeLog	2012-06-26 18:38:56 UTC (rev 121271)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 18:39:31 UTC (rev 121272)
@@ -1,3 +1,12 @@
+2012-06-26  Alpha Lam  hc...@chromium.org
+
+[chromium] Mark a layout test as fail
+https://bugs.webkit.org/show_bug.cgi?id=89998
+
+compositing/webgl/webgl-nonpremultiplied-blend.html started failing after r121267, give it IMAGE failure.
+
+* platform/chromium/TestExpectations:
+
 2012-06-26  Allan Sandfeld Jensen  allan.jen...@nokia.com
 
 [Qt] Baseline missing for 3D transforms tests.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (121271 => 121272)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-06-26 18:38:56 UTC (rev 121271)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-06-26 18:39:31 UTC (rev 121272)
@@ -3765,3 +3765,6 @@
 BUGWK89936 WIN : svg/custom/js-late-gradient-and-object-creation.svg = IMAGE
 BUGWK89936 WIN : svg/zoom/page/zoom-foreignObject.svg = IMAGE
 BUGWK89936 WIN : fast/css/text-rendering.html = IMAGE+TEXT
+
+// Started failing after r121267.
+BUGWK89998 SNOWLEOPARD RELEASE : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121273] trunk/Source

[commit-queue]

Title: [121273] trunk/Source








Revision 121273
Author commit-qu...@webkit.org
Date 2012-06-26 11:42:29 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] Layer chromium should need a redraw after getting its first non-empty bounds.
https://bugs.webkit.org/show_bug.cgi?id=89784

Patch by Ian Vollick voll...@chromium.org on 2012-06-26
Reviewed by James Robinson.

Previously, we'd only set needs redraw if the old bounds were zero,
and the new bounds were non-zero, but we should actually have
checked that the old bounds were non-empty.

Source/WebCore:

Unit test: LayerChromiumTestWithoutFixture.setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):

Source/WebKit/chromium:

* tests/LayerChromiumTest.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121272 => 121273)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 18:39:31 UTC (rev 121272)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 18:42:29 UTC (rev 121273)
@@ -1,3 +1,19 @@
+2012-06-26  Ian Vollick  voll...@chromium.org
+
+[chromium] Layer chromium should need a redraw after getting its first non-empty bounds.
+https://bugs.webkit.org/show_bug.cgi?id=89784
+
+Reviewed by James Robinson.
+
+Previously, we'd only set needs redraw if the old bounds were zero,
+and the new bounds were non-zero, but we should actually have 
+checked that the old bounds were non-empty.
+
+Unit test: LayerChromiumTestWithoutFixture.setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds
+
+* platform/graphics/chromium/LayerChromium.cpp:
+(WebCore::LayerChromium::setBounds):
+
 2012-06-26  Jia Pu  j...@apple.com
 
 On Mac, autocorrection sometimes fails to take place in Safari.


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp (121272 => 121273)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp	2012-06-26 18:39:31 UTC (rev 121272)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp	2012-06-26 18:42:29 UTC (rev 121273)
@@ -228,7 +228,7 @@
 if (bounds() == size)
 return;
 
-bool firstResize = !bounds().width()  !bounds().height()  size.width()  size.height();
+bool firstResize = bounds().isEmpty()  !size.isEmpty();
 
 m_bounds = size;
 


Modified: trunk/Source/WebKit/chromium/ChangeLog (121272 => 121273)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-06-26 18:39:31 UTC (rev 121272)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-06-26 18:42:29 UTC (rev 121273)
@@ -1,3 +1,16 @@
+2012-06-26  Ian Vollick  voll...@chromium.org
+
+[chromium] Layer chromium should need a redraw after getting its first non-empty bounds.
+https://bugs.webkit.org/show_bug.cgi?id=89784
+
+Reviewed by James Robinson.
+
+Previously, we'd only set needs redraw if the old bounds were zero,
+and the new bounds were non-zero, but we should actually have 
+checked that the old bounds were non-empty.
+
+* tests/LayerChromiumTest.cpp:
+
 2012-06-26  James Robinson  jam...@chromium.org
 
 [chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium


Modified: trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp (121272 => 121273)

--- trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp	2012-06-26 18:39:31 UTC (rev 121272)
+++ trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp	2012-06-26 18:42:29 UTC (rev 121273)
@@ -813,4 +813,20 @@
 WebKit::WebCompositor::shutdown();
 }
 
+class MockLayerChromium : public LayerChromium {
+public:
+bool needsDisplay() const { return m_needsDisplay; }
+};
+
+TEST(LayerChromiumTestWithoutFixture, setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds)
+{
+RefPtrMockLayerChromium layer(adoptRef(new MockLayerChromium));
+EXPECT_FALSE(layer-needsDisplay());
+layer-setBounds(IntSize(0, 10));
+EXPECT_FALSE(layer-needsDisplay());
+layer-setBounds(IntSize(10, 10));
+EXPECT_TRUE(layer-needsDisplay());
+}
+
+
 } // namespace






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121274] branches/chromium/1180

[jchaffraix]

Title: [121274] branches/chromium/1180








Revision 121274
Author jchaffr...@webkit.org
Date 2012-06-26 11:58:44 -0700 (Tue, 26 Jun 2012)


Log Message
Merge 120934 - Non-fixed length margins don't work with align=center
https://bugs.webkit.org/show_bug.cgi?id=89626

Reviewed by Levi Weintraub.

Source/WebCore:

Tests: fast/block/negative-start-margin-align-center-percent.html
   fast/block/positive-margin-block-child-align-center-calc.html

Calling Length::value() is a bad idea as it returns the *raw* value of
the length. For percent and calculated length this is a bad idea as they
bear not relation to the actual computed length.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeInlineDirectionMargins):
Fixed the code to use minimumValueForLength as this nicely takes care of the 'auto' case.

LayoutTests:

* fast/block/negative-start-margin-align-center-percent-expected.html: Added.
* fast/block/negative-start-margin-align-center-percent.html: Added.
* fast/block/positive-margin-block-child-align-center-calc-expected.html: Added.
* fast/block/positive-margin-block-child-align-center-calc.html: Added.


TBR=jchaffr...@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10668050

Modified Paths

branches/chromium/1180/Source/WebCore/rendering/RenderBox.cpp


Added Paths

branches/chromium/1180/LayoutTests/fast/block/negative-start-margin-align-center-percent-expected.html
branches/chromium/1180/LayoutTests/fast/block/negative-start-margin-align-center-percent.html
branches/chromium/1180/LayoutTests/fast/block/positive-margin-block-child-align-center-calc-expected.html
branches/chromium/1180/LayoutTests/fast/block/positive-margin-block-child-align-center-calc.html




Diff

Copied: branches/chromium/1180/LayoutTests/fast/block/negative-start-margin-align-center-percent-expected.html (from rev 120934, trunk/LayoutTests/fast/block/negative-start-margin-align-center-percent-expected.html) (0 => 121274)

--- branches/chromium/1180/LayoutTests/fast/block/negative-start-margin-align-center-percent-expected.html	(rev 0)
+++ branches/chromium/1180/LayoutTests/fast/block/negative-start-margin-align-center-percent-expected.html	2012-06-26 18:58:44 UTC (rev 121274)
@@ -0,0 +1,33 @@
+!DOCTYPE html
+html
+head
+style
+body
+{
+margin: 0px;
+}
+
+.hidTarget
+{
+height: 100px;
+width: 250px;
+position: absolute;
+left: 50px;
+background-color: green;
+}
+
+p
+{
+position: absolute;
+top: 300px;
+}
+/style
+/head
+body
+div class=hidTarget/div
+p
+a href="" Non-fixed length margins don't work with align=centerbr
+There should be a green rectangle above with no red.
+/p
+/body
+/html


Copied: branches/chromium/1180/LayoutTests/fast/block/negative-start-margin-align-center-percent.html (from rev 120934, trunk/LayoutTests/fast/block/negative-start-margin-align-center-percent.html) (0 => 121274)

--- branches/chromium/1180/LayoutTests/fast/block/negative-start-margin-align-center-percent.html	(rev 0)
+++ branches/chromium/1180/LayoutTests/fast/block/negative-start-margin-align-center-percent.html	2012-06-26 18:58:44 UTC (rev 121274)
@@ -0,0 +1,49 @@
+!DOCTYPE html
+html
+head
+style
+body {
+margin: 0px;
+}
+
+.hidTarget
+{
+height: 100px;
+width: 250px;
+position: absolute;
+left: 50px;
+background-color: green;
+}
+
+.sized
+{
+margin-left: 100px;
+width: 200px;
+}
+
+.marginLeft
+{
+font: Ahem 10px;
+height: 100px;
+margin-left: -25%;
+background-color: red;
+}
+
+p
+{
+position: absolute;
+top: 300px;
+}
+/style
+/head
+body
+div class=hidTarget/div
+div align=center class=sized
+div class=marginLeftx x x x/div
+/div
+p
+a href="" Non-fixed length margins don't work with align=centerbr
+There should be a green rectangle above with no red.
+/p
+/body
+/html


Copied: branches/chromium/1180/LayoutTests/fast/block/positive-margin-block-child-align-center-calc-expected.html (from rev 120934, trunk/LayoutTests/fast/block/positive-margin-block-child-align-center-calc-expected.html) (0 => 121274)

--- branches/chromium/1180/LayoutTests/fast/block/positive-margin-block-child-align-center-calc-expected.html	(rev 0)
+++ branches/chromium/1180/LayoutTests/fast/block/positive-margin-block-child-align-center-calc-expected.html	2012-06-26 18:58:44 UTC (rev 121274)
@@ -0,0 +1,32 @@
+!DOCTYPE html
+html
+head
+style
+body
+{
+margin: 0px;
+}
+
+.hidTarget {
+position: absolute;
+left: 100px;
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+p
+{
+position: absolute;
+top: 300px;
+}
+/style
+/head
+body
+div class=hidTarget/div
+p
+a href="" Non-fixed length margins don't work with align=centerbr
+There should be a green rectangle above with no red.
+/p
+/body
+/html


Copied: 

[webkit-changes] [121275] trunk

[jchaffraix]

Title: [121275] trunk








Revision 121275
Author jchaffr...@webkit.org
Date 2012-06-26 12:16:08 -0700 (Tue, 26 Jun 2012)


Log Message
Crash in FixedTableLayout::layout
https://bugs.webkit.org/show_bug.cgi?id=88676

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: fast/table/auto-table-layout-colgroup-removal-crash.html
   fast/table/fixed-table-layout/colgroup-removal-crash.html
   fast/table/fixed-table-layout/prepend-in-fixed-table.html

The issue comes from RenderTable not properly dirtying its preferred logical
widths. As the table layout codes (both fixed and auto), recomputes their internal
structures at computePreferredLogicalWidth, the internal structure doesn't match
the table sizing and we crash.

This fix adds a work-around in FixedTableLayout::layout (which matches AutoTableLayout).
The long-term fix would be to properly fix the logic but this is a lot safer, especially
since our logic is really not bullet-proof at the moment.

* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):
Added an internal structure recomputation, if we have drifted from our table's structure.
Also we need to update nEffCols if we call calcWidthArray.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
Added a comment matching FixedTableLayout. The nEffCols is unneeded but kept for consistency
with FixedTableLayout.

LayoutTests:

* fast/table/auto-table-layout-colgroup-removal-crash-expected.txt: Added.
* fast/table/auto-table-layout-colgroup-removal-crash.html: Added.
* fast/table/fixed-table-layout/colgroup-removal-crash-expected.txt: Added.
* fast/table/fixed-table-layout/colgroup-removal-crash.html: Added.
2 cases where we remove a colgroup after having done layout.

* fast/table/fixed-table-layout/prepend-in-fixed-table-expected.txt: Added.
* fast/table/fixed-table-layout/prepend-in-fixed-table.html: Added.
This is a copy of fast/table/prepend-in-anonymous-table.html modified to work with
fixed table layout. This covers a bug found during testing that is fixed as part of
this broader change.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/AutoTableLayout.cpp
trunk/Source/WebCore/rendering/FixedTableLayout.cpp


Added Paths

trunk/LayoutTests/fast/table/auto-table-layout-colgroup-removal-crash-expected.txt
trunk/LayoutTests/fast/table/auto-table-layout-colgroup-removal-crash.html
trunk/LayoutTests/fast/table/fixed-table-layout/colgroup-removal-crash-expected.txt
trunk/LayoutTests/fast/table/fixed-table-layout/colgroup-removal-crash.html
trunk/LayoutTests/fast/table/fixed-table-layout/prepend-in-fixed-table-expected.txt
trunk/LayoutTests/fast/table/fixed-table-layout/prepend-in-fixed-table.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121274 => 121275)

--- trunk/LayoutTests/ChangeLog	2012-06-26 18:58:44 UTC (rev 121274)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 19:16:08 UTC (rev 121275)
@@ -1,3 +1,22 @@
+2012-06-26  Julien Chaffraix  jchaffr...@webkit.org
+
+Crash in FixedTableLayout::layout
+https://bugs.webkit.org/show_bug.cgi?id=88676
+
+Reviewed by Abhishek Arya.
+
+* fast/table/auto-table-layout-colgroup-removal-crash-expected.txt: Added.
+* fast/table/auto-table-layout-colgroup-removal-crash.html: Added.
+* fast/table/fixed-table-layout/colgroup-removal-crash-expected.txt: Added.
+* fast/table/fixed-table-layout/colgroup-removal-crash.html: Added.
+2 cases where we remove a colgroup after having done layout.
+
+* fast/table/fixed-table-layout/prepend-in-fixed-table-expected.txt: Added.
+* fast/table/fixed-table-layout/prepend-in-fixed-table.html: Added.
+This is a copy of fast/table/prepend-in-anonymous-table.html modified to work with
+fixed table layout. This covers a bug found during testing that is fixed as part of
+this broader change.
+
 2012-06-26  Alpha Lam  hc...@chromium.org
 
 [chromium] Mark a layout test as fail


Added: trunk/LayoutTests/fast/table/auto-table-layout-colgroup-removal-crash-expected.txt (0 => 121275)

--- trunk/LayoutTests/fast/table/auto-table-layout-colgroup-removal-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/table/auto-table-layout-colgroup-removal-crash-expected.txt	2012-06-26 19:16:08 UTC (rev 121275)
@@ -0,0 +1,5 @@
+Bug 88676: Crash in FixedTableLayout::layout
+
+PASSED, the test didn't crash.
+
+


Added: trunk/LayoutTests/fast/table/auto-table-layout-colgroup-removal-crash.html (0 => 121275)

--- trunk/LayoutTests/fast/table/auto-table-layout-colgroup-removal-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/table/auto-table-layout-colgroup-removal-crash.html	2012-06-26 19:16:08 UTC (rev 121275)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+pBug a href="" Crash in FixedTableLayout::layout/p
+p id=consoleFAILED, the test didn't run./p
+table id=table
+tbody
+tr/tr
+/tbody
+colgroup 

[webkit-changes] [121276] trunk/LayoutTests

[hclam]

Title: [121276] trunk/LayoutTests








Revision 121276
Author hc...@chromium.org
Date 2012-06-26 12:21:32 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] Mark a layout test as timeout
https://bugs.webkit.org/show_bug.cgi?id=90003

fast/js/repeat-cached-vm-reentry.html started timing out on Mac debug and Win debug builds
between r121233:121239.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (121275 => 121276)

--- trunk/LayoutTests/ChangeLog	2012-06-26 19:16:08 UTC (rev 121275)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 19:21:32 UTC (rev 121276)
@@ -1,3 +1,13 @@
+2012-06-26  Alpha Lam  hc...@chromium.org
+
+[chromium] Mark a layout test as timeout
+https://bugs.webkit.org/show_bug.cgi?id=90003
+
+fast/js/repeat-cached-vm-reentry.html started timing out on Mac debug and Win debug builds
+between r121233:121239.
+
+* platform/chromium/TestExpectations:
+
 2012-06-26  Julien Chaffraix  jchaffr...@webkit.org
 
 Crash in FixedTableLayout::layout


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (121275 => 121276)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-06-26 19:16:08 UTC (rev 121275)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-06-26 19:21:32 UTC (rev 121276)
@@ -36,7 +36,7 @@
 BUGCR24182 LINUX WIN DEBUG : jquery/traversing.html = PASS TIMEOUT
 BUGCR24182 LEOPARD DEBUG : jquery/traversing.html = PASS TEXT TIMEOUT
 BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/frames/sandboxed-iframe-navigation-parent.html = PASS
-BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/js/repeat-cached-vm-reentry.html = PASS
+BUGCR24182 SNOWLEOPARD DEBUG : fast/js/repeat-cached-vm-reentry.html = PASS TIMEOUT
 BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/dom/Window/window-postmessage-clone-deep-array.html = PASS
 BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/frames/calculate-percentage.html = PASS
 BUGCR24182 SLOW DEBUG WIN MAC : fast/js/dfg-int8array.html = PASS
@@ -3768,3 +3768,6 @@
 
 // Started failing after r121267.
 BUGWK89998 SNOWLEOPARD RELEASE : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE
+
+// Started timeout between r121233:r121239.
+BUGWK90003 WIN DEBUG : fast/js/repeat-cached-vm-reentry.html = TIMEOUT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121277] trunk/Source

[commit-queue]

Title: [121277] trunk/Source








Revision 121277
Author commit-qu...@webkit.org
Date 2012-06-26 12:34:23 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] The single thread proxy should not automatically tick new animations.
https://bugs.webkit.org/show_bug.cgi?id=89996

Patch by Ian Vollick voll...@chromium.org on 2012-06-26
Reviewed by James Robinson.

Source/WebCore:

No new tests. No change to existing functionality.

* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::didAddAnimation):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCSingleThreadProxyTest.cpp: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi


Removed Paths

trunk/Source/WebKit/chromium/tests/CCSingleThreadProxyTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121276 => 121277)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 19:21:32 UTC (rev 121276)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 19:34:23 UTC (rev 121277)
@@ -1,3 +1,19 @@
+2012-06-26  Ian Vollick  voll...@chromium.org
+
+[chromium] The single thread proxy should not automatically tick new animations.
+https://bugs.webkit.org/show_bug.cgi?id=89996
+
+Reviewed by James Robinson.
+
+No new tests. No change to existing functionality.
+
+* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
+(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
+(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
+(WebCore::CCSingleThreadProxy::didAddAnimation):
+* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
+(WebCore):
+
 2012-06-26  Julien Chaffraix  jchaffr...@webkit.org
 
 Crash in FixedTableLayout::layout


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp (121276 => 121277)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp	2012-06-26 19:21:32 UTC (rev 121276)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp	2012-06-26 19:34:23 UTC (rev 121277)
@@ -39,26 +39,6 @@
 
 namespace WebCore {
 
-class CCSingleThreadProxyAnimationTimer : public CCTimer, CCTimerClient {
-public:
-static PassOwnPtrCCSingleThreadProxyAnimationTimer create(CCSingleThreadProxy* proxy) { return adoptPtr(new CCSingleThreadProxyAnimationTimer(proxy)); }
-
-virtual void onTimerFired() OVERRIDE
-{
-if (m_proxy-m_layerRendererInitialized)
-m_proxy-compositeImmediately();
-}
-
-private:
-explicit CCSingleThreadProxyAnimationTimer(CCSingleThreadProxy* proxy)
-: CCTimer(CCProxy::mainThread(), this)
-, m_proxy(proxy)
-{
-}
-
-CCSingleThreadProxy* m_proxy;
-};
-
 PassOwnPtrCCProxy CCSingleThreadProxy::create(CCLayerTreeHost* layerTreeHost)
 {
 return adoptPtr(new CCSingleThreadProxy(layerTreeHost));
@@ -68,7 +48,6 @@
 : m_layerTreeHost(layerTreeHost)
 , m_contextLost(false)
 , m_compositorIdentifier(-1)
-, m_animationTimer(CCSingleThreadProxyAnimationTimer::create(this))
 , m_layerRendererInitialized(false)
 , m_nextFrameIsNewlyCommittedFrame(false)
 {
@@ -168,9 +147,7 @@
 if (ok) {
 m_layerRendererInitialized = true;
 m_layerRendererCapabilitiesForMainThread = m_layerTreeHostImpl-layerRendererCapabilities();
-} else
-// If we couldn't initialize the layer renderer, we shouldn't process any future animation events.
-m_animationTimer-stop();
+}
 
 return ok;
 }
@@ -277,7 +254,6 @@
 
 void CCSingleThreadProxy::didAddAnimation()
 {
-m_animationTimer-startOneShot(animationTimerDelay());
 }
 
 void CCSingleThreadProxy::stop()
@@ -318,11 +294,6 @@
 }
 }
 
-double CCSingleThreadProxy::animationTimerDelay()
-{
-return 1 / 60.0;
-}
-
 void CCSingleThreadProxy::forceSerializeOnSwapBuffers()
 {
 {


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h (121276 => 121277)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h	2012-06-26 19:21:32 UTC (rev 121276)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h	2012-06-26 19:34:23 UTC (rev 121277)
@@ -34,7 +34,6 @@
 namespace WebCore {
 
 class CCLayerTreeHost;
-class CCSingleThreadProxyAnimationTimer;
 
 class CCSingleThreadProxy : public CCProxy, CCLayerTreeHostImplClient {
 public:
@@ -77,12 +76,7 @@
 // Called by the legacy path where RenderWidget does the scheduling.
 void compositeImmediately();
 
-// Measured in seconds.
-static double 

[webkit-changes] [121278] trunk

[adamk]

Title: [121278] trunk








Revision 121278
Author ad...@chromium.org
Date 2012-06-26 12:36:50 -0700 (Tue, 26 Jun 2012)


Log Message
MutationObserver.observe should treat a null or undefined options argument as empty
https://bugs.webkit.org/show_bug.cgi?id=89992

Reviewed by Ojan Vafai.

Source/WebCore:

The WebIDL spec was recently updated to treat null or undefined
Dictionary arguments the same as the empty dictionary. This patch
updates MutationObserver.observe to follow that spec.

Note that we still throw a SYNTAX_ERR in this case, since it's an
error not to pass one of attributes, childList, or characterData
as a key in the dictionary.

* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe):

LayoutTests:

* fast/mutation/observe-exceptions-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/WebKitMutationObserver.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (121277 => 121278)

--- trunk/LayoutTests/ChangeLog	2012-06-26 19:34:23 UTC (rev 121277)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 19:36:50 UTC (rev 121278)
@@ -1,3 +1,12 @@
+2012-06-26  Adam Klein  ad...@chromium.org
+
+MutationObserver.observe should treat a null or undefined options argument as empty
+https://bugs.webkit.org/show_bug.cgi?id=89992
+
+Reviewed by Ojan Vafai.
+
+* fast/mutation/observe-exceptions-expected.txt:
+
 2012-06-26  Alpha Lam  hc...@chromium.org
 
 [chromium] Mark a layout test as timeout


Modified: trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt (121277 => 121278)

--- trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt	2012-06-26 19:34:23 UTC (rev 121277)
+++ trunk/LayoutTests/fast/mutation/observe-exceptions-expected.txt	2012-06-26 19:36:50 UTC (rev 121278)
@@ -7,8 +7,8 @@
 PASS observer.observe(null) threw exception TypeError: Not enough arguments.
 PASS observer.observe(undefined) threw exception TypeError: Not enough arguments.
 PASS observer.observe(document.body) threw exception TypeError: Not enough arguments.
-PASS observer.observe(document.body, null) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
-PASS observer.observe(document.body, undefined) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
+PASS observer.observe(document.body, null) threw exception Error: SYNTAX_ERR: DOM Exception 12.
+PASS observer.observe(document.body, undefined) threw exception Error: SYNTAX_ERR: DOM Exception 12.
 PASS observer.observe(null, {attributes: true}) threw exception Error: NOT_FOUND_ERR: DOM Exception 8.
 PASS observer.observe(undefined, {attributes: true}) threw exception Error: NOT_FOUND_ERR: DOM Exception 8.
 PASS observer.observe(document.body, {subtree: true}) threw exception Error: SYNTAX_ERR: DOM Exception 12.


Modified: trunk/Source/WebCore/ChangeLog (121277 => 121278)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 19:34:23 UTC (rev 121277)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 19:36:50 UTC (rev 121278)
@@ -1,3 +1,21 @@
+2012-06-26  Adam Klein  ad...@chromium.org
+
+MutationObserver.observe should treat a null or undefined options argument as empty
+https://bugs.webkit.org/show_bug.cgi?id=89992
+
+Reviewed by Ojan Vafai.
+
+The WebIDL spec was recently updated to treat null or undefined
+Dictionary arguments the same as the empty dictionary. This patch
+updates MutationObserver.observe to follow that spec.
+
+Note that we still throw a SYNTAX_ERR in this case, since it's an
+error not to pass one of attributes, childList, or characterData
+as a key in the dictionary.
+
+* dom/WebKitMutationObserver.cpp:
+(WebCore::WebKitMutationObserver::observe):
+
 2012-06-26  Ian Vollick  voll...@chromium.org
 
 [chromium] The single thread proxy should not automatically tick new animations.


Modified: trunk/Source/WebCore/dom/WebKitMutationObserver.cpp (121277 => 121278)

--- trunk/Source/WebCore/dom/WebKitMutationObserver.cpp	2012-06-26 19:34:23 UTC (rev 121277)
+++ trunk/Source/WebCore/dom/WebKitMutationObserver.cpp	2012-06-26 19:36:50 UTC (rev 121278)
@@ -89,11 +89,6 @@
 return;
 }
 
-if (optionsDictionary.isUndefinedOrNull()) {
-ec = TYPE_MISMATCH_ERR;
-return;
-}
-
 static const struct {
 const char* name;
 MutationObserverOptions value;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121279] trunk/Source/WebCore

[jchaffraix]

Title: [121279] trunk/Source/WebCore








Revision 121279
Author jchaffr...@webkit.org
Date 2012-06-26 12:40:08 -0700 (Tue, 26 Jun 2012)


Log Message
Crash in FixedTableLayout::layout
https://bugs.webkit.org/show_bug.cgi?id=88676

Unreviewed typo fix, pointed out by Darin Adler.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/AutoTableLayout.cpp
trunk/Source/WebCore/rendering/FixedTableLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121278 => 121279)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 19:36:50 UTC (rev 121278)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 19:40:08 UTC (rev 121279)
@@ -1,3 +1,15 @@
+2012-06-26  Julien Chaffraix  jchaffr...@webkit.org
+
+Crash in FixedTableLayout::layout
+https://bugs.webkit.org/show_bug.cgi?id=88676
+
+Unreviewed typo fix, pointed out by Darin Adler.
+
+* rendering/AutoTableLayout.cpp:
+(WebCore::AutoTableLayout::layout):
+* rendering/FixedTableLayout.cpp:
+(WebCore::FixedTableLayout::layout):
+
 2012-06-26  Adam Klein  ad...@chromium.org
 
 MutationObserver.observe should treat a null or undefined options argument as empty


Modified: trunk/Source/WebCore/rendering/AutoTableLayout.cpp (121278 => 121279)

--- trunk/Source/WebCore/rendering/AutoTableLayout.cpp	2012-06-26 19:36:50 UTC (rev 121278)
+++ trunk/Source/WebCore/rendering/AutoTableLayout.cpp	2012-06-26 19:40:08 UTC (rev 121279)
@@ -502,7 +502,7 @@
 // This means that our preferred logical widths were not recomputed as expected.
 if (nEffCols != m_layoutStruct.size()) {
 fullRecalc();
-// FIXME: Table layout shouldn't modify our table structure (but does due to columns and colum-groups).
+// FIXME: Table layout shouldn't modify our table structure (but does due to columns and column-groups).
 nEffCols = m_table-numEffCols();
 }
 


Modified: trunk/Source/WebCore/rendering/FixedTableLayout.cpp (121278 => 121279)

--- trunk/Source/WebCore/rendering/FixedTableLayout.cpp	2012-06-26 19:36:50 UTC (rev 121278)
+++ trunk/Source/WebCore/rendering/FixedTableLayout.cpp	2012-06-26 19:40:08 UTC (rev 121279)
@@ -212,7 +212,7 @@
 // This means that our preferred logical widths were not recomputed as expected.
 if (nEffCols != m_width.size()) {
 calcWidthArray(tableLogicalWidth);
-// FIXME: Table layout shouldn't modify our table structure (but does due to columns and colum-groups).
+// FIXME: Table layout shouldn't modify our table structure (but does due to columns and column-groups).
 nEffCols = m_table-numEffCols();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121281] trunk/Source/WebKit/blackberry

[mifenton]

Title: [121281] trunk/Source/WebKit/blackberry








Revision 121281
Author mifen...@rim.com
Date 2012-06-26 12:52:14 -0700 (Tue, 26 Jun 2012)


Log Message
[BlackBerry] Add WebPage interface for Async spell check.
https://bugs.webkit.org/show_bug.cgi?id=8

Reviewed by Rob Buis.

PR 124517.

Add interface for IMS async spell checking.

Reviewed Internally by Nima Ghanavatian.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
(WebKit):
* Api/WebPage.h:
* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
* WebKitSupport/InputHandler.h:
(InputHandler):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPage.h
trunk/Source/WebKit/blackberry/Api/WebPageClient.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.h




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (121280 => 121281)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-06-26 19:52:14 UTC (rev 121281)
@@ -4510,6 +4510,11 @@
 static_castEditorClientBlackBerry*(d-m_page-editorClient())-enableSpellChecking(enabled);
 }
 
+void WebPage::spellCheckingRequestProcessed(int32_t id, spannable_string_t* spannableString)
+{
+d-m_inputHandler-spellCheckingRequestProcessed(id, spannableString);
+}
+
 class DeferredTaskSelectionCancelled: public DeferredTaskWebPagePrivate::m_wouldCancelSelection {
 public:
 explicit DeferredTaskSelectionCancelled(WebPagePrivate* webPagePrivate)


Modified: trunk/Source/WebKit/blackberry/Api/WebPage.h (121280 => 121281)

--- trunk/Source/WebKit/blackberry/Api/WebPage.h	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.h	2012-06-26 19:52:14 UTC (rev 121281)
@@ -250,6 +250,7 @@
 int32_t commitText(spannable_string_t*, int32_t relativeCursorPosition);
 
 void setSpellCheckingEnabled(bool);
+void spellCheckingRequestProcessed(int32_t id, spannable_string_t*);
 
 void setSelection(const Platform::IntPoint startPoint, const Platform::IntPoint endPoint);
 void setCaretPosition(const Platform::IntPoint);


Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (121280 => 121281)

--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h	2012-06-26 19:52:14 UTC (rev 121281)
@@ -144,6 +144,8 @@
 virtual void checkSpellingOfString(const unsigned short* text, int length, int misspellingLocation, int misspellingLength) = 0;
 virtual void requestSpellingSuggestionsForString(unsigned start, unsigned end) = 0;
 
+virtual int32_t checkSpellingOfStringAsync(wchar_t* text, int length) = 0;
+
 virtual void notifySelectionDetailsChanged(const Platform::IntRect start, const Platform::IntRect end, const Platform::IntRectRegion, bool overrideTouchHandling = false) = 0;
 virtual void cancelSelectionVisuals() = 0;
 virtual void notifySelectionHandlesReversed() = 0;


Modified: trunk/Source/WebKit/blackberry/ChangeLog (121280 => 121281)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-06-26 19:52:14 UTC (rev 121281)
@@ -1,3 +1,27 @@
+2012-06-26  Mike Fenton  mifen...@rim.com
+
+[BlackBerry] Add WebPage interface for Async spell check.
+https://bugs.webkit.org/show_bug.cgi?id=8
+
+Reviewed by Rob Buis.
+
+PR 124517.
+
+Add interface for IMS async spell checking.
+
+Reviewed Internally by Nima Ghanavatian.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
+(WebKit):
+* Api/WebPage.h:
+* Api/WebPageClient.h:
+* WebKitSupport/InputHandler.cpp:
+(WebKit):
+(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
+* WebKitSupport/InputHandler.h:
+(InputHandler):
+
 2012-06-26  Jonathan Dong  jonathan.d...@torchmobile.com.cn
 
 [BlackBerry] Limit session storage quota to 5MB by default


Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (121280 => 121281)

--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-06-26 19:42:05 UTC (rev 121280)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp	2012-06-26 19:52:14 UTC (rev 121281)
@@ -404,6 +404,14 @@
 sendLearnTextDetails(textInField);
 }
 
+
+void InputHandler::spellCheckingRequestProcessed(int32_t id, spannable_string_t* spannableString)
+{
+UNUSED_PARAM(id);
+UNUSED_PARAM(spannableString);
+// TODO implement.
+}
+
 void InputHandler::setElementUnfocused(bool refocusOccuring)
 {
 if (isActiveTextEdit()) {

[webkit-changes] [121282] trunk/Source/JavaScriptCore

[commit-queue]

Title: [121282] trunk/Source/_javascript_Core








Revision 121282
Author commit-qu...@webkit.org
Date 2012-06-26 12:55:32 -0700 (Tue, 26 Jun 2012)


Log Message
[BlackBerry] Add JSC statistics into about:memory
https://bugs.webkit.org/show_bug.cgi?id=89779

Patch by Yong Li y...@rim.com on 2012-06-26
Reviewed by Rob Buis.

Fix non-JIT build on BlackBerry broken by r121196.

* runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/MemoryStatistics.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121281 => 121282)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-26 19:52:14 UTC (rev 121281)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-26 19:55:32 UTC (rev 121282)
@@ -1,3 +1,15 @@
+2012-06-26  Yong Li  y...@rim.com
+
+[BlackBerry] Add JSC statistics into about:memory
+https://bugs.webkit.org/show_bug.cgi?id=89779
+
+Reviewed by Rob Buis.
+
+Fix non-JIT build on BlackBerry broken by r121196.
+
+* runtime/MemoryStatistics.cpp:
+(JSC::globalMemoryStatistics):
+
 2012-06-25  Filip Pizlo  fpi...@apple.com
 
 DFG::operationNewArray is unnecessarily slow, and may use the wrong array


Modified: trunk/Source/_javascript_Core/runtime/MemoryStatistics.cpp (121281 => 121282)

--- trunk/Source/_javascript_Core/runtime/MemoryStatistics.cpp	2012-06-26 19:52:14 UTC (rev 121281)
+++ trunk/Source/_javascript_Core/runtime/MemoryStatistics.cpp	2012-06-26 19:55:32 UTC (rev 121282)
@@ -37,7 +37,7 @@
 GlobalMemoryStatistics stats;
 
 stats.stackBytes = RegisterFile::committedByteCount();
-#if ENABLE(EXECUTABLE_ALLOCATOR_FIXED) || PLATFORM(BLACKBERRY)
+#if ENABLE(EXECUTABLE_ALLOCATOR_FIXED) || (PLATFORM(BLACKBERRY)  ENABLE(JIT))
 stats.JITBytes = ExecutableAllocator::committedByteCount();
 #else
 stats.JITBytes = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121283] trunk

[jamesr]

Title: [121283] trunk








Revision 121283
Author jam...@google.com
Date 2012-06-26 13:09:31 -0700 (Tue, 26 Jun 2012)


Log Message
Unreviewed, rolling out r120501.
http://trac.webkit.org/changeset/120501
https://bugs.webkit.org/show_bug.cgi?id=89126

[skia] Fix is too heavy-handed

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::drawNeedsCopy):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::isDeferred):
(WebCore::PlatformContextSkia::setDeferred):

Modified Paths

trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h




Diff

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (121282 => 121283)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-06-26 19:55:32 UTC (rev 121282)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-06-26 20:09:31 UTC (rev 121283)
@@ -3596,6 +3596,8 @@
 BUGWK86592 LINUX : fast/loader/unload-form-about-blank.html = TIMEOUT PASS
 BUGWK86592 LINUX : http/tests/xmlhttprequest/zero-length-response-sync.html = TIMEOUT PASS
 
+BUGWK89126 : platform/chromium/compositing/accelerated-drawing/svg-filters.html = IMAGE
+
 // strange Unexpected no expected results found on cr-linux ews
 BUGWK86600 LINUX : http/tests/cache/loaded-from-cache-after-reload-within-iframe.html = MISSING PASS
 BUGWK86600 LINUX : http/tests/cache/loaded-from-cache-after-reload.html = MISSING PASS


Modified: trunk/Source/WebCore/ChangeLog (121282 => 121283)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 19:55:32 UTC (rev 121282)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 20:09:31 UTC (rev 121283)
@@ -1,3 +1,20 @@
+2012-06-26  James Robinson  jam...@chromium.org
+
+Unreviewed, rolling out r120501.
+http://trac.webkit.org/changeset/120501
+https://bugs.webkit.org/show_bug.cgi?id=89126
+
+[skia] Fix is too heavy-handed
+
+* platform/graphics/skia/ImageBufferSkia.cpp:
+(WebCore::drawNeedsCopy):
+* platform/graphics/skia/PlatformContextSkia.cpp:
+(WebCore::PlatformContextSkia::PlatformContextSkia):
+* platform/graphics/skia/PlatformContextSkia.h:
+(PlatformContextSkia):
+(WebCore::PlatformContextSkia::isDeferred):
+(WebCore::PlatformContextSkia::setDeferred):
+
 2012-06-26  Julien Chaffraix  jchaffr...@webkit.org
 
 Crash in FixedTableLayout::layout


Modified: trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (121282 => 121283)

--- trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2012-06-26 19:55:32 UTC (rev 121282)
+++ trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2012-06-26 20:09:31 UTC (rev 121283)
@@ -202,12 +202,7 @@
 
 static bool drawNeedsCopy(GraphicsContext* src, GraphicsContext* dst)
 {
-if (src == dst)
-return true;
-// If we're rendering into a deferred canvas, we need to make a deep copy of the source pixels because Skia does not
-// retain a reference to the actual pixels otherwise. We check if we're drawing into a deferred canvas by seeing if the
-// device's bitmap configuration is set or not - if it's not, then we must not have a bitmap target yet.
-return dst-platformContext()-canvas()-getDevice()-config() == SkBitmap::kNo_Config;
+return dst-platformContext()-isDeferred() || src == dst;
 }
 
 void ImageBuffer::draw(GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect destRect, const FloatRect srcRect,


Modified: trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp (121282 => 121283)

--- trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp	2012-06-26 19:55:32 UTC (rev 121282)
+++ trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp	2012-06-26 20:09:31 UTC (rev 121283)
@@ -186,6 +186,7 @@
 , m_trackOpaqueRegion(false)
 , m_printing(false)
 , m_accelerated(false)
+, m_deferred(false)
 , m_drawingToImageBuffer(false)
 {
 m_stateStack.append(State());


Modified: trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h (121282 => 121283)

--- trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h	2012-06-26 19:55:32 UTC (rev 121282)
+++ trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h	2012-06-26 20:09:31 UTC (rev 121283)
@@ -186,6 +186,12 @@
 bool isAccelerated() const { return m_accelerated; }
 void setAccelerated(bool accelerated) { m_accelerated = accelerated; }
 
+// True if this context is deferring draw calls to be executed later.
+// We need to know this for context-to-context draws, in order to know if
+// the source bitmap needs to be copied.
+

[webkit-changes] [121284] trunk/Source

[jamesr]

Title: [121284] trunk/Source








Revision 121284
Author jam...@google.com
Date 2012-06-26 13:17:09 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] Add WebLayer API for scrolling
https://bugs.webkit.org/show_bug.cgi?id=89913

Reviewed by Adrienne Walker.

Source/Platform:

Adds WebScrollableLayer type to represent a layer that can be scrolled by the user. Currently WebContentLayers
are scrollable and no other layer types are, although this might change in the future.

* chromium/public/WebContentLayer.h:
(WebKit::WebContentLayer::WebContentLayer):
* chromium/public/WebLayer.h:
(WebLayer):
* chromium/public/WebScrollableLayer.h:
(WebKit):
(WebScrollableLayer):
(WebKit::WebScrollableLayer::WebScrollableLayer):
(WebKit::WebScrollableLayer::~WebScrollableLayer):
(WebKit::WebScrollableLayer::operator=):

Source/WebCore:

Use new WebScrollableLayer type in ScrollingCoordinatorChromium. This file peeks under the hood a fair amount
since we don't have WebLayer API for scrollbar layers yet.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::hasScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

Source/WebKit/chromium:

Use WebScrollableLayer type in NonCompositedContentHost.

* WebKit.gyp:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::reserveScrollbarLayers):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::haveScrollLayer):
(WebKit):
(WebKit::NonCompositedContentHost::scrollLayer):
* src/NonCompositedContentHost.h:
(WebCore):
* src/WebContentLayer.cpp:
(WebKit::WebContentLayer::WebContentLayer):
* src/WebLayer.cpp:
(WebKit::WebLayer::numberOfChildren):
(WebKit):
(WebKit::WebLayer::childAt):
(WebKit::WebLayer::setAlwaysReserveTextures):
* src/WebScrollableLayer.cpp:
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebContentLayer.h
trunk/Source/Platform/chromium/public/WebLayer.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp
trunk/Source/WebKit/chromium/src/NonCompositedContentHost.h
trunk/Source/WebKit/chromium/src/WebContentLayer.cpp
trunk/Source/WebKit/chromium/src/WebLayer.cpp


Added Paths

trunk/Source/Platform/chromium/public/WebScrollableLayer.h
trunk/Source/WebKit/chromium/src/WebScrollableLayer.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (121283 => 121284)

--- trunk/Source/Platform/ChangeLog	2012-06-26 20:09:31 UTC (rev 121283)
+++ trunk/Source/Platform/ChangeLog	2012-06-26 20:17:09 UTC (rev 121284)
@@ -1,3 +1,24 @@
+2012-06-25  James Robinson  jam...@chromium.org
+
+[chromium] Add WebLayer API for scrolling
+https://bugs.webkit.org/show_bug.cgi?id=89913
+
+Reviewed by Adrienne Walker.
+
+Adds WebScrollableLayer type to represent a layer that can be scrolled by the user. Currently WebContentLayers
+are scrollable and no other layer types are, although this might change in the future.
+
+* chromium/public/WebContentLayer.h:
+(WebKit::WebContentLayer::WebContentLayer):
+* chromium/public/WebLayer.h:
+(WebLayer):
+* chromium/public/WebScrollableLayer.h:
+(WebKit):
+(WebScrollableLayer):
+(WebKit::WebScrollableLayer::WebScrollableLayer):
+(WebKit::WebScrollableLayer::~WebScrollableLayer):
+(WebKit::WebScrollableLayer::operator=):
+
 2012-06-25  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r121176.


Modified: trunk/Source/Platform/chromium/public/WebContentLayer.h (121283 => 121284)

--- trunk/Source/Platform/chromium/public/WebContentLayer.h	2012-06-26 20:09:31 UTC (rev 121283)
+++ trunk/Source/Platform/chromium/public/WebContentLayer.h	2012-06-26 20:17:09 UTC (rev 121284)
@@ -27,7 +27,7 @@
 #define WebContentLayer_h
 
 #include WebCommon.h
-#include WebLayer.h
+#include WebScrollableLayer.h
 
 namespace WebCore {
 class ContentLayerChromium;
@@ -37,12 +37,12 @@
 class WebContentLayerClient;
 class WebContentLayerImpl;
 
-class WebContentLayer 

[webkit-changes] [121287] trunk/Tools

[ojan]

Title: [121287] trunk/Tools








Revision 121287
Author o...@chromium.org
Date 2012-06-26 14:21:54 -0700 (Tue, 26 Jun 2012)


Log Message
Fix platform picker change handler in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90010

Reviewed by Simon Fraser.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
The old code never worked. This is hard to test because change handlers require
a user-initiated action and the code is changing the window's location, which would
navigate the test page.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
due to the large margin-bottom.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (121286 => 121287)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js	2012-06-26 21:06:24 UTC (rev 121286)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js	2012-06-26 21:21:54 UTC (rev 121287)
@@ -112,8 +112,8 @@
 });
 
 platformSelect.addEventListener('change', function() {
-window.location.search = '?platform=' + platformSelect.selectedOptions[0]._platform;
-}, false);
+window.location.search = '?platform=' + platformSelect.options[platformSelect.selectedIndex]._platform;
+});
 
 platformSelect.selectedIndex = currentPlatformIndex;
 },


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css (121286 => 121287)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css	2012-06-26 21:06:24 UTC (rev 121286)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css	2012-06-26 21:21:54 UTC (rev 121287)
@@ -43,7 +43,8 @@
 
 #onebar #platform-picker {
 float: right;
-margin: 8px;
+margin-top: 8px;
+margin-right: 8px;
 font-size: larger;
 }
 


Modified: trunk/Tools/ChangeLog (121286 => 121287)

--- trunk/Tools/ChangeLog	2012-06-26 21:06:24 UTC (rev 121286)
+++ trunk/Tools/ChangeLog	2012-06-26 21:21:54 UTC (rev 121287)
@@ -1,3 +1,19 @@
+2012-06-26  Ojan Vafai  o...@chromium.org
+
+Fix platform picker change handler in garden-o-matic
+https://bugs.webkit.org/show_bug.cgi?id=90010
+
+Reviewed by Simon Fraser.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
+The old code never worked. This is hard to test because change handlers require
+a user-initiated action and the code is changing the window's location, which would
+navigate the test page.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
+Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
+due to the large margin-bottom.
+
 2012-06-26  Thiago Marcos P. Santos  thiago.san...@intel.com
 
 webkitpy: Make webkit-patch patches-to-review useful






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121288] trunk/Source

[commit-queue]

Title: [121288] trunk/Source








Revision 121288
Author commit-qu...@webkit.org
Date 2012-06-26 14:30:44 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] Expose rendering statistics to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=88268

Patch by Dave Tu d...@chromium.org on 2012-06-26
Reviewed by James Robinson.

The WebKit side of a basic framework for exposing rendering statistics
to Chromium's --enable-benchmarking extension.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebRenderingStatistics):
(WebKit):
(WebLayerTreeView):

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::implFrameNumber):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::implFrameNumber):
(WebCore):
(WebCore::CCThreadProxy::implFrameNumberOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::renderingStatistics):
(WebKit):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/Platform.gypi
trunk/Source/Platform/chromium/public/WebLayerTreeView.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCProxy.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/WebLayerTreeView.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp


Added Paths

trunk/Source/Platform/chromium/public/WebRenderingStats.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderingStats.h




Diff

Modified: trunk/Source/Platform/ChangeLog (121287 => 121288)

--- trunk/Source/Platform/ChangeLog	2012-06-26 21:21:54 UTC (rev 121287)
+++ trunk/Source/Platform/ChangeLog	2012-06-26 21:30:44 UTC (rev 121288)
@@ -1,3 +1,18 @@
+2012-06-26  Dave Tu  d...@chromium.org
+
+[chromium] Expose rendering statistics to WebWidget.
+https://bugs.webkit.org/show_bug.cgi?id=88268
+
+Reviewed by James Robinson.
+
+The WebKit side of a basic framework for exposing rendering statistics
+to Chromium's --enable-benchmarking extension.
+
+* chromium/public/WebLayerTreeView.h:
+(WebRenderingStatistics):
+(WebKit):
+(WebLayerTreeView):
+
 2012-06-25  James Robinson  jam...@chromium.org
 
 [chromium] Add WebLayer API for scrolling


Modified: trunk/Source/Platform/Platform.gypi (121287 => 121288)

--- trunk/Source/Platform/Platform.gypi	2012-06-26 21:21:54 UTC (rev 121287)
+++ trunk/Source/Platform/Platform.gypi	2012-06-26 21:30:44 UTC (rev 121288)
@@ -94,6 +94,7 @@
 'chromium/public/WebPrivatePtr.h',
 'chromium/public/WebRect.h',
 'chromium/public/WebReferrerPolicy.h',
+'chromium/public/WebRenderingStats.h',
 'chromium/public/WebSessionDescriptionDescriptor.h',
 'chromium/public/WebSize.h',
 'chromium/public/WebSocketStreamError.h',


Modified: trunk/Source/Platform/chromium/public/WebLayerTreeView.h (121287 => 121288)

--- trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2012-06-26 21:21:54 UTC (rev 121287)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2012-06-26 21:30:44 UTC (rev 121288)
@@ -44,6 +44,7 @@
 class WebLayerTreeViewImpl;
 struct WebPoint;
 struct WebRect;
+struct WebRenderingStats;
 
 class WebLayerTreeView : public WebNonCopyable {
 public:
@@ -173,6 +174,10 @@
 
 // Debugging / dangerous -
 
+// Fills in a WebRenderingStats struct containing information about the state of the compositor.
+// This call is relatively expensive in threaded mode as it blocks on the compositor thread.
+WEBKIT_EXPORT void renderingStats(WebRenderingStats) const;
+
 // Simulates a lost context. For testing only.
 WEBKIT_EXPORT void loseCompositorContext(int numTimes);
 


Added: trunk/Source/Platform/chromium/public/WebRenderingStats.h (0 => 121288)

--- trunk/Source/Platform/chromium/public/WebRenderingStats.h	(rev 0)
+++ trunk/Source/Platform/chromium/public/WebRenderingStats.h	2012-06-26 21:30:44 

[webkit-changes] [121290] trunk/LayoutTests

[rniwa]

Title: [121290] trunk/LayoutTests








Revision 121290
Author rn...@webkit.org
Date 2012-06-26 14:46:34 -0700 (Tue, 26 Jun 2012)


Log Message
Fix a test after r121286.

* editing/deleting/merge-into-empty-block-2.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/deleting/merge-into-empty-block-2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121289 => 121290)

--- trunk/LayoutTests/ChangeLog	2012-06-26 21:35:55 UTC (rev 121289)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 21:46:34 UTC (rev 121290)
@@ -1,3 +1,9 @@
+2012-06-26  Ryosuke Niwa  rn...@webkit.org
+
+Fix a test after r121286.
+
+* editing/deleting/merge-into-empty-block-2.html:
+
 2012-06-26  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r121285.


Modified: trunk/LayoutTests/editing/deleting/merge-into-empty-block-2.html (121289 => 121290)

--- trunk/LayoutTests/editing/deleting/merge-into-empty-block-2.html	2012-06-26 21:35:55 UTC (rev 121289)
+++ trunk/LayoutTests/editing/deleting/merge-into-empty-block-2.html	2012-06-26 21:46:34 UTC (rev 121290)
@@ -1,6 +1,6 @@
 p id=descriptionWhen a user puts the caret at the very beginning a list and hits delete into an empty line, the list should just move up./p
 div contenteditable=truedivbr/divullispan id=testfoo/span/li/ul/div
-
+script src=""
 script
 if (window.testRunner)
  testRunner.dumpEditingCallbacks();
@@ -10,6 +10,6 @@
 
 document.execCommand(Delete);
 
-Markup.description(document.getElementById('description'));
+Markup.description(document.getElementById('description').textContent);
 Markup.dump(document.querySelector('div'));
 /script






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121291] trunk/Source/WebCore

[jsbell]

Title: [121291] trunk/Source/WebCore








Revision 121291
Author jsb...@chromium.org
Date 2012-06-26 15:04:09 -0700 (Tue, 26 Jun 2012)


Log Message
IndexedDB: Move method precondition checks to front end objects
https://bugs.webkit.org/show_bug.cgi?id=89377

Reviewed by Tony Chang.

Now that metadata exists on the front end, most of the pre-condition validation checks
done on IDB method calls from script can be moved to the front end which simplifies the
code significantly in the case of complex methods like IDBObjectStore::put().

Adds an internal active flag for transactions, although the behavior is not accurate
to the spec (it should only be true during event callbacks - http://webkit.org/b/89379).
The back-end methods can then be simplifed to just adding async tasks to the transaction,
and the front end methods can take care of all exception cases except for asynchronous
transaction abort which still requires plumbing back to the front end.

No functional changes - no new tests.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update): Migrate from IDBObjectStoreBackendImpl::put.
(WebCore::IDBCursor::advance): Add more explicit transaction-is-active check.
(WebCore::IDBCursor::continueFunction): Ditto.
(WebCore::IDBCursor::deleteFunction): Ditto.
(WebCore::IDBCursor::effectiveObjectStore): Convenience function (source may be store or index).
(WebCore):
* Modules/indexeddb/IDBCursor.h:
(WebCore::IDBCursor::isKeyCursor): Distinguish from IDBCursorWithValue.
(IDBCursor):
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::update): Remove migrated check.
* Modules/indexeddb/IDBCursorWithValue.h:
(IDBCursorWithValue):
* Modules/indexeddb/IDBDatabase.cpp: Migrate checks.
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Replace checks with assertions.
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
* Modules/indexeddb/IDBIndex.cpp: Add transaction-is-active checks.
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
* Modules/indexeddb/IDBObjectStore.cpp: Migrate cehcks.
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add): Delegates to put(PutMode)
(WebCore::IDBObjectStore::put): Delegates to put(PutMode)
(WebCore): Adds put(PutMode) which has the unified checks migrated from
IDBObjectStoreBackendImpl::put.
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):
* Modules/indexeddb/IDBObjectStore.h: Adds put(PutMode).
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getInternal): Fix trace symbol.
(WebCore::IDBObjectStoreBackendImpl::put): Remove migrated checks.
(WebCore::IDBObjectStoreBackendImpl::createIndex): Remove migrated checks.
(WebCore::IDBObjectStoreBackendImpl::deleteIndex): Remove migrated checks.
* Modules/indexeddb/IDBTransaction.cpp: Add active flag tracking.
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* Modules/indexeddb/IDBTransaction.h:
(WebCore::IDBTransaction::isActive):
(WebCore::IDBTransaction::isReadOnly): Group IDL/non-IDL methods.
(IDBTransaction):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBCursor.h
trunk/Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBCursorWithValue.h
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.h
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (121290 => 121291)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 21:46:34 UTC (rev 121290)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 22:04:09 UTC (rev 121291)
@@ -1,3 +1,77 @@
+2012-06-26  Joshua Bell  jsb...@chromium.org
+
+IndexedDB: Move method precondition checks to front end objects
+https://bugs.webkit.org/show_bug.cgi?id=89377
+
+Reviewed by Tony Chang.
+
+Now that metadata exists on the front end, most of the pre-condition validation checks
+done on IDB method calls from script can be moved to the front end which simplifies the
+code significantly in the case of complex 

[webkit-changes] [121292] trunk/Source/WebCore

[noam . rosenthal]

Title: [121292] trunk/Source/WebCore








Revision 121292
Author noam.rosent...@nokia.com
Date 2012-06-26 15:51:35 -0700 (Tue, 26 Jun 2012)


Log Message
[Qt] Use premultiplied alpha when extracting image data in WebGL
https://bugs.webkit.org/show_bug.cgi?id=89937

Reviewed by Jocelyn Turcotte.

Perform conversion in QImage only if the image format is not ARGB32 or
ARGB32_Premultiplied. Otherwise, allow packPixels to perform the conversion if the formats
don't match, as packPixels already performs pixel-specific operations.

Covered by tests in LayoutTests/fast/canvas/webgl, e.g. webgl-composite-modes.html.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121291 => 121292)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 22:04:09 UTC (rev 121291)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 22:51:35 UTC (rev 121292)
@@ -1,3 +1,19 @@
+2012-06-26  No'am Rosenthal  noam.rosent...@nokia.com
+
+[Qt] Use premultiplied alpha when extracting image data in WebGL
+https://bugs.webkit.org/show_bug.cgi?id=89937
+
+Reviewed by Jocelyn Turcotte.
+
+Perform conversion in QImage only if the image format is not ARGB32 or
+ARGB32_Premultiplied. Otherwise, allow packPixels to perform the conversion if the formats
+don't match, as packPixels already performs pixel-specific operations.
+
+Covered by tests in LayoutTests/fast/canvas/webgl, e.g. webgl-composite-modes.html.
+
+* platform/graphics/qt/GraphicsContext3DQt.cpp:
+(WebCore::GraphicsContext3D::getImageData):
+
 2012-06-26  Joshua Bell  jsb...@chromium.org
 
 IndexedDB: Move method precondition checks to front end objects


Modified: trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp (121291 => 121292)

--- trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp	2012-06-26 22:04:09 UTC (rev 121291)
+++ trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp	2012-06-26 22:51:35 UTC (rev 121292)
@@ -414,6 +414,7 @@
 // If GraphicsContext3D init failed in constructor, m_private set to nullptr and no buffers are allocated.
 if (!m_private)
 return;
+
 makeContextCurrent();
 glDeleteTextures(1, m_texture);
 glDeleteFramebuffers(1, m_fbo);
@@ -486,13 +487,13 @@
 UNUSED_PARAM(ignoreGammaAndColorProfile);
 if (!image)
 return false;
-QImage nativeImage;
+
+QImage qtImage;
 // Is image already loaded? If not, load it.
 if (image-data())
-nativeImage = QImage::fromData(reinterpret_castconst uchar*(image-data()-data()), image-data()-size()).convertToFormat(QImage::Format_ARGB32);
+qtImage = QImage::fromData(reinterpret_castconst uchar*(image-data()-data()), image-data()-size());
 else {
 QPixmap* nativePixmap = image-nativeImageForCurrentFrame();
-QImage qtImage;
 #if HAVE(QT5)
 // With QPA, we can avoid a deep copy.
 qtImage = *nativePixmap-handle()-buffer();
@@ -500,19 +501,32 @@
 // This might be a deep copy, depending on other references to the pixmap.
 qtImage = nativePixmap-toImage();
 #endif
-nativeImage = qtImage.convertToFormat(QImage::Format_ARGB32);
 }
-AlphaOp neededAlphaOp = AlphaDoNothing;
-if (premultiplyAlpha)
-neededAlphaOp = AlphaDoPremultiply;
 
+AlphaOp alphaOp = AlphaDoNothing;
+switch (qtImage.format()) {
+case QImage::Format_ARGB32:
+if (premultiplyAlpha)
+alphaOp = AlphaDoPremultiply;
+break;
+case QImage::Format_ARGB32_Premultiplied:
+if (!premultiplyAlpha)
+alphaOp = AlphaDoUnmultiply;
+break;
+default:
+// The image has a format that is not supported in packPixels. We have to convert it here.
+qtImage = qtImage.convertToFormat(premultiplyAlpha ? QImage::Format_ARGB32_Premultiplied : QImage::Format_ARGB32);
+break;
+}
+
 unsigned int packedSize;
 // Output data is tightly packed (alignment == 1).
 if (computeImageSizeInBytes(format, type, image-width(), image-height(), 1, packedSize, 0) != GraphicsContext3D::NO_ERROR)
 return false;
+
 outputVector.resize(packedSize);
 
-return packPixels(nativeImage.bits(), SourceFormatBGRA8, image-width(), image-height(), 0, format, type, neededAlphaOp, outputVector.data());
+return packPixels(qtImage.bits(), SourceFormatBGRA8, image-width(), image-height(), 0, format, type, alphaOp, outputVector.data());
 }
 
 void GraphicsContext3D::setContextLostCallback(PassOwnPtrContextLostCallback)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121293] trunk/Source/WebCore

[commit-queue]

Title: [121293] trunk/Source/WebCore








Revision 121293
Author commit-qu...@webkit.org
Date 2012-06-26 16:00:04 -0700 (Tue, 26 Jun 2012)


Log Message
Include stdio.h when DEBUG_AUDIONODE_REFERENCES is set
https://bugs.webkit.org/show_bug.cgi?id=89997

Patch by Raymond Toy r...@google.com on 2012-06-26
Reviewed by Eric Seidel.

No new tests needed for a compile issue

* Modules/webaudio/AudioNode.cpp:  Include stdio.h

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121292 => 121293)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 22:51:35 UTC (rev 121292)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 23:00:04 UTC (rev 121293)
@@ -1,3 +1,14 @@
+2012-06-26  Raymond Toy  r...@google.com
+
+Include stdio.h when DEBUG_AUDIONODE_REFERENCES is set
+https://bugs.webkit.org/show_bug.cgi?id=89997
+
+Reviewed by Eric Seidel.
+
+No new tests needed for a compile issue
+
+* Modules/webaudio/AudioNode.cpp:  Include stdio.h
+
 2012-06-26  No'am Rosenthal  noam.rosent...@nokia.com
 
 [Qt] Use premultiplied alpha when extracting image data in WebGL


Modified: trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp (121292 => 121293)

--- trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp	2012-06-26 22:51:35 UTC (rev 121292)
+++ trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp	2012-06-26 23:00:04 UTC (rev 121293)
@@ -36,6 +36,10 @@
 #include wtf/Atomics.h
 #include wtf/MainThread.h
 
+#if DEBUG_AUDIONODE_REFERENCES
+#include stdio.h
+#endif
+
 namespace WebCore {
 
 AudioNode::AudioNode(AudioContext* context, float sampleRate)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121294] trunk/Tools

[ojan]

Title: [121294] trunk/Tools








Revision 121294
Author o...@chromium.org
Date 2012-06-26 16:00:43 -0700 (Tue, 26 Jun 2012)


Log Message
Fix failing garden-o-matic unittests
https://bugs.webkit.org/show_bug.cgi?id=90021

Reviewed by Adam Barth.

These had all just fallen out of date.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js (121293 => 121294)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js	2012-06-26 23:00:04 UTC (rev 121293)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js	2012-06-26 23:00:43 UTC (rev 121294)
@@ -56,7 +56,7 @@
 });
 });
 
-test(rebaseline, 4, function() {
+test(rebaseline, 3, function() {
 var simulator = new NetworkSimulator();
 
 var requests = [];
@@ -67,8 +67,8 @@
 };
 simulator.ajax = function(options)
 {
-if (options.url.indexOf('/ping') != -1)
-ok(false, 'Recieved non-ping ajax request.');
+if (options.url.indexOf('/ping') == -1)
+ok(false, 'Received non-ping ajax request: ' + options.url);
 simulator.scheduleCallback(options.success);
 };
 


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (121293 => 121294)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js	2012-06-26 23:00:04 UTC (rev 121293)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js	2012-06-26 23:00:43 UTC (rev 121294)
@@ -326,8 +326,8 @@
 'div class=what' +
 'div class=problemDisasterifying:' +
 'ul class=effects' +
-'li class=buildera class=failing-builder target=_blank href="" class=versionlucid/spanspan class=architecture64-bit/span/a/li' +
-'li class=buildera class=failing-builder target=_blank href="" class=versionwin7/span/a/li' +
+'li class=buildera class=failing-builder target=_blank href="" class=versionlucid/spanspan class=architecture64-bit/spanspan class=failures compile/span/a/li' +
+'li class=buildera class=failing-builder target=_blank href="" class=versionwin7/spanspan class=failures webkit_tests, update/span/a/li' +
 '/ul' +
 '/div' +
 'ul class=causes/ul' +


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js (121293 => 121294)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js	2012-06-26 23:00:04 UTC (rev 121293)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js	2012-06-26 23:00:43 UTC (rev 121294)
@@ -54,7 +54,7 @@
 _onebar_ = new ui.onebar();
 onebar.attach();
 equal(onebar.innerHTML,
-'divselect id=platform-pickeroptionApple/optionoptionChromium/option/select/div' +
+'divselect id=platform-pickeroptionApple/optionoptionChromium/optionoptionGTK/option/select/div' +
 'ul class=ui-tabs-nav ui-helper-reset ui-helper-clearfix ui-widget-header ui-corner-all' +
 'li class=ui-state-default ui-corner-top ui-tabs-selected ui-state-activea href="" Failures/a/li' +
 'li class=ui-state-default ui-corner-topa href="" Failures/a/li' +


Modified: trunk/Tools/ChangeLog (121293 => 121294)

--- trunk/Tools/ChangeLog	2012-06-26 23:00:04 UTC (rev 121293)
+++ trunk/Tools/ChangeLog	2012-06-26 23:00:43 UTC (rev 121294)
@@ -1,5 +1,18 @@
 2012-06-26  Ojan Vafai  o...@chromium.org
 
+Fix failing garden-o-matic unittests
+https://bugs.webkit.org/show_bug.cgi?id=90021
+
+Reviewed by Adam Barth.
+
+These had all just fallen out of date.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
+* 

[webkit-changes] [121295] trunk/Source/WebCore

[adamk]

Title: [121295] trunk/Source/WebCore








Revision 121295
Author ad...@chromium.org
Date 2012-06-26 16:02:00 -0700 (Tue, 26 Jun 2012)


Log Message
[v8] Clean up generated Dictionary-handling code
https://bugs.webkit.org/show_bug.cgi?id=89994

Reviewed by Adam Barth.

No change in behavior, so no new tests.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::optionsObjectCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121294 => 121295)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 23:00:43 UTC (rev 121294)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 23:02:00 UTC (rev 121295)
@@ -1,3 +1,17 @@
+2012-06-26  Adam Klein  ad...@chromium.org
+
+[v8] Clean up generated Dictionary-handling code
+https://bugs.webkit.org/show_bug.cgi?id=89994
+
+Reviewed by Adam Barth.
+
+No change in behavior, so no new tests.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateParametersCheck):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjV8Internal::optionsObjectCallback):
+
 2012-06-26  Raymond Toy  r...@google.com
 
 Include stdio.h when DEBUG_AUDIONODE_REFERENCES is set


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (121294 => 121295)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-06-26 23:00:43 UTC (rev 121294)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-06-26 23:02:00 UTC (rev 121295)
@@ -1724,13 +1724,8 @@
 $parameterCheckString .= EXCEPTION_BLOCK($nativeType, $parameterName,  .
  JSValueToNative($parameter, MAYBE_MISSING_PARAMETER(args, $paramIndex, $parameterDefaultPolicy), args.GetIsolate()) . );\n;
 if ($nativeType eq 'Dictionary') {
-   $parameterCheckString .= if (args.Length()  $paramIndex  !$parameterName.isUndefinedOrNull()  !$parameterName.isObject()) {\n;
-   if (@{$function-raisesExceptions}) {
-   $parameterCheckString .= ec = TYPE_MISMATCH_ERR;\n;
-   $parameterCheckString .= V8Proxy::setDOMException(ec, args.GetIsolate());\n;
-   }
-   $parameterCheckString .= return V8Proxy::throwTypeError(\Not an object.\);\n;
-   $parameterCheckString .= }\n;
+   $parameterCheckString .= if (!$parameterName.isUndefinedOrNull()  !$parameterName.isObject())\n;
+   $parameterCheckString .= return V8Proxy::throwTypeError(\Not an object.\, args.GetIsolate());\n;
 }
 }
 


Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (121294 => 121295)

--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp	2012-06-26 23:00:43 UTC (rev 121294)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp	2012-06-26 23:02:00 UTC (rev 121295)
@@ -1150,17 +1150,15 @@
 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate());
 TestObj* imp = V8TestObj::toNative(args.Holder());
 EXCEPTION_BLOCK(Dictionary, oo, MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined));
-if (args.Length()  0  !oo.isUndefinedOrNull()  !oo.isObject()) {
-return V8Proxy::throwTypeError(Not an object.);
-}
+if (!oo.isUndefinedOrNull()  !oo.isObject())
+return V8Proxy::throwTypeError(Not an object., args.GetIsolate());
 if (args.Length() = 1) {
 imp-optionsObject(oo);
 return v8::Handlev8::Value();
 }
 EXCEPTION_BLOCK(Dictionary, ooo, MAYBE_MISSING_PARAMETER(args, 1, DefaultIsUndefined));
-if (args.Length()  1  !ooo.isUndefinedOrNull()  !ooo.isObject()) {
-return V8Proxy::throwTypeError(Not an object.);
-}
+if (!ooo.isUndefinedOrNull()  !ooo.isObject())
+return V8Proxy::throwTypeError(Not an object., args.GetIsolate());
 imp-optionsObject(oo, ooo);
 return v8::Handlev8::Value();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121296] trunk

[commit-queue]

Title: [121296] trunk








Revision 121296
Author commit-qu...@webkit.org
Date 2012-06-26 16:08:09 -0700 (Tue, 26 Jun 2012)


Log Message
background-size:0 shows as 1px instead of invisible
https://bugs.webkit.org/show_bug.cgi?id=86942

Patch by Joe Thomas joetho...@motorola.com on 2012-06-26
Reviewed by Eric Seidel.

As per the specification http://www.w3.org/TR/css3-background/#background-size, if the background image's width or height resolves to zero,
this causes the image not to be displayed. The effect should be the same as if it had been a transparent image.
This is also mentioned in http://www.w3.org/TR/2002/WD-css3-background-20020802/#background-size.

Source/WebCore:

Test: fast/backgrounds/zero-background-size.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):

LayoutTests:

* fast/backgrounds/size/zero.html:
* fast/backgrounds/zero-background-size-expected.html: Added.
* fast/backgrounds/zero-background-size.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/fast/backgrounds/size/zero-expected.png:
* platform/mac/fast/backgrounds/size/zero-expected.txt:
* platform/qt/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/backgrounds/size/zero.html
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/fast/backgrounds/size/zero-expected.png
trunk/LayoutTests/platform/mac/fast/backgrounds/size/zero-expected.txt
trunk/LayoutTests/platform/qt/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp


Added Paths

trunk/LayoutTests/fast/backgrounds/zero-background-size-expected.html
trunk/LayoutTests/fast/backgrounds/zero-background-size.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121295 => 121296)

--- trunk/LayoutTests/ChangeLog	2012-06-26 23:02:00 UTC (rev 121295)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 23:08:09 UTC (rev 121296)
@@ -1,3 +1,24 @@
+2012-06-26  Joe Thomas  joetho...@motorola.com
+
+background-size:0 shows as 1px instead of invisible
+https://bugs.webkit.org/show_bug.cgi?id=86942
+
+Reviewed by Eric Seidel.
+
+As per the specification http://www.w3.org/TR/css3-background/#background-size, if the background image's width or height resolves to zero,
+this causes the image not to be displayed. The effect should be the same as if it had been a transparent image.
+This is also mentioned in http://www.w3.org/TR/2002/WD-css3-background-20020802/#background-size.
+
+* fast/backgrounds/size/zero.html:
+* fast/backgrounds/zero-background-size-expected.html: Added.
+* fast/backgrounds/zero-background-size.html: Added.
+* platform/chromium/TestExpectations:
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/mac/fast/backgrounds/size/zero-expected.png:
+* platform/mac/fast/backgrounds/size/zero-expected.txt:
+* platform/qt/TestExpectations:
+
 2012-06-26  Ryosuke Niwa  rn...@webkit.org
 
 Fix a test after r121286.


Modified: trunk/LayoutTests/fast/backgrounds/size/zero.html (121295 => 121296)

--- trunk/LayoutTests/fast/backgrounds/size/zero.html	2012-06-26 23:02:00 UTC (rev 121295)
+++ trunk/LayoutTests/fast/backgrounds/size/zero.html	2012-06-26 23:08:09 UTC (rev 121296)
@@ -5,9 +5,9 @@
 Test for ia href="" Web Inspector freezes beneath Image::drawPattern()/a Bug/i.
 /p
 p
-There should be four blue squares with black borders. WebKit should not hang or assert.
+There should be four empty squares with black borders. WebKit should not hang or assert.
 /p
-div style=-webkit-background-size: 0 0;/div
-div style=-webkit-background-size: 0 32px;/div
-div style=-webkit-background-size: 2px 0;/div
-div style=-webkit-background-size: auto 8px;/div
+div style=background-size: 0 0;/div
+div style=background-size: 0 32px;/div
+div style=background-size: 2px 0;/div
+div style=background-size: auto 8px;/div


Added: trunk/LayoutTests/fast/backgrounds/zero-background-size-expected.html (0 => 121296)

--- trunk/LayoutTests/fast/backgrounds/zero-background-size-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/backgrounds/zero-background-size-expected.html	2012-06-26 23:08:09 UTC (rev 121296)
@@ -0,0 +1,17 @@
+!DOCTYPE HTML
+html
+style type=text/css
+div {
+width: 200px;
+height: 200px;
+}
+/style
+div/div
+div/div
+div/div
+div/div
+div/div
+div/div
+div/div
+div/div
+/html


Added: trunk/LayoutTests/fast/backgrounds/zero-background-size.html (0 => 121296)

--- trunk/LayoutTests/fast/backgrounds/zero-background-size.html	(rev 0)
+++ trunk/LayoutTests/fast/backgrounds/zero-background-size.html	2012-06-26 23:08:09 UTC (rev 121296)
@@ -0,0 +1,17 

[webkit-changes] [121297] trunk

[tsepez]

Title: [121297] trunk








Revision 121297
Author tse...@chromium.org
Date 2012-06-26 16:18:31 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] HTML5 audio/video tags - loading http content from https page doesn't trigger warning.
https://bugs.webkit.org/show_bug.cgi?id=89906

Reviewed by Nate Chapin.

This patch treats mixed CachedRawResources as affecting the display of insecure content.

Source/WebCore:

Tests: http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html
   http/tests/security/mixedContent/insecure-xhr-in-main-frame.html

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::checkInsecureContent):

LayoutTests:

* http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Added.
* http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html: Added.
* http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt: Added.
* http/tests/security/mixedContent/insecure-xhr-in-main-frame.html: Added.
* http/tests/security/mixedContent/resources/frame-with-insecure-audio-video.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp


Added Paths

trunk/LayoutTests/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt
trunk/LayoutTests/http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html
trunk/LayoutTests/http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt
trunk/LayoutTests/http/tests/security/mixedContent/insecure-xhr-in-main-frame.html
trunk/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-audio-video.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121296 => 121297)

--- trunk/LayoutTests/ChangeLog	2012-06-26 23:08:09 UTC (rev 121296)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 23:18:31 UTC (rev 121297)
@@ -1,3 +1,23 @@
+2012-06-26  Tom Sepez  tse...@chromium.org
+
+[chromium] HTML5 audio/video tags - loading http content from https page doesn't trigger warning.
+https://bugs.webkit.org/show_bug.cgi?id=89906
+
+Reviewed by Nate Chapin.
+
+This patch treats mixed CachedRawResources as affecting the display of insecure content.
+
+* http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Added.
+* http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html: Added.
+* http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt: Added.
+* http/tests/security/mixedContent/insecure-xhr-in-main-frame.html: Added.
+* http/tests/security/mixedContent/resources/frame-with-insecure-audio-video.html: Added.
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/qt/TestExpectations:
+* platform/win/TestExpectations:
+
 2012-06-26  Joe Thomas  joetho...@motorola.com
 
 background-size:0 shows as 1px instead of invisible


Added: trunk/LayoutTests/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt (0 => 121297)

--- trunk/LayoutTests/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt	2012-06-26 23:18:31 UTC (rev 121297)
@@ -0,0 +1,5 @@
+CONSOLE MESSAGE: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-audio-video.html displayed insecure content from http://127.0.0.1:8080/resources/test.mp4.
+
+CONSOLE MESSAGE: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-audio-video.html displayed insecure content from http://127.0.0.1:8080/resources/test.mp4.
+
+This test opens a window that loads insecure HTML5 audio and video. We should trigger a mixed content callback because the main frame in the window is HTTPS but is displaying insecure content.


Added: trunk/LayoutTests/http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html (0 => 121297)

--- trunk/LayoutTests/http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html	2012-06-26 23:18:31 UTC (rev 121297)
@@ -0,0 +1,24 @@
+html
+body
+script
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+

[webkit-changes] [121298] trunk/LayoutTests

[rniwa]

Title: [121298] trunk/LayoutTests








Revision 121298
Author rn...@webkit.org
Date 2012-06-26 16:32:24 -0700 (Tue, 26 Jun 2012)


Log Message
Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=90024

Reviewed by Ojan Vafai.

Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way.

* editing/inserting/font-size-clears-from-typing-style-expected.txt:
* editing/inserting/font-size-clears-from-typing-style.html:
* editing/inserting/script-tests: Removed.
* editing/inserting/script-tests/TEMPLATE.html: Removed.
* editing/inserting/script-tests/font-size-clears-from-typing-style.js: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style-expected.txt
trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style.html


Removed Paths

trunk/LayoutTests/editing/inserting/script-tests/




Diff

Modified: trunk/LayoutTests/ChangeLog (121297 => 121298)

--- trunk/LayoutTests/ChangeLog	2012-06-26 23:18:31 UTC (rev 121297)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 23:32:24 UTC (rev 121298)
@@ -1,3 +1,18 @@
+2012-06-26  Ryosuke Niwa  rn...@webkit.org
+
+Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test
+https://bugs.webkit.org/show_bug.cgi?id=90024
+
+Reviewed by Ojan Vafai.
+
+Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way.
+
+* editing/inserting/font-size-clears-from-typing-style-expected.txt:
+* editing/inserting/font-size-clears-from-typing-style.html:
+* editing/inserting/script-tests: Removed.
+* editing/inserting/script-tests/TEMPLATE.html: Removed.
+* editing/inserting/script-tests/font-size-clears-from-typing-style.js: Removed.
+
 2012-06-26  Tom Sepez  tse...@chromium.org
 
 [chromium] HTML5 audio/video tags - loading http content from https page doesn't trigger warning.


Modified: trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style-expected.txt (121297 => 121298)

--- trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style-expected.txt	2012-06-26 23:18:31 UTC (rev 121297)
+++ trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style-expected.txt	2012-06-26 23:32:24 UTC (rev 121298)
@@ -1,11 +1,4 @@
-Tests that font-size in typingStyle is correctly cleared. See https://bugs.webkit.org/show_bug.cgi?id=26279.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS 1 is 1
-PASS 3 is 3
-PASS successfullyParsed is true
-
-TEST COMPLETE
-BA
+Tests that we don't serialize redundant font-size in typingStyle. There should be no span or style attribute around A or B below.See https://bugs.webkit.org/show_bug.cgi?id=26279.
+| div
+|   id=wrapper
+|   B#selection-caretA


Modified: trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style.html (121297 => 121298)

--- trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style.html	2012-06-26 23:18:31 UTC (rev 121297)
+++ trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style.html	2012-06-26 23:32:24 UTC (rev 121298)
@@ -1,12 +1,25 @@
-!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+!DOCTYPE html
 html
-head
-script src=""
-/head
 body
-p id=description/p
-div id=console/div
-script src=""
-script src=""
+script src=""
+script
+
+Markup.description(Tests that we don't serialize redundant font-size in typingStyle. There should be no span or style attribute around A or B below.
+ + See https://bugs.webkit.org/show_bug.cgi?id=26279.);
+
+var editable = document.createElement('div');
+editable.contentEditable = true;
+editable.innerHTML = 'brdiv id=wrapperA/div';
+
+document.body.appendChild(editable);
+editable.focus();
+
+window.getSelection().setBaseAndExtent(editable, 0, editable, 0);
+document.execCommand('ForwardDelete', false, false);
+document.execCommand('InsertText', false, 'B');
+
+Markup.dump(editable);
+
+/script
 /body
 /html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121299] trunk

[commit-queue]

Title: [121299] trunk








Revision 121299
Author commit-qu...@webkit.org
Date 2012-06-26 16:34:21 -0700 (Tue, 26 Jun 2012)


Log Message
Crash at WebCore::TextIterator::handleTextBox
https://bugs.webkit.org/show_bug.cgi?id=89526
rdar://problem/10305315

Patch by Alice Cheng alice_ch...@apple.com on 2012-06-26
Reviewed by Darin Adler.

Source/WebCore:

The range used for marking becomes invalid after SpellingCorrectionCommand, due to changes in the DOM made by ReplaceSelectionCommand.
This invalid range caused marking to be incorrect, and Mail.app to crash when iterating through the invalid range.  To fix this,
recalculate the range for marking after SpellingCorrectionCommand.

Test: platform/mac/editing/spelling/autocorrection-blockquote-crash.html

* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
* editing/Editor.cpp:  (WebCore::Editor::markAndReplaceFor):
* testing/Internals.cpp:
(WebCore):
(WebCore::Internals::hasAutocorrectedMarker):
* testing/Internals.h: (Internals):
* testing/Internals.idl:

LayoutTests:

* platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt: Added.
* platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/AlternativeTextController.cpp
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl


Added Paths

trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt
trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121298 => 121299)

--- trunk/LayoutTests/ChangeLog	2012-06-26 23:32:24 UTC (rev 121298)
+++ trunk/LayoutTests/ChangeLog	2012-06-26 23:34:21 UTC (rev 121299)
@@ -1,3 +1,14 @@
+2012-06-26  Alice Cheng  alice_ch...@apple.com
+
+Crash at WebCore::TextIterator::handleTextBox
+https://bugs.webkit.org/show_bug.cgi?id=89526
+rdar://problem/10305315
+
+Reviewed by Darin Adler.
+
+* platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt: Added.
+* platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added.
+
 2012-06-26  Ryosuke Niwa  rn...@webkit.org
 
 Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test


Added: trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt (0 => 121299)

--- trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt	2012-06-26 23:34:21 UTC (rev 121299)
@@ -0,0 +1,12 @@
+This test checks that markers are correct when auto correcting in the blockquote. If you type n and  , there should be blue dots under information, but is off by one.
+
+PASS internals.hasAutocorrectedMarker(document, 0, 1) is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+would this 
+testinformation 
+make a difference?
+
+


Added: trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash.html (0 => 121299)

--- trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash.html	(rev 0)
+++ trunk/LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash.html	2012-06-26 23:34:21 UTC (rev 121299)
@@ -0,0 +1,24 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+p id=descriptionThis test checks that markers are correct when auto correcting in the blockquote. If you type n and  , there should be blue dots under information, but is off by one. br Note, this test can fail due to user specific spell checking data. If the user has previously dismissed 'notational' as the correct spelling of 'notationl' several times, the spell checker will not provide 'information' as a suggestion anymore. To fix this, remove all files in ~/Library/Spelling./p
+div id=console/div
+
+div id = test contentEditable=true spellCheck=trueblockquote type=citefont style = font-family:Arialbr would this b id = boldbr/bbbr/bmake a difference?spanbr/spanspanbr/span/font/blockquote/div
+
+script language=_javascript_
+// Insert some text with a typographical error in it, so autocorrection occurs.
+window.getSelection().setPosition(document.getElementById(bold), 1);
+document.execCommand(InsertText, false, test infomatio);
+eventSender.keyDown('n');
+eventSender.keyDown(' ');
+
+if(window.internals)
+shouldBeTrue('internals.hasAutocorrectedMarker(document, 0, 1)');
+/script
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (121298 => 121299)

--- trunk/Source/WebCore/ChangeLog	

[webkit-changes] [121300] trunk/Source/WebCore

[commit-queue]

Title: [121300] trunk/Source/WebCore








Revision 121300
Author commit-qu...@webkit.org
Date 2012-06-26 16:39:57 -0700 (Tue, 26 Jun 2012)


Log Message
[EFL] Use eina_file_ls() in EFL implementation of FileSystem listDirectory()
https://bugs.webkit.org/show_bug.cgi?id=89976

Patch by Christophe Dumez christophe.du...@intel.com on 2012-06-26
Reviewed by Antonio Gomes.

Rewrite EFL implementation of Filesystem listDirectory() in order to
use eina_file_ls() instead of POSIX C functions. This results in
shorter code.

No new tests, behavior has not changed.

* platform/efl/FileSystemEfl.cpp:
(WebCore::listDirectory):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/FileSystemEfl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121299 => 121300)

--- trunk/Source/WebCore/ChangeLog	2012-06-26 23:34:21 UTC (rev 121299)
+++ trunk/Source/WebCore/ChangeLog	2012-06-26 23:39:57 UTC (rev 121300)
@@ -1,3 +1,19 @@
+2012-06-26  Christophe Dumez  christophe.du...@intel.com
+
+[EFL] Use eina_file_ls() in EFL implementation of FileSystem listDirectory()
+https://bugs.webkit.org/show_bug.cgi?id=89976
+
+Reviewed by Antonio Gomes.
+
+Rewrite EFL implementation of Filesystem listDirectory() in order to
+use eina_file_ls() instead of POSIX C functions. This results in
+shorter code.
+
+No new tests, behavior has not changed.
+
+* platform/efl/FileSystemEfl.cpp:
+(WebCore::listDirectory):
+
 2012-06-26  Alice Cheng  alice_ch...@apple.com
 
 Crash at WebCore::TextIterator::handleTextBox


Modified: trunk/Source/WebCore/platform/efl/FileSystemEfl.cpp (121299 => 121300)

--- trunk/Source/WebCore/platform/efl/FileSystemEfl.cpp	2012-06-26 23:34:21 UTC (rev 121299)
+++ trunk/Source/WebCore/platform/efl/FileSystemEfl.cpp	2012-06-26 23:39:57 UTC (rev 121300)
@@ -86,50 +86,19 @@
 
 VectorString listDirectory(const String path, const String filter)
 {
-VectorString entries;
-CString cpath = path.utf8();
+VectorString matchingEntries;
 CString cfilter = filter.utf8();
-char filePath[PATH_MAX];
-char* fileName;
-size_t fileNameSpace;
-DIR* dir;
+const char *f_name;
 
-if (cpath.length() + NAME_MAX = sizeof(filePath))
-return entries;
-// loop invariant: directory part + '/'
-memcpy(filePath, cpath.data(), cpath.length());
-fileName = filePath + cpath.length();
-if (cpath.length()  0  filePath[cpath.length() - 1] != '/') {
-fileName[0] = '/';
-fileName++;
+Eina_Iterator* it = eina_file_ls(path.utf8().data());
+EINA_ITERATOR_FOREACH(it, f_name) {
+if (!fnmatch(cfilter.data(), f_name, 0))
+matchingEntries.append(String::fromUTF8(f_name));
+eina_stringshare_del(f_name);
 }
-fileNameSpace = sizeof(filePath) - (fileName - filePath) - 1;
+eina_iterator_free(it);
 
-dir = opendir(cpath.data());
-if (!dir)
-return entries;
-
-struct dirent* de;
-while (de = readdir(dir)) {
-size_t nameLen;
-if (de-d_name[0] == '.') {
-if (de-d_name[1] == '\0')
-continue;
-if (de-d_name[1] == '.'  de-d_name[2] == '\0')
-continue;
-}
-if (fnmatch(cfilter.data(), de-d_name, 0))
-continue;
-
-nameLen = strlen(de-d_name);
-if (nameLen = fileNameSpace)
-continue; // maybe assert? it should never happen anyway...
-
-memcpy(fileName, de-d_name, nameLen + 1);
-entries.append(filePath);
-}
-closedir(dir);
-return entries;
+return matchingEntries;
 }
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121301] trunk/Tools

[ojan]

Title: [121301] trunk/Tools








Revision 121301
Author o...@chromium.org
Date 2012-06-26 16:43:03 -0700 (Tue, 26 Jun 2012)


Log Message
Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90025

Reviewed by Simon Fraser.

Move the chromium-specific filtering code into config.js and replace it with a method on each platform
config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js (121300 => 121301)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js	2012-06-26 23:39:57 UTC (rev 121300)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js	2012-06-26 23:43:03 UTC (rev 121301)
@@ -30,7 +30,7 @@
 var kUpdateStepName = 'update';
 var kUpdateScriptsStepName = 'update_scripts';
 var kCompileStepName = 'compile';
-var kWebKitTestsStepName = 'webkit_tests';
+var kWebKitTestsStepNames = ['webkit_tests', 'layout-test'];
 
 var kCrashedOrHungOutputMarker = 'crashed or hung';
 
@@ -51,8 +51,9 @@
 
 function didFail(step)
 {
-if (step.name == kWebKitTestsStepName) {
+if (kWebKitTestsStepNames.indexOf(step.name) != -1) {
 // run-webkit-tests fails to generate test coverage when it crashes or hangs.
+// FIXME: Do build.webkit.org bots output this marker when the tests fail to run?
 return step.text.indexOf(kCrashedOrHungOutputMarker) != -1;
 }
 return step.results[0]  0  step.text.indexOf('warning') == -1;
@@ -94,10 +95,7 @@
 var builderNames = Object.keys(builderStatus);
 var requestTracker = new base.RequestTracker(builderNames.length, callback, [buildInfoByBuilder]);
 builderNames.forEach(function(builderName) {
-// FIXME: Should garden-o-matic show these? I can imagine showing the deps bots being useful at least so
-// that the gardener only need to look at garden-o-matic and never at the waterfall. Not really sure who
-// watches the GPU bots.
-if (builderName.indexOf('GPU') != -1 || builderName.indexOf('deps') != -1 || builderName.indexOf('ASAN') != -1) {
+if (!config.kPlatforms[config.currentPlatform].builderApplies(builderName)) {
 requestTracker.requestComplete();
 return;
 }


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js (121300 => 121301)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js	2012-06-26 23:39:57 UTC (rev 121300)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js	2012-06-26 23:43:03 UTC (rev 121301)
@@ -57,6 +57,36 @@
 },
 };
 
+var kExampleWebKitDotOrgBuilderStatusJSON =  {
+Apple Lion Release WK2 (Tests): {
+basedir: Webkit_Linux,
+cachedBuilds: [11459, 11460, 11461, 11462],
+category: 6webkit linux latest,
+currentBuilds: [11462],
+pendingBuilds: 0,
+slaves: [vm124-m1],
+state: building
+},
+GTK Linux 64-bit Debug: {
+basedir: Webkit_Linux,
+cachedBuilds: [11459, 11460, 11461, 11462],
+category: 6webkit linux latest,
+currentBuilds: [11461, 11462],
+pendingBuilds: 0,
+slaves: [vm124-m1],
+state: building
+},
+Qt Linux Release: {
+basedir: Webkit_Linux,
+cachedBuilds: [11459, 11460, 11461, 11462],
+category: 6webkit linux latest,
+currentBuilds: [11461, 11462],
+pendingBuilds: 0,
+slaves: [vm124-m1],
+state: building
+},
+};
+
 var kExampleBuildInfoJSON = {
 blame: [aba...@webkit.org],
 builderName: Webkit Linux,
@@ -993,6 +1023,51 @@
 ]);
 });
 
+test(buildersFailing (Apple), 3, function() {
+var simulator = new NetworkSimulator();
+builders.clearBuildInfoCache();
+
+config.currentPlatform = 'apple';
+
+var failingBuildInfoJSON = JSON.parse(JSON.stringify(kExampleBuildInfoJSON));
+failingBuildInfoJSON.number = 11460;
+

[webkit-changes] [121302] trunk/Tools

[lforschler]

Title: [121302] trunk/Tools








Revision 121302
Author lforsch...@apple.com
Date 2012-06-26 16:54:46 -0700 (Tue, 26 Jun 2012)


Log Message
  Teach the Apple port how to build the test tools in build-webkit
  https://bugs.webkit.org/show_bug.cgi?id=89540

  Reviewed by Jon Lee  Simon Fraser.

  * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
  (RunUnitTests.start): ditto
  * Scripts/build-webkit: add tools to the projects build list

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (121301 => 121302)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-06-26 23:43:03 UTC (rev 121301)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-06-26 23:54:46 UTC (rev 121302)
@@ -307,8 +307,11 @@
 def start(self):
 platform = self.getProperty('platform')
 appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))
+if platform.startswith('mac'):
+self.setCommand(self.command + ['--no-build'])
 if platform == win:
 rootArgument = ['--root=' + os.path.join(WebKitBuild, self.getProperty('configuration'), bin)]
+self.setCommand(self.command + ['--no-build'])
 else:
 rootArgument = ['--root=WebKitBuild/bin']
 if not self.buildJSCTool:
@@ -418,6 +421,8 @@
 platform = self.getProperty('platform')
 if platform == 'win':
 self.setCommand(self.command + ['--no-build'])
+if platform.startswith('mac'):
+self.setCommand(self.command + ['--no-build'])
 if platform.startswith('chromium'):
 self.setCommand(self.command + ['--chromium'])
 return shell.Test.start(self)


Modified: trunk/Tools/ChangeLog (121301 => 121302)

--- trunk/Tools/ChangeLog	2012-06-26 23:43:03 UTC (rev 121301)
+++ trunk/Tools/ChangeLog	2012-06-26 23:54:46 UTC (rev 121302)
@@ -1,3 +1,15 @@
+2012-06-26  Lucas Forschler  lforsch...@apple.com
+
+  Teach the Apple port how to build the test tools in build-webkit
+  https://bugs.webkit.org/show_bug.cgi?id=89540
+
+  Reviewed by Jon Lee  Simon Fraser.
+
+  * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+  (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
+  (RunUnitTests.start): ditto
+  * Scripts/build-webkit: add tools to the projects build list
+
 2012-06-26  Ojan Vafai  o...@chromium.org
 
 Only show the platform-appropriate builders for non-layout test failures in garden-o-matic


Modified: trunk/Tools/Scripts/build-webkit (121301 => 121302)

--- trunk/Tools/Scripts/build-webkit	2012-06-26 23:43:03 UTC (rev 121301)
+++ trunk/Tools/Scripts/build-webkit	2012-06-26 23:54:46 UTC (rev 121302)
@@ -246,6 +246,9 @@
 # WebKit2 is only supported in SnowLeopard and later at present.
 push @projects, (Source/WebKit2, Tools/MiniBrowser) if osXVersion()-{minor} = 6 and !$noWebKit2;
 
+# Build Tools needed for Apple ports
+push @projects, (Tools/DumpRenderTree, Tools/WebKitTestRunner, Source/ThirdParty/gtest, Tools/TestWebKitAPI);
+
 # Copy library and header from WebKitLibraries to a findable place in the product directory.
 (system(perl, Tools/Scripts/copy-webkitlibraries-to-product-directory, $productDir) == 0) or die;
 } elsif (isWinCairo()) {
@@ -375,6 +378,7 @@
 push @local_options, XcodeCoverageSupportOptions() if $coverageSupport  $project ne ANGLE;
 my $useGYPProject = $useGYP  ($project =~ WebCore|_javascript_Core);
 my $projectPath = $useGYPProject ? gyp/$project : $project;
+$projectPath = $project =~ /gtest/ ? xcode/gtest : $project;
 $result = buildXCodeProject($projectPath, $clean, @local_options, @ARGV);
 } elsif (isAppleWinWebKit()) {
 if ($project eq WebKit) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121303] trunk

[rniwa]

Title: [121303] trunk








Revision 121303
Author rn...@webkit.org
Date 2012-06-26 17:00:52 -0700 (Tue, 26 Jun 2012)


Log Message
Stop calling node() and deprecatedEditingOffset() in comparePositions
https://bugs.webkit.org/show_bug.cgi?id=54535

Reviewed by Enrica Casucci.

Source/WebCore: 

Replaced deprecatedNode() and deprecatedEditingOffset() by containerNode() and computeOffsetInContainerNode()
in comparePositions().

In addition, fixed a bunch of bugs in DeleteSelectionCommand::handleSpecialCaseBRDelete revealed by this change:
- Use node after position instead of deprecated node in determinig whether start and end positions at a br.
- Don't set m_startsAtEmptyLine true when BR is wrapped in a block element. The only reason this code had worked
was positions like (div, offset, 0) and (br, before) in divbr were treated differently, which we no longer do.

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
* editing/htmlediting.cpp:
(WebCore::comparePositions):

LayoutTests: 

Rebaselined existing tests. There are no user-visible changes.

* editing/inseting/font-size-clears-from-typing-style-expected.txt: No longer keeps div's around
when merging paragraphs.
* platform/mac/editing/deleting/delete-br-002-expected.txt:
* platform/mac/editing/deleting/delete-br-004-expected.txt:
* platform/mac/editing/deleting/delete-br-005-expected.txt:
* platform/mac/editing/deleting/delete-br-006-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style-expected.txt
trunk/LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt
trunk/LayoutTests/platform/mac/editing/deleting/delete-br-004-expected.txt
trunk/LayoutTests/platform/mac/editing/deleting/delete-br-005-expected.txt
trunk/LayoutTests/platform/mac/editing/deleting/delete-br-006-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp
trunk/Source/WebCore/editing/htmlediting.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (121302 => 121303)

--- trunk/LayoutTests/ChangeLog	2012-06-26 23:54:46 UTC (rev 121302)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 00:00:52 UTC (rev 121303)
@@ -1,3 +1,19 @@
+2012-06-26  Ryosuke Niwa  rn...@webkit.org
+
+Stop calling node() and deprecatedEditingOffset() in comparePositions
+https://bugs.webkit.org/show_bug.cgi?id=54535
+
+Reviewed by Enrica Casucci.
+
+Rebaselined existing tests. There are no user-visible changes.
+
+* editing/inseting/font-size-clears-from-typing-style-expected.txt: No longer keeps div's around
+when merging paragraphs.
+* platform/mac/editing/deleting/delete-br-002-expected.txt:
+* platform/mac/editing/deleting/delete-br-004-expected.txt:
+* platform/mac/editing/deleting/delete-br-005-expected.txt:
+* platform/mac/editing/deleting/delete-br-006-expected.txt:
+
 2012-06-26  Alice Cheng  alice_ch...@apple.com
 
 Crash at WebCore::TextIterator::handleTextBox


Modified: trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style-expected.txt (121302 => 121303)

--- trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style-expected.txt	2012-06-26 23:54:46 UTC (rev 121302)
+++ trunk/LayoutTests/editing/inserting/font-size-clears-from-typing-style-expected.txt	2012-06-27 00:00:52 UTC (rev 121303)
@@ -1,4 +1,3 @@
 Tests that we don't serialize redundant font-size in typingStyle. There should be no span or style attribute around A or B below.See https://bugs.webkit.org/show_bug.cgi?id=26279.
-| div
-|   id=wrapper
-|   B#selection-caretA
+| B#selection-caretA
+| br


Modified: trunk/LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt (121302 => 121303)

--- trunk/LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt	2012-06-26 23:54:46 UTC (rev 121302)
+++ trunk/LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt	2012-06-27 00:00:52 UTC (rev 121303)
@@ -24,6 +24,7 @@
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: shouldDeleteDOMRange:range from 2 of SPAN  DIV  BODY  HTML  #document to 3 of SPAN  DIV  BODY  HTML  #document
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of SPAN  DIV  BODY  HTML  #document to 3 of SPAN  DIV  BODY  HTML  #document toDOMRange:range from 2 of SPAN  DIV  BODY  HTML  #document to 2 of SPAN  DIV  BODY  HTML  #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
 layer at (0,0) size 800x600


Modified: trunk/LayoutTests/platform/mac/editing/deleting/delete-br-004-expected.txt (121302 => 121303)

--- 

[webkit-changes] [121304] trunk/Source/WebKit/chromium

[peter]

Title: [121304] trunk/Source/WebKit/chromium








Revision 121304
Author pe...@chromium.org
Date 2012-06-26 17:06:19 -0700 (Tue, 26 Jun 2012)


Log Message
[Chromium] Decrease the number of conditional blocks in features.gypi
https://bugs.webkit.org/show_bug.cgi?id=90013

Reviewed by Adam Barth.

Consolidate two Android-specific and accelerated-compositing-specific
conditional blocks into other blocks which serve an identical purpose.

* features.gypi:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (121303 => 121304)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-06-27 00:00:52 UTC (rev 121303)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-06-27 00:06:19 UTC (rev 121304)
@@ -1,3 +1,15 @@
+2012-06-26  Peter Beverloo  pe...@chromium.org
+
+[Chromium] Decrease the number of conditional blocks in features.gypi
+https://bugs.webkit.org/show_bug.cgi?id=90013
+
+Reviewed by Adam Barth.
+
+Consolidate two Android-specific and accelerated-compositing-specific
+conditional blocks into other blocks which serve an identical purpose.
+
+* features.gypi:
+
 2012-06-26  Dave Tu  d...@chromium.org
 
 [chromium] Expose rendering statistics to WebWidget.


Modified: trunk/Source/WebKit/chromium/features.gypi (121303 => 121304)

--- trunk/Source/WebKit/chromium/features.gypi	2012-06-27 00:00:52 UTC (rev 121303)
+++ trunk/Source/WebKit/chromium/features.gypi	2012-06-27 00:06:19 UTC (rev 121304)
@@ -137,6 +137,7 @@
   'ENABLE_CALENDAR_PICKER=0',
   'ENABLE_FONT_BOOSTING=1',
   'ENABLE_INPUT_SPEECH=0',
+  'ENABLE_INPUT_TYPE_COLOR=0',
   'ENABLE_INPUT_TYPE_DATETIME=1',
   'ENABLE_INPUT_TYPE_DATETIMELOCAL=1',
   'ENABLE_INPUT_TYPE_MONTH=1',
@@ -157,11 +158,12 @@
   'WTF_USE_NATIVE_FULLSCREEN_VIDEO=1',
 ],
 'enable_touch_icon_loading': 1,
-  }, {
+  }, { # OS!=android
 'feature_defines': [
   'ENABLE_CALENDAR_PICKER=1',
   'ENABLE_FONT_BOOSTING=0',
   'ENABLE_INPUT_SPEECH=1',
+  'ENABLE_INPUT_TYPE_COLOR=1',
   'ENABLE_JAVASCRIPT_I18N_API=1',
   'ENABLE_LEGACY_NOTIFICATIONS=1',
   'ENABLE_MEDIA_CAPTURE=0',
@@ -174,24 +176,11 @@
   'ENABLE_WEB_AUDIO=1',
 ],
   }],
-  ['OS==android', {
-'feature_defines': [
-  'ENABLE_INPUT_TYPE_COLOR=0',
-],
-  }, {
-'feature_defines': [
-  'ENABLE_INPUT_TYPE_COLOR=1',
-],
-  }],
   ['use_accelerated_compositing==1', {
 'feature_defines': [
-  'WTF_USE_ACCELERATED_COMPOSITING=1',
   'ENABLE_3D_RENDERING=1',
-],
-  }],
-  ['use_accelerated_compositing==1', {
-'feature_defines': [
   'ENABLE_ACCELERATED_2D_CANVAS=1',
+  'WTF_USE_ACCELERATED_COMPOSITING=1',
 ],
   }],
   # Mac OS X uses Accelerate.framework FFT by default instead of FFmpeg.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121305] trunk

[commit-queue]

Title: [121305] trunk








Revision 121305
Author commit-qu...@webkit.org
Date 2012-06-26 17:41:28 -0700 (Tue, 26 Jun 2012)


Log Message
Touch adjustment does not target shadow DOM elements
https://bugs.webkit.org/show_bug.cgi?id=89556

Source/WebCore:

The position of internal shadow-DOM nodes were not being considered
when determining the snap position when TOUCH_ADJUSTMENT is enabled
for fine tuning the position of synthetic mouse events.  This
restriction results in not being able to select the calendar picker
when input type=date, or to clear the search field for input
type=search.

Patch by Kevin Ellis kev...@chromium.org on 2012-06-26
Reviewed by Antonio Gomes.

Test: touchadjustment/nested-shadow-node.html

* page/EventHandler.cpp:
(WebCore::EventHandler::bestClickableNodeForTouchPoint):

LayoutTests:

Cannot open calendar picker for input type=date using a touch tap
gesture if TOUCH_ADJUSTMENT is enabled. When touch adjustment is
enabled, the position of a touch point is snapped to the center of an
element when generating synthetic mouse events.  The position of shadow
nodes was not being considered when determining the snap position.
This test verifies that touch adjustment now considers shadow-DOM
when calculating the snap position.

Patch by Kevin Ellis kev...@chromium.org on 2012-06-26
Reviewed by Antonio Gomes.

* touchadjustment/nested-shadow-node-expected.txt: Added.
* touchadjustment/nested-shadow-node.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp


Added Paths

trunk/LayoutTests/touchadjustment/nested-shadow-node-expected.txt
trunk/LayoutTests/touchadjustment/nested-shadow-node.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121304 => 121305)

--- trunk/LayoutTests/ChangeLog	2012-06-27 00:06:19 UTC (rev 121304)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 00:41:28 UTC (rev 121305)
@@ -1,3 +1,21 @@
+2012-06-26  Kevin Ellis  kev...@chromium.org
+
+Touch adjustment does not target shadow DOM elements
+https://bugs.webkit.org/show_bug.cgi?id=89556
+
+Cannot open calendar picker for input type=date using a touch tap
+gesture if TOUCH_ADJUSTMENT is enabled. When touch adjustment is 
+enabled, the position of a touch point is snapped to the center of an
+element when generating synthetic mouse events.  The position of shadow
+nodes was not being considered when determining the snap position. 
+This test verifies that touch adjustment now considers shadow-DOM
+when calculating the snap position. 
+
+Reviewed by Antonio Gomes.
+
+* touchadjustment/nested-shadow-node-expected.txt: Added.
+* touchadjustment/nested-shadow-node.html: Added.
+
 2012-06-26  Ryosuke Niwa  rn...@webkit.org
 
 Stop calling node() and deprecatedEditingOffset() in comparePositions
@@ -3703,7 +3721,6 @@
 These make sure the alignment used in the first row of the span is correct when things like
 the height of the cell and the height of the span are specified.
 
-
 2012-06-18  Hayato Ito  hay...@chromium.org
 
 Event dispatcher should use InsertionPoint::hasDistribution instead of InsertinPoint::isActive in re-targeting.


Added: trunk/LayoutTests/touchadjustment/nested-shadow-node-expected.txt (0 => 121305)

--- trunk/LayoutTests/touchadjustment/nested-shadow-node-expected.txt	(rev 0)
+++ trunk/LayoutTests/touchadjustment/nested-shadow-node-expected.txt	2012-06-27 00:41:28 UTC (rev 121305)
@@ -0,0 +1,24 @@
+Test the case where a clickable target contains a shadow-DOM element. The adjusted point should snap to the location of the shadow-DOM element if close enough to the original touch position.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x is within 10 of 88
+PASS adjustedPoint.y is within 10 of 28
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x is within 10 of 88
+PASS adjustedPoint.y is within 10 of 28
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x is within 10 of 88
+PASS adjustedPoint.y is within 10 of 28
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x is within 10 of 88
+PASS adjustedPoint.y is within 10 of 28
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x is within 1 of 58
+PASS adjustedPoint.y is within 1 of 58
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/touchadjustment/nested-shadow-node.html (0 => 121305)

--- trunk/LayoutTests/touchadjustment/nested-shadow-node.html	(rev 0)
+++ trunk/LayoutTests/touchadjustment/nested-shadow-node.html	2012-06-27 00:41:28 UTC (rev 121305)
@@ -0,0 +1,103 @@
+html
+head
+style
+#targetDiv {
+background: #00f;
+height: 100px;
+position: relative;
+width: 100px;
+}
+/style
+script src=""
+
+/head
+

[webkit-changes] [121306] trunk/Source/WebCore

[simon . fraser]

Title: [121306] trunk/Source/WebCore








Revision 121306
Author simon.fra...@apple.com
Date 2012-06-26 18:31:22 -0700 (Tue, 26 Jun 2012)


Log Message
Optimize mappings of simple transforms in RenderGeometryMap
https://bugs.webkit.org/show_bug.cgi?id=90034

Reviewed by Dean Jackson.

For transforms that are identity or simple translations, don't
fall off the fast path in RenderGeometryMap; we can just
treat them as offsets.

Improves performance on pages with lots of translateZ(0) elements.

Remove RenderGeometryMapStep::mapPoint() and mapQuad(), which
were unused.

No new tests; optimization only, and tested by assertions.

* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::push):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGeometryMap.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (121305 => 121306)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 00:41:28 UTC (rev 121305)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 01:31:22 UTC (rev 121306)
@@ -1,3 +1,24 @@
+2012-06-26  Simon Fraser  simon.fra...@apple.com
+
+Optimize mappings of simple transforms in RenderGeometryMap
+https://bugs.webkit.org/show_bug.cgi?id=90034
+
+Reviewed by Dean Jackson.
+
+For transforms that are identity or simple translations, don't
+fall off the fast path in RenderGeometryMap; we can just
+treat them as offsets.
+
+Improves performance on pages with lots of translateZ(0) elements.
+
+Remove RenderGeometryMapStep::mapPoint() and mapQuad(), which
+were unused.
+
+No new tests; optimization only, and tested by assertions.
+
+* rendering/RenderGeometryMap.cpp:
+(WebCore::RenderGeometryMap::push):
+
 2012-06-26  Kevin Ellis  kev...@chromium.org
 
 Touch adjustment does not target shadow DOM elements


Modified: trunk/Source/WebCore/rendering/RenderGeometryMap.cpp (121305 => 121306)

--- trunk/Source/WebCore/rendering/RenderGeometryMap.cpp	2012-06-27 00:41:28 UTC (rev 121305)
+++ trunk/Source/WebCore/rendering/RenderGeometryMap.cpp	2012-06-27 01:31:22 UTC (rev 121306)
@@ -46,25 +46,6 @@
 {
 }
 
-FloatPoint mapPoint(const FloatPoint p) const
-{
-if (!m_transform)
-return p + m_offset;
-
-return m_transform-mapPoint(p);
-}
-
-FloatQuad mapQuad(const FloatQuad quad) const
-{
-if (!m_transform) {
-FloatQuad q = quad;
-q.move(m_offset);
-return q;
-}
-
-return m_transform-mapQuad(quad);
-}
-
 const RenderObject* m_renderer;
 LayoutSize m_offset;
 OwnPtrTransformationMatrix m_transform; // Includes offset if non-null.
@@ -216,8 +197,11 @@
 ASSERT(m_insertionPosition != notFound);
 
 OwnPtrRenderGeometryMapStep step = adoptPtr(new RenderGeometryMapStep(renderer, accumulatingTransform, isNonUniform, isFixedPosition, hasTransform));
-step-m_transform = adoptPtr(new TransformationMatrix(t));
-
+if (!t.isIntegerTranslation())
+step-m_transform = adoptPtr(new TransformationMatrix(t));
+else
+step-m_offset = LayoutSize(t.e(), t.f());
+
 stepInserted(*step.get());
 m_mapping.insert(m_insertionPosition, step.release());
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121307] trunk

[fpizlo]

Title: [121307] trunk








Revision 121307
Author fpi...@apple.com
Date 2012-06-26 18:34:01 -0700 (Tue, 26 Jun 2012)


Log Message
DFG PutByValAlias is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=90026
rdar://problem/11751830

Source/_javascript_Core: 

Reviewed by Gavin Barraclough.

For CSE on normal arrays, we now treat PutByVal as impure. This does not appear to affect
performance by much.

For CSE on typed arrays, we fix PutByValAlias by making GetByVal speculate that the access
is within bounds. This also has the effect of making our out-of-bounds handling consistent
with WebCore.

* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

LayoutTests: 

Reviewed by Gavin Barraclough.

* fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt: Added.
* fast/js/dfg-put-by-val-setter-then-get-by-val.html: Added.
* fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias-expected.txt: Added.
* fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.html: Added.
* fast/js/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Added.
(foo):
(for):
* fast/js/script-tests/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.js: Added.
(foo):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp


Added Paths

trunk/LayoutTests/fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt
trunk/LayoutTests/fast/js/dfg-put-by-val-setter-then-get-by-val.html
trunk/LayoutTests/fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias-expected.txt
trunk/LayoutTests/fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.html
trunk/LayoutTests/fast/js/script-tests/dfg-put-by-val-setter-then-get-by-val.js
trunk/LayoutTests/fast/js/script-tests/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.js




Diff

Modified: trunk/LayoutTests/ChangeLog (121306 => 121307)

--- trunk/LayoutTests/ChangeLog	2012-06-27 01:31:22 UTC (rev 121306)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 01:34:01 UTC (rev 121307)
@@ -1,3 +1,21 @@
+2012-06-26  Filip Pizlo  fpi...@apple.com
+
+DFG PutByValAlias is too aggressive
+https://bugs.webkit.org/show_bug.cgi?id=90026
+rdar://problem/11751830
+
+Reviewed by Gavin Barraclough.
+
+* fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt: Added.
+* fast/js/dfg-put-by-val-setter-then-get-by-val.html: Added.
+* fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias-expected.txt: Added.
+* fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.html: Added.
+* fast/js/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Added.
+(foo):
+(for):
+* fast/js/script-tests/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.js: Added.
+(foo):
+
 2012-06-26  Kevin Ellis  kev...@chromium.org
 
 Touch adjustment does not target shadow DOM elements


Added: trunk/LayoutTests/fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt (0 => 121307)

--- trunk/LayoutTests/fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt	2012-06-27 01:34:01 UTC (rev 121307)
@@ -0,0 +1,409 @@
+Tests that a GetByVal that accesses a value that was PutByVal'd, but where the PutByVal invoked a setter, works correctly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS foo(array, -1, i) is 42
+PASS thingy is 0
+PASS foo(array, -1, i) is 42
+PASS thingy is 1
+PASS foo(array, -1, i) is 42
+PASS thingy is 2
+PASS foo(array, -1, i) is 42
+PASS thingy is 3
+PASS foo(array, -1, i) is 42
+PASS thingy is 4
+PASS foo(array, -1, i) is 42
+PASS thingy is 5
+PASS foo(array, -1, i) is 42
+PASS thingy is 6
+PASS foo(array, -1, i) is 42
+PASS thingy is 7
+PASS foo(array, -1, i) is 42
+PASS thingy is 8
+PASS foo(array, -1, i) is 42
+PASS thingy is 9
+PASS foo(array, -1, i) is 42
+PASS thingy is 10
+PASS foo(array, -1, i) is 42
+PASS thingy is 11
+PASS foo(array, -1, i) is 42
+PASS thingy is 12
+PASS foo(array, -1, i) is 42
+PASS thingy is 13
+PASS foo(array, -1, i) is 42
+PASS thingy is 14
+PASS foo(array, -1, i) is 42
+PASS thingy is 15
+PASS foo(array, -1, i) is 42
+PASS thingy is 16
+PASS foo(array, -1, i) is 42
+PASS thingy is 17
+PASS foo(array, -1, i) is 42
+PASS thingy is 18
+PASS foo(array, -1, i) is 42
+PASS thingy is 19
+PASS foo(array, -1, i) is 42
+PASS thingy is 20
+PASS foo(array, -1, i) is 42
+PASS thingy is 21

[webkit-changes] [121308] trunk/Tools

[mhahnenberg]

Title: [121308] trunk/Tools








Revision 121308
Author mhahnenb...@apple.com
Date 2012-06-26 18:38:41 -0700 (Tue, 26 Jun 2012)


Log Message
Add support for preciseTime() to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=90027

Reviewed by Darin Adler.

It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 
(WTR::LayoutTestController::preciseTime): 
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h




Diff

Modified: trunk/Tools/ChangeLog (121307 => 121308)

--- trunk/Tools/ChangeLog	2012-06-27 01:34:01 UTC (rev 121307)
+++ trunk/Tools/ChangeLog	2012-06-27 01:38:41 UTC (rev 121308)
@@ -1,3 +1,19 @@
+2012-06-26  Mark Hahnenberg  mhahnenb...@apple.com
+
+Add support for preciseTime() to WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=90027
+
+Reviewed by Darin Adler.
+
+It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
+
+* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
+* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 
+(WTR::LayoutTestController::preciseTime): 
+(WTR):
+* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
+(LayoutTestController):
+
 2012-06-26  Lucas Forschler  lforsch...@apple.com
 
   Teach the Apple port how to build the test tools in build-webkit


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl (121307 => 121308)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl	2012-06-27 01:34:01 UTC (rev 121307)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl	2012-06-27 01:38:41 UTC (rev 121308)
@@ -32,6 +32,7 @@
 void waitForPolicyDelegate();
 void waitUntilDone();
 void notifyDone();
+double preciseTime();
 
 // Other dumping.
 void dumpBackForwardList();


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp (121307 => 121308)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp	2012-06-27 01:34:01 UTC (rev 121307)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp	2012-06-27 01:38:41 UTC (rev 121308)
@@ -43,6 +43,7 @@
 #include WebKit2/WKBundleScriptWorld.h
 #include WebKit2/WKRetainPtr.h
 #include WebKit2/WebKit2.h
+#include wtf/CurrentTime.h
 #include wtf/HashMap.h
 #include wtf/text/StringBuilder.h
 
@@ -617,4 +618,9 @@
 WKBundleOverrideBoolPreferenceForTestRunner(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), toWK(preference).get(), value);
 }
 
+double LayoutTestController::preciseTime()
+{
+return currentTime();
+}
+
 } // namespace WTR


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h (121307 => 121308)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h	2012-06-27 01:34:01 UTC (rev 121307)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h	2012-06-27 01:38:41 UTC (rev 121308)
@@ -63,6 +63,7 @@
 void dumpChildFramesAsText() { m_whatToDump = AllFramesText; }
 void waitUntilDone();
 void notifyDone();
+double preciseTime();
 
 // Other dumping.
 void dumpBackForwardList() { m_shouldDumpBackForwardListsForAllWindows = true; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121309] trunk

[commit-queue]

Title: [121309] trunk








Revision 121309
Author commit-qu...@webkit.org
Date 2012-06-26 18:41:06 -0700 (Tue, 26 Jun 2012)


Log Message
Unexpected element sizes when mixing inline-table with box-sizing
https://bugs.webkit.org/show_bug.cgi?id=89819

Patch by Kulanthaivel Palanichamy kulanthai...@codeaurora.org on 2012-06-26
Reviewed by Julien Chaffraix.

Source/WebCore:

This change handles box-sizing: border-box property for CSS tables properly.

Test: fast/box-sizing/css-table-with-box-sizing.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):

LayoutTests:

* fast/box-sizing/css-table-with-box-sizing-expected.txt: Added.
* fast/box-sizing/css-table-with-box-sizing.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTable.cpp


Added Paths

trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing-expected.txt
trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121308 => 121309)

--- trunk/LayoutTests/ChangeLog	2012-06-27 01:38:41 UTC (rev 121308)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 01:41:06 UTC (rev 121309)
@@ -1,3 +1,13 @@
+2012-06-26  Kulanthaivel Palanichamy  kulanthai...@codeaurora.org
+
+Unexpected element sizes when mixing inline-table with box-sizing
+https://bugs.webkit.org/show_bug.cgi?id=89819
+
+Reviewed by Julien Chaffraix.
+
+* fast/box-sizing/css-table-with-box-sizing-expected.txt: Added.
+* fast/box-sizing/css-table-with-box-sizing.html: Added.
+
 2012-06-26  Filip Pizlo  fpi...@apple.com
 
 DFG PutByValAlias is too aggressive


Added: trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing-expected.txt (0 => 121309)

--- trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing-expected.txt	2012-06-27 01:41:06 UTC (rev 121309)
@@ -0,0 +1,17 @@
+Test case for bug 89819. This tests CSS 'table' and 'inline-table' with box-sizing.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS document.getElementById(t1).offsetWidth is 120
+PASS document.getElementById(t1).offsetHeight is 120
+PASS document.getElementById(t2).offsetWidth is 120
+PASS document.getElementById(t2).offsetHeight is 120
+PASS document.getElementById(t3).offsetWidth is 140
+PASS document.getElementById(t3).offsetHeight is 140
+PASS document.getElementById(t4).offsetWidth is 140
+PASS document.getElementById(t4).offsetHeight is 140
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing.html (0 => 121309)

--- trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing.html	(rev 0)
+++ trunk/LayoutTests/fast/box-sizing/css-table-with-box-sizing.html	2012-06-27 01:41:06 UTC (rev 121309)
@@ -0,0 +1,53 @@
+html
+head
+  style
+.test {
+  width:120px;
+  height:120px;
+  border:10px solid black;
+}
+
+.border-box {
+  box-sizing:border-box;
+  -moz-box-sizing:border-box;
+}
+
+	.content-box {
+  box-sizing:content-box;
+  -moz-box-sizing:content-box;
+} 	
+
+.css-inline-table {
+  display:inline-table;
+}
+
+.css-table {
+  display:table;
+}
+  /style
+/head
+body
+div id=testContent
+  p id=t1 class=test css-inline-table border-box120x120brcss-inline-tablebrborder-box/p
+  p id=t2 class=test css-table border-box120x120brcss-tablebrborder-box/p
+  p id=t3 class=test css-inline-table content-box120x120brcss-inline-tablebrcontent-box/p
+  p id=t4 class=test css-table content-box120x120brcss-tablebrcontent-box/p
+/div
+  script src=""
+  script
+description(Test case for bug 89819. This tests CSS 'table' and 'inline-table' with box-sizing.);
+
+shouldBe('document.getElementById(t1).offsetWidth', '120');
+shouldBe('document.getElementById(t1).offsetHeight', '120');
+shouldBe('document.getElementById(t2).offsetWidth', '120');
+shouldBe('document.getElementById(t2).offsetHeight', '120');
+shouldBe('document.getElementById(t3).offsetWidth', '140');
+shouldBe('document.getElementById(t3).offsetHeight', '140');
+shouldBe('document.getElementById(t4).offsetWidth', '140');
+shouldBe('document.getElementById(t4).offsetHeight', '140');
+
+document.getElementById(testContent).style.display = 'none';
+/script
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (121308 => 121309)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 01:38:41 UTC (rev 121308)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 01:41:06 UTC (rev 121309)
@@ -1,3 +1,18 @@
+2012-06-26  Kulanthaivel Palanichamy  kulanthai...@codeaurora.org
+
+Unexpected element sizes when mixing inline-table with box-sizing
+  

[webkit-changes] [121310] trunk/Source

[commit-queue]

Title: [121310] trunk/Source








Revision 121310
Author commit-qu...@webkit.org
Date 2012-06-26 18:49:20 -0700 (Tue, 26 Jun 2012)


Log Message
[chromium] Remove WebView::graphicsContext3D getter
https://bugs.webkit.org/show_bug.cgi?id=89916

Patch by James Robinson jam...@chromium.org on 2012-06-26
Reviewed by Adrienne Walker.

Source/Platform:

Remove unused getter.

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):

Source/WebCore:

Deletes code supporting compositor context getter.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

Removes WebView::graphicsContext3D getter. This getter was used to access the compositor's context, which is an
inherently dangerous operation since the compositor context may not be safe to use on the main thread and has
somewhat complicated creation / recreation semantics. A shared context is exposed
(WebView::sharedGraphicsContext3D) for callers who may want access to a context in a share group with the
compositor.

* public/WebView.h:
(WebView):
* src/WebLayerTreeView.cpp:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebLayerTreeView.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCProxy.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/WebLayerTreeView.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h




Diff

Modified: trunk/Source/Platform/ChangeLog (121309 => 121310)

--- trunk/Source/Platform/ChangeLog	2012-06-27 01:41:06 UTC (rev 121309)
+++ trunk/Source/Platform/ChangeLog	2012-06-27 01:49:20 UTC (rev 121310)
@@ -1,3 +1,15 @@
+2012-06-26  James Robinson  jam...@chromium.org
+
+[chromium] Remove WebView::graphicsContext3D getter
+https://bugs.webkit.org/show_bug.cgi?id=89916
+
+Reviewed by Adrienne Walker.
+
+Remove unused getter.
+
+* chromium/public/WebLayerTreeView.h:
+(WebLayerTreeView):
+
 2012-06-26  Dave Tu  d...@chromium.org
 
 [chromium] Expose rendering statistics to WebWidget.


Modified: trunk/Source/Platform/chromium/public/WebLayerTreeView.h (121309 => 121310)

--- trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2012-06-27 01:41:06 UTC (rev 121309)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeView.h	2012-06-27 01:49:20 UTC (rev 121310)
@@ -167,11 +167,6 @@
 // This can have a significant performance impact and should be used with care.
 WEBKIT_EXPORT void finishAllRendering();
 
-// Returns the context being used for rendering this view. In threaded compositing mode, it is
-// not safe to use this context for anything on the main thread, other than passing the pointer to
-// the compositor thread.
-WEBKIT_EXPORT WebGraphicsContext3D* context();
-
 // Debugging / dangerous -
 
 // Fills in a WebRenderingStats struct containing information about the state of the compositor.


Modified: trunk/Source/WebCore/ChangeLog (121309 => 121310)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 01:41:06 UTC (rev 121309)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 01:49:20 UTC (rev 121310)
@@ -1,3 +1,24 @@
+2012-06-26  James Robinson  jam...@chromium.org
+
+[chromium] Remove WebView::graphicsContext3D getter
+https://bugs.webkit.org/show_bug.cgi?id=89916
+
+Reviewed by Adrienne Walker.
+
+Deletes code supporting compositor context getter.
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+(CCLayerTreeHost):
+* platform/graphics/chromium/cc/CCProxy.h:
+(CCProxy):
+* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
+* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
+(CCSingleThreadProxy):
+* platform/graphics/chromium/cc/CCThreadProxy.cpp:
+* platform/graphics/chromium/cc/CCThreadProxy.h:
+(CCThreadProxy):
+
 2012-06-26  Kulanthaivel Palanichamy  

[webkit-changes] [121311] trunk

[macpherson]

Title: [121311] trunk








Revision 121311
Author macpher...@chromium.org
Date 2012-06-26 18:57:13 -0700 (Tue, 26 Jun 2012)


Log Message
Be careful not to read past the end of input in CSSParser::lex() when looking for variable definitions.
https://bugs.webkit.org/show_bug.cgi?id=89949

Reviewed by Abhishek Arya.

Added repro case as fast/css/short-inline-style.html.

* css/CSSParser.cpp:
(WebCore::CSSParser::lex):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp


Added Paths

trunk/LayoutTests/fast/css/short-inline-style-expected.txt
trunk/LayoutTests/fast/css/short-inline-style.html




Diff

Added: trunk/LayoutTests/fast/css/short-inline-style-expected.txt (0 => 121311)

--- trunk/LayoutTests/fast/css/short-inline-style-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/short-inline-style-expected.txt	2012-06-27 01:57:13 UTC (rev 121311)
@@ -0,0 +1 @@
+Test successful if it does not crash.


Added: trunk/LayoutTests/fast/css/short-inline-style.html (0 => 121311)

--- trunk/LayoutTests/fast/css/short-inline-style.html	(rev 0)
+++ trunk/LayoutTests/fast/css/short-inline-style.html	2012-06-27 01:57:13 UTC (rev 121311)
@@ -0,0 +1,5 @@
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+a style=top:-1px;Test successful if it does not crash./a


Modified: trunk/Source/WebCore/ChangeLog (121310 => 121311)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 01:49:20 UTC (rev 121310)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 01:57:13 UTC (rev 121311)
@@ -1,3 +1,15 @@
+2012-06-26  Luke Macpherson  macpher...@chromium.org
+
+Be careful not to read past the end of input in CSSParser::lex() when looking for variable definitions.
+https://bugs.webkit.org/show_bug.cgi?id=89949
+
+Reviewed by Abhishek Arya.
+
+Added repro case as fast/css/short-inline-style.html.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::lex):
+
 2012-06-26  James Robinson  jam...@chromium.org
 
 [chromium] Remove WebView::graphicsContext3D getter


Modified: trunk/Source/WebCore/css/CSSParser.cpp (121310 => 121311)

--- trunk/Source/WebCore/css/CSSParser.cpp	2012-06-27 01:49:20 UTC (rev 121310)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-06-27 01:57:13 UTC (rev 121311)
@@ -8972,7 +8972,7 @@
 
 case CharacterDash:
 #if ENABLE(CSS_VARIABLES)
-if (cssVariablesEnabled()  m_currentCharacter[10] == '-'  isEqualToCSSIdentifier(m_currentCharacter, webkit-var)  isIdentifierStartAfterDash(m_currentCharacter + 11)) {
+if (cssVariablesEnabled()  isEqualToCSSIdentifier(m_currentCharacter, webkit-var)  m_currentCharacter[10] == '-'  isIdentifierStartAfterDash(m_currentCharacter + 11)) {
 // handle variable declarations
 m_currentCharacter += 11;
 parseIdentifier(result, hasEscape);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121313] trunk/Source/WebCore

[thakis]

Title: [121313] trunk/Source/WebCore








Revision 121313
Author tha...@chromium.org
Date 2012-06-26 19:20:21 -0700 (Tue, 26 Jun 2012)


Log Message
Fix new Wunused-private-field violations that crept in
https://bugs.webkit.org/show_bug.cgi?id=90032

Reviewed by Adam Barth.

* page/Performance.h:
(Performance):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Performance.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (121312 => 121313)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 02:11:13 UTC (rev 121312)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 02:20:21 UTC (rev 121313)
@@ -1,3 +1,13 @@
+2012-06-26  Nico Weber  tha...@chromium.org
+
+Fix new Wunused-private-field violations that crept in
+https://bugs.webkit.org/show_bug.cgi?id=90032
+
+Reviewed by Adam Barth.
+
+* page/Performance.h:
+(Performance):
+
 2012-06-26  Gyuyoung Kim  gyuyoung@samsung.com
 
 Change return type in bandwidth attribute of network information API


Modified: trunk/Source/WebCore/page/Performance.h (121312 => 121313)

--- trunk/Source/WebCore/page/Performance.h	2012-06-27 02:11:13 UTC (rev 121312)
+++ trunk/Source/WebCore/page/Performance.h	2012-06-27 02:20:21 UTC (rev 121313)
@@ -90,7 +90,6 @@
 virtual EventTargetData* ensureEventTargetData();
 
 EventTargetData m_eventTargetData;
-ScriptExecutionContext *m_scriptExecutionContext;
 
 mutable RefPtrPerformanceNavigation m_navigation;
 mutable RefPtrPerformanceTiming m_timing;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121314] trunk

[commit-queue]

Title: [121314] trunk








Revision 121314
Author commit-qu...@webkit.org
Date 2012-06-26 20:02:48 -0700 (Tue, 26 Jun 2012)


Log Message
REGRESSION(r107836): box shadow not drawn for opaque images with an opaque background
https://bugs.webkit.org/show_bug.cgi?id=89958

Patch by Douglas Stockwell dstockw...@chromium.org on 2012-06-26
Reviewed by Simon Fraser.

Source/WebCore:

Don't attempt to draw the box shadow as part of the background if the background is
obscured.

Test: fast/box-shadow/image-box-shadow.html

* rendering/RenderImage.cpp:
(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore):
* rendering/RenderImage.h:
(RenderImage):

LayoutTests:

* fast/box-shadow/image-box-shadow-expected.html: Added.
* fast/box-shadow/image-box-shadow.html: Added.
* fast/box-shadow/resources/green-alpha.png: Added.
* fast/box-shadow/resources/green.jpg: Added.
* fast/box-shadow/resources/green.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderImage.cpp
trunk/Source/WebCore/rendering/RenderImage.h


Added Paths

trunk/LayoutTests/fast/box-shadow/image-box-shadow-expected.html
trunk/LayoutTests/fast/box-shadow/image-box-shadow.html
trunk/LayoutTests/fast/box-shadow/resources/green-alpha.png
trunk/LayoutTests/fast/box-shadow/resources/green.jpg
trunk/LayoutTests/fast/box-shadow/resources/green.png




Diff

Modified: trunk/LayoutTests/ChangeLog (121313 => 121314)

--- trunk/LayoutTests/ChangeLog	2012-06-27 02:20:21 UTC (rev 121313)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 03:02:48 UTC (rev 121314)
@@ -1,3 +1,16 @@
+2012-06-26  Douglas Stockwell  dstockw...@chromium.org
+
+REGRESSION(r107836): box shadow not drawn for opaque images with an opaque background
+https://bugs.webkit.org/show_bug.cgi?id=89958
+
+Reviewed by Simon Fraser.
+
+* fast/box-shadow/image-box-shadow-expected.html: Added.
+* fast/box-shadow/image-box-shadow.html: Added.
+* fast/box-shadow/resources/green-alpha.png: Added.
+* fast/box-shadow/resources/green.jpg: Added.
+* fast/box-shadow/resources/green.png: Added.
+
 2012-06-26  Kulanthaivel Palanichamy  kulanthai...@codeaurora.org
 
 Unexpected element sizes when mixing inline-table with box-sizing


Added: trunk/LayoutTests/fast/box-shadow/image-box-shadow-expected.html (0 => 121314)

--- trunk/LayoutTests/fast/box-shadow/image-box-shadow-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/box-shadow/image-box-shadow-expected.html	2012-06-27 03:02:48 UTC (rev 121314)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+style
+img {
+width: 50px;
+height: 25px;
+margin-bottom: 25px;
+}
+div {
+display: inline-block;
+background: rgb(0,256,0);
+height: 50px;
+}
+/style
+divimg src=""
+divimg src=""
+divimg src=""


Added: trunk/LayoutTests/fast/box-shadow/image-box-shadow.html (0 => 121314)

--- trunk/LayoutTests/fast/box-shadow/image-box-shadow.html	(rev 0)
+++ trunk/LayoutTests/fast/box-shadow/image-box-shadow.html	2012-06-27 03:02:48 UTC (rev 121314)
@@ -0,0 +1,18 @@
+!DOCTYPE html
+style
+img {
+background: rgb(0,256,0);
+width: 50px;
+height: 25px;
+margin-bottom: 25px;
+box-shadow: 0px 25px rgb(0,256,0); 
+}
+div {
+display: inline-block;
+background: red;
+height: 50px;
+}
+/style
+divimg src=""
+divimg src=""
+divimg src=""


Added: trunk/LayoutTests/fast/box-shadow/resources/green-alpha.png (0 => 121314)

--- trunk/LayoutTests/fast/box-shadow/resources/green-alpha.png	(rev 0)
+++ trunk/LayoutTests/fast/box-shadow/resources/green-alpha.png	2012-06-27 03:02:48 UTC (rev 121314)
@@ -0,0 +1,5 @@
+\x89PNG
+
+
+IHDR

ĉ
+IDAT[cd\xF8\xCFP\x86
\x80\xA2`IEND\xAEB`\x82
\ No newline at end of file


Added: trunk/LayoutTests/fast/box-shadow/resources/green.jpg (0 => 121314)

--- trunk/LayoutTests/fast/box-shadow/resources/green.jpg	(rev 0)
+++ trunk/LayoutTests/fast/box-shadow/resources/green.jpg	2012-06-27 03:02:48 UTC (rev 121314)
@@ -0,0 +1,12 @@
+\xFF\xD8\xFF\xE0JFIF



\xFF\xDBC	
+
+			
+
+		
+
+
+\xFF\xDBC
	\xFF\xC0




\xFF\xC4



	
+\xFF\xC4\xB5

}
!1AQaq2\x81\x91\xA1#B\xB1\xC1R\xD1\xF0$3br\x82	
+%'()*456789:CDEFGHIJSTUVWXYZcdefghijstuvwxyz\x83\x84\x85\x86\x87\x88\x89\x8A\x92\x93\x94\x95\x96\x97\x98\x99\x9A\xA2\xA3\xA4\xA5\xA6\xA7\xA8\xA9\xAA\xB2\xB3\xB4\xB5\xB6\xB7\xB8\xB9\xBA\xC2\xC3\xC4\xC5\xC6\xC7\xC8\xC9\xCA\xD2\xD3\xD4\xD5\xD6\xD7\xD8\xD9\xDA\xE1\xE2\xE3\xE4\xE5\xE6\xE7\xE8\xE9\xEA\xF1\xF2\xF3\xF4\xF5\xF6\xF7\xF8\xF9\xFA\xFF\xC4


	
+\xFF\xC4\xB5

w
!1AQaq2\x81B\x91\xA1\xB1\xC1	#3R\xF0br\xD1

[webkit-changes] [121316] trunk/Source

[ggaren]

Title: [121316] trunk/Source








Revision 121316
Author gga...@apple.com
Date 2012-06-26 20:44:05 -0700 (Tue, 26 Jun 2012)


Log Message
Reduced (but did not eliminate) use of berzerker GC
https://bugs.webkit.org/show_bug.cgi?id=89237

Reviewed by Gavin Barraclough.

(PART 2)

../_javascript_Core: 

This part turns off berzerker GC and turns on incremental shrinking.

* heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::doSweep): Free or shrink after sweeping to
maintain the behavior we used to get from the occasional berzerker GC,
which would run all finalizers and then free or shrink all blocks
synchronously.

* heap/MarkedBlock.h:
(JSC::MarkedBlock::needsSweeping): Sweep zapped blocks, too. It's always
safe to sweep a zapped block (that's the point of zapping), and it's
sometimes profitable. For example, consider this case: Block A does some
allocation (transitioning Block A from Marked to FreeListed), then GC
happens (transitioning Block A to Zapped), then all objects in Block A
are free, then the incremental sweeper visits Block A. If we skipped
Zapped blocks, we'd skip Block A, even though it would be profitable to
run its destructors and free its memory.

* runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::doWork): Don't sweep eagerly; we'll do
this incrementally.

../WebCore: 

Don't ASSERT that RootObject's destructor runs and invalidates all
RuntimeObjects before their destructors run.

We don't guarantee this behavior because some RuntimeObjects may already
be garbage by the time RootObject's destructor runs, in which case
RootObject's weak pointers will be NULL, and RootObject will not call
invalidate() on them.

It's been theoretically possible for this ASSERT to fire for a while now.
This patch makes it fire all the time.

Luckily, we only needed the behavior guarded by this ASSERT for WebKit1
in Safari on Windows (cf. https://bugs.webkit.org/show_bug.cgi?id=61317),
to handle the way WebKit1 would unload plugin DLLs. If this ever becomes
an issue again, we can fix it by (a) not unloading plugin DLLs,
(b) migrating WebKit1 to the WebKit2 JS-plugin binding model, (c) making
the Instance pointer in a RuntimeObject an indirect pointer through
RootObject, or (c) giving RuntimeObject some sort of special way to
access a zombie weak pointer.

* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::destroy): ASSERT removed. Anders said so.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/IncrementalSweeper.cpp
trunk/Source/_javascript_Core/heap/MarkedBlock.h
trunk/Source/_javascript_Core/runtime/GCActivityCallback.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bridge/runtime_object.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (121315 => 121316)

--- trunk/Source/_javascript_Core/ChangeLog	2012-06-27 03:30:32 UTC (rev 121315)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-06-27 03:44:05 UTC (rev 121316)
@@ -1,3 +1,34 @@
+2012-06-26  Geoffrey Garen  gga...@apple.com
+
+Reduced (but did not eliminate) use of berzerker GC
+https://bugs.webkit.org/show_bug.cgi?id=89237
+
+Reviewed by Gavin Barraclough.
+
+(PART 2)
+
+This part turns off berzerker GC and turns on incremental shrinking.
+
+* heap/IncrementalSweeper.cpp:
+(JSC::IncrementalSweeper::doSweep): Free or shrink after sweeping to
+maintain the behavior we used to get from the occasional berzerker GC,
+which would run all finalizers and then free or shrink all blocks
+synchronously.
+
+* heap/MarkedBlock.h:
+(JSC::MarkedBlock::needsSweeping): Sweep zapped blocks, too. It's always
+safe to sweep a zapped block (that's the point of zapping), and it's
+sometimes profitable. For example, consider this case: Block A does some
+allocation (transitioning Block A from Marked to FreeListed), then GC
+happens (transitioning Block A to Zapped), then all objects in Block A
+are free, then the incremental sweeper visits Block A. If we skipped
+Zapped blocks, we'd skip Block A, even though it would be profitable to
+run its destructors and free its memory.
+
+* runtime/GCActivityCallback.cpp:
+(JSC::DefaultGCActivityCallback::doWork): Don't sweep eagerly; we'll do
+this incrementally.
+
 2012-06-26  Filip Pizlo  fpi...@apple.com
 
 DFG PutByValAlias is too aggressive


Modified: trunk/Source/_javascript_Core/heap/IncrementalSweeper.cpp (121315 => 121316)

--- trunk/Source/_javascript_Core/heap/IncrementalSweeper.cpp	2012-06-27 03:30:32 UTC (rev 121315)
+++ trunk/Source/_javascript_Core/heap/IncrementalSweeper.cpp	2012-06-27 03:44:05 UTC (rev 121316)
@@ -78,6 +78,7 @@
 continue;
 
 block-sweep();
+m_globalData-heap.objectSpace().freeOrShrinkBlock(block);
 
 CFTimeInterval elapsedTime = WTF::monotonicallyIncreasingTime() - sweepBeginTime;
 if 

[webkit-changes] [121317] trunk/LayoutTests

[keishi]

Title: [121317] trunk/LayoutTests








Revision 121317
Author kei...@webkit.org
Date 2012-06-26 20:49:44 -0700 (Tue, 26 Jun 2012)


Log Message
[Chromium] Rebaseline fast/backgrounds/size/zero.html. Caused by r121296

Unreviewed.

* platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png:
* platform/chromium-mac/fast/backgrounds/size/zero-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/size/zero-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (121316 => 121317)

--- trunk/LayoutTests/ChangeLog	2012-06-27 03:44:05 UTC (rev 121316)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 03:49:44 UTC (rev 121317)
@@ -1,5 +1,14 @@
 2012-06-26  Keishi Hattori  kei...@webkit.org
 
+[Chromium] Rebaseline fast/backgrounds/size/zero.html. Caused by r121296
+
+Unreviewed.
+
+* platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png:
+* platform/chromium-mac/fast/backgrounds/size/zero-expected.png:
+
+2012-06-26  Keishi Hattori  kei...@webkit.org
+
 [Chromium] Rebaseline 4 tests in editing/deleting. Caused by r121303.
 
 Unreviewed.


Modified: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/size/zero-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121318] trunk/LayoutTests

[rniwa]

Title: [121318] trunk/LayoutTests








Revision 121318
Author rn...@webkit.org
Date 2012-06-26 21:03:04 -0700 (Tue, 26 Jun 2012)


Log Message
Rebaseline after r121286 and r121290.

* editing/deleting/merge-into-empty-block-2-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/deleting/merge-into-empty-block-2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (121317 => 121318)

--- trunk/LayoutTests/ChangeLog	2012-06-27 03:49:44 UTC (rev 121317)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 04:03:04 UTC (rev 121318)
@@ -1,3 +1,9 @@
+2012-06-26  Ryosuke Niwa  rn...@webkit.org
+
+Rebaseline after r121286 and r121290.
+
+* editing/deleting/merge-into-empty-block-2-expected.txt:
+
 2012-06-26  Keishi Hattori  kei...@webkit.org
 
 [Chromium] Rebaseline fast/backgrounds/size/zero.html. Caused by r121296


Modified: trunk/LayoutTests/editing/deleting/merge-into-empty-block-2-expected.txt (121317 => 121318)

--- trunk/LayoutTests/editing/deleting/merge-into-empty-block-2-expected.txt	2012-06-27 03:49:44 UTC (rev 121317)
+++ trunk/LayoutTests/editing/deleting/merge-into-empty-block-2-expected.txt	2012-06-27 04:03:04 UTC (rev 121318)
@@ -4,20 +4,10 @@
 EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of DIV  DIV  BODY  HTML  #document to 0 of LI  UL  DIV  BODY  HTML  #document
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-CONSOLE MESSAGE: line 13: ReferenceError: Can't find variable: Markup
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x576
-  RenderBlock {P} at (0,0) size 784x18
-RenderText {#text} at (0,0) size 731x18
-  text run at (0,0) width 731: When a user puts the caret at the very beginning a list and hits delete into an empty line, the list should just move up.
-  RenderBlock {DIV} at (0,34) size 784x18
-RenderBlock {UL} at (0,0) size 784x18
-  RenderListItem {LI} at (40,0) size 744x18
-RenderListMarker at (-17,0) size 7x18: bullet
-RenderInline {SPAN} at (0,0) size 21x18
-  RenderText {#text} at (0,0) size 21x18
-text run at (0,0) width 21: foo
-caret: position 0 of child 0 {#text} of child 0 {SPAN} of child 0 {LI} of child 0 {UL} of child 2 {DIV} of body
+EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification
+When a user puts the caret at the very beginning a list and hits delete into an empty line, the list should just move up.
+| ul
+|   li
+| span
+|   id=test
+|   #selection-caretfoo






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121319] trunk

[commit-queue]

Title: [121319] trunk








Revision 121319
Author commit-qu...@webkit.org
Date 2012-06-26 21:22:47 -0700 (Tue, 26 Jun 2012)


Log Message
DragData::asFilenames should not push same file names to result in Windows.
https://bugs.webkit.org/show_bug.cgi?id=79861

Patch by Xueqing Huang huangxueq...@baidu.com on 2012-06-26
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: platform/win/fast/forms/file/drag-and-drop-files.html

* platform/win/DragDataWin.cpp:
(WebCore::DragData::asFilenames):

LayoutTests:

* platform/win/fast/forms/file/drag-and-drop-files-expected.txt: Added.
* platform/win/fast/forms/file/drag-and-drop-files.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/win/DragDataWin.cpp


Added Paths

trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files-expected.txt
trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121318 => 121319)

--- trunk/LayoutTests/ChangeLog	2012-06-27 04:03:04 UTC (rev 121318)
+++ trunk/LayoutTests/ChangeLog	2012-06-27 04:22:47 UTC (rev 121319)
@@ -1,3 +1,13 @@
+2012-06-26  Xueqing Huang  huangxueq...@baidu.com
+
+DragData::asFilenames should not push same file names to result in Windows.
+https://bugs.webkit.org/show_bug.cgi?id=79861
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/win/fast/forms/file/drag-and-drop-files-expected.txt: Added.
+* platform/win/fast/forms/file/drag-and-drop-files.html: Added.
+
 2012-06-26  Ryosuke Niwa  rn...@webkit.org
 
 Rebaseline after r121286 and r121290.


Added: trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files-expected.txt (0 => 121319)

--- trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files-expected.txt	2012-06-27 04:22:47 UTC (rev 121319)
@@ -0,0 +1,12 @@
+Tests drag multi-files into input type='file', and check the files name were correct.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS fileInput.files[0].name is 'got-file-upload-0.html'
+PASS fileInput.files[1].name is 'got-file-upload-1.html'
+PASS fileInput.files[2].name is 'got-file-upload-2.html'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files.html (0 => 121319)

--- trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files.html	(rev 0)
+++ trunk/LayoutTests/platform/win/fast/forms/file/drag-and-drop-files.html	2012-06-27 04:22:47 UTC (rev 121319)
@@ -0,0 +1,30 @@
+!DOCTYPE html
+html
+body
+input id=fileInput type=file multiple=true _onchange_=displayFiles()/input
+script src=""
+script
+description(Tests drag multi-files into lt;input type='file'gt;, and check the files name were correct.);
+
+if (window.eventSender) {
+var inputElement = document.getElementById(fileInput); 
+var fileRect = inputElement.getClientRects()[0];
+var targetX = fileRect.left + fileRect.width / 2;
+var targetY = fileRect.top + fileRect.height / 2;
+eventSender.beginDragWithFiles(['got-file-upload-0.html', 'got-file-upload-1.html', 'got-file-upload-2.html']);
+eventSender.mouseMoveTo(targetX, targetY);
+eventSender.mouseUp();
+}
+
+function displayFiles()
+{
+var input = document.getElementById(fileInput);
+shouldBe(fileInput.files[0].name, 'got-file-upload-0.html');
+shouldBe(fileInput.files[1].name, 'got-file-upload-1.html');
+shouldBe(fileInput.files[2].name, 'got-file-upload-2.html');
+}
+/script
+script src=""
+
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (121318 => 121319)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 04:03:04 UTC (rev 121318)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 04:22:47 UTC (rev 121319)
@@ -1,3 +1,15 @@
+2012-06-26  Xueqing Huang  huangxueq...@baidu.com
+
+DragData::asFilenames should not push same file names to result in Windows.
+https://bugs.webkit.org/show_bug.cgi?id=79861
+
+Reviewed by Alexey Proskuryakov.
+
+Test: platform/win/fast/forms/file/drag-and-drop-files.html 
+
+* platform/win/DragDataWin.cpp:
+(WebCore::DragData::asFilenames):
+
 2012-06-26  Geoffrey Garen  gga...@apple.com
 
 Reduced (but did not eliminate) use of berzerker GC


Modified: trunk/Source/WebCore/platform/win/DragDataWin.cpp (121318 => 121319)

--- trunk/Source/WebCore/platform/win/DragDataWin.cpp	2012-06-27 04:03:04 UTC (rev 121318)
+++ trunk/Source/WebCore/platform/win/DragDataWin.cpp	2012-06-27 04:22:47 UTC (rev 121319)
@@ -140,17 +140,17 @@
 STGMEDIUM medium;
 if (FAILED(m_platformDragData-GetData(cfHDropFormat(), medium)))
 return;
+   
+HDROP hdrop = reinterpret_castHDROP(GlobalLock(medium.hGlobal)); 
 
-

[webkit-changes] [121320] trunk/Source/WebCore

[macpherson]

Title: [121320] trunk/Source/WebCore








Revision 121320
Author macpher...@chromium.org
Date 2012-06-26 22:40:18 -0700 (Tue, 26 Jun 2012)


Log Message
Return correct value for css variables enabled runtime flag.
https://bugs.webkit.org/show_bug.cgi?id=90040

Reviewed by Dimitri Glazkov.

Was always returning true for the runtime flag when the compile time flag was on. That was good for testing,
but not so much for production.

* page/Settings.h:
(WebCore::Settings::cssVariablesEnabled):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (121319 => 121320)

--- trunk/Source/WebCore/ChangeLog	2012-06-27 04:22:47 UTC (rev 121319)
+++ trunk/Source/WebCore/ChangeLog	2012-06-27 05:40:18 UTC (rev 121320)
@@ -1,3 +1,16 @@
+2012-06-26  Luke Macpherson  macpher...@chromium.org
+
+Return correct value for css variables enabled runtime flag.
+https://bugs.webkit.org/show_bug.cgi?id=90040
+
+Reviewed by Dimitri Glazkov.
+
+Was always returning true for the runtime flag when the compile time flag was on. That was good for testing,
+but not so much for production.
+
+* page/Settings.h:
+(WebCore::Settings::cssVariablesEnabled):
+
 2012-06-26  Xueqing Huang  huangxueq...@baidu.com
 
 DragData::asFilenames should not push same file names to result in Windows.


Modified: trunk/Source/WebCore/page/Settings.h (121319 => 121320)

--- trunk/Source/WebCore/page/Settings.h	2012-06-27 04:22:47 UTC (rev 121319)
+++ trunk/Source/WebCore/page/Settings.h	2012-06-27 05:40:18 UTC (rev 121320)
@@ -333,7 +333,7 @@
 
 #if ENABLE(CSS_VARIABLES)
 void setCSSVariablesEnabled(bool enabled) { m_cssVariablesEnabled = enabled; }
-bool cssVariablesEnabled() const { return true; }
+bool cssVariablesEnabled() const { return m_cssVariablesEnabled; }
 #else
 void setCSSVariablesEnabled(bool) { }
 bool cssVariablesEnabled() const { return false; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes