[webkit-changes] [122921] trunk/Source/WebCore

[loislo]

Title: [122921] trunk/Source/WebCore








Revision 122921
Author loi...@chromium.org
Date 2012-07-17 23:31:53 -0700 (Tue, 17 Jul 2012)


Log Message
Unreviewed Web Inspector: followup fix for r122920.

Add collected Loaders size to InspectorMemoryBlock

* inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122920 => 122921)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 05:58:49 UTC (rev 122920)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 06:31:53 UTC (rev 122921)
@@ -1,5 +1,15 @@
 2012-07-17  Ilya Tikhonovsky  loi...@chromium.org
 
+Unreviewed Web Inspector: followup fix for r122920.
+
+Add collected Loaders size to InspectorMemoryBlock
+
+* inspector/InspectorMemoryAgent.cpp:
+(MemoryBlockName):
+(WebCore):
+
+2012-07-17  Ilya Tikhonovsky  loi...@chromium.org
+
 Web Inspector: show loaders memory consumption on the memory chart.
 https://bugs.webkit.org/show_bug.cgi?id=90686
 


Modified: trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp (122920 => 122921)

--- trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp	2012-07-18 05:58:49 UTC (rev 122920)
+++ trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp	2012-07-18 06:31:53 UTC (rev 122921)
@@ -96,6 +96,7 @@
 static const char domTreeDOM[] = DOMTreeDOM;
 static const char domTreeCSS[] = DOMTreeCSS;
 static const char domTreeBinding[] = DOMTreeBinding;
+static const char domTreeLoader[] = DOMTreeLoader;
 }
 
 namespace {
@@ -483,6 +484,7 @@
 addMemoryBlockFor(domChildren.get(), m_totalSizes[DOM], MemoryBlockName::domTreeDOM);
 addMemoryBlockFor(domChildren.get(), m_totalSizes[CSS], MemoryBlockName::domTreeCSS);
 addMemoryBlockFor(domChildren.get(), m_totalSizes[Binding], MemoryBlockName::domTreeBinding);
+addMemoryBlockFor(domChildren.get(), m_totalSizes[Loader], MemoryBlockName::domTreeLoader);
 
 RefPtrInspectorMemoryBlock dom = InspectorMemoryBlock::create().setName(MemoryBlockName::dom);
 dom-setSize(totalSize);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122922] trunk/Source

[yosin]

Title: [122922] trunk/Source








Revision 122922
Author yo...@chromium.org
Date 2012-07-17 23:50:25 -0700 (Tue, 17 Jul 2012)


Log Message
Decimal constructor with 9 loses last digit
https://bugs.webkit.org/show_bug.cgi?id=91579

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes maximum coefficient value handling in Decimal::EncodedData
constructor not to lose the last digit. It was used = operator for
comparison instead of  operator.

Tests: WebKit/chromium/tests/DecimalTest.cpp

* platform/Decimal.cpp:
(WebCore::Decimal::EncodedData::EncodedData): Replace = to  for
not getting rid of the last digit for maximum coefficient value.

Source/WebKit/chromium:

This patch adds test cases for Decimal::EncodedData constructors for
testing edge cases in addition to common cases which they aren't
covered by other test cases.

* tests/DecimalTest.cpp:
(EXPECT_DECIMAL_ENCODED_DATA_EQ): Introduce a new macro for ease of
writing test cases for verifying components of Decimal::EncodedData.
(TEST_F): Added a new test entry DecimalTest.Constructor.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Decimal.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/DecimalTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122921 => 122922)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 06:31:53 UTC (rev 122921)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 06:50:25 UTC (rev 122922)
@@ -1,3 +1,20 @@
+2012-07-17  Yoshifumi Inoue  yo...@chromium.org
+
+Decimal constructor with 9 loses last digit
+https://bugs.webkit.org/show_bug.cgi?id=91579
+
+Reviewed by Kent Tamura.
+
+This patch changes maximum coefficient value handling in Decimal::EncodedData
+constructor not to lose the last digit. It was used = operator for
+comparison instead of  operator.
+
+Tests: WebKit/chromium/tests/DecimalTest.cpp
+
+* platform/Decimal.cpp:
+(WebCore::Decimal::EncodedData::EncodedData): Replace = to  for
+not getting rid of the last digit for maximum coefficient value.
+
 2012-07-17  Ilya Tikhonovsky  loi...@chromium.org
 
 Unreviewed Web Inspector: followup fix for r122920.


Modified: trunk/Source/WebCore/platform/Decimal.cpp (122921 => 122922)

--- trunk/Source/WebCore/platform/Decimal.cpp	2012-07-18 06:31:53 UTC (rev 122921)
+++ trunk/Source/WebCore/platform/Decimal.cpp	2012-07-18 06:50:25 UTC (rev 122922)
@@ -246,7 +246,7 @@
 , m_sign(sign)
 {
 if (exponent = ExponentMin  exponent = ExponentMax) {
-while (coefficient = MaxCoefficient) {
+while (coefficient  MaxCoefficient) {
 coefficient /= 10;
 ++exponent;
 }


Modified: trunk/Source/WebKit/chromium/ChangeLog (122921 => 122922)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 06:31:53 UTC (rev 122921)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 06:50:25 UTC (rev 122922)
@@ -1,5 +1,21 @@
 2012-07-17  Yoshifumi Inoue  yo...@chromium.org
 
+Decimal constructor with 9 loses last digit
+https://bugs.webkit.org/show_bug.cgi?id=91579
+
+Reviewed by Kent Tamura.
+
+This patch adds test cases for Decimal::EncodedData constructors for
+testing edge cases in addition to common cases which they aren't
+covered by other test cases.
+
+* tests/DecimalTest.cpp:
+(EXPECT_DECIMAL_ENCODED_DATA_EQ): Introduce a new macro for ease of
+writing test cases for verifying components of Decimal::EncodedData.
+(TEST_F): Added a new test entry DecimalTest.Constructor.
+
+2012-07-17  Yoshifumi Inoue  yo...@chromium.org
+
 Test cases in DecimalTest should use EXPECT_STREQ for ease of debugging test case
 https://bugs.webkit.org/show_bug.cgi?id=91572
 


Modified: trunk/Source/WebKit/chromium/tests/DecimalTest.cpp (122921 => 122922)

--- trunk/Source/WebKit/chromium/tests/DecimalTest.cpp	2012-07-18 06:31:53 UTC (rev 122921)
+++ trunk/Source/WebKit/chromium/tests/DecimalTest.cpp	2012-07-18 06:50:25 UTC (rev 122922)
@@ -112,6 +112,12 @@
 }
 };
 
+// FIXME: We should use expectedSign without Decimal::, however, g++ causes undefined references for DecimalTest::Positive and Negative.
+#define EXPECT_DECIMAL_ENCODED_DATA_EQ(expectedCoefficient, expectedExponent,  expectedSign, decimal) \
+EXPECT_EQ((expectedCoefficient), (decimal).value().coefficient()); \
+EXPECT_EQ((expectedExponent), (decimal).value().exponent()); \
+EXPECT_EQ(Decimal::expectedSign, (decimal).value().sign());
+
 #define EXPECT_DECIMAL_STREQ(expected, decimal) EXPECT_STREQ((expected), (decimal).toString().ascii().data())
 
 TEST_F(DecimalTest, Abs)
@@ -447,6 +453,28 @@
 EXPECT_TRUE(NaN = NaN);
 }
 
+TEST_F(DecimalTest, Constructor)
+{
+EXPECT_DECIMAL_ENCODED_DATA_EQ(0u, 0, Positive, encode(0, 0, Positive));
+EXPECT_DECIMAL_ENCODED_DATA_EQ(0u, 0, Negative, 

[webkit-changes] [122923] trunk/Source/WebCore

[macpherson]

Title: [122923] trunk/Source/WebCore








Revision 122923
Author macpher...@chromium.org
Date 2012-07-18 00:09:21 -0700 (Wed, 18 Jul 2012)


Log Message
Fix null pointer dereference introduced by Changeset 121874.
https://bugs.webkit.org/show_bug.cgi?id=91578

Reviewed by Pavel Feldman.

In http://trac.webkit.org/changeset/121874/trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp I introduced code that
dereferences the return value of ownerDocument() without doing a null check. This was a bad idea.

No new tests. I don't have a repro case, but it is clear from reading the code for ownerDocument() that it can return null.

* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ensureSourceData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122922 => 122923)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 06:50:25 UTC (rev 122922)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 07:09:21 UTC (rev 122923)
@@ -1,3 +1,18 @@
+2012-07-18  Luke Macpherson   macpher...@chromium.org
+
+Fix null pointer dereference introduced by Changeset 121874.
+https://bugs.webkit.org/show_bug.cgi?id=91578
+
+Reviewed by Pavel Feldman.
+
+In http://trac.webkit.org/changeset/121874/trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp I introduced code that
+dereferences the return value of ownerDocument() without doing a null check. This was a bad idea.
+
+No new tests. I don't have a repro case, but it is clear from reading the code for ownerDocument() that it can return null.
+
+* inspector/InspectorStyleSheet.cpp:
+(WebCore::InspectorStyleSheet::ensureSourceData):
+
 2012-07-17  Yoshifumi Inoue  yo...@chromium.org
 
 Decimal constructor with 9 loses last digit


Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (122922 => 122923)

--- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp	2012-07-18 06:50:25 UTC (rev 122922)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp	2012-07-18 07:09:21 UTC (rev 122923)
@@ -1116,7 +1116,8 @@
 return false;
 
 RefPtrStyleSheetContents newStyleSheet = StyleSheetContents::create();
-CSSParser p(m_pageStyleSheet-ownerDocument());
+Document* ownerDocument = m_pageStyleSheet-ownerDocument();
+CSSParser p(ownerDocument ?  CSSParserContext(ownerDocument) : strictCSSParserContext());
 OwnPtrRuleSourceDataList ruleSourceDataResult = adoptPtr(new RuleSourceDataList());
 p.parseSheet(newStyleSheet.get(), m_parsedStyleSheet-text(), 0, ruleSourceDataResult.get());
 m_parsedStyleSheet-setSourceData(ruleSourceDataResult.release());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122926] trunk/LayoutTests

[ossy]

Title: [122926] trunk/LayoutTests








Revision 122926
Author o...@webkit.org
Date 2012-07-18 01:02:19 -0700 (Wed, 18 Jul 2012)


Log Message
[Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)
https://bugs.webkit.org/show_bug.cgi?id=91063

* platform/qt-5.0-wk2/Skipped: Skip one more test.
* platform/qt/Skipped: Move a skipped test to the proper Skipped list.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt-5.0-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (122925 => 122926)

--- trunk/LayoutTests/ChangeLog	2012-07-18 07:51:41 UTC (rev 122925)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 08:02:19 UTC (rev 122926)
@@ -1,3 +1,11 @@
+2012-07-18  Csaba Osztrogonác  o...@webkit.org
+
+[Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)
+https://bugs.webkit.org/show_bug.cgi?id=91063
+
+* platform/qt-5.0-wk2/Skipped: Skip one more test.
+* platform/qt/Skipped: Move a skipped test to the proper Skipped list.
+
 2012-07-18  Kristóf Kosztyó  kkris...@inf.u-szeged.hu
 
 [Qt] Unreviewed gardening. Skip the new failing tests.


Modified: trunk/LayoutTests/platform/qt/Skipped (122925 => 122926)

--- trunk/LayoutTests/platform/qt/Skipped	2012-07-18 07:51:41 UTC (rev 122925)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-07-18 08:02:19 UTC (rev 122926)
@@ -2582,10 +2582,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=90706
 inspector/timeline/timeline-frames.html
 
-# [Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)
-# https://bugs.webkit.org/show_bug.cgi?id=91063
-compositing/columns/geometry-map-paginated-assert.html
-
 # [Qt] REGRESSION(r122768, r122771): They broke jquery/data.html and inspector/elements/edit-dom-actions.html
 # https://bugs.webkit.org/show_bug.cgi?id=91476
 inspector/elements/edit-dom-actions.html


Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (122925 => 122926)

--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-07-18 07:51:41 UTC (rev 122925)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-07-18 08:02:19 UTC (rev 122926)
@@ -398,6 +398,11 @@
 # https://bugs.webkit.org/show_bug.cgi?id=90985
 fast/repaint/background-scaling.html
 
+# [Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)
+# https://bugs.webkit.org/show_bug.cgi?id=91063
+compositing/columns/geometry-map-paginated-assert.html
+fast/multicol/shrink-to-column-height-for-pagination.html
+
 # [Qt] The test fonts used for Qt tests changed to the Liberation font family,
 # due to this we are skipping tons of tests. They will be unskipped in batches ASAP.
 # https://bugs.webkit.org/show_bug.cgi?id=85203






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122927] trunk/Source/WebKit/chromium

[hans]

Title: [122927] trunk/Source/WebKit/chromium








Revision 122927
Author h...@chromium.org
Date 2012-07-18 01:08:50 -0700 (Wed, 18 Jul 2012)


Log Message
Add copy constructor to WebSpeechGrammar.h
https://bugs.webkit.org/show_bug.cgi?id=91484

Reviewed by Adam Barth.

Provide user-defined copy constructor (and assign function) for WebSpeechGrammar.
Without this, we were hitting the implicit copy constructor, which in
turn used the implicit copy constructor of WebPrivatePtr. This was bad,
because the implicit copy constructor wouldn't increace the reference
count on the wrapped object, causing us to crash.

Also add one for WebSpeechRecognitionResult; haven't seen any problems
here, but I noticed it was missing.

* public/WebSpeechGrammar.h:
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebSpeechGrammar):
* public/WebSpeechRecognitionResult.h:
(WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult):
(WebSpeechRecognitionResult):
* src/WebSpeechGrammar.cpp:
(WebKit::WebSpeechGrammar::assign):
(WebKit):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSpeechGrammar.h
trunk/Source/WebKit/chromium/public/WebSpeechRecognitionResult.h
trunk/Source/WebKit/chromium/src/WebSpeechGrammar.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122926 => 122927)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 08:02:19 UTC (rev 122926)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 08:08:50 UTC (rev 122927)
@@ -1,3 +1,29 @@
+2012-07-18  Hans Wennborg  h...@chromium.org
+
+Add copy constructor to WebSpeechGrammar.h
+https://bugs.webkit.org/show_bug.cgi?id=91484
+
+Reviewed by Adam Barth.
+
+Provide user-defined copy constructor (and assign function) for WebSpeechGrammar.
+Without this, we were hitting the implicit copy constructor, which in
+turn used the implicit copy constructor of WebPrivatePtr. This was bad,
+because the implicit copy constructor wouldn't increace the reference
+count on the wrapped object, causing us to crash.
+
+Also add one for WebSpeechRecognitionResult; haven't seen any problems
+here, but I noticed it was missing.
+
+* public/WebSpeechGrammar.h:
+(WebKit::WebSpeechGrammar::WebSpeechGrammar):
+(WebSpeechGrammar):
+* public/WebSpeechRecognitionResult.h:
+(WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult):
+(WebSpeechRecognitionResult):
+* src/WebSpeechGrammar.cpp:
+(WebKit::WebSpeechGrammar::assign):
+(WebKit):
+
 2012-07-17  Yoshifumi Inoue  yo...@chromium.org
 
 Decimal constructor with 9 loses last digit


Modified: trunk/Source/WebKit/chromium/public/WebSpeechGrammar.h (122926 => 122927)

--- trunk/Source/WebKit/chromium/public/WebSpeechGrammar.h	2012-07-18 08:02:19 UTC (rev 122926)
+++ trunk/Source/WebKit/chromium/public/WebSpeechGrammar.h	2012-07-18 08:08:50 UTC (rev 122927)
@@ -39,12 +39,14 @@
 class WebSpeechGrammar {
 public:
 WebSpeechGrammar() { }
+WebSpeechGrammar(const WebSpeechGrammar grammar) { assign(grammar); }
 ~WebSpeechGrammar() { reset(); }
 
 WEBKIT_EXPORT WebURL src() const;
 WEBKIT_EXPORT float weight() const;
 
 WEBKIT_EXPORT void reset();
+WEBKIT_EXPORT void assign(const WebSpeechGrammar);
 
 #if WEBKIT_IMPLEMENTATION
 WebSpeechGrammar(const WTF::PassRefPtrWebCore::SpeechGrammar);


Modified: trunk/Source/WebKit/chromium/public/WebSpeechRecognitionResult.h (122926 => 122927)

--- trunk/Source/WebKit/chromium/public/WebSpeechRecognitionResult.h	2012-07-18 08:02:19 UTC (rev 122926)
+++ trunk/Source/WebKit/chromium/public/WebSpeechRecognitionResult.h	2012-07-18 08:08:50 UTC (rev 122927)
@@ -40,6 +40,7 @@
 class WebSpeechRecognitionResult {
 public:
 WebSpeechRecognitionResult() { }
+WebSpeechRecognitionResult(const WebSpeechRecognitionResult result) { assign(result); }
 ~WebSpeechRecognitionResult() { reset(); }
 
 WEBKIT_EXPORT void assign(const WebVectorWebString transcripts, const WebVectorfloat confidences, bool final);


Modified: trunk/Source/WebKit/chromium/src/WebSpeechGrammar.cpp (122926 => 122927)

--- trunk/Source/WebKit/chromium/src/WebSpeechGrammar.cpp	2012-07-18 08:02:19 UTC (rev 122926)
+++ trunk/Source/WebKit/chromium/src/WebSpeechGrammar.cpp	2012-07-18 08:08:50 UTC (rev 122927)
@@ -36,6 +36,11 @@
 m_private.reset();
 }
 
+void WebSpeechGrammar::assign(const WebSpeechGrammar other)
+{
+m_private = other.m_private;
+}
+
 WebSpeechGrammar::WebSpeechGrammar(const PassRefPtrWebCore::SpeechGrammar value)
 : m_private(value)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122928] trunk/Source

[yosin]

Title: [122928] trunk/Source








Revision 122928
Author yo...@chromium.org
Date 2012-07-18 01:09:45 -0700 (Wed, 18 Jul 2012)


Log Message
Decimal::toString should not round integer value.
https://bugs.webkit.org/show_bug.cgi?id=91481

Reviewed by Kent Tamura.

Source/WebCore:

This patch makes Decimal::toString not to round an integer value
before converting string.

Tests: WebKit/chromium/tests/DecimalTest.cpp: DecimalTest.toString

* platform/Decimal.cpp:
(WebCore::Decimal::toString): When the value is an integer, we don't
round coefficient to be DBL_DIG(15) digits because double can
represent an integer without rounding error.

Source/WebKit/chromium:

This patch adds a new test cases for Decimal::toString() for failed
value and maximum coefficient value with various exponent.

* tests/DecimalTest.cpp:
(TEST_F): DecimalTest.toString: Add test cases for big coefficient values.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Decimal.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/DecimalTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122927 => 122928)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 08:08:50 UTC (rev 122927)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 08:09:45 UTC (rev 122928)
@@ -1,3 +1,20 @@
+2012-07-18  Yoshifumi Inoue  yo...@chromium.org
+
+Decimal::toString should not round integer value.
+https://bugs.webkit.org/show_bug.cgi?id=91481
+
+Reviewed by Kent Tamura.
+
+This patch makes Decimal::toString not to round an integer value
+before converting string.
+
+Tests: WebKit/chromium/tests/DecimalTest.cpp: DecimalTest.toString
+
+* platform/Decimal.cpp:
+(WebCore::Decimal::toString): When the value is an integer, we don't
+round coefficient to be DBL_DIG(15) digits because double can
+represent an integer without rounding error.
+
 2012-07-18  Luke Macpherson   macpher...@chromium.org
 
 Fix null pointer dereference introduced by Changeset 121874.


Modified: trunk/Source/WebCore/platform/Decimal.cpp (122927 => 122928)

--- trunk/Source/WebCore/platform/Decimal.cpp	2012-07-18 08:08:50 UTC (rev 122927)
+++ trunk/Source/WebCore/platform/Decimal.cpp	2012-07-18 08:09:45 UTC (rev 122928)
@@ -967,22 +967,24 @@
 builder.append('-');
 
 int originalExponent = exponent();
-
-const int maxDigits = DBL_DIG;
 uint64_t coefficient = m_data.coefficient();
-uint64_t lastDigit = 0;
-while (countDigits(coefficient)  maxDigits) {
-lastDigit = coefficient % 10;
-coefficient /= 10;
-++originalExponent;
-}
 
-if (lastDigit = 5)
-++coefficient;
+if (originalExponent  0) {
+const int maxDigits = DBL_DIG;
+uint64_t lastDigit = 0;
+while (countDigits(coefficient)  maxDigits) {
+lastDigit = coefficient % 10;
+coefficient /= 10;
+++originalExponent;
+}
 
-while (originalExponent  0  coefficient  !(coefficient % 10)) {
-coefficient /= 10;
-++originalExponent;
+if (lastDigit = 5)
+++coefficient;
+
+while (originalExponent  0  coefficient  !(coefficient % 10)) {
+coefficient /= 10;
+++originalExponent;
+}
 }
 
 const String digits = String::number(coefficient);


Modified: trunk/Source/WebKit/chromium/ChangeLog (122927 => 122928)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 08:08:50 UTC (rev 122927)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 08:09:45 UTC (rev 122928)
@@ -1,3 +1,16 @@
+2012-07-18  Yoshifumi Inoue  yo...@chromium.org
+
+Decimal::toString should not round integer value.
+https://bugs.webkit.org/show_bug.cgi?id=91481
+
+Reviewed by Kent Tamura.
+
+This patch adds a new test cases for Decimal::toString() for failed
+value and maximum coefficient value with various exponent.
+
+* tests/DecimalTest.cpp:
+(TEST_F): DecimalTest.toString: Add test cases for big coefficient values.
+
 2012-07-18  Hans Wennborg  h...@chromium.org
 
 Add copy constructor to WebSpeechGrammar.h


Modified: trunk/Source/WebKit/chromium/tests/DecimalTest.cpp (122927 => 122928)

--- trunk/Source/WebKit/chromium/tests/DecimalTest.cpp	2012-07-18 08:08:50 UTC (rev 122927)
+++ trunk/Source/WebKit/chromium/tests/DecimalTest.cpp	2012-07-18 08:09:45 UTC (rev 122928)
@@ -1072,6 +1072,16 @@
 EXPECT_DECIMAL_STREQ(-5.678e+103, encode(5678, 100, Negative));
 EXPECT_DECIMAL_STREQ(5.678e-97, encode(5678, -100, Positive));
 EXPECT_DECIMAL_STREQ(-5.678e-97, encode(5678, -100, Negative));
+EXPECT_DECIMAL_STREQ(86391361, encode(UINT64_C(86391361), 0, Positive));
+EXPECT_DECIMAL_STREQ(9007199254740991, encode((static_castuint64_t(1)  DBL_MANT_DIG) - 1, 0, Positive));
+EXPECT_DECIMAL_STREQ(9, encode(UINT64_C(9), 

[webkit-changes] [122929] trunk/LayoutTests

[vsevik]

Title: [122929] trunk/LayoutTests








Revision 122929
Author vse...@chromium.org
Date 2012-07-18 01:14:32 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, rebaselined tests.

* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Removed.
* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Removed.
* platform/chromium-win-xp/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
* platform/chromium-win-xp/fast/inline/002-expected.png: Removed.
* platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.png:
* platform/chromium-win/fast/inline/002-expected.png:
* platform/chromium-win/fast/table/table-display-types-strict-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png
trunk/LayoutTests/platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/inline/002-expected.png
trunk/LayoutTests/platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.png
trunk/LayoutTests/platform/chromium-win/fast/table/table-display-types-strict-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.png
trunk/LayoutTests/platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/fast/inline/002-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/inline-block/inline-block-vertical-align-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (122928 => 122929)

--- trunk/LayoutTests/ChangeLog	2012-07-18 08:09:45 UTC (rev 122928)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 08:14:32 UTC (rev 122929)
@@ -1,3 +1,17 @@
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium gardening, rebaselined tests.
+
+* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Removed.
+* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Removed.
+* platform/chromium-win-xp/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
+* platform/chromium-win-xp/fast/inline/002-expected.png: Removed.
+* platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
+* platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
+* platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.png:
+* platform/chromium-win/fast/inline/002-expected.png:
+* platform/chromium-win/fast/table/table-display-types-strict-expected.png:
+
 2012-07-18  Csaba Osztrogonác  o...@webkit.org
 
 [Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)


Modified: trunk/LayoutTests/platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt (122928 => 122929)

--- trunk/LayoutTests/platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt	2012-07-18 08:09:45 UTC (rev 122928)
+++ trunk/LayoutTests/platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt	2012-07-18 08:14:32 UTC (rev 122929)
@@ -1,81 +1,81 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x321
-  RenderBlock {HTML} at (0,0) size 800x321
-RenderBody {BODY} at (8,16) size 784x290
+layer at (0,0) size 800x322
+  RenderBlock {HTML} at (0,0) size 800x322
+RenderBody {BODY} at (8,16) size 784x291
   RenderBlock {P} at (0,0) size 784x40
 RenderText {#text} at (0,0) size 768x39
   text run at (0,0) width 365: Change your window size. However the lines wrap, the blue 
   text run at (365,0) width 403: rectanglues should always have their middles on the same alignment
   text run at (0,20) width 17: as 
   text run at (17,20) width 193: other blue rectangles on the line.
-  RenderBlock {P} at (15,56) size 754x234 [color=#FF] [bgcolor=#FF] [border: (1px solid #C0C0C0)]
-RenderText {#text} at (9,35) size 60x16
-  text run at (9,35) width 60: \x{C9}\x{C9}\x{C9} 
-RenderImage {IMG} at (69,25) size 30x31
-RenderText {#text} at (99,35) size 15x16
-  text run at (99,35) width 15:  
+  RenderBlock {P} at (15,56) size 754x235 [color=#FF] [bgcolor=#FF] [border: (1px solid #C0C0C0)]
+RenderText {#text} at (9,36) size 60x16
+  text run at (9,36) width 60: \x{C9}\x{C9}\x{C9} 
+RenderImage {IMG} at (69,26) size 30x31
+RenderText {#text} at (99,36) size 15x16
+  text run at (99,36) width 15:  
 RenderInline {SPAN} at (0,0) size 

[webkit-changes] [122930] trunk

[rniwa]

Title: [122930] trunk








Revision 122930
Author rn...@webkit.org
Date 2012-07-18 01:16:31 -0700 (Wed, 18 Jul 2012)


Log Message
REGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value
https://bugs.webkit.org/show_bug.cgi?id=91587

Reviewed by Benjamin Poulain.

Source/WebCore:

The bug was caused by my douchey code that set the length cache to be the *offset*
of the last item in a HTMLCollection. Clearly, the length of a collection that contains
the last item at offset n is n + 1. Fixed that.

Also removed the call to setLengthCache in HTMLCollection::length since it must have set
by previous calls to itemBeforeOrAfterCachedItem already. This will allow us to catch
regressions like this in ports that use JSC bindings as well.

Test: fast/dom/htmlcollection-length-after-item.html

* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::itemBeforeOrAfterCachedItem):

LayoutTests:

Add a regression test. It only fails on Chromium port before the patch is applied because JSC binding code
has a bug (?) that it always checks index  length() to throw an exception before accessing an item in HTMLCollection.

* fast/dom/htmlcollection-length-after-item-expected.txt: Added.
* fast/dom/htmlcollection-length-after-item.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCollection.cpp


Added Paths

trunk/LayoutTests/fast/dom/htmlcollection-length-after-item-expected.txt
trunk/LayoutTests/fast/dom/htmlcollection-length-after-item.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122929 => 122930)

--- trunk/LayoutTests/ChangeLog	2012-07-18 08:14:32 UTC (rev 122929)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 08:16:31 UTC (rev 122930)
@@ -1,3 +1,16 @@
+2012-07-18  Ryosuke Niwa  rn...@webkit.org
+
+REGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value
+https://bugs.webkit.org/show_bug.cgi?id=91587
+
+Reviewed by Benjamin Poulain.
+
+Add a regression test. It only fails on Chromium port before the patch is applied because JSC binding code
+has a bug (?) that it always checks index  length() to throw an exception before accessing an item in HTMLCollection.
+
+* fast/dom/htmlcollection-length-after-item-expected.txt: Added.
+* fast/dom/htmlcollection-length-after-item.html: Added.
+
 2012-07-18  Vsevolod Vlasov  vse...@chromium.org
 
 Unreviewed chromium gardening, rebaselined tests.


Added: trunk/LayoutTests/fast/dom/htmlcollection-length-after-item-expected.txt (0 => 122930)

--- trunk/LayoutTests/fast/dom/htmlcollection-length-after-item-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/htmlcollection-length-after-item-expected.txt	2012-07-18 08:16:31 UTC (rev 122930)
@@ -0,0 +1,9 @@
+This tests accessing the length after accessing (length + 1)-th item in HTMLCollection doesn't cache a wrong length.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS children = container.children; children.length is 0
+PASS container.appendChild(span); children[1]; children.length is 1
+PASS container.removeChild(span); children.length is 0
+


Added: trunk/LayoutTests/fast/dom/htmlcollection-length-after-item.html (0 => 122930)

--- trunk/LayoutTests/fast/dom/htmlcollection-length-after-item.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/htmlcollection-length-after-item.html	2012-07-18 08:16:31 UTC (rev 122930)
@@ -0,0 +1,18 @@
+!DOCTYPE html
+html
+body
+script src=""
+script
+
+description(This tests accessing the length after accessing (length + 1)-th item in HTMLCollection doesn't cache a wrong length.);
+
+var container = document.createElement('div');
+var span = document.createElement('span');
+var children;
+shouldBe(children = container.children; children.length, 0);
+shouldBe(container.appendChild(span); children[1]; children.length, 1);
+shouldBe(container.removeChild(span); children.length, 0);
+
+/script
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (122929 => 122930)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 08:14:32 UTC (rev 122929)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 08:16:31 UTC (rev 122930)
@@ -1,3 +1,24 @@
+2012-07-18  Ryosuke Niwa  rn...@webkit.org
+
+REGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value
+https://bugs.webkit.org/show_bug.cgi?id=91587
+
+Reviewed by Benjamin Poulain.
+
+The bug was caused by my douchey code that set the length cache to be the *offset*
+of the last item in a HTMLCollection. Clearly, the length of a collection that contains
+the last item at offset n is n + 1. Fixed that.
+
+Also removed the call to setLengthCache in HTMLCollection::length since it must have set
+by previous calls to itemBeforeOrAfterCachedItem already. This will allow us to catch
+regressions like 

[webkit-changes] [122931] trunk/LayoutTests

[vsevik]

Title: [122931] trunk/LayoutTests








Revision 122931
Author vse...@chromium.org
Date 2012-07-18 01:19:41 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122930 => 122931)

--- trunk/LayoutTests/ChangeLog	2012-07-18 08:16:31 UTC (rev 122930)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 08:19:41 UTC (rev 122931)
@@ -1,3 +1,9 @@
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium gardening, unskipped test.
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Ryosuke Niwa  rn...@webkit.org
 
 REGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122930 => 122931)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 08:16:31 UTC (rev 122930)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 08:19:41 UTC (rev 122931)
@@ -3719,9 +3719,6 @@
 // Started crashing after 122450
 BUGWK91254 WIN LINUX DEBUG : fast/dom/attribute-empty-value-no-children.html = CRASH
 
-// Fails since creation in 122761
-BUGWK91477 : fast/multicol/shrink-to-column-height-for-pagination.html = IMAGE+TEXT
-
 // Need rebaseline
 BUGWK90951 : fast/text/shaping/shaping-selection-rect.html = MISSING
 BUGWK90951 : fast/text/shaping/shaping-script-order.html = MISSING






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122933] trunk/LayoutTests

[vsevik]

Title: [122933] trunk/LayoutTests








Revision 122933
Author vse...@chromium.org
Date 2012-07-18 01:28:17 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122932 => 122933)

--- trunk/LayoutTests/ChangeLog	2012-07-18 08:20:13 UTC (rev 122932)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 08:28:17 UTC (rev 122933)
@@ -4,6 +4,12 @@
 
 * platform/chromium/TestExpectations:
 
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium gardening, unskipped test.
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Ryosuke Niwa  rn...@webkit.org
 
 REGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122932 => 122933)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 08:20:13 UTC (rev 122932)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 08:28:17 UTC (rev 122933)
@@ -1592,12 +1592,6 @@
 // END MAC PORT TESTS
 // -
 
-// To rebaseline after Skia 4600 lands
-BUGCR137508 : svg/W3C-SVG-1.1/paths-data-12-t.svg = IMAGE+TEXT
-BUGCR137508 : svg/hixie/perf/001.xml = IMAGE+TEXT
-BUGCR137508 : svg/hixie/perf/002.xml = IMAGE+TEXT
-BUGCR137508 : svg/as-background-image/svg-as-background-5.html = IMAGE
-
 // Rebaseline to take advantage of skia ColorFilter optimization.
 // Note that two of tests below are broken on Leopard for other reasons (search
 // elsewhere within this file) and thus should not be blindly rebaselined there.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122935] trunk/LayoutTests

[vsevik]

Title: [122935] trunk/LayoutTests








Revision 122935
Author vse...@chromium.org
Date 2012-07-18 01:51:53 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122934 => 122935)

--- trunk/LayoutTests/ChangeLog	2012-07-18 08:37:32 UTC (rev 122934)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 08:51:53 UTC (rev 122935)
@@ -1,5 +1,11 @@
 2012-07-18  Vsevolod Vlasov  vse...@chromium.org
 
+Unreviewed chromium gardening, updated test expectations.
+
+* platform/chromium/TestExpectations:
+
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
 Unreviewed chromium gardening, unskipped test.
 
 * platform/chromium/TestExpectations:


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122934 => 122935)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 08:37:32 UTC (rev 122934)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 08:51:53 UTC (rev 122935)
@@ -3482,8 +3482,6 @@
 BUGWK86592 LINUX : fast/loader/unload-form-about-blank.html = TIMEOUT PASS
 BUGWK86592 LINUX : http/tests/xmlhttprequest/zero-length-response-sync.html = TIMEOUT PASS
 
-BUGWK89126 MAC : platform/chromium/compositing/accelerated-drawing/svg-filters.html = IMAGE
-
 // strange Unexpected no expected results found on cr-linux ews
 BUGWK86600 LINUX : http/tests/cache/loaded-from-cache-after-reload-within-iframe.html = MISSING PASS
 BUGWK86600 LINUX : http/tests/cache/loaded-from-cache-after-reload.html = MISSING PASS
@@ -3602,8 +3600,7 @@
 BUGCR132898 : http/tests/websocket/tests/hybi/workers/close.html = PASS TEXT
 
 // Flaky
-BUGWK89166 MAC : http/tests/messaging/cross-domain-message-event-dispatch.html = TEXT
-BUGWK89167 : media/track/track-cue-rendering-snap-to-lines-not-set.html = TEXT
+BUGWK89167 : media/track/track-cue-rendering-snap-to-lines-not-set.html = TEXT PASS
 
 // Needs Rebaseline after bug 86942
 BUGWK86942 : fast/backgrounds/size/zero.html = IMAGE+TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122936] trunk/Tools

[alexis . menard]

Title: [122936] trunk/Tools








Revision 122936
Author alexis.men...@openbossa.org
Date 2012-07-18 01:57:47 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL] Build fix in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=91567

Reviewed by Kentaro Hara.

sleep() is defined in unistd.h, we need to include it.

* WebKitTestRunner/efl/TestControllerEfl.cpp:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp




Diff

Modified: trunk/Tools/ChangeLog (122935 => 122936)

--- trunk/Tools/ChangeLog	2012-07-18 08:51:53 UTC (rev 122935)
+++ trunk/Tools/ChangeLog	2012-07-18 08:57:47 UTC (rev 122936)
@@ -1,3 +1,14 @@
+2012-07-18  Alexis Menard  alexis.men...@openbossa.org
+
+[EFL] Build fix in WebKitTestRunner.
+https://bugs.webkit.org/show_bug.cgi?id=91567
+
+Reviewed by Kentaro Hara.
+
+sleep() is defined in unistd.h, we need to include it.
+
+* WebKitTestRunner/efl/TestControllerEfl.cpp:
+
 2012-07-18  Kristóf Kosztyó  kkris...@inf.u-szeged.hu
 
 [NRWT] Unreviewed gardening after r122913


Modified: trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp (122935 => 122936)

--- trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp	2012-07-18 08:51:53 UTC (rev 122935)
+++ trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp	2012-07-18 08:57:47 UTC (rev 122936)
@@ -23,6 +23,7 @@
 #include Ecore.h
 #include stdio.h
 #include stdlib.h
+#include unistd.h
 #include wtf/Platform.h
 #include wtf/text/WTFString.h
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122937] trunk/Source/WebCore

[yosin]

Title: [122937] trunk/Source/WebCore








Revision 122937
Author yo...@chromium.org
Date 2012-07-18 02:47:28 -0700 (Wed, 18 Jul 2012)


Log Message
REGRESSION(r117738) [Forms] Default step base should be 0 (=1970-01) for input type month
https://bugs.webkit.org/show_bug.cgi?id=91603

Reviewed by Kent Tamura.

This patch restores default step base value to 0 (=1970-01) as before
r117738.

No new tests. Existing test(fast/forms/month/month-stepup-stepdown-from-renderer.html)
covers this case, although it is disabled.

* html/MonthInputType.cpp:
(WebCore::MonthInputType::createStepRange): Changed default value of
step base to defaultMonthStepBase instead of DateComponents::minimumMonth().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/MonthInputType.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122936 => 122937)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 08:57:47 UTC (rev 122936)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 09:47:28 UTC (rev 122937)
@@ -1,3 +1,20 @@
+2012-07-18  Yoshifumi Inoue  yo...@chromium.org
+
+REGRESSION(r117738) [Forms] Default step base should be 0 (=1970-01) for input type month
+https://bugs.webkit.org/show_bug.cgi?id=91603
+
+Reviewed by Kent Tamura.
+
+This patch restores default step base value to 0 (=1970-01) as before
+r117738.
+
+No new tests. Existing test(fast/forms/month/month-stepup-stepdown-from-renderer.html)
+covers this case, although it is disabled.
+
+* html/MonthInputType.cpp:
+(WebCore::MonthInputType::createStepRange): Changed default value of
+step base to defaultMonthStepBase instead of DateComponents::minimumMonth().
+
 2012-07-18  Ryuan Choi  ryuan.c...@samsung.com
 
 [EFL] Cursor is not drawn when opengl_x11 backend is choosen.


Modified: trunk/Source/WebCore/html/MonthInputType.cpp (122936 => 122937)

--- trunk/Source/WebCore/html/MonthInputType.cpp	2012-07-18 08:57:47 UTC (rev 122936)
+++ trunk/Source/WebCore/html/MonthInputType.cpp	2012-07-18 09:47:28 UTC (rev 122937)
@@ -101,7 +101,7 @@
 {
 DEFINE_STATIC_LOCAL(const StepRange::StepDescription, stepDescription, (monthDefaultStep, monthDefaultStepBase, monthStepScaleFactor, StepRange::ParsedStepValueShouldBeInteger));
 
-const Decimal stepBase = parseToNumber(element()-fastGetAttribute(minAttr), Decimal::fromDouble(DateComponents::minimumMonth()));
+const Decimal stepBase = parseToNumber(element()-fastGetAttribute(minAttr), Decimal::fromDouble(monthDefaultStepBase));
 const Decimal minimum = parseToNumber(element()-fastGetAttribute(minAttr), Decimal::fromDouble(DateComponents::minimumMonth()));
 const Decimal maximum = parseToNumber(element()-fastGetAttribute(maxAttr), Decimal::fromDouble(DateComponents::maximumMonth()));
 const Decimal step = StepRange::parseStep(anyStepHandling, stepDescription, element()-fastGetAttribute(stepAttr));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122938] trunk/LayoutTests

[vsevik]

Title: [122938] trunk/LayoutTests








Revision 122938
Author vse...@chromium.org
Date 2012-07-18 02:49:32 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122937 => 122938)

--- trunk/LayoutTests/ChangeLog	2012-07-18 09:47:28 UTC (rev 122937)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 09:49:32 UTC (rev 122938)
@@ -1,5 +1,11 @@
 2012-07-18  Vsevolod Vlasov  vse...@chromium.org
 
+Unreviewed chromium gardening, unskipped test.
+
+* platform/chromium/TestExpectations:
+
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
 Unreviewed chromium gardening, updated test expectations.
 
 * platform/chromium/TestExpectations:


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122937 => 122938)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 09:47:28 UTC (rev 122937)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 09:49:32 UTC (rev 122938)
@@ -3707,9 +3707,6 @@
 // Fails since creation in 122663
 BUGWK91372 WIN : css2.1/20110323/vertical-align-boxes-001.htm = IMAGE
 
-// Started crashing after 122450
-BUGWK91254 WIN LINUX DEBUG : fast/dom/attribute-empty-value-no-children.html = CRASH
-
 // Need rebaseline
 BUGWK90951 : fast/text/shaping/shaping-selection-rect.html = MISSING
 BUGWK90951 : fast/text/shaping/shaping-script-order.html = MISSING






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122939] trunk/LayoutTests

[vsevik]

Title: [122939] trunk/LayoutTests








Revision 122939
Author vse...@chromium.org
Date 2012-07-18 02:55:35 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122938 => 122939)

--- trunk/LayoutTests/ChangeLog	2012-07-18 09:49:32 UTC (rev 122938)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 09:55:35 UTC (rev 122939)
@@ -12,6 +12,12 @@
 
 2012-07-18  Vsevolod Vlasov  vse...@chromium.org
 
+Unreviewed chromium gardening, updated test expectations.
+
+* platform/chromium/TestExpectations:
+
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
 Unreviewed chromium gardening, unskipped test.
 
 * platform/chromium/TestExpectations:


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122938 => 122939)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 09:49:32 UTC (rev 122938)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 09:55:35 UTC (rev 122939)
@@ -3634,9 +3634,9 @@
 
 BUGWK91433 LINUX : fast/forms/placeholder-position.html = PASS IMAGE
 
-BUGWK89936 WIN : compositing/shadows/shadow-drawing.html = IMAGE
-BUGWK89936 WIN : fast/text/atsui-kerning-and-ligatures.html = IMAGE
-BUGWK89936 WIN : fast/css/text-rendering.html = IMAGE+TEXT
+BUGWK89936 XP : compositing/shadows/shadow-drawing.html = IMAGE
+BUGWK89936 XP : fast/text/atsui-kerning-and-ligatures.html = IMAGE
+BUGWK89936 XP : fast/css/text-rendering.html = IMAGE+TEXT
 
 // Started timeout between r121233:r121239.
 BUGWK90003 WIN DEBUG : fast/js/repeat-cached-vm-reentry.html = TIMEOUT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122941] trunk/Source/WebKit2

[commit-queue]

Title: [122941] trunk/Source/WebKit2








Revision 122941
Author commit-qu...@webkit.org
Date 2012-07-18 03:31:12 -0700 (Wed, 18 Jul 2012)


Log Message
[WK2][EFL] Add a common code using Color instead of QColor
https://bugs.webkit.org/show_bug.cgi?id=91580

Patch by YoungTaeck Song youngtaeck.s...@samsung.com on 2012-07-18
Reviewed by Simon Hausmann.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
drawBorder's argument is QColor. So add a common code using Color to be used by Efl.

* UIProcess/texmap/LayerBackingStore.cpp:
(WebKit::LayerBackingStore::paintToTextureMapper):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122940 => 122941)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 10:20:19 UTC (rev 122940)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 10:31:12 UTC (rev 122941)
@@ -1,3 +1,16 @@
+2012-07-18  YoungTaeck Song  youngtaeck.s...@samsung.com
+
+[WK2][EFL] Add a common code using Color instead of QColor
+https://bugs.webkit.org/show_bug.cgi?id=91580
+
+Reviewed by Simon Hausmann.
+
+This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
+drawBorder's argument is QColor. So add a common code using Color to be used by Efl.
+
+* UIProcess/texmap/LayerBackingStore.cpp:
+(WebKit::LayerBackingStore::paintToTextureMapper):
+
 2012-07-17  Christophe Dumez  christophe.du...@intel.com
 
 [EFL] Replace 0 by NULL in public headers documentation


Modified: trunk/Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp (122940 => 122941)

--- trunk/Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp	2012-07-18 10:20:19 UTC (rev 122940)
+++ trunk/Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp	2012-07-18 10:31:12 UTC (rev 122941)
@@ -141,7 +141,8 @@
 static bool shouldDebug = shouldShowTileDebugVisuals();
 if (!shouldDebug)
 continue;
-textureMapper-drawBorder(QColor(Qt::red), 2, tile-rect(), transform);
+
+textureMapper-drawBorder(Color(0xFF, 0, 0), 2, tile-rect(), transform);
 textureMapper-drawRepaintCounter(static_castLayerBackingStoreTile*(tile)-repaintCount(), 8, tilesToPaint[i]-rect().location(), transform);
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122942] trunk/Source/WebCore

[vsevik]

Title: [122942] trunk/Source/WebCore








Revision 122942
Author vse...@chromium.org
Date 2012-07-18 03:54:21 -0700 (Wed, 18 Jul 2012)


Log Message
IndexedDB: IDBLevelDBBackingStore compilation fails because of unused variable.
https://bugs.webkit.org/show_bug.cgi?id=91612

Reviewed by Pavel Feldman.

Replaced ASSERT with ASSERT_UNUSED.

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getObjectStores):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122941 => 122942)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 10:31:12 UTC (rev 122941)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 10:54:21 UTC (rev 122942)
@@ -1,3 +1,15 @@
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
+IndexedDB: IDBLevelDBBackingStore compilation fails because of unused variable.
+https://bugs.webkit.org/show_bug.cgi?id=91612
+
+Reviewed by Pavel Feldman.
+
+Replaced ASSERT with ASSERT_UNUSED.
+
+* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
+(WebCore::IDBLevelDBBackingStore::getObjectStores):
+
 2012-07-18  Yoshifumi Inoue  yo...@chromium.org
 
 REGRESSION(r117738) [Forms] Default step base should be 0 (=1970-01) for input type month


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp (122941 => 122942)

--- trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp	2012-07-18 10:31:12 UTC (rev 122941)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp	2012-07-18 10:54:21 UTC (rev 122942)
@@ -422,7 +422,7 @@
 keyGeneratorCurrentNumber = decodeInt(it-value().begin(), it-value().end());
 // FIXME: Return keyGeneratorCurrentNumber, cache in object store, and write lazily to backing store.
 // For now, just assert that if it was written it was valid.
-ASSERT(keyGeneratorCurrentNumber = KeyGeneratorInitialNumber);
+ASSERT_UNUSED(keyGeneratorCurrentNumber, keyGeneratorCurrentNumber = KeyGeneratorInitialNumber);
 it-next();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122943] trunk

[commit-queue]

Title: [122943] trunk








Revision 122943
Author commit-qu...@webkit.org
Date 2012-07-18 04:15:41 -0700 (Wed, 18 Jul 2012)


Log Message
[CMake] Make gtest a shared library
https://bugs.webkit.org/show_bug.cgi?id=90973

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-07-18
Reviewed by Daniel Bates.

.:

It's nicer to make it a shared library because it might improve
linking time and we don't need to force gtest users to link with gtest
dependencies like pthreads (which causes linking errors when it is not
available).

* Source/cmake/gtest/CMakeLists.txt:

Source/WebKit:

No need to link with gtest dependencies now since it is a shared library.

* PlatformEfl.cmake:

Source/WebKit2:

No need to link with gtest dependencies now since it is a shared library.

* PlatformEfl.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformEfl.cmake
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/cmake/gtest/CMakeLists.txt




Diff

Modified: trunk/ChangeLog (122942 => 122943)

--- trunk/ChangeLog	2012-07-18 10:54:21 UTC (rev 122942)
+++ trunk/ChangeLog	2012-07-18 11:15:41 UTC (rev 122943)
@@ -1,3 +1,17 @@
+2012-07-18  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[CMake] Make gtest a shared library
+https://bugs.webkit.org/show_bug.cgi?id=90973
+
+Reviewed by Daniel Bates.
+
+It's nicer to make it a shared library because it might improve
+linking time and we don't need to force gtest users to link with gtest
+dependencies like pthreads (which causes linking errors when it is not
+available).
+
+* Source/cmake/gtest/CMakeLists.txt:
+
 2012-07-17  Gabor Ballabas  gab...@inf.u-szeged.hu
 
 [Qt][V8] Remove the V8 related codepaths and configuration


Modified: trunk/Source/WebKit/ChangeLog (122942 => 122943)

--- trunk/Source/WebKit/ChangeLog	2012-07-18 10:54:21 UTC (rev 122942)
+++ trunk/Source/WebKit/ChangeLog	2012-07-18 11:15:41 UTC (rev 122943)
@@ -1,3 +1,14 @@
+2012-07-18  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[CMake] Make gtest a shared library
+https://bugs.webkit.org/show_bug.cgi?id=90973
+
+Reviewed by Daniel Bates.
+
+No need to link with gtest dependencies now since it is a shared library.
+
+* PlatformEfl.cmake:
+
 2012-07-17  Ryuan Choi  ryuan.c...@samsung.com
 
 [EFL] Move codes related to theme setting from Widget to RenderTheme


Modified: trunk/Source/WebKit/PlatformEfl.cmake (122942 => 122943)

--- trunk/Source/WebKit/PlatformEfl.cmake	2012-07-18 10:54:21 UTC (rev 122942)
+++ trunk/Source/WebKit/PlatformEfl.cmake	2012-07-18 11:15:41 UTC (rev 122943)
@@ -297,6 +297,7 @@
 INCLUDE_DIRECTORIES(${THIRDPARTY_DIR}/gtest/include)
 
 SET(EWKUnitTests_LIBRARIES
+${WTF_LIBRARY_NAME}
 ${_javascript_Core_LIBRARY_NAME}
 ${WebCore_LIBRARY_NAME}
 ${WebKit_LIBRARY_NAME}
@@ -304,6 +305,7 @@
 ${ECORE_EVAS_LIBRARIES}
 ${EVAS_LIBRARIES}
 ${EDJE_LIBRARIES}
+gtest
 )
 
 SET(EWKUnitTests_INCLUDE_DIRECTORIES
@@ -335,8 +337,10 @@
 
 SET(DEFAULT_TEST_PAGE_DIR ${CMAKE_SOURCE_DIR}/Source/WebKit/efl/tests/resources)
 
-ADD_DEFINITIONS(-DDEFAULT_TEST_PAGE_DIR=\${DEFAULT_TEST_PAGE_DIR}\)
-ADD_DEFINITIONS(-DDEFAULT_THEME_PATH=\${THEME_BINARY_DIR}\)
+ADD_DEFINITIONS(-DDEFAULT_TEST_PAGE_DIR=\${DEFAULT_TEST_PAGE_DIR}\
+-DDEFAULT_THEME_PATH=\${THEME_BINARY_DIR}\
+-DGTEST_LINKED_AS_SHARED_LIBRARY=1
+)
 
 ADD_LIBRARY(ewkTestUtils
 ${WEBKIT_DIR}/efl/tests/UnitTestUtils/EWKTestBase.cpp
@@ -354,7 +358,7 @@
 FOREACH (testName ${EWKUnitTests_BINARIES})
 ADD_EXECUTABLE(${testName} ${WEBKIT_EFL_TEST_DIR}/${testName}.cpp ${WEBKIT_EFL_TEST_DIR}/test_runner.cpp)
 ADD_TEST(${testName} ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/${testName})
-TARGET_LINK_LIBRARIES(${testName} ${EWKUnitTests_LIBRARIES} ewkTestUtils gtest pthread)
+TARGET_LINK_LIBRARIES(${testName} ${EWKUnitTests_LIBRARIES} ewkTestUtils)
 ADD_TARGET_PROPERTIES(${testName} LINK_FLAGS ${EWKUnitTests_LINK_FLAGS})
 SET_TARGET_PROPERTIES(${testName} PROPERTIES FOLDER WebKit)
 ENDFOREACH ()


Modified: trunk/Source/WebKit2/ChangeLog (122942 => 122943)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 10:54:21 UTC (rev 122942)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 11:15:41 UTC (rev 122943)
@@ -1,3 +1,14 @@
+2012-07-18  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[CMake] Make gtest a shared library
+https://bugs.webkit.org/show_bug.cgi?id=90973
+
+Reviewed by Daniel Bates.
+
+No need to link with gtest dependencies now since it is a shared library.
+
+* PlatformEfl.cmake:
+
 2012-07-18  YoungTaeck Song  youngtaeck.s...@samsung.com
 
 [WK2][EFL] Add a common code using Color instead of QColor


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (122942 => 122943)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2012-07-18 

[webkit-changes] [122944] trunk/Tools

[hausmann]

Title: [122944] trunk/Tools








Revision 122944
Author hausm...@webkit.org
Date 2012-07-18 04:25:54 -0700 (Wed, 18 Jul 2012)


Log Message
[Qt] plugin tests should not be disabled for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=91604

Patch by Balazs Kelemen kbal...@webkit.org on 2012-07-18
Reviewed by Simon Hausmann.

Instead of not building TestNetscapePlugIn, we could programatically
disable actually loading it from WTR until https://bugs.webkit.org/show_bug.cgi?id=86620
has been solved, so we can still test plugins on WebKit1.

* Tools.pro:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::initializeTestPluginDirectory):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Tools.pro
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp




Diff

Modified: trunk/Tools/ChangeLog (122943 => 122944)

--- trunk/Tools/ChangeLog	2012-07-18 11:15:41 UTC (rev 122943)
+++ trunk/Tools/ChangeLog	2012-07-18 11:25:54 UTC (rev 122944)
@@ -1,3 +1,20 @@
+2012-07-18  Balazs Kelemen  kbal...@webkit.org
+
+[Qt] plugin tests should not be disabled for WebKit1
+https://bugs.webkit.org/show_bug.cgi?id=91604
+
+Reviewed by Simon Hausmann.
+
+Instead of not building TestNetscapePlugIn, we could programatically
+disable actually loading it from WTR until https://bugs.webkit.org/show_bug.cgi?id=86620
+has been solved, so we can still test plugins on WebKit1.
+
+* Tools.pro:
+* WebKitTestRunner/TestController.cpp:
+(WTR::TestController::initialize):
+* WebKitTestRunner/qt/TestControllerQt.cpp:
+(WTR::TestController::initializeTestPluginDirectory):
+
 2012-07-18  Mario Sanchez Prada  msanc...@igalia.com
 
 [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK


Modified: trunk/Tools/Tools.pro (122943 => 122944)

--- trunk/Tools/Tools.pro	2012-07-18 11:15:41 UTC (rev 122943)
+++ trunk/Tools/Tools.pro	2012-07-18 11:25:54 UTC (rev 122944)
@@ -21,13 +21,8 @@
 SUBDIRS += MiniBrowser/qt/raw/MiniBrowserRaw.pro
 }
 
-# FIXME: with Qt 5 the test plugin cause some trouble during layout tests.
-# See: https://bugs.webkit.org/show_bug.cgi?id=86620
-# Reenable it after we have a fix for this issue.
-!haveQt(5) {
-!win32:contains(DEFINES, ENABLE_NETSCAPE_PLUGIN_API=1) {
-SUBDIRS += DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro
-}
+!win32:contains(DEFINES, ENABLE_NETSCAPE_PLUGIN_API=1) {
+SUBDIRS += DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro
 }
 
 OTHER_FILES = \


Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (122943 => 122944)

--- trunk/Tools/WebKitTestRunner/TestController.cpp	2012-07-18 11:15:41 UTC (rev 122943)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp	2012-07-18 11:25:54 UTC (rev 122944)
@@ -324,7 +324,8 @@
 };
 WKContextSetInjectedBundleClient(m_context.get(), injectedBundleClient);
 
-WKContextSetAdditionalPluginsDirectory(m_context.get(), testPluginDirectory());
+if (testPluginDirectory())
+WKContextSetAdditionalPluginsDirectory(m_context.get(), testPluginDirectory());
 
 m_mainWebView = adoptPtr(new PlatformWebView(m_context.get(), m_pageGroup.get()));
 


Modified: trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp (122943 => 122944)

--- trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp	2012-07-18 11:15:41 UTC (rev 122943)
+++ trunk/Tools/WebKitTestRunner/qt/TestControllerQt.cpp	2012-07-18 11:25:54 UTC (rev 122944)
@@ -104,7 +104,10 @@
 
 void TestController::initializeTestPluginDirectory()
 {
-m_testPluginDirectory = WKStringCreateWithUTF8CString(qgetenv(QTWEBKIT_PLUGIN_PATH).constData());
+// FIXME: the test plugin cause some trouble for us, so we don't load it for the time being.
+// See: https://bugs.webkit.org/show_bug.cgi?id=86620
+
+// m_testPluginDirectory = WKStringCreateWithUTF8CString(qgetenv(QTWEBKIT_PLUGIN_PATH).constData());
 }
 
 void TestController::platformInitializeContext()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122945] trunk/Source/WebKit2

[carlosgc]

Title: [122945] trunk/Source/WebKit2








Revision 122945
Author carlo...@webkit.org
Date 2012-07-18 04:30:31 -0700 (Wed, 18 Jul 2012)


Log Message
[GTK] Fix a crash due to an invalid assert
https://bugs.webkit.org/show_bug.cgi?id=91614

Reviewed by Xan Lopez.

In webkitWebViewBaseContainerAdd() there's
ASSERT(priv-inspectorView); that should be the opposite, since we
shoulnd't have an inspector view when the inspector view is added.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerAdd):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122944 => 122945)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 11:25:54 UTC (rev 122944)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 11:30:31 UTC (rev 122945)
@@ -1,3 +1,17 @@
+2012-07-18  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Fix a crash due to an invalid assert
+https://bugs.webkit.org/show_bug.cgi?id=91614
+
+Reviewed by Xan Lopez.
+
+In webkitWebViewBaseContainerAdd() there's
+ASSERT(priv-inspectorView); that should be the opposite, since we
+shoulnd't have an inspector view when the inspector view is added.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseContainerAdd):
+
 2012-07-18  Thiago Marcos P. Santos  thiago.san...@intel.com
 
 [CMake] Make gtest a shared library


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (122944 => 122945)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2012-07-18 11:25:54 UTC (rev 122944)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp	2012-07-18 11:30:31 UTC (rev 122945)
@@ -188,7 +188,7 @@
 
 if (WEBKIT_IS_WEB_VIEW_BASE(widget)
  WebInspectorProxy::isInspectorPage(WEBKIT_WEB_VIEW_BASE(widget)-priv-pageProxy.get())) {
-ASSERT(priv-inspectorView);
+ASSERT(!priv-inspectorView);
 priv-inspectorView = widget;
 priv-inspectorViewHeight = gMinimumAttachedInspectorHeight;
 } else {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122946] trunk/Source/WebCore

[commit-queue]

Title: [122946] trunk/Source/WebCore








Revision 122946
Author commit-qu...@webkit.org
Date 2012-07-18 04:30:37 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL][WK2] Too early assertion failure if default theme is not available
https://bugs.webkit.org/show_bug.cgi?id=91608

Patch by Dominik Röttsches dominik.rottsc...@intel.com on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

After bug 90107 we're setting a default theme path, which leads to a
themeChanged() call initializing edje in createEdje() - if that theme
path is not available we run into a premature assertion failure.
We need to give the embedder a chance to override the default theme path
before failing - so only the usages of m_edje should be guarded with assertions.

No new tests, no change in rendering behavior.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntryReset): Adding an assertion to ensure m_edje is present - so that all usages of m_edje are now guarded.
(WebCore::RenderThemeEfl::createEdje): Not hitting assertion if theme path doesn't contain the theme object file, allowing the embedder to override with a new path.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122945 => 122946)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 11:30:31 UTC (rev 122945)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 11:30:37 UTC (rev 122946)
@@ -1,3 +1,22 @@
+2012-07-18  Dominik Röttsches  dominik.rottsc...@intel.com
+
+[EFL][WK2] Too early assertion failure if default theme is not available
+https://bugs.webkit.org/show_bug.cgi?id=91608
+
+Reviewed by Kenneth Rohde Christiansen.
+
+After bug 90107 we're setting a default theme path, which leads to a
+themeChanged() call initializing edje in createEdje() - if that theme
+path is not available we run into a premature assertion failure.
+We need to give the embedder a chance to override the default theme path
+before failing - so only the usages of m_edje should be guarded with assertions.
+
+No new tests, no change in rendering behavior.
+
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::themePartCacheEntryReset): Adding an assertion to ensure m_edje is present - so that all usages of m_edje are now guarded.
+(WebCore::RenderThemeEfl::createEdje): Not hitting assertion if theme path doesn't contain the theme object file, allowing the embedder to override with a new path.
+
 2012-07-18  Vsevolod Vlasov  vse...@chromium.org
 
 IndexedDB: IDBLevelDBBackingStore compilation fails because of unused variable.


Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (122945 => 122946)

--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2012-07-18 11:30:31 UTC (rev 122945)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2012-07-18 11:30:37 UTC (rev 122946)
@@ -100,6 +100,7 @@
 const char *file, *group;
 
 ASSERT(entry);
+ASSERT(m_edje);
 
 edje_object_file_get(m_edje, file, 0);
 group = edjeGroupFromFormType(type);
@@ -464,7 +465,6 @@
 #undef CONNECT
 }
 }
-ASSERT(m_edje);
 }
 
 void RenderThemeEfl::applyEdjeColors()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122947] trunk

[hausmann]

Title: [122947] trunk








Revision 122947
Author hausm...@webkit.org
Date 2012-07-18 04:41:33 -0700 (Wed, 18 Jul 2012)


Log Message
[ANGLE] On QT, use Bison and Flex during ANGLE build
https://bugs.webkit.org/show_bug.cgi?id=91108

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add derived source generators for the two angle bison parsers and flex based lexers.

* DerivedSources.pri:
* Target.pri:

Tools:

* qmake/mkspecs/features/default_post.prf: Add support for variable_out to our generators, to allow
generating not only for SOURCES but also ANGLE_SOURCES (in this bug)

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.pri
trunk/Source/WebCore/Target.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf




Diff

Modified: trunk/Source/WebCore/ChangeLog (122946 => 122947)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 11:30:37 UTC (rev 122946)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 11:41:33 UTC (rev 122947)
@@ -1,3 +1,15 @@
+2012-07-18  Simon Hausmann  simon.hausm...@nokia.com
+
+[ANGLE] On QT, use Bison and Flex during ANGLE build
+https://bugs.webkit.org/show_bug.cgi?id=91108
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add derived source generators for the two angle bison parsers and flex based lexers.
+
+* DerivedSources.pri:
+* Target.pri:
+
 2012-07-18  Dominik Röttsches  dominik.rottsc...@intel.com
 
 [EFL][WK2] Too early assertion failure if default theme is not available


Modified: trunk/Source/WebCore/DerivedSources.pri (122946 => 122947)

--- trunk/Source/WebCore/DerivedSources.pri	2012-07-18 11:30:37 UTC (rev 122946)
+++ trunk/Source/WebCore/DerivedSources.pri	2012-07-18 11:41:33 UTC (rev 122947)
@@ -901,3 +901,36 @@
 webkitversion.clean = ${QMAKE_FUNC_FILE_OUT_PATH}/WebKitVersion.h
 webkitversion.add_output_to_sources = false
 GENERATORS += webkitversion
+
+# Generator 12: Angle parsers
+contains(DEFINES, WTF_USE_3D_GRAPHICS=1) {
+
+ANGLE_DIR = $$replace(PWD, WebCore, ThirdParty/ANGLE)
+
+ANGLE_FLEX_SOURCES = \
+$$ANGLE_DIR/src/compiler/glslang.l \
+$$ANGLE_DIR/src/compiler/preprocessor/new/Tokenizer.l
+
+angleflex.output = ${QMAKE_FILE_BASE}_lex.cpp
+angleflex.input = ANGLE_FLEX_SOURCES
+angleflex.commands = flex --noline --nounistd --outfile=${QMAKE_FILE_OUT} ${QMAKE_FILE_IN}
+*g++*: angleflex.variable_out = ANGLE_SOURCES
+GENERATORS += angleflex
+
+ANGLE_BISON_SOURCES = \
+$$ANGLE_DIR/src/compiler/glslang.y \
+$$ANGLE_DIR/src/compiler/preprocessor/new/ExpressionParser.y
+
+anglebison_decl.output = ${QMAKE_FILE_BASE}_tab.h
+anglebison_decl.input = ANGLE_BISON_SOURCES
+anglebison_decl.commands = bison --no-lines --skeleton=yacc.c --defines=${QMAKE_FILE_OUT} --output=${QMAKE_FUNC_FILE_OUT_PATH}$${QMAKE_DIR_SEP}${QMAKE_FILE_OUT_BASE}.cpp ${QMAKE_FILE_IN}
+anglebison_decl.variable_out = GENERATED_FILES
+GENERATORS += anglebison_decl
+
+anglebison_impl.input = ANGLE_BISON_SOURCES
+anglebison_impl.commands = $$escape_expand(\\n)
+anglebison_impl.depends = ${QMAKE_FILE_BASE}_tab.h
+anglebison_impl.output = ${QMAKE_FILE_BASE}_tab.cpp
+*g++*: anglebison_impl.variable_out = ANGLE_SOURCES
+GENERATORS += anglebison_impl
+}


Modified: trunk/Source/WebCore/Target.pri (122946 => 122947)

--- trunk/Source/WebCore/Target.pri	2012-07-18 11:30:37 UTC (rev 122946)
+++ trunk/Source/WebCore/Target.pri	2012-07-18 11:41:33 UTC (rev 122947)
@@ -3716,7 +3716,10 @@
 
 ANGLE_DIR = $$replace(PWD, WebCore, ThirdParty/ANGLE)
 
-INCLUDEPATH += $$ANGLE_DIR/src $$ANGLE_DIR/include
+INCLUDEPATH += \
+$$ANGLE_DIR/src \
+$$ANGLE_DIR/src/compiler/preprocessor/new \
+$$ANGLE_DIR/include
 
 ANGLE_HEADERS += \
 $$ANGLE_DIR/src/compiler/BaseTypes.h \
@@ -3734,7 +3737,6 @@
 $$ANGLE_DIR/src/compiler/ExtensionBehavior.h \
 $$ANGLE_DIR/src/compiler/ForLoopUnroll.h \
 $$ANGLE_DIR/src/compiler/glslang.h \
-$$ANGLE_DIR/src/compiler/glslang_tab.h \
 $$ANGLE_DIR/src/compiler/InfoSink.h \
 $$ANGLE_DIR/src/compiler/InitializeDll.h \
 $$ANGLE_DIR/src/compiler/InitializeGlobals.h \
@@ -3754,7 +3756,6 @@
 $$ANGLE_DIR/src/compiler/preprocessor/new/Diagnostics.h \
 $$ANGLE_DIR/src/compiler/preprocessor/new/DirectiveHandler.h \
 $$ANGLE_DIR/src/compiler/preprocessor/new/DirectiveParser.h \
-$$ANGLE_DIR/src/compiler/preprocessor/new/ExpressionParser.h \
 $$ANGLE_DIR/src/compiler/preprocessor/new/Input.h \
 $$ANGLE_DIR/src/compiler/preprocessor/new/Lexer.h \
 $$ANGLE_DIR/src/compiler/preprocessor/new/Macro.h \
@@ -3809,8 +3810,6 @@
 $$ANGLE_DIR/src/compiler/Diagnostics.cpp \
 $$ANGLE_DIR/src/compiler/DirectiveHandler.cpp \
 $$ANGLE_DIR/src/compiler/ForLoopUnroll.cpp \
-$$ANGLE_DIR/src/compiler/glslang_lex.cpp \
- 

[webkit-changes] [122948] trunk/Source/WebKit2

[zeno . albisser]

Title: [122948] trunk/Source/WebKit2








Revision 122948
Author zeno.albis...@nokia.com
Date 2012-07-18 04:53:47 -0700 (Wed, 18 Jul 2012)


Log Message
[Qt][WK2] Caching of ShareableSurfaces breaks tiling.
https://bugs.webkit.org/show_bug.cgi?id=91609

A ShareableSurface should only be cached,
when it is GraphicsSurface based.

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
* UIProcess/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.cpp
trunk/Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122947 => 122948)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 11:41:33 UTC (rev 122947)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 11:53:47 UTC (rev 122948)
@@ -1,3 +1,18 @@
+2012-07-18  Zeno Albisser  z...@webkit.org
+
+[Qt][WK2] Caching of ShareableSurfaces breaks tiling.
+https://bugs.webkit.org/show_bug.cgi?id=91609
+
+A ShareableSurface should only be cached,
+when it is GraphicsSurface based.
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* UIProcess/LayerTreeCoordinatorProxy.cpp:
+(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
+* UIProcess/LayerTreeCoordinatorProxy.h:
+(LayerTreeCoordinatorProxy):
+
 2012-07-18  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Fix a crash due to an invalid assert


Modified: trunk/Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.cpp (122947 => 122948)

--- trunk/Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.cpp	2012-07-18 11:41:33 UTC (rev 122947)
+++ trunk/Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.cpp	2012-07-18 11:53:47 UTC (rev 122948)
@@ -61,26 +61,20 @@
 updateTileForLayer(layerID, tileID, targetRect, updateInfo);
 }
 
-static inline uint64_t createLayerTileUniqueKey(int layerID, int tileID)
-{
-uint64_t key = layerID;
-key = 32;
-key |= tileID;
-return key;
-}
-
 void LayerTreeCoordinatorProxy::updateTileForLayer(int layerID, int tileID, const IntRect targetRect, const WebKit::SurfaceUpdateInfo updateInfo)
 {
 RefPtrShareableSurface surface;
 #if USE(GRAPHICS_SURFACE)
-uint64_t key = createLayerTileUniqueKey(layerID, tileID);
-
-HashMapuint64_t, RefPtrShareableSurface ::iterator it = m_surfaces.find(key);
-if (it == m_surfaces.end()) {
-surface = ShareableSurface::create(updateInfo.surfaceHandle);
-m_surfaces.add(key, surface);
+int token = updateInfo.surfaceHandle.graphicsSurfaceToken();
+if (token) {
+HashMapuint32_t, RefPtrShareableSurface ::iterator it = m_surfaces.find(token);
+if (it == m_surfaces.end()) {
+surface = ShareableSurface::create(updateInfo.surfaceHandle);
+m_surfaces.add(token, surface);
+} else
+surface = it-second;
 } else
-surface = it-second;
+surface = ShareableSurface::create(updateInfo.surfaceHandle);
 #else
 surface = ShareableSurface::create(updateInfo.surfaceHandle);
 #endif


Modified: trunk/Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.h (122947 => 122948)

--- trunk/Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.h	2012-07-18 11:41:33 UTC (rev 122947)
+++ trunk/Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.h	2012-07-18 11:53:47 UTC (rev 122948)
@@ -79,7 +79,7 @@
 DrawingAreaProxy* m_drawingAreaProxy;
 RefPtrWebLayerTreeRenderer m_renderer;
 #if USE(GRAPHICS_SURFACE)
-HashMapuint64_t, RefPtrShareableSurface  m_surfaces;
+HashMapuint32_t, RefPtrShareableSurface  m_surfaces;
 #endif
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122949] trunk/LayoutTests

[vsevik]

Title: [122949] trunk/LayoutTests








Revision 122949
Author vse...@chromium.org
Date 2012-07-18 05:16:05 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, unskipped tests.
https://bugs.webkit.org/show_bug.cgi?id=84764
https://bugs.webkit.org/show_bug.cgi?id=84767
https://bugs.webkit.org/show_bug.cgi?id=84768
https://bugs.webkit.org/show_bug.cgi?id=84769
https://bugs.webkit.org/show_bug.cgi?id=84775
https://bugs.webkit.org/show_bug.cgi?id=84776

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122948 => 122949)

--- trunk/LayoutTests/ChangeLog	2012-07-18 11:53:47 UTC (rev 122948)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 12:16:05 UTC (rev 122949)
@@ -1,3 +1,15 @@
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium gardening, unskipped tests.
+https://bugs.webkit.org/show_bug.cgi?id=84764
+https://bugs.webkit.org/show_bug.cgi?id=84767
+https://bugs.webkit.org/show_bug.cgi?id=84768
+https://bugs.webkit.org/show_bug.cgi?id=84769
+https://bugs.webkit.org/show_bug.cgi?id=84775
+https://bugs.webkit.org/show_bug.cgi?id=84776
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Mario Sanchez Prada  msanc...@igalia.com
 
 [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122948 => 122949)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 11:53:47 UTC (rev 122948)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 12:16:05 UTC (rev 122949)
@@ -3353,16 +3353,10 @@
 BUGWK84759 : ietestcenter/css3/multicolumn/column-containing-block-001.htm = IMAGE
 BUGWK84760 : ietestcenter/css3/multicolumn/column-containing-block-002.htm = IMAGE
 BUGWK84761 : ietestcenter/css3/multicolumn/column-filling-001.htm = IMAGE
-BUGWK84764 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-001.htm = IMAGE
-BUGWK84767 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-002.htm = IMAGE
-BUGWK84768 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-003.htm = IMAGE
-BUGWK84769 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-004.htm = IMAGE
 BUGWK84770 : ietestcenter/css3/multicolumn/column-width-applies-to-007.htm = IMAGE
 BUGWK84771 : ietestcenter/css3/multicolumn/column-width-applies-to-009.htm = IMAGE
 BUGWK84772 : ietestcenter/css3/multicolumn/column-width-applies-to-010.htm = IMAGE
 BUGWK84773 : ietestcenter/css3/multicolumn/column-width-applies-to-012.htm = IMAGE
-BUGWK84775 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-013.htm = IMAGE
-BUGWK84776 MAC : ietestcenter/css3/multicolumn/column-width-applies-to-014.htm = IMAGE
 BUGWK84777 : ietestcenter/css3/multicolumn/column-width-applies-to-015.htm = IMAGE
 BUGWK84778 : ietestcenter/css3/multicolumn/column-width-negative-001.htm = IMAGE
 // IETC flexbox failures






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122950] trunk/Source/WebCore

[caseq]

Title: [122950] trunk/Source/WebCore








Revision 122950
Author ca...@chromium.org
Date 2012-07-18 05:38:44 -0700 (Wed, 18 Jul 2012)


Log Message
Web Inspector: create timeline detail records lazily
https://bugs.webkit.org/show_bug.cgi?id=91513

Reviewed by Pavel Feldman.

- only create timeline record details when these are used;

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineRecordListRow.prototype.update):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype.details):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (122949 => 122950)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 12:16:05 UTC (rev 122949)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 12:38:44 UTC (rev 122950)
@@ -1,3 +1,19 @@
+2012-07-18  Andrey Kosyakov  ca...@chromium.org
+
+Web Inspector: create timeline detail records lazily
+https://bugs.webkit.org/show_bug.cgi?id=91513
+
+Reviewed by Pavel Feldman.
+
+- only create timeline record details when these are used;
+
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelineRecordListRow.prototype.update):
+* inspector/front-end/TimelinePresentationModel.js:
+(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
+(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
+(WebInspector.TimelinePresentationModel.Record.prototype.details):
+
 2012-07-18  Simon Hausmann  simon.hausm...@nokia.com
 
 [ANGLE] On QT, use Bison and Flex during ANGLE build


Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (122949 => 122950)

--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js	2012-07-18 12:16:05 UTC (rev 122949)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js	2012-07-18 12:38:44 UTC (rev 122950)
@@ -1048,14 +1048,15 @@
 
 if (this._dataElement.firstChild)
 this._dataElement.removeChildren();
-if (record.details) {
+var details = record.details();
+if (details) {
 var detailsContainer = document.createElement(span);
-if (typeof record.details === object) {
+if (typeof details === object) {
 detailsContainer.appendChild(document.createTextNode(());
-detailsContainer.appendChild(record.details);
+detailsContainer.appendChild(details);
 detailsContainer.appendChild(document.createTextNode()));
 } else
-detailsContainer.textContent = ( + record.details + );
+detailsContainer.textContent = ( + details + );
 this._dataElement.appendChild(detailsContainer);
 }
 },


Modified: trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js (122949 => 122950)

--- trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js	2012-07-18 12:16:05 UTC (rev 122949)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js	2012-07-18 12:38:44 UTC (rev 122950)
@@ -605,8 +605,8 @@
 contentHelper._appendTextRow(WebInspector.UIString(Interval Duration), Number.secondsToString(this.intervalDuration, true));
 break;
 default:
-if (this.details)
-contentHelper._appendTextRow(WebInspector.UIString(Details), this.details);
+if (this.details())
+contentHelper._appendTextRow(WebInspector.UIString(Details), this.details());
 break;
 }
 
@@ -627,9 +627,19 @@
 
 _refreshDetails: function()
 {
-this.details = this._getRecordDetails();
+delete this._details;
 },
 
+/**
+ * @return {Object?|string}
+ */
+details: function()
+{
+if (!this._details)
+this._details = this._getRecordDetails();
+return this._details;
+},
+
 _getRecordDetails: function()
 {
 switch (this.type) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122951] trunk/LayoutTests

[vsevik]

Title: [122951] trunk/LayoutTests








Revision 122951
Author vse...@chromium.org
Date 2012-07-18 05:43:45 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, unskipped tests.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122950 => 122951)

--- trunk/LayoutTests/ChangeLog	2012-07-18 12:38:44 UTC (rev 122950)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 12:43:45 UTC (rev 122951)
@@ -1,6 +1,12 @@
 2012-07-18  Vsevolod Vlasov  vse...@chromium.org
 
 Unreviewed chromium gardening, unskipped tests.
+
+* platform/chromium/TestExpectations:
+
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium gardening, unskipped tests.
 https://bugs.webkit.org/show_bug.cgi?id=84764
 https://bugs.webkit.org/show_bug.cgi?id=84767
 https://bugs.webkit.org/show_bug.cgi?id=84768


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122950 => 122951)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 12:38:44 UTC (rev 122950)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 12:43:45 UTC (rev 122951)
@@ -1529,7 +1529,7 @@
 BUGCR23473 MAC : fast/repaint/content-into-overflow.html = IMAGE
 BUGCR23473 LION SNOWLEOPARD : fast/repaint/control-clip.html = IMAGE
 BUGCR23473 MAC : fast/repaint/create-layer-repaint.html = IMAGE
-BUGCR23473 LION SNOWLEOPARD : fast/repaint/delete-into-nested-block.html = IMAGE
+BUGCR23473 LION : fast/repaint/delete-into-nested-block.html = IMAGE
 BUGCR23473 MAC : fast/repaint/dynamic-table-vertical-alignment-change.html = IMAGE
 BUGCR23473 MAC : fast/repaint/erase-overflow.html = IMAGE
 BUGCR23473 MAC : fast/repaint/fixed-child-move-after-scroll.html = IMAGE
@@ -3531,7 +3531,7 @@
 BUGWK87652 SKIP : http/tests/appcache/load-from-appcache-defer-resume-crash.html = PASS
 
 // A few pixels off from the baseline, added by r118567.
-BUGWK87653 : compositing/geometry/composited-in-columns.html = IMAGE+TEXT
+BUGWK87653 WIN LINUX : compositing/geometry/composited-in-columns.html = IMAGE+TEXT
 
 // Needs Rebaseline.
 BUGWK88705 : fast/css/text-overflow-ellipsis-text-align-center.html = MISSING
@@ -3597,7 +3597,7 @@
 BUGWK89167 : media/track/track-cue-rendering-snap-to-lines-not-set.html = TEXT PASS
 
 // Needs Rebaseline after bug 86942
-BUGWK86942 : fast/backgrounds/size/zero.html = IMAGE+TEXT
+BUGWK86942 WIN LINUX : fast/backgrounds/size/zero.html = IMAGE+TEXT
 
 // Timing out on some Windows bots
 BUGWK89510 WIN : gamepad/gamepad-polling-access.html = PASS TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122952] trunk

[commit-queue]

Title: [122952] trunk








Revision 122952
Author commit-qu...@webkit.org
Date 2012-07-18 05:50:15 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=87935

Patch by Seokju Kwon seokju.k...@samsung.com on 2012-07-18
Reviewed by Andreas Kling.

Source/WebKit/efl:

Add implementation of DumpRenderTreeSupportEfl::evaluateInWebInspector().
Some scripts for test should be evaluated in frontend.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Web Inspector will be shown when path or url contains inspector/.
Dumprendertree should wait util web inspector resources are loaded totally
and handle the signals for creating or removing a view of web inspector.
(inspector,view,create and inspector,view,close)

* DumpRenderTree/efl/DumpRenderTree.cpp:
(shouldOpenWebInspector):
(createLayoutTestController):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::createWebInspectorView):
(DumpRenderTreeChrome::removeWebInspectorView):
(DumpRenderTreeChrome::waitInspectorLoadFinished):
(DumpRenderTreeChrome::onInspectorViewCreate):
(DumpRenderTreeChrome::onInspectorViewClose):
(DumpRenderTreeChrome::onInspectorFrameLoadFinished):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onConsoleMessage):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::showWebInspector):
(LayoutTestController::closeWebInspector):
(LayoutTestController::evaluateInWebInspector):

LayoutTests:

Remove the following tests from Skipped list.
LayoutTests/inspector
LayoutTests/http/test/inspector
LayoutTests/http/test/inspector-enabled
LayoutTests/http/tests/inspector/network/ping.html

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.h
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp
trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (122951 => 122952)

--- trunk/LayoutTests/ChangeLog	2012-07-18 12:43:45 UTC (rev 122951)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 12:50:15 UTC (rev 122952)
@@ -1,3 +1,18 @@
+2012-07-18  Seokju Kwon  seokju.k...@samsung.com
+
+[EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
+https://bugs.webkit.org/show_bug.cgi?id=87935
+
+Reviewed by Andreas Kling.
+
+Remove the following tests from Skipped list.
+LayoutTests/inspector
+LayoutTests/http/test/inspector
+LayoutTests/http/test/inspector-enabled
+LayoutTests/http/tests/inspector/network/ping.html
+
+* platform/efl/Skipped:
+
 2012-07-18  Vsevolod Vlasov  vse...@chromium.org
 
 Unreviewed chromium gardening, unskipped tests.


Modified: trunk/LayoutTests/platform/efl/Skipped (122951 => 122952)

--- trunk/LayoutTests/platform/efl/Skipped	2012-07-18 12:43:45 UTC (rev 122951)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-07-18 12:50:15 UTC (rev 122952)
@@ -234,11 +234,6 @@
 # The EFL port has no support for accessibility features
 accessibility
 
-# The EFL port has no support for the web inspector
-inspector
-http/tests/inspector
-http/tests/inspector-enabled
-
 # The EFL port has no support for device motion and orientation
 fast/dom/DeviceMotion
 fast/dom/DeviceOrientation
@@ -541,7 +536,6 @@
 fast/history/back-forward-reset-after-error-handling.html
 fast/repaint/no-caret-repaint-in-non-content-editable-element.html
 http/tests/canvas/webgl/origin-clean-conformance.html
-http/tests/inspector/network/ping.html
 http/tests/navigation/go-back-to-error-page.html
 loader/go-back-to-different-window-size.html
 userscripts/user-script-plugin-document.html


Modified: trunk/Source/WebKit/efl/ChangeLog (122951 => 122952)

--- trunk/Source/WebKit/efl/ChangeLog	2012-07-18 12:43:45 UTC (rev 122951)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-07-18 12:50:15 UTC (rev 122952)
@@ -1,3 +1,17 @@
+2012-07-18  Seokju Kwon  seokju.k...@samsung.com
+
+[EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
+https://bugs.webkit.org/show_bug.cgi?id=87935
+
+Reviewed by Andreas Kling.
+
+Add implementation of DumpRenderTreeSupportEfl::evaluateInWebInspector().
+Some scripts for test should be evaluated in frontend.
+
+* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+(DumpRenderTreeSupportEfl::evaluateInWebInspector):
+* 

[webkit-changes] [122953] trunk/Source

[zoltan]

Title: [122953] trunk/Source








Revision 122953
Author zol...@webkit.org
Date 2012-07-18 05:50:36 -0700 (Wed, 18 Jul 2012)


Log Message
[Qt] Modify the using of the QImage::Format enum to the appropriate functions from NativeImageQt
https://bugs.webkit.org/show_bug.cgi?id=91600

Reviewed by Andreas Kling.

Use NativeImageQt::defaultFormatForAlphaEnabledImages() and NativeImageQt::defaultFormatForOpaqueImages()
instead of the direct imagetypes at the appropriate places.

Source/WebCore:

Covered by existing tests.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):
* platform/graphics/qt/PathQt.cpp:
(WebCore::scratchContext):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawRepaintCounter):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::updateContents):

Source/WebKit2:

* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createQImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp
trunk/Source/WebCore/platform/graphics/qt/PathQt.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/qt/ShareableBitmapQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122952 => 122953)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 12:50:15 UTC (rev 122952)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 12:50:36 UTC (rev 122953)
@@ -1,3 +1,24 @@
+2012-07-18  Zoltan Horvath  zol...@webkit.org
+
+[Qt] Modify the using of the QImage::Format enum to the appropriate functions from NativeImageQt
+https://bugs.webkit.org/show_bug.cgi?id=91600
+
+Reviewed by Andreas Kling.
+
+Use NativeImageQt::defaultFormatForAlphaEnabledImages() and NativeImageQt::defaultFormatForOpaqueImages()
+instead of the direct imagetypes at the appropriate places.
+
+Covered by existing tests.
+
+* platform/graphics/qt/GraphicsContext3DQt.cpp:
+(WebCore::GraphicsContext3D::paintToCanvas):
+* platform/graphics/qt/PathQt.cpp:
+(WebCore::scratchContext):
+* platform/graphics/texmap/TextureMapperGL.cpp:
+(WebCore::TextureMapperGL::drawRepaintCounter):
+* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
+(WebCore::BitmapTextureImageBuffer::updateContents):
+
 2012-07-18  Andrey Kosyakov  ca...@chromium.org
 
 Web Inspector: create timeline detail records lazily


Modified: trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp (122952 => 122953)

--- trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp	2012-07-18 12:50:15 UTC (rev 122952)
+++ trunk/Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp	2012-07-18 12:50:36 UTC (rev 122953)
@@ -29,6 +29,7 @@
 #include HostWindow.h
 #include ImageBuffer.h
 #include ImageData.h
+#include NativeImageQt.h
 #include NotImplemented.h
 #include OpenGLShims.h
 #include QWebPageClient.h
@@ -468,7 +469,7 @@
 void GraphicsContext3D::paintToCanvas(const unsigned char* imagePixels, int imageWidth, int imageHeight,
   int canvasWidth, int canvasHeight, QPainter* context)
 {
-QImage image(imagePixels, imageWidth, imageHeight, QImage::Format_ARGB32_Premultiplied);
+QImage image(imagePixels, imageWidth, imageHeight, NativeImageQt::defaultFormatForAlphaEnabledImages());
 context-save();
 context-translate(0, imageHeight);
 context-scale(1, -1);


Modified: trunk/Source/WebCore/platform/graphics/qt/PathQt.cpp (122952 => 122953)

--- trunk/Source/WebCore/platform/graphics/qt/PathQt.cpp	2012-07-18 12:50:15 UTC (rev 122952)
+++ trunk/Source/WebCore/platform/graphics/qt/PathQt.cpp	2012-07-18 12:50:36 UTC (rev 122953)
@@ -35,6 +35,7 @@
 #include FloatRect.h
 #include GraphicsContext.h
 #include ImageBuffer.h
+#include NativeImageQt.h
 #include PlatformString.h
 #include StrokeStyleApplier.h
 #include QPainterPath
@@ -118,7 +119,7 @@
 
 static GraphicsContext* scratchContext()
 {
-static QImage image(1, 1, QImage::Format_ARGB32_Premultiplied);
+static QImage image(1, 1, NativeImageQt::defaultFormatForAlphaEnabledImages());
 static QPainter painter(image);
 static GraphicsContext* context = new GraphicsContext(painter);
 return context;


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (122952 => 122953)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2012-07-18 12:50:15 UTC (rev 122952)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp	2012-07-18 12:50:36 UTC (rev 122953)
@@ -38,6 +38,7 @@
 #endif
 
 #if PLATFORM(QT)
+#include NativeImageQt.h
 #if HAVE(QT5)
 #include QOpenGLContext
 #else
@@ -377,7 +378,7 @@
 IntRect sourceRect(IntPoint::zero(), size);
 IntRect 

[webkit-changes] [122954] trunk/LayoutTests

[vsevik]

Title: [122954] trunk/LayoutTests








Revision 122954
Author vse...@chromium.org
Date 2012-07-18 05:53:02 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122953 => 122954)

--- trunk/LayoutTests/ChangeLog	2012-07-18 12:50:36 UTC (rev 122953)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 12:53:02 UTC (rev 122954)
@@ -1,3 +1,9 @@
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium gardening, updated test expectations.
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Seokju Kwon  seokju.k...@samsung.com
 
 [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122953 => 122954)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 12:50:36 UTC (rev 122953)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 12:53:02 UTC (rev 122954)
@@ -3714,4 +3714,7 @@
 // Started failing around r122770
 BUGWK91445 LINUX : plugins/embed-attributes-style.html = PASS IMAGE
 
+// Fails since creation in r122130
+BUGWK91620 : css3/filters/blur-filter-page-scroll-self.html = PASS IMAGE
+
 BUGWK91544 : media/media-continues-playing-after-replace-source.html = PASS TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122956] trunk/Tools

[commit-queue]

Title: [122956] trunk/Tools








Revision 122956
Author commit-qu...@webkit.org
Date 2012-07-18 05:59:23 -0700 (Wed, 18 Jul 2012)


Log Message
[CMake][EFL] Building jsc causes reconfiguration
https://bugs.webkit.org/show_bug.cgi?id=91387

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-07-18
Reviewed by Daniel Bates.

We should remove CMakeCache only when running build-webkit script,
otherwise it will cause a reconfiguration every time someone calls
generateBuildSystemFromCMakeProject(). We were re-building jsc and
not running WebKit2 unit tests on the bots because the project was
reconfigured with default values by the scripts that run these tests.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(removeCMakeCache):
(generateBuildSystemFromCMakeProject):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (122955 => 122956)

--- trunk/Tools/ChangeLog	2012-07-18 12:59:21 UTC (rev 122955)
+++ trunk/Tools/ChangeLog	2012-07-18 12:59:23 UTC (rev 122956)
@@ -1,3 +1,21 @@
+2012-07-18  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[CMake][EFL] Building jsc causes reconfiguration
+https://bugs.webkit.org/show_bug.cgi?id=91387
+
+Reviewed by Daniel Bates.
+
+We should remove CMakeCache only when running build-webkit script,
+otherwise it will cause a reconfiguration every time someone calls
+generateBuildSystemFromCMakeProject(). We were re-building jsc and
+not running WebKit2 unit tests on the bots because the project was
+reconfigured with default values by the scripts that run these tests.
+
+* Scripts/build-webkit:
+* Scripts/webkitdirs.pm:
+(removeCMakeCache):
+(generateBuildSystemFromCMakeProject):
+
 2012-07-18  Seokju Kwon  seokju.k...@samsung.com
 
 [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT


Modified: trunk/Tools/Scripts/build-webkit (122955 => 122956)

--- trunk/Tools/Scripts/build-webkit	2012-07-18 12:59:21 UTC (rev 122955)
+++ trunk/Tools/Scripts/build-webkit	2012-07-18 12:59:23 UTC (rev 122956)
@@ -319,6 +319,11 @@
 $makeArgs .= ($makeArgs ?   : ) . -j . numberOfCPUs() if $makeArgs !~ /-j\s*\d+/;
 $cmakeArgs .= ($cmakeArgs ?   : ) . -DENABLE_WEBKIT=ON;
 $cmakeArgs .=  -DENABLE_WEBKIT2=ON if !$noWebKit2;
+
+# We remove CMakeCache to avoid the bots to reuse cached flags when
+# we enable new features. This forces a reconfiguration.
+removeCMakeCache();
+
 buildCMakeProjectOrExit($clean, Efl, $prefixPath, $makeArgs, (cmakeBasedPortArguments(), cMakeArgsFromFeatures()), $cmakeArgs);
 }
 


Modified: trunk/Tools/Scripts/webkitdirs.pm (122955 => 122956)

--- trunk/Tools/Scripts/webkitdirs.pm	2012-07-18 12:59:21 UTC (rev 122955)
+++ trunk/Tools/Scripts/webkitdirs.pm	2012-07-18 12:59:23 UTC (rev 122956)
@@ -2128,6 +2128,12 @@
 return ;
 }
 
+sub removeCMakeCache()
+{
+my $cacheFilePath = File::Spec-catdir(baseProductDir(), configuration(), CMakeCache.txt);
+unlink($cacheFilePath) if -e $cacheFilePath;
+}
+
 sub generateBuildSystemFromCMakeProject
 {
 my ($port, $prefixPath, @cmakeArgs, $additionalCMakeArgs) = @_;
@@ -2167,12 +2173,6 @@
 saveJhbuildMd5();
 }
 
-# Remove CMakeCache.txt to avoid using outdated build flags
-if (isEfl()) {
-my $cacheFilePath = File::Spec-catdir($buildPath, CMakeCache.txt);
-unlink($cacheFilePath) if -e $cacheFilePath;
-}
-
 # We call system(cmake @args) instead of system(cmake, @args) so that @args is
 # parsed for shell metacharacters.
 my $wrapper = jhbuildWrapperPrefixIfNeeded() .  ;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122955] trunk/Source/WebKit2

[commit-queue]

Title: [122955] trunk/Source/WebKit2








Revision 122955
Author commit-qu...@webkit.org
Date 2012-07-18 05:59:21 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL] Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=91585

Patch by Seokju Kwon seokju.k...@samsung.com on 2012-07-18
Reviewed by Andreas Kling.

Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
since it implements the platform specific methods of WebInspectorProxy.

* PlatformEfl.cmake:
* UIProcess/efl/WebInspectorProxyEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp.
(WebKit):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::platformIsFront):
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake


Added Paths

trunk/Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp


Removed Paths

trunk/Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122954 => 122955)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 12:53:02 UTC (rev 122954)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 12:59:21 UTC (rev 122955)
@@ -1,3 +1,29 @@
+2012-07-18  Seokju Kwon  seokju.k...@samsung.com
+
+[EFL] Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
+https://bugs.webkit.org/show_bug.cgi?id=91585
+
+Reviewed by Andreas Kling.
+
+Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
+since it implements the platform specific methods of WebInspectorProxy.
+
+* PlatformEfl.cmake:
+* UIProcess/efl/WebInspectorProxyEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp.
+(WebKit):
+(WebKit::WebInspectorProxy::platformCreateInspectorPage):
+(WebKit::WebInspectorProxy::platformOpen):
+(WebKit::WebInspectorProxy::platformDidClose):
+(WebKit::WebInspectorProxy::platformBringToFront):
+(WebKit::WebInspectorProxy::platformIsFront):
+(WebKit::WebInspectorProxy::platformInspectedURLChanged):
+(WebKit::WebInspectorProxy::inspectorPageURL):
+(WebKit::WebInspectorProxy::inspectorBaseURL):
+(WebKit::WebInspectorProxy::platformInspectedWindowHeight):
+(WebKit::WebInspectorProxy::platformAttach):
+(WebKit::WebInspectorProxy::platformDetach):
+(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
+
 2012-07-18  Zoltan Horvath  zol...@webkit.org
 
 [Qt] Modify the using of the QImage::Format enum to the appropriate functions from NativeImageQt


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (122954 => 122955)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2012-07-18 12:53:02 UTC (rev 122954)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2012-07-18 12:59:21 UTC (rev 122955)
@@ -54,7 +54,7 @@
 UIProcess/efl/TextCheckerEfl.cpp
 UIProcess/efl/WebContextEfl.cpp
 UIProcess/efl/WebFullScreenManagerProxyEfl.cpp
-UIProcess/efl/WebInspectorEfl.cpp
+UIProcess/efl/WebInspectorProxyEfl.cpp
 UIProcess/efl/WebPageProxyEfl.cpp
 UIProcess/efl/WebPreferencesEfl.cpp
 


Deleted: trunk/Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp (122954 => 122955)

--- trunk/Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp	2012-07-18 12:53:02 UTC (rev 122954)
+++ trunk/Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp	2012-07-18 12:59:21 UTC (rev 122955)
@@ -1,103 +0,0 @@
-/*
- * Copyright (C) 2011 Samsung Electronics
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 

[webkit-changes] [122958] trunk/Source/WebCore

[commit-queue]

Title: [122958] trunk/Source/WebCore








Revision 122958
Author commit-qu...@webkit.org
Date 2012-07-18 06:19:13 -0700 (Wed, 18 Jul 2012)


Log Message
[WK2][EFL] Divide ENABLE(WEBGL) into ENABLE(WEBGL) and USE(3D_GRAPHICS) in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=91584

Patch by YoungTaeck Song youngtaeck.s...@samsung.com on 2012-07-18
Reviewed by Noam Rosenthal.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
Modified CMakeLists.txt so that the basic 3D-graphics sources can be compiled even when WebGL is disabled.

* CMakeLists.txt:
* PlatformEfl.cmake:
* platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::platformGraphicsContext3D):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h
trunk/Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (122957 => 122958)

--- trunk/Source/WebCore/CMakeLists.txt	2012-07-18 13:11:01 UTC (rev 122957)
+++ trunk/Source/WebCore/CMakeLists.txt	2012-07-18 13:19:13 UTC (rev 122958)
@@ -2310,12 +2310,74 @@
 ENDIF ()
 
 IF (ENABLE_WEBGL)
-#ANGLE
+SET(WTF_USE_3D_GRAPHICS 1)
+ADD_DEFINITIONS(-DWTF_USE_3D_GRAPHICS=1)
+
+LIST(APPEND WebCore_SOURCES
+html/canvas/OESStandardDerivatives.cpp
+html/canvas/OESTextureFloat.cpp
+html/canvas/OESVertexArrayObject.cpp
+html/canvas/WebGLBuffer.cpp
+html/canvas/WebGLCompressedTextureS3TC.cpp
+html/canvas/WebGLContextAttributes.cpp
+html/canvas/WebGLContextEvent.cpp
+html/canvas/WebGLContextGroup.cpp
+html/canvas/WebGLContextObject.cpp
+html/canvas/WebGLDebugRendererInfo.cpp
+html/canvas/WebGLDebugShaders.cpp
+html/canvas/WebGLDepthTexture.cpp
+html/canvas/WebGLFramebuffer.cpp
+html/canvas/WebGLGetInfo.cpp
+html/canvas/WebGLLoseContext.cpp
+html/canvas/WebGLObject.cpp
+html/canvas/WebGLProgram.cpp
+html/canvas/WebGLRenderbuffer.cpp
+html/canvas/WebGLRenderingContext.cpp
+html/canvas/WebGLShader.cpp
+html/canvas/WebGLShaderPrecisionFormat.cpp
+html/canvas/WebGLSharedObject.cpp
+html/canvas/WebGLTexture.cpp
+html/canvas/WebGLUniformLocation.cpp
+html/canvas/WebGLVertexArrayObjectOES.cpp
+html/canvas/WebGLExtension.cpp
+html/canvas/EXTTextureFilterAnisotropic.cpp
+html/canvas/OESStandardDerivatives.cpp
+html/canvas/OESTextureFloat.cpp
+html/canvas/OESVertexArrayObject.cpp
+)
+LIST(APPEND WebCore_IDL_FILES
+html/canvas/EXTTextureFilterAnisotropic.idl
+html/canvas/OESStandardDerivatives.idl
+html/canvas/OESTextureFloat.idl
+html/canvas/OESVertexArrayObject.idl
+html/canvas/WebGLActiveInfo.idl
+html/canvas/WebGLBuffer.idl
+html/canvas/WebGLCompressedTextureS3TC.idl
+html/canvas/WebGLContextAttributes.idl
+html/canvas/WebGLContextEvent.idl
+html/canvas/WebGLDebugRendererInfo.idl
+html/canvas/WebGLDebugShaders.idl
+html/canvas/WebGLDepthTexture.idl
+html/canvas/WebGLFramebuffer.idl
+html/canvas/WebGLLoseContext.idl
+html/canvas/WebGLProgram.idl
+html/canvas/WebGLRenderbuffer.idl
+html/canvas/WebGLRenderingContext.idl
+html/canvas/WebGLShader.idl
+html/canvas/WebGLShaderPrecisionFormat.idl
+html/canvas/WebGLTexture.idl
+html/canvas/WebGLUniformLocation.idl
+html/canvas/WebGLVertexArrayObjectOES.idl
+)
+ENDIF ()
+
+IF (WTF_USE_3D_GRAPHICS)
 LIST(APPEND WebCore_INCLUDE_DIRECTORIES
 ${OPENGL_INCLUDE_DIR}
-${THIRDPARTY_DIR}/ANGLE/src
-   #${THIRDPARTY_DIR}/ANGLE/include #Defined as SYSTEM include in order to have less priority than actual system headers
-${THIRDPARTY_DIR}/ANGLE/include/GLSLANG
+${THIRDPARTY_DIR}/ANGLE/src
+${THIRDPARTY_DIR}/ANGLE/include
+${THIRDPARTY_DIR}/ANGLE/include/GLSLANG
+${WEBCORE_DIR}/platform/graphics/gpu
 )
 LIST(APPEND WebCore_LIBRARIES
 ${OPENGL_gl_LIBRARY}
@@ -2413,64 +2475,10 @@
 )
 
 LIST(APPEND WebCore_SOURCES
-html/canvas/OESStandardDerivatives.cpp
-html/canvas/OESTextureFloat.cpp
-html/canvas/OESVertexArrayObject.cpp
-html/canvas/WebGLBuffer.cpp
-html/canvas/WebGLCompressedTextureS3TC.cpp
-html/canvas/WebGLContextAttributes.cpp
-html/canvas/WebGLContextEvent.cpp
-html/canvas/WebGLContextGroup.cpp
-html/canvas/WebGLContextObject.cpp
-html/canvas/WebGLDebugRendererInfo.cpp
-html/canvas/WebGLDebugShaders.cpp
-html/canvas/WebGLDepthTexture.cpp
-html/canvas/WebGLFramebuffer.cpp
-

[webkit-changes] [122960] trunk/Source/WebKit2

[carlosgc]

Title: [122960] trunk/Source/WebKit2








Revision 122960
Author carlo...@webkit.org
Date 2012-07-18 06:27:12 -0700 (Wed, 18 Jul 2012)


Log Message
[GTK] No main resource in WebView when page has been loaded from history cache
https://bugs.webkit.org/show_bug.cgi?id=91478

Reviewed by Gustavo Noronha Silva.

We are assuming that a resource loaded for the main frame that is
provisionally loading is the main resource of the web view. However
that's not true for pages loaded from history cache, so when you
go back/forward webkit_web_view_get_main_resource() always returns
NULL. We can assume that the first resource loaded for the main
frame is the main resource of the web view when
pageIsProvisionallyLoading is false.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewResourceLoadStarted): Make sure we always have a
main resource for the web view.
* UIProcess/API/gtk/tests/TestResources.cpp:
(testWebViewResourcesHistoryCache): Test we always have a main
resource even after going back/forward.
(beforeAll): Add new test case.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122959 => 122960)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 13:19:21 UTC (rev 122959)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 13:27:12 UTC (rev 122960)
@@ -1,3 +1,26 @@
+2012-07-18  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] No main resource in WebView when page has been loaded from history cache
+https://bugs.webkit.org/show_bug.cgi?id=91478
+
+Reviewed by Gustavo Noronha Silva.
+
+We are assuming that a resource loaded for the main frame that is
+provisionally loading is the main resource of the web view. However
+that's not true for pages loaded from history cache, so when you
+go back/forward webkit_web_view_get_main_resource() always returns
+NULL. We can assume that the first resource loaded for the main
+frame is the main resource of the web view when
+pageIsProvisionallyLoading is false.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewResourceLoadStarted): Make sure we always have a
+main resource for the web view.
+* UIProcess/API/gtk/tests/TestResources.cpp:
+(testWebViewResourcesHistoryCache): Test we always have a main
+resource even after going back/forward.
+(beforeAll): Add new test case.
+
 2012-07-18  Seokju Kwon  seokju.k...@samsung.com
 
 [EFL] Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (122959 => 122960)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2012-07-18 13:19:21 UTC (rev 122959)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2012-07-18 13:27:12 UTC (rev 122960)
@@ -1250,7 +1250,7 @@
 
 WebKitWebViewPrivate* priv = webView-priv;
 WebKitWebResource* resource = webkitWebResourceCreate(wkFrame, request, isMainResource);
-if (WKFrameIsMainFrame(wkFrame)  isMainResource)
+if (WKFrameIsMainFrame(wkFrame)  (isMainResource || !priv-mainResource))
 priv-mainResource = resource;
 priv-loadingResourcesMap.set(resourceIdentifier, adoptGRef(resource));
 g_signal_emit(webView, signals[RESOURCE_LOAD_STARTED], 0, resource, request);


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp (122959 => 122960)

--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp	2012-07-18 13:19:21 UTC (rev 122959)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp	2012-07-18 13:27:12 UTC (rev 122960)
@@ -520,6 +520,25 @@
 g_assert(!webkit_web_view_get_subresources(test-m_webView));
 }
 
+static void testWebViewResourcesHistoryCache(SingleResourceLoadTest* test, gconstpointer)
+{
+test-loadURI(kServer-getURIForPath(/).data());
+test-waitUntilResourceLoadFinished();
+g_assert(webkit_web_view_get_main_resource(test-m_webView));
+
+test-loadURI(kServer-getURIForPath(/_javascript_.html).data());
+test-waitUntilResourceLoadFinished();
+g_assert(webkit_web_view_get_main_resource(test-m_webView));
+
+test-goBack();
+test-waitUntilResourceLoadFinished();
+g_assert(webkit_web_view_get_main_resource(test-m_webView));
+
+test-goForward();
+test-waitUntilResourceLoadFinished();
+g_assert(webkit_web_view_get_main_resource(test-m_webView));
+}
+
 static void addCacheHTTPHeadersToResponse(SoupMessage* message)
 {
 // The actual date doesn't really matter.
@@ -604,6 +623,7 @@
 ResourceURITrackingTest::add(WebKitWebResource, active-uri, testWebResourceActiveURI);
 ResourcesTest::add(WebKitWebResource, get-data, testWebResourceGetData);
 ResourcesTest::add(WebKitWebView, replaced-content, testWebViewResourcesReplacedContent);
+

[webkit-changes] [122961] trunk/Source/WebKit2

[carlosgc]

Title: [122961] trunk/Source/WebKit2








Revision 122961
Author carlo...@webkit.org
Date 2012-07-18 06:39:26 -0700 (Wed, 18 Jul 2012)


Log Message
[GTK] Add WebKitWebView::submit-form signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=91605

Reviewed by Gustavo Noronha Silva.

The signal is emitted when a form is about to submitted, with a
form submission request that can be used to get the text fields
and to continue the form submission wheh done.

* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitFormClient.cpp: Added.
(willSubmitForm): Create a WebKitFormSubmissionRequest and call
webkitWebViewSubmitFormRequest() with the request.
(attachFormClientToView): Add impementation for willSubmitForm
callback.
* UIProcess/API/gtk/WebKitFormClient.h: Added.
* UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp: Added.
(webkit_form_submission_request_init):
(webkitFormSubmissionRequestFinalize):
(webkit_form_submission_request_class_init):
(webkitFormSubmissionRequestCreate): Create a new
WebKitFormSubmissionRequest for the given values dictionary and
submission listener.
(webkit_form_submission_request_get_text_fields): Create a
GHashTable with the text fields values and return it.
(webkit_form_submission_request_submit): Continue the form
submission.
* UIProcess/API/gtk/WebKitFormSubmissionRequest.h: Added.
* UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Attach web view to form client.
(webkit_web_view_class_init): Add WebKitWebView::submit-form
signal.
(webkitWebViewSubmitFormRequest): Emit WebKitWebView::submit-form
signal.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitFormSubmissionRequest.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSubmitForm):
(beforeAll):
* UIProcess/API/gtk/webkit2.h: Include
WebKitFormSubmissionRequest.h.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.list.am
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/webkit2.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFormClient.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFormClient.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFormSubmissionRequest.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122960 => 122961)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 13:27:12 UTC (rev 122960)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 13:39:26 UTC (rev 122961)
@@ -1,5 +1,53 @@
 2012-07-18  Carlos Garcia Campos  cgar...@igalia.com
 
+[GTK] Add WebKitWebView::submit-form signal to WebKit2 GTK+ API
+https://bugs.webkit.org/show_bug.cgi?id=91605
+
+Reviewed by Gustavo Noronha Silva.
+
+The signal is emitted when a form is about to submitted, with a
+form submission request that can be used to get the text fields
+and to continue the form submission wheh done.
+
+* GNUmakefile.list.am: Add new files to compilation.
+* UIProcess/API/gtk/WebKitFormClient.cpp: Added.
+(willSubmitForm): Create a WebKitFormSubmissionRequest and call
+webkitWebViewSubmitFormRequest() with the request.
+(attachFormClientToView): Add impementation for willSubmitForm
+callback.
+* UIProcess/API/gtk/WebKitFormClient.h: Added.
+* UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp: Added.
+(webkit_form_submission_request_init):
+(webkitFormSubmissionRequestFinalize):
+(webkit_form_submission_request_class_init):
+(webkitFormSubmissionRequestCreate): Create a new
+WebKitFormSubmissionRequest for the given values dictionary and
+submission listener.
+(webkit_form_submission_request_get_text_fields): Create a
+GHashTable with the text fields values and return it.
+(webkit_form_submission_request_submit): Continue the form
+submission.
+* UIProcess/API/gtk/WebKitFormSubmissionRequest.h: Added.
+* UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h: Added.
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewConstructed): Attach web view to form client.
+(webkit_web_view_class_init): Add WebKitWebView::submit-form
+signal.
+(webkitWebViewSubmitFormRequest): 

[webkit-changes] [122963] trunk/Source/WebCore

[commit-queue]

Title: [122963] trunk/Source/WebCore








Revision 122963
Author commit-qu...@webkit.org
Date 2012-07-18 06:42:57 -0700 (Wed, 18 Jul 2012)


Log Message
Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
https://bugs.webkit.org/show_bug.cgi?id=91548

Patch by Scott Graham scot...@chromium.org on 2012-07-18
Reviewed by Kentaro Hara.

Use cl.exe as preprocessor for IDL files rather than cygwin gcc. Cuts
two minute execution time on Windows by a bit better than 50%.

No new tests.

* WebCore.gyp/WebCore.gyp:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/bindings/scripts/preprocessor.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (122962 => 122963)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 13:41:07 UTC (rev 122962)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 13:42:57 UTC (rev 122963)
@@ -1,3 +1,19 @@
+2012-07-18  Scott Graham  scot...@chromium.org
+
+Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
+https://bugs.webkit.org/show_bug.cgi?id=91548
+
+Reviewed by Kentaro Hara.
+
+Use cl.exe as preprocessor for IDL files rather than cygwin gcc. Cuts
+two minute execution time on Windows by a bit better than 50%.
+
+No new tests.
+
+* WebCore.gyp/WebCore.gyp:
+* bindings/scripts/preprocessor.pm:
+(applyPreprocessor):
+
 2012-07-18  Pavel Feldman  pfeld...@chromium.org
 
 Web Inspector: remove search replace from behind experiment, polish the behavior


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (122962 => 122963)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-07-18 13:41:07 UTC (rev 122962)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-07-18 13:42:57 UTC (rev 122963)
@@ -511,6 +511,17 @@
   'outputs': [
 '(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
   ],
+  'conditions': [
+['OS==win', {
+  'variables': {
+# Using cl instead of cygwin gcc cuts the processing time from
+# 1m58s to 0m52s.
+'preprocessor': '--preprocessor cl.exe /nologo /EP /TP',
+  },
+}, {
+  'variables': { 'preprocessor': '', }
+}],
+  ],
   'action': [
 'perl',
 '-w',
@@ -524,6 +535,7 @@
 '(SHARED_INTERMEDIATE_DIR)/supplemental_dependency.tmp',
 '--idlAttributesFile',
 '../bindings/scripts/IDLAttributes.txt',
+'@(preprocessor)',
   ],
   'message': 'Resolving [Supplemental=XXX] dependencies in all IDL files',
 }


Modified: trunk/Source/WebCore/bindings/scripts/preprocessor.pm (122962 => 122963)

--- trunk/Source/WebCore/bindings/scripts/preprocessor.pm	2012-07-18 13:41:07 UTC (rev 122962)
+++ trunk/Source/WebCore/bindings/scripts/preprocessor.pm	2012-07-18 13:42:57 UTC (rev 122963)
@@ -23,6 +23,7 @@
 
 use Config;
 use IPC::Open2;
+use IPC::Open3;
 
 BEGIN {
use Exporter   ();
@@ -66,7 +67,10 @@
 # This call can fail if Windows rebases cygwin, so retry a few times until it succeeds.
 for (my $tries = 0; !$pid  ($tries  20); $tries++) {
 eval {
-$pid = open2(\*PP_OUT, \*PP_IN, split(' ', $preprocessor), @args, @macros, $fileName);
+# Suppress STDERR so that if we're using cl.exe, the output
+# name isn't needlessly echoed.
+use Symbol 'gensym'; my $err = gensym;
+$pid = open3(\*PP_IN, \*PP_OUT, $err, split(' ', $preprocessor), @args, @macros, $fileName);
 1;
 } or do {
 sleep 1;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122964] trunk/Source/WebCore

[caseq]

Title: [122964] trunk/Source/WebCore








Revision 122964
Author ca...@chromium.org
Date 2012-07-18 06:46:22 -0700 (Wed, 18 Jul 2012)


Log Message
Web Inspector: intern strings when processing timeline records
https://bugs.webkit.org/show_bug.cgi?id=91531

Reviewed by Pavel Feldman.

- added StringPool that is capable of interning strings;
- used it in TimelineModel to process all incoming records;

* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype.reset):
* inspector/front-end/utilities.js:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TimelineModel.js
trunk/Source/WebCore/inspector/front-end/utilities.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (122963 => 122964)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 13:42:57 UTC (rev 122963)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 13:46:22 UTC (rev 122964)
@@ -1,3 +1,19 @@
+2012-07-17  Andrey Kosyakov  ca...@chromium.org
+
+Web Inspector: intern strings when processing timeline records
+https://bugs.webkit.org/show_bug.cgi?id=91531
+
+Reviewed by Pavel Feldman.
+
+- added StringPool that is capable of interning strings;
+- used it in TimelineModel to process all incoming records;
+
+* inspector/front-end/TimelineModel.js:
+(WebInspector.TimelineModel):
+(WebInspector.TimelineModel.prototype._addRecord):
+(WebInspector.TimelineModel.prototype.reset):
+* inspector/front-end/utilities.js:
+
 2012-07-18  Scott Graham  scot...@chromium.org
 
 Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency


Modified: trunk/Source/WebCore/inspector/front-end/TimelineModel.js (122963 => 122964)

--- trunk/Source/WebCore/inspector/front-end/TimelineModel.js	2012-07-18 13:42:57 UTC (rev 122963)
+++ trunk/Source/WebCore/inspector/front-end/TimelineModel.js	2012-07-18 13:46:22 UTC (rev 122964)
@@ -35,6 +35,7 @@
 WebInspector.TimelineModel = function()
 {
 this._records = [];
+this._stringPool = new StringPool();
 this._minimumRecordTime = -1;
 this._maximumRecordTime = -1;
 this._collectionEnabled = false;
@@ -152,6 +153,7 @@
 
 _addRecord: function(record)
 {
+this._stringPool.internObjectStrings(record);
 this._records.push(record);
 this._updateBoundaries(record);
 this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordAdded, record);
@@ -214,6 +216,7 @@
 reset: function()
 {
 this._records = [];
+this._stringPool.reset();
 this._minimumRecordTime = -1;
 this._maximumRecordTime = -1;
 this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordsCleared);


Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (122963 => 122964)

--- trunk/Source/WebCore/inspector/front-end/utilities.js	2012-07-18 13:42:57 UTC (rev 122963)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js	2012-07-18 13:46:22 UTC (rev 122964)
@@ -709,3 +709,59 @@
 this._map = {};
 }
 };
+
+
+/**
+ * @constructor
+ */
+function StringPool()
+{
+this.reset();
+}
+
+StringPool.prototype = {
+/**
+ * @param {string} string
+ * @return {string}
+ */
+intern: function(string)
+{
+// Do not mess with setting __proto__ to anything but null, just handle it explicitly.
+if (string === __proto__)
+return __proto__;
+var result = this._strings[string];
+if (result === undefined) {
+this._strings[string] = string;
+result = string;
+}
+return result;
+},
+
+reset: function()
+{
+this._strings = Object.create(null);
+},
+
+/**
+ * @param {Object} obj
+ * @param {number=} depthLimit
+ */
+internObjectStrings: function(obj, depthLimit)
+{
+if (typeof depthLimit !== number)
+depthLimit = 100;
+else if (--depthLimit  0)
+throw recursion depth limit reached in StringPool.deepIntern(), perhaps attempting to traverse cyclical references?;
+
+for (var field in obj) {
+switch (typeof obj[field]) {
+case string:
+obj[field] = this.intern(obj[field]);
+break;
+case object:
+this.internObjectStrings(obj[field], depthLimit);
+break;
+}
+}
+}
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122965] trunk/LayoutTests

[vsevik]

Title: [122965] trunk/LayoutTests








Revision 122965
Author vse...@chromium.org
Date 2012-07-18 06:51:45 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122964 => 122965)

--- trunk/LayoutTests/ChangeLog	2012-07-18 13:46:22 UTC (rev 122964)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 13:51:45 UTC (rev 122965)
@@ -1,3 +1,9 @@
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium gardening, updated test expectations.
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Szilard Ledan  szle...@inf.u-szeged.hu
 
 [Qt] editing/style and editing/undo tests needs update after rebaseline and new testfonts


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122964 => 122965)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 13:46:22 UTC (rev 122964)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 13:51:45 UTC (rev 122965)
@@ -885,7 +885,6 @@
 BUGWK66377 : fast/dom/StyleSheet/gc-parent-rule.html = TEXT
 BUGWK66377 : fast/dom/StyleSheet/gc-parent-stylesheet.html = TEXT
 BUGWK66377 : fast/dom/StyleSheet/gc-rule-children-wrappers.html = TEXT
-BUGWK66377 MAC : fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml = TEXT
 
 // These tests don't work with fast timers due to setTimeout
 // races. See https://bugs.webkit.org/show_bug.cgi?id=21536
@@ -1586,7 +1585,6 @@
 BUGCR23473 MAC : fast/repaint/transform-relative-position.html = IMAGE
 BUGCR23473 MAC : fast/repaint/transform-repaint-descendants.html = IMAGE
 BUGCR23473 MAC : fast/repaint/transform-replaced-shadows.html = IMAGE
-BUGCR23473 LION SNOWLEOPARD : fast/repaint/transform-translate.html = IMAGE
 
 // -
 // END MAC PORT TESTS
@@ -2837,8 +2835,7 @@
 BUGWK70066 SKIP : svg/as-image/image-respects-deviceScaleFactor.html = TIMEOUT
 
 // Flaky tests from ~r97647
-BUGWK70298 : fast/table/border-collapsing/cached-69296.html = IMAGE PASS
-BUGWK70298 LION : plugins/hidden-iframe-with-swf-plugin.html = TEXT
+BUGWK70298 : fast/table/border-collapsing/cached-69296.html = IMAGE
 
 // Failing since ~r97700.
 BUGWK70298 WIN LINUX SNOWLEOPARD : fast/selectors/unqualified-hover-strict.html = IMAGE+TEXT PASS
@@ -3020,8 +3017,6 @@
 
 BUGWK78159 DEBUG WIN MAC LINUX : compositing/iframes/scrolling-iframe.html = PASS TEXT
 
-BUGV8_1948 MAC : fast/js/dfg-put-by-id-prototype-check.html = TEXT
-
 // Tests Error.stack behavior. We aren't consistent with JSC and do not intend to become so.
 WONTFIX : fast/js/stack-trace.html = TEXT
 
@@ -3093,7 +3088,6 @@
 BUGWK81145 LION : fast/text/midword-break-before-surrogate-pair-2.html = IMAGE
 BUGWK81145 LION : fast/writing-mode/vertical-align-table-baseline.html = IMAGE
 BUGWK81145 LION : platform/chromium/compositing/tiny-layer-rotated.html = IMAGE
-BUGWK81145 LION : compositing/geometry/empty-embed-rects.html = TEXT
 BUGWK81145 LION : editing/inserting/insert-3907422-fix.html = TEXT
 BUGWK81145 LION : editing/pasteboard/paste-text-002.html = TEXT
 BUGWK81145 LION : editing/pasteboard/paste-text-003.html = TEXT
@@ -3101,9 +3095,6 @@
 BUGWK81145 LION : editing/pasteboard/paste-text-005.html = TEXT
 BUGWK81145 LION : editing/pasteboard/paste-text-008.html = TEXT
 BUGWK81145 LION : editing/spelling/spelling-backspace-between-lines.html = TEXT
-BUGWK81145 LION : fast/events/offsetX-offsetY.html = TEXT
-BUGWK81145 LION : fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html = TEXT
-BUGWK81145 LION : fast/loader/loadInProgress.html = TEXT
 BUGWK81145 LION : platform/chromium/virtual/gpu/fast/canvas/set-colors.html = TEXT
 BUGWK81145 LION : plugins/plugin-_javascript_-access.html = TEXT
 BUGWK81145 LION : fast/writing-mode/broken-ideograph-small-caps.html = CRASH
@@ -3382,12 +3373,8 @@
 
 BUGWK84688 SNOWLEOPARD : compositing/animation/computed-style-during-delay.html = TEXT PASS
 
-BUGWK84689 SNOWLEOPARD : fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html = TIMEOUT PASS
-
 BUGWK84696 SNOWLEOPARD : fast/workers/storage/interrupt-database.html = TIMEOUT PASS
 
-BUGWK84714 SNOWLEOPARD : compositing/geometry/empty-embed-rects.html = TIMEOUT PASS
-
 BUGWK84720 DEBUG : fast/repaint/fixed-right-in-page-scale.html = IMAGE PASS
 
 BUGWK84724 SNOWLEOPARD : platform/chromium/media/video-frame-size-change.html = IMAGE PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122968] trunk/LayoutTests

[vsevik]

Title: [122968] trunk/LayoutTests








Revision 122968
Author vse...@chromium.org
Date 2012-07-18 07:38:32 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed chromium gardening, unskipped tests.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122967 => 122968)

--- trunk/LayoutTests/ChangeLog	2012-07-18 14:06:11 UTC (rev 122967)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 14:38:32 UTC (rev 122968)
@@ -1,3 +1,9 @@
+2012-07-18  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium gardening, unskipped tests.
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Szilard Ledan  szle...@inf.u-szeged.hu
 
 [Qt] editing/input and editing/unsupported-content tests needs update after rebaseline and new testfonts


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122967 => 122968)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 14:06:11 UTC (rev 122967)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 14:38:32 UTC (rev 122968)
@@ -2835,7 +2835,7 @@
 BUGWK70066 SKIP : svg/as-image/image-respects-deviceScaleFactor.html = TIMEOUT
 
 // Flaky tests from ~r97647
-BUGWK70298 : fast/table/border-collapsing/cached-69296.html = IMAGE
+BUGWK70298 MAC : fast/table/border-collapsing/cached-69296.html = IMAGE
 
 // Failing since ~r97700.
 BUGWK70298 WIN LINUX SNOWLEOPARD : fast/selectors/unqualified-hover-strict.html = IMAGE+TEXT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122969] trunk/Source/WebKit2

[commit-queue]

Title: [122969] trunk/Source/WebKit2








Revision 122969
Author commit-qu...@webkit.org
Date 2012-07-18 07:41:22 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL][WK2] Add Ewk class for cookie manager
https://bugs.webkit.org/show_bug.cgi?id=91053

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-18
Reviewed by Gustavo Noronha Silva.

Add new Ewk_Cookie_Manager class to allow the client
to set/get the cookie acceptance policy, support
persistent cookie storage and clear cookies.

The Ewk_Cookie_Manager instance can be retrieved
from the Ewk_Context API.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(_Ewk_Context::~_Ewk_Context):
(ewk_context_cookie_manager_get):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_cookie_manager.cpp: Added.
(_Ewk_Cookie_Manager):
(_Ewk_Cookie_Manager::_Ewk_Cookie_Manager):
(ewk_cookie_manager_persistent_storage_set):
(ewk_cookie_manager_accept_policy_set):
(Get_Policy_Async_Data):
(getAcceptPolicyCallback):
(ewk_cookie_manager_async_accept_policy_get):
(Get_Hostnames_Async_Data):
(getHostnamesWithCookiesCallback):
(ewk_cookie_manager_async_hostnames_with_cookies_get):
(ewk_cookie_manager_hostname_cookies_clear):
(ewk_cookie_manager_cookies_clear):
(ewk_cookie_manager_free):
(ewk_cookie_manager_new):
* UIProcess/API/efl/ewk_cookie_manager.h: Added.
* UIProcess/API/efl/ewk_cookie_manager_private.h: Added.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager_private.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122968 => 122969)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 14:38:32 UTC (rev 122968)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 14:41:22 UTC (rev 122969)
@@ -1,3 +1,43 @@
+2012-07-18  Christophe Dumez  christophe.du...@intel.com
+
+[EFL][WK2] Add Ewk class for cookie manager
+https://bugs.webkit.org/show_bug.cgi?id=91053
+
+Reviewed by Gustavo Noronha Silva.
+
+Add new Ewk_Cookie_Manager class to allow the client
+to set/get the cookie acceptance policy, support
+persistent cookie storage and clear cookies.
+
+The Ewk_Cookie_Manager instance can be retrieved
+from the Ewk_Context API.
+
+* PlatformEfl.cmake:
+* UIProcess/API/efl/EWebKit2.h:
+* UIProcess/API/efl/ewk_context.cpp:
+(_Ewk_Context):
+(_Ewk_Context::_Ewk_Context):
+(_Ewk_Context::~_Ewk_Context):
+(ewk_context_cookie_manager_get):
+* UIProcess/API/efl/ewk_context.h:
+* UIProcess/API/efl/ewk_cookie_manager.cpp: Added.
+(_Ewk_Cookie_Manager):
+(_Ewk_Cookie_Manager::_Ewk_Cookie_Manager):
+(ewk_cookie_manager_persistent_storage_set):
+(ewk_cookie_manager_accept_policy_set):
+(Get_Policy_Async_Data):
+(getAcceptPolicyCallback):
+(ewk_cookie_manager_async_accept_policy_get):
+(Get_Hostnames_Async_Data):
+(getHostnamesWithCookiesCallback):
+(ewk_cookie_manager_async_hostnames_with_cookies_get):
+(ewk_cookie_manager_hostname_cookies_clear):
+(ewk_cookie_manager_cookies_clear):
+(ewk_cookie_manager_free):
+(ewk_cookie_manager_new):
+* UIProcess/API/efl/ewk_cookie_manager.h: Added.
+* UIProcess/API/efl/ewk_cookie_manager_private.h: Added.
+
 2012-07-18  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Add WebKitWebView::submit-form signal to WebKit2 GTK+ API


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (122968 => 122969)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2012-07-18 14:38:32 UTC (rev 122968)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2012-07-18 14:41:22 UTC (rev 122969)
@@ -37,6 +37,7 @@
 UIProcess/API/efl/BatteryProvider.cpp
 UIProcess/API/efl/PageClientImpl.cpp
 UIProcess/API/efl/ewk_context.cpp
+UIProcess/API/efl/ewk_cookie_manager.cpp
 UIProcess/API/efl/ewk_intent.cpp
 UIProcess/API/efl/ewk_intent_service.cpp
 UIProcess/API/efl/ewk_navigation_policy_decision.cpp
@@ -172,6 +173,7 @@
 SET (EWebKit2_HEADERS
 ${CMAKE_CURRENT_SOURCE_DIR}/UIProcess/API/efl/EWebKit2.h
 ${CMAKE_CURRENT_SOURCE_DIR}/UIProcess/API/efl/ewk_context.h
+${CMAKE_CURRENT_SOURCE_DIR}/UIProcess/API/efl/ewk_cookie_manager.h
 ${CMAKE_CURRENT_SOURCE_DIR}/UIProcess/API/efl/ewk_intent.h
 ${CMAKE_CURRENT_SOURCE_DIR}/UIProcess/API/efl/ewk_intent_service.h
 ${CMAKE_CURRENT_SOURCE_DIR}/UIProcess/API/efl/ewk_navigation_policy_decision.h


Modified: trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h (122968 => 122969)

--- 

[webkit-changes] [122970] trunk

[commit-queue]

Title: [122970] trunk








Revision 122970
Author commit-qu...@webkit.org
Date 2012-07-18 07:47:40 -0700 (Wed, 18 Jul 2012)


Log Message
TOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
https://bugs.webkit.org/show_bug.cgi?id=91262

Patch by Kevin Ellis kev...@chromium.org on 2012-07-18
Reviewed by Antonio Gomes.

Source/WebCore:

Constrains the extent to which the touch point can be adjusted when
generating synthetic mouse events when TOUCH_ADJUSTEMNT is enabled.
Previously, the target position snapped to the center of the target
element, which can be far removed from the touch position when tapping
on or near a large element.  The refined strategy is to leave the
adjusted position unchanged if tapping within the element or to snap
to the center of the overlap region if the touch point lies outside the
bounds of the element, but the touch area and element bounds overlap.
For non-rectilineary bounds, a point lying outside the element boundary
is pulled towards the center of the element, by an amount limited by
the radius of the touch area.

Tests: touchadjustment/big-div.html
   touchadjustment/rotated-node.html

* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::contentsToWindow):
(TouchAdjustment):
(WebCore::TouchAdjustment::snapTo):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):

LayoutTests:

Adding a test case to ensure that the adjusted touch position is
within the bounds of the target element and the touch area.
Previously, the target position snapped to the center of the target
element, which can be far removed from the touch area.

The second test is for non-rectilinear elements, and verifies that
the touch area must overlap the true bounds of the element for an
adjustment to occur.

* touchadjustment/big-div-expected.txt: Added.
* touchadjustment/big-div.html: Added.
* touchadjustment/rotated-node-expected.txt: Added.
* touchadjustment/rotated-node.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/TouchAdjustment.cpp


Added Paths

trunk/LayoutTests/touchadjustment/big-div-expected.txt
trunk/LayoutTests/touchadjustment/big-div.html
trunk/LayoutTests/touchadjustment/rotated-node-expected.txt
trunk/LayoutTests/touchadjustment/rotated-node.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122969 => 122970)

--- trunk/LayoutTests/ChangeLog	2012-07-18 14:41:22 UTC (rev 122969)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 14:47:40 UTC (rev 122970)
@@ -1,3 +1,24 @@
+2012-07-18  Kevin Ellis  kev...@chromium.org
+
+TOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
+https://bugs.webkit.org/show_bug.cgi?id=91262
+
+Reviewed by Antonio Gomes.
+
+Adding a test case to ensure that the adjusted touch position is 
+within the bounds of the target element and the touch area.
+Previously, the target position snapped to the center of the target
+element, which can be far removed from the touch area.
+
+The second test is for non-rectilinear elements, and verifies that
+the touch area must overlap the true bounds of the element for an
+adjustment to occur.
+
+* touchadjustment/big-div-expected.txt: Added.
+* touchadjustment/big-div.html: Added.
+* touchadjustment/rotated-node-expected.txt: Added.
+* touchadjustment/rotated-node.html: Added.
+
 2012-07-18  Vsevolod Vlasov  vse...@chromium.org
 
 Unreviewed chromium gardening, unskipped tests.


Added: trunk/LayoutTests/touchadjustment/big-div-expected.txt (0 => 122970)

--- trunk/LayoutTests/touchadjustment/big-div-expected.txt	(rev 0)
+++ trunk/LayoutTests/touchadjustment/big-div-expected.txt	2012-07-18 14:47:40 UTC (rev 122970)
@@ -0,0 +1,64 @@
+Test touch adjustment on a large div. The adjusted touch point should lie inside the target element and within the touch area.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+
+Overlapping touch above the target should snap to the top of the target element.
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x = targetBounds.x is true
+PASS adjustedPoint.x = targetBounds.x + targetBounds.width is true
+PASS adjustedPoint.y = targetBounds.y is true
+PASS adjustedPoint.y = targetBounds.y + targetBounds.height is true
+PASS adjustedPoint.x = touchBounds.x is true
+PASS adjustedPoint.x = touchBounds.x + touchBounds.width is true
+PASS adjustedPoint.y = touchBounds.y is true
+PASS adjustedPoint.y = touchBounds.y + touchBounds.height is true
+
+Overlapping touch below the target should snap to the bottom of the target element.
+PASS adjustedNode.id is element.id
+PASS adjustedPoint.x = targetBounds.x is true
+PASS adjustedPoint.x = targetBounds.x + targetBounds.width is true
+PASS adjustedPoint.y = targetBounds.y is true
+PASS adjustedPoint.y = targetBounds.y + targetBounds.height is true
+PASS adjustedPoint.x = 

[webkit-changes] [122972] trunk/Source/WebCore

[jason . liu]

Title: [122972] trunk/Source/WebCore








Revision 122972
Author jason@torchmobile.com.cn
Date 2012-07-18 08:04:17 -0700 (Wed, 18 Jul 2012)


Log Message
[BlackBerry] We should update the status in NetworkJob if there is a new one from libcurl.
https://bugs.webkit.org/show_bug.cgi?id=91475

Reviewed by Yong Li.

Libcurl sometimes sends multiple status messages, we need to keep the last
one in NetworkJob.
We originally had the m_statusReceived check, then we found out that libcurl
sometimes sent additional 401 codes and added the 401 exception to the check,
and now we're removing the whole check(so we don't need the exception either).

RIM PR# 163172
Reviewed internally by Joe Mason.

No new tests. This is caused by libcurl's multiple status messages.
So we don't need to write a test case for webkit.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyStatusReceived):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122971 => 122972)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 14:52:05 UTC (rev 122971)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 15:04:17 UTC (rev 122972)
@@ -1,3 +1,25 @@
+2012-07-18  Jason Liu  jason@torchmobile.com.cn
+
+[BlackBerry] We should update the status in NetworkJob if there is a new one from libcurl.
+https://bugs.webkit.org/show_bug.cgi?id=91475
+
+Reviewed by Yong Li.
+
+Libcurl sometimes sends multiple status messages, we need to keep the last 
+one in NetworkJob.
+We originally had the m_statusReceived check, then we found out that libcurl 
+sometimes sent additional 401 codes and added the 401 exception to the check, 
+and now we're removing the whole check(so we don't need the exception either).
+
+RIM PR# 163172
+Reviewed internally by Joe Mason.
+
+No new tests. This is caused by libcurl's multiple status messages.
+So we don't need to write a test case for webkit.
+
+* platform/network/blackberry/NetworkJob.cpp:
+(WebCore::NetworkJob::handleNotifyStatusReceived):
+
 2012-07-18  Kevin Ellis  kev...@chromium.org
 
 TOUCH_ADJUSTMENT is too aggressive when snapping to large elements.


Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (122971 => 122972)

--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-07-18 14:52:05 UTC (rev 122971)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-07-18 15:04:17 UTC (rev 122972)
@@ -192,7 +192,7 @@
 void NetworkJob::handleNotifyStatusReceived(int status, const String message)
 {
 // Check for messages out of order or after cancel.
-if ((m_statusReceived  m_extendedStatusCode != 401) || m_responseSent || m_cancelled)
+if (m_responseSent || m_cancelled)
 return;
 
 if (isInfo(status))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122973] trunk/Tools

[commit-queue]

Title: [122973] trunk/Tools








Revision 122973
Author commit-qu...@webkit.org
Date 2012-07-18 08:07:34 -0700 (Wed, 18 Jul 2012)


Log Message
[CMake][EFL] Build and run TestWebKitAPI unit tests
https://bugs.webkit.org/show_bug.cgi?id=90671

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-07-18
Reviewed by Daniel Bates.

This patch enables almost for free a significant amount of test for the
WebKit C API, WTF and KURL. It makes easy for CMake based ports to
enable TestWebKitAPI since the missing bits to implement are
relatively simple.

* CMakeLists.txt:
* TestWebKitAPI/CMakeLists.txt: Added.
* TestWebKitAPI/PlatformEfl.cmake: Added.
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/config.h:
* TestWebKitAPI/efl/InjectedBundleController.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* TestWebKitAPI/efl/PlatformUtilities.cpp: Added.
(TestWebKitAPI):
(Util):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::URLForNonExistentResource):
* TestWebKitAPI/efl/PlatformWebView.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::initEcoreEvas):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
* TestWebKitAPI/efl/main.cpp: Added.
(checkForUseX11WindowArgument):
(main):

Modified Paths

trunk/Tools/CMakeLists.txt
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformWebView.h
trunk/Tools/TestWebKitAPI/config.h


Added Paths

trunk/Tools/TestWebKitAPI/CMakeLists.txt
trunk/Tools/TestWebKitAPI/PlatformEfl.cmake
trunk/Tools/TestWebKitAPI/efl/
trunk/Tools/TestWebKitAPI/efl/InjectedBundleController.cpp
trunk/Tools/TestWebKitAPI/efl/PlatformUtilities.cpp
trunk/Tools/TestWebKitAPI/efl/PlatformWebView.cpp
trunk/Tools/TestWebKitAPI/efl/main.cpp




Diff

Modified: trunk/Tools/CMakeLists.txt (122972 => 122973)

--- trunk/Tools/CMakeLists.txt	2012-07-18 15:04:17 UTC (rev 122972)
+++ trunk/Tools/CMakeLists.txt	2012-07-18 15:07:34 UTC (rev 122973)
@@ -14,3 +14,7 @@
 ELSEIF (${PORT} STREQUAL WinCE)
 ADD_SUBDIRECTORY(WinCELauncher)
 ENDIF()
+
+IF (ENABLE_WEBKIT2 AND ENABLE_API_TESTS)
+ADD_SUBDIRECTORY(TestWebKitAPI)
+ENDIF()


Modified: trunk/Tools/ChangeLog (122972 => 122973)

--- trunk/Tools/ChangeLog	2012-07-18 15:04:17 UTC (rev 122972)
+++ trunk/Tools/ChangeLog	2012-07-18 15:07:34 UTC (rev 122973)
@@ -1,5 +1,43 @@
 2012-07-18  Thiago Marcos P. Santos  thiago.san...@intel.com
 
+[CMake][EFL] Build and run TestWebKitAPI unit tests
+https://bugs.webkit.org/show_bug.cgi?id=90671
+
+Reviewed by Daniel Bates.
+
+This patch enables almost for free a significant amount of test for the
+WebKit C API, WTF and KURL. It makes easy for CMake based ports to
+enable TestWebKitAPI since the missing bits to implement are
+relatively simple.
+
+* CMakeLists.txt:
+* TestWebKitAPI/CMakeLists.txt: Added.
+* TestWebKitAPI/PlatformEfl.cmake: Added.
+* TestWebKitAPI/PlatformWebView.h:
+* TestWebKitAPI/config.h:
+* TestWebKitAPI/efl/InjectedBundleController.cpp: Added.
+(TestWebKitAPI):
+(TestWebKitAPI::InjectedBundleController::platformInitialize):
+* TestWebKitAPI/efl/PlatformUtilities.cpp: Added.
+(TestWebKitAPI):
+(Util):
+(TestWebKitAPI::Util::run):
+(TestWebKitAPI::Util::sleep):
+(TestWebKitAPI::Util::createURLForResource):
+(TestWebKitAPI::Util::createInjectedBundlePath):
+(TestWebKitAPI::Util::URLForNonExistentResource):
+* TestWebKitAPI/efl/PlatformWebView.cpp: Added.
+(TestWebKitAPI):
+(TestWebKitAPI::initEcoreEvas):
+(TestWebKitAPI::PlatformWebView::PlatformWebView):
+(TestWebKitAPI::PlatformWebView::~PlatformWebView):
+(TestWebKitAPI::PlatformWebView::page):
+* TestWebKitAPI/efl/main.cpp: Added.
+(checkForUseX11WindowArgument):
+(main):
+
+2012-07-18  Thiago Marcos P. Santos  thiago.san...@intel.com
+
 [CMake][EFL] Building jsc causes reconfiguration
 https://bugs.webkit.org/show_bug.cgi?id=91387
 


Added: trunk/Tools/TestWebKitAPI/CMakeLists.txt (0 => 122973)

--- trunk/Tools/TestWebKitAPI/CMakeLists.txt	(rev 0)
+++ trunk/Tools/TestWebKitAPI/CMakeLists.txt	2012-07-18 15:07:34 UTC (rev 122973)
@@ -0,0 +1,135 @@
+SET(TESTWEBKITAPI_DIR ${TOOLS_DIR}/TestWebKitAPI)
+
+INCLUDE_DIRECTORIES(${CMAKE_BINARY_DIR}
+${TESTWEBKITAPI_DIR}
+${CMAKE_SOURCE_DIR}/Source
+${DERIVED_SOURCES_WEBKIT2_DIR}/include
+${_javascript_CORE_DIR}
+${_javascript_CORE_DIR}/API
+${_javascript_CORE_DIR}/ForwardingHeaders
+${THIRDPARTY_DIR}/gtest/include
+${WEBCORE_DIR}/editing
+${WEBCORE_DIR}/platform
+${WEBCORE_DIR}/platform/graphics
+

[webkit-changes] [122974] trunk/LayoutTests

[kbalazs]

Title: [122974] trunk/LayoutTests








Revision 122974
Author kbal...@webkit.org
Date 2012-07-18 08:12:26 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed gardening.
More pixel rebaseline in compositing for qt-5.0-wk2.

Added baselines, mark failing tests.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png: Added.
* platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
* platform/qt-5.0-wk2/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
* platform/qt-5.0-wk2/compositing/flat-with-transformed-child-expected.png: Added.
* platform/qt-5.0-wk2/compositing/images/content-image-change-expected.png: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations


Added Paths

trunk/LayoutTests/platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png
trunk/LayoutTests/platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png
trunk/LayoutTests/platform/qt-5.0-wk2/compositing/fixed-position-scroll-offset-history-restore-expected.png
trunk/LayoutTests/platform/qt-5.0-wk2/compositing/flat-with-transformed-child-expected.png
trunk/LayoutTests/platform/qt-5.0-wk2/compositing/images/content-image-change-expected.png
trunk/LayoutTests/platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.png
trunk/LayoutTests/platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (122973 => 122974)

--- trunk/LayoutTests/ChangeLog	2012-07-18 15:07:34 UTC (rev 122973)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 15:12:26 UTC (rev 122974)
@@ -1,3 +1,19 @@
+2012-07-18  Balazs Kelemen  kbal...@webkit.org
+
+Unreviewed gardening.
+More pixel rebaseline in compositing for qt-5.0-wk2.
+
+Added baselines, mark failing tests.
+
+* platform/qt-5.0-wk2/TestExpectations:
+* platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png: Added.
+* platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
+* platform/qt-5.0-wk2/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
+* platform/qt-5.0-wk2/compositing/flat-with-transformed-child-expected.png: Added.
+* platform/qt-5.0-wk2/compositing/images/content-image-change-expected.png: Added.
+* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
+* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
+
 2012-07-18  Bruno de Oliveira Abinader  bruno.abina...@basyskom.com
 
 [Qt] fast/text tests needs update after rebaseline and new testfonts


Modified: trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations (122973 => 122974)

--- trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations	2012-07-18 15:07:34 UTC (rev 122973)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations	2012-07-18 15:12:26 UTC (rev 122974)
@@ -35,3 +35,8 @@
 BUGWK91615: compositing/rtl/rtl-overflow-invalidation.html = IMAGE
 BUGWK91615: compositing/transitions/scale-transition-no-start.html = IMAGE
 BUGWK91615: compositing/transitions/singular-scale-transition.html = IMAGE
+BUGWK91615: compositing/geometry/fixed-position-iframe-composited-page-scale-down.html = IMAGE
+BUGWK91615: compositing/geometry/fixed-position-iframe-composited-page-scale.html = IMAGE
+BUGWK91615: compositing/culling/filter-occlusion-blur-large.html = IMAGE
+BUGWK91615: compositing/culling/filter-occlusion-blur.html = IMAGE
+BUGWK91615: compositing/flat-with-transformed-child.html = IMAGE


Added: trunk/LayoutTests/platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/qt-5.0-wk2/compositing/fixed-position-scroll-offset-history-restore-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/qt-5.0-wk2/compositing/fixed-position-scroll-offset-history-restore-expected.png
___

Added: svn:mime-type

Added: 

[webkit-changes] [122975] trunk/Source/WebCore

[kseo]

Title: [122975] trunk/Source/WebCore








Revision 122975
Author k...@webkit.org
Date 2012-07-18 08:13:34 -0700 (Wed, 18 Jul 2012)


Log Message
[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
https://bugs.webkit.org/show_bug.cgi?id=91595

Patch by Huang Dongsung luxte...@company100.net on 2012-07-18
Reviewed by Noam Rosenthal.

Internal review by Kwang Yul Seo.

Currently, TextureMapperLayer creates an ImageBuffer as big as
m_state.needsDisplayRect if m_state.needsDispaly is false. The size of
m_state.needsDisplayRect can be bigger than the size of the layerRect, so we may
consume more memory than the size of the layerRect. It even can cause crash if
m_state.needsDisplayRect is too big.

No new tests, covered by existing tests.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122974 => 122975)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 15:12:26 UTC (rev 122974)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 15:13:34 UTC (rev 122975)
@@ -1,3 +1,23 @@
+2012-07-18  Huang Dongsung  luxte...@company100.net
+
+[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
+https://bugs.webkit.org/show_bug.cgi?id=91595
+
+Reviewed by Noam Rosenthal.
+
+Internal review by Kwang Yul Seo.
+
+Currently, TextureMapperLayer creates an ImageBuffer as big as
+m_state.needsDisplayRect if m_state.needsDispaly is false. The size of
+m_state.needsDisplayRect can be bigger than the size of the layerRect, so we may
+consume more memory than the size of the layerRect. It even can cause crash if
+m_state.needsDisplayRect is too big.
+
+No new tests, covered by existing tests.
+
+* platform/graphics/texmap/TextureMapperLayer.cpp:
+(WebCore::TextureMapperLayer::updateBackingStore):
+
 2012-07-18  Jason Liu  jason@torchmobile.com.cn
 
 [BlackBerry] We should update the status in NetworkJob if there is a new one from libcurl.


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (122974 => 122975)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp	2012-07-18 15:12:26 UTC (rev 122974)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp	2012-07-18 15:13:34 UTC (rev 122975)
@@ -108,7 +108,9 @@
 return;
 }
 
-IntRect dirtyRect = enclosingIntRect(m_state.needsDisplay ? layerRect() : m_state.needsDisplayRect);
+IntRect dirtyRect = enclosingIntRect(layerRect());
+if (!m_state.needsDisplay)
+dirtyRect.intersect(enclosingIntRect(m_state.needsDisplayRect));
 if (dirtyRect.isEmpty())
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122976] trunk

[commit-queue]

Title: [122976] trunk








Revision 122976
Author commit-qu...@webkit.org
Date 2012-07-18 08:15:22 -0700 (Wed, 18 Jul 2012)


Log Message
WebCore::StylePropertySet::addParsedProperties - crash
https://bugs.webkit.org/show_bug.cgi?id=91153

Patch by Douglas Stockwell dstockw...@chromium.org on 2012-07-18
Reviewed by Andreas Kling.

Source/WebCore:

WebKitCSSKeyframeRule::style exposed an immutable StylePropertySet.
Modified to create a mutable copy on demand.

Test: fast/css/css-keyframe-style-mutate-crash.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::mutableProperties): Added, creates a mutable copy of properties as required.
(WebCore::WebKitCSSKeyframeRule::style):
* css/WebKitCSSKeyframeRule.h:
(WebCore::StyleKeyframe::properties): Made const, use mutableProperties to mutate.

LayoutTests:

* fast/css/css-keyframe-style-mutate-crash-expected.txt: Added.
* fast/css/css-keyframe-style-mutate-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/css/WebKitCSSKeyframeRule.cpp
trunk/Source/WebCore/css/WebKitCSSKeyframeRule.h


Added Paths

trunk/LayoutTests/fast/css/css-keyframe-style-mutate-crash-expected.txt
trunk/LayoutTests/fast/css/css-keyframe-style-mutate-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122975 => 122976)

--- trunk/LayoutTests/ChangeLog	2012-07-18 15:13:34 UTC (rev 122975)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 15:15:22 UTC (rev 122976)
@@ -1,3 +1,13 @@
+2012-07-18  Douglas Stockwell  dstockw...@chromium.org
+
+WebCore::StylePropertySet::addParsedProperties - crash
+https://bugs.webkit.org/show_bug.cgi?id=91153
+
+Reviewed by Andreas Kling.
+
+* fast/css/css-keyframe-style-mutate-crash-expected.txt: Added.
+* fast/css/css-keyframe-style-mutate-crash.html: Added.
+
 2012-07-18  Balazs Kelemen  kbal...@webkit.org
 
 Unreviewed gardening.


Added: trunk/LayoutTests/fast/css/css-keyframe-style-mutate-crash-expected.txt (0 => 122976)

--- trunk/LayoutTests/fast/css/css-keyframe-style-mutate-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/css-keyframe-style-mutate-crash-expected.txt	2012-07-18 15:15:22 UTC (rev 122976)
@@ -0,0 +1 @@
+This test passes if it does not CRASH.


Added: trunk/LayoutTests/fast/css/css-keyframe-style-mutate-crash.html (0 => 122976)

--- trunk/LayoutTests/fast/css/css-keyframe-style-mutate-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/css/css-keyframe-style-mutate-crash.html	2012-07-18 15:15:22 UTC (rev 122976)
@@ -0,0 +1,9 @@
+style
+@-webkit-keyframes foo { 1% { color: initial; } }
+/style
+This test passes if it does not CRASH.
+script
+window.document.styleSheets[0].cssRules[0][0].style.color = 0;
+if (window.testRunner)
+testRunner.dumpAsText();
+/script


Modified: trunk/Source/WebCore/ChangeLog (122975 => 122976)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 15:13:34 UTC (rev 122975)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 15:15:22 UTC (rev 122976)
@@ -1,3 +1,23 @@
+2012-07-18  Douglas Stockwell  dstockw...@chromium.org
+
+WebCore::StylePropertySet::addParsedProperties - crash
+https://bugs.webkit.org/show_bug.cgi?id=91153
+
+Reviewed by Andreas Kling.
+
+WebKitCSSKeyframeRule::style exposed an immutable StylePropertySet.
+Modified to create a mutable copy on demand.
+
+Test: fast/css/css-keyframe-style-mutate-crash.html
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::collectMatchingRulesForList):
+* css/WebKitCSSKeyframeRule.cpp:
+(WebCore::StyleKeyframe::mutableProperties): Added, creates a mutable copy of properties as required.
+(WebCore::WebKitCSSKeyframeRule::style):
+* css/WebKitCSSKeyframeRule.h:
+(WebCore::StyleKeyframe::properties): Made const, use mutableProperties to mutate.
+
 2012-07-18  Huang Dongsung  luxte...@company100.net
 
 [Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.


Modified: trunk/Source/WebCore/css/StyleResolver.cpp (122975 => 122976)

--- trunk/Source/WebCore/css/StyleResolver.cpp	2012-07-18 15:13:34 UTC (rev 122975)
+++ trunk/Source/WebCore/css/StyleResolver.cpp	2012-07-18 15:15:22 UTC (rev 122976)
@@ -1801,7 +1801,7 @@
 loadPendingResources();
 
 // Add all the animating properties to the keyframe.
-if (StylePropertySet* styleDeclaration = keyframe-properties()) {
+if (const StylePropertySet* styleDeclaration = keyframe-properties()) {
 unsigned propertyCount = styleDeclaration-propertyCount();
 for (unsigned i = 0; i  propertyCount; ++i) {
 CSSPropertyID property = styleDeclaration-propertyAt(i).id();


Modified: trunk/Source/WebCore/css/WebKitCSSKeyframeRule.cpp (122975 => 122976)

--- 

[webkit-changes] [122977] trunk/Source/WebCore

[pfeldman]

Title: [122977] trunk/Source/WebCore








Revision 122977
Author pfeld...@chromium.org
Date 2012-07-18 08:39:19 -0700 (Wed, 18 Jul 2012)


Log Message
Web Inspector: beautify the paused in debugger message, make it configurable from the front-end.
https://bugs.webkit.org/show_bug.cgi?id=91628

Reviewed by Vsevolod Vlasov.

Made message smaller, using consistent font;
Made message configurable from the front-end.

* English.lproj/localizedStrings.js:
* inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::setPausedInDebuggerMessage):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawPausedInDebugger):
* inspector/DOMNodeHighlighter.h:
(InspectorOverlay):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setOverlayMessage):
(WebCore):
(WebCore::InspectorDebuggerAgent::clear):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::setOverlayMessage):
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._setDebuggerPausedDetails):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp
trunk/Source/WebCore/inspector/DOMNodeHighlighter.h
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h
trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp
trunk/Source/WebCore/inspector/PageDebuggerAgent.h
trunk/Source/WebCore/inspector/front-end/DebuggerModel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (122976 => 122977)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 15:15:22 UTC (rev 122976)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 15:39:19 UTC (rev 122977)
@@ -1,3 +1,35 @@
+2012-07-18  Pavel Feldman  pfeld...@chromium.org
+
+Web Inspector: beautify the paused in debugger message, make it configurable from the front-end.
+https://bugs.webkit.org/show_bug.cgi?id=91628
+
+Reviewed by Vsevolod Vlasov.
+
+Made message smaller, using consistent font;
+Made message configurable from the front-end.
+
+* English.lproj/localizedStrings.js:
+* inspector/DOMNodeHighlighter.cpp:
+(WebCore::InspectorOverlay::InspectorOverlay):
+(WebCore::InspectorOverlay::setPausedInDebuggerMessage):
+(WebCore::InspectorOverlay::update):
+(WebCore::InspectorOverlay::drawPausedInDebugger):
+* inspector/DOMNodeHighlighter.h:
+(InspectorOverlay):
+* inspector/Inspector.json:
+* inspector/InspectorDebuggerAgent.cpp:
+(WebCore::InspectorDebuggerAgent::setOverlayMessage):
+(WebCore):
+(WebCore::InspectorDebuggerAgent::clear):
+* inspector/InspectorDebuggerAgent.h:
+(InspectorDebuggerAgent):
+* inspector/PageDebuggerAgent.cpp:
+(WebCore::PageDebuggerAgent::setOverlayMessage):
+* inspector/PageDebuggerAgent.h:
+(PageDebuggerAgent):
+* inspector/front-end/DebuggerModel.js:
+(WebInspector.DebuggerModel.prototype._setDebuggerPausedDetails):
+
 2012-07-18  Douglas Stockwell  dstockw...@chromium.org
 
 WebCore::StylePropertySet::addParsedProperties - crash


Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (122976 => 122977)

--- trunk/Source/WebCore/English.lproj/localizedStrings.js	2012-07-18 15:15:22 UTC (rev 122976)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js	2012-07-18 15:39:19 UTC (rev 122977)
@@ -724,3 +724,4 @@
 localizedStrings[Replace] = Replace;
 localizedStrings[Replace All] = Replace All;
 localizedStrings[Previous] = Previous;
+localizedStrings[Paused in debugger] = Paused in debugger;


Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (122976 => 122977)

--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp	2012-07-18 15:15:22 UTC (rev 122976)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp	2012-07-18 15:39:19 UTC (rev 122977)
@@ -489,7 +489,6 @@
 InspectorOverlay::InspectorOverlay(Page* page, InspectorClient* client)
 : m_page(page)
 , m_client(client)
-, m_pausedInDebugger(false)
 {
 }
 
@@ -522,9 +521,9 @@
 getOrDrawRectHighlight(0, m_page, m_highlightData.get(), highlight);
 }
 
-void InspectorOverlay::setPausedInDebugger(bool flag)
+void InspectorOverlay::setPausedInDebuggerMessage(const String* message)
 {
-m_pausedInDebugger = flag;
+m_pausedInDebuggerMessage = message ? *message : String();
 update();
 }
 
@@ -564,7 +563,7 @@
 
 void InspectorOverlay::update()
 {
-if (m_highlightData || m_pausedInDebugger)
+if (m_highlightData || !m_pausedInDebuggerMessage.isNull())
 m_client-highlight();
 else
 

[webkit-changes] [122978] trunk

[krit]

Title: [122978] trunk








Revision 122978
Author k...@webkit.org
Date 2012-07-18 08:42:40 -0700 (Wed, 18 Jul 2012)


Log Message
SVG CSS property types with number don't support exponents
https://bugs.webkit.org/show_bug.cgi?id=52542

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Parse numbers in SVG presentation attributes with SVG parser to support scientific notations.
The SVG parser is already well tested and has some extra checks for edge like protection from
overflow.

The patch is based upon a patch of Bear Travis.

Test: svg/css/scientific-numbers.html

* css/CSSParser.cpp:
(WebCore::CSSParser::lex): Use SVG parser to parse numbers of SVG attributes.
* svg/SVGParserUtilities.cpp:
(WebCore::parseSVGNumber): Added accessor to call from CSSParser with double value.
(WebCore):
* svg/SVGParserUtilities.h:
(WebCore):

LayoutTests:

Test scientific number values on SVG presentation attributes.

* svg/css/scientific-numbers-expected.txt: Added.
* svg/css/scientific-numbers.html: Added.
* svg/css/script-tests/scientific-numbers.js: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/svg/SVGParserUtilities.cpp
trunk/Source/WebCore/svg/SVGParserUtilities.h


Added Paths

trunk/LayoutTests/svg/css/scientific-numbers-expected.txt
trunk/LayoutTests/svg/css/scientific-numbers.html
trunk/LayoutTests/svg/css/script-tests/scientific-numbers.js




Diff

Modified: trunk/LayoutTests/ChangeLog (122977 => 122978)

--- trunk/LayoutTests/ChangeLog	2012-07-18 15:39:19 UTC (rev 122977)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 15:42:40 UTC (rev 122978)
@@ -1,3 +1,16 @@
+2012-07-18  Dirk Schulze  k...@webkit.org
+
+SVG CSS property types with number don't support exponents
+https://bugs.webkit.org/show_bug.cgi?id=52542
+
+Reviewed by Nikolas Zimmermann.
+
+Test scientific number values on SVG presentation attributes.
+
+* svg/css/scientific-numbers-expected.txt: Added.
+* svg/css/scientific-numbers.html: Added.
+* svg/css/script-tests/scientific-numbers.js: Added.
+
 2012-07-18  Douglas Stockwell  dstockw...@chromium.org
 
 WebCore::StylePropertySet::addParsedProperties - crash


Added: trunk/LayoutTests/svg/css/scientific-numbers-expected.txt (0 => 122978)

--- trunk/LayoutTests/svg/css/scientific-numbers-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/css/scientific-numbers-expected.txt	2012-07-18 15:42:40 UTC (rev 122978)
@@ -0,0 +1,115 @@
+Test scientific numbers on values for SVG presentation attributes.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+
+Test positive exponent values with 'e'
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+
+Test positive exponent values with 'E'
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+
+Test negative exponent values with 'e'
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is baseline
+PASS getComputedStyle(text).baselineShift is 50px
+PASS getComputedStyle(text).baselineShift is 

[webkit-changes] [122979] trunk/Source/WebCore

[pfeldman]

Title: [122979] trunk/Source/WebCore








Revision 122979
Author pfeld...@chromium.org
Date 2012-07-18 09:10:35 -0700 (Wed, 18 Jul 2012)


Log Message
Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
https://bugs.webkit.org/show_bug.cgi?id=91625

Reviewed by Vsevolod Vlasov.

* inspector/front-end/HandlerRegistry.js:
* inspector/front-end/NetworkPanel.js:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js
trunk/Source/WebCore/inspector/front-end/NetworkItemView.js
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (122978 => 122979)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 15:42:40 UTC (rev 122978)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 16:10:35 UTC (rev 122979)
@@ -1,3 +1,13 @@
+2012-07-18  Pavel Feldman  pfeld...@chromium.org
+
+Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
+https://bugs.webkit.org/show_bug.cgi?id=91625
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/HandlerRegistry.js:
+* inspector/front-end/NetworkPanel.js:
+
 2012-07-18  Dirk Schulze  k...@webkit.org
 
 SVG CSS property types with number don't support exponents


Modified: trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js (122978 => 122979)

--- trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js	2012-07-18 15:42:40 UTC (rev 122978)
+++ trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js	2012-07-18 16:10:35 UTC (rev 122979)
@@ -96,7 +96,7 @@
  */
 appendApplicableItems: function(contextMenu, target)
 {
-if (!(target instanceof WebInspector.UISourceCode || target instanceof WebInspector.Resource))
+if (!(target instanceof WebInspector.UISourceCode || target instanceof WebInspector.Resource || target instanceof WebInspector.NetworkRequest))
 return;
 var contentProvider = /** @type {WebInspector.ContentProvider} */ target;
 if (!contentProvider.contentURL())


Modified: trunk/Source/WebCore/inspector/front-end/NetworkItemView.js (122978 => 122979)

--- trunk/Source/WebCore/inspector/front-end/NetworkItemView.js	2012-07-18 15:42:40 UTC (rev 122978)
+++ trunk/Source/WebCore/inspector/front-end/NetworkItemView.js	2012-07-18 16:10:35 UTC (rev 122979)
@@ -63,7 +63,7 @@
 var timingView = new WebInspector.RequestTimingView(request);
 this.appendTab(timing, WebInspector.UIString(Timing), timingView);
 }
-
+this._request = request;
 }
 
 WebInspector.NetworkItemView.prototype = {
@@ -92,6 +92,14 @@
 {
 if (event.data.isUserGesture)
 WebInspector.settings.resourceViewTab.set(event.data.tabId);
+},
+
+/**
+  * @return {WebInspector.NetworkRequest}
+  */
+request: function()
+{
+return this._request;
 }
 }
 


Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (122978 => 122979)

--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2012-07-18 15:42:40 UTC (rev 122978)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2012-07-18 16:10:35 UTC (rev 122979)
@@ -1447,6 +1447,8 @@
 {
 if (!(target instanceof WebInspector.NetworkRequest))
 return;
+if (this.visibleView  this.visibleView.isShowing()  this.visibleView.request() === target)
+return;
 
 function reveal()
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122981] trunk

[cfleizach]

Title: [122981] trunk








Revision 122981
Author cfleiz...@apple.com
Date 2012-07-18 09:36:47 -0700 (Wed, 18 Jul 2012)


Log Message
AX: input type=submit unlabelled.
https://bugs.webkit.org/show_bug.cgi?id=91563

Reviewed by Adele Peterson.

Source/WebCore: 

Make sure the default value is returned if there is no other value specified.

Test: platform/mac/accessibility/submit-button-default-value.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title):

LayoutTests: 

* platform/mac/accessibility/submit-button-default-value-expected.txt: Added.
* platform/mac/accessibility/submit-button-default-value.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp


Added Paths

trunk/LayoutTests/platform/mac/accessibility/submit-button-default-value-expected.txt
trunk/LayoutTests/platform/mac/accessibility/submit-button-default-value.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122980 => 122981)

--- trunk/LayoutTests/ChangeLog	2012-07-18 16:34:11 UTC (rev 122980)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 16:36:47 UTC (rev 122981)
@@ -1,3 +1,13 @@
+2012-07-18  Chris Fleizach  cfleiz...@apple.com
+
+AX: input type=submit unlabelled.
+https://bugs.webkit.org/show_bug.cgi?id=91563
+
+Reviewed by Adele Peterson.
+
+* platform/mac/accessibility/submit-button-default-value-expected.txt: Added.
+* platform/mac/accessibility/submit-button-default-value.html: Added.
+
 2012-07-17  Shawn Singh  shawnsi...@chromium.org
 
 [chromium] Remove awkward anchorPoint usage that implicity affects layer position


Added: trunk/LayoutTests/platform/mac/accessibility/submit-button-default-value-expected.txt (0 => 122981)

--- trunk/LayoutTests/platform/mac/accessibility/submit-button-default-value-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/submit-button-default-value-expected.txt	2012-07-18 16:36:47 UTC (rev 122981)
@@ -0,0 +1,12 @@
+  
+This tests that a submit button will return its default value as the title.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS button.title is 'AXTitle: Submit'
+PASS button.title is 'AXTitle: non-default value'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/platform/mac/accessibility/submit-button-default-value.html (0 => 122981)

--- trunk/LayoutTests/platform/mac/accessibility/submit-button-default-value.html	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/submit-button-default-value.html	2012-07-18 16:36:47 UTC (rev 122981)
@@ -0,0 +1,39 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script
+var successfullyParsed = false;
+/script
+script src=""
+/head
+body id=body
+
+input type=submit tabindex=0 id=submitButton1
+
+input type=submit tabindex=0 id=submitButton2 value=non-default value
+
+p id=description/p
+div id=console/div
+
+script
+
+description(This tests that a submit button will return its default value as the title.);
+
+if (window.accessibilityController) {
+
+document.getElementById(submitButton1).focus();
+var button = accessibilityController.focusedElement;
+shouldBe(button.title, 'AXTitle: Submit');
+
+document.getElementById(submitButton2).focus();
+button = accessibilityController.focusedElement;
+shouldBe(button.title, 'AXTitle: non-default value');
+}
+
+successfullyParsed = true;
+/script
+
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (122980 => 122981)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 16:34:11 UTC (rev 122980)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 16:36:47 UTC (rev 122981)
@@ -1,3 +1,17 @@
+2012-07-18  Chris Fleizach  cfleiz...@apple.com
+
+AX: input type=submit unlabelled.
+https://bugs.webkit.org/show_bug.cgi?id=91563
+
+Reviewed by Adele Peterson.
+
+Make sure the default value is returned if there is no other value specified.
+
+Test: platform/mac/accessibility/submit-button-default-value.html
+
+* accessibility/AccessibilityRenderObject.cpp:
+(WebCore::AccessibilityRenderObject::title):
+
 2012-07-17  Shawn Singh  shawnsi...@chromium.org
 
 [chromium] Remove awkward anchorPoint usage that implicity affects layer position


Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (122980 => 122981)

--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2012-07-18 16:34:11 UTC (rev 122980)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2012-07-18 16:36:47 UTC (rev 122981)
@@ -1363,7 +1363,7 @@
 if (isInputTag) {
 HTMLInputElement* input = static_castHTMLInputElement*(node);
 if (input-isTextButton())
-return 

[webkit-changes] [122982] trunk/LayoutTests

[jsbell]

Title: [122982] trunk/LayoutTests








Revision 122982
Author jsb...@chromium.org
Date 2012-07-18 09:46:12 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Unreviewed TestExpectations update for WK90469.
Coalesce entries for windows flaky crashes related to 90469, and try
skipping a particularly impacted test to see if fails shift elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=90469

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122981 => 122982)

--- trunk/LayoutTests/ChangeLog	2012-07-18 16:36:47 UTC (rev 122981)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 16:46:12 UTC (rev 122982)
@@ -1,3 +1,12 @@
+2012-07-18  Joshua Bell  jsb...@chromium.org
+
+[chromium] Unreviewed TestExpectations update for WK90469.
+Coalesce entries for windows flaky crashes related to 90469, and try
+skipping a particularly impacted test to see if fails shift elsewhere.
+https://bugs.webkit.org/show_bug.cgi?id=90469
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Chris Fleizach  cfleiz...@apple.com
 
 AX: input type=submit unlabelled.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122981 => 122982)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 16:36:47 UTC (rev 122981)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 16:46:12 UTC (rev 122982)
@@ -3629,10 +3629,9 @@
 // Flaky
 BUGWK90430 : inspector/timeline/timeline-receive-response-event.html = PASS TEXT TIMEOUT
 
-// Flaky on windows
+// Flaky crashes on windows circa r121610 - all of these seem to be related
 BUGWK90469 WIN : storage/indexeddb/mozilla/indexes.html = PASS CRASH
 BUGWK90469 WIN : storage/indexeddb/mozilla/key-requirements-inline-and-passed.html = PASS CRASH
-BUGWK90469 WIN : storage/websql/multiple-databases-garbage-collection.html = PASS CRASH
 BUGWK90469 WIN : storage/indexeddb/mozilla/key-requirements.html = PASS CRASH
 BUGWK90469 WIN : storage/indexeddb/mozilla/objectstorenames.html = PASS CRASH
 BUGWK90469 WIN : storage/indexeddb/mozilla/autoincrement-indexes.html = PASS CRASH
@@ -3642,22 +3641,29 @@
 BUGWK90469 WIN : storage/indexeddb/mozilla/index-prev-no-duplicate.html = PASS CRASH
 BUGWK90469 WIN : storage/indexeddb/mozilla/cursors.html = PASS CRASH
 BUGWK90469 WIN : storage/indexeddb/mozilla/create-index-with-integer-keys.html = PASS CRASH
+// Started crashing after 122286
+BUGWK91133 WIN : storage/indexeddb/constants.html = PASS CRASH
+// Started flaky after r121629.
+BUGWK90469 WIN : storage/indexeddb/cursor-delete.html = PASS CRASH
+BUGWK90469 WIN : storage/indexeddb/cursor-added-bug.html = PASS CRASH
+// Recently(?) started crashing on occassion
+BUGWK91275 WIN : storage/indexeddb/cursor-key-order.html = PASS CRASH
+BUGWK91403 WIN : storage/indexeddb/cursor-update-value-argument-required.html = PASS CRASH
+BUGWK90517 WIN : svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg = PASS CRASH
+BUGWK91421 WIN7 : svg/W3C-SVG-1.1/animate-elem-39-t.svg = PASS CRASH
+// Temporarily marking as SKIP to see if crashes shift to later tests
+//BUGWK90469 WIN : storage/websql/multiple-databases-garbage-collection.html = PASS CRASH
+BUG_JSBELL SKIP : storage/websql/multiple-databases-garbage-collection.html = PASS CRASH
 
 // Require rebaseline after bug 88171
 BUGWK88171 WIN : css1/formatting_model/floating_elements.html = IMAGE
 
-BUGWK90517 WIN : svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg = PASS CRASH
-
 // webkitIsFullScreen does not have the correct value after an iframe exits fullscreen
 BUGWK90704 : fullscreen/exit-full-screen-iframe.html = TEXT
 
 // Started failing after r121907.
 BUGWK90741 MAC : fast/text-autosizing/simple-paragraph.html = IMAGE
 
-// Started flaky after r121629.
-BUGWK90469 WIN : storage/indexeddb/cursor-delete.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/cursor-added-bug.html = PASS CRASH
-
 // Flaky
 BUGWK90743 : fast/events/display-none-on-focus-crash.html = PASS TEXT
 
@@ -3674,9 +3680,6 @@
 BUGWK90980 LINUX MAC DEBUG : fast/forms/textarea/textarea-state-restore.html = PASS TIMEOUT
 BUGWK90980 WIN : fast/forms/textarea/textarea-state-restore.html = PASS TIMEOUT
 
-// Started crashing after 122286
-BUGWK91133 WIN : storage/indexeddb/constants.html = PASS CRASH
-
 BUGWK91183 : http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html = PASS TEXT
 
 // Fails on Mac 10.7
@@ -3692,12 +3695,7 @@
 BUGWK90951 : fast/text/shaping/shaping-selection-rect.html = MISSING
 BUGWK90951 : fast/text/shaping/shaping-script-order.html = MISSING
 
-// Recently(?) started crashing on occassion
-BUGWK91275 WIN : storage/indexeddb/cursor-key-order.html = PASS CRASH
-BUGWK91403 WIN : storage/indexeddb/cursor-update-value-argument-required.html = PASS CRASH
 
-BUGWK91421 WIN7 : svg/W3C-SVG-1.1/animate-elem-39-t.svg = PASS CRASH
-
 

[webkit-changes] [122983] trunk/Source/WebCore

[commit-queue]

Title: [122983] trunk/Source/WebCore








Revision 122983
Author commit-qu...@webkit.org
Date 2012-07-18 09:51:13 -0700 (Wed, 18 Jul 2012)


Log Message
[GStreamer] 0.11 build broken
https://bugs.webkit.org/show_bug.cgi?id=91629

Patch by Philippe Normand pnorm...@igalia.com on 2012-07-18
Reviewed by Alexis Menard.

* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkProposeAllocation): Pass null GstStructure to
gst_query_add_allocation_meta(). Our propose-allocation method
is simple enough to not need to set it.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122982 => 122983)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 16:46:12 UTC (rev 122982)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 16:51:13 UTC (rev 122983)
@@ -1,3 +1,15 @@
+2012-07-18  Philippe Normand  pnorm...@igalia.com
+
+[GStreamer] 0.11 build broken
+https://bugs.webkit.org/show_bug.cgi?id=91629
+
+Reviewed by Alexis Menard.
+
+* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
+(webkitVideoSinkProposeAllocation): Pass null GstStructure to
+gst_query_add_allocation_meta(). Our propose-allocation method
+is simple enough to not need to set it.
+
 2012-07-18  Chris Fleizach  cfleiz...@apple.com
 
 AX: input type=submit unlabelled.


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp (122982 => 122983)

--- trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp	2012-07-18 16:46:12 UTC (rev 122982)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp	2012-07-18 16:51:13 UTC (rev 122983)
@@ -355,8 +355,8 @@
 if (!gst_video_info_from_caps(sink-priv-info, caps))
 return FALSE;
 
-gst_query_add_allocation_meta(query, GST_VIDEO_META_API_TYPE);
-gst_query_add_allocation_meta(query, GST_VIDEO_CROP_META_API_TYPE);
+gst_query_add_allocation_meta(query, GST_VIDEO_META_API_TYPE, 0);
+gst_query_add_allocation_meta(query, GST_VIDEO_CROP_META_API_TYPE, 0);
 return TRUE;
 }
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122984] trunk/Source/WebCore

[commit-queue]

Title: [122984] trunk/Source/WebCore








Revision 122984
Author commit-qu...@webkit.org
Date 2012-07-18 10:10:40 -0700 (Wed, 18 Jul 2012)


Log Message
Chrome/Skia: PDF print output does not have clickable links.
https://bugs.webkit.org/show_bug.cgi?id=91171

Patch by Steve VanDeBogart vand...@chromium.org on 2012-07-18
Reviewed by Stephen White.

Connect GraphicsContext::setURLForRect to Skia's new API for annotations.

Printing is not generally testable.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setURLForRect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122983 => 122984)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 16:51:13 UTC (rev 122983)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 17:10:40 UTC (rev 122984)
@@ -1,3 +1,17 @@
+2012-07-18  Steve VanDeBogart  vand...@chromium.org
+
+Chrome/Skia: PDF print output does not have clickable links.
+https://bugs.webkit.org/show_bug.cgi?id=91171
+
+Reviewed by Stephen White.
+
+Connect GraphicsContext::setURLForRect to Skia's new API for annotations.
+
+Printing is not generally testable.
+
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+(WebCore::GraphicsContext::setURLForRect):
+
 2012-07-18  Philippe Normand  pnorm...@igalia.com
 
 [GStreamer] 0.11 build broken


Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (122983 => 122984)

--- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	2012-07-18 16:51:13 UTC (rev 122983)
+++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	2012-07-18 17:10:40 UTC (rev 122984)
@@ -37,14 +37,17 @@
 #include Gradient.h
 #include ImageBuffer.h
 #include IntRect.h
+#include KURL.h
 #include NativeImageSkia.h
 #include NotImplemented.h
 #include PlatformContextSkia.h
 
+#include SkAnnotation.h
 #include SkBitmap.h
 #include SkBlurMaskFilter.h
 #include SkColorFilter.h
 #include SkCornerPathEffect.h
+#include SkData.h
 #include SkLayerDrawLooper.h
 #include SkShader.h
 #include SkiaUtils.h
@@ -994,6 +997,11 @@
 
 void GraphicsContext::setURLForRect(const KURL link, const IntRect destRect)
 {
+if (paintingDisabled())
+return;
+
+SkAutoDataUnref url(SkData::NewWithCString(link.string().utf8().data()));
+SkAnnotateRectWithURL(platformContext()-canvas(), destRect, url.get());
 }
 
 void GraphicsContext::setPlatformShouldAntialias(bool enable)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122986] trunk/Source/WebKit2

[pierre . rossi]

Title: [122986] trunk/Source/WebKit2








Revision 122986
Author pierre.ro...@gmail.com
Date 2012-07-18 10:37:29 -0700 (Wed, 18 Jul 2012)


Log Message
[Qt] Build fix for ENABLE_TOUCH_EVENTS=0

Rubber-stamped by No'am Rosenthal.

Add the appropriate ENABLE(TOUCH_EVENTS) where they're needed.

* UIProcess/API/qt/raw/qrawwebview.cpp:
* UIProcess/API/qt/raw/qrawwebview_p.h: include Platform.h so we can use the ENABLE macro.
* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Also add the missing QFile include.
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::deactivateTapHighlight):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p.h
trunk/Source/WebKit2/UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122985 => 122986)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 17:22:40 UTC (rev 122985)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 17:37:29 UTC (rev 122986)
@@ -1,3 +1,17 @@
+2012-07-18  Pierre Rossi  pierre.ro...@gmail.com
+
+[Qt] Build fix for ENABLE_TOUCH_EVENTS=0
+
+Rubber-stamped by No'am Rosenthal.
+
+Add the appropriate ENABLE(TOUCH_EVENTS) where they're needed.
+
+* UIProcess/API/qt/raw/qrawwebview.cpp:
+* UIProcess/API/qt/raw/qrawwebview_p.h: include Platform.h so we can use the ENABLE macro.
+* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Also add the missing QFile include.
+* UIProcess/qt/QtWebPageEventHandler.cpp:
+(WebKit::QtWebPageEventHandler::deactivateTapHighlight):
+
 2012-07-18  Christophe Dumez  christophe.du...@intel.com
 
 [EFL][WK2] Add Ewk class for cookie manager


Modified: trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp (122985 => 122986)

--- trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp	2012-07-18 17:22:40 UTC (rev 122985)
+++ trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview.cpp	2012-07-18 17:37:29 UTC (rev 122986)
@@ -25,7 +25,9 @@
 #include LayerTreeCoordinatorProxy.h
 #include NativeWebKeyboardEvent.h
 #include NativeWebMouseEvent.h
+#if ENABLE(TOUCH_EVENTS)
 #include NativeWebTouchEvent.h
+#endif
 #include NativeWebWheelEvent.h
 #include NotImplemented.h
 #include WebContext.h
@@ -378,7 +380,9 @@
 d-m_webPageProxy-handleWheelEvent(WebKit::NativeWebWheelEvent(event, QTransform()));
 }
 
+#if ENABLE(TOUCH_EVENTS)
 void QRawWebView::sendTouchEvent(QTouchEvent* event)
 {
 d-m_webPageProxy-handleTouchEvent(WebKit::NativeWebTouchEvent(event, QTransform()));
 }
+#endif


Modified: trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p.h (122985 => 122986)

--- trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p.h	2012-07-18 17:22:40 UTC (rev 122985)
+++ trunk/Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p.h	2012-07-18 17:37:29 UTC (rev 122986)
@@ -30,6 +30,7 @@
 #include WebKit2/WKContext.h
 #include WebKit2/WKPage.h
 #include WebKit2/WKPageGroup.h
+#include wtf/Platform.h
 
 class QRect;
 class QRectF;
@@ -92,7 +93,9 @@
 void sendKeyEvent(QKeyEvent*);
 void sendMouseEvent(QMouseEvent*, int clickCount = 0);
 void sendWheelEvent(QWheelEvent*);
+#if ENABLE(TOUCH_EVENTS)
 void sendTouchEvent(QTouchEvent*);
+#endif
 
 private:
 QRawWebViewPrivate* d;


Modified: trunk/Source/WebKit2/UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp (122985 => 122986)

--- trunk/Source/WebKit2/UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp	2012-07-18 17:22:40 UTC (rev 122985)
+++ trunk/Source/WebKit2/UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp	2012-07-18 17:37:29 UTC (rev 122986)
@@ -25,6 +25,7 @@
 
 #include WebInspectorProxy.h
 #include WebPageProxy.h
+#include QFile
 #include WebCore/MIMETypeRegistry.h
 #include wtf/text/CString.h
 #include wtf/text/StringBuilder.h


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp (122985 => 122986)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp	2012-07-18 17:22:40 UTC (rev 122985)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp	2012-07-18 17:37:29 UTC (rev 122986)
@@ -246,12 +246,14 @@
 
 void QtWebPageEventHandler::deactivateTapHighlight()
 {
+#if ENABLE(TOUCH_EVENTS)
 if (!m_isTapHighlightActive)
 return;
 
 // An empty point deactivates the highlighting.
 m_webPageProxy-handlePotentialActivation(IntPoint(), IntSize());
 m_isTapHighlightActive = false;
+#endif
 }
 
 void QtWebPageEventHandler::handleSingleTapEvent(const QTouchEvent::TouchPoint point)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122989] trunk/LayoutTests

[tony]

Title: [122989] trunk/LayoutTests








Revision 122989
Author t...@chromium.org
Date 2012-07-18 10:58:59 -0700 (Wed, 18 Jul 2012)


Log Message
Convert svg/css/scientific-numbers.html to a text only test
https://bugs.webkit.org/show_bug.cgi?id=91641

Reviewed by Dirk Schulze.

This is a JS test so we don't need the pixel dump.

* svg/css/script-tests/scientific-numbers.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/svg/css/script-tests/scientific-numbers.js




Diff

Modified: trunk/LayoutTests/ChangeLog (122988 => 122989)

--- trunk/LayoutTests/ChangeLog	2012-07-18 17:57:21 UTC (rev 122988)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 17:58:59 UTC (rev 122989)
@@ -1,3 +1,14 @@
+2012-07-18  Tony Chang  t...@chromium.org
+
+Convert svg/css/scientific-numbers.html to a text only test
+https://bugs.webkit.org/show_bug.cgi?id=91641
+
+Reviewed by Dirk Schulze.
+
+This is a JS test so we don't need the pixel dump.
+
+* svg/css/script-tests/scientific-numbers.js:
+
 2012-07-18  Alex Bravo  alex.br...@nokia.com
 
 [Qt] platform/qt/http tests needs update after rebaseline and new testfonts


Modified: trunk/LayoutTests/svg/css/script-tests/scientific-numbers.js (122988 => 122989)

--- trunk/LayoutTests/svg/css/script-tests/scientific-numbers.js	2012-07-18 17:57:21 UTC (rev 122988)
+++ trunk/LayoutTests/svg/css/script-tests/scientific-numbers.js	2012-07-18 17:58:59 UTC (rev 122989)
@@ -1,4 +1,6 @@
 description(Test scientific numbers on length values for SVG presentation attributes.)
+if (window.testRunner)
+testRunner.dumpAsText();
 createSVGTestCase();
 
 var text = createSVGElement(text);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122990] trunk/Source

[rwlbuis]

Title: [122990] trunk/Source








Revision 122990
Author rwlb...@webkit.org
Date 2012-07-18 11:09:56 -0700 (Wed, 18 Jul 2012)


Log Message
Source/WebCore: Alignment crash in MIMESniffer
https://bugs.webkit.org/show_bug.cgi?id=89787

Reviewed by Yong Li.

PR 169064

Prevent ASSERT on unaligned data. Special-case handling of unaligned data
to maskedCompareSlowCase.

No test, too hard to reproduce.

* platform/network/MIMESniffing.cpp:
(std::maskedCompareSlowCase):
(std):
(std::maskedCompare):

Source/WTF: Alignment crash in MIMESniffer
https://bugs.webkit.org/show_bug.cgi?id=89787

Reviewed by Yong Li.

PR 169064

Change isPointerTypeAlignmentOkay so calling it does not require ifdefs.

* wtf/StdLibExtras.h:
(isPointerTypeAlignmentOkay):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/StdLibExtras.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/MIMESniffing.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (122989 => 122990)

--- trunk/Source/WTF/ChangeLog	2012-07-18 17:58:59 UTC (rev 122989)
+++ trunk/Source/WTF/ChangeLog	2012-07-18 18:09:56 UTC (rev 122990)
@@ -1,3 +1,17 @@
+2012-07-18  Rob Buis  rb...@rim.com
+
+Alignment crash in MIMESniffer
+https://bugs.webkit.org/show_bug.cgi?id=89787
+
+Reviewed by Yong Li.
+
+PR 169064
+
+Change isPointerTypeAlignmentOkay so calling it does not require ifdefs.
+
+* wtf/StdLibExtras.h:
+(isPointerTypeAlignmentOkay):
+
 2012-07-17  Gabor Ballabas  gab...@inf.u-szeged.hu
 
 [Qt][V8] Remove the V8 related codepaths and configuration


Modified: trunk/Source/WTF/wtf/StdLibExtras.h (122989 => 122990)

--- trunk/Source/WTF/wtf/StdLibExtras.h	2012-07-18 17:58:59 UTC (rev 122989)
+++ trunk/Source/WTF/wtf/StdLibExtras.h	2012-07-18 18:09:56 UTC (rev 122990)
@@ -102,6 +102,11 @@
 return reinterpret_castTypePtr(ptr);
 }
 #else
+templatetypename Type
+bool isPointerTypeAlignmentOkay(Type*)
+{
+return true;
+}
 #define reinterpret_cast_ptr reinterpret_cast
 #endif
 


Modified: trunk/Source/WebCore/ChangeLog (122989 => 122990)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 17:58:59 UTC (rev 122989)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 18:09:56 UTC (rev 122990)
@@ -1,3 +1,22 @@
+2012-07-18  Rob Buis  rb...@rim.com
+
+Alignment crash in MIMESniffer
+https://bugs.webkit.org/show_bug.cgi?id=89787
+
+Reviewed by Yong Li.
+
+PR 169064
+
+Prevent ASSERT on unaligned data. Special-case handling of unaligned data
+to maskedCompareSlowCase.
+
+No test, too hard to reproduce.
+
+* platform/network/MIMESniffing.cpp:
+(std::maskedCompareSlowCase):
+(std):
+(std::maskedCompare):
+
 2012-07-18  Steve VanDeBogart  vand...@chromium.org
 
 Chrome/Skia: PDF print output does not have clickable links.


Modified: trunk/Source/WebCore/platform/network/MIMESniffing.cpp (122989 => 122990)

--- trunk/Source/WebCore/platform/network/MIMESniffing.cpp	2012-07-18 17:58:59 UTC (rev 122989)
+++ trunk/Source/WebCore/platform/network/MIMESniffing.cpp	2012-07-18 18:09:56 UTC (rev 122990)
@@ -233,11 +233,28 @@
 return result;
 }
 
+static inline bool maskedCompareSlowCase(const MagicNumbers info, const char* data)
+{
+const char* pattern = reinterpret_castconst char*(info.pattern);
+const char* mask = reinterpret_castconst char*(info.mask);
+
+size_t count = info.size;
+
+for (size_t i = 0; i  count; ++i) {
+if ((*data++  *mask++) != *pattern++)
+return false;
+}
+return true;
+}
+
 static inline bool maskedCompare(const MagicNumbers info, const char* data, size_t dataSize)
 {
 if (dataSize  info.size)
 return false;
 
+if (!isPointerTypeAlignmentOkay(static_castconst uint32_t*(static_castconst void*(data
+return maskedCompareSlowCase(info, data);
+
 const uint32_t* pattern32 = reinterpret_cast_ptrconst uint32_t*(info.pattern);
 const uint32_t* mask32 = reinterpret_cast_ptrconst uint32_t*(info.mask);
 const uint32_t* data32 = reinterpret_cast_ptrconst uint32_t*(data);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122991] trunk/Source/WebCore

[tony]

Title: [122991] trunk/Source/WebCore








Revision 122991
Author t...@chromium.org
Date 2012-07-18 11:21:33 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed, rolling out r122984.
http://trac.webkit.org/changeset/122984
https://bugs.webkit.org/show_bug.cgi?id=91171

Broken the shared build, need to export a SkData in skia

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setURLForRect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122990 => 122991)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 18:09:56 UTC (rev 122990)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 18:21:33 UTC (rev 122991)
@@ -1,3 +1,14 @@
+2012-07-18  Tony Chang  t...@chromium.org
+
+Unreviewed, rolling out r122984.
+http://trac.webkit.org/changeset/122984
+https://bugs.webkit.org/show_bug.cgi?id=91171
+
+Broken the shared build, need to export a SkData in skia
+
+* platform/graphics/skia/GraphicsContextSkia.cpp:
+(WebCore::GraphicsContext::setURLForRect):
+
 2012-07-18  Rob Buis  rb...@rim.com
 
 Alignment crash in MIMESniffer


Modified: trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp (122990 => 122991)

--- trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	2012-07-18 18:09:56 UTC (rev 122990)
+++ trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	2012-07-18 18:21:33 UTC (rev 122991)
@@ -37,17 +37,14 @@
 #include Gradient.h
 #include ImageBuffer.h
 #include IntRect.h
-#include KURL.h
 #include NativeImageSkia.h
 #include NotImplemented.h
 #include PlatformContextSkia.h
 
-#include SkAnnotation.h
 #include SkBitmap.h
 #include SkBlurMaskFilter.h
 #include SkColorFilter.h
 #include SkCornerPathEffect.h
-#include SkData.h
 #include SkLayerDrawLooper.h
 #include SkShader.h
 #include SkiaUtils.h
@@ -997,11 +994,6 @@
 
 void GraphicsContext::setURLForRect(const KURL link, const IntRect destRect)
 {
-if (paintingDisabled())
-return;
-
-SkAutoDataUnref url(SkData::NewWithCString(link.string().utf8().data()));
-SkAnnotateRectWithURL(platformContext()-canvas(), destRect, url.get());
 }
 
 void GraphicsContext::setPlatformShouldAntialias(bool enable)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122994] trunk/LayoutTests

[tony]

Title: [122994] trunk/LayoutTests








Revision 122994
Author t...@chromium.org
Date 2012-07-18 11:32:24 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Unreviewed gardening. Rebaseline 2 tests due to minor changes from r122980.

* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png
trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (122993 => 122994)

--- trunk/LayoutTests/ChangeLog	2012-07-18 18:25:54 UTC (rev 122993)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 18:32:24 UTC (rev 122994)
@@ -1,5 +1,12 @@
 2012-07-18  Tony Chang  t...@chromium.org
 
+[chromium] Unreviewed gardening. Rebaseline 2 tests due to minor changes from r122980.
+
+* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
+* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
+
+2012-07-18  Tony Chang  t...@chromium.org
+
 Convert svg/css/scientific-numbers.html to a text only test
 https://bugs.webkit.org/show_bug.cgi?id=91641
 


Modified: trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122995] trunk/Tools

[tommyw]

Title: [122995] trunk/Tools








Revision 122995
Author tom...@google.com
Date 2012-07-18 11:34:16 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class
https://bugs.webkit.org/show_bug.cgi?id=86215

Reviewed by Adam Barth.

Adding a shadow Platform object that is used to override some WebKit::Platform funtions to
instead create mock objects. No actual mock objects created yet.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Copied from Tools/DumpRenderTree/chromium/config.h.
(MockWebKitPlatformSupport::create):
(MockWebKitPlatformSupport::MockWebKitPlatformSupport):
(MockWebKitPlatformSupport::cryptographicallyRandomValues):
(MockWebKitPlatformSupport::createMediaStreamCenter):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Copied from Tools/DumpRenderTree/chromium/config.h.
(MockWebKitPlatformSupport):
* DumpRenderTree/chromium/config.h:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gypi
trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/chromium/config.h


Added Paths

trunk/Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp
trunk/Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h




Diff

Modified: trunk/Tools/ChangeLog (122994 => 122995)

--- trunk/Tools/ChangeLog	2012-07-18 18:32:24 UTC (rev 122994)
+++ trunk/Tools/ChangeLog	2012-07-18 18:34:16 UTC (rev 122995)
@@ -1,3 +1,25 @@
+2012-07-18  Tommy Widenflycht  tom...@google.com
+
+[chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class
+https://bugs.webkit.org/show_bug.cgi?id=86215
+
+Reviewed by Adam Barth.
+
+Adding a shadow Platform object that is used to override some WebKit::Platform funtions to
+instead create mock objects. No actual mock objects created yet.
+
+* DumpRenderTree/DumpRenderTree.gypi:
+* DumpRenderTree/chromium/DumpRenderTree.cpp:
+(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
+* DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Copied from Tools/DumpRenderTree/chromium/config.h.
+(MockWebKitPlatformSupport::create):
+(MockWebKitPlatformSupport::MockWebKitPlatformSupport):
+(MockWebKitPlatformSupport::cryptographicallyRandomValues):
+(MockWebKitPlatformSupport::createMediaStreamCenter):
+* DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Copied from Tools/DumpRenderTree/chromium/config.h.
+(MockWebKitPlatformSupport):
+* DumpRenderTree/chromium/config.h:
+
 2012-07-18  Thiago Marcos P. Santos  thiago.san...@intel.com
 
 [CMake][EFL] Build and run TestWebKitAPI unit tests


Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gypi (122994 => 122995)

--- trunk/Tools/DumpRenderTree/DumpRenderTree.gypi	2012-07-18 18:32:24 UTC (rev 122994)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.gypi	2012-07-18 18:34:16 UTC (rev 122995)
@@ -14,6 +14,8 @@
 'chromium/MockGrammarCheck.h',
 'chromium/MockSpellCheck.cpp',
 'chromium/MockSpellCheck.h',
+'chromium/MockWebKitPlatformSupport.cpp',
+'chromium/MockWebKitPlatformSupport.h',
 'chromium/MockWebPrerenderingSupport.cpp',
 'chromium/MockWebPrerenderingSupport.h',
 'chromium/MockWebSpeechInputController.cpp',


Modified: trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp (122994 => 122995)

--- trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp	2012-07-18 18:32:24 UTC (rev 122994)
+++ trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp	2012-07-18 18:34:16 UTC (rev 122995)
@@ -30,6 +30,7 @@
 
 #include config.h
 
+#include MockWebKitPlatformSupport.h
 #include TestShell.h
 #include WebCompositor.h
 #include webkit/support/webkit_support.h
@@ -72,7 +73,7 @@
 public:
 WebKitSupportTestEnvironment()
 {
-webkit_support::SetUpTestEnvironment();
+webkit_support::SetUpTestEnvironment(MockWebKitPlatformSupport::create());
 }
 ~WebKitSupportTestEnvironment()
 {


Copied: trunk/Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp (from rev 122994, trunk/Tools/DumpRenderTree/chromium/config.h) (0 => 122995)

--- trunk/Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp	(rev 0)
+++ trunk/Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp	2012-07-18 18:34:16 UTC (rev 122995)
@@ -0,0 +1,55 @@
+/*
+ * Copyright (C) 2012 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list 

[webkit-changes] [122996] trunk

[commit-queue]

Title: [122996] trunk








Revision 122996
Author commit-qu...@webkit.org
Date 2012-07-18 11:43:13 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Drag image for image elements should be scaled with device scale factor.
https://bugs.webkit.org/show_bug.cgi?id=89688

Patch by Varun Jain varunj...@chromium.org on 2012-07-18
Reviewed by Adam Barth.

.:

* ManualTests/chromium/drag-image-accounts-for-device-scale.html:

Source/WebCore:

Modified ManualTest: ManualTests/chromium/drag-image-accounts-for-device-scale.html

* page/Frame.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::dragImageSize):
(WebCore::deleteDragImage):
(WebCore::scaleDragImage):
(WebCore::dissolveDragImageToFraction):
(WebCore::createDragImageFromImage):
* platform/chromium/DragImageRef.h:
(DragImageChromium):
(WebCore):
* platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(BitmapImageSingleFrameSkia):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
(WebCore::BitmapImageSingleFrameSkia::create):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia):
* platform/graphics/skia/NativeImageSkia.h:
(NativeImageSkia):
(WebCore::NativeImageSkia::resolutionScale):

Source/WebKit/chromium:

* src/DragClientImpl.cpp:
(WebKit::DragClientImpl::startDrag):
* tests/DragImageTest.cpp:
(WebCore::TEST):

Modified Paths

trunk/ChangeLog
trunk/ManualTests/chromium/drag-image-accounts-for-device-scale.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/platform/chromium/DragImageChromiumSkia.cpp
trunk/Source/WebCore/platform/chromium/DragImageRef.h
trunk/Source/WebCore/platform/graphics/skia/BitmapImageSingleFrameSkia.h
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp
trunk/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp
trunk/Source/WebCore/platform/graphics/skia/NativeImageSkia.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/DragClientImpl.cpp
trunk/Source/WebKit/chromium/tests/DragImageTest.cpp




Diff

Modified: trunk/ChangeLog (122995 => 122996)

--- trunk/ChangeLog	2012-07-18 18:34:16 UTC (rev 122995)
+++ trunk/ChangeLog	2012-07-18 18:43:13 UTC (rev 122996)
@@ -1,3 +1,12 @@
+2012-07-18  Varun Jain  varunj...@chromium.org
+
+[chromium] Drag image for image elements should be scaled with device scale factor.
+https://bugs.webkit.org/show_bug.cgi?id=89688
+
+Reviewed by Adam Barth.
+
+* ManualTests/chromium/drag-image-accounts-for-device-scale.html:
+
 2012-07-18  Thiago Marcos P. Santos  thiago.san...@intel.com
 
 [CMake] Make gtest a shared library


Modified: trunk/ManualTests/chromium/drag-image-accounts-for-device-scale.html (122995 => 122996)

--- trunk/ManualTests/chromium/drag-image-accounts-for-device-scale.html	2012-07-18 18:34:16 UTC (rev 122995)
+++ trunk/ManualTests/chromium/drag-image-accounts-for-device-scale.html	2012-07-18 18:43:13 UTC (rev 122996)
@@ -6,5 +6,7 @@
 div draggable='true' id='dragme'
 Drag me
 /div
+pLastly, for testing dragging of images, drag the image below. If drag image is exactly the same size as the image on the page, the test passes./p
+img src="" width=50 height=50
 /body
 /html


Modified: trunk/Source/WebCore/ChangeLog (122995 => 122996)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 18:34:16 UTC (rev 122995)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 18:43:13 UTC (rev 122996)
@@ -1,3 +1,38 @@
+2012-07-18  Varun Jain  varunj...@chromium.org
+
+[chromium] Drag image for image elements should be scaled with device scale factor.
+https://bugs.webkit.org/show_bug.cgi?id=89688
+
+Reviewed by Adam Barth.
+
+Modified ManualTest: ManualTests/chromium/drag-image-accounts-for-device-scale.html
+
+* page/Frame.cpp:
+(WebCore::Frame::nodeImage):
+(WebCore::Frame::dragImageForSelection):
+* platform/chromium/DragImageChromiumSkia.cpp:
+(WebCore::dragImageSize):
+(WebCore::deleteDragImage):
+(WebCore::scaleDragImage):
+(WebCore::dissolveDragImageToFraction):
+(WebCore::createDragImageFromImage):
+* platform/chromium/DragImageRef.h:
+(DragImageChromium):
+(WebCore):
+* platform/graphics/skia/BitmapImageSingleFrameSkia.h:
+(BitmapImageSingleFrameSkia):
+* platform/graphics/skia/ImageBufferSkia.cpp:
+(WebCore::ImageBuffer::ImageBuffer):
+(WebCore::ImageBuffer::copyImage):
+* platform/graphics/skia/ImageSkia.cpp:
+(WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
+(WebCore::BitmapImageSingleFrameSkia::create):
+ 

[webkit-changes] [122997] trunk/Source/WebKit/chromium

[tony]

Title: [122997] trunk/Source/WebKit/chromium








Revision 122997
Author t...@chromium.org
Date 2012-07-18 11:55:32 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Unreviewed compile fix for Android.

Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp: In member function 'virtual voidunnamed::CCDamageTrackerTest_verifyDamageForTransformedLayer_Test::TestBody()':
Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:332: error: call of overloaded 'sqrt(int)' is ambiguous

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122996 => 122997)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 18:43:13 UTC (rev 122996)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 18:55:32 UTC (rev 122997)
@@ -1,3 +1,13 @@
+2012-07-18  Tony Chang  t...@chromium.org
+
+[chromium] Unreviewed compile fix for Android.
+
+Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp: In member function 'virtual voidunnamed::CCDamageTrackerTest_verifyDamageForTransformedLayer_Test::TestBody()':
+Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:332: error: call of overloaded 'sqrt(int)' is ambiguous
+
+* tests/CCDamageTrackerTest.cpp:
+(WebKitTests::TEST_F):
+
 2012-07-18  Varun Jain  varunj...@chromium.org
 
 [chromium] Drag image for image elements should be scaled with device scale factor.


Modified: trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp (122996 => 122997)

--- trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp	2012-07-18 18:43:13 UTC (rev 122996)
+++ trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp	2012-07-18 18:55:32 UTC (rev 122997)
@@ -329,7 +329,7 @@
 // Since the child layer is square, rotation by 45 degrees about the center should
 // increase the size of the expected rect by sqrt(2), centered around (100, 100). The
 // old exposed region should be fully contained in the new region.
-double expectedWidth = 30 * sqrt(2);
+double expectedWidth = 30 * sqrt(2.0);
 double expectedPosition = 100 - 0.5 * expectedWidth;
 FloatRect expectedRect(expectedPosition, expectedPosition, expectedWidth, expectedWidth);
 rootDamageRect = root-renderSurface()-damageTracker()-currentDamageRect();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122998] trunk/Source/WebKit/chromium

[tony]

Title: [122998] trunk/Source/WebKit/chromium








Revision 122998
Author t...@chromium.org
Date 2012-07-18 12:23:19 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Unreviewed compile fix for Android.

More sqrt fixes.

* tests/CCLayerTreeHostCommonTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122997 => 122998)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 18:55:32 UTC (rev 122997)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 19:23:19 UTC (rev 122998)
@@ -1,6 +1,14 @@
 2012-07-18  Tony Chang  t...@chromium.org
 
 [chromium] Unreviewed compile fix for Android.
+
+More sqrt fixes.
+
+* tests/CCLayerTreeHostCommonTest.cpp:
+
+2012-07-18  Tony Chang  t...@chromium.org
+
+[chromium] Unreviewed compile fix for Android.
 
 Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp: In member function 'virtual voidunnamed::CCDamageTrackerTest_verifyDamageForTransformedLayer_Test::TestBody()':
 Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:332: error: call of overloaded 'sqrt(int)' is ambiguous


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp (122997 => 122998)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp	2012-07-18 18:55:32 UTC (rev 122997)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp	2012-07-18 19:23:19 UTC (rev 122998)
@@ -2394,7 +2394,7 @@
 // overlaps the right side of the layer. The visible rect should be the
 // layer's right half.
 layerToSurfaceTransform.makeIdentity();
-layerToSurfaceTransform.translate(0, -sqrt(2) * 15);
+layerToSurfaceTransform.translate(0, -sqrt(2.0) * 15);
 layerToSurfaceTransform.rotate(45);
 expected = IntRect(IntPoint(15, 0), IntSize(15, 30)); // right half of layer bounds.
 actual = CCLayerTreeHostCommon::calculateVisibleRect(targetSurfaceRect, layerContentRect, layerToSurfaceTransform);
@@ -2419,7 +2419,7 @@
 // Case 2: Orthographic projection of a layer rotated about y-axis by 45 degrees, but
 // shifted to the side so only the right-half the layer would be visible on
 // the surface.
-double halfWidthOfRotatedLayer = (100 / sqrt(2)) * 0.5; // 100 is the un-rotated layer width; divided by sqrt(2) is the rotated width.
+double halfWidthOfRotatedLayer = (100 / sqrt(2.0)) * 0.5; // 100 is the un-rotated layer width; divided by sqrt(2) is the rotated width.
 layerToSurfaceTransform.makeIdentity();
 layerToSurfaceTransform.translate(-halfWidthOfRotatedLayer, 0);
 layerToSurfaceTransform.rotate3d(0, 45, 0); // rotates about the left edge of the layer






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122999] trunk/Source/WebKit/chromium

[commit-queue]

Title: [122999] trunk/Source/WebKit/chromium








Revision 122999
Author commit-qu...@webkit.org
Date 2012-07-18 12:26:56 -0700 (Wed, 18 Jul 2012)


Log Message
Implement putIndexKeys in WebIDBObjectStoreImpl
https://bugs.webkit.org/show_bug.cgi?id=91546

Patch by Alec Flett alecfl...@chromium.org on 2012-07-18
Reviewed by Darin Fisher.

Implement putIndexKeys in the chromium API, so it is callable
from chromium.

* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp
trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122998 => 122999)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 19:23:19 UTC (rev 122998)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 19:26:56 UTC (rev 122999)
@@ -1,3 +1,19 @@
+2012-07-18  Alec Flett  alecfl...@chromium.org
+
+Implement putIndexKeys in WebIDBObjectStoreImpl
+https://bugs.webkit.org/show_bug.cgi?id=91546
+
+Reviewed by Darin Fisher.
+
+Implement putIndexKeys in the chromium API, so it is callable
+from chromium.
+
+* src/WebIDBObjectStoreImpl.cpp:
+(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
+(WebKit):
+* src/WebIDBObjectStoreImpl.h:
+(WebIDBObjectStoreImpl):
+
 2012-07-18  Tony Chang  t...@chromium.org
 
 [chromium] Unreviewed compile fix for Android.


Modified: trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp (122998 => 122999)

--- trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp	2012-07-18 19:23:19 UTC (rev 122998)
+++ trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp	2012-07-18 19:26:56 UTC (rev 122999)
@@ -63,6 +63,23 @@
 m_objectStore-put(value, key, static_castIDBObjectStoreBackendInterface::PutMode(putMode), IDBCallbacksProxy::create(adoptPtr(callbacks)), transaction.getIDBTransactionBackendInterface(), ec);
 }
 
+void WebIDBObjectStoreImpl::putWithIndexKeys(const WebSerializedScriptValue value, const WebIDBKey key, PutMode putMode, WebIDBCallbacks* callbacks, const WebIDBTransaction transaction, const WebVectorWebString webIndexNames, const WebVectorWebIndexKeys webIndexKeys, WebExceptionCode ec)
+{
+ASSERT(webIndexNames.size() == webIndexKeys.size());
+VectorString indexNames(webIndexNames.size());
+VectorIDBObjectStoreBackendInterface::IndexKeys indexKeys(webIndexKeys.size());
+
+for (size_t i = 0; i  webIndexNames.size(); ++i) {
+indexNames[i] = webIndexNames[i];
+VectorRefPtrIDBKey  indexKeyList(webIndexKeys[i].size());
+for (size_t j = 0; j  webIndexKeys[i].size(); ++j)
+indexKeyList[j] = webIndexKeys[i][j];
+indexKeys[i] = indexKeyList;
+}
+
+m_objectStore-putWithIndexKeys(value, key, static_castIDBObjectStoreBackendInterface::PutMode(putMode), IDBCallbacksProxy::create(adoptPtr(callbacks)), transaction.getIDBTransactionBackendInterface(), indexNames, indexKeys, ec);
+}
+
 void WebIDBObjectStoreImpl::deleteFunction(const WebIDBKeyRange keyRange, WebIDBCallbacks* callbacks, const WebIDBTransaction transaction, WebExceptionCode ec)
 {
 m_objectStore-deleteFunction(keyRange, IDBCallbacksProxy::create(adoptPtr(callbacks)), transaction.getIDBTransactionBackendInterface(), ec);


Modified: trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h (122998 => 122999)

--- trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h	2012-07-18 19:23:19 UTC (rev 122998)
+++ trunk/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h	2012-07-18 19:26:56 UTC (rev 122999)
@@ -47,6 +47,7 @@
 
 void get(const WebIDBKeyRange, WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode);
 void put(const WebSerializedScriptValue, const WebIDBKey, PutMode, WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode);
+void putWithIndexKeys(const WebSerializedScriptValue, const WebIDBKey, PutMode, WebIDBCallbacks*, const WebIDBTransaction, const WebVectorWebString indexNames, const WebVectorWebIndexKeys, WebExceptionCode);
 void deleteFunction(const WebIDBKeyRange, WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode);
 void clear(WebIDBCallbacks*, const WebIDBTransaction, WebExceptionCode);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123000] trunk/Source/WebKit2

[commit-queue]

Title: [123000] trunk/Source/WebKit2








Revision 123000
Author commit-qu...@webkit.org
Date 2012-07-18 12:31:24 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL] Set a theme for EFL WebKit2 unit test fixture
https://bugs.webkit.org/show_bug.cgi?id=91618

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

The test fixture should load the theme generated by the build
instead of trying to load the system theme.

* PlatformEfl.cmake:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::defaultTheme):
(EWK2UnitTest):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
(EWK2UnitTestEnvironment):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122999 => 123000)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 19:26:56 UTC (rev 122999)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 19:31:24 UTC (rev 123000)
@@ -1,3 +1,22 @@
+2012-07-18  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[EFL] Set a theme for EFL WebKit2 unit test fixture
+https://bugs.webkit.org/show_bug.cgi?id=91618
+
+Reviewed by Kenneth Rohde Christiansen.
+
+The test fixture should load the theme generated by the build
+instead of trying to load the system theme.
+
+* PlatformEfl.cmake:
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
+(EWK2UnitTest::EWK2UnitTestBase::SetUp):
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
+(EWK2UnitTest::EWK2UnitTestEnvironment::defaultTheme):
+(EWK2UnitTest):
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
+(EWK2UnitTestEnvironment):
+
 2012-07-18  Pierre Rossi  pierre.ro...@gmail.com
 
 [Qt] QQuickWebView shouldn't recieve mouse events while dialogs are active


Modified: trunk/Source/WebKit2/PlatformEfl.cmake (122999 => 123000)

--- trunk/Source/WebKit2/PlatformEfl.cmake	2012-07-18 19:26:56 UTC (rev 122999)
+++ trunk/Source/WebKit2/PlatformEfl.cmake	2012-07-18 19:31:24 UTC (rev 123000)
@@ -211,6 +211,7 @@
 SET(TEST_RESOURCES_DIR ${WEBKIT2_EFL_TEST_DIR}/resources)
 
 ADD_DEFINITIONS(-DTEST_RESOURCES_DIR=\${TEST_RESOURCES_DIR}\
+-DTEST_THEME_DIR=\${THEME_BINARY_DIR}\
 -DGTEST_LINKED_AS_SHARED_LIBRARY=1
 )
 


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp (122999 => 123000)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2012-07-18 19:26:56 UTC (rev 122999)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2012-07-18 19:31:24 UTC (rev 123000)
@@ -62,6 +62,8 @@
 Evas* evas = ecore_evas_get(m_ecoreEvas);
 
 m_webView = ewk_view_add(evas);
+ewk_view_theme_set(m_webView, environment-defaultTheme());
+
 evas_object_resize(m_webView, width, height);
 evas_object_show(m_webView);
 evas_object_focus_set(m_webView, true);


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp (122999 => 123000)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp	2012-07-18 19:26:56 UTC (rev 122999)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp	2012-07-18 19:31:24 UTC (rev 123000)
@@ -34,4 +34,9 @@
 return file://TEST_RESOURCES_DIR/default_test_page.html;
 }
 
+const char* EWK2UnitTestEnvironment::defaultTheme() const
+{
+return TEST_THEME_DIR/default.edj;
+}
+
 } // namespace EWK2UnitTest


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h (122999 => 123000)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h	2012-07-18 19:26:56 UTC (rev 122999)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h	2012-07-18 19:31:24 UTC (rev 123000)
@@ -29,6 +29,7 @@
 
 bool useX11Window() const { return m_useX11Window; }
 const char* defaultTestPageUrl() const;
+const char* defaultTheme() const;
 
 virtual unsigned int defaultWidth() const { return m_defaultWidth; }
 virtual unsigned int defaultHeight() const { return m_defaultHeight; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123001] trunk/Source/WebCore

[tony]

Title: [123001] trunk/Source/WebCore








Revision 123001
Author t...@chromium.org
Date 2012-07-18 12:51:12 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Fix crash in DragImageTest caused by r122996
https://bugs.webkit.org/show_bug.cgi?id=91653

Patch by Varun Jain varunj...@chromium.org on 2012-07-18
Reviewed by Tony Chang.

Covered by existing DragImageTest.

* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::deleteDragImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/DragImageChromiumSkia.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123000 => 123001)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 19:31:24 UTC (rev 123000)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 19:51:12 UTC (rev 123001)
@@ -1,5 +1,17 @@
 2012-07-18  Varun Jain  varunj...@chromium.org
 
+[chromium] Fix crash in DragImageTest caused by r122996
+https://bugs.webkit.org/show_bug.cgi?id=91653
+
+Reviewed by Tony Chang.
+
+Covered by existing DragImageTest.
+
+* platform/chromium/DragImageChromiumSkia.cpp:
+(WebCore::deleteDragImage):
+
+2012-07-18  Varun Jain  varunj...@chromium.org
+
 [chromium] Drag image for image elements should be scaled with device scale factor.
 https://bugs.webkit.org/show_bug.cgi?id=89688
 


Modified: trunk/Source/WebCore/platform/chromium/DragImageChromiumSkia.cpp (123000 => 123001)

--- trunk/Source/WebCore/platform/chromium/DragImageChromiumSkia.cpp	2012-07-18 19:31:24 UTC (rev 123000)
+++ trunk/Source/WebCore/platform/chromium/DragImageChromiumSkia.cpp	2012-07-18 19:51:12 UTC (rev 123001)
@@ -52,7 +52,8 @@
 
 void deleteDragImage(DragImageRef image)
 {
-delete image-bitmap;
+if (image)
+delete image-bitmap;
 delete image;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123002] trunk/Tools

[dpranke]

Title: [123002] trunk/Tools








Revision 123002
Author dpra...@chromium.org
Date 2012-07-18 12:59:02 -0700 (Wed, 18 Jul 2012)


Log Message
nrwt: start merging port/webkit.py into port/base.py
https://bugs.webkit.org/show_bug.cgi?id=91559

Reviewed by Ojan Vafai.

Since all the non-test port implementations now derive from
WebKitPort, there's no real point in keeping WebKitPort distinct
from Port. This patch starts merging the two by moving nearly
all of the webkit implementations of routines with no default
behavior into base.py. The few that didn't move rely on
additional infrastructure that should be refactored differently
(like the image diffing, which should probably be its own
class) and deserve their own patches.

This patch should just be moving code around, and require no
additional tests; in fact, we can delete the tests that were
asserting virtual methods in the base class.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.baseline_search_path):
(Port.check_build):
(Port):
(Port._check_driver):
(Port._check_port_build):
(Port.check_image_diff):
(Port.driver_name):
(Port.default_results_directory):
(Port.to.setup_environ_for_server):
(Port._path_to_apache):
(Port._is_redhat_based):
(Port._is_debian_based):
(Port._apache_config_file_name_for_platform):
(Port._path_to_apache_config_file):
(Port._build_path):
(Port._path_to_driver):
(Port._path_to_webcore_library):
(Port._path_to_helper):
(Port._path_to_image_diff):
(Port._path_to_wdiff):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_httpd_returns_error_code):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort):
(WebKitPort._build_driver_flags):
(WebKitPort._read_image_diff):
(WebKitPort.skipped_layout_tests):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (123001 => 123002)

--- trunk/Tools/ChangeLog	2012-07-18 19:51:12 UTC (rev 123001)
+++ trunk/Tools/ChangeLog	2012-07-18 19:59:02 UTC (rev 123002)
@@ -1,3 +1,52 @@
+2012-07-18  Dirk Pranke  dpra...@chromium.org
+
+nrwt: start merging port/webkit.py into port/base.py
+https://bugs.webkit.org/show_bug.cgi?id=91559
+
+Reviewed by Ojan Vafai.
+
+Since all the non-test port implementations now derive from
+WebKitPort, there's no real point in keeping WebKitPort distinct
+from Port. This patch starts merging the two by moving nearly
+all of the webkit implementations of routines with no default
+behavior into base.py. The few that didn't move rely on
+additional infrastructure that should be refactored differently
+(like the image diffing, which should probably be its own
+class) and deserve their own patches.
+
+This patch should just be moving code around, and require no
+additional tests; in fact, we can delete the tests that were
+asserting virtual methods in the base class.
+
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.baseline_search_path):
+(Port.check_build):
+(Port):
+(Port._check_driver):
+(Port._check_port_build):
+(Port.check_image_diff):
+(Port.driver_name):
+(Port.default_results_directory):
+(Port.to.setup_environ_for_server):
+(Port._path_to_apache):
+(Port._is_redhat_based):
+(Port._is_debian_based):
+(Port._apache_config_file_name_for_platform):
+(Port._path_to_apache_config_file):
+(Port._build_path):
+(Port._path_to_driver):
+(Port._path_to_webcore_library):
+(Port._path_to_helper):
+(Port._path_to_image_diff):
+(Port._path_to_wdiff):
+* Scripts/webkitpy/layout_tests/port/base_unittest.py:
+(PortTest.test_httpd_returns_error_code):
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+(WebKitPort):
+(WebKitPort._build_driver_flags):
+(WebKitPort._read_image_diff):
+(WebKitPort.skipped_layout_tests):
+
 2012-07-18  Tommy Widenflycht  tom...@google.com
 
 [chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (123001 => 123002)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2012-07-18 19:51:12 UTC (rev 123001)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2012-07-18 19:59:02 UTC (rev 123002)
@@ -36,6 +36,7 @@
 import os
 import optparse
 import re
+import sys
 
 try:
 from collections import OrderedDict
@@ -184,13 +185,40 @@
 def baseline_search_path(self):
 Return a list of absolute paths to directories to search under for
 baselines. The directories are searched in order.
-raise NotImplementedError('Port.baseline_search_path')
+   

[webkit-changes] [123003] trunk/Source/WebKit/chromium

[tony]

Title: [123003] trunk/Source/WebKit/chromium








Revision 123003
Author t...@chromium.org
Date 2012-07-18 12:59:24 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Fix compile on Windows.

148tests\LayerChromiumTest.cpp(510): warning C4305: 'argument' : truncation from 'double' to 'float'

* tests/LayerChromiumTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (123002 => 123003)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 19:59:02 UTC (rev 123002)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 19:59:24 UTC (rev 123003)
@@ -1,3 +1,11 @@
+2012-07-18  Tony Chang  t...@chromium.org
+
+[chromium] Fix compile on Windows.
+
+148tests\LayerChromiumTest.cpp(510): warning C4305: 'argument' : truncation from 'double' to 'float'
+
+* tests/LayerChromiumTest.cpp:
+
 2012-07-18  Alec Flett  alecfl...@chromium.org
 
 Implement putIndexKeys in WebIDBObjectStoreImpl


Modified: trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp (123002 => 123003)

--- trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp	2012-07-18 19:59:02 UTC (rev 123002)
+++ trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp	2012-07-18 19:59:24 UTC (rev 123003)
@@ -507,8 +507,8 @@
 
 // Next, test properties that should call setNeedsCommit (but not setNeedsDisplay)
 // All properties need to be set to new values in order for setNeedsCommit to be called.
-EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer-setAnchorPoint(FloatPoint(1.23, 4.56)));
-EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer-setAnchorPointZ(0.7));
+EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer-setAnchorPoint(FloatPoint(1.23f, 4.56f)));
+EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer-setAnchorPointZ(0.7f));
 EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer-setBackgroundColor(SK_ColorLTGRAY));
 EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer-setMasksToBounds(true));
 EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer-setMaskLayer(dummyLayer.get()));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123004] trunk

[commit-queue]

Title: [123004] trunk








Revision 123004
Author commit-qu...@webkit.org
Date 2012-07-18 13:01:46 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL] Add central error management to EFL port
https://bugs.webkit.org/show_bug.cgi?id=91598

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Define possible error types in ErrorsEfl so
that we can reuse the header in both WebKit1
and WebKit2. This is inspired from the GTK
port.

No new tests, no behavior change.

* PlatformEfl.cmake:
* platform/efl/ErrorsEfl.cpp: Added.
(WebCore):
(WebCore::cancelledError):
(WebCore::blockedError):
(WebCore::cannotShowURLError):
(WebCore::interruptedForPolicyChangeError):
(WebCore::cannotShowMIMETypeError):
(WebCore::fileDoesNotExistError):
(WebCore::pluginWillHandleLoadError):
(WebCore::downloadNetworkError):
(WebCore::downloadCancelledByUserError):
(WebCore::downloadDestinationError):
(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):
* platform/efl/ErrorsEfl.h: Added.
(WebCore):

Source/WebKit/efl:

Make use of ErrorsEfl header from WebCore in
EFL's FrameLoaderClient now that we have
a central place for errors.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::cancelledError):
(WebCore::FrameLoaderClientEfl::blockedError):
(WebCore::FrameLoaderClientEfl::cannotShowURLError):
(WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
(WebCore::FrameLoaderClientEfl::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientEfl::fileDoesNotExistError):
(WebCore::FrameLoaderClientEfl::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientEfl::shouldFallBack):

Source/WebKit2:

Make use of ErrorsEfl header from WebCore in
WebKit2, for Ewk_Web_Error and WebErrorsEfl.

* UIProcess/API/efl/ewk_web_error.cpp:
(ewk_web_error_type_get):
* UIProcess/API/efl/ewk_web_error.h:
* WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
(WebKit::cancelledError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::fileDoesNotExistError):
(WebKit::pluginWillHandleLoadError):

Tools:

Map WebKitNetworkError to NSURLErrorDomain when
printing in DumpRenderTree so that the output
matches the expected one.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(descriptionSuitableForTestResult):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_web_error.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp


Added Paths

trunk/Source/WebCore/platform/efl/ErrorsEfl.cpp
trunk/Source/WebCore/platform/efl/ErrorsEfl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (123003 => 123004)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 19:59:24 UTC (rev 123003)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 20:01:46 UTC (rev 123004)
@@ -1,3 +1,36 @@
+2012-07-18  Christophe Dumez  christophe.du...@intel.com
+
+[EFL] Add central error management to EFL port
+https://bugs.webkit.org/show_bug.cgi?id=91598
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Define possible error types in ErrorsEfl so
+that we can reuse the header in both WebKit1
+and WebKit2. This is inspired from the GTK
+port.
+
+No new tests, no behavior change.
+
+* PlatformEfl.cmake:
+* platform/efl/ErrorsEfl.cpp: Added.
+(WebCore):
+(WebCore::cancelledError):
+(WebCore::blockedError):
+(WebCore::cannotShowURLError):
+(WebCore::interruptedForPolicyChangeError):
+(WebCore::cannotShowMIMETypeError):
+(WebCore::fileDoesNotExistError):
+(WebCore::pluginWillHandleLoadError):
+(WebCore::downloadNetworkError):
+(WebCore::downloadCancelledByUserError):
+(WebCore::downloadDestinationError):
+(WebCore::printError):
+(WebCore::printerNotFoundError):
+(WebCore::invalidPageRangeToPrint):
+* platform/efl/ErrorsEfl.h: Added.
+(WebCore):
+
 2012-07-18  Varun Jain  varunj...@chromium.org
 
 [chromium] Fix crash in DragImageTest caused by r122996


Modified: trunk/Source/WebCore/PlatformEfl.cmake (123003 => 123004)

--- trunk/Source/WebCore/PlatformEfl.cmake	2012-07-18 19:59:24 UTC (rev 123003)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2012-07-18 20:01:46 UTC (rev 123004)
@@ -33,6 +33,7 @@
   platform/efl/DragImageEfl.cpp
   platform/efl/EflKeyboardUtilities.cpp
   platform/efl/EflScreenUtilities.cpp
+  platform/efl/ErrorsEfl.cpp
   platform/efl/EventLoopEfl.cpp
   platform/efl/FileSystemEfl.cpp
   platform/efl/GamepadsEfl.cpp


Added: 

[webkit-changes] [123005] trunk

[scheib]

Title: [123005] trunk








Revision 123005
Author sch...@chromium.org
Date 2012-07-18 13:06:12 -0700 (Wed, 18 Jul 2012)


Log Message
Unify allowfullscreen logic in Document::webkitFullScreenEnabled and fullScreenIsAllowedForElement.
https://bugs.webkit.org/show_bug.cgi?id=91448

Reviewed by Adrienne Walker.

Unifies redundant traversal logic and static cast previously used
to determine if an element or document can be made fullscreen.
This clean up prepares for pointer lock, which will use the same logic.

Added a test to detect an edge case of an owning document with
fullscreen permision moving an iframe to fullscreen, while that iframe
does not have permision for its contents to be made fullscreen.

Source/WebCore:

Test: fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html

* dom/Document.cpp:
(WebCore::isAttributeOnAllOwners):
(WebCore::Document::fullScreenIsAllowedForElement):
(WebCore::Document::webkitFullscreenEnabled):

LayoutTests:

* fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt: Added.
* fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLFrameElementBase.cpp
trunk/Source/WebCore/html/HTMLFrameElementBase.h


Added Paths

trunk/LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt
trunk/LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123004 => 123005)

--- trunk/LayoutTests/ChangeLog	2012-07-18 20:01:46 UTC (rev 123004)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 20:06:12 UTC (rev 123005)
@@ -1,3 +1,21 @@
+2012-07-18  Vincent Scheib  sch...@chromium.org
+
+Unify allowfullscreen logic in Document::webkitFullScreenEnabled and fullScreenIsAllowedForElement.
+https://bugs.webkit.org/show_bug.cgi?id=91448
+
+Reviewed by Adrienne Walker.
+
+Unifies redundant traversal logic and static cast previously used
+to determine if an element or document can be made fullscreen.
+This clean up prepares for pointer lock, which will use the same logic.
+
+Added a test to detect an edge case of an owning document with
+fullscreen permision moving an iframe to fullscreen, while that iframe
+does not have permision for its contents to be made fullscreen.
+
+* fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt: Added.
+* fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html: Added.
+
 2012-07-18  Tony Chang  t...@chromium.org
 
 [chromium] Unreviewed gardening. Rebaseline 2 tests due to minor changes from r122980.


Added: trunk/LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt (0 => 123005)

--- trunk/LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt	(rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt	2012-07-18 20:06:12 UTC (rev 123005)
@@ -0,0 +1,11 @@
+Test entering full screen security restrictions. An iframe without an allow attribute is still permitted to fullscreen if the request comes from the containing document.
+
+To test manually, press any key - the page should enter full screen mode.
+
+TEST(document.webkitFullscreenEnabled) OK
+iframe's webkitFullscreenEnabled should be false:
+TEST(iframeMessage == 'document.webkitFullscreenEnabled == false') OK
+EVENT(webkitfullscreenchange)
+SUCCEED - entered full screen!
+END OF TEST
+


Added: trunk/LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html (0 => 123005)

--- trunk/LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html	(rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html	2012-07-18 20:06:12 UTC (rev 123005)
@@ -0,0 +1,35 @@
+pTest entering full screen security restrictions. An iframe without an allow attribute
+is still permitted to fullscreen if the request comes from the containing document./p
+pTo test manually, press any key - the page should enter full screen mode./p
+script src=""
+script
+window._onmessage_ = function (e) {
+frame = document.getElementById('frame');
+
+test(document.webkitFullscreenEnabled);
+consoleWrite(iframe's webkitFullscreenEnabled should be false:);
+iframeMessage = e.data;
+test(iframeMessage == 'document.webkitFullscreenEnabled == false');
+
+waitForEvent(document, 'webkitfullscreenchange', function() {
+consoleWrite(SUCCEED - entered full screen!);
+endTest();
+});
+
+runWithKeyDown(function() {
+ 

[webkit-changes] [123006] trunk/Source/WebCore

[dglazkov]

Title: [123006] trunk/Source/WebCore








Revision 123006
Author dglaz...@chromium.org
Date 2012-07-18 13:09:57 -0700 (Wed, 18 Jul 2012)


Log Message
Fix up old name in RuleSet::addRulesFromSheet
https://bugs.webkit.org/show_bug.cgi?id=91646

Reviewed by Andreas Kling.

Simple parameter rename, no change in functionality.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Renamed styleSelector to resolver to reflect recent rename of the parameter type.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123005 => 123006)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 20:06:12 UTC (rev 123005)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 20:09:57 UTC (rev 123006)
@@ -1,3 +1,15 @@
+2012-07-18  Dimitri Glazkov  dglaz...@chromium.org
+
+Fix up old name in RuleSet::addRulesFromSheet
+https://bugs.webkit.org/show_bug.cgi?id=91646
+
+Reviewed by Andreas Kling.
+
+Simple parameter rename, no change in functionality.
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::collectMatchingRulesForList): Renamed styleSelector to resolver to reflect recent rename of the parameter type.
+
 2012-07-18  Vincent Scheib  sch...@chromium.org
 
 Unify allowfullscreen logic in Document::webkitFullScreenEnabled and fullScreenIsAllowedForElement.


Modified: trunk/Source/WebCore/css/StyleResolver.cpp (123005 => 123006)

--- trunk/Source/WebCore/css/StyleResolver.cpp	2012-07-18 20:06:12 UTC (rev 123005)
+++ trunk/Source/WebCore/css/StyleResolver.cpp	2012-07-18 20:09:57 UTC (rev 123006)
@@ -2607,17 +2607,17 @@
 m_regionSelectorsAndRuleSets.append(RuleSetSelectorPair(regionRule-selectorList().first(), regionRuleSet.release()));
 }
 
-void RuleSet::addRulesFromSheet(StyleSheetContents* sheet, const MediaQueryEvaluator medium, StyleResolver* styleSelector, const ContainerNode* scope)
+void RuleSet::addRulesFromSheet(StyleSheetContents* sheet, const MediaQueryEvaluator medium, StyleResolver* resolver, const ContainerNode* scope)
 {
 ASSERT(sheet);
 
 const VectorRefPtrStyleRuleImport  importRules = sheet-importRules();
 for (unsigned i = 0; i  importRules.size(); ++i) {
 StyleRuleImport* importRule = importRules[i].get();
-if (importRule-styleSheet()  (!importRule-mediaQueries() || medium.eval(importRule-mediaQueries(), styleSelector)))
-addRulesFromSheet(importRule-styleSheet(), medium, styleSelector, scope);
+if (importRule-styleSheet()  (!importRule-mediaQueries() || medium.eval(importRule-mediaQueries(), resolver)))
+addRulesFromSheet(importRule-styleSheet(), medium, resolver, scope);
 }
-bool hasDocumentSecurityOrigin = styleSelector  styleSelector-document()-securityOrigin()-canRequest(sheet-baseURL());
+bool hasDocumentSecurityOrigin = resolver  resolver-document()-securityOrigin()-canRequest(sheet-baseURL());
 
 const VectorRefPtrStyleRuleBase  rules = sheet-childRules();
 for (unsigned i = 0; i  rules.size(); ++i) {
@@ -2631,7 +2631,7 @@
 else if (rule-isMediaRule()) {
 StyleRuleMedia* mediaRule = static_castStyleRuleMedia*(rule);
 
-if ((!mediaRule-mediaQueries() || medium.eval(mediaRule-mediaQueries(), styleSelector))) {
+if ((!mediaRule-mediaQueries() || medium.eval(mediaRule-mediaQueries(), resolver))) {
 // Traverse child elements of the @media rule.
 const VectorRefPtrStyleRuleBase  childRules = mediaRule-childRules();
 for (unsigned j = 0; j  childRules.size(); ++j) {
@@ -2640,39 +2640,39 @@
 addStyleRule(static_castStyleRule*(childRule), hasDocumentSecurityOrigin, !scope);
 else if (childRule-isPageRule())
 addPageRule(static_castStyleRulePage*(childRule));
-else if (childRule-isFontFaceRule()  styleSelector) {
+else if (childRule-isFontFaceRule()  resolver) {
 // Add this font face to our set.
 // FIXME(BUG 72461): We don't add @font-face rules of scoped style sheets for the moment.
 if (scope)
 continue;
 const StyleRuleFontFace* fontFaceRule = static_castStyleRuleFontFace*(childRule);
-styleSelector-fontSelector()-addFontFaceRule(fontFaceRule);
-styleSelector-invalidateMatchedPropertiesCache();
-} else if (childRule-isKeyframesRule()  styleSelector) {
+resolver-fontSelector()-addFontFaceRule(fontFaceRule);
+resolver-invalidateMatchedPropertiesCache();
+} else if (childRule-isKeyframesRule()  resolver) {
 // Add this keyframe rule to our set.
 // 

[webkit-changes] [123007] trunk

[tony]

Title: [123007] trunk








Revision 123007
Author t...@chromium.org
Date 2012-07-18 13:21:34 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Unreviewed, more compile fixes on Chromium Win.

Source/WebKit/chromium:

* tests/WebTransformationMatrixTest.cpp:
(WebKit::TEST):

Tools:

* DumpRenderTree/chromium/TestShellWin.cpp:
(TestShell::waitTestFinished):
* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/WebTransformationMatrixTest.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShellWin.cpp
trunk/Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (123006 => 123007)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 20:09:57 UTC (rev 123006)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 20:21:34 UTC (rev 123007)
@@ -1,5 +1,12 @@
 2012-07-18  Tony Chang  t...@chromium.org
 
+[chromium] Unreviewed, more compile fixes on Chromium Win.
+
+* tests/WebTransformationMatrixTest.cpp:
+(WebKit::TEST):
+
+2012-07-18  Tony Chang  t...@chromium.org
+
 [chromium] Fix compile on Windows.
 
 148tests\LayerChromiumTest.cpp(510): warning C4305: 'argument' : truncation from 'double' to 'float'


Modified: trunk/Source/WebKit/chromium/tests/WebTransformationMatrixTest.cpp (123006 => 123007)

--- trunk/Source/WebKit/chromium/tests/WebTransformationMatrixTest.cpp	2012-07-18 20:09:57 UTC (rev 123006)
+++ trunk/Source/WebKit/chromium/tests/WebTransformationMatrixTest.cpp	2012-07-18 20:21:34 UTC (rev 123007)
@@ -200,10 +200,10 @@
 EXPECT_TRUE(scale.isInvertible());
 
 WebTransformationMatrix inverseScale = scale.inverse();
-EXPECT_ROW1_EQ(0.25,  0,0,0, inverseScale);
-EXPECT_ROW2_EQ(0,0.1,   0,0, inverseScale);
-EXPECT_ROW3_EQ(0, 0,   0.01,  0, inverseScale);
-EXPECT_ROW4_EQ(0, 0,0,1, inverseScale);
+EXPECT_ROW1_EQ(0.25,   0,0, 0, inverseScale);
+EXPECT_ROW2_EQ(0,.1f,0, 0, inverseScale);
+EXPECT_ROW3_EQ(0,  0, .01f, 0, inverseScale);
+EXPECT_ROW4_EQ(0,  0,0, 1, inverseScale);
 
 // Try to invert a matrix that is not invertible.
 // The inverse() function should simply return an identity matrix.


Modified: trunk/Tools/ChangeLog (123006 => 123007)

--- trunk/Tools/ChangeLog	2012-07-18 20:09:57 UTC (rev 123006)
+++ trunk/Tools/ChangeLog	2012-07-18 20:21:34 UTC (rev 123007)
@@ -1,3 +1,11 @@
+2012-07-18  Tony Chang  t...@chromium.org
+
+[chromium] Unreviewed, more compile fixes on Chromium Win.
+
+* DumpRenderTree/chromium/TestShellWin.cpp:
+(TestShell::waitTestFinished):
+* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
+
 2012-07-18  Christophe Dumez  christophe.du...@intel.com
 
 [EFL] Add central error management to EFL port


Modified: trunk/Tools/DumpRenderTree/chromium/TestShellWin.cpp (123006 => 123007)

--- trunk/Tools/DumpRenderTree/chromium/TestShellWin.cpp	2012-07-18 20:09:57 UTC (rev 123006)
+++ trunk/Tools/DumpRenderTree/chromium/TestShellWin.cpp	2012-07-18 20:21:34 UTC (rev 123007)
@@ -78,7 +78,7 @@
 
 void TestShell::waitTestFinished()
 {
-DCHECK(!m_testIsPending)  cannot be used recursively;
+ASSERT(!m_testIsPending);
 
 m_testIsPending = true;
 
@@ -89,7 +89,7 @@
 // timeout, it can't do anything except terminate the test
 // shell, which is unfortunate.
 m_finishedEvent = CreateEvent(0, TRUE, FALSE, 0);
-DCHECK(m_finishedEvent);
+ASSERT(m_finishedEvent);
 
 HANDLE threadHandle = reinterpret_castHANDLE(_beginthreadex(
0,
@@ -98,7 +98,7 @@
this,
0,
0));
-DCHECK(threadHandle);
+ASSERT(threadHandle);
 
 // TestFinished() will post a quit message to break this loop when the page
 // finishes loading.


Modified: trunk/Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp (123006 => 123007)

--- trunk/Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp	2012-07-18 20:09:57 UTC (rev 123006)
+++ trunk/Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp	2012-07-18 20:21:34 UTC (rev 123007)
@@ -43,6 +43,7 @@
 #include third_party/skia/include/core/SkPath.h
 #include third_party/skia/include/core/SkRect.h
 
+#include algorithm
 #include wtf/Assertions.h
 
 using namespace std;
@@ -74,8 +75,8 @@
 // The maximum width and height is 13.
 // Center the square in the passed rectangle.
 const int maxControlSize = 13;
-int controlSize = min(rect.width(), rect.height());
-controlSize = min(controlSize, maxControlSize);
+int controlSize = std::min(rect.width(), rect.height());
+controlSize = std::min(controlSize, 

[webkit-changes] [123008] trunk/Source

[msaboff]

Title: [123008] trunk/Source








Revision 123008
Author msab...@apple.com
Date 2012-07-18 13:22:43 -0700 (Wed, 18 Jul 2012)


Log Message
Make TextCodecLatin1 handle 8 bit data without converting to UChar's
https://bugs.webkit.org/show_bug.cgi?id=90319

Reviewed by Oliver Hunt.

Source/WebCore: 

Updated codec to create 8 bit strings where possible.
We assume that the incoming stream can all be decoded as 8-bit values.
If we find a 16-bit value, we take the already decoded data and
copy / convert it to a 16-bit buffer and then continue process the rest
of the stream as 16-bits.

No new tests, functionality covered with existing tests.

* platform/text/TextCodecASCIIFastPath.h:
(WebCore::copyASCIIMachineWord):
* platform/text/TextCodecLatin1.cpp:
(WebCore::TextCodecLatin1::decode):

Source/WTF: 

* wtf/text/StringImpl.h:
(StringImpl): Exported LChar variant of adopt().
* wtf/text/WTFString.h:
(WTF::String::createUninitialized): Exported LChar variant.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WTF/wtf/text/WTFString.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/TextCodecASCIIFastPath.h
trunk/Source/WebCore/platform/text/TextCodecLatin1.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (123007 => 123008)

--- trunk/Source/WTF/ChangeLog	2012-07-18 20:21:34 UTC (rev 123007)
+++ trunk/Source/WTF/ChangeLog	2012-07-18 20:22:43 UTC (rev 123008)
@@ -1,3 +1,15 @@
+2012-07-18  Michael Saboff  msab...@apple.com
+
+Make TextCodecLatin1 handle 8 bit data without converting to UChar's
+https://bugs.webkit.org/show_bug.cgi?id=90319
+
+Reviewed by Oliver Hunt.
+
+* wtf/text/StringImpl.h:
+(StringImpl): Exported LChar variant of adopt().
+* wtf/text/WTFString.h:
+(WTF::String::createUninitialized): Exported LChar variant.
+
 2012-07-18  Rob Buis  rb...@rim.com
 
 Alignment crash in MIMESniffer


Modified: trunk/Source/WTF/wtf/text/StringImpl.h (123007 => 123008)

--- trunk/Source/WTF/wtf/text/StringImpl.h	2012-07-18 20:21:34 UTC (rev 123007)
+++ trunk/Source/WTF/wtf/text/StringImpl.h	2012-07-18 20:22:43 UTC (rev 123008)
@@ -282,7 +282,7 @@
 return adoptRef(new StringImpl(rep-m_data16 + offset, length, ownerRep));
 }
 
-static PassRefPtrStringImpl createUninitialized(unsigned length, LChar* data);
+WTF_EXPORT_PRIVATE static PassRefPtrStringImpl createUninitialized(unsigned length, LChar* data);
 WTF_EXPORT_PRIVATE static PassRefPtrStringImpl createUninitialized(unsigned length, UChar* data);
 template typename T static ALWAYS_INLINE PassRefPtrStringImpl tryCreateUninitialized(unsigned length, T* output)
 {
@@ -336,8 +336,8 @@
 return empty();
 }
 
-static PassRefPtrStringImpl adopt(StringBufferLChar buffer);
-WTF_EXPORT_PRIVATE static PassRefPtrStringImpl adopt(StringBufferUChar buffer);
+WTF_EXPORT_PRIVATE static PassRefPtrStringImpl adopt(StringBufferUChar);
+WTF_EXPORT_PRIVATE static PassRefPtrStringImpl adopt(StringBufferLChar);
 
 #if PLATFORM(QT)  HAVE(QT5)
 static PassRefPtrStringImpl adopt(QStringData*);


Modified: trunk/Source/WTF/wtf/text/WTFString.h (123007 => 123008)

--- trunk/Source/WTF/wtf/text/WTFString.h	2012-07-18 20:21:34 UTC (rev 123007)
+++ trunk/Source/WTF/wtf/text/WTFString.h	2012-07-18 20:22:43 UTC (rev 123008)
@@ -321,6 +321,7 @@
 // into the buffer returned in data before the returned string is used.
 // Failure to do this will have unpredictable results.
 static String createUninitialized(unsigned length, UChar* data) { return StringImpl::createUninitialized(length, data); }
+static String createUninitialized(unsigned length, LChar* data) { return StringImpl::createUninitialized(length, data); }
 
 WTF_EXPORT_PRIVATE void split(const String separator, VectorString result) const;
 WTF_EXPORT_PRIVATE void split(const String separator, bool allowEmptyEntries, VectorString result) const;


Modified: trunk/Source/WebCore/ChangeLog (123007 => 123008)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 20:21:34 UTC (rev 123007)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 20:22:43 UTC (rev 123008)
@@ -1,3 +1,23 @@
+2012-07-18  Michael Saboff  msab...@apple.com
+
+Make TextCodecLatin1 handle 8 bit data without converting to UChar's
+https://bugs.webkit.org/show_bug.cgi?id=90319
+
+Reviewed by Oliver Hunt.
+
+Updated codec to create 8 bit strings where possible.
+We assume that the incoming stream can all be decoded as 8-bit values.
+If we find a 16-bit value, we take the already decoded data and
+copy / convert it to a 16-bit buffer and then continue process the rest
+of the stream as 16-bits.
+
+No new tests, functionality covered with existing tests.
+
+* platform/text/TextCodecASCIIFastPath.h:
+(WebCore::copyASCIIMachineWord):
+* platform/text/TextCodecLatin1.cpp:
+

[webkit-changes] [123009] trunk/Source

[commit-queue]

Title: [123009] trunk/Source








Revision 123009
Author commit-qu...@webkit.org
Date 2012-07-18 13:25:11 -0700 (Wed, 18 Jul 2012)


Log Message
Chromium Mac: Add TEXTURE_RECTANGLE_ARB support to CCVideoLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=91169

Patch by Sailesh Agrawal s...@chromium.org on 2012-07-18
Reviewed by Adrienne Walker.

Source/Platform:

Added a orientation field to WebCompositorIOSurfaceQuad. This is used at draw time to flip the texture if necessary.

* chromium/public/WebCompositorIOSurfaceQuad.h: Added orientation field to the constructor.
(WebKit::WebCompositorIOSurfaceQuad::orientation):
(WebCompositorIOSurfaceQuad): The new orientation field should be set to Flipped if the texture should be flipped when drawing.

Source/WebCore:

This extends CCVideoLayerImpl to support TEXTURE_RECTANGLE_ARB. This texture target is used by the Mac hardware accelerated video decoder.

No new tests (HW video decode on Mac is being tested manually.).

* platform/chromium/support/WebCompositorIOSurfaceQuad.cpp:
(WebKit::WebCompositorIOSurfaceQuad::create): Added an orientation argument.
(WebKit::WebCompositorIOSurfaceQuad::WebCompositorIOSurfaceQuad): Added an orientation argument.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawIOSurfaceQuad): Added support for non-flipped IOSurface textures.
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium): Changed TextureIOSurfaceProgram to be non-flipped. To draw flipped textures drawIOSurfaceQuad sets a different value for texTransformLocation.
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::appendQuads): Updated call to CCIOSurfaceDrawQuad constructor.
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads): Added support for drawing TEXTURE_RECTANGLE_ARB textures.

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebCompositorIOSurfaceQuad.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/support/WebCompositorIOSurfaceQuad.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (123008 => 123009)

--- trunk/Source/Platform/ChangeLog	2012-07-18 20:22:43 UTC (rev 123008)
+++ trunk/Source/Platform/ChangeLog	2012-07-18 20:25:11 UTC (rev 123009)
@@ -1,3 +1,16 @@
+2012-07-18  Sailesh Agrawal  s...@chromium.org
+
+Chromium Mac: Add TEXTURE_RECTANGLE_ARB support to CCVideoLayerImpl
+https://bugs.webkit.org/show_bug.cgi?id=91169
+
+Reviewed by Adrienne Walker.
+
+Added a orientation field to WebCompositorIOSurfaceQuad. This is used at draw time to flip the texture if necessary.
+
+* chromium/public/WebCompositorIOSurfaceQuad.h: Added orientation field to the constructor.
+(WebKit::WebCompositorIOSurfaceQuad::orientation):
+(WebCompositorIOSurfaceQuad): The new orientation field should be set to Flipped if the texture should be flipped when drawing.
+
 2012-07-13  Tony Payne  tpa...@chromium.org
 
 Remove Widget from screenColorProfile


Modified: trunk/Source/Platform/chromium/public/WebCompositorIOSurfaceQuad.h (123008 => 123009)

--- trunk/Source/Platform/chromium/public/WebCompositorIOSurfaceQuad.h	2012-07-18 20:22:43 UTC (rev 123008)
+++ trunk/Source/Platform/chromium/public/WebCompositorIOSurfaceQuad.h	2012-07-18 20:25:11 UTC (rev 123009)
@@ -37,20 +37,27 @@
 class WebCompositorIOSurfaceQuad : public WebCompositorQuad {
 public:
 #if WEBKIT_IMPLEMENTATION
-static PassOwnPtrWebCompositorIOSurfaceQuad create(const WebCompositorSharedQuadState*, const WebCore::IntRect, const WebCore::IntSize ioSurfaceSize, unsigned ioSurfaceTextureId);
+enum Orientation {
+  Flipped,
+  Unflipped
+};
 
+static PassOwnPtrWebCompositorIOSurfaceQuad create(const WebCompositorSharedQuadState*, const WebCore::IntRect, const WebCore::IntSize ioSurfaceSize, unsigned ioSurfaceTextureId, Orientation);
+
 WebCore::IntSize ioSurfaceSize() const { return m_ioSurfaceSize; }
 unsigned ioSurfaceTextureId() const { return m_ioSurfaceTextureId; }
+Orientation orientation() const { return m_orientation; }
 #endif
 
 static const WebCompositorIOSurfaceQuad* materialCast(const WebCompositorQuad*);
 private:
 #if WEBKIT_IMPLEMENTATION
-WebCompositorIOSurfaceQuad(const WebCompositorSharedQuadState*, const WebCore::IntRect, const WebCore::IntSize ioSurfaceSize, unsigned ioSurfaceTextureId);
+WebCompositorIOSurfaceQuad(const WebCompositorSharedQuadState*, const WebCore::IntRect, const WebCore::IntSize ioSurfaceSize, unsigned ioSurfaceTextureId, Orientation);
 #endif
 
 WebSize 

[webkit-changes] [123010] trunk/Source/WebKit2

[commit-queue]

Title: [123010] trunk/Source/WebKit2








Revision 123010
Author commit-qu...@webkit.org
Date 2012-07-18 13:27:23 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL][WK2] ewk_cookie_manager_persistent_storage_set is not exported
https://bugs.webkit.org/show_bug.cgi?id=91647

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-18
Reviewed by Gustavo Noronha Silva.

Properly export ewk_cookie_manager_persistent_storage_set in
ewk_cookie_manager.h by using EAPI.

* UIProcess/API/efl/ewk_cookie_manager.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (123009 => 123010)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 20:25:11 UTC (rev 123009)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 20:27:23 UTC (rev 123010)
@@ -1,5 +1,17 @@
 2012-07-18  Christophe Dumez  christophe.du...@intel.com
 
+[EFL][WK2] ewk_cookie_manager_persistent_storage_set is not exported
+https://bugs.webkit.org/show_bug.cgi?id=91647
+
+Reviewed by Gustavo Noronha Silva.
+
+Properly export ewk_cookie_manager_persistent_storage_set in
+ewk_cookie_manager.h by using EAPI.
+
+* UIProcess/API/efl/ewk_cookie_manager.h:
+
+2012-07-18  Christophe Dumez  christophe.du...@intel.com
+
 [EFL] Add central error management to EFL port
 https://bugs.webkit.org/show_bug.cgi?id=91598
 


Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.h (123009 => 123010)

--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.h	2012-07-18 20:25:11 UTC (rev 123009)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.h	2012-07-18 20:27:23 UTC (rev 123010)
@@ -102,7 +102,7 @@
  * @param filename the filename to read to/write from.
  * @param storage the type of storage.
  */
-void ewk_cookie_manager_persistent_storage_set(Ewk_Cookie_Manager *manager, const char *filename, Ewk_Cookie_Persistent_Storage storage);
+EAPI void ewk_cookie_manager_persistent_storage_set(Ewk_Cookie_Manager *manager, const char *filename, Ewk_Cookie_Persistent_Storage storage);
 
 /**
  * Set @a policy as the cookie acceptance policy for @a manager.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123011] trunk/Source/WebCore

[msaboff]

Title: [123011] trunk/Source/WebCore








Revision 123011
Author msab...@apple.com
Date 2012-07-18 13:28:39 -0700 (Wed, 18 Jul 2012)


Log Message
Make TextCodecUTF8 handle 8 bit data without converting to UChar's
https://bugs.webkit.org/show_bug.cgi?id=90320

Reviewed by Oliver Hunt.

Change UTF8 Codec to produce 8-bit strings when data fits in 8-bit range.
First we try decoding the string as all 8-bit and then fall back to 16 bit
when we find the first character that doesn't fit in 8 bits.  Then we take
the already decoded data and copy / convert it to a 16-bit buffer and then
continue process the rest of the stream as 16-bits.

No new tests, no change in functionality.

* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::handleError):
(WebCore::TextCodecUTF8::decode):
* platform/text/TextCodecUTF8.h:
(TextCodecUTF8):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp
trunk/Source/WebCore/platform/text/TextCodecUTF8.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (123010 => 123011)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 20:27:23 UTC (rev 123010)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 20:28:39 UTC (rev 123011)
@@ -1,3 +1,24 @@
+2012-07-18  Michael Saboff  msab...@apple.com
+
+Make TextCodecUTF8 handle 8 bit data without converting to UChar's
+https://bugs.webkit.org/show_bug.cgi?id=90320
+
+Reviewed by Oliver Hunt.
+
+Change UTF8 Codec to produce 8-bit strings when data fits in 8-bit range.
+First we try decoding the string as all 8-bit and then fall back to 16 bit
+when we find the first character that doesn't fit in 8 bits.  Then we take
+the already decoded data and copy / convert it to a 16-bit buffer and then
+continue process the rest of the stream as 16-bits.
+
+No new tests, no change in functionality.
+
+* platform/text/TextCodecUTF8.cpp:
+(WebCore::TextCodecUTF8::handleError):
+(WebCore::TextCodecUTF8::decode):
+* platform/text/TextCodecUTF8.h:
+(TextCodecUTF8):
+
 2012-07-18  Sailesh Agrawal  s...@chromium.org
 
 Chromium Mac: Add TEXTURE_RECTANGLE_ARB support to CCVideoLayerImpl


Modified: trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp (123010 => 123011)

--- trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp	2012-07-18 20:27:23 UTC (rev 123010)
+++ trunk/Source/WebCore/platform/text/TextCodecUTF8.cpp	2012-07-18 20:28:39 UTC (rev 123011)
@@ -167,7 +167,8 @@
 consumePartialSequenceByte();
 }
 
-void TextCodecUTF8::handlePartialSequence(UChar* destination, const uint8_t* source, const uint8_t* end, bool flush, bool stopOnError, bool sawError)
+template 
+bool TextCodecUTF8::handlePartialSequenceLChar(LChar* destination, const uint8_t* source, const uint8_t* end, bool flush, bool, bool)
 {
 ASSERT(m_partialSequenceSize);
 do {
@@ -177,10 +178,53 @@
 continue;
 }
 int count = nonASCIISequenceLength(m_partialSequence[0]);
+if (!count)
+return true;
+
+if (count  m_partialSequenceSize) {
+if (count - m_partialSequenceSize  end - source) {
+if (!flush) {
+// The new data is not enough to complete the sequence, so
+// add it to the existing partial sequence.
+memcpy(m_partialSequence + m_partialSequenceSize, source, end - source);
+m_partialSequenceSize += end - source;
+return false;
+}
+// An incomplete partial sequence at the end is an error, but it will create
+// a 16 bit string due to the replacementCharacter. Let the 16 bit path handle
+// the error.
+return true;
+}
+memcpy(m_partialSequence + m_partialSequenceSize, source, count - m_partialSequenceSize);
+source += count - m_partialSequenceSize;
+m_partialSequenceSize = count;
+}
+int character = decodeNonASCIISequence(m_partialSequence, count);
+if ((character == nonCharacter) || (character  0xff))
+return true;
+
+m_partialSequenceSize -= count;
+*destination++ = character;
+} while (m_partialSequenceSize);
+
+return false;
+}
+
+template 
+bool TextCodecUTF8::handlePartialSequenceUChar(UChar* destination, const uint8_t* source, const uint8_t* end, bool flush, bool stopOnError, bool sawError)
+{
+ASSERT(m_partialSequenceSize);
+do {
+if (isASCII(m_partialSequence[0])) {
+*destination++ = m_partialSequence[0];
+consumePartialSequenceByte();
+continue;
+}
+int count = nonASCIISequenceLength(m_partialSequence[0]);
 if (!count) {
 handleError(destination, stopOnError, sawError);
 if (stopOnError)
-return;
+return false;

[webkit-changes] [123013] trunk/Source/WebCore

[oliver]

Title: [123013] trunk/Source/WebCore








Revision 123013
Author oli...@apple.com
Date 2012-07-18 13:43:40 -0700 (Wed, 18 Jul 2012)


Log Message
WebKit provides APIs that make it possible for JSC to attempt to initialise the heap without initialising threading
https://bugs.webkit.org/show_bug.cgi?id=91663

Reviewed by Filip Pizlo.

Initialising a JSGlobalData now requires us to have initialised JSC's threading
logic, as that also initialises the JSC VM runtime options.  WebKit provides a
number of routines that make use of commonJSGlobalData() that can be used before
webcore has called the appropriate initialisation routine.  This patch makes the
minimal change of ensuring that commonJSGlobalData initialises threading before
attempting to create the common heap.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonJSGlobalData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123012 => 123013)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 20:40:30 UTC (rev 123012)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 20:43:40 UTC (rev 123013)
@@ -1,3 +1,20 @@
+2012-07-18  Oliver Hunt  oli...@apple.com
+
+WebKit provides APIs that make it possible for JSC to attempt to initialise the heap without initialising threading
+https://bugs.webkit.org/show_bug.cgi?id=91663
+
+Reviewed by Filip Pizlo.
+
+Initialising a JSGlobalData now requires us to have initialised JSC's threading
+logic, as that also initialises the JSC VM runtime options.  WebKit provides a
+number of routines that make use of commonJSGlobalData() that can be used before
+webcore has called the appropriate initialisation routine.  This patch makes the
+minimal change of ensuring that commonJSGlobalData initialises threading before
+attempting to create the common heap.
+
+* bindings/js/JSDOMWindowBase.cpp:
+(WebCore::JSDOMWindowBase::commonJSGlobalData):
+
 2012-07-18  Michael Saboff  msab...@apple.com
 
 Make TextCodecUTF8 handle 8 bit data without converting to UChar's


Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp (123012 => 123013)

--- trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp	2012-07-18 20:40:30 UTC (rev 123012)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp	2012-07-18 20:43:40 UTC (rev 123013)
@@ -32,6 +32,7 @@
 #include JSNode.h
 #include Logging.h
 #include Page.h
+#include ScriptController.h
 #include SecurityOrigin.h
 #include Settings.h
 #include WebCoreJSClientData.h
@@ -208,6 +209,7 @@
 
 static JSGlobalData* globalData = 0;
 if (!globalData) {
+ScriptController::initializeThreading();
 globalData = JSGlobalData::createLeaked(ThreadStackTypeLarge, LargeHeap).leakRef();
 globalData-timeoutChecker.setTimeoutInterval(1); // 10 seconds
 #ifndef NDEBUG






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123014] trunk/Source

[pilgrim]

Title: [123014] trunk/Source








Revision 123014
Author pilg...@chromium.org
Date 2012-07-18 13:51:30 -0700 (Wed, 18 Jul 2012)


Log Message
[Chromium] Call SQLiteFileSystem-related functions directly
https://bugs.webkit.org/show_bug.cgi?id=91631

Reviewed by Adam Barth.

Source/Platform:

Part of a refactoring series. See tracking bug 82948.

* chromium/public/Platform.h:
(Platform):
(WebKit::Platform::databaseOpenFile):
(WebKit::Platform::databaseDeleteFile):
(WebKit::Platform::databaseGetFileAttributes):
(WebKit::Platform::databaseGetFileSize):
(WebKit::Platform::databaseGetSpaceAvailableForOrigin):

Source/WebCore:

Part of a refactoring series. See tracking bug 82948.

* Modules/webdatabase/chromium/QuotaTracker.cpp:
(WebCore::QuotaTracker::getDatabaseSizeAndSpaceAvailableToOrigin):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::getDatabaseFileSize):
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport):
* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/chromium/QuotaTracker.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromium.cpp
trunk/Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp
trunk/Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (123013 => 123014)

--- trunk/Source/Platform/ChangeLog	2012-07-18 20:43:40 UTC (rev 123013)
+++ trunk/Source/Platform/ChangeLog	2012-07-18 20:51:30 UTC (rev 123014)
@@ -1,3 +1,20 @@
+2012-07-18  Mark Pilgrim  pilg...@chromium.org
+
+[Chromium] Call SQLiteFileSystem-related functions directly
+https://bugs.webkit.org/show_bug.cgi?id=91631
+
+Reviewed by Adam Barth.
+
+Part of a refactoring series. See tracking bug 82948.
+
+* chromium/public/Platform.h:
+(Platform):
+(WebKit::Platform::databaseOpenFile):
+(WebKit::Platform::databaseDeleteFile):
+(WebKit::Platform::databaseGetFileAttributes):
+(WebKit::Platform::databaseGetFileSize):
+(WebKit::Platform::databaseGetSpaceAvailableForOrigin):
+
 2012-07-18  Sailesh Agrawal  s...@chromium.org
 
 Chromium Mac: Add TEXTURE_RECTANGLE_ARB support to CCVideoLayerImpl


Modified: trunk/Source/Platform/chromium/public/Platform.h (123013 => 123014)

--- trunk/Source/Platform/chromium/public/Platform.h	2012-07-18 20:43:40 UTC (rev 123013)
+++ trunk/Source/Platform/chromium/public/Platform.h	2012-07-18 20:51:30 UTC (rev 123014)
@@ -68,6 +68,14 @@
 
 class Platform {
 public:
+// HTML5 Database --
+
+#ifdef WIN32
+typedef HANDLE FileHandle;
+#else
+typedef int FileHandle;
+#endif
+
 WEBKIT_EXPORT static void initialize(Platform*);
 WEBKIT_EXPORT static void shutdown();
 WEBKIT_EXPORT static Platform* current();
@@ -104,6 +112,25 @@
 virtual WebBlobRegistry* blobRegistry() { return 0; }
 
 
+// Database 
+
+// Opens a database file; dirHandle should be 0 if the caller does not need
+// a handle to the directory containing this file
+virtual FileHandle databaseOpenFile(const WebString vfsFileName, int desiredFlags) { return FileHandle(); }
+
+// Deletes a database file and returns the error code
+virtual int databaseDeleteFile(const WebString vfsFileName, bool syncDir) { return 0; }
+
+// Returns the attributes of the given database file
+virtual long databaseGetFileAttributes(const WebString vfsFileName) { return 0; }
+
+// Returns the size of the given database file
+virtual long long databaseGetFileSize(const WebString vfsFileName) { return 0; }
+
+// Returns the space available for the given origin
+virtual long long databaseGetSpaceAvailableForOrigin(const WebKit::WebString originIdentifier) { return 0; }
+
+
 // DOM Storage --
 
 // Return a LocalStorage namespace that corresponds to the following path.


Modified: trunk/Source/WebCore/ChangeLog (123013 => 123014)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 20:43:40 UTC (rev 123013)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 20:51:30 UTC (rev 123014)
@@ -1,3 +1,22 @@
+2012-07-18  Mark Pilgrim  

[webkit-changes] [123015] trunk/LayoutTests

[rniwa]

Title: [123015] trunk/LayoutTests








Revision 123015
Author rn...@webkit.org
Date 2012-07-18 14:13:03 -0700 (Wed, 18 Jul 2012)


Log Message
Update Chromium test expectations after filing the bug 91666.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123014 => 123015)

--- trunk/LayoutTests/ChangeLog	2012-07-18 20:51:30 UTC (rev 123014)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 21:13:03 UTC (rev 123015)
@@ -1,3 +1,9 @@
+2012-07-18  Ryosuke Niwa  rn...@webkit.org
+
+Update Chromium test expectations after filing the bug 91666.
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Alpha Lam  hc...@chromium.org
 
 [chromium] Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123014 => 123015)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 20:51:30 UTC (rev 123014)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 21:13:03 UTC (rev 123015)
@@ -74,10 +74,10 @@
 BUGWK79679 DEBUG SLOW : platform/chromium/virtual/gpu/fast/canvas/getPutImageDataPairTest.html = PASS
 
 BUGWK82097 SLOW : editing/selection/move-by-word-visually-crash-test-5.html = PASS
-BUGRNIWA SLOW MAC : editing/pasteboard/emacs-cntl-y-001.html = IMAGE
-BUGRNIWA SLOW MAC : editing/pasteboard/emacs-ctrl-a-k-y.html = IMAGE+TEXT
-BUGRNIWA SLOW MAC : editing/pasteboard/emacs-ctrl-k-y-001.html = IMAGE+TEXT
-BUGRNIWA SLOW MAC : editing/input/emacs-ctrl-o.html = IMAGE+TEXT
+BUGWK91666 SLOW MAC : editing/pasteboard/emacs-cntl-y-001.html = IMAGE
+BUGWK91666 SLOW MAC : editing/pasteboard/emacs-ctrl-a-k-y.html = IMAGE+TEXT
+BUGWK91666 SLOW MAC : editing/pasteboard/emacs-ctrl-k-y-001.html = IMAGE+TEXT
+BUGWK91666 SLOW MAC : editing/input/emacs-ctrl-o.html = IMAGE+TEXT
 
 // -
 // TEMPORARILY SKIPPED TESTS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123016] trunk/Source/WebKit2

[commit-queue]

Title: [123016] trunk/Source/WebKit2








Revision 123016
Author commit-qu...@webkit.org
Date 2012-07-18 14:22:00 -0700 (Wed, 18 Jul 2012)


Log Message
[WK2] Add C API for Network Information API
https://bugs.webkit.org/show_bug.cgi?id=90762

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

Add C API for WKNetworkInfo and WKNetworkInfoManager
so that they can be used by the client.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* UIProcess/API/C/WKContext.cpp:
(WKContextGetNetworkInfoManager):
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKNetworkInfo.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp.
(WKNetworkInfoGetTypeID):
(WKNetworkInfoCreate):
* UIProcess/API/C/WKNetworkInfo.h: Copied from Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp.
* UIProcess/API/C/WKNetworkInfoManager.cpp:
(WKNetworkInfoManagerSetProvider):
(WKNetworkInfoManagerProviderDidChangeNetworkInformation):
* UIProcess/API/C/WKNetworkInfoManager.h:

Modified Paths

trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.list.am
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h
trunk/Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/C/WKNetworkInfo.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKNetworkInfo.h




Diff

Modified: trunk/Source/WebKit2/CMakeLists.txt (123015 => 123016)

--- trunk/Source/WebKit2/CMakeLists.txt	2012-07-18 21:13:03 UTC (rev 123015)
+++ trunk/Source/WebKit2/CMakeLists.txt	2012-07-18 21:22:00 UTC (rev 123016)
@@ -298,6 +298,7 @@
 UIProcess/API/C/WKKeyValueStorageManager.cpp
 UIProcess/API/C/WKMediaCacheManager.cpp
 UIProcess/API/C/WKNavigationData.cpp
+UIProcess/API/C/WKNetworkInfo.cpp
 UIProcess/API/C/WKNetworkInfoManager.cpp
 UIProcess/API/C/WKNotification.cpp
 UIProcess/API/C/WKNotificationManager.cpp


Modified: trunk/Source/WebKit2/ChangeLog (123015 => 123016)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 21:13:03 UTC (rev 123015)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 21:22:00 UTC (rev 123016)
@@ -1,5 +1,30 @@
 2012-07-18  Christophe Dumez  christophe.du...@intel.com
 
+[WK2] Add C API for Network Information API
+https://bugs.webkit.org/show_bug.cgi?id=90762
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add C API for WKNetworkInfo and WKNetworkInfoManager
+so that they can be used by the client.
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* Target.pri:
+* UIProcess/API/C/WKContext.cpp:
+(WKContextGetNetworkInfoManager):
+* UIProcess/API/C/WKContext.h:
+* UIProcess/API/C/WKNetworkInfo.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp.
+(WKNetworkInfoGetTypeID):
+(WKNetworkInfoCreate):
+* UIProcess/API/C/WKNetworkInfo.h: Copied from Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp.
+* UIProcess/API/C/WKNetworkInfoManager.cpp:
+(WKNetworkInfoManagerSetProvider):
+(WKNetworkInfoManagerProviderDidChangeNetworkInformation):
+* UIProcess/API/C/WKNetworkInfoManager.h:
+
+2012-07-18  Christophe Dumez  christophe.du...@intel.com
+
 [EFL][WK2] ewk_cookie_manager_persistent_storage_set is not exported
 https://bugs.webkit.org/show_bug.cgi?id=91647
 


Modified: trunk/Source/WebKit2/GNUmakefile.list.am (123015 => 123016)

--- trunk/Source/WebKit2/GNUmakefile.list.am	2012-07-18 21:13:03 UTC (rev 123015)
+++ trunk/Source/WebKit2/GNUmakefile.list.am	2012-07-18 21:22:00 UTC (rev 123016)
@@ -71,6 +71,7 @@
 	$(WebKit2)/UIProcess/API/C/WKMediaCacheManager.h \
 	$(WebKit2)/UIProcess/API/C/WKNativeEvent.h \
 	$(WebKit2)/UIProcess/API/C/WKNavigationData.h \
+	$(WebKit2)/UIProcess/API/C/WKNetworkInfo.h \
 	$(WebKit2)/UIProcess/API/C/WKNetworkInfoManager.h \
 	$(WebKit2)/UIProcess/API/C/WKNotification.h \
 	$(WebKit2)/UIProcess/API/C/WKNotificationManager.h \
@@ -572,6 +573,8 @@
 	Source/WebKit2/UIProcess/API/C/WKNativeEvent.h \
 	Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp \
 	Source/WebKit2/UIProcess/API/C/WKNavigationData.h \
+	Source/WebKit2/UIProcess/API/C/WKNetworkInfo.cpp \
+	Source/WebKit2/UIProcess/API/C/WKNetworkInfo.h \
 	Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.cpp \
 	Source/WebKit2/UIProcess/API/C/WKNetworkInfoManager.h \
 	Source/WebKit2/UIProcess/API/C/WKNotification.cpp \


Modified: trunk/Source/WebKit2/Target.pri (123015 => 123016)

--- trunk/Source/WebKit2/Target.pri	2012-07-18 21:13:03 UTC (rev 123015)
+++ trunk/Source/WebKit2/Target.pri	2012-07-18 21:22:00 UTC (rev 123016)
@@ -167,6 +167,7 @@
 UIProcess/API/C/WKOpenPanelParameters.h \
 UIProcess/API/C/WKOpenPanelResultListener.h \
 

[webkit-changes] [123017] trunk/Source/WebKit/chromium

[tony]

Title: [123017] trunk/Source/WebKit/chromium








Revision 123017
Author t...@chromium.org
Date 2012-07-18 14:26:36 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Unreviewed, fix some MSVC compile warnings.

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp
trunk/Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (123016 => 123017)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 21:22:00 UTC (rev 123016)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-18 21:26:36 UTC (rev 123017)
@@ -1,3 +1,12 @@
+2012-07-18  Tony Chang  t...@chromium.org
+
+[chromium] Unreviewed, fix some MSVC compile warnings.
+
+* tests/CCDamageTrackerTest.cpp:
+(WebKitTests::TEST_F):
+* tests/CCLayerTreeHostCommonTest.cpp:
+* tests/TiledLayerChromiumTest.cpp:
+
 2012-07-18  Mark Pilgrim  pilg...@chromium.org
 
 [Chromium] Call SQLiteFileSystem-related functions directly


Modified: trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp (123016 => 123017)

--- trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp	2012-07-18 21:22:00 UTC (rev 123016)
+++ trunk/Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp	2012-07-18 21:26:36 UTC (rev 123017)
@@ -634,8 +634,8 @@
 // - child1 surface damage in root surface space: FloatRect(300, 300, 6, 8);
 // - child2 damage in root surface space: FloatRect(11, 11, 18, 18);
 clearDamageForAllSurfaces(root.get());
-grandChild1-setOpacity(0.7);
-child2-setOpacity(0.7);
+grandChild1-setOpacity(0.7f);
+child2-setOpacity(0.7f);
 emulateDrawingOneFrame(root.get());
 childDamageRect = child1-renderSurface()-damageTracker()-currentDamageRect();
 rootDamageRect = root-renderSurface()-damageTracker()-currentDamageRect();


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp (123016 => 123017)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp	2012-07-18 21:22:00 UTC (rev 123016)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp	2012-07-18 21:26:36 UTC (rev 123017)
@@ -200,7 +200,7 @@
 // Case 4: A change in actual position affects both the draw transform and screen space transform.
 WebTransformationMatrix positionTransform;
 positionTransform.translate(0, 1.2);
-setLayerPropertiesForTesting(layer.get(), identityMatrix, identityMatrix, FloatPoint(0.25, 0.25), FloatPoint(0, 1.2), IntSize(10, 12), false);
+setLayerPropertiesForTesting(layer.get(), identityMatrix, identityMatrix, FloatPoint(0.25, 0.25), FloatPoint(0, 1.2f), IntSize(10, 12), false);
 executeCalculateDrawTransformsAndVisibility(layer.get());
 EXPECT_TRANSFORMATION_MATRIX_EQ(positionTransform * translationToCenter, layer-drawTransform());
 EXPECT_TRANSFORMATION_MATRIX_EQ(positionTransform, layer-screenSpaceTransform());
@@ -227,7 +227,7 @@
 // The current implementation of calculateDrawTransforms does this implicitly, but it is
 // still worth testing to detect accidental regressions.
 expectedResult = positionTransform * translationToAnchor * layerTransform * translationToAnchor.inverse();
-setLayerPropertiesForTesting(layer.get(), layerTransform, identityMatrix, FloatPoint(0.5, 0), FloatPoint(0, 1.2), IntSize(10, 12), false);
+setLayerPropertiesForTesting(layer.get(), layerTransform, identityMatrix, FloatPoint(0.5, 0), FloatPoint(0, 1.2f), IntSize(10, 12), false);
 executeCalculateDrawTransformsAndVisibility(layer.get());
 EXPECT_TRANSFORMATION_MATRIX_EQ(expectedResult * translationToCenter, layer-drawTransform());
 EXPECT_TRANSFORMATION_MATRIX_EQ(expectedResult, layer-screenSpaceTransform());
@@ -259,7 +259,7 @@
 // Case 2: parent's position affects child and grandChild.
 WebTransformationMatrix parentPositionTransform;
 parentPositionTransform.translate(0, 1.2);
-setLayerPropertiesForTesting(parent.get(), identityMatrix, identityMatrix, FloatPoint(0.25, 0.25), FloatPoint(0, 1.2), IntSize(10, 12), false);
+setLayerPropertiesForTesting(parent.get(), identityMatrix, identityMatrix, FloatPoint(0.25, 0.25), FloatPoint(0, 1.2f), IntSize(10, 12), false);
 setLayerPropertiesForTesting(child.get(), identityMatrix, identityMatrix, FloatPoint(0, 0), FloatPoint(0, 0), IntSize(16, 18), false);
 setLayerPropertiesForTesting(grandChild.get(), identityMatrix, identityMatrix, FloatPoint(0, 0), FloatPoint(0, 0), IntSize(76, 78), false);
 executeCalculateDrawTransformsAndVisibility(parent.get());
@@ -1001,7 +1001,7 @@
 
 // In combination with descendantDrawsContent, opacity != 1 forces the layer to have a new renderSurface.
 

[webkit-changes] [123018] trunk/LayoutTests

[tony]

Title: [123018] trunk/LayoutTests








Revision 123018
Author t...@chromium.org
Date 2012-07-18 14:28:05 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed gardening.
http/tests/loading/307-after-303-after-post.html is flaky on win debug too.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123017 => 123018)

--- trunk/LayoutTests/ChangeLog	2012-07-18 21:26:36 UTC (rev 123017)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 21:28:05 UTC (rev 123018)
@@ -1,3 +1,10 @@
+2012-07-18  Tony Chang  t...@chromium.org
+
+Unreviewed gardening.
+http/tests/loading/307-after-303-after-post.html is flaky on win debug too.
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Ryosuke Niwa  rn...@webkit.org
 
 Update Chromium test expectations after filing the bug 91666.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123017 => 123018)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 21:26:36 UTC (rev 123017)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 21:28:05 UTC (rev 123018)
@@ -2778,7 +2778,7 @@
 // Failing after r94946
 BUGWK67926 WIN : fast/events/constructors/progress-event-constructor.html = TEXT
 
-BUGWK73030 MAC DEBUG : http/tests/loading/307-after-303-after-post.html = PASS TEXT
+BUGWK73030 WIN MAC DEBUG : http/tests/loading/307-after-303-after-post.html = PASS TEXT
 
 // Tests that are known to exhibit TEXT failures on Mac10.5 with Skia graphics.
 BUGWK68437 BUGWK54322 SNOWLEOPARD : platform/chromium/virtual/gpu/fast/canvas/set-colors.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123019] trunk/Source/WebKit2

[commit-queue]

Title: [123019] trunk/Source/WebKit2








Revision 123019
Author commit-qu...@webkit.org
Date 2012-07-18 14:31:34 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL][WK2] EFL should use DownloadSoup instead of defining DownloadEfl
https://bugs.webkit.org/show_bug.cgi?id=91602

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

Reuse WebProcess/Downloads/soup/DownloadSoup.cpp in EFL port
instead of redefining our own DownloadEfl.cpp. The EFL port
is also using libsoup so it is best to avoid code duplication.

* GNUmakefile.am:
* GNUmakefile.list.am:
* PlatformEfl.cmake:
* WebProcess/Downloads/Download.h:
(WebKit):
(Download):
* WebProcess/Downloads/efl/DownloadEfl.cpp: Removed.
* WebProcess/Downloads/efl/DownloadSoupErrorsEfl.cpp: Added.
(WebKit):
(WebKit::platformDownloadNetworkError):
(WebKit::platformDownloadDestinationError):
* WebProcess/Downloads/efl/FileDownloaderEfl.cpp: Removed.
* WebProcess/Downloads/efl/FileDownloaderEfl.h: Removed.
* WebProcess/Downloads/gtk/DownloadSoupErrorsGtk.cpp: Added.
(WebKit):
(WebKit::platformDownloadNetworkError):
(WebKit::platformDownloadDestinationError):
* WebProcess/Downloads/soup/DownloadSoup.cpp: Make the code
compile for other ports than GTK.
(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFail):
(WebKit::Download::continueWithoutCredential):
(WebKit):
(WebKit::Download::useCredential):
(WebKit::Download::cancelAuthenticationChallenge):
* WebProcess/Downloads/soup/DownloadSoupErrors.h: Added.
(WebKit):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/GNUmakefile.list.am
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/WebProcess/Downloads/Download.h
trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp


Added Paths

trunk/Source/WebKit2/WebProcess/Downloads/efl/DownloadSoupErrorsEfl.cpp
trunk/Source/WebKit2/WebProcess/Downloads/gtk/
trunk/Source/WebKit2/WebProcess/Downloads/gtk/DownloadSoupErrorsGtk.cpp
trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoupErrors.h


Removed Paths

trunk/Source/WebKit2/WebProcess/Downloads/efl/DownloadEfl.cpp
trunk/Source/WebKit2/WebProcess/Downloads/efl/FileDownloaderEfl.cpp
trunk/Source/WebKit2/WebProcess/Downloads/efl/FileDownloaderEfl.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (123018 => 123019)

--- trunk/Source/WebKit2/ChangeLog	2012-07-18 21:28:05 UTC (rev 123018)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-18 21:31:34 UTC (rev 123019)
@@ -1,5 +1,45 @@
 2012-07-18  Christophe Dumez  christophe.du...@intel.com
 
+[EFL][WK2] EFL should use DownloadSoup instead of defining DownloadEfl
+https://bugs.webkit.org/show_bug.cgi?id=91602
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Reuse WebProcess/Downloads/soup/DownloadSoup.cpp in EFL port
+instead of redefining our own DownloadEfl.cpp. The EFL port
+is also using libsoup so it is best to avoid code duplication.
+
+* GNUmakefile.am:
+* GNUmakefile.list.am:
+* PlatformEfl.cmake:
+* WebProcess/Downloads/Download.h:
+(WebKit):
+(Download):
+* WebProcess/Downloads/efl/DownloadEfl.cpp: Removed.
+* WebProcess/Downloads/efl/DownloadSoupErrorsEfl.cpp: Added.
+(WebKit):
+(WebKit::platformDownloadNetworkError):
+(WebKit::platformDownloadDestinationError):
+* WebProcess/Downloads/efl/FileDownloaderEfl.cpp: Removed.
+* WebProcess/Downloads/efl/FileDownloaderEfl.h: Removed.
+* WebProcess/Downloads/gtk/DownloadSoupErrorsGtk.cpp: Added.
+(WebKit):
+(WebKit::platformDownloadNetworkError):
+(WebKit::platformDownloadDestinationError):
+* WebProcess/Downloads/soup/DownloadSoup.cpp: Make the code
+compile for other ports than GTK.
+(WebKit::DownloadClient::didReceiveResponse):
+(WebKit::DownloadClient::didReceiveData):
+(WebKit::DownloadClient::didFail):
+(WebKit::Download::continueWithoutCredential):
+(WebKit):
+(WebKit::Download::useCredential):
+(WebKit::Download::cancelAuthenticationChallenge):
+* WebProcess/Downloads/soup/DownloadSoupErrors.h: Added.
+(WebKit):
+
+2012-07-18  Christophe Dumez  christophe.du...@intel.com
+
 [WK2] Add C API for Network Information API
 https://bugs.webkit.org/show_bug.cgi?id=90762
 


Modified: trunk/Source/WebKit2/GNUmakefile.am (123018 => 123019)

--- trunk/Source/WebKit2/GNUmakefile.am	2012-07-18 21:28:05 UTC (rev 123018)
+++ trunk/Source/WebKit2/GNUmakefile.am	2012-07-18 21:31:34 UTC (rev 123019)
@@ -63,6 +63,7 @@
 	-I$(srcdir)/Source/WebKit2/WebProcess/Battery \
 	-I$(srcdir)/Source/WebKit2/WebProcess/Cookies \
 	-I$(srcdir)/Source/WebKit2/WebProcess/Downloads \
+	-I$(srcdir)/Source/WebKit2/WebProcess/Downloads/soup \
 	

[webkit-changes] [123021] trunk/Tools

[kbalazs]

Title: [123021] trunk/Tools








Revision 123021
Author kbal...@webkit.org
Date 2012-07-18 14:36:29 -0700 (Wed, 18 Jul 2012)


Log Message
[Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=91514

Reviewed by Dirk Pranke.

Analyzing libQtWebKit.so is not enough in the case of force_static_libs_as_shared.
We need to analyze all the shared library or at least the WebCore one.

* Scripts/webkitdirs.pm:
(builtDylibPathForName):
In orwt it is hard coded to search for symbols in the WebCore library.
While in theory it is possible that symbols for a given feature are not
located in that, it doesn't happen in practice, so returning the path of
the WebCore library for a force_static_libs_as_shared build is enough to
fix the bug and it doesn't require a bigger refactoring. For a default
build we still return the path of the QtWebKit lib.
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._modules_to_search_for_symbols):
Enumerate all dynamic libraries, not just the QtWebKit one.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py




Diff

Modified: trunk/Tools/ChangeLog (123020 => 123021)

--- trunk/Tools/ChangeLog	2012-07-18 21:33:29 UTC (rev 123020)
+++ trunk/Tools/ChangeLog	2012-07-18 21:36:29 UTC (rev 123021)
@@ -1,3 +1,25 @@
+2012-07-18  Balazs Kelemen  kbal...@webkit.org
+
+[Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared
+https://bugs.webkit.org/show_bug.cgi?id=91514
+
+Reviewed by Dirk Pranke.
+
+Analyzing libQtWebKit.so is not enough in the case of force_static_libs_as_shared.
+We need to analyze all the shared library or at least the WebCore one.
+
+* Scripts/webkitdirs.pm:
+(builtDylibPathForName):
+In orwt it is hard coded to search for symbols in the WebCore library.
+While in theory it is possible that symbols for a given feature are not
+located in that, it doesn't happen in practice, so returning the path of
+the WebCore library for a force_static_libs_as_shared build is enough to
+fix the bug and it doesn't require a bigger refactoring. For a default
+build we still return the path of the QtWebKit lib.
+* Scripts/webkitpy/layout_tests/port/qt.py:
+(QtPort._modules_to_search_for_symbols):
+Enumerate all dynamic libraries, not just the QtWebKit one.
+
 2012-07-18  Tony Chang  t...@chromium.org
 
 [chromium] Unreviewed, more compile fixes on Chromium Win.


Modified: trunk/Tools/Scripts/webkitdirs.pm (123020 => 123021)

--- trunk/Tools/Scripts/webkitdirs.pm	2012-07-18 21:33:29 UTC (rev 123020)
+++ trunk/Tools/Scripts/webkitdirs.pm	2012-07-18 21:36:29 UTC (rev 123021)
@@ -721,11 +721,13 @@
 return $configurationProductDir/$libraryName/lib . lc($libraryName) . $libraryExtension;
 }
 if (isQt()) {
+my $isSearchingForWebCore = $libraryName =~ WebCore;
 $libraryName = QtWebKit;
+my $result;
 if (isDarwin() and -d $configurationProductDir/lib/$libraryName.framework) {
-return $configurationProductDir/lib/$libraryName.framework/$libraryName;
+$result = $configurationProductDir/lib/$libraryName.framework/$libraryName;
 } elsif (isDarwin() and -d $configurationProductDir/lib) {
-return $configurationProductDir/lib/lib$libraryName.dylib;
+$result = $configurationProductDir/lib/lib$libraryName.dylib;
 } elsif (isWindows()) {
 if (configuration() eq Debug) {
 # On Windows, there is a d suffix to the library name. See http://trac.webkit.org/changeset/53924/.
@@ -738,10 +740,23 @@
 if (not $qtMajorVersion) {
 $qtMajorVersion = ;
 }
-return $configurationProductDir/lib/$libraryName$qtMajorVersion.dll;
+
+$result = $configurationProductDir/lib/$libraryName$qtMajorVersion.dll;
 } else {
-return $configurationProductDir/lib/lib$libraryName.so;
+$result = $configurationProductDir/lib/lib$libraryName.so;
 }
+
+if ($isSearchingForWebCore) {
+# With CONFIG+=force_static_libs_as_shared we have a shared library for each subdir.
+# For feature detection to work it is necessary to return the path of the WebCore library here.
+my $replacedWithWebCore = $result;
+$replacedWithWebCore =~ s/$libraryName/WebCore/g;
+if (-e $replacedWithWebCore) {
+return $replacedWithWebCore;
+}
+}
+
+return $result;
 }
 if (isWx()) {
 return $configurationProductDir/libwxwebkit.dylib;


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py (123020 => 123021)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py	2012-07-18 21:33:29 UTC (rev 123020)
+++ 

[webkit-changes] [123022] trunk/LayoutTests

[tony]

Title: [123022] trunk/LayoutTests








Revision 123022
Author t...@chromium.org
Date 2012-07-18 14:38:55 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Unreviewed gardening.

svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg flakily crashes on Chromium Win.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123021 => 123022)

--- trunk/LayoutTests/ChangeLog	2012-07-18 21:36:29 UTC (rev 123021)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 21:38:55 UTC (rev 123022)
@@ -1,5 +1,13 @@
 2012-07-18  Tony Chang  t...@chromium.org
 
+[chromium] Unreviewed gardening.
+
+svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg flakily crashes on Chromium Win.
+
+* platform/chromium/TestExpectations:
+
+2012-07-18  Tony Chang  t...@chromium.org
+
 Unreviewed gardening.
 http/tests/loading/307-after-303-after-post.html is flaky on win debug too.
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123021 => 123022)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 21:36:29 UTC (rev 123021)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 21:38:55 UTC (rev 123022)
@@ -3701,3 +3701,5 @@
 
 // Needs rebaseline. Behavior should now be the same as Safari.
 BUGWK91472 : compositing/reflections/nested-reflection-anchor-point.html = IMAGE
+
+BUGWK91672 WIN : svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123024] trunk/LayoutTests

[kbr]

Title: [123024] trunk/LayoutTests








Revision 123024
Author k...@google.com
Date 2012-07-18 14:58:00 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed test expectations update. Added bug ID for fast/filesystem/file-writer-truncate-extend.html flakiness.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123023 => 123024)

--- trunk/LayoutTests/ChangeLog	2012-07-18 21:51:45 UTC (rev 123023)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 21:58:00 UTC (rev 123024)
@@ -1,3 +1,9 @@
+2012-07-18  Kenneth Russell  k...@google.com
+
+Unreviewed test expectations update. Added bug ID for fast/filesystem/file-writer-truncate-extend.html flakiness.
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Tony Chang  t...@chromium.org
 
 [chromium] Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123023 => 123024)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 21:51:45 UTC (rev 123023)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 21:58:00 UTC (rev 123024)
@@ -2559,7 +2559,7 @@
 BUGWK59673 : http/tests/history/cross-origin-replace-history-object-child.html = TIMEOUT
 
 // Flakiness on canaries (noted ~ r85140)
-BUGKBR WIN DEBUG : fast/filesystem/file-writer-truncate-extend.html = PASS TEXT
+BUGWK91673 WIN DEBUG : fast/filesystem/file-writer-truncate-extend.html = PASS TEXT
 BUGWK70886 DEBUG : fast/events/change-overflow-on-overflow-change.html = PASS TIMEOUT
 
 BUGWK60112 : fast/css/epub-properties.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123026] trunk/LayoutTests

[hclam]

Title: [123026] trunk/LayoutTests








Revision 123026
Author hc...@chromium.org
Date 2012-07-18 15:14:34 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Unreviewed gardening.

Updated test expectation for compositing/masks/layer-mask-placement.html.
Updated bug number for fast/js/mozilla/strict/assign-to-callee-name.html after filing webkit bug 91676.

Updated bug number for fast/url/ipv6.html after filing crbug.com/137938.

* platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Removed.
* platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png: Added.
* platform/chromium-win/compositing/masks/layer-mask-placement-expected.png: Added.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations


Added Paths

trunk/LayoutTests/platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png
trunk/LayoutTests/platform/chromium-win/compositing/masks/layer-mask-placement-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (123025 => 123026)

--- trunk/LayoutTests/ChangeLog	2012-07-18 22:06:34 UTC (rev 123025)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 22:14:34 UTC (rev 123026)
@@ -1,3 +1,17 @@
+2012-07-18  Alpha Lam  hc...@chromium.org
+
+[chromium] Unreviewed gardening.
+
+Updated test expectation for compositing/masks/layer-mask-placement.html.
+Updated bug number for fast/js/mozilla/strict/assign-to-callee-name.html after filing webkit bug 91676.
+
+Updated bug number for fast/url/ipv6.html after filing crbug.com/137938.
+
+* platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Removed.
+* platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png: Added.
+* platform/chromium-win/compositing/masks/layer-mask-placement-expected.png: Added.
+* platform/chromium/TestExpectations:
+
 2012-07-18  Kenneth Russell  k...@google.com
 
 Unreviewed test expectations update. Added bug ID for fast/filesystem/file-writer-truncate-extend.html flakiness.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123025 => 123026)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 22:06:34 UTC (rev 123025)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 22:14:34 UTC (rev 123026)
@@ -2568,14 +2568,11 @@
 
 BUGDPRANKE DEBUG : http/tests/misc/window-dot-stop.html = PASS TEXT
 
-// New test added in r85303.
-BUG_HCLAM : compositing/masks/layer-mask-placement.html = IMAGE
-
 // New test added in r85454. Actual failure.
-BUG_HCLAM : fast/js/mozilla/strict/assign-to-callee-name.html = TEXT
+BUGWK91676 : fast/js/mozilla/strict/assign-to-callee-name.html = TEXT
 
 // Failure introduced by Chromium r83848.
-BUG_HCLAM : fast/url/ipv6.html = TEXT
+BUG137938 : fast/url/ipv6.html = TEXT
 
 // New tests in r85961 and r86442
 BUGWK60414 WIN : platform/win/plugins/visibility-hidden.html = IMAGE+TEXT


Added: trunk/LayoutTests/platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/compositing/masks/layer-mask-placement-expected.png
___

Added: svn:mime-type

Deleted: trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png

(Binary files differ)


Added: trunk/LayoutTests/platform/chromium-win/compositing/masks/layer-mask-placement-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/compositing/masks/layer-mask-placement-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123027] trunk/Source/WTF

[tsepez]

Title: [123027] trunk/Source/WTF








Revision 123027
Author tse...@chromium.org
Date 2012-07-18 15:16:08 -0700 (Wed, 18 Jul 2012)


Log Message
OOB read of stack buffer below DoubleToStringConverter::CreateExponentialRepresentation() in debug builds
https://bugs.webkit.org/show_bug.cgi?id=91642

Reviewed by Abhishek Arya.

* wtf/dtoa/double-conversion.cc:
(DoubleToStringConverter::CreateExponentialRepresentation): NUL-terminate string buffer before passing it to StringBuilder::AddSubstring()

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/dtoa/double-conversion.cc




Diff

Modified: trunk/Source/WTF/ChangeLog (123026 => 123027)

--- trunk/Source/WTF/ChangeLog	2012-07-18 22:14:34 UTC (rev 123026)
+++ trunk/Source/WTF/ChangeLog	2012-07-18 22:16:08 UTC (rev 123027)
@@ -1,3 +1,13 @@
+2012-07-18  Tom Sepez  tse...@chromium.org
+
+OOB read of stack buffer below DoubleToStringConverter::CreateExponentialRepresentation() in debug builds
+https://bugs.webkit.org/show_bug.cgi?id=91642
+
+Reviewed by Abhishek Arya.
+
+* wtf/dtoa/double-conversion.cc:
+(DoubleToStringConverter::CreateExponentialRepresentation): NUL-terminate string buffer before passing it to StringBuilder::AddSubstring()
+
 2012-07-18  Michael Saboff  msab...@apple.com
 
 Make TextCodecLatin1 handle 8 bit data without converting to UChar's


Modified: trunk/Source/WTF/wtf/dtoa/double-conversion.cc (123026 => 123027)

--- trunk/Source/WTF/wtf/dtoa/double-conversion.cc	2012-07-18 22:14:34 UTC (rev 123026)
+++ trunk/Source/WTF/wtf/dtoa/double-conversion.cc	2012-07-18 22:16:08 UTC (rev 123027)
@@ -102,8 +102,9 @@
 }
 ASSERT(exponent  1e4);
 const int kMaxExponentLength = 5;
-char buffer[kMaxExponentLength];
+char buffer[kMaxExponentLength + 1];
 int first_char_pos = kMaxExponentLength;
+buffer[first_char_pos] = '\0';
 while (exponent  0) {
 buffer[--first_char_pos] = '0' + (exponent % 10);
 exponent /= 10;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123029] trunk/Source/WebCore

[commit-queue]

Title: [123029] trunk/Source/WebCore








Revision 123029
Author commit-qu...@webkit.org
Date 2012-07-18 15:20:04 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Ensure that the compositor code which is aware of flipped status of video-textures
per platform sets the flipped bit to false on Windows.
https://bugs.webkit.org/show_bug.cgi?id=91562

Patch by Anantanarayanan G Iyengar ana...@chromium.org on 2012-07-18
Reviewed by Adrienne Walker.

No new tests. (HW video decode is still only being tested manually for orientation)

* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123028 => 123029)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 22:17:18 UTC (rev 123028)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 22:20:04 UTC (rev 123029)
@@ -1,3 +1,16 @@
+2012-07-18  Anantanarayanan G Iyengar  ana...@chromium.org
+
+[chromium] Ensure that the compositor code which is aware of flipped status of video-textures
+per platform sets the flipped bit to false on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=91562
+
+Reviewed by Adrienne Walker.
+
+No new tests. (HW video decode is still only being tested manually for orientation)
+
+* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
+(WebCore::CCVideoLayerImpl::appendQuads):
+
 2012-07-18  Emil A Eklund  e...@chromium.org
 
 Replace uses of RenderBox::x(), y() in rendering code with with point and size methods


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp (123028 => 123029)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp	2012-07-18 22:17:18 UTC (rev 123028)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp	2012-07-18 22:20:04 UTC (rev 123029)
@@ -215,7 +215,7 @@
 #if defined(OS_CHROMEOS)  defined(__ARMEL__)
 bool flipped = true; // Under the covers, implemented by OpenMAX IL.
 #elif OS(WINDOWS)
-bool flipped = true; // Under the covers, implemented by DXVA.
+bool flipped = false; // Under the covers, implemented by DXVA.
 #else
 bool flipped = false; // LibVA (cros/intel), MacOS.
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123031] trunk

[commit-queue]

Title: [123031] trunk








Revision 123031
Author commit-qu...@webkit.org
Date 2012-07-18 15:28:21 -0700 (Wed, 18 Jul 2012)


Log Message
Content size of child having percent height inside a fixed height container having overflow:auto is wrongly calculated
https://bugs.webkit.org/show_bug.cgi?id=11355

Patch by Pravin D pravind@gmail.com on 2012-07-18
Reviewed by Julien Chaffraix.

Source/WebCore:

The content height of a child must be container height minus padding, border width and height of horizontal scrollbar(if any).

Tests: fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html
   fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
Subtracting the height of the scrollbar from the client height when the client has percentage height.

LayoutTests:

* fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt: Added.
* fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html: Added.
* fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt: Added.
* fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/LayoutTests/fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt
trunk/LayoutTests/fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html
trunk/LayoutTests/fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt
trunk/LayoutTests/fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123030 => 123031)

--- trunk/LayoutTests/ChangeLog	2012-07-18 22:22:58 UTC (rev 123030)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 22:28:21 UTC (rev 123031)
@@ -1,3 +1,15 @@
+2012-07-18  Pravin D  pravind@gmail.com
+
+Content size of child having percent height inside a fixed height container having overflow:auto is wrongly calculated
+https://bugs.webkit.org/show_bug.cgi?id=11355
+
+Reviewed by Julien Chaffraix.
+
+* fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt: Added.
+* fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html: Added.
+* fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt: Added.
+* fast/overflow/replaced-child-100percent-height-inside-fixed-container-with-overflow-auto.html: Added.
+
 2012-07-18  Filip Pizlo  fpi...@apple.com
 
 DFG 32-bit PutById transition stub storage reallocation case copies the first pointer of each JSValue instead of the whole JSValue


Added: trunk/LayoutTests/fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt (0 => 123031)

--- trunk/LayoutTests/fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto-expected.txt	2012-07-18 22:28:21 UTC (rev 123031)
@@ -0,0 +1,14 @@
+Testcase for bug https://bugs.webkit.org/show_bug.cgi?id=11355. When a container having overflow:auto has a horizontal scrollbar, the scrollbar is to be placed between the inner border edge and the outer padding edge. Thus the content height of a child inside the container must not include the height of the horizontal scollbars.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+The height of the inner element box should be 100% of the containers height minus the height of horizontal scrollbar. There should be no vertical scrollable content in the container
+
+PASS document.getElementById(container).scrollHeight == document.getElementById(container).clientHeight is true
+Container height = Inner Box height + scrollbar height
+PASS document.getElementById(container).offsetHeight  document.getElementById(innerBox).offsetHeight is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html (0 => 123031)

--- trunk/LayoutTests/fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html	(rev 0)
+++ trunk/LayoutTests/fast/overflow/child-100percent-height-inside-fixed-container-with-overflow-auto.html	2012-07-18 22:28:21 UTC (rev 123031)
@@ -0,0 +1,37 @@
+html
+head
+style type=text/css
+#container {
+	width: 200px;
+	

[webkit-changes] [123032] trunk/Source/WTF

[commit-queue]

Title: [123032] trunk/Source/WTF








Revision 123032
Author commit-qu...@webkit.org
Date 2012-07-18 15:28:24 -0700 (Wed, 18 Jul 2012)


Log Message
[BlackBerry] Implement currentTime() and monotonicallyIncreasingTime() for OS(QNX)
https://bugs.webkit.org/show_bug.cgi?id=91659

Patch by Yong Li y...@rim.com on 2012-07-18
Reviewed by Rob Buis.

Implement currentTime() and monotonicallyIncreasingTime() for OS(QNX) with clock_gettime().

* wtf/CurrentTime.cpp:
(WTF):
(WTF::currentTime):
(WTF::monotonicallyIncreasingTime):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CurrentTime.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (123031 => 123032)

--- trunk/Source/WTF/ChangeLog	2012-07-18 22:28:21 UTC (rev 123031)
+++ trunk/Source/WTF/ChangeLog	2012-07-18 22:28:24 UTC (rev 123032)
@@ -1,3 +1,17 @@
+2012-07-18  Yong Li  y...@rim.com
+
+[BlackBerry] Implement currentTime() and monotonicallyIncreasingTime() for OS(QNX)
+https://bugs.webkit.org/show_bug.cgi?id=91659
+
+Reviewed by Rob Buis.
+
+Implement currentTime() and monotonicallyIncreasingTime() for OS(QNX) with clock_gettime().
+
+* wtf/CurrentTime.cpp:
+(WTF):
+(WTF::currentTime):
+(WTF::monotonicallyIncreasingTime):
+
 2012-07-18  Tom Sepez  tse...@chromium.org
 
 OOB read of stack buffer below DoubleToStringConverter::CreateExponentialRepresentation() in debug builds


Modified: trunk/Source/WTF/wtf/CurrentTime.cpp (123031 => 123032)

--- trunk/Source/WTF/wtf/CurrentTime.cpp	2012-07-18 22:28:21 UTC (rev 123031)
+++ trunk/Source/WTF/wtf/CurrentTime.cpp	2012-07-18 22:28:24 UTC (rev 123032)
@@ -252,6 +252,16 @@
 return ecore_time_unix_get();
 }
 
+#elif OS(QNX)
+
+double currentTime()
+{
+struct timespec time;
+if (clock_gettime(CLOCK_REALTIME, time))
+CRASH();
+return time.tv_sec + time.tv_nsec / 1.0e9;
+}
+
 #else
 
 double currentTime()
@@ -299,6 +309,16 @@
 return timer.nsecsElapsed() / 1.0e9;
 }
 
+#elif OS(QNX)
+
+double monotonicallyIncreasingTime()
+{
+struct timespec time;
+if (clock_gettime(CLOCK_MONOTONIC, time))
+CRASH();
+return time.tv_sec + time.tv_nsec / 1.0e9;
+}
+
 #else
 
 double monotonicallyIncreasingTime()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123034] trunk/Source/Platform

[rniwa]

Title: [123034] trunk/Source/Platform








Revision 123034
Author rn...@webkit.org
Date 2012-07-18 15:36:22 -0700 (Wed, 18 Jul 2012)


Log Message
Another Chromium Windows build fix attempt after r123014.

* chromium/public/Platform.h:

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/Platform.h




Diff

Modified: trunk/Source/Platform/ChangeLog (123033 => 123034)

--- trunk/Source/Platform/ChangeLog	2012-07-18 22:33:06 UTC (rev 123033)
+++ trunk/Source/Platform/ChangeLog	2012-07-18 22:36:22 UTC (rev 123034)
@@ -1,3 +1,9 @@
+2012-07-18  Ryosuke Niwa  rn...@webkit.org
+
+Another Chromium Windows build fix attempt after r123014.
+
+* chromium/public/Platform.h:
+
 2012-07-18  Mark Pilgrim  pilg...@chromium.org
 
 [Chromium] Call SQLiteFileSystem-related functions directly


Modified: trunk/Source/Platform/chromium/public/Platform.h (123033 => 123034)

--- trunk/Source/Platform/chromium/public/Platform.h	2012-07-18 22:33:06 UTC (rev 123033)
+++ trunk/Source/Platform/chromium/public/Platform.h	2012-07-18 22:36:22 UTC (rev 123034)
@@ -31,6 +31,10 @@
 #ifndef Platform_h
 #define Platform_h
 
+#ifdef WIN32
+#include windows.h
+#endif
+
 #include WebAudioDevice.h
 #include WebCommon.h
 #include WebData.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123035] trunk/Tools

[dpranke]

Title: [123035] trunk/Tools








Revision 123035
Author dpra...@chromium.org
Date 2012-07-18 15:39:24 -0700 (Wed, 18 Jul 2012)


Log Message
test-webkitpy: run tests in parallel by default
https://bugs.webkit.org/show_bug.cgi?id=91422

Reviewed by Adam Barth.

We use multiprocessing.cpu_count() for the default number of
jobs to run; memory overhead should be very low, so this should
be fine.

* Scripts/webkitpy/test/main.py:
(Tester._parse_args):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/test/main.py




Diff

Modified: trunk/Tools/ChangeLog (123034 => 123035)

--- trunk/Tools/ChangeLog	2012-07-18 22:36:22 UTC (rev 123034)
+++ trunk/Tools/ChangeLog	2012-07-18 22:39:24 UTC (rev 123035)
@@ -1,3 +1,17 @@
+2012-07-18  Dirk Pranke  dpra...@chromium.org
+
+test-webkitpy: run tests in parallel by default
+https://bugs.webkit.org/show_bug.cgi?id=91422
+
+Reviewed by Adam Barth.
+
+We use multiprocessing.cpu_count() for the default number of
+jobs to run; memory overhead should be very low, so this should
+be fine.
+
+* Scripts/webkitpy/test/main.py:
+(Tester._parse_args):
+
 2012-07-18  Ryosuke Niwa  rn...@webkit.org
 
 Add Pravin D to the list of contributors.


Modified: trunk/Tools/Scripts/webkitpy/test/main.py (123034 => 123035)

--- trunk/Tools/Scripts/webkitpy/test/main.py	2012-07-18 22:36:22 UTC (rev 123034)
+++ trunk/Tools/Scripts/webkitpy/test/main.py	2012-07-18 22:39:24 UTC (rev 123035)
@@ -24,6 +24,7 @@
 unit testing code for webkitpy.
 
 import logging
+import multiprocessing
 import optparse
 import StringIO
 import sys
@@ -63,8 +64,8 @@
   help='do not run the integration tests')
 parser.add_option('-p', '--pass-through', action='', default=False,
   help='be debugger friendly by passing captured output through to the system')
-parser.add_option('-j', '--child-processes', action='', type='int', default=1,
-  help='number of tests to run in parallel')
+parser.add_option('-j', '--child-processes', action='', type='int', default=multiprocessing.cpu_count(),
+  help='number of tests to run in parallel (default=%default)')
 
 parser.epilog = ('[args...] is an optional list of modules, test_classes, or individual tests. '
  'If no args are given, all the tests will be run.')






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123038] trunk/Source

[commit-queue]

Title: [123038] trunk/Source








Revision 123038
Author commit-qu...@webkit.org
Date 2012-07-18 15:57:02 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Ubercomp: add id to SharedQuadState
https://bugs.webkit.org/show_bug.cgi?id=91670

Patch by Alexandre Elias ael...@google.com on 2012-07-18
Reviewed by Adrienne Walker.

This assigns an integer ID to SharedQuadState objects and a
corresponding ID to quads.  This ID is unique only within a
RenderPass and currently is just set to the index in the shared quad
state list.  This is redundant with the pointer and exists to
simplify serialization.

I found out that pointer rewriting within a pickler is blocked by
pointers to memory being const there, so the reassignment will have to
be performed in the application layer anyway.  In that case, it's
simplest to add some ID integers.

Source/Platform:

* chromium/public/WebCompositorQuad.h:
(WebKit::WebCompositorQuad::sharedQuadStateId):
(WebCompositorQuad):
* chromium/public/WebCompositorSharedQuadState.h:
(WebCompositorSharedQuadState):

Source/WebCore:

No new tests (will introduce them when making use of the ID).

* platform/chromium/support/WebCompositorQuad.cpp:
(WebKit::WebCompositorQuad::WebCompositorQuad):
(WebKit::WebCompositorQuad::setSharedQuadState):
(WebKit):
* platform/chromium/support/WebCompositorSharedQuadState.cpp:
(WebKit::WebCompositorSharedQuadState::WebCompositorSharedQuadState):
(WebKit::WebCompositorSharedQuadState::create):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::createSharedQuadState):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
(WebCore::CCRenderPass::appendQuadsToFillScreen):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCQuadCullerTest.cpp:
* tests/CCRenderSurfaceTest.cpp:
* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

Modified Paths

trunk/Source/Platform/ChangeLog
trunk/Source/Platform/chromium/public/WebCompositorQuad.h
trunk/Source/Platform/chromium/public/WebCompositorSharedQuadState.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/support/WebCompositorQuad.cpp
trunk/Source/WebCore/platform/chromium/support/WebCompositorSharedQuadState.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurface.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurface.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp
trunk/Source/WebKit/chromium/tests/CCQuadCullerTest.cpp
trunk/Source/WebKit/chromium/tests/CCRenderSurfaceTest.cpp
trunk/Source/WebKit/chromium/tests/CCSolidColorLayerImplTest.cpp
trunk/Source/WebKit/chromium/tests/CCTiledLayerImplTest.cpp




Diff

Modified: trunk/Source/Platform/ChangeLog (123037 => 123038)

--- trunk/Source/Platform/ChangeLog	2012-07-18 22:41:58 UTC (rev 123037)
+++ trunk/Source/Platform/ChangeLog	2012-07-18 22:57:02 UTC (rev 123038)
@@ -1,3 +1,27 @@
+2012-07-18  Alexandre Elias  ael...@google.com
+
+[chromium] Ubercomp: add id to SharedQuadState
+https://bugs.webkit.org/show_bug.cgi?id=91670
+
+Reviewed by Adrienne Walker.
+
+This assigns an integer ID to SharedQuadState objects and a
+corresponding ID to quads.  This ID is unique only within a
+RenderPass and currently is just set to the index in the shared quad
+state list.  This is redundant with the pointer and exists to
+simplify serialization.
+
+I found out that pointer rewriting within a pickler is blocked by
+pointers to memory being const there, so the reassignment will have to
+be performed in the application layer anyway.  In that case, it's
+simplest to add some ID integers.
+
+* chromium/public/WebCompositorQuad.h:
+(WebKit::WebCompositorQuad::sharedQuadStateId):
+(WebCompositorQuad):
+* chromium/public/WebCompositorSharedQuadState.h:
+(WebCompositorSharedQuadState):
+
 2012-07-18  Ryosuke Niwa  rn...@webkit.org
 
 Another Chromium Windows build fix attempt after r123014.


Modified: trunk/Source/Platform/chromium/public/WebCompositorQuad.h (123037 => 123038)

--- trunk/Source/Platform/chromium/public/WebCompositorQuad.h	2012-07-18 22:41:58 UTC (rev 123037)
+++ 

[webkit-changes] [123040] trunk/Tools

[dpranke]

Title: [123040] trunk/Tools








Revision 123040
Author dpra...@chromium.org
Date 2012-07-18 16:21:15 -0700 (Wed, 18 Jul 2012)


Log Message
fix python unit tests failing under cygwin
https://bugs.webkit.org/show_bug.cgi?id=91678

Reviewed by Adam Barth.

Fix a case where executive.kill_process was failing under cygwin
(apple win port) in an unexpected way.

* Scripts/webkitpy/common/system/executive.py:
(Executive.kill_process):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/executive.py




Diff

Modified: trunk/Tools/ChangeLog (123039 => 123040)

--- trunk/Tools/ChangeLog	2012-07-18 22:58:39 UTC (rev 123039)
+++ trunk/Tools/ChangeLog	2012-07-18 23:21:15 UTC (rev 123040)
@@ -1,5 +1,18 @@
 2012-07-18  Dirk Pranke  dpra...@chromium.org
 
+fix python unit tests failing under cygwin
+https://bugs.webkit.org/show_bug.cgi?id=91678
+
+Reviewed by Adam Barth.
+
+Fix a case where executive.kill_process was failing under cygwin
+(apple win port) in an unexpected way.
+
+* Scripts/webkitpy/common/system/executive.py:
+(Executive.kill_process):
+
+2012-07-18  Dirk Pranke  dpra...@chromium.org
+
 test-webkitpy: run tests in parallel by default
 https://bugs.webkit.org/show_bug.cgi?id=91422
 


Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (123039 => 123040)

--- trunk/Tools/Scripts/webkitpy/common/system/executive.py	2012-07-18 22:58:39 UTC (rev 123039)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py	2012-07-18 23:21:15 UTC (rev 123040)
@@ -211,6 +211,8 @@
 continue
 if e.errno == errno.ESRCH:  # The process does not exist.
 return
+if e.errno == errno.EPIPE:  # The process has exited already on cygwin
+return
 if e.errno == errno.ECHILD:
 # Can't wait on a non-child process, but the kill worked.
 return






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123041] trunk/Tools

[commit-queue]

Title: [123041] trunk/Tools








Revision 123041
Author commit-qu...@webkit.org
Date 2012-07-18 16:23:30 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Add gl_tests to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=91680

Patch by Dave Tu d...@chromium.org on 2012-07-18
Reviewed by Dirk Pranke.

* TestResultServer/static-dashboards/builders.js:
(loadBuildersList):
* TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/builders.js
trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js




Diff

Modified: trunk/Tools/ChangeLog (123040 => 123041)

--- trunk/Tools/ChangeLog	2012-07-18 23:21:15 UTC (rev 123040)
+++ trunk/Tools/ChangeLog	2012-07-18 23:23:30 UTC (rev 123041)
@@ -1,3 +1,15 @@
+2012-07-18  Dave Tu  d...@chromium.org
+
+[chromium] Add gl_tests to flakiness dashboard.
+https://bugs.webkit.org/show_bug.cgi?id=91680
+
+Reviewed by Dirk Pranke.
+
+* TestResultServer/static-dashboards/builders.js:
+(loadBuildersList):
+* TestResultServer/static-dashboards/dashboard_base.js:
+(currentBuilderGroupCategory):
+
 2012-07-18  Dirk Pranke  dpra...@chromium.org
 
 fix python unit tests failing under cygwin


Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (123040 => 123041)

--- trunk/Tools/TestResultServer/static-dashboards/builders.js	2012-07-18 23:21:15 UTC (rev 123040)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js	2012-07-18 23:23:30 UTC (rev 123041)
@@ -217,7 +217,9 @@
 }
 
 function loadBuildersList(groupName, testType) {
-if (testType == 'gpu_tests') {
+switch (testType) {
+case 'gl_tests':
+case 'gpu_tests':
 switch(groupName) {
 case '@DEPS - chromium.org':
 var builderGroup = new BuilderGroup(BuilderGroup.DEPS_WEBKIT);
@@ -234,7 +236,9 @@
 requestBuilderList(CHROMIUM_GPU_TESTS_BUILDER_GROUPS, isChromiumTipOfTreeGpuTestRunner, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, BuilderGroup.TOT_WEBKIT, builderGroup);
 break;
 }
-} else if (testType == 'layout-tests') {
+break;
+
+case 'layout-tests':
 switch(groupName) {
 case '@ToT - chromium.org':
 var builderGroup = new BuilderGroup(BuilderGroup.TOT_WEBKIT);
@@ -251,7 +255,9 @@
 requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, isChromiumWebkitDepsTestRunner, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, BuilderGroup.DEPS_WEBKIT, builderGroup);
 break;
 }
-} else {
+break;
+
+default:
 switch(groupName) {
 case '@DEPS - chromium.org':
 var builderGroup = new BuilderGroup(BuilderGroup.DEPS_WEBKIT);
@@ -271,6 +277,7 @@
 requestBuilderList(CHROMIUM_GTESTS_BUILDER_GROUPS, isChromiumTipOfTreeGTestRunner, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, BuilderGroup.TOT_WEBKIT, builderGroup);
 break;
 }
+break;
 }
 }
 


Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (123040 => 123041)

--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2012-07-18 23:21:15 UTC (rev 123040)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js	2012-07-18 23:23:30 UTC (rev 123041)
@@ -124,6 +124,7 @@
 'crypto_unittests',
 'googleurl_unittests',
 'gfx_unittests',
+'gl_tests',
 'gpu_tests',
 'gpu_unittests',
 'installer_util_unittests',
@@ -448,11 +449,15 @@
 
 function currentBuilderGroupCategory()
 {
-if (g_crossDashboardState.testType == 'layout-tests')
+switch (g_crossDashboardState.testType) {
+case 'gl_tests':
+case 'gpu_tests':
+return CHROMIUM_GPU_TESTS_BUILDER_GROUPS;
+case 'layout-tests':
 return LAYOUT_TESTS_BUILDER_GROUPS;
-if (g_crossDashboardState.testType == 'gpu_tests')
-return CHROMIUM_GPU_TESTS_BUILDER_GROUPS;
-return CHROMIUM_GTESTS_BUILDER_GROUPS;
+default:
+return CHROMIUM_GTESTS_BUILDER_GROUPS;
+}
 }
 
 function currentBuilderGroup()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123042] trunk/Source/JavaScriptCore

[oliver]

Title: [123042] trunk/Source/_javascript_Core








Revision 123042
Author oli...@apple.com
Date 2012-07-18 16:26:06 -0700 (Wed, 18 Jul 2012)


Log Message
dumpCallFrame is broken in ToT
https://bugs.webkit.org/show_bug.cgi?id=91444

Reviewed by Gavin Barraclough.

Various changes have been made to the SF calling convention, but
dumpCallFrame has not been updated to reflect these changes.
That resulted in both bogus information, as well as numerous
assertions of sadness.

This patch makes dumpCallFrame actually work again and adds the
wonderful feature of telling you the name of the variable that a
register reflects, or what value it contains.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::nameForRegister):
A really innefficient mechanism for finding the name of a local register.
This should only ever be used by debug code so this should be okay.
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
Debug builds no longer throw away a functions symbol table, this allows
us to actually perform a register# to name mapping
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
We weren't propogating the bytecode offset here leading to assertions
in debug builds when dumping bytecode of DFG compiled code.
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
 Rework to actually be correct.
(JSC::getCallerInfo):
 Return the byteocde offset as well now, given we have to determine it
 anyway.
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):
* interpreter/Interpreter.h:
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionDumpCallFrame):
 Give debug builds of JSC a method for calling dumpCallFrame so we can
 inspect a callframe without requiring us to break in a debugger.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/interpreter/Interpreter.h
trunk/Source/_javascript_Core/jsc.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (123041 => 123042)

--- trunk/Source/_javascript_Core/ChangeLog	2012-07-18 23:23:30 UTC (rev 123041)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-07-18 23:26:06 UTC (rev 123042)
@@ -1,3 +1,50 @@
+2012-07-16  Oliver Hunt  oli...@apple.com
+
+dumpCallFrame is broken in ToT
+https://bugs.webkit.org/show_bug.cgi?id=91444
+
+Reviewed by Gavin Barraclough.
+
+Various changes have been made to the SF calling convention, but
+dumpCallFrame has not been updated to reflect these changes.
+That resulted in both bogus information, as well as numerous
+assertions of sadness.
+
+This patch makes dumpCallFrame actually work again and adds the
+wonderful feature of telling you the name of the variable that a
+register reflects, or what value it contains.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::nameForRegister):
+A really innefficient mechanism for finding the name of a local register.
+This should only ever be used by debug code so this should be okay.
+* bytecode/CodeBlock.h:
+(CodeBlock):
+* bytecompiler/BytecodeGenerator.cpp:
+(JSC::BytecodeGenerator::generate):
+Debug builds no longer throw away a functions symbol table, this allows
+us to actually perform a register# to name mapping
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::link):
+We weren't propogating the bytecode offset here leading to assertions
+in debug builds when dumping bytecode of DFG compiled code.
+* interpreter/Interpreter.cpp:
+(JSC):
+(JSC::Interpreter::dumpRegisters):
+ Rework to actually be correct.
+(JSC::getCallerInfo):
+ Return the byteocde offset as well now, given we have to determine it
+ anyway.
+(JSC::Interpreter::getStackTrace):
+(JSC::Interpreter::retrieveCallerFromVMCode):
+* interpreter/Interpreter.h:
+(Interpreter):
+* jsc.cpp:
+(GlobalObject::finishCreation):
+(functionDumpCallFrame):
+ Give debug builds of JSC a method for calling dumpCallFrame so we can
+ inspect a callframe without requiring us to break in a debugger.
+
 2012-07-18  Filip Pizlo  fpi...@apple.com
 
 DFG 32-bit PutById transition stub storage reallocation case copies the first pointer of each JSValue instead of the whole JSValue


Modified: 

[webkit-changes] [123043] trunk/Source/WebCore

[arv]

Title: [123043] trunk/Source/WebCore








Revision 123043
Author a...@chromium.org
Date 2012-07-18 16:38:47 -0700 (Wed, 18 Jul 2012)


Log Message
[V8] Remove temporary flag override for es52_globals
https://bugs.webkit.org/show_bug.cgi?id=91681

Reviewed by Adam Barth.

V8 has now changed their default value for the es52_globals so we no longer needs this override.

No new tests. No change in functionality.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123042 => 123043)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 23:26:06 UTC (rev 123042)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 23:38:47 UTC (rev 123043)
@@ -1,3 +1,19 @@
+2012-07-18  Erik Arvidsson  a...@chromium.org
+
+[V8] Remove temporary flag override for es52_globals
+https://bugs.webkit.org/show_bug.cgi?id=91681
+
+Reviewed by Adam Barth.
+
+V8 has now changed their default value for the es52_globals so we no longer needs this override.
+
+No new tests. No change in functionality.
+
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::V8DOMWindowShell::initContextIfNeeded):
+* bindings/v8/WorkerContextExecutionProxy.cpp:
+(WebCore::WorkerContextExecutionProxy::initIsolate):
+
 2012-07-18  Alexandre Elias  ael...@google.com
 
 [chromium] Ubercomp: add id to SharedQuadState


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (123042 => 123043)

--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2012-07-18 23:26:06 UTC (rev 123042)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2012-07-18 23:38:47 UTC (rev 123043)
@@ -300,10 +300,6 @@
 #endif
 V8BindingPerIsolateData::ensureInitialized(v8::Isolate::GetCurrent());
 
-// FIXME: Remove the following 2 lines when V8 default has changed.
-const char es52GlobalsFlag[] = --es52_globals;
-v8::V8::SetFlagsFromString(es52GlobalsFlag, sizeof(es52GlobalsFlag));
-
 isV8Initialized = true;
 }
 


Modified: trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp (123042 => 123043)

--- trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp	2012-07-18 23:26:06 UTC (rev 123042)
+++ trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp	2012-07-18 23:38:47 UTC (rev 123043)
@@ -122,10 +122,6 @@
 v8::V8::SetGlobalGCPrologueCallback(V8GCController::gcPrologue);
 v8::V8::SetGlobalGCEpilogueCallback(V8GCController::gcEpilogue);
 
-// FIXME: Remove the following 2 lines when V8 default has changed.
-const char es52GlobalsFlag[] = --es52_globals;
-v8::V8::SetFlagsFromString(es52GlobalsFlag, sizeof(es52GlobalsFlag));
-
 v8::ResourceConstraints resource_constraints;
 uint32_t here;
 resource_constraints.set_stack_limit(here - kWorkerMaxStackSize / sizeof(uint32_t*));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123044] trunk/LayoutTests

[commit-queue]

Title: [123044] trunk/LayoutTests








Revision 123044
Author commit-qu...@webkit.org
Date 2012-07-18 16:39:27 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL][DRT] Add heap profiling tests to Skipped list
https://bugs.webkit.org/show_bug.cgi?id=91684

Unreviewed gardening.

JSC doesn't support heap profiling.

Patch by Seokju Kwon seokju.k...@samsung.com on 2012-07-18

* platform/efl/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (123043 => 123044)

--- trunk/LayoutTests/ChangeLog	2012-07-18 23:38:47 UTC (rev 123043)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 23:39:27 UTC (rev 123044)
@@ -1,3 +1,14 @@
+2012-07-18  Seokju Kwon  seokju.k...@samsung.com
+
+[EFL][DRT] Add heap profiling tests to Skipped list
+https://bugs.webkit.org/show_bug.cgi?id=91684
+
+Unreviewed gardening.
+
+JSC doesn't support heap profiling.
+
+* platform/efl/Skipped:
+
 2012-07-18  Jer Noble  jer.no...@apple.com
 
 REGRESSION (r122660-r122663): mathml/presentation/mo.xhtml, mathml/presentation/row.xhtml failing on Mountain Lion Production Tests


Modified: trunk/LayoutTests/platform/efl/Skipped (123043 => 123044)

--- trunk/LayoutTests/platform/efl/Skipped	2012-07-18 23:38:47 UTC (rev 123043)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-07-18 23:39:27 UTC (rev 123044)
@@ -1127,3 +1127,15 @@
 # http://webkit.org/b/35981
 # Needs a text rebaseline: 30px height difference.
 fast/block/basic/fieldset-stretch-to-legend.html
+
+# JSC doesn't support heap profiling
+inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
+inspector/profiler/heap-snapshot-comparison-dom-groups-change.html
+inspector/profiler/heap-snapshot-comparison-show-all.html
+inspector/profiler/heap-snapshot-loader.html
+inspector/profiler/heap-snapshot-reveal-in-dominators-view.html
+inspector/profiler/heap-snapshot-summary-retainers.html
+inspector/profiler/heap-snapshot-summary-show-ranges.html
+inspector/profiler/heap-snapshot-summary-sorting-fields.html
+inspector/profiler/heap-snapshot-summary-sorting.html
+inspector/profiler/heap-snapshot-summary-sorting-instances.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123045] trunk/LayoutTests

[jsbell]

Title: [123045] trunk/LayoutTests








Revision 123045
Author jsb...@chromium.org
Date 2012-07-18 16:44:25 -0700 (Wed, 18 Jul 2012)


Log Message
[chromium] Unreviewed TestExpectations update for WK90469.
Restore a test that was skipped to test a theory.
https://bugs.webkit.org/show_bug.cgi?id=90469

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123044 => 123045)

--- trunk/LayoutTests/ChangeLog	2012-07-18 23:39:27 UTC (rev 123044)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 23:44:25 UTC (rev 123045)
@@ -1,3 +1,11 @@
+2012-07-18  Joshua Bell  jsb...@chromium.org
+
+[chromium] Unreviewed TestExpectations update for WK90469.
+Restore a test that was skipped to test a theory.
+https://bugs.webkit.org/show_bug.cgi?id=90469
+
+* platform/chromium/TestExpectations:
+
 2012-07-18  Seokju Kwon  seokju.k...@samsung.com
 
 [EFL][DRT] Add heap profiling tests to Skipped list


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123044 => 123045)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 23:39:27 UTC (rev 123044)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-18 23:44:25 UTC (rev 123045)
@@ -3643,9 +3643,7 @@
 BUGWK91403 WIN : storage/indexeddb/cursor-update-value-argument-required.html = PASS CRASH
 BUGWK90517 WIN : svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg = PASS CRASH
 BUGWK91421 WIN7 : svg/W3C-SVG-1.1/animate-elem-39-t.svg = PASS CRASH
-// Temporarily marking as SKIP to see if crashes shift to later tests
-//BUGWK90469 WIN : storage/websql/multiple-databases-garbage-collection.html = PASS CRASH
-BUG_JSBELL SKIP : storage/websql/multiple-databases-garbage-collection.html = PASS CRASH
+BUGWK90469 WIN : storage/websql/multiple-databases-garbage-collection.html = PASS CRASH
 
 // Require rebaseline after bug 88171
 BUGWK88171 WIN : css1/formatting_model/floating_elements.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123046] trunk/LayoutTests

[jer . noble]

Title: [123046] trunk/LayoutTests








Revision 123046
Author jer.no...@apple.com
Date 2012-07-18 16:50:27 -0700 (Wed, 18 Jul 2012)


Log Message
Unreviewed gardening.

Correct a path error introduced by r122769 for the fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
test in many Skipped lists.

* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/mac-lion/Skipped
trunk/LayoutTests/platform/mac-snowleopard/Skipped
trunk/LayoutTests/platform/mac-wk2/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt-4.8/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/win-wk2/Skipped
trunk/LayoutTests/platform/win-xp/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/LayoutTests/platform/wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (123045 => 123046)

--- trunk/LayoutTests/ChangeLog	2012-07-18 23:44:25 UTC (rev 123045)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 23:50:27 UTC (rev 123046)
@@ -1,3 +1,22 @@
+2012-07-18  Jer Noble  jer.no...@apple.com
+
+Unreviewed gardening.
+
+Correct a path error introduced by r122769 for the fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
+test in many Skipped lists.
+
+* platform/mac-lion/Skipped:
+* platform/mac-snowleopard/Skipped:
+* platform/mac-wk2/Skipped:
+* platform/mac/Skipped:
+* platform/qt-4.8/Skipped:
+* platform/qt/Skipped:
+* platform/win-wk2/Skipped:
+* platform/win-xp/Skipped:
+* platform/win/Skipped:
+* platform/wincairo/Skipped:
+* platform/wk2/Skipped:
+
 2012-07-18  Joshua Bell  jsb...@chromium.org
 
 [chromium] Unreviewed TestExpectations update for WK90469.


Modified: trunk/LayoutTests/platform/mac/Skipped (123045 => 123046)

--- trunk/LayoutTests/platform/mac/Skipped	2012-07-18 23:44:25 UTC (rev 123045)
+++ trunk/LayoutTests/platform/mac/Skipped	2012-07-18 23:50:27 UTC (rev 123046)
@@ -817,7 +817,7 @@
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
-fast/sub-pixel/selection-gaps-at-fractional-offsets.html
+fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
 


Modified: trunk/LayoutTests/platform/mac-lion/Skipped (123045 => 123046)

--- trunk/LayoutTests/platform/mac-lion/Skipped	2012-07-18 23:44:25 UTC (rev 123045)
+++ trunk/LayoutTests/platform/mac-lion/Skipped	2012-07-18 23:50:27 UTC (rev 123046)
@@ -111,7 +111,7 @@
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
-fast/sub-pixel/selection-gaps-at-fractional-offsets.html
+fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
 


Modified: trunk/LayoutTests/platform/mac-snowleopard/Skipped (123045 => 123046)

--- trunk/LayoutTests/platform/mac-snowleopard/Skipped	2012-07-18 23:44:25 UTC (rev 123045)
+++ trunk/LayoutTests/platform/mac-snowleopard/Skipped	2012-07-18 23:50:27 UTC (rev 123046)
@@ -205,7 +205,7 @@
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
-fast/sub-pixel/selection-gaps-at-fractional-offsets.html
+fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
 


Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (123045 => 123046)

--- trunk/LayoutTests/platform/mac-wk2/Skipped	2012-07-18 23:44:25 UTC (rev 123045)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2012-07-18 23:50:27 UTC (rev 123046)
@@ -211,7 +211,7 @@
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html
-fast/sub-pixel/selection-gaps-at-fractional-offsets.html
+fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
 fast/sub-pixel/size-of-box-with-zoom.html
 fast/sub-pixel/table-rows-no-gaps.html
 


Modified: trunk/LayoutTests/platform/qt/Skipped (123045 => 123046)

--- trunk/LayoutTests/platform/qt/Skipped	2012-07-18 23:44:25 UTC (rev 123045)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-07-18 23:50:27 UTC (rev 123046)
@@ -244,7 +244,7 @@
 fast/sub-pixel/inline-block-with-margin.html
 fast/sub-pixel/inline-block-with-padding.html
 fast/sub-pixel/layout-boxes-with-zoom.html

[webkit-changes] [123047] trunk

[arv]

Title: [123047] trunk








Revision 123047
Author a...@chromium.org
Date 2012-07-18 16:54:23 -0700 (Wed, 18 Jul 2012)


Log Message
[V8] Improve Replaceable extended attribute
https://bugs.webkit.org/show_bug.cgi?id=91668

Reviewed by Adam Barth.

Replaceable is working by chance in the V8 bindings because V8 does not correctly handle
read only properties on the prototype chain. With this change we generate a setter that
uses ForceSet to replace the existing property when set.

Source/WebCore:

Test: fast/dom/Window/replaceable.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateReplaceableAttrSetter):
(GenerateFunctionCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::replaceableAttribute):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_get_replaceable_attribute):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjReplaceableAttribute):
(WebCore::setJSTestObjReplaceableAttribute):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj replaceableAttribute]):
(-[DOMTestObj setReplaceableAttribute:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::TestObjReplaceableAttrSetter):
(WebCore):

LayoutTests:

* fast/dom/Window/replaceable-expected.txt: Added.
* fast/dom/Window/replaceable.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp


Added Paths

trunk/LayoutTests/fast/dom/Window/replaceable-expected.txt
trunk/LayoutTests/fast/dom/Window/replaceable.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123046 => 123047)

--- trunk/LayoutTests/ChangeLog	2012-07-18 23:50:27 UTC (rev 123046)
+++ trunk/LayoutTests/ChangeLog	2012-07-18 23:54:23 UTC (rev 123047)
@@ -1,3 +1,17 @@
+2012-07-18  Erik Arvidsson  a...@chromium.org
+
+[V8] Improve Replaceable extended attribute
+https://bugs.webkit.org/show_bug.cgi?id=91668
+
+Reviewed by Adam Barth.
+
+Replaceable is working by chance in the V8 bindings because V8 does not correctly handle
+read only properties on the prototype chain. With this change we generate a setter that
+uses ForceSet to replace the existing property when set.
+
+* fast/dom/Window/replaceable-expected.txt: Added.
+* fast/dom/Window/replaceable.html: Added.
+
 2012-07-18  Jer Noble  jer.no...@apple.com
 
 Unreviewed gardening.


Added: trunk/LayoutTests/fast/dom/Window/replaceable-expected.txt (0 => 123047)

--- trunk/LayoutTests/fast/dom/Window/replaceable-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/Window/replaceable-expected.txt	2012-07-18 23:54:23 UTC (rev 123047)
@@ -0,0 +1,11 @@
+Tests that Replaceable attributes are writable
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS Object.getOwnPropertyDescriptor(window, innerHeight).writable is true
+PASS window.innerHeight is 42
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/Window/replaceable.html (0 => 123047)

--- trunk/LayoutTests/fast/dom/Window/replaceable.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/Window/replaceable.html	2012-07-18 23:54:23 UTC (rev 123047)
@@ -0,0 +1,13 @@
+!doctype html
+script src=""
+script
+
+description('Tests that Replaceable attributes are writable');
+
+shouldBeTrue('Object.getOwnPropertyDescriptor(window, innerHeight).writable');
+
+window.innerHeight = 42;
+shouldBe('window.innerHeight', '42');
+
+/script
+script src=""


Modified: trunk/Source/WebCore/ChangeLog (123046 => 123047)

--- trunk/Source/WebCore/ChangeLog	2012-07-18 23:50:27 UTC (rev 123046)
+++ trunk/Source/WebCore/ChangeLog	2012-07-18 23:54:23 UTC (rev 123047)
@@ -1,5 +1,48 @@
 2012-07-18  Erik Arvidsson  a...@chromium.org
 
+[V8] Improve Replaceable extended attribute
+