[webkit-changes] [123183] trunk

[hyatt]

Title: [123183] trunk








Revision 123183
Author hy...@apple.com
Date 2012-07-19 23:12:54 -0700 (Thu, 19 Jul 2012)


Log Message
SVG not properly respecting max-width.
https://bugs.webkit.org/show_bug.cgi?id=91474

Source/WebCore: 

My previous checkin for 91474 accidentally inverted width and height in the division case for
the computation of height. When I fixed this inversion, I discovered that object elements
are in fact also broken with max-width handling, and that furthermore, trying to apply the same
max-width fix by calling RenderBox::computeReplacedLogicalWidth/Height failed because those methods
call intrinsicLogicalWidth()/Height(). Becuase m_intrinsicSize is out-of-date and does not reflect
the values we just obtained from the contentRenderer, we use the default 300x150 values for object
and fail to render.

In order to both fix SVG/object with max-width constraints and to keep object rendering correctly
even when there are no max-width constraints, I was forced to update the m_intrinsicSize immediately
in order to make sure that the RenderBox methods returned the right values when computing the width/height
constrained to max/min-width/height values.

Reviewed by Dan Bernstein.

Added two new tests in svg/as-image. One test covers non-rectangular images to test for the inversion
mistake I made. The second test applies a max-width to object and shows that we have never gotten
this right before. An existing test in svg/as-image/ already covers basic object use (and tests that
the intrinsic size of 300x150 is not used when an explicit non-percentage size is specified on the SVG
itself).

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):
Add a check to update m_intrinsicSize when we know it should apply, so that the calls to check against
min/max-width fetch this correct size.

* rendering/RenderReplaced.h:
(RenderReplaced):
Make m_intrinsicSize mutable because of the mutation that occurs during the method above. It may be
that we should re-evaluate whether all of these methods should be const, but this would impact RenderBox
methods as well, so I chose to hold off going down that rabbit hole.

LayoutTests: 

Reviewed by Dan Bernstein.

* svg/as-image/svg-intrinsic-size-rectangular-expected.html: Added.
* svg/as-image/svg-intrinsic-size-rectangular.html: Added.
* svg/as-image/svg-object-intrinsic-size-expected.html: Added.
* svg/as-image/svg-object-intrinsic-size.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/svg/as-image/svg-non-integer-scaled-image-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderReplaced.cpp
trunk/Source/WebCore/rendering/RenderReplaced.h


Added Paths

trunk/LayoutTests/svg/as-image/svg-intrinsic-size-rectangular-expected.html
trunk/LayoutTests/svg/as-image/svg-intrinsic-size-rectangular.html
trunk/LayoutTests/svg/as-image/svg-object-intrinsic-size-expected.html
trunk/LayoutTests/svg/as-image/svg-object-intrinsic-size.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123182 => 123183)

--- trunk/LayoutTests/ChangeLog	2012-07-20 06:06:04 UTC (rev 123182)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 06:12:54 UTC (rev 123183)
@@ -1,3 +1,15 @@
+2012-07-19  David Hyatt  hy...@apple.com
+
+SVG not properly respecting max-width.
+https://bugs.webkit.org/show_bug.cgi?id=91474
+
+Reviewed by Dan Bernstein.
+
+* svg/as-image/svg-intrinsic-size-rectangular-expected.html: Added.
+* svg/as-image/svg-intrinsic-size-rectangular.html: Added.
+* svg/as-image/svg-object-intrinsic-size-expected.html: Added.
+* svg/as-image/svg-object-intrinsic-size.html: Added.
+
 2012-07-19  Dominic Mazzoni  dmazz...@google.com
 
 AX: Need AccessibilityObjects for nodes without renderers in canvas subtree


Added: trunk/LayoutTests/svg/as-image/svg-intrinsic-size-rectangular-expected.html (0 => 123183)

--- trunk/LayoutTests/svg/as-image/svg-intrinsic-size-rectangular-expected.html	(rev 0)
+++ trunk/LayoutTests/svg/as-image/svg-intrinsic-size-rectangular-expected.html	2012-07-20 06:12:54 UTC (rev 123183)
@@ -0,0 +1,4 @@
+!DOCTYPE html
+div style=position: absolute; top: 10px; left: 10px; width: 200px; height: 400px; outline: 1px solid blue;
+div style=height:100px;background-color:black/div
+/div


Added: trunk/LayoutTests/svg/as-image/svg-intrinsic-size-rectangular.html (0 => 123183)

--- trunk/LayoutTests/svg/as-image/svg-intrinsic-size-rectangular.html	(rev 0)
+++ trunk/LayoutTests/svg/as-image/svg-intrinsic-size-rectangular.html	2012-07-20 06:12:54 UTC (rev 123183)
@@ -0,0 +1,4 @@
+!DOCTYPE html
+div style=position: absolute; top: 10px; left: 10px; width: 200px; height: 400px; outline: 1px solid blue;
+img style=background-color: yellow; width: auto; height: auto; max-width: 100%; max-height: 100%; src="" width='600' height='300' 

[webkit-changes] [123184] trunk

[morrita]

Title: [123184] trunk








Revision 123184
Author morr...@google.com
Date 2012-07-19 23:33:48 -0700 (Thu, 19 Jul 2012)


Log Message
[Refactoring] Replace Node's Document pointer with a TreeScope pointer
https://bugs.webkit.org/show_bug.cgi?id=59816

Reviewed by Ryosuke Niwa.

.:

* Source/autotools/symbols.filter: Added newly exported symbols.

Source/WebCore:

Before this change, Node::treeScope() fetches the TreeScope object
from ElementRareData. This approach has several shortcomings:

- rareData() call is slow due to a hashtable lookup.
- In shadow tree, each node has its tree scope in ElementRareData,
  that means the rare-data is no longer rare in that case.

This change gets rid of ElementRareData::m_treeScope by replacing
Node::m_document with Node::m_treeScope. And retrieves the
document of Node through m_treeScope.

Note that Node::document() is a hot function and naive
replacemennt of m_document with m_treeScope can hurt the
speed. This change employs some tricks to address it.

- This change introduces Node::InShadowTree flag, if the flag is off,
  that means m_treeScope is actually a document an can be returned as the result.
  this eliminates an extract dereference.
- Node::m_treeScope can be null. But we don't want to issue any extra
  conditional statement. So this change represents a null
  TreeScope as TreeScope::nullInstance(), which saves one conditional
  statement.

With these changes, the Node::document() slowdown is minimized to
unnoticeable size.

No new tests. Covered by existing tests.

* dom/Document.cpp: Took care of connectio betwen TreeScope.
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::suggestedMIMEType):
* dom/Document.h:
(WebCore::Node::treeScope): Now just return m_treeScope, taking care of nullInstance() case.
(WebCore):
(WebCore::Node::setTreeScope): Now just sets m_treeScope.
(WebCore::Node::documentInternal): Extracted from document() to have ASSERT-free version.
(WebCore::Node::document): Re-implemented over treeScope() and the flag.
(WebCore::Node::isDocumentNode): Re-implemented using treeScope()
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::reportMemoryUsage):
* dom/Node.h:
(Node):
(WebCore::Node::inDocument):
(WebCore::Node::isInShadowTree): Rewrote to use InShadowTree flag.
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData): Eliminated m_treeScope.
(NodeRareData):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
* dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore):
(WebCore::TreeScope::setParentTreeScope): Added.
(WebCore::TreeScope::isDocumentScope): Added.
(WebCore::TreeScope::nullInstance): Added.
* dom/TreeScope.h: Added m_parentTreeScope.
(WebCore):
(WebCore::TreeScope::rootDocument): Added.
(TreeScope):
* dom/TreeScopeAdopter.cpp: No longer calls setDocument()
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
* editing/MoveSelectionCommand.cpp: Includes Document.h to find inlined Node functions
* editing/RemoveNodeCommand.cpp: Includes Document.h to find inlined Node functions
* editing/RemoveNodePreservingChildrenCommand.cpp: Includes Document.h to find inlined Node functions
* inspector/PageConsoleAgent.cpp: Includes Document.h to find inlined Node functions

Source/WebKit2:

* win/WebKit2.def: Added newly exported symbols.
* win/WebKit2CFLite.def: Ditto.

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/NodeRareData.h
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/dom/TreeScope.cpp
trunk/Source/WebCore/dom/TreeScope.h
trunk/Source/WebCore/dom/TreeScopeAdopter.cpp
trunk/Source/WebCore/editing/MoveSelectionCommand.cpp
trunk/Source/WebCore/editing/RemoveNodeCommand.cpp
trunk/Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp
trunk/Source/WebCore/inspector/PageConsoleAgent.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def
trunk/Source/WebKit2/win/WebKit2CFLite.def
trunk/Source/autotools/symbols.filter




Diff

Modified: trunk/ChangeLog (123183 => 123184)

--- trunk/ChangeLog	2012-07-20 06:12:54 UTC (rev 123183)
+++ trunk/ChangeLog	2012-07-20 06:33:48 UTC (rev 123184)
@@ -1,3 +1,12 @@
+2012-07-19  MORITA Hajime  morr...@google.com
+
+[Refactoring] Replace Node's Document pointer with a TreeScope pointer
+https://bugs.webkit.org/show_bug.cgi?id=59816
+
+Reviewed by Ryosuke Niwa.
+
+* Source/autotools/symbols.filter: Added newly exported symbols.
+
 2012-07-19  Christophe Dumez  christophe.du...@intel.com
 
 [EFL] Bump libsoup dependency to v2.39.4.1 to fix cookie issues


Modified: trunk/Source/WebCore/ChangeLog (123183 => 123184)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 06:12:54 UTC (rev 123183)
+++ 

[webkit-changes] [123185] trunk/Source/WebCore

[commit-queue]

Title: [123185] trunk/Source/WebCore








Revision 123185
Author commit-qu...@webkit.org
Date 2012-07-19 23:48:11 -0700 (Thu, 19 Jul 2012)


Log Message
[Qt] Compile WebCore without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=91819

Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-07-19
Reviewed by Kenneth Rohde Christiansen.

* WebCore.pri: QT += opengl is not needed for Qt 5, given that QtGui has OpenGL
support built in with the QOpenGL* classes.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (123184 => 123185)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 06:33:48 UTC (rev 123184)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 06:48:11 UTC (rev 123185)
@@ -1,3 +1,13 @@
+2012-07-19  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt] Compile WebCore without QtWidgets
+https://bugs.webkit.org/show_bug.cgi?id=91819
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* WebCore.pri: QT += opengl is not needed for Qt 5, given that QtGui has OpenGL
+support built in with the QOpenGL* classes.
+
 2012-07-19  MORITA Hajime  morr...@google.com
 
 [Refactoring] Replace Node's Document pointer with a TreeScope pointer


Modified: trunk/Source/WebCore/WebCore.pri (123184 => 123185)

--- trunk/Source/WebCore/WebCore.pri	2012-07-20 06:33:48 UTC (rev 123184)
+++ trunk/Source/WebCore/WebCore.pri	2012-07-20 06:48:11 UTC (rev 123185)
@@ -193,8 +193,7 @@
 contains(QT_CONFIG, opengles2): LIBS += -lEGL
 mac: LIBS += -framework IOSurface -framework CoreFoundation
 linux-*:contains(DEFINES, HAVE_XCOMPOSITE=1): LIBS += -lXcomposite
-# Only WebKit1 needs the opengl module, so it's optional for Qt5.
-haveQt(4)|contains(QT_CONFIG, opengl): QT *= opengl
+haveQt(4): QT *= opengl
 }
 
 !system-sqlite:exists( $${SQLITE3SRCDIR}/sqlite3.c ) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123186] trunk/LayoutTests/ChangeLog

[yosin]

Title: [123186] trunk/LayoutTests/ChangeLog








Revision 123186
Author yo...@chromium.org
Date 2012-07-20 00:36:17 -0700 (Fri, 20 Jul 2012)


Log Message
Unreviewed. Set svn:mime-type to image/png for PNG files without svn:mime-type.

* platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Added property svn:mime-type.
* platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added property svn:mime-type.
* platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added property svn:mime-type.

Modified Paths

trunk/LayoutTests/ChangeLog




Diff

Modified: trunk/LayoutTests/ChangeLog (123185 => 123186)

--- trunk/LayoutTests/ChangeLog	2012-07-20 06:48:11 UTC (rev 123185)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 07:36:17 UTC (rev 123186)
@@ -1,3 +1,11 @@
+2012-07-20  Yoshifumi Inoue  yo...@chromium.org
+
+Unreviewed. Set svn:mime-type to image/png for PNG files without svn:mime-type.
+
+* platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Added property svn:mime-type.
+* platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added property svn:mime-type.
+* platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added property svn:mime-type.
+
 2012-07-19  David Hyatt  hy...@apple.com
 
 SVG not properly respecting max-width.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123187] trunk/Source/WebCore

[tkent]

Title: [123187] trunk/Source/WebCore








Revision 123187
Author tk...@chromium.org
Date 2012-07-20 00:42:57 -0700 (Fri, 20 Jul 2012)


Log Message
[Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824

Reviewed by Hajime Morita.

No new tests. This code is used only in Chromium browser.

* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::hostInput):
Use shadowHost(), and allow to return 0.
(WebCore::TextFieldDecorationElement::defaultEventHandler):
Check 0.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123186 => 123187)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 07:36:17 UTC (rev 123186)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 07:42:57 UTC (rev 123187)
@@ -1,3 +1,18 @@
+2012-07-20  Kent Tamura  tk...@chromium.org
+
+[Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
+https://bugs.webkit.org/show_bug.cgi?id=91824
+
+Reviewed by Hajime Morita.
+
+No new tests. This code is used only in Chromium browser.
+
+* html/shadow/TextFieldDecorationElement.cpp:
+(WebCore::TextFieldDecorationElement::hostInput):
+Use shadowHost(), and allow to return 0.
+(WebCore::TextFieldDecorationElement::defaultEventHandler):
+Check 0.
+
 2012-07-19  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Compile WebCore without QtWidgets


Modified: trunk/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp (123186 => 123187)

--- trunk/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp	2012-07-20 07:36:17 UTC (rev 123186)
+++ trunk/Source/WebCore/html/shadow/TextFieldDecorationElement.cpp	2012-07-20 07:42:57 UTC (rev 123187)
@@ -116,9 +116,10 @@
 
 inline HTMLInputElement* TextFieldDecorationElement::hostInput()
 {
-ASSERT(shadowAncestorNode());
-ASSERT(shadowAncestorNode()-hasTagName(inputTag));
-return static_castHTMLInputElement*(shadowAncestorNode());
+// TextFieldDecorationElement is created only by C++ code, and it is always
+// in input shadow.
+ASSERT(!shadowHost() || shadowHost()-hasTagName(inputTag));
+return static_castHTMLInputElement*(shadowHost());
 }
 
 bool TextFieldDecorationElement::isTextFieldDecoration() const
@@ -181,7 +182,7 @@
 void TextFieldDecorationElement::defaultEventHandler(Event* event)
 {
 RefPtrHTMLInputElement input(hostInput());
-if (input-disabled() || input-readOnly() || !event-isMouseEvent()) {
+if (!input || input-disabled() || input-readOnly() || !event-isMouseEvent()) {
 if (!event-defaultHandled())
 HTMLDivElement::defaultEventHandler(event);
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123188] trunk

[keishi]

Title: [123188] trunk








Revision 123188
Author kei...@webkit.org
Date 2012-07-20 00:46:00 -0700 (Fri, 20 Jul 2012)


Log Message
Fix crash in WebCore::HTMLInputElement::dataList
https://bugs.webkit.org/show_bug.cgi?id=91818

Reviewed by Kent Tamura.

Source/WebCore:

Fix crash that occurs when setting slider appearance on a regular node.

Test: fast/forms/range/slider-appearance-crash.html

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks): Check if node is an input element.

LayoutTests:

* fast/forms/range/slider-appearance-crash-expected.txt: Added.
* fast/forms/range/slider-appearance-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTheme.cpp


Added Paths

trunk/LayoutTests/fast/forms/range/slider-appearance-crash-expected.txt
trunk/LayoutTests/fast/forms/range/slider-appearance-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123187 => 123188)

--- trunk/LayoutTests/ChangeLog	2012-07-20 07:42:57 UTC (rev 123187)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 07:46:00 UTC (rev 123188)
@@ -1,3 +1,13 @@
+2012-07-20  Keishi Hattori  kei...@webkit.org
+
+Fix crash in WebCore::HTMLInputElement::dataList
+https://bugs.webkit.org/show_bug.cgi?id=91818
+
+Reviewed by Kent Tamura.
+
+* fast/forms/range/slider-appearance-crash-expected.txt: Added.
+* fast/forms/range/slider-appearance-crash.html: Added.
+
 2012-07-20  Yoshifumi Inoue  yo...@chromium.org
 
 Unreviewed. Set svn:mime-type to image/png for PNG files without svn:mime-type.


Added: trunk/LayoutTests/fast/forms/range/slider-appearance-crash-expected.txt (0 => 123188)

--- trunk/LayoutTests/fast/forms/range/slider-appearance-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/range/slider-appearance-crash-expected.txt	2012-07-20 07:46:00 UTC (rev 123188)
@@ -0,0 +1,3 @@
+Checks that slider appearance on regular node doesn't crash.
+
+


Added: trunk/LayoutTests/fast/forms/range/slider-appearance-crash.html (0 => 123188)

--- trunk/LayoutTests/fast/forms/range/slider-appearance-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/range/slider-appearance-crash.html	2012-07-20 07:46:00 UTC (rev 123188)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+html
+body
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+pChecks that slider appearance on regular node doesn't crash./p
+style
+iframe {
+-webkit-appearance: slider-horizontal;
+}
+/style
+iframe
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (123187 => 123188)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 07:42:57 UTC (rev 123187)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 07:46:00 UTC (rev 123188)
@@ -1,3 +1,17 @@
+2012-07-20  Keishi Hattori  kei...@webkit.org
+
+Fix crash in WebCore::HTMLInputElement::dataList
+https://bugs.webkit.org/show_bug.cgi?id=91818
+
+Reviewed by Kent Tamura.
+
+Fix crash that occurs when setting slider appearance on a regular node.
+
+Test: fast/forms/range/slider-appearance-crash.html
+
+* rendering/RenderTheme.cpp:
+(WebCore::RenderTheme::paintSliderTicks): Check if node is an input element.
+
 2012-07-20  Kent Tamura  tk...@chromium.org
 
 [Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()


Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (123187 => 123188)

--- trunk/Source/WebCore/rendering/RenderTheme.cpp	2012-07-20 07:42:57 UTC (rev 123187)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp	2012-07-20 07:46:00 UTC (rev 123188)
@@ -963,7 +963,11 @@
 #if ENABLE(DATALIST)
 void RenderTheme::paintSliderTicks(RenderObject* o, const PaintInfo paintInfo, const IntRect rect)
 {
-HTMLInputElement* input = static_castHTMLInputElement*(o-node()-shadowAncestorNode());
+Node* node = o-node();
+if (!node)
+return;
+
+HTMLInputElement* input = node-toInputElement();
 if (!input)
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123190] trunk/LayoutTests

[yosin]

Title: [123190] trunk/LayoutTests








Revision 123190
Author yo...@chromium.org
Date 2012-07-20 00:56:46 -0700 (Fri, 20 Jul 2012)


Log Message
Unreviewed. Set svn:mime-type to image/png for PNG files without svn:mime-type.

* platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Added property svn:mime-type.
* platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added property svn:mime-type.
* platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added property svn:mime-type.

Modified Paths

trunk/LayoutTests/ChangeLog


Property Changed

trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png
trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png
trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (123189 => 123190)

--- trunk/LayoutTests/ChangeLog	2012-07-20 07:48:19 UTC (rev 123189)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 07:56:46 UTC (rev 123190)
@@ -1,3 +1,11 @@
+2012-07-20  Yoshifumi Inoue  yo...@chromium.org
+
+Unreviewed. Set svn:mime-type to image/png for PNG files without svn:mime-type.
+
+* platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Added property svn:mime-type.
+* platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added property svn:mime-type.
+* platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added property svn:mime-type.
+
 2012-07-20  Keishi Hattori  kei...@webkit.org
 
 Fix crash in WebCore::HTMLInputElement::dataList


Property changes: trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png



Added: svn:mime-type

Property changes: trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png



Added: svn:mime-type

Property changes: trunk/LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png



Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123191] trunk/Source/WebCore

[tkent]

Title: [123191] trunk/Source/WebCore








Revision 123191
Author tk...@chromium.org
Date 2012-07-20 01:03:59 -0700 (Fri, 20 Jul 2012)


Log Message
REGRESSION(r121420): Performance regression of form state saving for pages with multiple forms
https://bugs.webkit.org/show_bug.cgi?id=91804

Reviewed by Hajime Morita.

The complexity of FormKeyGenerator::formKey() was O(N) where N is the
number of form elements with an identical action URL, and formKey() is
called for every form. So, it's O(N^2). A page in www.reddit.com
contains hundreds of form elements with action="" So FormController::
formElementsState() took a few seconds on a slow machine.

In order to avoid O(N^2) operation, storing a map from form signatures
to next index numbers, instead of storing existing formKey strings.

No new tests. Just a performance improvement.

* html/FormController.cpp:
(FormKeyGenerator): Remove m_existingKeys. Add a map from a form
signature string to the next index number.
(WebCore::formSignature): Returns a signature string for a form, without
an index number. This is like actionURL [name1 name2 ]
(WebCore::FormKeyGenerator::formKey):
Creates a formKey string by concatenating a formSignature and #n. N is
obtained from m_formSignatureToNextIndexMap in O(1).
(WebCore::FormKeyGenerator::willDeleteForm):
Remove the code for m_existingKeys.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/FormController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123190 => 123191)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 07:56:46 UTC (rev 123190)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 08:03:59 UTC (rev 123191)
@@ -1,3 +1,32 @@
+2012-07-20  Kent Tamura  tk...@chromium.org
+
+REGRESSION(r121420): Performance regression of form state saving for pages with multiple forms
+https://bugs.webkit.org/show_bug.cgi?id=91804
+
+Reviewed by Hajime Morita.
+
+The complexity of FormKeyGenerator::formKey() was O(N) where N is the
+number of form elements with an identical action URL, and formKey() is
+called for every form. So, it's O(N^2). A page in www.reddit.com
+contains hundreds of form elements with action="" So FormController::
+formElementsState() took a few seconds on a slow machine.
+
+In order to avoid O(N^2) operation, storing a map from form signatures
+to next index numbers, instead of storing existing formKey strings.
+
+No new tests. Just a performance improvement.
+
+* html/FormController.cpp:
+(FormKeyGenerator): Remove m_existingKeys. Add a map from a form
+signature string to the next index number.
+(WebCore::formSignature): Returns a signature string for a form, without
+an index number. This is like actionURL [name1 name2 ]
+(WebCore::FormKeyGenerator::formKey):
+Creates a formKey string by concatenating a formSignature and #n. N is
+obtained from m_formSignatureToNextIndexMap in O(1).
+(WebCore::FormKeyGenerator::willDeleteForm):
+Remove the code for m_existingKeys.
+
 2012-07-20  Keishi Hattori  kei...@webkit.org
 
 Fix crash in WebCore::HTMLInputElement::dataList


Modified: trunk/Source/WebCore/html/FormController.cpp (123190 => 123191)

--- trunk/Source/WebCore/html/FormController.cpp	2012-07-20 07:56:46 UTC (rev 123190)
+++ trunk/Source/WebCore/html/FormController.cpp	2012-07-20 08:03:59 UTC (rev 123191)
@@ -278,8 +278,9 @@
 FormKeyGenerator() { }
 
 typedef HashMapHTMLFormElement*, AtomicString FormToKeyMap;
+typedef HashMapString, unsigned FormSignatureToNextIndexMap;
 FormToKeyMap m_formToKeyMap;
-HashSetAtomicString m_existingKeys;
+FormSignatureToNextIndexMap m_formSignatureToNextIndexMap;
 };
 
 static inline void recordFormStructure(const HTMLFormElement form, StringBuilder builder)
@@ -304,10 +305,9 @@
 builder.append(]);
 }
 
-static inline AtomicString createKey(HTMLFormElement* form, unsigned index)
+static inline String formSignature(const HTMLFormElement form)
 {
-ASSERT(form);
-KURL actionURL = form-getURLAttribute(actionAttr);
+KURL actionURL = form.getURLAttribute(actionAttr);
 // Remove the query part because it might contain volatile parameters such
 // as a session key.
 actionURL.setQuery(String());
@@ -315,11 +315,8 @@
 if (!actionURL.isEmpty())
 builder.append(actionURL.string());
 
-recordFormStructure(*form, builder);
-
-builder.append( #);
-builder.append(String::number(index));
-return builder.toAtomicString();
+recordFormStructure(form, builder);
+return builder.toString();
 }
 
 AtomicString FormKeyGenerator::formKey(const HTMLFormControlElementWithState control)
@@ -333,13 +330,18 @@
 if (it != m_formToKeyMap.end())
 return it-second;
 
-AtomicString candidateKey;
-unsigned index = 0;
-do {
-candidateKey = createKey(form, index++);
-} while 

[webkit-changes] [123192] trunk

[shinyak]

Title: [123192] trunk








Revision 123192
Author shin...@chromium.org
Date 2012-07-20 01:06:36 -0700 (Fri, 20 Jul 2012)


Log Message
Needs pseudo id to point the inner element of an img elemnet for styling
https://bugs.webkit.org/show_bug.cgi?id=91590

Reviewed by Hajime Morita.

Source/WebCore:

We introduce pseudo id to point the element in UserAgentShadowDOM.
This enables us to style the inner element of an img element shadow.
Please see also http://trac.webkit.org/wiki/ShadowDOMForReplacedElements

Test: fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html

* html/shadow/ImageInnerElement.cpp:
(WebCore::ImageInnerElement::shadowPseudoId):
(WebCore):
* html/shadow/ImageInnerElement.h:
(ImageInnerElement):

LayoutTests:

Uses pseudo id to confirm the style is applied to the inner element of an img element shadow.

* fast/dom/shadow/shadowdom-for-image-with-pseudo-id-expected.html: Added.
* fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/ImageInnerElement.cpp
trunk/Source/WebCore/html/shadow/ImageInnerElement.h


Added Paths

trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-pseudo-id-expected.html
trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123191 => 123192)

--- trunk/LayoutTests/ChangeLog	2012-07-20 08:03:59 UTC (rev 123191)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 08:06:36 UTC (rev 123192)
@@ -1,3 +1,15 @@
+2012-07-20  Shinya Kawanaka  shin...@chromium.org
+
+Needs pseudo id to point the inner element of an img elemnet for styling
+https://bugs.webkit.org/show_bug.cgi?id=91590
+
+Reviewed by Hajime Morita.
+
+Uses pseudo id to confirm the style is applied to the inner element of an img element shadow.
+
+* fast/dom/shadow/shadowdom-for-image-with-pseudo-id-expected.html: Added.
+* fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html: Added.
+
 2012-07-20  Yoshifumi Inoue  yo...@chromium.org
 
 Unreviewed. Set svn:mime-type to image/png for PNG files without svn:mime-type.


Added: trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-pseudo-id-expected.html (0 => 123192)

--- trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-pseudo-id-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-pseudo-id-expected.html	2012-07-20 08:06:36 UTC (rev 123192)
@@ -0,0 +1,10 @@
+!DOCTYPE html
+html
+body
+div id=container
+div
+div style=display: inline-block(before)img src="" width=100 height=100(after)/div
+/div
+/div
+/body
+/html


Added: trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html (0 => 123192)

--- trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html	2012-07-20 08:06:36 UTC (rev 123192)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+body
+script src=""
+style
+#host::-webkit-image-inner-element {
+width: 100px;
+height: 100px;
+}
+/style
+
+div id=container
+div
+img id=host src=""
+/div
+/div
+
+script
+function addShadowDOM(host) {
+var shadowRoot = new WebKitShadowRoot(host);
+shadowRoot.innerHTML = (before)shadow/shadow(after);
+}
+
+addShadowDOM(host);
+/script
+
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (123191 => 123192)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 08:03:59 UTC (rev 123191)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 08:06:36 UTC (rev 123192)
@@ -1,3 +1,22 @@
+2012-07-20  Shinya Kawanaka  shin...@chromium.org
+
+Needs pseudo id to point the inner element of an img elemnet for styling
+https://bugs.webkit.org/show_bug.cgi?id=91590
+
+Reviewed by Hajime Morita.
+
+We introduce pseudo id to point the element in UserAgentShadowDOM.
+This enables us to style the inner element of an img element shadow.
+Please see also http://trac.webkit.org/wiki/ShadowDOMForReplacedElements
+
+Test: fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html
+
+* html/shadow/ImageInnerElement.cpp:
+(WebCore::ImageInnerElement::shadowPseudoId):
+(WebCore):
+* html/shadow/ImageInnerElement.h:
+(ImageInnerElement):
+
 2012-07-20  Kent Tamura  tk...@chromium.org
 
 REGRESSION(r121420): Performance regression of form state saving for pages with multiple forms


Modified: trunk/Source/WebCore/html/shadow/ImageInnerElement.cpp (123191 => 123192)

--- trunk/Source/WebCore/html/shadow/ImageInnerElement.cpp	2012-07-20 08:03:59 UTC (rev 123191)
+++ trunk/Source/WebCore/html/shadow/ImageInnerElement.cpp	2012-07-20 08:06:36 UTC (rev 123192)
@@ -68,4 +68,10 @@
 return createRendererForImage(this, arena);
 }
 
+const AtomicString 

[webkit-changes] [123193] trunk

[commit-queue]

Title: [123193] trunk








Revision 123193
Author commit-qu...@webkit.org
Date 2012-07-20 01:28:37 -0700 (Fri, 20 Jul 2012)


Log Message
Show or hide dialog depending on the open attribute
https://bugs.webkit.org/show_bug.cgi?id=90931

Patch by Matt Falkenhagen fal...@chromium.org on 2012-07-20
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/dom/HTMLDialogElement/dialog-open.html

* css/html.css: Add CSS for dialog. This is copied verbatim from the HTML5 spec: http://www.whatwg.org/specs/web-apps/current-work/#flow-content-1
(dialog:not([open])):
(dialog):
* html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::close): Set open to false, to hide the dialog.
(WebCore::HTMLDialogElement::show): Set open to true, to show the dialog.
(WebCore):
(WebCore::HTMLDialogElement::isPresentationAttribute): Make openAttr a presentation attribute, to work around bug 91058
* html/HTMLDialogElement.h:
(HTMLDialogElement):
* html/HTMLDialogElement.idl:

LayoutTests:

* fast/dom/HTMLDialogElement/dialog-open-expected.txt: Added.
* fast/dom/HTMLDialogElement/dialog-open.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css
trunk/Source/WebCore/html/HTMLDialogElement.cpp
trunk/Source/WebCore/html/HTMLDialogElement.h
trunk/Source/WebCore/html/HTMLDialogElement.idl


Added Paths

trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-open-expected.txt
trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-open.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123192 => 123193)

--- trunk/LayoutTests/ChangeLog	2012-07-20 08:06:36 UTC (rev 123192)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 08:28:37 UTC (rev 123193)
@@ -1,3 +1,13 @@
+2012-07-20  Matt Falkenhagen  fal...@chromium.org
+
+Show or hide dialog depending on the open attribute
+https://bugs.webkit.org/show_bug.cgi?id=90931
+
+Reviewed by Kent Tamura.
+
+* fast/dom/HTMLDialogElement/dialog-open-expected.txt: Added.
+* fast/dom/HTMLDialogElement/dialog-open.html: Added.
+
 2012-07-20  Shinya Kawanaka  shin...@chromium.org
 
 Needs pseudo id to point the inner element of an img elemnet for styling


Added: trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-open-expected.txt (0 => 123193)

--- trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-open-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-open-expected.txt	2012-07-20 08:28:37 UTC (rev 123193)
@@ -0,0 +1,13 @@
+Tests that dialog is visible after show() is called and not visible after close() is called. bug 90931
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('display') is 'none'
+PASS computedStyle.getPropertyValue('display') is 'block'
+PASS computedStyle.getPropertyValue('display') is 'none'
+PASS dialog.close(); threw exception Error: INVALID_STATE_ERR: DOM Exception 11.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-open.html (0 => 123193)

--- trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-open.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLDialogElement/dialog-open.html	2012-07-20 08:28:37 UTC (rev 123193)
@@ -0,0 +1,31 @@
+!DOCTYPE html
+html
+head
+script src=""
+script
+if (window.internals)
+internals.settings.setDialogElementEnabled(true);
+/script
+/head
+body
+dialog id=mydialogIt's my dialog./dialog
+script
+description(Tests that dialog is visible after show() is called and not visible after close() is called. bug 90931);
+
+dialog = document.getElementById('mydialog');
+computedStyle = window.getComputedStyle(dialog, null);
+shouldBe(computedStyle.getPropertyValue('display'), 'none');
+
+dialog.show();
+computedStyle = window.getComputedStyle(dialog, null);
+shouldBe(computedStyle.getPropertyValue('display'), 'block');
+
+dialog.close();
+computedStyle = window.getComputedStyle(dialog, null);
+
+shouldBe(computedStyle.getPropertyValue('display'), 'none');
+shouldThrow('dialog.close();', 'Error: INVALID_STATE_ERR: DOM Exception 11');
+/script
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (123192 => 123193)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 08:06:36 UTC (rev 123192)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 08:28:37 UTC (rev 123193)
@@ -1,3 +1,24 @@
+2012-07-20  Matt Falkenhagen  fal...@chromium.org
+
+Show or hide dialog depending on the open attribute
+https://bugs.webkit.org/show_bug.cgi?id=90931
+
+Reviewed by Kent Tamura.
+
+Test: fast/dom/HTMLDialogElement/dialog-open.html
+
+* css/html.css: Add CSS for dialog. This is copied verbatim from the HTML5 spec: http://www.whatwg.org/specs/web-apps/current-work/#flow-content-1
+(dialog:not([open])):
+(dialog):
+* html/HTMLDialogElement.cpp:
+(WebCore::HTMLDialogElement::close): Set open to 

[webkit-changes] [123194] trunk

[kinuko]

Title: [123194] trunk








Revision 123194
Author kin...@chromium.org
Date 2012-07-20 01:41:16 -0700 (Fri, 20 Jul 2012)


Log Message
If value for responseType defined as type that not supported, it should not throw an exception in XHR 2
https://bugs.webkit.org/show_bug.cgi?id=90976

Reviewed by Alexey Proskuryakov.

Source/WebCore:

http://www.w3.org/TR/XMLHttpRequest2/#the-responsetype-attribute
The spec does not say it should throw an exception when a non-supported
type is set, and other browsers do not throw it either.

Test: fast/xmlhttprequest/xmlhttprequest-responsetype-set-type.html

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setResponseType): Stop throwing an exception when non-supported type is given.

LayoutTests:

Adding tests to see if setting invalid responseType does not throw an exception and does not change the value.

* fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html: Removed a line which tries to set invalid type (since we now have a separate test)

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XMLHttpRequest.cpp


Added Paths

trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt
trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123193 => 123194)

--- trunk/LayoutTests/ChangeLog	2012-07-20 08:28:37 UTC (rev 123193)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 08:41:16 UTC (rev 123194)
@@ -1,3 +1,17 @@
+2012-07-17  Kinuko Yasuda  kin...@chromium.org
+
+If value for responseType defined as type that not supported, it should not throw an exception in XHR 2
+https://bugs.webkit.org/show_bug.cgi?id=90976
+
+Reviewed by Alexey Proskuryakov.
+
+Adding tests to see if setting invalid responseType does not throw an exception and does not change the value.
+
+* fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt: Added.
+* fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html: Added.
+* fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
+* fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html: Removed a line which tries to set invalid type (since we now have a separate test)
+
 2012-07-20  Matt Falkenhagen  fal...@chromium.org
 
 Show or hide dialog depending on the open attribute


Modified: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt (123193 => 123194)

--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt	2012-07-20 08:28:37 UTC (rev 123193)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt	2012-07-20 08:41:16 UTC (rev 123194)
@@ -10,7 +10,6 @@
 PASS xhr.responseType has been correctly set to 'text'.
 PASS xhr.responseType has been correctly set to 'document'.
 PASS xhr.responseType has been correctly set to 'arraybuffer'.
-PASS exception correctly thrown when xhr.responseType is set to invalid value : Error: SYNTAX_ERR: DOM Exception 12.
 PASS 'arraybuffer' .response does not exist when .readyState is 2.
 PASS 'arraybuffer' .response does not exist when .readyState is 3.
 PASS 'arraybuffer' .response exists when .readyState is 4.


Modified: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html (123193 => 123194)

--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html	2012-07-20 08:28:37 UTC (rev 123193)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html	2012-07-20 08:41:16 UTC (rev 123194)
@@ -138,13 +138,6 @@
 } catch(e) {
 testFailed(unable to set xhr.responseType to a valid value  + e + .);
 }
-
-// Make sure exception is thrown if responseType is set to invalid value.
-try {
-xhr.responseType = dkjdfkjdfkj;
-} catch(e) {
-testPassed(exception correctly thrown when xhr.responseType is set to invalid value :  + e + .);
-}
 } catch(e) {
 testFailed(Caught exception  + e + .);
 }


Added: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt (0 => 123194)

--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt	(rev 0)
+++ 

[webkit-changes] [123195] trunk/Source/WebCore

[morrita]

Title: [123195] trunk/Source/WebCore








Revision 123195
Author morr...@google.com
Date 2012-07-20 02:13:10 -0700 (Fri, 20 Jul 2012)


Log Message
Unreviewed Mac build fix against r123184.

* WebCore.exp.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (123194 => 123195)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 08:41:16 UTC (rev 123194)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 09:13:10 UTC (rev 123195)
@@ -1,3 +1,9 @@
+2012-07-20  MORITA Hajime  morr...@google.com
+
+Unreviewed Mac build fix against r123184.
+
+* WebCore.exp.in:
+
 2012-07-17  Kinuko Yasuda  kin...@chromium.org
 
 If value for responseType defined as type that not supported, it should not throw an exception in XHR 2


Modified: trunk/Source/WebCore/WebCore.exp.in (123194 => 123195)

--- trunk/Source/WebCore/WebCore.exp.in	2012-07-20 08:41:16 UTC (rev 123194)
+++ trunk/Source/WebCore/WebCore.exp.in	2012-07-20 09:13:10 UTC (rev 123195)
@@ -1944,6 +1944,7 @@
 __ZNK7WebCore17RenderTextControl23visiblePositionForIndexEi
 __ZNK7WebCore4Node18rendererIsEditableENS0_13EditableLevelE
 __ZNK7WebCore4Node27traverseNextAncestorSiblingEPKS0_
+__ZNK7WebCore4Node9treeScopeEv
 __ZNK7WebCore5Frame12updateLayoutEv
 __ZNK7WebCore5Frame13documentScaleEv
 __ZNK7WebCore5Frame15innerLineHeightEP7DOMNode






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123197] trunk/Source/WebCore

[morrita]

Title: [123197] trunk/Source/WebCore








Revision 123197
Author morr...@google.com
Date 2012-07-20 02:30:07 -0700 (Fri, 20 Jul 2012)


Log Message
Another unreviewed Mac build fix against r123184.

* WebCore.exp.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (123196 => 123197)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 09:23:56 UTC (rev 123196)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 09:30:07 UTC (rev 123197)
@@ -1,3 +1,9 @@
+2012-07-20  MORITA Hajime  morr...@google.com
+
+Another unreviewed Mac build fix against r123184.
+
+* WebCore.exp.in:
+
 2012-07-20  Mihnea Ovidenie  mih...@adobe.com
 
 [CSSRegions]Crash when flowing a region into itself


Modified: trunk/Source/WebCore/WebCore.exp.in (123196 => 123197)

--- trunk/Source/WebCore/WebCore.exp.in	2012-07-20 09:23:56 UTC (rev 123196)
+++ trunk/Source/WebCore/WebCore.exp.in	2012-07-20 09:30:07 UTC (rev 123197)
@@ -1274,7 +1274,6 @@
 __ZNK7WebCore4Node27traverseNextAncestorSiblingEv
 __ZNK7WebCore4Node31numberOfScopedHTMLStyleChildrenEv
 __ZNK7WebCore4Node9nodeIndexEv
-__ZNK7WebCore4Node9treeScopeEv
 __ZNK7WebCore4Page10pluginDataEv
 __ZNK7WebCore4Page14renderTreeSizeEv
 __ZNK7WebCore4Page15backForwardListEv
@@ -1944,7 +1943,6 @@
 __ZNK7WebCore17RenderTextControl23visiblePositionForIndexEi
 __ZNK7WebCore4Node18rendererIsEditableENS0_13EditableLevelE
 __ZNK7WebCore4Node27traverseNextAncestorSiblingEPKS0_
-__ZNK7WebCore4Node9treeScopeEv
 __ZNK7WebCore5Frame12updateLayoutEv
 __ZNK7WebCore5Frame13documentScaleEv
 __ZNK7WebCore5Frame15innerLineHeightEP7DOMNode






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123198] trunk

[commit-queue]

Title: [123198] trunk








Revision 123198
Author commit-qu...@webkit.org
Date 2012-07-20 02:41:35 -0700 (Fri, 20 Jul 2012)


Log Message
Web Inspector: Timeline: forward compatibility for load.
https://bugs.webkit.org/show_bug.cgi?id=91714

Patch by Eugene Klyuchnikov eustas@gmail.com on 2012-07-20
Reviewed by Pavel Feldman.

Accept records of unrecognized types and render them as unknown.

Source/WebCore:

Test: inspector/timeline/timeline-load-incompatible.html

* English.lproj/localizedStrings.js: Added UI string.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.recordStyle): Add missing record
styles at runtime.
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
Add some common information for default case.

LayoutTests:

* inspector/timeline/timeline-load-incompatible-expected.txt: Added.
* inspector/timeline/timeline-load-incompatible.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js


Added Paths

trunk/LayoutTests/inspector/timeline/timeline-load-incompatible-expected.txt
trunk/LayoutTests/inspector/timeline/timeline-load-incompatible.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123197 => 123198)

--- trunk/LayoutTests/ChangeLog	2012-07-20 09:30:07 UTC (rev 123197)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 09:41:35 UTC (rev 123198)
@@ -1,3 +1,15 @@
+2012-07-20  Eugene Klyuchnikov  eustas@gmail.com
+
+Web Inspector: Timeline: forward compatibility for load.
+https://bugs.webkit.org/show_bug.cgi?id=91714
+
+Reviewed by Pavel Feldman.
+
+Accept records of unrecognized types and render them as unknown.
+
+* inspector/timeline/timeline-load-incompatible-expected.txt: Added.
+* inspector/timeline/timeline-load-incompatible.html: Added.
+
 2012-07-20  Mihnea Ovidenie  mih...@adobe.com
 
 [CSSRegions]Crash when flowing a region into itself


Added: trunk/LayoutTests/inspector/timeline/timeline-load-incompatible-expected.txt (0 => 123198)

--- trunk/LayoutTests/inspector/timeline/timeline-load-incompatible-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/timeline/timeline-load-incompatible-expected.txt	2012-07-20 09:41:35 UTC (rev 123198)
@@ -0,0 +1,5 @@
+Tests the Timeline save/load of unknown (incompatible) record types.
+
+Bug 91714
+passed
+


Added: trunk/LayoutTests/inspector/timeline/timeline-load-incompatible.html (0 => 123198)

--- trunk/LayoutTests/inspector/timeline/timeline-load-incompatible.html	(rev 0)
+++ trunk/LayoutTests/inspector/timeline/timeline-load-incompatible.html	2012-07-20 09:41:35 UTC (rev 123198)
@@ -0,0 +1,46 @@
+html
+head
+script src=""
+script src=""
+script
+
+function test()
+{
+WebInspector.showPanel(timeline);
+InspectorTest.addSniffer(WebInspector.TimelineModel.prototype, _loadNextChunk, loadNextChunk);
+InspectorFrontendHost.save = save;
+var data = ""
+
+try {
+WebInspector.panels.timeline._model._loadNextChunk(data, 0);
+} catch (e) {
+InspectorTest.addResult(failed);
+InspectorTest.completeTest();
+}
+
+function loadNextChunk()
+{
+WebInspector.panels.timeline._model.saveToFile();
+}
+
+function save(name, saveData, saveAs)
+{
+saveData = JSON.parse(saveData);
+saveData.shift(); // strip version info
+if (JSON.stringify(data) == JSON.stringify(saveData))
+InspectorTest.addResult(passed);
+else
+InspectorTest.addResult(saved data is not equal to restored);
+InspectorTest.completeTest();
+}
+}
+
+/script
+/head
+
+body _onload_=runTest()
+pTests the Timeline save/load of unknown (incompatible) record types./p
+a href="" 91714/a
+
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (123197 => 123198)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 09:30:07 UTC (rev 123197)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 09:41:35 UTC (rev 123198)
@@ -1,3 +1,21 @@
+2012-07-20  Eugene Klyuchnikov  eustas@gmail.com
+
+Web Inspector: Timeline: forward compatibility for load.
+https://bugs.webkit.org/show_bug.cgi?id=91714
+
+Reviewed by Pavel Feldman.
+
+Accept records of unrecognized types and render them as unknown.
+
+Test: inspector/timeline/timeline-load-incompatible.html
+
+* English.lproj/localizedStrings.js: Added UI string.
+* inspector/front-end/TimelinePresentationModel.js:
+(WebInspector.TimelinePresentationModel.recordStyle): Add missing record
+styles at runtime.
+(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
+Add some common information for default case.
+
 2012-07-20  MORITA Hajime  morr...@google.com
 
 Another unreviewed Mac 

[webkit-changes] [123199] trunk/Source/WebKit2

[commit-queue]

Title: [123199] trunk/Source/WebKit2








Revision 123199
Author commit-qu...@webkit.org
Date 2012-07-20 03:17:05 -0700 (Fri, 20 Jul 2012)


Log Message
[EFL][WK2] Use load,finished signal in EWK2UnitTestBase::loadUrlSync() instead of load,progress
https://bugs.webkit.org/show_bug.cgi?id=91721

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

The purpose of EWK2UnitTestBase::loadUrlSync() is to load
a URL in the view and wait synchronously for the load to finish.
The current implementation uses the load,progress signal to
detect when the load is finished, which is inefficient because
it gets emitted several times.

It is better to wait for the load,finished signal which gets
emitted only once when the load is complete.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::onLoadFinished):
(EWK2UnitTest::EWK2UnitTestBase::EWK2UnitTestBase):
(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (123198 => 123199)

--- trunk/Source/WebKit2/ChangeLog	2012-07-20 09:41:35 UTC (rev 123198)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-20 10:17:05 UTC (rev 123199)
@@ -1,3 +1,26 @@
+2012-07-20  Christophe Dumez  christophe.du...@intel.com
+
+[EFL][WK2] Use load,finished signal in EWK2UnitTestBase::loadUrlSync() instead of load,progress
+https://bugs.webkit.org/show_bug.cgi?id=91721
+
+Reviewed by Kenneth Rohde Christiansen.
+
+The purpose of EWK2UnitTestBase::loadUrlSync() is to load
+a URL in the view and wait synchronously for the load to finish.
+The current implementation uses the load,progress signal to
+detect when the load is finished, which is inefficient because
+it gets emitted several times.
+
+It is better to wait for the load,finished signal which gets
+emitted only once when the load is complete.
+
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
+(EWK2UnitTest::onLoadFinished):
+(EWK2UnitTest::EWK2UnitTestBase::EWK2UnitTestBase):
+(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
+(EWK2UnitTestBase):
+
 2012-07-19  MORITA Hajime  morr...@google.com
 
 [Refactoring] Replace Node's Document pointer with a TreeScope pointer


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp (123198 => 123199)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2012-07-20 09:41:35 UTC (rev 123198)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp	2012-07-20 10:17:05 UTC (rev 123199)
@@ -29,19 +29,17 @@
 
 namespace EWK2UnitTest {
 
-static void onLoadProgress(void* userData, Evas_Object* webView, void* eventInfo)
+static void onLoadFinished(void* userData, Evas_Object* webView, void* eventInfo)
 {
 UNUSED_PARAM(webView);
+UNUSED_PARAM(eventInfo);
 
-EWK2UnitTestBase* test = static_castEWK2UnitTestBase*(userData);
-double progress = *static_castdouble*(eventInfo);
-
-test-setLoadProgress(progress);
+bool* loadFinished = static_castbool*(userData);
+*loadFinished = true;
 }
 
 EWK2UnitTestBase::EWK2UnitTestBase()
-: m_loadProgress(0)
-, m_ecoreEvas(0)
+: m_ecoreEvas(0)
 , m_webView(0)
 {
 }
@@ -78,15 +76,15 @@
 
 void EWK2UnitTestBase::loadUrlSync(const char* url)
 {
-m_loadProgress = 0;
+bool loadFinished = false;
 
-evas_object_smart_callback_add(m_webView, load,progress, onLoadProgress, this);
+evas_object_smart_callback_add(m_webView, load,finished, onLoadFinished, loadFinished);
 ewk_view_uri_set(m_webView, url);
 
-while (m_loadProgress != 1)
+while (!loadFinished)
 ecore_main_loop_iterate();
 
-evas_object_smart_callback_del(m_webView, load,progress, onLoadProgress);
+evas_object_smart_callback_del(m_webView, load,finished, onLoadFinished);
 }
 
 } // namespace EWK2UnitTest


Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h (123198 => 123199)

--- trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h	2012-07-20 09:41:35 UTC (rev 123198)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h	2012-07-20 10:17:05 UTC (rev 123199)
@@ -28,7 +28,6 @@
 
 class EWK2UnitTestBase : public ::testing::Test {
 public:
-void setLoadProgress(float progress) { m_loadProgress = progress; }
 Evas_Object* webView() { return m_webView; }
 
 protected:
@@ -42,8 +41,6 @@
 private:
 Evas_Object* m_webView;
 Ecore_Evas* m_ecoreEvas;

[webkit-changes] [123202] trunk/Source/WebKit/efl

[commit-queue]

Title: [123202] trunk/Source/WebKit/efl








Revision 123202
Author commit-qu...@webkit.org
Date 2012-07-20 04:26:48 -0700 (Fri, 20 Jul 2012)


Log Message
[EFL] Check parameters of ewk APIs in ewk_security_origin
https://bugs.webkit.org/show_bug.cgi?id=91833

Patch by Kihong Kwon kihong.k...@samsung.com on 2012-07-20
Reviewed by Kentaro Hara.

For preventing crash, check parameters of ewk APIs in the ewk_security_origin.cpp.

* ewk/ewk_security_origin.cpp:
(ewk_security_origin_port_get):
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
(ewk_security_origin_web_database_quota_set):
(ewk_security_origin_application_cache_quota_set):
(ewk_security_origin_application_cache_clear):
(ewk_security_origin_web_database_get_all):
(ewk_security_origin_free):
* ewk/ewk_security_origin.h:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_security_origin.cpp
trunk/Source/WebKit/efl/ewk/ewk_security_origin.h




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (123201 => 123202)

--- trunk/Source/WebKit/efl/ChangeLog	2012-07-20 11:25:08 UTC (rev 123201)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-07-20 11:26:48 UTC (rev 123202)
@@ -1,3 +1,23 @@
+2012-07-20  Kihong Kwon  kihong.k...@samsung.com
+
+[EFL] Check parameters of ewk APIs in ewk_security_origin
+https://bugs.webkit.org/show_bug.cgi?id=91833
+
+Reviewed by Kentaro Hara.
+
+For preventing crash, check parameters of ewk APIs in the ewk_security_origin.cpp.
+
+* ewk/ewk_security_origin.cpp:
+(ewk_security_origin_port_get):
+(ewk_security_origin_web_database_usage_get):
+(ewk_security_origin_web_database_quota_get):
+(ewk_security_origin_web_database_quota_set):
+(ewk_security_origin_application_cache_quota_set):
+(ewk_security_origin_application_cache_clear):
+(ewk_security_origin_web_database_get_all):
+(ewk_security_origin_free):
+* ewk/ewk_security_origin.h:
+
 2012-07-19  Kihong Kwon  kihong.k...@samsung.com
 
 [EFL] Enable interactive form validation


Modified: trunk/Source/WebKit/efl/ewk/ewk_security_origin.cpp (123201 => 123202)

--- trunk/Source/WebKit/efl/ewk/ewk_security_origin.cpp	2012-07-20 11:25:08 UTC (rev 123201)
+++ trunk/Source/WebKit/efl/ewk/ewk_security_origin.cpp	2012-07-20 11:26:48 UTC (rev 123202)
@@ -60,11 +60,14 @@
 
 uint32_t ewk_security_origin_port_get(const Ewk_Security_Origin* origin)
 {
+EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0);
 return origin-securityOrigin-port();
 }
 
 uint64_t ewk_security_origin_web_database_usage_get(const Ewk_Security_Origin* origin)
 {
+EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0);
+
 #if ENABLE(SQL_DATABASE)
 return WebCore::DatabaseTracker::tracker().usageForOrigin(origin-securityOrigin.get());
 #else
@@ -74,6 +77,8 @@
 
 uint64_t ewk_security_origin_web_database_quota_get(const Ewk_Security_Origin* origin)
 {
+EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0);
+
 #if ENABLE(SQL_DATABASE)
 return WebCore::DatabaseTracker::tracker().quotaForOrigin(origin-securityOrigin.get());
 #else
@@ -83,6 +88,8 @@
 
 void ewk_security_origin_web_database_quota_set(const Ewk_Security_Origin* origin, uint64_t quota)
 {
+EINA_SAFETY_ON_NULL_RETURN(origin);
+
 #if ENABLE(SQL_DATABASE)
 WebCore::DatabaseTracker::tracker().setQuota(origin-securityOrigin.get(), quota);
 #endif
@@ -90,16 +97,20 @@
 
 void ewk_security_origin_application_cache_quota_set(const Ewk_Security_Origin* origin, int64_t quota)
 {
+EINA_SAFETY_ON_NULL_RETURN(origin);
 WebCore::cacheStorage().storeUpdatedQuotaForOrigin(origin-securityOrigin.get(), quota);
 }
 
 void ewk_security_origin_application_cache_clear(const Ewk_Security_Origin* origin)
 {
+EINA_SAFETY_ON_NULL_RETURN(origin);
 WebCore::ApplicationCache::deleteCacheForOrigin(origin-securityOrigin.get());
 }
 
 Eina_List* ewk_security_origin_web_database_get_all(const Ewk_Security_Origin* origin)
 {
+EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0);
+
 Eina_List* databases = 0;
 #if ENABLE(SQL_DATABASE)
 VectorWTF::String names;
@@ -119,6 +130,8 @@
 
 void ewk_security_origin_free(Ewk_Security_Origin* origin)
 {
+EINA_SAFETY_ON_NULL_RETURN(origin);
+
 origin-securityOrigin = 0;
 eina_stringshare_del(origin-host);
 eina_stringshare_del(origin-protocol);


Modified: trunk/Source/WebKit/efl/ewk/ewk_security_origin.h (123201 => 123202)

--- trunk/Source/WebKit/efl/ewk/ewk_security_origin.h	2012-07-20 11:25:08 UTC (rev 123201)
+++ trunk/Source/WebKit/efl/ewk/ewk_security_origin.h	2012-07-20 11:26:48 UTC (rev 123202)
@@ -81,7 +81,7 @@
  *
  * @param o security origin object
  *
- * @return the port
+ * @return the port or @c 0 if there is not a proper security origin scheme
  */
 EAPI uint32_t ewk_security_origin_port_get(const Ewk_Security_Origin *o);
 
@@ -91,7 +91,7 @@
  * This function won't work if Web SQL Database was not enabled when
  

[webkit-changes] [123203] trunk/Tools

[commit-queue]

Title: [123203] trunk/Tools








Revision 123203
Author commit-qu...@webkit.org
Date 2012-07-20 04:31:06 -0700 (Fri, 20 Jul 2012)


Log Message
[EFL][WK2][WTR] Implement EventSenderProxy
https://bugs.webkit.org/show_bug.cgi?id=91731

Patch by Kangil Han kangil@samsung.com on 2012-07-20
Reviewed by Kentaro Hara.

This is an initial EFL port implementation of EventSenderProxy.

* WebKitTestRunner/EventSenderProxy.h:
(WTR):
(EventSenderProxy):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/PlatformEfl.cmake:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added.
(WTR):
(WTREvent):
(WTR::WTREvent::WTREvent):
(WTR::KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(WTR::evasMouseButton):
(WTR::setEvasModifiers):
(WTR::dispatchMouseDownEvent):
(WTR::dispatchMouseUpEvent):
(WTR::dispatchMouseMoveEvent):
(WTR::dispatchMouseScrollByEvent):
(WTR::keyPadName):
(WTR::keyName):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::dispatchEvent):
(WTR::EventSenderProxy::replaySavedEvents):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):
(WTR::EventSenderProxy::setTouchPointRadius):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/EventSenderProxy.h
trunk/Tools/WebKitTestRunner/InjectedBundle/EventSendingController.h
trunk/Tools/WebKitTestRunner/PlatformEfl.cmake
trunk/Tools/WebKitTestRunner/TestController.cpp


Added Paths

trunk/Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp




Diff

Modified: trunk/Tools/ChangeLog (123202 => 123203)

--- trunk/Tools/ChangeLog	2012-07-20 11:26:48 UTC (rev 123202)
+++ trunk/Tools/ChangeLog	2012-07-20 11:31:06 UTC (rev 123203)
@@ -1,3 +1,57 @@
+2012-07-20  Kangil Han  kangil@samsung.com
+
+[EFL][WK2][WTR] Implement EventSenderProxy
+https://bugs.webkit.org/show_bug.cgi?id=91731
+
+Reviewed by Kentaro Hara.
+
+This is an initial EFL port implementation of EventSenderProxy.
+
+* WebKitTestRunner/EventSenderProxy.h:
+(WTR):
+(EventSenderProxy):
+* WebKitTestRunner/InjectedBundle/EventSendingController.h:
+* WebKitTestRunner/PlatformEfl.cmake:
+* WebKitTestRunner/TestController.cpp:
+(WTR::TestController::TestController):
+(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
+* WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added.
+(WTR):
+(WTREvent):
+(WTR::WTREvent::WTREvent):
+(WTR::KeyEventInfo::KeyEventInfo):
+(KeyEventInfo):
+(WTR::evasMouseButton):
+(WTR::setEvasModifiers):
+(WTR::dispatchMouseDownEvent):
+(WTR::dispatchMouseUpEvent):
+(WTR::dispatchMouseMoveEvent):
+(WTR::dispatchMouseScrollByEvent):
+(WTR::keyPadName):
+(WTR::keyName):
+(WTR::EventSenderProxy::EventSenderProxy):
+(WTR::EventSenderProxy::updateClickCountForButton):
+(WTR::EventSenderProxy::dispatchEvent):
+(WTR::EventSenderProxy::replaySavedEvents):
+(WTR::EventSenderProxy::sendOrQueueEvent):
+(WTR::EventSenderProxy::mouseDown):
+(WTR::EventSenderProxy::mouseUp):
+(WTR::EventSenderProxy::mouseMoveTo):
+(WTR::EventSenderProxy::mouseScrollBy):
+(WTR::EventSenderProxy::leapForward):
+(WTR::EventSenderProxy::keyDown):
+(WTR::EventSenderProxy::addTouchPoint):
+(WTR::EventSenderProxy::updateTouchPoint):
+(WTR::EventSenderProxy::setTouchModifier):
+(WTR::EventSenderProxy::touchStart):
+(WTR::EventSenderProxy::touchMove):
+(WTR::EventSenderProxy::touchEnd):
+(WTR::EventSenderProxy::touchCancel):
+(WTR::EventSenderProxy::clearTouchPoints):
+(WTR::EventSenderProxy::releaseTouchPoint):
+(WTR::EventSenderProxy::cancelTouchPoint):
+(WTR::EventSenderProxy::setTouchPointRadius):
+
 2012-07-20  Gyuyoung Kim  gyuyoung@samsung.com
 
 Unreviewed, rolling out r123085.


Modified: trunk/Tools/WebKitTestRunner/EventSenderProxy.h (123202 => 123203)

--- trunk/Tools/WebKitTestRunner/EventSenderProxy.h	2012-07-20 11:26:48 UTC (rev 123202)
+++ 

[webkit-changes] [123204] trunk/LayoutTests

[commit-queue]

Title: [123204] trunk/LayoutTests








Revision 123204
Author commit-qu...@webkit.org
Date 2012-07-20 05:29:40 -0700 (Fri, 20 Jul 2012)


Log Message
[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=91838

Unreviewed EFL gardening. Add failing tests to the Test Expectations.

Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-07-20

* platform/efl/TestExpectations:
* platform/efl/fast/forms/state-restore-skip-stateless-expected.txt: Removed
the platform specific expected after r123066.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations


Removed Paths

trunk/LayoutTests/platform/efl/fast/forms/state-restore-skip-stateless-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (123203 => 123204)

--- trunk/LayoutTests/ChangeLog	2012-07-20 11:31:06 UTC (rev 123203)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 12:29:40 UTC (rev 123204)
@@ -1,3 +1,14 @@
+2012-07-20  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
+
+[EFL] Gardening of failing tests
+https://bugs.webkit.org/show_bug.cgi?id=91838
+
+Unreviewed EFL gardening. Add failing tests to the Test Expectations.
+
+* platform/efl/TestExpectations:
+* platform/efl/fast/forms/state-restore-skip-stateless-expected.txt: Removed
+the platform specific expected after r123066.
+
 2012-07-20  János Badics  jbad...@inf.u-szeged.hu
 
 [Qt] Unreviewed gardening after r123192. Skipped a new test.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (123203 => 123204)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-07-20 11:31:06 UTC (rev 123203)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-07-20 12:29:40 UTC (rev 123204)
@@ -150,6 +150,9 @@
 // CRASHES
 //
 
+BUGWK91828 DEBUG : fast/css/acid2-pixel.html = CRASH
+BUGWK91828 DEBUG : http/tests/inspector/network/network-sidebar-width.html = CRASH
+
 //
 // FLAKY TESTS
 //
@@ -408,6 +411,7 @@
 BUGWK82294 : compositing/iframes/resizer.html = MISSING
 BUGWK82294 : compositing/iframes/scrolling-iframe.html = TEXT
 BUGWK82294 : compositing/images/clip-on-directly-composited-image.html = TEXT
+BUGWK82294 : compositing/layer-creation/animation-overlap-with-children.html = TEXT
 BUGWK82294 : compositing/layer-creation/fixed-position-and-transform.html = TEXT
 BUGWK82294 : compositing/layer-creation/fixed-position-under-transform.html = TEXT
 BUGWK82294 : compositing/layer-creation/overflow-scroll-overlap.html = TEXT
@@ -780,3 +784,6 @@
 BUGWK91210 : http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html = TEXT
 BUGWK91210 : http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist_in_object.html = TEXT
 BUGWK91210 : http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect.html = TEXT
+
+// Failing after r123145 on EFL, GTK and QT.
+BUGWK91843 : http/tests/security/cross-frame-access-put.html = TEXT


Deleted: trunk/LayoutTests/platform/efl/fast/forms/state-restore-skip-stateless-expected.txt (123203 => 123204)

--- trunk/LayoutTests/platform/efl/fast/forms/state-restore-skip-stateless-expected.txt	2012-07-20 11:31:06 UTC (rev 123203)
+++ trunk/LayoutTests/platform/efl/fast/forms/state-restore-skip-stateless-expected.txt	2012-07-20 12:29:40 UTC (rev 123204)
@@ -1,23 +0,0 @@
-CONSOLE MESSAGE: line 44: Test if state of stateless form control types are not saved.
-CONSOLE MESSAGE: line 8: Form state vector:
-CONSOLE MESSAGE: line 8: name02, hidden, No owner, 0, 
-CONSOLE MESSAGE: line 8: name03, text, No owner, 0, 
-CONSOLE MESSAGE: line 8: name04, tel, No owner, 0, 
-CONSOLE MESSAGE: line 8: name05, url, No owner, 0, 
-CONSOLE MESSAGE: line 8: name06, email, No owner, 0, 
-CONSOLE MESSAGE: line 8: name07, text, No owner, 0, 
-CONSOLE MESSAGE: line 8: name14, number, No owner, 0, 
-CONSOLE MESSAGE: line 8: name15, range, No owner, 1, 
-CONSOLE MESSAGE: line 8: 50, name17, checkbox, No owner, 
-CONSOLE MESSAGE: line 8: 1, off, name18, radio, 
-CONSOLE MESSAGE: line 8: No owner, 1, off, name19, 
-CONSOLE MESSAGE: line 8: file, No owner, 0, name26, 
-CONSOLE MESSAGE: line 8: select-one, No owner, 0, name27, 
-CONSOLE MESSAGE: line 8: select-multiple, No owner, 0, name28, 
-CONSOLE MESSAGE: line 8: textarea, No owner, 0, , 
-CONSOLE MESSAGE: line 13: select-one, No owner, 0, 
-CONSOLE MESSAGE: line 14: 
-PASS successfullyParsed is true
-
-TEST COMPLETE
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123205] trunk

[commit-queue]

Title: [123205] trunk








Revision 123205
Author commit-qu...@webkit.org
Date 2012-07-20 05:34:58 -0700 (Fri, 20 Jul 2012)


Log Message
Web Inspector: Protocol Extension: add getNamedFlowCollection command
https://bugs.webkit.org/show_bug.cgi?id=91607

Patch by Andrei Poenaru poen...@adobe.com on 2012-07-20
Reviewed by Pavel Feldman.

Source/WebCore:

Extended the protocol with getNamedFlowCollection command.
This command returns the CSS Named Flows from the document.

Test: inspector/styles/protocol-getNamedFlowCollection-command.html

* dom/WebKitNamedFlowCollection.cpp:
(WebCore::WebKitNamedFlowCollection::namedFlowsNames):
(WebCore):
* dom/WebKitNamedFlowCollection.h:
(WebKitNamedFlowCollection):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::assertDocument):
(WebCore):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):

LayoutTests:

The test builds a webpage with 3 Named Flows in the main frame and 1 Named Flow in an iframe.
Because the getNamedFlowCollection command is executed with the main document node id as an argument,
it should return only the first 3 Named Flows.

* inspector/styles/protocol-getNamedFlowCollection-command-expected.txt: Added.
* inspector/styles/protocol-getNamedFlowCollection-command.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/WebKitNamedFlowCollection.cpp
trunk/Source/WebCore/dom/WebKitNamedFlowCollection.h
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp
trunk/Source/WebCore/inspector/InspectorCSSAgent.h
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/InspectorDOMAgent.h
trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js


Added Paths

trunk/LayoutTests/inspector/styles/protocol-getNamedFlowCollection-command-expected.txt
trunk/LayoutTests/inspector/styles/protocol-getNamedFlowCollection-command.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123204 => 123205)

--- trunk/LayoutTests/ChangeLog	2012-07-20 12:29:40 UTC (rev 123204)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 12:34:58 UTC (rev 123205)
@@ -1,3 +1,17 @@
+2012-07-20  Andrei Poenaru  poen...@adobe.com
+
+Web Inspector: Protocol Extension: add getNamedFlowCollection command
+https://bugs.webkit.org/show_bug.cgi?id=91607
+
+Reviewed by Pavel Feldman.
+
+The test builds a webpage with 3 Named Flows in the main frame and 1 Named Flow in an iframe.
+Because the getNamedFlowCollection command is executed with the main document node id as an argument,
+it should return only the first 3 Named Flows.
+
+* inspector/styles/protocol-getNamedFlowCollection-command-expected.txt: Added.
+* inspector/styles/protocol-getNamedFlowCollection-command.html: Added.
+
 2012-07-20  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
 
 [EFL] Gardening of failing tests


Added: trunk/LayoutTests/inspector/styles/protocol-getNamedFlowCollection-command-expected.txt (0 => 123205)

--- trunk/LayoutTests/inspector/styles/protocol-getNamedFlowCollection-command-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/styles/protocol-getNamedFlowCollection-command-expected.txt	2012-07-20 12:34:58 UTC (rev 123205)
@@ -0,0 +1,11 @@
+Tests that the getNamedFlowCollection command returns the CSS Named Flows in the page. Bug 91607
+
+flow1
+flow2
+flow3
+
+=== CSS Named Flows ===
+flow1
+flow2
+flow3
+


Added: trunk/LayoutTests/inspector/styles/protocol-getNamedFlowCollection-command.html (0 => 123205)

--- trunk/LayoutTests/inspector/styles/protocol-getNamedFlowCollection-command.html	(rev 0)
+++ trunk/LayoutTests/inspector/styles/protocol-getNamedFlowCollection-command.html	2012-07-20 12:34:58 UTC (rev 123205)
@@ -0,0 +1,75 @@
+html
+head
+script src=""
+script
+
+function createDynamicElements()
+{
+var frameDoc = window.frames[0].document;
+
+var el = frameDoc.createElement(article);
+el.innerText = flow4;
+el.style.webkitFlowInto = flow4;
+frameDoc.body.appendChild(el);
+
+el = frameDoc.createElement(div);
+el.style.webkitFlowFrom = flow4;
+frameDoc.body.appendChild(el);
+}
+
+function test()
+{
+WebInspector.showPanel(elements);
+InspectorTest.evaluateInPage(createDynamicElements(), testStep);
+
+function testStep()
+{
+function namedFlowCallback(namedFlows)
+{
+InspectorTest.addResult(=== CSS Named Flows ===);
+
+if (!namedFlows)
+{
+InspectorTest.addResult([!] Failed to get Named Flows);
+InspectorTest.completeTest();
+ 

[webkit-changes] [123207] trunk/Source/WebCore

[pfeldman]

Title: [123207] trunk/Source/WebCore








Revision 123207
Author pfeld...@chromium.org
Date 2012-07-20 06:07:48 -0700 (Fri, 20 Jul 2012)


Log Message
Web Inspector: Status bar icons are misaligned by 1px to the right
https://bugs.webkit.org/show_bug.cgi?id=91757

Reviewed by Vsevolod Vlasov.

* inspector/front-end/inspector.css:
(.glyph):
(.glyph.shadow):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/Images/statusbarButtonGlyphs.png
trunk/Source/WebCore/inspector/front-end/inspector.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (123206 => 123207)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 12:50:42 UTC (rev 123206)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 13:07:48 UTC (rev 123207)
@@ -1,3 +1,14 @@
+2012-07-19  Pavel Feldman  pfeld...@chromium.org
+
+Web Inspector: Status bar icons are misaligned by 1px to the right
+https://bugs.webkit.org/show_bug.cgi?id=91757
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/front-end/inspector.css:
+(.glyph):
+(.glyph.shadow):
+
 2012-07-20  Andrei Poenaru  poen...@adobe.com
 
 Web Inspector: Protocol Extension: add getNamedFlowCollection command


Modified: trunk/Source/WebCore/inspector/front-end/Images/statusbarButtonGlyphs.png

(Binary files differ)


Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (123206 => 123207)

--- trunk/Source/WebCore/inspector/front-end/inspector.css	2012-07-20 12:50:42 UTC (rev 123206)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css	2012-07-20 13:07:48 UTC (rev 123207)
@@ -562,15 +562,16 @@
 .glyph {
 position: absolute;
 top: -1px;
+bottom: 1px;
 left: 0;
 right: 0;
-bottom: 0;
 background-color: rgba(0, 0, 0, 0.75);
 z-index: 1;
 }
 
 .glyph.shadow {
-top: 1px;
+top: 0;
+bottom: 0;
 background-color: white !important;
 z-index: 0;
 }
@@ -595,6 +596,10 @@
 border-right: 1px solid rgb(202, 202, 202);
 }
 
+.status-bar button.status-bar-item .glyph {
+margin: 0 -1px;
+}
+
 .status-bar select.status-bar-item:active,
 .status-bar button.status-bar-item:active {
 background-color: rgb(163,163,163);
@@ -625,7 +630,7 @@
 background-image: url(Images/disclosureTriangleSmallDown.png);
 background-repeat: no-repeat;
 background-position-x: right;
-background-position-y: 6px;
+background-position-y: 5px;
 padding-right: 10px;
 border-right: 5px solid transparent;
 }
@@ -642,6 +647,7 @@
 margin-right: -15px;
 position: relative;
 top: -1px;
+height: 23px;
 }
 
 select.status-bar-item, select.status-bar-item:hover {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123208] trunk/Tools

[zeno . albisser]

Title: [123208] trunk/Tools








Revision 123208
Author zeno.albis...@nokia.com
Date 2012-07-20 06:26:40 -0700 (Fri, 20 Jul 2012)


Log Message
[Qt][WK2] Add configure tests for Xrender and GLX.
https://bugs.webkit.org/show_bug.cgi?id=91845

GraphicsSurface on linux requires Xcomposite, Xrender
and GLX. If any of these requirements is not met,
we should disable GraphicsSurface.

Reviewed by Kenneth Rohde Christiansen.

* qmake/config.tests/glx/glx.cpp: Added.
(main):
* qmake/config.tests/glx/glx.pro: Added.
* qmake/config.tests/libXrender/libXrender.cpp: Added.
(main):
* qmake/config.tests/libXrender/libXrender.pro: Added.
* qmake/configure.pri:
* qmake/mkspecs/features/features.prf:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/configure.pri
trunk/Tools/qmake/mkspecs/features/features.prf


Added Paths

trunk/Tools/qmake/config.tests/glx/
trunk/Tools/qmake/config.tests/glx/glx.cpp
trunk/Tools/qmake/config.tests/glx/glx.pro
trunk/Tools/qmake/config.tests/libXrender/
trunk/Tools/qmake/config.tests/libXrender/libXrender.cpp
trunk/Tools/qmake/config.tests/libXrender/libXrender.pro




Diff

Modified: trunk/Tools/ChangeLog (123207 => 123208)

--- trunk/Tools/ChangeLog	2012-07-20 13:07:48 UTC (rev 123207)
+++ trunk/Tools/ChangeLog	2012-07-20 13:26:40 UTC (rev 123208)
@@ -1,3 +1,23 @@
+2012-07-20  Zeno Albisser  z...@webkit.org
+
+[Qt][WK2] Add configure tests for Xrender and GLX.
+https://bugs.webkit.org/show_bug.cgi?id=91845
+
+GraphicsSurface on linux requires Xcomposite, Xrender
+and GLX. If any of these requirements is not met,
+we should disable GraphicsSurface.
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* qmake/config.tests/glx/glx.cpp: Added.
+(main):
+* qmake/config.tests/glx/glx.pro: Added.
+* qmake/config.tests/libXrender/libXrender.cpp: Added.
+(main):
+* qmake/config.tests/libXrender/libXrender.pro: Added.
+* qmake/configure.pri:
+* qmake/mkspecs/features/features.prf:
+
 2012-07-20  Kangil Han  kangil@samsung.com
 
 [EFL][WK2][WTR] Implement EventSenderProxy


Added: trunk/Tools/qmake/config.tests/glx/glx.cpp (0 => 123208)

--- trunk/Tools/qmake/config.tests/glx/glx.cpp	(rev 0)
+++ trunk/Tools/qmake/config.tests/glx/glx.cpp	2012-07-20 13:26:40 UTC (rev 123208)
@@ -0,0 +1,36 @@
+/*
+ * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include GL/glx.h
+
+int main(int, char**)
+{
+Display* display = XOpenDisplay(0);
+int items = 0;
+(void)glXChooseFBConfig(display, DefaultScreen(display), 0, items);
+XCloseDisplay(display);
+
+return 0;
+}


Added: trunk/Tools/qmake/config.tests/glx/glx.pro (0 => 123208)

--- trunk/Tools/qmake/config.tests/glx/glx.pro	(rev 0)
+++ trunk/Tools/qmake/config.tests/glx/glx.pro	2012-07-20 13:26:40 UTC (rev 123208)
@@ -0,0 +1,4 @@
+SOURCES = glx.cpp
+OBJECTS_DIR = obj
+LIBS += -lX11 -lGL
+


Added: trunk/Tools/qmake/config.tests/libXrender/libXrender.cpp (0 => 123208)

--- trunk/Tools/qmake/config.tests/libXrender/libXrender.cpp	(rev 0)
+++ trunk/Tools/qmake/config.tests/libXrender/libXrender.cpp	2012-07-20 13:26:40 UTC (rev 123208)
@@ -0,0 +1,37 @@
+/*
+ * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. 

[webkit-changes] [123210] trunk

[schenney]

Title: [123210] trunk








Revision 123210
Author schen...@chromium.org
Date 2012-07-20 06:55:02 -0700 (Fri, 20 Jul 2012)


Log Message
SVG Filter Effect sub-region not applied for some filters
https://bugs.webkit.org/show_bug.cgi?id=89767

Reviewed by Dirk Schulze.

Source/WebCore: 

The filter effect region for SVG feGaussian and feDropShadow filters
was incorrectly set, failing to account for the radius of the blur.
This patch fixes the problem and removes an unneccessary clip
operation when the filter result is blitted into the target. That clip
was clipping the shadow from webkit-shadow.

Tests: svg/filters/feDropShadow-subregion.svg
   svg/filters/feGaussianBlur-subregion.svg

* platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::determineAbsolutePaintRect): Moved the code
that clips the paint rect by the filter effect subregion to come after
the paint is modified by the filter radius.
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
Moved the code that clips the paint rect by the filter effect subregion to
come after the paint is modified by the filter radius.
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
Removed a clip that is unnecessary and that was incorrectly clipping drop shadows.

LayoutTests: 

The filter effect region for SVG feGaussian and feDropShadow filters was incorrectly set,
failing to account for the radius of the blur. This patch fixes the problem and removes an
unneccessary clip operation when the filter result is blitted into the target. That clip
was clipping the shadow from webkit-shadow.

* platform/chromium/TestExpectations: Added temp entries for affected
tests. Will rebaseline later (not closing the bug in the meantime).
* svg/filters/feDropShadow-subregion-expected.png: Added.
* svg/filters/feDropShadow-subregion-expected.txt: Added.
* svg/filters/feDropShadow-subregion.svg: This verifies the subregion for feDropShadow.
* svg/filters/feGaussianBlur-subregion-expected.png: Added.
* svg/filters/feGaussianBlur-subregion-expected.txt: Added.
* svg/filters/feGaussianBlur-subregion.svg: This verifies the subregion for feGaussianBlur.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.cpp
trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp


Added Paths

trunk/LayoutTests/svg/filters/feDropShadow-subregion-expected.png
trunk/LayoutTests/svg/filters/feDropShadow-subregion-expected.txt
trunk/LayoutTests/svg/filters/feDropShadow-subregion.svg
trunk/LayoutTests/svg/filters/feGaussianBlur-subregion-expected.png
trunk/LayoutTests/svg/filters/feGaussianBlur-subregion-expected.txt
trunk/LayoutTests/svg/filters/feGaussianBlur-subregion.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (123209 => 123210)

--- trunk/LayoutTests/ChangeLog	2012-07-20 13:41:54 UTC (rev 123209)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 13:55:02 UTC (rev 123210)
@@ -1,3 +1,24 @@
+2012-07-20  Stephen Chenney  schen...@chromium.org
+
+SVG Filter Effect sub-region not applied for some filters
+https://bugs.webkit.org/show_bug.cgi?id=89767
+
+Reviewed by Dirk Schulze.
+
+The filter effect region for SVG feGaussian and feDropShadow filters was incorrectly set,
+failing to account for the radius of the blur. This patch fixes the problem and removes an
+unneccessary clip operation when the filter result is blitted into the target. That clip
+was clipping the shadow from webkit-shadow.
+
+* platform/chromium/TestExpectations: Added temp entries for affected
+tests. Will rebaseline later (not closing the bug in the meantime).
+* svg/filters/feDropShadow-subregion-expected.png: Added.
+* svg/filters/feDropShadow-subregion-expected.txt: Added.
+* svg/filters/feDropShadow-subregion.svg: This verifies the subregion for feDropShadow.
+* svg/filters/feGaussianBlur-subregion-expected.png: Added.
+* svg/filters/feGaussianBlur-subregion-expected.txt: Added.
+* svg/filters/feGaussianBlur-subregion.svg: This verifies the subregion for feGaussianBlur.
+
 2012-07-20  Mihnea Ovidenie  mih...@adobe.com
 
 Unreviewed. Skip regions inspector test on EFL.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123209 => 123210)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 13:41:54 UTC (rev 123209)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 13:55:02 UTC (rev 123210)
@@ -1296,7 +1296,45 @@
 BUGWK85107 : svg/as-image/svg-as-relative-image-with-explicit-size.html = PASS IMAGE
 BUGWK85107 : svg/as-image/animated-svg-as-image.html = PASS IMAGE
 
+BUGWK89767 : svg/W3C-SVG-1.1/filters-comptran-01-b.svg = PASS IMAGE

[webkit-changes] [123212] trunk/Source/WebCore

[commit-queue]

Title: [123212] trunk/Source/WebCore








Revision 123212
Author commit-qu...@webkit.org
Date 2012-07-20 07:05:08 -0700 (Fri, 20 Jul 2012)


Log Message
[WK2] WebIntents doesn't build if mutation observers is disabled
https://bugs.webkit.org/show_bug.cgi?id=91839

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

WebIntents was depending on a code protected by ENABLE(MUTATION_OBSERVERS).
Now the code is also enabled by ENABLE(WEB_INTENTS).

* bindings/js/JSDictionary.cpp:
(WebCore):
* bindings/js/JSDictionary.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDictionary.cpp
trunk/Source/WebCore/bindings/js/JSDictionary.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (123211 => 123212)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 13:59:48 UTC (rev 123211)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 14:05:08 UTC (rev 123212)
@@ -1,3 +1,17 @@
+2012-07-20  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[WK2] WebIntents doesn't build if mutation observers is disabled
+https://bugs.webkit.org/show_bug.cgi?id=91839
+
+Reviewed by Kenneth Rohde Christiansen.
+
+WebIntents was depending on a code protected by ENABLE(MUTATION_OBSERVERS).
+Now the code is also enabled by ENABLE(WEB_INTENTS).
+
+* bindings/js/JSDictionary.cpp:
+(WebCore):
+* bindings/js/JSDictionary.h:
+
 2012-07-20  Mihnea Ovidenie  mih...@adobe.com
 
 [CSSRegions]Assert failure when layout positioned objects in regions


Modified: trunk/Source/WebCore/bindings/js/JSDictionary.cpp (123211 => 123212)

--- trunk/Source/WebCore/bindings/js/JSDictionary.cpp	2012-07-20 13:59:48 UTC (rev 123211)
+++ trunk/Source/WebCore/bindings/js/JSDictionary.cpp	2012-07-20 14:05:08 UTC (rev 123212)
@@ -163,7 +163,7 @@
 }
 #endif
 
-#if ENABLE(MUTATION_OBSERVERS)
+#if ENABLE(MUTATION_OBSERVERS) || ENABLE(WEB_INTENTS)
 void JSDictionary::convertValue(ExecState* exec, JSValue value, HashSetAtomicString result)
 {
 result.clear();


Modified: trunk/Source/WebCore/bindings/js/JSDictionary.h (123211 => 123212)

--- trunk/Source/WebCore/bindings/js/JSDictionary.h	2012-07-20 13:59:48 UTC (rev 123211)
+++ trunk/Source/WebCore/bindings/js/JSDictionary.h	2012-07-20 14:05:08 UTC (rev 123212)
@@ -102,7 +102,7 @@
 #if ENABLE(VIDEO_TRACK)
 static void convertValue(JSC::ExecState*, JSC::JSValue, RefPtrTrackBase result);
 #endif
-#if ENABLE(MUTATION_OBSERVERS)
+#if ENABLE(MUTATION_OBSERVERS) || ENABLE(WEB_INTENTS)
 static void convertValue(JSC::ExecState*, JSC::JSValue, HashSetAtomicString result);
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123213] trunk/Source/WebKit/efl

[commit-queue]

Title: [123213] trunk/Source/WebKit/efl








Revision 123213
Author commit-qu...@webkit.org
Date 2012-07-20 07:11:17 -0700 (Fri, 20 Jul 2012)


Log Message
[EFL] Fix build when protocol handler and custom scheme is disabled
https://bugs.webkit.org/show_bug.cgi?id=91840

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

Fixed namespace closing bracket positioning.

* WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:
(WebCore):

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (123212 => 123213)

--- trunk/Source/WebKit/efl/ChangeLog	2012-07-20 14:05:08 UTC (rev 123212)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-07-20 14:11:17 UTC (rev 123213)
@@ -1,3 +1,15 @@
+2012-07-20  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[EFL] Fix build when protocol handler and custom scheme is disabled
+https://bugs.webkit.org/show_bug.cgi?id=91840
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Fixed namespace closing bracket positioning.
+
+* WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:
+(WebCore):
+
 2012-07-20  Kihong Kwon  kihong.k...@samsung.com
 
 [EFL] Check parameters of ewk APIs in ewk_security_origin


Modified: trunk/Source/WebKit/efl/WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp (123212 => 123213)

--- trunk/Source/WebKit/efl/WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp	2012-07-20 14:05:08 UTC (rev 123212)
+++ trunk/Source/WebKit/efl/WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp	2012-07-20 14:11:17 UTC (rev 123213)
@@ -87,5 +87,6 @@
 }
 #endif
 
+}
+
 #endif // ENABLE(REGISTER_PROTOCOL_HANDLER) || ENABLE(CUSTOM_SCHEME_HANDLER)
-}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123214] trunk/Source/WebCore

[pierre . rossi]

Title: [123214] trunk/Source/WebCore








Revision 123214
Author pierre.ro...@gmail.com
Date 2012-07-20 07:23:37 -0700 (Fri, 20 Jul 2012)


Log Message
ColorChooserClient should expose the element's location
https://bugs.webkit.org/show_bug.cgi?id=91767

Reviewed by Kent Tamura.

The rationale is that the chrome client could have an interest in placing the picker next to
the element for usability reasons.

No new tests as there is not much logic here: Just exposing a geometry information to WebKit.

* html/ColorInputType.cpp:
(WebCore::ColorInputType::elementRectRelativeToWindow):
(WebCore):
* html/ColorInputType.h:
(ColorInputType):
* platform/ColorChooserClient.h:
(ColorChooserClient):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/ColorInputType.cpp
trunk/Source/WebCore/html/ColorInputType.h
trunk/Source/WebCore/platform/ColorChooserClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (123213 => 123214)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 14:11:17 UTC (rev 123213)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 14:23:37 UTC (rev 123214)
@@ -1,3 +1,23 @@
+2012-07-20  Pierre Rossi  pierre.ro...@gmail.com
+
+ColorChooserClient should expose the element's location
+https://bugs.webkit.org/show_bug.cgi?id=91767
+
+Reviewed by Kent Tamura.
+
+The rationale is that the chrome client could have an interest in placing the picker next to
+the element for usability reasons.
+
+No new tests as there is not much logic here: Just exposing a geometry information to WebKit.
+
+* html/ColorInputType.cpp:
+(WebCore::ColorInputType::elementRectRelativeToWindow):
+(WebCore):
+* html/ColorInputType.h:
+(ColorInputType):
+* platform/ColorChooserClient.h:
+(ColorChooserClient):
+
 2012-07-20  Thiago Marcos P. Santos  thiago.san...@intel.com
 
 [WK2] WebIntents doesn't build if mutation observers is disabled


Modified: trunk/Source/WebCore/html/ColorInputType.cpp (123213 => 123214)

--- trunk/Source/WebCore/html/ColorInputType.cpp	2012-07-20 14:11:17 UTC (rev 123213)
+++ trunk/Source/WebCore/html/ColorInputType.cpp	2012-07-20 14:23:37 UTC (rev 123214)
@@ -38,6 +38,8 @@
 #include HTMLDivElement.h
 #include HTMLInputElement.h
 #include MouseEvent.h
+#include RenderObject.h
+#include RenderView.h
 #include ScriptController.h
 #include ShadowRoot.h
 
@@ -195,6 +197,13 @@
 return shadow ? toHTMLElement(shadow-firstChild()-firstChild()) : 0;
 }
 
+IntRect ColorInputType::elementRectRelativeToWindow() const
+{
+RenderObject* renderer = element()-renderer();
+ASSERT(renderer);
+return pixelSnappedIntRect(renderer-view()-frameView()-contentsToWindow(renderer-absoluteBoundingBoxRect()));
+}
+
 } // namespace WebCore
 
 #endif // ENABLE(INPUT_TYPE_COLOR)


Modified: trunk/Source/WebCore/html/ColorInputType.h (123213 => 123214)

--- trunk/Source/WebCore/html/ColorInputType.h	2012-07-20 14:11:17 UTC (rev 123213)
+++ trunk/Source/WebCore/html/ColorInputType.h	2012-07-20 14:23:37 UTC (rev 123214)
@@ -46,6 +46,7 @@
 // ColorChooserClient implementation.
 virtual void didChooseColor(const Color) OVERRIDE;
 virtual void didEndChooser() OVERRIDE;
+virtual IntRect elementRectRelativeToWindow() const OVERRIDE;
 
 private:
 ColorInputType(HTMLInputElement* element) : BaseClickableWithKeyInputType(element) { }


Modified: trunk/Source/WebCore/platform/ColorChooserClient.h (123213 => 123214)

--- trunk/Source/WebCore/platform/ColorChooserClient.h	2012-07-20 14:11:17 UTC (rev 123213)
+++ trunk/Source/WebCore/platform/ColorChooserClient.h	2012-07-20 14:23:37 UTC (rev 123214)
@@ -4,6 +4,7 @@
 #if ENABLE(INPUT_TYPE_COLOR)
 
 #include ColorChooser.h
+#include IntRect.h
 #include wtf/OwnPtr.h
 #include wtf/PassOwnPtr.h
 
@@ -17,6 +18,7 @@
 
 virtual void didChooseColor(const Color) = 0;
 virtual void didEndChooser() = 0;
+virtual IntRect elementRectRelativeToWindow() const = 0;
 };
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123215] trunk/LayoutTests

[schenney]

Title: [123215] trunk/LayoutTests








Revision 123215
Author schen...@chromium.org
Date 2012-07-20 07:30:51 -0700 (Fri, 20 Jul 2012)


Log Message
Rebaseline Chromium results after r121171
https://bugs.webkit.org/show_bug.cgi?id=91474

Reviewed by Dan Bernstein.

Unreviewed test expectations update.

Values have changed by one pixel, which is expected given the description in the bug report.

* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/chromium/svg/as-image: Removed.
* platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
* svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
trunk/LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
trunk/LayoutTests/platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png
trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png
trunk/LayoutTests/platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt
trunk/LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium/svg/as-image/
trunk/LayoutTests/platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt
trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt
trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (123214 => 123215)

--- trunk/LayoutTests/ChangeLog	2012-07-20 14:23:37 UTC (rev 123214)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 14:30:51 UTC (rev 123215)
@@ -1,3 +1,36 @@
+2012-07-20  Stephen Chenney  schen...@chromium.org
+
+Rebaseline Chromium results after r121171
+https://bugs.webkit.org/show_bug.cgi?id=91474
+
+Reviewed by Dan Bernstein.
+
+Unreviewed test expectations update.
+
+Values have changed by one pixel, which is expected given the description in the bug report.
+
+  

[webkit-changes] [123216] trunk/Source/WebKit2

[pierre . rossi]

Title: [123216] trunk/Source/WebKit2








Revision 123216
Author pierre.ro...@gmail.com
Date 2012-07-20 07:38:01 -0700 (Fri, 20 Jul 2012)


Log Message
[Qt][WK2] Add support for multi-select list
https://bugs.webkit.org/show_bug.cgi?id=85527

Patch by Dinu Jacob dinu.ja...@nokia.com on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Added support for multi-select list:
- Added multi-selection flag to PlatformPopupMenuData to indicate whether to accept multiple selections or not.
- Added selected state to WebPopupItem.
- Modified WebPopupMenuQt to support multiple selections.

* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
* Shared/PlatformPopupMenuData.h:
(PlatformPopupMenuData):
* Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::WebPopupItem):
(WebKit::WebPopupItem::encode):
(WebKit::WebPopupItem::decode):
* Shared/WebPopupItem.h:
* UIProcess/API/qt/tests/qmltests/WebView/tst_multiSelect.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/multiselect.html: Added.
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPopupMenuProxy.h:
(Client):
* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::changeSelectedIndex):
(WebKit):
(WebKit::WebPageProxy::closePopupMenu):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::PopupMenuItemModel::multiple):
(PopupMenuItemModel):
(WebKit::PopupMenuItemModel::Item::Item):
(ItemSelectorContextObject):
(WebKit::ItemSelectorContextObject::allowMultiSelect):
(WebKit::ItemSelectorContextObject::reject):
(WebKit::ItemSelectorContextObject::dismiss):
(WebKit::ItemSelectorContextObject::ItemSelectorContextObject):
(WebKit):
(WebKit::ItemSelectorContextObject::onIndexUpdate):
(WebKit::ItemSelectorContextObject::accept):
(WebKit::PopupMenuItemModel::PopupMenuItemModel):
(WebKit::PopupMenuItemModel::select):
(WebKit::PopupMenuItemModel::toggleItem):
(WebKit::PopupMenuItemModel::buildItems):
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
(WebKit::WebPopupMenuProxyQt::hidePopupMenu):
(WebKit::WebPopupMenuProxyQt::selectIndex):
(WebKit::WebPopupMenuProxyQt::createItem):
* UIProcess/qt/WebPopupMenuProxyQt.h:
(WebPopupMenuProxyQt):
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::didChangeSelectedIndex):
(WebKit::WebPopupMenu::populateItems):
* WebProcess/WebCoreSupport/WebPopupMenu.h:
(WebPopupMenu):
* WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeSelectedIndexForActivePopupMenu):
(WebKit):
(WebKit::WebPage::changeSelectedIndex):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::selectedIndex):
(WebKit):
(WebKit::WebPage::hidePopupMenu):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/PlatformPopupMenuData.cpp
trunk/Source/WebKit2/Shared/PlatformPopupMenuData.h
trunk/Source/WebKit2/Shared/WebPopupItem.cpp
trunk/Source/WebKit2/Shared/WebPopupItem.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPopupMenuProxy.h
trunk/Source/WebKit2/UIProcess/qt/WebPageProxyQt.cpp
trunk/Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp
trunk/Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPopupMenu.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPopupMenu.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (123215 => 123216)

--- trunk/Source/WebKit2/ChangeLog	2012-07-20 14:30:51 UTC (rev 123215)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-20 14:38:01 UTC (rev 123216)
@@ -1,3 +1,77 @@
+2012-06-01  Dinu Jacob  dinu.ja...@nokia.com
+
+[Qt][WK2] Add support for multi-select list
+https://bugs.webkit.org/show_bug.cgi?id=85527
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Added support for multi-select list:
+- Added multi-selection flag to PlatformPopupMenuData to indicate whether to accept multiple selections or not.
+- Added selected state to WebPopupItem.
+- Modified WebPopupMenuQt to support multiple selections.
+
+* Shared/PlatformPopupMenuData.cpp:
+(WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
+(WebKit::PlatformPopupMenuData::encode):
+(WebKit::PlatformPopupMenuData::decode):
+* Shared/PlatformPopupMenuData.h:
+(PlatformPopupMenuData):
+* Shared/WebPopupItem.cpp:
+(WebKit::WebPopupItem::WebPopupItem):
+(WebKit::WebPopupItem::encode):
+(WebKit::WebPopupItem::decode):
+* Shared/WebPopupItem.h:

[webkit-changes] [123217] trunk/LayoutTests

[schenney]

Title: [123217] trunk/LayoutTests








Revision 123217
Author schen...@chromium.org
Date 2012-07-20 07:38:44 -0700 (Fri, 20 Jul 2012)


Log Message
Fix chromium TestExpectations file.

Unreviewed build fix.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123216 => 123217)

--- trunk/LayoutTests/ChangeLog	2012-07-20 14:38:01 UTC (rev 123216)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 14:38:44 UTC (rev 123217)
@@ -1,5 +1,13 @@
 2012-07-20  Stephen Chenney  schen...@chromium.org
 
+Fix chromium TestExpectations file.
+
+Unreviewed build fix.
+
+* platform/chromium/TestExpectations:
+
+2012-07-20  Stephen Chenney  schen...@chromium.org
+
 Rebaseline Chromium results after r121171
 https://bugs.webkit.org/show_bug.cgi?id=91474
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123216 => 123217)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 14:38:01 UTC (rev 123216)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 14:38:44 UTC (rev 123217)
@@ -1423,7 +1423,10 @@
 
 // Requires rebaselining after skia roll
 BUGCR138159 : platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment.html = IMAGE
+// This test was already marked as failing on mac. It's commented out now to fix the build, but it
+// should be checked carefully before rebaselining.
 BUGCR138159 : platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop.html = IMAGE
+// BUGWK77188 MAC : platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop.html = IMAGE
 
 // -
 // Other failures
@@ -3035,8 +3038,6 @@
 
 BUGABARTH : fast/html/marquee-alternate.html = PASS TEXT
 
-BUGWK77188 MAC : platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop.html = IMAGE
-
 BUGWK77314 WIN MAC : fast/events/touch/send-oncancel-event.html = PASS TEXT
 BUGWK77324 WIN MAC DEBUG SLOW : fast/js/dfg-int32array.html = PASS
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123218] trunk

[commit-queue]

Title: [123218] trunk








Revision 123218
Author commit-qu...@webkit.org
Date 2012-07-20 07:39:35 -0700 (Fri, 20 Jul 2012)


Log Message
[EFL] Proxy configuration should honor the no_proxy environment variable
https://bugs.webkit.org/show_bug.cgi?id=91747

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Implement a custom Proxy URI Resolver for libsoup
so that we can use it in EFL port. This custom
proxy resolver brings support for setting
exceptions so that the proxy is not used for the
specified hosts.

By default, the proxy is not used for localhost and
127.0.0.1.

No new tests, no behavior change for layout tests.

* PlatformEfl.cmake:
* platform/network/soup/ProxyResolverSoup.cpp: Added.
(soup_proxy_resolver_wk_init):
(soupProxyResolverWkFinalize):
(soupProxyResolverWkSetProperty):
(soupProxyResolverWkGetProperty):
(shouldBypassProxy):
(idle_return_proxy_uri):
(soupProxyResolverWkGetProxyURIAsync):
(soupProxyResolverWkGetProxyURISync):
(soup_proxy_resolver_wk_class_init):
(soup_proxy_resolver_wk_interface_init):
(soupProxyResolverWkNew):
* platform/network/soup/ProxyResolverSoup.h: Added.

Source/WebKit:

Add WebCore/platform/network/soup to INCLUDE paths.

* PlatformEfl.cmake:

Source/WebKit/efl:

Use the new custom proxy resolver from WebCore in
WebKit1-EFL's ewk_network_proxy_uri_set() / get(),
instead of the less flexible SOUP_SESSION_PROXY_URI
SoupSession property.

* ewk/ewk_network.cpp:
(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):

Source/WebKit2:

Use the new custom proxy resolver from WebCore in
WebKit2-EFL so that it is possible for the client
to set proxy exceptions via the no_proxy
environment variable.

By default, the proxy set in the http_proxy
environment variable will not be used for requests
to localhost or 127.0.0.1.

* WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):

Tools:

Add ProxyResolverSoup to the list of classes that contain GObjects
in style checker script so that it does not complain about naming
convention issues that are mandated by GObject.

* Scripts/webkitpy/style/checker.py:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformEfl.cmake
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_network.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checker.py


Added Paths

trunk/Source/WebCore/platform/network/soup/ProxyResolverSoup.cpp
trunk/Source/WebCore/platform/network/soup/ProxyResolverSoup.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (123217 => 123218)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 14:38:44 UTC (rev 123217)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 14:39:35 UTC (rev 123218)
@@ -1,3 +1,36 @@
+2012-07-20  Christophe Dumez  christophe.du...@intel.com
+
+[EFL] Proxy configuration should honor the no_proxy environment variable
+https://bugs.webkit.org/show_bug.cgi?id=91747
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Implement a custom Proxy URI Resolver for libsoup
+so that we can use it in EFL port. This custom
+proxy resolver brings support for setting
+exceptions so that the proxy is not used for the
+specified hosts.
+
+By default, the proxy is not used for localhost and
+127.0.0.1.
+
+No new tests, no behavior change for layout tests.
+
+* PlatformEfl.cmake:
+* platform/network/soup/ProxyResolverSoup.cpp: Added.
+(soup_proxy_resolver_wk_init):
+(soupProxyResolverWkFinalize):
+(soupProxyResolverWkSetProperty):
+(soupProxyResolverWkGetProperty):
+(shouldBypassProxy):
+(idle_return_proxy_uri):
+(soupProxyResolverWkGetProxyURIAsync):
+(soupProxyResolverWkGetProxyURISync):
+(soup_proxy_resolver_wk_class_init):
+(soup_proxy_resolver_wk_interface_init):
+(soupProxyResolverWkNew):
+* platform/network/soup/ProxyResolverSoup.h: Added.
+
 2012-07-20  Pierre Rossi  pierre.ro...@gmail.com
 
 ColorChooserClient should expose the element's location


Modified: trunk/Source/WebCore/PlatformEfl.cmake (123217 => 123218)

--- trunk/Source/WebCore/PlatformEfl.cmake	2012-07-20 14:38:44 UTC (rev 123217)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2012-07-20 14:39:35 UTC (rev 123218)
@@ -85,6 +85,7 @@
   platform/network/soup/CredentialStorageSoup.cpp
   platform/network/soup/DNSSoup.cpp
   platform/network/soup/GOwnPtrSoup.cpp
+  platform/network/soup/ProxyResolverSoup.cpp
   platform/network/soup/ProxyServerSoup.cpp
   platform/network/soup/ResourceHandleSoup.cpp
   platform/network/soup/ResourceRequestSoup.cpp


Added: trunk/Source/WebCore/platform/network/soup/ProxyResolverSoup.cpp (0 => 123218)

--- 

[webkit-changes] [123220] trunk/Tools

[philn]

Title: [123220] trunk/Tools








Revision 123220
Author ph...@webkit.org
Date 2012-07-20 08:12:54 -0700 (Fri, 20 Jul 2012)


Log Message
[GTK][jhbuild] Switch to GStreamer 0.11 build
https://bugs.webkit.org/show_bug.cgi?id=91727

Reviewed by Gustavo Noronha Silva.

Switch build-webkit --gtk to GStreamer 0.11 support and build the
necessary GStreamer git modules from JHBuild.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
* gtk/jhbuild.modules: GStreamer build support.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (123219 => 123220)

--- trunk/Tools/ChangeLog	2012-07-20 14:57:55 UTC (rev 123219)
+++ trunk/Tools/ChangeLog	2012-07-20 15:12:54 UTC (rev 123220)
@@ -1,3 +1,17 @@
+2012-07-20  Philippe Normand  pnorm...@igalia.com
+
+[GTK][jhbuild] Switch to GStreamer 0.11 build
+https://bugs.webkit.org/show_bug.cgi?id=91727
+
+Reviewed by Gustavo Noronha Silva.
+
+Switch build-webkit --gtk to GStreamer 0.11 support and build the
+necessary GStreamer git modules from JHBuild.
+
+* Scripts/webkitdirs.pm:
+(buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
+* gtk/jhbuild.modules: GStreamer build support.
+
 2012-07-20  Christophe Dumez  christophe.du...@intel.com
 
 [EFL] Proxy configuration should honor the no_proxy environment variable


Modified: trunk/Tools/Scripts/webkitdirs.pm (123219 => 123220)

--- trunk/Tools/Scripts/webkitdirs.pm	2012-07-20 14:57:55 UTC (rev 123219)
+++ trunk/Tools/Scripts/webkitdirs.pm	2012-07-20 15:12:54 UTC (rev 123220)
@@ -2090,6 +2090,11 @@
 # Enable unstable features when building through build-webkit.
 push @buildArgs, --enable-unstable-features;
 
+# Enable upcoming GStreamer 1.0 build support through build-webkit.
+if ($project eq 'WebKit') {
+push @buildArgs, --with-gstreamer=1.0;
+}
+
 # We might need to update jhbuild dependencies.
 my $needUpdate = 0;
 if (jhbuildConfigurationChanged()) {


Modified: trunk/Tools/gtk/jhbuild.modules (123219 => 123220)

--- trunk/Tools/gtk/jhbuild.modules	2012-07-20 14:57:55 UTC (rev 123219)
+++ trunk/Tools/gtk/jhbuild.modules	2012-07-20 15:12:54 UTC (rev 123220)
@@ -18,6 +18,11 @@
   dep package=libsoup/
   dep package=at-spi2-core/
   dep package=at-spi2-atk/
+  dep package=gstreamer/
+  dep package=gst-plugins-base/
+  dep package=gst-plugins-good/
+  dep package=gst-plugins-bad/
+  dep package=gst-ffmpeg/
 /dependencies
   /metamodule
 
@@ -37,6 +42,12 @@
   href=""
   repository type=tarball name=freedesktop.org
   href=""
+  repository type=git name=gstreamer
+  href=""
+  repository type=git name=entropywave
+  href=""
+  repository type=tarball name=xiph
+  href=""
 
   autotools id=make autogen-sh=configure
 branch repo=ftp.gnu.org
@@ -210,4 +221,67 @@
 /dependencies
   /autotools
 
+  autotools id=orc
+branch repo=entropywave module=orc.git checkoutdir=orc tag=orc-0.4.16 /
+  /autotools
+
+  autotools id=gstreamer
+branch repo=gstreamer module=gstreamer checkoutdir=gstreamer revision=80f94703f985d8f125196dec1baa08d46657923f/
+  /autotools
+
+  autotools id=libogg autogen-sh=configure 
+ branch repo=xiph module=ogg/libogg-1.3.0.tar.gz
+ hash=sha256:a8de807631014615549d2356fd36641833b8288221cea214f8a72750efe93780
+ md5sum=0a7eb40b86ac050db3a789ab65fe21c2
+ version=1.3.0/
+  /autotools
+  autotools id=libvorbis autogen-sh=configure autogenargs=--disable-examples 
+ branch repo=xiph module=vorbis/libvorbis-1.3.3.tar.gz
+ hash=sha256:6d747efe7ac4ad249bf711527882cef79fb61d9194c45b5ca5498aa60f290762
+ md5sum=6b1a36f0d72332fae5130688e65efe1f
+ version=1.3.3/
+  /autotools
+  autotools id=libtheora autogen-sh=configure autogenargs=--disable-examples
+ branch repo=xiph module=theora/libtheora-1.1.1.tar.gz
+ hash=sha256:40952956c47811928d1e7922cda3bc1f427eb75680c3c37249c91e949054916b
+ md5sum=bb4dc37f0dc97db98333e7160bfbb52b
+ version=1.1.1/
+dependencies
+  dep package=libogg/
+  dep package=libvorbis/
+/dependencies
+  /autotools
+
+  autotools id=gst-plugins-base autogenargs=--disable-examples
+dependencies
+  dep package=gstreamer/
+  dep package=libogg/
+  dep package=libvorbis/
+  dep package=libtheora/
+  dep package=orc/
+/dependencies
+branch repo=gstreamer module=gst-plugins-base checkoutdir=gst-plugins-base revision=4b56b731d26eca35967075c34f375788f4a531b3/
+  /autotools
+
+  autotools id=gst-plugins-good autogenargs=--disable-examples
+dependencies
+  dep package=gst-plugins-base/
+/dependencies
+branch repo=gstreamer module=gst-plugins-good checkoutdir=gst-plugins-good 

[webkit-changes] [123221] trunk/LayoutTests

[schenney]

Title: [123221] trunk/LayoutTests








Revision 123221
Author schen...@chromium.org
Date 2012-07-20 08:33:33 -0700 (Fri, 20 Jul 2012)


Log Message
Rebaseline failing test svg/as-image/svg-non-integer-scaled-image.html

Unreviewed test expectations update.

* platform/chromium/svg/as-image: Added.
* platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium/svg/as-image/
trunk/LayoutTests/platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (123220 => 123221)

--- trunk/LayoutTests/ChangeLog	2012-07-20 15:12:54 UTC (rev 123220)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 15:33:33 UTC (rev 123221)
@@ -1,3 +1,12 @@
+2012-07-20  Stephen Chenney  schen...@chromium.org
+
+Rebaseline failing test svg/as-image/svg-non-integer-scaled-image.html
+
+Unreviewed test expectations update.
+
+* platform/chromium/svg/as-image: Added.
+* platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt: Added.
+
 2012-07-20  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r123182.


Added: trunk/LayoutTests/platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt (0 => 123221)

--- trunk/LayoutTests/platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt	2012-07-20 15:33:33 UTC (rev 123221)
@@ -0,0 +1,7 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (0,0) size 800x600
+  RenderImage {IMG} at (0,0) size 99x101
+  RenderText {#text} at (0,0) size 0x0






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123224] trunk/LayoutTests

[zandobersek]

Title: [123224] trunk/LayoutTests








Revision 123224
Author zandober...@gmail.com
Date 2012-07-20 10:09:54 -0700 (Fri, 20 Jul 2012)


Log Message
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, managing a few more unexpected passes for the GTK port.

Remove a few expectations for tests that were passing, reclassify some failures as
architecture-specific and add PASS expectations for a few tests that pass even though
they test features that are currently not supported on the GTK port.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123223 => 123224)

--- trunk/LayoutTests/ChangeLog	2012-07-20 16:50:40 UTC (rev 123223)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 17:09:54 UTC (rev 123224)
@@ -1,5 +1,18 @@
 2012-07-20  Zan Dobersek  zandober...@gmail.com
 
+[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
+https://bugs.webkit.org/show_bug.cgi?id=85591
+
+Unreviewed, managing a few more unexpected passes for the GTK port.
+
+Remove a few expectations for tests that were passing, reclassify some failures as
+architecture-specific and add PASS expectations for a few tests that pass even though
+they test features that are currently not supported on the GTK port.
+
+* platform/gtk/TestExpectations:
+
+2012-07-20  Zan Dobersek  zandober...@gmail.com
+
 Unreviewed GTK gardening, adding platform-specific baseline that's required
 after changes in r123145.
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (123223 => 123224)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-20 16:50:40 UTC (rev 123223)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-20 17:09:54 UTC (rev 123224)
@@ -152,6 +152,7 @@
 
 // ENABLE_INPUT_TYPE_* are not enabled.
 BUGWK29359 : fast/forms/date = TEXT
+BUGWK29359 : fast/forms/date/calendar-picker-type-change-onclick.html = PASS
 BUGWK29359 : fast/forms/date/date-stepup-stepdown-from-renderer.html = PASS
 BUGWK29359 : fast/forms/date/no-page-popup-controller.html = PASS
 BUGWK90987 : fast/forms/input-in-table-cell-no-value.html = IMAGE
@@ -321,15 +322,18 @@
 
 // These tests require subpixel layout to be enabled
 BUGWK85532 : fast/sub-pixel = TEXT IMAGE
+BUGWK85532 : fast/sub-pixel/column-clipping.html = PASS
+BUGWK85532 : fast/sub-pixel/file-upload-control-at-fractional-offset.html = PASS
 BUGWK85532 : fast/sub-pixel/float-containing-block-with-margin.html = PASS
 BUGWK85532 : fast/sub-pixel/float-with-margin-in-container.html = PASS
 BUGWK85532 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS
 BUGWK85532 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
 BUGWK85532 : fast/sub-pixel/inline-block-with-margin.html = PASS
-BUGWK85532 : fast/sub-pixel/file-upload-control-at-fractional-offset.html = PASS
-BUGWK85532 : fast/sub-pixel/column-clipping.html = PASS
+BUGWK85532 : fast/sub-pixel/size-of-span-with-different-positions.html = PASS
 BUGWK85532 : fast/sub-pixel/table-cells-with-padding-do-not-wrap.html = PASS
 BUGWK85532 : fast/sub-pixel/table-rows-have-stable-height.html = PASS
+BUGWK85532 : fast/sub-pixel/table-rows-no-gaps.html = PASS
+BUGWK85532 : fast/sub-pixel/vertical-align-middle-overflow.html = PASS
 
 // Mediastream implementation is not complete yet.
 BUGWK79203 SKIP : fast/mediastream = TEXT
@@ -392,8 +396,6 @@
 
 BUGWK89188 RELEASE : storage/websql/quota-tracking.html = CRASH PASS
 
-BUGWK89954 DEBUG : http/tests/xmlhttprequest/reentrant-cancel.html = CRASH
-
 BUGWK90589 RELEASE : fast/css/user-drag-none.html = CRASH TIMEOUT
 
 //
@@ -482,6 +484,8 @@
 
 BUGWK91314 : http/tests/misc/webtiming-origins.html = PASS TEXT
 
+BUGWK70485 : fast/events/drag-selects-image.html = PASS TEXT
+
 //
 // End of Flaky tests
 //
@@ -508,6 +512,7 @@
 // Fail on 32-bit release builders
 BUGWK84857 : fast/repaint/moving-shadow-on-container.html = PASS TEXT
 BUGWK84857 : fast/repaint/moving-shadow-on-path.html = PASS TEXT
+BUGWK80210 : security/block-test.html = PASS TEXT
 BUGWK43568 : sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.16_sin/S15.8.2.16_A7.html = PASS TEXT
 BUGWK43568 : sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.18_tan/S15.8.2.18_A7.html = PASS TEXT
 BUGWK62204 : svg/W3C-SVG-1.1/paths-data-03-f.svg = PASS TEXT
@@ -524,6 +529,9 @@
 // Fails on 32-bit release and 64-bit debug builders
 BUGWK83560 : fast/events/drop-with-file-paths.html = PASS TEXT
 
+// Fails on 32-bit release and 64-bit release builders

[webkit-changes] [123225] trunk/Source/WebCore

[senorblanco]

Title: [123225] trunk/Source/WebCore








Revision 123225
Author senorbla...@chromium.org
Date 2012-07-20 10:13:58 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Enable GPU-accelerated skia implementation of
feDiffuseLighting, feSpecularLighting.
https://bugs.webkit.org/show_bug.cgi?id=91865

Reviewed by Dirk Schulze.

Translate the light parameters into the appropriate
SkLightingImageFilter calls.  This path is only enabled when
the filters are created with the Accelerated flag set.

This will be covered by tests in svg/filters/* when they are
added to the virtual GPU tests.

* WebCore.gypi:
* platform/graphics/filters/FELighting.h:
(FELighting):
* platform/graphics/filters/skia/FELightingSkia.cpp: Added.
(WebCore):
(WebCore::FELighting::platformApplySkia):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/graphics/filters/FELighting.h


Added Paths

trunk/Source/WebCore/platform/graphics/filters/skia/FELightingSkia.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123224 => 123225)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 17:09:54 UTC (rev 123224)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 17:13:58 UTC (rev 123225)
@@ -1,3 +1,25 @@
+2012-07-20  Stephen White  senorbla...@chromium.org
+
+[chromium] Enable GPU-accelerated skia implementation of
+feDiffuseLighting, feSpecularLighting.
+https://bugs.webkit.org/show_bug.cgi?id=91865
+
+Reviewed by Dirk Schulze.
+
+Translate the light parameters into the appropriate
+SkLightingImageFilter calls.  This path is only enabled when
+the filters are created with the Accelerated flag set.
+
+This will be covered by tests in svg/filters/* when they are
+added to the virtual GPU tests.
+
+* WebCore.gypi:
+* platform/graphics/filters/FELighting.h:
+(FELighting):
+* platform/graphics/filters/skia/FELightingSkia.cpp: Added.
+(WebCore):
+(WebCore::FELighting::platformApplySkia):
+
 2012-07-20  Pavel Feldman  pfeld...@chromium.org
 
 Web Inspector: disable fake workers inspection.


Modified: trunk/Source/WebCore/WebCore.gypi (123224 => 123225)

--- trunk/Source/WebCore/WebCore.gypi	2012-07-20 17:09:54 UTC (rev 123224)
+++ trunk/Source/WebCore/WebCore.gypi	2012-07-20 17:13:58 UTC (rev 123225)
@@ -3725,6 +3725,7 @@
 'platform/graphics/filters/skia/FEColorMatrixSkia.cpp',
 'platform/graphics/filters/skia/FEGaussianBlurSkia.cpp',
 'platform/graphics/filters/skia/FEMorphologySkia.cpp',
+'platform/graphics/filters/skia/FELightingSkia.cpp',
 'platform/graphics/freetype/FontCacheFreeType.cpp',
 'platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp',
 'platform/graphics/freetype/FontPlatformData.h',


Modified: trunk/Source/WebCore/platform/graphics/filters/FELighting.h (123224 => 123225)

--- trunk/Source/WebCore/platform/graphics/filters/FELighting.h	2012-07-20 17:09:54 UTC (rev 123224)
+++ trunk/Source/WebCore/platform/graphics/filters/FELighting.h	2012-07-20 17:13:58 UTC (rev 123225)
@@ -46,6 +46,9 @@
 class FELighting : public FilterEffect {
 public:
 virtual void platformApplySoftware();
+#if USE(SKIA)
+virtual bool platformApplySkia();
+#endif
 
 virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
 


Added: trunk/Source/WebCore/platform/graphics/filters/skia/FELightingSkia.cpp (0 => 123225)

--- trunk/Source/WebCore/platform/graphics/filters/skia/FELightingSkia.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/graphics/filters/skia/FELightingSkia.cpp	2012-07-20 17:13:58 UTC (rev 123225)
@@ -0,0 +1,107 @@
+/*
+ * Copyright (C) 2012 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS AS IS AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, 

[webkit-changes] [123226] trunk/LayoutTests

[zandobersek]

Title: [123226] trunk/LayoutTests








Revision 123226
Author zandober...@gmail.com
Date 2012-07-20 10:25:52 -0700 (Fri, 20 Jul 2012)


Log Message
Unreviewed GTK gardening, rebaselining a test after r117477.

* platform/gtk/TestExpectations:
* platform/gtk/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug10296-1-expected.png
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (123225 => 123226)

--- trunk/LayoutTests/ChangeLog	2012-07-20 17:13:58 UTC (rev 123225)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 17:25:52 UTC (rev 123226)
@@ -1,5 +1,13 @@
 2012-07-20  Zan Dobersek  zandober...@gmail.com
 
+Unreviewed GTK gardening, rebaselining a test after r117477.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/tables/mozilla/bugs/bug10296-1-expected.png:
+* platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:
+
+2012-07-20  Zan Dobersek  zandober...@gmail.com
+
 [Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
 https://bugs.webkit.org/show_bug.cgi?id=85591
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (123225 => 123226)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-20 17:13:58 UTC (rev 123225)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-20 17:25:52 UTC (rev 123226)
@@ -1182,9 +1182,6 @@
 
 BUGWK86445 : fast/multicol/split-in-top-margin.html = IMAGE
 
-// Requires rebaseline after https://bugs.webkit.org/show_bug.cgi?id=85405
-BUGWK85405 : tables/mozilla/bugs/bug10296-1.html = TEXT
-
 // Paletted PNG with ICC color profiles not working.
 BUGWK86722 SKIP : fast/images/paletted-png-with-color-profile.html = TEXT MISSING
 


Modified: trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug10296-1-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt (123225 => 123226)

--- trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt	2012-07-20 17:13:58 UTC (rev 123225)
+++ trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt	2012-07-20 17:25:52 UTC (rev 123226)
@@ -947,7 +947,7 @@
 RenderTableCell {TD} at (326,74) size 34x22 [border: (1px solid #00)] [r=0 c=4 rs=1 cs=1]
   RenderText {#text} at (2,2) size 30x19
 text run at (2,2) width 30: Data
-RenderTableCell {TD} at (362,2) size 94x59 [border: (1px solid #00)] [r=0 c=5 rs=1 cs=1]
+RenderTableCell {TD} at (362,46) size 94x59 [border: (1px solid #00)] [r=0 c=5 rs=1 cs=1]
   RenderText {#text} at (2,2) size 90x54
 text run at (2,2) width 90: Data
   RenderTable {TABLE} at (0,5440) size 458x118
@@ -962,13 +962,13 @@
 RenderTableCell {TD} at (222,48) size 49x22 [border: (1px solid #00)] [r=0 c=2 rs=1 cs=1]
   RenderText {#text} at (2,2) size 45x19
 text run at (2,2) width 45: Middle
-RenderTableCell {TD} at (273,30) size 34x22 [border: (1px solid #00)] [r=0 c=3 rs=1 cs=1]
+RenderTableCell {TD} at (273,74) size 34x22 [border: (1px solid #00)] [r=0 c=3 rs=1 cs=1]
   RenderText {#text} at (2,2) size 30x19
 text run at (2,2) width 30: Data
 RenderTableCell {TD} at (309,94) size 51x22 [border: (1px solid #00)] [r=0 c=4 rs=1 cs=1]
   RenderText {#text} at (2,2) size 47x19
 text run at (2,2) width 47: Bottom
-RenderTableCell {TD} at (362,2) size 94x59 [border: (1px solid #00)] [r=0 c=5 rs=1 cs=1]
+RenderTableCell {TD} at (362,46) size 94x59 [border: (1px solid #00)] [r=0 c=5 rs=1 cs=1]
   RenderText {#text} at (2,2) size 90x54
 text run at (2,2) width 90: Data
   RenderTable {TABLE} at (0,5558) size 458x118
@@ -998,13 +998,13 @@
 RenderTableCell {TD} at (2,2) size 30x22 [border: (1px solid #00)] [r=0 c=0 rs=1 cs=1]
   RenderText {#text} at (2,2) size 26x19
 text run at (2,2) width 26: Top
-RenderTableCell {TD} at (34,2) size 94x59 [border: (1px solid #00)] [r=0 c=1 rs=1 cs=1]
+RenderTableCell {TD} at (34,46) size 94x59 [border: (1px solid #00)] [r=0 c=1 rs=1 cs=1]
   RenderText {#text} at (2,2) size 90x54
 text run at (2,2) width 90: Data
 RenderTableCell {TD} at (130,94) size 51x22 [border: (1px solid #00)] [r=0 c=2 rs=1 cs=1]
   RenderText {#text} at (2,2) size 47x19
 text run at (2,2) width 47: Bottom
-RenderTableCell {TD} at (183,2) size 34x22 [border: (1px solid #00)] [r=0 c=3 

[webkit-changes] [123227] trunk/Tools

[philn]

Title: [123227] trunk/Tools








Revision 123227
Author ph...@webkit.org
Date 2012-07-20 10:29:23 -0700 (Fri, 20 Jul 2012)


Log Message
Unreviewed, rolling out r123220.
http://trac.webkit.org/changeset/123220
https://bugs.webkit.org/show_bug.cgi?id=91880

broke Debug build (Requested by philn on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-07-20

* Scripts/webkitdirs.pm:
(buildAutotoolsProject):
* gtk/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (123226 => 123227)

--- trunk/Tools/ChangeLog	2012-07-20 17:25:52 UTC (rev 123226)
+++ trunk/Tools/ChangeLog	2012-07-20 17:29:23 UTC (rev 123227)
@@ -1,3 +1,15 @@
+2012-07-20  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r123220.
+http://trac.webkit.org/changeset/123220
+https://bugs.webkit.org/show_bug.cgi?id=91880
+
+broke Debug build (Requested by philn on #webkit).
+
+* Scripts/webkitdirs.pm:
+(buildAutotoolsProject):
+* gtk/jhbuild.modules:
+
 2012-07-20  Philippe Normand  pnorm...@igalia.com
 
 [GTK][jhbuild] Switch to GStreamer 0.11 build


Modified: trunk/Tools/Scripts/webkitdirs.pm (123226 => 123227)

--- trunk/Tools/Scripts/webkitdirs.pm	2012-07-20 17:25:52 UTC (rev 123226)
+++ trunk/Tools/Scripts/webkitdirs.pm	2012-07-20 17:29:23 UTC (rev 123227)
@@ -2090,11 +2090,6 @@
 # Enable unstable features when building through build-webkit.
 push @buildArgs, --enable-unstable-features;
 
-# Enable upcoming GStreamer 1.0 build support through build-webkit.
-if ($project eq 'WebKit') {
-push @buildArgs, --with-gstreamer=1.0;
-}
-
 # We might need to update jhbuild dependencies.
 my $needUpdate = 0;
 if (jhbuildConfigurationChanged()) {


Modified: trunk/Tools/gtk/jhbuild.modules (123226 => 123227)

--- trunk/Tools/gtk/jhbuild.modules	2012-07-20 17:25:52 UTC (rev 123226)
+++ trunk/Tools/gtk/jhbuild.modules	2012-07-20 17:29:23 UTC (rev 123227)
@@ -18,11 +18,6 @@
   dep package=libsoup/
   dep package=at-spi2-core/
   dep package=at-spi2-atk/
-  dep package=gstreamer/
-  dep package=gst-plugins-base/
-  dep package=gst-plugins-good/
-  dep package=gst-plugins-bad/
-  dep package=gst-ffmpeg/
 /dependencies
   /metamodule
 
@@ -42,12 +37,6 @@
   href=""
   repository type=tarball name=freedesktop.org
   href=""
-  repository type=git name=gstreamer
-  href=""
-  repository type=git name=entropywave
-  href=""
-  repository type=tarball name=xiph
-  href=""
 
   autotools id=make autogen-sh=configure
 branch repo=ftp.gnu.org
@@ -221,67 +210,4 @@
 /dependencies
   /autotools
 
-  autotools id=orc
-branch repo=entropywave module=orc.git checkoutdir=orc tag=orc-0.4.16 /
-  /autotools
-
-  autotools id=gstreamer
-branch repo=gstreamer module=gstreamer checkoutdir=gstreamer revision=80f94703f985d8f125196dec1baa08d46657923f/
-  /autotools
-
-  autotools id=libogg autogen-sh=configure 
- branch repo=xiph module=ogg/libogg-1.3.0.tar.gz
- hash=sha256:a8de807631014615549d2356fd36641833b8288221cea214f8a72750efe93780
- md5sum=0a7eb40b86ac050db3a789ab65fe21c2
- version=1.3.0/
-  /autotools
-  autotools id=libvorbis autogen-sh=configure autogenargs=--disable-examples 
- branch repo=xiph module=vorbis/libvorbis-1.3.3.tar.gz
- hash=sha256:6d747efe7ac4ad249bf711527882cef79fb61d9194c45b5ca5498aa60f290762
- md5sum=6b1a36f0d72332fae5130688e65efe1f
- version=1.3.3/
-  /autotools
-  autotools id=libtheora autogen-sh=configure autogenargs=--disable-examples
- branch repo=xiph module=theora/libtheora-1.1.1.tar.gz
- hash=sha256:40952956c47811928d1e7922cda3bc1f427eb75680c3c37249c91e949054916b
- md5sum=bb4dc37f0dc97db98333e7160bfbb52b
- version=1.1.1/
-dependencies
-  dep package=libogg/
-  dep package=libvorbis/
-/dependencies
-  /autotools
-
-  autotools id=gst-plugins-base autogenargs=--disable-examples
-dependencies
-  dep package=gstreamer/
-  dep package=libogg/
-  dep package=libvorbis/
-  dep package=libtheora/
-  dep package=orc/
-/dependencies
-branch repo=gstreamer module=gst-plugins-base checkoutdir=gst-plugins-base revision=4b56b731d26eca35967075c34f375788f4a531b3/
-  /autotools
-
-  autotools id=gst-plugins-good autogenargs=--disable-examples
-dependencies
-  dep package=gst-plugins-base/
-/dependencies
-branch repo=gstreamer module=gst-plugins-good checkoutdir=gst-plugins-good revision=cc6d533521841bc949136e969d96230ad7a30bd2/
-  /autotools
-
-  autotools id=gst-plugins-bad autogenargs=--disable-examples
-dependencies
-  dep package=gst-plugins-base/
-/dependencies
-branch repo=gstreamer module=gst-plugins-bad checkoutdir=gst-plugins-bad 

[webkit-changes] [123228] trunk/Websites/bugs.webkit.org

[wsiegrist]

Title: [123228] trunk/Websites/bugs.webkit.org








Revision 123228
Author wsiegr...@apple.com
Date 2012-07-20 10:35:33 -0700 (Fri, 20 Jul 2012)


Log Message
Port bugs.webkit.org to mod_perl for new hardware.

Reviewed by David Kilzer.

Modified Paths

trunk/Websites/bugs.webkit.org/Bugzilla/User.pm
trunk/Websites/bugs.webkit.org/attachment.cgi
trunk/Websites/bugs.webkit.org/checksetup.pl
trunk/Websites/bugs.webkit.org/data/params
trunk/Websites/bugs.webkit.org/mod_perl.pl




Diff

Modified: trunk/Websites/bugs.webkit.org/Bugzilla/User.pm (123227 => 123228)

--- trunk/Websites/bugs.webkit.org/Bugzilla/User.pm	2012-07-20 17:29:23 UTC (rev 123227)
+++ trunk/Websites/bugs.webkit.org/Bugzilla/User.pm	2012-07-20 17:35:33 UTC (rev 123228)
@@ -582,7 +582,13 @@
 sub can_see_bug {
 my ($self, $bugid) = @_;
 my $dbh = Bugzilla-dbh;
-my $sth  = $self-{sthCanSeeBug};
+
+#if WEBKIT_CHANGES
+# FIXME: disable memoization since it results in stale handle
+my $sth;
+#my $sth  = $self-{sthCanSeeBug};
+#endif WEBKIT_CHANGES 
+
 my $userid  = $self-id;
 # Get fields from bug, presence of user on cclist, and determine if
 # the user is missing any groups required by the bug. The prepared query
@@ -610,7 +616,12 @@
 my ($ready, $reporter, $owner, $qacontact, $reporter_access, $cclist_access,
 $isoncclist, $missinggroup) = $sth-fetchrow_array();
 $sth-finish;
-$self-{sthCanSeeBug} = $sth;
+
+#if WEBKIT_CHANGES
+# FIXME: disable memoization since it results in stale handle
+#$self-{sthCanSeeBug} = $sth;
+#endif WEBKIT_CHANGES 
+
 return ($ready
  ((($reporter == $userid)  $reporter_access)
 || (Bugzilla-params-{'useqacontact'} 


Modified: trunk/Websites/bugs.webkit.org/attachment.cgi (123227 => 123228)

--- trunk/Websites/bugs.webkit.org/attachment.cgi	2012-07-20 17:29:23 UTC (rev 123227)
+++ trunk/Websites/bugs.webkit.org/attachment.cgi	2012-07-20 17:35:33 UTC (rev 123228)
@@ -53,7 +53,8 @@
 use Bugzilla::Keyword;
 
 #if WEBKIT_CHANGES
-use IPC::Open2;
+use Apache2::SubProcess ();
+use Apache2::RequestUtil ();
 #endif // WEBKIT_CHANGES
 
 # For most scripts we don't make $cgi and $template global variables. But
@@ -392,16 +393,16 @@
 print $cgi-header(-type = 'text/html',
-expires = '+3M');
 
-my $orig_path = $ENV{'PATH'};
-$ENV{'PATH'} = /opt/local/bin: . $ENV{'PATH'};
-open2(\*OUT, \*IN, /usr/bin/ruby, -I, PrettyPatch, PrettyPatch/prettify.rb, --html-exceptions);
-$ENV{'PATH'} = $orig_path;
-print IN $attachment-data;
-close(IN);
-while (OUT) {
+my @prettyargs = (-I, /var/www/html/PrettyPatch, /var/www/html/PrettyPatch/prettify.rb, --html-exceptions);
+my $r = Apache2::RequestUtil-request;
+my ($in, $out, $err) = $r-spawn_proc_prog(/usr/bin/ruby, \@prettyargs);
+print $in $attachment-data;
+close($in);
+while ($out) {
 print;
 }
-close(OUT);
+close($out);
+close($err);
 }
 #endif // WEBKIT_CHANGES
 


Modified: trunk/Websites/bugs.webkit.org/checksetup.pl (123227 => 123228)

--- trunk/Websites/bugs.webkit.org/checksetup.pl	2012-07-20 17:29:23 UTC (rev 123227)
+++ trunk/Websites/bugs.webkit.org/checksetup.pl	2012-07-20 17:35:33 UTC (rev 123228)
@@ -1,4 +1,4 @@
-#!/usr/bin/env perl -w
+#!/bin/env perl
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public


Modified: trunk/Websites/bugs.webkit.org/data/params (123227 => 123228)

--- trunk/Websites/bugs.webkit.org/data/params	2012-07-20 17:29:23 UTC (rev 123227)
+++ trunk/Websites/bugs.webkit.org/data/params	2012-07-20 17:35:33 UTC (rev 123228)
@@ -34,8 +34,8 @@
'createemailregexp' = '.*',
'cvsroot' = '',
'cvsroot_get' = '',
-   'defaultopsys' = 'Mac OS X 10.5',
-   'defaultplatform' = '',
+   'defaultopsys' = 'Unspecified',
+   'defaultplatform' = 'Unspecified',
'defaultpriority' = 'P2',
'defaultquery' = 'bug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDemailassigned_to1=1emailassigned_to2=1emailreporter2=1emailcc2=1emailqa_contact2=1order=Importancelong_desc_type=substring',
'defaultseverity' = 'Normal',
@@ -51,7 +51,7 @@
'loginnetmask' = '0',
'lxr_root' = '',
'lxr_url' = '',
-   'mail_delivery_method' = 'Sendmail',
+   'mail_delivery_method' = 'SMTP',
'mailfrom' = 'bugzilla-dae...@webkit.org',
'maintainer' = 'ad...@webkit.org',
'makeproductgroups' = 0,
@@ -87,7 +87,7 @@
'smtp_debug' = 0,
'smtp_password' = '',
'smtp_username' = '',
-   'smtpserver' = 'localhost',
+   'smtpserver' = 'bz.apple.com',
'specific_search_allow_empty_words' = 0,
'ssl' = 'always',
'sslbase' = 'https://bugs.webkit.org/',
@@ -97,7 

[webkit-changes] [123231] branches/chromium/1180

[eae]

Title: [123231] branches/chromium/1180








Revision 123231
Author e...@chromium.org
Date 2012-07-20 10:50:32 -0700 (Fri, 20 Jul 2012)


Log Message
Merge 122769 - Inconsistent rounding in table layout causes background color to bleed through
https://bugs.webkit.org/show_bug.cgi?id=91410

Reviewed by Eric Seidel.

Source/WebCore: 

At certain zoom levels a rounding error in the table layout code cases
the table background color to bleed through between cells. Tables layout
happens on pixel bounds however the paint offset wasn't correctly rounded.

Test: fast/sub-pixel/table-rows-no-gaps.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
Round paintOffset before passing it to the paint method of the children.

LayoutTests: 

Add test to ensure that the table background color doesn't bleed through
when the table and a cell are positioned on a subpixel bound.

* fast/sub-pixel/table-rows-no-gaps-expected.html: Added.
* fast/sub-pixel/table-rows-no-gaps.html: Added.
* platform/chromium-linux/css1/basic/inheritance-expected.png:
* platform/chromium-linux/plugins/embed-attributes-style-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
Updated expectations to match new rounding logic. The new results better
match the rendering prior to turning on subpixel layout.

* platform/efl/Skipped:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
Mark new test as skipped on platforms that have not enabled subpixel
layout.


TBR=e...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10815035

Modified Paths

branches/chromium/1180/LayoutTests/ChangeLog
branches/chromium/1180/LayoutTests/platform/chromium-linux/css1/basic/inheritance-expected.png
branches/chromium/1180/LayoutTests/platform/chromium-linux/plugins/embed-attributes-style-expected.png
branches/chromium/1180/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png
branches/chromium/1180/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png
branches/chromium/1180/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
branches/chromium/1180/LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png
branches/chromium/1180/LayoutTests/platform/efl/Skipped
branches/chromium/1180/LayoutTests/platform/mac/Skipped
branches/chromium/1180/LayoutTests/platform/mac-lion/Skipped
branches/chromium/1180/LayoutTests/platform/mac-snowleopard/Skipped
branches/chromium/1180/LayoutTests/platform/mac-wk2/Skipped
branches/chromium/1180/LayoutTests/platform/qt/Skipped
branches/chromium/1180/LayoutTests/platform/qt-4.8/Skipped
branches/chromium/1180/LayoutTests/platform/win/Skipped
branches/chromium/1180/LayoutTests/platform/win-wk2/Skipped
branches/chromium/1180/LayoutTests/platform/win-xp/Skipped
branches/chromium/1180/LayoutTests/platform/wincairo/Skipped
branches/chromium/1180/LayoutTests/platform/wk2/Skipped
branches/chromium/1180/Source/WebCore/ChangeLog
branches/chromium/1180/Source/WebCore/rendering/RenderTable.cpp


Added Paths

branches/chromium/1180/LayoutTests/fast/sub-pixel/table-rows-no-gaps-expected.html
branches/chromium/1180/LayoutTests/fast/sub-pixel/table-rows-no-gaps.html




Diff

Modified: branches/chromium/1180/LayoutTests/ChangeLog (123230 => 123231)

--- branches/chromium/1180/LayoutTests/ChangeLog	2012-07-20 17:49:15 UTC (rev 123230)
+++ branches/chromium/1180/LayoutTests/ChangeLog	2012-07-20 17:50:32 UTC (rev 123231)
@@ -1,3 +1,41 @@
+2012-07-16  Emil A Eklund  e...@chromium.org
+
+Inconsistent rounding in table layout causes background color to bleed through
+https://bugs.webkit.org/show_bug.cgi?id=91410
+
+Reviewed by Eric Seidel.
+
+Add test to ensure that the table background color doesn't bleed through
+when the table and a cell are positioned on a subpixel bound.
+
+* fast/sub-pixel/table-rows-no-gaps-expected.html: Added.
+* fast/sub-pixel/table-rows-no-gaps.html: Added.
+* platform/chromium-linux/css1/basic/inheritance-expected.png:
+* platform/chromium-linux/plugins/embed-attributes-style-expected.png:
+* 

[webkit-changes] [123232] trunk/Tools

[tony]

Title: [123232] trunk/Tools








Revision 123232
Author t...@chromium.org
Date 2012-07-20 10:53:03 -0700 (Fri, 20 Jul 2012)


Log Message
Baseline align text in the flakiness dashboard toolbar
https://bugs.webkit.org/show_bug.cgi?id=91784

Reviewed by Ojan Vafai.

Baseline align the flex items.

* TestResultServer/static-dashboards/flakiness_dashboard.css:
(.forms): Add box-align: baseline
(.forms  *): Use block display to force flex items rather than box.
(#tests-form): Add box-align: baseline
(#tests-form  *): Use block display to force flex items rather than box.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css




Diff

Modified: trunk/Tools/ChangeLog (123231 => 123232)

--- trunk/Tools/ChangeLog	2012-07-20 17:50:32 UTC (rev 123231)
+++ trunk/Tools/ChangeLog	2012-07-20 17:53:03 UTC (rev 123232)
@@ -1,3 +1,18 @@
+2012-07-20  Tony Chang  t...@chromium.org
+
+Baseline align text in the flakiness dashboard toolbar
+https://bugs.webkit.org/show_bug.cgi?id=91784
+
+Reviewed by Ojan Vafai.
+
+Baseline align the flex items.
+
+* TestResultServer/static-dashboards/flakiness_dashboard.css:
+(.forms): Add box-align: baseline
+(.forms  *): Use block display to force flex items rather than box.
+(#tests-form): Add box-align: baseline
+(#tests-form  *): Use block display to force flex items rather than box.
+
 2012-07-20  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r123220.


Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css (123231 => 123232)

--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css	2012-07-20 17:50:32 UTC (rev 123231)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css	2012-07-20 17:53:03 UTC (rev 123232)
@@ -49,19 +49,21 @@
 }
 .forms {
 display: -webkit-box;
+-webkit-box-align: baseline;
 }
 .forms  * {
-display: -webkit-box;
+display: block;
 }
 .forms span {
 padding: 0px 3px;
 }
 #tests-form {
 display: -webkit-box;
+-webkit-box-align: baseline;
 -webkit-box-flex: 1;
 }
 #tests-form  * {
-display: -webkit-box;
+display: block;
 }
 #tests-input {
 display: -webkit-box;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123233] trunk/Source/WebCore

[adamk]

Title: [123233] trunk/Source/WebCore








Revision 123233
Author ad...@chromium.org
Date 2012-07-20 10:56:12 -0700 (Fri, 20 Jul 2012)


Log Message
CodeGeneratorInspector.py is unnecessarily chatty
https://bugs.webkit.org/show_bug.cgi?id=91758

Reviewed by Vsevolod Vlasov.

The code aded in r123091 included a print statement for each written
file. This makes for noisy build output, especially noticeable in the
Chromium ninja build (where build output takes up a single line of the
console).

If this print statement is generally useful, it should be
hidden behind a --verbose commandline option, as we do for the binding
generators.

* inspector/CodeGeneratorInspector.py:
(SmartOutput.close): Remove print statement.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py




Diff

Modified: trunk/Source/WebCore/ChangeLog (123232 => 123233)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 17:53:03 UTC (rev 123232)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 17:56:12 UTC (rev 123233)
@@ -1,3 +1,22 @@
+2012-07-20  Adam Klein  ad...@chromium.org
+
+CodeGeneratorInspector.py is unnecessarily chatty
+https://bugs.webkit.org/show_bug.cgi?id=91758
+
+Reviewed by Vsevolod Vlasov.
+
+The code aded in r123091 included a print statement for each written
+file. This makes for noisy build output, especially noticeable in the
+Chromium ninja build (where build output takes up a single line of the
+console).
+
+If this print statement is generally useful, it should be
+hidden behind a --verbose commandline option, as we do for the binding
+generators.
+
+* inspector/CodeGeneratorInspector.py:
+(SmartOutput.close): Remove print statement.
+
 2012-07-20  Stephen White  senorbla...@chromium.org
 
 [chromium] Enable GPU-accelerated skia implementation of


Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (123232 => 123233)

--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-07-20 17:53:03 UTC (rev 123232)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-07-20 17:56:12 UTC (rev 123233)
@@ -2975,7 +2975,6 @@
 pass
 
 if text_changed:
-print writing  + self.file_name_
 out_file = open(self.file_name_, w)
 out_file.write(self.output_)
 out_file.close()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123234] branches/chromium/1180

[eae]

Title: [123234] branches/chromium/1180








Revision 123234
Author e...@chromium.org
Date 2012-07-20 10:56:43 -0700 (Fri, 20 Jul 2012)


Log Message
Merge 122861 - Incorrect offset used for scrollWidth/Height calculation
https://bugs.webkit.org/show_bug.cgi?id=91461

Reviewed by Eric Seidel.

Source/WebCore:

Due to a different offset being used to calculate the scrollWidth/Height
and pixelSnappedClientWidth/Height the scroll value can be off by one in
same cases. This can causes scrollbars to appear even when there is no
overflow.

Test: fast/sub-pixel/block-with-margin-overflow.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
Change location offset passed to snapSizeToPixel to include x() to match
offset used by pixelSnappedClientWidth.

(WebCore::RenderBox::scrollHeight):
Change location offset passed to snapSizeToPixel to include y() to match
offset used by pixelSnappedClientHeight.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clampScrollOffset):
Change calculation to use pixelSnappedClientWidth/Height as it is
subtracted from the pixel snapped scrollWidth/Height values.

(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Change RenderLayer versions of scrollWidth/Height to include x()/y() as
per the RenderBox versions.

LayoutTests:

Add new test ensuring that a block that shouldn't have overflow doesn't
have scrollbars.

* fast/sub-pixel/block-with-margin-overflow-expected.html: Added.
* fast/sub-pixel/block-with-margin-overflow.html: Added.
* platform/chromium-win/fast/block/float/026-expected.txt:
* platform/chromium-win/fast/block/float/028-expected.txt:
* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
* platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png:
* platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
Update test expectations that incorrectly had overflow.


TBR=e...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10790105

Modified Paths

branches/chromium/1180/LayoutTests/ChangeLog
branches/chromium/1180/LayoutTests/platform/chromium-win/fast/block/float/026-expected.txt
branches/chromium/1180/LayoutTests/platform/chromium-win/fast/block/float/028-expected.txt
branches/chromium/1180/LayoutTests/platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt
branches/chromium/1180/Source/WebCore/ChangeLog
branches/chromium/1180/Source/WebCore/rendering/RenderBox.cpp
branches/chromium/1180/Source/WebCore/rendering/RenderLayer.cpp


Added Paths

branches/chromium/1180/LayoutTests/fast/sub-pixel/block-with-margin-overflow-expected.html
branches/chromium/1180/LayoutTests/fast/sub-pixel/block-with-margin-overflow.html




Diff

Modified: branches/chromium/1180/LayoutTests/ChangeLog (123233 => 123234)

--- branches/chromium/1180/LayoutTests/ChangeLog	2012-07-20 17:56:12 UTC (rev 123233)
+++ branches/chromium/1180/LayoutTests/ChangeLog	2012-07-20 17:56:43 UTC (rev 123234)
@@ -1,3 +1,22 @@
+2012-07-17  Emil A Eklund  e...@chromium.org
+
+Incorrect offset used for scrollWidth/Height calculation
+https://bugs.webkit.org/show_bug.cgi?id=91461
+
+Reviewed by Eric Seidel.
+
+Add new test ensuring that a block that shouldn't have overflow doesn't
+have scrollbars.
+
+* fast/sub-pixel/block-with-margin-overflow-expected.html: Added.
+* fast/sub-pixel/block-with-margin-overflow.html: Added.
+* platform/chromium-win/fast/block/float/026-expected.txt:
+* platform/chromium-win/fast/block/float/028-expected.txt:
+* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
+* platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png:
+* platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
+Update test expectations that incorrectly had overflow.
+
 2012-07-16  Emil A Eklund  e...@chromium.org
 
 Inconsistent rounding in table layout causes background color to bleed through


Copied: branches/chromium/1180/LayoutTests/fast/sub-pixel/block-with-margin-overflow-expected.html (from rev 122861, trunk/LayoutTests/fast/sub-pixel/block-with-margin-overflow-expected.html) (0 => 123234)

--- branches/chromium/1180/LayoutTests/fast/sub-pixel/block-with-margin-overflow-expected.html	(rev 0)
+++ branches/chromium/1180/LayoutTests/fast/sub-pixel/block-with-margin-overflow-expected.html	2012-07-20 17:56:43 UTC (rev 123234)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+head
+style
+.block {
+overflow: auto;
+margin: 0 1px;
+}
+/style
+/head
+body
+div class=block
+Should neither overflow nor display a scrollbar.
+/div
+/body
+/html
+


Copied: branches/chromium/1180/LayoutTests/fast/sub-pixel/block-with-margin-overflow.html (from rev 122861, 

[webkit-changes] [123236] trunk/LayoutTests

[zandobersek]

Title: [123236] trunk/LayoutTests








Revision 123236
Author zandober...@gmail.com
Date 2012-07-20 11:02:17 -0700 (Fri, 20 Jul 2012)


Log Message
Unreviewed GTK gardening.

Generating baselines for two input placeholder tests that fail. The image
baselines used are from Chromium Linux that clearly denote what's missing
in the GTK port's output for these two tests, ignoring other marginal
rendering differences.

* platform/gtk/TestExpectations:
* platform/gtk/fast/forms/input-placeholder-paint-order-expected.png: Added.
* platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt: Added.
* platform/gtk/fast/forms/textarea: Added.
* platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/platform/gtk/fast/forms/input-placeholder-paint-order-expected.png
trunk/LayoutTests/platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/textarea/
trunk/LayoutTests/platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.png
trunk/LayoutTests/platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (123235 => 123236)

--- trunk/LayoutTests/ChangeLog	2012-07-20 18:01:29 UTC (rev 123235)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 18:02:17 UTC (rev 123236)
@@ -1,3 +1,19 @@
+2012-07-20  Zan Dobersek  zandober...@gmail.com
+
+Unreviewed GTK gardening.
+
+Generating baselines for two input placeholder tests that fail. The image
+baselines used are from Chromium Linux that clearly denote what's missing
+in the GTK port's output for these two tests, ignoring other marginal
+rendering differences.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/forms/input-placeholder-paint-order-expected.png: Added.
+* platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt: Added.
+* platform/gtk/fast/forms/textarea: Added.
+* platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
+* platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Added.
+
 2012-07-20  Luciano Wolf  luciano.w...@openbossa.org
 
 Fix missing css1/text_properties/text_transform.html results (txt)


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (123235 => 123236)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-20 18:01:29 UTC (rev 123235)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-20 18:02:17 UTC (rev 123236)
@@ -1076,8 +1076,8 @@
 BUGWK78673 : svg/animations/animate-text-nested-transforms.html = TEXT
 
 BUGWK73409 : fast/forms/textarea-placeholder-set-attribute.html = IMAGE
-BUGWK73409 : fast/forms/textarea/textarea-placeholder-paint-order.html = MISSING
-BUGWK73409 : fast/forms/input-placeholder-paint-order.html = MISSING
+BUGWK73409 : fast/forms/textarea/textarea-placeholder-paint-order.html = IMAGE
+BUGWK73409 : fast/forms/input-placeholder-paint-order.html = IMAGE
 
 BUGWK73653 : fast/forms/range/slider-in-multi-column.html = TEXT
 


Added: trunk/LayoutTests/platform/gtk/fast/forms/input-placeholder-paint-order-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/gtk/fast/forms/input-placeholder-paint-order-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt (0 => 123236)

--- trunk/LayoutTests/platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt	2012-07-20 18:02:17 UTC (rev 123236)
@@ -0,0 +1,5 @@
+This test is meaningfull only if RenderTheme::shouldShowPlaceholderWhenFocused() returns true.
+
+The green caret in the following text box should painted over the red placeholder text.
+
+


Added: trunk/LayoutTests/platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt (0 => 123236)

--- trunk/LayoutTests/platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt	2012-07-20 18:02:17 UTC (rev 123236)
@@ -0,0 +1,5 @@
+This test is meaningfull only if 

[webkit-changes] [123237] trunk/Tools

[caio . oliveira]

Title: [123237] trunk/Tools








Revision 123237
Author caio.olive...@openbossa.org
Date 2012-07-20 11:05:33 -0700 (Fri, 20 Jul 2012)


Log Message
[Qt] Make WTR use the same color palette as DRT
https://bugs.webkit.org/show_bug.cgi?id=91870

Reviewed by Noam Rosenthal.

Make sure that WebKitTestRunner and DumpRenderTree use the same palette: the
standard from QWindowsStyle.

* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts): Moved code to platformInitialize since setting style is not
exactly font related.
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::InjectedBundle::platformInitialize): Force the usage of the style's
palette.  Because at this point QApplication was already instantiated, the
default palette was already initialized to be the system one, so we need to
explicitly set the palette to be the standard from style. This is not needed in
DRT because there we set the style before instantiating QApplication.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp




Diff

Modified: trunk/Tools/ChangeLog (123236 => 123237)

--- trunk/Tools/ChangeLog	2012-07-20 18:02:17 UTC (rev 123236)
+++ trunk/Tools/ChangeLog	2012-07-20 18:05:33 UTC (rev 123237)
@@ -1,3 +1,23 @@
+2012-07-20  Caio Marcelo de Oliveira Filho  caio.olive...@openbossa.org
+
+[Qt] Make WTR use the same color palette as DRT
+https://bugs.webkit.org/show_bug.cgi?id=91870
+
+Reviewed by Noam Rosenthal.
+
+Make sure that WebKitTestRunner and DumpRenderTree use the same palette: the
+standard from QWindowsStyle.
+
+* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
+(WTR::activateFonts): Moved code to platformInitialize since setting style is not
+exactly font related.
+* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
+(WTR::InjectedBundle::platformInitialize): Force the usage of the style's
+palette.  Because at this point QApplication was already instantiated, the
+default palette was already initialized to be the system one, so we need to
+explicitly set the palette to be the standard from style. This is not needed in
+DRT because there we set the style before instantiating QApplication.
+
 2012-07-20  Tony Chang  t...@chromium.org
 
 Baseline align text in the flakiness dashboard toolbar


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp (123236 => 123237)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp	2012-07-20 18:02:17 UTC (rev 123236)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp	2012-07-20 18:05:33 UTC (rev 123237)
@@ -31,16 +31,13 @@
 #include ActivateFonts.h
 #include DumpRenderTreeSupportQt.h
 #include QtInitializeTestFonts.h
+#include QCoreApplication
 
-#include QApplication
-#include QWindowsStyle
-
 namespace WTR {
 
 void activateFonts()
 {
 WebKit::initializeTestFonts();
-QApplication::setStyle(new QWindowsStyle);
 QCoreApplication::setAttribute(Qt::AA_Use96Dpi, true);
 }
 


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp (123236 => 123237)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp	2012-07-20 18:02:17 UTC (rev 123236)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp	2012-07-20 18:05:33 UTC (rev 123237)
@@ -26,8 +26,9 @@
 
 #include config.h
 #include InjectedBundle.h
+#include QApplication
 #include QByteArray
-#include QtGlobal
+#include QWindowsStyle
 #include stdio.h
 #include stdlib.h
 #include wtf/AlwaysInline.h
@@ -69,6 +70,12 @@
 
 void InjectedBundle::platformInitialize(WKTypeRef)
 {
+QWindowsStyle* styleForTests = new QWindowsStyle;
+QApplication::setStyle(styleForTests);
+// Force Qt to use the style's standard palette, instead of platform default palette. This is needed
+// because we are setting the style after QApplication is instantiated.
+QApplication::setPalette(styleForTests-standardPalette());
+
 if (qgetenv(QT_WEBKIT2_DEBUG) == 1)
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123238] trunk/LayoutTests

[jsbell]

Title: [123238] trunk/LayoutTests








Revision 123238
Author jsb...@chromium.org
Date 2012-07-20 11:10:42 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Unreviewed test expectations update.
Un-marking various tests as flaky on WIN following rollback of r121610
in http://trac.webkit.org/changeset/123110. Investigation documented in:
https://bugs.webkit.org/show_bug.cgi?id=90469

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123237 => 123238)

--- trunk/LayoutTests/ChangeLog	2012-07-20 18:05:33 UTC (rev 123237)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 18:10:42 UTC (rev 123238)
@@ -1,3 +1,12 @@
+2012-07-20  Joshua Bell  jsb...@chromium.org
+
+[chromium] Unreviewed test expectations update.
+Un-marking various tests as flaky on WIN following rollback of r121610
+in http://trac.webkit.org/changeset/123110. Investigation documented in:
+https://bugs.webkit.org/show_bug.cgi?id=90469
+
+* platform/chromium/TestExpectations:
+
 2012-07-20  Zan Dobersek  zandober...@gmail.com
 
 Unreviewed GTK gardening.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123237 => 123238)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 18:05:33 UTC (rev 123237)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 18:10:42 UTC (rev 123238)
@@ -3645,30 +3645,6 @@
 // Flaky
 BUGWK90430 : inspector/timeline/timeline-receive-response-event.html = PASS TEXT TIMEOUT
 
-// Flaky crashes on windows circa r121610 - all of these seem to be related
-BUGWK90469 WIN : storage/indexeddb/mozilla/indexes.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/mozilla/key-requirements-inline-and-passed.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/mozilla/key-requirements.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/mozilla/objectstorenames.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/mozilla/autoincrement-indexes.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/mozilla/delete-result.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/mozilla/key-requirements-put-no-key.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/mozilla/create-objectstore-null-name.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/mozilla/index-prev-no-duplicate.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/mozilla/cursors.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/mozilla/create-index-with-integer-keys.html = PASS CRASH
-// Started crashing after 122286
-BUGWK91133 WIN : storage/indexeddb/constants.html = PASS CRASH
-// Started flaky after r121629.
-BUGWK90469 WIN : storage/indexeddb/cursor-delete.html = PASS CRASH
-BUGWK90469 WIN : storage/indexeddb/cursor-added-bug.html = PASS CRASH
-// Recently(?) started crashing on occassion
-BUGWK91275 WIN : storage/indexeddb/cursor-key-order.html = PASS CRASH
-BUGWK91403 WIN : storage/indexeddb/cursor-update-value-argument-required.html = PASS CRASH
-BUGWK90517 WIN : svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg = PASS CRASH
-BUGWK91421 WIN7 : svg/W3C-SVG-1.1/animate-elem-39-t.svg = PASS CRASH
-BUGWK90469 WIN : storage/websql/multiple-databases-garbage-collection.html = PASS CRASH
-
 // Require rebaselines when Bug 85856 is fixed. (The left side of their RTL elements are cropped due to this bug.)
 BUGWK85856 BUGWK91756 : fast/block/float/026.html = TEXT IMAGE+TEXT IMAGE
 BUGWK85856 BUGWK91756 : fast/block/float/028.html = TEXT IMAGE+TEXT IMAGE
@@ -3726,8 +3702,6 @@
 // Needs rebaseline. Behavior should now be the same as Safari.
 BUGWK91472 : compositing/reflections/nested-reflection-anchor-point.html = IMAGE
 
-BUGWK91672 WIN : svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg = PASS CRASH
-
 BUGWK87844 SNOWLEOPARD : fast/forms/datalist/input-appearance-range-with-datalist-rtl.html = IMAGE
 BUGWK87844 SNOWLEOPARD : fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html = IMAGE
 BUGWK87844 SNOWLEOPARD : fast/forms/datalist/input-appearance-range-with-datalist.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123239] trunk/Source/WebCore

[thakis]

Title: [123239] trunk/Source/WebCore








Revision 123239
Author tha...@chromium.org
Date 2012-07-20 11:11:10 -0700 (Fri, 20 Jul 2012)


Log Message
Fix more -Wunused-private-field violations
https://bugs.webkit.org/show_bug.cgi?id=91876

Reviewed by Adam Barth.

As of http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120716/061102.html
the warning finds more bugs. Fix them.

* html/FTPDirectoryDocument.cpp:
(FTPDirectoryDocumentParser):
(WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
* html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
* html/shadow/MediaControlRootElementChromium.h:
(MediaControlRootElementChromium):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
* inspector/InspectorDOMStorageResource.h:
(InspectorDOMStorageResource):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(Settings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
* rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
* rendering/svg/RenderSVGTextPath.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/FTPDirectoryDocument.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h
trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp
trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.h
trunk/Source/WebCore/inspector/InspectorDOMStorageResource.cpp
trunk/Source/WebCore/inspector/InspectorDOMStorageResource.h
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
trunk/Source/WebCore/rendering/svg/RenderSVGTextPath.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGTextPath.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (123238 => 123239)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 18:11:10 UTC (rev 123239)
@@ -1,3 +1,40 @@
+2012-07-20  Nico Weber  tha...@chromium.org
+
+Fix more -Wunused-private-field violations
+https://bugs.webkit.org/show_bug.cgi?id=91876
+
+Reviewed by Adam Barth.
+
+As of http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120716/061102.html
+the warning finds more bugs. Fix them.
+
+* html/FTPDirectoryDocument.cpp:
+(FTPDirectoryDocumentParser):
+(WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
+* html/parser/HTMLTreeBuilder.h:
+(HTMLTreeBuilder):
+* html/shadow/MediaControlRootElementChromium.cpp:
+(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
+* html/shadow/MediaControlRootElementChromium.h:
+(MediaControlRootElementChromium):
+* inspector/InspectorDOMStorageResource.cpp:
+(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
+* inspector/InspectorDOMStorageResource.h:
+(InspectorDOMStorageResource):
+* page/Settings.cpp:
+(WebCore::Settings::Settings):
+* page/Settings.h:
+(Settings):
+* platform/graphics/chromium/cc/CCThreadProxy.cpp:
+(WebCore::CCThreadProxy::CCThreadProxy):
+* platform/graphics/chromium/cc/CCThreadProxy.h:
+(CCThreadProxy):
+* rendering/svg/RenderSVGTextPath.cpp:
+(WebCore::RenderSVGTextPath::RenderSVGTextPath):
+* rendering/svg/RenderSVGTextPath.h:
+
 2012-07-20  Adam Klein  ad...@chromium.org
 
 CodeGeneratorInspector.py is unnecessarily chatty


Modified: trunk/Source/WebCore/html/FTPDirectoryDocument.cpp (123238 => 123239)

--- trunk/Source/WebCore/html/FTPDirectoryDocument.cpp	2012-07-20 18:10:42 UTC (rev 123238)
+++ trunk/Source/WebCore/html/FTPDirectoryDocument.cpp	2012-07-20 18:11:10 UTC (rev 123239)
@@ -88,7 +88,6 @@
 RefPtrHTMLTableElement m_tableElement;
 
 bool m_skipLF;
-bool m_parsedTemplate;
 
 int m_size;
 UChar* m_buffer;
@@ -101,7 +100,6 @@
 FTPDirectoryDocumentParser::FTPDirectoryDocumentParser(HTMLDocument* document)
 : HTMLDocumentParser(document, false)
 , m_skipLF(false)
-, m_parsedTemplate(false)
 , m_size(254)
 , m_buffer(static_castUChar*(fastMalloc(sizeof(UChar) * m_size)))
 , m_dest(m_buffer)


Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (123238 => 123239)

--- 

[webkit-changes] [123240] trunk/Tools

[jochen]

Title: [123240] trunk/Tools








Revision 123240
Author joc...@chromium.org
Date 2012-07-20 11:13:17 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91847

Reviewed by Adam Barth.

This allows for including the TestIntefaces.h from content shell
without introducing a dependency to WebCore/wtf

* DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::Internal):
(TestInterfaces::Internal::Internal):
(TestInterfaces::Internal::~Internal):
(TestInterfaces::Internal::bindTo):
(TestInterfaces::Internal::resetAll):
(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):
* DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(TestInterfaces):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp
trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h




Diff

Modified: trunk/Tools/ChangeLog (123239 => 123240)

--- trunk/Tools/ChangeLog	2012-07-20 18:11:10 UTC (rev 123239)
+++ trunk/Tools/ChangeLog	2012-07-20 18:13:17 UTC (rev 123240)
@@ -1,3 +1,26 @@
+2012-07-20  Jochen Eisinger  joc...@chromium.org
+
+[chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
+https://bugs.webkit.org/show_bug.cgi?id=91847
+
+Reviewed by Adam Barth.
+
+This allows for including the TestIntefaces.h from content shell
+without introducing a dependency to WebCore/wtf
+
+* DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
+(TestInterfaces::Internal):
+(TestInterfaces::Internal::Internal):
+(TestInterfaces::Internal::~Internal):
+(TestInterfaces::Internal::bindTo):
+(TestInterfaces::Internal::resetAll):
+(TestInterfaces::TestInterfaces):
+(TestInterfaces::~TestInterfaces):
+(TestInterfaces::bindTo):
+(TestInterfaces::resetAll):
+* DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
+(TestInterfaces):
+
 2012-07-20  Caio Marcelo de Oliveira Filho  caio.olive...@openbossa.org
 
 [Qt] Make WTR use the same color palette as DRT


Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp (123239 => 123240)

--- trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp	2012-07-20 18:11:10 UTC (rev 123239)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp	2012-07-20 18:13:17 UTC (rev 123240)
@@ -34,24 +34,58 @@
 #include GamepadController.h
 #include platform/WebString.h
 
+#include wtf/OwnPtr.h
+
 using WebKit::WebFrame;
 using WebKit::WebString;
 
-TestInterfaces::TestInterfaces()
+class TestInterfaces::Internal {
+public:
+Internal();
+~Internal();
+
+void bindTo(WebFrame*);
+void resetAll();
+
+private:
+OwnPtrGamepadController m_gamepadController;
+};
+
+TestInterfaces::Internal::Internal()
 {
 m_gamepadController = adoptPtr(new GamepadController());
 }
 
+TestInterfaces::Internal::~Internal()
+{
+}
+
+void TestInterfaces::Internal::bindTo(WebFrame* frame)
+{
+m_gamepadController-bindToJavascript(frame, WebString::fromUTF8(gamepadController));
+}
+
+void TestInterfaces::Internal::resetAll()
+{
+m_gamepadController-reset();
+}
+
+TestInterfaces::TestInterfaces()
+: m_internal(new TestInterfaces::Internal())
+{
+}
+
 TestInterfaces::~TestInterfaces()
 {
+delete m_internal;
 }
 
 void TestInterfaces::bindTo(WebFrame* frame)
 {
-m_gamepadController-bindToJavascript(frame, WebString::fromUTF8(gamepadController));
+m_internal-bindTo(frame);
 }
 
 void TestInterfaces::resetAll()
 {
-m_gamepadController-reset();
+m_internal-resetAll();
 }


Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h (123239 => 123240)

--- trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h	2012-07-20 18:11:10 UTC (rev 123239)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h	2012-07-20 18:13:17 UTC (rev 123240)
@@ -31,14 +31,10 @@
 #ifndef TestInterfaces_h
 #define TestInterfaces_h
 
-#include wtf/OwnPtr.h
-
 namespace WebKit {
 class WebFrame;
 }
 
-class GamepadController;
-
 class TestInterfaces {
 public:
 TestInterfaces();
@@ -48,7 +44,8 @@
 void resetAll();
 
 private:
-OwnPtrGamepadController m_gamepadController;
+class Internal;
+Internal* m_internal;
 };
 
 #endif // TestInterfaces_h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123241] trunk/Source/WebKit/chromium

[abarth]

Title: [123241] trunk/Source/WebKit/chromium








Revision 123241
Author aba...@webkit.org
Date 2012-07-20 11:19:39 -0700 (Fri, 20 Jul 2012)


Log Message
[Chromium] Add WebView::zoomToFindInPageRect for Android
https://bugs.webkit.org/show_bug.cgi?id=91801

Reviewed by Tony Chang.

On Android, when you find in page, we scale the viewport to reveal what
you've found (because the screen is small). This function instructs the
WebView to zoom to display a given rect.

* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animateZoomAroundPoint):
- This function is a bit more general than necessary for this patch
  because it is also used in other cases for animating a zoom
  around a given point (e.g., double-tap to zoom). These uses will
  be upstreamed in later patches.
(WebKit::WebViewImpl::zoomToFindInPageRect):
* src/WebViewImpl.h:
(WebViewImpl):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (123240 => 123241)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 18:13:17 UTC (rev 123240)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 18:19:39 UTC (rev 123241)
@@ -1,3 +1,26 @@
+2012-07-20  Adam Barth  aba...@webkit.org
+
+[Chromium] Add WebView::zoomToFindInPageRect for Android
+https://bugs.webkit.org/show_bug.cgi?id=91801
+
+Reviewed by Tony Chang.
+
+On Android, when you find in page, we scale the viewport to reveal what
+you've found (because the screen is small). This function instructs the
+WebView to zoom to display a given rect.
+
+* public/WebView.h:
+(WebView):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::animateZoomAroundPoint):
+- This function is a bit more general than necessary for this patch
+  because it is also used in other cases for animating a zoom
+  around a given point (e.g., double-tap to zoom). These uses will
+  be upstreamed in later patches.
+(WebKit::WebViewImpl::zoomToFindInPageRect):
+* src/WebViewImpl.h:
+(WebViewImpl):
+
 2012-07-19  Luke Macpherson   macpher...@chromium.org
 
 Enable CSS variables compile time flag in Chrome.


Modified: trunk/Source/WebKit/chromium/public/WebView.h (123240 => 123241)

--- trunk/Source/WebKit/chromium/public/WebView.h	2012-07-20 18:13:17 UTC (rev 123240)
+++ trunk/Source/WebKit/chromium/public/WebView.h	2012-07-20 18:19:39 UTC (rev 123241)
@@ -196,7 +196,10 @@
 // previous element in the tab sequence (if reverse is true).
 virtual void advanceFocus(bool reverse) { }
 
+// Animate a scale into the specified find-in-page rect.
+virtual void zoomToFindInPageRect(const WebRect) = 0;
 
+
 // Zoom 
 
 // Returns the current zoom level.  0 is original size, and each increment


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (123240 => 123241)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-07-20 18:13:17 UTC (rev 123240)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-07-20 18:19:39 UTC (rev 123241)
@@ -195,7 +195,9 @@
 static const float minScaleDifference = 0.01f;
 static const float doubleTapZoomContentDefaultMargin = 5;
 static const float doubleTapZoomContentMinimumMargin = 2;
+static const double doubleTabZoomAnimationDurationInSeconds = 0.25;
 
+
 namespace WebKit {
 
 // Change the text zoom level by kTextSizeMultiplierRatio each time the user
@@ -745,10 +747,10 @@
 m_layerTreeView.renderingStats(stats);
 }
 
-void WebViewImpl::startPageScaleAnimation(const IntPoint scroll, bool useAnchor, float newScale, double durationSec)
+void WebViewImpl::startPageScaleAnimation(const IntPoint scroll, bool useAnchor, float newScale, double durationInSeconds)
 {
 if (!m_layerTreeView.isNull())
-m_layerTreeView.startPageScaleAnimation(scroll, useAnchor, newScale, durationSec);
+m_layerTreeView.startPageScaleAnimation(scroll, useAnchor, newScale, durationInSeconds);
 }
 #endif
 
@@ -1073,6 +1075,27 @@
 }
 #endif
 
+void WebViewImpl::animateZoomAroundPoint(const IntPoint point, AutoZoomType zoomType)
+{
+#if ENABLE(GESTURE_EVENTS)
+if (!mainFrameImpl())
+return;
+
+float scale;
+WebPoint scroll;
+computeScaleAndScrollForHitRect(WebRect(point.x(), point.y(), 0, 0), zoomType, scale, scroll);
+
+bool isDoubleTap = (zoomType == DoubleTap);
+double durationInSeconds = isDoubleTap ? doubleTabZoomAnimationDurationInSeconds : 0;
+startPageScaleAnimation(scroll, isDoubleTap, scale, durationInSeconds);
+#endif
+}
+
+void WebViewImpl::zoomToFindInPageRect(const WebRect rect)
+{
+animateZoomAroundPoint(IntRect(rect).center(), FindInPage);
+}
+
 void 

[webkit-changes] [123243] trunk/Source/WebCore

[rniwa]

Title: [123243] trunk/Source/WebCore








Revision 123243
Author rn...@webkit.org
Date 2012-07-20 11:28:24 -0700 (Fri, 20 Jul 2012)


Log Message
REGRESSION(r122873): 15% regression on Dromaeo/dom-attr
https://bugs.webkit.org/show_bug.cgi?id=91827

Reviewed by Anders Carlsson.

Move shouldInvalidateNodeListCaches from Document.cpp to Node.cpp since it's only called
in Node::invalidateNodeListCachesInAncestors.

Test: PerformanceTests/Dromaeo/dom-attr.html.

* dom/Document.cpp:
(WebCore):
* dom/Node.cpp:
(WebCore::shouldInvalidateNodeListCachesForAttr): Extracted from shouldInvalidateNodeListCaches
to unroll the loop in shouldInvalidateNodeListCaches. Apparently gcc wasn't doing the right thing.
(WebCore::Document::shouldInvalidateNodeListCaches):
(WebCore::Document::invalidateNodeListCaches):
(WebCore::Node::invalidateNodeListCachesInAncestors):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Node.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123242 => 123243)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 18:27:06 UTC (rev 123242)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 18:28:24 UTC (rev 123243)
@@ -1,3 +1,24 @@
+2012-07-20  Ryosuke Niwa  rn...@webkit.org
+
+REGRESSION(r122873): 15% regression on Dromaeo/dom-attr
+https://bugs.webkit.org/show_bug.cgi?id=91827
+
+Reviewed by Anders Carlsson.
+
+Move shouldInvalidateNodeListCaches from Document.cpp to Node.cpp since it's only called
+in Node::invalidateNodeListCachesInAncestors.
+
+Test: PerformanceTests/Dromaeo/dom-attr.html.
+
+* dom/Document.cpp:
+(WebCore):
+* dom/Node.cpp:
+(WebCore::shouldInvalidateNodeListCachesForAttr): Extracted from shouldInvalidateNodeListCaches
+to unroll the loop in shouldInvalidateNodeListCaches. Apparently gcc wasn't doing the right thing.
+(WebCore::Document::shouldInvalidateNodeListCaches):
+(WebCore::Document::invalidateNodeListCaches):
+(WebCore::Node::invalidateNodeListCachesInAncestors):
+
 2012-07-20  Nico Weber  tha...@chromium.org
 
 Fix more -Wunused-private-field violations


Modified: trunk/Source/WebCore/dom/Document.cpp (123242 => 123243)

--- trunk/Source/WebCore/dom/Document.cpp	2012-07-20 18:27:06 UTC (rev 123242)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-07-20 18:28:24 UTC (rev 123243)
@@ -3900,31 +3900,6 @@
 }
 }
 
-bool Document::shouldInvalidateNodeListCaches(const QualifiedName* attrName) const
-{
-if (attrName) {
-for (int type = DoNotInvalidateOnAttributeChanges + 1; type  numNodeListInvalidationTypes; type++) {
-if (m_nodeListCounts[type]  DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange(static_castNodeListInvalidationType(type), *attrName))
-return true;
-}
-return false;
-}
-
-for (int type = 0; type  numNodeListInvalidationTypes; type++) {
-if (m_nodeListCounts[type])
-return true;
-}
-
-return false;
-}
-
-void Document::invalidateNodeListCaches(const QualifiedName* attrName)
-{
-HashSetDynamicNodeListCacheBase*::iterator end = m_listsInvalidatedAtDocument.end();
-for (HashSetDynamicNodeListCacheBase*::iterator it = m_listsInvalidatedAtDocument.begin(); it != end; ++it)
-(*it)-invalidateCache(attrName);
-}
-
 void Document::attachNodeIterator(NodeIterator* ni)
 {
 m_nodeIterators.add(ni);


Modified: trunk/Source/WebCore/dom/Node.cpp (123242 => 123243)

--- trunk/Source/WebCore/dom/Node.cpp	2012-07-20 18:27:06 UTC (rev 123242)
+++ trunk/Source/WebCore/dom/Node.cpp	2012-07-20 18:28:24 UTC (rev 123243)
@@ -927,6 +927,40 @@
 return count;
 }
 
+templateunsigned type
+bool shouldInvalidateNodeListCachesForAttr(const unsigned nodeListCounts[], const QualifiedName attrName)
+{
+if (nodeListCounts[type]  DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange(static_castNodeListInvalidationType(type), attrName))
+return true;
+return shouldInvalidateNodeListCachesForAttrtype + 1(nodeListCounts, attrName);
+}
+
+template
+bool shouldInvalidateNodeListCachesForAttrnumNodeListInvalidationTypes(const unsigned[], const QualifiedName)
+{
+return false;
+}
+
+bool Document::shouldInvalidateNodeListCaches(const QualifiedName* attrName) const
+{
+if (attrName)
+return shouldInvalidateNodeListCachesForAttrDoNotInvalidateOnAttributeChanges + 1(m_nodeListCounts, *attrName);
+
+for (int type = 0; type  numNodeListInvalidationTypes; type++) {
+if (m_nodeListCounts[type])
+return true;
+}
+
+return false;
+}
+
+void Document::invalidateNodeListCaches(const QualifiedName* attrName)
+{
+HashSetDynamicNodeListCacheBase*::iterator end = m_listsInvalidatedAtDocument.end();
+for (HashSetDynamicNodeListCacheBase*::iterator it = m_listsInvalidatedAtDocument.begin(); it != end; ++it)
+

[webkit-changes] [123244] trunk/LayoutTests

[zandobersek]

Title: [123244] trunk/LayoutTests








Revision 123244
Author zandober...@gmail.com
Date 2012-07-20 11:40:29 -0700 (Fri, 20 Jul 2012)


Log Message
Unreviewed GTK gardening, adding image baseline for
fast/images/paletted-png-with-color-profile.html.

* platform/gtk/TestExpectations:
* platform/gtk/fast/images/paletted-png-with-color-profile-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/platform/gtk/fast/images/paletted-png-with-color-profile-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (123243 => 123244)

--- trunk/LayoutTests/ChangeLog	2012-07-20 18:28:24 UTC (rev 123243)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 18:40:29 UTC (rev 123244)
@@ -1,3 +1,11 @@
+2012-07-20  Zan Dobersek  zandober...@gmail.com
+
+Unreviewed GTK gardening, adding image baseline for
+fast/images/paletted-png-with-color-profile.html.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/images/paletted-png-with-color-profile-expected.png: Added.
+
 2012-07-20  Stephen Chenney  schen...@chromium.org
 
 SVG Filter Effect sub-region not applied for some filters


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (123243 => 123244)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-20 18:28:24 UTC (rev 123243)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-20 18:40:29 UTC (rev 123244)
@@ -1182,9 +1182,6 @@
 
 BUGWK86445 : fast/multicol/split-in-top-margin.html = IMAGE
 
-// Paletted PNG with ICC color profiles not working.
-BUGWK86722 SKIP : fast/images/paletted-png-with-color-profile.html = TEXT MISSING
-
 // This test is affecting other tests and seems to be behaving incorrectly itself
 BUGWK86771 SKIP : fast/dom/gc-10.html = TEXT
 


Added: trunk/LayoutTests/platform/gtk/fast/images/paletted-png-with-color-profile-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/gtk/fast/images/paletted-png-with-color-profile-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123245] trunk/Websites/bugs.webkit.org/attachment.cgi

[wsiegrist]

Title: [123245] trunk/Websites/bugs.webkit.org/attachment.cgi








Revision 123245
Author wsiegr...@apple.com
Date 2012-07-20 11:43:10 -0700 (Fri, 20 Jul 2012)


Log Message
Add /usr/bin to PATH so PrettyPatch can find git.

Modified Paths

trunk/Websites/bugs.webkit.org/attachment.cgi




Diff

Modified: trunk/Websites/bugs.webkit.org/attachment.cgi (123244 => 123245)

--- trunk/Websites/bugs.webkit.org/attachment.cgi	2012-07-20 18:40:29 UTC (rev 123244)
+++ trunk/Websites/bugs.webkit.org/attachment.cgi	2012-07-20 18:43:10 UTC (rev 123245)
@@ -393,9 +393,12 @@
 print $cgi-header(-type = 'text/html',
-expires = '+3M');
 
+my $orig_path = $ENV{'PATH'};
+$ENV{'PATH'} = /usr/bin: . $ENV{'PATH'};
 my @prettyargs = (-I, /var/www/html/PrettyPatch, /var/www/html/PrettyPatch/prettify.rb, --html-exceptions);
 my $r = Apache2::RequestUtil-request;
 my ($in, $out, $err) = $r-spawn_proc_prog(/usr/bin/ruby, \@prettyargs);
+$ENV{'PATH'} = $orig_path;
 print $in $attachment-data;
 close($in);
 while ($out) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123246] trunk/LayoutTests

[zandobersek]

Title: [123246] trunk/LayoutTests








Revision 123246
Author zandober...@gmail.com
Date 2012-07-20 11:58:00 -0700 (Fri, 20 Jul 2012)


Log Message
Unreviewed GTK gardening, adding platform-specific baseline for
fast/dom/Window/window-properties-performance.html that assumes jsHeapSizeLimit
attribute to be undefined, as expected for ports using _javascript_Core.

* platform/gtk/TestExpectations:
* platform/gtk/fast/dom/Window/window-properties-performance-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-performance-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (123245 => 123246)

--- trunk/LayoutTests/ChangeLog	2012-07-20 18:43:10 UTC (rev 123245)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 18:58:00 UTC (rev 123246)
@@ -1,5 +1,14 @@
 2012-07-20  Zan Dobersek  zandober...@gmail.com
 
+Unreviewed GTK gardening, adding platform-specific baseline for
+fast/dom/Window/window-properties-performance.html that assumes jsHeapSizeLimit
+attribute to be undefined, as expected for ports using _javascript_Core.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/fast/dom/Window/window-properties-performance-expected.txt: Added.
+
+2012-07-20  Zan Dobersek  zandober...@gmail.com
+
 Unreviewed GTK gardening, adding image baseline for
 fast/images/paletted-png-with-color-profile.html.
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (123245 => 123246)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-20 18:43:10 UTC (rev 123245)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-20 18:58:00 UTC (rev 123246)
@@ -175,9 +175,6 @@
 // Speech _javascript_ API is not yet enabled.
 BUGWKGTK SKIP : fast/events/constructors/speech-recognition-event-constructor.html = TEXT
 
-// Web Timing issues.
-BUGWKGTK : fast/dom/Window/window-properties-performance.html = TEXT
-
 // FileSystem API is not supported.
 BUGWKGTK SKIP : fast/filesystem = TEXT
 BUGWKGTK SKIP : http/tests/filesystem = TEXT


Added: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-performance-expected.txt (0 => 123246)

--- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-performance-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-performance-expected.txt	2012-07-20 18:58:00 UTC (rev 123246)
@@ -0,0 +1,41 @@
+This test dumps all of the properties that are reachable from the window.performance object, along with their types.
+
+window.performance [object Performance]
+window.performance.memory [object MemoryInfo]
+window.performance.memory.jsHeapSizeLimit [undefined]
+window.performance.memory.totalJSHeapSize [number]
+window.performance.memory.usedJSHeapSize [number]
+window.performance.navigation [object PerformanceNavigation]
+window.performance.navigation.TYPE_BACK_FORWARD [number]
+window.performance.navigation.TYPE_NAVIGATE [number]
+window.performance.navigation.TYPE_RELOAD [number]
+window.performance.navigation.TYPE_RESERVED [number]
+window.performance.navigation.redirectCount [number]
+window.performance.navigation.type [number]
+window.performance.timing [object PerformanceTiming]
+window.performance.timing.connectEnd [number]
+window.performance.timing.connectStart [number]
+window.performance.timing.domComplete [number]
+window.performance.timing.domContentLoadedEventEnd [number]
+window.performance.timing.domContentLoadedEventStart [number]
+window.performance.timing.domInteractive [number]
+window.performance.timing.domLoading [number]
+window.performance.timing.domainLookupEnd [number]
+window.performance.timing.domainLookupStart [number]
+window.performance.timing.fetchStart [number]
+window.performance.timing.loadEventEnd [number]
+window.performance.timing.loadEventStart [number]
+window.performance.timing.navigationStart [number]
+window.performance.timing.redirectEnd [number]
+window.performance.timing.redirectStart [number]
+window.performance.timing.requestStart [number]
+window.performance.timing.responseEnd [number]
+window.performance.timing.responseStart [number]
+window.performance.timing.secureConnectionStart [number]
+window.performance.timing.unloadEventEnd [number]
+window.performance.timing.unloadEventStart [number]
+window.performance.webkitNow [function]
+window.performance.timing [printed above as window.performance.timing]
+window.performance.navigation [printed above as window.performance.navigation]
+window.performance [string]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123247] trunk

[scheib]

Title: [123247] trunk








Revision 123247
Author sch...@chromium.org
Date 2012-07-20 12:17:58 -0700 (Fri, 20 Jul 2012)


Log Message
Move pointer lock test resources to http/tests/resources in preparation for adding new tests to http.
https://bugs.webkit.org/show_bug.cgi?id=91882

Reviewed by Adrienne Walker.

* http/tests/resources/pointer-lock/pointer-lock-test-harness.js: Renamed from LayoutTests/pointer-lock/resources/pointer-lock-test-harness.js.
* pointer-lock/bug90391-move-then-window-open-crash.html:
* pointer-lock/lock-already-locked.html:
* pointer-lock/lock-element-not-in-dom.html:
* pointer-lock/lock-fail-responses.html:
* pointer-lock/locked-element-iframe-removed-from-dom.html:
* pointer-lock/locked-element-removed-from-dom.html:
* pointer-lock/mouse-event-api.html:
* pointer-lock/mouse-event-delivery.html:
* pointer-lock/pointer-lock-api.html:
* pointer-lock/pointerlockchange-pointerlockerror-events.html:
* pointer-lock/pointerlocklost-event.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/pointer-lock/bug90391-move-then-window-open-crash.html
trunk/LayoutTests/pointer-lock/lock-already-locked.html
trunk/LayoutTests/pointer-lock/lock-element-not-in-dom.html
trunk/LayoutTests/pointer-lock/lock-fail-responses.html
trunk/LayoutTests/pointer-lock/locked-element-iframe-removed-from-dom.html
trunk/LayoutTests/pointer-lock/locked-element-removed-from-dom.html
trunk/LayoutTests/pointer-lock/mouse-event-api.html
trunk/LayoutTests/pointer-lock/mouse-event-delivery.html
trunk/LayoutTests/pointer-lock/pointer-lock-api.html
trunk/LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events.html
trunk/LayoutTests/pointer-lock/pointerlocklost-event.html
trunk/Source/WebCore/dom/Document.cpp


Added Paths

trunk/LayoutTests/http/tests/resources/pointer-lock/
trunk/LayoutTests/http/tests/resources/pointer-lock/pointer-lock-test-harness.js


Removed Paths

trunk/LayoutTests/pointer-lock/resources/pointer-lock-test-harness.js




Diff

Modified: trunk/LayoutTests/ChangeLog (123246 => 123247)

--- trunk/LayoutTests/ChangeLog	2012-07-20 18:58:00 UTC (rev 123246)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 19:17:58 UTC (rev 123247)
@@ -1,3 +1,23 @@
+2012-07-20  Vincent Scheib  sch...@chromium.org
+
+Move pointer lock test resources to http/tests/resources in preparation for adding new tests to http.
+https://bugs.webkit.org/show_bug.cgi?id=91882
+
+Reviewed by Adrienne Walker.
+
+* http/tests/resources/pointer-lock/pointer-lock-test-harness.js: Renamed from LayoutTests/pointer-lock/resources/pointer-lock-test-harness.js.
+* pointer-lock/bug90391-move-then-window-open-crash.html:
+* pointer-lock/lock-already-locked.html:
+* pointer-lock/lock-element-not-in-dom.html:
+* pointer-lock/lock-fail-responses.html:
+* pointer-lock/locked-element-iframe-removed-from-dom.html:
+* pointer-lock/locked-element-removed-from-dom.html:
+* pointer-lock/mouse-event-api.html:
+* pointer-lock/mouse-event-delivery.html:
+* pointer-lock/pointer-lock-api.html:
+* pointer-lock/pointerlockchange-pointerlockerror-events.html:
+* pointer-lock/pointerlocklost-event.html:
+
 2012-07-20  Zan Dobersek  zandober...@gmail.com
 
 Unreviewed GTK gardening, adding platform-specific baseline for


Copied: trunk/LayoutTests/http/tests/resources/pointer-lock/pointer-lock-test-harness.js (from rev 123246, trunk/LayoutTests/pointer-lock/resources/pointer-lock-test-harness.js) (0 => 123247)

--- trunk/LayoutTests/http/tests/resources/pointer-lock/pointer-lock-test-harness.js	(rev 0)
+++ trunk/LayoutTests/http/tests/resources/pointer-lock/pointer-lock-test-harness.js	2012-07-20 19:17:58 UTC (rev 123247)
@@ -0,0 +1,69 @@
+// Automatically add doNextStepButton to document for manual tests.
+if (!window.testRunner) {
+setTimeout(function () {
+doNextStepButton = document.body.insertBefore(document.createElement(button), document.body.firstChild);
+doNextStepButton._onclick_ = doNextStep;
+doNextStepButton.innerText = doNextStep button for manual testing. Use keyboard to select button and press (TAB, then SPACE).;
+}, 0);
+}
+
+function doNextStep()
+{
+if (typeof(currentStep) == undefined)
+currentStep = 0;
+
+setTimeout(function () {
+var thisStep = currentStep++;
+if (thisStep  todo.length)
+todo[thisStep]();
+else if (thisStep == todo.length)
+setTimeout(function () { finishJSTest(); }, 0); // Deferred so that excessive doNextStep calls will be observed.
+else
+testFailed(doNextStep called too many times.);
+}, 0);
+}
+
+function doNextStepWithUserGesture()
+{
+if (!window.testRunner)
+return; // Wait for human to press doNextStep button.
+doNextStep();
+}
+
+function eventExpected(eventHandlerName, message, expectedCalls, targetHanderNode)
+{

[webkit-changes] [123248] trunk/Source/WebCore

[scheib]

Title: [123248] trunk/Source/WebCore








Revision 123248
Author sch...@chromium.org
Date 2012-07-20 12:43:20 -0700 (Fri, 20 Jul 2012)


Log Message
Unreviewed compile fix, r123247 included unintended changes to Document.cpp.

See http://trac.webkit.org/changeset/123247.

* dom/Document.cpp:
(WebCore::Document::webkitExitPointerLock):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123247 => 123248)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 19:17:58 UTC (rev 123247)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 19:43:20 UTC (rev 123248)
@@ -1,3 +1,12 @@
+2012-07-20  Vincent Scheib  sch...@chromium.org
+
+Unreviewed compile fix, r123247 included unintended changes to Document.cpp.
+
+See http://trac.webkit.org/changeset/123247.
+
+* dom/Document.cpp:
+(WebCore::Document::webkitExitPointerLock):
+
 2012-07-20  Ryosuke Niwa  rn...@webkit.org
 
 REGRESSION(r122873): 15% regression on Dromaeo/dom-attr


Modified: trunk/Source/WebCore/dom/Document.cpp (123247 => 123248)

--- trunk/Source/WebCore/dom/Document.cpp	2012-07-20 19:17:58 UTC (rev 123247)
+++ trunk/Source/WebCore/dom/Document.cpp	2012-07-20 19:43:20 UTC (rev 123248)
@@ -5816,23 +5816,6 @@
 void Document::webkitExitPointerLock()
 {
 if (page())
-page()-pointerLockController()-requestPointerLock(element, 0, 0);
-else
-element-document()-enqueueDocumentEvent(Event::create(eventNames().webkitpointerlockerrorEvent, true, false));
-}
-
-bool Document::webkitPointerLockEnabled() const
-{
-return isAttributeOnAllOwners(webkitallowpointerlockAttr, ownerElement());
-}
-
-void Document::webkitExitPointerLock()
-{
-Element* element;
-if (!page() || !(element = page()-pointerLockController()-element()))
-return;
-
-if (securityOrigin()-canAccess(element-document()-securityOrigin()))
 page()-pointerLockController()-requestPointerUnlock();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123250] trunk/Tools

[dpranke]

Title: [123250] trunk/Tools








Revision 123250
Author dpra...@chromium.org
Date 2012-07-20 12:59:08 -0700 (Fri, 20 Jul 2012)


Log Message
REGRESSION: run-perf-tests --pause-before-testing is broken
https://bugs.webkit.org/show_bug.cgi?id=91789

Reviewed by Ryosuke Niwa.

Turns out start() wasn't actually starting things :(. Fixed, and
added tests.

* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidDriverTest.test_read_prompt):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.__init__):
(Driver._start):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_read_block):
(DriverTest.test_read_binary_block):
(DriverTest.test_read_base64_block):
(DriverTest.test_stop_cleans_up_properly):
(DriverTest.test_two_starts_cleans_up_properly):
(DriverTest.test_start_actually_starts):
(MockServerProcess.__init__):
(MockServerProcess.start):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (123249 => 123250)

--- trunk/Tools/ChangeLog	2012-07-20 19:43:34 UTC (rev 123249)
+++ trunk/Tools/ChangeLog	2012-07-20 19:59:08 UTC (rev 123250)
@@ -1,3 +1,28 @@
+2012-07-20  Dirk Pranke  dpra...@chromium.org
+
+REGRESSION: run-perf-tests --pause-before-testing is broken
+https://bugs.webkit.org/show_bug.cgi?id=91789
+
+Reviewed by Ryosuke Niwa.
+
+Turns out start() wasn't actually starting things :(. Fixed, and
+added tests.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
+(ChromiumAndroidDriverTest.test_read_prompt):
+* Scripts/webkitpy/layout_tests/port/driver.py:
+(Driver.__init__):
+(Driver._start):
+* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
+(DriverTest.test_read_block):
+(DriverTest.test_read_binary_block):
+(DriverTest.test_read_base64_block):
+(DriverTest.test_stop_cleans_up_properly):
+(DriverTest.test_two_starts_cleans_up_properly):
+(DriverTest.test_start_actually_starts):
+(MockServerProcess.__init__):
+(MockServerProcess.start):
+
 2012-07-20  Jochen Eisinger  joc...@chromium.org
 
 [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py (123249 => 123250)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py	2012-07-20 19:43:34 UTC (rev 123249)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py	2012-07-20 19:59:08 UTC (rev 123250)
@@ -147,9 +147,9 @@
 self.assertTrue('--err-fifo=' + chromium_android.DRT_APP_FILES_DIR + 'DumpRenderTree.err' in cmd_line)
 
 def test_read_prompt(self):
-self.driver._server_process = driver_unittest.MockServerProcess(['root@android:/ # '])
+self.driver._server_process = driver_unittest.MockServerProcess(lines=['root@android:/ # '])
 self.assertEquals(self.driver._read_prompt(time.time() + 1), None)
-self.driver._server_process = driver_unittest.MockServerProcess(['$ '])
+self.driver._server_process = driver_unittest.MockServerProcess(lines=['$ '])
 self.assertRaises(AssertionError, self.driver._read_prompt, time.time() + 1)
 
 def test_command_from_driver_input(self):


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py (123249 => 123250)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py	2012-07-20 19:43:34 UTC (rev 123249)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/driver.py	2012-07-20 19:59:08 UTC (rev 123250)
@@ -115,6 +115,9 @@
 self._worker_number = worker_number
 self._no_timeout = no_timeout
 
+# overridable for testing.
+self._server_process_constructor = server_process.ServerProcess
+
 self._driver_tempdir = None
 # WebKitTestRunner can report back subprocess crashes by printing
 # #CRASHED - PROCESSNAME.  Since those can happen at any time
@@ -268,9 +271,9 @@
 environment['LOCAL_RESOURCE_ROOT'] = self._port.layout_tests_dir()
 self._crashed_process_name = None
 self._crashed_pid = None
-self._server_process = server_process.ServerProcess(self._port, server_name, self.cmd_line(pixel_tests, per_test_args), environment)
+self._server_process = self._server_process_constructor(self._port, server_name, self.cmd_line(pixel_tests, per_test_args), environment)
+self._server_process.start()
 
-
 def stop(self):
 if self._server_process:
 self._server_process.stop()


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py (123249 => 123250)

--- 

[webkit-changes] [123253] trunk

[commit-queue]

Title: [123253] trunk








Revision 123253
Author commit-qu...@webkit.org
Date 2012-07-20 13:09:02 -0700 (Fri, 20 Jul 2012)


Log Message
[Chromium] Compilation fails under gcc 4.7
https://bugs.webkit.org/show_bug.cgi?id=90227

Patch by Han Shen shen...@google.com on 2012-07-20
Reviewed by Tony Chang.

Disable warnings about c++0x compatibility in gcc newer than 4.6.

Source/_javascript_Core:

* _javascript_Core.gyp/_javascript_Core.gyp:

Source/WebCore:

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* WebKit.gyp:
* WebKitUnitTests.gyp:

Source/WTF:

* WTF.gyp/WTF.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.gyp/WTF.gyp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/WebKitUnitTests.gyp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (123252 => 123253)

--- trunk/Source/_javascript_Core/ChangeLog	2012-07-20 20:07:18 UTC (rev 123252)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-07-20 20:09:02 UTC (rev 123253)
@@ -1,3 +1,14 @@
+2012-07-20  Han Shen  shen...@google.com
+
+[Chromium] Compilation fails under gcc 4.7
+https://bugs.webkit.org/show_bug.cgi?id=90227
+
+Reviewed by Tony Chang.
+
+Disable warnings about c++0x compatibility in gcc newer than 4.6.
+
+* _javascript_Core.gyp/_javascript_Core.gyp:
+
 2012-07-18  Filip Pizlo  fpi...@apple.com
 
 DFG cell checks should be hoisted


Modified: trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp (123252 => 123253)

--- trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp	2012-07-20 20:07:18 UTC (rev 123252)
+++ trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp	2012-07-20 20:09:02 UTC (rev 123253)
@@ -47,7 +47,7 @@
 ],
   },
   'conditions': [
-['os_posix == 1 and OS != mac and gcc_version==46', {
+['os_posix == 1 and OS != mac and gcc_version=46', {
   'target_defaults': {
 # Disable warnings about c++0x compatibility, as some names (such as nullptr) conflict
 # with upcoming c++0x types.


Modified: trunk/Source/WTF/ChangeLog (123252 => 123253)

--- trunk/Source/WTF/ChangeLog	2012-07-20 20:07:18 UTC (rev 123252)
+++ trunk/Source/WTF/ChangeLog	2012-07-20 20:09:02 UTC (rev 123253)
@@ -1,3 +1,14 @@
+2012-07-20  Han Shen  shen...@google.com
+
+[Chromium] Compilation fails under gcc 4.7
+https://bugs.webkit.org/show_bug.cgi?id=90227
+
+Reviewed by Tony Chang.
+
+Disable warnings about c++0x compatibility in gcc newer than 4.6.
+
+* WTF.gyp/WTF.gyp:
+
 2012-07-19  Dan Bernstein  m...@apple.com
 
 The ATSUI-based complex text code is unused


Modified: trunk/Source/WTF/WTF.gyp/WTF.gyp (123252 => 123253)

--- trunk/Source/WTF/WTF.gyp/WTF.gyp	2012-07-20 20:07:18 UTC (rev 123252)
+++ trunk/Source/WTF/WTF.gyp/WTF.gyp	2012-07-20 20:09:02 UTC (rev 123253)
@@ -44,7 +44,7 @@
 ],
   },
   'conditions': [
-['os_posix == 1 and OS != mac and gcc_version==46', {
+['os_posix == 1 and OS != mac and gcc_version=46', {
   'target_defaults': {
 # Disable warnings about c++0x compatibility, as some names (such as nullptr) conflict
 # with upcoming c++0x types.


Modified: trunk/Source/WebCore/ChangeLog (123252 => 123253)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 20:07:18 UTC (rev 123252)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 20:09:02 UTC (rev 123253)
@@ -1,3 +1,14 @@
+2012-07-20  Han Shen  shen...@google.com
+
+[Chromium] Compilation fails under gcc 4.7
+https://bugs.webkit.org/show_bug.cgi?id=90227
+
+Reviewed by Tony Chang.
+
+Disable warnings about c++0x compatibility in gcc newer than 4.6.
+
+* WebCore.gyp/WebCore.gyp:
+
 2012-07-20  Vincent Scheib  sch...@chromium.org
 
 Unreviewed compile fix, r123247 included unintended changes to Document.cpp.


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (123252 => 123253)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-07-20 20:07:18 UTC (rev 123252)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-07-20 20:09:02 UTC (rev 123253)
@@ -283,7 +283,7 @@
 'cflags!': ['-g'],
   },
 }],
-['os_posix==1 and OS!=mac and gcc_version==46', {
+['os_posix==1 and OS!=mac and gcc_version=46', {
   'target_defaults': {
 # Disable warnings about c++0x compatibility, as some names (such as nullptr) conflict
 # with upcoming c++0x types.


Modified: trunk/Source/WebKit/chromium/ChangeLog (123252 => 123253)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 20:07:18 UTC 

[webkit-changes] [123254] trunk/Source/WebKit/chromium

[commit-queue]

Title: [123254] trunk/Source/WebKit/chromium








Revision 123254
Author commit-qu...@webkit.org
Date 2012-07-20 13:24:29 -0700 (Fri, 20 Jul 2012)


Log Message
Introduce WebViewBenchmarkSupport for performance experiments on a real WebView
https://bugs.webkit.org/show_bug.cgi?id=88271

Patch by Daniel Murphy dmu...@chromium.org on 2012-07-20
Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebView.h:
(WebKit):
(WebView):
(WebKit::WebView::benchmarkSupport):
* public/WebViewBenchmarkSupport.h: Added.
(WebKit):
(WebViewBenchmarkSupport):
(PaintClient):
(WebKit::WebViewBenchmarkSupport::PaintClient::willPaint):
(WebKit::WebViewBenchmarkSupport::PaintClient::didPaint):
(WebKit::WebViewBenchmarkSupport::PaintClient::~PaintClient):
(WebKit::WebViewBenchmarkSupport::~WebViewBenchmarkSupport):
* src/WebViewBenchmarkSupportImpl.cpp: Added.
(WebKit):
(WebKit::WebViewBenchmarkSupportImpl::paintLayer):
(WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped):
(WebKit::WebViewBenchmarkSupportImpl::softwarePaint):
(WebKit::WebViewBenchmarkSupportImpl::paint):
* src/WebViewBenchmarkSupportImpl.h: Added.
(WebCore):
(WebKit):
(WebViewBenchmarkSupportImpl):
(WebKit::WebViewBenchmarkSupportImpl::WebViewBenchmarkSupportImpl):
(WebKit::WebViewBenchmarkSupportImpl::~WebViewBenchmarkSupportImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::benchmarkSupport):
(WebKit):
(WebKit::WebViewImpl::rootGraphicsLayer):
* src/WebViewImpl.h:
(WebKit):
(WebViewImpl):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h


Added Paths

trunk/Source/WebKit/chromium/public/WebViewBenchmarkSupport.h
trunk/Source/WebKit/chromium/src/WebViewBenchmarkSupportImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewBenchmarkSupportImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (123253 => 123254)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 20:09:02 UTC (rev 123253)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 20:24:29 UTC (rev 123254)
@@ -1,3 +1,44 @@
+2012-07-20  Daniel Murphy  dmu...@chromium.org
+
+Introduce WebViewBenchmarkSupport for performance experiments on a real WebView
+https://bugs.webkit.org/show_bug.cgi?id=88271
+
+Reviewed by Darin Fisher.
+
+* WebKit.gyp:
+* public/WebView.h:
+(WebKit):
+(WebView):
+(WebKit::WebView::benchmarkSupport):
+* public/WebViewBenchmarkSupport.h: Added.
+(WebKit):
+(WebViewBenchmarkSupport):
+(PaintClient):
+(WebKit::WebViewBenchmarkSupport::PaintClient::willPaint):
+(WebKit::WebViewBenchmarkSupport::PaintClient::didPaint):
+(WebKit::WebViewBenchmarkSupport::PaintClient::~PaintClient):
+(WebKit::WebViewBenchmarkSupport::~WebViewBenchmarkSupport):
+* src/WebViewBenchmarkSupportImpl.cpp: Added.
+(WebKit):
+(WebKit::WebViewBenchmarkSupportImpl::paintLayer):
+(WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped):
+(WebKit::WebViewBenchmarkSupportImpl::softwarePaint):
+(WebKit::WebViewBenchmarkSupportImpl::paint):
+* src/WebViewBenchmarkSupportImpl.h: Added.
+(WebCore):
+(WebKit):
+(WebViewBenchmarkSupportImpl):
+(WebKit::WebViewBenchmarkSupportImpl::WebViewBenchmarkSupportImpl):
+(WebKit::WebViewBenchmarkSupportImpl::~WebViewBenchmarkSupportImpl):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::WebViewImpl):
+(WebKit::WebViewImpl::benchmarkSupport):
+(WebKit):
+(WebKit::WebViewImpl::rootGraphicsLayer):
+* src/WebViewImpl.h:
+(WebKit):
+(WebViewImpl):
+
 2012-07-20  Han Shen  shen...@google.com
 
 [Chromium] Compilation fails under gcc 4.7


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (123253 => 123254)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2012-07-20 20:09:02 UTC (rev 123253)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2012-07-20 20:24:29 UTC (rev 123254)
@@ -279,6 +279,7 @@
 'public/WebUserMediaClient.h',
 'public/WebUserMediaRequest.h',
 'public/WebView.h',
+'public/WebViewBenchmarkSupport.h',
 'public/WebViewClient.h',
 'public/WebWidget.h',
 'public/WebWidgetClient.h',
@@ -661,6 +662,8 @@
 'src/WebTextFieldDecoratorClient.cpp',
 'src/WebUserMediaRequest.cpp',
 'src/WebVideoLayer.cpp',
+'src/WebViewBenchmarkSupportImpl.cpp',
+'src/WebViewBenchmarkSupportImpl.h',
 'src/WebViewImpl.cpp',
 'src/WebViewImpl.h',
 'src/WebWorkerBase.cpp',


Modified: trunk/Source/WebKit/chromium/public/WebView.h (123253 => 

[webkit-changes] [123255] trunk/Source/WebKit/blackberry

[commit-queue]

Title: [123255] trunk/Source/WebKit/blackberry








Revision 123255
Author commit-qu...@webkit.org
Date 2012-07-20 13:42:13 -0700 (Fri, 20 Jul 2012)


Log Message
[BlackBerry] Add Cancel button for Select popup
https://bugs.webkit.org/show_bug.cgi?id=91887

Patch by Crystal Zhang haizh...@rim.com on 2012-07-20
Reviewed by Yong Li.

PR 177706

* WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::generateHTML):
(WebCore::SelectPopupClient::setValueAndClosePopup):

Modified Paths

trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp




Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (123254 => 123255)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-07-20 20:24:29 UTC (rev 123254)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-07-20 20:42:13 UTC (rev 123255)
@@ -1,3 +1,16 @@
+2012-07-20  Crystal Zhang  haizh...@rim.com
+
+[BlackBerry] Add Cancel button for Select popup
+https://bugs.webkit.org/show_bug.cgi?id=91887
+
+Reviewed by Yong Li.
+
+PR 177706
+
+* WebCoreSupport/SelectPopupClient.cpp:
+(WebCore::SelectPopupClient::generateHTML):
+(WebCore::SelectPopupClient::setValueAndClosePopup):
+
 2012-07-19  Mary Wu  mary...@torchmobile.com.cn
 
 [BlackBerry] Make sure to send favicon when go back/forward


Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp (123254 => 123255)

--- trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp	2012-07-20 20:24:29 UTC (rev 123254)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp	2012-07-20 20:42:13 UTC (rev 123255)
@@ -115,6 +115,7 @@
 source.append(, );
 }
 source.append(] );
+source.append(, 'Cancel');
 // If multi-select, add OK button for confirm.
 if (m_multiple)
 source.append(, 'OK');
@@ -145,8 +146,13 @@
 void SelectPopupClient::setValueAndClosePopup(int, const String stringValue)
 {
 ASSERT(m_element);
-ASSERT(m_size == stringValue.length());
 
+static const char* cancelValue = -1;
+if (stringValue == cancelValue) {
+closePopup();
+return;
+}
+
 if (m_size  0) {
 bool selecteds[m_size];
 for (unsigned i = 0; i  m_size; i++)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123257] trunk/LayoutTests

[tony]

Title: [123257] trunk/LayoutTests








Revision 123257
Author t...@chromium.org
Date 2012-07-20 14:01:36 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Unreviewed gardening.  Unskip some tests that just need new baselines.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123256 => 123257)

--- trunk/LayoutTests/ChangeLog	2012-07-20 21:01:30 UTC (rev 123256)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 21:01:36 UTC (rev 123257)
@@ -1,5 +1,11 @@
 2012-07-20  Tony Chang  t...@chromium.org
 
+[chromium] Unreviewed gardening.  Unskip some tests that just need new baselines.
+
+* platform/chromium/TestExpectations:
+
+2012-07-20  Tony Chang  t...@chromium.org
+
 [chromium] Rebaseline css3/filters/custom tests
 https://bugs.webkit.org/show_bug.cgi?id=82372
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123256 => 123257)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 21:01:30 UTC (rev 123256)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 21:01:36 UTC (rev 123257)
@@ -2639,32 +2639,32 @@
 BUGWK74137 SNOWLEOPARD : fast/regions/region-overflow-auto-overflow-visible.html = PASS IMAGE+TEXT TIMEOUT
 BUGWK74137 WIN LINUX LION : fast/regions/region-overflow-auto-overflow-visible.html = PASS MISSING
 
-BUGWK82783 SKIP : css3/filters/filter-change-repaint-composited.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-change-repaint.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-repaint-blur.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-repaint-child-layers.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-repaint-composited-fallback-crash.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-repaint-composited-fallback.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-repaint-shadow-clipped.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-repaint-shadow-rotated.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-repaint-shadow.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-repaint.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-with-transform.html = PASS
-BUGWK82783 SKIP : css3/filters/filter-repaint-sepia.html = PASS
-BUGWK82783 SKIP : css3/filters/nested-filter.html = PASS
-BUGWK82783 SKIP WIN : css3/filters/blur-filter-page-scroll.html = PASS
+BUGWK82783 : css3/filters/filter-change-repaint-composited.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-change-repaint.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-repaint-blur.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-repaint-child-layers.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-repaint-composited-fallback-crash.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-repaint-composited-fallback.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-repaint-shadow-clipped.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-repaint-shadow-rotated.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-repaint-shadow.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-repaint.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-with-transform.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/filter-repaint-sepia.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 : css3/filters/nested-filter.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK82783 WIN : css3/filters/blur-filter-page-scroll.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
 
 // Following tests need baselines on Win and Linux
-BUGWK84800 SKIP WIN LINUX : css3/filters/custom/filter-repaint-custom-clipped.html = PASS
-BUGWK84800 SKIP WIN LINUX : css3/filters/custom/filter-repaint-custom-rotated.html = PASS
-BUGWK84800 SKIP WIN LINUX : css3/filters/custom/filter-repaint-custom.html = PASS
-BUGWK84800 SKIP WIN LINUX : css3/filters/custom/effect-color-check.html = PASS
+BUGWK84800 WIN LINUX : css3/filters/custom/filter-repaint-custom-clipped.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK84800 WIN LINUX : css3/filters/custom/filter-repaint-custom-rotated.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK84800 WIN LINUX : css3/filters/custom/filter-repaint-custom.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+BUGWK84800 WIN LINUX : css3/filters/custom/effect-color-check.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
 
 // CSS Regions tests for region styling and scoped styles
-BUGWK49142 SKIP : fast/regions/style-scoped-in-flow-override-container-style.html = PASS
-BUGWK49142 SKIP : fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html = PASS
-BUGWK49142 SKIP : fast/regions/style-scoped-in-flow-override-region-styling.html = PASS
-BUGWK49142 SKIP : fast/regions/style-scoped-in-flow.html = 

[webkit-changes] [123256] trunk/Source/WebKit/chromium

[commit-queue]

Title: [123256] trunk/Source/WebKit/chromium








Revision 123256
Author commit-qu...@webkit.org
Date 2012-07-20 14:01:30 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium][Mac] Switch the MACOSX_DEPLOYMENT_TARGET to 10.6
https://bugs.webkit.org/show_bug.cgi?id=91752

Patch by Robert Sesek rse...@chromium.org on 2012-07-20
Reviewed by Eric Seidel.

Use 10.6 NSScreen/NSColorSpace APIs to determine if the screen is
monochrome rather than comparing against deprecated colorspace names.

* src/mac/WebScreenInfoFactory.mm:
(WebKit::WebScreenInfoFactory::screenInfo):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/mac/WebScreenInfoFactory.mm




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (123255 => 123256)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 20:42:13 UTC (rev 123255)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 21:01:30 UTC (rev 123256)
@@ -1,3 +1,16 @@
+2012-07-20  Robert Sesek  rse...@chromium.org
+
+[chromium][Mac] Switch the MACOSX_DEPLOYMENT_TARGET to 10.6
+https://bugs.webkit.org/show_bug.cgi?id=91752
+
+Reviewed by Eric Seidel.
+
+Use 10.6 NSScreen/NSColorSpace APIs to determine if the screen is
+monochrome rather than comparing against deprecated colorspace names.
+
+* src/mac/WebScreenInfoFactory.mm:
+(WebKit::WebScreenInfoFactory::screenInfo):
+
 2012-07-20  Daniel Murphy  dmu...@chromium.org
 
 Introduce WebViewBenchmarkSupport for performance experiments on a real WebView


Modified: trunk/Source/WebKit/chromium/src/mac/WebScreenInfoFactory.mm (123255 => 123256)

--- trunk/Source/WebKit/chromium/src/mac/WebScreenInfoFactory.mm	2012-07-20 20:42:13 UTC (rev 123255)
+++ trunk/Source/WebKit/chromium/src/mac/WebScreenInfoFactory.mm	2012-07-20 21:01:30 UTC (rev 123256)
@@ -91,7 +91,7 @@
 
 WebScreenInfo WebScreenInfoFactory::screenInfo(NSView* view)
 {
-NSString *colorSpace = NSColorSpaceFromDepth([[NSScreen deepestScreen] depth]);
+NSScreen* screen = [NSScreen deepestScreen];
 
 WebScreenInfo results;
 
@@ -99,14 +99,10 @@
 results.horizontalDPI = deviceDPI;
 results.verticalDPI = deviceDPI;
 
-results.depth =
-NSBitsPerPixelFromDepth([[NSScreen deepestScreen] depth]);
-results.depthPerComponent =
-NSBitsPerSampleFromDepth([[NSScreen deepestScreen] depth]);
-results.isMonochrome = colorSpace == NSCalibratedWhiteColorSpace
-|| colorSpace == NSCalibratedBlackColorSpace
-|| colorSpace == NSDeviceWhiteColorSpace
-|| colorSpace == NSDeviceBlackColorSpace;
+results.depth = NSBitsPerPixelFromDepth([screen depth]);
+results.depthPerComponent = NSBitsPerSampleFromDepth([screen depth]);
+results.isMonochrome =
+[[screen colorSpace] colorSpaceModel] == NSGrayColorSpaceModel;
 results.rect = convertRect([screenForWindow([view window]) frame], [view window]);
 results.availableRect =
 convertRect([screenForWindow([view window]) visibleFrame], [view window]);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123258] trunk/Tools

[wangxianzhu]

Title: [123258] trunk/Tools








Revision 123258
Author wangxian...@chromium.org
Date 2012-07-20 14:08:59 -0700 (Fri, 20 Jul 2012)


Log Message
[Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
https://bugs.webkit.org/show_bug.cgi?id=91873

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py




Diff

Modified: trunk/Tools/ChangeLog (123257 => 123258)

--- trunk/Tools/ChangeLog	2012-07-20 21:01:36 UTC (rev 123257)
+++ trunk/Tools/ChangeLog	2012-07-20 21:08:59 UTC (rev 123258)
@@ -1,3 +1,12 @@
+2012-07-20  Xianzhu Wang  wangxian...@chromium.org
+
+[Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
+https://bugs.webkit.org/show_bug.cgi?id=91873
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+
 2012-07-20  Han Shen  shen...@google.com
 
 [Chromium] Compilation fails under gcc 4.7


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (123257 => 123258)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-07-20 21:01:36 UTC (rev 123257)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-07-20 21:08:59 UTC (rev 123258)
@@ -58,7 +58,7 @@
 DRT_APP_PACKAGE = 'org.chromium.native_test'
 DRT_ACTIVITY_FULL_NAME = DRT_APP_PACKAGE + '/.ChromeNativeTestActivity'
 DRT_APP_DIR = '/data/user/0/' + DRT_APP_PACKAGE + '/'
-DRT_APP_FILES_DIR = DRT_APP_DIR + 'files/'
+DRT_APP_FILES_DIR = '/sdcard/native_tests/'
 DRT_APP_CACHE_DIR = DRT_APP_DIR + 'cache/'
 
 # This only works for single core devices so far.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123259] trunk

[scherkus]

Title: [123259] trunk








Revision 123259
Author scher...@chromium.org
Date 2012-07-20 14:12:02 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] CSS tweaks to media controls to prevent styles from being overridden
https://bugs.webkit.org/show_bug.cgi?id=91802

Reviewed by Eric Carlson.

Source/WebCore:

Having the buttons declared as inline caused them to not be included in the box layout,
resulting in styles set outside the media element to affect the position of the buttons.

In a similar vein, it was also possible to override the font-style attribute for the time
display.

Test: media/controls-styling-strict.html

* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

LayoutTests:

* media/controls-styling-strict.html: Added.
* platform/chromium-linux/media/controls-styling-strict-expected.png: Added.
* platform/chromium-linux/media/controls-styling-strict-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/mediaControlsChromium.css


Added Paths

trunk/LayoutTests/media/controls-styling-strict.html




Diff

Modified: trunk/LayoutTests/ChangeLog (123258 => 123259)

--- trunk/LayoutTests/ChangeLog	2012-07-20 21:08:59 UTC (rev 123258)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 21:12:02 UTC (rev 123259)
@@ -1,3 +1,14 @@
+2012-07-19  Andrew Scherkus  scher...@chromium.org
+
+[chromium] CSS tweaks to media controls to prevent styles from being overridden
+https://bugs.webkit.org/show_bug.cgi?id=91802
+
+Reviewed by Eric Carlson.
+
+* media/controls-styling-strict.html: Added.
+* platform/chromium-linux/media/controls-styling-strict-expected.png: Added.
+* platform/chromium-linux/media/controls-styling-strict-expected.txt: Added.
+
 2012-07-20  Tony Chang  t...@chromium.org
 
 [chromium] Unreviewed gardening.  Unskip some tests that just need new baselines.


Added: trunk/LayoutTests/media/controls-styling-strict.html (0 => 123259)

--- trunk/LayoutTests/media/controls-styling-strict.html	(rev 0)
+++ trunk/LayoutTests/media/controls-styling-strict.html	2012-07-20 21:12:02 UTC (rev 123259)
@@ -0,0 +1,18 @@
+!DOCTYPE HTML
+html
+head
+script src=""
+script src=""
+style
+video:nth-of-type(1) {
+font: bold italic 30px monospace;
+color: red;
+}
+/style
+/head
+body _onload_=setSrcByTagName('video', findMediaFile('video', 'content/test')); init();
+pThe look of the controls should not change when styled under strict mode./p
+video controls/video
+video controls/video
+/body
+/html
Property changes on: trunk/LayoutTests/media/controls-styling-strict.html
___


Added: svn:eol-style

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123258 => 123259)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 21:08:59 UTC (rev 123258)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 21:12:02 UTC (rev 123259)
@@ -2887,26 +2887,6 @@
 BUGWK81402 WIN : media/track/track-active-cues.html = PASS TIMEOUT
 BUGWK83882 : media/track/track-mode.html = PASS TEXT TIMEOUT
 
-// Need rebaseline after patch lands.
-BUGWK89696 WIN MAC : media/audio-controls-rendering.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/audio-repaint.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/controls-after-reload.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/controls-layout-direction.html = IMAGE
-BUGWK89696 WIN MAC : media/controls-strict.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/controls-styling.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/controls-without-preload.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/media-controls-clone.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/media-document-audio-repaint.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/video-controls-rendering.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/video-display-toggle.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/video-no-audio.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/video-playing-and-pause.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : media/video-zoom-controls.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : fast/layers/video-layer.html = IMAGE IMAGE+TEXT
-BUGWK89696 WIN MAC : fullscreen/full-screen-stacking-context.html = IMAGE
-BUGWK89696 WIN MAC : http/tests/media/video-buffered-range-contains-currentTime.html 

[webkit-changes] [123260] trunk/Source/WebCore

[senorblanco]

Title: [123260] trunk/Source/WebCore








Revision 123260
Author senorbla...@chromium.org
Date 2012-07-20 14:24:05 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Clean up scratch texture usage in Chromium's implementation
of GPU-accelerated filters.
https://bugs.webkit.org/show_bug.cgi?id=83370

Reviewed by Adrienne Walker.

There didn't used to be a safe way to allocate a scratch texture, and
hold into it beyond the lifetime of GrAutoScratchTexture.  Now there is:
detach().

Covered by existing tests in css3/filters.

* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::apply):
Use a GrAutoScratchTexture to allocate the destination texture, and
detach() to detach it from the cache before placing it in an
SkGrTexturePixelRef.  This means we no longer need to do any lock/
unlock trickery with the TextureCacheEntry, since the refcount is
enough to keep the texture away from the cache's prying hands.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123259 => 123260)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 21:12:02 UTC (rev 123259)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 21:24:05 UTC (rev 123260)
@@ -1,3 +1,25 @@
+2012-07-20  Stephen White  senorbla...@chromium.org
+
+[chromium] Clean up scratch texture usage in Chromium's implementation
+of GPU-accelerated filters.
+https://bugs.webkit.org/show_bug.cgi?id=83370
+
+Reviewed by Adrienne Walker.
+
+There didn't used to be a safe way to allocate a scratch texture, and
+hold into it beyond the lifetime of GrAutoScratchTexture.  Now there is:
+detach().
+
+Covered by existing tests in css3/filters.
+
+* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
+(WebCore::CCRenderSurfaceFilters::apply):
+Use a GrAutoScratchTexture to allocate the destination texture, and 
+detach() to detach it from the cache before placing it in an
+SkGrTexturePixelRef.  This means we no longer need to do any lock/
+unlock trickery with the TextureCacheEntry, since the refcount is
+enough to keep the texture away from the cache's prying hands.
+
 2012-07-19  Andrew Scherkus  scher...@chromium.org
 
 [chromium] CSS tweaks to media controls to prevent styles from being overridden


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp (123259 => 123260)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp	2012-07-20 21:12:02 UTC (rev 123259)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp	2012-07-20 21:24:05 UTC (rev 123260)
@@ -193,12 +193,7 @@
 source.setConfig(SkBitmap::kARGB__Config, size.width(), size.height());
 source.setPixelRef(new SkGrTexturePixelRef(texture.get()))-unref();
 
-GrContext::TextureCacheEntry dest;
-
 for (unsigned i = 0; i  filters.size(); ++i) {
-// Save the previous texture cache destination (if any), and keep it
-// locked during draw to prevent it be re-used as destination.
-GrContext::TextureCacheEntry sourceEntry = dest;
 const WebKit::WebFilterOperation op = filters.at(i);
 // Allocate a destination texture.
 GrTextureDesc desc;
@@ -208,10 +203,11 @@
 desc.fHeight = size.height();
 desc.fConfig = kSkia_PM_GrPixelConfig;
 // FIXME: could we use approximate match, and fix texcoords on draw
-dest = gr-lockScratchTexture(desc, GrContext::kExact_ScratchTexMatch);
-if (!dest.texture())
+GrAutoScratchTexture scratchTexture(gr, desc, GrContext::kExact_ScratchTexMatch);
+SkAutoTUnrefGrTexture destination(scratchTexture.detach());
+if (!destination.get())
 return SkBitmap();
-SkGpuDevice device(gr, dest.texture());
+SkGpuDevice device(gr, destination.get());
 SkCanvas canvas(device);
 canvas.clear(0x0);
 switch (op.type()) {
@@ -289,13 +285,8 @@
 break;
 }
 // Dest texture from this filter becomes source bitmap for next filter.
-source.setPixelRef(new SkGrTexturePixelRef(dest.texture()))-unref();
-// Unlock the previous texture cache entry.
-if (sourceEntry.texture())
-gr-unlockTexture(sourceEntry);
+source.setPixelRef(new SkGrTexturePixelRef(destination.get()))-unref();
 }
-if (dest.texture())
-gr-unlockTexture(dest);
 context3D-flush();
 return source;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123261] trunk/LayoutTests

[tony]

Title: [123261] trunk/LayoutTests








Revision 123261
Author t...@chromium.org
Date 2012-07-20 14:24:20 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Unreviewed, mark some tests as slow in debug.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123260 => 123261)

--- trunk/LayoutTests/ChangeLog	2012-07-20 21:24:05 UTC (rev 123260)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 21:24:20 UTC (rev 123261)
@@ -1,3 +1,9 @@
+2012-07-20  Tony Chang  t...@chromium.org
+
+[chromium] Unreviewed, mark some tests as slow in debug.
+
+* platform/chromium/TestExpectations:
+
 2012-07-19  Andrew Scherkus  scher...@chromium.org
 
 [chromium] CSS tweaks to media controls to prevent styles from being overridden


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123260 => 123261)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 21:24:05 UTC (rev 123260)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 21:24:20 UTC (rev 123261)
@@ -2868,6 +2868,7 @@
 // Crashing since on or before r122699, please uncomment previous line before removing.
 BUGWK91415 MAC DEBUG SLOW : fast/frames/calculate-fixed.html = PASS TEXT
 BUGWK91415 MAC RELEASE : fast/frames/calculate-fixed.html = PASS TEXT
+BUGWK91415 WIN DEBUG SLOW : fast/frames/calculate-fixed.html = PASS
 
 BUGWK71278 SLOW WIN : fast/events/dispatch-message-string-data.html = PASS
 
@@ -3091,7 +3092,8 @@
 BUGWK81803 MAC : platform/chromium/compositing/rubberbanding/transform-overhang-sw.html = PASS IMAGE
 BUGWK81803 MAC : platform/chromium/compositing/rubberbanding/transform-overhang-w.html = PASS IMAGE
 
-BUGWK81857 SNOWLEOPARD : fast/frames/valid.html = IMAGE
+BUGWK81857 SNOWLEOPARD RELEASE : fast/frames/valid.html = IMAGE
+BUGWK81857 SLOW SNOWLEOPARD DEBUG : fast/frames/valid.html = IMAGE
 BUGWK81931 SNOWLEOPARD WIN DEBUG : fast/images/destroyed-image-load-event.html = PASS TIMEOUT
 
 BUGWK37244 : tables/mozilla/bugs/bug27038-1.html = IMAGE+TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123262] trunk/Source/WebCore

[commit-queue]

Title: [123262] trunk/Source/WebCore








Revision 123262
Author commit-qu...@webkit.org
Date 2012-07-20 14:27:00 -0700 (Fri, 20 Jul 2012)


Log Message
Typo in FontCacheWin.cpp causes return value from getCachedFontData() in getLastResortFallbackFont() to be ignored
https://bugs.webkit.org/show_bug.cgi?id=91506

Patch by Mark Salisbury mark.salisb...@hp.com on 2012-07-20
Reviewed by Joseph Pecoraro.

No new test.  The fallback fallback code ends up creating a font, so you always
get a fallback font even with this code bug.  A test would be buggy, being highly
platform dependent on what the fallback fallback font is on the particular
windows machine the test runs on.

* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getLastResortFallbackFont):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123261 => 123262)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 21:24:20 UTC (rev 123261)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 21:27:00 UTC (rev 123262)
@@ -1,3 +1,18 @@
+2012-07-20  Mark Salisbury  mark.salisb...@hp.com
+
+Typo in FontCacheWin.cpp causes return value from getCachedFontData() in getLastResortFallbackFont() to be ignored
+https://bugs.webkit.org/show_bug.cgi?id=91506
+
+Reviewed by Joseph Pecoraro.
+
+No new test.  The fallback fallback code ends up creating a font, so you always
+get a fallback font even with this code bug.  A test would be buggy, being highly
+platform dependent on what the fallback fallback font is on the particular
+windows machine the test runs on.
+
+* platform/graphics/win/FontCacheWin.cpp:
+(WebCore::FontCache::getLastResortFallbackFont):
+
 2012-07-20  Stephen White  senorbla...@chromium.org
 
 [chromium] Clean up scratch texture usage in Chromium's implementation


Modified: trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp (123261 => 123262)

--- trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp	2012-07-20 21:24:20 UTC (rev 123261)
+++ trunk/Source/WebCore/platform/graphics/win/FontCacheWin.cpp	2012-07-20 21:27:00 UTC (rev 123262)
@@ -331,7 +331,7 @@
 };
 SimpleFontData* simpleFont;
 for (size_t i = 0; i  WTF_ARRAY_LENGTH(fallbackFonts); ++i) {
-if (simpleFont = getCachedFontData(fontDescription, fallbackFonts[i]), false, shouldRetain) {
+if (simpleFont = getCachedFontData(fontDescription, fallbackFonts[i], false, shouldRetain)) {
 fallbackFontName = fallbackFonts[i];
 return simpleFont;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123263] trunk/LayoutTests

[tony]

Title: [123263] trunk/LayoutTests








Revision 123263
Author t...@chromium.org
Date 2012-07-20 14:31:39 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Unreviewed gardening.  Remove a test that hasn't been
added to the tree yet.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123262 => 123263)

--- trunk/LayoutTests/ChangeLog	2012-07-20 21:27:00 UTC (rev 123262)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 21:31:39 UTC (rev 123263)
@@ -1,5 +1,12 @@
 2012-07-20  Tony Chang  t...@chromium.org
 
+[chromium] Unreviewed gardening.  Remove a test that hasn't been
+added to the tree yet.
+
+* platform/chromium/TestExpectations:
+
+2012-07-20  Tony Chang  t...@chromium.org
+
 [chromium] Unreviewed, mark some tests as slow in debug.
 
 * platform/chromium/TestExpectations:


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123262 => 123263)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 21:27:00 UTC (rev 123262)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 21:31:39 UTC (rev 123263)
@@ -3642,7 +3642,6 @@
 
 // Needs rebaseline.
 BUGWK91802 : media/media-document-audio-repaint.html = IMAGE+TEXT
-BUGWK91802 : media/video-controls-audio-only.html = IMAGE+TEXT
 BUGWK91802 : fast/layers/video-layer.html = TEXT
 BUGWK91802 : media/audio-controls-rendering.html = TEXT
 BUGWK91802 : media/audio-repaint.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123265] trunk/Source/WebCore

[kov]

Title: [123265] trunk/Source/WebCore








Revision 123265
Author k...@webkit.org
Date 2012-07-20 14:41:14 -0700 (Fri, 20 Jul 2012)


Log Message
[Soup] Unnecessary RefPtr usage and null check
https://bugs.webkit.org/show_bug.cgi?id=91636

Patch by Gustavo Noronha Silva gustavo.noro...@collabora.com on 2012-07-18
Reviewed by Martin Robinson.

Small clean up of code that is not necessary; no change in functionality.

* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::connected):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123264 => 123265)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 21:40:24 UTC (rev 123264)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 21:41:14 UTC (rev 123265)
@@ -1,3 +1,15 @@
+2012-07-18  Gustavo Noronha Silva  gustavo.noro...@collabora.com
+
+[Soup] Unnecessary RefPtr usage and null check
+https://bugs.webkit.org/show_bug.cgi?id=91636
+
+Reviewed by Martin Robinson.
+
+Small clean up of code that is not necessary; no change in functionality.
+
+* platform/network/soup/SocketStreamHandleSoup.cpp:
+(WebCore::SocketStreamHandle::connected):
+
 2012-07-20  Mark Salisbury  mark.salisb...@hp.com
 
 Typo in FontCacheWin.cpp causes return value from getCachedFontData() in getLastResortFallbackFont() to be ignored


Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp (123264 => 123265)

--- trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp	2012-07-20 21:40:24 UTC (rev 123264)
+++ trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp	2012-07-20 21:41:14 UTC (rev 123265)
@@ -116,12 +116,8 @@
 g_input_stream_read_async(m_inputStream.get(), m_readBuffer, READ_BUFFER_SIZE, G_PRIORITY_DEFAULT, 0,
 reinterpret_castGAsyncReadyCallback(readReadyCallback), m_id);
 
-// The client can close the handle, potentially removing the last reference.
-RefPtrSocketStreamHandle protect(this); 
 m_state = Open;
 m_client-didOpenSocketStream(this);
-if (!m_socketConnection) // Client closed the connection.
-return;
 }
 
 void SocketStreamHandle::readBytes(signed long bytesRead, GError* error)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123266] trunk

[commit-queue]

Title: [123266] trunk








Revision 123266
Author commit-qu...@webkit.org
Date 2012-07-20 14:45:21 -0700 (Fri, 20 Jul 2012)


Log Message
Source/WebCore: [Soup] Unnecessary RefPtr usage and null check
https://bugs.webkit.org/show_bug.cgi?id=91636

Patch by Gustavo Noronha Silva gustavo.noro...@collabora.com on 2012-07-18
Reviewed by Martin Robinson.

Small clean up of code that is not necessary; no change in functionality.

* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::connected):

Source/WebKit/blackberry: [BlackBerry] clock_gettime() in BackingStore.cpp should use CLOCK_MONOTONIC
https://bugs.webkit.org/show_bug.cgi?id=91898

Patch by Jacky Jiang zhaji...@rim.com on 2012-07-20
Reviewed by Yong Li.

PR: 181043
Use CLOCK_MONOTONIC when we do expect a monotonic timer.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):

LayoutTests: [Qt] svg/text rebaseline after new test fonts (part 1)
https://bugs.webkit.org/show_bug.cgi?id=91762

Patch by Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org on 2012-07-20
Reviewed by Andreas Kling.

* platform/qt-5.0-wk2/svg/text/kerning-expected.png: Removed.
* platform/qt-5.0-wk2/svg/text/kerning-expected.txt: Removed.
* platform/qt-5.0/Skipped:
* platform/qt-5.0/svg/text/text-text-01-b-expected.png: Removed.
* platform/qt-5.0/svg/text/text-text-01-b-expected.txt: Removed.
* platform/qt-5.0/svg/text/text-text-04-t-expected.png: Removed.
* platform/qt-5.0/svg/text/text-text-04-t-expected.txt: Removed.
* platform/qt/svg/text/kerning-expected.png:
* platform/qt/svg/text/kerning-expected.txt:
* platform/qt/svg/text/small-fonts-2-expected.png:
* platform/qt/svg/text/small-fonts-2-expected.txt:
* platform/qt/svg/text/small-fonts-3-expected.png:
* platform/qt/svg/text/small-fonts-3-expected.txt:
* platform/qt/svg/text/small-fonts-expected.png:
* platform/qt/svg/text/small-fonts-expected.txt: Added.
* platform/qt/svg/text/small-fonts-in-html5-expected.png:
* platform/qt/svg/text/small-fonts-in-html5-expected.txt:
* platform/qt/svg/text/text-text-01-b-expected.png:
* platform/qt/svg/text/text-text-01-b-expected.txt:
* platform/qt/svg/text/text-text-03-b-expected.png:
* platform/qt/svg/text/text-text-03-b-expected.txt:
* platform/qt/svg/text/text-text-04-t-expected.png:
* platform/qt/svg/text/text-text-04-t-expected.txt:
* platform/qt/svg/text/text-text-05-t-expected.png:
* platform/qt/svg/text/text-text-05-t-expected.txt:
* platform/qt/svg/text/text-text-06-t-expected.png:
* platform/qt/svg/text/text-text-06-t-expected.txt:
* platform/qt/svg/text/text-text-07-t-expected.png:
* platform/qt/svg/text/text-text-07-t-expected.txt:
* platform/qt/svg/text/text-text-08-b-expected.png:
* platform/qt/svg/text/text-text-08-b-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebKit/blackberry/Api/BackingStore.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/LayoutTests/ChangeLog (123265 => 123266)

--- trunk/LayoutTests/ChangeLog	2012-07-20 21:41:14 UTC (rev 123265)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 21:45:21 UTC (rev 123266)
@@ -50,6 +50,12 @@
 
 * platform/chromium/TestExpectations:
 
+2012-07-20  Tony Chang  t...@chromium.org
+
+[chromium] Unreviewed, mark some tests as slow in debug.
+
+* platform/chromium/TestExpectations:
+
 2012-07-19  Andrew Scherkus  scher...@chromium.org
 
 [chromium] CSS tweaks to media controls to prevent styles from being overridden


Modified: trunk/Source/WebCore/ChangeLog (123265 => 123266)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 21:41:14 UTC (rev 123265)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 21:45:21 UTC (rev 123266)
@@ -47,6 +47,28 @@
 unlock trickery with the TextureCacheEntry, since the refcount is
 enough to keep the texture away from the cache's prying hands.
 
+2012-07-20  Stephen White  senorbla...@chromium.org
+
+[chromium] Clean up scratch texture usage in Chromium's implementation
+of GPU-accelerated filters.
+https://bugs.webkit.org/show_bug.cgi?id=83370
+
+Reviewed by Adrienne Walker.
+
+There didn't used to be a safe way to allocate a scratch texture, and
+hold into it beyond the lifetime of GrAutoScratchTexture.  Now there is:
+detach().
+
+Covered by existing tests in css3/filters.
+
+* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
+(WebCore::CCRenderSurfaceFilters::apply):
+Use a GrAutoScratchTexture to allocate the destination texture, and 
+detach() to detach it from the cache before placing it in an
+SkGrTexturePixelRef.  This means we no longer need to do any lock/
+unlock trickery with the TextureCacheEntry, since the refcount is
+enough to keep the texture away from the cache's prying hands.
+
 2012-07-19  Andrew Scherkus  scher...@chromium.org
 
 [chromium] CSS tweaks to media 

[webkit-changes] [123267] trunk/Source

[dgrogan]

Title: [123267] trunk/Source








Revision 123267
Author dgro...@chromium.org
Date 2012-07-20 14:56:04 -0700 (Fri, 20 Jul 2012)


Log Message
IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types
https://bugs.webkit.org/show_bug.cgi?id=91414

Reviewed by Adam Barth.

Source/WebCore:

No new tests because no new behavior.

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::metadata):
No behavior change, this just needs a dummy parameter to match the
modified API.

* Modules/indexeddb/IDBMetadata.h:
(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
(IDBDatabaseMetadata):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:
* src/WebIDBMetadata.cpp:
(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBMetadata.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/WebIDBMetadata.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123266 => 123267)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 21:45:21 UTC (rev 123266)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 21:56:04 UTC (rev 123267)
@@ -1,3 +1,21 @@
+2012-07-20  David Grogan  dgro...@chromium.org
+
+IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types
+https://bugs.webkit.org/show_bug.cgi?id=91414
+
+Reviewed by Adam Barth.
+
+No new tests because no new behavior.
+
+* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
+(WebCore::IDBDatabaseBackendImpl::metadata):
+No behavior change, this just needs a dummy parameter to match the
+modified API.
+
+* Modules/indexeddb/IDBMetadata.h:
+(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
+(IDBDatabaseMetadata):
+
 2012-07-18  Gustavo Noronha Silva  gustavo.noro...@collabora.com
 
 [Soup] Unnecessary RefPtr usage and null check


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp (123266 => 123267)

--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp	2012-07-20 21:45:21 UTC (rev 123266)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp	2012-07-20 21:56:04 UTC (rev 123267)
@@ -136,7 +136,7 @@
 
 IDBDatabaseMetadata IDBDatabaseBackendImpl::metadata() const
 {
-IDBDatabaseMetadata metadata(m_name, m_version);
+IDBDatabaseMetadata metadata(m_name, m_version, IDBDatabaseMetadata::NoIntVersion);
 for (ObjectStoreMap::const_iterator it = m_objectStores.begin(); it != m_objectStores.end(); ++it)
 metadata.objectStores.set(it-first, it-second-metadata());
 return metadata;


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBMetadata.h (123266 => 123267)

--- trunk/Source/WebCore/Modules/indexeddb/IDBMetadata.h	2012-07-20 21:45:21 UTC (rev 123266)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBMetadata.h	2012-07-20 21:56:04 UTC (rev 123267)
@@ -42,12 +42,24 @@
 struct IDBIndexMetadata;
 
 struct IDBDatabaseMetadata {
-IDBDatabaseMetadata() { }
-IDBDatabaseMetadata(const String name, const String version)
+enum {
+NoIntVersion = -1
+};
+
+IDBDatabaseMetadata()
+: intVersion(NoIntVersion)
+{
+}
+IDBDatabaseMetadata(const String name, const String version, int64_t intVersion)
 : name(name)
-, version(version) { }
+, version(version)
+, intVersion(intVersion)
+{
+}
+
 String name;
 String version;
+int64_t intVersion;
 
 typedef HashMapString, IDBObjectStoreMetadata ObjectStoreMap;
 ObjectStoreMap objectStores;


Modified: trunk/Source/WebKit/chromium/ChangeLog (123266 => 123267)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 21:45:21 UTC (rev 123266)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 21:56:04 UTC (rev 123267)
@@ -1,3 +1,15 @@
+2012-07-20  David Grogan  dgro...@chromium.org
+
+IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types
+https://bugs.webkit.org/show_bug.cgi?id=91414
+
+Reviewed by Adam Barth.
+
+* src/AssertMatchingEnums.cpp:
+* src/WebIDBMetadata.cpp:
+(WebKit::WebIDBMetadata::WebIDBMetadata):
+(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):
+
 2012-07-20  Robert Sesek  rse...@chromium.org
 
 [chromium][Mac] Switch the MACOSX_DEPLOYMENT_TARGET to 10.6


Modified: trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp (123266 => 123267)

--- trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp	2012-07-20 21:45:21 UTC (rev 123266)
+++ trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp	2012-07-20 21:56:04 UTC (rev 123267)
@@ -53,6 +53,7 @@
 #include IDBFactoryBackendInterface.h
 #include 

[webkit-changes] [123269] trunk/Source/WebCore

[dimich]

Title: [123269] trunk/Source/WebCore








Revision 123269
Author dim...@chromium.org
Date 2012-07-20 15:56:06 -0700 (Fri, 20 Jul 2012)


Log Message
[Chromium] Out of Memory is observed when a large object is passed to a Web Worker.
https://bugs.webkit.org/show_bug.cgi?id=91535.

Reviewed by David Levin.

No new tests because of no new behavior and lack of mechanism to monitor used memory.

* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::registerMemoryAllocatedWithCurrentScriptContext):
(WebCore):
(WebCore::SerializedScriptValue::~SerializedScriptValue):
* bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
Added a method to SerializedScriptValue to add memory pressure on GC proportional to the size of memory allocated in serialized data.

* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
Call the new method of SerializedScriptValue during creation of MessageEvent (presumably in the thread which contains the right V8 context).

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp
trunk/Source/WebCore/bindings/v8/SerializedScriptValue.h
trunk/Source/WebCore/dom/MessageEvent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123268 => 123269)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 22:41:20 UTC (rev 123268)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 22:56:06 UTC (rev 123269)
@@ -1,3 +1,26 @@
+2012-07-20  Dmitry Titov  dim...@chromium.org
+
+[Chromium] Out of Memory is observed when a large object is passed to a Web Worker.
+https://bugs.webkit.org/show_bug.cgi?id=91535.
+
+Reviewed by David Levin.
+
+No new tests because of no new behavior and lack of mechanism to monitor used memory.
+
+* bindings/v8/SerializedScriptValue.cpp:
+(WebCore::SerializedScriptValue::SerializedScriptValue):
+(WebCore::SerializedScriptValue::registerMemoryAllocatedWithCurrentScriptContext):
+(WebCore):
+(WebCore::SerializedScriptValue::~SerializedScriptValue):
+* bindings/v8/SerializedScriptValue.h:
+(SerializedScriptValue):
+Added a method to SerializedScriptValue to add memory pressure on GC proportional to the size of memory allocated in serialized data.
+
+* dom/MessageEvent.cpp:
+(WebCore::MessageEvent::MessageEvent):
+(WebCore::MessageEvent::initMessageEvent):
+Call the new method of SerializedScriptValue during creation of MessageEvent (presumably in the thread which contains the right V8 context).
+
 2012-07-20  David Grogan  dgro...@chromium.org
 
 IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types


Modified: trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp (123268 => 123269)

--- trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp	2012-07-20 22:41:20 UTC (rev 123268)
+++ trunk/Source/WebCore/bindings/v8/SerializedScriptValue.cpp	2012-07-20 22:56:06 UTC (rev 123269)
@@ -2201,6 +2201,7 @@
 }
 
 SerializedScriptValue::SerializedScriptValue()
+: m_externallyAllocatedMemory(0)
 {
 }
 
@@ -2252,6 +2253,7 @@
  MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers,
  bool didThrow,
  v8::Isolate* isolate)
+: m_externallyAllocatedMemory(0)
 {
 didThrow = false;
 Writer writer(isolate);
@@ -2298,6 +2300,7 @@
 }
 
 SerializedScriptValue::SerializedScriptValue(const String wireData)
+: m_externallyAllocatedMemory(0)
 {
 m_data = wireData.isolatedCopy();
 }
@@ -2322,4 +2325,23 @@
 }
 #endif
 
+void SerializedScriptValue::registerMemoryAllocatedWithCurrentScriptContext()
+{
+if (m_externallyAllocatedMemory)
+return;
+m_externallyAllocatedMemory = static_castintptr_t(m_data.length());
+v8::V8::AdjustAmountOfExternalAllocatedMemory(m_externallyAllocatedMemory);
+}
+
+SerializedScriptValue::~SerializedScriptValue()
+{
+// If the allocated memory was not registered before, then this class is likely
+// used in a context other then Worker's onmessage environment and the presence of
+// current v8 context is not guaranteed. Avoid calling v8 then.
+if (m_externallyAllocatedMemory) {
+ASSERT(v8::Isolate::GetCurrent());
+v8::V8::AdjustAmountOfExternalAllocatedMemory(-m_externallyAllocatedMemory);
+}
+}
+
 } // namespace WebCore


Modified: trunk/Source/WebCore/bindings/v8/SerializedScriptValue.h (123268 => 123269)

--- trunk/Source/WebCore/bindings/v8/SerializedScriptValue.h	2012-07-20 22:41:20 UTC (rev 123268)
+++ trunk/Source/WebCore/bindings/v8/SerializedScriptValue.h	2012-07-20 22:56:06 UTC (rev 123269)
@@ -45,6 +45,8 @@
 
 class SerializedScriptValue : public ThreadSafeRefCountedSerializedScriptValue {
 

[webkit-changes] [123272] trunk

[scherkus]

Title: [123272] trunk








Revision 123272
Author scher...@chromium.org
Date 2012-07-20 16:06:14 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Don't display fullscreen button for video elements not containing video
https://bugs.webkit.org/show_bug.cgi?id=91811

Reviewed by Eric Carlson.

Covered by media/media-document-audio-repaint.html

* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::reset):

Modified Paths

trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp




Diff

Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123271 => 123272)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 23:03:35 UTC (rev 123271)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-20 23:06:14 UTC (rev 123272)
@@ -3639,3 +3639,6 @@
 BUGWK87844 SNOWLEOPARD : fast/forms/datalist/input-appearance-range-with-datalist-rtl.html = IMAGE
 BUGWK87844 SNOWLEOPARD : fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html = IMAGE
 BUGWK87844 SNOWLEOPARD : fast/forms/datalist/input-appearance-range-with-datalist.html = IMAGE
+
+// Needs rebaseline.
+BUGWK91811 : media/media-document-audio-repaint.html = IMAGE+TEXT


Modified: trunk/Source/WebCore/ChangeLog (123271 => 123272)

--- trunk/Source/WebCore/ChangeLog	2012-07-20 23:03:35 UTC (rev 123271)
+++ trunk/Source/WebCore/ChangeLog	2012-07-20 23:06:14 UTC (rev 123272)
@@ -1,3 +1,15 @@
+2012-07-20  Andrew Scherkus  scher...@chromium.org
+
+[chromium] Don't display fullscreen button for video elements not containing video
+https://bugs.webkit.org/show_bug.cgi?id=91811
+
+Reviewed by Eric Carlson.
+
+Covered by media/media-document-audio-repaint.html
+
+* html/shadow/MediaControlRootElementChromium.cpp:
+(WebCore::MediaControlRootElementChromium::reset):
+
 2012-07-20  Dmitry Titov  dim...@chromium.org
 
 [Chromium] Out of Memory is observed when a large object is passed to a Web Worker.


Modified: trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp (123271 => 123272)

--- trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp	2012-07-20 23:03:35 UTC (rev 123271)
+++ trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp	2012-07-20 23:06:14 UTC (rev 123272)
@@ -244,7 +244,7 @@
 }
 }
 
-if (m_mediaController-supportsFullscreen())
+if (m_mediaController-supportsFullscreen()  m_mediaController-hasVideo())
 m_fullscreenButton-show();
 else
 m_fullscreenButton-hide();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123274] trunk/Source/WebKit/chromium

[tony]

Title: [123274] trunk/Source/WebKit/chromium








Revision 123274
Author t...@chromium.org
Date 2012-07-20 16:39:32 -0700 (Fri, 20 Jul 2012)


Log Message
Add windows native versions of bison, flex and gperf.

Patch by Scott Graham scot...@chromium.org on 2012-07-20
Reviewed by Tony Chang.

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (123273 => 123274)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 23:15:05 UTC (rev 123273)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-20 23:39:32 UTC (rev 123274)
@@ -1,3 +1,11 @@
+2012-07-20  Scott Graham  scot...@chromium.org
+
+Add windows native versions of bison, flex and gperf.
+
+Reviewed by Tony Chang.
+
+* DEPS:
+
 2012-07-20  David Grogan  dgro...@chromium.org
 
 IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types


Modified: trunk/Source/WebKit/chromium/DEPS (123273 => 123274)

--- trunk/Source/WebKit/chromium/DEPS	2012-07-20 23:15:05 UTC (rev 123273)
+++ trunk/Source/WebKit/chromium/DEPS	2012-07-20 23:39:32 UTC (rev 123274)
@@ -143,12 +143,18 @@
 
 deps_os = {
   'win': {
+'third_party/bison':
+  From('chromium_deps', 'src/third_party/bison'),
 'third_party/cygwin':
   From('chromium_deps', 'src/third_party/cygwin'),
+'third_party/gperf':
+  From('chromium_deps', 'src/third_party/gperf'),
 'third_party/lighttpd':
   From('chromium_deps', 'src/third_party/lighttpd'),
 'third_party/nss':
   From('chromium_deps', 'src/third_party/nss'),
+'third_party/perl':
+  From('chromium_deps', 'src/third_party/perl'),
 # Dependencies used by libjpeg-turbo
 'third_party/yasm/binaries':
   From('chromium_deps', 'src/third_party/yasm/binaries'),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123275] trunk

[jsbell]

Title: [123275] trunk








Revision 123275
Author jsb...@chromium.org
Date 2012-07-20 16:51:24 -0700 (Fri, 20 Jul 2012)


Log Message
IndexedDB: ASSERTION FAILED: !m_requestFinished hit in IDBRequest::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=86911

Reviewed by Tony Chang.

Source/WebCore:

Clean up the IDBRequest/IDBCursor relationship and the IDBRequest lifecycle.

The IDBRequest's m_cursor/setCursor() calls are renamed to m_pendingCursor/setPendingCursor() to
clarify that the request will move between two states - either there's a cursor request in-flight
c/o a continue() or advance() call, or the result has come in (cursor, null-for-done, or error).
Since they were only ever used together, resetReadyState() is merged into setResultCursor(). The
m_requestFinished flag becomes redundant and is dropped - the ASSERT reported in the bug
becomes an ASSERT(m_readyState == PENDING) and m_readyState tracking is already correct.

Test: storage/indexeddb/request-continue-abort.html

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance): Unreachable code path now dead and gone.
(WebCore::IDBCursor::continueFunction): Ditto.
* Modules/indexeddb/IDBRequest.cpp: Most functions just add state assertions.
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::setCursorDetails):
(WebCore::IDBRequest::setPendingCursor): Merge with old resetReadyState().
(WebCore):
(WebCore::IDBRequest::getResultCursor): Helper, since digging cursor out of IDBAny is pesky.
(WebCore::IDBRequest::setResultCursor): Just moved in the file to be with its friends.
(WebCore::IDBRequest::finishCursor):
(WebCore::IDBRequest::onError): Just assertions, re-ordering, re-naming.
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::hasPendingActivity):
(WebCore::IDBRequest::dispatchEvent): Simplify!
(WebCore::IDBRequest::enqueueEvent):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):

LayoutTests:

Added regression test based on repro steps in the bug.

* storage/indexeddb/request-continue-abort-expected.txt: Added.
* storage/indexeddb/request-continue-abort.html: Added.
* storage/indexeddb/resources/request-continue-abort.js: Added.
(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(onUpgrade):
(testCursor.request.onsuccess):
(testCursor.request.onerror):
(testCursor.transaction.onabort):
(testCursor):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h


Added Paths

trunk/LayoutTests/storage/indexeddb/request-continue-abort-expected.txt
trunk/LayoutTests/storage/indexeddb/request-continue-abort.html
trunk/LayoutTests/storage/indexeddb/resources/request-continue-abort.js




Diff

Modified: trunk/LayoutTests/ChangeLog (123274 => 123275)

--- trunk/LayoutTests/ChangeLog	2012-07-20 23:39:32 UTC (rev 123274)
+++ trunk/LayoutTests/ChangeLog	2012-07-20 23:51:24 UTC (rev 123275)
@@ -1,3 +1,25 @@
+2012-07-20  Joshua Bell  jsb...@chromium.org
+
+IndexedDB: ASSERTION FAILED: !m_requestFinished hit in IDBRequest::dispatchEvent
+https://bugs.webkit.org/show_bug.cgi?id=86911
+
+Reviewed by Tony Chang.
+
+Added regression test based on repro steps in the bug.
+
+* storage/indexeddb/request-continue-abort-expected.txt: Added.
+* storage/indexeddb/request-continue-abort.html: Added.
+* storage/indexeddb/resources/request-continue-abort.js: Added.
+(test.request.onsuccess.request.onsuccess.request.onsuccess):
+(test.request.onsuccess.request.onsuccess):
+(test.request.onsuccess):
+(test):
+(onUpgrade):
+(testCursor.request.onsuccess):
+(testCursor.request.onerror):
+(testCursor.transaction.onabort):
+(testCursor):
+
 2012-07-20  Caio Marcelo de Oliveira Filho  caio.olive...@openbossa.org
 
 [Qt] svg/text rebaseline after new test fonts (part 3)


Added: trunk/LayoutTests/storage/indexeddb/request-continue-abort-expected.txt (0 => 123275)

--- trunk/LayoutTests/storage/indexeddb/request-continue-abort-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/request-continue-abort-expected.txt	2012-07-20 23:51:24 UTC (rev 123275)
@@ -0,0 +1,38 @@
+Regression test for IDBRequest issue calling continue on a cursor then aborting.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+dbname = self.location.pathname
+indexedDB.deleteDatabase('dbname')
+request = indexedDB.open('dbname')
+db = request.result
+db.setVersion('1')
+
+onUpgrade:
+db.createObjectStore('store')
+
+testCursor:

[webkit-changes] [123278] trunk/LayoutTests

[tony]

Title: [123278] trunk/LayoutTests








Revision 123278
Author t...@chromium.org
Date 2012-07-20 17:24:58 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Unreviewed, land new baselines after r123272.

* platform/chromium-linux/media/controls-styling-strict-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
* platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
* platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
* platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
* platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
* platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png: Added.
* platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
* platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
* platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
* platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
* platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
* platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
* platform/chromium-mac/css1/basic/inheritance-expected.png:
* platform/chromium-mac/fast/layers/video-layer-expected.png:
* platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-repaint-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-layout-direction-expected.png:
* platform/chromium-mac/media/controls-strict-expected.png:
* platform/chromium-mac/media/controls-styling-expected.png:
* platform/chromium-mac/media/controls-styling-strict-expected.png: Added.
* platform/chromium-mac/media/controls-styling-strict-expected.txt: Added.
* platform/chromium-mac/media/controls-without-preload-expected.png:
* platform/chromium-mac/media/media-controls-clone-expected.png:
* platform/chromium-mac/media/video-controls-rendering-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-empty-source-expected.png:
* platform/chromium-mac/media/video-no-audio-expected.png:
* platform/chromium-mac/media/video-playing-and-pause-expected.png:
* platform/chromium-mac/media/video-zoom-controls-expected.png:
* platform/chromium-win/fast/layers/video-layer-expected.png:
* platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-layout-direction-expected.png:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-styling-strict-expected.png: Added.
* platform/chromium-win/media/controls-styling-strict-expected.txt: Added.
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/media-controls-clone-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-empty-source-expected.png:
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-playing-and-pause-expected.png:
* platform/chromium-win/media/video-zoom-controls-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac/css1/basic/inheritance-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/layers/video-layer-expected.png
trunk/LayoutTests/platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png
trunk/LayoutTests/platform/chromium-mac/media/audio-controls-rendering-expected.png
trunk/LayoutTests/platform/chromium-mac/media/audio-repaint-expected.png
trunk/LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.png
trunk/LayoutTests/platform/chromium-mac/media/controls-layout-direction-expected.png
trunk/LayoutTests/platform/chromium-mac/media/controls-strict-expected.png
trunk/LayoutTests/platform/chromium-mac/media/controls-styling-expected.png
trunk/LayoutTests/platform/chromium-mac/media/controls-without-preload-expected.png
trunk/LayoutTests/platform/chromium-mac/media/media-controls-clone-expected.png
trunk/LayoutTests/platform/chromium-mac/media/video-controls-rendering-expected.png

[webkit-changes] [123279] trunk/Tools

[wangxianzhu]

Title: [123279] trunk/Tools








Revision 123279
Author wangxian...@chromium.org
Date 2012-07-20 17:28:58 -0700 (Fri, 20 Jul 2012)


Log Message
[Chromium-Android] Store test pipes in /data/local/tmp
https://bugs.webkit.org/show_bug.cgi?id=91909

In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
However after tests we found some devices don't allow the app to create pipes there.
So /data/local/tmp is a better place for the pipes.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py




Diff

Modified: trunk/Tools/ChangeLog (123278 => 123279)

--- trunk/Tools/ChangeLog	2012-07-21 00:24:58 UTC (rev 123278)
+++ trunk/Tools/ChangeLog	2012-07-21 00:28:58 UTC (rev 123279)
@@ -1,5 +1,18 @@
 2012-07-20  Xianzhu Wang  wangxian...@chromium.org
 
+[Chromium-Android] Store test pipes in /data/local/tmp
+https://bugs.webkit.org/show_bug.cgi?id=91909
+
+In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
+However after tests we found some devices don't allow the app to create pipes there.
+So /data/local/tmp is a better place for the pipes.
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/port/chromium_android.py:
+
+2012-07-20  Xianzhu Wang  wangxian...@chromium.org
+
 [Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
 https://bugs.webkit.org/show_bug.cgi?id=91873
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py (123278 => 123279)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-07-21 00:24:58 UTC (rev 123278)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py	2012-07-21 00:28:58 UTC (rev 123279)
@@ -58,7 +58,7 @@
 DRT_APP_PACKAGE = 'org.chromium.native_test'
 DRT_ACTIVITY_FULL_NAME = DRT_APP_PACKAGE + '/.ChromeNativeTestActivity'
 DRT_APP_DIR = '/data/user/0/' + DRT_APP_PACKAGE + '/'
-DRT_APP_FILES_DIR = '/sdcard/native_tests/'
+DRT_APP_FILES_DIR = DEVICE_SOURCE_ROOT_DIR
 DRT_APP_CACHE_DIR = DRT_APP_DIR + 'cache/'
 
 # This only works for single core devices so far.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123280] trunk/LayoutTests

[tony]

Title: [123280] trunk/LayoutTests








Revision 123280
Author t...@chromium.org
Date 2012-07-20 17:33:23 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Unreviewed, one more new baselines after r123272.

* platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png
trunk/LayoutTests/platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png
trunk/LayoutTests/platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (123279 => 123280)

--- trunk/LayoutTests/ChangeLog	2012-07-21 00:28:58 UTC (rev 123279)
+++ trunk/LayoutTests/ChangeLog	2012-07-21 00:33:23 UTC (rev 123280)
@@ -1,5 +1,14 @@
 2012-07-20  Tony Chang  t...@chromium.org
 
+[chromium] Unreviewed, one more new baselines after r123272.
+
+* platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
+* platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
+* platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
+* platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
+
+2012-07-20  Tony Chang  t...@chromium.org
+
 [chromium] Unreviewed, land new baselines after r123272.
 
 * platform/chromium-linux/media/controls-styling-strict-expected.png: Added.


Modified: trunk/LayoutTests/platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123282] trunk/LayoutTests

[tony]

Title: [123282] trunk/LayoutTests








Revision 123282
Author t...@chromium.org
Date 2012-07-20 18:52:27 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Unreviewed, one more new baselines after r123272 (I missed SL).

* platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (123281 => 123282)

--- trunk/LayoutTests/ChangeLog	2012-07-21 01:03:17 UTC (rev 123281)
+++ trunk/LayoutTests/ChangeLog	2012-07-21 01:52:27 UTC (rev 123282)
@@ -1,5 +1,11 @@
 2012-07-20  Tony Chang  t...@chromium.org
 
+[chromium] Unreviewed, one more new baselines after r123272 (I missed SL).
+
+* platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
+
+2012-07-20  Tony Chang  t...@chromium.org
+
 [chromium] Unreviewed, one more new baselines after r123272.
 
 * platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:


Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123284] trunk/Source/WebCore

[commit-queue]

Title: [123284] trunk/Source/WebCore








Revision 123284
Author commit-qu...@webkit.org
Date 2012-07-20 19:46:29 -0700 (Fri, 20 Jul 2012)


Log Message
Anything else in the in table insertion mode is a parse error
https://bugs.webkit.org/show_bug.cgi?id=91915

Patch by Kwang Yul Seo sk...@company100.net on 2012-07-20
Reviewed by Adam Barth.

According to the HTML5 spec, anything else in the in table insertion mode is a parse error.

No behavior change because parseError(token) is just a marker.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTagForInTable):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (123283 => 123284)

--- trunk/Source/WebCore/ChangeLog	2012-07-21 02:00:46 UTC (rev 123283)
+++ trunk/Source/WebCore/ChangeLog	2012-07-21 02:46:29 UTC (rev 123284)
@@ -1,3 +1,17 @@
+2012-07-20  Kwang Yul Seo  sk...@company100.net
+
+Anything else in the in table insertion mode is a parse error
+https://bugs.webkit.org/show_bug.cgi?id=91915
+
+Reviewed by Adam Barth.
+
+According to the HTML5 spec, anything else in the in table insertion mode is a parse error.
+
+No behavior change because parseError(token) is just a marker.
+
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::processEndTagForInTable):
+
 2012-07-20  Kent Tamura  tk...@chromium.org
 
 Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT


Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (123283 => 123284)

--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2012-07-21 02:00:46 UTC (rev 123283)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2012-07-21 02:46:29 UTC (rev 123284)
@@ -1962,6 +1962,7 @@
 parseError(token);
 return;
 }
+parseError(token);
 // Is this redirection necessary here?
 HTMLConstructionSite::RedirectToFosterParentGuard redirecter(m_tree);
 processEndTagForInBody(token);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123285] trunk

[senorblanco]

Title: [123285] trunk








Revision 123285
Author senorbla...@chromium.org
Date 2012-07-20 19:50:29 -0700 (Fri, 20 Jul 2012)


Log Message
Source/WebCore: [chromium] Take current transformation matrix into account when
deciding on resize algorithm for drawPattern.
https://bugs.webkit.org/show_bug.cgi?id=90624

Reviewed by Adrienne Walker.

Since the pattern shader uses both the current transformation matrix
and the pattern matrix when transforming pixels, we need to
do the same when computing the resampling mode.  Also removed the
resampling hint code, added in r60658, since it appears to be dead
(caller was removed in r76379).

Covered by existing tests, such as
fast/borders/border-image-scale-transform.html.

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::computeResamplingMode):
Pass in the matrix to be used for computing the destination width and
height (for awesome resampling).  Remove the image resampling hint code.
(WebCore::paintSkBitmap):
Pass in the CTM to computeResamplingMode().
(WebCore::Image::drawPattern):
Concatenate the CTM and the pattern matrix, and pass that to
computeResamplingMode() and TransformDimensions().  Invert the
CTM's scale and apply it to the pattern transform, so their
concatenation gives identity scale.
* platform/graphics/skia/PlatformContextSkia.cpp:
* platform/graphics/skia/PlatformContextSkia.h:
Remove the image resampling hint (dead code).

LayoutTests: [chromium] Mark a test as needing a rebaseline due to image change.
https://bugs.webkit.org/show_bug.cgi?id=90624

Reviewed by Adrienne Walker.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h




Diff

Modified: trunk/LayoutTests/ChangeLog (123284 => 123285)

--- trunk/LayoutTests/ChangeLog	2012-07-21 02:46:29 UTC (rev 123284)
+++ trunk/LayoutTests/ChangeLog	2012-07-21 02:50:29 UTC (rev 123285)
@@ -1,3 +1,12 @@
+2012-07-20  Stephen White  senorbla...@chromium.org
+
+[chromium] Mark a test as needing a rebaseline due to image change.
+https://bugs.webkit.org/show_bug.cgi?id=90624
+
+Reviewed by Adrienne Walker.
+
+* platform/chromium/TestExpectations:
+
 2012-07-20  Tony Chang  t...@chromium.org
 
 [chromium] Unreviewed, one more new baselines after r123272 (I missed SL).


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123284 => 123285)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-21 02:46:29 UTC (rev 123284)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-21 02:50:29 UTC (rev 123285)
@@ -3611,6 +3611,9 @@
 
 BUGWK91183 : http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html = PASS TEXT
 
+// Needs rebaseline.
+BUGWK90624 : fast/borders/border-image-scale-transform.html = IMAGE
+
 // Fails on Mac 10.7
 BUGWK91255 LION : fast/multicol/table-vertical-align.html = TEXT
 


Modified: trunk/Source/WebCore/ChangeLog (123284 => 123285)

--- trunk/Source/WebCore/ChangeLog	2012-07-21 02:46:29 UTC (rev 123284)
+++ trunk/Source/WebCore/ChangeLog	2012-07-21 02:50:29 UTC (rev 123285)
@@ -1,3 +1,35 @@
+2012-07-20  Stephen White  senorbla...@chromium.org
+
+[chromium] Take current transformation matrix into account when
+deciding on resize algorithm for drawPattern.
+https://bugs.webkit.org/show_bug.cgi?id=90624
+
+Reviewed by Adrienne Walker.
+
+Since the pattern shader uses both the current transformation matrix
+and the pattern matrix when transforming pixels, we need to
+do the same when computing the resampling mode.  Also removed the
+resampling hint code, added in r60658, since it appears to be dead
+(caller was removed in r76379).
+
+Covered by existing tests, such as
+fast/borders/border-image-scale-transform.html.
+
+* platform/graphics/skia/ImageSkia.cpp:
+(WebCore::computeResamplingMode):
+Pass in the matrix to be used for computing the destination width and
+height (for awesome resampling).  Remove the image resampling hint code.
+(WebCore::paintSkBitmap):
+Pass in the CTM to computeResamplingMode().
+(WebCore::Image::drawPattern):
+Concatenate the CTM and the pattern matrix, and pass that to 
+computeResamplingMode() and TransformDimensions().  Invert the
+CTM's scale and apply it to the pattern transform, so their
+concatenation gives identity scale.
+* platform/graphics/skia/PlatformContextSkia.cpp:
+* platform/graphics/skia/PlatformContextSkia.h:
+Remove the image resampling hint (dead code).
+
 2012-07-20  Kwang Yul Seo  sk...@company100.net
 
 Anything else 

[webkit-changes] [123286] trunk/LayoutTests

[tony]

Title: [123286] trunk/LayoutTests








Revision 123286
Author t...@chromium.org
Date 2012-07-20 20:35:44 -0700 (Fri, 20 Jul 2012)


Log Message
[chromium] Mark anther test as needing a rebaseline due to r123285.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (123285 => 123286)

--- trunk/LayoutTests/ChangeLog	2012-07-21 02:50:29 UTC (rev 123285)
+++ trunk/LayoutTests/ChangeLog	2012-07-21 03:35:44 UTC (rev 123286)
@@ -1,3 +1,9 @@
+2012-07-20  Tony Chang  t...@chromium.org
+
+[chromium] Mark anther test as needing a rebaseline due to r123285.
+
+* platform/chromium/TestExpectations:
+
 2012-07-20  Stephen White  senorbla...@chromium.org
 
 [chromium] Mark a test as needing a rebaseline due to image change.


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (123285 => 123286)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-21 02:50:29 UTC (rev 123285)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-21 03:35:44 UTC (rev 123286)
@@ -3613,6 +3613,7 @@
 
 // Needs rebaseline.
 BUGWK90624 : fast/borders/border-image-scale-transform.html = IMAGE
+BUGWK90624 SNOWLEOPARD : fast/borders/border-image-rotate-transform.html = IMAGE
 
 // Fails on Mac 10.7
 BUGWK91255 LION : fast/multicol/table-vertical-align.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [123287] trunk/Source/WebKit/efl

[commit-queue]

Title: [123287] trunk/Source/WebKit/efl








Revision 123287
Author commit-qu...@webkit.org
Date 2012-07-20 20:58:27 -0700 (Fri, 20 Jul 2012)


Log Message
[EFL] Remove unused headers from ewk_security_origin
https://bugs.webkit.org/show_bug.cgi?id=91914

Patch by Kihong Kwon kihong.k...@samsung.com on 2012-07-20
Reviewed by Noam Rosenthal.

There are some unused header in the ewk_security_origin.h/cpp
We need to remove them.

* ewk/ewk_security_origin.cpp:
* ewk/ewk_security_origin.h:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_security_origin.cpp
trunk/Source/WebKit/efl/ewk/ewk_security_origin.h




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (123286 => 123287)

--- trunk/Source/WebKit/efl/ChangeLog	2012-07-21 03:35:44 UTC (rev 123286)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-07-21 03:58:27 UTC (rev 123287)
@@ -1,3 +1,16 @@
+2012-07-20  Kihong Kwon  kihong.k...@samsung.com
+
+[EFL] Remove unused headers from ewk_security_origin
+https://bugs.webkit.org/show_bug.cgi?id=91914
+
+Reviewed by Noam Rosenthal.
+
+There are some unused header in the ewk_security_origin.h/cpp
+We need to remove them.
+
+* ewk/ewk_security_origin.cpp:
+* ewk/ewk_security_origin.h:
+
 2012-07-20  Christophe Dumez  christophe.du...@intel.com
 
 [EFL] Proxy configuration should honor the no_proxy environment variable


Modified: trunk/Source/WebKit/efl/ewk/ewk_security_origin.cpp (123286 => 123287)

--- trunk/Source/WebKit/efl/ewk/ewk_security_origin.cpp	2012-07-21 03:35:44 UTC (rev 123286)
+++ trunk/Source/WebKit/efl/ewk/ewk_security_origin.cpp	2012-07-21 03:58:27 UTC (rev 123287)
@@ -24,11 +24,9 @@
 #include ApplicationCacheStorage.h
 #include DatabaseTracker.h
 #include SecurityOrigin.h
-#include ewk_private.h
 #include ewk_security_origin_private.h
 #include ewk_web_database.h
 #include ewk_web_database_private.h
-#include Eina.h
 #include wtf/RefPtr.h
 #include wtf/UnusedParam.h
 #include wtf/text/CString.h


Modified: trunk/Source/WebKit/efl/ewk/ewk_security_origin.h (123286 => 123287)

--- trunk/Source/WebKit/efl/ewk/ewk_security_origin.h	2012-07-21 03:35:44 UTC (rev 123286)
+++ trunk/Source/WebKit/efl/ewk/ewk_security_origin.h	2012-07-21 03:58:27 UTC (rev 123287)
@@ -33,7 +33,7 @@
 #ifndef ewk_security_origin_h
 #define ewk_security_origin_h
 
-#include Evas.h
+#include Eina.h
 
 #ifdef __cplusplus
 extern C {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes